Timeline
Jul 23, 2012:
- 11:43 PM Changeset in webkit [123431] by
-
- 2 edits in trunk
[GTK] Remove unnecessary trailing space in the previous commit.
- Source/autotools/symbols.filter:
- 11:35 PM Changeset in webkit [123430] by
-
- 2 edits in trunk
[GTK] Attempt to fix build
- Source/autotools/symbols.filter: Export DocumentMarkerController::addTextMatchMarker.
- 11:33 PM Changeset in webkit [123429] by
-
- 20 edits in trunk/Source/WebCore
Missing *explicit* keyword in editing.
https://bugs.webkit.org/show_bug.cgi?id=92055
Reviewed by Ryosuke Niwa.
Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.
No new tests. Covered by existing tests.
- editing/AlternativeTextController.h:
(WebCore::AlternativeTextController::UNLESS_ENABLED):
- editing/BreakBlockquoteCommand.h:
(BreakBlockquoteCommand):
- editing/DeleteButton.h:
(DeleteButton):
- editing/DeleteButtonController.h:
(DeleteButtonController):
- editing/EditCommand.h:
(EditCommand):
(WebCore::SimpleEditCommand::SimpleEditCommand):
- editing/EditingBehavior.h:
(WebCore::EditingBehavior::EditingBehavior):
- editing/EditingStyle.h:
(EditingStyle):
- editing/Editor.h:
(Editor):
- editing/FrameSelection.h:
(FrameSelection):
- editing/InsertLineBreakCommand.h:
(InsertLineBreakCommand):
- editing/ModifySelectionListLevel.h:
(ModifySelectionListLevelCommand):
(DecreaseSelectionListLevelCommand):
- editing/RemoveFormatCommand.h:
(RemoveFormatCommand):
- editing/RemoveNodeCommand.h:
(RemoveNodeCommand):
- editing/RemoveNodePreservingChildrenCommand.h:
(RemoveNodePreservingChildrenCommand):
- editing/ReplaceNodeWithSpanCommand.h:
(ReplaceNodeWithSpanCommand):
- editing/TextInsertionBaseCommand.h:
(TextInsertionBaseCommand):
- editing/UndoManager.h:
(UndoManager):
- editing/UnlinkCommand.h:
(UnlinkCommand):
- editing/WrapContentsInDummySpanCommand.h:
(WrapContentsInDummySpanCommand):
- 11:26 PM Changeset in webkit [123428] by
-
- 27 edits4 adds in trunk
AX: Need AccessibilityObjects for nodes without renderers in canvas subtree
https://bugs.webkit.org/show_bug.cgi?id=87899
Reviewed by Chris Fleizach.
Source/WebCore:
Refactors AccessibilityRenderObject so that it inherits from a new class,
AccessibilityNodeObject, that can be constructed from a Node without a
renderer. Modifies AXObjectCache so that it automatically creates an
AccessibilityNodeObject for elements in a canvas subtree but not otherwise.
A new layout test verifies that this correctly exposes an accessibility
tree with appropriate roles for elements in a canvas subtree.
This patch does not try to complete the implementation of
AccessibilityNodeObject. Most AX methods are still unimplemented and need
to be migrated from AccessibilityRenderObject to AccessibilityNodeObject
in a future patch.
This patch also doesn't change anything outside of WebCore/accessibility, so
the rest of WebCore only calls AXObjectCache when there are changes to a
RenderObject, not to a Node. Accessible notifications on nodes without
renderers need to be implemented in a future patch.
Test: accessibility/canvas-accessibilitynodeobject.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::get):
(WebCore):
(WebCore::createFromNode):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
- accessibility/AXObjectCache.h:
(AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
(WebCore):
(WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::init):
(WebCore::AccessibilityARIAGrid::create):
- accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::create):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::create):
- accessibility/AccessibilityAllInOne.cpp:
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::create):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::create):
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::create):
(WebCore):
- accessibility/AccessibilityMenuList.h:
(AccessibilityMenuList):
- accessibility/AccessibilityNodeObject.cpp: Added.
(WebCore):
(WebCore::AccessibilityNodeObject::AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::~AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::init):
(WebCore::AccessibilityNodeObject::create):
(WebCore::AccessibilityNodeObject::detach):
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::updateAccessibilityRole):
(WebCore::AccessibilityNodeObject::firstChild):
(WebCore::AccessibilityNodeObject::lastChild):
(WebCore::AccessibilityNodeObject::previousSibling):
(WebCore::AccessibilityNodeObject::nextSibling):
(WebCore::AccessibilityNodeObject::parentObjectIfExists):
(WebCore::AccessibilityNodeObject::parentObject):
(WebCore::AccessibilityNodeObject::elementRect):
(WebCore::AccessibilityNodeObject::setNode):
(WebCore::AccessibilityNodeObject::document):
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::accessibilityIsIgnored):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute):
(WebCore::AccessibilityNodeObject::ariaRoleAttribute):
(WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent):
- accessibility/AccessibilityNodeObject.h: Added.
(WebCore):
(AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::isAccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::node):
(WebCore::AccessibilityNodeObject::isDetached):
(WebCore::toAccessibilityNodeObject):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityNodeObject):
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::create):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::init):
(WebCore):
(WebCore::AccessibilityRenderObject::create):
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::setRenderer):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addCanvasChildren):
(WebCore::AccessibilityRenderObject::addChildren):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::create):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore::AccessibilityTable::init):
(WebCore::AccessibilityTable::create):
- accessibility/AccessibilityTable.h:
(AccessibilityTable):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::create):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::create):
LayoutTests:
This new test adds a bunch of elements to a normal container and the same elements to
a canvas subtree, then it iterates over all of the accessible objects within each
container and makes sure they have identical roles. Because we know the nodes in the
canvas subtree don't have renderers, this successfully tests that AccessibilityNodeObjects
are getting created for these nodes.
- accessibility/canvas-accessibilitynodeobject-expected.txt: Added.
- accessibility/canvas-accessibilitynodeobject.html: Added.
- 10:53 PM FeatureFlags edited by
- Add OPENTYPE_VERTICAL (diff)
- 10:46 PM Changeset in webkit [123427] by
-
- 2 edits in trunk/Source/WebCore
Fix ENABLE_CSS_IMAGE_ORIENTATION compile flag
https://bugs.webkit.org/show_bug.cgi?id=91961
Patch by David Barr <davidbarr@chromium.org> on 2012-07-23
Reviewed by Tony Chang.
https://bugs.webkit.org/show_bug.cgi?id=89055
A rule was missed implementing the ENABLE_CSS_IMAGE_ORIENTATION compile flag.
https://bugs.webkit.org/show_bug.cgi?id=90046
Half of the missing rule was inadvertently added together with ENABLE_CSS_STICKY_POSITION.
No new tests; build configuration fix.
- Configurations/FeatureDefines.xcconfig:
- 10:34 PM Changeset in webkit [123426] by
-
- 9 edits2 adds in trunk
Null-pointer crash when a derived color like -webkit-activelink is set in a gradient stop
https://bugs.webkit.org/show_bug.cgi?id=89148
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-23
Reviewed by Simon Fraser.
Source/WebCore:
CSSGradientValue attempted to resolve colors during paint, this crashed
when a derived color like -webkit-activelink was encountered because the
corresponding element was no longer available in the StyleResolver.
Instead, by adding a field to CSSGradientColorStop we can resolve and
then cache the resolved colors at the correct time. To avoid sharing
cached derived colors between elements we clone the gradient values when
needed.
Test: fast/css/crash-on-gradient-with-derived-color.html
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::gradientWithStylesResolved): Added. Resolve and cache
resolved colors, clone if colors are derived from the element.
(WebCore):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::isCacheable): Defer to new logic in
StyleResolver.
- css/CSSGradientValue.h:
(CSSGradientColorStop): Added cache of resolved color.
(CSSGradientValue):
(CSSLinearGradientValue):
(CSSRadialGradientValue):
- css/CSSImageGeneratorValue.h:
(WebCore):
- css/CSSValue.h:
(WebCore::CSSValue::isGradientValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(StyleResolver):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image): Revert change from r96449. This
is no longer necessary as the gradient colors are now resolved at a
time when the style is set on StyleResolver.
LayoutTests:
- fast/css/crash-on-gradient-with-derived-color-expected.txt: Added.
- fast/css/crash-on-gradient-with-derived-color.html: Added.
- 10:19 PM Changeset in webkit [123425] by
-
- 18 edits1 add in trunk/Source
Move GregorianDateTime from JSC to WTF namespace
https://bugs.webkit.org/show_bug.cgi?id=91948
Reviewed by Geoffrey Garen.
Moving GregorianDateTime into the WTF namespace allows us to us to
use it in WebCore too. The new class has the same behaviour as the
old struct. Only the unused timeZone member has been removed.
Source/JavaScriptCore:
- runtime/DateConstructor.cpp:
- runtime/DateConversion.cpp:
- runtime/DateConversion.h:
- runtime/DateInstance.h:
- runtime/DatePrototype.cpp:
- runtime/JSDateMath.cpp:
- runtime/JSDateMath.h:
Source/WebCore:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
- bridge/qt/qt_runtime_qt4.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
Source/WTF:
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/GregorianDateTime.h: Added.
(GregorianDateTime):
- 10:05 PM Changeset in webkit [123424] by
-
- 21 edits2 adds in trunk/Source
[Chromium] Move layoutTestMode to WebCore
https://bugs.webkit.org/show_bug.cgi?id=92010
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- platform/LayoutTestSupport.cpp: Added.
(WebCore):
(WebCore::isRunningLayoutTest):
(WebCore::setIsRunningLayoutTest):
- platform/LayoutTestSupport.h: Added.
(WebCore):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore):
(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::systemColor):
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::determineClassicState):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- src/WebKit.cpp:
(WebKit::setLayoutTestMode):
(WebKit::layoutTestMode):
- 9:57 PM Changeset in webkit [123423] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK/EFL gardening after r123379
Marked fast/css/sticky/parsing-position-sticky.html as known failure
tracked by the bug 92063
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 9:22 PM Changeset in webkit [123422] by
-
- 1 edit12 moves in trunk/LayoutTests
[Tests] Rename fast/forms/time/*.html to time-*.html
https://bugs.webkit.org/show_bug.cgi?id=92058
Reviewed by Kent Tamura.
This patch renames test scripts and expected text to same naming
scheme(name starts with "time-"), for fast/forms/time.
- fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Removed.
- fast/forms/time/ValidityState-rangeOverflow-time.html: Removed.
- fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Removed.
- fast/forms/time/ValidityState-rangeUnderflow-time.html: Removed.
- fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Removed.
- fast/forms/time/ValidityState-stepMismatch-time.html: Removed.
- fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Removed.
- fast/forms/time/ValidityState-typeMismatch-time.html: Removed.
- fast/forms/time/input-valueasdate-time-expected.txt: Removed.
- fast/forms/time/input-valueasdate-time.html: Removed.
- fast/forms/time/input-valueasnumber-time-expected.txt: Removed.
- fast/forms/time/input-valueasnumber-time.html: Removed.
- fast/forms/time/time-validity-state-range-overflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time-expected.txt.
- fast/forms/time/time-validity-state-range-overflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time.html.
- fast/forms/time/time-validity-state-range-underflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt.
- fast/forms/time/time-validity-state-range-underflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time.html.
- fast/forms/time/time-validity-state-step-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time-expected.txt.
- fast/forms/time/time-validity-state-step-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time.html.
- fast/forms/time/time-validity-state-type-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time-expected.txt.
- fast/forms/time/time-validity-state-type-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time.html.
- fast/forms/time/time-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasdate-time-expected.txt.
- fast/forms/time/time-valueasdate.html: Copied from LayoutTests/fast/forms/time/input-valueasdate-time.html.
- fast/forms/time/time-valueasnumber-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time-expected.txt.
- fast/forms/time/time-valueasnumber.html: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time.html.
- 9:17 PM Changeset in webkit [123421] by
-
- 12 edits in trunk/Source
[chromium] Add droppedFrameCount to renderingStats.
https://bugs.webkit.org/show_bug.cgi?id=91694
Patch by Dave Tu <dtu@chromium.org> on 2012-07-23
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebRenderingStats.h:
(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):
Source/WebCore:
- platform/graphics/chromium/cc/CCFrameRateCounter.cpp:
(WebCore):
(WebCore::CCFrameRateCounter::frameInterval):
(WebCore::CCFrameRateCounter::frameIndex):
(WebCore::CCFrameRateCounter::CCFrameRateCounter):
(WebCore::CCFrameRateCounter::markBeginningOfFrame):
(WebCore::CCFrameRateCounter::isBadFrame):
- platform/graphics/chromium/cc/CCFrameRateCounter.h:
(WebCore::CCFrameRateCounter::droppedFrameCount):
(CCFrameRateCounter):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::renderingStats):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderingStats.h:
(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::implSideRenderingStats):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::implSideRenderingStatsOnImplThread):
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::renderingStats):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
- 7:55 PM Changeset in webkit [123420] by
-
- 2 edits in trunk/Source/WebCore
Fixed the build after r123418.
- WebCore.exp.in: Added DocumentMarkerController::addTextMatchMarker.
- 7:44 PM Changeset in webkit [123419] by
-
- 3 edits in trunk/Source/WebCore
CSS3 calc: optimise blending expression
https://bugs.webkit.org/show_bug.cgi?id=90037
Reviewed by Tony Chang.
Introduce a new calc expression node - a BlendLength node. Given two Lengths and a progress
this blends them together when evaluated.
An alternative and more general approach of being able to blend two CalcExpressionNodes was
tested, but involves more memory allocations, was measurably slower, and nothing currently
would make use of the generality.
No functional change. Covered by existing tests.
- platform/CalculationValue.h:
(CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::operator==):
(WebCore::CalcExpressionBlendLength::evaluate):
(WebCore):
- platform/Length.cpp:
(WebCore::Length::blendCalculation):
- 7:19 PM Changeset in webkit [123418] by
-
- 16 edits4 adds in trunk
[chromium] Show search tickmarks on css-styled scrollbars
https://bugs.webkit.org/show_bug.cgi?id=91949
Reviewed by Adrienne Walker.
This is done by letting RenderScrollbarTheme::paintTickmarks()
delegate to the native ScrollbarTheme. To make this possible,
move paintTickmarks() from ScrollbarThemeComposite to the
superclass ScrollbarTheme.
For testing, add internals.addTextMatchMarker() and add a pixel test.
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintTickmarks):
Moved paintTickmarks() from ScrollbarThemeComposite to here.
- platform/ScrollbarThemeComposite.h:
Remove paintTickmarks().
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
Switch to drawing tickmarks as vectors, so they can be arbitrarily wide.
- platform/chromium/ScrollbarThemeChromiumMac.h:
(ScrollbarThemeChromiumMac):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.
- rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::paintTickmarks):
Delegate to the native ScrollbarTheme for tickmark drawing.
(WebCore):
- rendering/RenderScrollbarTheme.h:
(RenderScrollbarTheme):
Override paintTickmarks().
- 7:13 PM Changeset in webkit [123417] by
-
- 29 edits in trunk/Source/JavaScriptCore
Property storage should grow in reverse address direction, to support butterflies
https://bugs.webkit.org/show_bug.cgi?id=91788
Reviewed by Geoffrey Garen.
Changes property storage to grow to the left, and changes the property storage pointer to point
one 8-byte word (i.e. JSValue) to the right of the first value in the storage.
Also improved debug support somewhat, by adding a describe() function to the jsc command-line,
and a slow mode of object access in LLInt.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::repatchCompact):
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerX86Common::repatchCompact):
- assembler/X86Assembler.h:
(JSC::X86Assembler::repatchCompact):
- bytecode/CodeBlock.cpp:
(JSC::dumpStructure):
- bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::emitPutTransitionStub):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddPointer):
- heap/CopiedSpace.h:
(CopiedSpace):
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::pinIfNecessary):
(JSC):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetDirectOffset):
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionDescribe):
- llint/LLIntCommon.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::growOutOfLineStorage):
- runtime/JSObject.h:
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):
- runtime/JSValue.h:
(JSValue):
- runtime/PropertyOffset.h:
(JSC::offsetInOutOfLineStorage):
- 7:03 PM Changeset in webkit [123416] by
-
- 11 edits in trunk/Source
[chromium] Use shallow flushes that don't glFlush
https://bugs.webkit.org/show_bug.cgi?id=90325
Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-23
Reviewed by Kenneth Russell.
Source/Platform:
Adds shallowFlushCHROMIUM to WebGraphicsContext3D.
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::shallowFlushCHROMIUM):
Source/WebCore:
Adds plumbing for the shallowFlushCHROMIUM extension and uses
shallow flushes instead of normal flushes when uploading textures.
Shallow flushes allow us to initiate command buffer flushes to
the GPU thread/process without the overhead of a true glFlush.
CCTextureUpdaterTest updated to recognize shallow flushes.
- platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::shallowFlushCHROMIUM):
(WebCore):
- platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):
- platform/graphics/chromium/cc/CCGraphicsContext.h:
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::initialize):
- platform/graphics/chromium/cc/CCResourceProvider.h:
(CCResourceProvider):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
Source/WebKit/chromium:
Changed CCTextureUpdaterTest to recognize shallowFlushCHROMIUM().
- tests/CCTextureUpdaterTest.cpp:
- 6:59 PM Changeset in webkit [123415] by
-
- 4 edits in trunk
Disable flexbox on Windows
https://bugs.webkit.org/show_bug.cgi?id=92047
<rdar://problem/11570384>
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Darin Adler.
Disabled Flexbox CSS3 syntax on Mac, need to do the same for Windows.
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
Disable ENABLE_CSS3_FLEXBOX property.
LayoutTests:
- platform/win/Skipped:
Add related CSS3 Flexbox tests to skip list.
- 6:14 PM Changeset in webkit [123414] by
-
- 3 edits2 adds in trunk
Source/WebCore: When using TextureMapper, WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame.
https://bugs.webkit.org/show_bug.cgi?id=91322
Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.
When -webkit-fill-mode is forwards, GraphicsLayerAnimation::apply does not apply
the property values defined in the last executing keyframe after the final iteration of animation.
This patch does not return right after the end of animation, but it keeps applying
the property values defined in the last executing keyframe.
Add normalizedAnimationValueForFillsForwards function that returns a normalized value of the
last executing keyframe.
Link to CSS Animations spec: http://www.w3.org/TR/css3-animations/#animation-fill-mode-property
Test: animations/fill-mode-forwards2.html
- platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::normalizedAnimationValueForFillsForwards):
(WebCore):
(WebCore::GraphicsLayerAnimation::apply):
LayoutTests: WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame
https://bugs.webkit.org/show_bug.cgi?id=91322
Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.
Added a test to check if the opacity has the right value after animation.
- animations/fill-mode-forwards2-expected.txt: Added.
- animations/fill-mode-forwards2.html: Added.
- 6:13 PM FeatureFlags edited by
- Add CSS_STICKY_POSITION (diff)
- 5:57 PM Changeset in webkit [123413] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Add more compositor unit tests for high DPI transforms
https://bugs.webkit.org/show_bug.cgi?id=91917
Reviewed by Kenneth Russell.
The current set of high DPI tests only deal with layers in a render
surface. Add some extra tests for non-surface layers. Also add a test
to make sure that an owning layer in a surface doesn't differ from a
non-owning layer in high DPI circumstances.
- tests/CCLayerTreeHostCommonTest.cpp:
- 5:53 PM Changeset in webkit [123412] by
-
- 20 edits in trunk
Unreviewed, rolling out r123184, r123195, and r123197.
http://trac.webkit.org/changeset/123184
http://trac.webkit.org/changeset/123195
http://trac.webkit.org/changeset/123197
https://bugs.webkit.org/show_bug.cgi?id=92049
pagecycler regression (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::suggestedMIMEType):
- dom/Document.h:
(WebCore):
(WebCore::Node::isDocumentNode):
(WebCore::Node::Node):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::setDocument):
(WebCore):
(WebCore::Node::setTreeScope):
(WebCore::Node::treeScope):
(WebCore::Node::isInShadowTree):
(WebCore::Node::reportMemoryUsage):
- dom/Node.h:
(Node):
(WebCore::Node::document):
(WebCore::Node::inDocument):
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::treeScope):
(WebCore::NodeRareData::setTreeScope):
(NodeRareData):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
- dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):
- dom/TreeScope.h:
(WebCore):
(WebCore::TreeScope::idTargetObserverRegistry):
(TreeScope):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- editing/MoveSelectionCommand.cpp:
- editing/RemoveNodeCommand.cpp:
- editing/RemoveNodePreservingChildrenCommand.cpp:
- inspector/PageConsoleAgent.cpp:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
- 5:48 PM Changeset in webkit [123411] by
-
- 3 edits1 add in trunk
.: If select element in Windows is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.
Add a manual test to verify that popup menus render in the correct place.
- ManualTests/win/select-menu-off-screen.html: Added.
Source/WebCore: On Windows, if select element is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.
If the select element is positioned off the edge of the screen to the left,
the menu is resized. It should not be resized, just shifted to remain on the screen.
If the select element is positioned off the edge of the screen to the right,
the menu goes off screen instead of being shifted over to appear on screen.
This problem only occurs on Windows.
Test: ManualTests/win/select-menu-off-screen.html
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
Modified final horizontal position calculation code to position
popup menu on screen if it would otherwise go off.
- 5:42 PM Changeset in webkit [123410] by
-
- 1 copy in tags/Safari-537.2
New Tag.
- 5:37 PM Changeset in webkit [123409] by
-
- 5 edits in trunk
Fixed crash in webkitAddKey() when key parameter is null.
https://bugs.webkit.org/show_bug.cgi?id=85444
Patch by David Dorwin <ddorwin@chromium.org> on 2012-07-23
Reviewed by Kentaro Hara.
Reference: Step 1 of http://dvcs.w3.org/hg/html-media/raw-file/5f76a0b43836/encrypted-media/encrypted-media.html#dom-addkey
Source/WebCore:
Tests: media/encrypted-media/encrypted-media-syntax.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):
LayoutTests:
- media/encrypted-media/encrypted-media-syntax-expected.txt:
- media/encrypted-media/encrypted-media-syntax.html:
- 5:36 PM Changeset in webkit [123408] by
-
- 3 edits in trunk/LayoutTests
http/tests/multipart/policy-ignore-crash.php is failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=92046
Reviewed by Adam Barth.
Chromium's network layer now shows most text/* mime types. This test was using text/random to
try to trigger a crash when multipart content switch from a text type to a non-text type.
Change the test to use a text type that we don't render.
- http/tests/multipart/policy-ignore-crash.php: Use text/rtf instead of text/random.
- platform/chromium/TestExpectations: Test should be passing again.
- 5:12 PM Changeset in webkit [123407] by
-
- 4 edits2 adds in trunk
A FocusScope for a distributed node should not be its TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=91829
Reviewed by Dimitri Glazkov.
Source/WebCore:
Current implementation of FocusScope::focusScopeOf(Node*) returns
the given node's treeScope(). That does not apply if the node is
a distributed node. We should calculate a FocusScope for a
distributed node by traversing ancestor nodes in Composed Shadow
Tree.
Test: fast/dom/shadow/focus-navigation-with-distributed-nodes.html
- page/FocusController.cpp:
(WebCore::FocusScope::focusScopeOf):
LayoutTests:
- fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt: Added.
- fast/dom/shadow/focus-navigation-with-distributed-nodes.html: Added.
- fast/dom/shadow/resources/shadow-dom.js:
(shouldNavigateFocus):
- 5:06 PM Changeset in webkit [123406] by
-
- 3 edits2 adds in trunk
Null-pointer crash when parsing border-image
https://bugs.webkit.org/show_bug.cgi?id=91963
Patch by Douglas Stockwell <dstockwell@google.com> on 2012-07-23
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/border-image-fill-crash.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderImageRepeat): Handle the case where
parseBorderImageRepeat is called when the value list is empty.
LayoutTests:
- fast/css/border-image-fill-crash-expected.txt: Added.
- fast/css/border-image-fill-crash.html: Added.
- 4:56 PM Changeset in webkit [123405] by
-
- 5 edits in trunk
[CSS Exclusions] SVG shape errors should invalidate exclusion shapes
https://bugs.webkit.org/show_bug.cgi?id=91761
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2012-07-23
Reviewed by Andreas Kling.
Source/WebCore:
CSS exclusion shapes that are specified with negative radiuses or
height/width are now considered invalid and ignored.
Tests added to
LayoutTests/fast/exclusions/parsing-wrap-shape-lengths.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):
LayoutTests:
Test that negative heights. widths, and radiuses are ignored.
- fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
- fast/exclusions/parsing-wrap-shape-lengths.html:
- 4:46 PM Changeset in webkit [123404] by
-
- 12 edits in trunk/LayoutTests
[Qt] css3/selectors3 rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92038
Reviewed by Alexis Menard.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped: These tests are failing because of <input> default size in
WK2, which is different than the expected results generated from WK1. Moved them to
appropriate block in skipped list.
- platform/qt-5.0/Skipped:
- platform/qt/css3/selectors3/html/css3-modsel-21c-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-21c-expected.txt:
- platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.txt:
- platform/qt/css3/selectors3/xml/css3-modsel-148-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-148-expected.txt:
- platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.txt:
- 4:40 PM Changeset in webkit [123403] by
-
- 2 edits1 move1 add2 deletes in trunk/LayoutTests
Unreviewed gardening. Land pixel results for fast/frames/valid.html on chromium mac snowleopard.
- fast/frames/valid-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/valid-expected.txt.
- platform/chromium-mac-snowleopard/fast/frames/valid-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/gtk/fast/frames/valid-expected.txt: Removed.
- platform/mac/fast/frames/valid-expected.txt: Removed.
- 4:38 PM Changeset in webkit [123402] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Implement scrollbar theme for Android
https://bugs.webkit.org/show_bug.cgi?id=91674
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-07-23
Reviewed by Adam Barth.
Previously the scrollbar for Android was implemented as an extra
drawing pass in the compositor. Now we switch to use the standard
ScrollbarTheme mechanism.
No new tests. We use mock scrollbars during layout test to share
pixel results with Linux.
- platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::thumbPosition):
(WebCore::ScrollbarThemeChromiumAndroid::thumbLength):
(WebCore::ScrollbarThemeChromiumAndroid::backButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::forwardButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::trackRect):
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
- platform/chromium/ScrollbarThemeChromiumAndroid.h:
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(ScrollbarThemeChromiumAndroid):
(WebCore::ScrollbarThemeChromiumAndroid::hasButtons):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):
- 4:37 PM Changeset in webkit [123401] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations change to mark test as slow: fast/forms/select-set-length-with-mutation-remove.html.
- platform/chromium/TestExpectations:
- 4:33 PM Changeset in webkit [123400] by
-
- 1 edit in trunk/Websites/webkit.org/blog/wp-config.php
Update website for new hardware.
- 4:15 PM Changeset in webkit [123399] by
-
- 10 edits1 add in trunk
Use the original token to create an element in "reconstruct the active formatting elements" and "call the adoption agency"
https://bugs.webkit.org/show_bug.cgi?id=91703
Reviewed by Adam Barth.
Source/WebCore:
The current WebKit HTML5 parser implementation does not hold the original token
in the stack of open elements and the active formatting elements. This is
problematic because the original token is used to create an element in
"reconstruct the active formatting elements" and "call the adoption agency".
As a workaround, WebKit uses the saved element instead of the original token
to create an element. But this causes us to fail examples like this:
<b id="1"><p><script>document.getElementById("1").id = "2"</script></p>TEXT</b>
reconstructTheActiveFormattingElements calls this method to open a second <b>
tag to wrap TEXT, it will have id "2", even though the HTML5 spec implies it
should be "1".
Created a ref-counted container class, HTMLStackItem to hold the original token
and the namespace URI as well as the element. Changed HTMLElementStack and
HTMLFormattingElementList to use HTMLStackItem.
Changed HTMLConstructionSite::reconstructTheActiveFormattingElements and
HTMLTreeBuilder::callTheAdoptionAgency to create an element from the saved token
instead of the saved element.
Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):
- html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::currentElementRecord):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushRootNodeCommon):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):
- html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::ElementRecord::stackItem):
(ElementRecord):
(HTMLElementStack):
- html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::swapTo):
(WebCore::HTMLFormattingElementList::append):
- html/parser/HTMLFormattingElementList.h:
(WebCore::HTMLFormattingElementList::Entry::Entry):
(WebCore::HTMLFormattingElementList::Entry::isMarker):
(WebCore::HTMLFormattingElementList::Entry::stackItem):
(WebCore::HTMLFormattingElementList::Entry::element):
(WebCore::HTMLFormattingElementList::Entry::replaceElement):
(WebCore::HTMLFormattingElementList::Entry::operator==):
(WebCore::HTMLFormattingElementList::Entry::operator!=):
(Entry):
(HTMLFormattingElementList):
- html/parser/HTMLStackItem.h: Added.
(WebCore):
(HTMLStackItem):
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::element):
(WebCore::HTMLStackItem::node):
(WebCore::HTMLStackItem::token):
(WebCore::HTMLStackItem::namespaceURI):
(WebCore::HTMLStackItem::HTMLStackItem):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
LayoutTests:
Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.
- html5lib/runner-expected.txt:
- 4:12 PM Writing Reftests edited by
- (diff)
- 4:06 PM Changeset in webkit [123398] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Fix unit tests in debug mode after r123375
https://bugs.webkit.org/show_bug.cgi?id=92030
Reviewed by Adrienne Walker.
Fixed two unit tests that were causing debug assertions because
they gave calcDrawTransforms an empty sized root layer.
- tests/CCLayerTreeHostCommonTest.cpp:
- 3:57 PM Changeset in webkit [123397] by
-
- 24 edits2 copies5 adds2 deletes in trunk/LayoutTests
[Qt] svg/{in-html,overflow,repaint,wicd} needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92023
Unreviewed gardening.
- platform/qt-5.0/Skipped:
- platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Removed.
- platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Removed.
- platform/qt/Skipped:
- platform/qt/svg/in-html/by-reference-expected.txt:
- platform/qt/svg/in-html/circle-expected.png:
- platform/qt/svg/in-html/circle-expected.txt:
- platform/qt/svg/overflow/overflow-on-foreignObject-expected.png:
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
- platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
- platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
- platform/qt/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
- platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
- platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
- platform/qt/svg/repaint/mask-clip-target-transform-expected.png: Added.
- platform/qt/svg/repaint/text-mask-update-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
- platform/qt/svg/repaint/text-mask-update-expected.txt: Added.
- platform/qt/svg/wicd/rightsizing-grid-expected.png:
- platform/qt/svg/wicd/rightsizing-grid-expected.txt:
- platform/qt/svg/wicd/sizing-flakiness-expected.txt:
- platform/qt/svg/wicd/test-rightsizing-a-expected.png:
- platform/qt/svg/wicd/test-rightsizing-a-expected.txt:
- platform/qt/svg/wicd/test-rightsizing-b-expected.png:
- platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
- platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
- platform/qt/svg/wicd/test-scalable-background-image1-expected.txt:
- platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
- platform/qt/svg/wicd/test-scalable-background-image2-expected.txt:
- 3:56 PM Changeset in webkit [123396] by
-
- 3 edits in trunk/Source/WebCore
Report the extra memory used by immutable StylePropertySet objects.
<http://webkit.org/b/92032>
Reviewed by Anders Carlsson.
Add an optional parameter to the MemoryClassInfo constructor for passing in additional base object
size on top of sizeof(T).
Use this in StylePropertySet::reportMemoryUsage() to properly account for the CSSProperty array
tacked onto the end of the object when m_isMutable == false.
- css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
- 3:53 PM Changeset in webkit [123395] by
-
- 4 edits2 adds in trunk
Fix WebGL texSubImage2D for cube maps
https://bugs.webkit.org/show_bug.cgi?id=91927
Patch by Gregg Tavares <gman@google.com> on 2012-07-23
Reviewed by Kenneth Russell.
Source/WebCore:
Fixes texSubImage2D so any size rectangle can be passed in
for cube maps.
Test: fast/canvas/webgl/tex-sub-image-cube-maps.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
- html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
LayoutTests:
Tests for WebGL texSubImage2D for cube maps.
- fast/canvas/webgl/tex-sub-image-cube-maps-expected.txt: Added.
- fast/canvas/webgl/tex-sub-image-cube-maps.html: Added.
- 3:46 PM Changeset in webkit [123394] by
-
- 4 edits6 adds in trunk
DFG is too aggressive in performing the specific value optimization on loads
https://bugs.webkit.org/show_bug.cgi?id=92034
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This ensures that we don't do optimizations based on a structure having a specific
value, if there is no way to detect that the value is despecified. This is the
case for dictionaries, since despecifying a value in a dictionary does not lead to
a transition and so cannot be caught by either structure checks or structure
transition watchpoints.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
- bytecode/ResolveGlobalStatus.cpp:
(JSC::computeForStructure):
LayoutTests:
- fast/js/dfg-resolve-global-polymorphic-non-dictionary-expected.txt: Added.
- fast/js/dfg-resolve-global-polymorphic-non-dictionary.html: Added.
- fast/js/dfg-resolve-global-specific-dictionary-expected.txt: Added.
- fast/js/dfg-resolve-global-specific-dictionary.html: Added.
- fast/js/script-tests/dfg-resolve-global-polymorphic-non-dictionary.js: Added.
(description.foo):
- fast/js/script-tests/dfg-resolve-global-specific-dictionary.js: Added.
(description.foo):
(x):
- 3:38 PM Changeset in webkit [123393] by
-
- 4 edits in trunk
REGRESSION(r123169): It made fast/js/dfg-inline-arguments-use-from-uninlined-code.html fail on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=92002
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
In the process of changing the nature of local variable typing, I forgot to modify one of the places where
we glue the DFG's notion of variable prediction to the runtime's notion of variable tagging.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Unskip test that this change fixes, as requested by Ossy.
- platform/qt/Skipped:
- 3:36 PM Changeset in webkit [123392] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r123387.
http://trac.webkit.org/changeset/123387
https://bugs.webkit.org/show_bug.cgi?id=92036
Broke chromium win build (Requested by tonywork on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/rule_bison.py:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- make-hash-tools.pl:
- 3:34 PM Changeset in webkit [123391] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541
Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.
PR# 181304.
Move about: URL handling to the right place (FrameLoaderClientBlackBerry::createDocumentLoader), so
reload and history navigation can work.
Other changes: Remove about:version which makes little sense. Make about:memory partially visible.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::load): Remove the call to loadAbout()
- Api/WebPage_p.h: Remove loadAbout()
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader): Construct about: data here.
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::numberToHTMLTr): Make it static
(BlackBerry::WebKit::configPage): Make it static
(BlackBerry::WebKit::memoryPage): Make it static
(BlackBerry::WebKit::cachePage):
(BlackBerry::WebKit::buildPage):
(BlackBerry::WebKit::creditsPage):
(BlackBerry::WebKit::cookiePage):
(BlackBerry::WebKit::aboutData): The only export function that returns HTML source for a given about: URL.
(WebKit):
- WebKitSupport/AboutData.h:
(WebKit):
- 3:09 PM Changeset in webkit [123390] by
-
- 9 edits in trunk/Tools
Unreviewed, rolling out r123360.
http://trac.webkit.org/changeset/123360
https://bugs.webkit.org/show_bug.cgi?id=91890
broke the chromium bots
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):
- Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_build_path):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_build_path):
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_build_path):
- 3:02 PM Changeset in webkit [123389] by
-
- 7 edits in trunk/Source/WebCore
Ref-count AtomicHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=91981
Reviewed by Adam Barth.
Ref-count AtomicHTMLToken to avoid copying AtomicHTMLToken in Bug 91703.
No new tests - no functional changes.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
- html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
- html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::create):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
(WebCore::HTMLTreeBuilder::parseError):
- html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- 2:54 PM Changeset in webkit [123388] by
-
- 2 edits in trunk/LayoutTests
More unreviewed chromium expectation changes to mark tests as failing/slow.
- platform/chromium/TestExpectations:
- 2:52 PM Changeset in webkit [123387] by
-
- 5 edits in trunk/Source/WebCore
Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667
Patch by Scott Graham <scottmg@google.com> on 2012-07-23
Reviewed by Tony Chang.
Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).
Also, use - instead of / for cl flags because a layer of project
generator converts them to \ otherwise, which causes the preprocessing
to fail (very slowly because of the cygwin-loop with a sleep 1).
No new tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/rule_bison.py:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- make-hash-tools.pl:
- 2:39 PM Changeset in webkit [123386] by
-
- 4 edits2 adds in trunk
MediaController.currentTime should be kept stable during script execution.
https://bugs.webkit.org/show_bug.cgi?id=88555
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-controller-time-constant.html
To keep MediaController.currentTime stable, add a new m_position variable and
a new m_clearPositionTimer timer. Both must be mutable variables as they will
be updated from within const functions. Calls to currentTime() will result in
stable values until the next runloop iteration.
- html/MediaController.cpp:
(MediaController::MediaController):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::clearPositionTimerFired):
- html/MediaController.h:
LayoutTests:
- media/media-controller-time-constant-expected.txt: Added.
- media/media-controller-time-constant.html: Added.
- 2:38 PM Changeset in webkit [123385] by
-
- 3 edits in trunk/Source/WebCore
Destroy CSS decoded data more eagerly once they become dead caches.
https://bugs.webkit.org/show_bug.cgi?id=91733
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-23
Reviewed by Geoffrey Garen.
Internal review by Kwang Yul Seo.
There are three CachedResources with decoded data: CachedImage, CachedScript
and CachedCSSStyleSheet. In the cases of CachedImage and CachedScript, we
eagerly destroy the decoded data using Timer in CacehdResource::allClientsRemoved().
We must apply the same policy here in CachedCSSStyleSheet because priority
inversion can occur. For example, we can't destroy the decoded data of CachedImages
when they are referenced by CachedCSSStyleSheet as background, mask or border
images.
No new tests - no new testable functionality.
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):
- loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
- 2:24 PM Changeset in webkit [123384] by
-
- 5 edits in trunk/Tools
[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459
Reviewed by Ryosuke Niwa.
Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.
- DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
- DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::accessibilityController):
(TestShell):
- 2:23 PM Changeset in webkit [123383] by
-
- 15 edits in trunk/LayoutTests
[Qt] dom/xhtml/level3/core rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92028
Unreviewed.
- platform/qt-5.0/Skipped:
- platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
- platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
- platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
- platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
- 2:21 PM Changeset in webkit [123382] by
-
- 2 edits in trunk/Tools
nrwt swallows early exceptions
https://bugs.webkit.org/show_bug.cgi?id=91884
Reviewed by Dirk Pranke.
Put everything in a try block so we won't miss any error.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
- 2:07 PM Changeset in webkit [123381] by
-
- 3 edits in branches/chromium/1180
Merge 123272 - [chromium] Don't display fullscreen button for video elements not containing video
https://bugs.webkit.org/show_bug.cgi?id=91811
Reviewed by Eric Carlson.
Covered by media/media-document-audio-repaint.html
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::reset):
TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10800085
- 2:04 PM Changeset in webkit [123380] by
-
- 4 edits1 copy in branches/chromium/1180
Merge 123259 - [chromium] CSS tweaks to media controls to prevent styles from being overridden
https://bugs.webkit.org/show_bug.cgi?id=91802
Reviewed by Eric Carlson.
Source/WebCore:
Having the buttons declared as inline caused them to not be included in the box layout,
resulting in styles set outside the media element to affect the position of the buttons.
In a similar vein, it was also possible to override the font-style attribute for the time
display.
Test: media/controls-styling-strict.html
- css/mediaControlsChromium.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
LayoutTests:
- media/controls-styling-strict.html: Added.
- platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
- platform/chromium-linux/media/controls-styling-strict-expected.txt: Added.
TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10807077
- 2:03 PM Changeset in webkit [123379] by
-
- 17 edits5 adds in trunk
Part 2 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Source/JavaScriptCore:
Turn on ENABLE_CSS_STICKY_POSITION.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Turn on ENABLE_CSS_STICKY_POSITION. Add support for parsing the new '-webkit-sticky'
value for position, returning it from getComputedStyle(), and storing it in RenderStyle.
Test: fast/css/sticky/parsing-position-sticky.html
- Configurations/FeatureDefines.xcconfig:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPosition):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
Source/WebKit/chromium:
Turn on ENABLE_CSS_STICKY_POSITION.
- features.gypi:
Source/WebKit/mac:
Turn on ENABLE_CSS_STICKY_POSITION.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Turn on ENABLE_CSS_STICKY_POSITION.
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
Test for parsing and returning fro getComputedStyle() the new
-webkit-sticky value for position.
- fast/css/sticky/parsing-position-sticky-expected.txt: Added.
- fast/css/sticky/parsing-position-sticky.html: Added.
- fast/css/sticky/resources/parsing-position-sticky.js: Added.
(test):
- 2:03 PM Changeset in webkit [123378] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations change to mark media/media-fragments/TC0010-TC0019.html as flaky/crashy.
- platform/chromium/TestExpectations:
- 1:57 PM Changeset in webkit [123377] by
-
- 3 edits2 adds in trunk
Crash when setting empty class name on a new element
https://bugs.webkit.org/show_bug.cgi?id=92024
Reviewed by Andreas Kling.
Source/WebCore:
Add a check for null attributeData() when setting the className to an
empty string on a newly created element. New SVG elements have null
attributeData() on baseVal upon creation.
Test: svg/custom/empty-className-baseVal-crash.html
- dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged): Add check for null attributeData()
LayoutTests:
Add a check for null attributeData() when setting the className to an
empty string on a newly created element.
- svg/custom/empty-className-baseVal-crash-expected.txt: Added.
- svg/custom/empty-className-baseVal-crash.html: Added.
- 1:53 PM Changeset in webkit [123376] by
-
- 5 edits in trunk/Source/JavaScriptCore
Move JSC::parseDate() from DateConversion to JSDateMath
https://bugs.webkit.org/show_bug.cgi?id=91982
Reviewed by Geoffrey Garen.
Moveing this function into the other files removes the dependency
on JSC spcific classes in DateConversion.{cpp|h}.
- runtime/DateConversion.cpp:
- runtime/DateConversion.h:
(JSC):
- runtime/JSDateMath.cpp:
(JSC::parseDate):
(JSC):
- runtime/JSDateMath.h:
(JSC):
- 1:46 PM Changeset in webkit [123375] by
-
- 19 edits in trunk/Source
[chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect design
https://bugs.webkit.org/show_bug.cgi?id=80622
Reviewed by Adrienne Walker.
Source/WebCore:
clipRect(), usesLayerClipping(), and drawableContentRect() have been
very confusing in CCLayerTreeHostCommon for a while. This patch
refactors it so that (1) clipping is only done locally in
calcDrawTransforms, and (2) the layer's drawableContentRect value
is now meaningful value outside of calcDrawTransforms.
Additionally, the layer is now always clipped to the root
surface's contentBounds (which are set to the viewport bounds).
This refactor not only makes calcDrawTransforms far more readable and intuitive, but
this patch enables more upcoming beneficial refactors, including
the pending refactor in https://bugs.webkit.org/show_bug.cgi?id=88953.
Tests are also significantly updated to keep up with this refactoring change.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
Removed m_usesLayerClipping and m_clipRect and associated accessors.
- platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
Updated comment
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
Removed m_usesLayerClipping and m_clipRect and associated accessors.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
removed setClipRect code that no longer applies
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateLayerScissorRect):
scissor rect is now a little bit tighter, the intersection between damage and layer's new drawableContentRect.
(WebCore::calculateSurfaceScissorRect):
scissor rect is now a little bit tighter, except when filters are involved.
(WebCore::layerClipsSubtree):
new helper function
(WebCore):
(WebCore::calculateVisibleContentRect):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsInternal):
- added drawableContentRectOfSubtree to the function args, it is valid only after recursion returns,
- added clipRectFromAncestor and bool ancestorClipsSubtree to function args, this replaces the layer's clipRect and usesLayerClipping.
- removed the boolean return value, which was redundant with drawableContentRectOfSubtree.
- replaced all the "setDrawableContentRect" logic with more intuitive, clear logic.
- now, layer's drawableContentRect represents the clipped bounds of the layer expressed in the target surface space.
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
(WebCore::pointIsClippedBySurfaceOrClipRect):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::layerScissorRectInTargetSurface):
Updated this accessor. It could be removed in the future, but not appropriate for this patch.
- platform/graphics/chromium/cc/CCRenderSurface.h:
Source/WebKit/chromium:
Many tests needed to be updated because the semantics of the layer tree have changed:
- a few tests that were no longer applicable were removed.
- many tests needed to have fixed initialization, properly setting surface contentRect and rootLayer bounds.
- because clipRect and usesLayerClipping no longer exists, those places in code had to be removed/changed
- the scissorRect tests needed to have updated expectations because after this patch, the rootLayer Surface now clips to its contentBounds.
- the clipRect tests were changed to test the layer's new semantics for the drawableContentRect instead.
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerIteratorTest.cpp:
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
- tests/LayerChromiumTest.cpp:
- 1:37 PM Changeset in webkit [123374] by
-
- 20 edits4 moves in trunk
[WK2] WebKitTestRunner needs to print information about Web intents
https://bugs.webkit.org/show_bug.cgi?id=90873
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Anders Carlsson.
Source/WebKit2:
Add Bundle API for Web Intents. This is needed by the WebKitTestRunner
to print information about the new intent requests and the intent
service registrations.
- CMakeLists.txt: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
- GNUmakefile.list.am: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
- Shared/APIClientTraits.h:
- Shared/WebIntentData.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentData.cpp.
(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::extra):
(WebKit::WebIntentData::extras):
- Shared/WebIntentData.h: Renamed from Source/WebKit2/UIProcess/WebIntentData.h.
(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::service):
(WebKit::WebIntentData::store):
(WebKit::WebIntentData::type):
- Shared/WebIntentServiceInfo.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.cpp.
(WebKit):
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):
- Shared/WebIntentServiceInfo.h: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.h.
(WebKit):
(WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::create):
(WebKit::WebIntentServiceInfo::~WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::payloadType):
(WebKit::WebIntentServiceInfo::href):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::type):
- Target.pri: Move WebIntentData and WebIntentServiceInfo from
UIProcess/ to Shared/.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didReceiveIntentForFrame):
(registerIntentServiceForFrame):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveIntentForFrame):
(WebKit::WebLoaderClient::registerIntentServiceForFrame):
- UIProcess/WebLoaderClient.h:
(WebLoaderClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerIntentServiceForFrame):
(WebKit::WebPageProxy::didReceiveIntentForFrame):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit):
(WebKit::InjectedBundlePageLoaderClient::didReceiveIntentForFrame):
(WebKit::InjectedBundlePageLoaderClient::registerIntentServiceForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(WebKit):
(InjectedBundlePageLoaderClient):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchIntent):
(WebKit::WebFrameLoaderClient::registerIntentService):
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Tools:
Print out information about new intents requests and intent
services registrations in WebKitTestRunner. This is expected
by tests under webintents/*.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReceiveIntentForFrame):
(WTR):
(WTR::InjectedBundlePage::registerIntentServiceForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
- 1:32 PM Changeset in webkit [123373] by
-
- 3 edits in trunk/LayoutTests
[Qt] tables/mozilla_expected_failures rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92013
Unreviewed.
- platform/qt-5.0/Skipped:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- 1:26 PM Changeset in webkit [123372] by
-
- 4 edits3 adds in trunk/Source/WebKit2
[EFL][WK2] Add unit tests for Ewk_Cookie_Manager
https://bugs.webkit.org/show_bug.cgi?id=91639
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Antonio Gomes.
Add unit tests for Ewk_Cookie_Manager.
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_cookie_manager.h: Fix "accept policy" documentation
to indicate that only cookies set by the main document are accepted by default.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp: Added.
(EWK2UnitTestServer::EWK2UnitTestServer): Add HTTP server similar to the one
used by GTK port unit tests.
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::run):
(EWK2UnitTestServer::getURIForPath):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h: Added.
(EWK2UnitTestServer):
(EWK2UnitTestServer::baseURI):
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Added.
(serverCallback):
(getAcceptPolicyCallback):
(getAcceptPolicy):
(getHostnamesWithCookiesCallback):
(getHostnamesWithCookies):
(freeHostNames):
(countHostnamesWithCookies):
(TEST_F):
(cleanUpCookieFiles):
- 1:23 PM Changeset in webkit [123371] by
-
- 3 edits in trunk/Source/WebKit/win
Build fix if NOMINMAX is defined by the build system.
- COMEnumVariant.h: Added #ifndef NOMINMAX around #define NOMINMAX.
- COMPropertyBag.h: Ditto.
- 1:22 PM Changeset in webkit [123370] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Fix build on Ubuntu Precise.
https://bugs.webkit.org/show_bug.cgi?id=92021
Reviewed by Adrienne Walker.
Remove an array that's written but never read.
- tests/CCResourceProviderTest.cpp:
(WebKit::TEST_F):
- 1:16 PM Changeset in webkit [123369] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] Added missing RenderLayerFilterInfo.cpp to build system.
- CMakeLists.txt:
- 1:06 PM Changeset in webkit [123368] by
-
- 2 edits in trunk/LayoutTests
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017
Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-07-23
Reviewed by Alexis Menard.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 1:01 PM Changeset in webkit [123367] by
-
- 11 edits2 adds in trunk/LayoutTests
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017
Reviewed by Alexis Menard.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 12:54 PM Changeset in webkit [123366] by
-
- 42 edits8 adds2 deletes in trunk/LayoutTests
[Qt] svg/zoom needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92007
Reviewed by Alexis Menard.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
- platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
- platform/qt/Skipped:
- platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
- platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-background-images-expected.png:
- platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
- platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
- platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
- platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
- 12:49 PM Changeset in webkit [123365] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations change to ignore DEBUG failures for policy-ignore-crash.php.
- platform/chromium/TestExpectations:
- 12:44 PM Changeset in webkit [123364] by
-
- 20 edits3 deletes in trunk/LayoutTests
Unreviewed, rolling out r123362.
http://trac.webkit.org/changeset/123362
https://bugs.webkit.org/show_bug.cgi?id=92020
uploaded wrong expectations :( bad caio (Requested by cmarcelo
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 12:38 PM Changeset in webkit [123363] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations change to mark inline-plaintext-relayout-with-leading-neutrals.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=92019
- platform/chromium/TestExpectations:
- 12:32 PM Changeset in webkit [123362] by
-
- 20 edits1 copy2 adds in trunk/LayoutTests
[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017
Reviewed by Alexis Menard.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 12:31 PM Changeset in webkit [123361] by
-
- 3 edits in trunk/Source/WebKit/chromium
Add WebTextInputType enum values for text areas and
content-editable.
https://bugs.webkit.org/show_bug.cgi?id=91654
Reviewed by Adam Barth.
No new tests, no behavior change without corresponding chromium.org changes.
- public/WebTextInputType.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
- 12:26 PM Changeset in webkit [123360] by
-
- 9 edits in trunk/Tools
nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890
Reviewed by Tony Chang.
We were figuring out which directory look in for binaries by
testing for the base directory (the directory above
Debug/Release). In chromium-win's case, we look in src/build,
which always exists because there are checked-in files in it,
which means we'd always pick that directory over src/out. All of
the other ports' build_path() implementation was including
Debug/Release. If we matched that, we wouldn't have a problem,
so this change fixes that and updates all of the callers of the
chromium ports' implementation to not pass configuration as part
of the path to look up; we still need to pass configuration in
some cases (to test if the build is out of date between debug
and release) so the implementation gets slightly more
complicated.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):
- Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_build_path):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_build_path):
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_build_path):
- 12:26 PM Changeset in webkit [123359] by
-
- 3 edits2 adds in trunk
REGRESSION(r123281): childNodes sometimes returns wrong nodes
https://bugs.webkit.org/show_bug.cgi?id=92014
Reviewed by Anders Carlsson.
Source/WebCore:
The bug was caused by a typo in itemBeforeOrAfter. Namely, it should have been calling firstNode as
firstNode(forward, rootNode(), shouldOnlyIncludeDirectChildren()),
NOT firstNode(forward, rootNode(), previous)
as evident from the argument list of the function.
Test: fast/dom/NodeList/childNodes-reverse-iteration.html
- html/HTMLCollection.cpp:
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter):
LayoutTests:
Added an integration regression test that caught this bug.
- fast/dom/NodeList/childNodes-reverse-iteration-expected.txt: Added.
- fast/dom/NodeList/childNodes-reverse-iteration.html: Added.
- 11:58 AM Changeset in webkit [123358] by
-
- 12 edits1 add in trunk/LayoutTests
[Qt] animations needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91997
Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-23
Reviewed by Noam Rosenthal.
Updating skipped tests inside animations directory.
- platform/qt-5.0/Skipped:
- platform/qt/animations/3d/change-transform-in-end-event-expected.txt: Added.
- platform/qt/animations/3d/state-at-end-event-transform-expected.txt:
- platform/qt/animations/additive-transform-animations-expected.txt:
- platform/qt/animations/cross-fade-background-image-expected.txt:
- platform/qt/animations/cross-fade-border-image-source-expected.txt:
- platform/qt/animations/cross-fade-list-style-image-expected.txt:
- platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt:
- platform/qt/animations/cross-fade-webkit-mask-image-expected.txt:
- platform/qt/animations/missing-values-first-keyframe-expected.txt:
- platform/qt/animations/missing-values-last-keyframe-expected.txt:
- platform/qt/animations/state-at-end-event-expected.txt:
- 11:54 AM Changeset in webkit [123357] by
-
- 3 edits in branches/chromium/1180/Source/WebCore/inspector/front-end
Merge 122979 - Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625
Reviewed by Vsevolod Vlasov.
- inspector/front-end/HandlerRegistry.js:
- inspector/front-end/NetworkPanel.js:
TBR=pfeldman@chromium.org
BUG=137863
Review URL: https://chromiumcodereview.appspot.com/10796093
- 11:48 AM Changeset in webkit [123356] by
-
- 2 edits in trunk/Source/WebCore
Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171
Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-07-23
Reviewed by Stephen White.
Connect GraphicsContext::setURLForRect to Skia's new API for annotations.
Printing is not generally testable.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):
- 11:45 AM Changeset in webkit [123355] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013
Reviewed by Antonio Gomes.
Take advantage of the logic introduced in r122286.
- Target.pri:
- 11:31 AM Changeset in webkit [123354] by
-
- 37 edits in trunk
Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
https://bugs.webkit.org/show_bug.cgi?id=91006
Reviewed by Ryosuke Niwa.
Source/WebCore:
The rationale here is that the client doesn't need to know about the touch
event handler count. needTouchEvents was already used for that purpose.
Test: fast/events/touch/touch-handler-count.html
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler): Only notify the client if needed.
(WebCore::Document::didRemoveTouchEventHandler): Ditto. Also unset the TOUCH_LISTENER
flag for the document if we reach a count of zero. The rationale being that
hasListenerType() is relied upon in other places in combination with TOUCH_LISTENER for
the same purpose.
- dom/Document.h:
(Document):
(WebCore::Document::touchEventHandlerCount):
- loader/EmptyClients.h:
- page/ChromeClient.h:
(ChromeClient):
- page/Frame.cpp: Removed notifyChromeClientTouchEventHandlerCountChanged.
(WebCore::Frame::setDocument): call needsTouchEvents directly.
- page/Frame.h: Ditto.
(Frame):
- testing/Internals.cpp:
(WebCore::Internals::hasTouchEventListener): expose Document::hasListenerType indirectly
for additional testing.
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/blackberry:
Removed numTouchEventHandlersChanged stub.
- WebCoreSupport/ChromeClientBlackBerry.h:
Source/WebKit/chromium:
Rename the functions to follow a more boolean logic.
- public/WebViewClient.h:
(WebKit::WebViewClient::hasTouchEventHandlers):
- src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::ChromeClientImpl::needTouchEvents):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hasTouchEventHandlers):
- src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit/efl:
Removed numTouchEventHandlersChanged stub.
- WebCoreSupport/ChromeClientEfl.h:
Source/WebKit/gtk:
Remove numTouchEventHandlersChanged stub.
- WebCoreSupport/ChromeClientGtk.h:
Source/WebKit/mac:
Remove numTouchEventHandlersChanged stub.
- WebCoreSupport/WebChromeClient.h:
Source/WebKit/qt:
Remove numTouchEventHandlersChanged stub.
- WebCoreSupport/ChromeClientQt.h:
Source/WebKit/win:
Remove numTouchEventHandlersChanged stub.
- WebCoreSupport/WebChromeClient.h:
Source/WebKit/wince:
Remove numTouchEventHandlersChanged stub.
- WebCoreSupport/ChromeClientWinCE.h:
Source/WebKit/wx:
Remove numTouchEventHandlersChanged stub.
- WebKitSupport/ChromeClientWx.h:
Source/WebKit2:
Remove numTouchEventHandlersChanged stub.
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
LayoutTests:
Extend the touch-handler-count test to also cover the hasListenerType logic.
- fast/events/touch/touch-handler-count-expected.txt:
- fast/events/touch/touch-handler-count.html:
- 11:23 AM Changeset in webkit [123353] by
-
- 8 edits in trunk/Source
[Qt] RenderThemeQtMobile highlight colors are not being used
https://bugs.webkit.org/show_bug.cgi?id=92004
Reviewed by Noam Rosenthal.
Source/WebCore:
The issue here is that setPaletteFromPageClientIfExists() is being used as a
virtual function, but it isn't, so when platformActiveSelectionBackgroundColor()
runs, it doesn't pick the right palette.
Besides fixing this virtual behavior, the patch changes the structure a bit,
because setPaletteFromPageClientIfExists() was being "overriden" in mobile theme
to set the palette, which isn't exactly what the function name says.
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
Use the virtual colorPalette() to get the palette.
(WebCore::RenderThemeQt::colorPalette):
(WebCore): Removed the code for getting the page client from here since it is
used only by the QStyle variant.
- platform/qt/RenderThemeQt.h:
(RenderThemeQt):
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::colorPalette):
(WebCore):
- platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
Source/WebKit/qt:
- WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists): Moved here since
it's used only by RenderThemeQStyle. Remove unnecessary check for m_page->chrome().
(WebCore):
(WebCore::RenderThemeQStyle::colorPalette):
- WebCoreSupport/RenderThemeQStyle.h:
(RenderThemeQStyle):
- 11:17 AM Changeset in webkit [123352] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations change to mark fast/frames/frameset-frameborder-boolean-values.html as slow on snowleopard.
https://bugs.webkit.org/show_bug.cgi?id=24182
- platform/chromium/TestExpectations:
- 11:06 AM Changeset in webkit [123351] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium change to mark sandboxed-iframe-navigation-parent.html as slow on Windows.
https://bugs.webkit.org/show_bug.cgi?id=24182
- platform/chromium/TestExpectations:
- 10:45 AM Changeset in webkit [123350] by
-
- 13 edits in trunk
Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.
Sort the ENABLE_CSS lines in the file.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.
Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.
Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.
- features.gypi:
Source/WebKit/mac: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.
Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046
Reviewed by Ojan Vafai.
Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.
Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
- 10:44 AM Changeset in webkit [123349] by
-
- 4 edits in trunk/LayoutTests
Unreviewed chromium expectations change after r123302.
https://bugs.webkit.org/show_bug.cgi?id-91806
- platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- 10:27 AM Changeset in webkit [123348] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations change to ignore failures for policy-ignore-crash.php.
- platform/chromium/TestExpectations:
- 10:25 AM WebKit Team edited by
- (diff)
- 9:25 AM Changeset in webkit [123347] by
-
- 6 edits in trunk/LayoutTests
Skip http/tests/pointer-lock on ports that do not support pointer lock.
Unreviewed.
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 9:25 AM Changeset in webkit [123346] by
-
- 7 edits in trunk
Unreviewed, rolling out r123339.
http://trac.webkit.org/changeset/123339
https://bugs.webkit.org/show_bug.cgi?id=92006
massive media tests failure (Requested by philn on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23
Source/WebCore:
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(setGstElementClassMetadata):
- platform/graphics/gstreamer/GStreamerVersioning.h:
Tools:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- gtk/jhbuild.modules:
- 9:15 AM Changeset in webkit [123345] by
-
- 6 edits in trunk
[chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
https://bugs.webkit.org/show_bug.cgi?id=91857
Reviewed by Adam Barth.
Source/Platform:
Made Platforms destructor virtual.
- chromium/public/Platform.h:
(WebKit::Platform::~Platform):
Tools:
Made a few changes so that the destructor could be called at shutdown.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment):
- DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::create):
- DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
(MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::~MockWebKitPlatformSupport):
- 8:59 AM Changeset in webkit [123344] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] Merge createThreadInternal implementations
https://bugs.webkit.org/show_bug.cgi?id=91899
Reviewed by Yong Li.
PR 111675
Remove our implementation since the default thread stack size on QNX is fine.
- wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
(WTF::initializeCurrentThreadInternal): make sure we set the thread name.
- 8:50 AM Changeset in webkit [123343] by
-
- 8 edits12 adds in trunk
webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement block cross origin access.
https://bugs.webkit.org/show_bug.cgi?id=91892
Reviewed by Adam Barth.
Source/WebCore:
PointerLockElement only returned when requested from the document that owns it.
Tests: http/tests/fullscreen/fullscreenelement-different-origin.html
http/tests/fullscreen/fullscreenelement-same-origin.html
http/tests/pointer-lock/pointerlockelement-different-origin.html
http/tests/pointer-lock/pointerlockelement-same-origin.html
- dom/Document.cpp:
(WebCore::Document::webkitPointerLockElement):
LayoutTests:
Tests verifying the behavior of accessing
webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement
from different origins.
- http/tests/fullscreen/fullscreenelement-different-origin-expected.txt: Added.
- http/tests/fullscreen/fullscreenelement-different-origin.html: Added.
- http/tests/fullscreen/fullscreenelement-same-origin-expected.txt: Added.
- http/tests/fullscreen/fullscreenelement-same-origin.html: Added.
- http/tests/pointer-lock/pointerlockelement-different-origin-expected.txt: Added.
- http/tests/pointer-lock/pointerlockelement-different-origin.html: Added.
- http/tests/pointer-lock/pointerlockelement-same-origin-expected.txt: Added.
- http/tests/pointer-lock/pointerlockelement-same-origin.html: Added.
- http/tests/resources/pointer-lock/iframe-common.js: Added.
(thisFileName):
(window.onmessage):
- http/tests/resources/pointer-lock/inner-iframe.html: Added.
- http/tests/resources/pointer-lock/pointer-lock-test-harness.js:
(runOnKeyPress.keypressHandler):
- pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
- pointer-lock/locked-element-iframe-removed-from-dom.html:
- pointer-lock/locked-element-removed-from-dom-expected.txt:
- pointer-lock/locked-element-removed-from-dom.html:
- 8:49 AM Changeset in webkit [123342] by
-
- 2 edits in trunk/Source/JavaScriptCore
[BlackBerry] Implement GCActivityCallback with platform timer
https://bugs.webkit.org/show_bug.cgi?id=90175
Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.
Use JSLock when performing GC to avoid assertions.
- runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::doWork):
- 8:49 AM Changeset in webkit [123341] by
-
- 6 edits5 adds in trunk/Source/WebKit2
[EFL][WK2] Add request manager client
https://bugs.webkit.org/show_bug.cgi?id=91193
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.
Add a URL request manager client and attach it
to the Ewk_Context.
The client application can now register a URL scheme
via the Ewk_Context API and provide a callback handler
that will get called whenever a URL request with this
scheme is made.
A new Ewk_Url_Scheme_Request type is introduced to
provide information about the request to the client
and to allow the client to finish it by setting its
contents.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Url_Scheme_Handler):
(_Ewk_Url_Scheme_Handler::_Ewk_Url_Scheme_Handler):
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_request_manager_get):
(ewk_context_url_scheme_request_received):
(createDefaultEwkContext):
(ewk_context_uri_scheme_register):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/ewk_context_request_manager_client.cpp: Added.
(toEwkContext):
(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):
- UIProcess/API/efl/ewk_context_request_manager_client_private.h: Added.
- UIProcess/API/efl/ewk_url_scheme_request.cpp: Added.
(_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::~_Ewk_Url_Scheme_Request):
(ewk_url_scheme_request_ref):
(ewk_url_scheme_request_unref):
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
(ewk_url_scheme_request_id_get):
(ewk_url_scheme_request_finish):
(ewk_url_scheme_request_new):
- UIProcess/API/efl/ewk_url_scheme_request.h: Added.
- UIProcess/API/efl/ewk_url_scheme_request_private.h: Added.
- 8:39 AM Changeset in webkit [123340] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, adding the WONTFIX modifier to a few more tests,
moving them to the top of the expected failures section.
- platform/gtk/TestExpectations:
- 8:39 AM Changeset in webkit [123339] by
-
- 7 edits in trunk
[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Add a new function to encapsulate the GStreamer API removal of
GST_OBJECT_IS_FLOATING in the upcoming 1.0 release. Use of this
macro can now be replaced by calling the g_object_is_floating
function.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(gstObjectIsFloating):
- platform/graphics/gstreamer/GStreamerVersioning.h:
Tools:
Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
- gtk/jhbuild.modules: GStreamer build support.
- 8:01 AM Changeset in webkit [123338] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip the failing tests.
- platform/qt/Skipped:
- 7:17 AM Changeset in webkit [123337] by
-
- 2 edits in trunk/LayoutTests
[Qt] DumpRenderTree does not use 'monospace' font when directed
https://bugs.webkit.org/show_bug.cgi?id=85203
Unreviewed gardening.
- platform/qt-4.8/Skipped: Unskip now passing tests.
- 7:15 AM Changeset in webkit [123336] by
-
- 2 edits2 deletes in trunk/LayoutTests
[Qt] editing/inserting/multiple-lines-selected.html fails
https://bugs.webkit.org/show_bug.cgi?id=91993
Reviewed by Simon Hausmann.
Removing wrong expected results, adding it to the skipped list.
- platform/qt-5.0/Skipped:
- platform/qt/editing/inserting/multiple-lines-selected-expected.png: Removed.
- platform/qt/editing/inserting/multiple-lines-selected-expected.txt: Removed.
- 6:53 AM Changeset in webkit [123335] by
-
- 10 edits2 adds15 deletes in trunk/LayoutTests
[Qt] editing/inserting rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91985
Unreviewed.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.png: Removed.
- platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.txt: Removed.
- platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.png: Removed.
- platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.txt: Removed.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Removed.
- platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Removed.
- platform/qt/editing/inserting/4960120-1-expected.png:
- platform/qt/editing/inserting/before-after-input-element-expected.png:
- platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
- platform/qt/editing/inserting/insert-3851164-fix-expected.txt:
- platform/qt/editing/inserting/insert-div-009-expected.png: Added.
- platform/qt/editing/inserting/insert-div-009-expected.txt:
- platform/qt/editing/inserting/insert-div-010-expected.png: Added.
- platform/qt/editing/inserting/insert-div-010-expected.txt:
- 6:30 AM Changeset in webkit [123334] by
-
- 7 edits in trunk
[EFL] media/controls-styling.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91984
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Eric Carlson.
Source/WebCore:
Make sure that the CSS properties letter-spacing, word-spacing,
line-height, text-transform, text-indent, text-shadow,
text-decoration and color do not affect the media element controls,
that display text.
No new tests. Already tested by media/controls-styling.html and
media/controls-styling-strict.html
- css/mediaControlsEfl.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
LayoutTests:
Rebaseline media controls styling tests now that the
EFL port properly ensures that overriding CSS
properties won't affect the media controls.
- platform/efl/media/controls-styling-expected.png:
- platform/efl/media/controls-styling-expected.txt:
- platform/efl/media/controls-styling-strict-expected.png:
- platform/efl/media/controls-styling-strict-expected.txt:
- 5:15 AM Changeset in webkit [123333] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/layers/video-layer.html needs rebasing after r123320
https://bugs.webkit.org/show_bug.cgi?id=91978
Unreviewed EFL gardening, regenerate baseline for
fast/layers/video-layer.html after r123320.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
- platform/efl/fast/layers/video-layer-expected.txt:
- 4:44 AM Changeset in webkit [123332] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped:
- 4:37 AM Changeset in webkit [123331] by
-
- 3 edits1 add in trunk/Source/WebKit2
[EFL][WK2] ProcessExecutablePath is required
https://bugs.webkit.org/show_bug.cgi?id=89719
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.
Added executablePathOfWebProcess and executablePathOfPluginProcess.
It's used for getting the location of WebProcess and PluginProcess.
- PlatformEfl.cmake: Added LIBEXECDIR definition
- Shared/efl/ProcessExecutablePathEfl.cpp: Added.
(WebKit):
(WebKit::findWebKitProcess):
(WebKit::executablePathOfWebProcess): Get the absolute path of WebProcess
(WebKit::executablePathOfPluginProcess): Get the absolute path of PluginProcess
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess): Modified to use above routines
- 4:27 AM Changeset in webkit [123330] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header files.
- 4:19 AM Changeset in webkit [123329] by
-
- 10 edits in trunk/Source/WebCore
Replace some instances of shadowAncestorNode() with shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=91966
Reviewed by Hajime Morita.
shadowAncestorNode() is deprecated. We should use shadowHost().
No new tests. This doesn't change any behavior.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
- dom/TreeScope.cpp:
(WebCore::listTreeScopes):
- html/HTMLSummaryElement.cpp:
(WebCore::isClickableControl):
- html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::summaryElement):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::meterElement):
- html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressShadowElement::progressElement):
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::TrackLimiterElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::TextControlInnerTextElement::createRenderer):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::step):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setState):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlInnerBlock::positionForPoint):
- 4:18 AM Changeset in webkit [123328] by
-
- 2 edits in trunk/Source/WebCore
[WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit::PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=91782
Reviewed by Yury Semikhatsky.
hideHighlight was never called once user hovered over a node.
- inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::update):
- 4:07 AM Changeset in webkit [123327] by
-
- 2 edits in trunk/LayoutTests
[Qt] new test introduced in r123205 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91967
Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.
Skipped WebInspector test that needs CSS Regions enabled.
- platform/qt/Skipped:
- 3:54 AM Changeset in webkit [123326] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Build fix for the Windows builder following r123311
https://bugs.webkit.org/show_bug.cgi?id=91979
Unreviewed build fix.
Changeset r123311 moved the TextCodecWinCE.{cpp,h} files to the Windows
directory. Update Chromium's references to these files to fix the build.
- WebCore.gypi:
- 3:36 AM Changeset in webkit [123325] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Buildfix for fixing gclient on the Chromium Windows bot
https://bugs.webkit.org/show_bug.cgi?id=91977
Unreviewed build fix.
Add the tools/isolate directory to the Windows checkout as these files
currently are missing during gyp generation. maruel introduced the need
for these in this isolate refactoring, specifically this Chromium CL:
http://src.chromium.org/viewvc/chrome?view=rev&revision=147689
- DEPS:
- 3:05 AM Changeset in webkit [123324] by
-
- 5 edits in trunk
[WINCE] Define NOMINMAX in the build system instead of Platform.h
https://bugs.webkit.org/show_bug.cgi?id=91938
Reviewed by Ryosuke Niwa.
.:
Define it in OptionsWindows.cmake, since NOMINMAX
should to be defined for all windows ports.
- Source/cmake/OptionsWinCE.cmake:
- Source/cmake/OptionsWindows.cmake:
Source/WTF:
- wtf/Platform.h:
- 2:58 AM Changeset in webkit [123323] by
-
- 2 edits in trunk/Source/WebCore
[WIN] Remove ICU dependencies from UniscribeController
https://bugs.webkit.org/show_bug.cgi?id=91921
Reviewed by Ryosuke Niwa.
Replace ICU specific functions and macros with the corresponding code from WTF::Unicode.
This allows us to use UniscribeController with an other Unicode implementation too.
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):
- 2:47 AM Changeset in webkit [123322] by
-
- 2 edits in trunk/Source/WTF
Build fix for Windows after r123317.
- wtf/DateMath.cpp: Added missing header include.
- 2:47 AM Changeset in webkit [123321] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marking more svg/W3C-SVG-1.1/animate-elem-* tests as flaky.
- platform/gtk/TestExpectations:
- 2:23 AM Changeset in webkit [123320] by
-
- 18 edits2 adds in trunk
[EFL] media/controls-styling-strict.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91960
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Use "display: -webkit-box;" instead of inline-block
for current-time control. This is needed because
inline-block behaves differently in strict mode.
No new test, already tested by media/controls-styling-strict.html
- css/mediaControlsEfl.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
LayoutTests:
Update test expectations for media tests now that
we use "display: -webkit-box;" for the current-time
control.
- platform/efl/media/audio-controls-rendering-expected.txt:
- platform/efl/media/audio-repaint-expected.png:
- platform/efl/media/audio-repaint-expected.txt:
- platform/efl/media/controls-layout-direction-expected.png:
- platform/efl/media/controls-strict-expected.png:
- platform/efl/media/controls-strict-expected.txt:
- platform/efl/media/controls-styling-expected.txt:
- platform/efl/media/controls-styling-strict-expected.png: Added.
- platform/efl/media/controls-styling-strict-expected.txt: Added.
- platform/efl/media/media-controls-clone-expected.png:
- platform/efl/media/media-controls-clone-expected.txt:
- platform/efl/media/video-aspect-ratio-expected.png:
- platform/efl/media/video-layer-crash-expected.png:
- platform/efl/media/video-transformed-expected.png:
- platform/efl/media/video-zoom-controls-expected.png:
- platform/efl/media/video-zoom-controls-expected.txt:
- platform/efl/media/video-zoom-expected.png:
- 1:43 AM Changeset in webkit [123319] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ build with ENABLE_DATALIST_ELEMENT.
Add an implementation for virtual pure methods sliderTickSize()
and sliderTickOffsetFromTrackCenter() when HTML5 datalist element
is enabled.
- platform/gtk/RenderThemeGtk.cpp:
(WebCore):
(WebCore::RenderThemeGtk::sliderTickSize):
(WebCore::RenderThemeGtk::sliderTickOffsetFromTrackCenter):
- platform/gtk/RenderThemeGtk.h:
- 1:36 AM Changeset in webkit [123318] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip http/tests/inspector-enabled/injected-script-discard.html
https://bugs.webkit.org/show_bug.cgi?id=91959
Unreviewed EFL gardening. Skip flaky Web Inspector test case.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
- platform/efl/TestExpectations:
- 1:34 AM Changeset in webkit [123317] by
-
- 2 edits in trunk/Source/WTF
[WIN] Use GetTimeZoneInformation() for calculateUTCOffset()
https://bugs.webkit.org/show_bug.cgi?id=91935
Reviewed by Ryosuke Niwa.
GetTimeZoneInformation() returns the offset directly. Using it
avoids unnecessary calculations and remove dependencies on
other time related function, which do not exist on WinCE.
- wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
- 1:33 AM Changeset in webkit [123316] by
-
- 9 edits in trunk
WebKit2 needs layoutTestController.setAlwaysAcceptCookies
https://bugs.webkit.org/show_bug.cgi?id=42778
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add setAlwaysAcceptCookies() method to InjectedBundle
so that we can use it in LayoutTestController.
The method uses WebCookieManager::setHTTPCookieAcceptPolicy()
internally.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAlwaysAcceptCookies):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAlwaysAcceptCookies):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Tools:
Add support for layoutTestController.setAlwaysAcceptCookies()
since it is required by some tests.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setAlwaysAcceptCookies):
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- 1:30 AM Changeset in webkit [123315] by
-
- 16 edits in trunk/Source/WebKit2
[WK2] SQL Database cannot be disabled at build time
https://bugs.webkit.org/show_bug.cgi?id=91837
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.
WebKit2 had no #ifdefs for SQL Database. This patch adds these
statments and it can now be disabled at build time.
- Shared/OriginAndDatabases.cpp:
- Shared/OriginAndDatabases.h:
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetDatabaseManager):
- UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetTypeID):
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerSetClient):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebDatabaseManagerProxy.cpp:
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.messages.in:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
- 1:24 AM Changeset in webkit [123314] by
-
- 2 edits in trunk/Source/WebCore
Replace getCurrentLocalTime() with GetLocalTime() in LocaleWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=91937
Reviewed by Ryosuke Niwa.
The windows function returns the required year directly and
removes one additonal dependecy on getCurrentLocalTime().
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::LocaleWin):
- 1:18 AM Changeset in webkit [123313] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: Drag and drop should not be started on right mouse click.
https://bugs.webkit.org/show_bug.cgi?id=91728
Reviewed by Pavel Feldman.
Introduced WebInspector.installDragHandle method to control drag and drop support, checking whichg mouse button is pressed.
Simplified WebInspector._elementDragStart, removed "element" parameter.
Simplified tab moving support in TabbedPane, removed "mousemove" handler.
Removed while loop determining which element was dragged in TimelineOverviewPane, each drag support is now installed independently.
Drive-by: fixed TimelineOverviewPane window moving on resources-dividers-label-bar drang-and-drop.
Drive-by: fixed CSSStyleModel compilation.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._positionResizers):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):
- inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype._animationDuration):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._endStatusBarDragging):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):
- inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay.prototype.set _startResizerDragging):
(WebInspector.SidebarOverlay.prototype._endResizerDragging):
(WebInspector.SidebarOverlay.prototype._installResizer):
- inspector/front-end/Spectrum.js:
- inspector/front-end/SplitView.js:
(WebInspector.SplitView.prototype._startResizerDragging):
(WebInspector.SplitView.prototype._endResizerDragging):
(WebInspector.SplitView.prototype.installResizer):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabMouseDown):
(WebInspector.TabbedPaneTab.prototype._startTabDragging):
(WebInspector.TabbedPaneTab.prototype._endTabDragging):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._leftResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._rightResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._moveWindow):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
- inspector/front-end/UIUtils.js:
(WebInspector.installDragHandle):
(WebInspector._elementDragStart):
(WebInspector._elementDragEnd):
- inspector/front-end/timelinePanel.css:
(#timeline-overview-grid .resources-dividers-label-bar):
- 1:08 AM Changeset in webkit [123312] by
-
- 6 edits in trunk
ComposedShadowTreeWalker should skip an empty insertion points.
https://bugs.webkit.org/show_bug.cgi?id=91826
Reviewed by Hajime Morita.
Source/WebCore:
ComposedShadowTreeWalker wrongly returns 'null' if it encounters
an insertion point into where no nodes are distributed. We should
skip such an insertion point and continue walking using the next
possible node, which might be a next sibling or a next distributed
node, and resolve the next node recursively.
Test: fast/dom/shadow/composed-shadow-tree-walker.html
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseLightChildren):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseSiblings):
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseDistributedeNodes):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseBackToYoungerShadowRoot):
- dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker):
LayoutTests:
- fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
- fast/dom/shadow/composed-shadow-tree-walker.html:
- 1:06 AM Changeset in webkit [123311] by
-
- 3 edits2 moves in trunk/Source/WebCore
Rename TextCodecWinCE to TextCodecWin
https://bugs.webkit.org/show_bug.cgi?id=91947
Reviewed by Ryosuke Niwa.
Since TextCodecWinCE is used by other (non-upstreamed) windows ports too,
TextCodecWin is a better name for the implementation.
Also remove the dependency on WinCE FontCache to make it more usable.
- PlatformWinCE.cmake:
- platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps):
- platform/text/win/TextCodecWin.cpp: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.cpp.
- platform/text/win/TextCodecWin.h: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.h.
- 1:00 AM Changeset in webkit [123310] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip the new failing tests.
- platform/qt/Skipped:
- 12:53 AM Changeset in webkit [123309] by
-
- 3 edits in trunk/LayoutTests
Improve AudioChannelSplitter test
https://bugs.webkit.org/show_bug.cgi?id=91962
Patch by Li Yin <li.yin@intel.com> on 2012-07-23
Reviewed by Kentaro Hara.
Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section
The numberOfOutputs parameter determines the number of outputs.
Values of up to 32 must be supported. If not specified, then 6 will be used.
- webaudio/audiochannelsplitter-expected.txt:
- webaudio/audiochannelsplitter.html:
Jul 22, 2012:
- 9:55 PM Changeset in webkit [123308] by
-
- 8 edits in trunk/Source/WebCore
[V8] CodeGeneratorV8.pm should support static attributes
https://bugs.webkit.org/show_bug.cgi?id=91764
Reviewed by Adam Barth.
CodeGeneratorJS.pm already supports static attributes.
CodeGeneratorV8.pm should also support them.
Tests: bindings/scripts/test/TestObj.idl
bindings/scripts/test/TestSupplemental.idl
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
- bindings/scripts/test/TestObj.idl: Added defined(TESTING_V8).
- bindings/scripts/test/TestSupplemental.idl: Added test cases for static attributes in supplemental IDL files.
- bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.
(WebCore):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
The generated code is wrong since CodeGeneratorJS.pm does not support static attributes for
supplemental IDL files. I will fix it in a follow-up patch.
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp: Updated run-bindings-tests results.
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::staticReadOnlyIntAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore):
- 8:55 PM Changeset in webkit [123307] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium-Mac] Fix a build error.
- DEPS: Add third_party/GTM.
- 8:33 PM FeatureFlags edited by
- Rename some flags to _ELEMENT (diff)
- 7:11 PM Changeset in webkit [123306] by
-
- 3 edits in trunk/LayoutTests
Improve BiquadFilterNode test case
https://bugs.webkit.org/show_bug.cgi?id=90937
Patch by Li Yin <li.yin@intel.com> on 2012-07-22
Reviewed by Kentaro Hara.
Spec: http://www.w3.org/TR/webaudio/#BiquadFilterNode
Improve BiquadFilterNode test to cover constant value and number of inputs and outputs.
- webaudio/biquadfilternode-basic-expected.txt:
- webaudio/biquadfilternode-basic.html:
- 6:27 PM Changeset in webkit [123305] by
-
- 10 edits in trunk/Source/WebCore
Missing *explicit* keyword in storage and workers.
https://bugs.webkit.org/show_bug.cgi?id=91934
Reviewed by Kentaro Hara.
Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.
No new tests. Convered by existing tests.
- storage/StorageAreaImpl.h:
(StorageAreaImpl):
- storage/StorageMap.h:
(StorageMap):
- storage/StorageSyncManager.h:
(StorageSyncManager):
- storage/StorageTask.h:
(StorageTask):
- storage/StorageTracker.h:
(StorageTracker):
- workers/SharedWorker.h:
(SharedWorker):
- workers/Worker.h:
(Worker):
- workers/WorkerLocation.h:
(WebCore::WorkerLocation::WorkerLocation):
- workers/WorkerMessagingProxy.h:
(WorkerMessagingProxy):
- 6:17 PM Changeset in webkit [123304] by
-
- 48 edits in trunk/LayoutTests/platform
Unreviewed. Set missing SVN property svn:mime-type=image/png to PNG files in
/LayoutTests/fast/forms/ and LayoutTests/platfrom/*fast/forms
- 6:08 PM Changeset in webkit [123303] by
-
- 3 edits in trunk
Unreviewed, rolling out r123298 and r123301.
http://trac.webkit.org/changeset/123298
http://trac.webkit.org/changeset/123301
https://bugs.webkit.org/show_bug.cgi?id=91953
We need to think some more about the intricacies of exposing a
CMake option for ENABLE_DFG_JIT as this option is specific to
the port and architecture. (Requested by dydx on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-22
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- 6:00 PM Changeset in webkit [123302] by
-
- 11 edits98 moves in trunk/LayoutTests
[Tests] Rename fast/forms/number/*.html to number-*.html
https://bugs.webkit.org/show_bug.cgi?id=91806
Reviewed by Kent Tamura.
This patch renames test scripts and expected text/images to same
naming scheme(name starts with "number-"), for fast/forms/number.
This patch also updates TestExpectations and Skipped files in platform
directory for test name change.
This patch is a part of forms input type test arrangement.
https://bugs.webkit.org/show_bug.cgi?id=91805
- fast/forms/number/ValidityState-rangeOverflow-number-expected.txt: Removed.
- fast/forms/number/ValidityState-rangeOverflow-number.html: Removed.
- fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt: Removed.
- fast/forms/number/ValidityState-rangeUnderflow-number.html: Removed.
- fast/forms/number/ValidityState-stepMismatch-number-expected.txt: Removed.
- fast/forms/number/ValidityState-stepMismatch-number.html: Removed.
- fast/forms/number/ValidityState-typeMismatch-number-expected.txt: Removed.
- fast/forms/number/ValidityState-typeMismatch-number.html: Removed.
- fast/forms/number/input-appearance-number-rtl.html: Removed.
- fast/forms/number/input-appearance-spinbutton-disabled-readonly.html: Removed.
- fast/forms/number/input-appearance-spinbutton-layer.html: Removed.
- fast/forms/number/input-appearance-spinbutton-visibility-expected.html: Removed.
- fast/forms/number/input-appearance-spinbutton-visibility.html: Removed.
- fast/forms/number/input-number-blur-twice-expected.txt: Removed.
- fast/forms/number/input-number-blur-twice.html: Removed.
- fast/forms/number/input-number-change-type-on-focus-expected.txt: Removed.
- fast/forms/number/input-number-change-type-on-focus.html: Removed.
- fast/forms/number/input-number-commit-valid-only-expected.txt: Removed.
- fast/forms/number/input-number-commit-valid-only.html: Removed.
- fast/forms/number/input-number-crash-expected.txt: Removed.
- fast/forms/number/input-number-crash.html: Removed.
- fast/forms/number/input-number-events-expected.txt: Removed.
- fast/forms/number/input-number-events.html: Removed.
- fast/forms/number/input-number-keyoperation-expected.txt: Removed.
- fast/forms/number/input-number-keyoperation.html: Removed.
- fast/forms/number/input-number-large-padding-expected.txt: Removed.
- fast/forms/number/input-number-large-padding.html: Removed.
- fast/forms/number/input-number-outofrange-expected.txt: Removed.
- fast/forms/number/input-number-outofrange.html: Removed.
- fast/forms/number/input-number-size-expected.txt: Removed.
- fast/forms/number/input-number-size.html: Removed.
- fast/forms/number/input-number-spinbutton-crash-expected.txt: Removed.
- fast/forms/number/input-number-spinbutton-crash.html: Removed.
- fast/forms/number/input-number-unacceptable-style-expected.txt: Removed.
- fast/forms/number/input-number-unacceptable-style.html: Removed.
- fast/forms/number/input-number-validation-message-expected.txt: Removed.
- fast/forms/number/input-number-validation-message.html: Removed.
- fast/forms/number/input-number-wheel-expected.txt: Removed.
- fast/forms/number/input-number-wheel.html: Removed.
- fast/forms/number/input-spinbutton-capturing-expected.txt: Removed.
- fast/forms/number/input-spinbutton-capturing.html: Removed.
- fast/forms/number/input-valueasnumber-number-expected.txt: Removed.
- fast/forms/number/input-valueasnumber-number.html: Removed.
- fast/forms/number/number-appearance-rtl.html: Copied from LayoutTests/fast/forms/number/input-appearance-number-rtl.html.
- fast/forms/number/number-appearance-spinbutton-disabled-readonly.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-disabled-readonly.html.
- fast/forms/number/number-appearance-spinbutton-layer.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-layer.html.
- fast/forms/number/number-appearance-spinbutton-visibility-expected.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-visibility-expected.html.
- fast/forms/number/number-appearance-spinbutton-visibility.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-visibility.html.
- fast/forms/number/number-blur-twice-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-blur-twice-expected.txt.
- fast/forms/number/number-blur-twice.html: Copied from LayoutTests/fast/forms/number/input-number-blur-twice.html.
- fast/forms/number/number-change-type-on-focus-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-change-type-on-focus-expected.txt.
- fast/forms/number/number-change-type-on-focus.html: Copied from LayoutTests/fast/forms/number/input-number-change-type-on-focus.html.
- fast/forms/number/number-commit-valid-only-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-commit-valid-only-expected.txt.
- fast/forms/number/number-commit-valid-only.html: Copied from LayoutTests/fast/forms/number/input-number-commit-valid-only.html.
- fast/forms/number/number-crash-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-crash-expected.txt.
- fast/forms/number/number-crash.html: Copied from LayoutTests/fast/forms/number/input-number-crash.html.
- fast/forms/number/number-events-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-events-expected.txt.
- fast/forms/number/number-events.html: Copied from LayoutTests/fast/forms/number/input-number-events.html.
- fast/forms/number/number-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-keyoperation-expected.txt.
- fast/forms/number/number-keyoperation.html: Copied from LayoutTests/fast/forms/number/input-number-keyoperation.html.
- fast/forms/number/number-large-padding-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-large-padding-expected.txt.
- fast/forms/number/number-large-padding.html: Copied from LayoutTests/fast/forms/number/input-number-large-padding.html.
- fast/forms/number/number-outofrange-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-outofrange-expected.txt.
- fast/forms/number/number-outofrange.html: Copied from LayoutTests/fast/forms/number/input-number-outofrange.html.
- fast/forms/number/number-size-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-size-expected.txt.
- fast/forms/number/number-size.html: Copied from LayoutTests/fast/forms/number/input-number-size.html.
- fast/forms/number/number-spinbutton-capturing-expected.txt: Copied from LayoutTests/fast/forms/number/input-spinbutton-capturing-expected.txt.
- fast/forms/number/number-spinbutton-capturing.html: Copied from LayoutTests/fast/forms/number/input-spinbutton-capturing.html.
- fast/forms/number/number-spinbutton-crash-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-spinbutton-crash-expected.txt.
- fast/forms/number/number-spinbutton-crash.html: Copied from LayoutTests/fast/forms/number/input-number-spinbutton-crash.html.
- fast/forms/number/number-spinbutton-events-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-events-expected.txt.
- fast/forms/number/number-spinbutton-events.html: Copied from LayoutTests/fast/forms/number/spin-button-events.html.
- fast/forms/number/number-spinbutton-gets-disabled-or-readonly-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt.
- fast/forms/number/number-spinbutton-gets-disabled-or-readonly.html: Copied from LayoutTests/fast/forms/number/spin-button-gets-disabled-or-readonly.html.
- fast/forms/number/number-spinbutton-in-multi-column-expected.txt: Copied from LayoutTests/fast/forms/number/spin-in-multi-column-expected.txt.
- fast/forms/number/number-spinbutton-in-multi-column.html: Copied from LayoutTests/fast/forms/number/spin-in-multi-column.html.
- fast/forms/number/number-spinbutton-state-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-state-expected.txt.
- fast/forms/number/number-spinbutton-state.html: Copied from LayoutTests/fast/forms/number/spin-button-state.html.
- fast/forms/number/number-unacceptable-style-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-unacceptable-style-expected.txt.
- fast/forms/number/number-unacceptable-style.html: Copied from LayoutTests/fast/forms/number/input-number-unacceptable-style.html.
- fast/forms/number/number-validation-message-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-validation-message-expected.txt.
- fast/forms/number/number-validation-message.html: Copied from LayoutTests/fast/forms/number/input-number-validation-message.html.
- fast/forms/number/number-validity-state-range-underflow-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt.
- fast/forms/number/number-validity-state-range-underflow.html: Copied from LayoutTests/fast/forms/number/ValidityState-rangeUnderflow-number.html.
- fast/forms/number/number-validity-state-step-mismatch-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-stepMismatch-number-expected.txt.
- fast/forms/number/number-validity-state-step-mismatch.html: Copied from LayoutTests/fast/forms/number/ValidityState-stepMismatch-number.html.
- fast/forms/number/number-validity-state-type-mismatch-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-typeMismatch-number-expected.txt.
- fast/forms/number/number-validity-state-type-mismatch.html: Copied from LayoutTests/fast/forms/number/ValidityState-typeMismatch-number.html.
- fast/forms/number/number-validitystate-range-overflow-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-rangeOverflow-number-expected.txt.
- fast/forms/number/number-validitystate-range-overflow.html: Copied from LayoutTests/fast/forms/number/ValidityState-rangeOverflow-number.html.
- fast/forms/number/number-valueasnumber-expected.txt: Copied from LayoutTests/fast/forms/number/input-valueasnumber-number-expected.txt.
- fast/forms/number/number-valueasnumber.html: Copied from LayoutTests/fast/forms/number/input-valueasnumber-number.html.
- fast/forms/number/number-wheel-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-wheel-expected.txt.
- fast/forms/number/number-wheel.html: Copied from LayoutTests/fast/forms/number/input-number-wheel.html.
- fast/forms/number/spin-button-events-expected.txt: Removed.
- fast/forms/number/spin-button-events.html: Removed.
- fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt: Removed.
- fast/forms/number/spin-button-gets-disabled-or-readonly.html: Removed.
- fast/forms/number/spin-button-state-expected.txt: Removed.
- fast/forms/number/spin-button-state.html: Removed.
- fast/forms/number/spin-in-multi-column-expected.txt: Removed.
- fast/forms/number/spin-in-multi-column.html: Removed.
- platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-linux/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt.
- platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
- platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/efl/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/efl/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt.
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
- platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/gtk/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt.
- platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
- platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
- platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/mac/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/mac/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt.
- platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
- platform/qt-4.8/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.txt.
- platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
- platform/qt-arm/TestExpectations:
- platform/qt-mac/Skipped:
- platform/qt/Skipped:
- platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
- platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
- platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
- platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
- platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
- platform/qt/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png.
- platform/qt/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt.
- platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
- platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
- platform/win-wk2/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 5:00 PM Changeset in webkit [123301] by
-
- 2 edits in trunk
Fix the Windows CE build after <http://trac.webkit.org/changeset/123298>
(https://bugs.webkit.org/show_bug.cgi?id=91939)
Disable the DFG JIT across all CMake ports (by default) (*). Enabling DFG JIT
breaks the Windows CE build as the Windows CE port builds with the JIT disabled
(ENABLE_JIT := 0) and hence ENABLE_ASSEMBLER := 0.
(*) We should look to further discuss with CMake port maintainers about enabling
the DFG JIT by default.
- Source/cmake/WebKitFeatures.cmake:
- 4:23 PM Changeset in webkit [123300] by
-
- 77 edits in trunk
Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
https://bugs.webkit.org/show_bug.cgi?id=91941
Reviewed by Kentaro Hara.
A flag name for an elmement should be ENABLE_*_ELEMENT.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
- accessibility/AccessibilityProgressIndicator.cpp:
- accessibility/AccessibilityProgressIndicator.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/html.css:
- html/HTMLMeterElement.cpp:
- html/HTMLMeterElement.h:
- html/HTMLMeterElement.idl:
- html/HTMLProgressElement.cpp:
- html/HTMLProgressElement.h:
- html/HTMLProgressElement.idl:
- html/HTMLTagNames.in:
- html/shadow/MeterShadowElement.cpp:
- html/shadow/MeterShadowElement.h: Wrap with #if ENABLE(METER_ELEMENT).
- html/shadow/ProgressShadowElement.cpp:
- html/shadow/ProgressShadowElement.h: Wrap with #if ENABLE(PROGRESS_ELEMENT).
- page/DOMWindow.idl:
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore):
- platform/gtk/RenderThemeGtk.h:
(RenderThemeGtk):
- platform/gtk/RenderThemeGtk2.cpp:
(WebCore):
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore):
- platform/qt/RenderThemeQt.cpp:
(WebCore):
- platform/qt/RenderThemeQt.h:
(WebCore):
(RenderThemeQt):
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore):
- platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
- rendering/RenderMeter.cpp:
- rendering/RenderMeter.h:
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderProgress.cpp:
- rendering/RenderProgress.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore):
- rendering/RenderTheme.h:
(WebCore):
(RenderTheme):
- rendering/RenderThemeChromiumLinux.cpp:
(WebCore):
- rendering/RenderThemeChromiumLinux.h:
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore):
- rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore):
- rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):
- rendering/RenderThemeMac.h:
(RenderThemeMac):
- rendering/RenderThemeMac.mm:
(WebCore):
Source/WebKit:
- PlatformEfl.cmake:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/efl:
- DefaultTheme/default.edc:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/qt:
- WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore):
- WebCoreSupport/RenderThemeQStyle.h:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
- fast/dom/wrapper-classes.html:
- 11:06 AM Changeset in webkit [123299] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Shamed into removing some BUGSENORBLANCOs from previous gardening
stints.
- platform/chromium/TestExpectations:
- 9:36 AM Changeset in webkit [123298] by
-
- 3 edits in trunk
[CMake] Add option for ENABLE_DFG_JIT
https://bugs.webkit.org/show_bug.cgi?id=91939
Reviewed by Daniel Bates.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- 9:24 AM Changeset in webkit [123297] by
-
- 7 edits in trunk/LayoutTests
[chromium] Test result gardening; unreviewed.
- platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium/TestExpectations:
- 3:59 AM Changeset in webkit [123296] by
-
- 31 edits in trunk
Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=91928
Reviewed by Kentaro Hara.
A flag name for an elmement should be ENABLE_*_ELEMENT.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- html/HTMLDetailsElement.cpp:
- html/HTMLDetailsElement.idl:
- html/HTMLSummaryElement.cpp:
- html/HTMLTagNames.in:
- html/shadow/DetailsMarkerControl.cpp:
- rendering/RenderDetailsMarker.cpp:
- rendering/RenderDetailsMarker.h:
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 1:04 AM Changeset in webkit [123295] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening, adding baselines for the media/controls-styling-strict.html
test and skip a subpixel layout test that's crashing on debug builds (the
feature is disabled at the moment so the failure is somewhat acceptable).
- platform/gtk/TestExpectations:
- platform/gtk/media/controls-styling-strict-expected.png: Added.
- platform/gtk/media/controls-styling-strict-expected.txt: Added.