Context Navigation

← Previous Period
Next Period →

Timeline

Jul 27, 2012:

11:55 PM Changeset in webkit [123957] by pkasting@chromium.org

2 edits in trunk/Source/WebKit/chromium

Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=92318

Unreviewed, making bots happier.

tests/WebViewTest.cpp:

11:55 PM Changeset in webkit [123956] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[WebGL] Align contents of drawbuffer-test.html layout test with the one in the WebGL conformance suite.
https://bugs.webkit.org/show_bug.cgi?id=92375

Patch by Nayan Kumar K <nayankk@motorola.com> on 2012-07-27
Reviewed by Kenneth Russell.

fast/canvas/webgl/drawingbuffer-test-expected.txt:
fast/canvas/webgl/drawingbuffer-test.html:

11:16 PM Changeset in webkit [123955] by pkasting@chromium.org

2 edits in trunk/LayoutTests

Chromium rebaseline after r123285.
https://bugs.webkit.org/show_bug.cgi?id=90624

Unreviewed, rebaselining.

platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:

11:11 PM Changeset in webkit [123954] by msaboff@apple.com

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=92573
Mac Lion: http/tests/misc/submit-post-keygen.html fails on buildbots

platform/mac-lion/Skipped:

11:00 PM Changeset in webkit [123953] by commit-queue@webkit.org

8 edits in trunk

[EFL] Support for HTML media capture
https://bugs.webkit.org/show_bug.cgi?id=91842

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-27
Reviewed by Ryosuke Niwa.

Add HTML media capture feature, and enable that on the Efl port.

Source/cmake/OptionsEfl.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Tools:

Add HTML media capture feature to the feature list.
In addition, enable that on the Efl port.

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove file-input-capture.html from skipped list.

platform/efl/Skipped:

10:48 PM Changeset in webkit [123952] by commit-queue@webkit.org

16 edits
2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r123908.
http://trac.webkit.org/changeset/123908
https://bugs.webkit.org/show_bug.cgi?id=92572

Broke Chromium Linux compile (Requested by pkasting on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27

WebCore.gypi:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSValueKeywords.in:
css/mediaControls.css:
css/mediaControlsChromiumAndroid.css:

(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):

html/shadow/MediaControlElements.cpp:

(WebCore):

html/shadow/MediaControlElements.h:

(WebCore):

html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlChromiumEnclosureElement::create):
(WebCore):
(WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromium::create):

html/shadow/MediaControlRootElementChromium.h:

(MediaControlChromiumEnclosureElement):
(MediaControlRootElementChromium):

html/shadow/MediaControlRootElementChromiumAndroid.cpp: Removed.
html/shadow/MediaControlRootElementChromiumAndroid.h: Removed.
platform/ThemeTypes.h:
rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

rendering/RenderTheme.h:
rendering/RenderThemeChromiumAndroid.cpp:
rendering/RenderThemeChromiumAndroid.h:

10:12 PM Changeset in webkit [123951] by pkasting@chromium.org

2 edits in trunk/LayoutTests

Mark three tests as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=92570

Unreviewed, Chromium test expectations update.

platform/chromium/TestExpectations:

9:30 PM Changeset in webkit [123950] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[BlackBerry] Use new LocaleHandler.
https://bugs.webkit.org/show_bug.cgi?id=92548

Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li.

RIM PR 128381

platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::platformLanguage):

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp:

(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):

9:29 PM Changeset in webkit [123949] by pkasting@chromium.org

2 edits in trunk/LayoutTests

Fix broken script reference after test move.
https://bugs.webkit.org/show_bug.cgi?id=92111

Unreviewed, fixing bad test move.

platform/win/fast/events/panScroll-click-hyperlink.html:

9:20 PM Changeset in webkit [123948] by pkasting@chromium.org

1 edit
8 adds in trunk/LayoutTests

Chromium rebaselines after r123912.
https://bugs.webkit.org/show_bug.cgi?id=92327

Unreviewed, rebaselining.

platform/chromium-linux-x86/fast/hidpi: Added.
platform/chromium-linux-x86/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
platform/chromium-linux/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
platform/chromium-mac-snowleopard/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
platform/chromium-win-xp/fast/hidpi: Added.
platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.

9:12 PM Changeset in webkit [123947] by pkasting@chromium.org

2 edits in trunk/LayoutTests

Chromium rebaseline after r123706.
https://bugs.webkit.org/show_bug.cgi?id=92236

Unreviewed, rebaselining.

platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:

8:19 PM Changeset in webkit [123946] by pkasting@chromium.org

1 edit
10 adds in trunk/LayoutTests

Chromium rebaselines after r123790.
https://bugs.webkit.org/show_bug.cgi?id=92059

Unreviewed, rebaselining.

platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-expected.txt: Added.
platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.txt: Added.
platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
platform/chromium-win-xp/css3: Added.
platform/chromium-win-xp/css3/filters: Added.
platform/chromium-win-xp/css3/filters/effect-brightness-clamping-expected.txt: Added.
platform/chromium-win-xp/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-brightness-clamping-expected.txt: Added.
platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.

6:23 PM Changeset in webkit [123945] by commit-queue@webkit.org

32 edits in trunk/Source/WebCore

Change constructor with explicit constructor in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=92529

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit
type conversion.

No new tests. Covered by existing tests.

Modules/filesystem/LocalFileSystem.h:

(WebCore::LocalFileSystem::LocalFileSystem):

Modules/filesystem/Metadata.h:

(WebCore::Metadata::Metadata):

Modules/filesystem/SyncCallbackHelper.h:

(WebCore::SyncCallbackHelper::SuccessCallbackImpl::SuccessCallbackImpl):
(WebCore::SyncCallbackHelper::ErrorCallbackImpl::ErrorCallbackImpl):

Modules/mediastream/IceCandidate.h:

(IceCandidate):

Modules/mediastream/NavigatorUserMediaError.h:

(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):

Modules/mediastream/SessionDescription.h:

(SessionDescription):

Modules/mediastream/UserMediaController.h:

(UserMediaController):

Modules/notifications/NotificationController.h:

(NotificationController):

Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

Modules/speech/SpeechRecognitionController.h:

(SpeechRecognitionController):

Modules/speech/SpeechRecognitionEvent.h:

(SpeechRecognitionEvent):

Modules/speech/SpeechRecognitionResultList.h:

(SpeechRecognitionResultList):

Modules/vibration/Vibration.h:

(Vibration):

Modules/webaudio/AudioBuffer.h:

(AudioBuffer):

Modules/webaudio/AudioContext.h:

(AudioContext):

Modules/webaudio/AudioNodeInput.h:

(AudioNodeInput):

Modules/webaudio/AudioSummingJunction.h:

(AudioSummingJunction):

Modules/webaudio/BiquadDSPKernel.h:

(WebCore::BiquadDSPKernel::BiquadDSPKernel):

Modules/webaudio/DefaultAudioDestinationNode.h:

(DefaultAudioDestinationNode):

Modules/webaudio/DelayDSPKernel.h:

(DelayDSPKernel):

Modules/webaudio/OfflineAudioCompletionEvent.h:

(OfflineAudioCompletionEvent):

Modules/webaudio/WaveShaperDSPKernel.h:

(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):

Modules/webaudio/WaveShaperNode.h:

(WaveShaperNode):

Modules/webaudio/WaveTable.h:

(WaveTable):

Modules/webdatabase/DatabaseAuthorizer.h:

(DatabaseAuthorizer):

Modules/webdatabase/DatabaseTask.h:

(Database::DatabaseTransactionTask):

Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

Modules/webdatabase/SQLException.h:

(WebCore::SQLException::SQLException):

Modules/websockets/WebSocket.h:
Modules/websockets/WebSocketExtensionProcessor.h:

(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):

6:21 PM Changeset in webkit [123944] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[V8] Optimize Element::getAttributeNS() by replacing String with AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90276

Patch by Kentaro Hara <haraken@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

In r121439, we changed the argument type of Element::getAttribute()
from String to AtomicString for optimization. This patch changes the
argument type of Element::getAttributeNS() from String to AtomicString.

Actually this change affects V8 performance only.

[JSC without the patch]
The binding code converts a given JavaScript string to a String
-> the String is passed to getAttributeNS()
-> the String is converted to an AtomicString when it is passed to
QualifiedName() constructor.

[JSC with the patch]
The binding code converts a given JavaScript string to a String
-> the String is converted to an AtomicString when it is passed to
getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.

[V8 without the patch]
The binding code retrieves a cached external String for a given
JavaScript string
-> the String is passed to getAttributeNS()
-> the String is converted to AtomicString when it is passed to
QualifiedName() constructor.

[V8 with the patch]
The binding code retrieves a cached external AtomicString for a given
JavaScript string
-> the AtomicString is passed to getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.

In this way, in JSC, the change affects where a String is converted to
an AtomicString. On the other hand, in V8, (since the AtomicString is already
cached,) we can skip the conversion step.

Performance test: https://bugs.webkit.org/attachment.cgi?id=150158

getAttributeNS (Chromium/Linux):
577.80ms => 454.60ms

dom/Element.cpp:

(WebCore::Element::getAttributeNS):

dom/Element.h:

(Element):

6:02 PM Changeset in webkit [123943] by commit-queue@webkit.org

12 edits in trunk/Source

Unreviewed, rolling out r123679.
http://trac.webkit.org/changeset/123679
https://bugs.webkit.org/show_bug.cgi?id=92565

Slowed down HTML parsing by 3.6% (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27

Source/WebCore:

html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append):

html/parser/HTMLEntityParser.cpp:

(WebCore::HTMLEntityParser::consumeNamedEntity):

html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):

html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceSlowCase):
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):

platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(WebCore::SegmentedSubstring::appendTo):
(SegmentedSubstring):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(SegmentedString):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::operator*):
(WebCore::SegmentedString::operator->):
(WebCore::SegmentedString::current):
(WebCore::SegmentedString::equalsLiterally):
(WebCore::SegmentedString::equalsIgnoringCase):
(WebCore::SegmentedString::lookAheadInline):
(WebCore::SegmentedString::lookAheadSlowCase):

xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference):

xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

wtf/text/WTFString.h:

5:41 PM Changeset in webkit [123942] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

Reset the set of "seen" plugins when the main frame load is committed.
https://bugs.webkit.org/show_bug.cgi?id=92564

Reviewed by Anders Carlsson.

Because the Page object is re-used across navigation and reload, reset the list
of seen plugins when the main frame load commits. This gives a good baseline to
compare against the number of pages loaded.

No new tests; the "seen" plugin list is for diagnostic purposes only.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad):

page/Page.cpp:

(WebCore::Page::resetSeenPlugins):

page/Page.h:

5:34 PM Changeset in webkit [123941] by dpranke@chromium.org

3 edits in trunk/Tools

"webkit-patch rebaseline <test>" fails with exit_code 1
https://bugs.webkit.org/show_bug.cgi?id=91560

Reviewed by Adam Barth.

webkit-patch rebaseline-json crashes in an svn checkout if it
tries to add files and there are no files to add; arguably
svn.add() should be robust against this, but rebaseline-json
shouldn't be calling it, either. This patch fixes the latter and
adds better debugging info to garden-o-matic so we can see what
caused the crash.

Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractParallelRebaselineCommand._rebaseline):

Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaselineall):
(GardeningHTTPRequestHandler.rebaselineall.error_handler):
(GardeningHTTPRequestHandler):

5:32 PM Changeset in webkit [123940] by commit-queue@webkit.org

3 edits
2 adds in trunk

execCommand copies the backgroung-color of the enclosing element to the element being edited.
https://bugs.webkit.org/show_bug.cgi?id=91783

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

InsertListCommand and some other edit commands remove redundant
style properties after their DOM modification by using
StylePropertySet::removeEquivalentProperties. However, this method
does not remove redundant background-color properties such as
"background-color: white" and "background-color: #fff" because
it compares them using cssText and thus treats them as different.
Add code to convert background colors to RGBA and then compare them.

Test: editing/style/redundant-background-color.html

editing/EditingStyle.cpp:

(WebCore::getRGBABackgroundColor):
(WebCore):
(WebCore::getPropertiesNotIn):

LayoutTests:

This tests to make sure that WebKit removes redundant "background-color"
property after execCommand.

editing/style/redundant-background-color-expected.txt: Added.
editing/style/redundant-background-color.html: Added.

5:30 PM Changeset in webkit [123939] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] Return 0 when network is offline
https://bugs.webkit.org/show_bug.cgi?id=92454

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Network Info latest spec says 0 is returned when network is offline.
r123769 modified to return infinity value when network is offiline.

platform/efl/NetworkInfoProviderEfl.cpp:

(WebCore::NetworkInfoProviderEfl::bandwidth):

5:08 PM Changeset in webkit [123938] by rniwa@webkit.org

5 edits in trunk

Unreviewed perf-o-matic build fix for dashboard image generation.
Also, only show Parser/html5-full-render on the dashboard by default
so that it won't take forever to load it.

Websites/webkit-perf.appspot.com/controller.py:

(schedule_runs_update):
(RunsChartHandler.post):

Websites/webkit-perf.appspot.com/models.py:

(Runs.chart_params):
(DashboardImage.get_image):

Websites/webkit-perf.appspot.com/models_unittest.py:

(RunsTest.test_chart_params_with_value):

4:51 PM Changeset in webkit [123937] by commit-queue@webkit.org

13 edits in trunk

Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
https://bugs.webkit.org/show_bug.cgi?id=92533

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

Source/WebCore:

Per discussion on public-webapps. Pages that enumerate navigator were
causing background resources to be created to poll hardware
unintentionally. By changing to an explicit function call, this is
avoided (and the API becomes more clear too). This change updates the
implementation to match the current ED spec.

Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::webkitGetGamepads):

Modules/gamepad/NavigatorGamepad.h:

(NavigatorGamepad):

Modules/gamepad/NavigatorGamepad.idl:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):

Source/WebKit/chromium:

Renames for updated access point.

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

LayoutTests:

Updates for renamed access point.

gamepad/gamepad-api-expected.txt:
gamepad/gamepad-api.html:
gamepad/gamepad-polling-access-expected.txt:
gamepad/gamepad-polling-access.html:
platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:

4:44 PM Changeset in webkit [123936] by beidson@apple.com

14 edits
3 adds in trunk

Plugins should not be allowed to override standard properties/attributes in non-standard worlds
<rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519

Reviewed by Anders Carlsson.

Source/WebCore:

Change the 3 plugin-owning element's custom bindings to prefer built-in properties if they exist.
When they do they don't give the plugin a chance to override.

Test: plugins/npruntime/overrides-all-properties.html

Add plugin custom functions to prefer built-in properties over plugin scriptable object properties:

bindings/js/JSPluginElementFunctions.h:

(WebCore::pluginElementCustomGetOwnPropertySlot):
(WebCore::pluginElementCustomGetOwnPropertyDescriptor):

Use those new custom functions for getting properties:

bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):

bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):

bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):

Tools:

Add a test plugin which overrides all properties it is asked about:

DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.

(PluginScriptableObjectOverridesAllProperties):
(PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
(PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
(PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
(PluginScriptableObjectOverridesAllProperties::NPP_GetValue):

Expose NPN_MemAlloc to the test plugin:

DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_MemAlloc):

DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

(PluginTest):

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

LayoutTests:

plugins/npruntime/overrides-all-properties-expected.txt: Added.
plugins/npruntime/overrides-all-properties.html: Added.
platform/chromium/TestExpectations: Test behaves different in V8, so skip on chromium

4:32 PM Changeset in webkit [123935] by commit-queue@webkit.org

14 edits
3 adds in trunk

use createUninitialized when creating TypedArray from another array
https://bugs.webkit.org/show_bug.cgi?id=92518

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-27
Reviewed by Kenneth Russell.

PerformanceTests:

Bindings/typed-array-construct-from-array.html: Added.

Source/WebCore:

When creating a Typed Array from another array, we fill it with values
from the source array. So, we can create it uninitialized. This is
make constructor about 35% faster when constructed with another typed
array.

Test: fast/canvas/webgl/array-constructor.html

bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):

Source/WTF:

Expose a createUninitialized static method on TypedArray classes.

wtf/Float32Array.h:

(Float32Array):
(WTF::Float32Array::createUninitialized):
(WTF):

wtf/Float64Array.h:

(Float64Array):
(WTF::Float64Array::createUninitialized):
(WTF):

wtf/Int16Array.h:

(Int16Array):
(WTF::Int16Array::createUninitialized):
(WTF):

wtf/Int32Array.h:

(Int32Array):
(WTF::Int32Array::createUninitialized):
(WTF):

wtf/Int8Array.h:

(Int8Array):
(WTF::Int8Array::createUninitialized):
(WTF):

wtf/Uint16Array.h:

(Uint16Array):
(WTF::Uint16Array::createUninitialized):
(WTF):

wtf/Uint32Array.h:

(Uint32Array):
(WTF::Uint32Array::createUninitialized):
(WTF):

wtf/Uint8Array.h:

(Uint8Array):
(WTF::Uint8Array::createUninitialized):
(WTF):

wtf/Uint8ClampedArray.h:

(Uint8ClampedArray):

LayoutTests:

Add test to check that constructing a Typed Array with nan values does
not result in random values.

fast/canvas/webgl/array-constructor-expected.txt: Added.
fast/canvas/webgl/array-constructor.html: Added.

4:29 PM Changeset in webkit [123934] by commit-queue@webkit.org

4 edits in trunk/Source

[BlackBerry] Adapt to change in the FontInfo platform API.
https://bugs.webkit.org/show_bug.cgi?id=92547

Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li

RIM PR 161263

Source/WebCore:

page/blackberry/SettingsBlackBerry.cpp:

(WebCore::Settings::initializeDefaultFontFamilies):

Source/WebKit/blackberry:

Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

4:12 PM Changeset in webkit [123933] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Assertion hit in ewk_cookie_manager.cpp
https://bugs.webkit.org/show_bug.cgi?id=92544

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Removed wrong assertion in ewk_cookie_manager.cpp
and replace it by an if check. The assertion was
sometimes hit by our unit tests.

UIProcess/API/efl/ewk_cookie_manager.cpp:

(cookiesDidChange):

4:02 PM Changeset in webkit [123932] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Fix color matrix filter computation so that filters that don't need clamping are correctly detected as such
https://bugs.webkit.org/show_bug.cgi?id=92452

Patch by Antoine Labour <piman@chromium.org> on 2012-07-27
Reviewed by Stephen White.

Because of precision issues, some filters were returning true to
matrixNeedsClamping when they can return false. This fixes it.

No new tests in this CL, a follow-up change refactors the code to add
several tests.

platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

3:59 PM Changeset in webkit [123931] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Split functionality of MarkedAllocator::m_currentBlock
https://bugs.webkit.org/show_bug.cgi?id=92550

Reviewed by Filip Pizlo.

MarkedAllocator::m_currentBlock serves two purposes right now; it indicates the block that is currently
being used for allocation and the beginning of the list of blocks that need to be swept. We should split
these two functionalities into two separate fields.

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): Use m_blocksToSweep instead of m_currentBlock as the
initializer/reference of the loop. Only change m_currentBlock when we know what the result will be.
(JSC::MarkedAllocator::addBlock): When we add a new block we know that both m_blocksToSweep and
m_currentBlock are null. In order to preserve the invariant that m_currentBlock <= m_blocksToSweep,
we assign both of them to point to the new block.
(JSC::MarkedAllocator::removeBlock): We need a separate check to see if the block we're removing is
m_blocksToSweep and if so, advance it to the next block in the list.

heap/MarkedAllocator.h:

(MarkedAllocator): Initialize m_blocksToSweep.
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::reset): We set m_blocksToSweep to be the head of our list. This function is called
at the end of a collection, so all of the blocks in our allocator need to be swept. We need to sweep a
block before we can start allocating, so m_currentBlock is set to null. We also set the freeList to
the empty FreeList to emphasize the fact that we can't start allocating until we do some sweeping.

3:58 PM Changeset in webkit [123930] by jer.noble@apple.com

8 edits in trunk/Source/WebCore

Add diagnostic logging for plugins-per-page.
https://bugs.webkit.org/show_bug.cgi?id=92538

Reviewed by Anders Carlsson.

Add some diagnostic logging for whether a page has seen a plugin, and
whether a page has seen a plugin of a specific type.

Move the diagnostic logging out of the elemements themselves:

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

Instead, log when the plugin is requested, thereby catching plugins which are
rejected because, e.g., Java is disabled or not installed:

loader/SubframeLoader.cpp:

(WebCore::logPluginRequest):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::createJavaAppletWidget):

Add new diagnostic key values:

page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):

page/DiagnosticLoggingKeys.h:

Add a map of plugin types seen per-page for diagnostic purposes:

page/Page.cpp:

(WebCore::Page::hasSeenAnyPlugin):
(WebCore::Page::hasSeenPlugin):
(WebCore::Page::sawPlugin):

page/Page.h:

3:46 PM Changeset in webkit [123929] by commit-queue@webkit.org

4 edits in trunk/Source

[WINCE] Use macros from ICU instead of defining the same functionality again
https://bugs.webkit.org/show_bug.cgi?id=92530

Patch by Patrick Gansterer <Patrick Gansterer> on 2012-07-27
Reviewed by Ryosuke Niwa.

Replace isHighSurrogate() with U16_IS_LEAD(), isLowSurrogate() with
U16_IS_TRAIL() and surrogateToUcs4() with U16_GET_SUPPLEMENTARY().

Source/WebCore:

html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

Source/WTF:

wtf/unicode/wince/UnicodeWinCE.h:

3:41 PM Changeset in webkit [123928] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled
https://bugs.webkit.org/show_bug.cgi?id=92523

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-27
Reviewed by Simon Fraser.

Move #ifdef in CSSPrimitiveValueMappings.h to silent compilation warning
when CSS_STICKY_POSITION is disabled.

No new tests, no behavior change.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

3:37 PM Changeset in webkit [123927] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

DragController should ascertain dragClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92474

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Tony Chang.

The DragController must always ensure a valid dragClient object. Hence
adding the ASSERT to assure that.

No new tests. Added assertion for PageClient.dragClient.

page/DragController.cpp:

(WebCore::DragController::DragController):

3:30 PM Changeset in webkit [123926] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[chromium] Clean up LayerRendererChromium::drawTexturedQuad
https://bugs.webkit.org/show_bug.cgi?id=91823

Patch by Adrienne Walker <enne@google.com> on 2012-07-27
Reviewed by James Robinson.

LayerRendererChromium::drawTexturedQuad has been around forever and
over time has developed several problems:

Confusingly named relative to drawTextureQuad
All but one callers identically manipulate the transform matrix
Lots of optional parameters that only few functions use

This patch breaks up drawTexturedQuad into setShaderOpacity (for
optional opacity values sent to the shader), setShaderFloatQuad (the
full FloatQuad used by AA shaders), and drawQuadGeometry (actually
draw the geometry, and wrap the transform logic that was duplicated
everywhere).

No new tests; no change in functionality.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::setShaderFloatQuad):
(WebCore::LayerRendererChromium::setShaderOpacity):
(WebCore::LayerRendererChromium::drawQuadGeometry):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

3:20 PM Changeset in webkit [123925] by caio.oliveira@openbossa.org

2 edits in trunk/Source/WTF

[Qt] Fix build after r123917
https://bugs.webkit.org/show_bug.cgi?id=92555

Unreviewed.

wtf/GregorianDateTime.h: Needs string.h for memset().

3:10 PM Changeset in webkit [123924] by commit-queue@webkit.org

2 edits in trunk/Tools

"webkit-patch upload" should strip colors from patch if necessary
https://bugs.webkit.org/show_bug.cgi?id=92306

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-07-27
Reviewed by Adam Barth.

Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.

3:07 PM Changeset in webkit [123923] by caio.oliveira@openbossa.org

26 edits
2 deletes in trunk/LayoutTests

[Qt] Remaining rebaselines after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92552

Unreviewed.

Unskip a bunch of tests, organize the remaining skips. The mentions to bug 85203 were
removed now. A last batch of WK1 results were associated with the bug 91610.

platform/qt-5.0-wk1/Skipped:
platform/qt-5.0-wk2/Skipped:
platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt:
platform/qt-5.0/Skipped:
platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
platform/qt/editing/input/reveal-caret-of-multiline-input-expected.txt:
platform/qt/http/tests/cache/cancel-during-revalidation-succeeded-expected.txt: Removed.
platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
platform/qt/svg/text/select-x-list-1-expected.txt:
platform/qt/svg/text/select-x-list-2-expected.txt:
platform/qt/svg/text/select-x-list-3-expected.txt:
platform/qt/svg/text/select-x-list-4-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
platform/qt/svg/text/selection-doubleclick-expected.txt:

3:07 PM Changeset in webkit [123922] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r116357. <rdar://problem/11942044>

3:04 PM Changeset in webkit [123921] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] CCLayerTreeHost placeholder scissor should be deviceViewportSize instead of viewportSize
https://bugs.webkit.org/show_bug.cgi?id=92469

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-07-27
Reviewed by Adrienne Walker.

We were accidentally using viewportSize instead of
deviceViewportSize in a particular place in code. Recent
refactoring to use tighter scissor rects exposed this problem.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

2:56 PM Changeset in webkit [123920] by commit-queue@webkit.org

2 edits in trunk/Tools

clean-pending-commit throws exception when encountering Ossy
https://bugs.webkit.org/show_bug.cgi?id=92534

Patch by Eric Seidel <eric@webkit.org> on 2012-07-27
Reviewed by Adam Barth.

Mark a couple strings as unicode so that reviewers with unicode names do not cause
clean-pending-commit to barf.

Scripts/webkitpy/tool/commands/upload.py:

(CleanPendingCommit._flags_to_clear_on_patch):
(CleanPendingCommit.execute):
(AssignToCommitter._assign_bug_to_last_patch_attacher):

2:49 PM Changeset in webkit [123919] by commit-queue@webkit.org

3 edits
2 adds in trunk

Search cancel button is hard to activate with a tap gesture even if touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=91894

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.

Source/WebCore:

Update check for determining if a node responds to tap gestures.
Previously, the cancel button was being discarded as a candidate for
touch adjustment if the touch area clipped the text input region
because the candidate pruning process failed to account for the cancel
button having a default mouse handler. Possibly an interim fix,
depending on resolution to 92093.

Test: touchadjustment/search-cancel.html

page/TouchAdjustment.cpp:

(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):

LayoutTests:

Add test for touch adjustment in the vicinity of a search cancel button.
Prior to the patch, the cancel button was pruned as a candidate if the
touch area clipped the input field.

touchadjustment/search-cancel-expected.txt: Added.
touchadjustment/search-cancel.html: Added.

2:48 PM Changeset in webkit [123918] by dpranke@chromium.org

1 edit
1 add in trunk/Tools

chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549

Unreviewed, build fix.

It turns out that this file is listed in the chromium downstream
'browser_tests.isolate' file, and so deleting it broke gyp.
Adding a stub file back in until we can remove the entry from
the file.

Scripts/webkitpy/layout_tests/port/webkit.py: Added.

2:40 PM Changeset in webkit [123917] by Patrick Gansterer

2 edits in trunk/Source/WTF

MinGW build fails because of missing header in GregorianDateTime.h
https://bugs.webkit.org/show_bug.cgi?id=92531

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-07-27

wtf/GregorianDateTime.h: Include time.h

2:10 PM CommitterTips edited by peter@chromium.org

Clarify that new committers should manually commit the change to … (diff)

2:04 PM Changeset in webkit [123916] by dpranke@chromium.org

13 edits
2 deletes in trunk/Tools

nrwt: remove 'webkit.py' and the 'WebKitPort'
https://bugs.webkit.org/show_bug.cgi?id=92450

Reviewed by Ryosuke Niwa.

This patch finishes the work of merging WebKitPort into Port.
Now Port is way too big :).

This is all cutting and pasting; no new functionality and
no changes in the tests.

Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort):
(ApplePort.init):

Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_layout_tests):
(Port):
(Port._port_flag_for_scripts):
(Port._arguments_for_configuration):
(Port._run_script):
(Port._build_driver):
(Port._build_driver_flags):
(Port._tests_for_other_platforms):
(Port._runtime_feature_list):
(Port.nm_command):
(Port._modules_to_search_for_symbols):
(Port._symbols_string):
(Port._missing_feature_to_skipped_tests):
(Port._missing_symbol_to_skipped_tests):
(Port._has_test_in_directories):
(Port._skipped_tests_for_unsupported_features):
(Port._wk2_port_name):
(Port._skipped_file_search_paths):

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

Scripts/webkitpy/layout_tests/port/chromium_android.py:
Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_check_build):

Scripts/webkitpy/layout_tests/port/driver_unittest.py:
Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort):
(EflPort.init):

Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort):
(GtkPort.setup_environ_for_server):

Scripts/webkitpy/layout_tests/port/port_testcase.py:

(TestWebKitPort):
(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(TestWebKitPort._symbols_string):
(TestWebKitPort._tests_for_other_platforms):
(TestWebKitPort._tests_for_disabled_features):
(PortTestCase):
(PortTestCase.test_diff_image):
(PortTestCase.test_path_to_test_expectations_file):
(PortTestCase.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_directories_for_features_no_matching_tests_in_test_list):
(test_skipped_tests_for_unsupported_features_empty_test_list):
(test_skipped_layout_tests):
(test_skipped_file_search_paths):
(test_root_option):
(test_test_expectations):
(test_build_driver):
(_assert_config_file_for_platform):
(test_linux_distro_detection):
(test_apache_config_file_name_for_platform):
(test_path_to_apache_config_file):

Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.init):
(QtPort.setup_environ_for_server):

Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
Scripts/webkitpy/tool/servers/rebaselineserver.py:

(get_test_baselines.AllPlatformsPort):
(get_test_baselines.AllPlatformsPort.init):

Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config.TestMacPort):

1:48 PM Changeset in webkit [123915] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Don't use an NSUserDefault for disabling the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=92542
<rdar://problem/11976060>

Reviewed by Mark Rowe.

The user default was really helpful during WebKit2 bringup, but we no longer need to pay the IPC cost of initializing NSUserDefaults at startup,
so get rid of the preference and use a good old #ifdef instead.

WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

1:43 PM Changeset in webkit [123914] by commit-queue@webkit.org

4 edits
4 adds in trunk

Animated SVGs do not clear previous frame completely in hidpi mode.
https://bugs.webkit.org/show_bug.cgi?id=92395

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-27
Reviewed by Darin Adler.

Source/WebCore:

The rect thats is cleared in subsequent frames needed to be scaled with device scale.

Test: svg/as-image/animated-svg-repaints-completely-in-hidpi.html

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):

LayoutTests:

platform/chromium/TestExpectations:
platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
svg/as-image/animated-svg-repaints-completely-in-hidpi.html: Added.
svg/as-image/resources/animated-rect-fixed-size-3.svg: Added.

1:41 PM Changeset in webkit [123913] by mitz@apple.com

2 edits in trunk/Source/WebCore

Fix COMPILE_ASSERT for InlineFlowBox growing
https://bugs.webkit.org/show_bug.cgi?id=92541

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Dan Bernstein.

Use unsigned instead of bool to keep size small on Windows.

No new tests.

rendering/InlineFlowBox.h:

(InlineFlowBox):

1:33 PM Changeset in webkit [123912] by Beth Dakin

13 edits
3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=92327
-webkit-background-clip:text is blurry in WebKit 1 apps when
deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11683788>

Reviewed by Simon Fraser.

Source/WebCore:

The bug here is that the code to make createCompatibleBuffer() HiDPI-savvy
assumed that the deviceScaleFactor would always be baked into the CTM of the
GraphicsContext. But that is NOT the case in WebKit 1.

createCompatibleBuffer() is used for clip text and gradients.

Now getCTM() takes a parameter indicating whether the result should definitely
include the device scale, or if it should possibly included the device scale,
which is the option that matches old behavior.

platform/graphics/GraphicsContext.h:

(GraphicsContext):

platform/graphics/cairo/GraphicsContextCairo.cpp: