Context Navigation

← Previous Period
Next Period →

Timeline

Jul 29, 2012:

11:25 PM Changeset in webkit [123999] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

[WK2][EFL] Accelerated compositing support using TextureMapper on Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91583

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-29
Reviewed by Noam Rosenthal.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
This patch adds Texture Mapper related files to PlatformEfl.cmake.
And wrapped TextureMapperLayer and TextureMapperBackingStore with USE(ACCELERATED_COMPOSITING) for fixing building error when disable ACCELERATED_COMPOSITING.

CMakeLists.txt:
PlatformEfl.cmake:
platform/graphics/GraphicsLayer.cpp:

(WebCore):

platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

platform/graphics/GraphicsLayerAnimation.cpp:
platform/graphics/GraphicsLayerAnimation.h:
platform/graphics/PlatformLayer.h:

(WebCore):

platform/graphics/texmap/TextureMapperBackingStore.cpp:
platform/graphics/texmap/TextureMapperBackingStore.h:
platform/graphics/texmap/TextureMapperLayer.h:

11:09 PM Changeset in webkit [123998] by commit-queue@webkit.org

10 edits in trunk/Source

[WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91582

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-29
Reviewed by Noam Rosenthal.

Source/WebCore:

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
This patch adds TILED_BACKING_STORE related files to CMakeLists.txt and PlatformEfl.cmake

CMakeLists.txt:
PlatformEfl.cmake:

Source/WebKit/efl:

Add a dummy function for fixing building error when enabling TILED_BACKING_STORE.

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):
(WebCore::ChromeClientEfl::delegatedScrollRequested):

WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit2:

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Add a dummy function for fixing building error when enabling TILED_BACKING_STORE.

UIProcess/API/efl/PageClientImpl.cpp:

(WebKit):
(WebKit::PageClientImpl::pageDidRequestScroll):

UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

10:49 PM Changeset in webkit [123997] by keishi@webkit.org

3 edits in trunk/Source/WebCore

Fix removing invalid values from color input suggestions
https://bugs.webkit.org/show_bug.cgi?id=92502

Reviewed by Kent Tamura.

Make ColorInputType::typeMismatchFor() return false for invalid color
values so that they don't appear in the list of suggestions that
ColorInputType::suggestions() returns.

No new tests. Tests to be added in Bug 92075.

html/ColorInputType.cpp:

(WebCore::ColorInputType::typeMismatchFor):
(WebCore):

html/ColorInputType.h:

(ColorInputType):

10:28 PM Changeset in webkit [123996] by commit-queue@webkit.org

5 edits
2 adds in trunk

getChannelData should raise exception when index is more than numberOfChannels.
https://bugs.webkit.org/show_bug.cgi?id=92223

Patch by Li Yin <li.yin@intel.com> on 2012-07-29
Reviewed by Kentaro Hara.

Source/WebCore:

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBuffer-section
In getChannelData function, the index value MUST be less than numberOfChannels
or an exception will be thrown.

Test: webaudio/audiobuffer.html

Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::getChannelData):
(WebCore):

Modules/webaudio/AudioBuffer.h:

(WebCore):
(AudioBuffer):

Modules/webaudio/AudioBuffer.idl: raise exception when index is not less than numberOfChannels.

LayoutTests:

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBuffer-section
Add test to cover basic attributes of AudioBuffer.

webaudio/audiobuffer-expected.txt: Added.
webaudio/audiobuffer.html: Added.

10:22 PM Changeset in webkit [123995] by commit-queue@webkit.org

3 edits
2 adds in trunk

forward-delete in the last cell of a table moves the caret after the table
https://bugs.webkit.org/show_bug.cgi?id=24250

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-29
Reviewed by Ryosuke Niwa.

Source/WebCore:

The ForwardDelete command moved the cursor after the table when it's invoked
in an empty cell that is the last cell of a table. It also removed the break
element when invoked in an empty cell that is not the last cell of a table.
Make it do nothing inside an empty table cell.

Test: editing/deleting/forward-delete-empty-table-cell.html

editing/TypingCommand.cpp:

(WebCore::TypingCommand::forwardDeleteKeyPressed):

LayoutTests:

editing/deleting/forward-delete-empty-table-cell-expected.txt: Added.
editing/deleting/forward-delete-empty-table-cell.html: Added.

10:17 PM Changeset in webkit [123994] by tkent@chromium.org

3 edits in trunk/LayoutTests

REGRESSION(r123993): fast/forms/date/calendar-picker-type-change-onclick.html fails

fast/forms/date/calendar-picker-appearance-expected.txt:
fast/forms/date/calendar-picker-appearance.html:

Clear webkitTransitionEnd event handler before notifyDone().

9:19 PM Changeset in webkit [123993] by tkent@chromium.org

2 edits in trunk/LayoutTests

Fix opacity issue of fast/forms/date/calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92605

Reviewed by Hajime Morita.

We need to wait for pixel dumping until CSS transition completion for
the 'main' element, which has transition from opacity:0 to opacity:1.

fast/forms/date/calendar-picker-appearance.html:

6:58 PM Changeset in webkit [123992] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unused method HTMLConstructionSiteTask::take(HTMLConstructionSiteTask&)
https://bugs.webkit.org/show_bug.cgi?id=92601

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-29
Reviewed by Adam Barth.

This method was introduced in r104000, but has never been used from the beginning.

No functional change.

html/parser/HTMLConstructionSite.h:

6:46 PM Changeset in webkit [123991] by bashi@chromium.org

5 edits in trunk/Source/WebCore

[Chromium] HarfBuzzShaper can't handle segmented text run
https://bugs.webkit.org/show_bug.cgi?id=92445

Reviewed by Tony Chang.

Pass the range to be displayed to HarfBuzzShaper. The shaper calculates positions and advances of each glyph
regardless of the range, but only add glyphs which are in the range.

No new tests. platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html should
work as expected once we move to use harfbuzz-ng on linux. Note that the current expectation will need to be rebaselined
because the old hb shaper (ComplexTextController) mishandles the range. |to| should be exclusive. I'll rebaseline
the expectation later.

platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawComplexText): Call shaper.setDrawRange().

platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setDrawRange): Added.
(WebCore):
(WebCore::HarfBuzzShaper::shouldDrawCharacterAt): Added.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Added variables that hold pending advances.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Add only glyphs which are in the given range to glyphBuffer.

platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(HarfBuzzShaper):

platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::drawComplexText): Call shaper.setDrawRange().

6:17 PM UsingGitHub edited by morrita@google.com

(diff)

6:13 PM FeatureFlags edited by tkent@chromium.org

Add CSS_COMPOSITING (diff)

5:44 PM Changeset in webkit [123990] by mitz@apple.com

5 edits
2 adds in trunk

Hit testing in the gap between pages returns incorrect results in flipped blocks writing modes
https://bugs.webkit.org/show_bug.cgi?id=92600

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/hit-test-gap-between-pages-flipped.html

rendering/RenderBlock.h:

(WebCore::RenderBlock): Promoted offsetForContents() from private to protected, and demoted
adjustPointToColumnContents() back to private.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest): Changed to flip the point passed to updateHitTestResults().

rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult): Changed to call offsetForContents(), which, as
of r123977, correctly accounts for flippedness.

LayoutTests:

fast/multicol/hit-test-gap-between-pages-flipped-expected.txt: Added.
fast/multicol/hit-test-gap-between-pages-flipped.html: Added.

4:15 PM Changeset in webkit [123989] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

PropertyNameArray::m_shouldCache is only assigned and never used
https://bugs.webkit.org/show_bug.cgi?id=92598

Reviewed by Dan Bernstein.

runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(PropertyNameArray):

3:55 PM Changeset in webkit [123988] by mitz@apple.com

9 edits in trunk

In flipped blocks, a point on the top edge of a text box is considered outside the box (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=92597

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is similar to <http://webkit.org/b/92593> except for RenderText. Fixing this required
fixing some code that creates a point inside a box by setting its y coordinate to the
logical top of the box. In a flipped block, this would be just outside the box.

Enhanced fast/writing-mode/flipped-blocks-hit-test-line-edges.html to cover this.

editing/visible_units.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock): Changed to use
RootInlineBox::blockDirectionPointInLine in the vertical case as well.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren): Changed to use
RootInlineBox::blockDirectionPointInLine.

rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint): Changed the strictness of y inequalities based on
the flippedness of the block. This fixes the bug.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::blockDirectionPointInLine): Moved the implementation here from the
header, and made it return the bottom in the flipped block case, so that the returned point
is inside the line in that case as well.

rendering/RootInlineBox.h:

LayoutTests:

Added hits inside the text to this test.

fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt:
fast/writing-mode/flipped-blocks-hit-test-line-edges.html:

3:36 PM Changeset in webkit [123987] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] pass acceleratePainting info to settings
https://bugs.webkit.org/show_bug.cgi?id=92467

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-07-29
Reviewed by Eric Seidel.

The acceleratePainting info is not passed into settings correctly so
that GPU composition would not use the code path of accelerated painting.

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):

3:26 PM Changeset in webkit [123986] by rakuco@webkit.org

2 edits in trunk/Tools

[EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.
https://bugs.webkit.org/show_bug.cgi?id=92592

Reviewed by Eric Seidel.

Adapt to the changes made to GTK+'s run-with-jhbuild in r123979
and make EFL's run-with-jhbuild call os.execve() instead of
launching a subprocess as well.

This should make it possible to interrupt execution of jhbuild
cleanly.

efl/run-with-jhbuild:

3:03 PM Changeset in webkit [123985] by rniwa@webkit.org

4 edits
1 add in trunk

run-perf-tests should generate a results page
https://bugs.webkit.org/show_bug.cgi?id=92575

Reviewed by Eric Seidel.

PerformanceTests:

Add a results page template. This page includes flot and flot.fillbetween.
jQuery and the json that contains test results are injected by run-perf-tests.

resources/results-template.html: Added.

Tools:

Added the ability to generate a results page that summarizes performance test results from
multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
is not specified. We cannot generate a results page when --test-results-server is specified
because perf-o-matic cannot parse the new JSON format.

The new JSON format is simply an array of the old JSON output. This JSON is then merged into
results-template.html along with jQuery and copied as a HTML file of the same filename as
the output JSON file with a .html extension.

We merge all scripts and the JSON output into the results page as opposed to including them
with the src content attribute to make it standalone so that we may post it on Bugzilla or
e-mail it to someone else without breaking it.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.run):
(PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
a results page, and generate the results page from results-template.html merged with jQuery and
the generated JSON output.

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
several test cases.
(_test_run_with_json_output.mock_upload_json): Ditto.
(test_run_with_json_output): Refactored to use _test_run_with_json_output.
(test_run_generates_results_page): Added. Tests the new feature.
(test_run_with_json_source): Refactored to use _test_run_with_json_output.
(test_run_with_multiple_repositories): Ditto.
(test_run_with_upload_json): Ditto.

2:59 PM Changeset in webkit [123984] by commit-queue@webkit.org

18 edits in trunk

.: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553