Context Navigation

← Previous Period
Next Period →

Timeline

Aug 1, 2012:

11:59 PM Changeset in webkit [124414] by apavlov@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

platform/chromium/TestExpectations:

11:44 PM Changeset in webkit [124413] by commit-queue@webkit.org

26 edits in trunk/Source

Unreviewed, rolling out r124406.
http://trac.webkit.org/changeset/124406
https://bugs.webkit.org/show_bug.cgi?id=92951

it set the Mac bots on fire (Requested by pizlo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

Source/JavaScriptCore:

bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ConditionalNode::emitBytecode):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):

debugger/Debugger.h:
interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):

interpreter/Interpreter.h:

(Interpreter):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

parser/ASTBuilder.h:

(ASTBuilder):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):

parser/Lexer.h:

(Lexer):
(JSC::::lexExpectIdentifier):

parser/NodeConstructors.h:

(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):

parser/Nodes.cpp:

(JSC):
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):

parser/Nodes.h:

(Node):
(ExpressionNode):
(StatementNode):
(NullNode):
(BooleanNode):
(NumberNode):
(StringNode):
(RegExpNode):
(ThisNode):
(ResolveNode):
(ArrayNode):
(PropertyListNode):
(ObjectLiteralNode):
(BracketAccessorNode):
(DotAccessorNode):
(ArgumentListNode):
(NewExprNode):
(EvalFunctionCallNode):
(FunctionCallValueNode):
(FunctionCallResolveNode):
(FunctionCallBracketNode):
(FunctionCallDotNode):
(CallFunctionCallDotNode):
(ApplyFunctionCallDotNode):
(PrePostResolveNode):
(PostfixResolveNode):
(PostfixBracketNode):
(PostfixDotNode):
(PostfixErrorNode):
(DeleteResolveNode):
(DeleteBracketNode):
(DeleteDotNode):
(DeleteValueNode):
(VoidNode):
(TypeOfResolveNode):
(TypeOfValueNode):
(PrefixResolveNode):
(PrefixBracketNode):
(PrefixDotNode):
(PrefixErrorNode):
(UnaryOpNode):
(UnaryPlusNode):
(NegateNode):
(BitwiseNotNode):
(LogicalNotNode):
(BinaryOpNode):
(MultNode):
(DivNode):
(ModNode):
(AddNode):
(SubNode):
(LeftShiftNode):
(RightShiftNode):
(UnsignedRightShiftNode):
(LessNode):
(GreaterNode):
(LessEqNode):
(GreaterEqNode):
(ThrowableBinaryOpNode):
(InstanceOfNode):
(InNode):
(EqualNode):
(NotEqualNode):
(StrictEqualNode):
(NotStrictEqualNode):
(BitAndNode):
(BitOrNode):
(BitXOrNode):
(LogicalOpNode):
(ConditionalNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(ReadModifyBracketNode):
(AssignBracketNode):
(AssignDotNode):
(ReadModifyDotNode):
(AssignErrorNode):
(CommaNode):
(ConstDeclNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncExprNode):
(FuncDeclNode):
(SwitchNode):

parser/Parser.cpp:

(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):

parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::getTokenName):
(JSC::::parse):

parser/ParserTokens.h:

(JSC::JSTokenInfo::JSTokenInfo):
(JSTokenInfo):
(JSToken):

parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::closeBraceToken):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

Source/WebCore:

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):

bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

11:32 PM Changeset in webkit [124412] by loislo@chromium.org

7 edits
1 add in trunk/Source

Web Inspector: test native memory instrumentation code with help of unittests
https://bugs.webkit.org/show_bug.cgi?id=92743

Reviewed by Yury Semikhatsky.

Test a part of existing Native Memory Instrumentation code with help of unit tests.
6 tests were added and two bugs were fixed.
a drive-by improvement: the method MemoryInstrumentation::addInstrumentedObject
was marked as private and addRootObject was introduced instead of it.
The new function also calls processDeferedPointers.

Source/WebCore:

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addRootObject):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore):
(WebCore::MemoryInstrumentation::addObjectImpl):

inspector/InspectorMemoryAgent.cpp:

(WebCore):

inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalSize):
(WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):

Source/WebKit/chromium:

WebKit.gypi:
tests/MemoryInstrumentationTest.cpp: Added.

(WebCore):
(NotInstrumented):
(Instrumented):
(WebCore::Instrumented::Instrumented):
(WebCore::Instrumented::~Instrumented):
(WebCore::Instrumented::reportMemoryUsage):
(WebCore::TEST):
(InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):

10:57 PM Changeset in webkit [124411] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Chromium Android build fix after r124402.
Initialize the out variables as suggested by the compiler.

Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):

10:53 PM Changeset in webkit [124410] by rniwa@webkit.org

405 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in fast/notifications, overflow, parser, performance,
preloader, profiler, reflections, regex, regions, repaint, ruby and runin tests
https://bugs.webkit.org/show_bug.cgi?id=92944

Reviewed by Kent Tamura.

fast/notifications/notification-after-close.html:
fast/notifications/notifications-cancel-request-permission.html:
fast/notifications/notifications-check-permission.html:
fast/notifications/notifications-click-event-focus.html:
fast/notifications/notifications-click-event.html:
fast/notifications/notifications-display-close-events.html:
fast/notifications/notifications-document-close-crash.html:
fast/notifications/notifications-double-show.html:
fast/notifications/notifications-event-stop-propagation.html-disabled:
fast/notifications/notifications-multi-events.html-disabled:
fast/notifications/notifications-no-icon.html:
fast/notifications/notifications-replace.html:
fast/notifications/notifications-request-permission.html:
fast/notifications/notifications-rtl.html:
fast/notifications/notifications-window-close-crash.html:
fast/notifications/notifications-with-permission.html:
fast/notifications/notifications-without-permission.html:
fast/notifications/resources/notifications-cancel-request-permission.html:
fast/overflow/generated-content-crash.html:
fast/overflow/hidden-scrollbar-resize.html:
fast/overflow/horizontal-scroll-after-back.html:
fast/overflow/lots-of-sibling-inline-boxes.html:
fast/overflow/onscroll-layer-self-destruct.html:
fast/overflow/overflow-height-float-not-removed-crash.html:
fast/overflow/overflow-height-float-not-removed-crash2.html:
fast/overflow/overflow-height-float-not-removed-crash3.html:
fast/overflow/overflow-rtl-vertical-origin.html:
fast/overflow/overflow-text-hit-testing.html:
fast/overflow/overflow-y-scroll.html:
fast/overflow/scroll-vertical-not-horizontal.html:
fast/overflow/scrollRevealButton.html:
fast/overflow/scrollbar-restored-and-then-locked.html:
fast/overflow/scrollbar-restored.html:
fast/overflow/setting-scrollTop-after-hide-show.html:
fast/parser/:
fast/preloader/document-write-2.html:
fast/preloader/document-write-noscript.html:
fast/preloader/document-write.html:
fast/preloader/first-base-tag-scanned-wins.html:
fast/preloader/first-base-tag-wins.html:
fast/preloader/image.html:
fast/preloader/input.html:
fast/preloader/link.html:
fast/preloader/noscript.html:
fast/preloader/scan-body-from-head-import.html:
fast/preloader/scan-body-from-head-script.html:
fast/preloader/script.html:
fast/preloader/style.html:
fast/preloader/understands-base-tag.html:
fast/profiler/:
fast/reflections/inline-crash.html:
fast/reflections/pending-reflection-mask-crash.html:
fast/reflections/reflected-img-crash.html:
fast/reflections/reflection-computed-style.html:
fast/reflections/remove-reflection-crash.html:
fast/reflections/resources/reflection-overflow-scroll.js:
fast/reflections/teardown-crash.html:
fast/reflections/toggle-reflection-crash.html:
fast/regex/syntax-errors.html:
fast/regions/content-flowed-into-regions-no-scroll.html:
fast/regions/element-region-overflow-state-vertical-rl.html:
fast/regions/element-region-overflow-state.html:
fast/regions/flexbox-in-region-crash.html:
fast/regions/flow-anonymous-children.html:
fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html:
fast/regions/flowed-content-bounding-client-rect-vertical-rl.html:
fast/regions/flowed-content-bounding-client-rect-vertical.html:
fast/regions/flowed-content-bounding-client-rect.html:
fast/regions/flowed-content-transform-bounding-client-rect.html:
fast/regions/get-regions-by-content-horiz-bt.html:
fast/regions/get-regions-by-content-horiz-tb.html:
fast/regions/get-regions-by-content-vert-lr.html:
fast/regions/get-regions-by-content-vert-rl.html:
fast/regions/get-regions-by-content.html:
fast/regions/get-regions-by-content2.html:
fast/regions/hit-test-float.html:
fast/regions/hit-test-region.html:
fast/regions/imbricated-flow-threads-crash.html:
fast/regions/no-split-line-box.html:
fast/regions/parse-incomplete-region-rule.html:
fast/regions/parsing-region-style-rule.html:
fast/regions/region-element-dynamic-attach-flow.html:
fast/regions/region-element-dynamic-detach-flow.html:
fast/regions/region-range-for-box-crash.html:
fast/regions/region-style-block-background-color2.html:
fast/regions/script-tests/css-regions-disabled.js:
fast/regions/select-in-region-crash.html:
fast/regions/set-box-style-in-region-crash.html:
fast/regions/svg-root-element-collected.html:
fast/regions/symbol-in-named-flow-crash.svg:
fast/regions/text-region-breaks.html:
fast/regions/text-region-split-after-resize.html:
fast/regions/text-region-split-horizontal-bt.html:
fast/regions/text-region-split-vertical-rl.html:
fast/regions/text-region-split-vertical.html:
fast/regions/text-region-split.html:
fast/regions/webkit-named-flow-event-add-to-flow.html:
fast/regions/webkit-named-flow-event-no-regions.html:
fast/regions/webkit-named-flow-event-remove-from-dom.html:
fast/regions/webkit-named-flow-event-remove-from-flow.html:
fast/regions/webkit-named-flow-event-target.html:
fast/regions/webkit-named-flow-event-to-null.html:
fast/regions/webkit-named-flow-event.html:
fast/regions/webkit-named-flow-existing-flow.html:
fast/regions/webkit-named-flow-first-empty-region-index.html:
fast/regions/webkit-named-flow-flow-added.html:
fast/regions/webkit-named-flow-get-content.html:
fast/regions/webkit-named-flow-invalid-name.html:
fast/regions/webkit-named-flow-modified-flow.html:
fast/regions/webkit-named-flow-name.html:
fast/regions/webkit-named-flow-non-existing-flow.html:
fast/regions/webkit-named-flow-overset.html:
fast/regions/webkit-named-flow-removed-flow.html:
fast/regions/webkit-named-flow-same-object.html:
fast/repaint/:
fast/replaced/css-content-and-webkit-mask-box-image-crash.html:
fast/replaced/frame-removed-during-resize-smaller.html:
fast/replaced/frame-removed-during-resize.html:
fast/replaced/image-map-2.html:
fast/replaced/image-map-bug16782.html:
fast/replaced/image-map.html:
fast/replaced/image-resize-width.html:
fast/replaced/invalid-object-with-fallback.html:
fast/replaced/object-param-no-name.html:
fast/replaced/object-param-spaces.html:
fast/replaced/object-with-embed-url-param.html:
fast/replaced/object-with-non-empty-classid-triggers-fallback.html:
fast/replaced/outline-replaced-elements.html:
fast/replaced/resources/focus-test.js:

(checkNoFocusRing):

fast/replaced/table-percent-height-text-controls.html:
fast/replaced/table-percent-height.html:
fast/replaced/table-percent-width.html:
fast/replaced/table-replaced-element.html:
fast/replaced/vertical-resize-100percent-element.html:
fast/replaced/width100percent-textarea.html:
platform/chromium/fast/repaint/fixed-layout-360x240.html:
platform/mac/fast/overflow/overflow-scrollbar-hit-test.html:
platform/qt/fast/repaint/flexible-box-overflow-expected.txt:
platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.txt:
platform/qt/fast/repaint/focus-ring-expected.txt:
platform/qt/fast/repaint/inline-block-overflow-expected.txt:
platform/qt/fast/repaint/layer-child-outline-expected.txt:
platform/qt/fast/repaint/layer-outline-expected.txt:
platform/qt/fast/repaint/layer-outline-horizontal-expected.txt:
platform/qt/fast/repaint/list-marker-expected.txt:
platform/qt/fast/repaint/text-shadow-expected.txt:
platform/qt/fast/repaint/text-shadow-horizontal-expected.txt:

10:29 PM Changeset in webkit [124409] by keishi@webkit.org

4 edits
3 adds in trunk

Fix typo in colorSuggestionPicker.js
https://bugs.webkit.org/show_bug.cgi?id=92936

Reviewed by Kent Tamura.

Source/WebCore:

Fixes typo.

Test: platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html

Resources/colorSuggestionPicker.js:

(getScrollbarWidth):

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt: Added.
platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html: Added. Tests the appearance when there are many datalist options.

10:21 PM Changeset in webkit [124408] by pkasting@chromium.org

5 edits
3 deletes in trunk/LayoutTests

[Chromium] Test expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=72990
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=80219
https://bugs.webkit.org/show_bug.cgi?id=90741
https://bugs.webkit.org/show_bug.cgi?id=92850
https://bugs.webkit.org/show_bug.cgi?id=92852
https://bugs.webkit.org/show_bug.cgi?id=92938
https://bugs.webkit.org/show_bug.cgi?id=92941

Unreviewed, test expectation updates.

Attempting to fix http/tests/cache tests dumping as pixel tests by changing "window.testRunner.dumpAsText()" to "testRunner.dumpAsText()" since the test opens multiple windows. (I don't know why else it might not be working.)
Removing erroneous Chromium Linux pixel baselines for that test.
Rebaselined a CSS test after http://trac.webkit.org/changeset/123782 , which only got partially rebaselined before.
Fixed some incorrect bug numbers on some expectations.
Miscellaneous other stuff.

http/tests/cache/history-only-cached-subresource-loads-max-age-https.html:
http/tests/cache/history-only-cached-subresource-loads.html:
platform/chromium-linux/http/tests/cache/history-only-cached-subresource-loads-expected.png: Removed.
platform/chromium-linux/http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.png: Removed.
platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Removed.
platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
platform/chromium/TestExpectations:

9:57 PM Changeset in webkit [124407] by shinyak@chromium.org

3 edits
2 adds in trunk

The elements in Shadow DOM of input should not be modifiable.
https://bugs.webkit.org/show_bug.cgi?id=92200

Reviewed by Kent Tamura.

Source/WebCore:

Since we don't have "-webkit-user-modify: read-only !important;" for the elements in Shadow DOM of
input element, user can change them and it causes a crash.

We should have "-webkit-user-modify: read-only !important;" for those elements.

Test: fast/forms/input-user-modify.html

css/html.css:

(input::-webkit-textfield-decoration-container):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
(input[type="file"]::-webkit-file-upload-button):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(input::-webkit-calendar-picker-indicator):

LayoutTests:

fast/forms/input-user-modify-expected.txt: Added.
fast/forms/input-user-modify.html: Added.

9:49 PM Changeset in webkit [124406] by commit-queue@webkit.org

26 edits in trunk/Source

Web Inspector: [JSC] implement setting breakpoints by line:column
https://bugs.webkit.org/show_bug.cgi?id=53003

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-01
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add a counter in lexer to record the column of each token. Debugger will use column info
in "Pretty Print" debug mode of Inspector.

bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

bytecompiler/NodesCodegen.cpp:

debugger/Debugger.h:
interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):

interpreter/Interpreter.h:

(Interpreter):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

parser/ASTBuilder.h:

parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):

parser/Lexer.h:

(Lexer):
(JSC::Lexer::currentColumnNumber):
(JSC::::lexExpectIdentifier):

parser/NodeConstructors.h:

parser/Nodes.cpp:

(JSC::StatementNode::setLoc):
(JSC):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):

parser/Nodes.h:

(Node):
(JSC::Node::columnNo):
(ExpressionNode):
(StatementNode):
(JSC::StatementNode::column):
(NullNode):
(BooleanNode):
(NumberNode):
(StringNode):
(RegExpNode):
(ThisNode):
(ResolveNode):
(ArrayNode):
(PropertyListNode):
(ObjectLiteralNode):
(BracketAccessorNode):
(DotAccessorNode):
(ArgumentListNode):
(NewExprNode):
(EvalFunctionCallNode):
(FunctionCallValueNode):
(FunctionCallResolveNode):
(FunctionCallBracketNode):
(FunctionCallDotNode):
(CallFunctionCallDotNode):
(ApplyFunctionCallDotNode):
(PrePostResolveNode):
(PostfixResolveNode):
(PostfixBracketNode):
(PostfixDotNode):
(PostfixErrorNode):
(DeleteResolveNode):
(DeleteBracketNode):
(DeleteDotNode):
(DeleteValueNode):
(VoidNode):
(TypeOfResolveNode):
(TypeOfValueNode):
(PrefixResolveNode):
(PrefixBracketNode):
(PrefixDotNode):
(PrefixErrorNode):
(UnaryOpNode):
(UnaryPlusNode):
(NegateNode):
(BitwiseNotNode):
(LogicalNotNode):
(BinaryOpNode):
(MultNode):
(DivNode):
(ModNode):
(AddNode):
(SubNode):
(LeftShiftNode):
(RightShiftNode):
(UnsignedRightShiftNode):
(LessNode):
(GreaterNode):
(LessEqNode):
(GreaterEqNode):
(ThrowableBinaryOpNode):
(InstanceOfNode):
(InNode):
(EqualNode):
(NotEqualNode):
(StrictEqualNode):
(NotStrictEqualNode):
(BitAndNode):
(BitOrNode):
(BitXOrNode):
(LogicalOpNode):
(ConditionalNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(ReadModifyBracketNode):
(AssignBracketNode):
(AssignDotNode):
(ReadModifyDotNode):
(AssignErrorNode):
(CommaNode):
(ConstDeclNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncExprNode):
(FuncDeclNode):
(SwitchNode):

parser/Parser.cpp:

parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::tokenLocation):
(Parser):
(JSC::Parser::getTokenName):
(JSC::::parse):

parser/ParserTokens.h:

(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
(JSToken):

parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::closeBraceToken):

parser/SyntaxChecker.h:

Source/WebCore:

As JSC is enabled to provide column info of statement, ScriptDebugServer can use it to
support "Pretty Print" debug mode.

No new test case for this patch.

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore):
(WebCore::ScriptDebugServer::updateCurrentStatementPosition):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):

bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

9:45 PM Changeset in webkit [124405] by ryuan.choi@samsung.com

3 edits in trunk/Source/WebKit/efl

[EFL][Regression] Build break with NETSCAPE_PLUGIN_API after r123604
https://bugs.webkit.org/show_bug.cgi?id=92937

Unreviewed build fix.

r123604 replaced strdup to eina_stringshare, but related codes are not
changed properly.
This patch changes remained code to use eina_stringshare.

ewk/ewk_js.cpp:

(ewk_js_variant_to_npvariant):
(ewk_js_property_free):
(ewk_js_npvariant_to_variant):
(ewk_js_variant_free):
(ewk_js_variant_array_free):

ewk/ewk_js.h:

9:32 PM Changeset in webkit [124404] by fpizlo@apple.com

25 edits
5 adds in trunk

DFG should hoist structure checks
https://bugs.webkit.org/show_bug.cgi?id=92696

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This hoists structure checks in the same way that we would hoist array checks, but with added
complexity to cope with the fact that the structure of an object may change. This is handled
by performing a side effects analysis over the region in which the respective variable is
live. If a structure clobbering side effect may happen then we either hoist the structure
checks and fall back on structure transition watchpoints (if the watchpoint set is still
valid), or we avoid hoisting altogether.

Doing this required teaching the CFA that we may have an expectation that an object has a
particular structure even after structure clobbering happens, in the sense that structure
proofs that were cobbered can be revived using watchpoints. CFA must know about this so that
OSR entry may know about it, since we cannot allow entry to happen if the variable has a
clobbered structure proof, will have a watchpoint to revive the proof, and the variable in
the baseline JIT has a completely unrelated structure.

This is mostly performance neutral.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/ValueRecovery.h:

(JSC::ValueRecovery::isSet):
(JSC::ValueRecovery::operator!):
(ValueRecovery):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberWorld):
(DFG):
(JSC::DFG::AbstractState::clobberCapturedVars):

dfg/DFGAbstractState.h:

(AbstractState):

dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::validateForEntry):
(AbstractValue):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::fixVariableAccessSpeculations):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::Graph::vote):
(Graph):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToStructureTransitionWatchpoint):
(Node):
(JSC::DFG::Node::hasStructureSet):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationCheckWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecutionWithConditionalDirection):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::gpr):
(SpeculateCellOperand):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStructureCheckHoistingPhase.cpp: Added.

(DFG):
(StructureCheckHoistingPhase):
(JSC::DFG::StructureCheckHoistingPhase::StructureCheckHoistingPhase):
(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):
(JSC::DFG::StructureCheckHoistingPhase::clobber):
(CheckData):
(JSC::DFG::StructureCheckHoistingPhase::CheckData::CheckData):
(JSC::DFG::performStructureCheckHoisting):

dfg/DFGStructureCheckHoistingPhase.h: Added.

(DFG):

dfg/DFGVariableAccessData.h:

(VariableAccessData):
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeStructureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::structureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::clearVotes):
(JSC::DFG::VariableAccessData::vote):
(JSC::DFG::VariableAccessData::voteRatio):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):

runtime/Options.h:

(JSC):

LayoutTests:

Rubber stamped by Gavin Barraclough.

Added a new test that covers the following scenarios:

OSR entry if a variable with a hoisted check has an unexpected structure, structures get clobbered, and we're protecting ourselves with structure transition watchpoints.

OSR exit on hoisted structure checks, if the object doesn't have the expected structure, and where the source of the assignment is side-effecting.

I combined these into a single test because there is no way to test the latter without testing the former.

fast/js/dfg-osr-entry-hoisted-clobbered-structure-check-expected.txt: Added.
fast/js/dfg-osr-entry-hoisted-clobbered-structure-check.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js: Added.

(foo):
(bar):
(baz):

8:55 PM Changeset in webkit [124403] by charles.wei@torchmobile.com.cn

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Favicon should be Base64 encoded for cross-process passing
https://bugs.webkit.org/show_bug.cgi?id=92857

Reviewed by George Staikos.

The current implementation just passes the internal of SkPixels data to the client,
which can't be passed accross the process boundary to chrome for processing.
This patch makes the favicon Base64 encoded so that can be passed to chrome in another process.

Api/WebPageClient.h:
WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

8:08 PM Changeset in webkit [124402] by commit-queue@webkit.org

5 edits in trunk/Source

IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type
https://bugs.webkit.org/show_bug.cgi?id=92725

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-01
Reviewed by Kentaro Hara.

Source/WebCore:

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.*.

Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::decodeByte):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):

Modules/indexeddb/IDBLevelDBCoding.h:

(IDBLevelDBCoding):

Source/WebKit/chromium:

Add two new tests in IDBLevelDBCodingTest.cpp. One for an added function decodeByte() and
another for verifying that encodeByte() and encodeVarInt() are indentical when the encoded
values are <= 127.

tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):

7:31 PM Changeset in webkit [124401] by dpranke@chromium.org

3 edits in trunk/Tools

REGRESSION(r123893): Reftest mismatches are run through ImageDiff with 0.1 tolerance
https://bugs.webkit.org/show_bug.cgi?id=92847

Reviewed by Ojan Vafai.

I was failing to distinguish between 'None' and 0 :(. Fixed and added tests.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.diff_image):

Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_diff_image.make_proc):
(PortTestCase.test_diff_image):

7:29 PM Changeset in webkit [124400] by commit-queue@webkit.org

16 edits in trunk/Source

[chromium] Use new-style tracing macros with explicit category
https://bugs.webkit.org/show_bug.cgi?id=92928

Patch by James Robinson <jamesr@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

Source/WebCore:

The chromium tracing system supports using a string identifier for trace categories that can be used to filter
events. This switches over to setting an explicit category for all traces and removes the old-style
TRACE_EVENT() macro.

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

platform/chromium/TraceEvent.h:
platform/graphics/chromium/ProgramBinding.cpp:

(WebCore::ProgramBindingBase::init):

platform/graphics/skia/ImageSkia.cpp:

(WebCore::drawResampledBitmap):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):

platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::resizedBitmap):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::bitmap):

platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::decode):

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::decode):

platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decode):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::decode):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::decode):

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

Source/WebKit/chromium:

Set the category explicitly in traces.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):
(WebKit::WebViewImpl::layout):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

6:44 PM Changeset in webkit [124399] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] Crash at WebCore::toRenderSlider
https://bugs.webkit.org/show_bug.cgi?id=92893

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-01
Reviewed by Hajime Morita.

Added a type check before casting a render object to RenderSlider as
an arbitrary element can have for example webkit-appearance: slider-horizontal.

No new tests. Existing test fast/forms/range/slider-appearance-crash.html covers the case.

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):

6:28 PM Changeset in webkit [124398] by fpizlo@apple.com

11 edits in trunk/Source/JavaScriptCore

DFG should distinguish between PutByVal's that clobber the world and ones that don't
https://bugs.webkit.org/show_bug.cgi?id=92923

Reviewed by Mark Hahnenberg.

This is performance-neutral. I also confirmed that it's neutral if we make the
clobbering variant (PutByValSafe) clobber all knowledge of what is an array,
which should feed nicely into work on removing uses of ClassInfo.

bytecode/DFGExitProfile.h:
dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:26 PM Changeset in webkit [124397] by yosin@chromium.org

9 edits in trunk/Source/WebCore

Cache support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81332

Patch by Koji Ishii <Koji Ishii> on 2012-08-01
Reviewed by Tony Chang.

This patch adds FontCache to cache OpenTypeVerticalData class
instances that was introduced in bug 81326.

We need one instance of the class per OpenType font file, and we don't
have a class to hold such instances today.

ENABLE_OPENTYPE_VERTICAL isn't enabled for any platforms yet, so this
patch isn't on any code path. Apple Windows port (bug 48459) is going
to use this code, and probably Chromium (51450, 69282) as well.

"FIXME" comment in SimpleFontData.h will be implemented in 48459.

No new tests are required. No behavior changes.

platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData): Ignore leading "@" on Windows to disable Windows feature for vertical flow.
(WebCore):
(WebCore::FontCache::getVerticalData): Get cached OpenTypeVerticalData from FontPlatformData, or crete one.
(WebCore::FontCache::purgeInactiveFontData): Purge inactive OpenTypeVerticalData.

platform/graphics/FontCache.h:

(WebCore):

platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::verticalData): A dummy implementation for purgeInactiveFontData() to work.

platform/graphics/opentype/OpenTypeVerticalData.h: Added m_inFontCache for mark & sweep.

(OpenTypeVerticalData):

6:18 PM Changeset in webkit [124396] by jamesr@google.com

17 edits in trunk/Source

[chromium] Move compositor HUD font atlas initialization code out of compositor core
https://bugs.webkit.org/show_bug.cgi?id=92924

Reviewed by Adrienne Walker.

Source/Platform:

The chromium compositor does not have any text rendering capabilities. It generally does not need them, but it
is helpful for some debugging aids to be able to render at least ASCII text to the screen. This provides an API
on WebLayerTreeView by which an embedder can provide an ASCII glyph atlas to use for displaying debug
information.

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

This moves the HUD font atlas initialization code out of the compositor implementation to cut out Font-related
dependencies. The new flow is that an embedder can pass a font atlas to the CCLayerTreeHost, after which the
atlas is provided the HUD layer (if any) on the next commit. The HUD layer renders text using the font atlas if
it has any if the settings require text.

HUD tested manually, we don't have automated tests for this debugging-only feature.

platform/graphics/chromium/CompositorHUDFontAtlas.cpp:

(WebCore):
(WebCore::CompositorHUDFontAtlas::generateFontAtlas):

platform/graphics/chromium/CompositorHUDFontAtlas.h:

(CompositorHUDFontAtlas):

platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:

(WebCore::HeadsUpDisplayLayerChromium::create):
(WebCore::HeadsUpDisplayLayerChromium::HeadsUpDisplayLayerChromium):
(WebCore::HeadsUpDisplayLayerChromium::setFontAtlas):
(WebCore):
(WebCore::HeadsUpDisplayLayerChromium::createCCLayerImpl):
(WebCore::HeadsUpDisplayLayerChromium::pushPropertiesTo):

platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:

(HeadsUpDisplayLayerChromium):

platform/graphics/chromium/cc/CCFontAtlas.cpp:

(WebCore::CCFontAtlas::CCFontAtlas):

platform/graphics/chromium/cc/CCFontAtlas.h:

(WebCore):
(WebCore::CCFontAtlas::create):
(CCFontAtlas):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::setFontAtlas):
(WebCore):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:

(WebCore::CCHeadsUpDisplayLayerImpl::create):
(CCHeadsUpDisplayLayerImpl):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setFontAtlas):
(WebCore):
(WebCore::CCLayerTreeHost::willCommit):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(CCLayerTreeHost):

Source/WebKit/chromium:

This initializes the compositor's font atlas when initialization the compositor if the "Show FPS counter" or
"Show layer tree" settings are true.

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setFontAtlas):
(WebKit):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

5:49 PM Changeset in webkit [124395] by jianli@chromium.org

2 edits in trunk/Source/Platform

Unreviewed. Fix build break for chromium.

Platform.gypi:

5:27 PM Changeset in webkit [124394] by jianli@chromium.org

8 edits
1 add in trunk/Source

[chromium] Make WebKit API support draggable region change update
https://bugs.webkit.org/show_bug.cgi?id=92813

Reviewed by Adam Barth.

Source/Platform:

Add WebDraggableRegion for chromium's usage.

Platform.gypi:

Source/WebKit/chromium:

Introduce WebDraggableRegion and delegate the draggable region update
call to the new method draggableRegionsChanged in WebViewClient.

public/WebDocument.h:

(WebDocument):

public/WebDraggableRegion.h: Added.

(WebKit):
(WebDraggableRegion):

public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::draggableRegionsChanged):

src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::dashboardRegionsChanged):

src/ChromeClientImpl.h:

(ChromeClientImpl):

src/WebDocument.cpp:

(WebKit::WebDocument::draggableRegions):
(WebKit):

5:26 PM Changeset in webkit [124393] by beidson@apple.com

6 edits in trunk/Source/WebKit2

Small part of "Out-of-process plug-ins should support asynchronous initialization."
<rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919

Reviewed by Anders Carlsson.

Add API-level preferences for:

Is asynchronous plug-in initialization enabled.
Is an artificial initialization delay (for testing purposes) enabled.

Shared/WebPreferencesStore.h:

(WebKit):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAsynchronousPluginInitializationEnabled):
(WKPreferencesGetAsynchronousPluginInitializationEnabled):
(WKPreferencesSetArtificialPluginInitializationDelayEnabled):
(WKPreferencesGetArtificialPluginInitializationDelayEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::asynchronousPluginInitializationEnabled):
(WebKit::WebPage::artificialPluginInitializationDelayEnabled):
(WebPage):

5:22 PM Changeset in webkit [124392] by piman@chromium.org

10 edits
1 copy
1 add in trunk/Source

[chromium] factor out the optimization pass in CCRenderSurfaceFilters::apply
https://bugs.webkit.org/show_bug.cgi?id=92453

Reviewed by James Robinson.

This separates the "optimization" pass in CCRenderSurfaceFilters::apply
to resolve a succession of color matrix filters into a single operation.
This allows testing of that code.
This introduces a new generic color matrix WebFilterOperation, which can
also be used on its own.

Source/Platform:

Platform.gypi:
chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::createColorMatrixFilter):
(WebFilterOperation):
(WebKit::WebFilterOperation::WebFilterOperation):

chromium/src/WebFilterOperation.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.h.

(WebKit):
(WebKit::WebFilterOperation::equals):
(WebKit::WebFilterOperation::WebFilterOperation):

chromium/src/WebFilterOperations.cpp:

(WebKit::WebFilterOperations::hasFilterThatAffectsOpacity):

Source/WebCore:

New test: CCRenderSurfaceFiltersTest.

platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::optimize):
(WebCore):
(WebCore::CCRenderSurfaceFilters::apply):

platform/graphics/chromium/cc/CCRenderSurfaceFilters.h:

(CCRenderSurfaceFilters):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCRenderSurfaceFiltersTest.cpp: Added.

(WebKit):
(WebKit::isCombined):
(WebKit::TEST):

5:20 PM Changeset in webkit [124391] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Fix for drawing invalid layers in WebViewBenchmarkSupportImpl
https://bugs.webkit.org/show_bug.cgi?id=92920

Patch by Daniel Murphy <dmurph@chromium.org> on 2012-08-01
Reviewed by Adrienne Walker.

The GraphicsLayers without content needed to be skipped.

src/WebViewBenchmarkSupportImpl.cpp:

(WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped):

5:16 PM Changeset in webkit [124390] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

Enable codec tests in TestExpectations and update expected mp3 files
https://bugs.webkit.org/show_bug.cgi?id=92886

Patch by Raymond Toy <Raymond Toy> on 2012-08-01
Reviewed by Chris Rogers.

Update expected results caused by ffmpeg now removing pre-roll samples.

platform/chromium-linux/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav:
platform/chromium-mac/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav:
platform/chromium-win/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav:

Enable codec tests.

platform/chromium/TestExpectations:

5:14 PM Changeset in webkit [124389] by jianli@chromium.org

45 edits
2 adds in trunk

Add new CSS property "-webkit-widget-region" to expose dashboard region support for other port
https://bugs.webkit.org/show_bug.cgi?id=90298

Reviewed by Adam Barth.

configure.ac: Add ENABLE_WIDGET_REGION define.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.

Source/WebCore:

The css property "-webkit-widget-region" is essentially a synonym of
"-webkit-dashboard-region" that allows us to expose dashboard region
support for other port. This patch also adds a new feature define
ENABLE(WIDGET_REGION) such that "-webkit-dashboard-region" is only
provided under ENABLE(DASHBOARD_SUPPORT) as it is now and
"-webkit-widget-region" is only exposed under ENABLE(WIDGET_REGION).

Change almost all the code pieces guarded by ENABLE(DASHBOARD_SUPPORT)
to make them also guarded by ENABLE(WIDGET_REGION), except those
that are specific to Apple/WebKit.

Currently ENABLE(WIDGET_REGION) has been turned on by default for
Mac/WebKit and chromium ports.

Test: fast/css/widget-region-parser.html

Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.
DerivedSources.make:
GNUmakefile.am: Add ENABLE_WIDGET_REGION define.
WebCore.exp.in:
css/CSSComputedStyleDeclaration.cpp: Handle CSSPropertyWebkitWidgetRegion.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp: Parse "-webkit-widget-region".

(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseDashboardRegions):

css/CSSProperty.cpp: Handle CSSPropertyWebkitWidgetRegion.

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPrimitiveValue.cpp:

(WebCore):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

css/CSSPropertyNames.in: Add "-webkit-widget-region" property.
css/DashboardRegion.h:

(DashboardRegion):

css/StyleResolver.cpp: Handle CSSPropertyWebkitWidgetRegion.
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore):

dom/Document.h:

(WebCore):
(Document):

page/Chrome.cpp:

(WebCore):

page/ChromeClient.h:

(ChromeClient):

page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore):
(WebCore::FrameView::paintContents):

page/FrameView.h:

(FrameView):

rendering/RenderInline.cpp:

(WebCore):

rendering/RenderInline.h:

(RenderInline):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setHasVerticalScrollbar):

rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore):

rendering/RenderObject.h:

(RenderObject):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):
(WebCore):

rendering/style/RenderStyle.h:
rendering/style/StyleDashboardRegion.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

(WebCore):
(StyleRareNonInheritedData):

Source/WebKit/chromium:

features.gypi: Add ENABLE_WIDGET_REGION define.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.

Source/WebKit2:

Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.

LayoutTests:

Added a new test to test the new CSS property.

fast/css/widget-region-parser-expected.txt: Added.
fast/css/widget-region-parser.html: Added.
platform/efl/Skipped: Skip the new test.
platform/gtk/TestExpectations: Skip the new test.
platform/qt/Skipped: Skip the new test.
platform/win/Skipped: Skip the new test.
platform/wincario/Skipped: Skip the new test.

5:10 PM Changeset in webkit [124388] by fpizlo@apple.com

1 edit in trunk/Source/JavaScriptCore/ChangeLog

Remove apparent merge goof from JavaScriptCore/ChangeLog

4:57 PM Changeset in webkit [124387] by commit-queue@webkit.org

1 edit
1 add in trunk/LayoutTests

Some of the test results for LayoutTests/accessibility/canvas-accessibilitynodeobject.html do not show up on Windows.
https://bugs.webkit.org/show_bug.cgi?id=92916

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-01
Reviewed by Tim Horton.

Adding a failing test result and filing a bug.

platform/win/accessibility/canvas-accessibilitynodeobject-expected.txt: Added.

4:53 PM Changeset in webkit [124386] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

[V8] TypedArray binding performance improvements
https://bugs.webkit.org/show_bug.cgi?id=92557

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-01
Reviewed by Kenneth Russell.

Improve TypedArray bindings performance:

create arrays with createUninitialized when possible. Typed Array

construction is about 10% faster.

when creating a typed array from a same typed array, memcpy data

from source to target.

In order to detect if argument array is the same type as
implementation array, we pass the javascript wrapper type as a new
type argument to template function constructWebGLArray.

Introduce wrapArrayBufferView which wraps typed array into a v8::Value

No new tests: Performance tests are already handled by
Bindings/typed-array-construct-from-same-type.html and
Bindings/typed-array-construct-from-typed.html

bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):
(WebCore::constructWebGLArray):

bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::V8Float32Array::constructorCallback):

bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::V8Float64Array::constructorCallback):

bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::V8Int16Array::constructorCallback):

bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::V8Int32Array::constructorCallback):

bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::V8Int8Array::constructorCallback):

bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::V8Uint16Array::constructorCallback):

bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::V8Uint32Array::constructorCallback):

bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::V8Uint8Array::constructorCallback):

bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::V8Uint8ClampedArray::constructorCallback):

4:48 PM Changeset in webkit [124385] by piman@chromium.org

5 edits in trunk/Source

[chromium] Fix lost context handling on hud layer
https://bugs.webkit.org/show_bug.cgi?id=92915

Reviewed by Adrienne Walker.

On lost context we need to release CCScopedTextures, otherwise later on
we will try to re-allocate it using a stale CCResourceProvider.

Test CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext
extended.

Source/WebCore:

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::didLoseContext):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

4:43 PM Changeset in webkit [124384] by thakis@chromium.org

2 edits
1 delete in trunk/Source/WebKit/chromium

[chromium/mac] Delete WebImageCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=92910

Reviewed by James Robinson.

It's been unused since the switch to skia.
Also remove now-unneeded *CG.cpp exclusion rule.

WebKit.gyp:
src/WebImageCG.cpp: Removed.

4:27 PM Changeset in webkit [124383] by dgrogan@chromium.org

3 edits
36 adds in trunk/LayoutTests

IndexedDB: integer version layout tests
https://bugs.webkit.org/show_bug.cgi?id=92560

Reviewed by Nate Chapin.

Most of the integer version layout tests are here, with failures in
the expected files. This will allow us to incrementally implement
upgradeneeded and integer versions and just make the big patch in bug
89505 smaller.

There are two added skips to TestExpectations, one test exposes a bug
in the current implementation, causing an assert to fail. The other
times out in DRT so we will run it as a content_browsertest for the
time being.

platform/chromium/TestExpectations:
storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt: Added.
storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html: Added.
storage/indexeddb/intversion-and-setversion-expected.txt: Added.
storage/indexeddb/intversion-and-setversion.html: Added.
storage/indexeddb/intversion-blocked-expected.txt: Added.
storage/indexeddb/intversion-blocked.html: Added.
storage/indexeddb/intversion-close-between-events-expected.txt: Added.
storage/indexeddb/intversion-close-between-events.html: Added.
storage/indexeddb/intversion-close-in-oncomplete-expected.txt: Added.
storage/indexeddb/intversion-close-in-oncomplete.html: Added.
storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt: Added.
storage/indexeddb/intversion-close-in-upgradeneeded.html: Added.
storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt: Added.
storage/indexeddb/intversion-delete-in-upgradeneeded.html: Added.
storage/indexeddb/intversion-gated-on-delete-expected.txt: Added.
storage/indexeddb/intversion-gated-on-delete.html: Added.
storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt: Added.
storage/indexeddb/intversion-invalid-setversion-has-no-side-effects.html: Added.
storage/indexeddb/intversion-long-queue-expected.txt: Added.
storage/indexeddb/intversion-long-queue.html: Added.
storage/indexeddb/intversion-omit-parameter-expected.txt: Added.
storage/indexeddb/intversion-omit-parameter.html: Added.
storage/indexeddb/intversion-open-with-version-expected.txt: Added.
storage/indexeddb/intversion-open-with-version.html: Added.

and their respective js files...

storage/indexeddb/resources/shared.js:

(unexpectedVersionChangeCallback):
(setDBNameFromPath):
(preamble):

4:15 PM Changeset in webkit [124382] by jsbell@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: API stubs to simplify WebIDBCursor API
https://bugs.webkit.org/show_bug.cgi?id=92414

Reviewed by Adam Barth.

Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land.
Adds no-op methods which will later be implemented; during the landing sequence,
Chromium will call both the new methods and the old ones. The end goal is that
the success callbacks for cursors will include the new key/primaryKey/value rather
than requiring the callee to call back into the cursor backend to fetch them.

public/WebIDBCallbacks.h:

(WebIDBCallbacks):
(WebKit::WebIDBCallbacks::onSuccess):

4:12 PM Changeset in webkit [124381] by mitz@apple.com

1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceMountainLion.a

Set the svn:mime-type property on libWebKitSystemInterfaceMountainLion.a to indicate that it is a binary.

4:05 PM Changeset in webkit [124380] by fmalita@chromium.org

435 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in SVG tests
https://bugs.webkit.org/show_bug.cgi?id=92898

Reviewed by Dirk Schulze.

svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg:
svg/animations/animate-beginElementAt.svg:
svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml:
svg/animations/animate-linear-discrete-additive-b.svg:
svg/animations/animate-linear-discrete-additive-c.svg:
svg/animations/animate-linear-discrete-additive.svg:
svg/animations/animate-list-crash.svg:
svg/animations/animate-setcurrenttime.html:
svg/animations/animate-update-crash.xhtml:
svg/animations/animateColor-additive-2a.svg:
svg/animations/animateColor-additive-2b.svg:
svg/animations/animateColor-additive-2c.svg:
svg/animations/animateColor-additive-2d.svg:
svg/animations/animateMotion-additive-1.svg:
svg/animations/animateMotion-additive-2a.svg:
svg/animations/animateMotion-additive-2b.svg:
svg/animations/animateMotion-additive-2c.svg:
svg/animations/animateMotion-additive-2d.svg:
svg/animations/animateTransform-accumulation.svg:
svg/animations/animateTransform-by-scale-1.svg:
svg/animations/animateTransform-by-scale.svg:
svg/animations/animateTransform-from-by-from-to-comparision-expected.svg:
svg/animations/animateTransform-from-by-from-to-comparision.svg:
svg/animations/animateTransform-from-by-scale-additive-sum.svg:
svg/animations/animateTransform-from-by-scale.svg:
svg/animations/animateTransform-rotate-around-point.svg:
svg/animations/animateTransform-skewX.svg:
svg/animations/animateTransform-skewY.svg:
svg/animations/animateTransform-translate.svg:
svg/animations/dynamic-modify-attributename-crash.svg:
svg/animations/keypoints-mismatch.svg:
svg/animations/length-list-animation.svg:
svg/animations/list-wrapper-assertion.svg:
svg/animations/mozilla/animateMotion-by-1.svg:
svg/animations/mozilla/animateMotion-from-to-1-expected.svg:
svg/animations/mozilla/animateMotion-from-to-1.svg:
svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg:
svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg:
svg/animations/mozilla/animateMotion-to-overridden-1.svg:
svg/animations/multiple-animateTransform-additive-sum.svg:
svg/animations/multiple-begin-animation-discrete.svg:
svg/animations/multiple-begin-animation.svg:
svg/animations/path-animation.svg:
svg/animations/repeatDur-zero.xhtml:
svg/animations/repeating-path-animation.svg:
svg/animations/resources/SVGAnimationTestCase.js:

(runAnimationTest):

svg/animations/smil-element-not-removed-crash.html:
svg/animations/smil-element-target-crash-main.html:
svg/animations/smil-leak-dynamically-added-element-instances.svg:
svg/animations/smil-leak-element-instances-noBaseValRef.svg:
svg/animations/smil-leak-element-instances.svg:
svg/animations/smil-leak-elements.svg:
svg/animations/svg-two-animate-elements-crash.svg:
svg/animations/svglength-animation-retarget-crash.html:
svg/animations/svglength-element-removed-crash.svg:
svg/as-background-image/animated-svg-as-background.html:
svg/as-background-image/svg-background-crash-on-refresh.html:
svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html:
svg/as-image/animated-svg-as-image-same-image.html:
svg/as-image/animated-svg-as-image.html:
svg/as-image/animated-svg-repaints-completely-in-hidpi.html:
svg/as-image/drag-svg-as-image.html:
svg/as-image/image-respects-deviceScaleFactor.html:
svg/as-image/image-respects-pageScaleFactor-change.html:
svg/as-image/svg-image-leak-cached-data.html:
svg/as-image/svg-image-leak-loader.html:
svg/as-image/svg-nested.html:
svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
svg/as-object/embedded-svg-size-changes-no-layout-triggers.html:
svg/as-object/embedded-svg-size-changes.html:
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html:
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html:
svg/as-object/nested-embedded-svg-size-changes.html:
svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg:
svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html:
svg/carto.net/frameless-svg-parse-error.html:
svg/carto.net/window.svg:
svg/css/crash-css-generated-content.xhtml:
svg/css/cursor-image-replace.svg:
svg/css/cursor-replace.svg:
svg/css/getComputedStyle-basic.xhtml:
svg/css/invalid-color-crash.svg:
svg/css/multiple-cursors-crash.html:
svg/css/script-tests/svg-attribute-length-parsing.js:
svg/css/script-tests/svg-attribute-parser-mode.js:
svg/css/style-change-crash.html:
svg/css/svg-ellipse-render-crash.html:
svg/custom/acid3-test-77.html:
svg/custom/anchor-on-use.svg:
svg/custom/animate-disallowed-mask-element.svg:
svg/custom/animate-disallowed-use-element.svg:
svg/custom/animate-path-discrete.svg:
svg/custom/animate-path-morphing.svg:
svg/custom/animate-target-id-changed.svg:
svg/custom/animate-target-removed-from-document.svg:
svg/custom/animate-use-crash.xhtml:
svg/custom/assert-empty-layout-attributes.svg:
svg/custom/bbox-of-g-in-symbol.svg:
svg/custom/boundingBox.html:
svg/custom/bug78700.svg:
svg/custom/bug78807.svg:
svg/custom/bug78838.html:
svg/custom/bug79798.html:
svg/custom/bug86119.html:
svg/custom/bug86392.html:
svg/custom/bug86781.html:
svg/custom/click-internal-anchor-with-use-crash.xhtml:
svg/custom/crash-inline-container-client.html:
svg/custom/crash-text-in-textpath.svg:
svg/custom/crash-textPath-attributes.html:
svg/custom/delete-modified-text-in-defs-crash.svg:
svg/custom/delete-text-crash.html:
svg/custom/delete-text-innerText-crash.html:
svg/custom/detached-outermost-svg-crash.html:
svg/custom/disallowed-text-content-rendering.svg:
svg/custom/display-table-caption-foreignObject.svg:
svg/custom/display-table-caption-inherit-foreignObject.xhtml:
svg/custom/display-table-caption-inherit-text.xhtml:
svg/custom/display-table-caption-text.svg:
svg/custom/element-instance-held-by-js-crash.svg:
svg/custom/embedded-svg-allowed-in-dashboard.xml:
svg/custom/empty-className-baseVal-crash.html:
svg/custom/filter-on-svgimage.svg:
svg/custom/font-face-move.svg:
svg/custom/font-face-name-without-name-attr.svg:
svg/custom/font-face-not-in-document.svg:
svg/custom/font-platformDestroy-crash.svg:
svg/custom/foreignObject-crash-on-hover.xml:
svg/custom/foreignobject-crash-with-absolute-positioned-children.svg:
svg/custom/frame-getSVGDocument.html:
svg/custom/g-outside-svg.html:
svg/custom/get-text-element-transform-crash.html:
svg/custom/getBBox-empty-container.html:
svg/custom/getBBox-js.svg:
svg/custom/getBBox-path.svg:
svg/custom/getBBox-perpendicular-path.svg:
svg/custom/getscreenctm-in-mixed-content2.xhtml:
svg/custom/gradient-attr-update.svg:
svg/custom/gradient-stop-display-none-crash.svg:
svg/custom/hit-test-path-stroke.svg:
svg/custom/hit-test-path.svg:
svg/custom/hit-test-unclosed-subpaths.svg:
svg/custom/hit-test-with-br.xhtml:
svg/custom/image-base-uri.svg:
svg/custom/image-clipped-hit.svg:
svg/custom/image-rescale-scroll.html:
svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
svg/custom/image-with-prefix-in-webarchive.svg:
svg/custom/insertItemBefore-from-non-list-origin.svg:
svg/custom/intersection-list-clipping.svg:
svg/custom/intersection-list-crash.svg:
svg/custom/intersection-list-nested-svg.svg:
svg/custom/intersection-list-null.svg:
svg/custom/invalid-gradient-with-xlink.svg:
svg/custom/invalid-paint-shape-mask.svg:
svg/custom/js-late-clipPath-and-object-creation.svg:
svg/custom/js-late-clipPath-creation.svg:
svg/custom/js-late-gradient-and-object-creation.svg:
svg/custom/js-late-gradient-creation.svg:
svg/custom/js-late-marker-and-object-creation.svg:
svg/custom/js-late-marker-creation.svg:
svg/custom/js-late-mask-and-object-creation.svg:
svg/custom/js-late-mask-creation.svg:
svg/custom/js-late-pattern-and-object-creation.svg:
svg/custom/js-late-pattern-creation.svg:
svg/custom/js-svg-constructors.svg:
svg/custom/js-update-container2.svg:
svg/custom/js-update-image-and-display.svg:
svg/custom/js-update-image-and-display2.svg:
svg/custom/js-update-image-and-display3.svg:
svg/custom/layout-loop.svg:
svg/custom/linking-a-03-b-all.svg:
svg/custom/linking-a-03-b-preserveAspectRatio.svg:
svg/custom/linking-a-03-b-transform.svg:
svg/custom/linking-a-03-b-viewBox-transform.svg:
svg/custom/linking-a-03-b-viewBox.svg:
svg/custom/linking-a-03-b-viewTarget.svg:
svg/custom/linking-a-03-b-zoomAndPan.svg:
svg/custom/linking-uri-01-b.svg:
svg/custom/loadevents-capturing.svg:
svg/custom/loadevents-externalresourcesrequired-displaynone.svg:
svg/custom/loadevents-externalresourcesrequired.svg:
svg/custom/loadevents-normal-displaynone.svg:
svg/custom/loadevents-normal.svg:
svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html:
svg/custom/manually-parsed-svg-allowed-in-dashboard.html:
svg/custom/marker-getPropertyValue.svg:
svg/custom/mask-changes.svg:
svg/custom/mask-invalidation.svg:
svg/custom/mouse-move-on-svg-container-standalone.svg:
svg/custom/mouse-move-on-svg-container.xhtml:
svg/custom/mouse-move-on-svg-root-standalone.svg:
svg/custom/mouse-move-on-svg-root.xhtml:
svg/custom/multiple-title-elements.svg:
svg/custom/new-image-is-html-element.svg:
svg/custom/path-getPresentationAttribute-crash.html:
svg/custom/path-getTotalLength-on-big-segment-crash.svg:
svg/custom/path-getTotalLength.svg:
svg/custom/pending-resource-after-removal.xhtml:
svg/custom/pending-resource-leak-2.svg:
svg/custom/pending-resource-leak-3.svg:
svg/custom/pending-resource-leak.svg:
svg/custom/pointer-events-image-css-transform.svg:
svg/custom/pointer-events-image.svg:
svg/custom/pointer-events-invalid-fill.svg:
svg/custom/pointer-events-on-rounded-rect.xhtml:
svg/custom/pointer-events-on-svg-with-pointer.xhtml:
svg/custom/pointer-events-on-svg-without-pointer.xhtml:
svg/custom/pointer-events-text-css-transform.svg:
svg/custom/pointer-events-text.svg:
svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml:
svg/custom/poly-points-attribute-changes.svg:
svg/custom/polyline-hittest.svg:
svg/custom/polyline-points-crash.html:
svg/custom/prevent-default.svg:
svg/custom/recursive-use.svg:
svg/custom/recursive-use2.svg:
svg/custom/repaint-moving-svg-and-div.xhtml:
svg/custom/resource-client-removal.svg:
svg/custom/resources/focus-event-handling-keyboard.js:
svg/custom/resources/focus-event-handling.js:
svg/custom/resources/link-target.html:
svg/custom/resources/linkingCircle-f.svg:
svg/custom/resources/svgsvgelement-ctm.js:
svg/custom/resources/use-instanceRoot-event-bubbling.js:

(repaintTest):

svg/custom/resources/use-instanceRoot-event-listeners.js:

(repaintTest):

svg/custom/scroll-hit-test.xhtml:
svg/custom/scroll-to-anchor-in-symbol.svg:
svg/custom/scroll-to-svg-element-assertion.html:
svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html:
svg/custom/stop-crash.svg:
svg/custom/stroke-width-click.svg:
svg/custom/svg-allowed-in-dashboard-object.html:
svg/custom/svg-features.html:
svg/custom/svg-fonts-in-html-linebreaks.html:
svg/custom/svg-fonts-no-latin-glyph.html:
svg/custom/svg-getelementid.xhtml:
svg/custom/svg-parse-overflow-1.html:
svg/custom/svg-parse-overflow-2.html:
svg/custom/svg-parse-overflow-3.html:
svg/custom/svg-parse-overflow-4.html:
svg/custom/svg-parse-overflow-5.html:
svg/custom/svg-use-style-float-crash.svg:
svg/custom/svg-width-intrinsic-crash.html:
svg/custom/symbol-viewport-element-crash.svg:
svg/custom/text-node-in-text-invalidated.svg:
svg/custom/text-tref-03-b-dynamic.svg:
svg/custom/text-tref-03-b-dynamic2.svg:
svg/custom/textPath-assert.svg:
svg/custom/textPath-set-id.svg:
svg/custom/tiling-regular-hexagonal-crash.svg:
svg/custom/tref-clone-crash.html:
svg/custom/tref-shadowdom.html:
svg/custom/use-animation-in-fill.html:
svg/custom/use-crash-in-non-wellformed-document.svg:
svg/custom/use-crash-pending-resource.svg:
svg/custom/use-crash-using-children-before-destroy.svg:
svg/custom/use-crash-when-href-change.svg:
svg/custom/use-detach.svg:
svg/custom/use-display-none.svg:
svg/custom/use-elementInstance-event-target.svg:
svg/custom/use-elementInstance-methods.svg:
svg/custom/use-event-handler-on-referenced-element.svg:
svg/custom/use-event-handler-on-use-element.svg:
svg/custom/use-external-crash.svg:
svg/custom/use-instanceRoot-as-event-target.xhtml:
svg/custom/use-instanceRoot-event-listener-liveness.xhtml:
svg/custom/use-instanceRoot-with-use-removed.svg:
svg/custom/use-invalid-font-face.svg:
svg/custom/use-invalid-html.xhtml:
svg/custom/use-invalid-pattern.svg:
svg/custom/use-invalid-style.svg:
svg/custom/use-move-to-offset.svg:
svg/custom/use-multiple-on-nested-disallowed-font.html:
svg/custom/use-mutation-event-crash.svg:
svg/custom/use-nested-children.svg:
svg/custom/use-nested-disallowed-target.svg:
svg/custom/use-nested-missing-target-added.svg:
svg/custom/use-nested-missing-target-removed.svg:
svg/custom/use-nested-missing-target.svg:
svg/custom/use-nested-notarget.svg:
svg/custom/use-non-existing-symbol-crash.svg:
svg/custom/use-on-use-with-child-and-empty-target.svg:
svg/custom/use-on-use-with-child.svg:
svg/custom/use-referencing-style-crash.svg:
svg/custom/use-shadow-root-parent-removal.svg:
svg/custom/use-tref-crash.svg:
svg/custom/webkit-transform-crash.html:
svg/custom/xlink-prefix-in-attributes.html:
svg/custom/xlink-to-invalid-gradient.svg:
svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml:
svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html:
svg/dom/SVGScriptElement/script-async-attr.svg:
svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg:
svg/dom/SVGScriptElement/script-clone-rerun-self.svg:
svg/dom/SVGScriptElement/script-clone-rerun.svg:
svg/dom/SVGScriptElement/script-load-and-error-events.svg:
svg/dom/SVGScriptElement/script-onerror-bubbling.svg:
svg/dom/SVGScriptElement/script-reexecution.svg:
svg/dom/SVGScriptElement/script-set-href.svg:
svg/dom/SVGStyledElement-pendingResource-crash.html:
svg/dom/SVGTransformList-empty-list-consolidation.html:
svg/dom/animated-tearoff-equality.xhtml:
svg/dom/animated-tearoff-lifespan.xhtml:
svg/dom/baseVal-animVal-crash.html:
svg/dom/baseVal-animVal-list-crash.html:
svg/dom/frame-related-api-during-load.html:
svg/dom/parent-view-layout-crash.html:
svg/dom/path-marker-removed-crash.svg:
svg/dom/resources/viewspec-parser.js:

(continueFuzzing.else.script.onload):
(continueFuzzing):

svg/dom/script-tests/SVGViewSpec.js:

(completeTest.script.onload):
(completeTest):

svg/dom/smil-methods.svg:
svg/dom/stylesheet-candidate-node-crash-main.html:
svg/dom/svg-element-attribute-js-null.xhtml:
svg/dom/symbol-embeddedAnimation.svg:
svg/dom/use-style-recalc-script-execute-crash.html:
svg/dom/use-transform.svg:
svg/dom/viewport-container-crash.svg:
svg/dom/vkern-element-crash.html:
svg/dynamic-updates/resources/SVGTestCase.js:

(createSVGTestCase):
(embedSVGTestCase):
(completeTest.script.onload):
(completeTest):

svg/dynamic-updates/resources/linkTarget.svg:
svg/filters/feBlend-invalid-mode.xhtml:
svg/filters/feColorMatrix-invalid-value.svg:
svg/filters/feComponentTransfer-style-crash.xhtml:
svg/filters/feDisplacementMap-crash-test.xhtml:
svg/filters/feImage-animated-transform-on-target-rect.svg:
svg/filters/feImage-target-reappend-to-document.svg:
svg/filters/feImage-zero-size-crash.svg:
svg/filters/feMorphology-invalid-radius.svg:
svg/filters/feMorphology-zero-radius.svg:
svg/filters/filter-after-transform-crash.svg:
svg/filters/reparent-animated-filter-target.html:
svg/filters/svg-transform-blur-crash.svg:
svg/foreignObject/absolute-position-foreign-object-child-crash.html:
svg/foreignObject/fO-fixed-position-crash.html:
svg/hittest/foreign-object-background.svg:
svg/hittest/svg-ellipse-non-scale-stroke.xhtml:
svg/hittest/svg-ellipse-rect-stroke.xhtml:
svg/hittest/svg-ellipse.xhtml:
svg/hittest/svg-inside-display-table.xhtml:
svg/hittest/svg-inside-table.xhtml:
svg/hittest/svg-padding.xhtml:
svg/hittest/svg-shapes-non-scale-stroke.html:
svg/hittest/svg-small-path.xhtml:
svg/hittest/svg-small-viewbox.xhtml:
svg/hittest/zero-length-butt-cap-path.xhtml:
svg/hittest/zero-length-round-cap-path.xhtml:
svg/hittest/zero-length-square-cap-path.xhtml:
svg/hixie/dynamic/001.xml:
svg/hixie/links/003.xml:
svg/hixie/perf/001.xml:
svg/hixie/perf/002.xml:
svg/hixie/perf/003.xml:
svg/hixie/perf/004.xml:
svg/hixie/perf/005.xml:
svg/hixie/perf/006.xml:
svg/hixie/perf/007.xml:
svg/in-html/script-external.html:
svg/in-html/script-nested.html:
svg/in-html/script-write.html:
svg/in-html/script.html:
svg/in-html/svg-assert-failure-percentage.html:
svg/path-arc-invalid.html:
svg/repaint/filter-repaint.svg:
svg/repaint/image-href-change.svg:
svg/repaint/image-with-clip-path.svg:
svg/repaint/repainting-after-animation-element-removal.svg:
svg/text/add-tspan-position-bug.html:
svg/text/caret-in-svg-text.xhtml:
svg/text/clear-floats-crash.svg:
svg/text/font-size-null-assertion.svg:
svg/text/font-size-too-large-crash.svg:
svg/text/foreignObject-text-clipping-bug.xml:
svg/text/glyphref-renderer-create-crash.html:
svg/text/highcharts-assertion.html:
svg/text/inline-text-destroy-attributes-crash.xhtml:
svg/text/modify-tspan-position-bug.html:
svg/text/resources/SelectionTestCase.js:
svg/text/select-text-svgfont.html:
svg/text/selection-doubleclick.svg:
svg/text/selection-tripleclick.svg:
svg/text/svg-rtl-text-crash.html:
svg/text/svg-zoom-large-value.xhtml:
svg/text/text-align-01-b.svg:
svg/text/text-align-02-b.svg:
svg/text/text-align-03-b.svg:
svg/text/text-align-04-b.svg:
svg/text/text-align-05-b.svg:
svg/text/text-align-06-b.svg:
svg/text/text-altglyph-01-b.svg:
svg/text/text-assert.svg:
svg/text/text-block-child-crash.xhtml:
svg/text/text-deco-01-b.svg:
svg/text/text-font-anonymous-parent.xhtml:
svg/text/text-font-invalid.html:
svg/text/text-font-uri-invalid.svg:
svg/text/text-fonts-01-t.svg:
svg/text/text-fonts-02-t.svg:
svg/text/text-intro-05-t.svg:
svg/text/text-path-01-b.svg:
svg/text/text-positioning-remove-child-crash.svg:
svg/text/text-property-with-display-none.html:
svg/text/text-spacing-01-b.svg:
svg/text/text-style-invalid.svg:
svg/text/text-style-recalc-crash.html:
svg/text/text-text-01-b.svg:
svg/text/text-text-03-b.svg:
svg/text/text-text-04-t.svg:
svg/text/text-text-05-t.svg:
svg/text/text-text-06-t.svg:
svg/text/text-text-07-t.svg:
svg/text/text-text-08-b.svg:
svg/text/text-tref-01-b.svg:
svg/text/text-tselect-01-b.svg:
svg/text/text-tselect-02-f.svg:
svg/text/text-tspan-01-b.svg:
svg/text/text-ws-01-t.svg:
svg/text/text-ws-02-t.svg:
svg/text/textPathBoundsBug.svg:
svg/text/textpath-reference-crash.html:
svg/text/tref-event-listener-crash.svg:
svg/text/tspan-getComputedTextLength.svg:
svg/transforms/percent-transform-values.xhtml:
svg/transforms/transform-origin-presentation-attribute.xhtml:
svg/webarchive/svg-cursor-subresources-expected.webarchive:
svg/webarchive/svg-cursor-subresources.svg:
svg/webarchive/svg-feimage-subresources-expected.webarchive:
svg/webarchive/svg-feimage-subresources.svg:
svg/webarchive/svg-script-subresouces-expected.webarchive:
svg/webarchive/svg-script-subresouces.svg:
svg/zoom/page/zoom-getBoundingClientRect.xhtml:
svg/zoom/page/zoom-zoom-coords.xhtml:
svg/zoom/resources/testPageZoom.js:

(repaintTest):
(completeDynamicTest.script.onload):
(completeDynamicTest):

svg/zoom/resources/testTextZoom.js:

(repaintTest):

3:56 PM Changeset in webkit [124379] by kseo@webkit.org

2 edits in trunk/Source/WebCore

Read tag names and attributes from the saved tokens in HTMLElementStack
https://bugs.webkit.org/show_bug.cgi?id=92830

Reviewed by Adam Barth.

This is a follow-up patch for r123577.
Replaced top()->hasTagName(x) with topStackItem()->hasTagName(x).
Also replaced item->element()->hasTagName(x) with item->hasTagName(x).

No new tests, covered by existing tests.

html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::pop):
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::popCommon):

3:53 PM Changeset in webkit [124378] by dpranke@chromium.org

5 edits in trunk/Tools

test-webkitpy: clean up handling of tests to skip
https://bugs.webkit.org/show_bug.cgi?id=92909

Reviewed by Ryosuke Niwa.

This change moves the handling of tests to skip into main.py
where it is at least slightly more findable and generic.

Also fix a couple of lint nits.

Scripts/webkitpy/test/finder.py:

(Finder.init):
(Finder.skip):
(Finder._default_names):

Scripts/webkitpy/test/main.py:

(main):
(Tester.skip):

Scripts/webkitpy/test/main_unittest.py:

(TesterTest.test_no_tests_found):

Scripts/webkitpy/test/runner_unittest.py:

3:52 PM Changeset in webkit [124377] by dpranke@chromium.org

5 edits in trunk/Tools

test-webkitpy: remove --skip-integrationtests flag
https://bugs.webkit.org/show_bug.cgi?id=92907

Reviewed by Ryosuke Niwa.

This flag is no longer used since the tests complete quickly.

Also clean up the unused skip_if_parallel arg in finder, and
make a couple of lint fixes.

Scripts/webkitpy/test/finder.py:

(Finder.find_names):
(Finder._default_names):

Scripts/webkitpy/test/finder_unittest.py:

(FinderTest.check_names):
(FinderTest.test_default_names):

Scripts/webkitpy/test/main.py:

(Tester._parse_args):
(Tester.run):

Scripts/webkitpy/test/main_unittest.py:

(TesterTest.test_no_tests_found):

3:27 PM Changeset in webkit [124376] by piman@chromium.org

3 edits in trunk/Source/WebCore

[chromium] remove unused fields from LayerRendererCapabilities
https://bugs.webkit.org/show_bug.cgi?id=92906

Reviewed by James Robinson.

No new tests (just removing dead code).

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
(LayerRendererCapabilities):

3:26 PM Changeset in webkit [124375] by jamesr@google.com

5 edits
2 adds in trunk/Source/WebCore

[chromium] Move compositor HUD font atlas generation out of compositor core
https://bugs.webkit.org/show_bug.cgi?id=92901

Reviewed by Adrienne Walker.

This moves the font atlas generation out of CCFontAtlas into a separate helper class and ports the CCFontAtlas
text drawing code over to use skia directly.

WebCore.gypi:
platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Added.

(WebCore):
(WebCore::wrapPositionIfNeeded):
(WebCore::CompositorHUDFontAtlas::generateFontAtlas):

platform/graphics/chromium/CompositorHUDFontAtlas.h: Added.

(WebCore):
(CompositorHUDFontAtlas):

platform/graphics/chromium/cc/CCFontAtlas.cpp:

(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::CCFontAtlas::~CCFontAtlas):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):

platform/graphics/chromium/cc/CCFontAtlas.h:

(WebCore):
(CCFontAtlas):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

3:21 PM Changeset in webkit [124374] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] Race condition between first layout and viewport attributes initialization
https://bugs.webkit.org/show_bug.cgi?id=92902

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-08-01
Reviewed by Noam Rosenthal.

Initializing m_rawAttributes from QtViewportHandler to avoid calculation of random
scale factors on the first layout is triggered.

UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::QtViewportHandler):

3:16 PM Changeset in webkit [124373] by rniwa@webkit.org

5 edits
2 moves in trunk/Tools

Generalize SheriffIRCBot to prepare for PerfBot
https://bugs.webkit.org/show_bug.cgi?id=92912

Reviewed by Adam Barth.

Renamed SheriffIRCBot to IRCBot and generalized to support non-sheriffbot IRC bot in the future.
This will be useful when I add an experimental perf EWS IRC bot.

Scripts/webkitpy/tool/bot/irc_command.py:

(Whois.execute):

Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest):

Scripts/webkitpy/tool/bot/ircbot.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py.

(Eliza): Moved from irc_command.
(Eliza.init):
(Eliza.execute):
(IRCBot):
(IRCBot.init):
(IRCBot.irc_delegate):
(IRCBot._parse_command_and_args):
(IRCBot.process_message):

Scripts/webkitpy/tool/bot/ircbot_unittest.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py.

(run):
(IRCBotTest):
(IRCBotTest.test_eliza): Moved from IRCCommandTest.
(IRCBotTest.test_parse_command_and_args):
(IRCBotTest.test_exception_during_command):

Scripts/webkitpy/tool/bot/sheriffircbot.py: Removed.
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Removed.
Scripts/webkitpy/tool/commands/sheriffbot.py:

(SheriffBot.begin_work_queue):

Scripts/webkitpy/webkitpy.pyproj:

3:12 PM Changeset in webkit [124372] by peter@chromium.org

12 edits
2 adds in trunk

[Text Autosizing] Provide an API for influencing the font scale factor
https://bugs.webkit.org/show_bug.cgi?id=92882

Reviewed by Adam Barth.

Source/WebCore:

Add the font scale factor to settings, and provide an API in
window.internal.settings to change it from layout tests.

The font scale factor applied to Text Autosizing influences the sizing
of text, and will influence the scaling of boosted blocks once the
implementation progresses. For Android, it will be set to the font size
chosen in the user's system-wide preferences.

Test: fast/text-autosizing/font-scale-factor.html

page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore):
(WebCore::Settings::setTextAutosizingFontScaleFactor):

page/Settings.h:

(Settings):
(WebCore::Settings::textAutosizingFontScaleFactor):

rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processBlock):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setTextAutosizingFontScaleFactor):
(WebCore):

testing/InternalSettings.h:

(Backup):
(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit/chromium:

Add an API to change Text Autosizing's font scale factor.

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setTextAutosizingFontScaleFactor):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

Add a basic test. More usable tests should be added later, as it's
really hard to test this accurately in this phase of the implementation,
and Text Autosizing is still subject to various bugs.

fast/text-autosizing/font-scale-factor-expected.html: Added.
fast/text-autosizing/font-scale-factor.html: Added.

2:34 PM Changeset in webkit [124371] by commit-queue@webkit.org

3 edits
5 adds in trunk

CSP should correctly block plugin resources rendered in PluginDocuments.
https://bugs.webkit.org/show_bug.cgi?id=92675

Patch by Mike West <mkwst@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

Source/WebCore:

In certain cases, plugins aren't loaded directly, but are stuffed into a
newly-created PluginDocument before rendering. While we were already
correctly populating information that allowed us to make decisions about
that document's security origin, and already dealing with sandbox
status by creating a 'SinkDocument' that ignored plugin data, we weren't
correctly inheriting the parent frame's Content Security Policy. This
patch ensures that PluginDocuments correctly inherit their parent's
Content Security Policy, meaning that the plugin is blocked or allowed
according to the policy of the protected resource in which the
PluginDocument is embedded.

Tests: http/tests/security/contentSecurityPolicy/object-src-url-allowed.html

http/tests/security/contentSecurityPolicy/object-src-url-blocked.html

dom/Document.cpp:

(WebCore::Document::initContentSecurityPolicy):

Populate a created PluginDocument with its frame's parent's Content
Security Policy.

LayoutTests:

http/tests/plugins/resources/mock-plugin.pl: Added.

This lovely perl script mocks a plugin by sending a
'Content-Type application/x-webkit-test-netscape' header.

http/tests/security/contentSecurityPolicy/object-src-url-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/object-src-url-allowed.html: Added.
http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt: Added.
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html: Added.

Test that non-'data:' URLs that end up in PluginDocuments are also
dealt with correctly by CSP.

2:27 PM Changeset in webkit [124370] by dpranke@chromium.org

2 edits in trunk/Tools

nrwt: reenable the test for --verbose working in child processes
https://bugs.webkit.org/show_bug.cgi?id=92894

Reviewed by Ryosuke Niwa.

This change rewrites the test to not use outputcapture, meaning
that the MockHost can propagate to Worker properly and things
work again :).

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_verbose_in_child_processes):

2:24 PM Changeset in webkit [124369] by fmalita@chromium.org

3 edits
2 adds in trunk

SVG animation not working for elements inserted after parsing is finished
https://bugs.webkit.org/show_bug.cgi?id=92025

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Time containers for SVG elements inserted after document parsing is finished need to be
initialized on insertion (since they've missed the Document::implicitClose() initialization
point).

Test: svg/animations/deferred-insertion.html

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto):

LayoutTests:

svg/animations/deferred-insertion-expected.txt: Added.
svg/animations/deferred-insertion.html: Added.

2:21 PM Changeset in webkit [124368] by scheib@chromium.org

4 edits
2 adds in trunk

Block pointer lock for sandboxed iframes.
https://bugs.webkit.org/show_bug.cgi?id=92796

Reviewed by Adam Barth.

Source/WebCore:

Sandboxed iframe documents should be blocked from using the
pointer lock API until there is specification agreement
on what attribute to use to allow the feature. After
specification this restriction can be relaxed, but not
restricting it now would require breaking applications
later.

Test: http/tests/pointer-lock/iframe-sandboxed.html

dom/SecurityContext.h:
page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

LayoutTests:

Sandboxed iframe documents should be blocked from using the
pointer lock API until there is specification agreement
on what attribute to use to allow the feature.

http/tests/pointer-lock/iframe-sandboxed-expected.txt: Added.
http/tests/pointer-lock/iframe-sandboxed.html: Added.

2:19 PM Changeset in webkit [124367] by eae@chromium.org

2 edits in trunk/LayoutTests

Unreviewed chromium TestExpectations change, replace BUG_eae with a proper bug number.

platform/chromium/TestExpectations:

2:02 PM Changeset in webkit [124366] by rniwa@webkit.org

3 edits in trunk/Tools

run-perf-tests --build-directory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=92051

Reviewed by Dirk Pranke.

The bug was caused by not prepending build_directory even when one is defined.
Fixed that.

Scripts/webkitpy/layout_tests/port/base.py:

(Port._build_path):

Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_build_path):

1:49 PM Changeset in webkit [124365] by Patrick Gansterer

15 edits
1 add in trunk/Source

Replace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalTime()
https://bugs.webkit.org/show_bug.cgi?id=92286

Reviewed by Geoffrey Garen.

Add a method to GregorianDateTime to set its values to the current locale time.
Replacing all occurrences of getCurrentLocalTime with the new function allows
us to remove getCurrentLocalTime in a next step.

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Source/WebCore:

html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

Source/WTF:

GNUmakefile.list.am:
WTF.gypi:
WTF.pro:
WTF.vcproj/WTF.vcproj:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/DateMath.cpp:

(WTF::dayInYear):

wtf/DateMath.h:

(WTF):

wtf/GregorianDateTime.cpp: Added.

(WTF):
(WTF::GregorianDateTime::setToCurrentLocalTime):

wtf/GregorianDateTime.h:

(GregorianDateTime):

1:47 PM Changeset in webkit [124364] by ojan@chromium.org

2 edits in trunk/Source/WebCore

Remove code duplication in determining if display is inline or replaced
https://bugs.webkit.org/show_bug.cgi?id=92880

Reviewed by Julien Chaffraix.

Deduplicate lists of display types by using private helpers.

No new tests. No change in behavior.

rendering/style/RenderStyle.h:

1:35 PM Changeset in webkit [124363] by jonlee@apple.com

4 edits in trunk/WebKitLibraries

Update WKSI.

Reviewed by Mark Rowe.

libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceMountainLion.a:
libWebKitSystemInterfaceSnowLeopard.a:

1:33 PM Changeset in webkit [124362] by tommyw@google.com

5 edits in trunk/Source

MediaStream API: Add ExtraData capability to MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=92860

Reviewed by Adam Barth.

The Chromium port needs to store some related data in MediaStreamSource objects.

Source/Platform:

chromium/public/WebMediaStreamSource.h:

(ExtraData):
(WebKit::WebMediaStreamSource::ExtraData::~ExtraData):
(WebMediaStreamSource):

Source/WebCore:

Not testable from a LayoutTest.

platform/chromium/support/WebMediaStreamSource.cpp:

(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit):
(WebKit::WebMediaStreamSource::extraData):
(WebKit::WebMediaStreamSource::setExtraData):

platform/mediastream/MediaStreamSource.h:

(ExtraData):
(WebCore::MediaStreamSource::ExtraData::~ExtraData):
(MediaStreamSource):
(WebCore::MediaStreamSource::extraData):
(WebCore::MediaStreamSource::setExtraData):

1:20 PM Changeset in webkit [124361] by jsbell@chromium.org

7 edits
3 adds in trunk

IndexedDB: IDBCursor.continue(key) does not throw for key "behind" cursor
https://bugs.webkit.org/show_bug.cgi?id=92562

Reviewed by Ojan Vafai.

Source/WebCore:

Per spec, IDBCursor.continue(key) should throw for forward cursors
if key <= current key, and for reverse cursors if key >= current key.
Code was present on the back end but the error code was ignored, possibly
broken in a recent refactor, and there were no tests for this case.

Test: storage/indexeddb/cursor-continue-dir.html

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance): Handle async transaction termination.
(WebCore::IDBCursor::continueFunction): Move checks here from backend.

Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): Don't need direction param.
(WebCore::IDBCursorBackendImpl::continueFunction): Remove checks.

Modules/indexeddb/IDBCursorBackendImpl.h: Only IDBBackingStore::cursor needs direction now.

(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):

Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal): Drop unused param.

Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::openCursorInternal): Ditto.

LayoutTests:

Ensure cursor.continue(key) throws if key is "behind" the cursor.

storage/indexeddb/cursor-continue-dir-expected.txt: Added.
storage/indexeddb/cursor-continue-dir.html: Added.
storage/indexeddb/resources/cursor-continue-dir.js: Added.

(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(testCursors):
(testForwardCursor.request.onsuccess):
(testForwardCursor):
(testReverseCursor.request.onsuccess):
(testReverseCursor):

1:14 PM Changeset in webkit [124360] by Antti Koivisto

2 edits in trunk/Source/WebKit/mac

Assertion failure in inspector/profiler/heap-snapshot-containment-show-all.html on Lion bot
https://bugs.webkit.org/show_bug.cgi?id=92888

Reviewed by Andreas Kling.

Protect the WebInspectorWindowController so it doesn't get destroyed during [WebView close] and cause
unsafe [WebView dealloc].

WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController destroyInspectorView:]):

1:10 PM Changeset in webkit [124359] by commit-queue@webkit.org

5 edits in trunk

Source/WebCore: Don't request a clickCount of 1 on mouseMove event generated by tap gestures
https://bugs.webkit.org/show_bug.cgi?id=92779

Patch by Rick Byers <rbyers@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

mousemove events don't have a click count, so we shouldn't be passing 1
here. Note this makes no real difference in practice since the value is
ignored - fixed strictly for pedantics.

Test: fast/events/touch/gesture/gesture-click

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):

LayoutTests: Make Gesture click test validate click count in UIEvent.detail
https://bugs.webkit.org/show_bug.cgi?id=92779

Patch by Rick Byers <rbyers@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

Also validates that no dblclick event is fired for this single click.

fast/events/touch/gesture/gesture-click.html:
platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt:

12:51 PM Changeset in webkit [124358] by commit-queue@webkit.org

7 edits in trunk

Dropping webkit prefix from Vibration API
https://bugs.webkit.org/show_bug.cgi?id=92840

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-01
Reviewed by Adam Barth.

Source/WebCore:

Remove webkit prefix from navigator.webkitVibrate().

Vibration API have been entered CR already.
Firefox already implements Vibration API.

No new tests. Covered by fast/dom/navigator-vibration.html

Modules/vibration/NavigatorVibration.cpp:

(WebCore::NavigatorVibration::vibrate):

Modules/vibration/NavigatorVibration.h:

(NavigatorVibration):

Modules/vibration/NavigatorVibration.idl:

LayoutTests:

Remove webkit prefix from navigator.webkitVibrate().

fast/dom/navigator-vibration-expected.txt:
fast/dom/navigator-vibration.html:

12:42 PM Changeset in webkit [124357] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Read tag names and attributes from the saved tokens in HTMLFormattingElementList::closestElementInScopeWithName(const AtomicString&)
https://bugs.webkit.org/show_bug.cgi?id=92841

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-01
Reviewed by Adam Barth.

This is a follow-up patch for r123577.
Replaced entry.element()->hasLocalName(targetName) with entry.stackItem()->hasLocalName(targetName).

No new tests, covered by existing tests.

html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::closestElementInScopeWithName):

12:41 PM Changeset in webkit [124356] by Patrick Gansterer

2 edits in trunk/Source/WTF

Fix FastMalloc build with assertions enabled.

wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):

12:24 PM Changeset in webkit [124355] by mhahnenberg@apple.com

5 edits in trunk/Source/JavaScriptCore

C++ code should get ClassInfo from the Structure
https://bugs.webkit.org/show_bug.cgi?id=92892

Reviewed by Geoffrey Garen.

In our march to remove ClassInfo from our JSCell object headers, we can switch
C++ code over to grabbing the ClassInfo from the Structure since it is finally
safe to do so now that Structure access is safe during finalization/destruction.
The remaining JIT code changes can be done in a separate patch.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor): We don't want to clear the Structure any more
since the Structure should still be valid at this point.

heap/WeakSetInlines.h:

(JSC::WeakBlock::finalize): Ditto.

runtime/JSCell.h:

(JSC):

runtime/Structure.h:

(JSC::JSCell::classInfo): Move JSCell's classInfo() to Structure.h so it can be
inline. Use a different method of getting the JSCell's Structure based on
whether we're in GC_VALIDATION mode or not, since always using get() will cause
infinite recursion in GC_VALIDATION mode.
(JSC):

12:05 PM Changeset in webkit [124354] by commit-queue@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r123865.
http://trac.webkit.org/changeset/123865
https://bugs.webkit.org/show_bug.cgi?id=92891

This patch is causing the style-queue to fall behind
(Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue.begin_work_queue):
(StyleQueue.init):

Scripts/webkitpy/tool/commands/queues_unittest.py:

(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):

12:03 PM Changeset in webkit [124353] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

HTMLTreeBuilder passes a wrong token when pushing the head element
https://bugs.webkit.org/show_bug.cgi?id=92838

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-01
Reviewed by Adam Barth.

When the tree builder pushes the head element in the "after head" insertion mode,
it creates a HTMLStackItem from a wrong token.

Added HTMLConstructionSite::headStackItem() to retrieve the stack item for the head
element. Modified the tree builder to pass the correct stack item when pushing the head
element in the "after head" insertion mode.

No new tests, covered by existing tests.

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHeadElement):

html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSite::head):
(WebCore::HTMLConstructionSite::headStackItem):
(HTMLConstructionSite):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTag):

11:55 AM Changeset in webkit [124352] by mhahnenberg@apple.com

4 edits in trunk/Source/JavaScriptCore

MarkedBlock::sweep() should sweep another block if it can't sweep a Structure block
https://bugs.webkit.org/show_bug.cgi?id=92819

Reviewed by Geoffrey Garen.

If we are forced to allocate a new block for Structures because we are unable to safely
sweep our pre-existing Structure blocks, we should sweep another random block so that we
can start sweeping Structure blocks sooner.

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep): Change to use sweepNextBlock.
(JSC):
(JSC::IncrementalSweeper::sweepNextBlock):

heap/IncrementalSweeper.h:

(IncrementalSweeper):

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): When we can't safely sweep
our Structure blocks, call sweepNextBlock instead.

11:45 AM Changeset in webkit [124351] by allan.jensen@nokia.com

25 edits
1 add in trunk/LayoutTests

Clean-up touchadjustment tests.
https://bugs.webkit.org/show_bug.cgi?id=92869

Reviewed by Jocelyn Turcotte.

Review and cleanup the touchadjustment tests, so they are more consistent,
uses best practices and are good examples for future touchadjustment tests.

Gather commonly used functions in touchadjustment.js.
Add HTML5 doctype to ensure strict parsing rules.
Remove redundant testRunner calls, and use js-test-post.js instead.
Fix XHTMLisms in small-target-test.html
Fix ignored offset mistake in nested-touch.html that resulted in three identical tests.

touchadjustment/big-div-expected.txt:
touchadjustment/big-div.html:
touchadjustment/block-testing-expected.txt:
touchadjustment/block-testing.html:
touchadjustment/disabled-formelements-expected.txt:
touchadjustment/disabled-formelements.html:
touchadjustment/event-triggered-widgets-expected.txt:
touchadjustment/event-triggered-widgets.html:
touchadjustment/html-label-expected.txt:
touchadjustment/html-label.html:
touchadjustment/iframe.html:
touchadjustment/nested-shadow-node.html:
touchadjustment/nested-touch-expected.txt:
touchadjustment/nested-touch.html:
touchadjustment/resources/inner-frame.html:
touchadjustment/resources/touchadjustment.js: Added.

(findAbsoluteBounds):
(nodeToString):
(touchPoint):
(offsetTouchPoint):

touchadjustment/rotated-node-expected.txt:
touchadjustment/rotated-node.html:
touchadjustment/scroll-offset-expected.txt:
touchadjustment/scroll-offset.html:
touchadjustment/search-cancel.html:
touchadjustment/small-target-test-expected.txt:
touchadjustment/small-target-test.html:
touchadjustment/touch-inlines-expected.txt:
touchadjustment/touch-inlines.html:

11:42 AM Changeset in webkit [124350] by commit-queue@webkit.org

17 edits
8 moves
6 adds in trunk

[CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow object
https://bugs.webkit.org/show_bug.cgi?id=88778

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-01
Reviewed by Adam Barth.

Spec: http://www.w3.org/TR/css3-regions/#region-flow-layout-events

Source/WebCore:

This patch implements the regionLayoutUpdate event per May 3rd CSS Regions spec recommendation.
Before this patch the event was dispatched individually on each region whenever its overflow state changed. The trigger conditions are preserved with the following additions:

the event is dispatched when the last region is removed
the event is not dispatched when the named flow switches to the NULL state

Also, the NamedFlow objects are not deleted if they switch to the NULL state and have listeners attached. In that scenario the JS wrapper will not release the reference
until the parent Document is destroyed.

Tests: The old tests have been modified to use the event on the NamedFlow object rather the one on the Region. New tests have been added to verify the
correct behavior in the special states of the NamedFlow (no region chain, NULL state).

dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded): Listeners are not added on Nodes any more so the regionLayoutUpdate type was removed from the list.

dom/Document.h:
dom/EventTarget.h:

(WebCore):

dom/EventTargetFactory.in:
dom/Node.cpp:
dom/Node.h:

(Node):

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::eventTargetData):
(WebCore):
(WebCore::WebKitNamedFlow::ensureEventTargetData):
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent): The 3rd May WD says the event is bubbling. However this doesn't make sense as this object doesn't belong to the DOM tree. This was fixed in the ED.
(WebCore::WebKitNamedFlow::interfaceName):
(WebCore::WebKitNamedFlow::scriptExecutionContext):
(WebCore::WebKitNamedFlow::base): Getter for the owner Document used by the wrapper to determine if the object is reachable.

dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::refEventTarget):
(WebCore::WebKitNamedFlow::derefEventTarget):

dom/WebKitNamedFlow.idl:
rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout): The event dispatching is now handled by the implementation of RenderFlowThread.
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

rendering/RenderFlowThread.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread): The layout doesn't detect changes caused by removing the last region. This case is handled separately.
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
(WebCore):
(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired):

rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

The existing tests have been adapted to match the transition of the event on the NamedFlow interface. Also there are three more tests for the case
the region chain is removed, the flow goes in the NULL state and for the event target to match the NamedFlow object.

fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Renamed from LayoutTests/fast/regions/region-event-add-to-flow-expected.txt.
fast/regions/webkit-named-flow-event-add-to-flow.html: Renamed from LayoutTests/fast/regions/region-event-add-to-flow.html.
fast/regions/webkit-named-flow-event-expected.txt: Renamed from LayoutTests/fast/regions/region-event-expected.txt.
fast/regions/webkit-named-flow-event-no-regions-expected.txt: Added.
fast/regions/webkit-named-flow-event-no-regions.html: Added.
fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Renamed from LayoutTests/fast/regions/region-event-remove-from-dom-expected.txt.
fast/regions/webkit-named-flow-event-remove-from-dom.html: Renamed from LayoutTests/fast/regions/region-event-remove-from-dom.html.
fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Renamed from LayoutTests/fast/regions/region-event-remove-from-flow-expected.txt.
fast/regions/webkit-named-flow-event-remove-from-flow.html: Renamed from LayoutTests/fast/regions/region-event-remove-from-flow.html.
fast/regions/webkit-named-flow-event-target-expected.txt: Added.
fast/regions/webkit-named-flow-event-target.html: Added.
fast/regions/webkit-named-flow-event-to-null-expected.txt: Added.
fast/regions/webkit-named-flow-event-to-null.html: Added.
fast/regions/webkit-named-flow-event.html: Renamed from LayoutTests/fast/regions/region-event.html.

11:23 AM Changeset in webkit [124349] by rniwa@webkit.org

3 edits in trunk/Tools

run-perf-tests throws an exception when the output json is malformed
https://bugs.webkit.org/show_bug.cgi?id=92887

Reviewed by Dirk Pranke.

Catch exceptions and gracefully fail. Also split _generate_json into smaller methods.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_output): Extracted from _generate_json.
(PerfTestsRunner._merge_source_json): Ditto; catch all exceptions since they are too many
exceptions to consder here.
(PerfTestsRunner._merge_outputs): Ditto.
(PerfTestsRunner._generate_output_files): Extracted from _generate_json.

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(_test_run_with_json_output): Don't assert logs when we except an non-zero exit code.
(create_runner_and_setup_results_template): Extracted from test_run_generates_results_page.
(test_run_generates_results_page):
(test_run_with_bad_output_json): Added.
(test_run_with_bad_json_source): Added.
(test_run_with_upload_json):

11:17 AM Changeset in webkit [124348] by dpranke@chromium.org

2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS to 149416.

Unreviewed.

DEPS:

11:16 AM Changeset in webkit [124347] by robert@webkit.org

16 edits
4 adds in trunk

CSS 2.1 failure: margin-collapse-012 fails
https://bugs.webkit.org/show_bug.cgi?id=80219

Reviewed by Eric Seidel.

Source/WebCore:

Tests: css2.1/20110323/margin-collapse-012.htm

fast/css/margin-collapse-abspos-negmargin.htm

I also ran this against the full margin-collapse-* CSS 2.1 suite without regressions.

Per http://www.w3.org/TR/CSS21/box.html#collapsing-margins don't collapse the margins of
positioned blocks. Instead, just use the margin of the sibling/container to offset the
positioned block's logical top - its own margin gets added in later at
RenderBox::computePositionedLogicalHeightUsing().

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):

LayoutTests:

css2.1/20110323/margin-collapse-012.htm: Added.
css2.1/20110323/margin-collapse-012-expected.html: Added.
fast/css/margin-collapse-abspos-negmargin-expected.html: Added.
fast/css/margin-collapse-abspos-negmargin.htm: Added.

fast/block/positioning/auto/001.html:
fast/block/positioning/auto/002.html:
fast/block/positioning/auto/vertical-lr/002.html:
fast/block/positioning/auto/vertical-rl/002.html:
fast/dynamic/staticY.html: Remove the margins from these tests so the results remain the same. The new results are consistent with FF.

platform/chromium-linux/fast/box-sizing/box-sizing-expected.png:
platform/chromium-win/compositing/overflow/clip-descendents-expected.txt:
platform/chromium-win/fast/box-sizing/box-sizing-expected.txt: I've rebaselined these - removing the margins doesn't seem helpful.

11:10 AM Changeset in webkit [124346] by Lucas Forschler

4 edits in branches/safari-536.26-branch/Source

Versioning.

11:05 AM Changeset in webkit [124345] by Lucas Forschler

1 copy in tags/Safari-536.26.1

New Tag.

10:49 AM Changeset in webkit [124344] by commit-queue@webkit.org

2 edits in trunk/Tools

Regression(r124135): nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92845

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-01
Reviewed by Dirk Pranke.

Disabled the failing test. The Workers spawned by this test are using Host()
instead of MockHost() and trying to access the real filesystem instead of the
MockFilesytem.

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.disabled_test_verbose):

10:48 AM Changeset in webkit [124343] by commit-queue@webkit.org

2 edits in trunk/Tools

keyring.get_password may raise an exception.
https://bugs.webkit.org/show_bug.cgi?id=92876

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-01
Reviewed by Dirk Pranke.

keyring.get_password sometimes raises an exception. We wrap this call,
and also set_password to avoid breaking webkit-patch in that case.

Scripts/webkitpy/common/net/credentials.py:

(Credentials._offer_to_store_credentials_in_keyring):
(Credentials.read_credentials):

10:43 AM Changeset in webkit [124342] by commit-queue@webkit.org

7 edits
1 delete in trunk/Source

Unreviewed, rolling out r124334.
http://trac.webkit.org/changeset/124334
https://bugs.webkit.org/show_bug.cgi?id=92879

Broke MemoryInstrumentationTest.sizeOf from webkit_unit_tests
on Chromium canaries (Requested by apavlov1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

Source/WebCore:

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedObject):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):

inspector/InspectorMemoryAgent.cpp:

(WebCore):

inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalTypeSize):

Source/WebKit/chromium:

WebKit.gypi:
tests/MemoryInstrumentationTest.cpp: Removed.

10:37 AM Changeset in webkit [124341] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix gcc 4.7 compile warnings.
https://bugs.webkit.org/show_bug.cgi?id=92797

Patch by Han Shen <shenhan@google.com> on 2012-08-01
Reviewed by Kentaro Hara.

GCC 4.7 gives (more strict) warnings on uninitialized variables,
fixed by providing initilization values.

Tested by gcc 4.7 building. No change in behavior.

platform/graphics/filters/arm/NEONHelpers.h:

(WebCore::loadRGBA8AsFloat): Add initilizaton value for local variable.

9:54 AM Changeset in webkit [124340] by wangxianzhu@chromium.org

7 edits in trunk

Layout Test fast/text/descent-clip-in-scaled-page.html is failing on linux since it was added
https://bugs.webkit.org/show_bug.cgi?id=91386

Reviewed by Tony Chang.

Tools:

Added font mapping from SubpixelPositioningAhem to Ahem on Linux and Android
(used in layout test fast/text/descent-clip-in-scaled-page.html).
Added font mapping from SubpixelPositioning to Times New Roman on Android to match Linux
(used in platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html)

DumpRenderTree/chromium/android_main_fonts.xml:
DumpRenderTree/chromium/fonts.conf:

LayoutTests:

The failure was because of the caching of font data. Now use the fake font families which are
only used when subpixel text positioing is enabled. This is the same method used in
platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html.

On Linux and Android, the fake font families will be mapped to Time New Roman and Ahem, respectively.
On other platforms, they will fall back to system default fonts.

fast/text/descent-clip-in-scaled-page-expected.html:
fast/text/descent-clip-in-scaled-page.html:
platform/chromium/TestExpectations:

9:40 AM Changeset in webkit [124339] by rniwa@webkit.org

3 edits
4 adds in trunk

REGRESSION(r122498): Assertion failure: m_nodeListCounts is sometimes not zero in the Document destructor
https://bugs.webkit.org/show_bug.cgi?id=92742

Reviewed by Andreas Kling.

Source/WebCore:

The bug was caused by adoptTreeScope's not always calling unregisterNodeListCache and registerNodeListCache
on node lists that use m_atomicNameCaches and m_nameCaches.

Tests: fast/dom/NodeList/nodelist-moved-to-fragment-2.html

fast/dom/NodeList/nodelist-moved-to-fragment.html

dom/NodeRareData.h:

(WebCore::NodeListsNodeData::adoptTreeScope):

LayoutTests:

Add regression tests for two types of node lists: one that uses addCacheWithName and the other that uses
addCacheWithAtomicName.

fast/dom/NodeList/nodelist-moved-to-fragment-2-expected.txt: Added.
fast/dom/NodeList/nodelist-moved-to-fragment-2.html: Added.
fast/dom/NodeList/nodelist-moved-to-fragment-expected.txt: Added.
fast/dom/NodeList/nodelist-moved-to-fragment.html: Added.

9:15 AM Changeset in webkit [124338] by zhajiang@rim.com

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Allow client side to add and remove origin access whitelist entries
https://bugs.webkit.org/show_bug.cgi?id=92790

Reviewed by Yong Li.

PR: 172658
Add two new APIs to add and remove origin access whitelist entries.
Initialize the BlackBerryAllowCrossSiteRequests WebSetting to false.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::addOriginAccessWhitelistEntry):
(WebKit):
(BlackBerry::WebKit::WebPage::addOriginAccessWhitelistEntry):
(BlackBerry::WebKit::WebPagePrivate::removeOriginAccessWhitelistEntry):
(BlackBerry::WebKit::WebPage::removeOriginAccessWhitelistEntry):

Api/WebPage.h:
Api/WebPage_p.h:

(WebPagePrivate):

Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

8:57 AM Changeset in webkit [124337] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Consolidate suppression of keyboard requests.
https://bugs.webkit.org/show_bug.cgi?id=92871

Reviewed by Antonio Gomes.

Reduce VKB requests even more by applying the filter on
all requests during processing.

Reviewed Internally by Gen Mak.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):

8:45 AM Changeset in webkit [124336] by zeno.albisser@nokia.com

7 edits in trunk

[Qt]REGRESSION(r123786): It made 3 fast/animation tests fail.
https://bugs.webkit.org/show_bug.cgi?id=92490

Source/WebKit/qt:

QAbstractAnimation:start() is implicitly calling updateTime
without going through the event loop. This resulted in executing
scripted animation callbacks right when registering a first callback.

Reviewed by Noam Rosenthal.

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::RefreshAnimation::scheduleAnimation):

Invoke QAbstractAnimation::start() method through the event loop.

Source/WebKit2:

Make sure that scripted animations are also serviced when
forceRepaint is being executed. As this is what is being used for
running layout tests.
Move servicing of scripted animations and layoutIfNeeded call
into a separate function syncDisplayState.
This function can then be called from forceRepaint as well as from
performScheduledLayerFlush.

Reviewed by Noam Rosenthal.

WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit):
(WebKit::LayerTreeCoordinator::syncDisplayState):

WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

LayoutTests:

Reviewed by Noam Rosenthal.

platform/qt/Skipped: Unskipping the tests listed below.

fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-detach-element.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/dom/Window/post-message-crash.html

7:58 AM Changeset in webkit [124335] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Crashes in NetworkResourcesData.
https://bugs.webkit.org/show_bug.cgi?id=92874

Reviewed by Yury Semikhatsky.

inspector/NetworkResourcesData.cpp:

(WebCore::contentSizeInBytes):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):

7:38 AM Changeset in webkit [124334] by loislo@chromium.org

7 edits
1 add in trunk/Source

Web Inspector: test native memory instrumentation code with help of unittests
https://bugs.webkit.org/show_bug.cgi?id=92743

Reviewed by Yury Semikhatsky.

Source/WebCore:

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

dom/MemoryInstrumentation.h:

inspector/InspectorMemoryAgent.cpp:

(WebCore):

inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationImpl):

Source/WebKit/chromium:

Test a part of existing Native Memory Instrumentation code with help of unit tests.
6 tests were added and two bugs were fixed.

WebKit.gypi:
tests/MemoryInstrumentationTest.cpp: Added.

(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::reportedSize):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers):
(NotInstrumented):
(Instrumented):
(WebCore::Instrumented::Instrumented):
(WebCore::Instrumented::~Instrumented):
(WebCore::Instrumented::reportMemoryUsage):
(WebCore::TEST):
(InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):

7:33 AM Changeset in webkit [124333] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Memory leak found while running webaudio tests
https://bugs.webkit.org/show_bug.cgi?id=92861

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-01
Reviewed by Philippe Normand.

Fix a memory leak in decodeAudioForBusCreation by adopting
an allocation of GInputStream.

No new tests. No change in behavior.

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::decodeAudioForBusCreation):

6:55 AM Changeset in webkit [124332] by commit-queue@webkit.org

15 edits in trunk/Source

Web Inspector: count DOM storage cache memory for native snapshot
https://bugs.webkit.org/show_bug.cgi?id=91617

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-08-01
Reviewed by Yury Semikhatsky.

Source/Platform:

Add memory size used for DOM storage cache reporting interface.

chromium/public/WebStorageArea.h:

(WebStorageArea):
(WebKit::WebStorageArea::memoryBytesUsedByCache):

Source/WebCore:

Add memory size used for DOM storage cache reporting interface.
Report it to the native memory snapshot instrumentation framework.

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):
(WebCore):

inspector/InspectorDOMStorageAgent.h:

(InspectorDOMStorageAgent):

inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::dumpDOMStorageCache):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

inspector/InspectorMemoryAgent.h:

(WebCore):
(WebCore::InspectorMemoryAgent::create):
(InspectorMemoryAgent):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

storage/StorageArea.h:

(StorageArea):

storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::memoryBytesUsedByCache):
(WebCore):

storage/StorageAreaImpl.h:

(StorageAreaImpl):

Source/WebKit/chromium:

Add memory size used for DOM storage cache reporting interface.

src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::memoryBytesUsedByCache):
(WebCore):

src/StorageAreaProxy.h:

(StorageAreaProxy):

6:39 AM Changeset in webkit [124331] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Disable tap highlight when transparent color is specified
https://bugs.webkit.org/show_bug.cgi?id=92849

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-01
Reviewed by Antonio Gomes.

When the web page specifies -webkit-tap-highlight-color:rgba(0,0,0,0)
or any color with alpha value 0, we should disable the tap highlight.

WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::draw):

6:29 AM Changeset in webkit [124330] by yurys@chromium.org

25 edits in trunk/Source/WebCore

Web Inspector: add CSSStyleSheet memory instrumentation
https://bugs.webkit.org/show_bug.cgi?id=92748

Reviewed by Antti Koivisto.

Added MemoryInstrumentation for CSSStyleSheet, StyleSheetContents, StyleRule,
CSSSelectorList and StylePropertySet. The coverage is not complete as the
patch was growing too big.

css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::length):
(WebCore):
(WebCore::CSSSelectorList::reportMemoryUsage):

css/CSSSelectorList.h:

(WebCore):
(CSSSelectorList):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):
(WebCore):

css/CSSStyleSheet.h:

(WebCore):
(CSSStyleSheet):

css/MediaList.cpp:

(WebCore):
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):

css/MediaList.h:

(WebCore):
(MediaQuerySet):
(MediaList):

css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):
(WebCore):

css/MediaQuery.h:

(WebCore):
(MediaQuery):

css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):
(WebCore):

css/MediaQueryExp.h:

(WebCore):
(MediaQueryExp):

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::reportMemoryUsage):
(WebCore):

css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage): We cannot make
reportMemoryUsage virtual as it would add vtable to StyleRuleBase
and its descendants and would blow its memory footprint. This
is why we have a switch over StyleRule type here.
(WebCore):
(WebCore::StyleRule::reportMemoryUsage):
(WebCore::StyleRulePage::reportMemoryUsage):
(WebCore::StyleRuleFontFace::reportMemoryUsage):
(WebCore::StyleRuleBlock::reportMemoryUsage):
(WebCore::StyleRuleMedia::reportMemoryUsage):
(WebCore::StyleRuleRegion::reportMemoryUsage):

css/StyleRule.h:

(WebCore):
(StyleRuleBase):
(StyleRule):
(StyleRuleFontFace):
(StyleRulePage):
(StyleRuleBlock):
(StyleRuleMedia):
(StyleRuleRegion):

css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):
(WebCore):

css/StyleSheetContents.h:

(WebCore):
(StyleSheetContents):

dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

dom/MemoryInstrumentation.h:

(WebCore::MemoryClassInfo::addInstrumentedVectorPtr):
(WebCore::MemoryClassInfo::addVectorPtr):

5:28 AM Changeset in webkit [124329] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r124325.
http://trac.webkit.org/changeset/124325
https://bugs.webkit.org/show_bug.cgi?id=92865

broke android build (Requested by mnaganov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

5:23 AM Changeset in webkit [124328] by Patrick Gansterer

2 edits in trunk/Source/WTF

Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API
https://bugs.webkit.org/show_bug.cgi?id=92851

Reviewed by Hajime Morita.

r124069 missed to change one export macro, which is needed
to make the windows port with USE(EXPORT_MACROS).

wtf/text/StringImpl.h:

(StringImpl):

5:23 AM Changeset in webkit [124327] by commit-queue@webkit.org

3 edits in trunk/Tools

[EFL] Dump a backtrace in case of a crash on the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=92843

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-01
Reviewed by Csaba Osztrogonác.

We are already dumping the backtraces when automated tests are
crashing, but only for the WebProcess. This patch adds the same
hooks for the UIProcess.

TestWebKitAPI/efl/main.cpp:

(main):

WebKitTestRunner/efl/main.cpp:

(main):

5:03 AM Changeset in webkit [124326] by keishi@webkit.org

4 edits in trunk

Attempt to fix flakiness of color-suggestion-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92848

Reviewed by Kent Tamura.

Source/WebCore:

Resources/colorSuggestionPicker.js:

(ColorPicker.prototype._layout): We put the width and height into
variables so we don't call window.onresize twice.

LayoutTests:

We observed console.log bleeding into the next test.

platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html:

4:51 AM Changeset in webkit [124325] by abarth@webkit.org

2 edits in trunk/Tools

[Chromium] Merge final nits to DumpRenderTree.gyp for Android
https://bugs.webkit.org/show_bug.cgi?id=90920

Reviewed by Tony Chang.

This patch contains the last few small changes to DumpRenderTree.gyp
from the chromium-android branch. After this change, this file will be
fully merged.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

4:41 AM Changeset in webkit [124324] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] ImageDiff should use float division instead of integer
https://bugs.webkit.org/show_bug.cgi?id=92859

Reviewed by Zoltan Herczeg.

DumpRenderTree/qt/ImageDiff.cpp:

(main):

4:41 AM Changeset in webkit [124323] by apavlov@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed, suppress fast/forms/input-widths.html failure, which is due to r124314.

platform/chromium/TestExpectations:

4:20 AM Changeset in webkit [124322] by Martin Robinson

4 edits in releases/WebKitGTK/webkit-1.8

.: Update the NEWS file and configure.ac in preparation for the 1.8.2 release

Reviewed by Carlos Garcia Campos.

configure.ac: Update the version.

Source/WebKit/gtk: Update the NEWS file and configure.ac in preparation for the 1.8.2 release.

Reviewed by Carlos Garcia Campos.

NEWS: Add the news.

4:19 AM Changeset in webkit [124321] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merge 124177 - [GTK] New lines automatically and repeatedly added to list items in Etherpad
https://bugs.webkit.org/show_bug.cgi?id=89971

Reviewed by Ryosuke Niwa.

Disable the deletion UI by default. This UI, which was enabled as a side-effect
of the addition of the private editing API, seems to expose a bug in Etherpad
which causes the continuous insertion of bullet points.

WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.

3:07 AM Changeset in webkit [124320] by Patrick Gansterer

5 edits in trunk/Source/WTF

[WIN] Add missing WTF export macros to functions
https://bugs.webkit.org/show_bug.cgi?id=92842

Reviewed by Hajime Morita.

When we switch the windows port to USE(EXPORT_MACROS) we
need to export all functions referenced by WebKit.dll.

wtf/ThreadingPrimitives.h:

(WTF):

wtf/dtoa.h:

(WTF):

wtf/dtoa/double-conversion.h:

(StringToDoubleConverter):

wtf/unicode/UTF8.h:

2:33 AM Changeset in webkit [124319] by yosin@chromium.org

26 edits
1 delete in trunk/Tools

Unreviewed, rolling out r124313.
http://trac.webkit.org/changeset/124313
https://bugs.webkit.org/show_bug.cgi?id=92855

Compilation failed on Chromium ports (Requested by yosin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeCommon.cpp: Removed.
DumpRenderTree/chromium/DumpRenderTree.cpp:

(runTest):
(main):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::runFileTest):
(TestShell::dump):

DumpRenderTree/chromium/TestShell.h:

(TestParams):
(TestParams::TestParams):
(TestShell):

DumpRenderTree/efl/CMakeLists.txt:
DumpRenderTree/efl/DumpRenderTree.cpp:

(parseCommandLineOptions):
(getFinalTestURL):
(getExpectedPixelHash):
(runTest):
(shouldDumpPixelsAndCompareWithExpected):
(main):

DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeGlobalsFromCommandLineOptions):
(dump):
(runTest):
(main):

DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions):
(dumpRenderTree):
(dump):
(runTest):

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::processLine):

DumpRenderTree/win/DumpRenderTree.cpp:

(dump):
(runTest):
(dllLauncherEntryPoint):

DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/wscript:
DumpRenderTree/wx/DumpRenderTreeWx.cpp:

(dump):
(runTest):
(MyApp::OnInit):

GNUmakefile.am:
Scripts/old-run-webkit-tests:
Scripts/webkitpy/layout_tests/port/base.py:

(Port.supports_switching_pixel_tests_per_test):
(Port):
(Port._supports_switching_pixel_tests_per_test):
(Port.should_run_as_pixel_test):

Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.cmd_line):
(Driver._command_from_driver_input):

Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._supports_switching_pixel_tests_per_test):

Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.supports_switching_pixel_tests_per_test):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

WebKitTestRunner/TestController.h:

(TestController):

2:24 AM Changeset in webkit [124318] by Carlos Garcia Campos

5 edits in trunk/Source

Unreviewed. Fix GTK+ build with recent version of GTK+.

Use g_threads_enter/leave instead of the wrapper macros. This
gives a compile warning because they are now deprecated but at
least it builds.

Source/WebCore:

plugins/gtk/gtk2xtbin.c:

(xt_event_prepare):
(xt_event_check):
(xt_event_dispatch):

Source/WebKit2:

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunAsModal): Fix enter/leave order.

UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

2:23 AM Changeset in webkit [124317] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, typo fix.

platform/qt/TestExpectations:

2:20 AM Changeset in webkit [124316] by pkasting@chromium.org

2 edits
16 adds in trunk/LayoutTests

[Chromium] Rebaseline a test.
https://bugs.webkit.org/show_bug.cgi?id=92444

Unreviewed, test expectation updates.

platform/chromium-linux-x86/platform/chromium/fast: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms/color: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium-linux/platform/chromium/fast/forms: Added.
platform/chromium-linux/platform/chromium/fast/forms/color: Added.
platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms: Added.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color: Added.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium-win-xp/platform/chromium/fast/forms: Added.
platform/chromium-win-xp/platform/chromium/fast/forms/color: Added.
platform/chromium-win-xp/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium-win/platform/chromium/fast/forms: Added.
platform/chromium-win/platform/chromium/fast/forms/color: Added.
platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium/TestExpectations:

2:19 AM Changeset in webkit [124315] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Web Inspector: Add native memory used by GlyphCache to the snapshot
https://bugs.webkit.org/show_bug.cgi?id=90615

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-08-01
Reviewed by Yury Semikhatsky.

Adds interface for reporting memory usage of platform specific
components.
Report memory usage of the font cache allocated by skia in chromium.

inspector/InspectorMemoryAgent.cpp:

(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):

platform/MemoryUsageSupport.h:

(MemoryUsageSupport):
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):

platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):

platform/qt/MemoryUsageSupportQt.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):

2:17 AM Changeset in webkit [124314] by yosin@chromium.org

2 edits in trunk/Source/WebCore

[CSS] Add selectors for multiple fields time input UI.
https://bugs.webkit.org/show_bug.cgi?id=92834

Reviewed by Kent Tamura.

This patch adds new selectors and "height" property to spin button
for multiple fields time input UI.

RenderTextControlSingleLine::layout() sets height of spin button for
input type "number" and other input types using RenderTextControlSingleLine
as renderer object. However, multiple fields time input UI doesn't use
it and needs to set height of spin button.

No new tests. This patch doesn't change behavior.

css/html.css:

(input::-webkit-datetime-edit): Added.
(input::-webkit-datetime-edit-ampm-field): Added.
(input::-webkit-datetime-edit-hour-field): Added.
(input::-webkit-datetime-edit-millisecond-field): Added.
(input::-webkit-datetime-edit-minute-field): Added.
(input::-webkit-datetime-edit-minute-field[readonly]): Added. This selector
is used for step>=3600 second and time format contains minute field.
(input::-webkit-datetime-edit-second-field): Added.
(input::-webkit-datetime-edit-second-field[readonly]): Added. This selector
is used for step>=60 second and time format contains second field.
(input::-webkit-inner-spin-button): Add "height" property for using
spin button other than RenderTextControlSingleLine.

2:07 AM Changeset in webkit [124313] by kbalazs@webkit.org

26 edits
1 add in trunk/Tools

All ports should support per test switching of pixel testing
https://bugs.webkit.org/show_bug.cgi?id=92398

Reviewed by Dirk Pranke.

Teach all test drivers to accept a per test control of whether
to dump pixels. Drivers now accept a -p/--pixel-test argument
on the standart input that means that running the current
test as pixel test is allowed (even if the expected hash is
missing). Removed the --pixel-tests command line option since
there is no need for it anymore.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/DumpRenderTree.h:

(TestCommand::TestCommand):
(TestCommand):

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeCommon.cpp: Added.

(CommandTokenizer):
(CommandTokenizer::CommandTokenizer):
(CommandTokenizer::pump):
(CommandTokenizer::next):
(CommandTokenizer::hasNext):
(die):
(parseInputLine):
Common logic to parse the input line from the standard input (or from the command line
in standalone mode). Made it somewhat general so we can easily add more arguments if
there is a need.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(runTest):
(main):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::runFileTest):
(TestShell::dump):

DumpRenderTree/chromium/TestShell.h:

(TestParams::TestParams):
(TestShell):

DumpRenderTree/efl/CMakeLists.txt:
DumpRenderTree/efl/DumpRenderTree.cpp:

(parseCommandLineOptions):
(runTest):
(shouldDumpPixelsAndCompareWithExpected):
(main):

DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeGlobalsFromCommandLineOptions):
(dump):

DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions):
(dumpRenderTree):

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::processLine):

DumpRenderTree/win/DumpRenderTree.cpp:

(dump):
(runTest):
(dllLauncherEntryPoint):

DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/wscript:
DumpRenderTree/wx/DumpRenderTreeWx.cpp:

(dump):
(runTest):
(MyApp::OnInit):

Scripts/old-run-webkit-tests: Pass --pixel-test before the hash.

Changed the separator form ' to : because it don't need to be escaped
when passing manually on the comand line.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.should_run_as_pixel_test): Removed now that all ports supports it.

Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.cmd_line): Don't pass --pixel-tests anymore.
(Driver._command_from_driver_input):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestCommand::TestCommand):
(TestCommand):
(WTR):
(CommandTokenizer):
(WTR::CommandTokenizer::CommandTokenizer):
(WTR::CommandTokenizer::pump):
(WTR::CommandTokenizer::next):
(WTR::CommandTokenizer::hasNext):
(WTR::die):
(WTR::parseInputLine):
(WTR::TestController::runTest):

WebKitTestRunner/TestController.h:

(TestController):
Duplicate the logic for parsing the command line because
unfortunately there is no way to share code between
WebKitTestRunner and DumpRenderTree.

1:53 AM Changeset in webkit [124312] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Mark a couple of flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=92850
https://bugs.webkit.org/show_bug.cgi?id=92852

Unreviewed, test expectation updates.

platform/chromium/TestExpectations:

1:11 AM Changeset in webkit [124311] by zandobersek@gmail.com

3 edits
1 add in trunk/LayoutTests

Unreviewed GTK gardening, adding an image failure expectation for a
CSS3 Flexbox test that relies on the subpixel layout to be enabled.

Also adding a missing platform-specific expectation for a CSS2.1 test
that somehow got removed in r124142.

platform/gtk/TestExpectations:
platform/gtk/css2.1/20110323/block-replaced-width-001-expected.png:
platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Added.

1:03 AM Changeset in webkit [124310] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Make HTMLConstructionSite::createHTMLElement(AtomicHTMLToken*) private.
https://bugs.webkit.org/show_bug.cgi?id=92846

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-01
Reviewed by Eric Seidel.

This method is internal to HTMLConstructionSite.

No functional change.

html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

12:57 AM Changeset in webkit [124309] by kinuko@chromium.org

3 edits
2 adds in trunk

[Filesystem] Assertion on $0.webkitEntries while on the input field.
https://bugs.webkit.org/show_bug.cgi?id=91954

Reviewed by Kent Tamura.

Accessing .webkitEntries should not crash when input type is not for file.

Source/WebCore:

Tests: fast/filesystem/input-access-entries.html

Modules/filesystem/HTMLInputElementFileSystem.cpp:

(WebCore::HTMLInputElementFileSystem::webkitEntries):

LayoutTests:

fast/filesystem/input-access-entries.html: Added.
fast/filesystem/input-access-entries-expected.txt: Added.

12:53 AM Changeset in webkit [124308] by commit-queue@webkit.org

6 edits in trunk

Web Inspector: Profiles: cleanup HeapSnapshotReceiver interface
https://bugs.webkit.org/show_bug.cgi?id=92390

Patch by Eugene Klyuchnikov <eustas.big@gmail.com> on 2012-08-01
Reviewed by Yury Semikhatsky.

Source/WebCore:

Remove callback parameter and return values from methods startLoading
and finishLoading. All implementations of HeapSnapshotReceiver honestly
override interface methods now.

inspector/front-end/HeapSnapshotLoader.js: Adopted new API.
inspector/front-end/HeapSnapshotProxy.js: Adopted new API.

(WebInspector.HeapSnapshotLoaderProxy.prototype.isStarted): Added.
(WebInspector.HeapSnapshotLoaderProxy.prototype.addConsumer): Added.
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
Explicitly finishes loading and build snapshot.

inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotReceiver.prototype.startLoading):
Removed callback parameter and return value.
(WebInspector.HeapSnapshotReceiver.prototype.finishLoading):
Removed callback parameter.
(WebInspector.HeapSnapshotSaveToFileReceiver): Adopted new API.

LayoutTests:

Fixed test to adopt new API.

inspector/profiler/heap-snapshot-loader.html:

12:37 AM QtWebKit edited by hotukdeals.com2@yahoo.co.uk

(diff)

12:32 AM ExportingSymbols edited by Kaustubh Atrawalkar

(diff)

12:30 AM Changeset in webkit [124307] by Martin Robinson

2 edits in trunk/Tools

Add the jhbuild source directory to the builtin object

Reviewed by Philippe Normand.

It seems that the jhbuild script explicitly looks for the SRCDIR builtin when
initializing. This is necessary for loading the jhbuild from the checkout directory.

jhbuild/jhbuildutils.py:

(enter_jhbuild_environment_if_available): Set SRCDIR to the source directory.

12:29 AM Changeset in webkit [124306] by loislo@chromium.org

9 edits
2 adds in trunk/Source/WebCore

Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
https://bugs.webkit.org/show_bug.cgi?id=92751

Reviewed by Yury Semikhatsky.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/InspectorAllInOne.cpp:
inspector/InspectorMemoryAgent.cpp:

(WebCore):

inspector/MemoryInstrumentationImpl.cpp: Added.

(WebCore):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore::MemoryInstrumentationImpl::deferInstrumentedPointer):
(WebCore::MemoryInstrumentationImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):

inspector/MemoryInstrumentationImpl.h: Added.

(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalTypeSize):

12:01 AM BuildBot edited by hotukdeals.com2@yahoo.co.uk

(diff)

Jul 31, 2012:

11:23 PM Changeset in webkit [124305] by pkasting@chromium.org

2 edits
2 adds in trunk/LayoutTests

[Chromium] Add a baseline and modify expectations.
https://bugs.webkit.org/show_bug.cgi?id=66417
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=82547
https://bugs.webkit.org/show_bug.cgi?id=84802

Unreviewed, test expectation updates.

One baseline was ommitted from http://trac.webkit.org/changeset/124296 .

platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/chromium/TestExpectations:

11:11 PM Changeset in webkit [124304] by morrita@google.com

9 edits in trunk

Internals::setAuthorShadowDOMForAnyElementEnabled should be on InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=92823

Reviewed by Kentaro Hara.

Source/WebCore:

This change moves Internals::setAuthorShadowDOMForAnyElementEnabled() to
InternalSettings to support original value recovery.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAuthorShadowDOMForAnyElementEnabled): Moved from Internals.
(WebCore):

testing/InternalSettings.h:

(Backup):
(InternalSettings):

testing/InternalSettings.idl:
testing/Internals.cpp:
testing/Internals.h:

(Internals):

testing/Internals.idl:

LayoutTests:

Followed the changed on Internals API.

fast/dom/shadow/input-with-validation.html:

11:05 PM Changeset in webkit [124303] by keishi@webkit.org

2 edits in trunk/LayoutTests

Mark fast/forms/color/color-suggestion-picker-appearance.html as missing or image mismatch

Unreviewed.

platform/chromium/TestExpectations:

10:17 PM Changeset in webkit [124302] by fischman@chromium.org

2 edits in trunk/LayoutTests

Layout Test media/video-currentTime-set.html is still flaky
https://bugs.webkit.org/show_bug.cgi?id=85003

Unreviewed gardening; test was fixed in r115462 but expectation was left behind.

platform/chromium/TestExpectations:

10:10 PM Changeset in webkit [124301] by scheib@chromium.org

7 edits
2 adds in trunk

webkitRequestPointerLock and webkitExitPointerLock limited to the same document of an active Pointer lock.
https://bugs.webkit.org/show_bug.cgi?id=91284

Reviewed by Adrienne Walker.

Previously, cross-talk between documents was possible, e.g. allowing one
document.webkitExitPointerLock to exit the lock from another document.
This change brings Pointer Lock closer to the Fullscreen API behavior,
and stops the pointer lock target from being transferable between
documents.

Source/WebCore:

Test: http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html

dom/Document.cpp:

(WebCore::Document::webkitExitPointerLock):

page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

LayoutTests:

http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-expected.txt: Added.
http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html: Added.
http/tests/resources/pointer-lock/iframe-common.js:

(document.onwebkitpointerlockchange):
(document.onwebkitpointerlockerror):

pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
pointer-lock/pointerlockchange-pointerlockerror-events.html:

10:07 PM Changeset in webkit [124300] by fischman@chromium.org

2 edits in trunk/LayoutTests

[Chromium][Mac] Assertion failure in null_audio_sink.cc running WebGL video layout test on 10.5 debug bots
https://bugs.webkit.org/show_bug.cgi?id=89529

Unreviewed gardening.

Should be mostly/all cured on Mac. See http://crbug.com/138583 for ongoing details.

platform/chromium/TestExpectations:

10:02 PM Changeset in webkit [124299] by keishi@webkit.org

2 edits in trunk/Source/WebCore

ColorInputType::typeMismatchFor is returning the opposite bool
https://bugs.webkit.org/show_bug.cgi?id=92836

Reviewed by Kent Tamura.

No new tests. Covered by color-suggestion-picker-appearance.html.

html/ColorInputType.cpp:

(WebCore::ColorInputType::typeMismatchFor):

9:57 PM Changeset in webkit [124298] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=85952
https://bugs.webkit.org/show_bug.cgi?id=92835

Unreviewed, test expectation updates.

platform/chromium/TestExpectations:

9:48 PM Changeset in webkit [124297] by commit-queue@webkit.org

4 edits
2 adds in trunk

-webkit-flex-flow does not work with inherit/initial values
https://bugs.webkit.org/show_bug.cgi?id=92709

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-31
Reviewed by Ojan Vafai.

Source/WebCore:

Add a new handler for flex-flow and move flex to StyleBuilder to mirror the standard pattern for handling initial/inherit in shorthands.

Test: css3/flexbox/flex-flow-initial.html

css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Added handlers for flex and flex-flow.

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Removed hand written logic for handling flex.

LayoutTests:

Test that flex-flow handles 'initial' as expected.

css3/flexbox/flex-flow-initial-expected.txt: Added.
css3/flexbox/flex-flow-initial.html: Added.

9:14 PM Changeset in webkit [124296] by pkasting@chromium.org

34 edits
16 adds
1 delete in trunk/LayoutTests

[Chromium] Rebaselines and test expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=66953
https://bugs.webkit.org/show_bug.cgi?id=72746
https://bugs.webkit.org/show_bug.cgi?id=74157
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=83051

Unreviewed, test expectation updates.

Mostly rebaselining for https://bugs.webkit.org/show_bug.cgi?id=72746 .

platform/chromium-linux-x86/fast/writing-mode: Added.
platform/chromium-linux-x86/fast/writing-mode/english-lr-text-expected.png: Added.
platform/chromium-linux-x86/transitions: Added.
platform/chromium-linux-x86/transitions/default-timing-function-expected.png: Added.
platform/chromium-linux-x86/transitions/svg-text-shadow-transition-expected.png: Added.
platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
platform/chromium-linux/fast/repaint/text-shadow-expected.png:
platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.png:
platform/chromium-linux/fast/text/shadow-no-blur-expected.png:
platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-linux/fast/text/stroking-decorations-expected.png:
platform/chromium-linux/fast/text/stroking-expected.png:
platform/chromium-linux/fast/writing-mode/english-lr-text-expected.png:
platform/chromium-linux/transitions/default-timing-function-expected.png:
platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/text-shadow-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/text-shadow-horizontal-expected.png: Added.
platform/chromium-mac-snowleopard/fast/text/shadow-no-blur-expected.png: Added.
platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-mac-snowleopard/fast/text/stroking-expected.png: Removed.
platform/chromium-mac-snowleopard/transitions/cross-fade-border-image-expected.png:
platform/chromium-mac-snowleopard/transitions/default-timing-function-expected.png: Added.
platform/chromium-mac-snowleopard/transitions/svg-text-shadow-transition-expected.png: Added.
platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png: Added.
platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
platform/chromium-mac/fast/repaint/text-shadow-expected.png:
platform/chromium-mac/fast/repaint/text-shadow-horizontal-expected.png:
platform/chromium-mac/fast/text/shadow-no-blur-expected.png:
platform/chromium-mac/fast/text/stroking-decorations-expected.png:
platform/chromium-mac/fast/writing-mode/english-lr-text-expected.png:
platform/chromium-mac/transitions/default-timing-function-expected.png:
platform/chromium-mac/transitions/svg-text-shadow-transition-expected.png:
platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-win-xp/fast/text/stroking-decorations-expected.png: Added.
platform/chromium-win-xp/fast/text/stroking-expected.png: Added.
platform/chromium-win-xp/fast/writing-mode/english-lr-text-expected.png: Added.
platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png:
platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-win/fast/text/stroking-decorations-expected.png:
platform/chromium-win/fast/text/stroking-expected.png:
platform/chromium-win/fast/writing-mode/english-lr-text-expected.png:
platform/chromium-win/transitions/default-timing-function-expected.png:
platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
platform/chromium/TestExpectations:

9:03 PM Changeset in webkit [124295] by eae@chromium.org

14 edits
2 adds in trunk

Float imprecision causes incorrect wrapping in LineLayout with subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=92778

Reviewed by Eric Seidel.

Source/WebCore:

Due to float imprecision an incorrect wrapping decision is made in
certain cases where the values being compare are close but not exactly
the same. This can happen as the size of blocks is represented in layout
units while line layout uses floats.

Test: fast/sub-pixel/inline-block-should-not-wrap.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitsOnLine):
Use LayoutUnit::epsilon when comparing values as that is the maximum
precision we support.

LayoutTests:

Add test ensuring that an inline block isn't wrapped incorrectly.

fast/sub-pixel/inline-block-should-not-wrap-expected.html: Added.
fast/sub-pixel/inline-block-should-not-wrap.html: Added.
platform/mac-lion/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac-wk2/Skipped:
platform/mac/Skipped:
platform/qt-4.8/Skipped:
platform/qt/Skipped:
platform/win-wk2/Skipped:
platform/win-xp/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

8:56 PM Changeset in webkit [124294] by Joone Hur

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.
Marked the following tests as pass, but they don't pass on 32-bits machines.

sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.16_sin/S15.8.2.16_A7.html
sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.18_tan/S15.8.2.18_A7.html
svg/css/stars-with-shadow.html

platform/efl/TestExpectations:

8:50 PM Changeset in webkit [124293] by fischman@chromium.org

2 edits in trunk/LayoutTests

Layout tests media/event-attributes.html and media/video-playbackrate.html failing
https://bugs.webkit.org/show_bug.cgi?id=73692

Unreviewed gardening.

Should be mostly/all cured. See http://crbug.com/138583 for ongoing details.

platform/chromium/TestExpectations:

8:42 PM Changeset in webkit [124292] by fischman@chromium.org

3 edits in trunk/LayoutTests

media/video-currentTime-delay.html shouldn't be a performance test, so remove artificial deadline.
https://bugs.webkit.org/show_bug.cgi?id=92816

Unreviewed test cleanup.

media/video-currentTime-delay.html:
platform/chromium/TestExpectations:

8:41 PM Changeset in webkit [124291] by hayato@chromium.org

3 edits in trunk/Source/WebCore

Refactor EventDispatcher::dispatchEvent() so that we can call each phase (Caputure, Target and Bubbling) of event dispatching separately.
https://bugs.webkit.org/show_bug.cgi?id=92621

Reviewed by Dimitri Glazkov.

This is one of the required refactorings to support event
propagation for seamless iframes. I've removed 'goto' statements
from EventDispatcher::dispatchEvent() as a result.

I've verified that all separated functions are successfully
inlined. I could not see any performance regression. The
benchmark result is:

Before this patch:
% ./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html
Running 1 tests
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 243.986607143 ms
median= 242.297619048 ms, stdev= 5.74748351315 ms, min= 239.80952381 ms, max= 268.0 ms

After this patch:
% ./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html
Running 1 tests
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 242.291666667 ms
median= 240.452380952 ms, stdev= 5.8718643632 ms, min= 238.214285714 ms, max= 266.5 ms

No new tests, no behavior change.

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):

dom/EventDispatcher.h:

(WebCore):
(EventDispatcher):

8:29 PM Changeset in webkit [124290] by yosin@chromium.org

9 edits in trunk/Source

[Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
https://bugs.webkit.org/show_bug.cgi?id=92822

Reviewed by Kent Tamura.

Source/WebCore:

This patch touches header files for compiling files which contains
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

platform/text/DateTimeFormat.h:
platform/text/LocaleICU.h:
platform/text/LocaleWin.h:
platform/text/LocalizedDate.h:
platform/text/LocalizedNumber.h:
platform/text/mac/LocaleMac.h:

Source/WebKit/chromium:

This patch enables ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS for Chromium
port except for Android.

features.gypi: Add ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS=1 to "feature_defines"

block of OS != "android".

8:22 PM Changeset in webkit [124289] by pkasting@chromium.org

2 edits
1 add in trunk/LayoutTests

[Chromium] Rebaseline a test and correct two expectations
http://crbug.com/23477

Unreviewed, test expectation updates.

One line was extraneous after http://trac.webkit.org/changeset/124245 ,
another after http://trac.webkit.org/changeset/124284 .

platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
platform/chromium/TestExpectations:

7:55 PM Changeset in webkit [124288] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium]Upstream WebViewImpl:StartPageScaleAnimation changes for Chrome for Android
https://bugs.webkit.org/show_bug.cgi?id=92698

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-07-31
Reviewed by Adam Barth.

Enforce the maximum and minimum scroll positions after the scale has changed.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::startPageScaleAnimation):

src/WebViewImpl.h:

(WebViewImpl):

7:49 PM Changeset in webkit [124287] by ojan@chromium.org

4 edits in trunk/LayoutTests

i and j keys no longer scroll in results.html
https://bugs.webkit.org/show_bug.cgi?id=92584

Reviewed by Tony Chang.

Scrolling broke with r122880 since the scrolling element is no
longer the body.

Also, fix TestNavigator to allow navigating to tests in the
unexpected passes table. That table doesn't have expand links,
so we change TestNavigator to navigate the tbody's instead, which
also happens to remove a bunch of unnecessary tree-walking.

fast/harness/resources/results-test.js:
fast/harness/results-expected.txt:
fast/harness/results.html:

7:43 PM Changeset in webkit [124286] by fischman@chromium.org

4 edits in trunk/LayoutTests

[Chromium] Layout Test http/tests/media/media-source/webm/video-media-source-*.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85952

Unreviewed test cleanup.

Timeouts were fixed by acolwell@chromium.org a few weeks ago. Flakiness of seeked vs. the other events is just overspecificity in the test.

http/tests/media/media-source/video-media-source-seek-expected.txt:
http/tests/media/media-source/video-media-source-seek.html:
platform/chromium/TestExpectations:

7:39 PM Changeset in webkit [124285] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pass all file chooser settings to clients
https://bugs.webkit.org/show_bug.cgi?id=92237

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-07-31
Reviewed by Rob Buis.

Expose all file chooser settings to clients.

Api/WebPageClient.h:
WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::runOpenPanel):

7:28 PM Changeset in webkit [124284] by pkasting@chromium.org

20 edits
146 adds
5 deletes in trunk/LayoutTests

Unreviewed, test expectation updates.

platform/chromium-linux-x86/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
platform/chromium-linux-x86/css3/filters/custom: Added.
platform/chromium-linux-x86/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/chromium-linux-x86/css3/filters/custom/effect-color-check-expected.png: Added.
platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-expected.png: Added.
platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-linux-x86/fast/text/shaping: Added.
platform/chromium-linux-x86/fast/text/shaping/shaping-script-order-expected.png: Added.
platform/chromium-linux-x86/fast/text/shaping/shaping-script-order-expected.txt: Added.
platform/chromium-linux-x86/fast/text/shaping/shaping-selection-rect-expected.png: Added.
platform/chromium-linux-x86/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
platform/chromium-linux-x86/media: Removed.
platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-linux/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Added.
platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png: Added.
platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-linux/fast/text/shaping: Added.
platform/chromium-linux/fast/text/shaping/shaping-script-order-expected.png: Added.
platform/chromium-linux/fast/text/shaping/shaping-script-order-expected.txt: Added.
platform/chromium-linux/fast/text/shaping/shaping-selection-rect-expected.png: Added.
platform/chromium-linux/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
platform/chromium-linux/media/media-document-audio-repaint-expected.png:
platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-mac-snowleopard/css3/filters/custom: Added.
platform/chromium-mac-snowleopard/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/chromium-mac-snowleopard/fast/block/lineboxcontain/glyphs-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/text/shaping: Added.
platform/chromium-mac-snowleopard/fast/text/shaping/shaping-script-order-expected.png: Added.
platform/chromium-mac-snowleopard/fast/text/shaping/shaping-script-order-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/text/shaping/shaping-selection-rect-expected.png: Added.
platform/chromium-mac-snowleopard/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-mac/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/chromium-mac/fast/block/lineboxcontain/glyphs-expected.txt:
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
platform/chromium-mac/fast/text/shaping: Added.
platform/chromium-mac/fast/text/shaping/shaping-script-order-expected.png: Added.
platform/chromium-mac/fast/text/shaping/shaping-script-order-expected.txt: Added.
platform/chromium-mac/fast/text/shaping/shaping-selection-rect-expected.png: Added.
platform/chromium-mac/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
platform/chromium-mac/media/media-document-audio-repaint-expected.png:
platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
platform/chromium-win-xp/compositing/reflections: Added.
platform/chromium-win-xp/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
platform/chromium-win-xp/compositing/shadows: Added.
platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png: Added.
platform/chromium-win-xp/css1/formatting_model: Added.
platform/chromium-win-xp/css1/formatting_model/floating_elements-expected.png: Added.
platform/chromium-win-xp/css3/filters/custom: Added.
platform/chromium-win-xp/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/chromium-win-xp/css3/filters/custom/effect-color-check-expected.png: Added.
platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-expected.png: Added.
platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-win-xp/fast/forms/datalist: Added.
platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
platform/chromium-win-xp/fast/text/shaping: Added.
platform/chromium-win-xp/fast/text/shaping/shaping-script-order-expected.png: Added.
platform/chromium-win-xp/fast/text/shaping/shaping-script-order-expected.txt: Added.
platform/chromium-win-xp/fast/text/shaping/shaping-selection-rect-expected.png: Added.
platform/chromium-win-xp/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
platform/chromium-win-xp/media: Removed.
platform/chromium-win/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-win/css1/formatting_model/floating_elements-expected.png:
platform/chromium-win/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/chromium-win/css3/filters/custom/effect-color-check-expected.png: Added.
platform/chromium-win/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
platform/chromium-win/css3/filters/custom/filter-repaint-custom-expected.png: Added.
platform/chromium-win/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
platform/chromium-win/fast/text/shaping: Added.
platform/chromium-win/fast/text/shaping/shaping-script-order-expected.png: Added.
platform/chromium-win/fast/text/shaping/shaping-script-order-expected.txt: Added.
platform/chromium-win/fast/text/shaping/shaping-selection-rect-expected.png: Added.
platform/chromium-win/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
platform/chromium-win/media/media-document-audio-repaint-expected.png:
platform/chromium-win/media/media-document-audio-repaint-expected.txt:
platform/chromium/TestExpectations:
platform/efl/css1/formatting_model/floating_elements-expected.png: Removed.

7:04 PM Changeset in webkit [124283] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap
https://bugs.webkit.org/show_bug.cgi?id=92151

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-31
Reviewed by Darin Fisher.

public/WebInputEvent.h:

(WebGestureEvent):

src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

7:03 PM Changeset in webkit [124282] by rniwa@webkit.org

3 edits
2 adds in trunk

REGRESSION(r120979): Node list returned by getElementsByTagNameNS isn't invalidated when children changes
https://bugs.webkit.org/show_bug.cgi?id=92705

Reviewed by Abhishek Arya.

Source/WebCore:

The bug was caused by a typo in NodeListsNodeData::invalidateCaches. We need to invalidate
tag name node lists when child nodes change and not when attributes change.

Test: fast/dom/NodeList/nodelist-namespace-invalidation.html

dom/Node.cpp:

(WebCore::NodeListsNodeData::invalidateCaches):

LayoutTests:

Add a regression test to ensure node lists returned by getElementsByTagNameNS are invalidated
when child nodes are added or removed.

fast/dom/NodeList/nodelist-namespace-invalidation-expected.txt: Added.
fast/dom/NodeList/nodelist-namespace-invalidation.html: Added.

6:51 PM Changeset in webkit [124281] by dpranke@chromium.org

5 edits in trunk/Tools

nrwt: move actual test-running code into layout_test_runner.py
https://bugs.webkit.org/show_bug.cgi?id=92806

Reviewed by Ryosuke Niwa.

This is the final patch in manager-refactoring series (for now).
This moves all of the logic to actually run the tests into
layout_test_runner (in a new LayoutTestRunner) class. Now
the mechanics of actually executing all of the tests are
contained in one file (of course the actual work of talking to
DRT/WTR and diff'ing the results is still in single_test_runner).

Now manager is left with setting up and tearing down the test
environment, finding the tests to run, and processing the
results of the tests, which is a pretty managable amount of code
(no pun intended).

The unit tests for manager were split in two and all of the
runner-specific tests moved into layout_test_runner_unittest.
They were significantly cleaned up to be easier to read and
maintain as a part of this.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(TestRunInterruptedException):
(TestRunInterruptedException.init):
(TestRunInterruptedException.reduce):
(LayoutTestRunner):
(LayoutTestRunner.init):
(LayoutTestRunner.test_key):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.run_tests.worker_factory):
(LayoutTestRunner.run_tests.instead):
(LayoutTestRunner._mark_interrupted_tests_as_skipped):
(LayoutTestRunner._interrupt_if_at_failure_limits):
(LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
(LayoutTestRunner._update_summary_with_result):
(LayoutTestRunner.start_servers_with_lock):
(LayoutTestRunner.stop_servers_with_lock):
(LayoutTestRunner.handle):
(LayoutTestRunner._handle_started_test):
(LayoutTestRunner._handle_finished_test_list):
(LayoutTestRunner._handle_finished_test_list.find):
(LayoutTestRunner._handle_finished_test):

Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(FakePrinter):
(FakePrinter.print_workers_and_shards):
(FakePrinter.print_finished_test):
(FakePrinter.write):
(FakePrinter.write_update):
(FakePrinter.flush):
(LockCheckingRunner):
(LockCheckingRunner.init):
(LockCheckingRunner.handle_finished_list):
(LayoutTestRunnerTests):
(LayoutTestRunnerTests._runner):
(LayoutTestRunnerTests._result_summary):
(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_http_locking):
(LayoutTestRunnerTests.test_perf_locking):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
(LayoutTestRunnerTests.test_update_summary_with_result):
(LayoutTestRunnerTests.test_servers_started):
(LayoutTestRunnerTests.test_servers_started.start_http_server):
(LayoutTestRunnerTests.test_servers_started.start_websocket_server):
(LayoutTestRunnerTests.test_servers_started.stop_http_server):
(LayoutTestRunnerTests.test_servers_started.stop_websocket_server):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):
(Manager.init):
(Manager._is_http_test):
(Manager):
(Manager._is_websocket_test):
(Manager._websocket_tests):
(Manager._prepare_lists):
(Manager._is_ref_test):
(Manager.run):
(Manager._run_tests):
(Manager._look_for_new_crash_logs):
(Manager._show_results_html_file):

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_summarized_results_wontfix):

6:48 PM Changeset in webkit [124280] by dpranke@chromium.org

5 edits
1 add in trunk/Tools

nrwt: move sharding logic into layout_test_runner.py
https://bugs.webkit.org/show_bug.cgi?id=92805

Reviewed by Ryosuke Niwa.

The sharding logic is specific to how we actually run the tests,
so it belongs in this file instead of manager.py or finder.py.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(Worker._run_single_test):
(TestShard):
(TestShard.init):
(TestShard.repr):
(TestShard.eq):
(Sharder):
(Sharder.init):
(Sharder.shard_tests):
(Sharder.shard_tests.or):
(Sharder._shard_in_two):
(Sharder._shard_every_file):
(Sharder._shard_by_directory):
(Sharder._resize_shards):
(Sharder._resize_shards.divide_and_round_up):
(Sharder._resize_shards.extract_and_flatten):
(Sharder._resize_shards.split_at):
(Sharder._dir_for_test_input):
(Sharder.test_key):
(Sharder.natural_sort_key):
(Sharder.natural_sort_key.tryint):

Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Added.

(SharderTests):
(SharderTests.get_test_input):
(SharderTests.get_shards):
(SharderTests.get_shards.split):
(SharderTests.assert_shards):
(SharderTests.test_shard_by_dir):
(SharderTests.test_shard_by_dir_sharding_ref_tests):
(SharderTests.test_shard_every_file):
(SharderTests.test_shard_in_two):
(SharderTests.test_shard_in_two_sharding_ref_tests):
(SharderTests.test_shard_in_two_has_no_locked_shards):
(SharderTests.test_shard_in_two_has_no_unlocked_shards):
(SharderTests.test_multiple_locked_shards):
(NaturalCompareTest):
(NaturalCompareTest.assert_cmp):
(NaturalCompareTest.test_natural_compare):
(KeyCompareTest):
(KeyCompareTest.setUp):
(KeyCompareTest.setUp.split):
(KeyCompareTest.assert_cmp):
(KeyCompareTest.test_test_key):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager._prepare_lists):
(Manager._is_ref_test):
(Manager._run_tests):
(Manager._handle_finished_test):

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.get_options):
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_update_summary_with_result):
(ManagerTest.test_needs_servers.get_manager_with_tests):
(ManagerTest.integration_test_needs_servers.get_manager_with_tests):
(ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
(ManagerTest.test_servers_started):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

6:31 PM Changeset in webkit [124279] by tony@chromium.org

5 edits in trunk

flexbox should avoid floats
https://bugs.webkit.org/show_bug.cgi?id=92661

Reviewed by Ojan Vafai.

Source/WebCore:

Block types should avoid floats. Deprecated flexbox and grid already avoid floats.

Tests: css3/flexbox/floated-flexbox.html - added a test case.

rendering/RenderFlexibleBox.h:

LayoutTests:

Add a test case to make sure flexboxen avoid floats.

css3/flexbox/floated-flexbox.html:

5:54 PM Changeset in webkit [124278] by tony@chromium.org

4 edits
2 adds in trunk

REGRESSION: flexbox content-size fails to exclude scrollbar
https://bugs.webkit.org/show_bug.cgi?id=92667

Reviewed by Ojan Vafai.

Source/WebCore:

In r123909, we switched to computing the height using computeContentLogicalHeightUsing().
Unfortunately, this includes the scrollbar when we want the content height. Add a helper
method for computing the value needed by flexbox.

Test: css3/flexbox/content-height-with-scrollbars.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent): Use computeLogicalClientHeight
(WebCore::RenderFlexibleBox::computeLogicalClientHeight): Add new method for taking scrollbar into consideration.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use computeLogicalClientHeight
(WebCore::RenderFlexibleBox::lineBreakLength): Use computeLogicalClientHeight

rendering/RenderFlexibleBox.h:

LayoutTests:

Add column flow test cases with scrollbars forced on.

css3/flexbox/content-height-with-scrollbars-expected.html: Added.
css3/flexbox/content-height-with-scrollbars.html: Added.

5:51 PM Changeset in webkit [124277] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Remove unused method HTMLElementStack::bottom()
https://bugs.webkit.org/show_bug.cgi?id=92807

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-31
Reviewed by Kentaro Hara.

HTMLElementStack::bottom() was replaced with HTMLElementStack::rootNode()
in r80231.

No functional change, so no new tests.

html/parser/HTMLElementStack.cpp:
html/parser/HTMLElementStack.h:

(HTMLElementStack):

5:44 PM Changeset in webkit [124276] by tony@chromium.org

12 edits in trunk

-webkit-order should take an integer, not a number
https://bugs.webkit.org/show_bug.cgi?id=92688

Reviewed by Ojan Vafai.

Source/WebCore:

The spec changed back from floats to integers:
http://lists.w3.org/Archives/Public/www-style/2012Jul/0607.html

Tests: css3/flexbox/css-properties.html: Updated.

css3/flexbox/flex-order.html: Test cases modified.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

rendering/RenderFlexibleBox.cpp:

(WebCore):
(RenderFlexibleBox::OrderHashTraits):
(WebCore::RenderFlexibleBox::OrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::isDeletedValue):
(RenderFlexibleBox::OrderIterator):

rendering/RenderFlexibleBox.h:
rendering/style/RenderStyle.h:
rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Update tests.

css3/flexbox/css-properties-expected.txt:
css3/flexbox/css-properties.html:
css3/flexbox/flex-order.html:

5:34 PM Changeset in webkit [124275] by jamesr@google.com

6 edits
2 deletes in trunk/Source/WebCore

[chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=92810

Reviewed by Adrienne Walker.

The chromium compositor HUD doesn't need to use a full GraphicsContext/etc, all it draws are rectangles and a
simple stroked path. This draws the HUD with straight skia calls and removes the now unnecessary PlatformCanvas
wrapper.

WebCore.gypi:
platform/graphics/chromium/PlatformCanvas.cpp: Removed.
platform/graphics/chromium/PlatformCanvas.h: Removed.
platform/graphics/chromium/cc/CCFontAtlas.cpp:

(WebCore::CCFontAtlas::drawText):

platform/graphics/chromium/cc/CCFontAtlas.h:

(CCFontAtlas):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
(WebCore::CCHeadsUpDisplayLayerImpl::drawHudContents):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounter):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounterText):
(WebCore::CCHeadsUpDisplayLayerImpl::drawDebugRects):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:

(WebCore):

5:19 PM Changeset in webkit [124274] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

DEPS:

5:07 PM Changeset in webkit [124273] by dino@apple.com

2 edits in trunk/Source/WebCore

ImageCG doesn't initialize m_decodedPropertiesSize in BitmapImage constructor
https://bugs.webkit.org/show_bug.cgi?id=92418

Reviewed by Dan Bernstein.

Tested by existing content.

platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::BitmapImage): initialize m_decodedPropertiesSize to zero.

4:50 PM Changeset in webkit [124272] by weinig@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix the Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

4:46 PM Changeset in webkit [124271] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Maybe fix the GCC build.

heap/HeapBlock.h:

(HeapBlock): Accommodate incorrect parsing in GCC.

4:38 PM Changeset in webkit [124270] by shawnsingh@chromium.org

4 edits in trunk/Source

[chromium] Hit test points are being clipped by layers that should not clip
https://bugs.webkit.org/show_bug.cgi?id=92786

Reviewed by James Robinson.

Source/WebCore:

On impl-side hit testing for chromium compositor, we are
accidentally checking all ancestor layers for clipping, instead of
only layers that actually clip something. This patch fixes it.

Added new unit test that reproduces the scenario:

CCLayerTreeHostCommonTest.verifyHitTestingForNonClippingIntermediateLayer

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::pointIsClippedBySurfaceOrClipRect):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp: adds a test where the hit-testable layer does not overlap its parent. The parent does not clip, so the layer should still be hittable.

4:37 PM LayoutUnit edited by eae@chromium.org

(diff)

4:31 PM Changeset in webkit [124269] by jamesr@google.com

4 edits in trunk/Source/WebCore

[chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show-paint-rects
https://bugs.webkit.org/show_bug.cgi?id=92775

Reviewed by Adrienne Walker.

In r123644, the compositor HUD was turned into a normal layer. When the HUD is supposed to cover the entire
viewport - for instance if the showPlatformLayerTree or showDebugRects settings are true -
HeadsUpDisplayLayerChromium's constructor tries to size itself to its layerTreeHost()'s device viewport size.
Unfortunately, its layerTreeHost pointer is always nil in the constructor since the layer is not yet in the
tree. Additionally, this doesn't handle resize at all.

To fix this, this grabs the device viewport size and settings in a LayerChromium::update() OVERRIDE. Also
changes CCLayerTreeHost::willCommit to only reparent the HUD layer if needed instead of on every frame.

Tested manually, we don't have any layout tests for the debug HUD.

platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:

(WebCore::HeadsUpDisplayLayerChromium::create):
(WebCore::HeadsUpDisplayLayerChromium::HeadsUpDisplayLayerChromium):

platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:

(HeadsUpDisplayLayerChromium):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::willCommit):

4:24 PM Changeset in webkit [124268] by weinig@apple.com

15 edits in trunk/Source

Stop masking 8 bits off of the visited link hash. We need all the bits!
https://bugs.webkit.org/show_bug.cgi?id=92799

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

runtime/Identifier.cpp:

(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::hash):

runtime/Identifier.h:

(JSC::IdentifierCharBufferTranslator::hash):
Update for new function names.

Source/WebCore:

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::urlHostHash):

platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::hashCredentialInfo):

plugins/blackberry/PluginPackageBlackBerry.cpp:

(WebCore::PluginPackage::hash):
Update for new function names.

Source/WTF:

wtf/StringHasher.h:

(WTF::StringHasher::hashWithTop8BitsMasked):
(WTF::StringHasher::hash):
(StringHasher):
(WTF::StringHasher::computeHashAndMaskTop8Bits):
(WTF::StringHasher::hashMemory):
(WTF::StringHasher::avalancheBits):
Rename existing computeHash and hash functions to computeHashAndMaskTop8Bits
and hashWithTop8BitsMasked respectively. Add new computeHash and hash functions
that do the StringHash without the masking.

wtf/text/AtomicString.cpp:

(WTF::CStringTranslator::hash):
(WTF::UCharBufferTranslator::hash):
(WTF::HashAndCharactersTranslator::hash):
(WTF::SubstringTranslator::hash):
(WTF::LCharBufferFromLiteralDataTranslator::hash):
(WTF::AtomicString::fromUTF8Internal):

wtf/text/StringHash.h:

(WTF::CaseFoldingHash::hash):

wtf/text/StringImpl.h:

(WTF::StringImpl::setHash):

wtf/text/StringStatics.cpp:

(WTF::StringImpl::hashSlowCase):

wtf/unicode/UTF8.cpp:

(WTF::Unicode::calculateStringHashAndLengthFromUTF8MaskingTop8Bits):

wtf/unicode/UTF8.h:

Update for new function names.

4:20 PM Changeset in webkit [124267] by dpranke@chromium.org

2 edits
1 move in trunk/Tools

nrwt: rename worker.py to layout_test_runner.py
https://bugs.webkit.org/show_bug.cgi?id=92804

Reviewed by Ojan Vafai.

Home stretch of this round of manager refactoring ... I will be
moving all of the actual test-running code (which includes the
code that shards the tests for the workers) into a different
module, and it makes sense for that module to contain the actual
worker code, so I'm renaming worker.py to layout_test_runner.py.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/worker.py.

(Worker):
(Worker.init):
(Worker.del):
(Worker.start):
(Worker.handle):
(Worker._update_test_input):
(Worker._run_test):
(Worker.stop):
(Worker._timeout):
(Worker._kill_driver):
(Worker._run_test_with_timeout):
(Worker._clean_up_after_test):
(Worker._run_test_in_another_thread):
(Worker._run_test_in_another_thread.SingleTestThread):
(Worker._run_test_in_another_thread.SingleTestThread.init):
(Worker._run_test_in_another_thread.SingleTestThread.run):
(Worker._run_test_in_this_thread):
(Worker._run_single_test):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests.worker_factory):

4:07 PM Changeset in webkit [124266] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Maybe break the Windows build.

Reviewed by Anders Carlsson.

Formally objected to by Sam Weinig.

heap/HeapBlock.h:

(HeapBlock): Try to slightly improve this because we don't want Windows to control our lives.

4:05 PM Changeset in webkit [124265] by mhahnenberg@apple.com

11 edits in trunk/Source/JavaScriptCore

Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679

Reviewed by Filip Pizlo.

In order to get rid of ClassInfo from our objects, we need to be able to safely get the
ClassInfo during the destruction of objects. We'd like to get the ClassInfo out of the
Structure, but currently it is not safe to do so because the order of destruction of objects
is not guaranteed to sweep objects before their corresponding Structure. We can fix this by
sweeping Structures after everything else.

heap/Heap.cpp:

(JSC::Heap::isSafeToSweepStructures): Add a function that checks if it is safe to sweep Structures.
If the Heap's IncrementalSweeper member is null, that means we're shutting down this VM and it is
safe to sweep structures since we'll always do Structures last anyways due to the ordering of
MarkedSpace::forEachBlock.
(JSC):
(JSC::Heap::didStartVMShutdown): Add this intermediate function to the Heap that ~JSGlobalData now
calls rather than calling the two HeapTimer objects individually. This allows the Heap to null out
these pointers after it has invalidated them to prevent accidental use-after-free in the sweep()
calls during lastChanceToFinalize().

heap/Heap.h:

(Heap):

heap/HeapTimer.h:

(HeapTimer):

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::structuresCanBeSwept): Determines if it is currently safe to sweep Structures.
This decision is based on whether we have gotten to the end of the vector of blocks that need sweeping
the first time.
(JSC):
(JSC::IncrementalSweeper::doSweep): We add a second pass over the vector to sweep Structures after we
make our first pass. We now null out the slots as we sweep them so that we can quickly find the
Structures during the second pass.
(JSC::IncrementalSweeper::startSweeping): Initialize our new Structure sweeping index.
(JSC::IncrementalSweeper::willFinishSweeping): Callback that is called by MarkedSpace::sweep to notify
the IncrementalSweeper that we are going to sweep all of the remaining blocks in the Heap so it can
assume that everything is taken care of in the correct order. Since MarkedSpace::forEachBlock
iterates over the Structure blocks after all other blocks, the ordering property for sweeping Structures holds.
(JSC::IncrementalSweeper::IncrementalSweeper): Initialize Structure sweeping index.

heap/IncrementalSweeper.h: Add declarations for new stuff.

(IncrementalSweeper):

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): We now check if the current block only contains structures and
if so and it isn't safe to sweep Structures according to the Heap, we just return early instead of doing
the normal lazy sweep. If this proves to be too much of a waste in the future we can add an extra clause that
will sweep some number of other blocks in place of the current block to mitigate the cost of the floating
Structure garbage.
(JSC::MarkedAllocator::addBlock):

heap/MarkedAllocator.h:

(JSC::MarkedAllocator::zapFreeList): When we zap the free list in the MarkedAllocator, the current block is no
longer valid to allocate from, so we set the current block to null.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweepHelper): Added a couple assertions to make sure that we weren't trying to sweep Structures
at an unsafe time.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::sweep): Notify the IncrementalSweeper that the MarkedSpace will finish all currently remaining sweeping.
(JSC):

heap/MarkedSpace.h:

(JSC):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::~JSGlobalData): Call the new Heap::didStartVMShutdown.

4:04 PM Changeset in webkit [124264] by crogers@google.com

19 edits
1 copy in trunk/Source

Allow AudioDestination to support local/live audio input
https://bugs.webkit.org/show_bug.cgi?id=90318

Reviewed by Kenneth Russell.

Source/Platform:

chromium/public/WebAudioDevice.h:

(WebKit::WebAudioDevice::RenderCallback::render):
(RenderCallback):

Source/WebCore:

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
GNUmakefile.list.am:

Add AudioIOCallback.h to make files.

Modules/webaudio/AudioDestinationNode.h:
Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::render):
Change provideInput() method to render() to support optional audio input.

(AudioDestinationNode):
(WebCore::AudioDestinationNode::localAudioInputProvider):
Expose public access to an AudioSourceProvider for local/live audio input.

(LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
Add simple AudioSourceProvider implementation which dishes out a single AudioBus each
render quantum for optional local/live audio input.

Modules/webaudio/OfflineAudioDestinationNode.h:
Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::offlineRenderEntry):
(WebCore::OfflineAudioDestinationNode::offlineRender):
Simple name change using "offline" prefix to avoid confusion with AudioDestinationNode::render() method (implementing AudioIOCallback)

platform/audio/AudioDestination.h:

Switch create() method to take an AudioIOCallback instead of AudioSourceProvider.

platform/audio/AudioIOCallback.h:

(WebCore::AudioIOCallback::~AudioIOCallback):
Add new AudioIOCallback interface for audio input/output.

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

platform/audio/gstreamer/AudioDestinationGStreamer.h:

(AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::callback):

platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(_WebKitWebAudioSourcePrivate):
(webKitWebAudioSrcSetProperty):
(webKitWebAudioSrcLoop):
Small tweaks to AudioDestinationGStreamer implementation to account for switch to AudioIOCallback.

platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):

platform/audio/mac/AudioDestinationMac.h:

(AudioDestinationMac):
Small tweaks to AudioDestinationMac implementation to account for switch to AudioIOCallback.

Source/WebKit/chromium:

src/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::provideInput):
(WebCore):

src/AudioDestinationChromium.h:

(AudioDestinationChromium):

4:00 PM Changeset in webkit [124263] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix all the other builds I just broke. Maybe fix the Windows build.

heap/HeapBlock.h:

(HeapBlock): WTF?

4:00 PM Changeset in webkit [124262] by kseo@webkit.org

4 edits in trunk/Source/WebCore

Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*)
https://bugs.webkit.org/show_bug.cgi?id=92715

Reviewed by Adam Barth.

This is a follow-up patch for r123577. Changed oneBelowTop to return HTMLStackItem*.

No new tests, covered by existing tests.

html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSite::oneBelowTop):

html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::oneBelowTop):

html/parser/HTMLElementStack.h:

(HTMLElementStack):

3:59 PM Changeset in webkit [124261] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Maybe fix the Windows build.

heap/HeapBlock.h:

(HeapBlock): WTF?

3:55 PM Changeset in webkit [124260] by eric@webkit.org

2 edits in trunk/Source/WebCore

StyleResolver::canShareStyleWithElement does not need to use getAttribute for classAttr in the non-SVG case
https://bugs.webkit.org/show_bug.cgi?id=92687

Reviewed by Antti Koivisto.

Previously 10% of samples in canShareStyleWithElement hit this line, after this change < 1% do.
This is a small speedup for the non-SVG case. Since this call is made for every element
when style is resolved, any small speedup in this function matters on large documents.

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

3:44 PM Changeset in webkit [124259] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Prefer the Oracle Java plug-in over the Apple Java plug-in
https://bugs.webkit.org/show_bug.cgi?id=92780

Reviewed by Oliver Hunt.

UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::findPluginWithBundleIdentifier):
Add a new helper for finding a plug-in with the given bundle identifier.

(WebKit::checkForPreferredPlugin):
Helper function for making sure that an old plug-in is never loaded if a new plug-in is found, and that the old plug-in
is removed from the list of loaded plug-ins if the new plug-in is found.

(WebKit::PluginInfoStore::shouldUsePlugin):
Prefer the Oracle Java plug-in over the Apple Java plug-in.

3:36 PM Changeset in webkit [124258] by macpherson@chromium.org

4 edits
2 adds in trunk

Heap-use-after-free in WebCore::StyleResolver::loadPendingImage
https://bugs.webkit.org/show_bug.cgi?id=92606

Reviewed by Abhishek Arya.

Source/WebCore:

Changes StyleResolver's m_pendingImageProperties set to a map, such that for each property we keep
a RefPtr to the CSSValue used to set that property. This ensures that CSSValues are not freed before
they are needed by loadPendingImage.

Test: fast/css/variables/deferred-image-load-from-variable.html

css/StyleResolver.cpp:
css/StyleResolver.h:

LayoutTests:

Exercises the codepath where an image is loaded using a url specified via a variable.

fast/css/variables/deferred-image-load-from-variable-expected.txt: Added.
fast/css/variables/deferred-image-load-from-variable.html: Added.

3:34 PM Changeset in webkit [124257] by pkasting@chromium.org

19 edits
7 adds
14 deletes in trunk/LayoutTests

[Chromium] Rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=58008
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=92537

Unreviewed, test updates.

Mostly rebaselining for
http://src.chromium.org/viewvc/chrome?view=rev&revision=149198 , which
resulted in some i18n font changes due to
http://trac.webkit.org/changeset/83126 .

fast/dom/52776-expected.txt: Added.
fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
platform/chromium-linux-x86/fast/text/international: Removed.
platform/chromium-linux-x86/fast/text/international/bidi-neutral-run-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/compositing: Added.
platform/chromium-linux-x86/platform/chromium/compositing/scrollbars: Added.
platform/chromium-linux-x86/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt:
platform/chromium-mac-snowleopard/fast/text/complex-text-opacity-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt:
platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png:
platform/chromium-mac/fast/dom/52776-expected.png:
platform/chromium-mac/fast/dom/52776-expected.txt: Removed.
platform/chromium-mac/fast/text/complex-text-opacity-expected.png:
platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Removed.
platform/chromium-mac/fast/text/international/arabic-justify-expected.png:
platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png:
platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png:
platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
platform/chromium-win-xp/fast/text/international/bidi-neutral-run-expected.png: Removed.
platform/chromium/TestExpectations:
platform/efl/fast/dom/52776-expected.txt: Removed.
platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
platform/gtk/fast/dom/52776-expected.txt: Removed.
platform/gtk/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.

3:27 PM Changeset in webkit [124256] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Maybe fix the Windows build.

heap/HeapBlock.h:

(HeapBlock): WTF?

3:07 PM Changeset in webkit [124255] by crogers@google.com

11 edits
5 adds in trunk

Add stub implementation for MediaStreamAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=90110

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/mediastreamaudiosourcenode.html

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:

Add MediaStreamAudioSourceNode files to make files.

Modules/webaudio/AudioContext.cpp:
Modules/webaudio/AudioContext.h:
Modules/webaudio/AudioContext.idl:

(WebCore::AudioContext::createMediaStreamSource):
Add new createMediaStreamSource() method.

Modules/webaudio/AudioNode.h:

Add NodeTypeMediaStreamAudioSource.

Modules/webaudio/MediaStreamAudioSourceNode.cpp: Added.
Modules/webaudio/MediaStreamAudioSourceNode.h: Added.

(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::setFormat):
(WebCore::MediaStreamAudioSourceNode::process):
(WebCore::MediaStreamAudioSourceNode::reset):
(WebCore::MediaStreamAudioSourceNode::mediaStream):
(WebCore::MediaStreamAudioSourceNode::audioSourceProvider):
Basic MediaStreamAudioSourceNode implementation.

Modules/webaudio/MediaStreamAudioSourceNode.idl: Added.

LayoutTests:

webaudio/mediastreamaudiosourcenode-expected.txt: Added.
webaudio/mediastreamaudiosourcenode.html: Added.

3:00 PM Changeset in webkit [124254] by pkasting@chromium.org

33 edits
30 adds
10 deletes in trunk/LayoutTests

[Chromium] Rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=45991
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=82911
http://crbug.com/131187
http://crbug.com/135709
http://crbug.com/139796

Mostly rebaselining in the wake of r124209, with a few other things
mixed in.

platform/chromium-linux-x86/fast/gradients: Added.
platform/chromium-linux-x86/fast/gradients/crash-on-zero-radius-expected.png: Added.
platform/chromium-linux-x86/fast/gradients/generated-gradients-expected.png: Added.
platform/chromium-linux-x86/fast/gradients/list-item-gradient-expected.png: Added.
platform/chromium-linux-x86/fast/gradients/simple-gradients-expected.png: Added.
platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Removed.
platform/chromium-linux-x86/svg/as-background-image: Added.
platform/chromium-linux-x86/svg/as-background-image/svg-as-background-3-expected.png: Added.
platform/chromium-linux-x86/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Removed.
platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.png:
platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
platform/chromium-linux/fast/gradients/list-item-gradient-expected.png:
platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png:
platform/chromium-mac-snowleopard/fast/gradients/list-item-gradient-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Removed.
platform/chromium-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
platform/chromium-mac/fast/gradients/crash-on-zero-radius-expected.png:
platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png: Added.
platform/chromium-mac/fast/gradients/generated-gradients-expected.png:
platform/chromium-mac/fast/gradients/list-item-gradient-expected.png:
platform/chromium-mac/fast/gradients/simple-gradients-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
platform/chromium-mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
platform/chromium-win-xp/svg/as-background-image: Added.
platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png: Added.
platform/chromium-win-xp/svg/as-background-image/svg-as-background-6-expected.png: Added.
platform/chromium-win-xp/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.png:
platform/chromium-win/fast/gradients/generated-gradients-expected.png:
platform/chromium-win/fast/gradients/list-item-gradient-expected.png:
platform/chromium-win/fast/gradients/simple-gradients-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
platform/chromium/TestExpectations:

2:32 PM Changeset in webkit [124253] by allan.jensen@nokia.com

3 edits in trunk/Source/WebCore

FractionalLayoutUnit minor math bugs
https://bugs.webkit.org/show_bug.cgi?id=86065

Reviewed by Levi Weintraub.

Implement a consistent set of subject modifying operators, to ensure
operations that need to be in float are performed in float.

Scale FractionalLayoutSize in FractionalLayoutUnits instead of intergers.

No new functionality. No new tests.

platform/FractionalLayoutUnit.h:

(WebCore::operator-=):
(WebCore::operator*=):
(WebCore::operator/=):

platform/graphics/FractionalLayoutSize.h:

(WebCore::FractionalLayoutSize::scale):

2:29 PM Changeset in webkit [124252] by abarth@webkit.org

4 edits in trunk/Source/WebKit/chromium

[Chromium-Android] We should hueristically detect content intents on touch
https://bugs.webkit.org/show_bug.cgi?id=92346

Reviewed by Nate Chapin.

On Android, when the user touches a block of text, we run a bunch of
OS-provided hueristics to detect content intents, such as telephone
numbers and mailing addresses.

This patch introduces the WebViewClient functions and the
detectContentIntentOnTouch function, but does not wire the code into
the event system. There are some decisions to make about how to wire it
into the event system, we'll tackle in the next patch.

public/WebViewClient.h:

(WebKit::WebViewClient::detectContentIntentAround):
(WebViewClient):
(WebKit::WebViewClient::scheduleContentIntent):
(WebKit::WebViewClient::cancelScheduledContentIntents):

src/WebViewImpl.cpp:

(WebKit):
(WebKit::tapHighlightColorForNode):
(WebKit::WebViewImpl::showTouchHighlightQuads):
(WebKit::WebViewImpl::detectContentIntentOnTouch):

src/WebViewImpl.h:

(WebViewImpl):

2:29 PM Changeset in webkit [124251] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviwed gardening.
Some TestExpectations hygiene.

platform/chromium/TestExpectations:

2:26 PM Changeset in webkit [124250] by ggaren@apple.com

12 edits in trunk/Source/JavaScriptCore

Removed some public data and casting from the Heap
https://bugs.webkit.org/show_bug.cgi?id=92777

Reviewed by Oliver Hunt.

heap/BlockAllocator.cpp:

(JSC::BlockAllocator::releaseFreeBlocks):
(JSC::BlockAllocator::blockFreeingThreadMain): Use the DeadBlock class
since HeapBlock is a template, and not a class, now. Call destroy()
instead of monkeying around with DeadBlock's internal data because
encapsulation is good.

heap/BlockAllocator.h:

(DeadBlock): Added a class to represent a dead block, since HeapBlock is
a template now, and can't be instantiated directly.

(JSC::DeadBlock::DeadBlock):
(JSC::DeadBlock::create):
(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::deallocate): Use the DeadBlock class because
encapsulation is good.

heap/CopiedBlock.h:

(CopiedBlock::destroy): No need for a destroy() function, since we
inherit one now.

(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payloadEnd):
(JSC::CopiedBlock::capacity): Updated for some encapsulation inside
HeapBlock.

heap/CopiedSpace.cpp:

(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::size):
(JSC::CopiedSpace::capacity):
(JSC::isBlockListPagedOut): Removed a bunch of casting. This is no longer
necessary, now that our list and its nodes have the right type.

heap/CopiedSpace.h: Use the right type in our data structures because

it improves clarity.

heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::startedCopying): Use swap to avoid duplicating it.

heap/HeapBlock.h:

(HeapBlock): Made this a class template so we can return the right type
in linked list operations. Made our data private because encapsulation
is good.

(JSC::HeapBlock::destroy): Since we know our type, we can also eliminate
duplicate destroy() functions in our subclasses.

(JSC::HeapBlock::allocation): Added an accessor so we can hide our data.
By using const, this accessor prevents clients from accidentally deleting
our allocation.

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::removeBlock): Removed a bunch of casting. This is
no longer necessary, now that our list and its nodes have the right type.

heap/MarkedAllocator.h:

(MarkedAllocator):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::forEachBlock): Use the right type, do less casting.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::destroy): Removed this function because our parent
class provides it for us now.

(JSC::MarkedBlock::MarkedBlock):

heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::capacity): Updated for encapsulation.

2:22 PM Changeset in webkit [124249] by ap@apple.com

7 edits in trunk/Source/WebKit2

[WK2] Use an actual WebProcessProxy when decoding messages
https://bugs.webkit.org/show_bug.cgi?id=92788

Reviewed by Anders Carlsson.

WebContextUserMessageDecoder gets process proxy from a WebContext object, but we
know which process a message came from, and can just use that.

UIProcess/WebContextUserMessageCoders.h: (WebKit::WebContextUserMessageDecoder::WebContextUserMessageDecoder): (WebKit::WebContextUserMessageDecoder::decode): This is the focal point of this patch - decoder no longer needs to call m_context->process().

UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveMessage): (WebKit::WebContext::didReceiveSyncMessage):
UIProcess/WebContext.h: These methods now take a WebProcessProxy pointer instead of IPC::Connection, so that they can call the updated coder. A number of other didReceiveMessage can be modified to take WebProcessProxy later if needed (it's a richer interface than IPC::Connection), although not all messages come from WebProcesses.

UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::didReceiveMessage):
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::willGoToBackForwardListItem): (WebKit::WebPageProxy::registerIntentServiceForFrame): (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebPageProxy::didFailProvisionalLoadForFrame): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::didFirstLayoutForFrame): (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame): (WebKit::WebPageProxy::didNewFirstVisuallyNonEmptyLayout): (WebKit::WebPageProxy::didRemoveFrameFromHierarchy): (WebKit::WebPageProxy::didDisplayInsecureContentForFrame): (WebKit::WebPageProxy::didRunInsecureContentForFrame): (WebKit::WebPageProxy::didDetectXSSForFrame): (WebKit::WebPageProxy::didReceiveIntentForFrame): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponse): (WebKit::WebPageProxy::unableToImplementPolicy): (WebKit::WebPageProxy::willSubmitForm): (WebKit::WebPageProxy::mouseDidMoveOverElement): (WebKit::WebPageProxy::internalShowContextMenu):
UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage): (WebKit::WebProcessProxy::didReceiveSyncMessage): Updated arguments accordingly.

1:55 PM Changeset in webkit [124248] by senorblanco@chromium.org

1 edit
1 add in trunk/LayoutTests

[chromium] Unreviewed gardening.

platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.

1:50 PM Changeset in webkit [124247] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt: clean up names in sharding code
https://bugs.webkit.org/show_bug.cgi?id=92785

Reviewed by Ryosuke Niwa.

More refactoring ... this makes the methods use TestInputs
consistently (and updates the names accordingly) and improves
encapsulation a bit. The sharding code is now pretty
self-contained.

This change adds no new functionality and is covered by the
existing (updated) tests.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(TestShard.visible.init):
(TestShard.visible.repr):
(Manager._dir_for_test_input):
(Manager._shard_tests):
(Manager._shard_in_two):
(Manager._shard_every_file):
(Manager._shard_by_directory):
(Manager._run_tests):

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerWrapper._test_input_for_file):
(ShardingTests.get_shards):

Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput.init):
(TestInput.repr):

1:48 PM Changeset in webkit [124246] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt: clean up TestInputs in preparation for cleaning up sharding
https://bugs.webkit.org/show_bug.cgi?id=92784

Reviewed by Ryosuke Niwa.

Currently, in order to shard the tests you need to refer to
state in the manager as well as the state in the TestInputs;
this change embeds the necessary state into the TestInputs so
sharding them can be a standalone operation.

The actual clean up of the sharding will follow in a subsequent patch.

Covered by existing tests; no new functionality. However, I did
rework the sharding tests to be less dependent on the test
scaffolding and easier to follow.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._test_input_for_file):
(Manager._shard_in_two):
(Manager._shard_every_file):
(Manager._shard_by_directory):

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerWrapper._test_input_for_file):
(ShardingTests.assert_shards):
(ShardingTests.test_shard_by_dir):
(ShardingTests.test_shard_by_dir_sharding_ref_tests):
(ShardingTests.test_shard_every_file):
(ShardingTests.test_shard_in_two):
(ShardingTests.test_shard_in_two_sharding_ref_tests):
(ShardingTests.test_shard_in_two_has_no_unlocked_shards):
(ShardingTests.test_multiple_locked_shards):

Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput.init):
(TestInput.repr):

1:46 PM Changeset in webkit [124245] by senorblanco@chromium.org

2 edits
2 adds in trunk/LayoutTests

[chromium] Unreviewed gardening.

Add new mac baselines for fill-stroke-clip-reset-path. These have red
squares for the dashboard results, since chrome doesn't support
dashboard mode. The same had already been done for Win and Linux.

platform/chromium-mac-snowleopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
platform/chromium-mac/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
platform/chromium/TestExpectations:

1:30 PM Changeset in webkit [124244] by commit-queue@webkit.org

4 edits in trunk/Tools

[EFL] Dump a backtrace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92489

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.

Dump a stack trace in case of a unexpected signal. This should
provide a better report at the build bots when WTR crashes.

DumpRenderTree/efl/DumpRenderTree.cpp:

(main):

TestWebKitAPI/efl/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::platformInitialize):

WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WTR::InjectedBundle::platformInitialize):

1:24 PM Changeset in webkit [124243] by reed@google.com

2 edits in trunk/LayoutTests

suppress gradient tests on skia/mac that have incorrectly "recorded failure", now that those tests are actually passing (drawing correctly)
https://bugs.webkit.org/show_bug.cgi?id=92787

Reviewed by NOBODY - expectations only

platform/chromium/TestExpectations:

12:52 PM Changeset in webkit [124242] by commit-queue@webkit.org

19 edits
2 adds in trunk

[BlackBerry] Enable CSS Filter Effects
https://bugs.webkit.org/show_bug.cgi?id=92685

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-31
Reviewed by Rob Buis.

Enable CSS filter effects, with the exception of custom effects (CSS shaders) and reference effects (SVG effects)

Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.

Source/cmake/OptionsBlackBerry.cmake: Add LayerFilterRenderer
Source/cmakeconfig.h.cmake: Acknowledge CSS filter effects

Source/WebCore:

No new tests, because this is covered by tests from other platforms.

Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.

CMakeLists.txt:
PlatformBlackBerry.cmake:
platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore):
(WebCore::GraphicsLayerBlackBerry::setFilters):
(WebCore::GraphicsLayerBlackBerry::updateFilters):

platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::filters):

platform/graphics/blackberry/LayerCompositingThread.h:

(LayerOverride):
(WebCore):
(WebCore::LayerCompositingThread::filterOperationsChanged):
(WebCore::LayerCompositingThread::setFilterOperationsChanged):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::filterActions):
(WebCore::LayerCompositingThread::setFilterActions):

platform/graphics/blackberry/LayerData.h:

(LayerData):
(WebCore::LayerData::filters):

platform/graphics/blackberry/LayerFilterRenderer.cpp: Added.

(WebCore):
(WebCore::operationTypeToProgramID):
(WebCore::Uniformf::Uniformf):
(WebCore::Uniform1f::apply):
(WebCore::Uniform1f::create):
(WebCore::Uniform1f::Uniform1f):
(WebCore::Uniform2f::apply):
(WebCore::Uniform2f::create):
(WebCore::Uniform2f::Uniform2f):
(WebCore::Uniform3f::apply):
(WebCore::Uniform3f::create):
(WebCore::Uniform3f::Uniform3f):
(WebCore::LayerFilterRendererAction::create):
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::~LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::useActionOn):
(WebCore::LayerFilterRenderer::create):
(WebCore::LayerFilterRenderer::LayerFilterRenderer):
(WebCore::LayerFilterRenderer::bindCommonAttribLocation):
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):

platform/graphics/blackberry/LayerFilterRenderer.h: Added.

(WebCore):
(Uniformf):
(WebCore::Uniformf::location):
(Uniform1f):
(Uniform2f):
(Uniform3f):
(LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::shouldPushSnapshot):
(WebCore::LayerFilterRendererAction::setPushSnapshot):
(WebCore::LayerFilterRendererAction::shouldPopSnapshot):
(WebCore::LayerFilterRendererAction::setPopSnapshot):
(WebCore::LayerFilterRendererAction::appendUniform):
(LayerFilterRenderer):
(WebCore::LayerFilterRenderer::isEnabled):
(WebCore::LayerFilterRenderer::disable):

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::loadShader):
(WebCore::LayerRenderer::loadShaderProgram):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore):
(WebCore::LayerRenderer::initializeSharedGLObjects):

platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore):
(WebCore::LayerWebKitThread::filtersCanBeComposited):

platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):
(WebCore::LayerWebKitThread::setFilters):

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):

platform/graphics/filters/FilterOperation.h:

(WebCore):
(FilterOperation):

Tools:

Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.

Scripts/webkitperl/FeatureList.pm: Acknowledge CSS filter effects.

12:50 PM Changeset in webkit [124241] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

Get rid of "parser" type casts in CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=92760

Reviewed by Adam Barth.

r124099 now type the parser parameter, it is therefore not needed to
cast to CSSParser* everywhere as we know have a CSSParser* type
already.

No new tests : refactor with no behavior change expected.

css/CSSGrammar.y:

12:42 PM Changeset in webkit [124240] by dpranke@chromium.org

2 edits in trunk/Tools

nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
https://bugs.webkit.org/show_bug.cgi?id=92781

Reviewed by Ryosuke Niwa.

More refactoring ... rename prepare_lists_and_print_output to
just prepare_lists so that it only has a single purpose, and
clean up the surrounding code a bit as well.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._collect_tests):
(Manager._prepare_lists):
(Manager._set_up_run):
(Manager.run):

12:38 PM Changeset in webkit [124239] by vollick@chromium.org

21 edits
1 move in trunk/Source

[chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTranslationUtil
https://bugs.webkit.org/show_bug.cgi?id=90468

Reviewed by James Robinson.

Source/Platform:

Platform.gypi:
chromium/public/WebAnimation.h:

(WebAnimation):
(WebKit::WebAnimation::WebAnimation):

chromium/public/WebAnimationDelegate.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationDelegate.h.

(WebKit):
(WebAnimationDelegate):

chromium/public/WebLayer.h:

(WebKit):
(WebLayer):

Source/WebCore:

No new tests. No new functionality.

WebCore.gypi:
platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::appendKeyframe):
(WebCore::WebTransformAnimationCurve):
(WebCore::createWebAnimation):

platform/graphics/chromium/AnimationTranslationUtil.h:

(WebKit):
(WebCore):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

platform/graphics/chromium/LayerChromium.cpp:
platform/graphics/chromium/LayerChromium.h:

(WebKit):
(WebCore):
(WebCore::LayerChromium::setLayerAnimationDelegate):
(LayerChromium):

platform/graphics/chromium/LinkHighlight.h:

(LinkHighlight):

Source/WebKit/chromium:

src/WebAnimation.cpp:

(WebKit::WebAnimation::targetProperty):
(WebKit):
(WebKit::WebAnimation::initialize):

src/WebLayer.cpp:

(WebKit::WebLayer::setAnimationDelegate):
(WebKit):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::transferAnimationsTo):

tests/CCThreadedTest.cpp:
tests/CCThreadedTest.h:

(TestHooks):

tests/WebAnimationTest.cpp:

(WebKit::TEST):

12:20 PM Changeset in webkit [124238] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix potential build error on LocalFileSystem::deleteFileSystem.
https://bugs.webkit.org/show_bug.cgi?id=92695

Non-Chrome build of WebKit with FILE_SYSTEM flag will be broken at
LocalFileSystem::deleteFileSystem.
Chrome does not use this source and most of other ports don't turn on
FILE_SYSTEM flag for now. So, we've not seen the breakage explicitly yet.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-31
Reviewed by Adam Barth.

Non-Chrome WebKit build with FILE_SYSTEM should be finished successfully.

Modules/filesystem/LocalFileSystem.cpp:

(WebCore::LocalFileSystem::deleteFileSystem):

12:14 PM Changeset in webkit [124237] by commit-queue@webkit.org

5 edits
2 adds
2 deletes in trunk

AudioPannerNode should raise exception when distanceModel is set incorrectly
https://bugs.webkit.org/show_bug.cgi?id=90952

Patch by Li Yin <li.yin@intel.com> on 2012-07-31
Reviewed by Chris Rogers.

Source/WebCore:

Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
The distance model can be only set to LINEAR_DISTANCE, INVERSE_DISTANCE or EXPONENTIAL_DISTANCE.
If the incorrect value is set, it will raise the exception.
Use the unsigned short to replace unsigned long in AudioPannerNode.idl.

Test: webaudio/audiopannernode-basic.html

Modules/webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::setDistanceModel): raise exception
(WebCore):

Modules/webaudio/AudioPannerNode.h:

(AudioPannerNode):

Modules/webaudio/AudioPannerNode.idl: using unsigned short to replace unsigned long

LayoutTests:

Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
Add tests for distanceModel,numberOfInputs and numberOfInputs of AudioPannerNode.

webaudio/audiopannernode-basic-expected.txt: Added.
webaudio/audiopannernode-basic.html: Added.
webaudio/panner-set-model-expected.txt: Removed.
webaudio/panner-set-model.html: Removed.

12:11 PM Changeset in webkit [124236] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt: clean up self._test_files_list vs. self._test_files, other nits
https://bugs.webkit.org/show_bug.cgi?id=92702

Reviewed by Ojan Vafai.

Get rid of self._test_files, rename self._test_files_list to
self._test_names (removing the confusion between the two fields).

Also inline the one call to _parse_expectations, remove the one
use of more_tests_to_skip, and fix a couple of minor nits.

Scripts/webkitpy/layout_tests/controllers/finder.py:

(LayoutTestFinder.split_into_chunks):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager._collect_tests):
(Manager._http_tests):
(Manager._websocket_tests):
(Manager._is_perf_test):
(Manager.prepare_lists_and_print_output):
(Manager.needs_servers):
(Manager.run):
(Manager._mark_interrupted_tests_as_skipped):
(Manager._update_summary_with_result):
(Manager._upload_json_files):

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_needs_servers.get_manager_with_tests):
(ManagerTest.test_servers_started):

12:09 PM Changeset in webkit [124235] by dpranke@chromium.org

2 edits in trunk/Tools

nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673

Reviewed by Ojan Vafai.

Add a test for r124090.

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_verbose):

12:05 PM Changeset in webkit [124234] by dpranke@chromium.org

2 edits in trunk/Tools

REGRESSION(124116): Number of skipped tests isn't printed anymore
https://bugs.webkit.org/show_bug.cgi?id=92736

Reviewed by Tony Chang.

Add the skipped number back in; it was useful ... also clean up
the formatting a little bit.

Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_found):

12:04 PM Changeset in webkit [124233] by commit-queue@webkit.org

7 edits
4 adds in trunk

[CSS Shaders] CSS parser rejects parameter names that are also CSS keywords
https://bugs.webkit.org/show_bug.cgi?id=92537

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-07-31
Reviewed by Dirk Schulze.

Source/WebCore:

Remove the CSS keyword check for CSS Shaders parameter names. Parameters are allowed to be
any valid CSS identifier, including CSS keywords. See the spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/custom/index.html#feCustom

The CSS parser was rejecting input like the following because it uses a CSS keyword
"background" as a parameter name:
-webkit-filter: custom(none url(fragment.shader), background 0 1 0 1);

Test: css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilter): Do not return early when the parameter name is a
CSS keyword (i.e. when the CSSParserValue has a non-zero id).

LayoutTests:

Add a pixel test that uses the CSS keyword "background" as a CSS Shaders parameter name.
Add a parsing test case that uses the CSS keyword "background".

css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.txt: Added.
css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html: Added.
css3/filters/custom/custom-filter-property-parsing-expected.txt:
css3/filters/resources/css-keyword-as-parameter-name.fs: Added.
css3/filters/script-tests/custom-filter-property-parsing.js:
platform/chromium/TestExpectations:
platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:

12:01 PM Changeset in webkit [124232] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Typo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=92135

Reviewed by Kentaro Hara.

This patch fixes a typo.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animateZoomAroundPoint):

11:56 AM Changeset in webkit [124231] by commit-queue@webkit.org

3 edits
2 adds in trunk

Caret position is wrong when a editable container has word-wrap:normal set
https://bugs.webkit.org/show_bug.cgi?id=89649

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-31
Reviewed by Levi Weintraub.

Source/WebCore:

Correcting the incorrect addumption that the min and max position for the caret rect is constrained to
the logical containing block width. This assumption is incorrect when the text has word-wrap:normal and
flows beyound the visible rect of the container.

Test: editing/input/editable-container-with-word-wrap-normal.html

rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

LayoutTests:

editing/input/editable-container-with-word-wrap-normal-expected.txt: Added.
editing/input/editable-container-with-word-wrap-normal.html: Added.

11:48 AM Changeset in webkit [124230] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

DFG OSR exit profiling has unusual oversights
https://bugs.webkit.org/show_bug.cgi?id=92728

Reviewed by Geoffrey Garen.

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationWatchpoint):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:47 AM Changeset in webkit [124229] by Antti Koivisto

2 edits in trunk/Source/WebCore

Crash in FrameLoader::checkLoadComplete with non-browser client app
https://bugs.webkit.org/show_bug.cgi?id=92774

Reviewed by Alexey Proskuryakov..

Speculative fix. It is possible that CSSFontSelector could get deleted during the timer callback
and memory reused, making m_document point to some garbage when it is tested at the end.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

11:44 AM Changeset in webkit [124228] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Add MIPS add32 function
https://bugs.webkit.org/show_bug.cgi?id=91522

Patch by Chao-ying Fu <fu@mips.com> on 2012-07-31
Reviewed by Oliver Hunt.

Add isCompactPtrAlignedAddressOffset.
Add a new version of add32 that accepts AbsoluteAddress as inputs.

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::isCompactPtrAlignedAddressOffset): New.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::add32): Support AbsoluteAddress as inputs.

11:43 AM Changeset in webkit [124227] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix crash in InputHandler spell checking.
https://bugs.webkit.org/show_bug.cgi?id=92763

Reviewed by Antonio Gomes.

PR 185574.

Fix crash in getSpellChecker by guarding the calling paths
to ensure that m_currentFocusElement is valid.

Also add ASSERTs for previous crash.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::getSpellChecker):

11:31 AM Changeset in webkit [124226] by commit-queue@webkit.org

2 edits
3 adds
8 deletes in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=92770

Unreviewed gardening.

New baselines, skipped some failing tests and removed test
expectations that are the same as the global expectations.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31

platform/efl/TestExpectations:
platform/efl/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
platform/efl/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
platform/efl/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.txt: Removed.
platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
platform/efl/fast/forms/listbox-clip-expected.txt: Removed.
platform/efl/fast/html/details-position-expected.txt: Removed.
platform/efl/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.

11:26 AM Changeset in webkit [124225] by hans@chromium.org

8 edits
2 adds in trunk

Speech JavaScript API: Throw exception for start() when already started
https://bugs.webkit.org/show_bug.cgi?id=92756

Reviewed by Adam Barth.

Source/WebCore:

Make the start() function throw an exception if the SpeechRecognition
object was already started.

Test: fast/speech/scripted/start-exception.html

Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didReceiveError):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):

Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

Modules/speech/SpeechRecognition.idl:

Tools:

Fix the task queue in MockWebSpeechRecognizer.
It's important that we remove the task from the queue before we run
it, as running the task could alter the queue's state.

DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

(MockWebSpeechRecognizer::abort):
(MockWebSpeechRecognizer::setError):
(MockWebSpeechRecognizer::clearTaskQueue):
(MockWebSpeechRecognizer::StepTask::runIfValid):

DumpRenderTree/chromium/MockWebSpeechRecognizer.h:

(MockWebSpeechRecognizer):

LayoutTests:

Layout test for checking that calling start on an already started
SpeechRecognition object throws an exception.

fast/speech/scripted/start-exception-expected.txt: Added.
fast/speech/scripted/start-exception.html: Added.

11:19 AM Changeset in webkit [124224] by dpranke@chromium.org

3 edits in trunk/Tools

nrwt: move handling the initial list of tests to skip to finder
https://bugs.webkit.org/show_bug.cgi?id=92701

Reviewed by Ryosuke Niwa.

More refactoring of manager ...

Scripts/webkitpy/layout_tests/controllers/finder.py:

(LayoutTestFinder.skip_tests):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._collect_tests):
(Manager.prepare_lists_and_print_output):

11:16 AM Changeset in webkit [124223] by zandobersek@gmail.com

5 edits
2 deletes in trunk/Source

Unreviewed, rolling out r124207.
http://trac.webkit.org/changeset/124207
https://bugs.webkit.org/show_bug.cgi?id=92773

Patch causes crashes on the 64-bit debug builder (and other
builders likely) (Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

Source/WebCore:

GNUmakefile.am:
GNUmakefile.list.am:
platform/text/gtk/TextCheckerEnchant.cpp: Removed.
platform/text/gtk/TextCheckerEnchant.h: Removed.

Source/WebKit/gtk:

webkit/webkitspellcheckerenchant.cpp:

(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

11:13 AM Changeset in webkit [124222] by enne@google.com

6 edits
2 deletes in trunk/LayoutTests

[Chromium] transforms/3d/point-mapping/3d-point-mapping-*.html failing on Win
https://bugs.webkit.org/show_bug.cgi?id=92707

Unreviewed, updating expectations after r124052.

For efficiency's sake, ScrollbarLayerChromium doesn't draw the top and
bottom part of the track differently on "native" scrollbars. This
changes the way the mock Windows scrollbars look in tests.

platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Removed.
platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Removed.
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
platform/chromium/TestExpectations:

10:43 AM Changeset in webkit [124221] by msaboff@apple.com

2 edits in trunk/LayoutTests

inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>

platform/mac-lion/Skipped: Added inspector/debugger/debugger-expand-scope.html to skip list.

10:42 AM Changeset in webkit [124220] by ap@apple.com

2 edits in trunk/Tools

[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676

Reviewed by Sam Weinig.

MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.

Don't create a new context for every view.

10:26 AM Changeset in webkit [124219] by peter@chromium.org

2 edits in trunk/Tools

[Chromium] Don't use ninja for building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=92764

Reviewed by Adam Barth.

When Ninja projects files are generated (which will be done for Android),
make sure that the Android builder doesn't unintentionally switch to
using Ninja. We should make that switch at a predetermined time.

Scripts/webkitdirs.pm:

(buildChromium):

10:21 AM Changeset in webkit [124218] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

Send an onContextMenu event to the page content
so that context menus can be prevented. We use
the node's event handler because we want to use
the fat finger's node. If we use the EventHandler's
sendContextMenuEvent it will hit test with the mouse
position which may not be what we want.
PR #184032
https://bugs.webkit.org/show_bug.cgi?id=92766

Patch by Genevieve Mak <gmak@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.
Reviewed Internally by Antonio Gomes.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::contextNode):

10:16 AM Changeset in webkit [124217] by Philippe Normand

3 edits in trunk/Source/WebCore

[GStreamer] Live stream support is weak
https://bugs.webkit.org/show_bug.cgi?id=90084

Reviewed by Martin Robinson.

Make sure on-disk buffering is disabled for live streams. It is
enabled initially when loading any remote media file if preload is
set to Auto. Later on if the player detects that the media is live
it disables on-disk buffering. This patch also adds support for
caching the total size of the media.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Keep track of the
media url as an instance attribute.
(WebCore::MediaPlayerPrivateGStreamer::duration): Logging improvement.
(WebCore::MediaPlayerPrivateGStreamer::setRate): use the new
isLiveStream() method.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Indicate
source of duration message.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Perform an
anonymous duration change emission, mostly to cache its value.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Return
cached size when available.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Use the new
isLiveStream() method and handle state change corner cases for live streams.
(WebCore::MediaPlayerPrivateGStreamer::durationChanged): Cache
media total size and re-enable on-disk buffering if caching succeeds.
(WebCore::MediaPlayerPrivateGStreamer::movieLoadType): New
implementation handling on-disk buffered and live streaming cases.
(WebCore::MediaPlayerPrivateGStreamer::setPreload): Remember the
case where preload is updated from Auto to another value, do
on-disk buffering only for Auto preload attribute.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream): Utility
method, a stream is live if it goes to PAUSE without prerolling.

10:02 AM Changeset in webkit [124216] by Csaba Osztrogonác

3 edits
3 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, last attempt to paint the WK2 bot green today.

platform/qt-5.0-wk2/Skipped: Skip a failing test.
platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt: Added.
platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
platform/qt/Skipped:

9:42 AM Changeset in webkit [124215] by commit-queue@webkit.org

6 edits in trunk

Add a mechanism to dump the stack trace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92666

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.

Source/WTF:

Unix based ports can make use of signal handlers to dump the stack
trace in case of a crash. This is specially handy when a test crashes on
the bot without hitting an assertion, we might have a chance to see
some insightful information at the reports.

wtf/Assertions.cpp:
wtf/Assertions.h:

Tools:

Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
and eliminate some duplicated code.

DumpRenderTree/qt/main.cpp:

(main):

WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::InjectedBundle::platformInitialize):

9:21 AM Changeset in webkit [124214] by tonikitoo@webkit.org

2 edits in trunk/Source/WebCore

[Blackberry][FullScreen] HTML5 <video> controls are scaled differently depending on the current webpage scale
https://bugs.webkit.org/show_bug.cgi?id=90884
PR #162839

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

The way the BlackBerry port implements the FULLSCREEN_API for media
elements might result in the controls being oversized, proportionally
to the current page scale. That happens because the fullscreen element
gets sized to be as big as the viewport size, and the viewport size might
get outstretched to fit to the screen dimensions.

In order to fix that, the patch strips out the Page scale factor from
the media controls multiplier.

Patch also changes many integer-based calculations to be float-based, in
order to get the needed precision.

Internally reviewed by Jacky Jiang.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):

9:10 AM Changeset in webkit [124213] by senorblanco@chromium.org

3 edits in trunk/Source/WebCore

Remove the clone() method from FilterOperation (and subclasses).
https://bugs.webkit.org/show_bug.cgi?id=92757

Reviewed by Kentaro Hara.

Since the move to WebFilterOperation in Chromium, this is now dead
code.

Covered by existing tests in css3/filters.

platform/graphics/filters/CustomFilterOperation.h:
platform/graphics/filters/FilterOperation.h:

9:08 AM Changeset in webkit [124212] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Regression(r124135): SVG tests crashing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=92752

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Martin Robinson.

platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::operator=):

9:05 AM Changeset in webkit [124211] by loislo@chromium.org

9 edits
2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r124208.
http://trac.webkit.org/changeset/124208
https://bugs.webkit.org/show_bug.cgi?id=92765

it broke compilation on mac (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorAllInOne.cpp:
inspector/InspectorMemoryAgent.cpp:

(WebCore):

inspector/MemoryInstrumentationImpl.cpp: Removed.
inspector/MemoryInstrumentationImpl.h: Removed.

9:02 AM Changeset in webkit [124210] by schenney@chromium.org

8 edits
4 adds in trunk

xmlserializer strips xlink from xlink:html svg image tag
https://bugs.webkit.org/show_bug.cgi?id=79586

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adding code to ensure the correct prefix on attributes in the xml,
xmlns and xlink namespaces. We now follow the rules in
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serializing-html-fragments
(circa the time of this change).

Rob Buis wrote the original test for this patch and did the initial work.

Tests: fast/dom/XMLSerializer-xml-namespace.html

svg/custom/xlink-prefix-in-attributes.html

editing/MarkupAccumulator.cpp:

(WebCore::attributeIsInSerializedNamespace): Test for an attribute in
a specially serialized namespace: xml, xmlns, xlink.
(WebCore):
(WebCore::MarkupAccumulator::appendAttribute): Check the namespace of
attributes upon serialization, and add any necessary prefixes.

html/parser/HTMLTreeBuilder.cpp:

(WebCore::adjustForeignAttributes): Use WTF::xmlAtom etc for AtomicString arguments.

Source/WTF:

Add WTF::xlinkAtom as a global AtomicString constant.

wtf/text/AtomicString.h:

(WTF): Add xlinkAtom.

wtf/text/StringStatics.cpp:

(WTF): Add xlinkAtom.
(WTF::AtomicString::init): Add xlinkAtom.

LayoutTests:

Rob Buis wrote the original test for this patch and did the initial work.

editing/pasteboard/paste-noscript-svg-expected.txt: Updated.
fast/dom/XMLSerializer-xml-namespace-expected.txt: Added.
fast/dom/XMLSerializer-xml-namespace.html: Added. Tests serializing attributes with the xml namespace.
svg/custom/xlink-prefix-in-attributes-expected.txt: Added.
svg/custom/xlink-prefix-in-attributes.html: Added. Tests serializing attributes in the xmlns and xlink namespaces.

8:55 AM Changeset in webkit [124209] by reed@google.com

4 edits in trunk

skia: switch to conical gradient to match css/svg spec for two-point gradients
https://bugs.webkit.org/show_bug.cgi?id=92754

Reviewed by Stephen White.

Source/WebCore:

Switching to skia's TwoPointConical gradient, which has been written explicitly to match the css/svg spec.
Leaving the existing TwoPointRadial gradient in skia, for other callers that may want the old behavior.

No new tests. existing layouttests exercise this change (9 pending rebaselines associated with this CL).

platform/graphics/skia/GradientSkia.cpp:

(WebCore::Gradient::platformGradient):

LayoutTests:

Update expectations to rebaseline 9 images after this change lands

platform/chromium/TestExpectations:

8:53 AM Changeset in webkit [124208] by loislo@chromium.org

9 edits
2 adds in trunk/Source/WebCore

Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
https://bugs.webkit.org/show_bug.cgi?id=92751

Reviewed by Yury Semikhatsky.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/InspectorAllInOne.cpp:
inspector/InspectorMemoryAgent.cpp:

(WebCore):

inspector/MemoryInstrumentationImpl.cpp: Added.

inspector/MemoryInstrumentationImpl.h: Added.

(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalTypeSize):

8:51 AM Changeset in webkit [124207] by mario@webkit.org

5 edits
2 adds in trunk/Source

[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269

Reviewed by Martin Robinson.

Source/WebCore:

Move enchant specific code down to WebCore, into a new class
TextCheckerEnchant, that we can use from WK1 and WK2.

GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
GNUmakefile.list.am: Added new files.
platform/text/gtk/TextCheckerEnchant.cpp: Added.

(getAvailableDictionariesCallback):
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):

platform/text/gtk/TextCheckerEnchant.h: Added.

(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):

Source/WebKit/gtk:

Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.

webkit/webkitspellcheckerenchant.cpp:

(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

8:44 AM Changeset in webkit [124206] by apavlov@chromium.org

2 edits
1 add in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline fast/ruby/overhang-horizontal.html.

platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Added.
platform/chromium/TestExpectations:

8:41 AM Changeset in webkit [124205] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[BlackBerry] Support Negotiate auth
https://bugs.webkit.org/show_bug.cgi?id=91871

Patch by Joe Mason <jmason@rim.com> on 2012-07-31
Reviewed by George Staikos.

Add Negotiate to the list of auth schemes allowed in the platform request.

Add "success" and "requireCredentials" parameters to notifyAuthReceived (which is now called
with success = true on successful authentication, as well as on failures).

When success is true, update the stored credential to use the auth scheme actually reported
rather than that set in the request. (This is used when Negotiate auth can't get a ticket
and falls back to a different supported auth type.)

When requireCredentials is false, just set the auth type and start a new request using empty
credentials.

RIM PR# 166514
Internally reviewed by Jonathan Dong

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived): Add Negotiate to the auth scheme switch. Handle
success param by updating auth type in stored credentials; pass requireCredentials param on
to sendRequestWithCredentials.
(WebCore::NetworkJob::startNewJobWithRequest): Fix typo in increaseRedirectCount parameter
name.
(WebCore::NetworkJob::sendRequestWithCredentials): Use empty credentials if
requireCredentials is false.

platform/network/blackberry/NetworkJob.h:

(NetworkJob):

platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob): Add Negotiate to the auth scheme switch.

8:37 AM Changeset in webkit [124204] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

platform/qt/Skipped:
platform/qt/TestExpectations:

8:20 AM Changeset in webkit [124203] by Csaba Osztrogonác

2 edits
8 deletes in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Skip failing tests and remove unnecessary expected files. (bug85203)

platform/qt-5.0-wk2/Skipped:
platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Removed.
platform/qt-5.0-wk2/fast/dynamic/008-expected.txt: Removed.
platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.png: Removed.
platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.png: Removed.
platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.txt: Removed.

8:15 AM Changeset in webkit [124202] by apavlov@chromium.org

11 edits
2 adds in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline some platform/chromium/virtual/gpu/fast/canvas tests due to antialiasing changes.

platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
platform/chromium/TestExpectations:

8:05 AM Changeset in webkit [124201] by commit-queue@webkit.org

6 edits in trunk

Web Inspector: take into account the whole security origin instead of just host
https://bugs.webkit.org/show_bug.cgi?id=92740

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-31
Reviewed by Pavel Feldman.

Source/WebCore:

Make the DOM Storage Agent take into account all the
information relevant to the security origin, i.e. protocol, host, and
port. Previously only the host was taken into account. That caused
inspector to show the first storage only in the case a page operated
over several security origins sharing the same host (but having
different protocols e.g. http and https).

inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):

inspector/InspectorDOMStorageResource.h:

(InspectorDOMStorageResource):

LayoutTests:

http/tests/inspector-enabled/dom-storage-open-expected.txt:

7:41 AM Changeset in webkit [124200] by abecsi@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Visible content rect update with null trajectory vector does not reach the backing store
https://bugs.webkit.org/show_bug.cgi?id=92750

Reviewed by Jocelyn Turcotte.

Make sure that notifications with a null trajectory vector reach the backing store
since a null vector means that all tiles around the viewport were requested.

WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::setVisibleContentsRect):

7:35 AM Changeset in webkit [124199] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Backing store output flickers when using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=90291

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.

The backing store doesn't know when the API client swaps the buffers,
so it doesn't know when to signal the blit generation condition
variable. Fixed by using EGL fence sync instead, when available, so we
don't have to know.

Reviewed internally by Filip Spacek.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):

Api/BackingStore_p.h:

(BackingStorePrivate):

WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::TileBuffer):

WebKitSupport/BackingStoreTile.h:

(BlackBerry::WebKit::TileBuffer::syncObject):
(BlackBerry::WebKit::TileBuffer::setSyncObject):
(TileBuffer):

WebKitSupport/SurfacePool.cpp:

(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):

WebKitSupport/SurfacePool.h:

(SurfacePool):

6:50 AM Changeset in webkit [124198] by keishi@webkit.org

9 edits in trunk

Slider ticks are drawn at wrong positions
https://bugs.webkit.org/show_bug.cgi?id=92720

Reviewed by Kent Tamura.

Source/WebCore:

Slider tick marks for vertical sliders were drawn reversed. And the tick
mark positions were slightly off from the thumb position because of rounding.

No new tests. Covered in input-appearance-range-with-datalist.html.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

LayoutTests:

fast/forms/datalist/input-appearance-range-with-datalist.html: Added values to input elements so we can see if the slider thumb position matches with the tick marks.
platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
platform/chromium/TestExpectations:

6:42 AM Changeset in webkit [124197] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Input method update should also include hints
https://bugs.webkit.org/show_bug.cgi?id=92744

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-07-31
Reviewed by Simon Hausmann.

The QInputMethod is told to query for input method hints when updated.

UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::updateTextInputState):

6:15 AM Changeset in webkit [124196] by shinyak@chromium.org

7 edits
2 adds in trunk

Older ShadowDOM is still rendered when a new ShadowDOM is added when they don't have any InsertionPoints.
https://bugs.webkit.org/show_bug.cgi?id=92456

Reviewed by Hajime Morita.

Source/WebCore:

When adding a new ShadowRoot to an element having other ShadowRoots, and they don't have any InsretionPoint,
the older ShadowDOM is still rendered.

When ContentDistributor's validity is 'Undetermined', ElementShadow reattaches the host and the whole shadow
subtree. Since adding a new ShadowRoot makes the validity 'Undetermined', we have had to make it 'Undetermined'.

This change enables us to remove a unnecessary InvalidationType flag from the code. We should call
setValidityUndetermined() instead of using InvalidateAndForceReattach.

Test: fast/dom/shadow/invalidate-distribution.html

dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot): Calls setValidityUndetermined().
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::setValidityUndetermined):
(WebCore::ElementShadow::invalidateDistribution): When validity is undetermined, we will reattach the
host and the shadow subtree.

dom/ElementShadow.h:

(ElementShadow):

html/shadow/ContentDistributor.cpp:
html/shadow/ContentDistributor.h:

(WebCore::ContentDistributor::setValidity):
(ContentDistributor):

html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::insertedInto): Calls setValidityUndetermined().

LayoutTests:

fast/dom/shadow/invalidate-distribution-expected.html: Added.
fast/dom/shadow/invalidate-distribution.html: Added.

6:02 AM Changeset in webkit [124195] by jochen@chromium.org

8 edits
2 moves in trunk/Tools

[chromium] move EventSender into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=92277

Reviewed by Adam Barth.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::Internal::eventSender):
(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::setWebView):
(TestInterfaces::Internal::setDelegate):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::eventSender):

DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

DumpRenderTree/chromium/TestShell.h:

(TestShell::eventSender):
(TestShell):

DumpRenderTree/chromium/WebViewHost.cpp:

5:57 AM Changeset in webkit [124194] by Csaba Osztrogonác

1 edit
8 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening, remove unnecessary expected files.

platform/qt-5.0/fast/css/beforeSelectorOnCodeElement-expected.txt: Removed.
platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
platform/qt-5.0/fast/dynamic/008-expected.png: Removed.
platform/qt-5.0/fast/dynamic/008-expected.txt: Removed.
platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.png: Removed.
platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.

4:59 AM Changeset in webkit [124193] by tommyw@google.com

17 edits
9 adds in trunk

Introduce a minimal RTCPeerConnection together with Dictionary changes
https://bugs.webkit.org/show_bug.cgi?id=92380

Reviewed by Kentaro Hara.

Source/WebCore:

This patch introduces a shell RTCPeerConnection together with neccecary changes to
Dictionary.

The W3C specification can be found here:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#rtcpeerconnection

Since Dictionaries can't be fully copied around adding
get(const String& name, Vector<Dictionary>& result)
isn't feasible so I have added a new ArrayValue class.

Test: fast/mediastream/RTCPeerConnection.html

CMakeLists.txt:
GNUmakefile.list.am:
Modules/mediastream/DOMWindowMediaStream.idl:
Modules/mediastream/RTCPeerConnection.cpp: Added.

(WebCore):
(RTCIceServer):
(WebCore::RTCIceServer::create):
(WebCore::RTCIceServer::~RTCIceServer):
(WebCore::RTCIceServer::uri):
(WebCore::RTCIceServer::credential):
(WebCore::RTCIceServer::RTCIceServer):
(RTCConfiguration):
(WebCore::RTCConfiguration::create):
(WebCore::RTCConfiguration::~RTCConfiguration):
(WebCore::RTCConfiguration::appendServer):
(WebCore::RTCConfiguration::numberOfServers):
(WebCore::RTCConfiguration::server):
(WebCore::RTCConfiguration::RTCConfiguration):
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::interfaceName):
(WebCore::RTCPeerConnection::scriptExecutionContext):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::eventTargetData):
(WebCore::RTCPeerConnection::ensureEventTargetData):

Modules/mediastream/RTCPeerConnection.h: Added.

(WebCore):
(RTCPeerConnection):
(WebCore::RTCPeerConnection::refEventTarget):
(WebCore::RTCPeerConnection::derefEventTarget):

Modules/mediastream/RTCPeerConnection.idl: Added.
Target.pri:
UseJSC.cmake:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):

bindings/js/ArrayValue.cpp: Added.

(WebCore):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):

bindings/js/ArrayValue.h: Added.

(WebCore):
(ArrayValue):

bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):
(WebCore):

bindings/js/JSDictionary.h:

(WebCore):

bindings/v8/ArrayValue.cpp: Added.

(WebCore):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):

bindings/v8/ArrayValue.h: Added.

(WebCore):
(ArrayValue):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::~ArrayValue):

bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):
(WebCore):

bindings/v8/Dictionary.h:

(WebCore):
(Dictionary):

dom/EventTargetFactory.in:

LayoutTests:

fast/mediastream/RTCPeerConnection-expected.txt: Added.
fast/mediastream/RTCPeerConnection.html: Added.

4:28 AM Changeset in webkit [124192] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][EFL] New inspector/styles/region-style-crash.html introduced in r124186 fails
https://bugs.webkit.org/show_bug.cgi?id=91503

Patch by János Badics <János Badics> on 2012-07-31
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:

4:27 AM Changeset in webkit [124191] by Csaba Osztrogonác

1 edit
1 move
1 add
34 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening after r124189, remove unnecessary expected files.

platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt.
platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Removed.
platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
platform/qt-5.0/fast/images/object-image-expected.txt: Added.
platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.png: Removed.
platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.png: Removed.
platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.txt: Removed.
platform/qt-5.0/fast/repaint/continuation-after-outline-expected.txt: Removed.
platform/qt-5.0/fast/replaced/three-selects-break-expected.png: Removed.
platform/qt-5.0/fast/replaced/three-selects-break-expected.txt: Removed.
platform/qt-5.0/fast/writing-mode/fallback-orientation-expected.txt: Removed.
platform/qt-5.0/fast/xsl/document-function-expected.png: Removed.
platform/qt-5.0/fast/xsl/document-function-expected.txt: Removed.
platform/qt-5.0/fast/xsl/xslt-entity-expected.png: Removed.
platform/qt-5.0/fast/xsl/xslt-entity-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.

3:46 AM Changeset in webkit [124190] by jochen@chromium.org

2 edits in trunk/Tools

Unreviewed. Update watchlist

Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped

3:33 AM Changeset in webkit [124189] by Csaba Osztrogonác

146 edits
14 copies
16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip passing tests and add new expected files. (bug85203)

platform/qt-5.0/Skipped: Unskip passing tests.
platform/qt/Skipped: Skip the remaining failing tests and add bug reports.
platform/qt/css2.1/t040103-ident-03-c-expected.png: Added.
platform/qt/css2.1/t040103-ident-03-c-expected.txt: Added.
platform/qt/editing/pasteboard/4242293-1-expected.txt:
platform/qt/editing/pasteboard/5761530-1-expected.txt: Added.
platform/qt/fast/backgrounds/mask-box-image-expected.png:
platform/qt/fast/backgrounds/mask-box-image-expected.txt:
platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png: Copied from LayoutTests/platform/qt/fast/invalid/020-expected.png.
platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
platform/qt/fast/backgrounds/svg-as-mask-expected.png:
platform/qt/fast/backgrounds/svg-as-mask-expected.txt:
platform/qt/fast/block/positioning/051-expected.png:
platform/qt/fast/block/positioning/051-expected.txt:
platform/qt/fast/compact/003-expected.png:
platform/qt/fast/compact/003-expected.txt:
platform/qt/fast/css-generated-content/010-expected.png:
platform/qt/fast/css-generated-content/010-expected.txt:
platform/qt/fast/css-grid-layout/place-cell-by-index-expected.txt: Added.
platform/qt/fast/css/font-face-descending-unicode-range-expected.txt:
platform/qt/fast/css/font-face-font-family-descriptor-expected.txt:
platform/qt/fast/css/imageTileOpacity-expected.png:
platform/qt/fast/css/imageTileOpacity-expected.txt:
platform/qt/fast/css/live-cssrules-expected.png:
platform/qt/fast/css/live-cssrules-expected.txt:
platform/qt/fast/css/rgba-custom-text-expected.txt: Added.
platform/qt/fast/css/rtl-to-viewport-expected.png:
platform/qt/fast/css/rtl-to-viewport-expected.txt:
platform/qt/fast/css/vertical-align-lengths-expected.png:
platform/qt/fast/css/vertical-align-lengths-expected.txt:
platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.png:
platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.txt:
platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.png:
platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.txt:
platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.png:
platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.txt:
platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.png:
platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.txt:
platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.png:
platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:
platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png:
platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
platform/qt/fast/dom/comment-not-documentElement-expected.png:
platform/qt/fast/dom/comment-not-documentElement-expected.txt:
platform/qt/fast/dom/icon-url-change-expected.txt: Added.
platform/qt/fast/dom/icon-url-list-expected.txt: Added.
platform/qt/fast/dynamic/010-expected.png:
platform/qt/fast/dynamic/010-expected.txt:
platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt:
platform/qt/fast/dynamic/genContentDestroyChildren-expected.png: Added.
platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
platform/qt/fast/dynamic/move-node-with-selection-expected.png:
platform/qt/fast/dynamic/move-node-with-selection-expected.txt:
platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png:
platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
platform/qt/fast/html/details-add-summary-1-expected.png:
platform/qt/fast/html/details-add-summary-1-expected.txt:
platform/qt/fast/html/details-add-summary-10-expected.png:
platform/qt/fast/html/details-add-summary-10-expected.txt:
platform/qt/fast/html/details-add-summary-2-expected.png:
platform/qt/fast/html/details-add-summary-2-expected.txt:
platform/qt/fast/html/details-add-summary-3-expected.png:
platform/qt/fast/html/details-add-summary-3-expected.txt:
platform/qt/fast/html/details-add-summary-4-expected.png:
platform/qt/fast/html/details-add-summary-4-expected.txt:
platform/qt/fast/html/details-add-summary-5-expected.png:
platform/qt/fast/html/details-add-summary-5-expected.txt:
platform/qt/fast/html/details-add-summary-6-expected.png:
platform/qt/fast/html/details-add-summary-6-expected.txt:
platform/qt/fast/html/details-add-summary-7-expected.png:
platform/qt/fast/html/details-add-summary-7-expected.txt:
platform/qt/fast/html/details-add-summary-8-expected.png:
platform/qt/fast/html/details-add-summary-8-expected.txt:
platform/qt/fast/html/details-add-summary-9-expected.png:
platform/qt/fast/html/details-add-summary-9-expected.txt:
platform/qt/fast/html/details-no-summary1-expected.png:
platform/qt/fast/html/details-no-summary1-expected.txt:
platform/qt/fast/html/details-no-summary2-expected.png:
platform/qt/fast/html/details-no-summary2-expected.txt:
platform/qt/fast/html/details-no-summary3-expected.png:
platform/qt/fast/html/details-no-summary3-expected.txt:
platform/qt/fast/html/details-open1-expected.png:
platform/qt/fast/html/details-open1-expected.txt:
platform/qt/fast/html/details-open3-expected.png:
platform/qt/fast/html/details-open3-expected.txt:
platform/qt/fast/html/details-open5-expected.png:
platform/qt/fast/html/details-open5-expected.txt:
platform/qt/fast/html/details-open6-expected.png:
platform/qt/fast/html/details-open6-expected.txt:
platform/qt/fast/html/details-remove-summary-1-expected.png:
platform/qt/fast/html/details-remove-summary-1-expected.txt:
platform/qt/fast/html/details-remove-summary-2-expected.png:
platform/qt/fast/html/details-remove-summary-2-expected.txt:
platform/qt/fast/html/details-remove-summary-3-expected.png:
platform/qt/fast/html/details-remove-summary-3-expected.txt:
platform/qt/fast/html/details-remove-summary-4-expected.png:
platform/qt/fast/html/details-remove-summary-4-expected.txt:
platform/qt/fast/html/details-remove-summary-5-expected.png:
platform/qt/fast/html/details-remove-summary-5-expected.txt:
platform/qt/fast/html/details-remove-summary-6-expected.png:
platform/qt/fast/html/details-remove-summary-6-expected.txt:
platform/qt/fast/images/image-in-map-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
platform/qt/fast/images/image-in-map-expected.txt:
platform/qt/fast/inline/002-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/010-expected.png.
platform/qt/fast/inline/002-expected.txt:
platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Added.
platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Added.
platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.txt:
platform/qt/fast/inline/positionedLifetime-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/continuation-after-outline-expected.png.
platform/qt/fast/inline/positionedLifetime-expected.txt:
platform/qt/fast/invalid/005-expected.png: Copied from LayoutTests/platform/qt/fast/dom/comment-not-documentElement-expected.png.
platform/qt/fast/invalid/005-expected.txt:
platform/qt/fast/invalid/007-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-remove-summary-6-expected.png.
platform/qt/fast/invalid/007-expected.txt:
platform/qt/fast/invalid/020-expected.png:
platform/qt/fast/invalid/020-expected.txt:
platform/qt/fast/lists/004-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
platform/qt/fast/lists/004-expected.txt:
platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
platform/qt/fast/lists/ol-start-dynamic-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-no-summary2-expected.png.
platform/qt/fast/lists/ol-start-dynamic-expected.txt:
platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Added.
platform/qt/fast/multicol/table-vertical-align-expected.txt:
platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt:
platform/qt/fast/parser/tabs-in-scripts-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
platform/qt/fast/parser/tabs-in-scripts-expected.txt:
platform/qt/fast/reflections/reflection-direction-expected.png: Added.
platform/qt/fast/reflections/reflection-direction-expected.txt:
platform/qt/fast/reflections/reflection-masks-expected.png: Added.
platform/qt/fast/reflections/reflection-masks-expected.txt:
platform/qt/fast/reflections/reflection-masks-opacity-expected.png: Added.
platform/qt/fast/reflections/reflection-masks-opacity-expected.txt:
platform/qt/fast/repaint/block-no-inflow-children-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
platform/qt/fast/repaint/block-no-inflow-children-expected.txt:
platform/qt/fast/repaint/button-spurious-layout-hint-expected.txt:
platform/qt/fast/repaint/clip-with-layout-delta-expected.txt:
platform/qt/fast/repaint/continuation-after-outline-expected.png:
platform/qt/fast/repaint/continuation-after-outline-expected.txt:
platform/qt/fast/repaint/float-overflow-expected.png:
platform/qt/fast/repaint/float-overflow-expected.txt:
platform/qt/fast/repaint/float-overflow-right-expected.png:
platform/qt/fast/repaint/float-overflow-right-expected.txt:
platform/qt/fast/repaint/gradients-em-stops-repaint-expected.png:
platform/qt/fast/repaint/gradients-em-stops-repaint-expected.txt:
platform/qt/fast/repaint/iframe-scroll-repaint-expected.txt:
platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png.
platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
platform/qt/fast/repaint/lines-with-layout-delta-expected.txt:
platform/qt/fast/repaint/reflection-repaint-test-expected.png:
platform/qt/fast/repaint/reflection-repaint-test-expected.txt:
platform/qt/fast/repaint/repaint-svg-after-style-change-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png.
platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt:
platform/qt/fast/repaint/selection-clear-expected.png:
platform/qt/fast/repaint/selection-clear-expected.txt:
platform/qt/fast/repaint/transform-layout-repaint-expected.png:
platform/qt/fast/repaint/transform-layout-repaint-expected.txt:
platform/qt/fast/replaced/image-onload-expected.png:
platform/qt/fast/replaced/image-onload-expected.txt:
platform/qt/fast/runin/002-expected.png:
platform/qt/fast/runin/002-expected.txt:
platform/qt/fast/runin/generated4-expected.png:
platform/qt/fast/runin/generated4-expected.txt:
platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Added.

3:22 AM Changeset in webkit [124188] by tkent@chromium.org

2 edits in trunk/Tools

Unreviewed, update watchlist

Scripts/webkitpy/common/config/watchlist:
Improve "Forms" filename pattern.
tkent stops watching Chromium DRT. It was not so helpful.

3:20 AM Changeset in webkit [124187] by apavlov@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed, handle more tests failing after r124052.

platform/chromium/TestExpectations:

3:08 AM Changeset in webkit [124186] by commit-queue@webkit.org

6 edits
2 adds in trunk

Inspector crashes when trying to inspect a page with CSS region styling
https://bugs.webkit.org/show_bug.cgi?id=91503

Patch by Raul Hudea <rhudea@adobe.com> on 2012-07-31
Reviewed by Alexander Pavlov.

Source/WebCore:

Fix by making sure a CSSRuleSourceData is always created when parsing @-webkit-region rules.

Test: inspector/styles/region-style-crash.html

css/CSSGrammar.y: Made ruleset called explicitly markRuleBodyStart instead of depending on updateLastSelectorLineAndPosition to call it.
css/CSSParser.cpp:

(WebCore::CSSParser::updateLastSelectorLineAndPosition): markRuleBodyStart should be called via at_rule_body_start.

css/CSSPropertySourceData.h:

LayoutTests:

Test to make sure inspector is not crashing when having to parse @-webkit-region rules

inspector/styles/region-style-crash-expected.txt: Added.
inspector/styles/region-style-crash.html: Added.
platform/chromium/TestExpectations:

2:41 AM Changeset in webkit [124185] by commit-queue@webkit.org

5 edits in trunk/Source

Unreviewed, rolling out r124179.
http://trac.webkit.org/changeset/124179
https://bugs.webkit.org/show_bug.cgi?id=92730

Breaks Chromium Linux 32 bots with "error: integer constant is
too large for 'long' type" in IDBLevelDBCodingTest.cpp
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

Source/WebCore:

Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeByte):
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::encodeDouble):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):

Modules/indexeddb/IDBLevelDBCoding.h:

(IDBLevelDBCoding):

Source/WebKit/chromium:

tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

2:00 AM Changeset in webkit [124184] by rniwa@webkit.org

2 edits in trunk

Perf-o-matic: dashboard images are not generated properly from incrementally updated JSON
https://bugs.webkit.org/show_bug.cgi?id=92717

Reviewed by Hajime Morita.

Sort the values by timestamp. Unfortunately, there isn't a good way of testing this fix.

Websites/webkit-perf.appspot.com/models.py:

(Runs.chart_params):

1:53 AM Changeset in webkit [124183] by Martin Robinson

2 edits in trunk/Tools

[jhbuild] Also try to load jhbuild Python module from the source checkout

Reviewed by Philippe Normand.

JHBuild also seems to have an installation mode where it prefers to load its
Python modules from the source checkout. This seems to be used particularly
on the GTK+ 64-bit release bot. We should fall back to this mode.

jhbuild/jhbuildutils.py:

(enter_jhbuild_environment_if_available): Use the source checkout if there
is no installation path.

1:46 AM Changeset in webkit [124182] by commit-queue@webkit.org

7 edits in trunk

add Farstream flags/deps to WebKit, for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=87524

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-07-31
Reviewed by Philippe Normand.

Since Farstream will be used as the backend for GTK's WebRTC, this
patch adds it as a dependency to the build system.

GNUmakefile.am:
configure.ac:

Source/WebCore:

No new features or code changes were added, so new tests aren't necessary.

GNUmakefile.am:

Source/WebKit2:

GNUmakefile.am:

1:09 AM Changeset in webkit [124181] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed crash fix after r124135.

platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::Path): Ensure the Cairo path when acquiring its context,
crashes ensue otherwise.

12:58 AM Changeset in webkit [124180] by yosin@chromium.org

11 edits in trunk/Source/WebCore

Change Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldMatchReadWriteSelector or HTMLFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Reviewed by Kent Tamura.

This patch replaces Element::isReadOnlyFormControl() by
Element::shouldMatchReadOnlySelector/shouldMatchReadOnlySelector or
HTMLFormControlElement::readOnly() to make intention of functions
self descriptive.

No new tests. This patch doesn't change behavior.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class, and replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class.

dom/Element.cpp:

(WebCore::Element::shouldMatchReadOnlySelector): Added for default implementation.
(WebCore::Element::shouldMatchReadWriteSelector): for default implementation.

dom/Element.h:

(Element): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::shouldMatchReadOnlySelector): Added.
(WebCore::HTMLFormControlElement::shouldMatchReadWriteSelector): Added.

html/HTMLFormControlElement.h:

(HTMLFormControlElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::shouldMatchReadOnlySelector): Added.
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Added.
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
(SliderThumbElement):

html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto.
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto.
(WebCore::SpinButtonElement::shouldMatchReadOnlySelector): Added.
(WebCore::SpinButtonElement::shouldMatchReadWriteSelector): Added.
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().

html/shadow/TextControlInnerElements.h:

(SpinButtonElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyControl() by shouldMatchReadOnlySelector().

12:12 AM Changeset in webkit [124179] by commit-queue@webkit.org

4 edits in trunk/Source

IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-31
Reviewed by Kentaro Hara.

To avoid memory re-allocation in Vector, init the capability or size of Vector in encodeInt(), encodeVarInt(),
encodeBool(), encodeIDBKey() etc.

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.* which validates the sizes of buffers returned by encodeVarInt.

Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed