Timeline
Aug 13, 2012:
- 11:49 PM Changeset in webkit [125510] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Adding an empty platform baseline for r125462 just to avoid exceptions
in the layout-test step on the buildbots. The baseline will be updated
accordingly later.
- platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Added.
- 10:39 PM WebKitIDL edited by
- (diff)
- 10:35 PM Changeset in webkit [125509] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Unreviewed gardening, rebaselining after r125462.
Add a new test result to avoid layout-test exception
- platform/efl/svg/filters/color-interpolation-filters-expected.txt: Added.
- 9:58 PM Changeset in webkit [125508] by
-
- 39 edits12 moves in trunk/Tools
Rename files that declare and define LayoutTestController in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=93899
Reviewed by Tony Chang.
Renamed files and fixed style errors.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/LayoutTestController.cpp: Removed.
- DumpRenderTree/LayoutTestController.h: Removed.
- DumpRenderTree/PixelDumpSupport.cpp:
- DumpRenderTree/StorageTrackerDelegate.mm:
- DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
- DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
(LayoutTestController):
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
- DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
- DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
- DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
- DumpRenderTree/chromium/LayoutTestController.h: Removed.
- DumpRenderTree/chromium/TestShell.cpp:
- DumpRenderTree/chromium/TestShell.h:
- DumpRenderTree/chromium/WebPermissions.cpp:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTree.cpp:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
- DumpRenderTree/efl/EditingCallbacks.cpp:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
- DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
- DumpRenderTree/gtk/EditingCallbacks.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
- DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
- DumpRenderTree/mac/DumpRenderTree.mm:
- DumpRenderTree/mac/DumpRenderTreeWindow.mm:
- DumpRenderTree/mac/EditingDelegate.mm:
- DumpRenderTree/mac/FrameLoadDelegate.mm:
- DumpRenderTree/mac/HistoryDelegate.mm:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
- DumpRenderTree/mac/PolicyDelegate.mm:
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
- DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
- DumpRenderTree/mac/UIDelegate.mm:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
- DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
- DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
- DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
(WebCore):
(LayoutTestController):
(LayoutTestController::setCloseRemainingWindowsWhenComplete):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setCallCloseOnWebViews):
(LayoutTestController::addDisallowedURL):
(LayoutTestController::abortModal):
- DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
- DumpRenderTree/win/DumpRenderTree.cpp:
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/EditingDelegate.cpp:
- DumpRenderTree/win/FrameLoadDelegate.cpp:
- DumpRenderTree/win/HistoryDelegate.cpp:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
- DumpRenderTree/win/PolicyDelegate.cpp:
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
- DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
(LayoutTestController::setUserStyleSheetEnabled):
(resolveCygwinPath):
- DumpRenderTree/win/UIDelegate.cpp:
- DumpRenderTree/wscript:
- DumpRenderTree/wx/DumpRenderTreeWx.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
- DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
- 9:29 PM Changeset in webkit [125507] by
-
- 3 edits in trunk/Source/WebCore
Remove fade in transition from calendar picker
https://bugs.webkit.org/show_bug.cgi?id=93816
Reviewed by Kent Tamura.
The fade in transition was incomplete because it was only fading in the
popup content and not the popup itself. Removing the effect for now.
No new tests. Can't test animation.
- Resources/calendarPicker.css:
(#main):
- Resources/calendarPicker.js:
(initialize):
(fixWindowSize):
- 8:32 PM Changeset in webkit [125506] by
-
- 6 edits in trunk/Source/WebCore
WPARAM and LPARAM are incorrectly defined for x64
https://bugs.webkit.org/show_bug.cgi?id=89902
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.
Include WindowsExtras.h for PLATFORM(WIN) to define WPARAM and LPARAM correctly
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformWheelEvent.h:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
- platform/win/WindowMessageListener.h:
- 8:20 PM Changeset in webkit [125505] by
-
- 3 edits in trunk/Tools
Windows 64 bit compliance
https://bugs.webkit.org/show_bug.cgi?id=93275
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.
Fixed a few compile and link problems for Win64
- WinLauncher/WinLauncher.cpp:
- win/DLLLauncher/DLLLauncherMain.cpp:
- 7:53 PM Changeset in webkit [125504] by
-
- 4 edits in trunk/Source/WebCore
[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=93918
Patch by John Bates <jbates@google.com> on 2012-08-13
Reviewed by James Robinson.
Also, update some trace events.
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::setActive):
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::setActive):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::onVSyncParametersChanged):
- 7:52 PM Changeset in webkit [125503] by
-
- 3 edits2 adds in trunk
Crash in WebCore::RenderBlock::LineBreaker::nextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=93806
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-13
Reviewed by Abhishek Arya.
Source/WebCore:
When looking for line breaks on the first line, existing code was
checking for text-combine only in the first-line style. Since
text-combine isn't inherited this resulted in a line break being
chosen before combineText was called. When this happened and then
combineText was called subsequently, the position of the line break
iterator would be invalid.
This patch changes the check to use the regular style as in
skipLeadingWhitespace and textWidth.
Test: fast/text/text-combine-first-line-crash.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Don't use the
first-line style when checking text-combine.
LayoutTests:
- fast/text/text-combine-first-line-crash-expected.txt: Added.
- fast/text/text-combine-first-line-crash.html: Added.
- 7:49 PM EFLWebKitCodingStyle edited by
- (diff)
- 7:49 PM Changeset in webkit [125502] by
-
- 1 edit1 move1 add in trunk/LayoutTests
[Chromium] Unreviewed. Rebaseline test results for add-table-overpaint.html.
- platform/chromium-mac/fast/repaint/add-table-overpaint-expected.png: Added.
- platform/chromium-win/fast/repaint/add-table-overpaint-expected.png: Renamed from LayoutTests/platform/chromium/fast/repaint/add-table-overpaint-expected.png.
- 7:44 PM EFLWebKitCodingStyle edited by
-
Add #!cpp in
...(diff) - 7:43 PM Changeset in webkit [125501] by
-
- 3 edits in trunk/Source/WebCore
Remove unused method HTMLDocumentParser::script()
https://bugs.webkit.org/show_bug.cgi?id=93916
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.
The use of HTMLDocumentParser::script() was removed in r61640 and has never been used since then.
No behavior change, so no new tests.
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLDocumentParser.h:
- 7:37 PM Changeset in webkit [125500] by
-
- 20 edits in trunk/Source
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
https://bugs.webkit.org/show_bug.cgi?id=93283
Reviewed by Eric Seidel.
Source/WebCore:
Chromium has a refptr that needs to be NULLed at this point.
The approach is to change the client redirectDataToPlugin method(s) to expect
the possibility of a NULL argument, and the use this to clear the refptr on
the chromium platform. Other platforms can merely ignore the NULL case, thereby
maintaining the existing behaviour.
Formal testing is nearly impossible without some chrome-specific plugins.
- html/PluginDocument.cpp:
(WebCore::PluginDocument::detach):
Source/WebKit/blackberry:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
Source/WebKit/chromium:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, NULLing Chromium's refptr that needs to be NULLed.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
Source/WebKit/efl:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):
Source/WebKit/gtk:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::redirectDataToPlugin):
Source/WebKit/qt:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::redirectDataToPlugin):
Source/WebKit/win:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::redirectDataToPlugin):
Source/WebKit/wince:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):
Source/WebKit/wx:
Chromium has a refptr that needs to be NULLed at this point.
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::redirectDataToPlugin):
Source/WebKit2:
Chromium has a refptr that needs to be NULLed at this point.
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::redirectDataToPlugin):
- 7:31 PM EFLWebKitCodingStyle edited by
- Add a better explanation about the usage of !!s (diff)
- 7:17 PM Changeset in webkit [125499] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, update test expectations to reflect the recent results and
remove lint errors.
- platform/chromium/TestExpectations:
- 7:14 PM Changeset in webkit [125498] by
-
- 6 edits in trunk/Source
[chromium] Paint animated layers immediately to avoid animation hiccups.
https://bugs.webkit.org/show_bug.cgi?id=93028
Patch by Eric Penner <epenner@google.com> on 2012-08-13
Reviewed by Adrienne Walker.
Source/WebCore:
This is a technique used on Android, which is very prone
to hiccups in animations. Paint the entire layer if it is
of reasonable size such that there is no hiccups when the
animation reaches unpainted content. The reasonable size
is choosen for page-transitions specifically, as this was
the problem case (animations would just jump to the end).
Since we already have a special case this just modifies it
and replaces the unit test with a new one. This can be
improved/simplified further when distances/directions are
available for the animated layers.
Replaced one test.
Fixed bugs in and improved idlePaintNonVisibleLayers test.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::contentRectToTileIndices):
- platform/graphics/chromium/cc/CCPriorityCalculator.h:
(WebCore::CCPriorityCalculator::maxPriority):
Source/WebKit/chromium:
Replaced one test. Test painting full animated layer.
- tests/TiledLayerChromiumTest.cpp:
- 7:10 PM Changeset in webkit [125497] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Simple refactoring that I forgot to apply in r125495.
- bindings/v8/V8ThrowException.cpp:
(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
- bindings/v8/V8ThrowException.h:
- 7:09 PM Changeset in webkit [125496] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE][EFL] Fix build break with --tiled-backing-store
https://bugs.webkit.org/show_bug.cgi?id=93487
Unreviewed build fix for Efl with --tiled-backing-store.
- CMakeLists.txt:
Checked bison version and selected proper glslang files.
- 7:04 PM Changeset in webkit [125495] by
-
- 71 edits1 copy1 add in trunk/Source/WebCore
[V8] Factor out exception related methods of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93792
Reviewed by Adam Barth.
To remove V8Proxy, this patch factors out exception related methods of V8Proxy
to a separate file.
(1) Move exception related methods from V8Proxy.{h,cpp} to V8ThrowException.{h,cpp}.
(2) To avoid writing V8ThrowException::throwError() here and there in V8 binding,
implement WebCore::throwError() in V8Binding.{h,cpp}. Ideally, we want to list up
all V8 binding APIs in V8Binding.h.
(3) Replace all V8Proxy::throwError() with throwError().
Nit: I couldn't write the definition of WebCore::throwError() in V8BInding.h
due to circular dependency issues. Either way, these methods wouldn't be
performance-critical.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::MethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::OnSleepDetected):
- bindings/v8/NPV8Object.cpp:
(_NPN_SetException):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/V8Binding.cpp:
(WebCore::setDOMException):
(WebCore):
(WebCore::throwError):
(WebCore::throwTypeError):
(WebCore::throwNotEnoughArgumentsError):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::toV8Sequence):
- bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::checkNewLegal):
- bindings/v8/V8Proxy.h:
(V8Proxy):
(WebCore):
- bindings/v8/V8ThrowException.cpp: Added.
(WebCore):
(WebCore::DOMExceptionStackGetter):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
(WebCore::V8ThrowException::throwError):
(WebCore::V8ThrowException::throwTypeError):
(WebCore::V8ThrowException::throwNotEnoughArgumentsError):
- bindings/v8/V8ThrowException.h: Added.
(WebCore):
(V8ThrowException):
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
(WebCore::setTypeMismatchException):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
- bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
- bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback):
(WebCore::V8DOMFormData::appendCallback):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertySetter):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
- bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAccessorSetter):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):
- bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):
- bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageSetter):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
- bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback):
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):
- 6:48 PM EFLWebKitCodingStyle edited by
- (diff)
- 6:45 PM Changeset in webkit [125494] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
https://bugs.webkit.org/show_bug.cgi?id=93818
Reviewed by Adam Barth.
(1) This patch moves GCEventData class from V8Binding.h to ScriptGCEvent.h.
(2) This patch makes GCEventData::startTime and GCEventData::usedHeapSize
private members.
(3) This patch removes unused forward declarations from V8Binding.h.
No tests. No change in behavior.
- bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):
- bindings/v8/ScriptGCEvent.h:
(GCEventData):
(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(WebCore::GCEventData::listeners):
(WebCore::GCEventData::startTime):
(WebCore::GCEventData::setStartTime):
(WebCore::GCEventData::usedHeapSize):
(WebCore::GCEventData::setUsedHeapSize):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8PerIsolateData.cpp:
- 6:39 PM Changeset in webkit [125493] by
-
- 7 edits1 add in trunk/Source/WebCore
[V8] Move checkNewLegal() from V8Proxy.h to SafeAllocation.h
https://bugs.webkit.org/show_bug.cgi?id=93830
Reviewed by Adam Barth.
This patch moves checkNewLegal() from V8Proxy.h to SafeAllocation.h.
In addition, this patch renames checkNewLegal() to isValidConstructorMode()
for clarification.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/SafeAllocation.cpp: Added.
- bindings/v8/SafeAllocation.h:
(WebCore::SafeAllocation::newInstance):
(WebCore):
- bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 6:38 PM EFLWebKitCodingStyle edited by
- Add new coding style related to double not operator(!!) (diff)
- 6:34 PM Changeset in webkit [125492] by
-
- 2 edits in trunk/Source/WebCore
[V8] Remove unused methods from V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=93836
Reviewed by Adam Barth.
enableStringImplCache() and v8UndetectableString() are not used by anybody.
No tests. No change in behavior.
- bindings/v8/V8Binding.h:
- 6:32 PM Changeset in webkit [125491] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
https://bugs.webkit.org/show_bug.cgi?id=93834
Reviewed by Adam Barth.
This patch moves hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.
No tests. No change in behavior.
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::hintForGCIfNecessary):
- bindings/v8/V8GCController.h:
(V8GCController):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 6:29 PM Changeset in webkit [125490] by
-
- 4 edits in trunk/LayoutTests
Unreviewed rebaseline after r125193.
- platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png:
- platform/chromium-win/compositing/masks/layer-mask-placement-expected.png:
- platform/chromium/TestExpectations:
- 6:27 PM Changeset in webkit [125489] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r124970.
http://trac.webkit.org/changeset/124970
https://bugs.webkit.org/show_bug.cgi?id=93495
Postponing the merge in a clearer context (Requested by
Michelangelo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransform):
- css/CSSParser.h:
- 6:24 PM Changeset in webkit [125488] by
-
- 1 edit4 adds in trunk/LayoutTests
Add test to demonstrate overpainting seen in bug 92800
https://bugs.webkit.org/show_bug.cgi?id=93901
Reviewed by Levi Weintraub.
Bug 92800 is a rather complicated change to fix this overpainting bug.
Adding the test before the change so that it's easier for me to track as I change
this behavior and for reviewers to see that I'm fixing this overpainting.
- fast/repaint/add-table-overpaint-expected.png: Added.
- fast/repaint/add-table-overpaint-expected.txt: Added.
- fast/repaint/add-table-overpaint.html: Added.
- 6:04 PM Changeset in webkit [125487] by
-
- 2 edits in trunk/Tools
Unreviewed update for webcomponents-bugzilla address.
- Scripts/webkitpy/common/config/committers.py:
- 6:03 PM Changeset in webkit [125486] by
-
- 4 edits in trunk/Source
[chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
https://bugs.webkit.org/show_bug.cgi?id=93795
Reviewed by Adrienne Walker.
Source/WebCore:
If a renderSurface is created by a layer that had zero
area (empty) but non-zero bounds (either width or height was
non-zero), then one translation transform was accidentally being
skipped, causing the renderSurface drawTransform to be incorrect.
The fix is simply to move that transform outside of the
if-statement so it is not skipped.
Unit test added:
CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer()
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
- 5:57 PM Changeset in webkit [125485] by
-
- 2 edits in trunk/WebKitLibraries
Enable CSS Sticky Position on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93905
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-13
Reviewed by Tim Horton.
As per https://bugs.webkit.org/show_bug.cgi?id=90046, the ENABLE_CSS_STICKY_POSITION needs to be turned on for Windows as well.
- win/tools/vsprops/FeatureDefines.vsprops:
Include ENABLE_CSS_STICKY_POSITION flag.
- 5:55 PM Changeset in webkit [125484] by
-
- 18 edits in trunk/Source/WebCore
[V8] Remove [TreatReturnedNullAs=False]
https://bugs.webkit.org/show_bug.cgi?id=93835
Reviewed by Adam Barth.
[TreatReturnedNullAs=False] is neither defined in the Web IDL spec
nor used in any WebKit IDL file.
No tests. No change in behavior.
- WebCore.order:
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue):
- bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/V8Binding.h:
- 5:53 PM Changeset in webkit [125483] by
-
- 5 edits in trunk/Source/WebCore
[V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=93839
Reviewed by Adam Barth.
For naming consistency with toWebCoreString() and toWebCoreAtomicString(),
this patch renames v8ValueToWebCoreDOMStringList() to toDOMStringList().
("WebCore" wouldn't be needed because it's clear from "DOMStringList".)
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
- bindings/v8/V8Binding.h:
(WebCore):
- 5:51 PM Changeset in webkit [125482] by
-
- 14 edits in trunk/Source/WebCore
[V8] Rename v8ValueToAtomicWebCoreString() to toWebCoreAtomicString()
https://bugs.webkit.org/show_bug.cgi?id=93824
Reviewed by Adam Barth.
For naming consistency with toWebCoreString(), we can rename
v8ValueToAtomicWebCoreString() to toWebCoreAtomicString().
Also we can rename v8ValueToAtomicWebCoreStringWithNullCheck()
to toWebCoreAtomicStringWithNullCheck().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):
- bindings/v8/V8Binding.cpp:
(WebCore::toWebCoreAtomicString):
- bindings/v8/V8Binding.h:
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::toWebCoreAtomicStringWithNullCheck):
- bindings/v8/V8Collection.h:
(WebCore::getNamedPropertyOfCollection):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
- 5:49 PM Changeset in webkit [125481] by
-
- 7 edits in trunk/Source/WebCore
[V8] Remove v8ValueToWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=93822
Reviewed by Adam Barth.
There are two equivalent ways to convert a V8 value to a WebCore String;
i.e. v8ValueToWebCoreString() and toWebCoreString(). We can remove the former.
In a follow-up patch, I will replace v8ValueToAtomicWebCoreString()
with toWebCoreAtomicString(), for consistency with toWebCoreString().
No tests. No change in behavior.
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
- bindings/v8/V8Binding.cpp:
(WebCore::toWebCoreString):
(WebCore::v8ValueToWebCoreDOMStringList):
- bindings/v8/V8Binding.h:
(WebCore::toWebCoreStringWithNullCheck):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
- 5:47 PM Changeset in webkit [125480] by
-
- 4 edits in trunk/Source/WebCore
[V8] Move the ConstructorMode class from V8Binding.h to SafeAllocation.h
https://bugs.webkit.org/show_bug.cgi?id=93821
Reviewed by Adam Barth.
This patch factors out the ConstructorMode class from V8Binding.h to SafeAllocation.h.
No tests. No change in behavior.
- bindings/v8/SafeAllocation.h:
(ConstructorMode):
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(WebCore):
- bindings/v8/V8Binding.h:
- bindings/v8/V8RecursionScope.h:
- 5:44 PM Changeset in webkit [125479] by
-
- 5 edits2 deletes in trunk/Source/WebCore
[V8] Remove V8BindingHelpers
https://bugs.webkit.org/show_bug.cgi?id=93807
Reviewed by Adam Barth.
V8BindingHelpers contains toV8Context() and toV8Proxy(), which are used
by NPV8Object.cpp only.
(1) Move these methods to NPV8Object.cpp as static methods.
(2) Remove V8BindingHelpers.{h,cpp}.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/NPV8Object.cpp:
(WebCore::toV8Context):
(WebCore):
(WebCore::toV8Proxy):
- bindings/v8/V8Binding.h:
- bindings/v8/V8BindingHelpers.cpp: Removed.
- bindings/v8/V8BindingHelpers.h: Removed.
- 5:42 PM Changeset in webkit [125478] by
-
- 3 edits in trunk/Source/WebCore
[V8] Remove unused methods and headers from V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=93805
Reviewed by Adam Barth.
This patch removes unused methods, forward declarations and
headers from V8Utilities.{h,cpp}.
No tests. No change in behavior.
- bindings/v8/V8Utilities.cpp:
- bindings/v8/V8Utilities.h:
(WebCore):
- 5:40 PM Changeset in webkit [125477] by
-
- 3 edits in trunk/Source/WebCore
[V8] Move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp
https://bugs.webkit.org/show_bug.cgi?id=93803
Reviewed by Adam Barth.
In r125015, I forgot to move V8PerIsolateData::visitExternalStrings()
to V8PerIsolateData.cpp. This patch moves it.
No tests. No change in behavior.
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8PerIsolateData.cpp:
(WebCore):
(WebCore::V8PerIsolateData::visitExternalStrings):
- 5:38 PM Changeset in webkit [125476] by
-
- 6 edits2 adds in trunk
Expand list of supported languages for RenderQuote to match WHATWG spec
https://bugs.webkit.org/show_bug.cgi?id=93424
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.
Source/WebCore:
Expand the table of quotes to include the 148 lang values and associated quotes
from the WHATWG web-apps recommended styling spec.
Test: fast/css-generated-content/quotes-lang-case-insensitive.html
- rendering/RenderQuote.cpp: Added missing copyright.
(WebCore::quotesDataLanguageMap): Expanded the table of quotes.
(WebCore::basicQuotesData): Added a FIXME to switch to using stylized "en" quotes.
- rendering/RenderQuote.h: Added missing copyright.
LayoutTests:
Update quote language test to include the 148 languages in the WHATWG web-apps
recommended styling table.
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#quotes
Add a new test that ensures language matching for quotes is case insensitive.
- fast/css-generated-content/quotes-lang-case-insensitive-expected.html: Added.
- fast/css-generated-content/quotes-lang-case-insensitive.html: Added.
- fast/css-generated-content/quotes-lang-expected.html:
- fast/css-generated-content/quotes-lang.html:
- 5:36 PM Changeset in webkit [125475] by
-
- 5 edits in trunk/Source/WebCore
[V8] Remove evaluateInIsolatedWorld() from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93679
Reviewed by Adam Barth.
To remove V8Proxy, this patch moves V8Proxy::evaluateInIsolatedWorld()
to ScriptController.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::precompileScript):
- 5:33 PM Changeset in webkit [125474] by
-
- 8 edits4 copies in branches/chromium/1229
Merge 125193 - [chromium] Pass mask scale and offset to shaders for correct masking
https://bugs.webkit.org/show_bug.cgi?id=93558
Reviewed by Adrienne Walker.
Source/WebCore:
In chromium compositor code, the mask was accidentally mapped 1:1
to the layer's renderSurface, rather than the layer itself. This
patch adds a layout test that reproduces the error and fixes the
problem. The solution we opted for in this patch is to pass a
scale and offset to the fragment shader, so that the correct
texture coordinate lookup is computed by the fragment shader.
Test: compositing/masks/mask-of-clipped-layer.html
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPassQuad):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
- platform/graphics/chromium/ShaderChromium.h:
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMaskAA):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleY):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetY):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::appendQuads):
Source/WebKit/chromium:
Updated one unit test that needed additional args in a
constructor, but no change in behavior of the test.
- tests/CCLayerTreeHostImplTest.cpp:
LayoutTests:
Added a layout test that checks the mask does not accidentally get
resized when it is inside of an overflow div.
- compositing/masks/mask-of-clipped-layer-expected.png: Added.
- compositing/masks/mask-of-clipped-layer-expected.txt: Added.
- compositing/masks/mask-of-clipped-layer.html: Added.
- compositing/resources/alpha-blocks.png: Added.
- 5:22 PM Changeset in webkit [125473] by
-
- 3 edits in trunk/Source/WebCore
[CSS Exclusions] Remove unused CSSWrapShapes header includes
https://bugs.webkit.org/show_bug.cgi?id=93395
Patch by Bear Travis <betravis@adobe.com> on 2012-08-13
Reviewed by Kentaro Hara.
Removing the #include "CSSWrapShapes.h" lines from StyleBuilder.cpp and
RenderStyle.cpp. Both files now use the length-based WrapShapes.h classes.
- css/StyleBuilder.cpp:
- rendering/style/RenderStyle.cpp:
- 5:11 PM Changeset in webkit [125472] by
-
- 3 edits2 adds in trunk
Bad cast in RenderBox::computeReplacedLogicalHeightUsing
https://bugs.webkit.org/show_bug.cgi?id=93875
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-08-13
Reviewed by Abhishek Arya.
Source/WebCore:
Pointer to the container of a replaced element was being type casted to renderbox
without checking if the container is a renderbox or not.
Test: fast/replaced/render-inline-cast-to-render-box-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
Scrollbar height is retrieved only if the container is a renderBox. Otherwise scrollbar is taken as zero.
LayoutTests:
- fast/replaced/render-inline-cast-to-render-box-crash-expected.txt: Added.
- fast/replaced/render-inline-cast-to-render-box-crash.html: Added.
- 5:05 PM Changeset in webkit [125471] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93910
Unreviewed test expectations update. Temporarily skipping tests.
- platform/mac/TestExpectations:
- 4:49 PM Changeset in webkit [125470] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unreviewed bot fix after r125467.
- PlatformEfl.cmake: Make the WK2 tests link against glib, gobject
and gio as well.
- 4:45 PM Changeset in webkit [125469] by
-
- 11 edits1 move1 add in trunk/Source
[chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols
https://bugs.webkit.org/show_bug.cgi?id=93907
Reviewed by Darin Fisher.
Source/Platform:
This makes WebAnimation a pure virtual interface with instances returned by a factory function. Currently the
factory is a static function on WebAnimation, but it will likely move to a platform support interface. This
provides better isolation of the implementation from the interface and in particular allows for implementing the
WebAnimation interface outside of WebKit.dll without having unresolved external symbols in WebKit.dll.
- chromium/public/WebAnimation.h:
(WebKit::WebAnimation::~WebAnimation):
(WebAnimation):
- chromium/public/WebLayer.h:
(WebLayer):
Source/WebCore:
Updates WebAnimation users for interface changes.
- platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::createWebAnimation):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
Source/WebKit/chromium:
Adds a WebAnimationImpl implementation of the WebAnimation interface.
- WebKit.gyp:
- src/WebAnimationImpl.cpp: Renamed from Source/WebKit/chromium/src/WebAnimation.cpp.
(WebKit):
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::targetProperty):
(WebKit::WebAnimationImpl::iterations):
(WebKit::WebAnimationImpl::setIterations):
(WebKit::WebAnimationImpl::startTime):
(WebKit::WebAnimationImpl::setStartTime):
(WebKit::WebAnimationImpl::timeOffset):
(WebKit::WebAnimationImpl::setTimeOffset):
(WebKit::WebAnimationImpl::alternatesDirection):
(WebKit::WebAnimationImpl::setAlternatesDirection):
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- src/WebAnimationImpl.h: Added.
(WebCore):
(WebKit):
(WebAnimationImpl):
(WebKit::WebAnimationImpl::WebAnimationImpl):
(WebKit::WebAnimationImpl::~WebAnimationImpl):
- src/WebLayer.cpp:
(WebKit::WebLayer::addAnimation):
- tests/WebAnimationTest.cpp:
(WebKit::TEST):
- 4:41 PM Changeset in webkit [125468] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unreviewed attempt at fixing the bots after r125467.
- PlatformEfl.cmake: Link against GIO and GObject due to the usage
of libsoup.
- 4:30 PM Changeset in webkit [125467] by
-
- 15 edits1 add1 delete in trunk
[CMake] Rewrite FindLibSoup2.cmake.
https://bugs.webkit.org/show_bug.cgi?id=93191
Reviewed by Rob Buis.
.:
The existing LibSoup2 was imported from somewhere else and not
only did it contain a lot of unnecessary cruft to look for libsoup
2.2 (which we do not support anyway), but it also relied on the
paths returned by pkg-config for setting the library and include
paths.
For one, this meant "-lsoup-2.4" was passed to the linked instead
of "-L/path/to/libsoup-2.4.so", which would sometimes make a
system version of libsoup to be picked up instead of the one
installed by, say, jhbuild.
The new FindLibSoup.cmake now only looks for libsoup 2.4 and
relies on pkg-config solely for retrieving the current LibSoup
version.
- Source/cmake/FindLibSoup.cmake: Added.
- Source/cmake/FindLibSoup2.cmake: Removed.
- Source/cmake/OptionsEfl.cmake: Look for LibSoup instead of
LibSoup2, look for the GObject component of Glib.
Source/WebCore:
- PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO,
also link against GObject, which is needed by libsoup.
Source/WebKit:
- PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO.
Source/WebKit2:
- PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO, and
do not use LIBSOUP24_LDFLAGS, as it is not needed anymore.
Tools:
- DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of
LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
needed anymore.
- EWebLauncher/CMakeLists.txt: Ditto.
- MiniBrowser/efl/CMakeLists.txt: Ditto.
- TestWebKitAPI/PlatformEfl.cmake: Ditto.
- WebKitTestRunner/CMakeLists.txt: Ditto.
- WebKitTestRunner/PlatformEfl.cmake: Ditto.
- 3:46 PM Changeset in webkit [125466] by
-
- 12 edits2 adds in trunk/Source
[chromium] Clean up dependencies for Canvas2DLayerBridgeTest and GraphicsLayerChromiumTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=93757
Reviewed by Adrienne Walker.
Source/Platform:
Exposes a function to check for active animations on a layer.
- chromium/public/WebLayer.h:
(WebLayer):
Source/WebCore:
Exposes the current contentsScale for tests.
- platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
Source/WebKit/chromium:
Breaks up some unit tests and removes unused code to avoid unit tests depending on both non-compositor WebCore
logic and compositor internals. Canvas2DLayerBridgeTest had some vestigal includes and local variables that
weren't being used, those are removed. GraphicsLayerChromiumTest was reaching into CC types, but could mostly
use Platform API types for testing.
GraphicsLayerChromiumTest had some tests that were verifying that we could correctly translate WebCore
animation lists into CCAnimation types - these have been moved into AnimationTranslationUtilTest.cpp, since the
logic under test is in AnimationTranslationUtil. Currently these only test that we accept / reject animations as
expected. They could be expanded to verify that the animation was translated faithfully, but that would require
expanding the information exposed on WebAnimation.
- WebKit.gypi:
- src/WebLayer.cpp:
(WebKit::WebLayer::hasActiveAnimation):
(WebKit):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(GraphicsLayerChromiumTest):
(WebKit::TEST_F):
- tests/WebLayerTreeViewTest.cpp:
- tests/WebLayerTreeViewTestCommon.h: Added.
(WebKit):
(MockWebLayerTreeViewClient):
- 3:44 PM Changeset in webkit [125465] by
-
- 3 edits in trunk/Source/WebCore
Reduce the size of empty NinePieceImage objects.
<http://webkit.org/b/93747>
Reviewed by Antti Koivisto.
Move the members of NinePieceImage into a NinePieceImageData class, leaving NinePieceImage
with a single OwnPtr<NinePieceImageData> member. The constant NinePieceImage::defaultData()
provides default values for objects with null m_data.
RenderStyle's "StyleSurroundData" member has a BorderData, which in turn holds a NinePieceImage.
This means that anything with left/right/top/bottom, margin, padding or border style but *no*
border-image will save 104 bytes (assuming their RenderStyle is unshared, which is fairly common.)
This reduces the size of StyleSurroundData by 104 bytes, effectively reducing memory consumption
by 1.72MB when viewing the full HTML5 spec at <http://whatwg.org/c>
- rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImageData::operator==):
(WebCore::NinePieceImage::defaultData):
(WebCore):
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImageData::NinePieceImageData):
(NinePieceImageData):
(WebCore::NinePieceImageData::operator!=):
(WebCore):
(NinePieceImage):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::operator=):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::ensureData):
(WebCore::NinePieceImage::data):
- 3:42 PM Changeset in webkit [125464] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
More Windows build fixing.
- UIProcess/WebContext.cpp: (WebKit::WebContext::dummy):
- 3:39 PM Changeset in webkit [125463] by
-
- 6 edits16 deletes in branches/safari-536.26-branch
Merge fix for <rdar://problem/12050793>.
- 3:37 PM Changeset in webkit [125462] by
-
- 41 edits3 adds in trunk
WebKit+SVG does not support color-interpolation-filters or draw filters in correct colorspace
https://bugs.webkit.org/show_bug.cgi?id=6033
Reviewed by Dirk Schulze.
Source/WebCore:
This patch adds support for SVG color-interpolation-filters. All non-CG plarforms now
perform color space conversions as needed (CG performs color space adjustments internally),
and the new default color space for filters is linearRGB
(http://www.w3.org/TR/SVG/filters.html#FilterPrimitivesOverviewIntro).
FilterEffect tracks the color-interpolation-filters attribute (m_colorSpace) and the
current result color space (m_resultColorSpace). When applying, the input results are
converted to the current FilterEffect's color space, and at the end of the filter effect
chain the result is finally converted to ColorSpaceDeviceRGB.
FilterEffect::transformResultColorSpace() handles non-CG color space converion (CG has
built in support for different color spaces) by first converting the result to an image
buffer, and then using the platform specific ImageBuffer::transformColorSpace(). This can
be expensive for filter chains with alternating color-interpolation-filters, but can be
optimized if/when color space support is added to all the graphics backends similarly to CG.
As expected, lots of filter-related pixel results will require rebaselining after this lands.
Test: svg/filters/color-interpolation-filters.svg
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::transformResultColorSpace):
(WebCore):
- platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::colorSpace):
(WebCore::FilterEffect::setColorSpace):
(FilterEffect):
- platform/graphics/filters/SourceGraphic.h:
(WebCore::SourceGraphic::SourceGraphic):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::apply):
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::postApplyResource):
LayoutTests:
- platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png:
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-expected.png:
- platform/chromium-linux/svg/filters/color-interpolation-filters-expected.png: Added.
- platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt: Added.
- platform/chromium-win/css3/filters/add-filter-rendering-expected.png:
- platform/chromium-win/css3/filters/crash-filter-change-expected.png:
- platform/chromium-win/css3/filters/effect-blur-expected.png:
- platform/chromium-win/css3/filters/effect-combined-expected.png:
- platform/chromium-win/css3/filters/effect-contrast-expected.png:
- platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
- platform/chromium-win/css3/filters/effect-grayscale-expected.png:
- platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
- platform/chromium-win/css3/filters/effect-invert-expected.png:
- platform/chromium-win/css3/filters/effect-opacity-expected.png:
- platform/chromium-win/css3/filters/effect-reference-expected.png:
- platform/chromium-win/css3/filters/effect-reference-external-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
- platform/chromium-win/css3/filters/effect-saturate-expected.png:
- platform/chromium-win/css3/filters/effect-sepia-expected.png:
- platform/chromium-win/css3/filters/filtered-inline-expected.png:
- platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
- platform/chromium-win/css3/filters/nested-filters-expected.png:
- platform/chromium-win/css3/filters/regions-expanding-expected.png:
- platform/chromium-win/css3/filters/simple-filter-rendering-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/css3/filters/blur-filter-page-scroll-expected.png:
- platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- svg/filters/color-interpolation-filters.svg: Added.
- 3:35 PM Changeset in webkit [125461] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebCore
Merged r125104. <rdar://problem/12082988>
- 3:16 PM Changeset in webkit [125460] by
-
- 7 edits in trunk
Oscillator node should throw exception if type is assigned an invalid value
https://bugs.webkit.org/show_bug.cgi?id=93490
Patch by Raymond Toy <Raymond Toy> on 2012-08-13
Reviewed by Chris Rogers.
Source/WebCore:
New tests added to oscillator-basic to catch exceptions.
- Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::setType): Return exception
- Modules/webaudio/Oscillator.h:
(Oscillator): Update setType declaration
- Modules/webaudio/Oscillator.idl: setType can raise exception.
LayoutTests:
Add tests for invalid oscillator types.
- webaudio/oscillator-basic-expected.txt: Updated
- webaudio/oscillator-basic.html: Test CUSTOM and invalid
oscillator type.
- 3:16 PM Changeset in webkit [125459] by
-
- 5 edits3 copies in branches/safari-536.26-branch
Merged r125086. <rdar://problem/12082988>
- 3:07 PM Changeset in webkit [125458] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
More Windows build fix
- UIProcess/WebContext.cpp: (WebKit::WebPage::dummy):
- UIProcess/WebContext.h: (WebContext):
- UIProcess/WebContext.messages.in: Add a dummy sync message - the same workaround is already used in WebPage.
- 3:04 PM Changeset in webkit [125457] by
-
- 10 edits3 adds in trunk
With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
<rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
A few things were in play here:
- The WebProcess thought the plug-in was done initializing but it wasn't.
- The sync message out from the PluginProcess was not being handled by the WebProcess.
Expose the ability for the PluginProcess to act as if it is handling a sync message and needs messages dispatched:
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::incrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):
(CoreIPC::Connection::decrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::setInitializationReply): Save the delayed reply for synchronous initialization.
(WebKit::PluginControllerProxy::takeInitializationReply): Give back the delayed reply for initialization completion.
(WebKit::PluginControllerProxy::initialize):
- PluginProcess/PluginControllerProxy.h:
(WebKit::PluginControllerProxy::isInitializing): Accessor so WebProcessConnection knows whether or not to store the
delayed reply for later.
- PluginProcess/WebProcessConnection.messages.in: Make the synchronous form of "CreatePlugin" have a delayed reply.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPlugin): Store away the delayed reply message so it can be responded to after
asynchronous initialization completes.
(WebKit::WebProcessConnection::createPluginAsynchronously): If there is a stored away delayed reply message, respond to
it instead of sending the asynchronously reply.
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
Tools:
Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.
(EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::NPP_New):
LayoutTests:
- platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt: Added.
- platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html: Added.
- 3:03 PM Changeset in webkit [125456] by
-
- 4 edits in trunk/Source/WebCore
AudioContext::createMediaStreamSource() must create a provider for local MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=93756
Reviewed by Eric Carlson.
There are two main kinds of MediaStreams (local and from remote peers).
Internally we need to know the difference so a MediaStreamAudioSourceNode will "just work".
Tested by existing test: mediastreamaudiosourcenode.html
Full testing can only be verified by manual tests.
- Modules/mediastream/LocalMediaStream.h:
(LocalMediaStream):
- Modules/mediastream/MediaStream.h:
(WebCore::MediaStream::isLocal):
(MediaStream):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource):
- 2:51 PM Changeset in webkit [125455] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebCore
Merged r123013. <rdar://problem/12087344>
- 2:49 PM Changeset in webkit [125454] by
-
- 5 edits in trunk
Unreviewed, rolling out r125422.
http://trac.webkit.org/changeset/125422
https://bugs.webkit.org/show_bug.cgi?id=93902
Broke the Android canary build (Requested by fmalita on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 2:42 PM Changeset in webkit [125453] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
Windows build fix.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Use WebProcessProxy for the message here, too.
- 2:37 PM Changeset in webkit [125452] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r125444.
http://trac.webkit.org/changeset/125444
https://bugs.webkit.org/show_bug.cgi?id=93872
Broke some tests
Source/JavaScriptCore:
- Target.pri:
Source/WebCore:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
- 2:29 PM Changeset in webkit [125451] by
-
- 10 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
Reviewed by Sam Weinig.
There was one plug-in message renaming. Moving it, and also other plug-in messages
for consistency.
- UIProcess/WebContext.cpp: (WebKit): Got rid of the last MESSAGE_CHECK in this file. (WebKit::WebContext::WebContext): Moved m_pluginWorkQueue to a singleton. We don't need more than one queue (all it does is read plug-in info), and if we needed, it would have been per-process, not per-context. (WebKit::WebContext::~WebContext): No more work queue. (WebKit::WebContext::processDidFinishLaunching): Ditto.
- UIProcess/WebContext.h: No longer needs to be a QueueClient.
- UIProcess/WebContext.messages.in:
- UIProcess/WebProcessProxy.messages.in: Moved plug-in related messages.
- UIProcess/WebProcessProxy.cpp: (WebKit::pluginWorkQueue): Moved from WebContext to a singleton. (WebKit::WebProcessProxy::sendDidGetPlugins): Moved from WebContext. (WebKit::WebProcessProxy::handleGetPlugins): Ditto. (WebKit::WebProcessProxy::getPlugins): Ditto. (WebKit::WebProcessProxy::getPluginPath): Ditto. (WebKit::WebProcessProxy::getPluginProcessConnection): Ditto. (WebKit::WebProcessProxy::didGetSitesWithPluginData): Ditto. (WebKit::WebProcessProxy::didClearPluginSiteData): Ditto.
- UIProcess/WebProcessProxy.h: Process proxy needs to be thread safe ref counted now, since it sends messages to itself on a work queue and back.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::populatePluginCache): Updated for new receiver.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Ditto.
- WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ditto.
- 2:15 PM Changeset in webkit [125450] by
-
- 9 edits2 deletes in trunk
CanvasRenderContext2D::font() does not re-serialize the font
https://bugs.webkit.org/show_bug.cgi?id=50859
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Added proper serialization for the font property.
No new tests, unskipped the existing ones.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::font):
LayoutTests:
Unskip tests that will now pass and remove wrong/duplicated
expectations. canvas-font-ex-units-crash has now the wrong
expectations until we fix the issue on 93840.
- fast/canvas/canvas-font-ex-units-crash-expected.txt:
- fast/canvas/script-tests/canvas-font-ex-units-crash.js:
Even though we are setting a value on this test case (and verifying),
the font is not being effectiviely set as the serialization reveled. This
is going to be fixed in another bug.
- platform/chromium/TestExpectations:
- platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
- platform/qt/Skipped:
- 2:09 PM Changeset in webkit [125449] by
-
- 8 edits in branches/safari-536.26-branch
Merged r118725 for <rdar://problem/11942136>
- 2:06 PM Changeset in webkit [125448] by
-
- 6 edits2 adds in trunk
CSS quotes output quotes when depth is negative
https://bugs.webkit.org/show_bug.cgi?id=92690
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.
Source/WebCore:
Previously if the quote depth would go negative we would output the close quote from the
first pair of quotes again instead of outputting no quotes as required by the spec.
See: http://www.w3.org/TR/CSS21/generate.html#quotes-insert
Test: fast/css-generated-content/nested-quote-more-than-pairs.html
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText): Allow the value passed to getOpenQuote to go negative by removing std::max.
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::getOpenQuote): Bounds check for negative values for safety.
(WebCore::QuotesData::getCloseQuote): Allow index to be >= -1 and return an empty string for -1.
LayoutTests:
Make the expected output of close-quote-negative-depth.html follow the spec and
add another test that ensures the last quote pair is repeated when the depth is
greater than the number of quote pairs.
- fast/css-generated-content/close-quote-negative-depth-expected.html:
- fast/css-generated-content/close-quote-negative-depth.html:
- fast/css-generated-content/nested-quote-more-than-pairs-expected.html: Added.
- fast/css-generated-content/nested-quote-more-than-pairs.html: Added.
- 2:01 PM Changeset in webkit [125447] by
-
- 2 edits in trunk/LayoutTests
Unreviewed skip: Skip faling test after r125428.
The fix will be tracked in https://bugs.webkit.org/show_bug.cgi?id=93897
- platform/qt/Skipped:
- 2:01 PM Changeset in webkit [125446] by
-
- 5 edits2 copies in branches/safari-536.26-branch
Merged r118721 for <rdar://problem/11942136>
- 1:48 PM Changeset in webkit [125445] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Clear HUD canvas contents before drawing into it.
https://bugs.webkit.org/show_bug.cgi?id=93759
Reviewed by Adrienne Walker.
Not clearing the bitmaps before drawing into it results into
random noise. This patch also caches the SkCanvas used by the HUD
to avoid reallocating it every frame.
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
- 1:44 PM Changeset in webkit [125444] by
-
- 5 edits in trunk/Source
[Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap
https://bugs.webkit.org/show_bug.cgi?id=93872
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
- Target.pri: Add missing JSWeakObjectMap file to build.
Source/WebCore:
The intention of this patch series is to replace use of internal JSC
API with use of the stable and public C API.
The JSC::Weak template is internal API and the only part of the C API
that exposes similar functionality is the JSWeakObjectMap. It is
special in the sense that its life-time is tied to the life-time of the
JS global object, which in turn is subject to garbage collection. In
order to maximize re-use of the same map across different JSContextRef
instances, we use the associated global context ref as owner of the
weak maps. The key in the weak map is the identity (pointer) of the
runtime method object itself. The iteration through the maps is
tedious, but should usually not go beyond just a few.
- bridge/qt/qt_runtime.cpp:
(Bindings):
(JSC::Bindings::methodMapCleaner):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
- 1:38 PM Changeset in webkit [125443] by
-
- 17 edits1 add3 deletes in trunk
[CMake] Remove glib-related Find modules and write single new one instead.
https://bugs.webkit.org/show_bug.cgi?id=93786
Reviewed by Rob Buis.
.:
As part of the ongoing effort to write proper Find modules that use
absolute include and library paths instead of the short ones from
pkg-config, replace Find{GIO,Glib,Gthread}.cmake with a single
FindGLIB.cmake that optionally detects components such as GIO and
GObject.
Library paths are now defined as "/full/path/to/libfoo.so" instead of
simply "foo", so that the linker receives a full path and we can then
avoid accidentally picking up a libfoo.so installed into /usr/lib
instead of a local one built with jhbuild.
- Source/cmake/FindGIO.cmake: Removed.
- Source/cmake/FindGLIB.cmake: Added.
- Source/cmake/FindGlib.cmake: Removed.
- Source/cmake/FindGthread.cmake: Removed.
- Source/cmake/OptionsEfl.cmake: Look for GLIB with the GIO component.
Source/JavaScriptCore:
- shell/PlatformEfl.cmake: Use GLIB_* instead of Glib_*.
Source/WebCore:
No new tests, build system plumbing.
- PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link
directly against GIO, as code in the soup network backend uses
that.
Source/WebKit:
- PlatformEfl.cmake: Use GLIB_* instead of Glib_*.
Source/WebKit2:
- PlatformEfl.cmake: Use GLIB_* instead of Glib_*.
Source/WTF:
- wtf/PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link directly to GIO, as wtf/gobject uses functions from it.
Tools:
- DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
- EWebLauncher/CMakeLists.txt: Ditto.
- MiniBrowser/efl/CMakeLists.txt: Ditto.
- WebKitTestRunner/PlatformEfl.cmake: Ditto.
- 1:33 PM Changeset in webkit [125442] by
-
- 3 edits in trunk/Source/WebCore
[Qt] Simplify storage and reduce size of QtConnectionObject
https://bugs.webkit.org/show_bug.cgi?id=93868
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
The connection object is a child of the sender QObject, so we can use parent()
whenever we need the sender instead of keeping an extra QObject pointer. Also
QtConnectionObject kept a RefPtr to the Instance, but actually only needed the
root object, so we can store a pointer to that instead.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
- bridge/qt/qt_runtime.h:
(QtConnectionObject):
- 1:23 PM Changeset in webkit [125441] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update API for spell checking suggestions again.
https://bugs.webkit.org/show_bug.cgi?id=93877
Reviewed by Antonio Gomes.
PR 163283.
Update the spell checking options request API
to include the caret positions.
Reviewed internally by Nima Ghanavatian.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(WebKit):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- WebKitSupport/InputHandler.h:
(Platform):
(InputHandler):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):
- 1:17 PM Changeset in webkit [125440] by
-
- 4 edits in trunk/Source/WebCore
Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well
https://bugs.webkit.org/show_bug.cgi?id=93864
Reviewed by Eric Carlson.
Add the WEB_AUDIO to the Conditional attribute in MediaElementAudioSourceNode
IDL file and the ENABLE(WEB_AUDIO) compilation guard to the header files for both
MediaStreamAudioSourceNode and MediaElementAudioSourceNode.
No new tests - no new functionality.
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.idl:
- 1:12 PM Changeset in webkit [125439] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Clean up exception handling
https://bugs.webkit.org/show_bug.cgi?id=93880
Reviewed by Kenneth Rohde Christiansen.
The JSC C API uses a JSValueRef* exception parameter to indicate to the
caller that an exception was thrown. Naturally the caller must store
that ValueRef on the stack in order to get seen and marked by the
garbage collector, otherwise the callee would have to use
JSValueProtect on it.
This patch fixes one such case where in fact the exception pointer was passed as zero to the
callee and thus ignored. The patch also removes an unused exception parameter.
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
- bridge/qt/qt_runtime.h:
- 1:05 PM Changeset in webkit [125438] by
-
- 5 edits in trunk
Web Inspector: remove commitEditing from the text editor delegate.
https://bugs.webkit.org/show_bug.cgi?id=93858
Reviewed by Vsevolod Vlasov.
This should be up to the source frame.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._registerShortcuts):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.SourceFrame.prototype._handleKeyDown):
(WebInspector.SourceFrame.prototype._commitEditing):
- inspector/front-end/TextEditor.js:
- 12:49 PM Changeset in webkit [125437] by
-
- 16 edits14 adds24 deletes in trunk
Unreviewed, rolling out r125430.
http://trac.webkit.org/changeset/125430
https://bugs.webkit.org/show_bug.cgi?id=93881
Caused css2.1/t1604-c541-word-sp-00-b-a.html to regress on Mac
builds (Requested by mwenge on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
Source/WebCore:
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
LayoutTests:
- css2.1/20110323/c541-word-sp-001-expected.html: Removed.
- css2.1/20110323/c541-word-sp-001.htm: Removed.
- css2.1/20110323/word-spacing-characters-002-expected.html: Removed.
- css2.1/20110323/word-spacing-characters-002.htm: Removed.
- css2.1/20110323/word-spacing-characters-003-expected.html: Removed.
- css2.1/20110323/word-spacing-characters-003.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-001-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-001.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-002-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-002.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-003-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-003.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-004-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-004.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-005-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-005.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-006-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-006.htm: Removed.
- css2.1/t1604-c541-word-sp-01-b-a.html: Added.
- fast/css/word-spacing-characters-complex-text-expected.html: Removed.
- fast/css/word-spacing-characters-complex-text.html: Removed.
- fast/css/word-spacing-characters-expected.html: Removed.
- fast/css/word-spacing-characters.html: Removed.
- fast/css/word-spacing-linebreak-expected.html: Removed.
- fast/css/word-spacing-linebreak.html: Removed.
- platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-linux/fast/css/word-space-extra-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/chromium-win/fast/css/word-space-extra-expected.txt:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/qt/TestExpectations:
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/win/Skipped:
- 12:30 PM Changeset in webkit [125436] by
-
- 2 edits in trunk/Source/WebCore
FrameLoader::receivedMainResourceError doesn't handle GET cancellations well.
https://bugs.webkit.org/show_bug.cgi?id=93850
Patch by Mike West <mkwst@chromium.org> on 2012-08-13
Reviewed by Adam Barth.
'FrameLoader::cancel' should reset the loader's state, and it mostly
does. In the case of a GET form submission, however, the submitted form
URL that's stored doesn't match the URL that's requested (query string).
This leads to the loader getting a bit confused about what's going on,
and not clearing the stored form submission URL.
This patch moves to storing the form submission's actual request URL
as opposed to the form action URL.
None of the current tests should break, and when issue 93777 lands, it
won't be broken either.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
Switched to using 'FormSubmission::requestURL', as that matches the
URL that's actually requested during a form submission via GET.
- 12:25 PM Changeset in webkit [125435] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Hardware accelerated scrolling of <select> content
https://bugs.webkit.org/show_bug.cgi?id=93856
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Matthew Staikos.
- Resources/blackberry/selectControlBlackBerry.css: add -webkit-overflow-scrolling: touch (EOM).
(.select-area):
- 12:24 PM Changeset in webkit [125434] by
-
- 6 edits in trunk/Source
[BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
https://bugs.webkit.org/show_bug.cgi?id=93848
PR #190986
Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Patch adds a WebKit thread setScrollPosition-like API to InRegionScroller.
It fixes a mismatch we had of setting a layer's scroll positing directly via
::setScrollPosition on the UI thread, but dispatching a coalesceable
scrollBy(delta) message to WebKit thread.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScroller::setScrollPositionCompositingThread):
Changed the API name to match other thread specific methods naming.
(WebKit):
(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
Added a setScrollPosition-like method to InRegionScroller public API. Used
together with its UI-thread counterpart, it can fix some rounding
errors we have due to mixing ::setScrollPosition and ::scrollBy methods.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
Method renamed. See reasons above.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
Calls fowards the call to ::setLayerScrollPosition (below).
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
Sets the scroll position of a given RenderLayer.
- Api/InRegionScroller.h:
(InRegionScroller):
- Api/InRegionScroller_p.h:
(WebCore):
(InRegionScrollerPrivate):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
Cache the RenderLayer object associated to a given scrollable area
instead of its LayerCompositingThread. This way we can use it for
scrolling from both Compositing/UI and WebKit threads.
- 12:24 PM Changeset in webkit [125433] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Assertion in RenderObject::offsetFromAncestorContainer
https://bugs.webkit.org/show_bug.cgi?id=93845
Reviewed by Kenneth Rohde Christiansen.
Do not attempt to clip using layers that are not containers of the renderer.
- page/GestureTapHighlighter.cpp:
- 12:09 PM Changeset in webkit [125432] by
-
- 5 edits in trunk
[Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=93244
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Similar to Skia's and Qt's ImageBuffer implementation we need to make sure that buffers
for images are copied when the destination canvas is identical to the
image buffer's context. This happens mostly in JS calls to canvas' drawImage method.
For now fixing the drawImage case, drawPattern case is handled in bug 93854.
No new tests, covered by canvas/philip/tests/2d.drawImage.self.2.html
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::draw): Making sure buffer is copied when source and destination contexts are identical.
LayoutTests:
Unskipping canvas/philip/tests/2d.drawImage.self.2.html for GTK and EFL now that it's working.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- 12:07 PM Changeset in webkit [125431] by
-
- 2 edits in trunk/LayoutTests
[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Gardening. Unskip now passing test.
- platform/qt/Skipped:
- 11:55 AM Changeset in webkit [125430] by
-
- 16 edits24 adds14 deletes in trunk
CSS 2.1 failure: Word-spacing affects each space and non-breaking space
https://bugs.webkit.org/show_bug.cgi?id=89826
Reviewed by Eric Seidel.
Source/WebCore:
Add word spacing to consecutive spaces in a run per http://www.w3.org/TR/CSS21/text.html#spacing-props.
Test: fast/css/word-spacing-characters.html
fast/css/word-spacing-characters-complex-text.html
fast/css/word-spacing-characters-linebreak.html
css2.1/20110323/word-spacing-characters-002.htm
css2.1/20110323/word-spacing-characters-003.htm
css2.1/20110323/word-spacing-remove-space-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm
css2.1/20110323/c541-word-sp-001.htm
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): All spaces (ordinary space or ) get word-spacing added, even
if they are consecutive.
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use
m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
find it specified anywhere.
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): ditto, but for the complext text case on Mac.
The change to this file is speculative, I don't have a Mac build.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html
- rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache): This code-path is not covered by any existing layout tests!
I've tried to come up with a test to hit it but have failed.
LayoutTests:
- css2.1/20110323/c541-word-sp-001-expected.html: Added.
- css2.1/20110323/c541-word-sp-001.htm: Added. Replaces t1604-c541-word-sp-01-b-a.html below.
- css2.1/20110323/word-spacing-characters-002-expected.html: Added.
- css2.1/20110323/word-spacing-characters-002.htm: Added.
- css2.1/20110323/word-spacing-characters-003-expected.html: Added.
- css2.1/20110323/word-spacing-characters-003.htm: Added. These passed already.
- css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-001.htm: Added.
- css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-002.htm: Added.
- css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-003.htm: Added.
- css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-004.htm: Added.
- css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-005.htm: Added.
- css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-006.htm: Added. These 6 tests are fixed by this patch.
- css2.1/t1604-c541-word-sp-01-b-a.html: Removed. Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is now invalid and has been replaced by c541-word-sp-001.htm above.
- fast/css/word-spacing-characters-complex-text-expected.html: Added.
- fast/css/word-spacing-characters-complex-text.html: Added. This is a complex text version of word-spacing-characters-001.htm
- fast/css/word-spacing-characters-expected.html: Added.
- fast/css/word-spacing-characters.html: Added. The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case. This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced with word-spacing-characters-001.htm from the css test suite when https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
- fast/css/word-spacing-linebreak-expected.html: Added.
- fast/css/word-spacing-linebreak.html: Added.
- platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-linux/fast/css/word-space-extra-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/chromium-win/fast/css/word-space-extra-expected.txt:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/qt/TestExpectations:
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- 11:45 AM Changeset in webkit [125429] by
-
- 5 edits in trunk
Remove webkitMediaSourceURL from HTMLMediaElement.idl
https://bugs.webkit.org/show_bug.cgi?id=93619
Reviewed by Adam Barth.
The webkitMediaSourceURL attribute is no longer needed now that we use
createObjectURL() to generate a media source URL.
Source/WebCore:
Test: update http/test/media/media-source/media-source.js
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
LayoutTests:
- http/tests/media/media-source/media-source.js:
(MediaSourceTest.setSrcToMediaSourceTestURL):
- 10:53 AM Changeset in webkit [125428] by
-
- 8 edits in trunk/Source
[Qt] Port meta method/signal/slot handling in run-time bridge to use JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93476
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Based on patch by No'am Rosenthal and lots of good suggestions by Caio Marcelo.
Ported the code that mapped invokable methods (and signals/slots) as
well as the code that provides the connect() and disconnect() functions
over to use the JSC C API. In the process one behavioural change was
implemented: Previously meta methods were actually function objects
that through Function.prototype allowed calling via
object.method.call(object). Through the use of plain JS objects that is
not possible anymore.
If we tried to continue to use function objects (JSObjectMakeFunction)
then we would loose the ability to store the private pointer. An
alternative approach would be to use a regular object and install the
Function prototype (Function.prototype), but unfortunately we cannot do
that without loosing the common prototype for signals and slots.
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::newRuntimeObject):
- bridge/qt/qt_instance.h:
(Bindings):
(QtInstance):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::connect):
(JSC::Bindings::QtRuntimeMethod::disconnect):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
(Bindings):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::name):
(QtRuntimeMethod):
(QtConnectionObject):
Source/WebKit/qt:
Changed semantics of some test expectations. Similarly to r125032 when generating
error exceptions for connect/disconnect, we cannot generate explicit type error
exceptions but only generic errors. Another change is that the meta-method wrapper
doesn't support the call() through Function.prototype anymore. See WebCore changelog
for details.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::connectAndDisconnect):
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods):
- 10:42 AM Changeset in webkit [125427] by
-
- 4 edits in trunk/Source
[Chromium] Fix nits in the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93817
Reviewed by Adam Barth.
This patch fixes a few pending nits from 93111.
Source/WebCore:
Tests: existing WebKit unit test WebFrameTest.FindInPageMatchRects
- dom/Range.cpp:
(WebCore::Range::transformFriendlyBoundingBox): add call to updateLayoutIgnorePendingStylesheets.
Source/WebKit/chromium:
- src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument.
(WebKit::toNormalizedRect):
(WebKit::findInPageRectFromAbsoluteRect):
- 10:35 AM EFLWebKit edited by
- (diff)
- 9:49 AM Changeset in webkit [125426] by
-
- 9 edits in trunk
Web Inspector: get rid of beforeTextChanged
https://bugs.webkit.org/show_bug.cgi?id=93851
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Merged beforeTextChanged and afterTextChanged into a single
onTextChanged event.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.editRange):
(WebInspector.CodeMirrorTextEditor.prototype._onChange):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._enterInternalTextChangeMode):
(WebInspector.DefaultTextEditor.prototype._exitInternalTextChangeMode):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.onTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.onTextChanged):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditorDelegate.prototype.onTextChanged):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.onTextChanged):
LayoutTests:
- http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):
- 9:47 AM Changeset in webkit [125425] by
-
- 2 edits in trunk/Source/WebCore
[css] Remove "default" switch case from CSS primitive value mappings
https://bugs.webkit.org/show_bug.cgi?id=93781
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-13
Reviewed by Alexey Proskuryakov.
Removing the "default" switch case allows compile-time early warning check,
specially useful for newly added or removed enumeration values.
- css/CSSPrimitiveValueMappings.h:
- 9:45 AM Changeset in webkit [125424] by
-
- 5 edits in trunk/Source/WebCore
Cap the number of SourceBuffers that may be added to a MediaSource.
https://bugs.webkit.org/show_bug.cgi?id=93406
Reviewed by Eric Carlson.
Make sure that no more SourceBuffer objects are added to a MediaSource
than can fit into the sourceBuffers SourceBufferList (internally stored
as a Vector). Also, make sure that new SourceBuffers are added with a
unique id even if the variable we are using to generate id wraps around.
No new tests. It would not be realistic to add so many SourceBuffers to
test the id variable wrapping. Existing tests should not be affected.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::addSourceBuffer): Obtain a unique id before creating
a new SourceBuffer.
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::generateUniqueId): Search for and generate a
unique id.
(WebCore):
(WebCore::SourceBufferList::contains): Check if a SourceBuffer with a
given id already exists in this SourceBufferList.
- Modules/mediasource/SourceBufferList.h:
(SourceBufferList):
- 9:41 AM Changeset in webkit [125423] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Update TestExpectations to make bot green
https://bugs.webkit.org/show_bug.cgi?id=93852
Unreviewed EFL gardening. Update wk2-efl TestExpectations
to make the bot green.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- 9:40 AM Changeset in webkit [125422] by
-
- 5 edits in trunk
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841
Reviewed by Dimitri Glazkov.
APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 9:36 AM Changeset in webkit [125421] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP][WK2] Missing LocalTerminationDisabler in WebCookieManager::setCookiePersistentStorage()
https://bugs.webkit.org/show_bug.cgi?id=93837
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Carlos Garcia Campos.
Add missing WebCore::LocalTerminationDisabler in
WebCookieManager::setCookiePersistentStorage() to
temporarily disable process termination.
- WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::setCookiePersistentStorage):
- 8:50 AM Changeset in webkit [125420] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 7:54 AM Changeset in webkit [125419] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: when status bar is too narrow, cut panel status bar, not main status bar items
https://bugs.webkit.org/show_bug.cgi?id=93814
Reviewed by Pavel Feldman.
- set shrink factor of bottom-status-bar-container to 1;
- set bottom-status-bar-container's width to 0 to workaround for flex-basis being ignored;
- inspector/front-end/inspector.css:
(#bottom-status-bar-container):
- 7:19 AM Changeset in webkit [125418] by
-
- 2 edits in trunk/Tools
[WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
https://bugs.webkit.org/show_bug.cgi?id=93825
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-13
Reviewed by Antonio Gomes.
Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadForResource):
- 6:43 AM Changeset in webkit [125417] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating test expectation for
canvas/philip/tests/2d.drawImage.self.2.html to note that
bug #93244 tracks the regression.
- platform/gtk/TestExpectations:
- 6:31 AM Changeset in webkit [125416] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a failing test.
- platform/qt/Skipped:
- platform/qt/TestExpectations:
- 6:24 AM Changeset in webkit [125415] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add memory instrumentation for Attribute
https://bugs.webkit.org/show_bug.cgi?id=93827
Reviewed by Pavel Feldman.
Attribute's name and value footprint is counted as part of the DOM
component.
- dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
(Attribute):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
- 6:19 AM Changeset in webkit [125414] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
- DEPS:
- 5:58 AM Changeset in webkit [125413] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Polish search/replace toolbar buttons style.
https://bugs.webkit.org/show_bug.cgi?id=93826
Reviewed by Pavel Feldman.
- inspector/front-end/inspector.css:
(.toolbar-search button):
- 5:35 AM Changeset in webkit [125412] by
-
- 4 edits1 add in trunk/LayoutTests
[EFL] fast/box-sizing/box-sizing.html needs new baseline after r124347
https://bugs.webkit.org/show_bug.cgi?id=93823
Unreviewed EFL gardening.
Provide new baseline for fast/box-sizing/box-sizing.html,
needed after r124347.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/fast/box-sizing/box-sizing-expected.png:
- platform/efl/fast/box-sizing/box-sizing-expected.txt: Added.
- 5:07 AM Changeset in webkit [125411] by
-
- 6 edits1 add in trunk
[Qt] Add gprof.prf to build WebKit with gprof enabled
https://bugs.webkit.org/show_bug.cgi?id=90283
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.
Source/WebCore:
No behavior change, so no new tests.
- WebCore.pri:
-ffunction-sections conflicts with -pg option, so don't use
-ffunction-sections option when gprof is enabled.
Source/WebKit/qt:
- tests/MIMESniffing/MIMESniffing.pro:
Don't build MIMESniffing.cpp because MIMESniffing test links
WebKitQt statically when gprof is enabled.
Tools:
- qmake/mkspecs/features/functions.prf:
gprof does not support profiling a shared library.
To profile WebKit, applications must link QtWebKit statically.
- qmake/mkspecs/features/gprof.prf: Added.
Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.
- 5:00 AM Changeset in webkit [125410] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r125408, removing another usage of SVG_FEATURES.
- GNUmakefile.am:
- 4:54 AM Changeset in webkit [125409] by
-
- 3 edits in trunk/LayoutTests
[EFL][WK2] Skip inspector tests that hit assertion in WebCore::SuspendableTimer::resume()
https://bugs.webkit.org/show_bug.cgi?id=93815
Unreviewed EFL gardening.
Update TestExpectations for several flaky Web Inspector
test cases.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:42 AM Changeset in webkit [125408] by
-
- 4 edits in trunk
[Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=90693
Reviewed by Philippe Normand.
.:
Remove exportation of SVG_FLAGS and HTML_FLAGS as Automake conditionals
as they are not required anymore.
- configure.ac:
Source/WebCore:
Remove SVG_FEATURES and HTML_FEATURES variables. They can be replaced by the
FEATURE_DEFINES variable wherever they are used.
No new tests - no new functionality.
- GNUmakefile.am:
- 4:38 AM WebKitGTK/1.8.x edited by
- (diff)
- 3:35 AM Changeset in webkit [125407] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-08-13
Reviewed by Xan Lopez.
Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.
- 3:16 AM Changeset in webkit [125406] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 3:15 AM Changeset in webkit [125405] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Wrong TestExpectations for 2 webintents tests
https://bugs.webkit.org/show_bug.cgi?id=93811
Unreviewed EFL gardening.
Update expected state for the following webintents tests
to make the tree green:
webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- 3:01 AM Changeset in webkit [125404] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing/crashing tests.
- platform/qt/Skipped:
- platform/qt/TestExpectations:
- 2:42 AM Changeset in webkit [125403] by
-
- 4 edits in trunk/Source
[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
https://bugs.webkit.org/show_bug.cgi?id=93804
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Use the 'length' parameter to insert a substring of the full
string passed to this method from AtkEditableText interface.
- accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextInsertText): Don't ignore 'length'.
Source/WebKit/gtk:
Update unit tests to also check inserting a partial string.
- tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Update test.
- 2:33 AM Changeset in webkit [125402] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Feature Request - Adding mouse gesture for editing attribute values in elements/css panel
https://bugs.webkit.org/show_bug.cgi?id=93581
Patch by Sam D <dsam2912@gmail.com> on 2012-08-13
Reviewed by Alexander Pavlov.
Added functionality to modify valuesAdding support for updating number values in attributes in element
panel/ css panel using mouse gestures as well.
No new tests.
- inspector/front-end/StylesSidebarPane.js:
handling mousewheel event
- inspector/front-end/TextPrompt.js:
adding mouse event listener
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onMouseWheel):
- inspector/front-end/UIUtils.js:
handling mouse event gesture and updating number based on mouse wheel
scroll direction as well.
(WebInspector._valueModificationDirection):
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):
- 2:29 AM Changeset in webkit [125401] by
-
- 2 edits in trunk/Tools
[TestNetscapePlugin][X11] Additional key up event handler routine is required
https://bugs.webkit.org/show_bug.cgi?id=91357
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-13
Reviewed by Eric Seidel.
Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
has-focus.html on X11 architecture. The test can not be done without this patch.
All other ports implemented it already.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11): Modified key up event handler for X11
- 2:28 AM Changeset in webkit [125400] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header file.
- 2:06 AM Changeset in webkit [125399] by
-
- 16 edits in trunk
Web Inspector: [Protocol] Force elements pseudo state via a separate InspectorCSSAgent method
https://bugs.webkit.org/show_bug.cgi?id=93721
Reviewed by Pavel Feldman.
Source/WebCore:
Introduce InspectorCSSAgent::forcePseudoState() to modify the element's forced pseudo state.
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.forcePseudoState):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
- inspector/front-end/MetricsSidebarPane.js:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
LayoutTests:
- http/tests/inspector/modify-cross-domain-rule.html:
- inspector/styles/get-set-stylesheet-text.html:
- inspector/styles/styles-formatting.html:
- inspector/styles/styles-new-API.html:
- inspector/styles/styles-new-API-expected.txt:
- 1:26 AM Changeset in webkit [125398] by
-
- 3 edits1 add1 delete in trunk
[EFL][WK2] Replace Skipped list by TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=93796
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Tools:
Enable cascaded TestExpectations for EFL port so
that we can use TestExpectations in WK2-EFL.
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._search_paths):
(EflPort):
(EflPort.expectations_files):
LayoutTests:
Replace efl-wk2 Skipped file by TestExpectations now
that we support cascaded TestExpectations in EFL
port.
- platform/efl-wk2/Skipped: Removed.
- platform/efl-wk2/TestExpectations: Added.
- 1:22 AM Changeset in webkit [125397] by
-
- 5 edits2 adds in trunk
Cannot select the AuthorShadowDOM inner element of an img element
https://bugs.webkit.org/show_bug.cgi?id=91591
Reviewed by Dimitri Glazkov.
Source/WebCore:
Since HTMLImageElement::canStartSelection always returns false, we cannot start selection
from any children (including shadow dom) of an img element. When the img element has a shadow dom,
we should be able to start selection.
Test: fast/dom/shadow/select-image-with-shadow.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::canStartSelection):
(WebCore):
- html/HTMLImageElement.h:
(HTMLImageElement):
- html/shadow/ImageInnerElement.h:
(WebCore::ImageInnerElement::canStartSelection): Since ImageInnerElement is really an image,
this should return always false to obey the exising behavior.
(ImageInnerElement):
LayoutTests:
- fast/dom/shadow/select-image-with-shadow-expected.txt: Added.
- fast/dom/shadow/select-image-with-shadow.html: Added.
- 1:11 AM Changeset in webkit [125396] by
-
- 2 edits in trunk/Tools
REGRESSION(r125153): It broke the 'Unexpected no expected results' case
https://bugs.webkit.org/show_bug.cgi?id=93789
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-08-13
Reviewed by Csaba Osztrogonác.
Fix the regex, so the text won't be a capturing group.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests._parseNewRunWebKitTestsOutput):
- 12:52 AM Changeset in webkit [125395] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Add expectations for flaky tests.
- platform/chromium/TestExpectations:
- 12:19 AM Changeset in webkit [125394] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93387
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-13
Reviewed by Pavel Feldman.
Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
of "column" to make the behavior back to the time as JSC cannot provide "column" info.
Refer to https://bugs.webkit.org/show_bug.cgi?id=93473.
No new test case for this bug.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
Aug 12, 2012:
- 11:55 PM Changeset in webkit [125393] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r125392.
http://trac.webkit.org/changeset/125392
https://bugs.webkit.org/show_bug.cgi?id=93797
Simple rebaseline won't work. Need further investigation.
(Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-12
- inspector/console/console-format-collections-expected.txt:
- 11:48 PM Changeset in webkit [125392] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: rebaselined inspector/console/console-format-collections.html after r125284.
https://bugs.webkit.org/show_bug.cgi?id=93748
- inspector/console/console-format-collections-expected.txt:
- 11:21 PM Changeset in webkit [125391] by
-
- 21 edits in trunk/Source
Support creating File object from FileSystem URL for files in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=93706
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebBlobData.h:
- chromium/public/WebHTTPBody.h:
(WebHTTPBody):
Source/WebCore:
Current File code assumes the existence of local file (i.e. requires a platform local file path) but for FileSystem
files it may not be always the case. For example some implementation may want to use in-memory filesystem to realize
sandboxed filesystem, or others may have the filesystem in remote servers.
This patch adds basic support for making File object constructible not only from a file path but from a FileSystem URL.
Since File can be appended to FormData or included in another Blob this patch also extends BlobData and FormData to support URL.
FileChooser and Drag-and-drop changes are not included in this patch.
No new tests: will add tests when we implement the platform side changes to wire this change.
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile):
- Modules/filesystem/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::createFile):
- fileapi/Blob.cpp:
(WebCore::Blob::sliceInternal):
- fileapi/File.cpp:
(WebCore::createBlobDataForFileSystemURL): Added.
(WebCore::File::File):
- fileapi/File.h:
(WebCore::File::createForFileSystemFile):
(WebCore::File::fileSystemURL): Added.
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
- platform/chromium/support/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendURL): Added.
(WebKit::WebHTTPBody::appendURLRange): Added.
(WebKit::WebHTTPBody::appendBlob):
- platform/network/BlobData.cpp:
(WebCore::BlobData::appendURL):
- platform/network/BlobData.h:
(BlobDataItem):
(WebCore::BlobDataItem::BlobDataItem):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerBlobURL):
- platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendURL): Added.
(WebCore::FormData::appendURLRange): Added.
(WebCore::FormData::appendKeyValuePairItems):
- platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(FormDataElement):
(WebCore::operator==):
Source/WebKit/chromium:
- src/WebBlobData.cpp:
(WebKit::WebBlobData::itemAt):
- 10:21 PM Changeset in webkit [125390] by
-
- 2 edits in trunk/Tools
Unreviewed, added a proxy address to contributors_who_are_not_committers.
- Scripts/webkitpy/common/config/committers.py:
- 9:36 PM Changeset in webkit [125389] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/11442485> off-screen or inactive pages can change the mouse pointer
Reviewed by Adele Peterson.
- page/EventHandler.cpp:
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Added a check that the page is
on-screen and active before dispatching the fake mouse event.
- 9:35 PM Changeset in webkit [125388] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid layering violation
https://bugs.webkit.org/show_bug.cgi?id=93588
Patch by Jonathan Dong <Jonathan Dong> on 2012-08-12
Reviewed by Antonio Gomes.
Removed helper function MediaPlayerPrivate::userAgent() which has
introduced abstraction layering violation and replaced with
MediaPlayer::userAgent().
No new tests since there's no functional change.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
- 9:23 PM Changeset in webkit [125387] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Update TestExpectations so it matches the recent results.
- platform/chromium/TestExpectations:
- 9:16 PM Changeset in webkit [125386] by
-
- 5 edits in trunk/Source/WebCore
Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90535
Reviewed by Eric Seidel.
No new tests as this has no functional changes.
- bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::getBlob):
- fileapi/WebKitBlobBuilder.h:
(WebKitBlobBuilder):
- 8:55 PM Changeset in webkit [125385] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Fix Chromium's Android build.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find): Needs parentheses for a function call.
- 5:14 PM Changeset in webkit [125384] by
-
- 3 edits in trunk/Source/WebCore
Remove unnecessary null checks from pseudoStyleForElement and adjustRenderStyle
https://bugs.webkit.org/show_bug.cgi?id=93730
Reviewed by Tony Chang.
All the callers of both methods make sure to pass in a non-null parentStyle.
No change in behavior.
- css/StyleResolver.cpp:
- css/StyleResolver.h:
- 4:13 PM Changeset in webkit [125383] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new tests without expected results.
- platform/qt/Skipped:
- 4:01 PM Changeset in webkit [125382] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Tap highlight flashes checkerboard after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=93601
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.
Since the tap highlight is usually rather small, we can reimplement
GraphicsLayerClient::contentsVisible() to always return true in order
to keep all AC layer tiles cached all the time.
PR 189895
- WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
(WebKit):
- WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
- 3:59 PM Changeset in webkit [125381] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Tap highlight sometimes doesn't disappear
https://bugs.webkit.org/show_bug.cgi?id=93711
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.
The WebOverlayOverride implementation just changes properties of a
LayerCompositingThread directly, which means the changes will
immediately be overwritten on the next commit. Therefore, when the tap
highlight implementation adds a fade out animation, that animation will
instantly be removed again if a commit happens for any reason.
The reason is I totally botched the implementation of
WebOverlayOverride, it's not wrapping WebCore::LayerOverride at all,
instead for some reason it's manipulating the LayerCompositingThread
directly.
Fixed by actually mapping WebOverlayOverride calls to the corresponding
WebCore::LayerOverride method, and scheduling a compositing run to make
the change visible and kick off animations.
Reviewed internally by Sean Wang.
PR 188453
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivate::override):
- Api/WebOverlayOverride.cpp:
(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::setPosition):
(BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayOverride::setSize):
(BlackBerry::WebKit::WebOverlayOverride::setTransform):
(BlackBerry::WebKit::WebOverlayOverride::setOpacity):
(BlackBerry::WebKit::WebOverlayOverride::addAnimation):
(BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
- Api/WebOverlayOverride.h:
- Api/WebOverlay_p.h:
(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):
- 11:14 AM Changeset in webkit [125380] by
-
- 4 edits2 adds in trunk
table cell.cellIndex should return -1 if there is no parent table
https://bugs.webkit.org/show_bug.cgi?id=93738
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-08-12
Reviewed by Eric Seidel.
Source/WebCore:
According to the HTML5 spec the cellIndex of a table cell(td/th) whose parent is not a table row
must be -1. Currently we are returning zero. This patch fixes this behavior.
Test: fast/table/cellIndex-of-cell-with-different-parents.html
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::cellIndex):
If the parent of the cell is not a table row, -1 is returned. Otherwise a value greater
than or equal to zero is return.
- rendering/RenderTableCell.h:
(RenderTableCell):
Removed dead code and made minor webkit style related fix.
LayoutTests:
- fast/table/cellIndex-of-cell-with-different-parents-expected.txt: Added.
- fast/table/cellIndex-of-cell-with-different-parents.html: Added.
- 11:05 AM Changeset in webkit [125379] by
-
- 9 edits4 adds in trunk/Source
[Chromium] Implement the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93111
Reviewed by Adam Barth.
Source/WebCore:
Introduce the find-in-page coordinate system. This system tries to solve
the unintuitive tickmark results presented in pages with multiple frames
and scrolled contents where the find results might not be in the visible
area of a frame, which might lead to tickmarks below the container frame.
To achieve this, this coordinate system goes up the render tree
normalizing the coordinates by the actual contents size of its container.
This leads to tickmarks scaled to the visible size of their frame
independently of its scroll. This coordinate system supports also CSS
scroll:overflow, transforms and the different positions.
Also add an auxiliary method to Range in order to provide a transform
friendly way to retrieve the absolute coordinates of the enclosing
bounding box without the adjustment operations that the existing
enclosingRect method does.
Tested by WebFrameTest WebKit unit test.
- dom/Range.cpp:
(WebCore::Range::transformFriendlyBoundingBox): add a transform-friendly equivalent of boundingBox.
(WebCore):
- dom/Range.h: move boundingBox to the group of non-transform-friendly methods.
(Range):
Source/WebKit/chromium:
Implement the funcionality of the find-in-page match rects API in WebFrame.
These methods keep a cache of the match rects in a special coordinate system
(find-in-page coordinates) and update them on size changes. They also allow
to recover the match closest to a given point, therefore enabling to move
to find matches when tapping on their corresponding tickmarks.
- WebKit.gyp: add FindInPageCoordinates.h / cpp.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl.
- src/FindInPageCoordinates.cpp: Added.
(WebKit):
(WebKit::toNormalizedRect): auxiliary internal function.
(WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function.
(WebKit::findInPageRectFromRange): convenience conversion function for Ranges.
- src/FindInPageCoordinates.h: Added.
(WebCore):
(WebKit):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor.
(WebKit):
(WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port.
(WebKit::WebFrameImpl::stopFinding): clear matches cache.
(WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache.
(WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::resetMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version.
(WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache.
(WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree.
(WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required.
(WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates.
(WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates.
(WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames.
(WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates.
(WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame.
(WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache.
(WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables.
(WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes.
- src/WebFrameImpl.h:
(WebCore):
(WebFrameImpl):
(WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const.
(WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing.
(FindMatch): cache structure for find matches.
- tests/WebFrameTest.cpp: new test case for find-in-page match rects.
- tests/data/find_in_page.html: Added. Test case layout.
- tests/data/find_in_page_frame.html: Added. Test case layout.
- 10:40 AM Changeset in webkit [125378] by
-
- 2 edits in trunk/Source/WebCore
Stop Y-flipping CROS/ARM video textures
https://bugs.webkit.org/show_bug.cgi?id=93769
Reviewed by Eric Seidel.
No new tests; there's no cros/arm bot yet, sadly.
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads): drop the single-platform Y-flipping in prep for the platform doing the flip natively.
- 9:52 AM Changeset in webkit [125377] by
-
- 16 edits in trunk
[Qt] Make it possible to build without QtTest/QtPrintSupport
https://bugs.webkit.org/show_bug.cgi?id=93492
Patch by Loïc Yhuel <loic.yhuel@softathome.com> on 2012-08-12
Reviewed by Tor Arne Vestbø.
.:
- Source/QtWebKit.pro: Disable tests if no testlib
Source/WebKit:
- WebKit1.pri: Optional printsupport
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebFrame::print): Does nothing if no printsupport
- Api/qwebview.cpp:
(QWebView::print): Does nothing if no printsupport
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore):
(WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
- QtTestBrowser/QtTestBrowser.pro: Optional printsupport
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome): No print menu if no printsupport
(LauncherWindow::print): Does nothing if no printsupport
- QtTestBrowser/launcherwindow.h:
- Tools.pro: Disable DRT/WTR if QtTest not present
- qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
- qmake/mkspecs/features/features.prf: Qt module availability tests
- 8:57 AM Changeset in webkit [125376] by
-
- 6 edits2 adds in trunk
CSSRegions: Crash when using style in region for removed element.
https://bugs.webkit.org/show_bug.cgi?id=93276
Reviewed by Abhishek Arya.
Source/WebCore:
When a RenderInline object from within a render flow thread is split, the cloned
hierarchy built during the split process does not have the inRenderFlowThread bit
set properly. If the cloned hierarchy is flowed into a region with region style rules,
we compute the style in region also for objects that do not have inRenderFlowThread bit
set and we store the computed style in region for caching purposes. But we only remove
an object style in region information if that object has the inRenderFlowThread bit set.
Under these circumstances, it is possible to remove a object with cached style in region
and without inRenderFlowThread bit set from the render tree and leave the associated cached
information un-removed. Such information will be accesses during the next paint phase of
the region, thus resulting a crash.
The fix is to modify RenderBlock::clone() and RenderInline::clone() functions to also copy the inRenderFlowThread bit
from the source into the clone, therefore the cloned hierarchies will have the inRenderFlowThread
bit set properly.
Test: fast/regions/removed-element-style-in-region-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clone): Replace former static RenderInline::cloneInline with member RenderInline::clone.
(WebCore::RenderInline::splitInlines):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setObjectStyleInRegion):
Added an assert to make sure that when we are computing style in region, we are doing for objects
with inRenderFlowThread set. Also, bail out early in this case to prevent further crashes.
LayoutTests:
Added test reproducing the problem.
- fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
- fast/regions/removed-element-style-in-region-crash.html: Added.
- 8:46 AM Changeset in webkit [125375] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Skip webintents/web-intents-obj-constructor.html test
https://bugs.webkit.org/show_bug.cgi?id=93778
Unreviewed EFL gardening.
Skip webintents/web-intents-obj-constructor.html for
WebKit2 EFL until WTR can print information about the
MessagePorts in a Web Intent (Bug 89072).
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-12
- platform/efl-wk2/Skipped:
- 5:12 AM Changeset in webkit [125374] by
-
- 3 edits in trunk/Source/WebCore
Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.
https://bugs.webkit.org/show_bug.cgi?id=90505
Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-12
Reviewed by Eric Seidel.
Following 4 methods are protected.
size_t frameCount();
NativeImagePtr frameAtIndex(size_t);
bool frameIsCompleteAtIndex(size_t);
float frameDurationAtIndex(size_t);
So, 2 methds also should be protected because the frame info is only specific of
BitmapImage.
bool frameHasAlphaAtIndex(size_t);
ImageOrientation frameOrientationAtIndex(size_t);
On the other hand, this patch amended GraphicsContext3DCG.
- static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0)
+ image->currentFrameHasAlpha()
This patch does not affect PNG, JPEG, BMP, and WEBP because those images
have only 0 indexed frame.
Thus, GIF, and ICO are affected. However, an above query to get Alpha
is for the image that is created by image->nativeImageForCurrentFrame(), so it
is proper to use image->currentFrameHasAlpha() instead of
image->frameHasAlphaAtIndex(0).
No new tests, because it is hard to test. We need an animated GIF that
one frame has alpha and another frame does not have alpha. However, I
cannot find the animated GIF file that suffices the requirement.
- platform/graphics/BitmapImage.h:
(BitmapImage):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
- 4:47 AM Changeset in webkit [125373] by
-
- 3 edits in trunk/Source/JavaScriptCore
Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042
Reviewed by Eric Seidel.
Include headers without which CallFrame.h does not build, and
fix gcc warning about comparing unsigned int with 0.
- dfg/DFGDriver.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::isOpcode):
- 4:38 AM Changeset in webkit [125372] by
-
- 2 edits in trunk/Tools
master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
https://bugs.webkit.org/show_bug.cgi?id=90161
Reviewed by Eric Seidel.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 4:38 AM Changeset in webkit [125371] by
-
- 4 edits2 deletes in trunk
webkit fails IETC namespaces/prefix-007.xml
https://bugs.webkit.org/show_bug.cgi?id=86137
Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-12
Reviewed by Eric Seidel.
Source/WebCore:
If a namespace prefix or default namespace is declared more than once
only the last declaration shall be used.
parseAddNamespace doesn't check return value of WTF::HashMap<>::add.
If the return value's isNewEntry is true, the new entry is added with
the specified value. However, if isNewEntry is false, it is required
to update the store value.
No new tests. ietestcenter/css3/namespaces/prefix-007.xml and
ietestcenter/css3/namespaces/prefix-010.xml covers this change.
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAddNamespace):
Modified to check m_namespaces.add's return value.
If the result says not a new entry, updated the value stored in
m_namespaces by using iterator in the result.
LayoutTests:
- platform/chromium/TestExpectations:
Enabled the layout tests, ietestcenter/css3/namespaces/prefix-007.xml
and ietestcenter/css3/namespaces/prefix-010.xml.
- platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Removed.
- platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Removed.
Removed old expectations.
- 4:29 AM Changeset in webkit [125370] by
-
- 4 edits in trunk/Source/WebKit2
Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90701
Patch by Nuno Lopes <nlopes@apple.com> on 2012-08-12
Reviewed by Eric Seidel.
- Shared/CommandLine.h:
(CommandLine):
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):
- WebProcess/Notifications/NotificationPermissionRequestManager.h:
(NotificationPermissionRequestManager):
- 4:26 AM Changeset in webkit [125369] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL][UT] Delete shutdown method.
https://bugs.webkit.org/show_bug.cgi?id=90785
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-08-12
Reviewed by Eric Seidel.
EWKTestBase class already has a shutdownAll method that can be used instead of shutdown.
- tests/UnitTestUtils/EWKTestBase.cpp:
- tests/UnitTestUtils/EWKTestBase.h:
(EWKTestBase):
- 3:39 AM Changeset in webkit [125368] by
-
- 2 edits in trunk/Source/WebCore
Move CSS's propertyNameStrings[] to from the header to the cpp file
https://bugs.webkit.org/show_bug.cgi?id=93771
Reviewed by Eric Seidel.
The names of propertyNameStrings[] should never be accessed directly. The function getPropertyName()
return the correct string of propertyNameStrings.
To ensure the values are not accessed by mistake, move them from the header to the implementation.
- css/makeprop.pl:
- 3:37 AM Changeset in webkit [125367] by
-
- 2 edits in trunk/Source/WebCore
CSSComputedStyleDeclaration::cssText() should use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=93776
Reviewed by Eric Seidel.
String::append() is fairly inefficient when used to create a long string by appending a lot of small
pieces. StringBuilder is more approriate for the kind of operations done by CSSComputedStyleDeclaration::cssText().
This changes makes CSSComputedStyleDeclaration::cssText() about 6 times faster.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssText):
- 12:32 AM Changeset in webkit [125366] by
-
- 4 edits in branches/safari-536.26-branch/Source
Versioning.
- 12:18 AM Changeset in webkit [125365] by
-
- 4 edits in trunk/Tools
[Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
through the QTestLib headers anymore.
- DumpRenderTree/qt/EventSenderQt.cpp:
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
