Timeline



Aug 14, 2012:

11:28 PM Changeset in webkit [125651] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r125516. Revert the erroneous rename since we need to keep exposing
layoutTestController in Chromium port as explained r124785.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::bindJSObjectsToWindow):

11:25 PM Changeset in webkit [125650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeMirrorTextEditor doesn't clear execution line
​https://bugs.webkit.org/show_bug.cgi?id=94069

Patch by Jan Keromnes <​janx@linux.com> on 2012-08-14
Reviewed by Pavel Feldman.

Make CodeMirrorTextEditor use line handles instead of numbers, remove
typeof == "number" checks.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):

10:53 PM Changeset in webkit [125649] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Chromium-Android builds.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::TimeInputType):
Declare the function as a constructor.

10:20 PM Changeset in webkit [125648] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Text selection in text area in auto scroll mode goes wrong.
​https://bugs.webkit.org/show_bug.cgi?id=74346

Patch by Sukolsak Sakshuwong <​sukolsak@google.com> on 2012-08-14
Reviewed by Ojan Vafai.

Source/WebCore:

WebKit triggers autoscroll in text area when the user drags the cursor from inside
the text area to the outside. When that happens, it gets the local cursor position
relative to the node under the cursor from hit-testing, converts it to
the absolute position, and then converts it to the local position relative to the
text area. However, the hit-testing method of text area did not take scrolling
offset into account. This caused it to give an incorrect value of the local cursor
position. Make the hit-testing take scrolling offset into account.

Test: fast/events/autoscroll-in-textarea.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::createRenderer):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hitInnerTextElement):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore):

  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):

LayoutTests:

  • fast/events/autoscroll-in-textarea-expected.txt: Added.
  • fast/events/autoscroll-in-textarea.html: Added.
10:07 PM Changeset in webkit [125647] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Remove obsolete test expectations, and mark
slow tests as such.

  • platform/chromium/TestExpectations:
10:06 PM EfficientStrings created by benjamin@webkit.org
Some advice on the use of strings
9:27 PM Changeset in webkit [125646] by annacc@chromium.org
  • 19 edits
    5 deletes in branches/chromium/1229/Source/WebCore

Revert 124780 - Create a MediaSource object.
​https://bugs.webkit.org/show_bug.cgi?id=91773

Reviewed by Eric Carlson.

MediaSource object is needed in order to implement the new
object-oriented MediaSource API:
​http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing:
​https://bugs.webkit.org/show_bug.cgi?id=91775

Adding new files to build files:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

New MediaSource object:

  • Modules/mediasource/MediaSource.cpp: Added.
  • Modules/mediasource/MediaSource.h: Added.
  • Modules/mediasource/MediaSource.idl: Added.

Create a registry for the blob storage and lookup:

  • Modules/mediasource/MediaSourceRegistry.cpp: Added.
  • Modules/mediasource/MediaSourceRegistry.h: Added.

Connect SourceBuffer to MediaSource:

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered): Forward call to MediaSource.
(WebCore::SourceBuffer::append): Ditto.
(WebCore::SourceBuffer::abort): Ditto.

  • Modules/mediasource/SourceBuffer.h:

(WebCore::SourceBuffer::create): Add a MediaSource to the constructor.
(WebCore::SourceBuffer::clear): Clear the MediaSource.
(SourceBuffer):

  • Modules/mediasource/SourceBufferList.cpp: include SourceBuffer.h
  • Modules/mediasource/SourceBufferList.h:

Make MediaSource an EventTarget:

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Enable creation of MediaSource object URL from JavaScript:

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL):

  • html/DOMURL.h:

(WebCore):
(DOMURL):

  • html/DOMURL.idl:

New MediaSource constructor:

  • page/DOMWindow.idl:

TBR=​annacc@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10834324

9:22 PM Changeset in webkit [125645] by annacc@chromium.org
  • 2 edits in branches/chromium/1229/Source/WebCore/html

Revert 124798 - MediaSource should use it's own list of source URLs
​https://bugs.webkit.org/show_bug.cgi?id=93285

Reviewed by Eric Carlson.

r124780 added MediaSource objects to PublicURLManager's streamURLs list,
piggy-backing on MEDIA_STREAM. This patch creates a sourceURLs list so
that MediaSource can stand on its own.

Test: builds on Andriod even when MEDIA_STREAM is disabled.

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • html/PublicURLManager.h:

(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs):

TBR=​annacc@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10836255

9:02 PM Changeset in webkit [125644] by shinyak@chromium.org
  • 5 edits in trunk/Source/WebCore

[Refactoring] RenderMenuList and RenderListBox should have a method to return HTMLSelectElement.
​https://bugs.webkit.org/show_bug.cgi?id=94061

Reviewed by Kent Tamura.

This is a preparation patch for Bug 91487. Since RenderMenuList::node() and RenderListBox::node()
will not return HTMLSelectElement to fix Bug 91487, it would be good to have a method to HTMLSelectElement.

No new tests, no change in behavior.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectElement):
(WebCore):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::scrollToRevealSelection):
(WebCore::RenderListBox::size):
(WebCore::RenderListBox::numItems):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::stopAutoscroll):
(WebCore::RenderListBox::valueChanged):
(WebCore::RenderListBox::nodeAtPoint):

  • rendering/RenderListBox.h:

(WebCore):
(RenderListBox):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::selectElement):
(WebCore):
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::updateFromElement):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::valueChanged):
(WebCore::RenderMenuList::listBoxSelectItem):
(WebCore::RenderMenuList::multiple):
(WebCore::RenderMenuList::didSetSelectedIndex):
(WebCore::RenderMenuList::didUpdateActiveOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemAccessibilityText):
(WebCore::RenderMenuList::itemToolTip):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::listSize):
(WebCore::RenderMenuList::selectedIndex):
(WebCore::RenderMenuList::itemIsSeparator):
(WebCore::RenderMenuList::itemIsLabel):
(WebCore::RenderMenuList::itemIsSelected):
(WebCore::RenderMenuList::setTextFromItem):

  • rendering/RenderMenuList.h:

(WebCore):
(RenderMenuList):

9:00 PM Changeset in webkit [125643] by kinuko@chromium.org
  • 3 edits
    5 adds in trunk

FileWriter fails with assertion when trying to write empty Blob
​https://bugs.webkit.org/show_bug.cgi?id=93694

Reviewed by Kent Tamura.

if the given data size is zero (i.e. m_bytesToWrite is zero) the assertion 'bytes + m_bytesWritten > 0' should not be tested.

Source/WebCore:

Tests: fast/filesystem/file-writer-empty-blob.html

fast/filesystem/workers/file-writer-empty-blob.html

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::didWrite):

LayoutTests:

  • fast/filesystem/file-writer-empty-blob-expected.txt: Added.
  • fast/filesystem/file-writer-empty-blob.html: Added.
  • fast/filesystem/resources/file-writer-empty-blob.js: Added.
  • fast/filesystem/workers/file-writer-empty-blob-expected.txt: Added.
  • fast/filesystem/workers/file-writer-empty-blob.html: Added.
8:45 PM Changeset in webkit [125642] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, another gardening. Add one slow test.

  • platform/chromium/TestExpectations:
8:34 PM Changeset in webkit [125641] by keishi@webkit.org
  • 10 edits
    2 adds in trunk

Share common code between calendar picker and color suggestion picker
​https://bugs.webkit.org/show_bug.cgi?id=93802

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html:
  • ManualTests/forms/color-suggestion-picker.html:

Source/WebCore:

We want to share common code like utility functions between picker page popups.

No new tests because no behavior change. Covered by existing tests, color-suggestion-picker-appearance.html and calendar-picker-apeparance.html.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._showPopup):

  • Resources/pagepopups/colorSuggestionPicker.js:

(handleMessage):
(handleArgumentsTimeout):

  • Resources/pagepopups/pickerCommon.css: Added.

(body):

  • Resources/pagepopups/pickerCommon.js: Added.

(createElement):
(resizeWindow):
(getScrollbarWidth):

  • WebCore.gyp/WebCore.gyp: Add actions for pickerCommon.{css,js}
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument):

Source/WebKit/chromium:

  • src/ColorChooserUIController.cpp:

(WebKit::ColorChooserUIController::writeDocument):

8:24 PM Changeset in webkit [125640] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Add new test expectation for nested-rounded-corners.html.

  • platform/chromium/TestExpectations:
8:10 PM Changeset in webkit [125639] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for !ENABLE(DFG_JIT)

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
7:52 PM Changeset in webkit [125638] by mitz@apple.com
  • 2 edits in trunk/Tools

fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=94045

Reviewed by Geoff Garen.

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.

7:48 PM Changeset in webkit [125637] by fpizlo@apple.com
  • 30 edits
    2 adds in trunk/Source/JavaScriptCore

Array checks should use the structure, not the class info
​https://bugs.webkit.org/show_bug.cgi?id=93150

Reviewed by Mark Hahnenberg.

This changes all array checks used in array accesses (get, put, get length,
push, pop) to use the structure, not the class info. Additionally, these
checks in the LLInt and baseline JIT record the structure in an ArrayProfile,
so that the DFG can know exactly what structure to check for.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/ArrayProfile.cpp: Added.

(JSC):
(JSC::ArrayProfile::computeUpdatedPrediction):

  • bytecode/ArrayProfile.h: Added.

(JSC):
(JSC::arrayModeFromStructure):
(ArrayProfile):
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::bytecodeOffset):
(JSC::ArrayProfile::addressOfLastSeenStructure):
(JSC::ArrayProfile::observeStructure):
(JSC::ArrayProfile::expectedStructure):
(JSC::ArrayProfile::structureIsPolymorphic):
(JSC::ArrayProfile::hasDefiniteStructure):
(JSC::ArrayProfile::observedArrayModes):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::getArrayProfile):
(JSC):
(JSC::CodeBlock::getOrAddArrayProfile):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::executionEntryCount):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(CodeBlock):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetArgumentByVal):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitPutByVal):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::StructureAbstractValue::hasSingleton):
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::singleton):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateArray):
(DFG):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/Structure.h:

(Structure):
(JSC::Structure::classInfoOffset):

7:33 PM Changeset in webkit [125636] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation update. Address new flakiness
and slow tests.

  • platform/chromium/TestExpectations:
7:14 PM Changeset in webkit [125635] by ojan@chromium.org
  • 5 edits
    2 adds in trunk

Fix access to m_markupBox in WebCore::EllipsisBox::paint
​https://bugs.webkit.org/show_bug.cgi?id=91138

Reviewed by Abhishek Arya.

Source/WebCore:

EllipsisBox would hold on to m_markupBox, which would then get destroyed during
the followup layoutIfNeeded in layoutVerticalBox. Instead, have EllipsisBox
dynamically grab to pointer to the markup box during paint since there's no
straightforward way to notify the EllipsisBox that the markupBox has been destroyed
and/or point it at the new markupBox.

Test: fast/overflow/line-clamp-and-columns.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore):
(WebCore::EllipsisBox::paintMarkupBox):

  • rendering/EllipsisBox.h:

(WebCore::EllipsisBox::EllipsisBox):
Just store a boolean that we have a markup box that needs painting.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
Clearing the override size right after setting it was incorrect because
there are cases where we'll do a followup layout in layoutVerticalBox, at which
point we'll still need the override size.
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
Clear the override size here to handle cases where line clamp is removed since
we don't call applyLineClamp in those cases.

LayoutTests:

  • fast/overflow/line-clamp-and-columns-expected.html: Added.
  • fast/overflow/line-clamp-and-columns.html: Added.
7:08 PM Changeset in webkit [125634] by yosin@chromium.org
  • 5 edits
    3 adds in trunk

[Forms] Make input type "time" to use multiple field time input UI
​https://bugs.webkit.org/show_bug.cgi?id=93929

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes input type "time" UI to use multiple field time
input UI when build flag ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
enabled.

No new tests. This patch doesn't change behavior for users, however,
this patch changes behavior on layout tests. Tests will be added
in another patch with runtime enabled feature flag is enabled.

Test expectations for following tests are updated:

  • fast/forms/time/time-input-visible-string.html
  • fast/forms/time/time-stepup-stepdown-from-renderer.html
  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Exposed serialize() to derived classes.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::DateTimeEditControlOwnerImpl):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::~DateTimeEditControlOwnerImpl):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlMouseFocus):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerDisabled):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerReadOnly):
(WebCore::TimeInputType::TimeInputType):
(WebCore::TimeInputType::~TimeInputType):
(WebCore::TimeInputType::createRenderer):
(WebCore::TimeInputType::createShadowSubtree):
(WebCore::TimeInputType::destroyShadowSubtree):
(WebCore::TimeInputType::forwardEvent):
(WebCore::TimeInputType::disabledAttributeChanged):
(WebCore::TimeInputType::handleKeydownEvent):
(WebCore::TimeInputType::handleDOMActivateEvent):
(WebCore::TimeInputType::isKeyboardFocusable):
(WebCore::TimeInputType::isMouseFocusable):
(WebCore::TimeInputType::minOrMaxAttributeChanged):
(WebCore::TimeInputType::readonlyAttributeChanged):
(WebCore::TimeInputType::isTextField):
(WebCore::TimeInputType::setValue):
(WebCore::TimeInputType::shouldUseInputMethod):
(WebCore::TimeInputType::stepAttributeChanged):
(WebCore::TimeInputType::updateEditElementLayout):
(WebCore::TimeInputType::updateInnerTextValue):
(WebCore::TimeInputType):

  • html/TimeInputType.h:

(TimeInputType):
(DateTimeEditControlOwnerImpl):

LayoutTests:

This patch added test expectations for multiple fields time input UI
testing which are different behavior from single field time input UI
for Chromium which enables multiple fields time input UI.

  • platform/chromium/fast/forms/time/time-input-visible-string-expected.txt: Select all in a field doesn't select text.
  • platform/chromium/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Fields don't change value on Up/Down keyboard events when they don't have focus and Up/Down keyboard increment/decrement value on hour field rather than minute field.
6:51 PM Changeset in webkit [125633] by dino@apple.com
  • 3 edits
    2 adds in trunk

Initial call to webkitRequestAnimationFrame returns 0, Spec indicates the handle should always be > 0
​https://bugs.webkit.org/show_bug.cgi?id=85819

Reviewed by James Robinson.

Source/WebCore:

The callback id returned by requestAnimationFrame was beginning at zero, when the spec
says it should be above one. Use a pre-increment rather than a post-increment.

Test: fast/animation/request-animation-frame-callback-id.html

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback): Pre-increment rather than post-increment.

LayoutTests:

  • fast/animation/request-animation-frame-callback-id-expected.txt: Added.
  • fast/animation/request-animation-frame-callback-id.html: Added.
6:39 PM Changeset in webkit [125632] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

r125591 broke tests with SUBPIXEL_LAYOUT disabled
​https://bugs.webkit.org/show_bug.cgi?id=94027

Reviewed by Eric Seidel.

The previous patch to fix block preferred widths for subpixel layout broke ports
without the flag enabled. This patch adds a static inline function --
adjustFloatForSubPixelLayout -- that truncates with sub-pixel layout disabled, and
ceil's to the nearest FractionalLayoutUnit when sub-pixel layout is enabled.

A block's max preferred width should be enough to layout the entire line without
wrapping. r125591 addressed a bug whereby converting floats to LayoutUnits with sub-
pixel layout enabled lost precision in certain cases, and could result in a line
being layed out to slightly over the max preferred width of the block.

This patch reverts the behavior when sub-pixel layout is disabled to truncating
sub-pixel values (such as those that originate in Length) when assigning them to
LayoutUnits, and ceiling the length of the entire line to the next largest integer.

Covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore):
(WebCore::adjustFloatForSubPixelLayout):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

6:28 PM Changeset in webkit [125631] by cevans@google.com
  • 3 edits
    2 adds in trunk

Handle the XPath / (root) operator correctly for nodes that aren't attached to the document.
​https://bugs.webkit.org/show_bug.cgi?id=36427

Reviewed by Abhishek Arya.

Source/WebCore:

We now behave the same as Firefox 14.
The consensus seems to be that the XPath spec is ambiguous for the case of detached nodes, and that using the fragment root is more intuitive than the document root for the case of detached nodes.
For example, ​http://www.w3.org/TR/xpath/ section 2 "Location Paths" is only clear for attached nodes: "A / by itself selects the root node of the document containing the context node. If it is followed by a relative location path, then the location path selects the set of nodes that would be selected by the relative location path relative to the root node of the document containing the context node."

Test: fast/xpath/xpath-detached-nodes.html

  • xml/XPathPath.cpp:

(WebCore::XPath::LocationPath::evaluate): Jump to the root of the detached subtree instead of the parent document if the node isn't attached to the document.

LayoutTests:

  • fast/xpath/xpath-detached-nodes-expected.txt: Added.
  • fast/xpath/xpath-detached-nodes.html: Added.
6:23 PM Changeset in webkit [125630] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

6:21 PM Changeset in webkit [125629] by Alexandru Chiculita
  • 3 edits
    2 adds in trunk

[CSS Shaders][Chromium] Filters area applied twice when CustomFilterOperation is in the list
​https://bugs.webkit.org/show_bug.cgi?id=93900

Reviewed by James Robinson.

Source/WebCore:

Whenever the platform cannot render a shader in hardware it will fallback to software.
In such cases, the platform should remove any old filters applied, so that the filters do not apply twice.

Test: css3/filters/custom/filter-fallback-to-software.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setFilters):

LayoutTests:

Added a test that first applies a blur and then switches to a CSS Shader plus a blur.
The test was failing on Chromium by not removing the old blur filter from the platform layer.

  • css3/filters/custom/filter-fallback-to-software-expected.html: Added.
  • css3/filters/custom/filter-fallback-to-software.html: Added.
6:19 PM Changeset in webkit [125628] by ap@apple.com
  • 3 edits in trunk/Tools

[WK2] Fix some typos in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=94047

Reviewed by Jon Honeycutt.

  • MiniBrowser/mac/AppDelegate.m:

(didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didReceiveMessage):
(WKBundleInitialize):

6:18 PM Changeset in webkit [125627] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

IndexedDB: add tracing to IDBLevelDBBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=93914

Patch by Alec Flett <​alecflett@chromium.org> on 2012-08-14
Reviewed by Tony Chang.

Add a bunch of trace events to the lower level
database layer, to separate database slowness
from core IDB slowness.

Also moving findKeyInIndex into IDBLevelDBBackingStore to
eventually make it const.

No new tests, just adding debug logging.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):

5:56 PM Changeset in webkit [125626] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Refactor EventDispatcher, moving code to make actual changes easier to review later.
​https://bugs.webkit.org/show_bug.cgi?id=93959

Reviewed by Dimitri Glazkov.

No new tests - no new functionality.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore):
(WebCore::EventDispatcher::dispatchSimulatedClick):

5:33 PM Changeset in webkit [125625] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Fix warnings on Windows build
​https://bugs.webkit.org/show_bug.cgi?id=93997

Patch by Scott Graham <​scottmg@chromium.org> on 2012-08-14
Reviewed by Kentaro Hara.

Fixes truncation from 'double' to 'float' warnings on Chromium Windows
build.

  • tests/CCRenderSurfaceFiltersTest.cpp:

(WebKit::TEST):

  • tests/CCScrollbarAnimationControllerLinearFadeTest.cpp:

(WebCore::TEST_F):

5:10 PM Changeset in webkit [125624] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Clear pattern to prevent timing problem between cancelVibration and vibrate
​https://bugs.webkit.org/show_bug.cgi?id=93957

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-08-14
Reviewed by Kentaro Hara.

There is a timing issue in the cancelVibration.
Since vibrate works based on timer, cancelVibration might be called
eariler than vibrate when cancelVibration is called just after vibrate call.
It can be prevented from clearing m_pattern in the cancelVibration.

  • Modules/vibration/Vibration.cpp:

(WebCore::Vibration::cancelVibration):

5:08 PM Changeset in webkit [125623] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.6

New Tag.

4:40 PM Changeset in webkit [125622] by commit-queue@webkit.org
  • 12 edits in trunk

/SAFESEH should not be a common linker option
​https://bugs.webkit.org/show_bug.cgi?id=89372

Patch by Alex Christensen <​alex.christensen@flexsim.com> on 2012-08-14
Reviewed by Darin Adler.

  • win/tools/vsprops/common.vsprops:

removed /SAFESEH as a default option for the linker (doesn't work for x64)

4:28 PM Changeset in webkit [125621] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/JavaScriptCore

Merged r124272. <rdar://problem/12002610>

4:25 PM Changeset in webkit [125620] by Lucas Forschler
  • 14 edits in branches/safari-536.26-branch/Source

Merged r124268. <rdar://problem/12002610>

4:21 PM Changeset in webkit [125619] by enne@google.com
  • 3 edits
    8 adds in trunk/LayoutTests

[chromium] Add baselines for video-controls-layer-creation layout test

Unreviewed expectation update.

  • compositing/video/video-controls-layer-creation-expected.txt: Added.
  • platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/mac/TestExpectations:
4:17 PM Changeset in webkit [125618] by crogers@google.com
  • 3 edits in trunk/Source/WebKit/chromium

Implement new synchronized audio I/O render method in chromium
​https://bugs.webkit.org/show_bug.cgi?id=93510

Reviewed by Kenneth Russell.

The chromium implementation of AudioDestination is being upgraded to
support synchronized audio I/O. Other changes on the chromium-side
can then be tested against something that works in WebKit.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::render):
(WebCore):
(WebCore::AudioDestinationChromium::provideInput):

  • src/AudioDestinationChromium.h:

(WebCore):
(AudioDestinationChromium):

4:16 PM Changeset in webkit [125617] by Alexandru Chiculita
  • 7 edits in trunk

Layout Test css3/filters/custom/custom-filter-animation.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=91769

Reviewed by Dean Jackson.

Source/WebCore:

Mountain Lion added support for accelerated filter animations, but CSS Shaders are still
rendered in software mode. The setFilters method is using PlatformCALayer::filtersCanBeComposited to check
if the filters can be handled in hardwawre, so I've reused that in the createFilterAnimationsFromKeyframes
to check if the animations can also run in hardware.

Also the GraphicsContext3D doesn't update its own internal m_boundFBO when a framebuffer is deleted,
so I've added that to the FECustomFilter. Otherwise, if the next framebuffer is created using the same
identifier, bindFramebuffer will just return without calling the glBindFramebuffer because of this optimization.

The documentation for glDeleteFramebuffer says that the bound framebuffer is unbound before deleting it.
This is not reproduceable from WebGL, because WebGLRenderingContext::deleteFramebuffer
already knows to unbind the framebuffer when needed. However, I'm also adding that in GraphicsContext3DOpenGLCommon.cpp
and efl/GraphicsContext3DPrivate.cpp, to make sure that m_boundFBO is not used for other purposes.

No new tests, this patch fixes a failing test.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::deleteFramebuffer):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::deleteRenderBuffers):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::deleteFramebuffer):

LayoutTests:

The test should be passing on Mountain Lion now, so I'm removing it from the list.

  • platform/mac/TestExpectations:
3:47 PM Changeset in webkit [125616] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r125319. <rdar://problem/12092509>

3:34 PM Changeset in webkit [125615] by abarth@webkit.org
  • 64 edits in trunk/Source

Delete Frame::domWindow() and Frame::existingDOMWindow()
​https://bugs.webkit.org/show_bug.cgi?id=93990

Reviewed by Eric Seidel.

Source/WebCore:

These functions just call through to document()->domWindow(). This
patch updates the callers so it's clearer what's going on.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToFrame):
(WebCore::printErrorMessageForFrame):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):
(WebCore::JSDocument::setLocation):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWindowShell):

  • bindings/objc/DOMAbstractView.mm:

(core):

  • bindings/v8/NPV8Object.cpp:

(WebCore::toV8Context):

  • bindings/v8/ScriptController.cpp:

(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrieveFrame):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):
(WebCore::V8Document::locationAccessorSetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • dom/Document.cpp:

(WebCore::printNavigationErrorMessage):

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::insertDictatedText):

  • editing/Editor.cpp:

(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::setComposition):

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::contentWindow):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::storageId):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::fireBeforeUnloadEvent):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::isCurrentlyDisplayedInFrame):
(WebCore::DOMWindow::self):
(WebCore::DOMWindow::opener):
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):

  • page/DragController.cpp:

(WebCore::DragController::dispatchTextInputEventFor):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTextInputEvent):

  • page/Frame.cpp:
  • page/Frame.h:

(Frame):

  • page/Location.cpp:

(WebCore::Location::replace):
(WebCore::Location::reload):
(WebCore::Location::setLocation):

  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatch):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::toOriginString):
(WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
(WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
(WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::requestWebGLPermission):

Source/WebKit/chromium:

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):

  • src/WebDOMMessageEvent.cpp:

(WebKit::WebDOMMessageEvent::initMessageEvent):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::performance):
(WebKit::WebFrameImpl::addMessageToConsole):
(WebKit::WebFrameImpl::unloadListenerCount):
(WebKit::WebFrameImpl::addEventListener):
(WebKit::WebFrameImpl::removeEventListener):
(WebKit::WebFrameImpl::dispatchEvent):
(WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck):
(WebKit::WebFrameImpl::deliverIntent):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::pendingUnloadEventCount):

  • ewk/ewk_frame.cpp:

(ewk_frame_intent_deliver):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getPendingUnloadEventCount):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _pendingFrameUnloadEventCount]):
(-[WebFrame _cacheabilityDictionary]):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::DOMWindow):
(WebFrame::pendingFrameUnloadEventCount):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::deliverIntent):
(WebKit::WebFrame::pendingUnloadCount):

3:27 PM Changeset in webkit [125614] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Tighten up parsing the 'script-nonce' CSP directive value.
​https://bugs.webkit.org/show_bug.cgi?id=93783

Patch by Mike West <​mkwst@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Source/WebCore:

Currently we're accepting any non-whitespace character. This patch
limits the valid characters to VCHAR minus ',' and ';', and pulls the
validity check out into a named function for clarity.

Test: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::parseScriptNonce):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html: Added.
3:14 PM Changeset in webkit [125613] by abarth@webkit.org
  • 8 edits in trunk

Delete DOMWindow::m_url
​https://bugs.webkit.org/show_bug.cgi?id=93989

Reviewed by Eric Seidel.

Source/WebCore:

There's no reason for DOMWindow to keep a separate copy of the
Document's URL now that there is a predictable way to get a Document
from a DOMWindow.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

  • page/DOMWindow.h:

(DOMWindow):

LayoutTests:

The error messages for these tests now relect the document's updated
URL after document.write has changed the URL. Previously, we failed to
sync these changes to DOMWindow::m_url, which is why the error messages
showed the wrong URL.

  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
3:05 PM Changeset in webkit [125612] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

De-inline stuff from RenderStyle.h
​https://bugs.webkit.org/show_bug.cgi?id=94019

Patch by Nikhil Bhargava <​nbhargava@google.com> on 2012-08-14
Reviewed by Eric Seidel.

De-inline things from RenderStyle.h in preparation of fixing a series of
errant includes.

No new tests. Doesn't change functionality

  • WebCore.exp.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::listStyleImage):
(WebCore::RenderStyle::setListStyleImage):
(WebCore):
(WebCore::RenderStyle::color):
(WebCore::RenderStyle::visitedLinkColor):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
(WebCore::RenderStyle::horizontalBorderSpacing):
(WebCore::RenderStyle::verticalBorderSpacing):
(WebCore::RenderStyle::setHorizontalBorderSpacing):
(WebCore::RenderStyle::setVerticalBorderSpacing):
(WebCore::RenderStyle::font):
(WebCore::RenderStyle::fontMetrics):
(WebCore::RenderStyle::fontDescription):
(WebCore::RenderStyle::fontSize):
(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::letterSpacing):
(WebCore::RenderStyle::setFontDescription):
(WebCore::RenderStyle::lineHeight):
(WebCore::RenderStyle::setLineHeight):
(WebCore::RenderStyle::computedLineHeight):
(WebCore::RenderStyle::setWordSpacing):
(WebCore::RenderStyle::setLetterSpacing):

  • rendering/style/RenderStyle.h:
3:02 PM Changeset in webkit [125611] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Checkerboard flashes on Go Back
​https://bugs.webkit.org/show_bug.cgi?id=94018

Patch by Leo Yang <​leoyang@rim.com> on 2012-08-14
Reviewed by Yong Li.
Reviewed internally by Yong Li.

The backing store need to be suspended before the
WebPagePrivate::restoreHistoryViewState() is called to avoid UI thread
drawing checkerboard.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

2:36 PM Changeset in webkit [125610] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

[CSSRegions]Region overset property is incorectly computed when content has negative letter spacing and is flowed near to the edge of a region
​https://bugs.webkit.org/show_bug.cgi?id=92506

Patch by Andrei Onea <​onea@adobe.com> on 2012-08-14
Reviewed by Eric Seidel.

Source/WebCore:

When the content which is flowed inside a region creates visual overflow in
the writing direction, the overflow rect is also extended in the other direction, and
that forces regionOverset to become "fit" for all regions.

Tests: fast/regions/element-region-overset-state-negative-letter-spacing.html

fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):

LayoutTests:

Added tests for incorrect regionOverset computation when visual overflow in the writing direction creates
overset for all regions.

  • fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
  • fast/regions/element-region-overset-state-negative-letter-spacing.html: Added.
  • fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
  • fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html: Added.
2:35 PM Changeset in webkit [125609] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unnecessary \n's from InputHandler log messages.
​https://bugs.webkit.org/show_bug.cgi?id=94015

Reviewed by Rob Buis.

Remove many unnecessary \n's from the end of log messages.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setText):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):

2:33 PM Changeset in webkit [125608] by fmalita@chromium.org
  • 4 edits
    2 adds in trunk

beginElement() does not observe updated animation attributes
​https://bugs.webkit.org/show_bug.cgi?id=93972

Reviewed by Dirk Schulze.

Source/WebCore:

The SVG animation attributes 'from', 'to' and 'by' should be registered as supported
SVGSMILElement attributes in order to trigger animationAttributeChanged() on dynamic
updates.

Test: svg/animations/updated-attributes.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::updateAnimation):
Minor optimization - avoid recalculating animationMode().

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::isSupportedAttribute):
Register 'from', 'to' and 'by' as supported SVGSMILElement attributes.

LayoutTests:

  • svg/animations/updated-attributes-expected.txt: Added.
  • svg/animations/updated-attributes.html: Added.
2:33 PM Changeset in webkit [125607] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/1180

Merge 123822 - [Chromium] Regression: Global-buffer-overflow in WebCore::mediaControlElementType
BUG=132270
Review URL: ​https://chromiumcodereview.appspot.com/10827333

2:23 PM Changeset in webkit [125606] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Rebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents.html.
​https://bugs.webkit.org/show_bug.cgi?id=93909

Patch by Roger Fong <​roger_fong@apple.com> on 2012-08-14
Reviewed by Tim Horton.

As per ​https://bugs.webkit.org/show_bug.cgi?id=92904 rebaselining those tests.

  • compositing/overflow/clip-descendents-expected.txt: Rebaselined.
  • platform/mac/TestExpectations: Removed tests from expectations list.
  • platform/mac/fast/box-sizing/box-sizing-expected.txt: Rebaselined.
2:20 PM Changeset in webkit [125605] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Don't crash on OOM in AC
​https://bugs.webkit.org/show_bug.cgi?id=93999

Patch by Filip Spacek <​fspacek@rim.com> on 2012-08-14
Reviewed by George Staikos.

Internally reviewed by George Staikos.

Fail gracefully in case we fail to allocate the bitmap
for the AC layer contents.

  • platform/graphics/blackberry/InstrumentedPlatformCanvas.h:

(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::paintContents):

2:16 PM Changeset in webkit [125604] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
​https://bugs.webkit.org/show_bug.cgi?id=93904

Patch by Roger Fong <​roger_fong@apple.com> on 2012-08-14
Reviewed by Tim Horton.

old-run-webkit-tests ref test only skipped .html test.
They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.

  • Scripts/old-run-webkit-tests:

(isUsedInReftest): Skip all extensions for ref tests.

2:11 PM Changeset in webkit [125603] by commit-queue@webkit.org
  • 71 edits in trunk

Convert signals/slots to Q_* macros.

[Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
​https://bugs.webkit.org/show_bug.cgi?id=93996

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Change usage of keyword-conflicting 'signals' and 'slots' for
Q_SIGNALS and Q_SLOTS macro.

Source/WebCore:

  • bridge/testqtbindings.cpp:

(MyObject):

  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/network/qt/DnsPrefetchHelper.h:

(DnsPrefetchHelper):

  • platform/network/qt/NetworkStateNotifierPrivate.h:

(NetworkStateNotifierPrivate):

  • platform/network/qt/QNetworkReplyHandler.h:

(QNetworkReplyHandler):

  • platform/network/qt/QtMIMETypeSniffer.h:

(QtMIMETypeSniffer):

  • platform/network/qt/SocketStreamHandlePrivate.h:

(SocketStreamHandlePrivate):

  • platform/qt/GamepadsQt.cpp:

(GamepadDeviceLinuxQt):
(GamepadsQt):

  • platform/qt/SharedTimerQt.cpp:

(SharedTimerQt):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

  • WebCoreSupport/FullScreenVideoQt.h:

(FullScreenVideoQt):

  • WebCoreSupport/FullScreenVideoWidget.h:

(FullScreenVideoWidget):

  • WebCoreSupport/IconDatabaseClientQt.h:

(IconDatabaseClientQt):

  • WebCoreSupport/InspectorClientQt.cpp:

(InspectorClientWebPage):

  • WebCoreSupport/InspectorServerQt.h:

(InspectorServerQt):
(InspectorServerRequestHandlerQt):

  • WebCoreSupport/PopupMenuQt.h:

(PopupMenuQt):

  • WebCoreSupport/QtFallbackWebPopup.h:

(QtFallbackWebPopup):

  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:

(wrapInFunction):

  • docs/webkitsnippets/webpage/main.cpp:

(Thumbnailer):

  • examples/platformplugin/WebPlugin.h:

(Popup):
(WebPopup):

  • tests/benchmarks/webgl/tst_webgl.cpp:

(tst_WebGlPerformance):

  • tests/hybridPixmap/tst_hybridPixmap.cpp:

(tst_hybridPixmap):

  • tests/hybridPixmap/widget.h:

(Widget):

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView):

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView):
(WebPage):
(ResizeSpy):

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(MyWebElementSlotOnlyObject):
(tst_QObjectBridge):
(TestPluginWidget):

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement):

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame):
(FakeReply):

  • tests/qwebhistory/tst_qwebhistory.cpp:
  • tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:

(tst_QWebHistoryInterface):

  • tests/qwebinspector/tst_qwebinspector.cpp:

(tst_QWebInspector):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(JSTestPage):
(RepaintRequestedRenderer):
(SpyForLoadSignalsOrder):

  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp:

(tst_QWebPluginDatabase):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView):
(WebViewCrashTest):

Source/WebKit2:

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp:

(tst_InspectorServer):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

(tst_publicapi):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):

  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:

(WebView):
(tst_qrawwebview):

  • UIProcess/API/qt/tests/util.cpp:

(LoadSpy):

  • UIProcess/API/qt/tests/util.h:

(LoadStartedCatcher):

  • UIProcess/InspectorServer/qt/WebSocketServerQt.h:

(QtTcpServerHandler):

  • UIProcess/qt/QtDialogRunner.cpp:

(DialogContextBase):
(DialogContextObject):
(BaseAuthenticationContextObject):
(CertificateVerificationDialogContextObject):
(FilePickerContextObject):
(DatabaseQuotaDialogContextObject):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

  • WebProcess/Downloads/qt/QtFileDownloader.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(NetworkAccessManager):
(WebPage):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

  • DumpRenderTree/qt/GCControllerQt.h:

(GCController):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/qt/TextInputControllerQt.h:

(TextInputController):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions):

  • MiniBrowser/qt/UrlLoader.h:

(UrlLoader):

  • QtTestBrowser/cookiejar.h:

(TestBrowserCookieJar):

  • QtTestBrowser/fpstimer.h:

(FpsTimer):

  • QtTestBrowser/launcherwindow.h:

(LauncherWindow):

  • QtTestBrowser/locationedit.h:

(LocationEdit):

  • QtTestBrowser/mainwindow.h:

(MainWindow):

  • QtTestBrowser/urlloader.h:

(UrlLoader):

  • QtTestBrowser/webinspector.h:

(WebInspector):

  • QtTestBrowser/webpage.h:

(WebPage):

  • QtTestBrowser/webview.h:

(WebViewGraphicsBased):

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WatchdogTimerHelper):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WrapperWindow):

  • WebKitTestRunner/qt/main.cpp:

(Launcher):

2:06 PM Changeset in webkit [125602] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

[WK2] Track multiple Web Processes per context
​https://bugs.webkit.org/show_bug.cgi?id=93915

Reviewed by Sam Weinig.

  • UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): Downloads don't work yet, added a FIXME.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::deprecatedSharedProcess): Renamed from process(), added an assertion that this is only used in single proces mode. (WebKit::WebContext::textCheckerStateChanged): Abstract out access to web processes. (WebKit::WebContext::ensureSharedWebProcess): Renamed ensureWebProcess() for clarity. (WebKit::WebContext::createNewWebProcess): Extracted code for creating a process from ensureWebProcess(). (WebKit::WebContext::warmInitialProcess): Create the process more explicitly. (WebKit::WebContext::enableProcessTermination): Iterate over all processes. (WebKit::WebContext::shouldTerminate): Updated assertion. (WebKit::WebContext::processDidFinishLaunching): Changed to use process argument instead of m_process. (WebKit::WebContext::disconnectProcess): Updated code forto use m_processes. (WebKit::WebContext::createWebPage): Handle both process policies (initial support for multi-process). (WebKit::WebContext::relaunchProcessIfNecessary): Added cases for both policies. (WebKit::WebContext::download): Ditto. (WebKit::WebContext::postMessageToInjectedBundle): Ditto. (WebKit::WebContext::didReceiveSyncMessage): Fixed whitespace. (WebKit::WebContext::getWebCoreStatistics): Added cases for both policies.
  • UIProcess/WebContext.h: (WebKit::WebContext::sendToAllProcesses): (WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary): Send to all processes. Changed return type to void, since no caller checked it.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage): Removed an assertion that assumed one process per context.
  • UIProcess/WebTextChecker.cpp: (WebKit::updateStateForAllWebProcesses): Updated to use a WebContext method.
2:02 PM Changeset in webkit [125601] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION r125500: 7 tests crashing on Mac bots
​https://bugs.webkit.org/show_bug.cgi?id=93970

Reviewed by Eric Seidel.

Make WebFrameLoaderClient::redirectDataToPlugin expect the now real possibility
of a NULL pluginWidget argument.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::redirectDataToPlugin)

1:53 PM Changeset in webkit [125600] by commit-queue@webkit.org
  • 7 edits in trunk

[CSSRegions]regionOverset is computed as "overset" even though the region is not the last in the chain
​https://bugs.webkit.org/show_bug.cgi?id=93102

Patch by Andrei Onea <​onea@adobe.com> on 2012-08-14
Reviewed by Eric Seidel.

Source/WebCore:

Making Element.webkitRegionOverset return "overset" only for the last region in a region chain,
if the content cannot fit inside it, to reflect current spec. ​http://www.w3.org/TR/css3-regions/#dom-region-regionoverset

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):

LayoutTests:

Modified existing tests to reflect spec, where Element.webkitRegionOverset can be
"overset" only for the last region in a region chain, if the content cannot fit inside it.

  • fast/regions/element-region-overset-state-expected.txt:
  • fast/regions/element-region-overset-state-vertical-rl-expected.txt:
  • fast/regions/element-region-overset-state-vertical-rl.html:
  • fast/regions/element-region-overset-state.html:
1:47 PM Changeset in webkit [125599] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Render breakpoint gutter markers and execution line in CodeMirrorTextEditor
​https://bugs.webkit.org/show_bug.cgi?id=93686

Patch by Jan Keromnes <​janx@linux.com> on 2012-08-14
Reviewed by Pavel Feldman.

Divided TextEditor.addDecoration into addBreakpoint, setExecutionLine
and addDecoration. Same for removeDecoration. Render breakpoint
markers and execution line in CodeMirrorTextEditor.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._onGutterClick):
(WebInspector.CodeMirrorTextEditor.prototype.addBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.removeBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.setExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.removeAttribute):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._onMouseDown):
(WebInspector.DefaultTextEditor.prototype.addBreakpoint):
(WebInspector.DefaultTextEditor.prototype.removeBreakpoint):
(WebInspector.DefaultTextEditor.prototype.setExecutionLine):
(WebInspector.DefaultTextEditor.prototype.clearExecutionLine):
(WebInspector.DefaultTextEditor.prototype.addDecoration):
(WebInspector.DefaultTextEditor.prototype.removeDecoration):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.addBreakpoint):
(WebInspector.TextEditor.prototype.removeBreakpoint):
(WebInspector.TextEditor.prototype.setExecutionLine):
(WebInspector.TextEditor.prototype.clearExecutionLine):
(WebInspector.TextEditor.prototype.addDecoration):
(WebInspector.TextEditor.prototype.removeDecoration):

  • inspector/front-end/cmdevtools.css:

(.CodeMirror):
(.cm-highlight):
(@-webkit-keyframes fadeout):
(to):
(.cm-breakpoint):
(.cm-breakpoint-disabled):
(.cm-breakpoint-conditional):
(.cm-execution-line):
(.webkit-html-message-bubble):
(.webkit-html-warning-message):
(.webkit-html-error-message):
(.webkit-html-message-line):
(.webkit-html-message-line-hover):

1:45 PM Changeset in webkit [125598] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Queue spellcheck requests with char-count limitations
​https://bugs.webkit.org/show_bug.cgi?id=93866

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-08-14
Reviewed by Rob Buis.

PR184196
Making spellcheck a little more granular so as to work around
the limitations of the inputservice.
Also, spellcheck the entire field on focus only if
spellcheck="on" is explicitly set.

Internally reviewed by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

1:44 PM Changeset in webkit [125597] by enne@google.com
  • 5 edits
    1 add in trunk

REGRESSION (r109851): Video controls do not render
​https://bugs.webkit.org/show_bug.cgi?id=93859

Reviewed by Simon Fraser.

Source/WebCore:

Because video layers can't act as an ancestor composited layer whose
backing can be shared by child layers, any child layer of a video
layer needs to be put into its own composited layer. Because this is
technically overlap, the "overlap" indirect compositing reason is
reused for this case.

Test: compositing/video/video-controls-layer-creation.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

Convert jernoble's test into a layout test.

  • compositing/video/video-controls-layer-creation.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
1:30 PM Changeset in webkit [125596] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Update Test Expectations to consolidate bug refs for new tests added
with r125578.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
1:06 PM Changeset in webkit [125595] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark css2.1/20110323/c541-word-sp-000.htm as failing on Windows Chromium
​https://bugs.webkit.org/show_bug.cgi?id=94017

Unreviewed gardening. Expectation update.

  • platform/chromium/TestExpectations:
1:02 PM Changeset in webkit [125594] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Update Test Expectations after r125578

Unreviewed gardening.

  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
12:49 PM Changeset in webkit [125593] by commit-queue@webkit.org
  • 17 edits in trunk

WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
​https://bugs.webkit.org/show_bug.cgi?id=42332

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Provide build for mac.

  • WebCore.exp.in: Added ZNK7WebCore19ResourceRequestBase20firstPartyForCookiesEv.

Source/WebKit2:

Added new getters to WKURL, WKURLRequest, WKURLResponse so that it is possible
to dump information necessary for the tests passing.

  • Shared/API/c/WKURL.cpp:

(WKURLCopyPath):

  • Shared/API/c/WKURL.h:
  • Shared/API/c/WKURLRequest.cpp:

(WKURLRequestCopyFirstPartyForCookies):
(WKURLRequestCopyHTTPMethod):

  • Shared/API/c/WKURLRequest.h:
  • Shared/API/c/WKURLResponse.cpp:

(WKURLResponseHTTPStatusCode):

  • Shared/API/c/WKURLResponse.h:
  • Shared/WebURL.h:

(WebKit::WebURL::path):
(WebURL):

Tools:

Added Resource Callbacks logging. Several aux dumping functions are added.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::isFileScheme):
(WTR):
(WTR::pathSuitableForTestResult):
(WTR::urlSuitableForTestResult):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::dumpErrorDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
(WTR::InjectedBundlePage::didFinishLoadForResource):
(WTR::InjectedBundlePage::didFailLoadForResource):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpResourceLoadCallbacks):
(WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
(LayoutTestController):

LayoutTests:

Unskipped correspondong test cases.

  • platform/wk2/Skipped:
12:47 PM Changeset in webkit [125592] by abarth@webkit.org
  • 29 edits
    1 delete in trunk

DOMWindow::document() should not reach through Frame
​https://bugs.webkit.org/show_bug.cgi?id=27640

Reviewed by Eric Seidel.

Source/WebCore:

Originally, the lifetime of DOMWindow was similar to that of Frame in
that it was reused for each document that was displayed in the Frame.
To fix some tricky security issues, all modern browsers use a "split
window" architecture whereby the DOMWindow is not reused by each
Document in a Frame. Instead a JavaScript "window shell" object
redirects JavaScript references to the active Document's DOMWindow.

When we implemented split windows, we left DOMWindow attached to the
Frame and attempted to keep it in sync with the Document via a lot of
delicate code. One of the main problems with this approach is that
finding the DOMWindow associated with a Document or the Document
associated with a DOMWindow required traversing through the Frame.
Because there is a many-to-one relationship between both Documents and
Frames (as well as DOMWindows and Frames), this traversal is error
prone and not always available (e.g., for inactive documents).

This patch moves the "owning" reference for DOMWindow to Document so
that we can directly traverse from Document to DOMWindow. For
traversing from DOMWindow to Document, each DOMWindow keeps a Document
pointer via a ContextDestructionObserver base class.

The main sublties in this patch are related to situations in which
there isn't precisely a one-to-one relationship between Documents and
DOMWindows. Previously, these situations were handled implicitly by the
"flex and slop" of having separate Document and DOMWindow pointers in
Frame. In this patch, these sublties are made explicit via
Document::takeDOMWindowFrom, which explicitly transfers the DOMWindow
(as well as ASSERTs that all the relevant objects exist in a sensible
constellation).

  • WebCore.exp.in:
    • These functions are no longer exported because they're inline.
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell):

  • bindings/js/ScriptController.h:

(ScriptController):

  • clearWindowShell now explicitly takes the new DOMWindow that will be pointed to by the WindowShell. Previously, clearWindowShell would implicitly create the new DOMWindow by accessing Frame::domWindow (which used to lazily create the DOMWindow).
  • bindings/v8/BindingState.cpp:

(WebCore::currentDocument):

  • bindings/v8/BindingState.h:

(WebCore):

  • currentDocument provides a directly path from the current v8::Context to the Document (by way of DOMWindow). Previously, code transited via the Frame using currentFrame.
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • Mirror JSC changes to clearWindowShell.
  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext):

  • Update getScriptExecutionContext to transit directly from the DOMWindow to the Document rather than detouring via the Frame.
  • dom/ContextDestructionObserver.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore):
(WebCore::ContextDestructionObserver::observeContext):

  • dom/ContextDestructionObserver.h:

(ContextDestructionObserver):

  • When we transfer a DOMWindow from one Document to another, we need to update the Document pointer in the DOMWindow to point to the new Document. The DOMWindow holds the Document pointer via ContextDestructionObserver, so this patch teaches ContextDestructionObserver how to change which ScriptExecutionContext it is observing. This code mirrors similar code in FrameDestructionObserver.
  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):
(WebCore::Document::createDOMWindow):

  • createDOMWindow now explicitly creates the DOMWindow. Previously, we created the DOMWindow implicitly in Frame::domWindow when it was first accessed.

(WebCore::Document::takeDOMWindowFrom):

  • takeDOMWindowFrom explicitly transfers the DOMWindow from one Document to another. The main benefit of this function is the ASSERTs that ensure that the Document, DOMWindow, and Frame all point to each other the correct configuration.

(WebCore::Document::didUpdateSecurityOrigin):

  • We no longer need to keep the SecurityOrigin pointer in DOMWindow in sync with the Document because DOMWindow no longer has a SecurityOrigin object.
  • dom/Document.h:

(Document):
(WebCore::Document::domWindow):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::destroy):

  • history/CachedFrame.h:

(CachedFrameBase):

  • Previously, CachedFrame held the Document and the DOMWindow with separate pointers. Now, the CachedFrame holds the DOMWnidow via the Document, which makes adding and removing Documents from the PageCache simpler because we don't need to keep the Frame's DOMWindow pointer synchronized.
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • begin now explicitly creates the DOMWindow and transfers DOMWindow when performing a "secure transition." Previously, both of these processes were handled implicitly: the DOMWindow was created implicitly by Frame::domWindow, and the DOMWindow was reused during navigation by not clearing Frame::m_domWindow.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::cancelAndClear):
(WebCore::FrameLoader::clear):

  • These functions now pass the new Document so that we have access to the new DOMWindow in clearDOMWindowShell.

(WebCore::FrameLoader::setOpener):

  • We no longer need to keep the DOMWindow's SecurityOrigin in sync with the Document's SecurityOrigin because DOMWindow no longer has a duplicate SecurityOrigin pointer.

(WebCore::FrameLoader::open):

  • We no longer need to keep the Frame::m_domWindow in sync with the Document because the Document carries its own DOMWindow.
  • loader/FrameLoader.h:

(FrameLoader):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):

  • DOMWindow now uses Document as its primary context object. In a future patch, we should remove the FrameDestructionObserver base class and instead access the frame via DOMWindow::document().

(WebCore::DOMWindow::didSecureTransitionTo):

  • Notify the DOMWindow that it is now associated with a new Document.

(WebCore::DOMWindow::scriptExecutionContext):
(WebCore::DOMWindow::document):
(WebCore::DOMWindow::securityOrigin):

  • These functions now retrieve the Document directly rather than transiting via the Frame.
  • page/DOMWindow.h:

(WebCore::DOMWindow::create):
(DOMWindow):

  • page/Frame.cpp:

(WebCore::Frame::setDocument):

  • Add more ASSERTs that the Document and its DOMWindow are properly wired up to this Frame.

(WebCore::Frame::domWindow):

  • Rather than lazily creating the DOMWindow, this function now just accesses the already-created DOMWindow on Document. Eventually, all callers should retreive the DOMWindow from the Document directly.
  • page/Frame.h:

(WebCore::Frame::existingDOMWindow):

  • The DOMWindow always exists, so there is no distinction between domWindow() and existingDOMWindow().
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

  • Previously, open would exit early if it was unable to find its ScriptExecutionContext (e.g., if the ScriptExecutionContext was inactive). Now we can always locate the ScriptExecutionContext and so we need to test whether the ScriptExecutionContext is still attached to the Page before accessing Settings. Tests verify that the platform-visible behaviors of XMLHttpRequest are unchanged, even for XMLHttpRequest constructors associated with inactive Documents.
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

  • Make it explicit that XSLT re-uses the DOMWindow from the source Document in the transformed Document.

LayoutTests:

  • fast/dom/Window/timer-null-script-execution-context.html:
    • This test was assuming that we'd throw an exception when we failed to find the script execution context. Now that we are always able to find the script execution context, we never throw that exception, even after GC. As far as I can tell, the original intent of the test was to make sure we don't crash in that case, which of course we don't.
  • fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt:
    • Remove warning message about not being able to find the script execution context. We can now always find the script execution context.
  • http/tests/security/MessagePort/event-listener-context-expected.txt:
  • http/tests/security/MessagePort/event-listener-context.html:
    • This test is attempting to check that MessagePorts behave in a reasonable way when created in inactive documents. The test relies on us throwing an exception in the inactive case because we're unable to find the script execution context. We are now able to find the script execution context (as above), so we no longer throw the exception. It's not clear whether this test is valuable any more, but I've converted it to be a test that we don't crash in this situation.
  • platform/chromium/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
    • Remove platform-specific result as it now matches the cross-platform result.
12:45 PM Changeset in webkit [125591] by leviw@chromium.org
  • 4 edits
    2 adds in trunk

Accumulating LayoutUnits with floats for determining block preferred width can lead to wrapping
​https://bugs.webkit.org/show_bug.cgi?id=93513

Reviewed by Eric Seidel.

Source/WebCore:

Sub-pixel values from floats are subject to small losses in precision when accumulated with
floating point values, as we do in RenderBlock. This patch adds a new method to FractionalLayoutUnit --
ceilToFloat -- which guarantees us a floating point value at least as big as our original LayoutUnit
value, and uses it along with ceiledLayoutUnit to avoid underprovisioning RenderBlock's preferred
widths due to lost precision.

Test: fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::ceilToFloat): Returns a float value the same or larger than the
FractionalLayoutUnit value.
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::epsilon): Now returns 0 when sub-pixel is disabled.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat): Adding a LayoutUnit::epsilon fudge factor
for fitting floats. This is probably necessary due to precision being lost elsewhere.
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths): Ensure no precision is lost due to conversion
when accumulating our min/max width with floats.

LayoutTests:

Ensuring floats with sub-pixel values don't unnecessarily wrap.

  • fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt: Added.
  • fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html: Added.
12:38 PM Changeset in webkit [125590] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

Fullscreen/normal volume sliders don't stay in sync
​https://bugs.webkit.org/show_bug.cgi?id=93867

Reviewed by Eric Carlson.

Source/WebCore:

Change the full screen volume slider, if present, when the media element's volume
changes.

Test: media/video-controls-fullscreen-volume.html

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::changedVolume):

LayoutTests:

New test checking that volume changes in the media element are reflected in the full
screen volume slider.

  • media/video-controls-fullscreen-volume-expected.txt: Added.
  • media/video-controls-fullscreen-volume.html: Added.
  • platform/chromium/TestExpectations: Skip this test on chromium.
12:17 PM Changeset in webkit [125589] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused yyparse method in CSSParser
​https://bugs.webkit.org/show_bug.cgi?id=93986

Patch by Olivier Blin <Olivier Blin> on 2012-08-14
Reviewed by Darin Adler.

This method is unused and not even declared.

No new tests, it just removes unused code.

  • css/CSSParser.h:
12:02 PM Changeset in webkit [125588] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedContentEditableElement
​https://bugs.webkit.org/show_bug.cgi?id=93992

Reviewed by Antonio Gomes.

Use form control helper functions to determine the editable state
of the input field.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):

11:54 AM Changeset in webkit [125587] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/regex/unicodeCaseInsensitive.html expectation as crashing
​https://bugs.webkit.org/show_bug.cgi?id=94010

Unreviewed gardening. Update expectations.

  • platform/chromium/TestExpectations:
11:53 AM Changeset in webkit [125586] by robert@webkit.org
  • 6 edits in trunk/LayoutTests

Update Test Expectations after r125578

Unreviewed gardening.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
11:28 AM Changeset in webkit [125585] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
​https://bugs.webkit.org/show_bug.cgi?id=93988

Reviewed by Antonio Gomes.

Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

11:23 AM Changeset in webkit [125584] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix use of endsWith to use string instead of char.
​https://bugs.webkit.org/show_bug.cgi?id=93994

Reviewed by Antonio Gomes.

Regex comparison should use string instead of char comparison.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementPatternMatches):

10:58 AM Changeset in webkit [125583] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile.list.am into the build
​https://bugs.webkit.org/show_bug.cgi?id=90696

Reviewed by Philippe Normand.

Include all files in the Autotools build that are currently guarded by ENABLE_* guards in
the WebCore GNUmakefile.list.am, regardless of the feature being enabled. Compilation should
rely on proper use of guards inside source files and preprocessor work to keep the disabled
features out.

The only exception left is the ENABLE_WEBGL guard that includes the ANGLE into compilation
only if WebGL feature is enabled.

No new tests - no new functionality.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • bindings/gobject/GNUmakefile.am: Add StorageInfo to the DOM bindings, despite

the feature being currently disabled.

10:58 AM Changeset in webkit [125582] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark inspector/debugger tests as flaky timeout on Win7
​https://bugs.webkit.org/show_bug.cgi?id=94002

Unreviewed gardening. Update expectations.

  • platform/chromium/TestExpectations:
10:55 AM Changeset in webkit [125581] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebKit/chromium

[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
​https://bugs.webkit.org/show_bug.cgi?id=93108

Patch by Iain Merrick <​husky@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange,
and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is
used by selectRange.

The test uses sample files that contain selected text on load. The test uses
WebViewImpl::selectionBounds to get the coordinates, deselects all, then
calls WebFrameImpl::selectRange to attempt to reselect the same text.

Four cases are tested:

  • the basic case
  • the case where the selected text is offscreen due to a scroll
  • the case where the selected text is in an iframe
  • the case where the selected text is in an editable element
  • tests/WebFrameTest.cpp:
  • tests/data/select_range_basic.html: Added.
  • tests/data/select_range_editable.html: Added.
  • tests/data/select_range_iframe.html: Added.
  • tests/data/select_range_scroll.html: Added.
10:51 AM Changeset in webkit [125580] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Plumb through EXT_debug_marker entry points
​https://bugs.webkit.org/show_bug.cgi?id=93860

Patch by Gregg Tavares <​gman@google.com> on 2012-08-14
Reviewed by Kenneth Russell.

Source/Platform:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT are
all entry points exposed by the OpenGL ES EXT_debug_marker
extension.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::insertEventMarkerEXT):
(WebKit::WebGraphicsContext3D::pushGroupMarkerEXT):
(WebKit::WebGraphicsContext3D::popGroupMarkerEXT):

Source/WebCore:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT,
are all entry points exposed by the OpenGL ES
EXT_debug_marker extension

No new tests as no new functionality exposed to web.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

  • platform/chromium/support/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DChromium::pushGroupMarkerEXT):
(WebCore::Extensions3DChromium::popGroupMarkerEXT):

  • platform/graphics/Extensions3D.h:

(Extensions3D):

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGL::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGL::popGroupMarkerEXT):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGLES::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGLES::popGroupMarkerEXT):

  • platform/graphics/opengl/Extensions3DOpenGLES.h:

(Extensions3DOpenGLES):

10:46 AM Changeset in webkit [125579] by shawnsingh@chromium.org
  • 2 edits in branches/chromium/1229/Source

Merge 125486 - [chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
​https://bugs.webkit.org/show_bug.cgi?id=93795

Reviewed by Adrienne Walker.

Source/WebCore:

If a renderSurface is created by a layer that had zero
area (empty) but non-zero bounds (either width or height was
non-zero), then one translation transform was accidentally being
skipped, causing the renderSurface drawTransform to be incorrect.
The fix is simply to move that transform outside of the
if-statement so it is not skipped.

Unit test added:

CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer()

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

TBR=​shawnsingh@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10829322

10:36 AM Changeset in webkit [125578] by robert@webkit.org
  • 14 edits
    1 move
    25 adds
    27 deletes in trunk

CSS 2.1 failure: Word-spacing affects each space and non-breaking space
​https://bugs.webkit.org/show_bug.cgi?id=89826

Reviewed by Eric Seidel.

Source/WebCore:

Add word spacing to consecutive spaces in a run per ​http://www.w3.org/TR/CSS21/text.html#spacing-props.

Test: fast/css/word-spacing-characters.html

fast/css/word-spacing-characters-complex-text.html
fast/css/word-spacing-characters-linebreak.html
css2.1/20110323/word-spacing-characters-002.htm
css2.1/20110323/word-spacing-characters-003.htm
css2.1/20110323/word-spacing-remove-space-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm
css2.1/20110323/c541-word-sp-001.htm
css2.1/20110323/c541-word-sp-000.htm

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): All spaces (ordinary space or &nbsp;) get word-spacing added, even

if they are consecutive.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use

m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
find it specified anywhere.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:

(WebCore::HarfBuzzShaperBase::isCodepointSpace):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html

LayoutTests:

  • css2.1/20110323/c541-word-sp-000-expected.html: Added.
  • css2.1/20110323/c541-word-sp-000.htm: Renamed from LayoutTests/css2.1/t1604-c541-word-sp-00-b-a.html.
  • css2.1/20110323/c541-word-sp-001-expected.html: Added.
  • css2.1/20110323/c541-word-sp-001.htm: Added. Replaces t1604-c541-word-sp-01-b-a.html below.
  • css2.1/20110323/word-spacing-characters-002-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-002.htm: Added.
  • css2.1/20110323/word-spacing-characters-003-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-003.htm: Added. These passed already.
  • css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-001.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-002.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-003.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-004.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-005.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-006.htm: Added. These 6 tests are fixed by this patch.
  • css2.1/t1604-c541-word-sp-01-b-a.html: Removed. Per ​http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is now invalid and has been replaced by c541-word-sp-001.htm above.
  • fast/css/word-spacing-characters-complex-text-expected.html: Added.
  • fast/css/word-spacing-characters-complex-text.html: Added. This is a complex text version of word-spacing-characters-001.htm
  • fast/css/word-spacing-characters-expected.html: Added.
  • fast/css/word-spacing-characters.html: Added. The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case. This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced with word-spacing-characters-001.htm from the css test suite when ​https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
  • fast/css/word-spacing-linebreak-expected.html: Added.
  • fast/css/word-spacing-linebreak.html: Added.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-linux/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/win/Skipped:
10:25 AM Changeset in webkit [125577] by piman@chromium.org
  • 11 edits in trunk/Source

[chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProxy::beginFrameCompleteOnImplThread
​https://bugs.webkit.org/show_bug.cgi?id=93684

Reviewed by James Robinson.

This keeps track of whether we're between the beginFrame post and the
commit when releaseContentsTextures comes, and if that is the case, we
prune the texture uploads, keep the "textures purged" flag on and kick a
new commit.

Added CCLayerTreeHostTestEvictTextures test.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::beginFramePosted):
(WebCore):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::contentsTexturesPurged):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastBeginFrame):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h:

(CCTextureUpdateController):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:

(WebCore::CCTextureUpdateQueue::clearUploads):
(WebCore):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.h:

(CCTextureUpdateQueue):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

10:19 AM Changeset in webkit [125576] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

[BlackBerry] Pass URL String's 8-bit buffer directly to platform layer when possible
​https://bugs.webkit.org/show_bug.cgi?id=93861

Patch by Yong Li <​yoli@rim.com> on 2012-08-14
Reviewed by Rob Buis.

PR# 187605.
URL strings and HTTP header strings usually use 8-bit buffers internally. We can
just pass the buffers to platform calls when only Latin1 strings are needed.

  • platform/blackberry/ReadOnlyLatin1String.h: Added.

(WebCore):
(ReadOnlyLatin1String): A utility class that uses either WTF::CString or WTF::String's 8-bit buffer.
(WebCore::ReadOnlyLatin1String::ReadOnlyLatin1String): Can only be constructed with WTF::String for now.
(WebCore::ReadOnlyLatin1String::data):
(WebCore::ReadOnlyLatin1String::length):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

10:16 AM Changeset in webkit [125575] by commit-queue@webkit.org
  • 7 edits
    1 delete in trunk

Fix LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html
​https://bugs.webkit.org/show_bug.cgi?id=92974

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Replace space characters by U+0020 SPACE characters in
CanvasRenderingContext2D::drawTextInternal() in order to
comply with the HTML Canvas 2D Context specification:

No new tests, already tested by canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::replaceCharacterInString):
(WebCore):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

Unskip canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html for
all the ports now that space characters are correctly replaced in
the text passed to fillText() and strokeText().

  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Removed.
  • platform/qt/Skipped:
10:09 AM Changeset in webkit [125574] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=93895

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <​zhajiang@rim.com>

PR: 188232
When adjusting block zoom node, don't choose a node if the width of the
node size is very close to the width of the actual visible size as
block zoom can do nothing on such kind of node. This condition is more
restrictive than the one based on area and can bail out early.
In this way, we can get a better node for double-tap zoom.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):

  • Api/WebPage_p.h:

(WebPagePrivate):

10:01 AM Changeset in webkit [125573] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Change the call to setUserScalable to use the setting.
​https://bugs.webkit.org/show_bug.cgi?id=93974

Reviewed by Rob Buis.

We should be using the WebSetting and not the current value of m_userScalable.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

9:52 AM Changeset in webkit [125572] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding image failure expectation for fast/css-generated-content/quotes-lang.html.

  • platform/gtk/TestExpectations:
9:47 AM Changeset in webkit [125571] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updated the GTK WK2 Skipped file with well-known
failures in the WK2 bot.

  • platform/gtk-wk2/Skipped:
9:36 AM Changeset in webkit [125570] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Avoid assertion failure in App Cache.
​https://bugs.webkit.org/show_bug.cgi?id=93926

Reviewed by Rob Buis.

Short-circuit data url decoding if we know it's not a data URL to
avoid an assertion failure in debug mode. No functional change.

No new tests since this is just a debug mode assertion failure.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

9:12 AM Changeset in webkit [125569] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not warn when the default theme is not found
​https://bugs.webkit.org/show_bug.cgi?id=93968

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Even if you are using a custom theme, we always try to load first the
theme at the default path (that may or may not exist). In the case it
doesn't exist and you have a custom theme, we were always getting a
misleading error message.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::createEdje):

9:06 AM Changeset in webkit [125568] by jsbell@chromium.org
  • 26 edits in trunk/Source

IndexedDB: Pass cursor continue results back in callback
​https://bugs.webkit.org/show_bug.cgi?id=92278

Reviewed by Tony Chang.

Supply the updated cursor key/primaryKey/value in the success callback,
rather than forcing the callee to make three calls into the back end to
fetch them. Callbacks onSuccess(cursor) and onSuccessWithContinuation()
are given the three new payload parameters (and the latter is renamed.)

Source/WebCore:

No new tests - no behavioral changes.

  • Modules/indexeddb/IDBCallbacks.h: Updated callbacks.

(IDBCallbacks):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::setValueReady): Takes values rather than fetching them.

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp: Delete accessors.

(WebCore::IDBCursorBackendImpl::advanceInternal): Pass along updated cursor state.
(WebCore::IDBCursorBackendImpl::continueFunctionInternal): Ditto.

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(IDBCursorBackendImpl): Delete accessors from interface...
(WebCore::IDBCursorBackendImpl::key): ...but keep them for use within back-end.
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):

  • Modules/indexeddb/IDBCursorBackendInterface.h: Delete accessors.
  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal): Pass along new cursor state.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::openCursorInternal): Ditto.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::setResultCursor): Stash updated cursor state until dispatch.
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent): Update cursor with new state.

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • inspector/InspectorIndexedDBAgent.cpp: Update iteration code to use new callbacks.

(WebCore):

Source/WebKit/chromium:

  • public/WebIDBCallbacks.h:

(WebIDBCallbacks):
(WebKit::WebIDBCallbacks::onSuccess): Replace with no-op stub.
(WebKit::WebIDBCallbacks::onSuccessWithContinuation): Ditto.

  • public/WebIDBCursor.h:

(WebIDBCursor): Methods can be removed once Chromium is cleaned up.

  • src/IDBCallbacksProxy.cpp: Updated callbacks.

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit):

  • src/IDBCallbacksProxy.h: Updated callbacks.

(IDBCallbacksProxy):

  • src/IDBCursorBackendProxy.cpp: Remove back end accessors.
  • src/IDBCursorBackendProxy.h:

(IDBCursorBackendProxy):

  • src/WebIDBCallbacksImpl.cpp: Updated callbacks.

(WebKit::WebIDBCallbacksImpl::onSuccess):

  • src/WebIDBCallbacksImpl.h: Updated callbacks.

(WebIDBCallbacksImpl):

  • src/WebIDBCursorImpl.cpp: Remove back end accessors.
  • src/WebIDBCursorImpl.h: Remove back end accessors.

(WebIDBCursorImpl):

  • tests/IDBAbortOnCorruptTest.cpp: Update test stubs.

(WebCore::MockIDBCallbacks::onSuccess):

  • tests/IDBDatabaseBackendTest.cpp: Ditto.
  • tests/IDBRequestTest.cpp: Ditto.
8:53 AM Changeset in webkit [125567] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
​https://bugs.webkit.org/show_bug.cgi?id=93967

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-08-14

  • platform/efl/TestExpectations:
  • platform/efl/fast/css-generated-content/quotes-lang-expected.png: Added.
8:48 AM Changeset in webkit [125566] by fmalita@chromium.org
  • 45 edits
    1 copy
    1 move
    1 add
    8 deletes in trunk/LayoutTests

[Chromium] Rebaseline filter results after 125462
​https://bugs.webkit.org/show_bug.cgi?id=93969

Unreviewed gardening.

  • platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
  • platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/add-filter-rendering-expected.png:
  • platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-external-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac/css3/filters/filtered-inline-expected.png:
  • platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium-mac/css3/filters/nested-filters-expected.png:
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png:
  • platform/chromium-mac/svg/filters/color-interpolation-filters-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png.
  • platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
  • platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
  • platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
  • platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-win/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-win/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-win/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-win/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-expected.png:
  • platform/chromium-win/svg/filters/color-interpolation-filters-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/svg/filters/color-interpolation-filters-expected.txt: Removed.
  • platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Removed.
  • svg/filters/color-interpolation-filters-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt.
8:09 AM Changeset in webkit [125565] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Some callback of Select onchange doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=93944

Reviewed by George Staikos.

The Selection element is implemented with PagePopup, an HTML-based WebView with
some Javascripts to make the UI of the select and option lists; The selection
change is initiated from the javascript code in the Select Webview, and back to
the native code of SelectPopupClient, which now in turn dispatches
FormControlChangeEvent to the select element directly, and that causes the
javascript callback been invoked in the same cycle as the javascript in the
Popup View, and causes some Javascript Context problem.

The solution is to send the FormControlChangeEvent asynchronously by a timer,
when the JavaScript in the Popup view finishes execution, we then send the
FormControlChangeEvent to the select element in the content page, that avoids
the concurrent Javascript context issue.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::SelectPopupClient):
(WebCore::SelectPopupClient::setValueAndClosePopup):
(WebCore):
(WebCore::SelectPopupClient::notifySelectionChange):

  • WebCoreSupport/SelectPopupClient.h:

(SelectPopupClient):

7:52 AM Changeset in webkit [125564] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

Update INdT build bot to Mountain Lion.
​https://bugs.webkit.org/show_bug.cgi?id=93963

Reviewed by Csaba Osztrogonác.

We updated the machine as well as the OS as the Qt port is now running
on top of Qt5.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
7:33 AM Changeset in webkit [125563] by commit-queue@webkit.org
  • 17 edits
    4 adds in trunk/Source

[BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
​https://bugs.webkit.org/show_bug.cgi?id=93614

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

We used to set up resource sharing between the compositing thread
context and the Canvas and WebGL contexts, and use glCopyTexImage2D to
get a copy of the framebuffer to use as front buffer for compositing
purposes.

Now we instead create an EGLImage and blit the Canvas/WebGL output to
it. The compositing thread creates a texture from the EGLImage in order
to composite the output.

Source/WebCore:

Created a new EGLImageLayerWebKitThread base class that handles the
EGLImage and does the blitting. CanvasLayerWebKitThread and
WebGLLayerWebKitThread now inherit from this new base class.

However, we need to be careful to restore state after the blit because
it's done using the Canvas/WebGL context.

The BlackBerry implementation of GraphicsContext3D::prepareTexture()
was changed to no longer call glCopyTexImage, and
GraphicsContext3D::platformLayer() now returns the target texture
directly.

Reviewed internally by Filip Spacek.

PR 188472

No change in behavior, new tests.

  • PlatformBlackBerry.cmake:
  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setDevice):
(WebCore::CanvasLayerWebKitThread::makeContextCurrent):
(WebCore::CanvasLayerWebKitThread::textureSize):
(WebCore):
(WebCore::CanvasLayerWebKitThread::textureID):

  • platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(CanvasLayerWebKitThread):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp: Added.

(WebCore):
(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setImage):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h: Added.

(WebCore):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::create):
(WebCore::EGLImageLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::EGLImageLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::setNeedsDisplay):
(WebCore::EGLImageLayerWebKitThread::makeContextCurrent):
(WebCore::EGLImageLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createImageIfNeeded):
(WebCore::EGLImageLayerWebKitThread::createShaderIfNeeded):
(WebCore::EGLImageLayerWebKitThread::drawTexture):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.h: Copied from Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.h.

(WebCore):
(EGLImageLayerWebKitThread):

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::platformTexture):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::releaseTextureResources):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::setClient):
(LayerCompositingThread):

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(LayerData):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::commitOnCompositingThread):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:

(WebCore::WebGLLayerWebKitThread::WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::WebGLLayerWebKitThread::makeContextCurrent):
(WebCore):
(WebCore::WebGLLayerWebKitThread::textureSize):
(WebCore::WebGLLayerWebKitThread::textureID):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.h:

(WebGLLayerWebKitThread):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore):
(WebCore::GraphicsContext3D::prepareTexture):

Source/WebKit/blackberry:

This allows us to turn off resource sharing, so the WebPageCompositor
no longer needs to pass the compositing thread context to the webkit
thread.

Reviewed internally by Filip Spacek.

PR 188472

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):

  • Api/WebPage_p.h:

(WebPagePrivate):

7:31 AM Changeset in webkit [125562] by tkent@chromium.org
  • 6 edits
    1 add in trunk/LayoutTests

[Chromium] Update expectation files for fast/forms/date/calendar-picker-appearance.html

  • platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
  • platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:
7:26 AM Changeset in webkit [125561] by peter@chromium.org
  • 6 edits in trunk

[Chromium] Remove unneeded build logic for Android
​https://bugs.webkit.org/show_bug.cgi?id=93962

Reviewed by Dimitri Glazkov.

The Android SDK and NDK have been checked in to the Chromium tree, which
allows WebKit to leverage those as well. They will already be pulled in
through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
environment variable, the envsetup.sh will set the project files up
appropriately for us.

Source/WebKit/chromium:

  • DEPS:

Tools:

  • Scripts/webkitdirs.pm:
7:05 AM Changeset in webkit [125560] by commit-queue@webkit.org
  • 2 edits
    4 deletes in trunk/LayoutTests

REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=93910

Unreviewed gardening.

Removed wrong and duplicated expectations. Mac port should use the
global expectations since this test is now passing.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-08-14

  • platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.
7:00 AM Changeset in webkit [125559] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
6:53 AM Changeset in webkit [125558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Texture cache must adapt to HashMap changes
​https://bugs.webkit.org/show_bug.cgi?id=93955

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):

6:37 AM Changeset in webkit [125557] by allan.jensen@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed, Qt gardening

Unmark tests that has been passing since they were fixed generally in r125371.

  • platform/qt/TestExpectations:
6:30 AM Changeset in webkit [125556] by allan.jensen@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for Qt, rebaselining marked test from r125167.

Changelog and commit mixed with entry below.

  • platform/qt/TestExpectations:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
6:27 AM Changeset in webkit [125555] by allan.jensen@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for Qt, rebaselining marked test from r125167.

  • platform/qt/TestExpectations:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
6:16 AM Changeset in webkit [125554] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] LayerCompositingThread.h doesn't compile
​https://bugs.webkit.org/show_bug.cgi?id=93956

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

I forgot to upstream this local change.

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerOverride::setBounds):
(WebCore::LayerOverride::setOpacity):

5:59 AM WebInspector edited by doris.greys@gmail.com
(diff)
5:52 AM Changeset in webkit [125553] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] QNX build fails due to reference to MADV_FREE_REUSE and MADV_FREE_REUSABLE
​https://bugs.webkit.org/show_bug.cgi?id=93843

Patch by Milian Wolff <​milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

QNX does not implement MADV_FREE_REUSE nor MADV_FREE_REUSABLE.
The Blackberry port already sets the define to use the system
malloc, which is now also done for QNX in general.

  • wtf/Platform.h:
5:39 AM Changeset in webkit [125552] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[BlackBerry] LayerAnimation is not immutable, which makes dereferencing an expensive operation
​https://bugs.webkit.org/show_bug.cgi?id=93946

Patch by Ed Baker <​edbaker@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

Make LayerAnimation immutable so it can be dereferenced from the main
WebKit thread without having to dispatch to the compositing thread,
which is an expensive operation.

TransformOperation and TimingFunction need to be made thread safe as
they are referenced in LayerAnimation, but that effort is being tracked
by a separate bug, #86483.

Reviewed internally by Arvid Nilsson.

No change in behavior, no new tests.

  • platform/graphics/blackberry/LayerAnimation.h:

(WebCore::LayerAnimation::name):
(LayerAnimation):
(WebCore::LayerAnimation::LayerAnimation):
(WebCore::LayerAnimation::setName):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::~LayerWebKitThread):

5:34 AM Changeset in webkit [125551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsLayerBlackBerry::willBeDestroyed() must call superclass implementation
​https://bugs.webkit.org/show_bug.cgi?id=93947

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):

5:10 AM Changeset in webkit [125550] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Remove custom JSC bindings from ConvolverNode.idl
​https://bugs.webkit.org/show_bug.cgi?id=93952

Patch by Vineet Chaudhary <Vineet> on 2012-08-14
Reviewed by Kentaro Hara.

We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.

No new tests. No behavioural changes.
All tests under webaudio/* should behave same.

  • GNUmakefile.list.am: Removed JSConvolverNodeCustom.cpp from builds.
  • Modules/webaudio/ConvolverNode.idl: Removed [JSCustomSetter].
  • UseJSC.cmake: Removed JSConvolverNodeCustom.cpp from builds.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto
  • bindings/js/JSConvolverNodeCustom.cpp: Removed.
4:56 AM Changeset in webkit [125549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix failing tst_QWebPage::findText unit test
​https://bugs.webkit.org/show_bug.cgi?id=93951

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Adjust the expected text, as the HTML editing code improved to avoid unnecessary tags.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::findText):

4:52 AM Changeset in webkit [125548] by pfeldman@chromium.org
  • 4 edits
    1 add in trunk

Web Inspector: add external test runner for running inspector front-end tests with no TestRunner infrastructure.
​https://bugs.webkit.org/show_bug.cgi?id=93833

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added mock test runner that allows running front-end layout tests.
InspectorFrontendAPI can now dispatch whatever it receives from its embedder (opener).

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.evaluateForTest):
(InspectorFrontendAPI.dispatch):
(InspectorFrontendAPI.loadCompleted):
(.onMessageFromOpener):

LayoutTests:

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resources/test-runner.html: Added.
4:47 AM Changeset in webkit [125547] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Incomplete repaint of link underline
​https://bugs.webkit.org/show_bug.cgi?id=66034

Reviewed by Kenneth Rohde Christiansen.

When trying to point a line of width 30, we end up painting on of width 31, because Qt
interprets the line as end-inclusive. So adjust for end-include/exclusive difference
before requesting the draw from Qt.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLine):

4:46 AM Changeset in webkit [125546] by sergio@webkit.org
  • 2 edits in trunk/Tools

[WK2] [GTK] Plugin tests failing in WK2 bot
​https://bugs.webkit.org/show_bug.cgi?id=93954

Reviewed by Carlos Garcia Campos.

Plugin tests are failing in the WK2 bot because we aren't exporting
the Netscape plugin when creating the product archive.

  • BuildSlaveSupport/built-product-archive: added TestNetscapePlugin

to the list of directories to export.
(archiveBuiltProduct):

4:43 AM Changeset in webkit [125545] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix test calendar-picker-appearance.html after r125507

Unreviewed.

  • fast/forms/date/calendar-picker-appearance.html: Use resize event instead of transitionEnd.
4:42 AM Changeset in webkit [125544] by commit-queue@webkit.org
  • 2 edits in trunk

[Qt] QtWebKit linking fails for QNX cross build
​https://bugs.webkit.org/show_bug.cgi?id=93460

Patch by Milian Wolff <​milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

The GCC 4.4.2 used by the QNX BBNDK 2.0.1 fails to link QtWebKit.
Apparently it does not properly support the linker invokation using
-Wl,-whole-archive -l... -Wl,-no-whole-archive
yielding a "cc: no files to process" error. This patch works around
this issue by adding an empty dummy file (and thus object file) to
the linking stage.

  • Source/api.pri:
4:39 AM Changeset in webkit [125543] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash in http/tests/plugins/plugin-document-has-focus
​https://bugs.webkit.org/show_bug.cgi?id=93949

Patch by Mike West <​mkwst@chromium.org> on 2012-08-14
Reviewed by Jochen Eisinger.

Covered by http/tests/plugins/plugin-document-has-focus.html. If that
doesn't crash, we're good!

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::pluginIsLoadable):

Check the PluginDocument's ownerElement before derefing.

4:32 AM Changeset in webkit [125542] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix apk generation for the Android platform
​https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix (step 2).

The path from webkit_unit_tests isn't robust enough. Use the same
convention as the Chromium side, i.e. walk up from the ant_build_out path.
One-line Android-only gyp change.

  • WebKitUnitTests.gyp:
4:28 AM Changeset in webkit [125541] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Rename functions in the ARM port of DFG-JIT for better code readability.
​https://bugs.webkit.org/show_bug.cgi?id=93609

Patch by Gabor Ballabas <​gaborb@inf.u-szeged.hu> on 2012-08-14
Reviewed by Zoltan Herczeg.

Rename functions in the ARM port of DFG-JIT for better code
readability, and for following the WebKit coding style
wherever it is possible.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::genInt):
(JSC::ARMAssembler::getImm):
(JSC::ARMAssembler::moveImm):
(JSC::ARMAssembler::encodeComplexImm):
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::baseIndexTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::baseIndexTransferFloat):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::bitAnd):
(JSC::ARMAssembler::bitAnds):
(JSC::ARMAssembler::eor):
(JSC::ARMAssembler::eors):
(JSC::ARMAssembler::sub):
(JSC::ARMAssembler::subs):
(JSC::ARMAssembler::rsb):
(JSC::ARMAssembler::rsbs):
(JSC::ARMAssembler::add):
(JSC::ARMAssembler::adds):
(JSC::ARMAssembler::adc):
(JSC::ARMAssembler::adcs):
(JSC::ARMAssembler::sbc):
(JSC::ARMAssembler::sbcs):
(JSC::ARMAssembler::rsc):
(JSC::ARMAssembler::rscs):
(JSC::ARMAssembler::tst):
(JSC::ARMAssembler::teq):
(JSC::ARMAssembler::cmp):
(JSC::ARMAssembler::cmn):
(JSC::ARMAssembler::orr):
(JSC::ARMAssembler::orrs):
(JSC::ARMAssembler::mov):
(JSC::ARMAssembler::movw):
(JSC::ARMAssembler::movt):
(JSC::ARMAssembler::movs):
(JSC::ARMAssembler::bic):
(JSC::ARMAssembler::bics):
(JSC::ARMAssembler::mvn):
(JSC::ARMAssembler::mvns):
(JSC::ARMAssembler::mul):
(JSC::ARMAssembler::muls):
(JSC::ARMAssembler::mull):
(JSC::ARMAssembler::vmov_f64):
(JSC::ARMAssembler::vadd_f64):
(JSC::ARMAssembler::vdiv_f64):
(JSC::ARMAssembler::vsub_f64):
(JSC::ARMAssembler::vmul_f64):
(JSC::ARMAssembler::vcmp_f64):
(JSC::ARMAssembler::vsqrt_f64):
(JSC::ARMAssembler::vabs_f64):
(JSC::ARMAssembler::vneg_f64):
(JSC::ARMAssembler::ldrImmediate):
(JSC::ARMAssembler::ldrUniqueImmediate):
(JSC::ARMAssembler::dtrUp):
(JSC::ARMAssembler::dtrUpRegister):
(JSC::ARMAssembler::dtrDown):
(JSC::ARMAssembler::dtrDownRegister):
(JSC::ARMAssembler::halfDtrUp):
(JSC::ARMAssembler::halfDtrUpRegister):
(JSC::ARMAssembler::halfDtrDown):
(JSC::ARMAssembler::halfDtrDownRegister):
(JSC::ARMAssembler::doubleDtrUp):
(JSC::ARMAssembler::doubleDtrDown):
(JSC::ARMAssembler::push):
(JSC::ARMAssembler::pop):
(JSC::ARMAssembler::poke):
(JSC::ARMAssembler::peek):
(JSC::ARMAssembler::vmov_vfp64):
(JSC::ARMAssembler::vmov_arm64):
(JSC::ARMAssembler::vmov_vfp32):
(JSC::ARMAssembler::vmov_arm32):
(JSC::ARMAssembler::vcvt_f64_s32):
(JSC::ARMAssembler::vcvt_s32_f64):
(JSC::ARMAssembler::vcvt_u32_f64):
(JSC::ARMAssembler::vcvt_f64_f32):
(JSC::ARMAssembler::vcvt_f32_f64):
(JSC::ARMAssembler::clz):
(JSC::ARMAssembler::lslRegister):
(JSC::ARMAssembler::lsrRegister):
(JSC::ARMAssembler::asrRegister):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::vmov):

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::countLeadingZeros32):
(JSC::MacroAssemblerARM::convertibleLoadPtr):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::pop):
(JSC::MacroAssemblerARM::push):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::relativeTableJump):
(JSC::MacroAssemblerARM::moveWithPatch):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::moveDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::absDouble):
(JSC::MacroAssemblerARM::negateDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::convertFloatToDouble):
(JSC::MacroAssemblerARM::convertDoubleToFloat):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerARM::truncateDoubleToInt32):
(JSC::MacroAssemblerARM::truncateDoubleToUint32):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):

4:22 AM Changeset in webkit [125540] by allan.jensen@nokia.com
  • 7 edits
    2 adds in trunk/Source/WebKit2

[Qt] UpdateAtlas is wasting memory
​https://bugs.webkit.org/show_bug.cgi?id=93606

Reviewed by Jocelyn Turcotte.

Imported and QAreaAllocator from Qt3D and ported it to WebCore style,
and use this new area allocator to replace old one from UpdateAtlas.

  • CMakeLists.txt:
  • Target.pri:
  • WebProcess/WebPage/AreaAllocator.cpp: Added.

(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):

  • WebProcess/WebPage/AreaAllocator.h: Added.

(WebCore::nextPowerOfTwo):
(AreaAllocator):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):
(GeneralAreaAllocator):
(Node):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::renderNextFrame):
(WebKit::LayerTreeCoordinator::beginContentUpdate):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/UpdateAtlas.h:

(UpdateAtlas):

4:14 AM Changeset in webkit [125539] by Csaba Osztrogonác
  • 1 edit
    108 deletes in trunk/LayoutTests

[Qt] Remove duplicated platform test expectations
​https://bugs.webkit.org/show_bug.cgi?id=93351

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-08-10
Reviewed by Csaba Osztrogonác.

Remove platform test expectations that are the same as the global
expectations.

  • platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/nested-composited-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/remove-iframe-crash-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/scroll-grandchild-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/become-simple-composited-reflection-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/empty-reflection-with-mask-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/remove-add-reflection-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/remove-reflection-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.
  • platform/qt-5.0-wk2/plugins/document-open-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceMotion/no-page-cache-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceMotion/optional-event-properties-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceMotion/window-property-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation/no-page-cache-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation/optional-event-properties-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation/window-property-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
  • platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Removed.
  • platform/qt/compositing/geometry/composited-in-columns-expected.txt: Removed.
  • platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/qt/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
  • platform/qt/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt: Removed.
  • platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
  • platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
  • platform/qt/editing/selection/hit-test-on-text-with-line-height-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Removed.
  • platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid01-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid03-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid04-expected.txt: Removed.
  • platform/qt/fast/box-shadow/box-shadow-radius-expected.txt: Removed.
  • platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt: Removed.
  • platform/qt/fast/css/font-face-descending-unicode-range-expected.txt: Removed.
  • platform/qt/fast/css/font-face-font-family-descriptor-expected.txt: Removed.
  • platform/qt/fast/css/font-family-pictograph-expected.txt: Removed.
  • platform/qt/fast/css/hsla-color-expected.txt: Removed.
  • platform/qt/fast/css/rgba-custom-text-expected.txt: Removed.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
  • platform/qt/fast/dom/icon-url-change-expected.txt: Removed.
  • platform/qt/fast/dom/icon-url-list-expected.txt: Removed.
  • platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Removed.
  • platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Removed.
  • platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
  • platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt: Removed.
  • platform/qt/fast/writing-mode/background-horizontal-bt-expected.txt: Removed.
  • platform/qt/fast/writing-mode/background-vertical-lr-expected.txt: Removed.
  • platform/qt/fast/writing-mode/background-vertical-rl-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
  • platform/qt/svg/custom/bug86119-expected.txt: Removed.
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/svg-features-expected.txt: Removed.
  • platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Removed.
  • platform/qt/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
  • platform/qt/svg/hixie/viewbox/002-expected.txt: Removed.
  • platform/qt/svg/hixie/viewbox/003-expected.txt: Removed.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Removed.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Removed.
  • platform/qt/svg/text/text-viewbox-rescale-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug26553-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
4:02 AM Changeset in webkit [125538] by peter@chromium.org
  • 5 edits in trunk

[Chromium] Fix apk generation for the Android platform
​https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix.

APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3:24 AM Changeset in webkit [125537] by commit-queue@webkit.org
  • 5 edits
    5 deletes in trunk/LayoutTests

Unreviewed, rolling out r125525.
​http://trac.webkit.org/changeset/125525
​https://bugs.webkit.org/show_bug.cgi?id=93950

rebaseline revert after r125526... (Requested by philn on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-14

  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
3:13 AM Changeset in webkit [125536] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fixed displaying buffering progress in the media control.
​https://bugs.webkit.org/show_bug.cgi?id=75681

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

It is required "rangeRect" instead of "rect" to display buffering
progress properly.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaSliderTrack):

3:12 AM Changeset in webkit [125535] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r125516.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-08-14
Reviewed by Csaba Osztrogonác.

Added baseline to fast/text/zero-font-size.html.

  • platform/qt/fast/text/zero-font-size-expected.txt:
2:56 AM Changeset in webkit [125534] by yosin@chromium.org
  • 1 edit
    2 copies in trunk/Source/WebCore

[Forms] Copy Source/WebCore/html/shadow/TextControlInnerElements.{cpp,h} to SpinButtonElement.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=93943

Reviewed by Kent Tamura.

This patch copys html/shadow/TextControlInnerElement.{cpp,h} to SpinButtonElement.{cpp,h} for
preparation of bug 93941, Set SpinButtonElement free from HTMLInputElement.

No new tests. This patch doesn't change behavior.

  • html/shadow/SpinButtonElement.cpp: Copied from Source/WebCore/html/shadow/TextControlInnerElements.cpp.
  • html/shadow/SpinButtonElement.h: Copied from Source/WebCore/html/shadow/TextControlInnerElements.h.
2:38 AM WebInspector edited by toybabyyou@gmail.com
(diff)
2:28 AM Changeset in webkit [125533] by sergio@webkit.org
  • 4 edits in trunk

[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
​https://bugs.webkit.org/show_bug.cgi?id=91083

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

After r122428 search_next()/search_prev() should return just 1 match
if the text is found.

  • UIProcess/API/gtk/tests/TestWebKitFindController.cpp:

(testFindControllerNext):
(testFindControllerPrevious):

Tools:

Unskipped a couple of API tests that should work fine from now on.

  • Scripts/run-gtk-tests:

(TestRunner):

2:25 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
2:21 AM Changeset in webkit [125532] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/TestExpectations: Skip media-source tests, the GTK

port doesn't support this feature yet and the tests time out.

2:16 AM Changeset in webkit [125531] by commit-queue@webkit.org
  • 8 edits
    20 adds in trunk

Implement the plugin-types Content Security Policy directive.
​https://bugs.webkit.org/show_bug.cgi?id=91919

Patch by Mike West <​mkwst@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Source/WebCore:

The CSP 1.1 editor's draft defines the 'plugin-types' directive as a
mechanism for whitelisting only specific types of plugin content on a
page. A protected resource might trust only Flash content, for instance,
and could enforce that preference via a Content Security Policy of
'plugin-types application/x-shockwave-flash'. Flash would load, no other
plugin type would.

Specification details available at: ​https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#plugin-types--experimental

This experimental directive is gated on the ENABLE_CSP_NEXT flag, which
is currently only enabled in Chromium.

Tests: http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html

http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::pluginIsLoadable):

Adding a check against 'allowPluginType', and passing in both the
MIME type of the plugin, as well as the declared MIME type from the
object/embed element (ensuring that we do this correctly, even if
we're inside a PluginDocument).

(WebCore::SubframeLoader::createJavaAppletWidget):

Same as 'pluginIsLoadable', but hard-coded to
'application/x-java-applet'.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::logInvalidPluginTypes):

Plugin types that don't match the grammar ('not/a/mime/type') are
logged to the console, and ignored for purposes of matching.

(WebCore):
(WebCore::CSPDirectiveList::checkPluginType):

Given both the plugin type and the declared type attribute, returns
true if both types match, and are contained in the list of accepted
plugin types.

(WebCore::CSPDirectiveList::checkPluginTypeAndReportViolation):

Calls out to checkPluginType, and reports a violation if that check
fails.

(WebCore::CSPDirectiveList::allowPluginType):

Analog to the other 'CSPDirectiveList::allowXXX' methods, this
branches between simply checking the type against the policy, and
checking against the policy and then reporting violations.

(WebCore::CSPDirectiveList::parsePluginTypes):

Given a directive value, parse out the media types contained within
by splitting on spaces, and validating each token. Valid tokens are
added to 'm_pluginTypes' for use in 'checkPluginType'.

(WebCore::CSPDirectiveList::addDirective):

Wire up 'plugin-types' as a valid directive (if the ENABLE_CSP_NEXT
flag is set). This has been combined with the other implemented 1.1
header, 'script-nonce'.

(WebCore::ContentSecurityPolicy::allowPluginType):

The public interface to this set of functionality.

  • page/ContentSecurityPolicy.h:

LayoutTests:

  • http/tests/plugins/resources/mock-plugin-unknown-type.pl:

Adding a mock plugin resource that is served with a type that WebKit
doesn't understand. Using it to test a confusion attack in
plugintypes-url-02.

  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html: Added.
  • http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:

Renaming the q parameter to plugin in these two tests.

  • http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:

Add output of explicit MIME types to the object data renderer, and
changed the q parameter to be slightly less confusingly named.
It's now plugin.

  • http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js: Added.

Copy multiple-iframe-test.js, and add in plugin-specific details,
like plugin, log, and type.

(test):
(finishTesting):

2:16 AM BuildingGtk edited by Csaba Osztrogonác
typo fix (diff)
2:12 AM Changeset in webkit [125530] by charles.wei@torchmobile.com.cn
  • 5 edits
    1 copy in trunk/Source

[BlackBerry] Enable DNS prefetch
​https://bugs.webkit.org/show_bug.cgi?id=93846

Reviewed by George Staikos.

Source/WebCore:

No new tests.

  • PlatformBlackBerry.cmake:
  • platform/blackberry/TemporaryLinkStubs.cpp:
  • platform/network/blackberry/DNSBlackBerry.cpp: Copied from Source/WebCore/platform/blackberry/TemporaryLinkStubs.cpp.

(WebCore):
(WebCore::prefetchDNS):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

2:06 AM Changeset in webkit [125529] by hans@chromium.org
  • 5 edits
    2 adds in trunk

Speech Input: wrong position was reported for scolled-down elements
​https://bugs.webkit.org/show_bug.cgi?id=93634

Reviewed by Kent Tamura.

Source/WebCore:

When clicking on a speech-enabled input element, WebKit reports
the position of the element to the embedder, so that it can show
a bubble indicating that speech recognition is in progress for
the element that the user clicked on.

On a page that was scrolled, this position was being reported
erroneously: it was given relative to the frame content as opposed to
the root view, and the in-progress bubble would be shown in the wrong
place.

Test: fast/speech/bubble-position-scrolled.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

LayoutTests:

Test that the position of the speech element is passed to the embedder
corectly, i.e. where the user clicked, when the page is scrolled down.

  • fast/speech/bubble-position-scrolled-expected.txt: Added.
  • fast/speech/bubble-position-scrolled.html: Added.
2:06 AM Changeset in webkit [125528] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Implement smart separators for context menu in WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=90449

Reviewed by Martin Robinson.

Don't add to the context menu separators that are at the very
beginning or end of the menu. Once the context menu is shown,
monitor menu items visibility to hide or show separators to make
sure they never appear in the context menu unless they are between
two visible items.

  • UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuSmartSeparators):
(beforeAll):

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::contextMenuItemVisibilityChanged):
(WebKit):
(WebKit::WebContextMenuProxyGtk::append):
(WebKit::WebContextMenuProxyGtk::populate):

2:04 AM Changeset in webkit [125527] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Drop "Loading..." message from FileContentView
​https://bugs.webkit.org/show_bug.cgi?id=91732

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-08-14
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/FileContentView.js:

(WebInspector.FileContentView.prototype.wasShown):

1:56 AM Changeset in webkit [125526] by commit-queue@webkit.org
  • 23 edits
    12 deletes in trunk

Unreviewed, rolling out r125519.
​http://trac.webkit.org/changeset/125519
​https://bugs.webkit.org/show_bug.cgi?id=93945

New ref-tests caused image failures on chromium-mac bots.
(Requested by yutak on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-14

Source/WebCore:

  • css/html.css:

(meter):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLMeterElement.h:

(WebCore):
(HTMLMeterElement):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):

  • html/shadow/MeterShadowElement.h:

(WebCore):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::valueRatio):

  • rendering/RenderMeter.h:

(RenderMeter):

LayoutTests:

  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
  • fast/dom/shadow/resources/replaced-element-styles.css:

(.progress-inner-element-like):

  • fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-dynamic.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-multiple.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-with-style.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter.html: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
  • platform/mac/TestExpectations:
1:53 AM Changeset in webkit [125525] by Philippe Normand
  • 5 edits
    5 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r125519.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
1:48 AM Changeset in webkit [125524] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/Tools

[NRWT] Compare results between different platforms
​https://bugs.webkit.org/show_bug.cgi?id=90555

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_search_path):
(Port):
(Port.compare_baseline):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

1:48 AM Changeset in webkit [125523] by keishi@webkit.org
  • 5 edits
    5 moves
    1 add in trunk

Move page popup resources to separate directory
​https://bugs.webkit.org/show_bug.cgi?id=93932

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html:
  • ManualTests/forms/color-suggestion-picker.html:

Source/WebCore:

Keeping the resources organized.

No new tests.

  • Resources/pagepopups/calendarPicker.css: Renamed from Source/WebCore/Resources/calendarPicker.css.
  • Resources/pagepopups/calendarPicker.js: Renamed from Source/WebCore/Resources/calendarPicker.js.
  • Resources/pagepopups/calendarPickerMac.css: Renamed from Source/WebCore/Resources/calendarPickerMac.css.
  • Resources/pagepopups/colorSuggestionPicker.css: Renamed from Source/WebCore/Resources/colorSuggestionPicker.css.
  • Resources/pagepopups/colorSuggestionPicker.js: Renamed from Source/WebCore/Resources/colorSuggestionPicker.js.
  • WebCore.gyp/WebCore.gyp:
1:44 AM Changeset in webkit [125522] by yosin@chromium.org
  • 12 edits in trunk/Source/WebCore

[Forms] Move wheel event handler to spin button class
​https://bugs.webkit.org/show_bug.cgi?id=93928

Reviewed by Kent Tamura.

This patch moves implmentation of wheel event handling from TextFieldInput
class to SpinButtonElement class to share implementation in TextFieldInput
class, and DateTimeEditElement.

No new tests. This patch doesn't change behavior. fast/orms/number/number-wheel.html
covers this change.

  • html/BaseDateAndTimeInputType.cpp: Removed handleWheelEvent() implementation.
  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Removed handleWheelEvent() declaration.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler): Removed wheel event handling.

  • html/InputType.cpp: Removed handleWheelEvent() implementation.
  • html/InputType.h:

(InputType): Removed handleWheelEvent() declaration.

  • html/NumberInputType.cpp: Removed handleWheelEvent() implementation.
  • html/NumberInputType.h:

(NumberInputType): Removed handleWheelEvent() declaration.

  • html/TextFieldInputType.cpp: Removed handleWheelEventForSpinButton() declaration.

(WebCore::TextFieldInputType::forwardEvent): Changed to call SpinButtonElement::forwardEvent().

  • html/TextFieldInputType.h:

(TextFieldInputType): Removed handleWheelEventForSpinButton() declaration.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::forwardEvent): Moved implementation of wheel event handling code
from TextFieldInputType::handleWheelEventForSpinButton().

  • html/shadow/TextControlInnerElements.h:

(SpinButtonElement): Added forwardEvent() declaration.

1:23 AM Changeset in webkit [125521] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK baseline for test introduced in r125462.

  • platform/gtk/svg/filters/color-interpolation-filters-expected.txt:
12:53 AM Changeset in webkit [125520] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Add expectations for recent flakiness.

  • platform/chromium/TestExpectations:
12:48 AM Changeset in webkit [125519] by shinyak@chromium.org
  • 23 edits
    12 adds in trunk

AuthorShadowDOM for meter element
​https://bugs.webkit.org/show_bug.cgi?id=91970

Reviewed by Hajime Morita.

Source/WebCore:

We add support for AuthorShadowDOM for a meter element.

According to the Shadow DOM spec, a meter element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'meter' bar. In this patch, we change the inner structure
of a meter element so that we can distribute an element having RenderMeter to AuthorShadowDOM.

Before this patch, a meter element has the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterBarElement
|
+-- MeterValueElement

After this patch, a meter element will have the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterInnerElement

|
+-- MeterBarElement
|
+-- MeterValueElement

However, if RenderTheme supports rendering meter, MeterInnerElement will not create a renderer
unless an AuthorShadowDOM is attached to it so that we can keep the current rendering style.

Tests: fast/dom/shadow/shadowdom-for-meter-dynamic.html

fast/dom/shadow/shadowdom-for-meter-multiple.html
fast/dom/shadow/shadowdom-for-meter-with-style.html
fast/dom/shadow/shadowdom-for-meter-without-appearance.html
fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html
fast/dom/shadow/shadowdom-for-meter.html

  • css/html.css:

(meter): Changed the display type. inline-box is not supported WebKit. inline-block is true.
(meter::-webkit-meter-inner-element):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::willAddAuthorShadowRoot):
(WebCore::HTMLMeterElement::renderMeter):
(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLMeterElement.h:

(WebCore):
(WebCore::HTMLMeterElement::hasAuthorShadowRoot):
(HTMLMeterElement):
(WebCore::isHTMLMeterElement):
(WebCore::toHTMLMeterElement):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):
(WebCore::MeterInnerElement::MeterInnerElement): We introduce a new element having RenderMeter
so that we can distribute an element having RenderMeter to AuthorShadowDOM.
(WebCore::MeterInnerElement::rendererIsNeeded): Different from a progress element, meter element will not be
rendered using a theme. So we don't need to check the style appearance.
(WebCore::MeterInnerElement::createRenderer):
(WebCore::MeterInnerElement::shadowPseudoId):

  • html/shadow/MeterShadowElement.h:

(WebCore):
(MeterInnerElement):
(WebCore::MeterInnerElement::create):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::meterElement):
(WebCore):
(WebCore::RenderMeter::valueRatio):

  • rendering/RenderMeter.h:

(RenderMeter):

LayoutTests:

Contains the following tests:

(1) meter element with AuthorShadowDOM
(2) meter element with multiple AuthorShadowDOM with a shadow element
(3) meter element with multiple AuthorShadowDOM without a shadow element
(4) meter element with AuthorShadowDOM with dynamic value update
(5) meter element with AuthorShadowDOM with style
(6) meter element with AuthorShadowDOM with -webkit-appearance: none

  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
  • fast/dom/shadow/resources/replaced-element-styles.css:

(.meter-like):
(.meter-inner-element-like):

  • fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-dynamic.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-multiple.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-with-style.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Added.
  • fast/dom/shadow/shadowdom-for-meter.html: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
  • platform/mac/TestExpectations:
12:46 AM Changeset in webkit [125518] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] inspector/debugger/debugger-pause-on-exception.html is duplicated in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=93936

Unreviewed EFL gardening. Remove duplicated test
in WK2-EFL TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14

  • platform/efl-wk2/TestExpectations:
12:37 AM Changeset in webkit [125517] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip passing inspector tests after r125394.
​https://bugs.webkit.org/show_bug.cgi?id=93228

  • platform/qt/Skipped:
12:36 AM Changeset in webkit [125516] by rniwa@webkit.org
  • 53 edits in trunk/Tools

Rename LayoutTestController to TestRunner in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=93758

Reviewed by Tony Chang.

Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
since it already has TestRunner class shared between DumpRenderTree and content_shell.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/PixelDumpSupport.cpp:
  • DumpRenderTree/StorageTrackerDelegate.h:
  • DumpRenderTree/StorageTrackerDelegate.mm:
  • DumpRenderTree/TestRunner.cpp:
  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/blackberry/DumpRenderTree.cpp:
  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/DRTTestRunner.cpp:
  • DumpRenderTree/chromium/DRTTestRunner.h:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:
  • DumpRenderTree/chromium/WebPermissions.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/efl/DumpRenderTree.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:
  • DumpRenderTree/efl/EditingCallbacks.cpp:
  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/EditingCallbacks.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/HistoryDelegate.mm:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PolicyDelegate.h:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:
  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/HistoryDelegate.cpp:
  • DumpRenderTree/win/PolicyDelegate.h:
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:
  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
12:31 AM Changeset in webkit [125515] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] String returned by g_path_get_dirname() must be freed
​https://bugs.webkit.org/show_bug.cgi?id=93885

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-08-14
Reviewed by Philippe Normand.

Fix a memory leak in GTK's DRT code.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(pathFromSoupURI): Free the string returned by g_path_get_dirname().

12:25 AM Changeset in webkit [125514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[EFL] undefined reference to 'g_type_init' with gold linker
​https://bugs.webkit.org/show_bug.cgi?id=93935

Unreviewed build fix. Link against glib-gobject to
fix linking error with gold linker.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14

  • PlatformEfl.cmake:
12:22 AM Changeset in webkit [125513] by commit-queue@webkit.org
  • 6 edits in trunk

regression(r124510) webintents/web-intents-obj-constructor.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=93096

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14
Reviewed by Kentaro Hara.

Source/WebCore:

Add null-check for JSC::ExecState pointer in JSDictionary constructor
before using it. The exec may indeed be null, thus causing crashes.

No new test, already tested by webintents/web-intents-obj-constructor.html

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::tryGetProperty):
(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::JSDictionary):

LayoutTests:

Unskip webintents/web-intents-obj-constructor.html now that the
crash is fixed in WebCore.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
12:17 AM Changeset in webkit [125512] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[WK2] Add getter for capture attribute of input element
​https://bugs.webkit.org/show_bug.cgi?id=93710

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-08-14
Reviewed by Antonio Gomes.

Add getter for capture attribute to WKOpenPanelParameters to support HTML Media Capture.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebOpenPanelParameters.cpp:

(WebKit):
(WebKit::WebOpenPanelParameters::capture):

  • Shared/WebOpenPanelParameters.h:

(WebOpenPanelParameters):

  • UIProcess/API/C/WKOpenPanelParameters.cpp:

(WKOpenPanelParametersCopyCapture):

  • UIProcess/API/C/WKOpenPanelParameters.h:
12:14 AM Changeset in webkit [125511] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK build fix after r125508.

Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.

  • GNUmakefile.am:

Aug 13, 2012:

11:49 PM Changeset in webkit [125510] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding an empty platform baseline for r125462 just to avoid exceptions
in the layout-test step on the buildbots. The baseline will be updated
accordingly later.

  • platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Added.
10:39 PM WebKitIDL edited by Vineet
(diff)
10:35 PM Changeset in webkit [125509] by Joone Hur
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening, rebaselining after r125462.

Add a new test result to avoid layout-test exception

  • platform/efl/svg/filters/color-interpolation-filters-expected.txt: Added.
9:58 PM Changeset in webkit [125508] by rniwa@webkit.org
  • 39 edits
    12 moves in trunk/Tools

Rename files that declare and define LayoutTestController in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=93899

Reviewed by Tony Chang.

Renamed files and fixed style errors.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/LayoutTestController.cpp: Removed.
  • DumpRenderTree/LayoutTestController.h: Removed.
  • DumpRenderTree/PixelDumpSupport.cpp:
  • DumpRenderTree/StorageTrackerDelegate.mm:
  • DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
  • DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.

(LayoutTestController):

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:
  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
  • DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
  • DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
  • DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
  • DumpRenderTree/chromium/LayoutTestController.h: Removed.
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTree.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:
  • DumpRenderTree/efl/EditingCallbacks.cpp:
  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
  • DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/EditingCallbacks.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
  • DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/HistoryDelegate.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
  • DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
  • DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
  • DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.

(WebCore):
(LayoutTestController):
(LayoutTestController::setCloseRemainingWindowsWhenComplete):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setCallCloseOnWebViews):
(LayoutTestController::addDisallowedURL):
(LayoutTestController::abortModal):

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/HistoryDelegate.cpp:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
  • DumpRenderTree/win/PolicyDelegate.cpp:
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:
  • DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.

(LayoutTestController::setUserStyleSheetEnabled):
(resolveCygwinPath):

  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/wscript:
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
  • DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
9:29 PM Changeset in webkit [125507] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove fade in transition from calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=93816

Reviewed by Kent Tamura.

The fade in transition was incomplete because it was only fading in the
popup content and not the popup itself. Removing the effect for now.

No new tests. Can't test animation.

  • Resources/calendarPicker.css:

(#main):

  • Resources/calendarPicker.js:

(initialize):
(fixWindowSize):

8:32 PM Changeset in webkit [125506] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

WPARAM and LPARAM are incorrectly defined for x64
​https://bugs.webkit.org/show_bug.cgi?id=89902

Patch by Alex Christensen <​alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.

Include WindowsExtras.h for PLATFORM(WIN) to define WPARAM and LPARAM correctly

  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
  • platform/win/WindowMessageListener.h:
8:20 PM Changeset in webkit [125505] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Windows 64 bit compliance
​https://bugs.webkit.org/show_bug.cgi?id=93275

Patch by Alex Christensen <​alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.

Fixed a few compile and link problems for Win64

  • WinLauncher/WinLauncher.cpp:
  • win/DLLLauncher/DLLLauncherMain.cpp:
7:53 PM Changeset in webkit [125504] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
​https://bugs.webkit.org/show_bug.cgi?id=93918

Patch by John Bates <​jbates@google.com> on 2012-08-13
Reviewed by James Robinson.

Also, update some trace events.

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::setActive):

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setActive):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onVSyncParametersChanged):

7:52 PM Changeset in webkit [125503] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash in WebCore::RenderBlock::LineBreaker::nextLineBreak
​https://bugs.webkit.org/show_bug.cgi?id=93806

Patch by Douglas Stockwell <​dstockwell@chromium.org> on 2012-08-13
Reviewed by Abhishek Arya.

Source/WebCore:

When looking for line breaks on the first line, existing code was
checking for text-combine only in the first-line style. Since
text-combine isn't inherited this resulted in a line break being
chosen before combineText was called. When this happened and then
combineText was called subsequently, the position of the line break
iterator would be invalid.

This patch changes the check to use the regular style as in
skipLeadingWhitespace and textWidth.

Test: fast/text/text-combine-first-line-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Don't use the
first-line style when checking text-combine.

LayoutTests:

  • fast/text/text-combine-first-line-crash-expected.txt: Added.
  • fast/text/text-combine-first-line-crash.html: Added.
7:49 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
(diff)
7:49 PM Changeset in webkit [125502] by yutak@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed. Rebaseline test results for add-table-overpaint.html.

  • platform/chromium-mac/fast/repaint/add-table-overpaint-expected.png: Added.
  • platform/chromium-win/fast/repaint/add-table-overpaint-expected.png: Renamed from LayoutTests/platform/chromium/fast/repaint/add-table-overpaint-expected.png.
7:44 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Add #!cpp in ... (diff)
7:43 PM Changeset in webkit [125501] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused method HTMLDocumentParser::script()
​https://bugs.webkit.org/show_bug.cgi?id=93916

Patch by Kwang Yul Seo <​skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.

The use of HTMLDocumentParser::script() was removed in r61640 and has never been used since then.

No behavior change, so no new tests.

  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
7:37 PM Changeset in webkit [125500] by tsepez@chromium.org
  • 20 edits in trunk/Source

[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
​https://bugs.webkit.org/show_bug.cgi?id=93283

Reviewed by Eric Seidel.

Source/WebCore:

Chromium has a refptr that needs to be NULLed at this point.

The approach is to change the client redirectDataToPlugin method(s) to expect
the possibility of a NULL argument, and the use this to clear the refptr on
the chromium platform. Other platforms can merely ignore the NULL case, thereby
maintaining the existing behaviour.

Formal testing is nearly impossible without some chrome-specific plugins.

  • html/PluginDocument.cpp:

(WebCore::PluginDocument::detach):

Source/WebKit/blackberry:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):

Source/WebKit/chromium:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, NULLing Chromium's refptr that needs to be NULLed.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):

Source/WebKit/efl:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):

Source/WebKit/gtk:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::redirectDataToPlugin):

Source/WebKit/qt:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::redirectDataToPlugin):

Source/WebKit/win:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKit/wince:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):

Source/WebKit/wx:

Chromium has a refptr that needs to be NULLed at this point.

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::redirectDataToPlugin):

Source/WebKit2:

Chromium has a refptr that needs to be NULLed at this point.

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

7:31 PM EFLWebKitCodingStyle edited by rakuco@webkit.org
Add a better explanation about the usage of !!s (diff)
7:17 PM Changeset in webkit [125499] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations to reflect the recent results and
remove lint errors.

  • platform/chromium/TestExpectations:
7:14 PM Changeset in webkit [125498] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Paint animated layers immediately to avoid animation hiccups.
​https://bugs.webkit.org/show_bug.cgi?id=93028

Patch by Eric Penner <​epenner@google.com> on 2012-08-13
Reviewed by Adrienne Walker.

Source/WebCore:

This is a technique used on Android, which is very prone
to hiccups in animations. Paint the entire layer if it is
of reasonable size such that there is no hiccups when the
animation reaches unpainted content. The reasonable size
is choosen for page-transitions specifically, as this was
the problem case (animations would just jump to the end).

Since we already have a special case this just modifies it
and replaces the unit test with a new one. This can be
improved/simplified further when distances/directions are
available for the animated layers.

Replaced one test.
Fixed bugs in and improved idlePaintNonVisibleLayers test.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::contentRectToTileIndices):

  • platform/graphics/chromium/cc/CCPriorityCalculator.h:

(WebCore::CCPriorityCalculator::maxPriority):

Source/WebKit/chromium:

Replaced one test. Test painting full animated layer.

  • tests/TiledLayerChromiumTest.cpp:
7:10 PM Changeset in webkit [125497] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Simple refactoring that I forgot to apply in r125495.

  • bindings/v8/V8ThrowException.cpp:

(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):

  • bindings/v8/V8ThrowException.h:
7:09 PM Changeset in webkit [125496] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[CMAKE][EFL] Fix build break with --tiled-backing-store
​https://bugs.webkit.org/show_bug.cgi?id=93487

Unreviewed build fix for Efl with --tiled-backing-store.

  • CMakeLists.txt:

Checked bison version and selected proper glslang files.

7:04 PM Changeset in webkit [125495] by haraken@chromium.org
  • 71 edits
    1 copy
    1 add in trunk/Source/WebCore

[V8] Factor out exception related methods of V8Proxy
​https://bugs.webkit.org/show_bug.cgi?id=93792

Reviewed by Adam Barth.

To remove V8Proxy, this patch factors out exception related methods of V8Proxy
to a separate file.

(1) Move exception related methods from V8Proxy.{h,cpp} to V8ThrowException.{h,cpp}.
(2) To avoid writing V8ThrowException::throwError() here and there in V8 binding,
implement WebCore::throwError() in V8Binding.{h,cpp}. Ideally, we want to list up
all V8 binding APIs in V8Binding.h.
(3) Replace all V8Proxy::throwError() with throwError().

Nit: I couldn't write the definition of WebCore::throwError() in V8BInding.h
due to circular dependency issues. Either way, these methods wouldn't be
performance-critical.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::MethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/DateExtension.cpp:

(WebCore::DateExtension::OnSleepDetected):

  • bindings/v8/NPV8Object.cpp:

(_NPN_SetException):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::setDOMException):
(WebCore):
(WebCore::throwError):
(WebCore::throwTypeError):
(WebCore::throwNotEnoughArgumentsError):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toV8Sequence):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Proxy.h:

(V8Proxy):
(WebCore):

  • bindings/v8/V8ThrowException.cpp: Added.

(WebCore):
(WebCore::DOMExceptionStackGetter):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
(WebCore::V8ThrowException::throwError):
(WebCore::V8ThrowException::throwTypeError):
(WebCore::V8ThrowException::throwNotEnoughArgumentsError):

  • bindings/v8/V8ThrowException.h: Added.

(WebCore):
(V8ThrowException):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
(WebCore::setTypeMismatchException):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):
(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertySetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):
(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:

(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAccessorSetter):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::protocolAccessorSetter):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallback):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):

6:48 PM EFLWebKitCodingStyle edited by eunmi15.lee@samsung.com
(diff)
6:45 PM Changeset in webkit [125494] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
​https://bugs.webkit.org/show_bug.cgi?id=93818

Reviewed by Adam Barth.

(1) This patch moves GCEventData class from V8Binding.h to ScriptGCEvent.h.
(2) This patch makes GCEventData::startTime and GCEventData::usedHeapSize
private members.
(3) This patch removes unused forward declarations from V8Binding.h.

No tests. No change in behavior.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/ScriptGCEvent.h:

(GCEventData):
(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(WebCore::GCEventData::listeners):
(WebCore::GCEventData::startTime):
(WebCore::GCEventData::setStartTime):
(WebCore::GCEventData::usedHeapSize):
(WebCore::GCEventData::setUsedHeapSize):
(WebCore):

  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8PerIsolateData.cpp:
6:39 PM Changeset in webkit [125493] by haraken@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

[V8] Move checkNewLegal() from V8Proxy.h to SafeAllocation.h
​https://bugs.webkit.org/show_bug.cgi?id=93830

Reviewed by Adam Barth.

This patch moves checkNewLegal() from V8Proxy.h to SafeAllocation.h.
In addition, this patch renames checkNewLegal() to isValidConstructorMode()
for clarification.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/SafeAllocation.cpp: Added.
  • bindings/v8/SafeAllocation.h:

(WebCore::SafeAllocation::newInstance):
(WebCore):

  • bindings/v8/V8Binding.cpp:

(WebCore::createRawTemplate):

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

(V8Proxy):

6:38 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Add new coding style related to double not operator(!!) (diff)
6:34 PM Changeset in webkit [125492] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused methods from V8Binding.h
​https://bugs.webkit.org/show_bug.cgi?id=93836

Reviewed by Adam Barth.

enableStringImplCache() and v8UndetectableString() are not used by anybody.

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:
6:32 PM Changeset in webkit [125491] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
​https://bugs.webkit.org/show_bug.cgi?id=93834

Reviewed by Adam Barth.

This patch moves hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.

No tests. No change in behavior.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::hintForGCIfNecessary):

  • bindings/v8/V8GCController.h:

(V8GCController):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

6:29 PM Changeset in webkit [125490] by shawnsingh@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed rebaseline after r125193.

  • platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png:
  • platform/chromium-win/compositing/masks/layer-mask-placement-expected.png:
  • platform/chromium/TestExpectations:
6:27 PM Changeset in webkit [125489] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r124970.
​http://trac.webkit.org/changeset/124970
​https://bugs.webkit.org/show_bug.cgi?id=93495

Postponing the merge in a clearer context (Requested by
Michelangelo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-13

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransform):

  • css/CSSParser.h:
6:24 PM Changeset in webkit [125488] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add test to demonstrate overpainting seen in bug 92800
​https://bugs.webkit.org/show_bug.cgi?id=93901

Reviewed by Levi Weintraub.

Bug 92800 is a rather complicated change to fix this overpainting bug.
Adding the test before the change so that it's easier for me to track as I change
this behavior and for reviewers to see that I'm fixing this overpainting.

  • fast/repaint/add-table-overpaint-expected.png: Added.
  • fast/repaint/add-table-overpaint-expected.txt: Added.
  • fast/repaint/add-table-overpaint.html: Added.
6:04 PM Changeset in webkit [125487] by morrita@google.com
  • 2 edits in trunk/Tools

Unreviewed update for webcomponents-bugzilla address.

  • Scripts/webkitpy/common/config/committers.py:
6:03 PM Changeset in webkit [125486] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
​https://bugs.webkit.org/show_bug.cgi?id=93795

Reviewed by Adrienne Walker.

Source/WebCore:

If a renderSurface is created by a layer that had zero
area (empty) but non-zero bounds (either width or height was
non-zero), then one translation transform was accidentally being
skipped, causing the renderSurface drawTransform to be incorrect.
The fix is simply to move that transform outside of the
if-statement so it is not skipped.

Unit test added:

CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer()

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
5:57 PM Changeset in webkit [125485] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

Enable CSS Sticky Position on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=93905

Patch by Roger Fong <​roger_fong@apple.com> on 2012-08-13
Reviewed by Tim Horton.

As per ​https://bugs.webkit.org/show_bug.cgi?id=90046, the ENABLE_CSS_STICKY_POSITION needs to be turned on for Windows as well.

  • win/tools/vsprops/FeatureDefines.vsprops:

Include ENABLE_CSS_STICKY_POSITION flag.

5:55 PM Changeset in webkit [125484] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

[V8] Remove [TreatReturnedNullAs=False]
​https://bugs.webkit.org/show_bug.cgi?id=93835

Reviewed by Adam Barth.

[TreatReturnedNullAs=False] is neither defined in the Web IDL spec
nor used in any WebKit IDL file.

No tests. No change in behavior.

  • WebCore.order:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/V8Binding.h:
5:53 PM Changeset in webkit [125483] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList()
​https://bugs.webkit.org/show_bug.cgi?id=93839

Reviewed by Adam Barth.

For naming consistency with toWebCoreString() and toWebCoreAtomicString(),
this patch renames v8ValueToWebCoreDOMStringList() to toDOMStringList().
("WebCore" wouldn't be needed because it's clear from "DOMStringList".)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):

  • bindings/v8/V8Binding.h:

(WebCore):

5:51 PM Changeset in webkit [125482] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[V8] Rename v8ValueToAtomicWebCoreString() to toWebCoreAtomicString()
​https://bugs.webkit.org/show_bug.cgi?id=93824

Reviewed by Adam Barth.

For naming consistency with toWebCoreString(), we can rename
v8ValueToAtomicWebCoreString() to toWebCoreAtomicString().
Also we can rename v8ValueToAtomicWebCoreStringWithNullCheck()
to toWebCoreAtomicStringWithNullCheck().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/V8Binding.cpp:

(WebCore::toWebCoreAtomicString):

  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::toWebCoreAtomicStringWithNullCheck):

  • bindings/v8/V8Collection.h:

(WebCore::getNamedPropertyOfCollection):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

5:49 PM Changeset in webkit [125481] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Remove v8ValueToWebCoreString()
​https://bugs.webkit.org/show_bug.cgi?id=93822

Reviewed by Adam Barth.

There are two equivalent ways to convert a V8 value to a WebCore String;
i.e. v8ValueToWebCoreString() and toWebCoreString(). We can remove the former.

In a follow-up patch, I will replace v8ValueToAtomicWebCoreString()
with toWebCoreAtomicString(), for consistency with toWebCoreString().

No tests. No change in behavior.

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):

  • bindings/v8/V8Binding.cpp:

(WebCore::toWebCoreString):
(WebCore::v8ValueToWebCoreDOMStringList):

  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreStringWithNullCheck):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallback):

5:47 PM Changeset in webkit [125480] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Move the ConstructorMode class from V8Binding.h to SafeAllocation.h
​https://bugs.webkit.org/show_bug.cgi?id=93821

Reviewed by Adam Barth.

This patch factors out the ConstructorMode class from V8Binding.h to SafeAllocation.h.

No tests. No change in behavior.

  • bindings/v8/SafeAllocation.h:

(ConstructorMode):
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(WebCore):

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8RecursionScope.h:
5:44 PM Changeset in webkit [125479] by haraken@chromium.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

[V8] Remove V8BindingHelpers
​https://bugs.webkit.org/show_bug.cgi?id=93807

Reviewed by Adam Barth.

V8BindingHelpers contains toV8Context() and toV8Proxy(), which are used
by NPV8Object.cpp only.

(1) Move these methods to NPV8Object.cpp as static methods.
(2) Remove V8BindingHelpers.{h,cpp}.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/NPV8Object.cpp:

(WebCore::toV8Context):
(WebCore):
(WebCore::toV8Proxy):

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8BindingHelpers.cpp: Removed.
  • bindings/v8/V8BindingHelpers.h: Removed.
5:42 PM Changeset in webkit [125478] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove unused methods and headers from V8Utilities
​https://bugs.webkit.org/show_bug.cgi?id=93805

Reviewed by Adam Barth.

This patch removes unused methods, forward declarations and
headers from V8Utilities.{h,cpp}.

No tests. No change in behavior.

  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:

(WebCore):

5:40 PM Changeset in webkit [125477] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp
​https://bugs.webkit.org/show_bug.cgi?id=93803

Reviewed by Adam Barth.

In r125015, I forgot to move V8PerIsolateData::visitExternalStrings()
to V8PerIsolateData.cpp. This patch moves it.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8PerIsolateData.cpp:

(WebCore):
(WebCore::V8PerIsolateData::visitExternalStrings):

5:38 PM Changeset in webkit [125476] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Expand list of supported languages for RenderQuote to match WHATWG spec
​https://bugs.webkit.org/show_bug.cgi?id=93424

Patch by Elliott Sprehn <​esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.

Source/WebCore:

Expand the table of quotes to include the 148 lang values and associated quotes
from the WHATWG web-apps recommended styling spec.

Test: fast/css-generated-content/quotes-lang-case-insensitive.html

  • rendering/RenderQuote.cpp: Added missing copyright.

(WebCore::quotesDataLanguageMap): Expanded the table of quotes.
(WebCore::basicQuotesData): Added a FIXME to switch to using stylized "en" quotes.

  • rendering/RenderQuote.h: Added missing copyright.

LayoutTests:

Update quote language test to include the 148 languages in the WHATWG web-apps
recommended styling table.
​http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#quotes

Add a new test that ensures language matching for quotes is case insensitive.

  • fast/css-generated-content/quotes-lang-case-insensitive-expected.html: Added.
  • fast/css-generated-content/quotes-lang-case-insensitive.html: Added.
  • fast/css-generated-content/quotes-lang-expected.html:
  • fast/css-generated-content/quotes-lang.html:
5:36 PM Changeset in webkit [125475] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Remove evaluateInIsolatedWorld() from V8Proxy
​https://bugs.webkit.org/show_bug.cgi?id=93679

Reviewed by Adam Barth.

To remove V8Proxy, this patch moves V8Proxy::evaluateInIsolatedWorld()
to ScriptController.

No tests. No change in behavior.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::precompileScript):

5:33 PM Changeset in webkit [125474] by shawnsingh@chromium.org
  • 8 edits
    4 copies in branches/chromium/1229

Merge 125193 - [chromium] Pass mask scale and offset to shaders for correct masking
​https://bugs.webkit.org/show_bug.cgi?id=93558

Reviewed by Adrienne Walker.

Source/WebCore:

In chromium compositor code, the mask was accidentally mapped 1:1
to the layer's renderSurface, rather than the layer itself. This
patch adds a layout test that reproduces the error and fixes the
problem. The solution we opted for in this patch is to pass a
scale and offset to the fragment shader, so that the correct
texture coordinate lookup is computed by the fragment shader.

Test: compositing/masks/mask-of-clipped-layer.html

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMaskAA):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleY):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetY):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

Source/WebKit/chromium:

Updated one unit test that needed additional args in a
constructor, but no change in behavior of the test.

  • tests/CCLayerTreeHostImplTest.cpp:

LayoutTests:

Added a layout test that checks the mask does not accidentally get
resized when it is inside of an overflow div.

  • compositing/masks/mask-of-clipped-layer-expected.png: Added.
  • compositing/masks/mask-of-clipped-layer-expected.txt: Added.
  • compositing/masks/mask-of-clipped-layer.html: Added.
  • compositing/resources/alpha-blocks.png: Added.

TBR=​shawnsingh@chromium.org

5:22 PM Changeset in webkit [125473] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Exclusions] Remove unused CSSWrapShapes header includes
​https://bugs.webkit.org/show_bug.cgi?id=93395

Patch by Bear Travis <​betravis@adobe.com> on 2012-08-13
Reviewed by Kentaro Hara.

Removing the #include "CSSWrapShapes.h" lines from StyleBuilder.cpp and
RenderStyle.cpp. Both files now use the length-based WrapShapes.h classes.

  • css/StyleBuilder.cpp:
  • rendering/style/RenderStyle.cpp:
5:11 PM Changeset in webkit [125472] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Bad cast in RenderBox::computeReplacedLogicalHeightUsing
​https://bugs.webkit.org/show_bug.cgi?id=93875

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-08-13
Reviewed by Abhishek Arya.

Source/WebCore:

Pointer to the container of a replaced element was being type casted to renderbox
without checking if the container is a renderbox or not.

Test: fast/replaced/render-inline-cast-to-render-box-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

Scrollbar height is retrieved only if the container is a renderBox. Otherwise scrollbar is taken as zero.

LayoutTests:

  • fast/replaced/render-inline-cast-to-render-box-crash-expected.txt: Added.
  • fast/replaced/render-inline-cast-to-render-box-crash.html: Added.
5:05 PM Changeset in webkit [125471] by dino@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=93910

Unreviewed test expectations update. Temporarily skipping tests.

  • platform/mac/TestExpectations:
4:49 PM Changeset in webkit [125470] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed bot fix after r125467.

  • PlatformEfl.cmake: Make the WK2 tests link against glib, gobject

and gio as well.

4:45 PM Changeset in webkit [125469] by jamesr@google.com
  • 11 edits
    1 move
    1 add in trunk/Source

[chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols
​https://bugs.webkit.org/show_bug.cgi?id=93907

Reviewed by Darin Fisher.

Source/Platform:

This makes WebAnimation a pure virtual interface with instances returned by a factory function. Currently the
factory is a static function on WebAnimation, but it will likely move to a platform support interface. This
provides better isolation of the implementation from the interface and in particular allows for implementing the
WebAnimation interface outside of WebKit.dll without having unresolved external symbols in WebKit.dll.

  • chromium/public/WebAnimation.h:

(WebKit::WebAnimation::~WebAnimation):
(WebAnimation):

  • chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Updates WebAnimation users for interface changes.

  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::createWebAnimation):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

Source/WebKit/chromium:

Adds a WebAnimationImpl implementation of the WebAnimation interface.

  • WebKit.gyp:
  • src/WebAnimationImpl.cpp: Renamed from Source/WebKit/chromium/src/WebAnimation.cpp.

(WebKit):
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::targetProperty):
(WebKit::WebAnimationImpl::iterations):
(WebKit::WebAnimationImpl::setIterations):
(WebKit::WebAnimationImpl::startTime):
(WebKit::WebAnimationImpl::setStartTime):
(WebKit::WebAnimationImpl::timeOffset):
(WebKit::WebAnimationImpl::setTimeOffset):
(WebKit::WebAnimationImpl::alternatesDirection):
(WebKit::WebAnimationImpl::setAlternatesDirection):
(WebKit::WebAnimationImpl::cloneToCCAnimation):

  • src/WebAnimationImpl.h: Added.

(WebCore):
(WebKit):
(WebAnimationImpl):
(WebKit::WebAnimationImpl::WebAnimationImpl):
(WebKit::WebAnimationImpl::~WebAnimationImpl):

  • src/WebLayer.cpp:

(WebKit::WebLayer::addAnimation):

  • tests/WebAnimationTest.cpp:

(WebKit::TEST):

4:41 PM Changeset in webkit [125468] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed attempt at fixing the bots after r125467.

  • PlatformEfl.cmake: Link against GIO and GObject due to the usage

of libsoup.

4:30 PM Changeset in webkit [125467] by rakuco@webkit.org
  • 15 edits
    1 add
    1 delete in trunk

[CMake] Rewrite FindLibSoup2.cmake.
​https://bugs.webkit.org/show_bug.cgi?id=93191

Reviewed by Rob Buis.

.:

The existing LibSoup2 was imported from somewhere else and not
only did it contain a lot of unnecessary cruft to look for libsoup
2.2 (which we do not support anyway), but it also relied on the
paths returned by pkg-config for setting the library and include
paths.

For one, this meant "-lsoup-2.4" was passed to the linked instead
of "-L/path/to/libsoup-2.4.so", which would sometimes make a
system version of libsoup to be picked up instead of the one
installed by, say, jhbuild.

The new FindLibSoup.cmake now only looks for libsoup 2.4 and
relies on pkg-config solely for retrieving the current LibSoup
version.

  • Source/cmake/FindLibSoup.cmake: Added.
  • Source/cmake/FindLibSoup2.cmake: Removed.
  • Source/cmake/OptionsEfl.cmake: Look for LibSoup instead of

LibSoup2, look for the GObject component of Glib.

Source/WebCore:

  • PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO,

also link against GObject, which is needed by libsoup.

Source/WebKit:

  • PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO.

Source/WebKit2:

  • PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO, and

do not use LIBSOUP24_LDFLAGS, as it is not needed anymore.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of

LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
needed anymore.

  • EWebLauncher/CMakeLists.txt: Ditto.
  • MiniBrowser/efl/CMakeLists.txt: Ditto.
  • TestWebKitAPI/PlatformEfl.cmake: Ditto.
  • WebKitTestRunner/CMakeLists.txt: Ditto.
  • WebKitTestRunner/PlatformEfl.cmake: Ditto.
3:46 PM Changeset in webkit [125466] by jamesr@google.com
  • 12 edits
    2 adds in trunk/Source

[chromium] Clean up dependencies for Canvas2DLayerBridgeTest and GraphicsLayerChromiumTest unit tests
​https://bugs.webkit.org/show_bug.cgi?id=93757

Reviewed by Adrienne Walker.

Source/Platform:

Exposes a function to check for active animations on a layer.

  • chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Exposes the current contentsScale for tests.

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

Source/WebKit/chromium:

Breaks up some unit tests and removes unused code to avoid unit tests depending on both non-compositor WebCore
logic and compositor internals. Canvas2DLayerBridgeTest had some vestigal includes and local variables that
weren't being used, those are removed. GraphicsLayerChromiumTest was reaching into CC types, but could mostly
use Platform API types for testing.

GraphicsLayerChromiumTest had some tests that were verifying that we could correctly translate WebCore
animation lists into CCAnimation types - these have been moved into AnimationTranslationUtilTest.cpp, since the
logic under test is in AnimationTranslationUtil. Currently these only test that we accept / reject animations as
expected. They could be expanded to verify that the animation was translated faithfully, but that would require
expanding the information exposed on WebAnimation.

  • WebKit.gypi:
  • src/WebLayer.cpp:

(WebKit::WebLayer::hasActiveAnimation):
(WebKit):

  • tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(GraphicsLayerChromiumTest):
(WebKit::TEST_F):

  • tests/WebLayerTreeViewTest.cpp:
  • tests/WebLayerTreeViewTestCommon.h: Added.

(WebKit):
(MockWebLayerTreeViewClient):

3:44 PM Changeset in webkit [125465] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Reduce the size of empty NinePieceImage objects.
<​http://webkit.org/b/93747>

Reviewed by Antti Koivisto.

Move the members of NinePieceImage into a NinePieceImageData class, leaving NinePieceImage
with a single OwnPtr<NinePieceImageData> member. The constant NinePieceImage::defaultData()
provides default values for objects with null m_data.

RenderStyle's "StyleSurroundData" member has a BorderData, which in turn holds a NinePieceImage.
This means that anything with left/right/top/bottom, margin, padding or border style but *no*
border-image will save 104 bytes (assuming their RenderStyle is unshared, which is fairly common.)

This reduces the size of StyleSurroundData by 104 bytes, effectively reducing memory consumption
by 1.72MB when viewing the full HTML5 spec at <​http://whatwg.org/c>

  • rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImageData::operator==):
(WebCore::NinePieceImage::defaultData):
(WebCore):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImageData::NinePieceImageData):
(NinePieceImageData):
(WebCore::NinePieceImageData::operator!=):
(WebCore):
(NinePieceImage):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::operator=):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::ensureData):
(WebCore::NinePieceImage::data):

3:42 PM Changeset in webkit [125464] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
​https://bugs.webkit.org/show_bug.cgi?id=93883

More Windows build fixing.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::dummy):
3:39 PM Changeset in webkit [125463] by Lucas Forschler
  • 6 edits
    16 deletes in branches/safari-536.26-branch

Merge fix for <rdar://problem/12050793>.

3:37 PM Changeset in webkit [125462] by fmalita@chromium.org
  • 41 edits
    3 adds in trunk

WebKit+SVG does not support color-interpolation-filters or draw filters in correct colorspace
​https://bugs.webkit.org/show_bug.cgi?id=6033

Reviewed by Dirk Schulze.

Source/WebCore:

This patch adds support for SVG color-interpolation-filters. All non-CG plarforms now
perform color space conversions as needed (CG performs color space adjustments internally),
and the new default color space for filters is linearRGB
(​http://www.w3.org/TR/SVG/filters.html#FilterPrimitivesOverviewIntro).

FilterEffect tracks the color-interpolation-filters attribute (m_colorSpace) and the
current result color space (m_resultColorSpace). When applying, the input results are
converted to the current FilterEffect's color space, and at the end of the filter effect
chain the result is finally converted to ColorSpaceDeviceRGB.

FilterEffect::transformResultColorSpace() handles non-CG color space converion (CG has
built in support for different color spaces) by first converting the result to an image
buffer, and then using the platform specific ImageBuffer::transformColorSpace(). This can
be expensive for filter chains with alternating color-interpolation-filters, but can be
optimized if/when color space support is added to all the graphics backends similarly to CG.

As expected, lots of filter-related pixel results will require rebaselining after this lands.

Test: svg/filters/color-interpolation-filters.svg

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::transformResultColorSpace):
(WebCore):

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::colorSpace):
(WebCore::FilterEffect::setColorSpace):
(FilterEffect):

  • platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::apply):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::postApplyResource):

LayoutTests:

  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-expected.png:
  • platform/chromium-linux/svg/filters/color-interpolation-filters-expected.png: Added.
  • platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt: Added.
  • platform/chromium-win/css3/filters/add-filter-rendering-expected.png:
  • platform/chromium-win/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-win/css3/filters/effect-blur-expected.png:
  • platform/chromium-win/css3/filters/effect-combined-expected.png:
  • platform/chromium-win/css3/filters/effect-contrast-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-win/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-win/css3/filters/effect-invert-expected.png:
  • platform/chromium-win/css3/filters/effect-opacity-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-external-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
  • platform/chromium-win/css3/filters/effect-saturate-expected.png:
  • platform/chromium-win/css3/filters/effect-sepia-expected.png:
  • platform/chromium-win/css3/filters/filtered-inline-expected.png:
  • platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium-win/css3/filters/nested-filters-expected.png:
  • platform/chromium-win/css3/filters/regions-expanding-expected.png:
  • platform/chromium-win/css3/filters/simple-filter-rendering-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/css3/filters/blur-filter-page-scroll-expected.png:
  • platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • svg/filters/color-interpolation-filters.svg: Added.
3:35 PM Changeset in webkit [125461] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r125104. <rdar://problem/12082988>

3:16 PM Changeset in webkit [125460] by commit-queue@webkit.org
  • 7 edits in trunk

Oscillator node should throw exception if type is assigned an invalid value
​https://bugs.webkit.org/show_bug.cgi?id=93490

Patch by Raymond Toy <Raymond Toy> on 2012-08-13
Reviewed by Chris Rogers.

Source/WebCore:

New tests added to oscillator-basic to catch exceptions.

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::setType): Return exception

  • Modules/webaudio/Oscillator.h:

(Oscillator): Update setType declaration

  • Modules/webaudio/Oscillator.idl: setType can raise exception.

LayoutTests:

Add tests for invalid oscillator types.

  • webaudio/oscillator-basic-expected.txt: Updated
  • webaudio/oscillator-basic.html: Test CUSTOM and invalid

oscillator type.

3:16 PM Changeset in webkit [125459] by Lucas Forschler
  • 5 edits
    3 copies in branches/safari-536.26-branch

Merged r125086. <rdar://problem/12082988>

3:07 PM Changeset in webkit [125458] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
​https://bugs.webkit.org/show_bug.cgi?id=93883

More Windows build fix

  • UIProcess/WebContext.cpp: (WebKit::WebPage::dummy):
  • UIProcess/WebContext.h: (WebContext):
  • UIProcess/WebContext.messages.in: Add a dummy sync message - the same workaround is already used in WebPage.
3:04 PM Changeset in webkit [125457] by beidson@apple.com
  • 10 edits
    3 adds in trunk

With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
<rdar://problem/12062125> and ​https://bugs.webkit.org/show_bug.cgi?id=93894

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

A few things were in play here:

  • The WebProcess thought the plug-in was done initializing but it wasn't.
  • The sync message out from the PluginProcess was not being handled by the WebProcess.

Expose the ability for the PluginProcess to act as if it is handling a sync message and needs messages dispatched:

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::incrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):
(CoreIPC::Connection::decrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::setInitializationReply): Save the delayed reply for synchronous initialization.
(WebKit::PluginControllerProxy::takeInitializationReply): Give back the delayed reply for initialization completion.
(WebKit::PluginControllerProxy::initialize):

  • PluginProcess/PluginControllerProxy.h:

(WebKit::PluginControllerProxy::isInitializing): Accessor so WebProcessConnection knows whether or not to store the

delayed reply for later.

  • PluginProcess/WebProcessConnection.messages.in: Make the synchronous form of "CreatePlugin" have a delayed reply.
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin): Store away the delayed reply message so it can be responded to after

asynchronous initialization completes.

(WebKit::WebProcessConnection::createPluginAsynchronously): If there is a stored away delayed reply message, respond to

it instead of sending the asynchronously reply.

  • PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

Tools:

Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.

(EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::NPP_New):

LayoutTests:

  • platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt: Added.
  • platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html: Added.
3:03 PM Changeset in webkit [125456] by crogers@google.com
  • 4 edits in trunk/Source/WebCore

AudioContext::createMediaStreamSource() must create a provider for local MediaStreams
​https://bugs.webkit.org/show_bug.cgi?id=93756

Reviewed by Eric Carlson.

There are two main kinds of MediaStreams (local and from remote peers).
Internally we need to know the difference so a MediaStreamAudioSourceNode will "just work".

Tested by existing test: mediastreamaudiosourcenode.html
Full testing can only be verified by manual tests.

  • Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

  • Modules/mediastream/MediaStream.h:

(WebCore::MediaStream::isLocal):
(MediaStream):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

2:51 PM Changeset in webkit [125455] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123013. <rdar://problem/12087344>

2:49 PM Changeset in webkit [125454] by fmalita@chromium.org
  • 5 edits in trunk

Unreviewed, rolling out r125422.
​http://trac.webkit.org/changeset/125422
​https://bugs.webkit.org/show_bug.cgi?id=93902

Broke the Android canary build (Requested by fmalita on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-13

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2:42 PM Changeset in webkit [125453] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
​https://bugs.webkit.org/show_bug.cgi?id=93883

Windows build fix.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Use WebProcessProxy for the message here, too.
2:37 PM Changeset in webkit [125452] by Simon Hausmann
  • 5 edits in trunk/Source

Unreviewed, rolling out r125444.
​http://trac.webkit.org/changeset/125444
​https://bugs.webkit.org/show_bug.cgi?id=93872

Broke some tests

Source/JavaScriptCore:

  • Target.pri:

Source/WebCore:

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):

  • bridge/qt/qt_runtime.h:

(QtRuntimeMethod):

2:29 PM Changeset in webkit [125451] by ap@apple.com
  • 10 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
​https://bugs.webkit.org/show_bug.cgi?id=93883

Reviewed by Sam Weinig.

There was one plug-in message renaming. Moving it, and also other plug-in messages
for consistency.

  • UIProcess/WebContext.cpp: (WebKit): Got rid of the last MESSAGE_CHECK in this file. (WebKit::WebContext::WebContext): Moved m_pluginWorkQueue to a singleton. We don't need more than one queue (all it does is read plug-in info), and if we needed, it would have been per-process, not per-context. (WebKit::WebContext::~WebContext): No more work queue. (WebKit::WebContext::processDidFinishLaunching): Ditto.
  • UIProcess/WebContext.h: No longer needs to be a QueueClient.
  • UIProcess/WebContext.messages.in:
  • UIProcess/WebProcessProxy.messages.in: Moved plug-in related messages.
  • UIProcess/WebProcessProxy.cpp: (WebKit::pluginWorkQueue): Moved from WebContext to a singleton. (WebKit::WebProcessProxy::sendDidGetPlugins): Moved from WebContext. (WebKit::WebProcessProxy::handleGetPlugins): Ditto. (WebKit::WebProcessProxy::getPlugins): Ditto. (WebKit::WebProcessProxy::getPluginPath): Ditto. (WebKit::WebProcessProxy::getPluginProcessConnection): Ditto. (WebKit::WebProcessProxy::didGetSitesWithPluginData): Ditto. (WebKit::WebProcessProxy::didClearPluginSiteData): Ditto.
  • UIProcess/WebProcessProxy.h: Process proxy needs to be thread safe ref counted now, since it sends messages to itself on a work queue and back.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::populatePluginCache): Updated for new receiver.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Ditto.
  • WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ditto.
2:15 PM Changeset in webkit [125450] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

CanvasRenderContext2D::font() does not re-serialize the font
​https://bugs.webkit.org/show_bug.cgi?id=50859

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Added proper serialization for the font property.

No new tests, unskipped the existing ones.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::font):

LayoutTests:

Unskip tests that will now pass and remove wrong/duplicated
expectations. canvas-font-ex-units-crash has now the wrong
expectations until we fix the issue on 93840.

  • fast/canvas/canvas-font-ex-units-crash-expected.txt:
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js:

Even though we are setting a value on this test case (and verifying),
the font is not being effectiviely set as the serialization reveled. This
is going to be fixed in another bug.

  • platform/chromium/TestExpectations:
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
  • platform/qt/Skipped:
2:09 PM Changeset in webkit [125449] by Lucas Forschler
  • 8 edits in branches/safari-536.26-branch

Merged r118725 for <rdar://problem/11942136>

2:06 PM Changeset in webkit [125448] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

CSS quotes output quotes when depth is negative
​https://bugs.webkit.org/show_bug.cgi?id=92690

Patch by Elliott Sprehn <​esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.

Source/WebCore:

Previously if the quote depth would go negative we would output the close quote from the
first pair of quotes again instead of outputting no quotes as required by the spec.

See: ​http://www.w3.org/TR/CSS21/generate.html#quotes-insert

Test: fast/css-generated-content/nested-quote-more-than-pairs.html

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText): Allow the value passed to getOpenQuote to go negative by removing std::max.

  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::getOpenQuote): Bounds check for negative values for safety.
(WebCore::QuotesData::getCloseQuote): Allow index to be >= -1 and return an empty string for -1.

LayoutTests:

Make the expected output of close-quote-negative-depth.html follow the spec and
add another test that ensures the last quote pair is repeated when the depth is
greater than the number of quote pairs.

  • fast/css-generated-content/close-quote-negative-depth-expected.html:
  • fast/css-generated-content/close-quote-negative-depth.html:
  • fast/css-generated-content/nested-quote-more-than-pairs-expected.html: Added.
  • fast/css-generated-content/nested-quote-more-than-pairs.html: Added.
2:01 PM Changeset in webkit [125447] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

Unreviewed skip: Skip faling test after r125428.
The fix will be tracked in ​https://bugs.webkit.org/show_bug.cgi?id=93897

  • platform/qt/Skipped:
2:01 PM Changeset in webkit [125446] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-536.26-branch

Merged r118721 for <rdar://problem/11942136>

1:48 PM Changeset in webkit [125445] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Clear HUD canvas contents before drawing into it.
​https://bugs.webkit.org/show_bug.cgi?id=93759

Reviewed by Adrienne Walker.

Not clearing the bitmaps before drawing into it results into
random noise. This patch also caches the SkCanvas used by the HUD
to avoid reallocating it every frame.

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
1:44 PM Changeset in webkit [125444] by Simon Hausmann
  • 5 edits in trunk/Source

[Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap
​https://bugs.webkit.org/show_bug.cgi?id=93872

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

  • Target.pri: Add missing JSWeakObjectMap file to build.

Source/WebCore:

The intention of this patch series is to replace use of internal JSC
API with use of the stable and public C API.

The JSC::Weak template is internal API and the only part of the C API
that exposes similar functionality is the JSWeakObjectMap. It is
special in the sense that its life-time is tied to the life-time of the
JS global object, which in turn is subject to garbage collection. In
order to maximize re-use of the same map across different JSContextRef
instances, we use the associated global context ref as owner of the
weak maps. The key in the weak map is the identity (pointer) of the
runtime method object itself. The iteration through the maps is
tedious, but should usually not go beyond just a few.

  • bridge/qt/qt_runtime.cpp:

(Bindings):
(JSC::Bindings::methodMapCleaner):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):

  • bridge/qt/qt_runtime.h:

(QtRuntimeMethod):

1:38 PM Changeset in webkit [125443] by rakuco@webkit.org
  • 17 edits
    1 add
    3 deletes in trunk

[CMake] Remove glib-related Find modules and write single new one instead.
​https://bugs.webkit.org/show_bug.cgi?id=93786

Reviewed by Rob Buis.

.:

As part of the ongoing effort to write proper Find modules that use
absolute include and library paths instead of the short ones from
pkg-config, replace Find{GIO,Glib,Gthread}.cmake with a single
FindGLIB.cmake that optionally detects components such as GIO and
GObject.

Library paths are now defined as "/full/path/to/libfoo.so" instead of
simply "foo", so that the linker receives a full path and we can then
avoid accidentally picking up a libfoo.so installed into /usr/lib
instead of a local one built with jhbuild.

  • Source/cmake/FindGIO.cmake: Removed.
  • Source/cmake/FindGLIB.cmake: Added.
  • Source/cmake/FindGlib.cmake: Removed.
  • Source/cmake/FindGthread.cmake: Removed.
  • Source/cmake/OptionsEfl.cmake: Look for GLIB with the GIO component.

Source/JavaScriptCore:

  • shell/PlatformEfl.cmake: Use GLIB_* instead of Glib_*.

Source/WebCore:

No new tests, build system plumbing.

  • PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link

directly against GIO, as code in the soup network backend uses
that.

Source/WebKit:

  • PlatformEfl.cmake: Use GLIB_* instead of Glib_*.

Source/WebKit2:

  • PlatformEfl.cmake: Use GLIB_* instead of Glib_*.

Source/WTF:

  • wtf/PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link directly to GIO, as wtf/gobject uses functions from it.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
  • EWebLauncher/CMakeLists.txt: Ditto.
  • MiniBrowser/efl/CMakeLists.txt: Ditto.
  • WebKitTestRunner/PlatformEfl.cmake: Ditto.
1:33 PM Changeset in webkit [125442] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Simplify storage and reduce size of QtConnectionObject
​https://bugs.webkit.org/show_bug.cgi?id=93868

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

The connection object is a child of the sender QObject, so we can use parent()
whenever we need the sender instead of keeping an extra QObject pointer. Also
QtConnectionObject kept a RefPtr to the Instance, but actually only needed the
root object, so we can store a pointer to that instead.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):

  • bridge/qt/qt_runtime.h:

(QtConnectionObject):

1:23 PM Changeset in webkit [125441] by mifenton@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update API for spell checking suggestions again.
​https://bugs.webkit.org/show_bug.cgi?id=93877

Reviewed by Antonio Gomes.

PR 163283.

Update the spell checking options request API
to include the caret positions.

Reviewed internally by Nima Ghanavatian.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(WebKit):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

  • WebKitSupport/InputHandler.h:

(Platform):
(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

1:17 PM Changeset in webkit [125440] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well
​https://bugs.webkit.org/show_bug.cgi?id=93864

Reviewed by Eric Carlson.

Add the WEB_AUDIO to the Conditional attribute in MediaElementAudioSourceNode
IDL file and the ENABLE(WEB_AUDIO) compilation guard to the header files for both
MediaStreamAudioSourceNode and MediaElementAudioSourceNode.

No new tests - no new functionality.

  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.idl:
1:12 PM Changeset in webkit [125439] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

[Qt] Clean up exception handling
​https://bugs.webkit.org/show_bug.cgi?id=93880

Reviewed by Kenneth Rohde Christiansen.

The JSC C API uses a JSValueRef* exception parameter to indicate to the
caller that an exception was thrown. Naturally the caller must store
that ValueRef on the stack in order to get seen and marked by the
garbage collector, otherwise the callee would have to use
JSValueProtect on it.

This patch fixes one such case where in fact the exception pointer was passed as zero to the
callee and thus ignored. The patch also removes an unused exception parameter.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):

  • bridge/qt/qt_runtime.h:
1:05 PM Changeset in webkit [125438] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: remove commitEditing from the text editor delegate.
​https://bugs.webkit.org/show_bug.cgi?id=93858

Reviewed by Vsevolod Vlasov.

This should be up to the source frame.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._registerShortcuts):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.SourceFrame.prototype._handleKeyDown):
(WebInspector.SourceFrame.prototype._commitEditing):

  • inspector/front-end/TextEditor.js:
12:49 PM Changeset in webkit [125437] by commit-queue@webkit.org
  • 16 edits
    14 adds
    24 deletes in trunk

Unreviewed, rolling out r125430.
​http://trac.webkit.org/changeset/125430
​https://bugs.webkit.org/show_bug.cgi?id=93881

Caused css2.1/t1604-c541-word-sp-00-b-a.html to regress on Mac
builds (Requested by mwenge on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-13

Source/WebCore:

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::isWordEnd):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:

(HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::isCodepointSpace):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):

LayoutTests:

  • css2.1/20110323/c541-word-sp-001-expected.html: Removed.
  • css2.1/20110323/c541-word-sp-001.htm: Removed.
  • css2.1/20110323/word-spacing-characters-002-expected.html: Removed.
  • css2.1/20110323/word-spacing-characters-002.htm: Removed.
  • css2.1/20110323/word-spacing-characters-003-expected.html: Removed.
  • css2.1/20110323/word-spacing-characters-003.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-001-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-001.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-002-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-002.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-003-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-003.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-004-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-004.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-005-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-005.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-006-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-006.htm: Removed.
  • css2.1/t1604-c541-word-sp-01-b-a.html: Added.
  • fast/css/word-spacing-characters-complex-text-expected.html: Removed.
  • fast/css/word-spacing-characters-complex-text.html: Removed.
  • fast/css/word-spacing-characters-expected.html: Removed.
  • fast/css/word-spacing-characters.html: Removed.
  • fast/css/word-spacing-linebreak-expected.html: Removed.
  • fast/css/word-spacing-linebreak.html: Removed.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-linux/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/win/Skipped:
12:30 PM Changeset in webkit [125436] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

FrameLoader::receivedMainResourceError doesn't handle GET cancellations well.
​https://bugs.webkit.org/show_bug.cgi?id=93850

Patch by Mike West <​mkwst@chromium.org> on 2012-08-13
Reviewed by Adam Barth.

'FrameLoader::cancel' should reset the loader's state, and it mostly
does. In the case of a GET form submission, however, the submitted form
URL that's stored doesn't match the URL that's requested (query string).
This leads to the loader getting a bit confused about what's going on,
and not clearing the stored form submission URL.

This patch moves to storing the form submission's actual request URL
as opposed to the form action URL.

None of the current tests should break, and when issue 93777 lands, it
won't be broken either.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):

Switched to using 'FormSubmission::requestURL', as that matches the
URL that's actually requested during a form submission via GET.

12:25 PM Changeset in webkit [125435] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Hardware accelerated scrolling of <select> content
​https://bugs.webkit.org/show_bug.cgi?id=93856

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>

Internally reviewed by Matthew Staikos.

  • Resources/blackberry/selectControlBlackBerry.css: add -webkit-overflow-scrolling: touch (EOM).

(.select-area):

12:24 PM Changeset in webkit [125434] by tonikitoo@webkit.org
  • 6 edits in trunk/Source

[BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
​https://bugs.webkit.org/show_bug.cgi?id=93848
PR #190986

Reviewed by Yong Li.
Patch by Antonio Gomes <​agomes@rim.com>

Patch adds a WebKit thread setScrollPosition-like API to InRegionScroller.
It fixes a mismatch we had of setting a layer's scroll positing directly via
::setScrollPosition on the UI thread, but dispatching a coalesceable
scrollBy(delta) message to WebKit thread.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScroller::setScrollPositionCompositingThread):
Changed the API name to match other thread specific methods naming.
(WebKit):
(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
Added a setScrollPosition-like method to InRegionScroller public API. Used
together with its UI-thread counterpart, it can fix some rounding
errors we have due to mixing ::setScrollPosition and ::scrollBy methods.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
Method renamed. See reasons above.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
Calls fowards the call to ::setLayerScrollPosition (below).
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
Sets the scroll position of a given RenderLayer.

  • Api/InRegionScroller.h:

(InRegionScroller):

  • Api/InRegionScroller_p.h:

(WebCore):
(InRegionScrollerPrivate):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
Cache the RenderLayer object associated to a given scrollable area
instead of its LayerCompositingThread. This way we can use it for
scrolling from both Compositing/UI and WebKit threads.

12:24 PM Changeset in webkit [125433] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Assertion in RenderObject::offsetFromAncestorContainer
​https://bugs.webkit.org/show_bug.cgi?id=93845

Reviewed by Kenneth Rohde Christiansen.

Do not attempt to clip using layers that are not containers of the renderer.

  • page/GestureTapHighlighter.cpp:
12:09 PM Changeset in webkit [125432] by commit-queue@webkit.org
  • 5 edits in trunk

[Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo
​https://bugs.webkit.org/show_bug.cgi?id=93244

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Similar to Skia's and Qt's ImageBuffer implementation we need to make sure that buffers
for images are copied when the destination canvas is identical to the
image buffer's context. This happens mostly in JS calls to canvas' drawImage method.
For now fixing the drawImage case, drawPattern case is handled in bug 93854.

No new tests, covered by canvas/philip/tests/2d.drawImage.self.2.html

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw): Making sure buffer is copied when source and destination contexts are identical.

LayoutTests:

Unskipping canvas/philip/tests/2d.drawImage.self.2.html for GTK and EFL now that it's working.

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
12:07 PM Changeset in webkit [125431] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test css3/flexbox/line-wrapping.html failing
​https://bugs.webkit.org/show_bug.cgi?id=72490

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Gardening. Unskip now passing test.

  • platform/qt/Skipped:
11:55 AM Changeset in webkit [125430] by robert@webkit.org
  • 16 edits
    24 adds
    14 deletes in trunk

CSS 2.1 failure: Word-spacing affects each space and non-breaking space
​https://bugs.webkit.org/show_bug.cgi?id=89826

Reviewed by Eric Seidel.

Source/WebCore:

Add word spacing to consecutive spaces in a run per ​http://www.w3.org/TR/CSS21/text.html#spacing-props.

Test: fast/css/word-spacing-characters.html

fast/css/word-spacing-characters-complex-text.html
fast/css/word-spacing-characters-linebreak.html
css2.1/20110323/word-spacing-characters-002.htm
css2.1/20110323/word-spacing-characters-003.htm
css2.1/20110323/word-spacing-remove-space-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm
css2.1/20110323/c541-word-sp-001.htm

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): All spaces (ordinary space or &nbsp;) get word-spacing added, even

if they are consecutive.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use

m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
find it specified anywhere.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:

(WebCore::HarfBuzzShaperBase::isCodepointSpace):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): ditto, but for the complext text case on Mac.

The change to this file is speculative, I don't have a Mac build.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache): This code-path is not covered by any existing layout tests!

I've tried to come up with a test to hit it but have failed.

LayoutTests:

  • css2.1/20110323/c541-word-sp-001-expected.html: Added.
  • css2.1/20110323/c541-word-sp-001.htm: Added. Replaces t1604-c541-word-sp-01-b-a.html below.
  • css2.1/20110323/word-spacing-characters-002-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-002.htm: Added.
  • css2.1/20110323/word-spacing-characters-003-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-003.htm: Added. These passed already.
  • css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-001.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-002.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-003.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-004.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-005.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-006.htm: Added. These 6 tests are fixed by this patch.
  • css2.1/t1604-c541-word-sp-01-b-a.html: Removed. Per ​http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is now invalid and has been replaced by c541-word-sp-001.htm above.
  • fast/css/word-spacing-characters-complex-text-expected.html: Added.
  • fast/css/word-spacing-characters-complex-text.html: Added. This is a complex text version of word-spacing-characters-001.htm
  • fast/css/word-spacing-characters-expected.html: Added.
  • fast/css/word-spacing-characters.html: Added. The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case. This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced with word-spacing-characters-001.htm from the css test suite when ​https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
  • fast/css/word-spacing-linebreak-expected.html: Added.
  • fast/css/word-spacing-linebreak.html: Added.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-linux/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
11:45 AM Changeset in webkit [125429] by annacc@chromium.org
  • 5 edits in trunk

Remove webkitMediaSourceURL from HTMLMediaElement.idl
​https://bugs.webkit.org/show_bug.cgi?id=93619

Reviewed by Adam Barth.

The webkitMediaSourceURL attribute is no longer needed now that we use
createObjectURL() to generate a media source URL.

Source/WebCore:

Test: update http/test/media/media-source/media-source.js

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:

LayoutTests:

  • http/tests/media/media-source/media-source.js:

(MediaSourceTest.setSrcToMediaSourceTestURL):

10:53 AM Changeset in webkit [125428] by Simon Hausmann
  • 8 edits in trunk/Source

[Qt] Port meta method/signal/slot handling in run-time bridge to use JSC C API
​https://bugs.webkit.org/show_bug.cgi?id=93476

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Based on patch by No'am Rosenthal and lots of good suggestions by Caio Marcelo.

Ported the code that mapped invokable methods (and signals/slots) as
well as the code that provides the connect() and disconnect() functions
over to use the JSC C API. In the process one behavioural change was
implemented: Previously meta methods were actually function objects
that through Function.prototype allowed calling via
object.method.call(object). Through the use of plain JS objects that is
not possible anymore.

If we tried to continue to use function objects (JSObjectMakeFunction)
then we would loose the ability to store the private pointer. An
alternative approach would be to use a regular object and install the
Function prototype (Function.prototype), but unfortunately we cannot do
that without loosing the common prototype for signals and slots.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::newRuntimeObject):

  • bridge/qt/qt_instance.h:

(Bindings):
(QtInstance):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::connect):
(JSC::Bindings::QtRuntimeMethod::disconnect):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
(Bindings):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMethod::name):
(QtRuntimeMethod):
(QtConnectionObject):

Source/WebKit/qt:

Changed semantics of some test expectations. Similarly to r125032 when generating
error exceptions for connect/disconnect, we cannot generate explicit type error
exceptions but only generic errors. Another change is that the meta-method wrapper
doesn't support the call() through Function.prototype anymore. See WebCore changelog
for details.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::connectAndDisconnect):
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods):

10:42 AM Changeset in webkit [125427] by leandrogracia@chromium.org
  • 4 edits in trunk/Source

[Chromium] Fix nits in the find-in-page match rects API
​https://bugs.webkit.org/show_bug.cgi?id=93817

Reviewed by Adam Barth.

This patch fixes a few pending nits from 93111.

Source/WebCore:

Tests: existing WebKit unit test WebFrameTest.FindInPageMatchRects

  • dom/Range.cpp:

(WebCore::Range::transformFriendlyBoundingBox): add call to updateLayoutIgnorePendingStylesheets.

Source/WebKit/chromium:

  • src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument.

(WebKit::toNormalizedRect):
(WebKit::findInPageRectFromAbsoluteRect):

10:35 AM EFLWebKit edited by michalolczak@gmail.com
(diff)
9:49 AM Changeset in webkit [125426] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: get rid of beforeTextChanged
​https://bugs.webkit.org/show_bug.cgi?id=93851

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Merged beforeTextChanged and afterTextChanged into a single
onTextChanged event.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.editRange):
(WebInspector.CodeMirrorTextEditor.prototype._onChange):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._enterInternalTextChangeMode):
(WebInspector.DefaultTextEditor.prototype._exitInternalTextChangeMode):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.onTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.onTextChanged):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditorDelegate.prototype.onTextChanged):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype.onTextChanged):

LayoutTests:

  • http/tests/inspector/live-edit-test.js:

(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):

9:47 AM Changeset in webkit [125425] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[css] Remove "default" switch case from CSS primitive value mappings
​https://bugs.webkit.org/show_bug.cgi?id=93781

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-13
Reviewed by Alexey Proskuryakov.

Removing the "default" switch case allows compile-time early warning check,
specially useful for newly added or removed enumeration values.

  • css/CSSPrimitiveValueMappings.h:
9:45 AM Changeset in webkit [125424] by annacc@chromium.org
  • 5 edits in trunk/Source/WebCore

Cap the number of SourceBuffers that may be added to a MediaSource.
​https://bugs.webkit.org/show_bug.cgi?id=93406

Reviewed by Eric Carlson.

Make sure that no more SourceBuffer objects are added to a MediaSource
than can fit into the sourceBuffers SourceBufferList (internally stored
as a Vector). Also, make sure that new SourceBuffers are added with a
unique id even if the variable we are using to generate id wraps around.

No new tests. It would not be realistic to add so many SourceBuffers to
test the id variable wrapping. Existing tests should not be affected.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::addSourceBuffer): Obtain a unique id before creating

a new SourceBuffer.

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::generateUniqueId): Search for and generate a

unique id.

(WebCore):
(WebCore::SourceBufferList::contains): Check if a SourceBuffer with a

given id already exists in this SourceBufferList.

  • Modules/mediasource/SourceBufferList.h:

(SourceBufferList):

9:41 AM Changeset in webkit [125423] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Update TestExpectations to make bot green
​https://bugs.webkit.org/show_bug.cgi?id=93852

Unreviewed EFL gardening. Update wk2-efl TestExpectations
to make the bot green.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
9:40 AM Changeset in webkit [125422] by peter@chromium.org
  • 5 edits in trunk

[Chromium] Fix apk generation for the Android platform
​https://bugs.webkit.org/show_bug.cgi?id=93841

Reviewed by Dimitri Glazkov.

APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
9:36 AM Changeset in webkit [125421] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[SOUP][WK2] Missing LocalTerminationDisabler in WebCookieManager::setCookiePersistentStorage()
​https://bugs.webkit.org/show_bug.cgi?id=93837

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Carlos Garcia Campos.

Add missing WebCore::LocalTerminationDisabler in
WebCookieManager::setCookiePersistentStorage() to
temporarily disable process termination.

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::setCookiePersistentStorage):

8:50 AM Changeset in webkit [125420] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:54 AM Changeset in webkit [125419] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: when status bar is too narrow, cut panel status bar, not main status bar items
​https://bugs.webkit.org/show_bug.cgi?id=93814

Reviewed by Pavel Feldman.

  • set shrink factor of bottom-status-bar-container to 1;
  • set bottom-status-bar-container's width to 0 to workaround for flex-basis being ignored;
  • inspector/front-end/inspector.css:

(#bottom-status-bar-container):

7:19 AM Changeset in webkit [125418] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
​https://bugs.webkit.org/show_bug.cgi?id=93825

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-08-13
Reviewed by Antonio Gomes.

Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFailLoadForResource):

6:43 AM Changeset in webkit [125417] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, updating test expectation for
canvas/philip/tests/2d.drawImage.self.2.html to note that
bug #93244 tracks the regression.

  • platform/gtk/TestExpectations:
6:31 AM Changeset in webkit [125416] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a failing test.

  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
6:24 AM Changeset in webkit [125415] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add memory instrumentation for Attribute
​https://bugs.webkit.org/show_bug.cgi?id=93827

Reviewed by Pavel Feldman.

Attribute's name and value footprint is counted as part of the DOM
component.

  • dom/Attribute.h:

(WebCore::Attribute::reportMemoryUsage):
(Attribute):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

6:19 AM Changeset in webkit [125414] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-13

  • DEPS:
5:58 AM Changeset in webkit [125413] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Polish search/replace toolbar buttons style.
​https://bugs.webkit.org/show_bug.cgi?id=93826

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(.toolbar-search button):

5:35 AM Changeset in webkit [125412] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[EFL] fast/box-sizing/box-sizing.html needs new baseline after r124347
​https://bugs.webkit.org/show_bug.cgi?id=93823

Unreviewed EFL gardening.

Provide new baseline for fast/box-sizing/box-sizing.html,
needed after r124347.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/fast/box-sizing/box-sizing-expected.png:
  • platform/efl/fast/box-sizing/box-sizing-expected.txt: Added.
5:07 AM Changeset in webkit [125411] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[Qt] Add gprof.prf to build WebKit with gprof enabled
​https://bugs.webkit.org/show_bug.cgi?id=90283

Patch by Kwang Yul Seo <​skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.

Source/WebCore:

No behavior change, so no new tests.

  • WebCore.pri:

-ffunction-sections conflicts with -pg option, so don't use
-ffunction-sections option when gprof is enabled.

Source/WebKit/qt:

  • tests/MIMESniffing/MIMESniffing.pro:

Don't build MIMESniffing.cpp because MIMESniffing test links
WebKitQt statically when gprof is enabled.

Tools:

  • qmake/mkspecs/features/functions.prf:

gprof does not support profiling a shared library.
To profile WebKit, applications must link QtWebKit statically.

  • qmake/mkspecs/features/gprof.prf: Added.

Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.

5:00 AM Changeset in webkit [125410] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r125408, removing another usage of SVG_FEATURES.

  • GNUmakefile.am:
4:54 AM Changeset in webkit [125409] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][WK2] Skip inspector tests that hit assertion in WebCore::SuspendableTimer::resume()
​https://bugs.webkit.org/show_bug.cgi?id=93815

Unreviewed EFL gardening.

Update TestExpectations for several flaky Web Inspector
test cases.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:42 AM Changeset in webkit [125408] by zandobersek@gmail.com
  • 4 edits in trunk

[Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am
​https://bugs.webkit.org/show_bug.cgi?id=90693

Reviewed by Philippe Normand.

.:

Remove exportation of SVG_FLAGS and HTML_FLAGS as Automake conditionals
as they are not required anymore.

  • configure.ac:

Source/WebCore:

Remove SVG_FEATURES and HTML_FEATURES variables. They can be replaced by the
FEATURE_DEFINES variable wherever they are used.

No new tests - no new functionality.

  • GNUmakefile.am:
4:38 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
3:35 AM Changeset in webkit [125407] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
​https://bugs.webkit.org/show_bug.cgi?id=93600

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-08-13
Reviewed by Xan Lopez.

Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init): Do not install a default signal handler.

3:16 AM Changeset in webkit [125406] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
3:15 AM Changeset in webkit [125405] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Wrong TestExpectations for 2 webintents tests
​https://bugs.webkit.org/show_bug.cgi?id=93811

Unreviewed EFL gardening.

Update expected state for the following webintents tests
to make the tree green:
webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
3:01 AM Changeset in webkit [125404] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing/crashing tests.

  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
2:42 AM Changeset in webkit [125403] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
​https://bugs.webkit.org/show_bug.cgi?id=93804

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Use the 'length' parameter to insert a substring of the full
string passed to this method from AtkEditableText interface.

  • accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:

(webkitAccessibleEditableTextInsertText): Don't ignore 'length'.

Source/WebKit/gtk:

Update unit tests to also check inserting a partial string.

  • tests/testatk.c:

(testWebkitAtkTextChangedNotifications): Update test.

2:33 AM Changeset in webkit [125402] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Feature Request - Adding mouse gesture for editing attribute values in elements/css panel
​https://bugs.webkit.org/show_bug.cgi?id=93581

Patch by Sam D <​dsam2912@gmail.com> on 2012-08-13
Reviewed by Alexander Pavlov.

Added functionality to modify valuesAdding support for updating number values in attributes in element
panel/ css panel using mouse gestures as well.

No new tests.

  • inspector/front-end/StylesSidebarPane.js:

handling mousewheel event

  • inspector/front-end/TextPrompt.js:

adding mouse event listener
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onMouseWheel):

  • inspector/front-end/UIUtils.js:

handling mouse event gesture and updating number based on mouse wheel
scroll direction as well.
(WebInspector._valueModificationDirection):
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):

2:29 AM Changeset in webkit [125401] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[TestNetscapePlugin][X11] Additional key up event handler routine is required
​https://bugs.webkit.org/show_bug.cgi?id=91357

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-08-13
Reviewed by Eric Seidel.

Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
has-focus.html on X11 architecture. The test can not be done without this patch.
All other ports implemented it already.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventX11): Modified key up event handler for X11

2:28 AM Changeset in webkit [125400] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file.
2:06 AM Changeset in webkit [125399] by apavlov@chromium.org
  • 16 edits in trunk

Web Inspector: [Protocol] Force elements pseudo state via a separate InspectorCSSAgent method
​https://bugs.webkit.org/show_bug.cgi?id=93721

Reviewed by Pavel Feldman.

Source/WebCore:

Introduce InspectorCSSAgent::forcePseudoState() to modify the element's forced pseudo state.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.forcePseudoState):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):

  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):

LayoutTests:

  • http/tests/inspector/modify-cross-domain-rule.html:
  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-new-API-expected.txt:
1:26 AM Changeset in webkit [125398] by commit-queue@webkit.org
  • 3 edits
    1 add
    1 delete in trunk

[EFL][WK2] Replace Skipped list by TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=93796

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Tools:

Enable cascaded TestExpectations for EFL port so
that we can use TestExpectations in WK2-EFL.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._search_paths):
(EflPort):
(EflPort.expectations_files):

LayoutTests:

Replace efl-wk2 Skipped file by TestExpectations now
that we support cascaded TestExpectations in EFL
port.

  • platform/efl-wk2/Skipped: Removed.
  • platform/efl-wk2/TestExpectations: Added.
1:22 AM Changeset in webkit [125397] by shinyak@chromium.org
  • 5 edits
    2 adds in trunk

Cannot select the AuthorShadowDOM inner element of an img element
​https://bugs.webkit.org/show_bug.cgi?id=91591

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since HTMLImageElement::canStartSelection always returns false, we cannot start selection
from any children (including shadow dom) of an img element. When the img element has a shadow dom,
we should be able to start selection.

Test: fast/dom/shadow/select-image-with-shadow.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::canStartSelection):
(WebCore):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/shadow/ImageInnerElement.h:

(WebCore::ImageInnerElement::canStartSelection): Since ImageInnerElement is really an image,
this should return always false to obey the exising behavior.
(ImageInnerElement):

LayoutTests:

  • fast/dom/shadow/select-image-with-shadow-expected.txt: Added.
  • fast/dom/shadow/select-image-with-shadow.html: Added.
1:11 AM Changeset in webkit [125396] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

REGRESSION(r125153): It broke the 'Unexpected no expected results' case
​https://bugs.webkit.org/show_bug.cgi?id=93789

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2012-08-13
Reviewed by Csaba Osztrogonác.

Fix the regex, so the text won't be a capturing group.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests._parseNewRunWebKitTestsOutput):

12:52 AM Changeset in webkit [125395] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Add expectations for flaky tests.

  • platform/chromium/TestExpectations:
12:19 AM Changeset in webkit [125394] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=93387

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-08-13
Reviewed by Pavel Feldman.

Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
of "column" to make the behavior back to the time as JSC cannot provide "column" info.
Refer to ​https://bugs.webkit.org/show_bug.cgi?id=93473.

No new test case for this bug.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

Note: See TracTimeline for information about the timeline view.