Context Navigation

← Previous Period
Next Period →

Timeline

Aug 16, 2012:

11:59 PM WikiStart edited by toyoshim@chromium.org

(diff)

11:32 PM Changeset in webkit [125862] by commit-queue@webkit.org

4 edits in trunk/Tools

[jhbuild] EFL now runs jhbuild update for every build
https://bugs.webkit.org/show_bug.cgi?id=94267

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2012-08-16
Reviewed by Dirk Pranke.

This change makes EFL's approach to jhbuild more in line with the one
used by WebKitGTK+. update-webkitefl-libs will only be called by build-
webkit if --update-efl is given explicitly. The EWS bot will do that
from now on.

Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
Dependencies directory exists also for EFL
(generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
(buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
given

Scripts/webkitpy/common/config/ports.py:

(EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit

Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_efl_port): add unit testing for EFL port

11:23 PM Changeset in webkit [125861] by enne@google.com

5 edits in trunk/LayoutTests

[chromium] Rebaseline media-document-audio-repaint after Chromium r151988

Unreviewed gardening.

platform/chromium-linux/media/media-document-audio-repaint-expected.png:
platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
platform/chromium-mac/media/media-document-audio-repaint-expected.png:
platform/chromium-win/media/media-document-audio-repaint-expected.png:

11:15 PM Changeset in webkit [125860] by vsevik@chromium.org

12 edits
1 delete in trunk

Web Inspector: Snippet script mapping should not load snippets until workspace reset event is dispatched on scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=94218

Reviewed by Pavel Feldman.

Source/WebCore:

Scripts panel does not load uiSourceCodes in workspace reset handler anymore.
Snippet script mapping does not start reloading snippets after reset until WorkspaceReset event is dispatched.

inspector/front-end/JavaScriptSourceFrame.js: Simplified isComittingEditing to be reset synchronously.

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._reset):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._reset):

inspector/front-end/UISourceCodeFrame.js: Simplified isComittingEditing to be reset synchronously.

(WebInspector.UISourceCodeFrame.prototype.commitEditing):
(WebInspector.UISourceCodeFrame.prototype._didEditContent):

LayoutTests:

http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

inspector/debugger/script-snippet-model-expected.txt:
inspector/debugger/script-snippet-model.html: added a check that snippet uiSourceCode is correctly recreated after workspace reset.
inspector/debugger/scripts-panel-expected.txt:
inspector/debugger/scripts-panel.html:
platform/chromium/inspector/debugger/script-snippet-model-expected.txt: Removed.

11:10 PM Changeset in webkit [125859] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Failure to build with --no-inspector
https://bugs.webkit.org/show_bug.cgi?id=94148

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-16
Reviewed by Noam Rosenthal.

Add guards around usage of inspector functions.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::remoteInspectorUrl):

11:02 PM Changeset in webkit [125858] by enne@google.com

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r125829.
http://trac.webkit.org/changeset/125829
https://bugs.webkit.org/show_bug.cgi?id=94299

Maybe causing Chromium AutomationTabHelperBrowserTest failures
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):

loader/FrameLoader.h:

(FrameLoader):

10:51 PM Changeset in webkit [125857] by yosin@chromium.org

2 edits in trunk/LayoutTests

[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=94297

Unreviewed. Temporary disabled time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows

platform/chromium/TestExpectations:

10:32 PM Changeset in webkit [125856] by enne@google.com

2 edits
1 copy in trunk/LayoutTests

Rebaseline overflow-scroll-overlap to pass on both Mac and Chromium

Unreviewed expectation gardening.

compositing/layer-creation/overflow-scroll-overlap-expected.txt:
platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt.

10:24 PM Changeset in webkit [125855] by tkent@chromium.org

2 edits in trunk/Source/WTF

Build fix for Chromium-mac.

wtf/text/WTFString.cpp: Remove unnecessary includes.

10:21 PM Changeset in webkit [125854] by yosin@chromium.org

3 edits in trunk/LayoutTests

[Tests] Remove redundant text from fast/forms/resources/common-change-type-on-focus.js
https://bugs.webkit.org/show_bug.cgi?id=94293

Reviewed by Kent Tamura.

This patch removes bug number text in description for sharing code
among input types.

fast/forms/number/number-change-type-on-focus-expected.txt:
fast/forms/resources/common-change-type-on-focus.js:

10:17 PM Changeset in webkit [125853] by thakis@chromium.org

3 edits in trunk/Source/WebCore

[chromium/mac] Remove RenderThemeChromiumMac::paintTextField override
https://bugs.webkit.org/show_bug.cgi?id=94276

Reviewed by Eric Seidel.

The comment says this can go once 10.5 goes away. Besides, the
superclass implementation has the same hack anyway.

No behavior change.

rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):

rendering/RenderThemeChromiumMac.mm:

9:51 PM Changeset in webkit [125852] by commit-queue@webkit.org

3 edits
3 adds in trunk

@import url("#foo") causes stack overflow
https://bugs.webkit.org/show_bug.cgi?id=93687

Patch by David Barr <davidbarr@chromium.org> on 2012-08-16
Reviewed by Tony Chang.

Source/WebCore:

Test: http/tests/css/css-imports-url-fragment.html

css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet): Ignore the fragment identifier in cycle detection.

LayoutTests:

http/tests/css/css-imports-url-fragment-expected.txt: Added.
http/tests/css/css-imports-url-fragment.css: Added.
http/tests/css/css-imports-url-fragment.html: Added.

9:25 PM Changeset in webkit [125851] by piman@chromium.org

5 edits in trunk/Source

[chromium] Add resource transfer functions to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93524

Reviewed by James Robinson.

This adds methods to CCResourceProvider to be able to transport
resources from a child to a parent.

Added test to CCResourceProviderTest.

Source/WebCore:

platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::createChild):
(WebCore):
(WebCore::CCResourceProvider::destroyChild):
(WebCore::CCResourceProvider::getChildToParentMap):
(WebCore::CCResourceProvider::prepareSendToParent):
(WebCore::CCResourceProvider::prepareSendToChild):
(WebCore::CCResourceProvider::receiveFromChild):
(WebCore::CCResourceProvider::receiveFromParent):
(WebCore::CCResourceProvider::transferResource):

platform/graphics/chromium/cc/CCResourceProvider.h:

(Mailbox):
(TransferableResource):
(TransferableResourceList):
(CCResourceProvider):
(Resource):
(Child):

Source/WebKit/chromium:

tests/CCResourceProviderTest.cpp:

(WebKit::textureSize):
(WebKit):
(WebKit::Texture::Texture):
(Texture):
(ContextSharedData):
(WebKit::ContextSharedData::create):
(WebKit::ContextSharedData::insertSyncPoint):
(WebKit::ContextSharedData::genMailbox):
(WebKit::ContextSharedData::produceTexture):
(WebKit::ContextSharedData::consumeTexture):
(WebKit::ContextSharedData::ContextSharedData):
(WebKit::ResourceProviderContext::create):
(ResourceProviderContext):
(WebKit::ResourceProviderContext::insertSyncPoint):
(WebKit::ResourceProviderContext::waitSyncPoint):
(WebKit::ResourceProviderContext::genMailboxCHROMIUM):
(WebKit::ResourceProviderContext::produceTextureCHROMIUM):
(WebKit::ResourceProviderContext::consumeTextureCHROMIUM):
(WebKit::ResourceProviderContext::ResourceProviderContext):
(PendingProduceTexture):
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(CCResourceProviderTest):
(WebKit::TEST_F):

9:21 PM Changeset in webkit [125850] by dgrogan@chromium.org

51 edits
5 copies
1 add in trunk

IndexedDB: Frontend and plumbing for integer versions
https://bugs.webkit.org/show_bug.cgi?id=92897

Source/WebCore:

Reviewed by Tony Chang.

This patch exposes integer versions and the upgradeneeded event to
script.

The events surrounding an IDBOpenDBRequest follow a new pattern
compared to other idb requests. An open request can receive a blocked
event, an upgradeneeded event, and then a success event. When
dispatching the upgradeneeded and success events the request has its
readyState set to DONE and its result property set to an IDBDatabase.
We usually think of IDBRequests firing one event with one result,
cursors being the big exception. There are some minor changes around
enqueuing and dispatching events to support this.

There's also some funkiness in
IDBRequest::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>) so that
the IDBDatabase object delivered in upgradeneeded is reused for the
success event.

Tests - expectations are updated in this patch.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::onVersionChange):
(WebCore):
(WebCore::IDBDatabase::registerFrontendCallbacks):

Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

Modules/indexeddb/IDBDatabaseCallbacks.h:

(IDBDatabaseCallbacks):

Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
(WebCore):

Modules/indexeddb/IDBDatabaseCallbacksImpl.h:

(IDBDatabaseCallbacksImpl):

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore):

Modules/indexeddb/IDBFactory.h:

(IDBFactory):

Modules/indexeddb/IDBFactory.idl:
Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

Modules/indexeddb/IDBOpenDBRequest.cpp: Added.

(WebCore):
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::~IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::interfaceName):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::shouldEnqueueEvent):

Modules/indexeddb/IDBOpenDBRequest.h: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacksImpl.h.

(WebCore):
(IDBOpenDBRequest):

Modules/indexeddb/IDBOpenDBRequest.idl: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacks.h.
Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::shouldEnqueueEvent):
(WebCore::IDBRequest::onSuccess):
This function works with WebIDBCallbacksImpl::onSuccess to reuse its
IDBDatabaseBackendInterface that it got during
IDBOpenDBRequest::onUpgradeNeeded.

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::transactionDidDispatchCompleteOrAbort):
(WebCore):
(WebCore::IDBRequest::enqueueEvent):

Modules/indexeddb/IDBRequest.h:

(WebCore::IDBRequest::onBlocked):
(IDBRequest):

Modules/indexeddb/IDBTransaction.cpp:

We now take a pointer to the openDBRequest if this is a version
change transaction as a result of an open-with-version call so that we
can clear the transaction property on the openDBRequest as soon as the
upgradeneeded event is dispatched per the spec ("... set request's
transaction property to null... ", currently 4.8.12).

(WebCore::IDBTransaction::create):
(WebCore):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::setActive):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):

Modules/indexeddb/IDBTransaction.h:

(WebCore):
(IDBTransaction):

Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::commit):

Modules/indexeddb/IDBUpgradeNeededEvent.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp.

(WebCore):
(WebCore::IDBUpgradeNeededEvent::create):
(WebCore::IDBUpgradeNeededEvent::IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::~IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::oldVersion):
(WebCore::IDBUpgradeNeededEvent::newVersion):
(WebCore::IDBUpgradeNeededEvent::interfaceName):

Modules/indexeddb/IDBUpgradeNeededEvent.h: Copied from Source/WebKit/chromium/src/WebIDBDatabaseCallbacksImpl.h.

(WebCore):
(IDBUpgradeNeededEvent):

Modules/indexeddb/IDBUpgradeNeededEvent.idl: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacks.h.
WebCore.gypi:
dom/EventNames.h:

(WebCore):

dom/EventNames.in:
dom/EventTargetFactory.in:
inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onBlocked):
(WebKit):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):

src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::setVersion):

src/IDBDatabaseCallbacksProxy.cpp:

(WebKit::IDBDatabaseCallbacksProxy::onVersionChange):
(WebKit):

src/IDBDatabaseCallbacksProxy.h:

(IDBDatabaseCallbacksProxy):

src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::open):

src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

src/IDBTransactionCallbacksProxy.cpp:

(WebKit::IDBTransactionCallbacksProxy::onComplete):

src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
(WebKit::WebIDBCallbacksImpl::onSuccess):
We don't want to create IDBDatabaseBackendProxy again if we've already
created it during upgradeNeeded. This makes
IDBRequest::onSuccess(IDBDatabaseBackend) reuse its previous
IDBDatabaseBackendInterface if it has one.

(WebKit::WebIDBCallbacksImpl::onBlocked):
(WebKit):
(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):

src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

src/WebIDBDatabaseCallbacksImpl.cpp:

(WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
(WebKit):

src/WebIDBDatabaseCallbacksImpl.h:

(WebIDBDatabaseCallbacksImpl):

src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
(WebKit::WebIDBDatabaseImpl::open):

src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):

src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

src/WebIDBTransactionCallbacksImpl.cpp:

(WebKit::WebIDBTransactionCallbacksImpl::onComplete):

tests/IDBAbortOnCorruptTest.cpp:

(WebCore::TEST):

tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

This patch exposes integer versions and the upgradeneeded event to
script so upgradeneeded events are now fired mostly per expectations.
This is the bulk of changes to the expected files, further intversion
patches will change the behavior of a test or two, nothing wholesale.

Reviewed by Tony Chang.

storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
storage/indexeddb/intversion-and-setversion-expected.txt:
storage/indexeddb/intversion-blocked-expected.txt:
storage/indexeddb/intversion-close-between-events-expected.txt:
storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
storage/indexeddb/intversion-gated-on-delete-expected.txt:
storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
storage/indexeddb/intversion-long-queue-expected.txt:
storage/indexeddb/intversion-open-with-version-expected.txt:

9:10 PM Changeset in webkit [125849] by yosin@chromium.org

4 edits
17 adds in trunk

[Forms] Cleanup CSS selectors for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94287

Reviewed by Kent Tamura.

Source/WebCore:

This patch cleans CSS selectors for multiple fields time input UI:

Removed "width" from fields: we use monospace font for field.
Use "em" instead of "px" for unit.
Add left margin to spin button.

Changes of this patch affect only both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS are enabled.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html

fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html

css/html.css:

(input::-webkit-datetime-edit-ampm-field):
(input::-webkit-datetime-edit-hour-field):
(input::-webkit-datetime-edit-millisecond-field):
(input::-webkit-datetime-edit-minute-field):
(input::-webkit-datetime-edit-second-field):
(input[type=time]::-webkit-inner-spin-button):

LayoutTests:

This patch introduces tests for multiple fields time input UI appearance
when both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
are enabled.

Note: We need to do rebaseline for Chromium-Mac and Chromium-Win.

fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.css: Added.
fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Added.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
platform/chromium/TestExpectations: Added MISSING entries for Chromium-Mac and Chromium-Win.

8:34 PM Changeset in webkit [125848] by tkent@chromium.org

2 edits in trunk/Tools

Add forms-bugs@chromium.org as a contributor.

Scripts/webkitpy/common/config/committers.py:

7:52 PM Changeset in webkit [125847] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix vsync-disabled Null pointer crash bug
https://bugs.webkit.org/show_bug.cgi?id=94280

Patch by John Bates <jbates@google.com> on 2012-08-16
Reviewed by Kentaro Hara.

The m_timeSource member is NULL for vsync-disabled path, need to check for that.

Tests: Covered by Chromium throughput tests. All the compositor thread throughput tests are crashing.

platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setTimebaseAndInterval):

7:44 PM Changeset in webkit [125846] by msaboff@apple.com

9 edits in trunk/Source

HTML Parser should produce 8bit substrings for inline style and script elements
https://bugs.webkit.org/show_bug.cgi?id=93742

Reviewed by Benjamin Poulain.

Source/WebCore:

Currently all data associated with a token is stored and processed as UChars.
Added code to determine that the contents of token data is all 8 bit by keeping
the logical OR value of all prior characters. Also added a flag that the parser
can set to indicate when the token data is converted to a String that we want
to make an 8 bit string if possible. Enabled this handling for script, style,
iframe, noembed, noframes, noscript and xmp tags.

No new tests. Existing tests provide coverage.

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::isAll8BitData):
(HTMLTreeBuilder::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemaining):

xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::clear):
(WebCore::MarkupTokenBase::appendToCharacter):
(MarkupTokenBase):
(WebCore::MarkupTokenBase::eraseCharacters):
(WebCore::MarkupTokenBase::setConvertTo8Bit):
(WebCore::MarkupTokenBase::isAll8BitData):
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::isAll8BitData):
(AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):

Source/WTF:

Added 8 bit path to String::isAllSpecialCharacters(). Added new String creator
that takes a pointer to a UChar array that is known to contain only 8 bit
characters (LChar's). Added new helper method to copy contents of a
UChar buffer to a LChar buffer. The helper method includes X86-64 intrinsics
of SSE family instructions for performance.

wtf/Alignment.h:

(WTF::isAlignedTo):

wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

wtf/text/WTFString.cpp:

(WTF::String::make8BitFrom16BitSource):

wtf/text/WTFString.h:

(String):
(WTF::isAllSpecialCharacters):
(WTF::String::isAllSpecialCharacters):

7:17 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com

Remove by … (diff)

7:04 PM Changeset in webkit [125845] by Michelangelo De Simone

9 edits in trunk

[Part 3] Parse the custom() function in -webkit-filter: parse the 3d-transforms parameters
https://bugs.webkit.org/show_bug.cgi?id=71443

Reviewed by Dirk Schulze.

Source/WebCore:

custom() now correctly parses the 3d-tranforms parameters. In order to do that the parseTransform() method
has been refactored and split to reuse already present code.

css/CSSParser.cpp:

(WebCore::parseTranslateTransformValue): Renamed from parseTransformValue()
(WebCore::CSSParser::parseValue): Reference updated from parseTransformValue() to parseTranslateTransformValue()
(WebCore::CSSParser::parseTransform): This method has been split in two to reuse already present code
(WebCore):
(WebCore::CSSParser::parseTransformValue): New method to parse single transform values
(WebCore::CSSParser::parseCustomFilter): Updated to parse the transform parameters
(WebCore::CSSParser::parseCustomFilterTransform): New method to parse custom() transforms

css/CSSParser.h:

LayoutTests:

New round of tests for custom() to assess the correct parsing of the 3d-transform parameters.

css3/filters/custom/custom-filter-property-parsing-expected.txt:
css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
css3/filters/script-tests/custom-filter-property-parsing.js:
platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:

6:46 PM Changeset in webkit [125844] by enne@google.com

5 edits in trunk/Source

Unreviewed, rolling out r125838.
http://trac.webkit.org/changeset/125838
https://bugs.webkit.org/show_bug.cgi?id=94283

Breaks Mac compile due to bug 74625 (Requested by enne on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

Source/WebCore:

platform/graphics/chromium/cc/CCResourceProvider.cpp:

platform/graphics/chromium/cc/CCResourceProvider.h:

(CCResourceProvider):
(Resource):

Source/WebKit/chromium:

tests/CCResourceProviderTest.cpp:

(WebKit::ResourceProviderContext::create):
(WebKit::ResourceProviderContext::textureSize):
(ResourceProviderContext):
(WebKit::ResourceProviderContext::ResourceProviderContext):
(WebKit::ResourceProviderContext::Texture::Texture):
(Texture):
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(CCResourceProviderTest):
(WebKit::TEST_F):

6:43 PM Changeset in webkit [125843] by kbr@google.com

13 edits in trunk/Source

Unreviewed, rolling out r125800.
http://trac.webkit.org/changeset/125800
https://bugs.webkit.org/show_bug.cgi?id=84281

Hypothesis that this change caused gpu_throughput_tests to
start timing out on all platforms on the Chromium GPU
canaries.

Source/WebCore:

platform/graphics/chromium/cc/CCFrameRateController.cpp:
platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

platform/graphics/chromium/cc/CCScheduler.h:

(CCSchedulerClient):

platform/graphics/chromium/cc/CCTextureUpdateController.cpp:

platform/graphics/chromium/cc/CCTextureUpdateController.h:

(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
(FakeCCTimeSource):

tests/CCTextureUpdateControllerTest.cpp:

6:37 PM Changeset in webkit [125842] by enne@google.com

1 edit in branches/chromium/1229/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp

Merge 125702 - [chromium] Must account for empty transformation lists when checking for big rotations.
https://bugs.webkit.org/show_bug.cgi?id=93975

Reviewed by James Robinson.

Source/WebCore:

AnimationTranslationUtil.cpp is supposed to reject large rotations
(>= 180 degrees between keyframes). The current code assumes that if
the lists of transforms at two consecutive keyframes do not match
(i.e., are different types), then do not need to reject. The rationale
is that we will revert to matrix blending -- we will collapse the lists
of transform operations to matrices at each keyframe and blend those.
Unfortunately, this is not true if a list is empty. It can be the case
that we transition from no transform to a rotation about the z axis of
360 degrees. In this case, the first list of transform operations will
be empty and the second will have a single rotation of 360 degrees. An
empty list should be treated as a rotation of zero degrees.

Unit tested in: GraphicsLayerChromiumTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList

platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::causesRotationOfAtLeast180Degrees):

Source/WebKit/chromium:

Adds a test to check that creating an animation with a big (> 180
degree) rotation, where the transform operations list in the 1st
keyframe is empty fails as expected.

tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):
(WebKit):

TBR=vollick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836307

6:34 PM Changeset in webkit [125841] by kbr@google.com

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r125833.
http://trac.webkit.org/changeset/125833
https://bugs.webkit.org/show_bug.cgi?id=94234

Was not the cause of the test failures. Per
http://crbug.com/143311 , it is probably WebKit r125800.

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::deferredCanvas):
(WebCore):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::skCanvas):

platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

platform/graphics/skia/ImageBufferSkia.cpp:

6:31 PM Changeset in webkit [125840] by Lucas Forschler

1 copy in tags/Safari-537.6

New Tag.

6:24 PM Changeset in webkit [125839] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Remove test expectations for fast/overflow/line-clamp-and-columns.html on mac
https://bugs.webkit.org/show_bug.cgi?id=94270

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-16
Reviewed by Brady Eidson.

Unmark fast/overflow/line-clamp-and-columns.html as an expected failure, since
it passes after the fix for https://bugs.webkit.org/show_bug.cgi?id=94080.

platform/mac/TestExpectations:

6:16 PM Changeset in webkit [125838] by piman@chromium.org

5 edits in trunk/Source

[chromium] Add resource transfer functions to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93524

Reviewed by James Robinson.

This adds methods to CCResourceProvider to be able to transport
resources from a child to a parent.

Added test to CCResourceProviderTest.

Source/WebCore:

platform/graphics/chromium/cc/CCResourceProvider.cpp:

platform/graphics/chromium/cc/CCResourceProvider.h:

(Mailbox):
(TransferableResource):
(TransferableResourceList):
(CCResourceProvider):
(Resource):
(Child):

Source/WebKit/chromium:

tests/CCResourceProviderTest.cpp:

6:06 PM Changeset in webkit [125837] by tkent@chromium.org

2 edits in trunk/Source/WebCore

[Chromium-win] Use native digits in a case of "context" substitution setting too.
https://bugs.webkit.org/show_bug.cgi?id=94210

Reviewed by Hajime Morita.

Use native digits in a case of "context" substitution setting, not only
"native" substitution. IE10's input[type=number] always show native
digits even if the system setting is "context". We had better follow
this behavior.

No new tests. This behavior depends on the system locale setting.

platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::initializeNumberLocalizerData):
Uses 0-9 only if the substitution setting is "0 to 9". It measn we apply
native digits if the substitution setting is "context" or "native".

6:06 PM Changeset in webkit [125836] by leviw@chromium.org

2 edits
1 add in trunk/LayoutTests

Unreviewed gardening.

r125694 incorrectly updated mac expectations for the below test instead of
Chromium Mac. Moving the updated expectations to Chromium and reverting the
incorrect Mac expectations.

platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Added.
platform/mac/tables/mozilla/bugs/bug55527-expected.txt:

6:03 PM Changeset in webkit [125835] by enne@google.com

2 edits in trunk/LayoutTests

[chromium] Mark fast/forms/file/selected-files-from-history-state.html as failing
https://bugs.webkit.org/show_bug.cgi?id=94278

Unreviewed gardening.

platform/chromium/TestExpectations:

5:49 PM Changeset in webkit [125834] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Texmap] Render gif animation well.
https://bugs.webkit.org/show_bug.cgi?id=93458

Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-16
Reviewed by Noam Rosenthal.

GraphicsLayerTextureMapper::setContentsToImage() checks the pointer to the
image, not nativeImagePtr, so Texmap currently draws only the first frame of gif
animations. This patch makes Texmap draw gif animations.

No new tests, could not write a test due to DRT limitation, see Bug 93458.

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

5:47 PM Changeset in webkit [125833] by kbr@google.com

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r125804.
http://trac.webkit.org/changeset/125804
https://bugs.webkit.org/show_bug.cgi?id=94234

Made threaded tests in performance_browser_tests start timing
out on Chromium GPU bots

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):

platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

platform/graphics/skia/ImageBufferSkia.cpp:

5:29 PM Changeset in webkit [125832] by abarth@webkit.org

5 edits in trunk/Source/WebCore

Rename DOMWindow::clear to something more descriptive
https://bugs.webkit.org/show_bug.cgi?id=93993

Reviewed by Eric Seidel.

As requested by Eric Seidel. In WebKit, we typically use "clear" to
mean zeroing out a pointer (e.g., OwnPtr::clear). For DOMWindow, it's
more like we're resetting the DOMWindow to a known state (i.e., its
initial state), modulo a wrinkle w.r.t. the PageCache. The new name
attempts to clarify the situation.

dom/Document.cpp:

(WebCore::Document::~Document):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::frameDestroyed):
(WebCore::DOMWindow::resetUnlessSuspendedForPageCache):
(WebCore::DOMWindow::resetDOMWindowProperties):

page/DOMWindow.h:

(DOMWindow):

5:18 PM Changeset in webkit [125831] by enne@google.com

8 edits
2 copies in trunk/Source/WebCore

Unreviewed, rolling out r125717.
http://trac.webkit.org/changeset/125717
https://bugs.webkit.org/show_bug.cgi?id=94272

Likely to be causing Chromium Win Debug extensions browser
tests to fail (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

UseV8.cmake:
WebCore.gypi:
bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::mainThreadNormalWorld):

bindings/v8/DOMWrapperWorld.h:

(WebCore):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(DOMWrapperWorld):

bindings/v8/IsolatedWorld.cpp: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.cpp.

(WebCore):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):

bindings/v8/IsolatedWorld.h: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.h.

(WebCore):
(IsolatedWorld):
(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::count):
(WebCore::IsolatedWorld::id):
(WebCore::IsolatedWorld::domDataStore):

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):

5:10 PM Changeset in webkit [125830] by thakis@chromium.org

4 edits
2 deletes in trunk/Source/WebCore

Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead
https://bugs.webkit.org/show_bug.cgi?id=94260

Reviewed by James Robinson.

ThemeChromiumMac was introduced when ThemeMac assumed that an
in-process Cocoa view existed. With WebKit2, that's no longer true,
and the files can now be merged.

No behavior change.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/chromium/ThemeChromiumMac.h: Removed.
platform/chromium/ThemeChromiumMac.mm: Removed.
platform/mac/ThemeMac.mm:

(WebCore::paintStepper):
(WebCore::ThemeMac::ensuredView):

5:02 PM Changeset in webkit [125829] by Nate Chapin

3 edits in trunk/Source/WebCore

ProgressTracker never completes if iframe detached during parsing
https://bugs.webkit.org/show_bug.cgi?id=92272

Reviewed by Adam Barth.

Add a simple helper class to FrameLoader to ensure progressStarted/progressCompleted calls are matched,
and balance the calls when the Frame is detached.

No new tests, as this behavior has only been producing reliably by setting a breakpoint in a specific place.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::FrameProgressTracker::progressStarted):
(WebCore::FrameLoader::FrameProgressTracker::progressCompleted):
(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):

loader/FrameLoader.h:

(FrameProgressTracker):
(WebCore::FrameLoader::FrameProgressTracker::create):
(WebCore::FrameLoader::FrameProgressTracker::FrameProgressTracker):

4:53 PM Changeset in webkit [125828] by commit-queue@webkit.org

7 edits
2 adds in trunk

Update TypedArrays to throw RangeError or similar instead of INDEX_SIZE_ERR
https://bugs.webkit.org/show_bug.cgi?id=45118

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-16
Reviewed by Kenneth Russell.

Source/WebCore:

Update TypedArrays to raise JavaScript RangeError instead of dom
INDEX_SIZE_ERR exceptions. Also, update TypedArrays to raise TypeError
instead of JavaScript SyntaxError or dom exceptions SYNTAX_ERR when
calling set method with invalid arguments.

Specification does not define the type of exceptions to raise, but
other browsers raise JavaScript errors, so those changes will improve
compatibility.

New Test: fast/canvas/webgl/array-set-invalid-arguments.html

Updated Tests expectations:

fast/canvas/webgl/array-set-out-of-bounds.html
fast/canvas/webgl/data-view-crash.html
fast/canvas/webgl/data-view-test.html

bindings/js/JSArrayBufferViewHelper.h:

(WebCore):
(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferViewWithArrayBufferArgument):
(WebCore::constructArrayBufferView):

bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):

LayoutTests:

New test to test invalid arguments to TypedArray set method

Update array-set-out-of-bounds.html, data-view-crash.html and
data-view-test.html test expectations no match new exceptions thrown.

fast/canvas/webgl/array-set-invalid-arguments-expected.txt: Added.
fast/canvas/webgl/array-set-invalid-arguments.html: Added.
fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
fast/canvas/webgl/data-view-crash-expected.txt:
fast/canvas/webgl/data-view-test-expected.txt:

4:43 PM Changeset in webkit [125827] by commit-queue@webkit.org

28 edits in trunk/Source

[chromium] Replace destRect with destOffset in texture upload
https://bugs.webkit.org/show_bug.cgi?id=94154

Patch by Alexandre Elias <aelias@google.com> on 2012-08-16
Reviewed by James Robinson.

Previously, texture upload code implicitly assumed that sourceRect and
destRect have the same size. The behavior is undefined if they are
different, since they are used interchangeably and there's no support
for scaling from one rect to the other. This patch enforces that
constraint at the interface level by replacing all instances of
"IntRect destRect" by "IntSize destOffset".

Source/WebCore:

No new tests (no-op refactoring).

platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(Texture):
(BitmapCanvasLayerTextureUpdater):

platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):

platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):

platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):

platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):

platform/graphics/chromium/LayerRendererChromium.cpp:
platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::upload):
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

platform/graphics/chromium/LayerTextureSubImage.h:

(LayerTextureSubImage):

platform/graphics/chromium/LayerTextureUpdater.h:

(Texture):

platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):

platform/graphics/chromium/TextureUploader.h:

(Parameters):

platform/graphics/chromium/ThrottledTextureUploader.cpp:

(WebCore::ThrottledTextureUploader::uploadTexture):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTileTextures):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):

platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:

(WebCore::CCPrioritizedTexture::upload):

platform/graphics/chromium/cc/CCPrioritizedTexture.h:

(CCPrioritizedTexture):

platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::upload):

platform/graphics/chromium/cc/CCResourceProvider.h:

(CCResourceProvider):

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::copyPlaneData):

Source/WebKit/chromium:

tests/CCResourceProviderTest.cpp:

(WebKit::TEST_F):

tests/CCTextureUpdateControllerTest.cpp:
tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):

tests/CCTiledLayerTestCommon.h:

(Texture):
(WebKitTests::FakeTextureUploader::uploadTexture):

4:39 PM Changeset in webkit [125826] by kov@webkit.org

2 edits in trunk

Unreviewed speculative 32 bits build fix.

Source/autotools/symbols.filter: add symbol version that gets

generated in 32 bits build.

4:35 PM Changeset in webkit [125825] by kov@webkit.org

2 edits in trunk/Tools

Unreviewed warning fix, sys.argv is a python construct.

Scripts/update-webkitefl-libs:

4:27 PM Changeset in webkit [125824] by enne@google.com

3 edits
1 delete in trunk/LayoutTests

Remove text output from overflow-hidden-canvas-layer test
https://bugs.webkit.org/show_bug.cgi?id=94050

Unreviewed gardening.

This was added in r125758 and doesn't need a text dump.

compositing/overflow/overflow-hidden-canvas-layer-expected.txt:
compositing/overflow/overflow-hidden-canvas-layer.html:
platform/chromium-linux/compositing/overflow/overflow-hidden-canvas-layer-expected.txt: Removed.

4:17 PM Changeset in webkit [125823] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

Structure check hoisting should be less expensive
https://bugs.webkit.org/show_bug.cgi?id=94201

Reviewed by Mark Hahnenberg.

This appears like a broad win on short-running programs.

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGGraph.h:

(JSC::DFG::Graph::compareAndSwap):
(Graph):
(JSC::DFG::Graph::substitute):
(JSC::DFG::Graph::substituteGetLocal):

dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

4:11 PM Changeset in webkit [125822] by jamesr@google.com

7 edits in trunk/Source

[chromium] Remove unnecessary tree hierarchy inspection APIs from WebLayer
https://bugs.webkit.org/show_bug.cgi?id=94229

Reviewed by Adrienne Walker.

Source/Platform:

As it turns out, these APIs are needed. Without them, there is no way to re-wrap an existing layer so we can
know that when all WebLayer wrappers of a given layer go away that layer will never be exposed to the public API
again and run appropriate cleanup code.

chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Tweak updateLayerPreserves3D() logic to use the existing GraphicsLayer tree hierarchy instead of pulling the
hierarchy off of WebLayer.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

Remove dead WebLayer function implementations and tests of same.

src/WebLayer.cpp:
tests/WebLayerTest.cpp:

4:07 PM Changeset in webkit [125821] by Lucas Forschler

4 edits in branches/safari-536.26-branch/Source

Versioning.

4:04 PM Changeset in webkit [125820] by Lucas Forschler

1 copy in tags/Safari-536.26.7

New Tag.

3:50 PM Changeset in webkit [125819] by enne@google.com

2 edits in trunk/LayoutTests

[chromium] Mark http/tests/inspector/indexeddb/resources-panel.html as debug crasher
https://bugs.webkit.org/show_bug.cgi?id=94261

Unreviewed gardening.

platform/chromium/TestExpectations:

3:48 PM Changeset in webkit [125818] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Let XCode have its own way.

WebCore.xcodeproj/project.pbxproj:

3:44 PM Changeset in webkit [125817] by commit-queue@webkit.org

4 edits in trunk

Refactor CSPDirective to support non-sourcelist types.
https://bugs.webkit.org/show_bug.cgi?id=94252

Patch by Mike West <mkwst@chromium.org> on 2012-08-16
Reviewed by Adam Barth.

Source/WebCore:

The 'CSPDirective' was built to support source list Content Security
Policy directives like 'script-src' or 'object-src'. It doesn't support
new directive types like 'script-nonce' or 'plugin-types'. That
functionality has been implemented by hanging state off of
CSPDirectiveList, which isn't a great solution.

This patch pulls the source list functionality out of CSPDirective and
into SourceListDirective, and likewise pulls the nonce and media list
functionality into NonceDirective and MediaListDirective.

No new tests have been added; this refactoring should be externally
transparent, and the current CSP tests should continue to pass.

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirective::CSPDirective):
(CSPDirective):
(WebCore::CSPDirective::text):
(WebCore::CSPDirective::policy):

CSPDirective is now a parent class for NonceDirective,
MediaListDirective, and SourceListDirective. It stores a pointer
to the ContentSecurityPolicy object in order to facilitate logging,
which now needs to happen at this level, rather than higher up in
CSPDirectiveList.

(WebCore):
(NonceDirective):
(WebCore::NonceDirective::NonceDirective):
(WebCore::NonceDirective::allows):
(WebCore::NonceDirective::parse):

Pull the nonce parsing code and state out of CSPDirectiveList
and into this new class.

(MediaListDirective):
(WebCore::MediaListDirective::MediaListDirective):
(WebCore::MediaListDirective::allows):
(WebCore::MediaListDirective::parse):

Pull the media list parsing code and state out of CSPDirectiveList
and into this new class.

(SourceListDirective):
(WebCore::SourceListDirective::SourceListDirective):
(WebCore::SourceListDirective::allows):

Pull the source list functionality out of CSPDirective
and into this new class.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkEval):
(WebCore::CSPDirectiveList::checkInline):
(WebCore::CSPDirectiveList::checkNonce):
(WebCore::CSPDirectiveList::checkSource):
(WebCore::CSPDirectiveList::checkMediaType):
(WebCore::CSPDirectiveList::operativeDirective):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):
(WebCore::CSPDirectiveList::setCSPDirective):
(WebCore::CSPDirectiveList::addDirective):

Use the new classes rather than CSPDirective (or no directive
at all, in the case of nonces and plugin types).

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt:

This test was buggy. Now it writes out the full directive text as it
ought to.

3:42 PM Changeset in webkit [125816] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Update test expectations for fast/overflow/line-clamp-and-columns.html on mac
https://bugs.webkit.org/show_bug.cgi?id=94251

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-16
Reviewed by Brady Eidson.

Mark layout test fast/overflow/line-clamp-and-columns.html as an expected failure
on mac until https://bugs.webkit.org/show_bug.cgi?id=94080 is fixed.

platform/mac/TestExpectations:

3:29 PM Changeset in webkit [125815] by abarth@webkit.org

3 edits in trunk/Source/WebCore

Null checks of m_frame->document()->domWindow() aren't needed
https://bugs.webkit.org/show_bug.cgi?id=94052

Reviewed by Eric Seidel.

If a document is attached to a frame, then its DOMWindow is necessarily
non-0. Checking for 0 is needless.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::prepareForCachedPageRestore):

3:18 PM Changeset in webkit [125814] by enne@google.com

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Update expectations.

platform/chromium/TestExpectations:

3:01 PM Changeset in webkit [125813] by ojan@chromium.org

2 edits
1 add
1 delete in trunk/LayoutTests

Fix test added in r125635. The test failed on non-chromium ports due
to the column sizing 1px differently. I'm not really sure what was going on,
but this was a fix for a crash anyways. Just marking the test dumpAsText.

fast/overflow/line-clamp-and-columns-expected.html: Removed.
fast/overflow/line-clamp-and-columns-expected.txt: Added.
fast/overflow/line-clamp-and-columns.html:

2:45 PM Changeset in webkit [125812] by dpranke@chromium.org

14 edits in trunk/Tools

NRWT cutting off the output from LayoutTest run under Valgrind
https://bugs.webkit.org/show_bug.cgi?id=94011

Reviewed by Ojan Vafai.

Make NRWT work with valgrind again ... I needed to rework the
driver infrastructure so that we could get the stderr written
between a test completing and a process being stopped and
associate it with the DriverOutput for the test; this meant that
run_test() needed to stop the driver at the end of the test
directly if/when appropriate. This also entailed reworking
run_test() so that we would gather stderr and stdout
consistently regardless of whether this was a normal test, or
stop_when_done, or a crash or timeout.

Also, I had to rework the process_stop_time() (and renamed it to
driver_stop_timeout) so that it would be longer if --time-out-ms
was long as well (so that valgrind would get enough time to
run), and I reworked driver.stop(kill_directly=True) to just
driver.stop(timeout=0.0).

Lastly, adding the new stop_when_done parameter entailed
touching a lot of test mock functions :(.

This change appeared to be well-covered by existing tests.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(Worker._run_test):
(Worker._run_test_with_timeout):
(Worker._run_test_in_another_thread):
(Worker._run_test_in_another_thread.SingleTestThread.run):
(Worker._run_test_in_this_thread):
(Worker._run_single_test):

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(run_single_test):
(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._run_reftest):

Scripts/webkitpy/layout_tests/port/base.py:

(Port.driver_stop_timeout):
(Port.variable.default_configuration):

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.driver_stop_timeout):
(ChromiumAndroidDriver.stop):

Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):
(Driver.stop):
(DriverProxy.run_test):

Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):

Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.write):
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess.stop):
(ServerProcess.kill):
(ServerProcess):
(ServerProcess._kill):

Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.init):
(MockProc.wait):
(TestServerProcess.test_basic):

Scripts/webkitpy/layout_tests/port/test.py:

(TestDriver.run_test):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run.RecordingTestDriver.run_test):

Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.run_single):

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPageLoadingPerfTest.MockDriver.run_test):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver.run_test):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
(TestReplayPerfTest.test_prepare.run_test):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):

1:54 PM Changeset in webkit [125811] by commit-queue@webkit.org

3 edits
1 add in trunk

[BlackBerry] Some media controls are mispositioned for dynamic live streams (HLS)
https://bugs.webkit.org/show_bug.cgi?id=94176

Patch by Max Feil <mfeil@rim.com> on 2012-08-16
Reviewed by Antonio Gomes.

An automated layout test is not possible for this patch because
dynamic live streams require a special dedicated web server.
Putting an external video URL into an automated test is not
correct either. So I have created a manual test that points to
an external HLS video that works today.

ManualTests/blackberry/video-hls-controls.html: Added.

Source/WebCore:

The default HTML5 media controls for dynamic live streams have
no timeline or timeline container, which for BlackBerry results
in mispositioning of the buttons that are supposed to be to
the right of the timeline (fullscreen and mute). Instead of
being right justified they incorrectly appear on the left next
to the play button. The fix is to explicitly position these 2
buttons whenever the media duration is infinite (indicating a
live stream).

Manual test: ManualTests/blackberry/video-hls-controls.html

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

1:50 PM Changeset in webkit [125810] by inferno@chromium.org

3 edits
2 adds in trunk

Regression(r118248): Replaced element not layout
https://bugs.webkit.org/show_bug.cgi?id=85804

Reviewed by Levi Weintraub.

Source/WebCore:

r118248 moved the layout call of replaced elements to nextLineBreak.
This was intended to delay the layout after all the lineboxes are cleared
in RenderBlock::layoutInlineChildren. However, this caused the end line
object to not layout at all. We revert to the old planned way to just
keep a local vector of replaced elements to layout and then layout all of them
after the lineboxes are cleared.

Test: fast/replaced/replaced-last-line-layout.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

fast/replaced/replaced-last-line-layout-expected.html: Added.
fast/replaced/replaced-last-line-layout.html: Added.

1:48 PM Changeset in webkit [125809] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-16
Reviewed by Geoffrey Garen.

In most String to CFString conversion, we should be able to use the "NoCopy" constructor and have
a relatively cheap conversion from WTF::String to CFString.

When the String is 8 bits, it was converted to 16 bits by getData16SlowCase() because of the call
to String::characters().

This patch adds a path for creating a CFString from a 8bits string using CFStringCreateWithBytes.

This is covered by existing tests.

platform/text/cf/StringCF.cpp:

(WTF::String::createCFString): CFSTR() create static CFString, it is unecessary to retain it.

platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString): The logic to avoid the StringWrapperCFAllocator has also been simplified.
The allocator creation is now closer to where it is useful.

The function CFStringCreateWithBytesNoCopy() does not necessarilly allocate a new string, it can reuse
existing strings. In those cases, the allocator is not used. For that reason, the assertion regarding
currentString is moved to the branch that always allocate new strings.

1:47 PM Changeset in webkit [125808] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use form state to determine the VKB enter key.
https://bugs.webkit.org/show_bug.cgi?id=94239

Reviewed by Rob Buis.

PR 188234.

If the enter key for the VKB is not explicitly set, use
submit if we are in a single line input and a default
button exists for the form.

Reviewed Internally by Gen Mak.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementFocused):

1:44 PM Changeset in webkit [125807] by abarth@webkit.org

21 edits
1 move
4 deletes in trunk

DirectoryEntry should use Dictionary rather than custom bindings code
https://bugs.webkit.org/show_bug.cgi?id=94207

Reviewed by Eric Seidel.

Source/WebCore:

Since this code was written, we added native support for WebIDL
Dictionary objects. This patch moves DirectoryEntry to use this
automatic facility instead of custom code.

I've also renamed and simplified WebKitFlags. This is possible because
this object was no longer exposed via IDL (even before to this patch).

GNUmakefile.list.am:
Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::getFile):
(WebCore::DOMFileSystemBase::getDirectory):

Modules/filesystem/DOMFileSystemBase.h:

(DOMFileSystemBase):

Modules/filesystem/DirectoryEntry.cpp:

(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):

Modules/filesystem/DirectoryEntry.h:

(DirectoryEntry):

Modules/filesystem/DirectoryEntry.idl:
Modules/filesystem/DirectoryEntrySync.cpp:

(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):

Modules/filesystem/DirectoryEntrySync.h:

(DirectoryEntrySync):

Modules/filesystem/DirectoryEntrySync.idl:
Modules/filesystem/FileSystemCallbacks.cpp:

(WebCore):
(WebCore::ResolveURICallbacks::didOpenFileSystem):

Modules/filesystem/FileSystemFlags.h: Renamed from Source/WebCore/Modules/filesystem/WebKitFlags.h.

(WebCore):
(WebCore::FileSystemFlags::FileSystemFlags):
(FileSystemFlags):

Modules/filesystem/WorkerContextFileSystem.cpp:

(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):

Target.pri:
UseJSC.cmake:
UseV8.cmake:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDirectoryEntryCustom.cpp: Removed.
bindings/js/JSDirectoryEntrySyncCustom.cpp: Removed.
bindings/v8/custom/V8DirectoryEntryCustom.cpp: Removed.
bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: Removed.

LayoutTests:

This patch changes our behavior slightly in that passing a non-object
as a flags Dictionary throws an exception rather than being treated as
an empty dictionary. This new behavior matches the WebIDL spec and
hopefully won't cause compat problems.

fast/filesystem/flags-passing-expected.txt:
fast/filesystem/script-tests/flags-passing.js:

(runNullTest):
(runNonObjectTest):

1:35 PM Changeset in webkit [125806] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

All op_resolve_global instructions should end up in the list of global resolve instructions
https://bugs.webkit.org/show_bug.cgi?id=94247
<rdar://problem/12103500>

Reviewed by Mark Hahnenberg.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolveWithBase):

1:30 PM Changeset in webkit [125805] by Antti Koivisto

10 edits in trunk/Source/WebCore

Remove StyleSheetContents::m_finalURL
https://bugs.webkit.org/show_bug.cgi?id=94140

Reviewed by Andreas Kling.

It is equal (or empty in case of inline stylesheets) to the baseURL passed in CSSParserContext.
Removing it simplifies the constructors and the related code.

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::createInline):
(WebCore::CSSStyleSheet::canAccessRules):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):

factor access check to a function
allow document always access rules of its inline stylesheets

css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):

css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):

css/StyleSheetContents.h:

(WebCore::StyleSheetContents::create):
(WebCore::StyleSheetContents::originalURL):
(StyleSheetContents):

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::styleSheetURL):

xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

1:11 PM Changeset in webkit [125804] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[Chromium] Changing Canvas2DLayerBridge to use SkDeferredCanvas's notification client API
https://bugs.webkit.org/show_bug.cgi?id=94234

Patch by Justin Novosad <junov@chromium.org> on 2012-08-16
Reviewed by James Robinson.

The existing DeviceContext API in skia's SkDeferredCanvas is being
deprecated in favor of the new NotificationClient interface, which is
designed to allow WebKit to control deferred canvas global memory
consumption.

No new tests: this patch does not fix any bug and does not add new
functionality. It is just a transition to a new skia interface.
Coverage is assured by existing tests.

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore):
Removed the AcceleratedDeviceContext class completely and mixed it
into Canvas2DLayerBridge by inheriting
SkDeferredCanvas::NotificationClient
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::deferredCanvas):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::skCanvas):

platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

platform/graphics/skia/ImageBufferSkia.cpp:

Cleaning up unnecessary include of SkDeferredCanvas.h

12:55 PM Changeset in webkit [125803] by kpiascik@rim.com

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reload valid page from Error Page keeps history ViewState and zoom.
https://bugs.webkit.org/show_bug.cgi?id=94123

Reviewed by Antonio Gomes.

Reviewed internally by Leo Yang, Jacky Jiang.
PR 178305

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):Reset the scales and
the user scalable flag if we're reloading from an error page.
(BlackBerry::WebKit::WebPagePrivate::updateViewportSize): Don't update the
viewport size if we're still in the WebPagePrivate::init method.
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
Properly set the shouldZoom flag if we're not going to restore the
view state.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad): Set the
ViewState's shouldSaveViewState flag if we're coming from an error page.
(WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem): Set the
new member variable m_shouldRestoreViewState based on the ViewState's
shouldSaveViewState flag.
(WebCore::FrameLoaderClientBlackBerry::restoreViewState): Added early
return if m_shouldRestoreViewState is false.

WebCoreSupport/FrameLoaderClientBlackBerry.h: Add new method to have

the client track whether we should restore the view state.
(WebCore::FrameLoaderClientBlackBerry::shouldRestoreViewState):
(FrameLoaderClientBlackBerry):

12:54 PM Changeset in webkit [125802] by commit-queue@webkit.org

7 edits in trunk/Source

[Chromium] Avoid aliasing global symbol monotonicallyIncreasingTime().
https://bugs.webkit.org/show_bug.cgi?id=94233

Patch by David Reveman <reveman@chromium.org> on 2012-08-16
Reviewed by James Robinson.

Source/WebCore:

Rename virtual function CCDelayBasedTimeSource::monotonicallyIncreasingTime()
that exist for testing purposes to CCDelayBasedTimeSource::monotonicTimeNow().

No new tests.

platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::monotonicTimeNow):

platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

Source/WebKit/chromium:

tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

tests/CCFrameRateControllerTest.cpp:

(WebKitTests::TEST):

tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicTimeNow):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(FakeCCDelayBasedTimeSource):

12:50 PM Changeset in webkit [125801] by commit-queue@webkit.org

2 edits in trunk/Tools

Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
https://bugs.webkit.org/show_bug.cgi?id=94228

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-16
Reviewed by Tim Horton.

I previously made the change but made a typo that causes the script not ignore mismatch ref tests.

Scripts/old-run-webkit-tests:

(isUsedInReftest):

12:42 PM Changeset in webkit [125800] by commit-queue@webkit.org

13 edits in trunk/Source

[Chromium] Schedule texture uploads based on hard-coded timer and vsync.
https://bugs.webkit.org/show_bug.cgi?id=84281

Patch by David Reveman <reveman@chromium.org> on 2012-08-16
Reviewed by James Robinson.

Source/WebCore:

Improve interaction between vsync and texture uploads by performing
uploads in smaller batches and use a hard-coded timer to emulate
upload completion. This greatly reduces the chance of the compositor
missing a vsync due to being busy with texture uploads.

The CCScheduler client is now given a time limit when told to update
more resources. This time limit is passed to an instance of the
CCTextureUpdateController class, which is responsible for performing
texture updates until the limit is reached.

Unit tests: CCSchedulerTest.RequestCommit

CCTextureUpdateControllerTest.UpdateMoreTextures
CCTextureUpdateControllerTest.HasMoreUpdates

platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::nextTickTime):
(WebCore):

platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

platform/graphics/chromium/cc/CCScheduler.h:

(CCSchedulerClient):

platform/graphics/chromium/cc/CCTextureUpdateController.cpp:

(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore):
(WebCore::CCTextureUpdateController::onTimerFired):
(WebCore::CCTextureUpdateController::monotonicTimeNow):
(WebCore::CCTextureUpdateController::updateMoreTexturesTime):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):
(WebCore::CCTextureUpdateController::updateMoreTexturesIfEnoughTimeRemaining):
(WebCore::CCTextureUpdateController::updateMoreTexturesNow):

platform/graphics/chromium/cc/CCTextureUpdateController.h:

(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
(WebKitTests::FakeCCTimeSource::setNextTickTime):
(FakeCCTimeSource):

tests/CCTextureUpdateControllerTest.cpp:

12:35 PM Changeset in webkit [125799] by danakj@chromium.org

4 edits in trunk/Source

[chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232

Reviewed by James Robinson.

Source/WebCore:

CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.

Chromium bug: crbug.com/125482

Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):

Source/WebKit/chromium:

Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.

tests/CCLayerTreeHostImplTest.cpp:

12:31 PM Changeset in webkit [125798] by beidson@apple.com

2 edits in trunk/LayoutTests

http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html fails (results weren't updated in r125772)
https://bugs.webkit.org/show_bug.cgi?id=94236

Unreviewed (test gardening)

http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Update results here, like the rest of 125772 did.

12:28 PM Changeset in webkit [125797] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Use initialization from literals for StringStatics
https://bugs.webkit.org/show_bug.cgi?id=94185

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-16
Reviewed by Geoffrey Garen.

wtf/text/StringStatics.cpp:

Remove the arguments for DEFINE_GLOBAL. They are no longer used by the macro.
(WTF::AtomicString::init):
Use ConstructFromLiteral to initialize the strings faster and to save memory.

11:46 AM Changeset in webkit [125796] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove Mobile mode from WebPage.cpp and WebPage_p.h
https://bugs.webkit.org/show_bug.cgi?id=94223
PR #192773

Patch by Leo Yang <leoyang@rim.com> on 2012-08-16
Reviewed by Rob Buis.
Reviewed internally by Arvid Nilsson.

Remove Mobile mode as it's not been used. Also remove code that
handle top-level SVG document because now we can handle it in Desktop mode.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

Api/WebPage_p.h:

11:23 AM Companies and Organizations that have contributed to WebKit edited by Bruno de Oliveira Abinader

Adding basyKom work. (diff)

11:07 AM Changeset in webkit [125795] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] SurfacePool::waitForBuffer() sometimes waits for deleted EGLSyncKHR object
https://bugs.webkit.org/show_bug.cgi?id=94208

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-16
Reviewed by Rob Buis.

SurfacePool::notifyBuffersComposited() adds a tile's previous
sync object to the garbage list before replacing it with a new one.
However, it failed to thoroughly clear all tiles that were referencing
the old sync object.

Thus it could happen that if a set of tiles A was composited, then
another set of tiles B was composited, only the intersection of A and B
was cleared of the soon-to-be-deleted sync object, and the subtraction
A - B would reference an invalid sync object in case the BackingStore
decided to render to one of the tiles in A - B before they were
composited again.

Fixed by storing each individual sync object in only one place so we
don't have to rummage through all tiles and remove stale references to
sync objects that are about to be destroyed.

A new reference counted Fence class is added for this purpose, to store
a sync object. Tiles refer to Fence instances instead of holding a sync
object directly. Since Fence is reference counted, several tiles can
refer to the same Fence instance, and clearing its sync object will
instantly remove it from the grasp of all tiles that depend on that
Fence.

Since there's no point in waiting for the same Fence twice, the only
operation provided on Fence is takePlatformSync() which returns the
sync object and clears the Fence of its sync object.

Reviewed internally by Filip Spacek.

PR 193610

WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::TileBuffer):

WebKitSupport/BackingStoreTile.h:

(BlackBerry):
(Fence):
(BlackBerry::Fence::create):
(BlackBerry::Fence::takePlatformSync):
(BlackBerry::Fence::Fence):
(BlackBerry::WebKit::TileBuffer::fence):
(BlackBerry::WebKit::TileBuffer::setFence):
(TileBuffer):

WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):

WebKitSupport/SurfacePool.h:

(SurfacePool):

11:00 AM Changeset in webkit [125794] by leviw@chromium.org

47 edits
4 adds in trunk

Accumulate sub-pixel offsets through layers and transforms
https://bugs.webkit.org/show_bug.cgi?id=89238

Reviewed by Eric Seidel.

Source/WebCore:

Pixel snapping logic makes use of sub-pixel offsets accumulated when walking down
the render tree. When we align RenderLayers to paint on pixel boundaries, we were
also losing that accumulated value. This preserves the fractional offset and passes
it to the RenderLayer's RenderObjects so they paint the proper size and offset.

This also necessitates a new mode of mapLocalToContainer whereby we pixel snap the
offset used in transforms. Otherwise, they wouldn't account for the pixel snapping
done elsewhere in the render tree.

Test: fast/sub-pixel/sub-pixel-accumulates-to-layers.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::pixelSnappedSizingBox): The LayoutUnit version of sizingBox returns a
LayoutRect with the location zeroed out. This leads to incorrect pixel snapping, so
we shouldn't put these numbers into a transform. Sadly, I couldn't figure out a
test for this without the rest of the patch.
(WebCore):
(WebCore::computedTransform): Using pixel-snapped values when generating transforms.

rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer): Adding a mode whereby the values inputed
into the transform are properly pixel snapped.
(WebCore::RenderBox::computeRectForRepaint): Using pixel snapped values for the transform.

rendering/RenderBox.h:

(RenderBox):

rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToAbsolute):

rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

rendering/RenderInline.h:

(RenderInline):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateTransform): Using pixel snapped values for the transform.
(WebCore::RenderLayer::currentTransform): Ditto.
(WebCore::RenderLayer::perspectiveTransform): Ditto.
(WebCore::RenderLayer::paint): Support passing along the accumulated sub-pixel offset instead
of rounding and use enclosingIntRect for the damageRect.
(WebCore::RenderLayer::paintOverlayScrollbars): Updating to the new paintLayer contract
(WebCore::RenderLayer::paintLayer): Adding a sub-pixel accumulation LayoutSize. We pass this
delta to the Layer's RenderObject when we paint, but align the graphics context to the proper
pixel value.
(WebCore::RenderLayer::paintLayerContentsAndReflection): Ditto.
(WebCore::RenderLayer::paintLayerContents): Ditto.
(WebCore::RenderLayer::paintList): Ditto.
(WebCore::RenderLayer::paintChildLayerIntoColumns): Ditto.
(WebCore::RenderLayer::calculateClipRects): Avoid unnecessary rounding when sub-pixel is enabled.
(WebCore::RenderLayer::calculateRects): Remove unnecessary pixel snapping.

rendering/RenderLayer.h:

(RenderLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateLayerTransform): Use pixel-snapped values for transforms.
(WebCore::RenderLayerBacking::paintIntoLayer): Update to new paintLayer contract.

rendering/RenderObject.cpp:

(WebCore::RenderObject::localToContainerQuad): Adding a mode for optionally pixel snapping.
(WebCore::RenderObject::localToContainerPoint): Ditto.

rendering/RenderObject.h:

(WebCore::RenderObject::localToAbsoluteQuad): Ditto.
(RenderObject):

rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint): Updating to new paintLayer contract.

rendering/RenderView.h:

(RenderView):

rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer):

rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer):

rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer):

rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer):

rendering/svg/RenderSVGText.h:

(RenderSVGText):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

fast/sub-pixel/sub-pixel-accumulates-to-layers.html: Added.
platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
platform/chromium-mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
platform/chromium-mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
platform/chromium-mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
platform/chromium-mac/fast/transforms/transformed-document-element-expected.png:
platform/chromium-mac/media/audio-repaint-expected.png:
platform/chromium-mac/svg/transforms/svg-css-transforms-expected.png:
platform/chromium/TestExpectations:
platform/efl/Skipped:
platform/gtk/TestExpectations:
platform/mac-lion/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac-wk2/Skipped:
platform/mac/Skipped:
platform/qt-4.8/Skipped:
platform/qt/Skipped:
platform/win-wk2/Skipped:
platform/win-xp/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

10:47 AM Changeset in webkit [125793] by annacc@chromium.org

2 edits in trunk/LayoutTests

Layout Test media/track/track-active-cues.html frequently times out on Windows.
https://bugs.webkit.org/show_bug.cgi?id=81402

Reviewed by Eric Carlson.

This patch changes the test to use captions-fast.vtt to see if several cuechange
events available at different times helps the test not timeout.

media/track/track-active-cues.html:

10:45 AM Changeset in webkit [125792] by peter@chromium.org

5 edits in trunk

[Chromium] Pass the --strip-binary argument to the apk test generator
https://bugs.webkit.org/show_bug.cgi?id=94224

Reviewed by Adam Barth.

The native test generator currently relies on the $STRIP environment
variable to be available, which it shouldn't do. Instead, pass it as an
argument to the script. The $STRIP variable is being deprecated.

Source/WebKit/chromium:

WebKitUnitTests.gyp:

Tools:

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

10:33 AM Changeset in webkit [125791] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Bad utf8 data is being passed to enchant_dict_check
https://bugs.webkit.org/show_bug.cgi?id=94202

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-16
Reviewed by Martin Robinson.

Pass the number of bytes instead of the number of UTF8 characters
when calling enchant_dict_check.

platform/text/gtk/TextCheckerEnchant.cpp:

(TextCheckerEnchant::checkSpellingOfString): Use 'bytes' instead
of 'wordLength'.

10:22 AM Changeset in webkit [125790] by commit-queue@webkit.org

9 edits
9 adds in trunk

Web Inspector: added Paint events for Images to TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90277

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-16
Reviewed by Pavel Feldman.

Source/WebCore:

add DecodeImage & ResizeImage timeline events;
implement {will,did}DecodeImage and {will,did}ResizeImage methods of Timeline agent;

Test: inspector/timeline/timeline-decode-resize.html

English.lproj/localizedStrings.js:
inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::willDecodeImage):
(WebCore::InspectorTimelineAgent::didDecodeImage):
(WebCore::InspectorTimelineAgent::willResizeImage):
(WebCore::InspectorTimelineAgent::didResizeImage):

inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createDecodeImageData):
(WebCore):
(WebCore::TimelineRecordFactory::createResizeImageData):

inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

inspector/front-end/TimelineModel.js:
inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.initRecordStyles_):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):

LayoutTests:

Added a test and fixed enum-stabitily because of a new Timeline Event.

inspector/timeline/resources/big.png: Added.
inspector/timeline/resources/test.bmp: Added.
inspector/timeline/resources/test.gif: Added.
inspector/timeline/resources/test.ico: Added.
inspector/timeline/resources/test.jpg: Added.
inspector/timeline/resources/test.png: Added.
inspector/timeline/resources/test.webp: Added.
inspector/timeline/timeline-decode-resize-expected.txt: Added.
inspector/timeline/timeline-decode-resize.html: Added.
inspector/timeline/timeline-enum-stability-expected.txt:

10:20 AM Changeset in webkit [125789] by enne@google.com

4 edits
1 delete in trunk/LayoutTests

Make compositing/layer-creation/overflow-scroll-overlap non-flaky
https://bugs.webkit.org/show_bug.cgi?id=94162

Reviewed by James Robinson.

This test has been failing flakily in Chromium with the scrollbar
layer sometimes being composited and sometimes not. This is likely due
to the video flakily being accelerated depending on whether it has
loaded or not.

Fix this test by making it always have a vertical scrollbar and remove
the video with an always-composited div.

compositing/layer-creation/overflow-scroll-overlap-expected.txt:
compositing/layer-creation/overflow-scroll-overlap.html:
platform/chromium/TestExpectations:
platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.

10:16 AM Changeset in webkit [125788] by jamesr@google.com

8 edits in trunk/Source

[chromium] Remove alwaysReserveTextures code - it doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=94183

Reviewed by Dimitri Glazkov.

Source/Platform:

Remove deprecated setAlwaysReserveTextures() call from WebLayer.

chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

LayerChromium::setAlwaysReservesTextures doesn't do anything and hasn't since the prioritized texture manager
landed. This deletes the associated code.

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

Source/WebKit/chromium:

Stops attempting to find the scrollbar layers and call setAlwaysReserveTextures() on them since the call doesn't
do anything.

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):

src/WebLayer.cpp:

10:06 AM Changeset in webkit [125787] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed. Sort the xcodeproj file.

WebCore.xcodeproj/project.pbxproj:

10:05 AM Changeset in webkit [125786] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed. Update bindings tests results from my recent VoidCallback
patch. The new result is correct.

bindings/scripts/test/V8/V8TestCallback.cpp:

9:06 AM Changeset in webkit [125785] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: CPU profiler status bar is broken.
https://bugs.webkit.org/show_bug.cgi?id=94212

Reviewed by Pavel Feldman.

properly compute floating status bar buttons offset for profile and timeline panels,

taking actual number of panel status bar buttons and panel sidebar offset into account;

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype.sidebarResized):
(WebInspector.ProfilesPanel.prototype.onResize):

inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype.sidebarWidth):

inspector/front-end/StatusBarButton.js:
inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype.onResize):

9:02 AM Changeset in webkit [125784] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebCore

Fix the Mac build.

Unreviewed build fix.

WebCore.exp.in: Export FrameView::didFirstLayout()

8:33 AM Changeset in webkit [125783] by jocelyn.turcotte@nokia.com

3 edits in trunk/Source/WebKit2

[Qt] Remove an unused variable

Reviewed by Simon Hausmann.

UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

8:31 AM Changeset in webkit [125782] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebKit2

[Qt][WK2] Change the default cache model to enable the page cache
https://bugs.webkit.org/show_bug.cgi?id=94221

Reviewed by Simon Hausmann.

The default CacheModelDocumentViewer disables the memory back-forward page cache.
As uses of applications using QQuickWebView might vary, I'm setting the default to
CacheModelDocumentBrowser.
We should eventually expose this in the API to allow serious Web browsers setting it
to CacheModelPrimaryWebBrowser or to CacheModelDocumentViewer for application tight
on memory with limited page navigations.

UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::defaultContext):

8:30 AM Changeset in webkit [125781] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebKit2

[Qt] Make sure that we don't prematurely force the first layout during loading.
https://bugs.webkit.org/show_bug.cgi?id=94106

Reviewed by Kenneth Rohde Christiansen.

This would have the nasty effect that the frame loader would report the first layout
before loadCommitted was reported. This would resume the rendering engine prematurely,
showing blank content and reporting an empty contents size.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedLayoutSize):

8:23 AM Changeset in webkit [125780] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

7:58 AM Changeset in webkit [125779] by kpiascik@rim.com

2 edits in trunk/Source/WebCore

Add BB10 User Agent String to Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=94217

Reviewed by George Staikos.

Add the new BlackBerry 10 User Agent String and device metrics for
emulation.

inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):

7:54 AM Changeset in webkit [125778] by commit-queue@webkit.org

4 edits in trunk

Source/WebKit/blackberry: [BlackBerry] Suppress non DRT JS Console output.
https://bugs.webkit.org/show_bug.cgi?id=94058

Patch by Rob Buis <rbuis@rim.com> on 2012-08-16
Reviewed by Yong Li.
Reviewed internally by Ming Xie.

Some actual test results show JS Console showing up twice, for
instance traversal/moz-bug559526.html. Only print the DRT specific
Console message.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addMessageToConsole):

Tools: [BlackBerry] Update format of JS console message to keep consistent with other ports.
https://bugs.webkit.org/show_bug.cgi?id=94058

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-08-16
Reviewed by Yong Li.
Reviewed internally by George Staikos.

Remove line number if it's zero.
Print only file name for "file://" URL.

DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):

7:27 AM Changeset in webkit [125777] by commit-queue@webkit.org

7 edits in trunk/Source

[Qt] Input method hints are not being set.
https://bugs.webkit.org/show_bug.cgi?id=92386

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-08-16
Reviewed by Kenneth Rohde Christiansen.

Input method hints for an editable element must be obtained from a proper
HTML element. If the editable element is a complex one, it will have elements
in the Shadow DOM, and it's one of those that will be returned as the root
editable element. This works for editable DIVs, but not for INPUT elements.
Using Element::shadowHost() on the root editable element will provide the
needed HTML element, and for further clarity a method that does this was added
to FrameSelection.

Source/WebCore:

editing/FrameSelection.cpp:

(WebCore::FrameSelection::rootEditableElementRespectingShadowTree): Similar to
WebCore::FrameSelection::rootEditableElement, but returns the first ancestor of
the editable element outside the shadow tree.
(WebCore):

editing/FrameSelection.h:

(FrameSelection):

Source/WebKit2:

Added an API test to the Qt port regarding the correct setting
of input method hints information on INPUT HTML tags.

UIProcess/API/qt/tests/html/inputmethod.html:
UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::inputMethodHints):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

7:17 AM Changeset in webkit [125776] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Make DRT results more reliable on X11

Reviewed by Jocelyn Turcotte.

Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
the running desktop environment.

DumpRenderTree/qt/main.cpp:

(main):

7:16 AM Changeset in webkit [125775] by zandobersek@gmail.com

1 edit
1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline after r125772.

platform/gtk/http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.

6:57 AM Changeset in webkit [125774] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening after r125758, r125759
https://bugs.webkit.org/show_bug.cgi?id=94215

Unreviewed, gardening.

Newly added tests: compositing/overflow/overflow-hidden-canvas-layer.html,
fast/forms/file/selected-files-from-history-state.html fail on EFL and need gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-16

platform/efl/TestExpectations:

6:24 AM Changeset in webkit [125773] by zeno.albisser@nokia.com

20 edits in trunk/Source

Make GraphicsSurface double buffered by default.
https://bugs.webkit.org/show_bug.cgi?id=93252

Create only a single GraphicsSurface per canvas
on both supported platforms Mac/Linux.
The GraphicsSurface on Mac internally uses two IOSurface
to provide a front and a back buffer.
The GLX implementation of GraphicsSurface uses
an XWindow which already provides a front and a back buffer.

Reviewed by Noam Rosenthal.

Source/WebCore:

platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):

Remove creation of second GraphicsSurface.

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):

platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::create):

Adjust token type to uint64_t.

(WebCore::GraphicsSurface::exportToken):

Adjust return type to uint64_t.

(WebCore::GraphicsSurface::frontBuffer):
(WebCore):
(WebCore::GraphicsSurface::swapBuffers):

Add forwarding function to swap buffers inside GraphicsSurface.

platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

Add SupportsSingleBuffered flag to allow for single buffered implementations.
Currently single buffered surfaces are either not implemented or disabled.

platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

Move implementation details into GraphicsSurfacePrivate.
This way the platform specific code can be hidden in the specific cpp file
instead of polluting the global GraphicsSurface header.

(WebCore::createTexture):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::token):
(WebCore::GraphicsSurfacePrivate::frontBufferTextureID):
(WebCore::GraphicsSurfacePrivate::backBufferTextureID):
(WebCore::GraphicsSurfacePrivate::frontBuffer):
(WebCore::GraphicsSurfacePrivate::backBuffer):
(WebCore):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::ioSurfaceLockOptions):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):

platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::get):
(WebCore::GraphicsSurfacePrivate::swapBuffers):

Make sure that framebuffer bindings remain consistent
after swapping buffers on the XWindow.

(WebCore::GraphicsSurface::platformExport):

Make sure the GLXPixmap is only bound to the texture once.

(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
(WebCore):
(WebCore::GraphicsSurface::platformFrontBuffer):

The GLX surface does not know how to destinguish between
the front and the back buffer by an id. This is not necessary
for GraphicsSurfaceGLX, because the texture can just be
read from the XWindow at any time.

(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):

platform/graphics/texmap/TextureMapperBackingStore.cpp:

Remove code that was used for switching between two GraphicsSurfaces,
as this is now handled directly inside GraphicsSurface.

(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
(WebCore::TextureMapperSurfaceBackingStore::setSurface):
(WebCore):

platform/graphics/texmap/TextureMapperBackingStore.h:

Remove GraphicsSurfaceData struct. This class is not needed anymore
as we do not keep track of more than one GraphicsSurface at the time.

(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::graphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):

platform/graphics/texmap/TextureMapperPlatformLayer.h:

(WebCore::TextureMapperPlatformLayer::graphicsSurfaceToken):

Source/WebKit2:

Shared/ShareableSurface.h:

(Handle):

Change the type of GraphicsSurface token to uint64_t.

UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::syncCanvas):

Add a parameter that denotes the current front buffer of the
GraphicsSurface.

UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::syncCanvas):

UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncCanvas):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::syncCanvas):

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

5:42 AM Changeset in webkit [125772] by commit-queue@webkit.org

13 edits
14 adds in trunk

Implement the form-action Content Security Policy directive.
https://bugs.webkit.org/show_bug.cgi?id=93777

Patch by Mike West <mkwst@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

Source/WebCore:

The CSP 1.1 editor's draft defines the 'form-action' directive as a
mechanism for whitelisting valid targets for form submission from a
protected resource. A web author might desire to restrict form
submissions to the same origin as the protected resource itself via
a Content Security Policy of "form-action 'self'", or ensure that all
submissions were sent over an SSL connection via "form-action https:".

Specification details available at: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#form-action--experimental

This experimental directive is gated on the ENABLE_CSP_NEXT flag, which
is currently only enabled in Chromium.

Tests: http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed.html

http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkIfFormActionAllowedByCSP):

Adding a callback to FrameLoader in order to allow the
MainResourceLoader to check the relevant CSP status without knowing
anything about CSP.

(WebCore):

loader/FrameLoader.h:

(FrameLoader):

loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):

Check against the protected resource's Content Security Policy when
presented with a request that is itself a form submission, or is the
result of a redirect in response to a form submission. If CSP would
block the target, cancel the request.

page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

Added explanatory text to the source violation console warning that
specifically calls out sending form data (as opposed to "connect to"
or "load the").

(WebCore::CSPDirectiveList::allowFormAction):

Check a URL against a directive list's the 'form-action' source list.

(WebCore):
(WebCore::CSPDirectiveList::addDirective):

Recognize the 'form-action' CSP directive.

(WebCore::ContentSecurityPolicy::allowFormAction):

Public interface to check a form action.

page/ContentSecurityPolicy.h:

LayoutTests:

http/tests/navigation/resources/redirection-response.php:

Allow for the specification of alternate hosts for the redirect. We
need this capability in order to check that an initial submission
followed by a blocked redirect results in the correct behavior.

http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed.html: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored.html: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed.html: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked.html: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html: Added.

5:20 AM Changeset in webkit [125771] by jochen@chromium.org

1 edit in branches/chromium/1229/Source/WebKit/chromium/features.gypi

Disable wip ContentSecurityPolicy features on M22

BUG=142415

5:12 AM Changeset in webkit [125770] by commit-queue@webkit.org

14 edits in trunk/Source

[BlackBerry] WebGL and Canvas fail to display after being restored from page cache
https://bugs.webkit.org/show_bug.cgi?id=94105

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-16
Reviewed by George Staikos.

The EGLImage was being destroyed when releasing layer resources on the
compositing thread, but the WebKit thread layer never found out and
failed to create a new image.

Fixed by extending the release layer resources mechanism to also make a
pass on the WebKit thread so that thread's layers have a chance to
delete their textures and related resources.

Source/WebCore:

WebGL and canvas layers now take this opportunity to release their
textures so the EGLImage gets recreated when compositing commits
resume.

The only detail that deserves extra explanation is the ownership of the
EGLImage.

Since the EGLImage is created in updateTextureContentsIfNeeded() and
that one is always followed by commitPendingTextureUploads() which
transfers the EGLImage to the compositing thread layer's custody, the
EGLImage currently referenced by EGLImageLayerWebKitThread::m_image
should never be deleted by the WebKit thread layer.

Thus all we have to do in deleteFrontBuffer() is to set the m_image
member to 0 so the image gets recreated on the next commit. It will be
deleted by the part of releaseLayerResources() that executes on the
compositing thread (which, if you recall, was the original source of
this bug).

Reviewed internally by Filip Spacek.

PR 192899

Not currently testable by the BlackBerry testing infrastructure.

platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::deleteTextures):
(WebCore):

platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(CanvasLayerWebKitThread):

platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:

(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):

platform/graphics/blackberry/EGLImageLayerWebKitThread.h:

(EGLImageLayerWebKitThread):

platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::releaseLayerResources):
(WebCore):

platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):
(WebCore::LayerWebKitThread::deleteTextures):

platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:

(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::deleteTextures):
(WebCore):

platform/graphics/blackberry/WebGLLayerWebKitThread.h:

(WebGLLayerWebKitThread):

Source/WebKit/blackberry:

Reviewed internally by Filip Spacek.

PR 192899

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResources):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):

Api/WebPage_p.h:

(WebPagePrivate):

WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::releaseLayerResources):
(WebKit):

WebKitSupport/FrameLayers.h:

(FrameLayers):

5:06 AM Changeset in webkit [125769] by caseq@chromium.org

18 edits
2 adds in trunk/Source/WebCore

Web Inspector: enable instrumentation of platform code
https://bugs.webkit.org/show_bug.cgi?id=94125

Reviewed by Pavel Feldman.

add PlatformInstrumentation class that exposes instrumentation methods that may be used by code under WebCore/platform;
move TRACE_EVENT_XXX() macros into PlatformInstrumentation.h to minimize instrumentation hassle in the client code;
implement PlatformInstrumentationClient by InspectorTimelineAgent;
only install PlatformInstrumentationClient when we have outer events for which we expect low-level details

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willDecodeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didDecodeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::willResizeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didResizeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):

inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

platform/PlatformInstrumentation.cpp: Added.

(WebCore):
(WebCore::PlatformInstrumentation::setClient):

platform/PlatformInstrumentation.h: Added.

(WebCore):
(PlatformInstrumentationClient):
(PlatformInstrumentation):
(WebCore::PlatformInstrumentation::hasClient):
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::resizedBitmap): added calls to PlatformInstrumentation, removed TRACE_EVENT();

platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::BMPImageDecoder::decode): removed TRACE_EVENT()

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::GIFImageDecoder::decode): removed TRACE_EVENT()

platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::ICOImageDecoder::decode): removed TRACE_EVENT()

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::JPEGImageDecoder::decode): removed TRACE_EVENT()

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::WEBPImageDecoder::decode): removed TRACE_EVENT();

inspector/InspectorInstrumentation.cpp: removed orphan event support;

(WebCore):

inspector/InspectorInstrumentation.h: ditto.

4:54 AM Changeset in webkit [125768] by commit-queue@webkit.org

31 edits in trunk/LayoutTests

[EFL] Update pixel test expectations for layout test fast/dom/
https://bugs.webkit.org/show_bug.cgi?id=94177

Unreviewed, rebaseline.

Some tests have wrong pixel test results. They should be replaced.

And, two tests related image seem to fail. Alt text should be displayed
if src attribute is not set.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-16

platform/efl/TestExpectations: Added two tests related to display alt text without src.
platform/efl/fast/dom/34176-expected.png:
platform/efl/fast/dom/Element/class-attribute-whitespace-expected.png:
platform/efl/fast/dom/HTMLElement/bdo-expected.png:
platform/efl/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png:
platform/efl/fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png:
platform/efl/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
platform/efl/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.png:
platform/efl/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.png:
platform/efl/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
platform/efl/fast/dom/HTMLTableElement/colSpan-expected.png:
platform/efl/fast/dom/HTMLTableElement/createCaption-expected.png:
platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
platform/efl/fast/dom/Range/surroundContents-1-expected.png:
platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
platform/efl/fast/dom/blur-contenteditable-expected.png:
platform/efl/fast/dom/children-nodes-expected.png:
platform/efl/fast/dom/clone-contents-0-end-offset-expected.png:
platform/efl/fast/dom/css-rule-functions-expected.png:
platform/efl/fast/dom/focus-contenteditable-expected.png:
platform/efl/fast/dom/gc-10-expected.png:
platform/efl/fast/dom/importNodeHTML-expected.png:
platform/efl/fast/dom/importNodeXML-expected.png:
platform/efl/fast/dom/row-inner-text-expected.png:
platform/efl/fast/dom/scroll-reveal-left-overflow-expected.png:
platform/efl/fast/dom/scroll-reveal-top-overflow-expected.png:

4:42 AM Changeset in webkit [125767] by vsevik@chromium.org

7 edits in trunk

Web Inspector: Breakpoints are not correctly restored on reload.
https://bugs.webkit.org/show_bug.cgi?id=94209

Reviewed by Pavel Feldman.

Source/WebCore:

BreakpointManager now resets uiLocations on workspace reset (was doing it on GlobalObjectCleared).
Breakpoint manager now calls restoreBreakpoints automatically when uiSourceCode is added to workspace.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._workspaceReset):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

inspector/front-end/inspector.js:

LayoutTests:

restoreBreakpoints is not called inside the test anymore to test that it is called automatically.

inspector/debugger/breakpoint-manager-expected.txt:
inspector/debugger/breakpoint-manager.html:

3:53 AM Changeset in webkit [125766] by pierre.rossi@gmail.com

21 edits
1 delete in trunk

[Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
https://bugs.webkit.org/show_bug.cgi?id=93960

Reviewed by Simon Hausmann.

Following the removal of Qt 4 support from trunk in r124879.

Source/WebCore:

No new tests. Simple cleanup job.

Target.pri:
platform/graphics/Font.cpp:

(WebCore::Font::codePath):

platform/graphics/Font.h:

(Font):

platform/graphics/GraphicsContext.cpp:

(WebCore):

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):
(WebCore::SimpleFontData::glyphForCharacter):

platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):

platform/graphics/qt/FontCacheQt.cpp:

(WebCore::rawFontForCharacters):
(WebCore::FontCache::getFontDataForCharacters):

platform/graphics/qt/FontCustomPlatformData.h:

(FontCustomPlatformData):

platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):

platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(FontPlatformDataPrivate):
(FontPlatformData):
(WebCore::FontPlatformData::FontPlatformData):

platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::hash):

platform/graphics/qt/FontQt4.cpp: Removed.
platform/graphics/qt/GlyphPageTreeNodeQt.cpp:

(WebCore::GlyphPage::fill):

platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):

rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):

Source/WebKit/blackberry:

WebCoreSupport/AboutDataHaveFeatures.in: Remove all traces of HAVE_QRAWFONT's existence.

Source/WebKit2:

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

Tools:

qmake/mkspecs/features/features.prf:

3:02 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com

Moving the openssl note to the top with other dependencies. (diff)

2:56 AM Changeset in webkit [125765] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening after r125592, r125635
https://bugs.webkit.org/show_bug.cgi?id=94197

Unreviewed gardening.

Gardening of fast/overflow/line-clamp-and-columns.html and
http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-16

platform/efl/TestExpectations:

2:56 AM BuildingQtOnWindows edited by kevin.funk@kdab.com

Add note about ICU (diff)

2:53 AM BuildingQtOnWindows edited by kevin.funk@kdab.com

Add grep dependency (diff)

2:28 AM Changeset in webkit [125764] by keishi@webkit.org

2 edits in trunk/Source/WebKit/chromium

DOMWindowPagePopup needs to be installed before loading the html inside the page popup
https://bugs.webkit.org/show_bug.cgi?id=94193

Reviewed by Kent Tamura.

We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html.

src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

2:18 AM Changeset in webkit [125763] by yurys@chromium.org

10 edits in trunk/Source/WebCore

Web Inspector: memory instrumentation for Resource{Request/Response}Base
https://bugs.webkit.org/show_bug.cgi?id=94109

Reviewed by Vsevolod Vlasov.

Added reportMemoryUsage methods to ResourceRequestBase, ResourceResponseBase
and several related classes.

dom/MemoryInstrumentation.cpp:

(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl): added overrides
for String, StringImpl and AtomicString object types so that we can reuse
existing addInstrumentedCollection method instead of adding a counterpart
that would operate on not instrumented content. Next step would be to get
rid od addObject overrides for these types so that all kinds of Strings are
considered as instrumented classes despite they don't have reportMemoryUsage
method.
(WebCore):

dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(MemoryInstrumentation):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):
(WebCore):

platform/network/FormData.h:

(WebCore):
(FormData):

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsage):
(WebCore):

platform/network/ResourceRequestBase.h:

(ResourceRequestBase):

platform/network/ResourceResponseBase.cpp:

(WebCore):
(WebCore::ResourceResponseBase::reportMemoryUsage):

platform/network/ResourceResponseBase.h:

(WebCore):
(ResourceResponseBase):

2:12 AM Changeset in webkit [125762] by commit-queue@webkit.org

2 edits
2 adds in trunk/Source/WebKit2

[EFL][WK2] Add unit tests for Web intent registration
https://bugs.webkit.org/show_bug.cgi?id=94133

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-16
Reviewed by Kenneth Rohde Christiansen.

Add unit tests for Web Intent service registration.
This tests the "intent,service,register" signaling
on the Ewk_View as well as Ewk_Intent_Service.

PlatformEfl.cmake:
UIProcess/API/efl/tests/resources/intent-service.html: Added.
UIProcess/API/efl/tests/test_ewk2_intents.cpp: Added.

(onIntentServiceRegistration):
(TEST_F):

2:09 AM Changeset in webkit [125761] by abarth@webkit.org

8 edits in trunk/Source/WebCore

Delete DOMWindow::securityOrigin()
https://bugs.webkit.org/show_bug.cgi?id=93991

Reviewed by Eric Seidel.

DOMWindow::securityOrigin() just calls through to
document()->securityOrigin(). This patch updates all the callers to do
that work themselves, making it clearer what's going on at each call
site.

bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):

bindings/js/JSDOMWindowCustom.h:

(WebCore::JSDOMWindowBase::allowsAccessFromPrivate):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::collectIsolatedContexts):

page/DOMWindow.cpp:

(WebCore::DOMWindow::isInsecureScriptAccess):
(WebCore::DOMWindow::createWindow):

page/DOMWindow.h:

(DOMWindow):

page/Location.cpp:

(WebCore::Location::reload):

1:54 AM Changeset in webkit [125760] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r125751.
http://trac.webkit.org/changeset/125751
https://bugs.webkit.org/show_bug.cgi?id=94206

we shouldn't be rolling out this patch without a formal
review. (Requested by rniwa_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

editing/FrameSelection.cpp:

(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWasReplaced):

editing/FrameSelection.h:

(FrameSelection):

1:52 AM Changeset in webkit [125759] by commit-queue@webkit.org

19 edits
2 adds in trunk

.: FormController, WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

Source/autotools/symbols.filter: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.

Source/WebCore: FormController, FileInputType: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

Test: fast/forms/file/selected-files-from-history-state.html

WebCore.exp.in: Exported FormController::getReferencedFilePaths.
html/FileInputType.cpp:

(WebCore::FileInputType::filesFromFormControlState): Added. Extracts FileChooserFileInfos from a FormControlState.
(WebCore):
(WebCore::FileInputType::restoreFormControlState): Refactored to use filesFromFormControlState.

html/FileInputType.h:

(FileInputType): Added filesFromFormControlState.

html/FormController.cpp:

(SavedFormState): Added getReferencedFilePaths.
(WebCore::SavedFormState::getReferencedFilePaths): Added. Extracts selected file paths from SavedFormState.
(WebCore):
(WebCore::FormController::setStateForNewFormElements): Refactored to use formStatesFromStateVector.
(WebCore::FormController::formStatesFromStateVector):
(WebCore::FormController::getReferencedFilePaths): Added. Static. Extracts selected file paths from a document state.

html/FormController.h:

(FormController): Added getReferencedFilePaths and formStatesFromStateVector.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::filesFromFileInputFormControlState): Added. Delegates to FileInputType::filesFromFormControlState.
(WebCore):

html/HTMLInputElement.h: Added filesFromFileInputFormControlState.

(HTMLInputElement):

testing/Internals.cpp:

(WebCore::Internals::getReferencedFilePaths): Calls FormController::getReferencedFilePaths.
(WebCore):

testing/Internals.h:

(Internals): Added getReferencedFilePaths.

testing/Internals.idl: Added binding for getReferencedFilePaths.

Source/WebKit/chromium: WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

public/WebHistoryItem.h:

(WebHistoryItem): Added getReferencedFilePaths.

src/WebHistoryItem.cpp:

(WebKit::WebHistoryItem::getReferencedFilePaths): Extracts selected and posted file paths from a document state.
(WebKit):

Source/WebKit2: FormController, WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

win/WebKit2.def: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.

LayoutTests: FormController: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

fast/forms/file/selected-files-from-history-state-expected.txt: Added.
fast/forms/file/selected-files-from-history-state.html: Added.

1:50 AM Changeset in webkit [125758] by shawnsingh@chromium.org

5 edits
4 adds in trunk

[chromium] set scissorRect per quad so that quads are correctly clipped
https://bugs.webkit.org/show_bug.cgi?id=94050

Reviewed by Adrienne Walker.

Source/WebCore:

Certain quad types rely on scissoring to do correct
clipping. Refactoring the quad types to remove this assumption
will be done in a later patch, but for now, we have to apply the
scissor rect to every quad to ensure that those quads are
correctly clipped.

Test: compositing/overflow/overflow-hidden-canvas-layer.html

Also updated two unit tests to reflect the change in semantics.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):

Source/WebKit/chromium:

Updated two unit tests to reflect that we need to always scissor,
until we refactor so that quads do not depend on scissoring.

tests/CCLayerTreeHostImplTest.cpp:

LayoutTests:

compositing/overflow/overflow-hidden-canvas-layer-expected.png: Added.
compositing/overflow/overflow-hidden-canvas-layer-expected.txt: Added.
compositing/overflow/overflow-hidden-canvas-layer.html: Added.

1:42 AM EFLWebKitCodingStyle edited by kenneth@webkit.org

(diff)

1:07 AM Changeset in webkit [125757] by hbono@chromium.org

2 edits in trunk/Source/WebKit/chromium

Prevent showing suggestions when right-clicking a selection range.
https://bugs.webkit.org/show_bug.cgi?id=94189

Reviewed by Hajime Morita.

To emulate Safari, my r120810 changes selection when right-clicking a misspelled
word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange
and it changes the existing selection when right-clicking a selection which
includes a misspelled word. This change uses VisibleSelection::isCaret to
prevent showing suggestions when right-clicking a selection range. (Neither does
Safari show suggestions when there is a selection range.)

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

12:57 AM Changeset in webkit [125756] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for two accessibility tests introduced in r125710.

Rebaselining fast/css/word-space-extra.html after r125578.

platform/gtk/TestExpectations:
platform/gtk/fast/css/word-space-extra-expected.txt:

12:54 AM Changeset in webkit [125755] by commit-queue@webkit.org

3 edits in trunk/Tools

Add deleteFileSystem support to DumpRenderTree for chromium
https://bugs.webkit.org/show_bug.cgi?id=94071

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-16
Reviewed by Kent Tamura.

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::deleteFileSystem): Added

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

12:34 AM Changeset in webkit [125754] by yosin@chromium.org

3 edits
3 adds in trunk

[Forms] Wheel event support in multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94166

Reviewed by Kent Tamura.

Source/WebCore:

This patch makes multiple fields time input UI to handle wheel event
on spin button.

This patch affects if ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_MULTIPLE_FIELDS
are enabled.

Test: fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html

html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::defaultEventHandler): Changed to forward
event to spin button if available.

LayoutTests:

This patch adds a test for wheel event handling in multiple fields
time input UI.

fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html: Added.

12:28 AM Changeset in webkit [125753] by vsevik@chromium.org

1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/HandlerRegistry.js

Merge 125668 - Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
https://bugs.webkit.org/show_bug.cgi?id=94074

Reviewed by Pavel Feldman.

Added dirty flag check when saving uiSourceCode to save working copy in this case.

inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

BUG=141180
TBR=vsevik@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828339

12:18 AM Changeset in webkit [125752] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
https://bugs.webkit.org/show_bug.cgi?id=94180

Patch by Zhigang Gong <zhigang.gong@linux.intel.com> on 2012-08-16
Reviewed by Noam Rosenthal.

platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginPainting):

12:06 AM Changeset in webkit [125751] by inferno@chromium.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r119705.
http://trac.webkit.org/changeset/119705
https://bugs.webkit.org/show_bug.cgi?id=94192

Causing crash on ClusterFuzz due to incorrect layout ordering
change (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

editing/FrameSelection.cpp:

(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWillBeReplaced):

editing/FrameSelection.h:

(FrameSelection):

Aug 15, 2012:

11:20 PM Changeset in webkit [125750] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-15

DEPS:

11:01 PM Changeset in webkit [125749] by tkent@chromium.org

3 edits in trunk/Source/WebCore

[Chromium] Refactoring: Introduce a new function for some part of PopupContainer::layoutAndCalculateWidgetRect()
https://bugs.webkit.org/show_bug.cgi?id=94087

Reviewed by Hajime Morita.

Move some part of PopupContainer::layoutAndCalculateWidgetRect() to a
new function which is not a member of PopupContainer because we'd like
to add a unit test for the position calculation code, and to reduce the
dependency.

No new tests. Popup positioning code is not testable in WebKit.

platform/chromium/PopupContainer.cpp:

(WebCore::layoutAndCalculateWidgetRectInternal):
Added. Move the code from PopupContainer::layoutAndCalculateWidgetRect.
In order to avoid to call member functions of PopupContainer, we
don't call layoutAndGetRTLOffset() and height(). Use
PopupListBox::layout() to recalculate the popup content size, and use
PopupListBox::height() + kBorderSize * 2 instead of height(). We
resize the view after finishing layoutAndCalculateWidgetRectInternal
in PopupContainer::layoutAndCalculateWidgetRect.
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
Move some code to layoutAndCalculateWidgetRectInternal.
(WebCore::PopupContainer::fitToListBox):
Added. Move the code from PopupContainer::layoutAndGetRTLOffset.
(WebCore::PopupContainer::layoutAndGetRTLOffset):
Move some code to fitToListBox.

platform/chromium/PopupContainer.h:

(PopupContainer): Added fitToListBox.

10:59 PM Changeset in webkit [125748] by yosin@chromium.org

8 edits in trunk/LayoutTests

[Tests] Disable fast/forms/time-multiple-fields tests for port which don't enable multiple fields time input UI feature
https://bugs.webkit.org/show_bug.cgi?id=94186

Reviewed by Kent Tamura.

This patch disables tests in fast/forms/time-multiple-fields.
These tests are enabled if both ENABLE_INPUT_TYPE_TIME and
ENABLED_INPUT_TYPE_TIME_MULTIPLE_FIELDS enabled.

platform/chromium/TestExpectations:
platform/efl/tExpectations:
platform/gtk/TestExpectations:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:

10:37 PM Changeset in webkit [125747] by yosin@chromium.org

3 edits in trunk/LayoutTests

[Forms] Re-factor fast/forms/number/number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94172

Reviewed by Kent Tamura.

This patch moves test code from number-wheel-event.html to common-wheel-event.js
for sharing test code among input types.

fast/forms/number/number-wheel-event.html:
fast/forms/resources/common-wheel-event.js:

(testWheelEvent):

10:21 PM Changeset in webkit [125746] by shinyak@chromium.org

6 edits in trunk/LayoutTests

REGRESSION (r125659): 4 HTMLMeterElement tests fail on Mac.
https://bugs.webkit.org/show_bug.cgi?id=94157

Unreviewed, unskip failing tests and rebaseline after r125659.

platform/mac/Skipped:
platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:

10:01 PM Changeset in webkit [125745] by abarth@webkit.org

25 edits
1 move
1 add
5 deletes in trunk/Source/WebCore

VoidCallback should not be a special snowflake
https://bugs.webkit.org/show_bug.cgi?id=94119

Reviewed by Eric Seidel.

VoidCallback is the oldest of the callbacks and it predates our ability
to autogenerate callback objects. The existing implementation of
VoidCallback is wrong because it doesn't call
ActiveDOMCallback::canInvokeCallback. The net result of that is that
void callbacks can race with navigations and occationally execute after
the Frame has navigated to a new Document, which was causing the
flakiness.

This patch changes VoidCallback to no longer be a unique snowflake.
Instead, we autogenerate the implementation, just like every other
callback in WebCore.

Tests: storage/websql/database-lock-after-reload.html is no longer flaky.

DerivedSources.make:
GNUmakefile.list.am:
Modules/filesystem/SyncCallbackHelper.h:

(WebCore::SyncCallbackHelper::SuccessCallbackImpl::handleEvent):

Target.pri:
UseJSC.cmake:
UseV8.cmake:
WebCore.gyp/WebCore.gyp:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/cpp/WebDOMCustomVoidCallback.cpp: Removed.
bindings/cpp/WebDOMCustomVoidCallback.h: Removed.
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSCustomVoidCallback.cpp: Removed.
bindings/js/JSCustomVoidCallback.h: Removed.
bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotificationCenter::requestPermission):

bindings/scripts/CodeGeneratorCPP.pm:

(GetClassName):
(AddIncludesForType):

bindings/scripts/CodeGeneratorJS.pm:

(GetCallbackClassName):
(GenerateCallbackImplementation):
(JSValueToNative):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackImplementation):
(TypeCanFailConversion):
(GetCallbackClassName):

bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithNoParam):

bindings/scripts/test/V8/V8TestCallback.cpp:
bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
bindings/v8/custom/V8CustomVoidCallback.cpp: Removed.
bindings/v8/custom/V8CustomVoidCallback.h: Removed.
bindings/v8/custom/V8MutationCallbackCustom.cpp:
bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallback):

html/VoidCallback.h:

(VoidCallback):

html/VoidCallback.idl:
inspector/InspectorDatabaseAgent.cpp:

(WebCore):

9:51 PM Changeset in webkit [125744] by hayato@chromium.org

5 edits in trunk

[Shadow] Stop 'load' and 'error' events at shadow boundaries
https://bugs.webkit.org/show_bug.cgi?id=93425

Reviewed by Dimitri Glazkov.

Source/WebCore:

The shadow DOM spec has added these events as 'always-be-stopped' events at shadow boundaries.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped

Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

LayoutTests:

fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
fast/dom/shadow/events-stopped-at-shadow-boundary.html:

9:21 PM Changeset in webkit [125743] by yosin@chromium.org

1 edit
1 copy in trunk/LayoutTests

[Tests] Copy to fast/forms/resources/common-wheel-event.js from fast/forms/number/number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94184

Reviewed by Kent Tamura.

This patch copies fast/forms/number/number-wheel-event.html
to fast/forms/resources/common-wheel-event.js for sharing
test code among input types.

fast/forms/resources/common-wheel-event.js: Copied from LayoutTests/fast/forms/number/number-wheel-event.html.

8:56 PM Changeset in webkit [125742] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

(r125629): Newly added test css3/filters/custom/filter-fallback-to-software.html failing on mac
https://bugs.webkit.org/show_bug.cgi?id=94169

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Sam Weinig.

Update TestExpecatations of failing test to make the bot green.

platform/mac/TestExpectations:

8:54 PM Changeset in webkit [125741] by tkent@chromium.org

7 edits in trunk

Calendar Picker: Localize numbers in a calendar picker
https://bugs.webkit.org/show_bug.cgi?id=93704

Reviewed by Hajime Morita.

ManualTests/forms/calendar-picker.html:

Add a mock pagePopupController.localizeNumberString().

Source/WebCore:

Because Number.toLocaleString() of V8 returns no localized
numbers, we provide a localization function via
PagePopupController.

No new tests. We have no ways to change the locale in layout tests.

Resources/pagepopups/calendarPicker.js:

(localizeNumber): Added. A wrapper for pagePopupController.localizeNumberString().
(formatJapaneseImperialEra): Use localizeNumber().
(formatYearMonth): ditto.
(DaysTable.prototype._renderMonth): ditto.

page/PagePopupController.cpp:

(WebCore::PagePopupController::localizeNumberString):
Added. Just calls WebCore::convertToLocalizedNumber().

page/PagePopupController.h:

(PagePopupController): Declare localizeNumberString().

page/PagePopupController.idl: Add localizeNumberString().

8:45 PM Changeset in webkit [125740] by yosin@chromium.org

1 edit
2 moves in trunk/LayoutTests

[Forms] Rename LayoutTests/fast/forms/number/number-wheel.html to number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94173

Reviewed by Kent Tamura.

This patch renames LayoutTest/fast/forms/number/number-wheel.html to
number-wheel-event.html to indicate the test checks wheel event
handling.

fast/forms/number/number-wheel-event-expected.txt: Copied from LayoutTests/fast/forms/number/number-wheel-expected.txt.
fast/forms/number/number-wheel-event.html: Copied from LayoutTests/fast/forms/number/number-wheel.html.
fast/forms/number/number-wheel-expected.txt: Removed.
fast/forms/number/number-wheel.html: Removed.

8:05 PM Changeset in webkit [125739] by morrita@google.com

3 edits
2 adds in trunk

Regression(121518) TextFieldDecorationElement formatting is broken.
https://bugs.webkit.org/show_bug.cgi?id=90913

Reviewed by Dimitri Glazkov.

Source/WebCore:

NodeRenderingContext::nextRenderer() has a problem which cannot retrieve the renderer
across an insertion point in some case. That is because ad-hoc composed tree traversal on
NodeRenderingContext is broken. The problem is hidden before r121518 though.

This change rewrite nextRenderer() using ComposedShadowTreeWalker to eliminate the ad-hoc
traversal. previousRenderer() is also rewritten in the same way.

Test: fast/dom/shadow/shadow-div-reflow.html

dom/NodeRenderingContext.cpp:

(WebCore):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

LayoutTests:

fast/dom/shadow/shadow-div-reflow-expected.html: Added.
fast/dom/shadow/shadow-div-reflow.html: Added.

7:40 PM Changeset in webkit [125738] by rniwa@webkit.org

14 edits in trunk

Update manual tests and comments to refer to TestRunner instead of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=94168

Reviewed by Kent Tamura.

ManualTests/resources/multiFileResources/post-echo-and-notify-done.cgi:

Source/WebKit:

PlatformBlackBerry.cmake:

Source/WebKit/chromium:

public/WebDevToolsAgent.h:

(WebDevToolsAgent):

public/WebView.h:

(WebView):

Source/WebKit/qt:

Api/qwebelement.cpp:

(convertJSValueToWebElementVariant):

WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::getBoolValueForKey):

7:35 PM Changeset in webkit [125737] by jchaffraix@webkit.org

10 edits in trunk/Source/WebCore

Add a was-inserted-into-tree notification to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=93874

Reviewed by Eric Seidel.

This change adds insertedIntoTree to RenderObject so that renderers
can now do their post-insertion task inside this function.

Our current architecture has 2 ways of doing post-insertion tasks:

overriding RenderObject::addChild
RenderObjectChildList::insertChildNode / appendChildNode

Because the former is not guaranteed to be called for each insertion
(on top of being called on the parent and not the inserted child), the
2 latter functions are the one that have been mostly used recently. This
led to code duplication between the functions but also doesn't scale as
other renderers need to hop on this notification and currently don't (for
example, table parts). The other renderer's migration will be done in
follow-up patches.

Refactoring covered by existing tests.

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingRenderNamedFlowThread):
Moved the code from renderNamedFlowThreadContainer to RenderObject::enclosingRenderNamedFlowThread.
This is needed as now 2 classes need to access the function.

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Moved the code duplicated from those 2 functions into
the instances of insertedIntoTree below.

rendering/RenderObject.cpp:

(WebCore::RenderObject::insertedIntoTree):
Base function that needs to be called from all the other
specialized functions below.

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::insertedIntoTree):

rendering/RenderListItem.h:
rendering/RenderObject.h:
rendering/RenderObjectChildList.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::insertedIntoTree):

rendering/RenderRegion.h:

Added the overriden insertedIntoTree function.

rendering/RenderQuote.h:

Moved the comment from RenderObjectChildList about RenderQuote here.

7:19 PM FeatureFlags edited by Bruno de Oliveira Abinader

Added CSS3_TEXT_DECORATION feature flag information (diff)

7:14 PM Changeset in webkit [125736] by jpfau@apple.com

5 edits
5 adds in trunk

Allow blocking of Web SQL databases in third-party documents
https://bugs.webkit.org/show_bug.cgi?id=94057

Reviewed by Adam Barth.

Source/WebCore:

Add a check for pages in third-party pages to allow third-party storage blocking of Web SQL databases.

Tests: http/tests/security/cross-origin-websql-allowed.html

http/tests/security/cross-origin-websql.html

Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase): Pass top origin to canAccessDatabase

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canAccessStorage): Common method for various types of storage that use the same criteria

page/SecurityOrigin.h:

(WebCore::SecurityOrigin::canAccessDatabase): Use canAccessStorage
(WebCore::SecurityOrigin::canAccessLocalStorage): Change to using canAccessStorage
(SecurityOrigin):

LayoutTests:

Created tests for accessing openDatabase from a third party and first party context when third-party blocking is on and off.

http/tests/security/cross-origin-websql-allowed-expected.txt: Added.
http/tests/security/cross-origin-websql-allowed.html: Added.
http/tests/security/cross-origin-websql-expected.txt: Added.
http/tests/security/cross-origin-websql.html: Added.
http/tests/security/resources/cross-origin-iframe-for-websql.html: Added.

6:48 PM Changeset in webkit [125735] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Fix TestExpectations line format for two fast/css tests failing on mac
https://bugs.webkit.org/show_bug.cgi?id=94160

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Sam Weinig.

Remove "MAC" modifier, which seems to prevent the expectations from taking effect.

platform/mac/TestExpectations:

6:41 PM Changeset in webkit [125734] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Improve Document.h compile time - reduce includes of ScriptCallStack.h
https://bugs.webkit.org/show_bug.cgi?id=94161

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-15
Reviewed by Eric Seidel.

ScriptCallStack.h no longer included from ScriptExecutionContext. It's
relatively expensive to compile and gets compiled a ton because
Document.h indirectly includes it.

No new tests. Functionality should remain the same

Modules/indexeddb/IDBDatabase.cpp:
Modules/indexeddb/IDBIndex.cpp:
Modules/indexeddb/IDBObjectStore.cpp:
bindings/js/ScriptController.cpp:
dom/ScriptElement.cpp:
dom/ScriptExecutionContext.h:

(WebCore):

fileapi/Blob.cpp:
fileapi/WebKitBlobBuilder.cpp:
html/HTMLTrackElement.cpp:
loader/TextTrackLoader.cpp:
page/DOMSecurityPolicy.cpp:

6:27 PM Changeset in webkit [125733] by tkent@chromium.org

1 edit
2 copies in branches/chromium/1180

Merge 123637 - https://bugs.webkit.org/show_bug.cgi?id=89114
REGRESSION (r112919): Setting scrollTop after setting display from none to block
fails
-and corresponding-
<rdar://problem/11656050>

Reviewed by Simon Fraser.

Source/WebCore:

ScrollAnimatorMac::immediateScrollTo() and ScrollAnimatorMac::immediateScrollBy()
both have an optimization in place so that they do not call
notifyPositionChanged() if the new scroll offset matches the ScrollAnimator's
cached m_currentPosX and m_currentPosY. So revision 112919 caused troubled with
this optimization because it allowed RenderLayers to restore a scrollOffset from
the Element if there is one cached there. This caused the RenderLayer to have a
scrollOffset that is improperly out-of-synch with the ScrollAnimator's
currentPosition (which will just be 0,0 since it is being re-created like the
RenderLayer). This fix makes sure they are in synch by calling
setCurrentPosition() on the ScrollAnimator when the cached position is non-zero.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

LayoutTests:

fast/overflow/setting-scrollTop-after-hide-show-expected.txt: Added.
fast/overflow/setting-scrollTop-after-hide-show.html: Added.

TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823356

6:22 PM Changeset in webkit [125732] by rniwa@webkit.org

12 edits
8 moves in trunk/Tools

Rename LayoutTestController to TestRunner in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=93942

Reviewed by Simon Fraser.

Renamed the class and relevant files.

WebKitTestRunner/CMakeLists.txt:
WebKitTestRunner/DerivedSources.make:
WebKitTestRunner/GNUmakefile.am:
WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
WebKitTestRunner/InjectedBundle/DerivedSources.pri:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::testRunner):
(InjectedBundle):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
WebKitTestRunner/InjectedBundle/Target.pri:
WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.

(TestRunner):

WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.

(WTR::waitToDumpWatchdogTimerCallback):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.

WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.

(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::waitUntilDoneWatchdogTimerFired):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.

(WTR::WatchdogTimerHelper::timerFired):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.

(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::waitToDumpWatchdogTimerFired):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

WebKitTestRunner/PlatformEfl.cmake:
WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
WebKitTestRunner/win/InjectedBundle.vcproj:

6:03 PM Changeset in webkit [125731] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Update test expectations for css3/filters/custom/invalid-custom-filter-shader.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=94067

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Brady Eidson.

Add to the list of tests needing rebaselining after https://bugs.webkit.org/show_bug.cgi?id=6033

platform/mac/TestExpectations:

5:57 PM Changeset in webkit [125730] by commit-queue@webkit.org

9 edits in trunk/Source/WebCore

IndexedDB: IDB*::keyPath should return IDBKeyPath, not IDBAny
https://bugs.webkit.org/show_bug.cgi?id=92434

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-15
Reviewed by Tony Chang.

Clean up IDBKeyPath conversion to IDBAny objects. This gets rid of
some implicit conversion from IDBKeyPath to IDBAny.

No new tests, just changing method signatures.

Modules/indexeddb/IDBAny.cpp:

(WebCore::IDBAny::set):
(WebCore):

Modules/indexeddb/IDBAny.h:

(WebCore):
(WebCore::IDBAny::create):
(IDBAny):

Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::keyPathAny):
(WebCore::IDBIndex::keyPath):

Modules/indexeddb/IDBIndex.idl:
Modules/indexeddb/IDBKeyPath.cpp:
Modules/indexeddb/IDBKeyPath.h:
Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::keyPathAny):
(WebCore::IDBObjectStore::keyPath):

Modules/indexeddb/IDBObjectStore.idl:

5:52 PM Changeset in webkit [125729] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

EFL build fix attempt after r125711. Touch an IDL file to regenerate derived sources.

html/HTMLAllCollection.idl:

5:50 PM Changeset in webkit [125728] by commit-queue@webkit.org

27 edits
2 adds in trunk

IndexedDB: generate index keys for existing data in createIndex in front end
https://bugs.webkit.org/show_bug.cgi?id=91125

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-15
Reviewed by Tony Chang.

Source/WebCore:

Make createIndex() do index key generation in the frontend, rather
than the backend. When an index is created, the frontend uses the
cursor API to iterate through the values in the backend to
generate keys, sending them back to the backend using
IDBObjectStore::setIndexKeys()

This confines all key injection/extraction to the frontend.

The new test verifies the implemented behavior with respect to
error handling in degenerate uses of put(), though that behavior
is still in discussion as the spec is vague on the proper error
behavior.

Test: storage/indexeddb/lazy-index-population.html

Modules/indexeddb/IDBCursorBackendImpl.cpp: Make sure that the

TaskType propagates throught the cursor and all subsequent
continue() calls.
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):

Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):

Modules/indexeddb/IDBObjectStore.cpp: Add an IndexPopulator

class to run a cursor from the frontend.
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):

Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
(WebCore::IDBObjectStore::createIndex):

Modules/indexeddb/IDBObjectStore.idl: Pass along ScriptContext

so that openCursor can be called from createIndex.

Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReadyInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):

Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::iterIndexesBegin):
(WebCore::IDBObjectStoreBackendImpl::iterIndexesEnd):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):

Modules/indexeddb/IDBObjectStoreBackendInterface.h:
Modules/indexeddb/IDBRequest.cpp:

Allow requests to keep their own TaskType, to give certain
requests priority over others.
(WebCore::IDBRequest::create):
(WebCore):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):

Modules/indexeddb/IDBRequest.h:

(IDBRequest):
(WebCore::IDBRequest::taskType):

Modules/indexeddb/IDBTransactionBackendImpl.cpp:

Introduce a second, higher priority event queue, m_preemptiveTaskQueue,
which takes priority over the regular task queue.
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(WebCore::IDBTransactionBackendImpl::isTaskQueueEmpty):
(WebCore):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::addEarlyEvent):
(WebCore::IDBTransactionBackendImpl::didCompleteEarlyEvent):

Modules/indexeddb/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):

Source/WebKit/chromium:

Add Chromium API methods to let the renderer process tell the
browser process about indexing progress.

public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::openCursor):

src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::openCursor):

src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::openCursor):

src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

LayoutTests:

The transaction should be aborted when existing data in an
objectStore causes uniqueness errors during index creation.

storage/indexeddb/lazy-index-population-expected.txt: Added.
storage/indexeddb/lazy-index-population.html: Added.

5:43 PM Changeset in webkit [125727] by hayato@chromium.org

4 edits
2 adds in trunk

A 'load' event should be fired on the shadow host directly, not on an inner image element of shadow dom subtree.
https://bugs.webkit.org/show_bug.cgi?id=93920

Reviewed by Dimitri Glazkov.

Source/WebCore:

A 'load' event is a must-stoppable event at shadow boundary. So we
should fire a 'load' event on a shadow host directly, not on an
inner image element.

Test: fast/dom/shadow/shadowdom-for-image-event.html

html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):

loader/ImageLoaderClient.h:

(WebCore::ImageLoaderClient::eventTarget):

LayoutTests:

fast/dom/shadow/shadowdom-for-image-event-expected.txt: Added.
fast/dom/shadow/shadowdom-for-image-event.html: Added.

5:38 PM Changeset in webkit [125726] by wangxianzhu@chromium.org

2 edits in trunk/Tools

[Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
https://bugs.webkit.org/show_bug.cgi?id=94155

Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.create_driver): Force no_timeout=True

5:18 PM Changeset in webkit [125725] by rniwa@webkit.org

2 edits in trunk/Tools

Add a hyperlink to perf-o-matic from build.webkit.org/root.html
https://bugs.webkit.org/show_bug.cgi?id=93749

Reviewed by Csaba Osztrogonác.

Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
of performance tests.

BuildSlaveSupport/build.webkit.org-config/templates/root.html:

5:05 PM Changeset in webkit [125724] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[Qt] new test fast/forms/radio/radio-group.html introduced in r104668 fails
https://bugs.webkit.org/show_bug.cgi?id=76051

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-15
Reviewed by Csaba Osztrogonác.

Unskip now working test.

platform/qt/Skipped:

4:43 PM Changeset in webkit [125723] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add a layout test for :lang() selector observing dynamic changes to lang
https://bugs.webkit.org/show_bug.cgi?id=94092

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-08-15
Reviewed by Alexey Proskuryakov.

This patch adds a test that dynamic changes to the lang attribute are seen by the :lang selector.
This behavior was first added in an earlier patch (probably http://trac.webkit.org/changeset/103608)
but there was no layout test for it yet.

fast/selectors/lang-dynamic-expected.html: Added.
fast/selectors/lang-dynamic.html: Added.

4:38 PM Changeset in webkit [125722] by beidson@apple.com

2 edits in trunk/LayoutTests

REGRESSION (125659): 4 HTMLMeterElement tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=94157

Skipping these 4 tests until the perpetrator can fix.

Not reviewed (Bot gardening).

platform/mac/Skipped:

4:34 PM Changeset in webkit [125721] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] When there is an exception we want to check if the ref is 0, not the
value as JSObjectCallAsFunction returns 0 in that case.
https://bugs.webkit.org/show_bug.cgi?id=94153

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-08-15
Reviewed by Yong Li.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

4:32 PM Changeset in webkit [125720] by commit-queue@webkit.org

5 edits
13 adds in trunk/LayoutTests

[EFL] Some late night gardening
https://bugs.webkit.org/show_bug.cgi?id=94151

Unreviewed, EFL gardening.

Moving the autoscroll test out, adding platform specific baselines for the HTMLMeterElement tests.

Patch by Dominik Röttsches <d-r@roettsches.de> on 2012-08-15

platform/efl/TestExpectations:
platform/efl/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
platform/efl/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/efl/fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
platform/efl/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt: Added.

3:54 PM Changeset in webkit [125719] by enne@google.com

2 edits in trunk/LayoutTests

[chromium] Mark canvas-fallback-content tests as asserting in debug builds
https://bugs.webkit.org/show_bug.cgi?id=94156

Unreviewed gardening. Update expectations.

platform/chromium/TestExpectations:

3:42 PM Changeset in webkit [125718] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Show custom error page when 407 is received
https://bugs.webkit.org/show_bug.cgi?id=94138

Reviewed by George Staikos.
Internally reviewed by Lianghui Chen

Adding a new custom error page when the browser receieves
a Wifi proxy authentication error. The previous behaviour
is to ask for user credentials everytime, and silently fails
when the username and password fields in the Wifi settings
are not empty. UX suggests modifying the behaviour to simply
asks the user to change their credentials in the Wifi settings
when we receive such an error.

The fix is to prevent notifyAuthReceived from sending another
networkjob when authCallbacks are called, and to listen to any 407
calls in notifyStatusReceived. Once we hit a 407, tell the frame we
failed and should load the custom error page.

Also removed checking functions in sendRequestWithCredentials because
proxy auth requests won't get into that function anymore.

#PR163400

Tested by loading on device and loading/reloading pages under
these scenarios:

Connected to wifi (no proxy)
Connected to wifi (proxy with no credentials)
Connected to wifi (proxy with invalid credentials)
Connected to wifi (proxy with valid credentials)

platform/network/blackberry/NetworkJob.cpp: (WebCore::NetworkJob::handleNotifyStatusReceived): (WebCore::NetworkJob::notifyAuthReceived): (WebCore::NetworkJob::sendRequestWithCredentials):

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-08-15

3:37 PM Changeset in webkit [125717] by commit-queue@webkit.org

8 edits
2 deletes in trunk/Source/WebCore

Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971

Patch by Dan Carney <dcarney@google.com> on 2012-08-15
Reviewed by Adam Barth.

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This paves the way towards a JSC-like use of DOMWrapperWorld.

No tests. No change in functionality.

UseV8.cmake:
WebCore.gypi:
bindings/v8/DOMWrapperWorld.cpp:

(WebCore):
(WebCore::mainThreadNormalWorld):

bindings/v8/DOMWrapperWorld.h:

(WebCore):
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::count):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

bindings/v8/IsolatedWorld.cpp: Removed.
bindings/v8/IsolatedWorld.h: Removed.
bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):

3:31 PM Changeset in webkit [125716] by commit-queue@webkit.org

38 edits
2 moves
1 add in trunk

[css3-text] Add CSS3 Text decoration compile flag
https://bugs.webkit.org/show_bug.cgi?id=93863

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-15
Reviewed by Julien Chaffraix.

This patch handles the compile flag implementation, which will come disabled by
default, thus not exposing the CSS3 text decoration features to the web, unless
when explicitly enabling it with "--css3-text-decoration" build parameter.

Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:
configure.ac:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Changeset r125205 added "-webkit-text-decoration-line" support without proper
compile flag. I am fixing this on this patch by adding #ifdef's along the added
code and reverting getComputedStyle* layout test changes until further notice.
The text-decoration-line.html layout test is now moved to
fast/css3-text-decoration directory, which is skipped on all platforms until
feature is sound and ready to be exposed to web.

Test: fast/css3-text-decoration/text-decoration-line.html

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecoration):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:
css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):
Added #ifdefs to enable/disable CSS3 Text Decoration code implemented by r125205.

Source/WebKit/chromium:

features.gypi:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/webkitperl/FeatureList.pm:
qmake/mkspecs/features/features.pri:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/resources/property-names.js:
svg/css/getComputedStyle-basic-expected.txt:

Avoid regression by reverting changes from r125205.

fast/css3-text-decoration/text-decoration-line-expected.html: Renamed from LayoutTests/fast/css/text-decoration-line-expected.html.
fast/css3-text-decoration/text-decoration-line.html: Renamed from LayoutTests/fast/css/text-decoration-line.html.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:

fast/css3-text-decoration directory is skipped until feature is enabled by default.

3:14 PM Changeset in webkit [125715] by commit-queue@webkit.org

13 edits in trunk/Source

Refactoring: move EventHandler::targetNode into HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=94107

Patch by Iain Merrick <husky@chromium.org> on 2012-08-15
Reviewed by Dimitri Glazkov.

Source/WebCore:

This static helper method in EventHandler was made public so that
WebFrameImpl can call it. That's untidy because EventHandler isn't
really involved. This patch turns it into an instance method of
HitTestResult (with a wrapper in MouseEventWithHitTestResult for
convenience).

Pure refactoring, no behavior change, no new test needed.

page/EventHandler.cpp:

(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::subframeForHitTestResult):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::sendContextMenuEvent):

page/EventHandler.h:

(EventHandler):

page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::targetNode):

page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):

page/wx/EventHandlerWx.cpp:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::targetNode):
(WebCore):

rendering/HitTestResult.h:

(HitTestResult):

Source/WebKit/chromium:

Pure refactoring, no behavior change, no new test needed.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

3:07 PM Changeset in webkit [125714] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream FrameLoaderClientBlackBerry::securityOriginForNewDocument()
https://bugs.webkit.org/show_bug.cgi?id=94139

Patch by Yong Li <yoli@rim.com> on 2012-08-15
Reviewed by Antonio Gomes.

Keep same security origin when a file URL automatically redirects to its child folder.
This patch will be reverted when we finish the better solution.
PR# 172333 and PR# 180590.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientBlackBerry::securityOriginForNewDocument):
(WebCore):

WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

2:54 PM Changeset in webkit [125713] by dgrogan@chromium.org

6 edits in trunk/Source

IndexedDB: Add some ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=94055

Reviewed by Ojan Vafai.

Source/WebCore:

These are just some additional ASSERTS and some ASSERT_WITH_MESSAGE in
place of ASSERT. They are from the patch in
https://bugs.webkit.org/show_bug.cgi?id=92897

No new tests - we should never hit this behavior.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::registerFrontendCallbacks):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setActive):

Source/WebKit/chromium:

src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::setVersion):

2:41 PM Changeset in webkit [125712] by leviw@chromium.org

10 edits
5 deletes in trunk/LayoutTests

More unreviewed updated expectations from r125694.

platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

2:35 PM Changeset in webkit [125711] by commit-queue@webkit.org

61 edits
3 deletes in trunk

Unreviewed, rolling out r125687.
http://trac.webkit.org/changeset/125687
https://bugs.webkit.org/show_bug.cgi?id=94147

It broke the whole world (Requested by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-15

Source/JavaScriptCore:

API/JSValueRef.cpp:

(JSValueToBoolean):

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
bytecode/Watchpoint.h:

(WatchpointSet):

debugger/DebuggerCallFrame.h:
dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

runtime/JSCell.h:

(JSCell):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSGlobalObject.h:

(JSGlobalObject):

runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

runtime/JSValue.h:
runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):

runtime/Operations.h:

(JSC):
(JSC::JSValue::equalSlowCaseInline):

runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

runtime/Structure.h:

Source/WebCore:

bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

bindings/js/JavaScriptCallFrame.cpp:
bindings/js/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateEventListenerCall):
(GenerateHeader):
(JSValueToNative):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):

Source/WebKit2:

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

LayoutTests:

fast/js/document-all-between-frames-expected.txt: Removed.
fast/js/document-all-between-frames.html: Removed.
fast/js/resources/document-all-between-frames-subframe.html: Removed.
platform/chromium/TestExpectations:

2:31 PM Changeset in webkit [125710] by dmazzoni@google.com

30 edits
6 adds in trunk

AX: Calls to AXObjectCache should prefer Node over Renderer
https://bugs.webkit.org/show_bug.cgi?id=91794

Reviewed by Chris Fleizach.

Source/WebCore:

Now that it's possible for nodes inside a canvas subtree to be focused and
represent accessible content, accessibility notifications should be triggered
with a Node* rather than with a RenderObject* whenever possible.

Every public API in AXObjectCache that took a RenderObject* before now either
takes a Node* instead, or has a parallel method that takes a Node*.

Tests: accessibility/accessibility-node-memory-management.html

accessibility/accessibility-node-reparent.html
accessibility/canvas-fallback-content.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::contentChanged):
(WebCore):
(WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::AXObjectCache::nodeIsTextControl):

accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::setNodeInUse):
(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::isNodeInUse):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::contentChanged):
(WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):

accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::parentObject):

accessibility/AccessibilityObject.cpp:

(WebCore::appendAccessibilityObject):
(WebCore::replacedNodeNeedsCharacter):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::menuForMenuButton):
(WebCore::AccessibilityRenderObject::menuButtonForMenu):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

bindings/cpp/WebDOMCustomVoidCallback.cpp:

(toWebCore):

dom/Document.cpp:

(WebCore::Document::setFocusedNode):

dom/Element.cpp:

(WebCore::Element::attributeChanged):

dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::attach):

editing/AppendNodeCommand.cpp:

(WebCore::sendAXTextChangedIgnoringLineBreaks):

editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

editing/chromium/FrameSelectionChromium.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::optionElementChildrenChanged):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

html/InputType.cpp:

(WebCore::InputType::applyStep):

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

LayoutTests:

New tests:

canvas-fallback-content tests that objects in a canvas subtree can be focused and then you can retrieve the role of the accessible object.
accessibility-node-memory-management ensures that an AccessibilityNodeObject is detached when its node is destroyed.
accessibility-node-reparent ensures that if an AccessibilityNodeObject is created for a node without a renderer, but the node later gets a renderer, the AccessibilityNodeObject is detached and an AccessibilityRenderObject is created instead.

accessibility/accessibility-node-memory-management-expected.txt: Added.
accessibility/accessibility-node-memory-management.html: Added.
accessibility/accessibility-node-reparent-expected.txt: Added.
accessibility/accessibility-node-reparent.html: Added.
accessibility/canvas-fallback-content-expected.txt: Added.
accessibility/canvas-fallback-content.html: Added.
platform/gtk/TestExpectations:

2:24 PM Changeset in webkit [125709] by zandobersek@gmail.com

5 edits
6 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for <meter> tests after r125659.

Marking fullscreen/full-screen-iframe-legacy.html and
storage/websql/database-lock-after-reload.html as flaky.

platform/gtk/TestExpectations:
platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.

2:22 PM Changeset in webkit [125708] by kling@webkit.org

2 edits in trunk/Source/WebCore

NinePieceImage: Avoid unnecessary duplication of default data in assignment operator.
<http://webkit.org/b/94046>

Reviewed by Geoffrey Garen.

If copying a NinePieceImage with a null m_data, don't create a copy of it's data()
as that will point to the default NinePieceImageData. ~200kB progression on Membuster.

rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::operator=):

2:20 PM Changeset in webkit [125707] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[Qt] unskip passing fast/text tests.
https://bugs.webkit.org/show_bug.cgi?id=94127

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-15
Reviewed by Csaba Osztrogonác.

Three fast/text tests are working for Qt5 (WK1 and WK2).

platform/qt-5.0/Skipped:

2:19 PM Changeset in webkit [125706] by leviw@chromium.org

27 edits
9 adds
16 deletes in trunk/LayoutTests

Unreviewed gardening. Updating test expectations after r125694.

fast/table/rowindex-expected.txt: Added.
fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
fast/text/international/bidi-override-expected.txt: Added.
fast/transforms/bounding-rect-zoom-expected.txt: Replaced.
platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.txt: Added.
platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
platform/chromium-mac-snowleopard/fast/table/rowindex-expected.png:
platform/chromium-mac-snowleopard/fast/table/rowindex-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55527-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-mac/fast/table/rowindex-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-override-expected.txt: Removed.
platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/chromium/TestExpectations:
platform/efl/fast/table/rowindex-expected.txt: Removed.
platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/efl/fast/text/international/bidi-override-expected.txt: Removed.
platform/efl/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
platform/gtk/fast/table/rowindex-expected.txt: Removed.
platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/gtk/fast/text/international/bidi-override-expected.txt: Removed.
platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt: Removed.

2:13 PM Changeset in webkit [125705] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
https://bugs.webkit.org/show_bug.cgi?id=94136

Patch by Yong Li <yoli@rim.com> on 2012-08-15
Reviewed by Rob Buis.
Internally reviewed by Lyon Chen.

PR# 192401.

The prototype of GeoTracker::create() has changed.
Fix the issue that it could recreate tracker unnecessarily when setEnableHighAccuracy() is called but accuracy requirment hasn't changed.
Fix the issue setEnableHighAccuracy() could start tracking when tracker was suspended.

WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::startUpdating):
(GeolocationControllerClientBlackBerry::setEnableHighAccuracy):

2:09 PM Changeset in webkit [125704] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Buildfix after r125541
https://bugs.webkit.org/show_bug.cgi?id=94097

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-15
Reviewed by Filip Pizlo.

r125541 has broken the traditional ARM port build of JSC.

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::xor32):

1:51 PM Changeset in webkit [125703] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Mark Skia and Compositor Contexts
https://bugs.webkit.org/show_bug.cgi?id=94129

Patch by Gregg Tavares <gman@google.com> on 2012-08-15
Reviewed by James Robinson.

Marks the Skia and Compositor contexts to aid in debugging.

No new tests as no new functionality.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

1:50 PM Changeset in webkit [125702] by vollick@chromium.org

4 edits in trunk/Source

[chromium] Must account for empty transformation lists when checking for big rotations.
https://bugs.webkit.org/show_bug.cgi?id=93975

Reviewed by James Robinson.

Source/WebCore:

Unit tested in: GraphicsLayerChromiumTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList

platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::causesRotationOfAtLeast180Degrees):

Source/WebKit/chromium:

Adds a test to check that creating an animation with a big (> 180
degree) rotation, where the transform operations list in the 1st
keyframe is empty fails as expected.

tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):
(WebKit):

1:40 PM Changeset in webkit [125701] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use the unconverted attribute instead of composing when deciding to how to handle key input.
https://bugs.webkit.org/show_bug.cgi?id=94132

Reviewed by Rob Buis.

PR 139838.

Switch direct key input handling to be based on the unconverted
attribute being present. Converted keys, even during composition
are now input directly.

Reviewed Internally by Nima Ghanavatian.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setText):

12:58 PM Changeset in webkit [125700] by Beth Dakin

12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=93693
[WK2] REGRESSION(125091): pixel results don't sow scrollbars
anymore

Reviewed by Sam Weinig.

Source/WebCore:

This is a regression from http://trac.webkit.org/changeset/125091
in which I failed to noticed that
WKBundlePageCreateSnapshotInViewCoordinates() did actually do
something different than
WKBundlePageCreateSnapshotInDocumentCoordinates(). Specifically,
it used ScrollView::paint() to paint instead of
FrameView::paintContents(). So this patch restores that
functionality by adding a value to SnapshotOptions indicating
whether the snapshot should be taken in ViewCoordinates
(otherwise it defaults to DocumentCoordinates).

FrameView:: paintContentsForSnapshot() now takes a new parameter
that indicates whether to take the snapshot in document
coordinates or view coordinates.

WebCore.exp.in:
page/FrameView.cpp:

(WebCore::FrameView::paintContentsForSnapshot):

page/FrameView.h:

Source/WebKit2:

Shared/API/c/WKImage.h:
Shared/API/c/WKSharedAPICast.h:

(WebKit::toSnapshotOptions):

Shared/ImageOptions.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):

Even though we plan to deprecate this API, it should keep doing
the right thing until it's gone.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCreateSnapshotInViewCoordinates):

Tools:

Use new API WKBundlePageCreateSnapshotWithOptions().

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):

12:54 PM Changeset in webkit [125699] by piman@chromium.org

10 edits in branches/chromium/1229/Source

Merge 125577 - [chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProxy::beginFrameCompleteOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=93684

Reviewed by James Robinson.

This keeps track of whether we're between the beginFrame post and the
commit when releaseContentsTextures comes, and if that is the case, we
prune the texture uploads, keep the "textures purged" flag on and kick a
new commit.

Added CCLayerTreeHostTestEvictTextures test.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::beginFramePosted):
(WebCore):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::contentsTexturesPurged):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastBeginFrame):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):

platform/graphics/chromium/cc/CCTextureUpdateController.h:

(CCTextureUpdateController):

platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:

(WebCore::CCTextureUpdateQueue::clearUploads):
(WebCore):

platform/graphics/chromium/cc/CCTextureUpdateQueue.h:

(CCTextureUpdateQueue):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836250

12:39 PM Changeset in webkit [125698] by ap@apple.com

2 edits in trunk/Tools

Add rfong to Bugzilla CC "contributor" list.

Scripts/webkitpy/common/config/committers.py:

12:38 PM Changeset in webkit [125697] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Use literal initialization for CSS's pseudo types
https://bugs.webkit.org/show_bug.cgi?id=94066

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Initialize CSS pseudo type strings with the new initialization from literal.

The first invocation of nameToPseudoTypeMap() becomes 20% faster and we use
less memory to store the strings.

css/CSSSelector.cpp:

(WebCore::nameToPseudoTypeMap):

12:36 PM Changeset in webkit [125696] by jsbell@chromium.org

3 edits in trunk/Source/WebKit/chromium

[chromium] IndexedDB: Delete unused WebKit API cursor accessors
https://bugs.webkit.org/show_bug.cgi?id=94134

Reviewed by Adam Barth.

Last bit of refactor work from http://webkit.org/b/92278 that ships the
cursor key/primaryKey/value to the front end via success messages, eliminating
the need for these accessors and the old success messages.

public/WebIDBCallbacks.h:
public/WebIDBCursor.h:

12:33 PM Changeset in webkit [125695] by beidson@apple.com

10 edits
2 adds in trunk

Removing a plug-in element from a page opened in a background tab in Safari crashes
<rdar://problem/12057991> and https://bugs.webkit.org/show_bug.cgi?id=93913

Reviewed by Beth Dakin.

Source/autotools/symbols.filter: Allow this symbol through for DRT's sake.

Source/WebCore:

Expose Page::setCanStartMedia to regression tests so they can pretend to be in a non-windowed WebView.

Test: platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setCanStartMedia):
(WebCore):

testing/InternalSettings.h:

(Backup):
(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit2:

This only happens in WebKit2 with asynchronous plug-in initialization enabled.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::destroy): Null-check m_connection, as it might not have been created yet.

win/WebKit2.def: Export Page::setCanStartMedia for InternalSettings/DRT use.

LayoutTests:

Using internal setting setCanStartMedia, pretend the page is in an unwindowed WebView then remove
the plug-in element.

platform/mac-wk2/plugins/asynchronous-destroy-before-initialization-expected.txt: Added.
platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html: Added.

12:32 PM Changeset in webkit [125694] by leviw@chromium.org

51 edits
2 adds in trunk

AutoTableLayout truncates preferred widths for cells when it needs to ceil them to contain the contents
https://bugs.webkit.org/show_bug.cgi?id=93911

Reviewed by Eric Seidel.

Source/WebCore:

Avoiding truncation of sub-pixel accumulated values when determining the preferred width of a table cell
in AutoTableLayout. Since we continue to layout tables using integers, we need to ceil the contents to
prevent premature wrapping of the contents.

This only affects ports with sub-pixel layout enabled, and fixes regressions of a handful of tests that
were missed when updating expectations when sub-pixel was enabled.

Test: fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping.html

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

LayoutTests:

This only affects ports with sub-pixel layout enabled, and fixes regressions of a handful of tests that
were missed when updating expectations when sub-pixel was enabled.

fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping-expected.txt: Added.
fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping.html: Added.
platform/chromium-mac/editing/deleting/5144139-2-expected.txt:
platform/chromium-mac/fast/forms/001-expected.png:
platform/chromium-mac/fast/forms/001-expected.txt:
platform/chromium-mac/fast/forms/button-white-space-expected.txt:
platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
platform/chromium-mac/fast/forms/formmove3-expected.txt:
platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
platform/chromium-mac/fast/table/rowindex-expected.png:
platform/chromium-mac/fast/table/rowindex-expected.txt:
platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/chromium-mac/fast/text/international/bidi-override-expected.png:
platform/chromium-mac/fast/text/international/bidi-override-expected.txt:
platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
platform/chromium/TestExpectations:
platform/mac/tables/mozilla/bugs/bug55527-expected.txt:

12:28 PM Changeset in webkit [125693] by ojan@chromium.org

4 edits
2 adds in trunk

z-index should work without position on flexitems
https://bugs.webkit.org/show_bug.cgi?id=91405

Reviewed by Tony Chang.

Source/WebCore:

Require a layer on any RenderBox that has a non-auto z-index.
Statically positioned, non-flex-item's have their z-index coerced to auto,
so it's safe to check z-index unconditionally.

Test: css3/flexbox/z-index.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
-Don't coerce z-index to auto on statically positioned flex-items.
-Use the parentStyle to determine if the parent is a flexbox instead of
looking at the element's parentNode's renderer.

rendering/RenderBox.h:

-Add having a non-auto z-index to the list of things that require a layer.

LayoutTests:

css3/flexbox/z-index-expected.html: Added.
css3/flexbox/z-index.html: Added.

Use a ref-test since we want to be sure that the elements get painted in the right order.

12:18 PM Changeset in webkit [125692] by commit-queue@webkit.org

4 edits in trunk/Source

[Gtk] atk_text_set_caret_offset() fails for table cells
https://bugs.webkit.org/show_bug.cgi?id=83501

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
Reviewed by Chris Fleizach.

Source/WebCore:

Allow using text ranges in accessible table cells.

accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::allowsTextRanges):
Add table cells to the list of accessibility objects supporting text ranges.

Source/WebKit/gtk:

Update unit test to include setting the caret in a table cell via the AtkText interface.

tests/testatk.c:

(testWebkitAtkCaretOffsets): Add setting the caret inside the text of a table cell.

12:08 PM Changeset in webkit [125691] by commit-queue@webkit.org

22 edits
2 moves in trunk

Rename window.internals.fastMallocStatistics to mallocStatistics
https://bugs.webkit.org/show_bug.cgi?id=94033

Patch by Scott Graham <scottmg@chromium.org> on 2012-08-15
Reviewed by Adam Barth.

PerformanceTests:

resources/runner.js:

(PerfTestRunner.storeHeapResults):
(PerfTestRunner.getUsedMallocHeap):
(PerfTestRunner.getAndPrintMemoryStatistics):
(PerfTestRunner.initAndStartLoop):

Source/WebCore:

Mechanical rename. In preparation for plumbing allocation information
from allocators that aren't "fastMalloc".

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gyp/WebCore.gyp:
WebCore.gypi:
WebCore.vcproj/WebCoreTestSupport.vcproj:
WebCore.xcodeproj/project.pbxproj:
loader/DocumentLoader.h:

(WebCore::DocumentLoader::didTellClientAboutLoad):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadResource):

testing/FastMallocStatistics.h: Removed.
testing/FastMallocStatistics.idl: Removed.
testing/Internals.cpp:

(WebCore::Internals::mallocStatistics):

testing/Internals.h:

(WebCore):
(Internals):

testing/Internals.idl:
testing/MallocStatistics.h: Added.
testing/MallocStatistics.idl: Added.

Tools:

GNUmakefile.am:
Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_memory_test):

LayoutTests:

fast/harness/fastmallocstatistics-object.html:

11:54 AM Changeset in webkit [125690] by commit-queue@webkit.org

8 edits in trunk/Source

[BlackBerry] Upstream BlackBerry build fixes
https://bugs.webkit.org/show_bug.cgi?id=94121

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-15
Reviewed by Rob Buis.

This includes several build fixes due to incorrect upstream patches.
These mistakes were never present downstream.

No new tests, because no new functionality is added.

Source/WebCore:

platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):

platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):
(WebCore::GraphicsContext3D::ShaderSourceEntry::ShaderSourceEntry):

platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):

platform/graphics/blackberry/LayerFilterRenderer.h:

(LayerFilterRendererAction):

Source/WebKit/blackberry:

WebCoreSupport/AboutDataEnableFeatures.in:
WebCoreSupport/AboutTemplate.html.cpp:

(writeHeader):

11:44 AM Changeset in webkit [125689] by ojan@chromium.org

2 edits in trunk/LayoutTests

Update expectations to match the bots. This test hasn't timed out in over 500 runs.

platform/chromium/TestExpectations:

11:44 AM Changeset in webkit [125688] by abarth@webkit.org

2 edits in trunk/Source/WebCore

JSDOMWrapper should ASSERT that it has an associated ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=94053

Reviewed by Sam Weinig.

Previously we were unable have this ASSERT because DOMWindow needed a
Frame to find Document. Now that we can find the Document without a
Frame, we can include the ASSERT and sanity will rein across the land.

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::JSDOMWrapper):

11:32 AM Changeset in webkit [125687] by mhahnenberg@apple.com

61 edits
3 adds in trunk

Change behavior of MasqueradesAsUndefined to better accommodate DFG changes
https://bugs.webkit.org/show_bug.cgi?id=93884

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

There are two primary changes that are taking place here. One is to thread the ExecState* through
JSValue::toBoolean and JSCell::toBoolean so that JSCell::toBoolean can check the object's
JSGlobalObject to compare it to the lexical JSGlobalObject of the currently running code. If the two
are distinct, then the object cannot MasqueradeAsUndefined.

The other change is to perform this comparison of JSGlobalObjects everywhere where the MasqueradesAsUndefined
flag in the Structure is checked. For C++ code, this check has been factored into its own function in
Structure::masqueradesAsUndefined. We only perform this check in the DFG if the current JSGlobalObject has
had a MasqueradesAsUndefined object allocated within its context. This conditional compilation is managed
through the use of a WatchpointSet in each JSGlobalObject and alternate create() functions for JS DOM wrappers
that are MasqueradesAsUndefined.

API/JSValueRef.cpp:

(JSValueToBoolean):

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
bytecode/Watchpoint.h:

(WatchpointSet):

debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::callFrame):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

runtime/JSCell.h:

(JSCell):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::masqueradesAsUndefinedWatchpoint):

runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

runtime/JSValue.h:
runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):

runtime/Operations.h:

(JSC):
(JSC::JSValue::equalSlowCaseInline):

runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

runtime/Structure.h:

(Structure):
(JSC::Structure::globalObjectOffset):
(JSC::Structure::masqueradesAsUndefined):
(JSC):

Source/WebCore:

Test: fast/js/document-all-between-frames.html

All of the changes in WebCore are simply passing the additional ExecState argument to JSValue::toBoolean.

bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::exec):
(WebCore):

bindings/js/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

bindings/scripts/CodeGeneratorJS.pm: Also add the custom create function for MasqueradesAsUndefined JS DOM wrappers.

(GenerateEventListenerCall):
(GenerateHeader):
(JSValueToNative):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

bindings/scripts/test/JS/JSTestObj.cpp:

bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray): Passing ExecState to toBoolean call.

Source/WebKit2:

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): Passing ExecState to toBoolean call.

LayoutTests:

Added a test that uses a variety of ways of checking whether something is correctly
masquerading as undefined (or not) in a subframe.

fast/js/document-all-between-frames-expected.txt: Added.
fast/js/document-all-between-frames.html: Added.
fast/js/resources/document-all-between-frames-subframe.html: Added.
platform/chromium/TestExpectations: Chromium treats document.all differently, so skip our new test.

11:31 AM Changeset in webkit [125686] by abarth@webkit.org

2 edits in trunk/LayoutTests

Update TestExpectations entry to refer to an actual bug.

platform/chromium/TestExpectations:

11:13 AM Changeset in webkit [125685] by commit-queue@webkit.org

4 edits in trunk/Source

[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs in list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=83435

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
Reviewed by Chris Fleizach.

Source/WebCore:

Fix a logic error when checking if an object is a list marker.

accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(textForRenderer):

Source/WebKit/gtk:

Updated unit test to include a paragraph in a list item when testing atk_text_get_text_at_offset().

tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithSpecialCharacters):

11:01 AM Changeset in webkit [125684] by commit-queue@webkit.org

3 edits
8 adds in trunk

There is additional space not belonged to a table between the table cells
https://bugs.webkit.org/show_bug.cgi?id=74864

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-08-15
Reviewed by Julien Chaffraix.

Source/WebCore:

Hittest for a point on the edge, i.e. between two table columns, currently
does not return any matching underlying element.

A hittest on such a point (on the edge of two table columns) should return
the column that lies either on the logical right/bottom of the said point.

Tests: fast/table/hittest-tablecell-bottom-edge.html

fast/table/hittest-tablecell-right-edge.html
fast/table/hittest-tablecell-with-borders-bottom-edge.html
fast/table/hittest-tablecell-with-borders-right-edge.html

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::spannedRows):
Removed the FIXME regarding the correctness of the usage of the upper_bound algorithm
since that is now verified by the testcases in this patch. Also, the comment
regarding the inconsistency between the algorithms used in spannedRows and spannedColumns
is no longer valid.

(WebCore::RenderTableSection::spannedColumns):
Changed lower_bound() algorithm to upper_bound() for obtaining the next column.
This is now similar to what is used for obtaining the next row in spannedRows().

LayoutTests:

fast/table/hittest-tablecell-bottom-edge-expected.txt: Added.
fast/table/hittest-tablecell-bottom-edge.html: Added.
fast/table/hittest-tablecell-right-edge-expected.txt: Added.
fast/table/hittest-tablecell-right-edge.html: Added.

Testcases added for verifying that the proper node is returned upon hit test
carried out at a point lying on the edge of two table cells.

fast/table/hittest-tablecell-with-borders-bottom-edge-expected.txt: Added.
fast/table/hittest-tablecell-with-borders-bottom-edge.html: Added.
fast/table/hittest-tablecell-with-borders-right-edge-expected.txt: Added.
fast/table/hittest-tablecell-with-borders-right-edge.html: Added.

These testcases verify the aforementioned behavior when the table cells
also have border specified for them.

10:59 AM Changeset in webkit [125683] by peter@chromium.org

2 edits in trunk/Tools

Fix a warning in TestWebKitAPI's MediaTime test-suite
https://bugs.webkit.org/show_bug.cgi?id=94096

Reviewed by Adam Barth.

This warning is visible when building the file with certain GCC versions,
including the one used by Chromium for Android. The warning is visible in
the cr-android build bot output:

MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90

TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

9:58 AM Changeset in webkit [125682] by annacc@chromium.org

16 edits in trunk

Add the timestampOffset attribute to SourceBuffer.
https://bugs.webkit.org/show_bug.cgi?id=93303

Reviewed by Dimitri Glazkov.

On the 30 July 2012 version of the Media Source Extensions spec, a timestampOffset
attribute was added to the SourceBuffer object:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#dom-timestampoffset

Source/WebCore:

Tests: additions to http/tests/media/media-source/video-media-source-objects.html

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setTimestampOffset): Set the timestampOffset on MediaPlayer.
(WebCore):

Modules/mediasource/MediaSource.h:

(MediaSource):

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Let the timestampOffset be 0 initially
(WebCore::SourceBuffer::timestampOffset): Return the last value set.
(WebCore):
(WebCore::SourceBuffer::setTimestampOffset): Forward the call onto MediaSouce.

Modules/mediasource/SourceBuffer.h:

(SourceBuffer):

Modules/mediasource/SourceBuffer.idl: Create the new timestampOffset attr.
platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceSetTimestampOffset): A null media player

should just return false (nothing to set).

(WebCore):
(WebCore::MediaPlayer::sourceSetTimestampOffset): Forward the call.

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceSetTimestampOffset):

Source/WebKit/chromium:

public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceSetTimestampOffset): Add the new method.

src/WebMediaPlayerClientImpl.cpp:

(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceSetTimestampOffset): Forward the call.

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

http/tests/media/media-source/video-media-source-objects-expected.txt:
http/tests/media/media-source/video-media-source-objects.html:

9:50 AM Changeset in webkit [125681] by vsevik@chromium.org

17 edits
3 adds in trunk

Source/WebCore: Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-15
Reviewed by Vsevolod Vlasov.

CachedResource object for XHR response is now taken from ResourceLoader (if it's possible).

Test: http/tests/inspector/network/network-xhr-async-double.html

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):

inspector/InspectorResourceAgent.h:

(WebCore):
(InspectorResourceAgent):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didReceiveResponse):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):

loader/ResourceLoadNotifier.h:

(ResourceLoadNotifier):

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::isSubresourceLoader):
(WebCore):

loader/ResourceLoader.h:

(ResourceLoader):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::cachedResource):
(WebCore):
(WebCore::SubresourceLoader::isSubresourceLoader):

loader/SubresourceLoader.h:

(SubresourceLoader):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):

LayoutTests: Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-15
Reviewed by Vsevolod Vlasov.

New test for two async XHRs sent synchronously.

http/tests/inspector/network-test.js:

(doXHR):
(doXHRWithPayload.xhr.onreadystatechange):
(doXHRWithPayload):

http/tests/inspector/network/network-xhr-async-double-expected.txt: Added.
http/tests/inspector/network/network-xhr-async-double.html: Added.
http/tests/inspector/network/resources/echo-payload.php: Added.
platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:

9:20 AM Changeset in webkit [125680] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use nested layout when rotating
https://bugs.webkit.org/show_bug.cgi?id=94117

Partially patched by Arvid Nilsson.

Patch by Leo Yang <leoyang@rim.com> on 2012-08-15
Reviewed by George Staikos.
Reviewed internally by Arvid Nilsson.

When rotating the content width used for fixedLayoutSize is not
correct because we are changing the rotation and the content with
should be determined after layout. So we set the with to 0 if we
are rotating and beginning the nested layout. And in setViewportSize
we need a nested layout loop to trigger zoom-to-fit.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

9:06 AM Changeset in webkit [125679] by tonikitoo@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Stop copying ScrollViewBase vector all over
https://bugs.webkit.org/show_bug.cgi?id=94021

Reviewed by Rob Buis.

It outlives long enough in WebKit that we can
just pass a const+ref of it.

Internally reviewed by Gen Mak.

Api/WebPageClient.h:

9:05 AM Changeset in webkit [125678] by tonikitoo@webkit.org

7 edits in trunk/Source/WebKit/blackberry

Robust-fy the LayerWebKitThread ownership with InRegionScroller
https://bugs.webkit.org/show_bug.cgi?id=93983
PR #191737

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

Patch changes the way we currently keep track of the active scrollable area
objects: before, we acquired the scrollable areas and just passed them in a vector up
to the client, copying it over and over again. Also, it was a client responsability to
delete stuff (BAD!).
Now, we keep track of vector within InRegionScroller, as a class member, which allows us to
avoid copies (in follow up patch), and control until when these objects outlive.

Patch also changes InRegionScrollableArea to "retptr" the composited layer
associated to it (if any). This ensure we have a non-null scrollable element always.

As mentioned, InRegionScroller is now responsible for deleting and vector of scrollable areas.

Internally reviewed by Arvid Nilsson.

Api/InRegionScroller.cpp:

(WebKit):
(BlackBerry::WebKit::InRegionScrollerPrivate::reset): Method is now responsible for
deleting the tracked scrollable areas.
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
Renamed from 'inRegionScrollableAreasForPoint'. It was changed in order to store the
scrollable area objects instead of just pass a copy of them up to the client.
(BlackBerry::WebKit::InRegionScrollerPrivate::activeInRegionScrollableAreas): Getter.
(BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): It was
promoted to a class method instead of a local helper.

Api/InRegionScroller_p.h:

(WebKit):
(InRegionScrollerPrivate):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint): Adjustments needed due to the
above changed.

WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea): Clear up the cached layer.
(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

WebKitSupport/InRegionScrollableArea.h:

(InRegionScrollableArea):

8:56 AM Changeset in webkit [125677] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Use default parameter on reportResult in InspectorFileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=93930

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-15
Reviewed by Vsevolod Vlasov.

No functional change.

inspector/InspectorFileSystemAgent.cpp:

(WebCore):

8:50 AM Changeset in webkit [125676] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check for valid field focus before processing a spellcheck request
https://bugs.webkit.org/show_bug.cgi?id=94115

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-15
Reviewed by Rob Buis.

PR192891
Checking for valid field focus before processing the spellcheck
request.

Internally reviewed by Mike Fenton.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

8:46 AM Changeset in webkit [125675] by commit-queue@webkit.org

2 edits in trunk/Tools

Fix the 'git log' call in VCSUtils.pm for Windows
https://bugs.webkit.org/show_bug.cgi?id=94113

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Failed because of invalid enquoting characters.

Scripts/VCSUtils.pm:

7:17 AM Changeset in webkit [125674] by kov@webkit.org

4 edits in trunk/Tools

[jhbuild] move md5sum checking to update-webkit-libs-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=93208

Reviewed by Martin Robinson.

This change makes the md5sum check and saving be done by the script
that performs the dependencies update. build-webkit no longer prefixes
calls to commands with jhbuild-wrapper if jhbuild has not been
bootstrapped by the developer and --update-gtk is not given.

Scripts/update-webkit-libs-jhbuild:

(getMD5HashForFile): moved from webkitdirs.
(jhbuildConfigurationChanged): ditto.
(saveJhbuildMd5): ditto.
(cleanJhbuild): ditto, and changed to run jhbuild clean before removing
jhbuild.

Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
(buildAutotoolsProject): ditto.
(jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
(generateBuildSystemFromCMakeProject): call update-webkitefl-libs
unconditionally for EFL.

jhbuild/jhbuild-wrapper:

(update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
update script itself
(ensure_jhbuild): remove update call.

6:58 AM Changeset in webkit [125673] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: TabbedEditorContainer Doens't show '*' near modified file name sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94095

Reviewed by Pavel Feldman.

TabbedEditorContainer now correctly updates event listeners on UISourceCodeReplaced event.

inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._addUISourceCodeListeners):
(WebInspector.TabbedEditorContainer.prototype._removeUISourceCodeListeners):

6:53 AM Changeset in webkit [125672] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94098

Reviewed by Pavel Feldman.

SourceFrame listeners and _currentFile field are now cleared only when currently open tab is closed.

inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._tabClosed):

6:50 AM Changeset in webkit [125671] by commit-queue@webkit.org

12 edits in trunk/Source/WebKit2

[EFL][WK2] Refactoring: start using WKEinaSharedString in ewk_ classes
https://bugs.webkit.org/show_bug.cgi?id=93964

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Started using WKEinaSharedString where it is advisable.

UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::operator==):

UIProcess/API/cpp/efl/WKEinaSharedString.h:
UIProcess/API/efl/ewk_download_job.cpp:

(_Ewk_Download_Job):
(_Ewk_Download_Job::_Ewk_Download_Job):
(_Ewk_Download_Job::~_Ewk_Download_Job):
(ewk_download_job_destination_set):
(ewk_download_job_suggested_filename_set):

UIProcess/API/efl/ewk_intent.cpp:

(_Ewk_Intent):
(_Ewk_Intent::_Ewk_Intent):
(_Ewk_Intent::~_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):

UIProcess/API/efl/ewk_intent_service.cpp:

(_Ewk_Intent_Service):
(_Ewk_Intent_Service::_Ewk_Intent_Service):
(_Ewk_Intent_Service::~_Ewk_Intent_Service):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):

UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):

UIProcess/API/efl/ewk_url_request.cpp:

(_Ewk_Url_Request):
(_Ewk_Url_Request::_Ewk_Url_Request):
(_Ewk_Url_Request::~_Ewk_Url_Request):
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):

UIProcess/API/efl/ewk_url_response.cpp:

(_Ewk_Url_Response):
(_Ewk_Url_Response::_Ewk_Url_Response):
(_Ewk_Url_Response::~_Ewk_Url_Response):
(ewk_url_response_url_get):
(ewk_url_response_mime_type_get):

UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_uri_update):
(ewk_view_title_get):
(ewk_view_theme_set):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):

UIProcess/API/efl/ewk_web_error.cpp:

(_Ewk_Web_Error):
(_Ewk_Web_Error::_Ewk_Web_Error):
(_Ewk_Web_Error::~_Ewk_Web_Error):
(ewk_web_error_url_get):
(ewk_web_error_description_get):

UIProcess/API/efl/ewk_web_resource.cpp:

(_Ewk_Web_Resource):
(_Ewk_Web_Resource::_Ewk_Web_Resource):
(_Ewk_Web_Resource::~_Ewk_Web_Resource):

6:03 AM Changeset in webkit [125670] by commit-queue@webkit.org

35 edits
4 copies in trunk

[WK2] Add support for Web Intents MessagePorts
https://bugs.webkit.org/show_bug.cgi?id=89072

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add support for WebIntents MessagePorts in WebKit2.
MessagePorts can be passed with a Web Intent in
order to open a direct communication channel
between the Web application and the intent service.

This functionality is already supported by WebKit 1.

This patch introduces a new InjectedBundleIntent
class which wraps a WebCore::Intent. This way
information regarding the MessagePorts in a Web
Intent is kept when using an injected bundle.

For the UIProcess, WebIntentData now carries
identifiers for the MessagePorts which can go over
IPC. Those identifiers map to actual MessagePorts
stored in the Web process. This way, when the UI
delivers an intent to a frame, we can get back the
corresponding MessagePorts from the Web process
before delivering the intent to the DOMWindow.

This functionality is already tested by:

webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html

CMakeLists.txt:
GNUmakefile.list.am:
Shared/API/c/WKBase.h:
Shared/APIObject.h:
Shared/IntentData.cpp: Add MessagePort identifiers.

(WebKit::IntentData::IntentData):
(WebKit::IntentData::encode):
(WebKit::IntentData::decode):

Shared/IntentData.h:

(IntentData):

Target.pri:
UIProcess/API/C/WKIntentData.cpp: Rename WKIntentDataCopyExtra() to

WKIntentDataCopyExtraValue() for clarity.
(WKIntentDataCopyExtraValue):

UIProcess/API/C/WKIntentData.h: Remove WKIntentDataCreate() function now

that WTR uses WKBundleIntentCreate() instead.

UIProcess/API/efl/ewk_intent.cpp:

(ewk_intent_extra_get): Use WKIntentDataCopyExtraValue() instead of
WKIntentDataCopyExtra() since it was renamed.

UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::~WebIntentData): Remove MessagePorts from WebProcess upon
WebIntentData destruction.
(WebKit):
(WebKit::WebIntentData::extras):

UIProcess/WebIntentData.h:

(WebKit):
(WebKit::WebIntentData::create):
(WebIntentData):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveIntentForFrame):

UIProcess/WebProcessProxy.cpp:

(WebKit):
(WebKit::WebProcessProxy::removeMessagePortChannel):

UIProcess/WebProcessProxy.h:

(WebProcessProxy):

WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit):

WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKIntentData.cpp.

(WKBundleIntentGetTypeID):
(WKBundleIntentCreate):
(WKBundleIntentCopyAction):
(WKBundleIntentCopyType):
(WKBundleIntentCopyService):
(WKBundleIntentCopySuggestions):
(WKBundleIntentCopyExtraValue):
(WKBundleIntentCopyExtras):
(WKBundleIntentMessagePortCount):

WebProcess/InjectedBundle/API/c/WKBundleIntent.h: Copied from Source/WebKit2/UIProcess/API/C/WKIntentData.h.
WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.cpp:

(WKBundleIntentRequestCopyIntent):

WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageDeliverIntentToFrame):

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundleIntent.cpp: Copied from Source/WebKit2/UIProcess/WebIntentData.cpp.

(WebKit):
(WebKit::InjectedBundleIntent::create):
(WebKit::InjectedBundleIntent::InjectedBundleIntent):
(WebKit::InjectedBundleIntent::action):
(WebKit::InjectedBundleIntent::payloadType):
(WebKit::InjectedBundleIntent::service):
(WebKit::InjectedBundleIntent::data):
(WebKit::InjectedBundleIntent::extra):
(WebKit::InjectedBundleIntent::extras):
(WebKit::InjectedBundleIntent::suggestions):

WebProcess/InjectedBundle/InjectedBundleIntent.h: Copied from Source/WebKit2/UIProcess/WebIntentData.h.

(WebKit):
(InjectedBundleIntent):
(WebKit::InjectedBundleIntent::coreIntent):
(WebKit::InjectedBundleIntent::type):

WebProcess/InjectedBundle/InjectedBundleIntentRequest.cpp:

(WebKit::InjectedBundleIntentRequest::intent):

WebProcess/InjectedBundle/InjectedBundleIntentRequest.h:

(WebKit):
(InjectedBundleIntentRequest):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::deliverIntent):
(WebKit):

WebProcess/WebPage/WebFrame.h:

(WebCore):
(WebFrame):

WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::deliverCoreIntentToFrame):

WebProcess/WebPage/WebPage.h:

(WebCore):
(WebPage):

WebProcess/WebProcess.cpp: Store MessagePorts in WebProcess and keep mapping with

their identifiers.
(WebKit):
(WebKit::WebProcess::addMessagePortChannel):
(WebKit::WebProcess::messagePortChannel):
(WebKit::WebProcess::removeMessagePortChannel):

WebProcess/WebProcess.h:

(WebCore):
(WebProcess):

WebProcess/WebProcess.messages.in:

Tools:

Use WKBundleIntent instead of WebIntentData in
WebKitTestRunner. WTR now prints the number of
MessagePorts in received Web intents as
expected by the following layout tests:
webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveIntentForFrame):

WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::deliverWebIntent):

LayoutTests:

Unskip webintents/web-intents-invoke-port.html and
webintents/web-intents-obj-constructor.html for
WebKit2 EFL now that information about message ports
is correctly displayed by WebKitTestRunner.

platform/efl-wk2/TestExpectations:

5:11 AM Changeset in webkit [125669] by commit-queue@webkit.org

2 edits
1 delete in trunk/LayoutTests

[EFL] Remove image expectation added for a ref test
https://bugs.webkit.org/show_bug.cgi?id=94090

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-15

platform/efl/TestExpectations:
platform/efl/fast/css-generated-content/quotes-lang-expected.png: Removed.

5:06 AM Changeset in webkit [125668] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
https://bugs.webkit.org/show_bug.cgi?id=94074

Reviewed by Pavel Feldman.

Added dirty flag check when saving uiSourceCode to save working copy in this case.

inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

4:55 AM Changeset in webkit [125667] by kkristof@inf.u-szeged.hu

1 edit
8 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platfrom specific expected results after r125593.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-08-15

platform/qt-5.0-wk2/http/tests/misc/window-dot-stop-expected.txt: Added.
platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
platform/qt-5.0-wk2/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.

4:17 AM Changeset in webkit [125666] by shinyak@chromium.org

4 edits
1 move
1 delete in trunk/LayoutTests

[Chromium Mac] Unreviewed, rebaseline after r125659.

fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.

4:02 AM Changeset in webkit [125665] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Roll WebKit Chromium DEPS to r151672
https://bugs.webkit.org/show_bug.cgi?id=94091

Unreviewed DEPS roll.

This also adds the new dependency on third_party/skia/gyp/, as was
introduced in Chromium's revision 151463.

DEPS:

3:45 AM Changeset in webkit [125664] by Csaba Osztrogonác

11 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r125659.

platform/qt/Skipped: Skip new tests because of disabled SHADOW_DOM
platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:

3:27 AM Changeset in webkit [125663] by commit-queue@webkit.org

12 edits
4 deletes in trunk

Relative units are not set when the canvas has not parent
https://bugs.webkit.org/show_bug.cgi?id=93840

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Set the default font when no parent style is set. It will make
possible to apply relative units when a parent is not set.

No new tests, unskipped the existing ones.

css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):
Make it possible to apply relative units if a parent style exist but
not a parent node. It works like this for em and ex, but not for
percent units.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore):
(WebCore::CanvasRenderingContext2D::setFont):

LayoutTests:

Unskipped tests that will now pass, removed wrong expectations
and updated test case which was fixed by the W3C.

canvas/philip/tests/2d.text.font.parse.size.percentage.default.html:

This test case was fixed on W3C upstream:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=18522

fast/canvas/canvas-font-ex-units-crash-expected.txt:
fast/canvas/script-tests/canvas-font-ex-units-crash.js:
platform/chromium/TestExpectations:
platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Removed.
platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Removed.
platform/efl/Skipped:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Removed.
platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Removed.
platform/qt/Skipped:

3:15 AM Changeset in webkit [125662] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewd gardening. Readd removed expectations in r125658 with some modification.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-15

platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.

3:10 AM Changeset in webkit [125661] by pfeldman@chromium.org

4 edits
2 adds
1 delete in trunk

Web Inspector: split standalone test runner, test scanner and test stub.
https://bugs.webkit.org/show_bug.cgi?id=94001

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change starts sending loacCompleted message to the embedder.

inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.loadCompleted):

inspector/front-end/test-runner.html: Added.

LayoutTests:

This change allows opening a) test runner, b) layout tests and c) inspector front-end off different
hosts. It is one more step towards extension-driven runner.

http/tests/inspector/inspector-test.js:
http/tests/inspector/resources/test-runner.html: Removed.
http/tests/inspector/resources/test-scanner.html: Added.

2:51 AM Changeset in webkit [125660] by shinyak@chromium.org

3 edits in trunk/Source/WebCore

[Refactoring] The debug version and release version of toHTMLSelectElement can be merged without any penalty
https://bugs.webkit.org/show_bug.cgi?id=94084

Reviewed by Kent Tamura.

We have two versions of toHTMLSelectElement. One has ASSERT() and the other one does not have ASSERT().
We can merge them without any penalty.

No new tests, no change in behavior.

html/HTMLSelectElement.cpp:
html/HTMLSelectElement.h:

(WebCore::isHTMLSelectElement):
(WebCore::toHTMLSelectElement):
(WebCore):

2:37 AM Changeset in webkit [125659] by shinyak@chromium.org

24 edits
12 adds in trunk

AuthorShadowDOM for meter element
https://bugs.webkit.org/show_bug.cgi?id=91970

Reviewed by Hajime Morita.

Source/WebCore:

We add support for AuthorShadowDOM for a meter element.

According to the Shadow DOM spec, a meter element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'meter' bar. In this patch, we change the inner structure
of a meter element so that we can distribute an element having RenderMeter to AuthorShadowDOM.

Before this patch, a meter element has the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterBarElement
|
+-- MeterValueElement

After this patch, a meter element will have the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterInnerElement

|
+-- MeterBarElement
|
+-- MeterValueElement

However, if RenderTheme supports rendering meter, MeterInnerElement will not create a renderer
unless an AuthorShadowDOM is attached to it so that we can keep the current rendering style.

Tests: fast/dom/shadow/shadowdom-for-meter-dynamic.html

fast/dom/shadow/shadowdom-for-meter-multiple.html
fast/dom/shadow/shadowdom-for-meter-with-style.html
fast/dom/shadow/shadowdom-for-meter-without-appearance.html
fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html
fast/dom/shadow/shadowdom-for-meter.html

css/html.css:

(meter): Changed the display type. inline-box is not supported WebKit. inline-block is true.
(meter::-webkit-meter-inner-element):

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore):
(WebCore::HTMLMeterElement::attach): Added didElementStateChange.
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::willAddAuthorShadowRoot):
(WebCore::HTMLMeterElement::renderMeter):
(WebCore::HTMLMeterElement::createShadowSubtree):

html/HTMLMeterElement.h:

(WebCore):
(WebCore::HTMLMeterElement::hasAuthorShadowRoot):
(HTMLMeterElement):
(WebCore::isHTMLMeterElement):
(WebCore::toHTMLMeterElement):

html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):
(WebCore::MeterInnerElement::MeterInnerElement): We introduce a new element having RenderMeter
so that we can distribute an element having RenderMeter to AuthorShadowDOM.
(WebCore::MeterInnerElement::rendererIsNeeded): Different from a progress element, meter element will not be
rendered using a theme. So we don't need to check the style appearance.
(WebCore::MeterInnerElement::createRenderer):
(WebCore::MeterInnerElement::shadowPseudoId):

html/shadow/MeterShadowElement.h:

(WebCore):
(MeterInnerElement):
(WebCore::MeterInnerElement::create):

rendering/RenderMeter.cpp:

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::meterElement):
(WebCore):
(WebCore::RenderMeter::valueRatio):

rendering/RenderMeter.h:

(RenderMeter):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::levelIndicatorFor):

LayoutTests:

Contains the following tests:

(1) meter element with AuthorShadowDOM
(2) meter element with multiple AuthorShadowDOM with a shadow element
(3) meter element with multiple AuthorShadowDOM without a shadow element
(4) meter element with AuthorShadowDOM with dynamic value update
(5) meter element with AuthorShadowDOM with style
(6) meter element with AuthorShadowDOM with -webkit-appearance: none

fast/dom/HTMLMeterElement/meter-clone-expected.txt:
fast/dom/HTMLMeterElement/meter-clone.html:
fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
fast/dom/shadow/resources/replaced-element-styles.css:

(.meter-like):
(.meter-inner-element-like):

fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Added.
fast/dom/shadow/shadowdom-for-meter-dynamic.html: Added.
fast/dom/shadow/shadowdom-for-meter-expected.html: Added.
fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Added.
fast/dom/shadow/shadowdom-for-meter-multiple.html: Added.
fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Added.
fast/dom/shadow/shadowdom-for-meter-with-style.html: Added.
fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Added.
fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Added.
fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Added.
fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Added.
fast/dom/shadow/shadowdom-for-meter.html: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
platform/mac/TestExpectations:

2:00 AM Changeset in webkit [125658] by kkristof@inf.u-szeged.hu

2 edits
2 deletes in trunk/LayoutTests

[Qt] Unreviwed gardening. Skip failing tests and remove obsolete test expectations.
https://bugs.webkit.org/show_bug.cgi?id=94076

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-15

platform/qt/Skipped: skip fast/events/autoscroll-in-textarea.html.
platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed after r125615.
platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed after r125615.

1:48 AM QtWebKitBuildBots edited by Csaba Osztrogonác

update Qt Mac bot (diff)

1:41 AM Changeset in webkit [125657] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding image failure expectation for fast/overflow/line-clamp-and-columns.html,
the reftest is failing since it was introduced in r125635.

Skipping media/video-controls-fullscreen-volume.html for the moment after
it's been failing since introduced in r125590, the failure is probably expected
and will be marked as WONTFIX when confirmed.

Marking fast/js/random-array-gc-stress.html as a flaky crasher. The crashing
occurs due to parallel GC being enabled.

platform/gtk/TestExpectations:

1:26 AM Changeset in webkit [125656] by abarth@webkit.org

4 edits
2 adds in trunk

[Chromium] fast/dom/Window/dom-access-from-closure-window.html is flaky on Linux
https://bugs.webkit.org/show_bug.cgi?id=94060

Reviewed by Kentaro Hara.

Source/WebCore:

Previously, the V8 garbage collector might have collected the Document
wrapper before the DOMWindow wrapper because we overwrite the
"document" property of the DOMWindow during navigation.

This patch adds a hidden document property on the global object to
ensure that the Document wrapper lives at least as long as the
DOMWindow wrapper, ensuring that DOMWindows that we obtain from V8
always have non-null Document objects.

The JavaScriptCore bindings already have this behavior.

Test: fast/dom/Window/dom-access-from-closure-window-with-gc.html

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):

bindings/v8/V8HiddenPropertyName.h:

(WebCore):

LayoutTests:

Ensure that collecting garbage doesn't change the behavior of this test
(compared with dom-access-from-closure-window.html).

fast/dom/Window/dom-access-from-closure-window-with-gc-expected.txt: Added.
fast/dom/Window/dom-access-from-closure-window-with-gc.html: Added.

1:17 AM Changeset in webkit [125655] by yutak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Add one more flaky test to test expectations.

platform/chromium/TestExpectations:

1:10 AM Changeset in webkit [125654] by caseq@chromium.org

6 edits
1 copy in trunk

Web Inspector: Calling getEventListeners() on element with malformed javascript event listeners crashes
https://bugs.webkit.org/show_bug.cgi?id=93937

Reviewed by Pavel Feldman.

Source/WebCore:

check listener function to be non-null (happens upon an exception while compiling attribute listeners)

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::getJSListenerFunctions):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::getJSListenerFunctions):

LayoutTests:

added test for crash on invalid syntax in an attribute JS listener;
added custom expectation for chrome due to JS error logged to console by JSC while compiling attribute listener;

inspector/console/command-line-api-getEventListeners-expected.txt:
inspector/console/command-line-api-getEventListeners.html:
platform/chromium/inspector/console/command-line-api-getEventListeners-expected.txt: Copied from LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt.

12:14 AM Changeset in webkit [125653] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] Update expectations for canvas/philip tests that require space collapsing
https://bugs.webkit.org/show_bug.cgi?id=94072

Unreviewed EFL gardening.

Move canvas/philip tests that require space collapsing
from Skipped file to TestExpectations and indicate
that the tests are outdated with corresponding bug
number.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-15

platform/efl/Skipped:
platform/efl/TestExpectations:

12:06 AM Changeset in webkit [125652] by yutak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update. Tests named dfg-*array.html are
known to be slow on debug bots.

platform/chromium/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed