Timeline
Aug 18, 2012:
- 5:57 PM Changeset in webkit [125971] by
-
- 3 edits in trunk/Source/WebCore
Refactor SVGMaskElement to inherit from StyledElement
https://bugs.webkit.org/show_bug.cgi?id=94418
Reviewed by Dirk Schulze.
Previously, SVGMaskElement inherited from SVGStyledLocatableElement which includes
several unnecessary functions (e.g., getBBox()). This patch refactors SVGMaskElement
to inherit from SVGStyledElement which matches the spec:
http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement
No new tests as this is just a refactoring.
- svg/SVGMaskElement.cpp:
(WebCore):
(WebCore::SVGMaskElement::SVGMaskElement):
- svg/SVGMaskElement.h:
- 3:56 PM Changeset in webkit [125970] by
-
- 2 edits in branches/chromium/1229/Source
Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232
Reviewed by James Robinson.
Source/WebCore:
CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.
Chromium bug: crbug.com/125482
Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
Source/WebKit/chromium:
Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.
- tests/CCLayerTreeHostImplTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829399
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857077
- 2:47 PM Changeset in webkit [125969] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] ewk_back_forward_list_item properties should be in sync with WebProcessProxy::m_backForwardListItemMap
https://bugs.webkit.org/show_bug.cgi?id=94248
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-18
Reviewed by Kenneth Rohde Christiansen.
Currently ewk_back_forward_list_item properties are initialized from
WKBackForwardListItemRef once in the constructor and then just stored.
This is erroneous approach as back forward items can be initialized within
several iterations, meaning several ipc calls to UI process and several updates
of WebProcessProxy::m_backForwardListItemMap where the items are stored.
Hence the values of ewk_back_forward_list_item properties should be updated
with the corresponding WKBackForwardListItem function invokes every time
they are called.
- UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(_Ewk_Back_Forward_List_Item): Data members have to be mutable as assigned being const pointers.
(_Ewk_Back_Forward_List_Item::_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_uri_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_uri_get):
- 10:43 AM Changeset in webkit [125968] by
-
- 3 edits in trunk/Source/WebCore
CSSValueList: Reserve the exact amount of space needed when constructing from CSS parser.
(No bug URL as Bugzilla is down today.)
Reviewed by Antti Koivisto.
Use Vector::reserveInitialCapacity() when constructing a CSSValueList from a CSSParserValueList
since we have the final length available. Also inlined the trivial append() and prepend().
- css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
- css/CSSValueList.h:
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):
- 7:21 AM Changeset in webkit [125967] by
-
- 3 edits in trunk/LayoutTests
Follow up to r125966, fixing flaky tests.
- inspector/elements/event-listeners-about-blank.html:
- 2:32 AM Changeset in webkit [125966] by
-
- 22 edits in trunk
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- removed usages of WebInspector.panels.profiles.
- made panel lazily loaded
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/front-end/CPUProfileView.js: (WebInspector.CPUProfileHeader.prototype.createView):
- inspector/front-end/CSSSelectorProfileView.js: (WebInspector.CSSSelectorProfileType.prototype.buttonClicked): (WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile): (WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile): (WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/HeapSnapshotDataGrids.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._profiles): (WebInspector.HeapSnapshotView.prototype.populateContextMenu): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapProfileHeader.prototype.createView):
- inspector/front-end/InspectorFrontendAPI.js: (InspectorFrontendAPI.isProfilingJavaScript): (InspectorFrontendAPI.startProfilingJavaScript): (InspectorFrontendAPI.stopProfilingJavaScript):
- inspector/front-end/NativeMemorySnapshotView.js: (WebInspector.NativeMemoryProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfileHeader.prototype.view): (WebInspector.ProfileHeader.prototype.createView): (WebInspector.ProfilesPanel.prototype.toggleRecordButton): (WebInspector.ProfilesPanel.prototype.showProfileForURL): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu): (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent): (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
- inspector/front-end/Settings.js:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector._toggleSearchingForNode): (WebInspector._profilesLinkifier): (WebInspector._requestZoom.set InspectorFrontendHost): (WebInspector._requestZoom): (WebInspector.documentClick.followLink): (WebInspector.documentClick):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- WebKit.gyp:
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-summary-show-ranges.html:
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html:
- 12:20 AM Changeset in webkit [125965] by
-
- 29 edits in trunk
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- Introduces importScript that evals in debug mode and inlines for release
- Loads Element, Resources, Timeline, Audits panels lazily.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/compile-front-end.py:
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/CodeMirrorTextEditor.js: (WebInspector.CodeMirrorTextEditor): (WebInspector.CodeMirrorTextEditor.prototype._toRange):
- inspector/front-end/Color.js:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.PanelDescriptor): (WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/SettingsScreen.js: (WebInspector.GenericSettingsTab):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
- inspector/front-end/Spectrum.js: (WebInspector.Spectrum.prototype.get outputColorFormat):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector.doLoadedDone):
- inspector/front-end/utilities.js:
- inspector/inline-javascript-imports.py: (main):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- WebKit.gyp:
- scripts/concatenate_js_files.py: (OrderedJSFilesExtractor.handle_starttag):
- scripts/inline_js_imports.py: (main):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
Showing panels prior to running tests in order to load the code for them.
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- inspector/database-table-name-excaping.html:
- inspector/styles/styles-invalid-color-values.html:
- inspector/timeline-dfs.html:
Aug 17, 2012:
- 11:39 PM EFLWebKit edited by
- (diff)
- 11:01 PM Changeset in webkit [125964] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CSE should be more honest about when it changed the IR
https://bugs.webkit.org/show_bug.cgi?id=94408
Reviewed by Geoffrey Garen.
The CSE phase now always returns true if it changed the IR.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
- 8:46 PM Changeset in webkit [125963] by
-
- 2 edits in trunk/Tools
Add self to webkit contributors list
https://bugs.webkit.org/show_bug.cgi?id=94409
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-17
Reviewed by Dirk Pranke.
Add name, email and irc handle to webkit contributors list.
- Scripts/webkitpy/common/config/committers.py:
- 7:51 PM Changeset in webkit [125962] by
-
- 3 edits2 adds in trunk
Calendar picker shows wrong date when input element has year earlier than 100
https://bugs.webkit.org/show_bug.cgi?id=94100
Reviewed by Kent Tamura.
Source/WebCore:
Date.UTC can't set an year earlier than 100. So when the input has a value earlier than 100, calendar picker shows the wrong date.
Test: fast/forms/date/calendar-picker-appearance-pre-100.html
- Resources/pagepopups/calendarPicker.js:
(createUTCDate): Uses setUTCFullYear when the year is pre 100.
(parseDateString):
(DaysTable.prototype._renderMonth):
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
LayoutTests:
- fast/forms/date/calendar-picker-appearance-pre-100-expected.txt: Added.
- fast/forms/date/calendar-picker-appearance-pre-100.html: Added.
- 7:27 PM EFLWebKit edited by
- (diff)
- 7:06 PM Changeset in webkit [125961] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix random noise around text in FPS HUD.
https://bugs.webkit.org/show_bug.cgi?id=94400
Reviewed by James Robinson.
This was the result of an incorrect clear operation on the canvas
that stores the font atlas used by the HUD.
- platform/graphics/chromium/CompositorHUDFontAtlas.cpp:
(WebCore::CompositorHUDFontAtlas::generateFontAtlas):
- 7:00 PM Changeset in webkit [125960] by
-
- 27 edits in trunk
Unreviewed, rolling out r125897.
http://trac.webkit.org/changeset/125897
https://bugs.webkit.org/show_bug.cgi?id=94326
Source/WebCore:
This patch seems to have broken the inspector on the apple mac bots.
- WebCore.gypi:
- inspector/compile-front-end.py:
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._toRange):
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries.loadLibrary):
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries):
- inspector/front-end/Color.js:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js:
(WebInspector.Panel):
(WebInspector.PanelDescriptor):
(WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.get outputColorFormat):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector.doLoadedDone):
- inspector/front-end/utilities.js:
Source/WebKit/chromium:
this patch seems to have broken the inspector on the apple mac bots.
- WebKit.gyp:
- scripts/concatenate_js_files.py:
(OrderedJSFilesExtractor.handle_starttag):
- scripts/inline_js_imports.py:
(main):
LayoutTests:
This patch seems to have broken the inspector on the apple mac bots.
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- inspector/database-table-name-excaping.html:
- inspector/styles/styles-invalid-color-values.html:
- inspector/timeline-dfs.html:
- 5:48 PM Changeset in webkit [125959] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG is still too pessimistic about what constitutes a side-effect on array accesses
https://bugs.webkit.org/show_bug.cgi?id=94309
Reviewed by Geoffrey Garen.
This change means that even if structure transition watchpoints are not used for
hoisting of clobbered structure checks, we still retain good performance on the
benchmarks we care about. That's important, since butterflies will likely make
most array structures not watchpointable.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 5:43 PM Changeset in webkit [125958] by
-
- 5 edits in trunk
Add ability to create AtomicString using LChar* buffer and length
https://bugs.webkit.org/show_bug.cgi?id=94381
Reviewed by Geoffrey Garen.
Allows the use of 8 bit string data directly without converting to 16 bits first.
- wtf/text/AtomicString.cpp:
(WTF::LCharBufferTranslator::hash):
(LCharBufferTranslator):
(WTF::LCharBufferTranslator::equal):
(WTF::LCharBufferTranslator::translate):
(WTF::AtomicString::add):
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(AtomicString):
- wtf/text/StringImpl.h:
(StringImpl):
- 5:42 PM Changeset in webkit [125957] by
-
- 4 edits in trunk/Source/WebCore
AudioParam must support k-rate processing with audio-rate connections
https://bugs.webkit.org/show_bug.cgi?id=94385
Reviewed by Kenneth Russell.
Fully implement AudioParam *final* value calculation according to spec:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioParam
In particular, this covers the case where the parameter is k-rate, and we also
have audio-rate connections to the AudioParam.
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::finalValue):
(WebCore):
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateFinalValues):
- Modules/webaudio/AudioParam.h:
(AudioParam):
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::process):
- 5:36 PM Changeset in webkit [125956] by
-
- 3 edits in trunk/Tools
Perfalizer should differentiate results with and without the patch
https://bugs.webkit.org/show_bug.cgi?id=94399
Reviewed by Dirk Pranke.
Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
the results page are labled accordingly.
Also use _build_without_patch when building without a patch so that we get the right error message.
- Scripts/webkitpy/tool/commands/perfalizer.py:
(PerfalizerTask.run):
(PerfalizerTask._run_perf_test):
- Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
(PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
- 5:31 PM Changeset in webkit [125955] by
-
- 4 edits2 adds in trunk
Preserve styling elements in DeleteSelectionCommand
<rdar://problem/12040676>
https://bugs.webkit.org/show_bug.cgi?id=93643
Patch by Alice Cheng <alice_cheng@apple.com> on 2012-08-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
Styling elements (<link> and <style>) can appear inside editable content. To
prevent accidental deletion, we move styling elements to rootEditableElement in
DeleteSelectionCommand undoably.
Test: editing/execCommand/delete-selection-has-style.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss): Added to preserve styling elements during the command
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Modified to preserve styling elements during the command
- editing/DeleteSelectionCommand.h:
(DeleteSelectionCommand):
LayoutTests:
Test if delete selection command does move styling elements to
rootEditableElement, when the selection contains some. Also test command's
undoness.
- editing/execCommand/delete-selection-has-style-expected.txt: Added.
- editing/execCommand/delete-selection-has-style.html: Added.
- 5:25 PM Changeset in webkit [125954] by
-
- 2 edits in trunk/Tools
nrwt: don't fail tests if ImageDiff fails on the wk2 ports
https://bugs.webkit.org/show_bug.cgi?id=94396
Reviewed by Ryosuke Niwa.
It appears that WTR is generating PNGs that ImageDiff doesn't
like, and so we're getting lots of "can not get ImageDiff"
errors (see bug 81962). The change in r124581 made this a test
failure, and this is causing the WK2 bots to frequently abort
with 500+ failures.
This change makes ImageDiff errors not be test failures just for
WK2 for now until we can better triage what's going on.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
- 5:10 PM Changeset in webkit [125953] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r125940.
http://trac.webkit.org/changeset/125940
https://bugs.webkit.org/show_bug.cgi?id=94398
"Causes crashes on the bots
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r125944%20(2626)/fast/css
/first-letter-removed-added-crash-log.txt" (Requested by
bradee-oh on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
- rendering/RenderListItem.cpp:
- rendering/RenderListItem.h:
(RenderListItem):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderObjectChildList.h:
(RenderObjectChildList):
- rendering/RenderQuote.cpp:
- rendering/RenderQuote.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
(RenderRegion):
- 5:08 PM Changeset in webkit [125952] by
-
- 3 edits in trunk/Tools
[chromium] Add a style check for #include "cc/..." in chromium files
https://bugs.webkit.org/show_bug.cgi?id=94382
Patch by James Robinson <jamesr@chromium.org> on 2012-08-17
Reviewed by Adam Barth.
Adds a style check to make sure new chromium code follows the correct convention for including cc files.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_cc_includes):
- 5:06 PM Changeset in webkit [125951] by
-
- 3 edits2 adds in trunk
Disconnect UndoManager when its undo scope host is destroyed
https://bugs.webkit.org/show_bug.cgi?id=94388
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
Disconnect UndoManager in Element's destructor to prevent
use-after-free vulnerabilities.
Test: editing/undomanager/undoscopehost-use-after-free.html
- dom/Element.cpp:
(WebCore::Element::~Element):
LayoutTests:
- editing/undomanager/undoscopehost-use-after-free-expected.txt: Added.
- editing/undomanager/undoscopehost-use-after-free.html: Added.
- 4:57 PM Changeset in webkit [125950] by
-
- 2 edits in trunk/Source/WebCore
Fixed incorrect references to JSVoidCallback.{cpp,h} in the project file.
- WebCore.xcodeproj/project.pbxproj:
- 4:51 PM Changeset in webkit [125949] by
-
- 2 edits in trunk/Source/WebCore
Fix XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 4:36 PM Changeset in webkit [125948] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry][EFL] Remove compile warning in WebCore
https://bugs.webkit.org/show_bug.cgi?id=94328
Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-17
Reviewed by Rob Buis.
Fixed compile time warning in WebCore.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje): unused variable ‘errmsg’ [-Wunused-variable]
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::selectionRect): ‘toX’ may be used uninitialized in this function [-Wuninitialized], ‘fromX’ may be used uniniti
- 4:35 PM Changeset in webkit [125947] by
-
- 2 edits in trunk/Source/WebCore
[V8] use checkInboundData in setWebGLArrayHelper
https://bugs.webkit.org/show_bug.cgi?id=93051
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-17
Reviewed by Kenneth Russell.
Use TypedArray method checkInboundData in setWebGLArrayHelper instead
of performing the computation manually.
No new tests. This patch doesn't change behavior.
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::setWebGLArrayHelper):
- 4:27 PM Changeset in webkit [125946] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r125912): Crashes in worker tests
https://bugs.webkit.org/show_bug.cgi?id=94390
Reviewed by Brady Eidson and Sam Weinig.
- bindings/js/JSDOMBinding.cpp: (WebCore::reportException): It's always fine to report an exception on a worker context, but it's not fine to treat those as windows.
- 4:14 PM Changeset in webkit [125945] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Add missing header files to .gypi and missing include to CCTiledLayerImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=94391
Reviewed by Adrienne Walker.
- WebCore.gypi:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- 4:11 PM Changeset in webkit [125944] by
-
- 2 edits in trunk/Source/WebKit2
Adding back the first statement of WebProcessMain accidentally
removed in r125358.
Reviewed by Sam Weinig.
- WebProcess/mac/WebProcessMainMac.mm: Adding back the stripping
of DYLD_INSERT_LIBRARIES.
- 4:11 PM Changeset in webkit [125943] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version
https://bugs.webkit.org/show_bug.cgi?id=94269
Reviewed by Ojan Vafai.
I don't see a path through which this code is exercised.
ASSERT_NOT_REACHED doesn't cause any of our tests to fail. It might be
timing-related, in which case this ASSERT should be sporadically hit.
If this ASSERT is hit, see if we can write a test that exercises it or
at least add comments explaining how it gets exercised. If this ASSERT
is not hit after a while, change it to
ASSERT(transaction.scheduleTask(...)).
No new tests, we're looking for existing tests to fail.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- 4:07 PM Changeset in webkit [125942] by
-
- 20 edits in trunk
Unreviewed, rolling out r125922.
http://trac.webkit.org/changeset/125922
https://bugs.webkit.org/show_bug.cgi?id=94389
"Causing failing/crashing tests on Mac bots" (Requested by
bradee-oh on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
Source/WebCore:
- WebCore.gypi:
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileHeader.prototype.createView):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):
(WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype.populateContextMenu):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapProfileHeader.prototype.createView):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype.showProfileForURL):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
- inspector/front-end/Settings.js:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._toggleSearchingForNode):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector.frontendReused):
Source/WebKit/chromium:
- WebKit.gyp:
LayoutTests:
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-summary-show-ranges.html:
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html:
- 3:04 PM Changeset in webkit [125941] by
-
- 2 edits in branches/chromium/1229/Source
Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232
Reviewed by James Robinson.
Source/WebCore:
CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.
Chromium bug: crbug.com/125482
Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
Source/WebKit/chromium:
Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.
- tests/CCLayerTreeHostImplTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829399
- 2:59 PM Changeset in webkit [125940] by
-
- 11 edits in trunk/Source/WebCore
Introduce a will-be-removed-from-tree notification in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=94271
Reviewed by Abhishek Arya.
Following bug 93874, we have an insertion notification. This change adds the
matching removal notification (willBeRemovedFromTree).
Refactoring covered by existing tests.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the code from here and moved it below.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):
- rendering/RenderObject.h:
This is the base function that should be called by every instance.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::willBeRemovedFromTree):
- rendering/RenderListItem.h:
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::willBeRemovedFromTree):
- rendering/RenderQuote.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::willBeRemovedFromTree):
- rendering/RenderRegion.h:
Overriden functions.
- 2:50 PM Changeset in webkit [125939] by
-
- 3 edits in trunk/Source
Fix vsyncTick drought when vsync throttling is disabled
https://bugs.webkit.org/show_bug.cgi?id=94012
Patch by Brian Anderson <brianderson@chromium.org> on 2012-08-17
Reviewed by James Robinson.
CCFrameRateController made an assumption that every vsyncTick results
in a call to didBeginFrame, which is not necessarily true and causes
the CCFrameRateController to stop ticking when vsync is disabled. We
move the manual ticks out of didBeginFrame and manually tick in the
proper place.
CCFrameRateControllerTest updated with use cases that should tick
without a didBeginFrame and will fail without this patch.
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
- 2:46 PM Changeset in webkit [125938] by
-
- 2 edits in trunk/Source/WebCore
Delete some dead code in RenderBox::computePercentageLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=94262
Reviewed by Tony Chang.
I'm pretty sure this is dead code. None of the layout tests hit this code,
including the ones added in the original patch http://trac.webkit.org/changeset/10983.
I spent a good while and could not concoct a test that hits this code.
The test-cases added in that file, as well as the test-cases I came up with that should
go through this codepath, instead go through computePositionedLogicalHeight and never
hit computePercentageLogicalHeight.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
- 2:38 PM Changeset in webkit [125937] by
-
- 2 edits in trunk/LayoutTests
2012-08-17 Nate Chapin <Nate Chapin>
Add missing CR in bug identifiers in TextExpectations
- platform/chromium/TestExpectations:
- 2:36 PM Changeset in webkit [125936] by
-
- 4 edits in trunk/Source
Make it easier to append a literal to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=94273
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-17
Reviewed by Kentaro Hara.
Source/WebCore:
Use StringBuilder::appendLiteral() in MarkupAccumulator instead of computing every
value individually.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendXMLDeclaration):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendCDATASection):
Source/WTF:
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::appendLiteral): Add the method StringBuilder::appendLiteral() for efficiently
adding a string literal to the StringBuilder.
- 2:29 PM Changeset in webkit [125935] by
-
- 2 edits in trunk/LayoutTests
2012-08-17 Nate Chapin <Nate Chapin>
Update BUGJAPHET TextExpectations entries to point to bugs.
- platform/chromium/TestExpectations:
- 2:24 PM Changeset in webkit [125934] by
-
- 9 edits in trunk/Source/WebCore
Share the StringImpl the CSS property names
https://bugs.webkit.org/show_bug.cgi?id=94187
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-17
Reviewed by Alexey Proskuryakov.
Previously, we would instanciate a new String every time a CSS property name was needed.
This patches moves the creation of the AtomicString to CSSPropertyNames and reuse that
StringImpl whenever needed.
With the patch, accessing CSS property names from JavaScript gets about 2.1 times faster.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::item):
- css/CSSPrimitiveValue.cpp:
(WebCore::valueOrPropertyName):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::cssName):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
- css/makeprop.pl:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::sendTransitionEvent):
- 2:16 PM Changeset in webkit [125933] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Allow in-region accelerated scrolling take advantage of defer_blits
https://bugs.webkit.org/show_bug.cgi?id=94379
PR #194595
Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Jakob Petsovits.
Client does the blitting now.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- 1:58 PM Changeset in webkit [125932] by
-
- 195 edits in trunk/Source
[chromium] Add Source/WebCore/platform/graphics/chromium/cc/ to include path and remove cc/ prefix from includes
https://bugs.webkit.org/show_bug.cgi?id=94279
Reviewed by Adam Barth.
Source/WebCore:
This brings us more in line with the rest of the WebKit repo and avoids potential header collisions during
transition.
- WebCore.gyp/WebCore.gyp:
- platform/chromium/support/CCThreadImpl.cpp:
- platform/chromium/support/CCThreadImpl.h:
- platform/chromium/support/WebCompositorImpl.cpp:
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/ContentLayerChromium.cpp:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:
- platform/graphics/chromium/IOSurfaceLayerChromium.cpp:
- platform/graphics/chromium/ImageLayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LinkHighlight.cpp:
- platform/graphics/chromium/RateLimiter.cpp:
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
- platform/graphics/chromium/SolidColorLayerChromium.cpp:
- platform/graphics/chromium/TextureLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/TreeSynchronizer.cpp:
- platform/graphics/chromium/VideoLayerChromium.cpp:
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
- platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:
- platform/graphics/chromium/cc/CCAnimationCurve.cpp:
- platform/graphics/chromium/cc/CCAnimationEvents.h:
- platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp:
- platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h:
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
- platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:
- platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h:
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
- platform/graphics/chromium/cc/CCDrawQuad.h:
- platform/graphics/chromium/cc/CCFontAtlas.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp:
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h:
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h:
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerIterator.cpp:
- platform/graphics/chromium/cc/CCLayerIterator.h:
- platform/graphics/chromium/cc/CCLayerQuad.cpp:
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
- platform/graphics/chromium/cc/CCLayerSorter.h:
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCMathUtil.cpp:
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
- platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:
- platform/graphics/chromium/cc/CCPrioritizedTexture.h:
- platform/graphics/chromium/cc/CCProxy.cpp:
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCRenderPass.cpp:
- platform/graphics/chromium/cc/CCRenderPass.h:
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
- platform/graphics/chromium/cc/CCRenderSurface.h:
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
- platform/graphics/chromium/cc/CCRenderer.h:
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
- platform/graphics/chromium/cc/CCResourceProvider.h:
- platform/graphics/chromium/cc/CCScheduler.cpp:
- platform/graphics/chromium/cc/CCScheduler.h:
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
- platform/graphics/chromium/cc/CCScopedTexture.cpp:
- platform/graphics/chromium/cc/CCScopedTexture.h:
- platform/graphics/chromium/cc/CCScopedThreadProxy.h:
- platform/graphics/chromium/cc/CCScrollbarAnimationController.cpp:
- platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.cpp:
- platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.h:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
- platform/graphics/chromium/cc/CCSettings.cpp:
- platform/graphics/chromium/cc/CCSharedQuadState.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:
- platform/graphics/chromium/cc/CCSolidColorDrawQuad.h:
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
- platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp:
- platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h:
- platform/graphics/chromium/cc/CCTexture.cpp:
- platform/graphics/chromium/cc/CCTexture.h:
- platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:
- platform/graphics/chromium/cc/CCTextureDrawQuad.h:
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTextureLayerImpl.h:
- platform/graphics/chromium/cc/CCTextureUpdateController.cpp:
- platform/graphics/chromium/cc/CCTextureUpdateController.h:
- platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadTask.h:
- platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
- platform/graphics/chromium/cc/CCTileDrawQuad.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
- platform/graphics/chromium/cc/CCTimer.cpp:
- platform/graphics/chromium/cc/CCTimingFunction.cpp:
- platform/graphics/chromium/cc/CCTimingFunction.h:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp:
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h:
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
Source/WebKit/chromium:
- src/WebAnimationCurveCommon.cpp:
- src/WebAnimationImpl.cpp:
- src/WebCompositorInputHandlerImpl.cpp:
- src/WebCompositorInputHandlerImpl.h:
- src/WebExternalTextureLayer.cpp:
- src/WebFloatAnimationCurve.cpp:
- src/WebLayerTreeView.cpp:
- src/WebLayerTreeViewImpl.cpp:
- src/WebTransformAnimationCurve.cpp:
- tests/CCActiveAnimationTest.cpp:
- tests/CCAnimationTestCommon.cpp:
- tests/CCAnimationTestCommon.h:
- tests/CCDamageTrackerTest.cpp:
- tests/CCDelayBasedTimeSourceTest.cpp:
- tests/CCFrameRateControllerTest.cpp:
- tests/CCKeyframedAnimationCurveTest.cpp:
- tests/CCLayerAnimationControllerTest.cpp:
- tests/CCLayerImplTest.cpp:
- tests/CCLayerIteratorTest.cpp:
- tests/CCLayerQuadTest.cpp:
- tests/CCLayerSorterTest.cpp:
- tests/CCLayerTestCommon.cpp:
- tests/CCLayerTestCommon.h:
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
- tests/CCMathUtilTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
- tests/CCOcclusionTrackerTestCommon.h:
- tests/CCPrioritizedTextureTest.cpp:
- tests/CCQuadCullerTest.cpp:
- tests/CCRenderSurfaceFiltersTest.cpp:
- tests/CCRenderSurfaceTest.cpp:
- tests/CCResourceProviderTest.cpp:
- tests/CCSchedulerStateMachineTest.cpp:
- tests/CCSchedulerTest.cpp:
- tests/CCSchedulerTestCommon.h:
- tests/CCScopedTextureTest.cpp:
- tests/CCScrollbarAnimationControllerLinearFadeTest.cpp:
- tests/CCSolidColorLayerImplTest.cpp:
- tests/CCTestCommon.h:
- tests/CCTextureUpdateControllerTest.cpp:
- tests/CCThreadTaskTest.cpp:
- tests/CCThreadedTest.cpp:
- tests/CCThreadedTest.h:
- tests/CCTiledLayerImplTest.cpp:
- tests/CCTiledLayerTestCommon.h:
- tests/CCTimerTest.cpp:
- tests/ContentLayerChromiumTest.cpp:
- tests/FakeCCGraphicsContext.h:
- tests/FakeCCLayerTreeHostClient.h:
- tests/FloatQuadTest.cpp:
- tests/GraphicsLayerChromiumTest.cpp:
- tests/LayerChromiumTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
- tests/MockCCQuadCuller.h:
- tests/PlatformGestureCurveTest.cpp:
- tests/ScrollbarLayerChromiumTest.cpp:
- tests/TextureLayerChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
- tests/TreeSynchronizerTest.cpp:
- tests/WebCompositorInputHandlerImplTest.cpp:
- tests/WebFloatAnimationCurveTest.cpp:
- tests/WebTransformAnimationCurveTest.cpp:
- 1:55 PM Changeset in webkit [125931] by
-
- 2 edits in trunk/Tools
Delete some dead code from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=94380
Reviewed by Dirk Pranke.
This code became dead in one of the refactors of how we handle BuilderGroups.
There's no bug here, it's just dead code.
- TestResultServer/static-dashboards/builders.js:
(requestBuilderList):
(loadBuildersList):
- 1:43 PM Changeset in webkit [125930] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] REGRESSION(r125923): Breaks EFL build
https://bugs.webkit.org/show_bug.cgi?id=94376
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
Reviewed by Alexey Proskuryakov.
Fix EFL build break after r125923.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveIntentForFrame):
- 1:42 PM Changeset in webkit [125929] by
-
- 2 edits in trunk/Source/WebCore
Delete dead code in deprecated flexbox for RTL line-clamp
https://bugs.webkit.org/show_bug.cgi?id=94282
Reviewed by Tony Chang.
-webkit-line-clamp and direction:rtl is not supported. Delete some
obviously dead code that half-tries to support it.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
- 1:22 PM Changeset in webkit [125928] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for inspector/timeline/timeline-decode-resize.html on mac
https://bugs.webkit.org/show_bug.cgi?id=94375
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-17
Reviewed by Brady Eidson.
Mark inspector/timeline/timeline-decode-resize.html as an expected
failure on mac until https://bugs.webkit.org/show_bug.cgi?id=94374
is resolved.
- platform/mac/TestExpectations:
- 1:10 PM Changeset in webkit [125927] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: Refactor InspectorTest to split evals for initialization from runTest
https://bugs.webkit.org/show_bug.cgi?id=93520
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-17
Reviewed by Pavel Feldman.
Split function runTestInFrontend() into initialization and runTestInFrontEnd parts;
send them to the front-end in two different evaluateInFrontEnd calls, resulting in
two different eval() calls. In debug setup, we'll get two different UISourceCodes,
much easier to debug with.
Refactoring, all inspector tests pass.
- http/tests/inspector/inspector-test.js:
- 12:57 PM Changeset in webkit [125926] by
-
- 3 edits in trunk/Tools
[chromium] Add content shell bots to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=94369
Reviewed by Ojan Vafai.
The bots are named $OS (Content Shell).
- TestResultServer/static-dashboards/builders.js:
(isChromiumWebkitTipOfTreeTestRunner):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 12:17 PM Changeset in webkit [125925] by
-
- 18 edits4 copies6 adds in trunk
Text Autosizing: Increase line height in proportion to font size.
https://bugs.webkit.org/show_bug.cgi?id=91660
Patch by John Mellor <johnme@chromium.org> on 2012-08-17
Reviewed by Julien Chaffraix.
Source/WebCore:
This patch causes line heights to be increased in proportion to font
size (so autosized text doesn't overlap itself). It does this by adding
a textAutosizingMultiplier() to RenderStyle, which the lineHeight()
getter multiplies its response by.
It also cleans up one or two things, for example treatAsInline is
renamed isNotAnAutosizingContainer to clarify that its purpose is to
discriminate autosizing containers (the smallest unit that we can turn
Text Autosizing on or off for; in particular these are not allowed to
be line participants, since multiple sizes on one line looks awful).
Tests: fast/text-autosizing/em-margin-border-padding.html
fast/text-autosizing/narrow-child.html
fast/text-autosizing/nested-em-line-height.html
fast/text-autosizing/simple-paragraph.html
fast/text-autosizing/span-child.html
fast/text-autosizing/wide-child.html
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeight::applyValue):
Replaced Length(-100.0, Percent) with RenderStyle::initialLineHeight(),
which is equivalent but makes the intent clearer.
(WebCore::ApplyPropertyLineHeight::createHandler):
Use specifiedLineHeight to match setLineHeight which takes a specified
line height (and generally this avoids accidentally inheriting text
autosizing).
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Similarly use specifiedLineHeight when inheriting line height.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::ensurePropertyMap):
Get and set specified lineHeight/fontSize if Text Autosizing is
enabled to avoid setting the specified value to the computed value
(causing values to be multiplied more than once!).
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
Adjust for renamed setBlendedFontSize, and maintain cast to int.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
Replaced Length(-100.0, Percent) with RenderStyle::initialLineHeight(),
which is equivalent but makes the intent clearer.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
Use nextInPreOrderMatchingFilter instead of traverseNext, and some
other methods that got renamed.
(WebCore::TextAutosizer::processBox):
Renamed from processBlock, since RenderBoxes are sufficient; use
renamed nextInPreOrderMatchingFilter; make two calls to setMultiplier
(one for parent for line height) instead of processText.
(WebCore::TextAutosizer::setMultiplier):
Simplified from previous processText method; this just sets the
style's textAutosizingMultiplier (and the style does the rest).
(WebCore::TextAutosizer::isNotAnAutosizingContainer):
Renamed from treatAsInline; added explanatory comment; changed
isRenderBlock to isBox as boxes still have logicalWidth; changed
isInlineBlockOrInlineTable to isInline as it was an omission that
other inlines were allowed.
(WebCore::TextAutosizer::nextInPreOrderMatchingFilter):
Renamed from TextAutosizer::traverseNext.
(RenderObjectFilterFunctor):
Renamed from RenderObjectFilter to clafiry that it's a function ptr.
- rendering/TextAutosizer.h:
(TextAutosizer): Previously mentioned renamings.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::fixScriptsStyle):
Adjust for renamed setBlendedFontSize.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
textAutosizingMultiplier is a StyleDifferenceLayout (we want
setNeedsLayoutAndPrefWidthsRecalc to get called).
(WebCore::RenderStyle::setFontSize):
Renamed from setBlendedFontSize; if Text Autosizing is enabled and a
multiplier is set it auto-calculates the computedSize; float
param instead of int as discussed on webkit.org/b/91660.
- rendering/style/RenderStyle.h:
Added specifiedFontSize, computedFontSize and specifiedLineHeight
getters; changed lineHeight to dynamically calculate autosized line
height, and made computedLineHeight use this value instead of the
specified line height; also added textAutosizingMultiplier
getter/setter (the setter updated the font description's computed
size, by calling setFontSize); also renamed the parameter to
setLineHeight to explicitly note that it's setting the
specifiedLineHeight (and can still be adjusted by autosizing).
- rendering/style/StyleVisualData.cpp/.h:
Added m_textAutosizingMultiplier (this seems the best place to put a
non-inherited non-rare presentational property).
LayoutTests:
Adjusted the expectation for simple-paragraph.html and
font-scale-factor.html now that line-height is correctly increased.
Also added 5 more tests making sure that autosized children of
non-autosized parents work correctly, and vice versa; that nested
inline elements behave correctly; and documenting the behavior of
margins, borders, and padding with em lengths.
- fast/text-autosizing/em-margin-border-padding-expected.html: Added.
- fast/text-autosizing/em-margin-border-padding.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- fast/text-autosizing/font-scale-factor-expected.html:
- fast/text-autosizing/font-scale-factor.html:
- fast/text-autosizing/narrow-child-expected.html: Added.
- fast/text-autosizing/narrow-child.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- fast/text-autosizing/nested-em-line-height-expected.html: Added.
- fast/text-autosizing/nested-em-line-height.html: Added.
- fast/text-autosizing/simple-paragraph-expected.html:
- fast/text-autosizing/simple-paragraph.html:
- fast/text-autosizing/span-child-expected.html: Added.
- fast/text-autosizing/span-child.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- fast/text-autosizing/wide-child-expected.html: Added.
- fast/text-autosizing/wide-child.html: Copied from LayoutTests/fast/text-autosizing/simple-paragraph.html.
- 12:12 PM Changeset in webkit [125924] by
-
- 4 edits1 add in trunk
[CMake] Add FindDBus.cmake and use it in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=94319
Reviewed by Daniel Bates.
.:
Currently, the Battery Status-related code in the EFL port uses
libdbus but does not directly include its directories or link
against it, relying instead on the compiler flags coming via
EDbus's pkg-config information.
That will break once we stop obtaining EFL's include directories
and library paths from pkg-config, so write FindDBus.cmake to
prepare for that.
- Source/cmake/FindDBus.cmake: Added.
- Source/cmake/OptionsEfl.cmake: Look for D-Bus if BATTERY_STATUS
support is enabled.
Source/WebCore:
- PlatformEfl.cmake: Link against DBUS_LIBRARIES and add
DBUS_INCLUDE_DIRS to the include path list if BATTERY_STATUS
support is enabled.
- 12:01 PM Changeset in webkit [125923] by
-
- 2 edits in trunk/Source/WebKit2
Access m_process directly in WebPageProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=94363
Reviewed by John Sullivan.
Consistency fix - we don't use accessors when we don't have to, and there is a mix in this file.
- UIProcess/WebPageProxy.cpp:
- 11:57 AM Changeset in webkit [125922] by
-
- 19 edits in trunk
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
Source/WebCore:
Moving files from .html to importScript.
- WebCore.gypi:
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileHeader.prototype.createView):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):
(WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype.populateContextMenu):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapProfileHeader.prototype.createView):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype.showProfileForURL):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._toggleSearchingForNode):
(WebInspector._profilesLinkifier):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
Source/WebKit/chromium:
- WebKit.gyp:
- 11:45 AM Changeset in webkit [125921] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing expectations for two flaky crashers that were fixed in r125181.
Skipping three tests of otherwise unsupported features as they time out
and just prolong the bot cycle in doing so.
- platform/gtk/TestExpectations:
- 11:42 AM Changeset in webkit [125920] by
-
- 4 edits in trunk
REGRESSION(r125710) - canvas-fallback-content tests asserting in Chromium
https://bugs.webkit.org/show_bug.cgi?id=94156
Reviewed by Chris Fleizach.
Source/WebCore:
When determining if a Node is focusable, check the canvas subtree
case first before encountering assertions that assume that anything
focusable must have an associated renderer.
Fixes existing tests so they don't assert.
- dom/Node.cpp:
(WebCore::Node::isFocusable):
LayoutTests:
Fixes two canvas tests that were asserting.
- platform/chromium/TestExpectations:
- 11:39 AM Changeset in webkit [125919] by
-
- 20 edits7 adds8 deletes in trunk/LayoutTests
Unreviewed gardening. Updating test expectations after r125794.
- fast/repaint/transform-absolute-child-expected.txt: Added.
- fast/repaint/transform-repaint-descendants-expected.txt: Added.
- platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-linux/fast/repaint/transform-absolute-child-expected.png:
- platform/chromium-linux/fast/repaint/transform-repaint-descendants-expected.png:
- platform/chromium-linux/fast/repaint/transform-translate-expected.png:
- platform/chromium-linux/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
- platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
- platform/chromium-linux/media/audio-repaint-expected.png:
- platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png:
- platform/chromium-linux/transforms/svg-vs-css-expected.png:
- platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Removed.
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- platform/chromium-mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Removed.
- platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
- platform/chromium-win/fast/repaint/transform-absolute-child-expected.png:
- platform/chromium-win/fast/repaint/transform-repaint-descendants-expected.png:
- platform/chromium-win/fast/repaint/transform-translate-expected.png:
- platform/chromium-win/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
- platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
- platform/chromium-win/media/audio-repaint-expected.png:
- platform/chromium-win/svg/transforms/svg-css-transforms-expected.png:
- platform/chromium-win/transforms/svg-vs-css-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/fast/sub-pixel: Added.
- platform/chromium/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
- platform/efl/fast/repaint/transform-absolute-child-expected.txt: Removed.
- platform/efl/fast/repaint/transform-repaint-descendants-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-absolute-child-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-repaint-descendants-expected.txt: Removed.
- platform/mac/fast/repaint/transform-absolute-child-expected.txt: Removed.
- platform/qt/fast/repaint/transform-absolute-child-expected.txt: Removed.
- 11:33 AM Changeset in webkit [125918] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark indexeddb/resources-panel as also timing out
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:31 AM Changeset in webkit [125917] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: allocatedMaxLogicalWidth <= cellMaxLogicalWidth : int WebCore::AutoTableLayout::calcEffectiveLogicalWidth()
https://bugs.webkit.org/show_bug.cgi?id=92471
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-08-17
Reviewed by Julien Chaffraix.
Source/WebCore:
The assert occurs due to the float based computations causing a floating
point rounding error between allocatedMaxLogicalWidth and cellMaxLogicalWidth.
Test: fast/table/assert-autotablelayout-maxlogicalwidth.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
Converting float based calculations for computing max logical width to int based;
similar to the calculations for min logical width.
LayoutTests:
- fast/table/assert-autotablelayout-maxlogicalwidth-expected.txt: Added.
- fast/table/assert-autotablelayout-maxlogicalwidth.html: Added.
Added a testcase for verifying that the assert in AutoTableLayout::calcEffectiveLogicalWidth()
for allocatedMaxLogicalWidth coming greater than cellMaxLogicalWidth, does not occur.
- 11:27 AM Changeset in webkit [125916] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add @ sourceURL to test-runner evals
https://bugs.webkit.org/show_bug.cgi?id=94268
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-17
Reviewed by Pavel Feldman.
Postpend a line that tells the debugger what to call this eval buffer.
Name ends in the sequennce number so all evals will appear together.
evaluateInWebInspector0.js eg
- inspector/front-end/TestController.js:
(WebInspector.evaluateForTestInFrontend):
- 11:23 AM Changeset in webkit [125915] by
-
- 2 edits in trunk/Tools
Add AV perf layout tests to webkit flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=94255
Patch by Shadi Khalek <shadi@chromium.org> on 2012-08-17
Reviewed by Ojan Vafai.
Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
The isChromiumDepsAVTestRunner() filter does not work on current builder names.
It assumes the new names they are getting renamed to (AV Linux, AV Win7).
- TestResultServer/static-dashboards/builders.js:
(isChromiumTipOfTreeAVTestRunner):
(loadBuildersList):
- 11:11 AM Changeset in webkit [125914] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark context-menu.html as failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94367
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:01 AM Changeset in webkit [125913] by
-
- 269 edits7 copies3 adds20 deletes in trunk/LayoutTests
[chromium] Rebaseline Chromium mac images after r125830
Unreviewed gardening. Expectation update.
All changes looked like text fields changed imperceptibly and
checkboxes with text fields moved up to match the expected
non-Chromium versions.
- platform/chromium-linux-x86/fast/events/autoscroll-expected.png: Removed.
- platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
- platform/chromium-mac-snowleopard/css1/box_properties/acid_test-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac-snowleopard/fast/block/basic/011-expected.png:
- platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
- platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
- platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
- platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
- platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/formmove-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/formmove2-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/indeterminate-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
- platform/chromium-mac-snowleopard/fast/inline/positionedLifetime-expected.png:
- platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac-snowleopard/fast/parser/bad-xml-slash-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac-snowleopard/fast/table/003-expected.png:
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/textfield-overflow-expected.png.
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png.
- platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
- platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
- platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-mac/css1/box_properties/acid_test-expected.png:
- platform/chromium-mac/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/4895428-3-expected.png:
- platform/chromium-mac/editing/selection/4975120-expected.png:
- platform/chromium-mac/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac/fast/block/basic/011-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac/fast/css/input-search-padding-expected.png:
- platform/chromium-mac/fast/css/line-height-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/dom/isindex-001-expected.png:
- platform/chromium-mac/fast/dom/isindex-002-expected.png:
- platform/chromium-mac/fast/events/autoscroll-expected.png:
- platform/chromium-mac/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac/fast/forms/001-expected.png:
- platform/chromium-mac/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/encoding-test-expected.png:
- platform/chromium-mac/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/formmove-expected.png:
- platform/chromium-mac/fast/forms/formmove2-expected.png:
- platform/chromium-mac/fast/forms/indeterminate-expected.png:
- platform/chromium-mac/fast/forms/input-align-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac/fast/forms/input-baseline-expected.png:
- platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac/fast/forms/input-spaces-expected.png:
- platform/chromium-mac/fast/forms/input-table-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-width-expected.png:
- platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac/fast/forms/text-style-color-expected.png:
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac/fast/html/details-open2-expected.png:
- platform/chromium-mac/fast/html/details-open4-expected.png:
- platform/chromium-mac/fast/inline/positionedLifetime-expected.png:
- platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac/fast/parser/bad-xml-slash-expected.png:
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac/fast/table/003-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-mac/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-win-xp/editing/input/caret-at-the-edge-of-input-expected.png: Removed.
- platform/chromium-win-xp/fast/block/margin-collapse/103-expected.png: Removed.
- platform/chromium-win-xp/fast/events/autoscroll-expected.png: Removed.
- platform/chromium-win-xp/fast/events/context-no-deselect-expected.png: Removed.
- platform/chromium-win-xp/fast/forms/date/date-appearance-expected.png: Removed.
- platform/chromium-win-xp/fast/frames/take-focus-from-iframe-expected.png: Removed.
- platform/chromium-win-xp/fast/lists/dynamic-marker-crash-expected.png: Removed.
- platform/chromium-win-xp/fast/speech/input-appearance-numberandspeech-expected.png: Removed.
- platform/chromium-win-xp/fast/speech/input-appearance-speechbutton-expected.png: Removed.
- platform/chromium-win-xp/fast/speech/speech-bidi-rendering-expected.png: Removed.
- platform/chromium-win-xp/fast/transforms/transformed-focused-text-input-expected.png: Removed.
- platform/chromium-win-xp/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
- platform/chromium-win-xp/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
- platform/chromium-win-xp/svg/hixie/mixed/003-expected.png: Removed.
- platform/chromium-win-xp/tables/mozilla/dom/tableDom-expected.png: Removed.
- platform/chromium-win-xp/tables/mozilla/other/move_row-expected.png: Removed.
- platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
- 10:45 AM Changeset in webkit [125912] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r125592): Crash in Console::addMessage, under InjectedBundle::reportException
https://bugs.webkit.org/show_bug.cgi?id=94220
Reviewed by Alexey Proskuryakov.
Previously, this code was trying to detect whether a DOMWindow is
currently displayed in a Frame by testing whether
DOMWindow->scriptExecutionContext is zero. That used to work, but now
that DOMWindow->scriptExecutionContext is non-zero for detached
DOMWindow, this code doesn't work anymore. This patch replaces the code
with the current idiom, which is to call
DOMWindow::isCurrentDisplayedInFrame.
Alexey and I couldn't figure out how to test this change. This bug
causes a crash when some Safari extensions are installed, but it's not
clear whether this bug can be triggered from the web platform. We're
going to ask Jessie for ideas when she gets back from vacation.
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- 10:41 AM Changeset in webkit [125911] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Narrowing the failure expectation for http/tests/xmlhttprequest/origin-exact-matching.html.
The test now constantly fails only on release builds.
Adding a new baseline for a subpixel test that's required after r125794.
- platform/gtk/TestExpectations:
- platform/gtk/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
- 9:46 AM Changeset in webkit [125910] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add WK2 API to get suggested filename for URI responses
https://bugs.webkit.org/show_bug.cgi?id=92967
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-08-17
Reviewed by Carlos Garcia Campos.
Webcore has API to get the suggested filename for a response, add
a property and getter for it in WebKitURIResponse.
- UIProcess/API/gtk/WebKitURIResponse.cpp:
(_WebKitURIResponsePrivate): Add a CString holding the value.
(webkitURIResponseGetProperty): Add the gobject bits for the
property.
(webkit_uri_response_class_init): Install the property.
(webkit_uri_response_get_suggested_filename): New getter.
- UIProcess/API/gtk/WebKitURIResponse.h: Declare the public
method.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API
symbols.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSuggestedFilename): Test the new API.
(serverCallback): Add the the content-disposition header
in one case, in order to test it.
(beforeAll): Add the new test.
- 9:09 AM Changeset in webkit [125909] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Turn off ENABLE_DATALIST_ELEMENT for Android
https://bugs.webkit.org/show_bug.cgi?id=94337
Reviewed by Kent Tamura.
We shouldn't have turned ENABLE_DATALIST_ELEMENT on for Android.
- features.gypi:
- 8:55 AM Changeset in webkit [125908] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] On reload, www.sohu.com renders part white background, part overscroll pattern
https://bugs.webkit.org/show_bug.cgi?id=94348
Reviewed by Yong Li.
Jacky Jiang <zhajiang@rim.com>
PR: 179200
This can fix the reload issues of sohu.com, yahoo.com and
thestar.com/iphone(PR158041). And it is also related with PR178305.
Internally reviewed by George Staikos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState): Keeping scales for
reload was doing more harm than good. Two reasons to remove this:
(1) During reload, contents rect is changing due to layout updates,
it is possible that the contents or the white background can't cover
the whole screen if we are using the previous scales.
(2) Before reload, the source of the web page can be changed, therefore
previous scales won't be valid anymore.
Remove shouldRestoreViewState() as this check here is useless now.
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad): During
reload, we should give it a chance to zoom to fit the screen,
otherwise, it happens that the contents can't cover the whole screen
until we restore the view state, see PR158041.
Remove shouldRestoreViewState() as the error page issue PR178305 can be
covered by reload now.
- WebCoreSupport/FrameLoaderClientBlackBerry.h: Remove unused shouldRestoreViewState().
- 8:46 AM Changeset in webkit [125907] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Removing track-active-cues.html from TextExpectations, passing now.
[Chromium] Updating bug on track-cues-sorted-before-dispatch.html.
Unreviewed gardening.
- platform/chromium/TextExpectations:
- 8:38 AM Changeset in webkit [125906] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r125892.
http://trac.webkit.org/changeset/125892
https://bugs.webkit.org/show_bug.cgi?id=94350
Broke windows build (Requested by vollick on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
Source/WebCore:
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::cloneForImplThread):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
- src/WebAnimationImpl.cpp:
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- 8:37 AM Changeset in webkit [125905] by
-
- 3 edits1 add in trunk/Source/WebKit2
[EFL][wk2] Add unit tests for back-forward list API
https://bugs.webkit.org/show_bug.cgi?id=92617
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
Added unit tests covering the existing EFL WK2 back-forward list API.
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/resources/default_test_page.html:
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp: Added.
(serverCallbackNavigation):
(checkItem):
(urlFromTitle):
(TEST_F):
- 8:23 AM Changeset in webkit [125904] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 8:22 AM Changeset in webkit [125903] by
-
- 4 edits in trunk/Source
Add support for Skia Magnifier filter to Chromium layers
https://bugs.webkit.org/show_bug.cgi?id=93939
Patch by Zach Kuznia <zork@chromium.org> on 2012-08-17
Reviewed by James Robinson.
This is used by Chrome OS for the screen magnifier
Source/Platform:
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createZoomFilter):
(WebKit::WebFilterOperation::WebFilterOperation):
Source/WebCore:
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::optimize):
(WebCore::CCRenderSurfaceFilters::apply):
- 8:17 AM Changeset in webkit [125902] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] Turn on a few macros for jpeg decoding and image interpolation
https://bugs.webkit.org/show_bug.cgi?id=94244
Patch by Yong Li <yoli@rim.com> on 2012-08-17
Reviewed by Antonio Gomes.
Turn on these macros to get better performance.
- wtf/Platform.h:
- 8:12 AM Changeset in webkit [125901] by
-
- 4 edits in trunk
[BlackBerry] Remove some shared libraries from linking
https://bugs.webkit.org/show_bug.cgi?id=94253
Reviewed by Yong Li.
Remove some shared libraries.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit:
- PlatformBlackBerry.cmake:
- 7:48 AM Changeset in webkit [125900] by
-
- 2 edits in trunk/Source/WebKit2
UserMessageEncoder::baseEncode() should ASSERT when attempting to encode a non-shareable image
https://bugs.webkit.org/show_bug.cgi?id=94245
Reviewed by Alexey Proskuryakov.
It's a programming error if a client attempts to encode an image that has an
allocated bitmap, but isn't shareable, so we should assert in this case.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
Assert if we're trying to encode valid non-shareable image.
- 7:37 AM Changeset in webkit [125899] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=94344
Unreviewed EFL gardening of failing tests and new passes.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 7:31 AM Changeset in webkit [125898] by
-
- 10 edits4 adds in trunk
Touch adjustment for context menu gestures
https://bugs.webkit.org/show_bug.cgi?id=94101
Reviewed by Antonio Gomes.
Source/WebCore:
Adds a new filter for detecting nodes that provides extra context-menu items,
and use that in a new set of functions for adjusting context-menu gestures.
Tests: touchadjustment/context-menu-select-text.html
touchadjustment/context-menu.html
- page/EventHandler.cpp:
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::adjustGesturePosition):
- page/EventHandler.h:
(EventHandler):
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeProvidesContextMenuItems):
(TouchAdjustment):
(WebCore::findBestContextMenuCandidate):
- page/TouchAdjustment.h:
- testing/Internals.cpp:
(WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
(WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
Two new tests for context-menu touch adjustment.
- touchadjustment/context-menu-expected.txt: Added.
- touchadjustment/context-menu-select-text-expected.txt: Added.
- touchadjustment/context-menu-select-text.html: Added.
- touchadjustment/context-menu.html: Added.
- touchadjustment/resources/touchadjustment.js:
(nodeToString):
(testTouchPoint):
(testTouchPointContextMenu):
(adjustTouchPointContextMenu):
- 7:28 AM Changeset in webkit [125897] by
-
- 27 edits in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
Loading code on demand (upon the panel access).
- WebCore.gypi:
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._toRange):
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js:
(WebInspector.Panel):
(WebInspector.PanelDescriptor):
(WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector.doLoadedDone):
- inspector/front-end/utilities.js:
Source/WebKit/chromium: Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- WebKit.gyp:
- scripts/concatenate_js_files.py:
(OrderedJSFilesExtractor.handle_starttag):
- scripts/inline_js_imports.py:
(main):
LayoutTests: Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
Loading code on demand (upon the panel access);
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- inspector/database-table-name-excaping.html:
- inspector/timeline-dfs.html:
- 7:23 AM Changeset in webkit [125896] by
-
- 10 edits in trunk
Unreviewed, rolling out r125880.
http://trac.webkit.org/changeset/125880
https://bugs.webkit.org/show_bug.cgi?id=94347
Breaks front-end compilation: SourceFrame passed where View is
expected. (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17
Source/WebCore:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
- inspector/front-end/TextEditor.js:
- inspector/front-end/scriptsPanel.css:
(.script-view):
(.script-view.visible):
LayoutTests:
- inspector/debugger/reveal-execution-line.html:
- inspector/debugger/source-frame-count.html:
- 7:16 AM Changeset in webkit [125895] by
-
- 7 edits in trunk/Source
[Qt] QNX build fails due to ctype usage in system headers
https://bugs.webkit.org/show_bug.cgi?id=93849
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-17
Reviewed by Simon Hausmann.
Move the check for whether DisallowCType should be active or not
to the DisallowCType.h header. This way, we can update the list
of platforms or OSes which do not work with this header in a
central place. All users can now safely include the header
and do not need to place custom guards around it.
Source/JavaScriptCore:
- config.h:
Source/WebCore:
- config.h:
Source/WTF:
- config.h:
- wtf/DisallowCType.h:
- 7:11 AM Changeset in webkit [125894] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial build fix: Correct file name in bindings/js/DOMTransaction.h used in HEADERS
- Target.pri:
- 7:04 AM Changeset in webkit [125893] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] [WK2] Add unit tests for vibration_client_callbacks_set API
https://bugs.webkit.org/show_bug.cgi?id=93890
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
This patch covers unit testing of the Vibration API as delivered.
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(VibrationCbData):
(vibrateCallback):
(cancelVibrationCallback):
(loadVibrationHTMLString):
(TEST_F):
- 6:48 AM Changeset in webkit [125892] by
-
- 6 edits in trunk/Source
[chromium] Add tracing for active composited animations
https://bugs.webkit.org/show_bug.cgi?id=84210
Reviewed by James Robinson.
This patch issues the trace events from the animations. Animations will
report when they start and finish on the main and impl threads (via
TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they
change state.
Source/WebCore:
No new tests, only changes tracing behavior.
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::clone):
(WebCore):
(WebCore::CCActiveAnimation::cloneAndInitialize):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore::CCActiveAnimation::isControllingInstance):
(CCActiveAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
- src/WebAnimationImpl.cpp:
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- 6:40 AM EFLWebKit edited by
- update-efl info (diff)
- 6:23 AM Changeset in webkit [125891] by
-
- 2 edits in trunk/Tools
[Qt] QtWebKit fails to build with OpenGL support on QNX
https://bugs.webkit.org/show_bug.cgi?id=93278
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-17
Reviewed by Noam Rosenthal.
Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
contains opengl. Furthermore, we disable this feature on win32-* as usual,
but now also disable it on QNX.
Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
- qmake/mkspecs/features/features.prf:
- 6:11 AM Changeset in webkit [125890] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Rename WebKitWebView print-requested signal to print
https://bugs.webkit.org/show_bug.cgi?id=94306
Reviewed by Martin Robinson.
WebKitWebView::print-requested is inconsistent with the rest of
the API. It's a true_handled signal that allows users to implement
their own print dialog, or block printing, or rely on
defaults. The signal should be WebKitWebView::print like other
signals (create, close, decide_policy, etc.)
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
(webkitWebViewPrintFrame):
- UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass):
- UIProcess/API/gtk/tests/TestPrinting.cpp:
(webViewPrintCallback):
(testWebViewPrint):
(beforeAll):
- 6:00 AM Changeset in webkit [125889] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: enhance external test-runner and add cleanup code
https://bugs.webkit.org/show_bug.cgi?id=94231
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-17
Reviewed by Pavel Feldman.
add 'click on test result to select for next run' feature.
remember the users size for the inspector popup.
refactor server URLs to one location at top of file.
use the same value for both tests and scanner servers.
remove one extra instruction on the page.
refactor clean up code.
close the two popup windows if the test-runner.html is reloaded.
- inspector/front-end/test-runner.html:
- 5:33 AM Changeset in webkit [125888] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free()
https://bugs.webkit.org/show_bug.cgi?id=94312
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
eina_strbuf_string_free() frees the contents of a string buffer but not the
buffer, so eina_strbuf_free() must be used to free the buffer.
Contents of the buffer has already been take care by stealing it with
eina_strbuf_string_steal(), so no reason to call eina_strbuf_string_free().
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(serverCallback):
- 5:30 AM Changeset in webkit [125887] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial follow-up fix to r125873: Add missing adoptRef to avoid leaks.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::WeakMap::set):
- 5:25 AM Changeset in webkit [125886] by
-
- 3 edits in trunk/Source/WebCore
Remove RefPtr from DateInputType::m_pickerElement
https://bugs.webkit.org/show_bug.cgi?id=94330
Reviewed by Kent Tamura.
To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is describe in bug 94324.
DateInputType::m_pickerElement does not need to be a RefPtr<Node>,
because it is guaranteed to point to a shadow DOM tree of the DateInputType
node, which is guaranteed to exist in the subtree of the DateInputType node.
No tests. No change in behavior.
- html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
(WebCore::DateInputType::createShadowSubtree):
(WebCore::DateInputType::destroyShadowSubtree):
- html/DateInputType.h:
(DateInputType):
- 5:23 AM Changeset in webkit [125885] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Change font family/script on layout tests causes flakiness
https://bugs.webkit.org/show_bug.cgi?id=94327
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
Always set the font on WebCore even if the font family is the same. It
has to be done because the script value might have also changed.
Settings::set*FontFamily() has an implicit UScriptCode
parameter that will set the script back to the defaults.
- ewk/ewk_view.cpp:
(ewk_view_font_family_name_set):
- 5:22 AM Changeset in webkit [125884] by
-
- 9 edits2 deletes in trunk/Source/WebCore
Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971
Patch by Dan Carney <dcarney@google.com> on 2012-08-17
Reviewed by Kentaro Hara.
Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This update fixes a bad assertion which caused the previous
version to be rolled back.
No tests. No change in functionality.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::mainThreadNormalWorld):
- bindings/v8/DOMWrapperWorld.h:
(WebCore):
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::count):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
- bindings/v8/IsolatedWorld.cpp: Removed.
- bindings/v8/IsolatedWorld.h: Removed.
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
- bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):
- bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):
- 5:18 AM Changeset in webkit [125883] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Remove alloca usage
https://bugs.webkit.org/show_bug.cgi?id=93931
Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-17
Reviewed by Carlos Garcia Campos.
This patch is unifying the approaches for the creation of Edje_Message_Float_Set messages, and getting rid of alloca is part of it, since it is not portable.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
- platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::updateThumbPositionAndProportion):
- 5:08 AM Changeset in webkit [125882] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: hovering over an image link in Timeline popup kills popup
https://bugs.webkit.org/show_bug.cgi?id=94213
Reviewed by Pavel Feldman.
- Fixed bug with ElementsPanel PopoverHelper acting on the TimelinePanel (due to which the original issue occurs).
- Image preview added to resource entries popover in the timeline.
- Extracted the core image preview building code into UIUtils.js.
- Drive-by: fixed image centering in the preview element.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._showPopover.showCallback):
(WebInspector.TimelinePanel.prototype._showPopover):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.needsPreviewElement):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
First build the image preview element if necessary, then do everything else.
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
Original generatePopupContent() code plus the preview generation when necessary.
- inspector/front-end/UIUtils.js:
(WebInspector.buildImagePreviewContents.errorCallback):
(WebInspector.buildImagePreviewContents.buildContent):
(WebInspector.buildImagePreviewContents): Extracted from ElementsPanel. Enabled building of preview elements without the dimensions text data.
- inspector/front-end/elementsPanel.css:
(.image-preview-container):
(.image-preview-container img):
- inspector/front-end/timelinePanel.css:
(.image-preview-container): Fixed centering of the preview container contents.
(.image-preview-container img):
(.image-container):
- 5:06 AM Changeset in webkit [125881] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: decouple extension server from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=94322
Reviewed by Pavel Feldman.
- relay WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged received in ElementsPanel on WebInspector.notifications;
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
- inspector/front-end/ExtensionServer.js:
- 4:42 AM Changeset in webkit [125880] by
-
- 10 edits in trunk
Web Inspector: SourceFrame shouldn't be a View
https://bugs.webkit.org/show_bug.cgi?id=93444
Patch by Jan Keromnes <janx@linux.com> on 2012-08-17
Reviewed by Pavel Feldman.
Source/WebCore:
Move SourceFrame from being a View to being an Object. This will allow
future ExtensionSourceFrames to share a single iframe ExtensionView.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.wasShown):
(WebInspector.CodeMirrorTextEditor.prototype.willHide):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.detach):
(WebInspector.SourceFrame.prototype.focus):
(WebInspector.SourceFrame.prototype._onTextEditorWasShown):
(WebInspector.SourceFrame.prototype._onTextEditorWillHide):
- inspector/front-end/TextEditor.js:
- inspector/front-end/scriptsPanel.css:
LayoutTests:
Use TextEditor as a View instead of SourceFrame.
- inspector/debugger/reveal-execution-line.html:
- inspector/debugger/source-frame-count.html:
- 3:54 AM Changeset in webkit [125879] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: requests filtering in network tab
https://bugs.webkit.org/show_bug.cgi?id=93090
Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-17
Reviewed by Vsevolod Vlasov.
Added filtering support to search panel.
Implemented filtering for network panel.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._clearSearchMatchedList):
(WebInspector.NetworkLogView.prototype._updateHighlightIfMatched):
(WebInspector.NetworkLogView.prototype._highlightMatchedRequests):
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequestForSearch):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.performFilter):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.performFilter):
(WebInspector.NetworkDataGridNode.prototype._highlightMatchedSubstring):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.showSearchField):
(WebInspector.SearchController.prototype._switchFilterToSearch):
(WebInspector.SearchController.prototype._switchSearchToFilter):
(WebInspector.SearchController.prototype._updateFilterVisibility):
(WebInspector.SearchController.prototype._replaceAll):
(WebInspector.SearchController.prototype._filterCheckboxClick):
(WebInspector.SearchController.prototype._performFilter):
(WebInspector.SearchController.prototype._onFilterInput):
(WebInspector.SearchController.prototype._onSearchInput):
(WebInspector.SearchController.prototype.resetFilter):
- inspector/front-end/inspector.css:
(.filter):
- inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other:not(.filtered-out)):
- 3:46 AM Changeset in webkit [125878] by
-
- 7 edits in trunk
View source doesn't interpret escape characters in hrefs.
https://bugs.webkit.org/show_bug.cgi?id=94216
Patch by Anthony Berent <aberent@chromium.org> on 2012-08-17
Reviewed by Adam Barth.
Source/WebCore:
The cause was that HTMLViewSourceDocument was passing the unparsed content of the href attribute to the DOM as the URL for the link.
The fix is to pass the parsed content of the href attribute to the DOM.
Test: fast/forms/frames/viewsource-link-on-href-value.html extended to test this case.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::processTagToken): Pass parsed URL to AddRange.
(WebCore::HTMLViewSourceDocument::addRange):Added argument for parsed URL, and used this instead of text, to create link.
- html/HTMLViewSourceDocument.h:
(HTMLViewSourceDocument): Add new link argument to addRange for parsed URL, defaulting to "".
LayoutTests:
Extra href added to test containing escape characters
- fast/frames/resources/viewsource-frame-3.html: Added href containing escape characters to test
- fast/frames/resources/viewsource-frame-4.html: Added href containing escape characters to test
- fast/frames/viewsource-link-on-href-value.html: Check escape characters are correctly interpreted in href.
- 3:31 AM WebKitGTK/WebKit2Roadmap edited by
- Update roadmap in preparation for the freeze (diff)
- 3:23 AM Changeset in webkit [125877] by
-
- 3 edits in trunk/Source/WTF
[Qt] QNX build fails due to missing timegm declaration
https://bugs.webkit.org/show_bug.cgi?id=93842
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-17
Reviewed by Simon Hausmann.
On QNX, timegm is declared in nbutils.h and one must link against
nbutils to use it.
- WTF.pri:
- wtf/DateMath.cpp:
- 3:05 AM Changeset in webkit [125876] by
-
- 2 edits in trunk/LayoutTests
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=94297
Unreviewd. Temporary disable these tests.
- platform/chromium/TestExpectations:
- 2:50 AM Changeset in webkit [125875] by
-
- 3 edits in trunk/LayoutTests
Fixed fast/forms/file/selected-files-from-history-state.html on Windows
https://bugs.webkit.org/show_bug.cgi?id=94278
Patch by Marja Hölttä <marja@chromium.org> on 2012-08-17
Reviewed by Jochen Eisinger.
- fast/forms/file/selected-files-from-history-state.html: Fixed the test.
- platform/chromium/TestExpectations: Removed the expectation to fail.
- 2:44 AM Changeset in webkit [125874] by
-
- 7 edits in trunk/Source/WebCore
[Forms] Rename SpinButtonElement::StepActionHandler to SpinButtonOwner
https://bugs.webkit.org/show_bug.cgi?id=94311
Reviewed by Kent Tamura.
This patch renames SpinButtonElement::StepActionHandler class to
SpinButtonOwner for adding functions to it for communicating spin
button and its owner.
No new tests. This patch doesn't change behavior.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::~TextFieldInputType):
(WebCore::TextFieldInputType::destroyShadowSubtree):
- html/TextFieldInputType.h:
(TextFieldInputType):
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::~DateTimeEditElement):
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement):
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::create):
(WebCore::SpinButtonElement::doStepAction):
- html/shadow/SpinButtonElement.h:
(WebCore::SpinButtonElement::SpinButtonOwner::~SpinButtonOwner):
(SpinButtonElement):
(WebCore::SpinButtonElement::removeSpinButtonOwner):
- 2:42 AM Changeset in webkit [125873] by
-
- 7 edits in trunk/Source
[Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap
https://bugs.webkit.org/show_bug.cgi?id=93872
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
- Target.pri: Add missing JSWeakObjectMap file to build.
Source/WebCore:
The intention of this patch series is to replace use of internal JSC
API with use of the stable and public C API.
The JSC::Weak template is internal API and the only part of the C API
that exposes similar functionality is the JSWeakObjectMap. It is
special in the sense that its life-time is tied to the life-time of the
JS global object, which in turn is subject to garbage collection. In
order to maximize re-use of the same map across different JSContextRef
instances, we use one JSWeakObjectMap per context group and store the
map in a separate context.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::unusedWeakObjectMapCallback):
(Bindings):
(JSC::Bindings::WeakMapImpl::WeakMapImpl):
(JSC::Bindings::WeakMapImpl::~WeakMapImpl):
(JSC::Bindings::WeakMap::~WeakMap):
(JSC::Bindings::WeakMap::set):
(JSC::Bindings::WeakMap::get):
(JSC::Bindings::WeakMap::remove):
- bridge/qt/qt_instance.h:
(WeakMapImpl):
(Bindings):
(WeakMap):
(QtInstance):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
- 2:25 AM Changeset in webkit [125872] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation
https://bugs.webkit.org/show_bug.cgi?id=94308
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
The reason is that loadClient.didChangeBackForwardList callback is invoked with zero
arguments which is valid case while page back-forward navigation and means basically
that the back-froward list has changed but items were not added or deleted.
- UIProcess/API/efl/ewk_back_forward_list.cpp:
(ewk_back_forward_list_changed):
- 2:16 AM pywebsocket: a WebSocket server for layout tests edited by
- (diff)
- 2:16 AM pywebsocket: a WebSocket server for layout tests edited by
- (diff)
- 2:14 AM pywebsocket: a WebSocket server for layout tests edited by
- (diff)
- 2:08 AM Changeset in webkit [125871] by
-
- 45 edits in trunk
Web Inspector: build Elements, Resources, Timeline, Audits and Console panels lazily.
https://bugs.webkit.org/show_bug.cgi?id=94222
Reviewed by Vsevolod Vlasov.
Source/WebCore:
There is no need to construct these panels on inspector startup - we can do that lazily.
This change introduces the concept of PanelDescriptor that is sufficient for the panel
representation before it has been selected. It also makes selected panels build lazily.
The next step is to migrate rest of the panels and load the panel code lazily as well.
That should speed up startup time significantly.
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsSidebarTreeElement):
(WebInspector.AuditsSidebarTreeElement.prototype.onselect):
(WebInspector.AuditResultSidebarTreeElement):
(WebInspector.AuditResultSidebarTreeElement.prototype.onselect):
- inspector/front-end/ConsolePanel.js:
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.domStorageUpdated):
- inspector/front-end/Database.js:
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.revealAndSelectNode):
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
(WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateForcedPseudoStateItems):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onAddAuditCategory):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.showConsole):
(InspectorFrontendAPI.showResources):
(InspectorFrontendAPI.enterInspectElementMode):
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype.addPanel):
(WebInspector.InspectorView.prototype.panel):
(WebInspector.InspectorView.prototype.showPanel):
(WebInspector.InspectorView.prototype._keyDownInternal):
- inspector/front-end/NetworkPanel.js:
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):
(WebInspector.PanelDescriptor):
(WebInspector.PanelDescriptor.prototype.name):
(WebInspector.PanelDescriptor.prototype.title):
(WebInspector.PanelDescriptor.prototype.iconURL):
(WebInspector.PanelDescriptor.prototype.setIconURL):
(WebInspector.PanelDescriptor.prototype.panel):
(WebInspector.PanelDescriptor.prototype.lazy):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.cachedResourcesLoaded):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.prototype._createPanelToolbarItem.panelSelected):
(WebInspector.Toolbar.prototype._createPanelToolbarItem):
(WebInspector.Toolbar.prototype._panelSelected):
(WebInspector.Toolbar.prototype._setDropdownVisible):
(WebInspector.ToolbarDropdown):
(WebInspector.ToolbarDropdown.prototype.show):
(WebInspector.ToolbarDropdown.prototype._populate):
- inspector/front-end/inspector.css:
(.toolbar-small .toolbar-icon.custom-toolbar-icon):
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._panelSelected):
(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector.openResource):
(WebInspector.showPanel):
(WebInspector.panel):
(WebInspector.inspect.):
(WebInspector.inspect):
(WebInspector._showAnchorLocation):
(WebInspector.showProfileForURL):
(WebInspector.frontendReused):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.selectNodeWithId.onNodeFound):
(initialize_ElementTest.InspectorTest.selectNodeWithId):
(initialize_ElementTest.InspectorTest.expandElementsTree):
- http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest.InspectorTest.showPanel):
- http/tests/inspector/inspect-element.html:
- http/tests/inspector/resource-har-pages.html:
- http/tests/inspector/resource-tree/resource-tree-frame-add.html:
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- http/tests/inspector/resource-tree/resource-tree-reload.html:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- inspector/console/command-line-api-inspect.html:
- inspector/debugger/dom-breakpoints.html:
- inspector/debugger/source-frame.html:
- inspector/elements/edit-dom-actions.html:
- inspector/elements/elements-img-tooltip.html:
- inspector/elements/elements-panel-limited-children.html:
- inspector/elements/highlight-node-scaled.html:
- inspector/extensions/extensions-panel.html:
- inspector/extensions/extensions-sidebar.html:
- inspector/styles/force-pseudo-state.html:
- inspector/styles/set-property-boundaries.html:
- inspector/styles/styles-new-API.html:
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.stopTimeline):
- 2:02 AM Changeset in webkit [125870] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Add two more crash expectations for a couple of tests that started crashing
after r125710.
Update stale test expectations, removing or adding build type modifiers
or updating the expected failure type.
- platform/gtk/TestExpectations:
- 1:54 AM WebKitGTK/WebKit2Roadmap edited by
- Added bug report for GObject introspection (diff)
- 1:52 AM Changeset in webkit [125869] by
-
- 6 edits2 adds in trunk
Source/WebCore: libwebp-0.2.0: handle alpha channel if present
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
updated the Layout test webp-image-decoding.html
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
(outputMode):
switch to premultiplied-RGB if needed
(WebCore::WEBPImageDecoder::WEBPImageDecoder):
(WebCore::WEBPImageDecoder::decode):
use WebPGetFeatures() instead of WebPGetInfo(),
to detect presence of alpha channel
- platform/image-decoders/webp/WEBPImageDecoder.h:
(WEBPImageDecoder):
add a m_hasAlpha field
LayoutTests: update layout test for new libwebp-0.2.0
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
- fast/images/resources/test2.webp: Added.
lossy+alpha example
- fast/images/resources/test3.webp: Added.
lossless with alpha example
- fast/images/webp-image-decoding-expected.txt:
- fast/images/webp-image-decoding.html:
Updated test. Will now decode test2.webp and test3.webp too.
- 1:35 AM Changeset in webkit [125868] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Enable multiple fields time input UI for Chromium except Android
https://bugs.webkit.org/show_bug.cgi?id=94195
Reviewed by Kent Tamura.
This patch enables multiple fields time input UI for Chromium except
for Android.
No new tests. Existing tests in fast/forms/time-multiple-fields/
covers appearance and functionality of multiple fields time UI.
A manual checking for browser displays multiple fields time input UI
is needed.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore): Changed RuntimeEnabledFeatures::isInputTypeTimeEnabled to true
if ENABLE_INPUT_TYPE_TIME is enabled.
- 1:13 AM Changeset in webkit [125867] by
-
- 1 edit12 adds in trunk/LayoutTests
[Tests] Adding tests for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94196
Reviewed by Kent Tamura.
This patch introduces functional testing for multiple fields time input
UI when both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
are enabled.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-step-attribute-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-step-attribute.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html: Added.
- 1:11 AM Changeset in webkit [125866] by
-
- 15 edits in trunk/Source/WebCore
[Forms] Introduce SpinButtonElement.{cpp,h} into build
https://bugs.webkit.org/show_bug.cgi?id=94289
Reviewed by Kent Tamura.
This patch introduces html/shadow/SpinButtonElement.{cpp,h} into
build, files were copied from TextControlInnerElements.{cpp,h} by
bug 93943.
No new tests. This patch doesn't changes behavior.
- CMakeLists.txt: Added SpinButtonElement.cpp
- GNUmakefile.list.am: Added SpinButtonElement.{cpp,h}
- Target.pri: Added SpinButtonElement.cpp
- WebCore.gypi: Added SpinButtonElement.{cpp,h}
- WebCore.vcproj/WebCore.vcproj: Added SpinButtonElement.{cpp,h}
- WebCore.xcodeproj/project.pbxproj: Added SpinButtonElement.{cpp,h}
- accessibility/AccessibilitySpinButton.h: Replaced include file to SpinButtonElement.h from TextControlInnerElements.h
- html/TextFieldInputType.h: Added include file SpinButtonElement.h
- html/shadow/DateTimeEditElement.h: Replaced include file to SpinButtonElement.h from TextControlInnerElements.h
- html/shadow/SpinButtonElement.cpp: Removed code other than SpinButtonElement.
- html/shadow/SpinButtonElement.h: Removed code other than SpinButtonElement.
- html/shadow/TextControlInnerElements.cpp: Removed code of SpinButtonElement.
- html/shadow/TextControlInnerElements.h: Removed SpinButtonElement.
- rendering/RenderTheme.cpp: Added include file SpinButtonElement.h
- 1:08 AM Changeset in webkit [125865] by
-
- 23 edits18 adds in trunk
Implement UndoManager's V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=93912
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch implements V8 bindings for UndoManager's transact() method.
We keep alive the user objects passed to transact() by storing them in
a hidden property of DOMTransaction's wrapper and registering implicit
references from UndoManager to DOMTransaction.
Tests: editing/undomanager/domtransaction-survives-gc.html
editing/undomanager/undomanager-isolated-world.html
editing/undomanager/undomanager-transact.html
editing/undomanager/undomanager-undo-redo.html
editing/undomanager/undomanager-use-after-free.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMTransaction.cpp: Added.
(WebCore):
(WebCore::DOMTransaction::DOMTransaction):
(WebCore::DOMTransaction::create):
(WebCore::DOMTransaction::apply):
(WebCore::DOMTransaction::unapply):
(WebCore::DOMTransaction::reapply):
- bindings/js/DOMTransaction.h: Added.
(WebCore):
(DOMTransaction):
(WebCore::DOMTransaction::undoManager):
(WebCore::DOMTransaction::setUndoManager):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSUndoManagerCustom.cpp: Added.
(WebCore):
(WebCore::JSUndoManager::transact):
- bindings/v8/DOMTransaction.cpp: Added.
(WebCore):
(WebCore::DOMTransaction::DOMTransaction):
(WebCore::DOMTransaction::create):
(WebCore::DOMTransaction::apply):
(WebCore::DOMTransaction::unapply):
(WebCore::DOMTransaction::reapply):
(WebCore::DOMTransaction::getFunction):
(WebCore::DOMTransaction::callFunction):
- bindings/v8/DOMTransaction.h: Added.
(WebCore):
(DOMTransaction):
(WebCore::DOMTransaction::undoManager):
(WebCore::DOMTransaction::setUndoManager):
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/custom/V8DOMTransactionCustom.cpp: Added.
(WebCore):
(WebCore::V8DOMTransaction::visitDOMWrapper):
- bindings/v8/custom/V8UndoManagerCustom.cpp: Added.
(WebCore):
(WebCore::V8UndoManager::transactCallback):
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::undoManager):
- dom/Element.cpp:
(WebCore::Element::undoManager):
(WebCore::Element::disconnectUndoManager):
- editing/CompositeEditCommand.h:
- editing/DOMTransaction.idl: Added.
- editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::canUndo):
(WebCore::Editor::undo):
(WebCore::Editor::canRedo):
(WebCore::Editor::redo):
- editing/UndoManager.cpp:
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::clearStack):
(WebCore):
(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::stop):
(WebCore::UndoManager::~UndoManager):
(WebCore::createUndoManagerEntry):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::registerUndoStep):
(WebCore::UndoManager::registerRedoStep):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):
- editing/UndoManager.h:
(WebCore):
(UndoManager):
(WebCore::UndoManager::position):
(WebCore::UndoManager::canUndo):
(WebCore::UndoManager::canRedo):
(WebCore::UndoManager::undoScopeHost):
(WebCore::UndoManager::ownerNode):
- editing/UndoManager.idl:
- editing/UndoStep.h:
(UndoStep):
LayoutTests:
- editing/undomanager/domtransaction-survives-gc-expected.txt: Added.
- editing/undomanager/domtransaction-survives-gc.html: Added.
- editing/undomanager/undomanager-isolated-world-expected.txt: Added.
- editing/undomanager/undomanager-isolated-world.html: Added.
- editing/undomanager/undomanager-transact-expected.txt: Added.
- editing/undomanager/undomanager-transact.html: Added.
- editing/undomanager/undomanager-undo-redo-expected.txt: Added.
- editing/undomanager/undomanager-undo-redo.html: Added.
- editing/undomanager/undomanager-use-after-free-expected.txt: Added.
- editing/undomanager/undomanager-use-after-free.html: Added.
- 12:46 AM pywebsocket: a WebSocket server for layout tests created by
- 12:39 AM Changeset in webkit [125864] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: mark two accessibility tests as failing on GTK. Bug 94200.
- 12:38 AM Changeset in webkit [125863] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: CPU profile view select overlaps with status bar buttons
https://bugs.webkit.org/show_bug.cgi?id=94243
Reviewed by Pavel Feldman.
- use StatusBarComboBox inated of plain select element in the status bar of CPU profile view;
- add StatusBarComboBox.select()
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.get statusBarItems):
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarComboBox.prototype.selectedOption):
(WebInspector.StatusBarComboBox.prototype.select):
- inspector/front-end/externs.js: drive-by fix: add declaration to suppress compilation error;
(Array.prototype.select):