⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 19, 2012:

11:51 PM Changeset in webkit [126000] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Replace proxy()->windowShell() in ScriptController with windowShell()
​https://bugs.webkit.org/show_bug.cgi?id=94445

Reviewed by Adam Barth.

Now ScriptController owns windowShell. So ScriptController doesn't
need to get windowShell through V8Proxy.

No tests. No change in behavior.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::updateSecurityOrigin):
(WebCore::ScriptController::haveInterpreter):
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::namedItemAdded):
(WebCore::ScriptController::namedItemRemoved):

11:11 PM Changeset in webkit [125999] by fpizlo@apple.com
  • 17 edits
    1 add in trunk/Source/JavaScriptCore

The relationship between abstract values and structure transition watchpoints should be rationalized
​https://bugs.webkit.org/show_bug.cgi?id=94205

Reviewed by Geoffrey Garen.

This patch does a number of things related to the handling of the abstract values
arrising from values with structures known to be watchpointable:

  • This rationalizes the relationship between the structure that we know an object to have *right now* based on having executed a check against that structure, and the structure that we know the object could have *in the future* based on a type check executed in the past over a structure that was watchpointable.


  • We use the above to assert that structure transition watchpoints are being used soundly.


  • We use the above to strength reduce CheckStructure into StructureTransitionWatchpoint whenever possible.


  • This rationalizes the handling of CFA over constants that appeared in the bytecode. If at compile-time the constant has a watchpointable structure, then we can prove what structures it may have in the future. The analysis uses this to both assert that structure transition watchpoints are being used correctly, and to find opportunities for using them more aggressively.


The net effect of all of these changes is that OSR entry should work more smoothly.
It may also be a slight win due to strength reductions, though most of those strength
reductions would have already been done by the parser and the structure check hoister.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractValue.h:

(DFG):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(AbstractValue):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::filterValueByType):
(JSC::DFG::AbstractValue::validateType):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToStructureTransitionWatchpoint):
(Node):
(JSC::DFG::Node::hasStructure):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::forwardSpeculationWatchpoint):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationWatchpointWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculateArray):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureAbstractValue.h: Added.

(DFG):
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::clear):
(JSC::DFG::StructureAbstractValue::makeTop):
(JSC::DFG::StructureAbstractValue::top):
(JSC::DFG::StructureAbstractValue::add):
(JSC::DFG::StructureAbstractValue::addAll):
(JSC::DFG::StructureAbstractValue::contains):
(JSC::DFG::StructureAbstractValue::isSubsetOf):
(JSC::DFG::StructureAbstractValue::doesNotContainAnyOtherThan):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::isClear):
(JSC::DFG::StructureAbstractValue::isTop):
(JSC::DFG::StructureAbstractValue::isClearOrTop):
(JSC::DFG::StructureAbstractValue::isNeitherClearNorTop):
(JSC::DFG::StructureAbstractValue::size):
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::last):
(JSC::DFG::StructureAbstractValue::speculationFromStructures):
(JSC::DFG::StructureAbstractValue::hasSingleton):
(JSC::DFG::StructureAbstractValue::singleton):
(JSC::DFG::StructureAbstractValue::operator==):
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::StructureAbstractValue::topValue):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

10:18 PM Changeset in webkit [125998] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Move V8Proxy::callFunction() to ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=94437

Reviewed by Adam Barth.

To kill V8Proxy, this patch moves callFunction() from V8Proxy to ScriptController.

No tests. No change in behavior.

  • bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::callFunction):

  • bindings/v8/NPV8Object.cpp:

(_NPN_Invoke):
(_NPN_InvokeDefault):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScheduledAction.h:

(WebCore):
(ScheduledAction):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::callFunction):
(WebCore):
(WebCore::ScriptController::callFunctionEvenIfScriptDisabled):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::callListenerFunction):

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

10:11 PM Changeset in webkit [125997] by yosin@chromium.org
  • 9 edits in trunk/Source/WebCore

[Forms] Set SpinButtonElement free from HTMLInputElement
​https://bugs.webkit.org/show_bug.cgi?id=93941

Reviewed by Kent Tamura.

This patch removes dependency to HTMLInputElement from SpinButtonElement.

Functionalities used to be calling HTMLInputElement functions are
replaced to calling functions SpinButtonOwner class.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::focusAndSelectSpinButtonOwner): Moved functionality from SpinButtonElement::defaultEventHandler.
(WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents): Moved code from SpinButtonElement::willRespondToMouseClickEvents
(WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents): Moved code from SpinButtonElement::forwardEvent

  • html/TextFieldInputType.h:

(TextFieldInputType):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::focusAndSelectEditControlOwner): Moved functionality from SpinButtonElement::defaultEventHandler.
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerFocused): Added for DateTimeEditElement::shouldSpinButtonRespondToWheelEvents.

  • html/TimeInputType.h:
  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::focusAndSelectSpinButtonOwner): Added for SpinButtonElementOwner class change.
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToMouseEvents): ditto
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToWheelEvents): ditto

  • html/shadow/DateTimeEditElement.h:

(EditControlOwner): Added new virtual function declarations for SpinButtonElementOwner class change.
(DateTimeEditElement): Added new function declarations for SpinButtonElementOwner.

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler): Changed to use SpinButtonElementOwner instead of HTMLInputElement.
(WebCore::SpinButtonElement::forwardEvent): ditto
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto
(WebCore::SpinButtonElement::step): ditto
(WebCore::SpinButtonElement::shouldRespondToMouseEvents): Added helper function for calling SpinButtonOwner instance.

  • html/shadow/SpinButtonElement.h:

(SpinButtonOwner): Added new virtual function declarations.
(SpinButtonElement):

9:52 PM Changeset in webkit [125996] by yosin@chromium.org
  • 11 edits in trunk

[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Mac
​https://bugs.webkit.org/show_bug.cgi?id=94439

Reviewed by Kent Tamura.

Source/WebCore:

This patch disabled CSS selector for Firefox compatibility applied to
multiple fields time input UI, because it is supposed to apply text
field rather than multiple fields.

This patch allows us to have same appearance among Chromium-Linux,
Mac and Win.

No new tests. Following existing tests cover this change:

fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html

  • css/themeWin.css: Exclude input[type="time"] selector if ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS

enabled.

LayoutTests:

This patch updates expected images of multiple fields time input UI for
Chromium-Linux and CSS selectors for expected HTML file for changing
of Source/WebCore/css/themeWin.css.

  • fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.css:

(.host): Changed padding property.
(.ampmField): Remove wrong property.
(.hourField): ditto
(.millisecondField): ditto
(.minuteField): ditto
(.secondField): ditto

  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt:
  • platform/chromium/TestExpectations: Remove Chromium-Mac disabled entries.
9:39 PM Changeset in webkit [125995] by haraken@chromium.org
  • 14 edits
    2 moves in trunk/Source/WebCore

[V8] Rename SafeAllocation to V8ObjectConstructor
​https://bugs.webkit.org/show_bug.cgi?id=94436

Reviewed by Adam Barth.

For clarification.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::construct):

  • bindings/v8/V8Binding.cpp:

(WebCore::createRawTemplate):

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8NPObject.cpp:

(WebCore::createV8ObjectForNPObject):

  • bindings/v8/V8ObjectConstructor.cpp: Renamed from Source/WebCore/bindings/v8/SafeAllocation.cpp.

(WebCore):
(WebCore::V8ObjectConstructor::isValidConstructorMode):

  • bindings/v8/V8ObjectConstructor.h: Renamed from Source/WebCore/bindings/v8/SafeAllocation.h.

(WebCore):
(ConstructorMode):
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(V8ObjectConstructor):
(WebCore::V8ObjectConstructor::newInstance):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::createInjectedScriptHostV8Wrapper):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

9:35 PM EFLWebKitTests edited by ryuan.choi@samsung.com
(diff)
9:32 PM Changeset in webkit [125994] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Put webkit compositor binding files in separate conditionally included gyp section
​https://bugs.webkit.org/show_bug.cgi?id=94392

Patch by James Robinson <​jamesr@chromium.org> on 2012-08-19
Reviewed by Dirk Pranke.

This allows the use_libcc_for_compositor gyp variable to control whether the webkit bindings are pulled from the
WebKit repository or an external target.

  • WebKit.gyp:
  • WebKit.gypi:
9:32 PM Changeset in webkit [125993] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Move m_windowShell from V8Proxy to ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=94438

Reviewed by Adam Barth.

m_windowShell should be owned by ScriptController.
After this change, I can move a bunch of V8Proxy methods
that access windowShell() from V8Proxy to ScriptController.

No tests. No change in behavior.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):

  • bindings/v8/ScriptController.h:

(WebCore):
(WebCore::ScriptController::windowShell):
(ScriptController):

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::windowShell):
(WebCore):

  • bindings/v8/V8Proxy.h:

(WebCore):
(WebCore::V8Proxy::frame):
(V8Proxy):

9:03 PM Changeset in webkit [125992] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Do not allocate SQLiteDatabase's m_openErrorMessage until its needed
​https://bugs.webkit.org/show_bug.cgi?id=94434

Reviewed by Andreas Kling.

Previously, m_openErrorMessage was initialized from a static literal string whenever
the database is not open.

This patch changes the way we use m_openErrorMessage to only allocate a string in the
few cases where we need it. If there is no error message, we fallback to the previous
default string.

The goal is to prevent allocating the string unless needed. That saves initialization time
and memory.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastErrorMsg):

8:44 PM Changeset in webkit [125991] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Use initialization from literal for HTML Input type names
​https://bugs.webkit.org/show_bug.cgi?id=94421

Reviewed by Kent Tamura.

AtomicString's initialization from literal is faster and use less memory.

  • html/InputType.cpp:

(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):

8:39 PM Changeset in webkit [125990] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT
​https://bugs.webkit.org/show_bug.cgi?id=94420

Reviewed by Kentaro Hara.

Use the new StringBuilder::appendLiteral() instead of keeping some WTF::String in
memory.

The patch reduces memory usage.
It also reduces the binary size (-1672 bytes on x86_64).
I did not measure any difference in performance.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::customCssText):

8:33 PM Changeset in webkit [125989] by commit-queue@webkit.org
  • 15 edits
    11 adds in trunk

Source/WebCore: parse CSS attribute -webkit-blend-mode
​https://bugs.webkit.org/show_bug.cgi?id=94024

Patch by Rik Cabanier <​cabanier@adobe.com> on 2012-08-19
Reviewed by Dirk Schulze.

Added parsing and general CSS handling of -webkit-blend-mode per ​http://www.w3.org/TR/2012/WD-compositing-20120816/

Tests: css3/compositing/blend-mode-property-parsing-invalid.html

css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore):
(WebCore::RenderLayerBacking::updateLayerBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests: parse CSS attribute -webkit-blend-mode
​https://bugs.webkit.org/show_bug.cgi?id=94024

Patch by Rik Cabanier <​cabanier@adobe.com> on 2012-08-19
Reviewed by Dirk Schulze.

Added parsing and general CSS handling of -webkit-blend-mode per ​http://www.w3.org/TR/2012/WD-compositing-20120816/

  • css3/compositing: Added.
  • css3/compositing/blend-mode-property-expected.txt: Added.
  • css3/compositing/blend-mode-property-parsing-expected.txt: Added.
  • css3/compositing/blend-mode-property-parsing-invalid-expected.txt: Added.
  • css3/compositing/blend-mode-property-parsing-invalid.html: Added.
  • css3/compositing/blend-mode-property-parsing.html: Added.
  • css3/compositing/blend-mode-property.html: Added.
  • css3/compositing/script-tests: Added.
  • css3/compositing/script-tests/blend-mode-property-parsing-invalid.js: Added.

(testInvalidFilterRule):

  • css3/compositing/script-tests/blend-mode-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testFilterRule):

  • css3/compositing/script-tests/blend-mode-property.js: Added.
7:56 PM Changeset in webkit [125988] by morrita@google.com
  • 7 edits
    2 adds in trunk

DOM mutation against including <link> shouldn't trigger pending HTML parser.
​https://bugs.webkit.org/show_bug.cgi?id=93641

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLLinkElement::removedFrom() invoked Document::removePendingSheet(), which can trigger
HTMLParser that can mutate DOM tree. DOM mutation reentrancy on like this is problematic and
should be prohibited.

This change add an variation of Document::removePendingSheet() which postpones the notification
which triggers DOM mutation, and flush such pending notifications at the end of ongoing mutation.

Test: http/tests/loading/remove-child-triggers-parser.html

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeRemovalNotifier::notify): Flushed pending notifications at the end.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::removePendingSheet): Added RemovePendingSheetNotificationType parameter.
(WebCore):
(WebCore::Document::didRemoveAllPendingStylesheet): Extracted from removePendingSheet()

  • dom/Document.h:

(Document):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet): A flag setter.
(WebCore::Document::notifyRemovePendingSheetIfNeeded):
(WebCore):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::removedFrom): Switched to use "notification later" version of removePendingSheet()
(WebCore::HTMLLinkElement::removePendingSheet): Added RemovePendingSheetNotificationType parameter.

  • html/HTMLLinkElement.h:

LayoutTests:

Note that the test content need to be such cryptic because HTML parser is involving the
captured bug and adding explanations can affect the behavior then mask the bug.

  • http/tests/loading/remove-child-triggers-parser-expected.txt: Added.
  • http/tests/loading/remove-child-triggers-parser.html: Added.
7:30 PM Changeset in webkit [125987] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[EFL] Gardening for fast/forms/range/thumbslider-no-parent-slider.html
​https://bugs.webkit.org/show_bug.cgi?id=94334

Unreviewed gardening.

Slider thumb can not be displayed without parent slider because
current theme of EFL does not display slider thumb separately.

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-08-19

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
7:25 PM Changeset in webkit [125986] by yosin@chromium.org
  • 3 edits in trunk/LayoutTests

[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
​https://bugs.webkit.org/show_bug.cgi?id=94297

Reviewed by Kent Tamura.

This patch updates a logic for detcting multiple fields time input UI
has second field or not.

  • fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js:

(checkHasShortFormat): Added "<br>" between input elements to avoid rounding error
on calculating rendering width of input elements. When input elements are rendered on
same baseline, width of first one is 126px and second is 125px.

  • platform/chromium/TestExpectations: Changed bug id of entries Chromium-Mac specific bug entry, bug 94339.
6:31 PM Changeset in webkit [125985] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove RefPtr from HTMLProgressElement::m_value
​https://bugs.webkit.org/show_bug.cgi?id=94336

Reviewed by Kent Tamura.

To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because
it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement
node, which is guaranteed to exist in the subtree of the HTMLProgressElement node.

No tests. No change in behavior.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLProgressElement.h:
6:08 PM Changeset in webkit [125984] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove RefPtr from SearchInputType::m_resultsButton and SearchInputType::m_cancelButton
​https://bugs.webkit.org/show_bug.cgi?id=94339

Reviewed by Kent Tamura.

To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary
RefPtr<Node>s. The rationale is described in bug 94324.

SearchInputType::m_resultsButton and SearchInputType::m_cancelButton do not
need to be RefPtr<Node>s, because they are guaranteed to point to the shadow
DOM tree of the SearchInputType node, which is guaranteed to exist in the
subtree of the SearchInputType node.

No tests. No change in behavior.

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):
(WebCore::SearchInputType::destroyShadowSubtree):
(WebCore::SearchInputType::subtreeHasChanged):

  • html/SearchInputType.h:

(SearchInputType):

3:39 PM Changeset in webkit [125983] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

CSP 1.1: Add 'plugin-types' and 'form-action' DOM API.
​https://bugs.webkit.org/show_bug.cgi?id=94415

Patch by Mike West <​mkwst@chromium.org> on 2012-08-19
Reviewed by Adam Barth.

Source/WebCore:

Experimental implementations of the new 'plugin-types' and 'form-action'
directives recently landed, but we neglected to add DOM API endpoints to
query their state. Those APIs have been added to the specification[1],
and this patch brings our implementation up to date.

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html

http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html

  • page/DOMSecurityPolicy.cpp:

(isAllowed):

As a drive-by, change a parameter from a KURL to a String to match
the actual template. There's no reason to stringify an empty URL
when we can just use an empty string instead.

(isAllowedWithType):

Call out to the ContentSecurityPolicy object to check the protected
resource's ability to load a given media type.

(WebCore::DOMSecurityPolicy::allowsFormAction):

Call out to the ContentSecurityPolicy object to check the protected
resource's ability to submit a form to the given URL.

(WebCore):
(WebCore::DOMSecurityPolicy::allowsPluginType):

Pipes the plugin type through 'isAllowedWithType' for resolution.

  • page/DOMSecurityPolicy.h:

Add the 'allowsPluginType' and 'allowsFormAction' methods.

(DOMSecurityPolicy):

  • page/DOMSecurityPolicy.idl:

Add the 'allowsPluginType' and 'allowsFormAction' methods.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html: Added.
2:59 PM Changeset in webkit [125982] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

The current state of the call frame should be taken into account in the DFG for both predictions and proofs
​https://bugs.webkit.org/show_bug.cgi?id=94412

Reviewed by Geoffrey Garen.

This ensures that no matter how smart the DFG gets, it'll always know through
which entrypoint OSR will try to enter, and with which values it will attempt
to do so. For prologue OSR, this has no effect other than adding the current
arguments to the argument predictions. For loop OSR, this makes our treatment
of the loop slightly more conservative - just conservative enough to ensure
that OSR succeeds.

  • bytecode/CodeBlock.cpp:

(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):

  • bytecode/CodeBlock.h:

(CodeBlock):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::setMostSpecific):
(AbstractValue):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h:

(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::Graph):
(Graph):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::compileOptimizedFor):

  • runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

12:49 PM Changeset in webkit [125981] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add additional fields to WebGestureEvent
​https://bugs.webkit.org/show_bug.cgi?id=94238

Patch by Rick Byers <​rbyers@chromium.org> on 2012-08-19
Reviewed by James Robinson.

Add a union to WebGestureEvent with per-event-type data, as a first
step to eliminating the overloaded delta fields.

  • public/WebInputEvent.h:

(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

12:34 PM Changeset in webkit [125980] by pfeldman@chromium.org
  • 52 edits in trunk

Web Inspector: load network panel lazily
​https://bugs.webkit.org/show_bug.cgi?id=94414

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change removes access to WebInspector.panels.network and loads it lazily.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.clone):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.create):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.NetworkLog.prototype.requestForId):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):

  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):
(WebInspector._showAnchorLocation):

Source/WebKit/chromium:

  • WebKit.gyp:

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.navigate):
(initialize_InspectorTest.InspectorTest._innerReloadPage):

  • http/tests/inspector/network-test.js:
  • http/tests/inspector/network/async-xhr-json-mime-type.html:
  • http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html:
  • http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html:
  • http/tests/inspector/network/download.html:
  • http/tests/inspector/network/network-cachedresources-with-same-urls.html:
  • http/tests/inspector/network/network-clear-cache.html-disabled:
  • http/tests/inspector/network/network-clear-cookies.html-disabled:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-cyrillic-xhr.html:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-empty-xhr.html:
  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/inspector/network/network-image-404.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/network-preview-json.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/network-shared-worker.html:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-worker.html:
  • http/tests/inspector/network/network-xhr-async-double.html:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/request-parameters-decoding.html:
  • http/tests/inspector/network/x-frame-options-deny.html:
  • http/tests/inspector/resource-har-pages.html:
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html:
12:12 PM Changeset in webkit [125979] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WebPageProxy::setCursor does not check that the view is still in an active window
​https://bugs.webkit.org/show_bug.cgi?id=94427

Reviewed by Alexey Proskuryakov.

The Web process may ask to change the cursor when the view is in an active window, but
if by the time the UI process receives the message, the view is no longer in a window or the
window is not active , then the cursor should not change.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setCursor): Added a check that the view is in an active window before
allowing the page to change the cursor.

11:34 AM Changeset in webkit [125978] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

Unreviewed, rolling out r125972.
​http://trac.webkit.org/changeset/125972
​https://bugs.webkit.org/show_bug.cgi?id=94431

Breaks AppleMac builds (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-19

  • UIProcess/API/gtk/WebKitWebContext.cpp:
  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::WebViewTest):

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::userPreferredLanguagesChanged):

  • WebProcess/gtk/WebProcessGtk.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):

11:30 AM Changeset in webkit [125977] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r125976.
​http://trac.webkit.org/changeset/125976
​https://bugs.webkit.org/show_bug.cgi?id=94430

it does not fix build. (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-19

  • GNUmakefile.am:
  • GNUmakefile.list.am:
10:15 AM Changeset in webkit [125976] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.am: Add idl files in Modules/quota to EXTRA_DIST.
  • GNUmakefile.list.am: Add missing files to compilation.
9:24 AM Changeset in webkit [125975] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r125280-r125284): inspector/console/console-format-collections.html failing on Apple Lion Debug WK1 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=93748

Reviewed by Pavel Feldman.

Not reviewed - simple test fix.

  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-collections.html:
5:29 AM Changeset in webkit [125974] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Add API unit tests for Web Intents
​https://bugs.webkit.org/show_bug.cgi?id=90454

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-19
Reviewed by Kenneth Rohde Christiansen.

Add unit testing for Web intent requests,
including the "intent,request,new" signal on
the Ewk_View and the Ewk_Intent API.

  • UIProcess/API/efl/ewk_view.h: Fix documentation for argument type of "intent,request,new" signal.
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::mouseClick): Add utility method to simulate a click at given
coordinates. This is needed for testing functionality that requires a user gesture.
(EWK2UnitTest):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

  • UIProcess/API/efl/tests/resources/intent-request.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_intents.cpp:

(stringSortCb):
(onIntentReceived):
(TEST_F):

5:02 AM Changeset in webkit [125973] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused ElementAttributeData::removeAttribute() overload.
<​http://webkit.org/b/94425>

Reviewed by Antti Koivisto.

  • dom/ElementAttributeData.h:

(ElementAttributeData):

2:24 AM Changeset in webkit [125972] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

[GTK] Add API to set preferred languages to WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=90878

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_preferred_languages): Public API to set a
list of preferred languages sorted from most desirable to least
desirable.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextLanguages):
(serverCallback):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(resourceGetDataCallback):
(WebViewTest::mainResourceData): Moved from TestWebKitWebContext
to make it available to all WebViewTests.

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::userPreferredLanguagesChanged): Notify our
observer that the languages have been overriden.

  • WebProcess/gtk/WebProcessGtk.cpp:

(WebKit::buildAcceptLanguages): Helper function to build the
accept languages as specified in RFC 2616.
(WebKit::setSoupSessionAcceptLanguage): Set the accept-language
property of the default SoupSession.
(WebKit::languageChanged): Update the preferred languages in
SoupSession.
(WebKit::WebProcess::platformInitializeWebProcess): Add an
observer to be notified when the list of preferred languages is
updated.
(WebKit::WebProcess::platformTerminate): Remove the observer added
in platformInitializeWebProcess().

Aug 18, 2012:

5:57 PM Changeset in webkit [125971] by pdr@google.com
  • 3 edits in trunk/Source/WebCore

Refactor SVGMaskElement to inherit from StyledElement
​https://bugs.webkit.org/show_bug.cgi?id=94418

Reviewed by Dirk Schulze.

Previously, SVGMaskElement inherited from SVGStyledLocatableElement which includes
several unnecessary functions (e.g., getBBox()). This patch refactors SVGMaskElement
to inherit from SVGStyledElement which matches the spec:
​http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement

No new tests as this is just a refactoring.

  • svg/SVGMaskElement.cpp:

(WebCore):
(WebCore::SVGMaskElement::SVGMaskElement):

  • svg/SVGMaskElement.h:
3:56 PM Changeset in webkit [125970] by Mark Larson
  • 2 edits in branches/chromium/1229/Source

Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
​https://bugs.webkit.org/show_bug.cgi?id=94232

Reviewed by James Robinson.

Source/WebCore:

CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.

Chromium bug: crbug.com/125482

Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):

Source/WebKit/chromium:

Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.

  • tests/CCLayerTreeHostImplTest.cpp:

TBR=​danakj@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10829399

TBR=​danakj@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10857077

2:47 PM Changeset in webkit [125969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_back_forward_list_item properties should be in sync with WebProcessProxy::m_backForwardListItemMap
​https://bugs.webkit.org/show_bug.cgi?id=94248

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-08-18
Reviewed by Kenneth Rohde Christiansen.

Currently ewk_back_forward_list_item properties are initialized from
WKBackForwardListItemRef once in the constructor and then just stored.
This is erroneous approach as back forward items can be initialized within
several iterations, meaning several ipc calls to UI process and several updates
of WebProcessProxy::m_backForwardListItemMap where the items are stored.
Hence the values of ewk_back_forward_list_item properties should be updated
with the corresponding WKBackForwardListItem function invokes every time
they are called.

  • UIProcess/API/efl/ewk_back_forward_list_item.cpp:

(_Ewk_Back_Forward_List_Item): Data members have to be mutable as assigned being const pointers.
(_Ewk_Back_Forward_List_Item::_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_uri_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_uri_get):

10:43 AM Changeset in webkit [125968] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSValueList: Reserve the exact amount of space needed when constructing from CSS parser.
(No bug URL as Bugzilla is down today.)

Reviewed by Antti Koivisto.

Use Vector::reserveInitialCapacity() when constructing a CSSValueList from a CSSParserValueList
since we have the final length available. Also inlined the trivial append() and prepend().

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):

  • css/CSSValueList.h:

(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):

7:21 AM Changeset in webkit [125967] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

Follow up to r125966, fixing flaky tests.

  • inspector/elements/event-listeners-about-blank.html:
2:32 AM Changeset in webkit [125966] by pfeldman@chromium.org
  • 22 edits in trunk

2012-08-18 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: make profiles panel a lazily loaded module.
​https://bugs.webkit.org/show_bug.cgi?id=94351

Reviewed by Yury Semikhatsky.

  • removed usages of WebInspector.panels.profiles.
  • made panel lazily loaded
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/front-end/CPUProfileView.js: (WebInspector.CPUProfileHeader.prototype.createView):
  • inspector/front-end/CSSSelectorProfileView.js: (WebInspector.CSSSelectorProfileType.prototype.buttonClicked): (WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile): (WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile): (WebInspector.CSSProfileHeader.prototype.createView):
  • inspector/front-end/HeapSnapshotDataGrids.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._profiles): (WebInspector.HeapSnapshotView.prototype.populateContextMenu): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapProfileHeader.prototype.createView):
  • inspector/front-end/InspectorFrontendAPI.js: (InspectorFrontendAPI.isProfilingJavaScript): (InspectorFrontendAPI.startProfilingJavaScript): (InspectorFrontendAPI.stopProfilingJavaScript):
  • inspector/front-end/NativeMemorySnapshotView.js: (WebInspector.NativeMemoryProfileHeader.prototype.createView):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfileHeader.prototype.view): (WebInspector.ProfileHeader.prototype.createView): (WebInspector.ProfilesPanel.prototype.toggleRecordButton): (WebInspector.ProfilesPanel.prototype.showProfileForURL): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu): (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent): (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
  • inspector/front-end/Settings.js:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector._toggleSearchingForNode): (WebInspector._profilesLinkifier): (WebInspector._requestZoom.set InspectorFrontendHost): (WebInspector._requestZoom): (WebInspector.documentClick.followLink): (WebInspector.documentClick):

2012-08-18 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: make profiles panel a lazily loaded module.
​https://bugs.webkit.org/show_bug.cgi?id=94351

Reviewed by Yury Semikhatsky.

  • WebKit.gyp:

2012-08-18 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: make profiles panel a lazily loaded module.
​https://bugs.webkit.org/show_bug.cgi?id=94351

Reviewed by Yury Semikhatsky.

  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-summary-show-ranges.html:
  • inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html:
12:20 AM Changeset in webkit [125965] by pfeldman@chromium.org
  • 29 edits in trunk

2012-08-18 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: load panels code on demand
​https://bugs.webkit.org/show_bug.cgi?id=94326

Reviewed by Vsevolod Vlasov.

  • Introduces importScript that evals in debug mode and inlines for release
  • Loads Element, Resources, Timeline, Audits panels lazily.
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AuditsPanel.js:
  • inspector/front-end/CodeMirrorTextEditor.js: (WebInspector.CodeMirrorTextEditor): (WebInspector.CodeMirrorTextEditor.prototype._toRange):
  • inspector/front-end/Color.js:
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
  • inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.PanelDescriptor): (WebInspector.PanelDescriptor.prototype.panel):
  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/SettingsScreen.js: (WebInspector.GenericSettingsTab):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
  • inspector/front-end/Spectrum.js: (WebInspector.Spectrum.prototype.get outputColorFormat):
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector.doLoadedDone):
  • inspector/front-end/utilities.js:
  • inspector/inline-javascript-imports.py: (main):

2012-08-18 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: load panels code on demand
​https://bugs.webkit.org/show_bug.cgi?id=94326

Reviewed by Vsevolod Vlasov.

  • WebKit.gyp:
  • scripts/concatenate_js_files.py: (OrderedJSFilesExtractor.handle_starttag):
  • scripts/inline_js_imports.py: (main):

2012-08-18 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: load panels code on demand
​https://bugs.webkit.org/show_bug.cgi?id=94326

Reviewed by Vsevolod Vlasov.

Showing panels prior to running tests in order to load the code for them.

  • http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
  • inspector/database-table-name-excaping.html:
  • inspector/styles/styles-invalid-color-values.html:
  • inspector/timeline-dfs.html:
Note: See TracTimeline for information about the timeline view.