Timeline

Aug 25, 2012:

9:03 PM Changeset in webkit [126698] by Dave Barton

• 6 edits in trunk

Remove { vertical-align: baseline } declarations from mathml.css
​https://bugs.webkit.org/show_bug.cgi?id=95015

Reviewed by Eric Seidel.

Source/WebCore:

The { vertical-align: baseline } declarations in mathml.css had no positive effect, and could
wrongly override a previous { vertical-align: sub } or { vertical-align: super } declaration.

Added 1 test to mathml/presentation/subsup.xhtml.

• css/mathml.css:

(math):
(mrow, mfenced):
(msub, msup):
(msubsup):
(munder, mover, munderover):

• Remove { vertical-align: baseline } declarations

LayoutTests:

Added 1 test to mathml/presentation/subsup.xhtml.

• mathml/presentation/subsup.xhtml:
• platform/mac/mathml/presentation/subsup-expected.png:
• platform/mac/mathml/presentation/subsup-expected.txt:

8:58 PM Changeset in webkit [126697] by ggaren@apple.com

• 3 edits in trunk/Source/JavaScriptCore

2012-08-25 Geoffrey Garen <​ggaren@apple.com>

Try a little harder to fix the Linux build.

• runtime/JSActivation.cpp:
• runtime/JSActivation.h:

8:53 PM Changeset in webkit [126696] by ggaren@apple.com

• 2 edits in trunk/Source/JavaScriptCore

2012-08-25 Geoffrey Garen <​ggaren@apple.com>

Try to fix the Linux build.

• runtime/JSActivation.cpp:

8:25 PM Changeset in webkit [126695] by ggaren@apple.com

• 30 edits in trunk/Source/JavaScriptCore

Don't use malloc / destructors for activation objects
​https://bugs.webkit.org/show_bug.cgi?id=94897

Reviewed by Oliver Hunt.

65% faster on v8-real-earley.

Lots of boilerplate here, but the jist is this:

(1) Use CopiedSpace instead of malloc to allocate the activation's
backing store.

(2) Use MarkedSpace instead of ref-counting to allocate the symbol table.

(3) ==> No more destructor.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::stronglyVisitStrongReferences):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(FunctionCodeBlock): SymbolTable is a GC object now, so it gets a write
barrier and visit calls instead of ref-counting. I changed all CodeBlocks
to use shared symbol tables because the distinction between shared and
unshared hurt my head.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::emitPutStaticVar):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Sometimes, a period just wants
to be an arrow. And then C++ is there to accommodate.

• jit/JITDriver.h:

(JSC::jitCompileFunctionIfAppropriate):

• runtime/Arguments.h:

(ArgumentsData):
(JSC::Arguments::setRegisters):
(Arguments):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):

• runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::visitChildren):

• runtime/Executable.h:

(JSC::FunctionExecutable::symbolTable):
(FunctionExecutable):

• runtime/ExecutionHarness.h:

(JSC::prepareFunctionForExecution): I changed from WriteBarrier to
WriteBarrierBase so activations could reuse StorageBarrier and PropertyStorage.

• runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation): Allocate the symbol table here,
after we're fully constructed, to avoid GC during initialization.

(JSC::JSActivation::visitChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

• runtime/JSActivation.h:

(JSC::JSActivation::create):
(JSActivation):
(JSC::JSActivation::registerOffset):
(JSC):
(JSC::JSActivation::registerArraySize):
(JSC::JSActivation::registerArraySizeInBytes):
(JSC::JSActivation::tearOff): Tear-off zero-initializes all uncopied
registers. This makes it safe to copyAndAppend the full buffer in
visitChildren, without any extra checks.

• runtime/JSCell.h:

(JSCell): Moved a shared default set of flags into this base class, so
I could use it in a few places.

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

• runtime/JSGlobalData.h:

(JSGlobalData): New structure for symbol tables.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::addStaticGlobals):

• runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::symbolTableHasProperty): We don't need an inline
symbol table -- JSSymbolTableObject will GC allocate one for us.

• runtime/JSObject.h:

(JSObject):

• runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):

• runtime/JSStaticScopeObject.cpp:

(JSC):
(JSC::JSStaticScopeObject::visitChildren): NULL check our register store
because finishCreation allocates an object now, so we may get marked
before we've assigned to our register store.

• runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
(JSStaticScopeObject): No more destructor for this object, either, since
it no longer embeds a hash table.

• runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::visitChildren):
(JSC::JSSymbolTableObject::deleteProperty):
(JSC::JSSymbolTableObject::getOwnPropertyNames):

• runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::symbolTable):
(JSSymbolTableObject):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes): SymbolTableObject allocates a symbol
table automatically if one isn't provided. (Activations provide their
own, which they get from compiled code.)

• runtime/JSVariableObject.cpp:

(JSC):

• runtime/JSVariableObject.h:

(JSC::JSVariableObject::registerAt):
(JSC::JSVariableObject::addressOfRegisters):
(JSVariableObject):
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation): Removed a bunch of obsolete code.
Activations manage their registers directly now.

• runtime/StorageBarrier.h:

(StorageBarrier):
(JSC::StorageBarrier::operator!):

• runtime/SymbolTable.cpp:

(JSC):
(JSC::SharedSymbolTable::destroy):

• runtime/SymbolTable.h:

(JSC::SharedSymbolTable::create):
(SharedSymbolTable):
(JSC::SharedSymbolTable::createStructure):
(JSC::SharedSymbolTable::SharedSymbolTable): Boilerplat code to
make shared symbol table GC-allocated.

6:51 PM Changeset in webkit [126694] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[Texmap] Move TextureMapperGL to use GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=78672

Patch by Roland Takacs <​rtakacs@inf.u-szeged.hu>, Helder Correia <Helder Correia> on 2012-08-25
Reviewed by Noam Rosenthal.

It is based on a previous patch by Helder Correia.

TextureMapperGL (TMGL) includes direct GL calls and
GraphicsContext3D (GC3D) offers many conveniences over the
former approach: using existing CSS shader code, ANGLE for
shader compilation, reusing WebCore::Texture, having shaders and
textures that can delete themselves.

A GC3D object is created by TMGL with the newly introduced
builder createForCurrentGLContext(), which in turn uses
the new RenderToCurrentGLContext flag underneath.

TMGL's dependency on OpenGLShims.h was completely removed.
However, GC3D does not map every single GL constant. Thus, it's
important to document the following:

• GL_FALSE was mapped to false.
• GL_UNPACK_ROW_LENGTH, GL_UNPACK_SKIP_PIXELS, GL_UNPACK_SKIP_ROWS, GL_TEXTURE_RECTANGLE_ARB, and GL_UNSIGNED_INT_8_8_8_8_REV were locally defined in TMGL.

The patch was originally developed by Helder Correia and finished
by Roland Takacs.

No new tests, refactoring.

• platform/graphics/GraphicsContext3D.h:
• platform/graphics/texmap/TextureMapperGL.cpp:

(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::sharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::scissorClip):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawQuad):
(WebCore::TextureMapperGL::drawBorder):
(WebCore):
(WebCore::TextureMapperGL::drawTextureRectangleARB):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::viewportMatrix):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
(WebCore::TextureMapperGL::createTexture):

• platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::graphicsContext3D):
(TextureMapperGL):
(ClipStack):
(WebCore::BitmapTextureGL::textureTarget):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):

• platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::initializeProgram):
(WebCore::TextureMapperShaderProgram::getUniformLocation):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::TextureMapperShaderProgramAntialiasingNoMask):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(WebCore::StandardFilterProgram::~StandardFilterProgram):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::StandardFilterProgram::create):
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

• platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::id):
(WebCore::TextureMapperShaderProgram::vertexAttrib):
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::matrixLocation):
(WebCore::TextureMapperShaderProgram::flipLocation):
(WebCore::TextureMapperShaderProgram::textureSizeLocation):
(WebCore::TextureMapperShaderProgram::sourceTextureLocation):
(WebCore::TextureMapperShaderProgram::maskTextureLocation):
(WebCore::TextureMapperShaderProgram::opacityLocation):
(WebCore::TextureMapperShaderProgram::isValidUniformLocation):
(StandardFilterProgram):
(WebCore::StandardFilterProgram::vertexAttrib):
(WebCore::StandardFilterProgram::texCoordAttrib):
(WebCore::StandardFilterProgram::textureUniform):
(WebCore::TextureMapperShaderProgramSimple::create):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::colorLocation):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::create):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadVerticesInTextureCoordinatesLocation):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadEdgesInScreenSpaceLocation):
(TextureMapperShaderProgramAntialiasingNoMask):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(TextureMapperShaderManager):

6:16 PM Changeset in webkit [126693] by pdr@google.com

• 5 edits in trunk

Roll out r126056 and r126626
​https://bugs.webkit.org/show_bug.cgi?id=95017

Reviewed by Dirk Schulze.

Source/WebCore:

This patch rolls out r126056 which regressed a test.
The getBBox() code removed turns out to be required for tight bounding
boxes in SVGPathElement::getBBox().

When this regression occurred the relevant test was skipped in r126626. This
patch reverts that skip.

No new tests.

• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::getBBox):
(WebCore):

• svg/SVGPathElement.h:

(SVGPathElement):

LayoutTests:

Removing skipped test.

• platform/mac/Skipped:

4:58 PM Changeset in webkit [126692] by fpizlo@apple.com

• 7 edits in trunk/Source/JavaScriptCore

op_call should have ArrayProfiling for the benefit of array intrinsics
​https://bugs.webkit.org/show_bug.cgi?id=95014

Reviewed by Sam Weinig.

This is a performance-neutral change that just adds the profiling but does not
use it, yet. If in the future we wanted to make this kind of profiling cheaper
we could move it into specialized thunks for the relevant array intrinsics, but
I figure that if this much simpler change gives us what we need without any
discernable performance penalty then that's for the best.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):

• jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

4:45 PM Changeset in webkit [126691] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Skipping 4 compositing/overflow tests for gardening.
​https://bugs.webkit.org/show_bug.cgi?id=95011.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-08-25
Reviewed by Sam Weinig.

compositing/overflow/overflow-auto-with-touch.html
compositing/overflow/overflow-overlay-with-touch.html
compositing/overflow/scrolling-content-clip-to-viewport.html
compositing/overflow/textarea-scroll-touch.html

• platform/mac/Skipped:

4:06 PM Changeset in webkit [126690] by abarth@webkit.org

• 3 edits in trunk/Source/WebCore

[V8] V8NodeFilterCondition should use ScopedPersistent
​https://bugs.webkit.org/show_bug.cgi?id=95010

Reviewed by Eric Seidel.

V8NodeFilterCondition just re-implements ScopedPersistent by hand.

• bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::acceptNode):

• bindings/v8/V8NodeFilterCondition.h:

(WebCore):
(V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::create):

3:34 PM Changeset in webkit [126689] by fpizlo@apple.com

• 6 edits
  2 deletes in trunk/Source/JavaScriptCore

The redundant phi elimination phase is not used and should be removed
​https://bugs.webkit.org/show_bug.cgi?id=95006

Reviewed by Dan Bernstein.

Just removing dead code.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGDriver.cpp:
• dfg/DFGRedundantPhiEliminationPhase.cpp: Removed.
• dfg/DFGRedundantPhiEliminationPhase.h: Removed.

3:26 PM Changeset in webkit [126688] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

WinCairo Build Broken due to missing export definitions
​https://bugs.webkit.org/show_bug.cgi?id=95007

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-08-25
Reviewed by Ryosuke Niwa.

Export symbols were missing from the def file for WinCairo port. Added
these missing symbols to avoid build break

• win/WebKit2CFLite.def:

2:40 PM Changeset in webkit [126687] by Dave Barton

• 2 edits in trunk/LayoutTests

Re-unskip 2 previously fixed tests that were accidentally re-skipped in r119192.

Unreviewed, gardening.

• platform/mac/Skipped:

1:18 PM Changeset in webkit [126686] by zandobersek@gmail.com

• 120 edits
  10 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after the changes made in r126683.

• platform/gtk/TestExpectations:
• platform/gtk/animations/cross-fade-border-image-source-expected.txt:
• platform/gtk/css1/box_properties/border_bottom-expected.txt:
• platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
• platform/gtk/css1/box_properties/border_left-expected.txt:
• platform/gtk/css1/box_properties/border_left_inline-expected.txt:
• platform/gtk/css1/box_properties/border_right-expected.txt:
• platform/gtk/css1/box_properties/border_right_inline-expected.txt:
• platform/gtk/css1/units/length_units-expected.txt:
• platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.txt:
• platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
• platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.txt:
• platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
• platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt:
• platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
• platform/gtk/css2.1/t040302-c61-phys-len-00-b-expected.txt:
• platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
• platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
• platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
• platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
• platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
• platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
• platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
• platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
• platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
• platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
• platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
• platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
• platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
• platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
• platform/gtk/editing/execCommand/4580583-1-expected.txt:
• platform/gtk/editing/execCommand/4580583-2-expected.txt:
• platform/gtk/editing/inserting/5418891-expected.txt:
• platform/gtk/editing/inserting/5510537-expected.txt:
• platform/gtk/editing/inserting/6703873-expected.txt:
• platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
• platform/gtk/editing/pasteboard/5006779-expected.txt:
• platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
• platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
• platform/gtk/fast/block/float/012-expected.txt:
• platform/gtk/fast/block/float/013-expected.txt:
• platform/gtk/fast/block/float/016-expected.txt: Added.
• platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
• platform/gtk/fast/block/margin-collapse/041-expected.txt:
• platform/gtk/fast/block/margin-collapse/043-expected.txt:
• platform/gtk/fast/block/margin-collapse/057-expected.txt:
• platform/gtk/fast/borders/border-radius-wide-border-01-expected.txt: Added.
• platform/gtk/fast/borders/only-one-border-with-width-expected.txt: Added.
• platform/gtk/fast/css/acid2-expected.txt: Added.
• platform/gtk/fast/css/acid2-pixel-expected.txt: Added.
• platform/gtk/fast/css/border-height-expected.txt:
• platform/gtk/fast/css/caption-width-absolute-position-expected.txt:
• platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt:
• platform/gtk/fast/css/caption-width-fixed-position-expected.txt:
• platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt:
• platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
• platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt:
• platform/gtk/fast/frames/viewsource-attribute-expected.txt:
• platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
• platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
• platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
• platform/gtk/fast/inline/inline-padding-disables-text-quirk-expected.txt:
• platform/gtk/fast/inline/inline-text-quirk-bpm-expected.txt:
• platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt:
• platform/gtk/fast/layers/video-layer-expected.txt:
• platform/gtk/fast/lists/007-expected.txt:
• platform/gtk/fast/multicol/block-axis-horizontal-bt-expected.txt:
• platform/gtk/fast/multicol/block-axis-vertical-lr-expected.txt:
• platform/gtk/fast/multicol/block-axis-vertical-rl-expected.txt:
• platform/gtk/fast/multicol/progression-reverse-expected.txt: Added.
• platform/gtk/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
• platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
• platform/gtk/fast/overflow/overflow-rtl-expected.txt: Added.
• platform/gtk/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
• platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
• platform/gtk/fast/table/border-collapsing/003-expected.txt:
• platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt:
• platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
• platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
• platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
• platform/gtk/fast/table/colgroup-spanning-groups-rules-expected.txt:
• platform/gtk/fast/text/apply-start-width-after-skipped-text-expected.txt:
• platform/gtk/fast/text/basic/015-expected.txt:
• platform/gtk/fast/text/monospace-width-cache-expected.txt:
• platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
• platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt:
• platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
• platform/gtk/http/tests/misc/acid2-expected.txt:
• platform/gtk/http/tests/misc/acid2-pixel-expected.txt:
• platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
• platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
• platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
• platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
• platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
• platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
• platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
• platform/gtk/media/audio-controls-rendering-expected.txt:
• platform/gtk/media/audio-repaint-expected.txt:
• platform/gtk/media/controls-after-reload-expected.txt:
• platform/gtk/media/controls-strict-expected.txt:
• platform/gtk/media/controls-styling-expected.txt:
• platform/gtk/media/controls-styling-strict-expected.txt:
• platform/gtk/media/controls-without-preload-expected.txt:
• platform/gtk/media/media-controls-clone-expected.txt:
• platform/gtk/media/media-document-audio-repaint-expected.txt:
• platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
• platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
• platform/gtk/media/video-controls-rendering-expected.txt:
• platform/gtk/media/video-display-toggle-expected.txt:
• platform/gtk/media/video-empty-source-expected.txt:
• platform/gtk/media/video-no-audio-expected.txt:
• platform/gtk/media/video-volume-slider-expected.txt:
• platform/gtk/media/video-zoom-controls-expected.txt:
• platform/gtk/tables/mozilla/core/table_rules-expected.txt:
• platform/gtk/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
• platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
• platform/gtk/transforms/2d/transform-borderbox-expected.txt:
• platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
• platform/gtk/transitions/cross-fade-border-image-expected.txt:

11:42 AM Changeset in webkit [126685] by Dave Barton

• 1 edit
  10 deletes in trunk/LayoutTests

Remove custom mac-snowleopard mathml test baselines
​https://bugs.webkit.org/show_bug.cgi?id=95004

Reviewed by Eric Seidel.

These custom baselines are no longer needed, since the mac lion bots were upgraded to
OS X 10.7.4 in the fix for ​https://bugs.webkit.org/show_bug.cgi?id=94393.

• platform/mac-snowleopard/mathml: Removed.
• platform/mac-snowleopard/mathml/presentation: Removed.
• platform/mac-snowleopard/mathml/presentation/attributes-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/fenced-mi-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/fractions-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/mo-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/over-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/roots-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/row-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/sub-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/tokenElements-expected.txt: Removed.
• platform/mac-snowleopard/mathml/presentation/underover-expected.txt: Removed.

10:25 AM Changeset in webkit [126684] by robert@webkit.org

• 6 edits in trunk/LayoutTests

Update TestExpectations for Qt, EFL, GTK, Apple Win and Chromium after r126683.

Unreviewed, gardening.

• platform/chromium/TestExpectations:
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:

9:20 AM Changeset in webkit [126683] by robert@webkit.org

• 10 edits
  2 adds in trunk

Tables with just border-style set on the cells do not get a grid
​https://bugs.webkit.org/show_bug.cgi?id=84286

Reviewed by Julien Chaffraix.

Source/WebCore:

This is happening because every cell gets a zero-width border in createSharedCellStyle() if the table border is not explictly set.
FF and Opera don't do this, so leave the cell's border alone if there is no table border explicitly set.

Test: fast/css/table-rules-attribute-none-with-cell-borders.html

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle):

• rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject): Without this we would end up rebaselining a bunch of tests to report 'border: []'

rather than 'border: [none]'. The problem here was that writeRenderObject would only report the first border if it differed from
BorderValue(). What we want is for it to report the first border always and then any borders after that if they differ.

LayoutTests:

With the exception of the new test table-rules-attribute-none-with-cell-borders.html all
of these are rebaselines due to RenderTreeAsText now reporting the first border, even if it
is a default border.

• fast/block/float/avoidance-rtl-expected.txt:
• fast/borders/border-radius-wide-border-01-expected.txt:
• fast/borders/only-one-border-with-width-expected.txt:
• fast/css/table-rules-attribute-none-with-cell-borders-expected.html: Added.
• fast/css/table-rules-attribute-none-with-cell-borders.html: Added.
• fast/multicol/progression-reverse-expected.txt:
• fast/multicol/vertical-lr/rules-with-border-before-expected.txt:
• fast/multicol/vertical-rl/rules-with-border-before-expected.txt:
• platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
• platform/chromium-linux/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
• platform/chromium-linux/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
• platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/chromium-linux/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
• platform/chromium-linux/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
• platform/chromium-linux/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
• platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt:
• platform/chromium-win/animations/cross-fade-border-image-source-expected.txt:
• platform/chromium-win/css1/box_properties/border_bottom-expected.txt:
• platform/chromium-win/css1/box_properties/border_bottom_inline-expected.txt:
• platform/chromium-win/css1/box_properties/border_left-expected.txt:
• platform/chromium-win/css1/box_properties/border_left_inline-expected.txt:
• platform/chromium-win/css1/box_properties/border_right-expected.txt:
• platform/chromium-win/css1/box_properties/border_right_inline-expected.txt:
• platform/chromium-win/css1/units/length_units-expected.txt:
• platform/chromium-win/css2.1/20110323/absolute-replaced-height-036-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-height-007-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-height-008-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-height-009-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-height-010-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-width-001-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-width-002-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-width-003-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-width-004-expected.txt:
• platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
• platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.txt:
• platform/chromium-win/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
• platform/chromium-win/css2.1/t040302-c61-phys-len-00-b-expected.txt:
• platform/chromium-win/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
• platform/chromium-win/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
• platform/chromium-win/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
• platform/chromium-win/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
• platform/chromium-win/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
• platform/chromium-win/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
• platform/chromium-win/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
• platform/chromium-win/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
• platform/chromium-win/editing/deleting/type-delete-after-quote-expected.txt:
• platform/chromium-win/editing/execCommand/4580583-1-expected.txt:
• platform/chromium-win/editing/execCommand/4580583-2-expected.txt:
• platform/chromium-win/editing/inserting/5418891-expected.txt:
• platform/chromium-win/editing/inserting/5510537-expected.txt:
• platform/chromium-win/editing/inserting/6703873-expected.txt:
• platform/chromium-win/editing/inserting/break-blockquote-after-delete-expected.txt:
• platform/chromium-win/editing/pasteboard/5006779-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
• platform/chromium-win/fast/block/float/012-expected.txt:
• platform/chromium-win/fast/block/float/013-expected.txt:
• platform/chromium-win/fast/block/float/016-expected.txt:
• platform/chromium-win/fast/block/margin-collapse/041-expected.txt:
• platform/chromium-win/fast/block/margin-collapse/043-expected.txt:
• platform/chromium-win/fast/block/margin-collapse/057-expected.txt:
• platform/chromium-win/fast/css/acid2-expected.txt:
• platform/chromium-win/fast/css/acid2-pixel-expected.txt:
• platform/chromium-win/fast/css/border-height-expected.txt:
• platform/chromium-win/fast/frames/viewsource-attribute-expected.txt:
• platform/chromium-win/fast/frames/viewsource-on-image-file-expected.txt:
• platform/chromium-win/fast/inline/inline-padding-disables-text-quirk-expected.txt:
• platform/chromium-win/fast/inline/inline-text-quirk-bpm-expected.txt:
• platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.txt:
• platform/chromium-win/fast/lists/007-expected.txt:
• platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt:
• platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt:
• platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt:
• platform/chromium-win/fast/overflow/overflow-rtl-expected.txt:
• platform/chromium-win/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
• platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
• platform/chromium-win/fast/table/border-collapsing/003-expected.txt:
• platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:
• platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
• platform/chromium-win/fast/table/colgroup-spanning-groups-rules-expected.txt:
• platform/chromium-win/fast/text/basic/015-expected.txt:
• platform/chromium-win/fast/text/monospace-width-cache-expected.txt:
• platform/chromium-win/http/tests/misc/acid2-expected.txt:
• platform/chromium-win/http/tests/misc/acid2-pixel-expected.txt:
• platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
• platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
• platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
• platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
• platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
• platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
• platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
• platform/chromium-win/tables/mozilla/core/table_rules-expected.txt:
• platform/chromium-win/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
• platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
• platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
• platform/chromium-win/transforms/2d/transform-borderbox-expected.txt:
• platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.txt:
• platform/chromium-win/transitions/cross-fade-border-image-expected.txt:
• platform/chromium/fast/css/pseudo-first-line-border-width-expected.txt:
• platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
• platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
• platform/mac/fast/css/caption-width-absolute-position-expected.txt:
• platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt:
• platform/mac/fast/css/caption-width-fixed-position-expected.txt:
• platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt:
• platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
• platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
• platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt:

6:33 AM Changeset in webkit [126682] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: missing time ruler in Timeline and Network panels
​https://bugs.webkit.org/show_bug.cgi?id=95001

Reviewed by Pavel Feldman.

Fixed a call site for Calculator.boundarySpan(), which is now a function rather than a property.

• inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

2:23 AM Changeset in webkit [126681] by Michelangelo De Simone

• 5 edits in trunk

[Crash] Null pointer in CSSParser::parseMixFunction()
​https://bugs.webkit.org/show_bug.cgi?id=94998

Reviewed by Benjamin Poulain.

Source/WebCore:

parseMixFunction() may try to access invalid memory when the arguments of the
mix() function are comma-terminated.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseMixFunction):

LayoutTests:

New test cases added to check invalid comma-terminated values within mix().

• css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
• css3/filters/script-tests/custom-filter-property-parsing-invalid.js:

Aug 24, 2012:

11:25 PM EfficientStrings edited by benjamin@webkit.org

Use appendLiteral instead of append with StringBuilder (diff)

10:33 PM Changeset in webkit [126680] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping a test added in r126611 that requires CSS image-set support.
That feature is not currently enabled on the GTK port.

• platform/gtk/TestExpectations:

10:13 PM EfficientStrings edited by dbates@webkit.org

Remove extraneous semicolon. (diff)

10:10 PM EfficientStrings edited by dbates@webkit.org

Remove extraneous parenthesis (diff)

9:55 PM Changeset in webkit [126679] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/12157689> REGRESSION: WebProcessProxy destructor is sometimes called recursively
​https://bugs.webkit.org/show_bug.cgi?id=94997

Reviewed by Dan Bernstein.

• UIProcess/WebContext.cpp: (WebKit::WebContext::disconnectProcess): Make sure that

we don't try to delete WebProcessProxy while the vector still contains it. Previously,
we used RefPtr::clear, which zeroes out the value before destructing, but doing that
in every RefPtr destructor would be bad for performance.

8:42 PM Changeset in webkit [126678] by psolanki@apple.com

• 2 edits in trunk/Source/WebKit/mac

Don't create a new ResourceRequest if delegate returns the same NSURLRequest we passed it
​https://bugs.webkit.org/show_bug.cgi?id=94962

Reviewed by Geoffrey Garen.

If the NSURLRequest returned from the delegate callback is the same as the one we passed to
it, then avoid creating a new ResourceRequest object. This reduces the number of calls to
ResourceRequest::doUpdateResourceRequest().

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchWillSendRequest):

7:59 PM WikiStart edited by benjamin@webkit.org

(diff)

7:35 PM Changeset in webkit [126677] by cevans@google.com

• 4 edits
  2 copies in branches/chromium/1229

Merge 126131
BUG=143551
Review URL: ​https://chromiumcodereview.appspot.com/10875067

7:27 PM Changeset in webkit [126676] by cevans@google.com

• 5 edits
  2 copies in branches/chromium/1229

Merge 125988
BUG=141564
Review URL: ​https://chromiumcodereview.appspot.com/10874075

7:26 PM Changeset in webkit [126675] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[Texmap] Move TextureMapperGL to use GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=78672

Patch by Helder Correia <Helder Correia> on 2012-08-24
Reviewed by Noam Rosenthal.

Introducing a new GraphicsContext3D::texImage2DDirect() to allow
initialization of textures without allocation. The existing
textImage2D() refuses a null pixel buffer, and
texImage2DResourceSafe() allows it but performs memory
allocation and zeroes the bits. This was not fast enough for
BitmapTextureGL frequent setting up.

No new tests, refactoring.

• platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::texImage2D):

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::texImage2DDirect):
(WebCore):

• platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::texImage2D):

7:07 PM Changeset in webkit [126674] by cevans@google.com

• 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderBlock.cpp

Merge 125315
BUG=137409
Review URL: ​https://chromiumcodereview.appspot.com/10867075

6:57 PM Changeset in webkit [126673] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 125234
BUG=137147
Review URL: ​https://chromiumcodereview.appspot.com/10875066

6:41 PM Changeset in webkit [126672] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1229

Merge 126205
BUG=143656
Review URL: ​https://chromiumcodereview.appspot.com/10868094

6:29 PM Changeset in webkit [126671] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 125472
BUG=142395
Review URL: ​https://chromiumcodereview.appspot.com/10883044

6:25 PM Changeset in webkit [126670] by cevans@google.com

• 1 edit in branches/chromium/1229/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp

Merge 125292
BUG=140656
Review URL: ​https://chromiumcodereview.appspot.com/10868093

6:16 PM Changeset in webkit [126669] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 124843
BUG=139690
Review URL: ​https://chromiumcodereview.appspot.com/10867074

6:04 PM Changeset in webkit [126668] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 125237
BUG=139168
Review URL: ​https://chromiumcodereview.appspot.com/10868092

6:02 PM WebKit Team edited by kpiascik@rim.com

Added myself to the committers list (diff)

5:58 PM Changeset in webkit [126667] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 124914
BUG=138915
Review URL: ​https://chromiumcodereview.appspot.com/10878069

5:50 PM Changeset in webkit [126666] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

-webkit-font-smoothing: antialiased should use CG font rendering code path, not GDI
​https://bugs.webkit.org/show_bug.cgi?id=54004
<rdar://problem/8971429>

Patch by Roger Fong <​roger_fong@apple.com> on 2012-08-24
Reviewed by Dan Bernstein.

When specifying -webkit-font-smoothing: antialised; the code path ends up using GDI to draw the text.
GDI ends up drawing subpixel antialiased text, not aliased text anyways.
The CG code path also has the capability of drawing antialiased text. The reason that the GDI path was
used in the first place is no longer a concern here so we can stop using the GDI code path.

• platform/graphics/win/FontCGWin.cpp: Removing GDI font drawing code path.

(WebCore):
(WebCore::Font::drawGlyphs):

5:40 PM Changeset in webkit [126665] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1229

Merge 125052
BUG=136182
Review URL: ​https://chromiumcodereview.appspot.com/10870090

5:40 PM Changeset in webkit [126664] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

Touch Platform.h to solve a build dependency issue

Unreviewed.

• wtf/Platform.h:

5:35 PM Changeset in webkit [126663] by commit-queue@webkit.org

• 10 edits
  34 adds in trunk

Add support for compositing the contents of overflow:scroll areas
​https://bugs.webkit.org/show_bug.cgi?id=91117

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-08-24
Reviewed by Simon Fraser.

Patch by Simon Fraser with modifications by Sami Kyostila and Ian Vollick.

Allow a RenderLayer which exists for overflow scrolling
to use a composited layer for the scrolled contents, which
allows for compositing-accelerated overflow scrolling.

Tests:

compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html
compositing/overflow/iframe-inside-overflow-clipping.html
compositing/overflow/nested-scrolling.html
compositing/overflow/overflow-auto-with-touch-no-overflow.html
compositing/overflow/overflow-auto-with-touch.html
compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html
compositing/overflow/overflow-hidden-with-touch.html
compositing/overflow/overflow-overlay-with-touch-no-overflow.html
compositing/overflow/overflow-overlay-with-touch.html
compositing/overflow/overflow-scroll-with-touch-no-overflow.html
compositing/overflow/overflow-visible-with-touch.html
compositing/overflow/remove-overflow-crash.html
compositing/overflow/remove-overflow-crash2.html
compositing/overflow/scrolling-content-clip-to-viewport.html
compositing/overflow/textarea-scroll-touch.html

• platform/graphics/GraphicsLayerClient.h: New paint phase flag

used for scrolled contents. Provide a typedef for the flags
so that they can be ORed together.

• rendering/RenderLayer.h:

(WebCore::ClipRectsCache::ClipRectsCache):
(ClipRectsCache): In debug builds, store a m_respectingOverflowClip
flag so we can ASSERT later that we're fetching clip rects with the
same setting the rects were generated with.
Add new PaintLayerPaintingOverflowContents painting flag.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::usesCompositedScrolling): New method returns
true if this layer is using composited overflow scrolling.
(WebCore::RenderLayer::scrollTo): Don't repaint if we're doing
a composited scroll.
(WebCore::RenderLayer::paintLayer): Pass the right flags to backgroundClipRect();
if we're painting scrolled contents, we don't want to take the overflow clip rect
into account.
(WebCore::RenderLayer::paintLayerContents): Ditto. Also don't do the intersectsDamageRect()
check if we're painting scrolled contents.
(WebCore::RenderLayer::updateClipRects): New parameter to tell whether to respect overflow clipping.
Assert if we're fetching cached rects with a different 'respect clip' flag to the one they were generated
with.
(WebCore::RenderLayer::calculateClipRects): Take the 'respectOverflowClip' flag into account
when computing clip rects.
(WebCore::RenderLayer::parentClipRects): Ditto
(WebCore::RenderLayer::backgroundClipRect): Ditto
(WebCore::RenderLayer::calculateRects): Ditto
(WebCore::RenderLayer::childrenClipRect): This function is called from widget code, so may use a different
'respect clip rects' setting than that used for painting, so it has to compute clip rects on the fly.
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Composited scrolling makes a layer not normal-flow only.

• rendering/RenderLayerBacking.h:

(RenderLayerBacking): New member variables for the layers for scrolled contents, and the scrolling
layer which handles the scroll offset.
(WebCore::RenderLayerBacking::hasScrollingLayer):
(WebCore::RenderLayerBacking::scrollingLayer):
(WebCore::RenderLayerBacking::scrollingContentsLayer):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::destroyGraphicsLayers): Tear down the scrolling layers, if any.
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling): Renamed from layerOrAncestorIsTransformed,
since it has to look for composited scrolling layers too.
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): We don't want the contents of scrolling layers
to get clipped to the viewport.
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Create scrolling layers if necessary.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Set scrolling layer geometry.
(WebCore::RenderLayerBacking::updateInternalHierarchy): Hook up scrolling layers.
(WebCore::RenderLayerBacking::updateDrawsContent): Scrolling layers affect whether the main graphics layer
needs to draw content.
(WebCore::RenderLayerBacking::updateScrollingLayers): Create or destroy scrolling layers.
(WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer): If we have a scrolled contents layer,
the main layer should not paint the foreground.
(WebCore::RenderLayerBacking::parentForSublayers): Sublayers are parented in the scrolling contents
layer if one exists.
(WebCore::RenderLayerBacking::setContentsNeedDisplay): Need to dirty the scrolling contents layer.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Ditto.
(WebCore::RenderLayerBacking::paintIntoLayer): Set the right painting flags.
(WebCore::RenderLayerBacking::paintContents): Only clip to the bounds if we're not painting overflow contents.

5:34 PM Changeset in webkit [126662] by dmazzoni@google.com

• 3 edits in trunk/Source/WebKit/chromium

Chromium: WebAccessibilityObject should expose updateBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=94611

Reviewed by Chris Fleizach.

This change just exposes a method, with no new tests. Next, Chromium
will be modified to call this new method, and this will be followed
by a change that gets rid of calls to updateBackingStore under the
hood. That last change may add a test or update an existing test.

• public/WebAccessibilityObject.h:

(WebAccessibilityObject):

• src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::updateBackingStoreAndCheckValidity):
(WebKit):

5:32 PM Changeset in webkit [126661] by cevans@google.com

• 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderBlock.cpp

Merge 125353
BUG=134324
Review URL: ​https://chromiumcodereview.appspot.com/10868091

5:31 PM Changeset in webkit [126660] by cevans@google.com

• 6 edits
  2 copies in branches/chromium/1229

Merge 125351
BUG=134324
Review URL: ​https://chromiumcodereview.appspot.com/10882045

5:15 PM Changeset in webkit [126659] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 124888
BUG=132019
Review URL: ​https://chromiumcodereview.appspot.com/10879084

5:13 PM Changeset in webkit [126658] by benjamin@webkit.org

• 19 edits
  3 adds in trunk

Unify Number to StringImpl conversion
​https://bugs.webkit.org/show_bug.cgi?id=94879

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-08-24
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• runtime/UString.cpp:
• runtime/UString.h:

(JSC::UString::number):
Update UString to directly use the common NumberToString implementation.

Source/WebKit2:

• win/WebKit2.def: Update the exported symbols.

Source/WTF:

Previously, UString::number() and String::number() used different implementations.

WTF::String::number() was simply forwarding to String::format().
UString::number() had an optimized version of the conversion.

This patch replace both implementation by a new version, faster than the two previous versions.

The new functions numberToStringImpl improvements are:
-about 3 times faster than String::number().
-14% faster than UString::number() on signed numbers.
-9% faster than UString::number() on unsigned numbers.

• GNUmakefile.list.am:
• WTF.gypi:
• WTF.pro:
• WTF.vcproj/WTF.vcproj:
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/text/IntegerToStringConversion.cpp: Added.

(WTF::numberToStringImplSigned):
(WTF::numberToStringImpl):
(WTF::numberToStringImplUnsigned):

• wtf/text/IntegerToStringConversion.h: Added.
• wtf/text/WTFString.cpp:

(WTF::String::format):

• wtf/text/WTFString.h:

(WTF::String::number):

Tools:

Add testing for the new IntegerToStringConversion.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/GNUmakefile.am:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.

5:06 PM Changeset in webkit [126657] by fmalita@chromium.org

• 3 edits
  2 adds in trunk

ASSERTION FAILED: !attached() in WebCore::Node::attach()
​https://bugs.webkit.org/show_bug.cgi?id=94650

Reviewed by Abhishek Arya.

Source/WebCore:

Prevent SVGTests::handleAttributeChange() from attaching elements with detached parents.

Test: svg/custom/system-language-crash.html

• svg/SVGTests.cpp:

(WebCore::SVGTests::handleAttributeChange):

LayoutTests:

• svg/custom/system-language-crash-expected.txt: Added.
• svg/custom/system-language-crash.html: Added.

4:58 PM Changeset in webkit [126656] by commit-queue@webkit.org

• 86 edits
  4 adds in trunk

CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter
​https://bugs.webkit.org/show_bug.cgi?id=94633

Patch by Glenn Adams <​glenn@skynav.com> on 2012-08-24
Reviewed by Benjamin Poulain.

Ensure cssText final delimiter does not contain extraneous space character after semicolon.

Source/WebCore:

Test: cssom/cssstyledeclaration-csstext-final-delimiter.html

• css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

• css/CSSPageRule.cpp:

(WebCore::CSSPageRule::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

• css/CSSProperty.cpp:

(WebCore::CSSProperty::cssText):
Ensure serialized property does longer contains extra space in cssText.
Construct result using StringBuilder.

• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

• css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addRule):
Conditionally add SPACE in reserialized rule in case passed style no
longer contains extra space. Note that if it does already contain an
extra space that inserting an extra space here is harmless (i.e., is
effectively normalized during parse).
Construct result using StringBuilder.

• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):
Ensure serialized property set does longer contains extra space in final
delimiter.
Construct result using StringBuilder.

• css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::addBlockStyle):
Conditionally add SPACE in block style since cssText no longer contains
extra space.
Construct result using StringBuilder.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
Conditionally add SPACE in pre-existing inline style since cssText no
longer contains extra space.
Construct result using StringBuilder.

LayoutTests:

• cssom/README.txt: Added.
• cssom/cssstyledeclaration-csstext-final-delimiter-expected.txt: Added.
• cssom/cssstyledeclaration-csstext-final-delimiter.html: Added.
• editing/deleting/delete-line-break-before-underlined-content-expected.txt: Remove extraneous space.
• editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt: ditto
• editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: ditto
• editing/deleting/merge-paragraph-from-h6-with-style-2-expected.txt: ditto
• editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: ditto
• editing/deleting/merge-paragraph-from-p-with-style-3-expected.txt: ditto
• editing/deleting/merge-paragraph-from-p-with-style-expected.txt: ditto
• editing/deleting/paste-with-transparent-background-color-expected.txt: ditto
• editing/execCommand/insert-list-with-noneditable-content-expected.txt: ditto
• editing/execCommand/script-tests/toggle-link.js: ditto
• editing/execCommand/script-tests/toggle-unlink.js: ditto
• editing/execCommand/toggle-link-expected.txt: ditto
• editing/execCommand/toggle-unlink-expected.txt: ditto
• editing/inserting/page-zoom-font-size-expected.txt: ditto
• editing/pasteboard/19644-2-expected.txt: ditto
• editing/pasteboard/5761530-1-expected.txt: ditto
• editing/pasteboard/5780697-2-expected.txt: ditto
• editing/pasteboard/copy-null-characters-expected.txt: ditto
• editing/pasteboard/copy-paste-bidi-expected.txt: ditto
• editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: ditto
• editing/pasteboard/data-transfer-items-expected.txt: ditto
• editing/pasteboard/display-block-on-spans-expected.txt: ditto
• editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt: ditto
• editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt: ditto
• editing/pasteboard/drag-drop-url-with-style-expected.txt: ditto
• editing/pasteboard/onpaste-text-html-expected.txt: ditto
• editing/pasteboard/paste-4039777-fix-expected.txt: ditto
• editing/pasteboard/paste-and-sanitize-expected.txt: ditto
• editing/pasteboard/paste-and-sanitize.html: ditto
• editing/pasteboard/paste-list-003-expected.txt: ditto
• editing/pasteboard/paste-noscript-expected.txt: ditto
• editing/pasteboard/paste-noscript-xhtml-expected.txt: ditto
• editing/pasteboard/paste-table-002-expected.txt: ditto
• editing/pasteboard/paste-text-with-style-4-expected.txt: ditto
• editing/pasteboard/paste-text-with-style-5-expected.txt: ditto
• editing/pasteboard/paste-with-redundant-style-expected.txt: ditto
• editing/pasteboard/preserve-underline-color-expected.txt: ditto
• editing/pasteboard/style-from-rules-expected.txt: ditto
• editing/pasteboard/testcase-9507-expected.txt: ditto
• editing/style/non-inheritable-styles-expected.txt: ditto
• editing/style/push-down-font-styles-expected.txt: ditto
• editing/style/push-down-implicit-styles-around-list-expected.txt: ditto
• editing/style/push-down-implicit-styles-expected.txt: ditto
• editing/style/push-down-inline-styles-expected.txt: ditto
• editing/style/script-tests/push-down-font-styles.js: ditto
• editing/style/script-tests/push-down-implicit-styles-around-list.js: ditto
• editing/style/script-tests/push-down-implicit-styles.js: ditto
• editing/style/script-tests/push-down-inline-styles.js: ditto
• editing/undo/remove-css-property-and-remove-style-expected.txt: ditto
• editing/undo/replace-by-span-then-remove-expected.txt: ditto
• editing/undo/replace-by-span-then-remove.html: ditto
• fast/css/background-position-serialize.html: ditto
• fast/css/counters/counter-cssText-expected.txt: ditto
• fast/css/counters/counter-cssText.html: ditto
• fast/css/parse-border-image-repeat-null-crash-expected.txt: ditto
• fast/css/remove-shorthand.html: ditto
• fast/dom/Element/scrollWidth.html: ditto
• fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: ditto
• fast/dom/HTMLProgressElement/progress-element-markup-expected.txt: ditto
• fast/dom/attr-style-too-lazy-expected.txt: ditto
• fast/dom/attr-style-too-lazy.html: ditto
• fast/dom/css-set-property-exception-expected.txt: ditto
• fast/fast/events/ondrop-text-html-expected.txt: ditto
• fast/mutation/observe-attributes-expected.txt: ditto
• fast/mutation/observe-attributes.html: ditto
• inspector/elements/insert-node-expected.txt: ditto
• inspector/styles/styles-update-from-js-expected.txt: ditto
• platform/chromium-win/editing/pasteboard/5780697-2-expected.txt: ditto
• platform/efl/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: ditto
• platform/mac/editing/pasteboard/5761530-1-expected.txt: ditto
• platform/qt/editing/pasteboard/5761530-1-expected.txt: ditto
• platform/qt/editing/pasteboard/5780697-2-expected.txt: ditto
• svg/webarchive/svg-script-subresouces-expected.webarchive: ditto
• webarchive/test-link-rel-icon-beforeload-expected.webarchive: ditto

4:56 PM Changeset in webkit [126655] by jchaffraix@webkit.org

• 2 edits
  6 adds
  2 deletes in trunk/LayoutTests

More unreviewed Chromium rebaselining.

• fast/repaint/bugzilla-6473-expected.txt: Added.
• platform/chromium-linux/fast/repaint/bugzilla-6473-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/bugzilla-6473-expected.png: Added.
• platform/chromium-mac/fast/repaint/bugzilla-6473-expected.png: Added.
• platform/chromium-win/fast/repaint/bugzilla-6473-expected.png: Added.
• platform/chromium-win/fast/repaint/bugzilla-6473-expected.txt: Added.
• platform/efl/fast/repaint/bugzilla-6473-expected.txt: Removed.
• platform/gtk/fast/repaint/bugzilla-6473-expected.txt: Removed.

Rebaseline this test as it was deflaked by Simon in r79661. The new baseline
matches Mac and Mitz's expectations (see bug 21536).

• platform/chromium/TestExpectations:

Removed fast/repaint/bugzilla-6473.html now that it's rebaselined.
Removed fast/table/frame-and-rules.html as it hasn't been failing for a week.

4:50 PM Changeset in webkit [126654] by wjmaclean@chromium.org

• 3 edits
  3 adds in trunk

[chromium] WebViewImpl::enableTouchHighlight() should always clear any existing highlight when invoked.
​https://bugs.webkit.org/show_bug.cgi?id=94978

Reviewed by James Robinson.

Modified WebViewImpl::enableTouchHighlight() so it always clears any existing highlight, even if no new
highlight target is found.

Source/WebKit/chromium:

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enableTouchHighlight):

LayoutTests:

• platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: Added.
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.png: Added.
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.txt: Added.

4:50 PM Changeset in webkit [126653] by piman@chromium.org

• 1 edit in branches/chromium/1229/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp

Reverting change in test file that broke the build

4:47 PM Changeset in webkit [126652] by jamesr@google.com

• 23 edits
  2 copies
  1 delete in trunk

[chromium] Convert WebLayerTreeView interface into pure virtual
​https://bugs.webkit.org/show_bug.cgi?id=94866

Reviewed by Adrienne Walker.

Source/Platform:

This makes the WebLayerTreeView interface pure virtual to provide better insulation from the implementation.

• chromium/public/WebLayerTreeView.h:

(WebKit):
(Settings):
(WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):

Source/WebCore:

Renames CCLayerTreeHostClient::updateAnimations -> CCLayerTreeHostClient::animate to avoid a naming collision
and to better match the other imperative-sounding calls (like layout).

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateAnimations):

• platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):

Source/WebKit/chromium:

Updates WebLayerTreeView implementation and callers to new interface. The createGraphicsContext3D() wrapper
stuff can just go away now since downstream has updated to createOutputSurface().

• WebKit.gypi:
• src/WebLayerTreeView.cpp: Removed.
• src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::initialize):
(WebKit):
(WebKit::WebLayerTreeViewImpl::setSurfaceReady):
(WebKit::WebLayerTreeViewImpl::setRootLayer):
(WebKit::WebLayerTreeViewImpl::clearRootLayer):
(WebKit::WebLayerTreeViewImpl::compositorIdentifier):
(WebKit::WebLayerTreeViewImpl::setViewportSize):
(WebKit::WebLayerTreeViewImpl::layoutViewportSize):
(WebKit::WebLayerTreeViewImpl::deviceViewportSize):
(WebKit::WebLayerTreeViewImpl::setDeviceScaleFactor):
(WebKit::WebLayerTreeViewImpl::deviceScaleFactor):
(WebKit::WebLayerTreeViewImpl::setBackgroundColor):
(WebKit::WebLayerTreeViewImpl::setHasTransparentBackground):
(WebKit::WebLayerTreeViewImpl::setVisible):
(WebKit::WebLayerTreeViewImpl::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeViewImpl::startPageScaleAnimation):
(WebKit::WebLayerTreeViewImpl::setNeedsAnimate):
(WebKit::WebLayerTreeViewImpl::setNeedsRedraw):
(WebKit::WebLayerTreeViewImpl::commitRequested):
(WebKit::WebLayerTreeViewImpl::composite):
(WebKit::WebLayerTreeViewImpl::updateAnimations):
(WebKit::WebLayerTreeViewImpl::compositeAndReadback):
(WebKit::WebLayerTreeViewImpl::finishAllRendering):
(WebKit::WebLayerTreeViewImpl::renderingStats):
(WebKit::WebLayerTreeViewImpl::setFontAtlas):
(WebKit::WebLayerTreeViewImpl::loseCompositorContext):
(WebKit::WebLayerTreeViewImpl::willBeginFrame):
(WebKit::WebLayerTreeViewImpl::didBeginFrame):
(WebKit::WebLayerTreeViewImpl::animate):
(WebKit::WebLayerTreeViewImpl::layout):
(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
(WebKit::WebLayerTreeViewImpl::createOutputSurface):
(WebKit::WebLayerTreeViewImpl::didRecreateOutputSurface):
(WebKit::WebLayerTreeViewImpl::willCommit):
(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

• src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::renderingStats):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit::WebViewImpl::isInputThrottled):
(WebKit::WebViewImpl::loseCompositorContext):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleCompositingLayerSync):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::setBackgroundColor):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::setVisibilityState):

• src/WebViewImpl.h:

(WebKit):

• tests/CCLayerTreeHostTest.cpp:
• tests/CCThreadedTest.cpp:
• tests/CCThreadedTest.h:

(WebKitTests::TestHooks::animate):

• tests/FakeCCLayerTreeHostClient.h:
• tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(GraphicsLayerChromiumTest):

• tests/WebLayerTest.cpp:
• tests/WebLayerTreeViewTest.cpp:
• tests/WebLayerTreeViewTestCommon.h:

(MockWebLayerTreeViewClient):

Tools:

Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
tests.

• DumpRenderTree/DumpRenderTree.gypi:
• DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):

• DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

• DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.

(WebKit):
(WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
(WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
(WebKit::WebViewHostOutputSurface::bindToClient):
(WebKit::WebViewHostOutputSurface::capabilities):
(WebKit::WebViewHostOutputSurface::context3D):
(WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):

• DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.

(WebKit):
(WebViewHostOutputSurface):

4:36 PM Changeset in webkit [126651] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-24

• DEPS:

4:25 PM Changeset in webkit [126650] by jamesr@google.com

• 13 edits
  2 deletes in trunk/Source

[chromium] Clean up WebAnimation animationId/groupId generation
​https://bugs.webkit.org/show_bug.cgi?id=94973

Reviewed by Adrienne Walker.

Source/Platform:

This removes the unused groupId from the public interface and makes the implicit animation id generation a bit
clearer.

• chromium/public/WebAnimation.h:

(WebAnimation):

Source/WebCore:

This gets rid of AnimationIdVendor and simplifies GraphicsLayerChromium's name<->id mapping. We only have to
track the IDs of animations that we have started and can let WebAnimation generate new IDs if we haven't seen
the name before.

• WebCore.gypi:
• platform/graphics/chromium/AnimationIdVendor.cpp: Removed.
• platform/graphics/chromium/AnimationIdVendor.h: Removed.
• platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::createWebAnimation):

• platform/graphics/chromium/AnimationTranslationUtil.h:

(WebCore):

• platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):

• platform/graphics/chromium/GraphicsLayerChromium.h:

Source/WebKit/chromium:

• src/WebAnimationImpl.cpp:

(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::WebAnimationImpl):
(WebKit::WebAnimationImpl::id):
(WebKit):

• src/WebAnimationImpl.h:

(WebAnimationImpl):

• tests/AnimationTranslationUtilTest.cpp:

(WebKit::animationCanBeTranslated):

• tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

4:23 PM Changeset in webkit [126649] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 125631
BUG=124924
Review URL: ​https://chromiumcodereview.appspot.com/10869059

4:18 PM Changeset in webkit [126648] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Populate DatabaseTracker's origins lazily on demand
​https://bugs.webkit.org/show_bug.cgi?id=94649

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-08-24
Reviewed by Brady Eidson.

Previously, we would populate m_quotaMap on startup when initialializing DatabaseTracker.
This takes a significant amount of time and memory and it is not needed in many cases.

This patch change DatabaseTracker to invoke populateOrigins() only when needed.
This saves:
-7-15ms on startup.
-96Kbytes of SQLite page cache
-the size of m_quotaMap on that particular system.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::hasEntryForOriginNoLock):
(WebCore::DatabaseTracker::populateOriginsIfNeeded):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::quotaForOriginNoLock):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):

• Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

4:08 PM Changeset in webkit [126647] by pilgrim@chromium.org

• 5 edits in trunk/Source

[Chromium] Remove visitedLinkHash from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=94965

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

• platform/chromium/LinkHashChromium.cpp:

(WebCore):
(WebCore::visitedLinkHash):

• platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

• src/PlatformSupport.cpp:

(WebCore):

4:07 PM Changeset in webkit [126646] by cevans@google.com

• 2 edits in branches/chromium/1180/Source/WebCore/platform/network/chromium

Merge 124682
BUG=136881
Review URL: ​https://chromiumcodereview.appspot.com/10868088

4:06 PM Changeset in webkit [126645] by scheib@chromium.org

• 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderWidget.cpp

Merge 126042 - [chromium] pepper plugins sometimes are shifted by 1 pixel
​https://bugs.webkit.org/show_bug.cgi?id=94257

Patch by Yuzhu Shen <​yzshen@chromium.com> on 2012-08-20
Reviewed by Levi Weintraub.

Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
(when converting from FloatRect to IntRect).

This makes sure that the optimized rendering code path of Pepper plugin
(PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
code path.

No new tests because we don't have Pepper plugin tests in WebKit.

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10867067

4:06 PM Changeset in webkit [126644] by jchaffraix@webkit.org

• 1 edit
  1 add in trunk/LayoutTests

Unreviewed rebaseline after r126622.

• platform/chromium-mac-snowleopard/fast/repaint/delete-into-nested-block-expected.png: Added.

4:04 PM WebKit Team edited by victor@rosedu.org

Added myself to the committers list (diff)

4:02 PM Changeset in webkit [126643] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[chromium] Reduce padding on popup menu entries when used on a touch screen.
​https://bugs.webkit.org/show_bug.cgi?id=94953

Patch by Kevin Ellis <​kevers@chromium.org> on 2012-08-24
Reviewed by Adam Barth.

Prior to the patch, the height of entries in a popup menu was 44px,
which is excessive. Reduced the padding to make the menu entries
30px tall to match the wrench menu.

No new tests required.

• platform/chromium/PopupMenuChromium.cpp:

(WebCore):

4:02 PM Changeset in webkit [126642] by cevans@google.com

• 3 edits
  2 copies in branches/chromium/1180

Merge 124645
BUG=139240

3:57 PM Changeset in webkit [126641] by cevans@google.com

• 1 edit in branches/chromium/1180/Source/WebCore/rendering/RenderBlock.cpp

Merge 124580
BUG=136116
Review URL: ​https://chromiumcodereview.appspot.com/10867066

3:54 PM Changeset in webkit [126640] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1180

Merge 124564
BUG=136116
Review URL: ​https://chromiumcodereview.appspot.com/10880056

3:53 PM Changeset in webkit [126639] by timothy@apple.com

• 1 delete in tags/Safari-536.26.10

Removing bad tag.

3:49 PM Changeset in webkit [126638] by timothy@apple.com

• 1 copy in tags/Safari-536.26.10

New tag.

3:38 PM Changeset in webkit [126637] by fpizlo@apple.com

• 2 edits
  3 adds in trunk/LayoutTests

We should have tests for the DFG CFA's handling of structure clobbering and basic blocks
​https://bugs.webkit.org/show_bug.cgi?id=94977

Reviewed by Mark Hahnenberg.

• fast/js/dfg-multi-basic-block-structure-clobber-expected.txt: Added.
• fast/js/dfg-multi-basic-block-structure-clobber.html: Added.
• fast/js/script-tests/dfg-multi-basic-block-structure-clobber.js: Added.

(bar):
(foo):

• fast/js/jsc-test-list:

3:37 PM Changeset in webkit [126636] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web pages are zoomed out to much on initial load
​https://bugs.webkit.org/show_bug.cgi?id=94830

The previous patch caused a slight regression to the calculation we do
for the default splitting factor in the render queue. The default value
we use to represent the max area should be the tile size. This was true
with the old calculation of default max layout width since it was the
screen size. The fix is to be explicit and use the tile size directly.

Patch by Adam Treat <​atreat@rim.com> on 2012-08-24
Reviewed by George Staikos.

• WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::splittingFactor):

3:30 PM Changeset in webkit [126635] by commit-queue@webkit.org

• 11 edits in trunk/Source/WebCore

[Texmap] Move TextureMapperGL to use GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=78672

Patch by Helder Correia <Helder Correia>, Roland Takacs <​rtakacs@inf.u-szeged.hu> on 2012-08-24
Reviewed by Noam Rosenthal.

This is part of a several patch-refactoring.

Introduce additional logic in GraphicsContext3DQt to support a
new RenderToCurrentGLContext RenderStyle. This is necessary to
use GC3D for other things than WebGL, like TextureMapper.

The GC3D constructor now accepts a RenderStyle instead of the
boolean renderDirectlyToHostWindow and thus mimics create()'s
signature. This has been changed for all ports in this patch.

A new GC3D::createForCurrentGLContext() builder was
introduced to better abstract the goal of using GC3D with the
current context.

The patch was originally developed by Helder Correia and finished
by Roland Takacs.

No new tests, refactoring.

3:24 PM Changeset in webkit [126634] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 125503
BUG=121347
Review URL: ​https://chromiumcodereview.appspot.com/10869057

3:22 PM Changeset in webkit [126633] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1180

Merge 125503
BUG=121347
Review URL: ​https://chromiumcodereview.appspot.com/10883035

3:16 PM Changeset in webkit [126632] by cevans@google.com

• 15 edits
  4 copies in branches/chromium/1180

Merge 124556
BUG=134897
Review URL: ​https://chromiumcodereview.appspot.com/10871074

3:15 PM Changeset in webkit [126631] by commit-queue@webkit.org

• 6 edits
  3 deletes in trunk/Source

Unreviewed, rolling out r126620.
​http://trac.webkit.org/changeset/126620
​https://bugs.webkit.org/show_bug.cgi?id=94976

ASSERT((intptr_t)m_bytesAllocated + deltaBytes > 0) is
triggering on the bots (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-24

Source/WebCore:

• WebCore.gypi:
• platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::contextAcquired):

• platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

• platform/graphics/chromium/Canvas2DLayerManager.cpp: Removed.
• platform/graphics/chromium/Canvas2DLayerManager.h: Removed.

Source/WebKit/chromium:

• WebKit.gypi:
• tests/Canvas2DLayerManagerTest.cpp: Removed.

3:08 PM Changeset in webkit [126630] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 125810
BUG=140495
Review URL: ​https://chromiumcodereview.appspot.com/10869055

3:07 PM Changeset in webkit [126629] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1180

Merge 125810
BUG=140495
Review URL: ​https://chromiumcodereview.appspot.com/10871072

3:05 PM Changeset in webkit [126628] by wangxianzhu@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium-Android] Reapply "Upstream layout test expectations (Part 1)"
​https://bugs.webkit.org/show_bug.cgi?id=94884

Reviewed by Adam Barth.

This part include:

• Removed ANDROID tag for passing tests and tests that should be covered by other Android specific rules
• Added android rules for fast/js and jquery/ tests
• crbug.com/144536
• Several other rules with public bugs

• platform/chromium/TestExpectations:

2:46 PM Changeset in webkit [126627] by rniwa@webkit.org

• 21 edits
  2 moves
  5 adds in trunk

[CSSRegions]Expose WebKitNamedFlowCollection interface through document.getNamedFlows()
​https://bugs.webkit.org/show_bug.cgi?id=93368

Patch by Andrei Onea <​onea@adobe.com> on 2012-08-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

The WebKitNamedFlowCollection already implemented was being used by Document to store all
the named flows - regardless of state - so we need to use another class to expose to JS.
WebKitNamedFlowCollection was renamed to NamedFlowCollection since it is used only internally,
and the C++ class used to expose to JS is DOMNamedFlowCollection (with the interface name
WebKitNamedFlowCollection). DOMNamedFlowCollection is exposed via Document::webKitGetFlows(),
and it itself exposes the length property, the indexed getter, and the named getter.
​http://dev.w3.org/csswg/css3-regions/#document-getnamedflows

Test: fast/regions/webkit-named-flow-collection.html

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• bindings/gobject/GNUmakefile.am:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
We need to use same trick as with HTMLPropertiesCollection, to make NamedGetter generate required code.

• dom/DOMAllInOne.cpp:
• dom/DOMNamedFlowCollection.cpp:

(WebCore):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowCollection):
(WebCore::DOMNamedFlowCollection::length):
(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):
(WebCore::DOMNamedFlowCollection::hasNamedItem):

• dom/DOMNamedFlowCollection.h:

(WebCore):
(DOMNamedFlowCollection):
(WebCore::DOMNamedFlowCollection::create):

• dom/DOMNamedFlowCollection.idl:
• dom/Document.cpp:

(WebCore):
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::namedFlows):

• dom/Document.h:

(WebCore):
(Document):

• dom/Document.idl:
• dom/NamedFlowCollection.cpp:

Renamed from Source/WebCore/dom/WebKitNamedFlowCollection.cpp.
(WebCore):
(WebCore::NamedFlowCollection::NamedFlowCollection):
(WebCore::NamedFlowCollection::namedFlows):
(WebCore::NamedFlowCollection::flowByName):
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
(WebCore::NamedFlowCollection::documentDestroyed):
(WebCore::NamedFlowCollection::createCSSOMSnapshot):
Used to create a snapshot of current named flows in CREATED state.

• dom/NamedFlowCollection.h:

Renamed from Source/WebCore/dom/WebKitNamedFlowCollection.h.
(WebCore):
(NamedFlowCollection):
(WebCore::NamedFlowCollection::create):
(WebCore::NamedFlowCollection::document):
(WebCore::NamedFlowCollection::~NamedFlowCollection):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::hash):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::equal):
(NamedFlowCollection::NamedFlowHashFunctions):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::hash):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::equal):
Moved NamedFlowHashFunctions and NamedFlowHashTranslator definitions to .h
and made them public, so they can be used in DOMNamedFlow as well.

• dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::create):

• dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):

• inspector/InspectorCSSAgent.cpp:
• rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):

LayoutTests:

Added test for WebKitNamedFlowCollection interface.

• fast/regions/webkit-named-flow-collection-expected.txt: Added.
• fast/regions/webkit-named-flow-collection.html: Added.

2:39 PM Changeset in webkit [126626] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Skipping svg/custom/getBBox-path.svg on platform mac.
​https://bugs.webkit.org/show_bug.cgi?id=94971.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-08-24
Reviewed by Sam Weinig.

• platform/mac/Skipped:

2:37 PM Changeset in webkit [126625] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

[CSS Shaders] [ANGLE] RenameFunction::RenameFunction may store references to temporary string
​https://bugs.webkit.org/show_bug.cgi?id=94736
​http://code.google.com/p/angleproject/issues/detail?id=360

Patch by Joshua Netterfield <​jnetterfield@rim.com> on 2012-08-24
Reviewed by George Staikos.

When RenameFunction::RenameFunction(const TString& oldFunctionName, const TString&
newFunctionName) is called from TCompiler::rewriteCSSShader(TIntermNode*), references to
the temporaries oldFunctionName and newFunctionName are stored as mOldFunctionName and
mNewFunctionName. This results in undefined behaviour in visitAggregate.

This same patch is being applied in upstream ANGLE, and is needed for CSS Shader
sanitization.

• src/compiler/RenameFunction.h:

(RenameFunction::visitAggregate):
(RenameFunction):

2:23 PM Changeset in webkit [126624] by oliver@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Always null check cells before marking
​https://bugs.webkit.org/show_bug.cgi?id=94968

Reviewed by Geoffrey Garen.

Originally we tried to minimise null checks by only null checking values
that we knew could be null, however given that we can't ever guarantee
when a GC will happen, we're better off just always assuming that a null
check will be necessary. This results in a much less fragile code base
as we can add GC allocations to object initialisers without having to
subsequently worry about whether the object we are initialising will need
to add a bunch of null checks in its visitChildren implementation.

• heap/MarkStack.cpp:

(JSC::MarkStack::internalAppend):

• heap/MarkStackInlineMethods.h:

(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):

• runtime/Structure.h:

(JSC::MarkStack::internalAppend):

2:23 PM Changeset in webkit [126623] by piman@chromium.org

• 3 edits in branches/chromium/1229/Source

Merge 126540 - [chromium] Fix lost context when textures are evicted
​https://bugs.webkit.org/show_bug.cgi?id=94892

Reviewed by James Robinson.

After eviction, the CCPrioritizedTextureManager is in a limbo state
where all its resources are invalid. If we try to release them we will
double-destroy them.

New test: CCLayerTreeHostTestLostContextAfterEvictTextures.

Source/WebCore:

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

• tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestLostContextAfterEvictTextures):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest):
(EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest):
(WTF):
(WTF::TEST_F):

TBR=​piman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10883032

2:05 PM Changeset in webkit [126622] by jchaffraix@webkit.org

• 3 edits
  48 adds in trunk/LayoutTests

Unreviewed Chromium gardening.

Rebaselined a bunch of repaint tests on Mac. The failures or differences fell in
the following categories:

• small alpha difference on the repaint tests' background. This issue has been known for

some time now but is not being worked on AFAICT.

• Chromium unions the invalidation rects when Mac doesn't.
• font difference.

• platform/chromium-mac-snowleopard/fast/repaint/box-shadow-dynamic-expected.png: Added.
• platform/chromium-mac/fast/repaint/box-shadow-dynamic-expected.png: Added.

This test was using Mac's expectation which is wrong (they have some beige rectangles that
are not in the page). Those new baselines matches the other ports and the expected result.

• platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/border-fit-lines-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/border-repaint-glitch-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/bugzilla-3509-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/bugzilla-6388-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/bugzilla-7235-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/change-transform-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/containing-block-position-change-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/float-move-during-layout-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/inline-color-change-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/layout-state-relative-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/outline-shrinking-expected.png: Added.
• platform/chromium-mac/fast/repaint/4774354-expected.png: Added.
• platform/chromium-mac/fast/repaint/4776765-expected.png: Added.
• platform/chromium-mac/fast/repaint/block-selection-gap-in-table-cell-expected.png: Added.
• platform/chromium-mac/fast/repaint/border-fit-lines-expected.png: Added.
• platform/chromium-mac/fast/repaint/border-repaint-glitch-expected.png: Added.
• platform/chromium-mac/fast/repaint/bugzilla-3509-expected.png: Added.
• platform/chromium-mac/fast/repaint/bugzilla-6388-expected.png: Added.
• platform/chromium-mac/fast/repaint/bugzilla-7235-expected.png: Added.
• platform/chromium-mac/fast/repaint/button-spurious-layout-hint-expected.png: Added.
• platform/chromium-mac/fast/repaint/change-transform-expected.png: Added.
• platform/chromium-mac/fast/repaint/clip-with-layout-delta-expected.png: Added.
• platform/chromium-mac/fast/repaint/containing-block-position-change-expected.png: Added.
• platform/chromium-mac/fast/repaint/delete-into-nested-block-expected.png:
• platform/chromium-mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
• platform/chromium-mac/fast/repaint/erase-overflow-expected.png: Added.
• platform/chromium-mac/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
• platform/chromium-mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
• platform/chromium-mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
• platform/chromium-mac/fast/repaint/fixed-move-after-scroll-expected.png: Added.
• platform/chromium-mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
• platform/chromium-mac/fast/repaint/float-move-during-layout-expected.png: Added.
• platform/chromium-mac/fast/repaint/inline-block-resize-expected.png: Added.
• platform/chromium-mac/fast/repaint/inline-color-change-expected.png: Added.
• platform/chromium-mac/fast/repaint/inline-overflow-expected.png: Added.
• platform/chromium-mac/fast/repaint/layer-full-repaint-expected.png: Added.
• platform/chromium-mac/fast/repaint/layer-hide-when-needs-layout-expected.png: Added.
• platform/chromium-mac/fast/repaint/layer-visibility-expected.png: Added.
• platform/chromium-mac/fast/repaint/layout-state-relative-expected.png: Added.
• platform/chromium-mac/fast/repaint/outline-shrinking-expected.png: Added.
• platform/chromium/TestExpectations:

1:51 PM Changeset in webkit [126621] by cevans@google.com

• 5 edits in trunk

Source/WebCore: Update comment regarding root node handling in XPath for detached trees.
​https://bugs.webkit.org/show_bug.cgi?id=36427

Reviewed by Alexey Proskuryakov.

• xml/XPathPath.cpp:

(WebCore::XPath::LocationPath::evaluate): Update XPath root node comment.

LayoutTests: Improve xpath-detached-nodes.html test.
​https://bugs.webkit.org/show_bug.cgi?id=36427

Reviewed by Alexey Proskuryakov.

• fast/xpath/xpath-detached-nodes-expected.txt:
• fast/xpath/xpath-detached-nodes.html: Increase coverage and improve log messages.

1:47 PM Changeset in webkit [126620] by commit-queue@webkit.org

• 6 edits
  3 adds in trunk/Source

[Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
​https://bugs.webkit.org/show_bug.cgi?id=94386

Patch by Justin Novosad <​junov@chromium.org> on 2012-08-24
Reviewed by Stephen White.

Source/WebCore:

Before this change, there was no global bound on memory that could be
consumed for the purpose of recording 2d canvas deferred draw commands.
There was only a per canvas limit. It is possible for canvases to get
dereferenced without flushing pending draw commands, which may lock
resources until the canvas element is garbage collected. This makes
it possible to grow memory consumption indefinitely by hitting reload
successively on some canvas-intensive web pages.

The solution implemented in this change consists in maintaining a
global registry of deferred canvas layers and tracking the sum of
memory allocated by all canvases for the purpose of storing deferred
draw commands. When memory consumption reaches the allowed limit,
caches are cleared and draw operations are flushed on one or several
canvases, starting with the least recently used, until memory
consumption is below a target level.

New tests: webkit_unit_tests DeferredLayerManagerTest*

• WebCore.gypi:
• platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
Overloaded from SkDeferredCanvas::NotificationClient. Called when
there is a change in the number of bytes allocated by the deferred
canvas.
(WebCore):
(WebCore::Canvas2DLayerBridge::flushedDrawCommands):
Overloaded from SkDeferredCanvas::NotificationClient. Called when
pending draw commands are flush by the deferred canvas.
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
Called by the Canvas2DLayerManager to request the release of unlocked
memory resources (caches). Request is relayed to SkDeferredCanvas.
returns number of bytes freed.
(WebCore::Canvas2DLayerBridge::flush):
Requests that pending draw commands be flushed immediately from the
deferred canvas queue. Request is relayed to SkDeferredCanvas.
(WebCore::Canvas2DLayerBridge::contextAcquired):

• platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::bytesAllocated):
(WebCore::Canvas2DLayerBridge::updateBytesAllocated):

• platform/graphics/chromium/Canvas2DLayerManager.cpp: Added.

(WebCore):
(WebCore::Canvas2DLayerManager::Canvas2DLayerManager):
(WebCore::Canvas2DLayerManager::~Canvas2DLayerManager):
(WebCore::Canvas2DLayerManager::init):
Sets the global limit for the maximum total number of bytes allocated
by deferred layers.
(WebCore::Canvas2DLayerManager::get):
Singleton accessor
(WebCore::Canvas2DLayerManager::layerDidDraw):
Called by Canvas2DLayerBridge to indicate that the layer was drawn to.
(WebCore::Canvas2DLayerManager::addLayerToList):
(WebCore::Canvas2DLayerManager::layerAllocatedStorageChanged):
Called by Canvas2DLayerBridge to indicate thet the memory consumed by
the layer has changed.
(WebCore::Canvas2DLayerManager::layerDidFlush):
Called by Canvas2DLayerBridge to indicated that the pending draw
commands of the layer were flushed.
(WebCore::Canvas2DLayerManager::layerToBeDestroyed):
Called by Canvas2DLayerBridge upon destruction.
(WebCore::Canvas2DLayerManager::freeMemoryIfNecessary):
Called internally. Check that current memory consumption is below
the tolerated limit. If check fails, intiates resource releases.
(WebCore::Canvas2DLayerManager::removeLayerFromList):
(WebCore::Canvas2DLayerManager::isInList):
(WebCore::Canvas2DLayerManager::updateBytesAllocated):

• platform/graphics/chromium/Canvas2DLayerManager.h: Added.

(WebCore):
(Canvas2DLayerManager):

Source/WebKit/chromium:

Adding unit tests for WebCore::Canvas2DLayerManager

• WebKit.gypi:
• tests/Canvas2DLayerManagerTest.cpp: Added.

(FakeCanvas2DLayerBridge):
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
(FakeCanvas2DLayerBridge::fakeFreeableBytes):
(Canvas2DLayerManagerTest):
(Canvas2DLayerManagerTest::storageAllocationTrackingTest):
(Canvas2DLayerManagerTest::evictionTest):
(Canvas2DLayerManagerTest::flushEvictionTest):

1:27 PM Changeset in webkit [126619] by jhoneycutt@apple.com

• 1 edit
  5 adds
  1 delete in branches/safari-536.26-branch/LayoutTests

2012-08-24 Mark Lam <​mark.lam@apple.com>

Re-merge test expectations from r126219. Fixes previous bad merge.
Patch by Mark Lam. Unreviewed.

• platform/mac-lion/platform/mac: Added.
• platform/mac-lion/platform/mac-lion: Removed.
• platform/mac-lion/platform/mac-lion/platform: Removed.
• platform/mac-lion/platform/mac-lion/platform/mac: Removed.
• platform/mac-lion/platform/mac-lion/platform/mac/fast: Removed.
• platform/mac-lion/platform/mac-lion/platform/mac/fast/text: Removed.
• platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Removed.
• platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Removed.
• platform/mac-lion/platform/mac/fast: Added.
• platform/mac-lion/platform/mac/fast/text: Added.
• platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
• platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.

1:22 PM Changeset in webkit [126618] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Unreviewed, rolling out r126606.
​http://trac.webkit.org/changeset/126606
​https://bugs.webkit.org/show_bug.cgi?id=94970

The change broke TestExpectations.txt (Requested by jchaffraix
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-24

• platform/chromium/TestExpectations:

1:21 PM Changeset in webkit [126617] by commit-queue@webkit.org

• 5 edits in trunk/Source

[BlackBerry] Changes resulting from moving network related methods
from platform client to platform settings.
​https://bugs.webkit.org/show_bug.cgi?id=94963

Patch by Parth Patel <​parpatel@rim.com> on 2012-08-24
Reviewed by Yong Li.

Changes in response to Network methods moved from
class BlackBerryPlatformClient to class BlackBerryPlatformSettings
in platform repository.

Source/WebCore:

No new tests as there are no logical modifications.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::storeCredentials):

• platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

Source/WebKit/blackberry:

• WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::cachePage):

1:19 PM Changeset in webkit [126616] by senorblanco@chromium.org

• 3 edits
  1 add in trunk/Source/WebCore

Enable accelerated Skia implementation of feBlend filter.
​https://bugs.webkit.org/show_bug.cgi?id=94954

Reviewed by James Robinson.

Will be covered by existing tests in svg/ when tests are run with
accelerated painting.

• WebCore.gypi:
• platform/graphics/filters/FEBlend.h:

(FEBlend):

• platform/graphics/filters/skia/FEBlendSkia.cpp: Added.

(WebCore):
(WebCore::toSkiaMode):
(WebCore::FEBlend::platformApplySkia):

12:55 PM Changeset in webkit [126615] by rjkroege@chromium.org

• 2 edits in trunk/Source/WebCore

[chromium] CCLayerTreeHostImpl::scrollBy always assumes screen space deltas
​https://bugs.webkit.org/show_bug.cgi?id=94946

Reviewed by James Robinson.

Multiply scrollBy deltas in CCLayerTreeHostImpl to correctly support
scrolling on devices that send deltas in DIP (as opposed to screen)
space. Change is a nop on platforms that have not setDeviceScaleFactor
to a non-unity value.

Tested by existing unit tests.

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollBy):

12:44 PM Changeset in webkit [126614] by kareng@chromium.org

• 1 edit in branches/chromium/1180/Source/WebCore/rendering/RenderWidget.cpp

Merge 126042 - [chromium] pepper plugins sometimes are shifted by 1 pixel
​https://bugs.webkit.org/show_bug.cgi?id=94257

Patch by Yuzhu Shen <​yzshen@chromium.com> on 2012-08-20
Reviewed by Levi Weintraub.

Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
(when converting from FloatRect to IntRect).

This makes sure that the optimized rendering code path of Pepper plugin
(PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
code path.

No new tests because we don't have Pepper plugin tests in WebKit.

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10870077

12:37 PM Changeset in webkit [126613] by oliver@apple.com

• 4 edits
  5 adds in trunk/Source/JavaScriptCore

Autogenerate Opcode definitions
​https://bugs.webkit.org/show_bug.cgi?id=94840

Reviewed by Gavin Barraclough.

Start the process of autogenerating the code emission for the bytecode.
We'll just start with automatic generation of the list of Opcodes as that
requires the actual definition of the opcodes, and the logic for parsing
them.

Due to some rather annoying dependency cycles, this initial version has
the OpcodeDefinitions.h file checked into the tree, although with some
work I hope to be able to fix that.

• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/Opcode.h: Include OpcodeDefinitions.h as our definitive source of info about the opcodes.
• bytecode/OpcodeDefinitions.h: Added. Autogenerated file
• bytecode/opcodes: Added. The new opcode definition file
• opcode_definition_generator.py: Added.

(generateOpcodeDefinition):
(generate):

Module that generates the content for OpcodeDefinitions.h

• opcode_generator.py: Added.

(printUsage):
(main):

Driver script

• opcode_parser.py: Added. Simple parser for the opcode definitions.

12:19 PM Changeset in webkit [126612] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Debug assertion fires in BackingStorePrivate::renderJob()
​https://bugs.webkit.org/show_bug.cgi?id=94960

Patch by Liam Quinn <​lquinn@rim.com> on 2012-08-24
Reviewed by Adam Treat.

Change the assertion into an early return as recommended by Adam Treat.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderJob):

12:17 PM Changeset in webkit [126611] by commit-queue@webkit.org

• 4 edits
  3 adds in trunk

webkit-image-set() function not showing up when computing background property
​https://bugs.webkit.org/show_bug.cgi?id=94536

Patch by Anish Bhayani <​anish.bhayani@gmail.com> on 2012-08-24
Reviewed by Simon Fraser.

Source/WebCore:

Added isBaseValueList() to ensure ImageSetClass is not displaying shorthand notation.
Tests to make sure background shows '-webkit-image-set('.

Test: fast/css/image-set-setting.html

• css/CSSValue.h:

(CSSValue):
(WebCore::CSSValue::isBaseValueList):

• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

LayoutTests:

Used same tests from image-set-parsing to show consistency between CSS background
value and backgroundImage value when setting -webkit-image-set(...).

• fast/css/image-set-setting-expected.txt: Added.
• fast/css/image-set-setting.html: Added.
• fast/css/script-tests/image-set-setting.js: Added.

(testComputedStyle):
(testImageSetRule):

12:15 PM Changeset in webkit [126610] by tony@chromium.org

• 3 edits in trunk/Source/WebCore

Remove unnecessary CSS selector text generation
​https://bugs.webkit.org/show_bug.cgi?id=94857

Reviewed by Ojan Vafai.

When setting the selector text, there was some old code that would
check to see if it was unchanged. That got removed, but the code
to generate the previous selector text is still there.

Covered by fast/css/css-set-selector-text.html and
fast/css/css-set-selector-text-crash.html.

• css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText): Remove unused oldSelectorText.

• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText): Remove unused oldSelectorText
and rather than update the cache, just invalidate the previous entry since
we may not need the new selector text.

12:01 PM Changeset in webkit [126609] by cdn@chromium.org

• 7 edits in trunk/Source

Source/WebCore: Add support for consumable user gestures
​https://bugs.webkit.org/show_bug.cgi?id=94867

Reviewed by Adam Barth.

Adds a static counter of the number of consumable gestures. This is decremented either when
a gestures falls out of scope or is consumed via a call to consumeUserGesture().

Planned usage in Chromium is to prevent the piggybacking of multiple popup windows on a
single user gesture.

No new tests as this should not change behavior. The platform must implement consumable
gestures for this to do anything.

• bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::consumeUserGesture):
(WebCore):

• bindings/v8/ScriptController.h:

(ScriptController):

• dom/UserGestureIndicator.cpp:

(WebCore):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
(WebCore::UserGestureIndicator::consumeUserGesture):

• dom/UserGestureIndicator.h:

(WebCore::UserGestureIndicator::processingUserGesture):
(UserGestureIndicator):

Source/WebKit/chromium: Plumb consumeUserGesture() to the chromium platform layer.
​https://bugs.webkit.org/show_bug.cgi?id=9475294867

Reviewed by Adam Barth.

• public/WebFrame.h:

(WebFrame):

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::consumeUserGesture):
(WebKit):

• src/WebFrameImpl.h:

(WebFrameImpl):

11:59 AM Changeset in webkit [126608] by wjmaclean@chromium.org

• 3 edits
  3 adds in trunk

[chromium] gestureTapDown should not select a RenderView node as target.
​https://bugs.webkit.org/show_bug.cgi?id=94956

Reviewed by James Robinson.

Add check to prevent selecting a RenderView node as a highlight target.

Source/WebKit/chromium:

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

• platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html: Added.
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background-expected.png: Added.
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background-expected.txt: Added.

11:55 AM Changeset in webkit [126607] by wangxianzhu@chromium.org

• 3 edits in trunk/Tools

[Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
​https://bugs.webkit.org/show_bug.cgi?id=94865

Reviewed by Dirk Pranke.

Android detects crash of test by checking if the return value of read() is None.
Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
If set, ServerProcess will set _crashed unconditionaly when there is no data.

• Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort):
(ChromiumAndroidPort._android_server_process_constructor):
(ChromiumAndroidDriver._start_once):

• Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.init):
(ServerProcess._wait_for_data_and_update_buffers_using_select):

11:51 AM Changeset in webkit [126606] by wangxianzhu@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium-Android] Upstream layout test expectations (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=94884

Reviewed by Adam Barth.

This part include:

• Removed ANDROID tag for passing tests and tests that should be covered by other Android specific rules
• Added android rules for fast/js and jquery/ tests
• crbug.com/144536
• Several other rules with public bugs

• platform/chromium/TestExpectations:

11:48 AM Changeset in webkit [126605] by commit-queue@webkit.org

• 12 edits
  13 adds in trunk

[CSS Exclusions] Enable shape-inside for simple rectangles
​https://bugs.webkit.org/show_bug.cgi?id=89259

Patch by Bear Travis <​betravis@adobe.com> on 2012-08-24
Reviewed by Levi Weintraub.

Source/WebCore:

This patch is the first in a series enabling shape-inside. It adds
support for inline layout within a single render block with a
rectangular shape-inside.
Each RenderBlock with a valid shape-inside maintains a WrapShapeInfo,
which can calculate the areas, or LineSegments, where inline content
can flow on a line. The WrapShapeInfo class maintains a static map of
RenderBlocks to WrapShapeInfos. The basic algorithm involves three stages:

1. Determine if the RenderBlock has a valid shape-inside, and store it

in a WrapShapeInfo if necessary.

2. If the inline content is affected by a shape-inside, use the

corresponding WrapShapeInfo to break the content into line segments.

3. Lay out the line segments.

Tests: fast/exclusions/shape-inside/shape-inside-floats-simple.html

fast/exclusions/shape-inside/shape-inside-inline-elements.html
fast/exclusions/shape-inside/shape-inside-overflow.html
fast/exclusions/shape-inside/shape-inside-percentage-auto.html
fast/exclusions/shape-inside/shape-inside-text.html

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed): Remove WrapShapeInfo when destroyed.
(WebCore::RenderBlock::styleDidChange): Detect modifications to style()->wrapShapeInside.
(WebCore):
(WebCore::RenderBlock::updateWrapShapeInfoAfterStyleChange): Update WrapShapeInfo
when style()->wrapShapeInside changes.
(WebCore::RenderBlock::layoutBlock): Notify WrapShapeInfo of changes in logicalWidth
and logicalHeight before laying out inline content.

• rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::wrapShapeInfo): Return the wrapShapeInfo associated with a
RenderBlock.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth): Determine the WrapShapeInfo::LineSegment this LineWidth
corresponds to, if any.
(LineWidth):
(WebCore::LineWidth::updateAvailableWidth): The width's LineSegment boundaries affect
the available width.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): The current LineSegment
affects the left & right positioning of inline boxes.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Move to the top of the inside wrap
shape before beginning inline layout, and update the line segments for each line.

• rendering/WrapShapeInfo.cpp: Added.

(WebCore):
(WebCore::WrapShapeInfo::WrapShapeInfo): Create an empty WrapShapeInfo.
(WebCore::WrapShapeInfo::~WrapShapeInfo): No additional cleanup.
(WebCore::WrapShapeInfo::create): Create a WrapShapeInfo reference.
(WebCore::WrapShapeInfo::ensureWrapShapeInfoForRenderBlock): Create a WrapShapeInfo
for a RenderBlock with an inside WrapShape and place it in the WrapShapeInfo map.
(WebCore::WrapShapeInfo::wrapShapeInfoForRenderBlock): Lookup the WrapShapeInfo for
a RenderBlock in the WrapShapeInfo map.
(WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForBlock): Determine if a RenderBlock
has an inside wrap shape that we can use for inline layout.
(WebCore::WrapShapeInfo::removeWrapShapeInfoForRenderBlock): Remove a RenderBlock's
WrapShapeInfo from the WrapShapeInfo map.
(WebCore::WrapShapeInfo::hasSegments): Returns true if there are any line segments
for the current line.
(WebCore::WrapShapeInfo::computeShapeSize): Compute the dimensions of the wrap shape
based on a block's logical width & height.
(WebCore::WrapShapeInfo::computeSegmentsForLine): Sets the current line and computes
its line segments.

• rendering/WrapShapeInfo.h: Added.

(WebCore):
(LineSegment):
(WrapShapeInfo):
(WebCore::WrapShapeInfo::shapeTop): The top of a wrap shape, where the inline content
area begins.
(WebCore::WrapShapeInfo::segments): The list of line segments for the current line.
(WebCore::WrapShapeInfo::wrapShapeSizeNeedsRecomputing): Mark a WrapShapeInfo as
needing to recompute its WrapShape dimensions.
(WebCore::WrapShapeInfo::lineState): The current line state: above, inside, or below
the wrap shape.

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Changes to shape inside require relayout.

LayoutTests:

Test that inline content correctly wraps for a simple rectangular
shape-inside. Text and inline content should wrap inside the
rectangular shape-inside, and overflow to its containing block.
Inline content inside a shape-inside should also avoid floats.

• fast/exclusions/shape-inside/shape-inside-floats-simple-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-floats-simple.html: Added.
• fast/exclusions/shape-inside/shape-inside-inline-elements-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-inline-elements.html: Added.
• fast/exclusions/shape-inside/shape-inside-overflow-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-overflow.html: Added.
• fast/exclusions/shape-inside/shape-inside-percentage-auto-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-percentage-auto.html: Added.
• fast/exclusions/shape-inside/shape-inside-text-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-text.html: Added.

11:43 AM Changeset in webkit [126604] by jchaffraix@webkit.org

• 2 edits
  16 adds in trunk/LayoutTests

Unreviewed Chromium rebaseline.

• platform/chromium-mac/fast/table/border-collapsing/cached-69296-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-cell-append-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
• platform/chromium-mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
• platform/chromium/TestExpectations:

Rebaselined the border-collapsing tests on Mac. They have required a different baseline for several months
now and the root cause (small alpha difference) doesn't seem to be worked on.

11:00 AM Changeset in webkit [126603] by hyatt@apple.com

• 1 edit in trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp

Fix build bustage on android.

10:49 AM Changeset in webkit [126602] by hyatt@apple.com

• 8 edits in trunk/Source/WebCore

[New Multicolumn] Plumbing to prepare for contents painting and hit testing implementation.
​https://bugs.webkit.org/show_bug.cgi?id=94945

Reviewed by Dan Bernstein.

Make some improvements to how column sets interact with flow threads. Make sure the last column set
always expands to hold all of the remaining flow thread contents (including overflow). Rename the
column height, count and width variables to have "computed" in front of them to indicate that they
just represent what the multi-column algorithm computed so that there is no confusion between the
computed column count and the actual number of columns in the set.

Implement the ability to get the actual column count based off the logical height of the flow thread
portion contained within the column set.

Fix gap painting to use the actual column count rather than the computed column count.

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
After a flow thread is done laying out, have it tell the last region to expand to
encompass all the remaining contents if it wants to do so. Column and page sets will always do this.

• rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):
Override computeLogicalHeight() to do nothing. We want the flow thread to just keep its intrinsic
height, since the last column set is always going to expand to encompass the flow thread's contents
anyway. Unlike CSS Regions, we don't ever "run out of room."

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::computeLogicalWidth):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):
(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::columnRectAt):
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::paintColumnContents):
Rename count, width and height for columns to have "computed" in front of the members and functions.
In particular, this lets us distinguish the computed column count from the actual column count.

• rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::computedColumnCount):
(WebCore::RenderMultiColumnSet::computedColumnWidth):
(WebCore::RenderMultiColumnSet::computedColumnHeight):
(WebCore::RenderMultiColumnSet::setComputedColumnWidthAndCount):
(WebCore::RenderMultiColumnSet::setComputedColumnHeight):
Rename count, width and height for columns to have "computed" in front of the members and functions.
In particular, this lets us distinguish the computed column count from the actual column count.

• rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::expandToEncompassFlowThreadContentsIfNeeded):

• rendering/RenderRegionSet.cpp:

(WebCore::RenderRegionSet::expandToEncompassFlowThreadContentsIfNeeded):
(WebCore):

• rendering/RenderRegionSet.h:

(RenderRegionSet):
Make sure region sets expand to encompass all the remaining flow thread contents. We are always
able to generate more columns or pages, so in effect the amount of the flow thread we can
consume is unlimited.

10:48 AM Changeset in webkit [126601] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Qt] Range input progress indicator is upside down when vertical and RTL is set
​https://bugs.webkit.org/show_bug.cgi?id=94948

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-08-24
Reviewed by Kenneth Rohde Christiansen.

RTL should not affect vertical sliders, but on Qt it was changing the
direction of the progress indicator, making it flow in the opposite
direction of the knob.

• platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::paintSliderTrack):

10:47 AM Changeset in webkit [126600] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding expectations for a few failing tests that popped up on the debug
builder after it was brought back into a working state.

Removing failure expectation for fast/dom/Window/window-postmessage-clone.html
after the test was fixed in r126464.

• platform/gtk/TestExpectations:

10:38 AM Changeset in webkit [126599] by jchaffraix@webkit.org

• 2 edits in trunk/LayoutTests

Unreviewed gardening.

• platform/chromium/TestExpectations:

Marked fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html as failing following r126534.

10:21 AM Changeset in webkit [126598] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Animation & UI lag when rendering
​https://bugs.webkit.org/show_bug.cgi?id=94943

Patch by Andrew Lo <​anlo@rim.com> on 2012-08-24
Reviewed by Rob Buis.

Schedule a backing store blit & composite when commiting root layer.
This results in compositing not having to wait until after a long render
operation, increasing responsiveness & fixing animations which skip to
the last frame due to lag.

This can cause a blit during a "one shot drawing synchronization", which is
a render & commit on the AC layers, which may result in flashing.
However, this can happen in other situations as well, and we feel that
the responsiveness, reduced lag, and smoothness of animations is
more important.

Internal PR194209
Internally reviewed by: George Staikos.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):

10:21 AM Changeset in webkit [126597] by commit-queue@webkit.org

• 2 edits in trunk/Tools

build-webkit --gtk fails with Can't exec ""
​https://bugs.webkit.org/show_bug.cgi?id=94944

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2012-08-24
Reviewed by Martin Robinson.

When jhbuild wrapper is not needed, do unshift a blank string to build
arguments.

• Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):

10:12 AM Changeset in webkit [126596] by commit-queue@webkit.org

• 10 edits in trunk/Source

[BlackBerry] Changes resulting from moving application directory methods from platform client to platform settings.
​https://bugs.webkit.org/show_bug.cgi?id=94249

Patch by Parth Patel <​parpatel@rim.com> on 2012-08-24
Reviewed by Rob Buis.

Source/WebCore:

PR 170160

Changes in response to Application Directory methods moved from
Class BlackBerryPlatformClient to BlackBerryPlatformSettings in
platform respository since these methods are more appropriate in
class BlackBerryPlatformSettings.

No new tests as there are no logical modifications.

• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::CookieManager):

• platform/blackberry/FileSystemBlackBerry.cpp:

(WebCore::homeDirectoryPath):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):

• platform/network/blackberry/AutofillBackingStore.cpp:

(WebCore::autofillBackingStore):

• platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::credentialBackingStore):

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::isPreferredPluginDirectory):

Source/WebKit/blackberry:

PR# 170160
Changes in response to Application Directory methods moved from
Class BlackBerryPlatformClient to BlackBerryPlatformSettings in
platform respository since these methods are more appropriate in
class BlackBerryPlatformSettings.

• WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

10:10 AM Changeset in webkit [126595] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: do not count weak and shortcut edges.
​https://bugs.webkit.org/show_bug.cgi?id=94947

Reviewed by Yury Semikhatsky.

When calculating distance from an object to Window in heap profiler we should only
take into account strong real references. This means that shortcuts and weak edges should be ignored.

• inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._bfs):

9:49 AM Changeset in webkit [126594] by vsevik@chromium.org

• 1 edit in branches/chromium/1180/Source/WebCore/inspector/front-end/HandlerRegistry.js

Merge 125668 - Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
​https://bugs.webkit.org/show_bug.cgi?id=94074

Reviewed by Pavel Feldman.

Added dirty flag check when saving uiSourceCode to save working copy in this case.

• inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

BUG=141180
TBR=​vsevik@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10883027

9:47 AM Changeset in webkit [126593] by commit-queue@webkit.org

• 1 edit
  13 adds in trunk/LayoutTests

[EFL] Add baselines for the tests which are missing expected results
​https://bugs.webkit.org/show_bug.cgi?id=94942

Unreviewed EFL gardening. Add platform specific baselines required
after r126343 and r126372.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-08-24

• platform/efl/fast/overflow/paged-x-div-expected.png: Added.
• platform/efl/fast/overflow/paged-x-div-expected.txt: Added.
• platform/efl/fast/overflow/paged-x-on-root-expected.png: Added.
• platform/efl/fast/overflow/paged-x-on-root-expected.txt: Added.
• platform/efl/fast/overflow/paged-y-div-expected.png: Added.
• platform/efl/fast/overflow/paged-y-div-expected.txt: Added.
• platform/efl/fast/overflow/paged-y-on-root-expected.png: Added.
• platform/efl/fast/overflow/paged-y-on-root-expected.txt: Added.
• platform/efl/media/track/track-cue-rendering-horizontal-expected.png: Added.
• platform/efl/media/track/track-cue-rendering-horizontal-expected.txt: Added.
• platform/efl/media/track/track-cue-rendering-vertical-expected.png: Added.
• platform/efl/media/track/track-cue-rendering-vertical-expected.txt: Added.

9:42 AM Changeset in webkit [126592] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] fast/dom/navigator-vibration.html is failing after r126562
​https://bugs.webkit.org/show_bug.cgi?id=94939

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-08-24
Reviewed by Kentaro Hara.

Update expected results for fast/dom/navigator-vibration.html now that
NotEnoughArguments is thrown instead of TypeError if the actual argument
count is less than the least mandatory argument count.

• fast/dom/navigator-vibration-expected.txt:

9:39 AM Changeset in webkit [126591] by jchaffraix@webkit.org

• 3 edits
  3 adds in trunk

Crash in RenderTableCell::borderTop() due to custom scrollbars after r124168
​https://bugs.webkit.org/show_bug.cgi?id=93903

Reviewed by Tony Chang.

Source/WebCore:

r124168 changed when we create scrollbars so that it happens (rightly) at style change time.
However the RenderScrollbar code assumes that any overflow: scroll RenderScrollbar would be
created at layout time as it directly tries to layout to scrollbar parts. The big issues with
the move is that the first style change operates on a detached renderer which means that we
could crash in some situation.

Test: scrollbars/custom-scrollbar-table-cell.html

• rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
Fixed the crash by using style information instead of calling the renderer. This is guaranteed
to be safe but it also means that custom scrollbars sizing is not right on table cells with
collapsing borders. The existing logic was querying layout information at style change so I
wouldn't bet on it working properly anyway.

LayoutTests:

• scrollbars/custom-scrollbar-table-cell-expected.png: Added.
• scrollbars/custom-scrollbar-table-cell-expected.txt: Added.
• scrollbars/custom-scrollbar-table-cell.html: Added.

9:37 AM Changeset in webkit [126590] by jchaffraix@webkit.org

• 7 edits in trunk/Source/WebCore

Remove RenderTableSection::removeChild
​https://bugs.webkit.org/show_bug.cgi?id=94883

Reviewed by Abhishek Arya.

This change removed removeChild, replaced by willBeRemoved calls in the children
class. This is done to ensure that post-removal invalidations are properly done
in table rows and table cells.

Refactoring covered by existing tests.

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::removeChild):

• rendering/RenderTableSection.h:

Removed this function...

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeRemovedFromTree):

• rendering/RenderTableCell.h:

(RenderTableCell):

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::willBeRemovedFromTree):

• rendering/RenderTableRow.h:

... and moved the invalidation into the willBeRemovedFromTree functions.
The willBeRemovedFromTree replaced the willBeDestroyed functions in the
2 classes as the invalidation really represented tree removal updates,
not death updates.

8:40 AM Changeset in webkit [126589] by apavlov@chromium.org

• 6 edits in trunk/LayoutTests

Web Inspector: Unreviewed, fix test flakiness due to the recently introduced lazy panel loading.

• inspector/debugger/scripts-file-selector.html:
• inspector/debugger/step-through-event-listeners.html:
• inspector/elements/edit-dom-actions.html:
• inspector/elements/edit-style-attribute.html:
• inspector/timeline/timeline-enum-stability.html:

8:30 AM Changeset in webkit [126588] by tonikitoo@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Touch cancel can cause huge and needless invalidations
​https://bugs.webkit.org/show_bug.cgi?id=94938
PR #198051

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>
Internally reviewed by Gen Mak.

In order to remove the possible hover effect on touch_cancel, we always
invalidate the node under the fat finger, being the fat finger valid or not.

Point is: having a valid fat finger node does not mean the original touch
position was actually adjust for clicking or that the fat finger is actually
valid. We set the fat finger node to be the result of the point-based hit-test
regardless if it is a click target or not (in order to make our mouse-move
machinery to work).

We should can less aggressively invalidate the fat finger node, since it can
be rather an expensive call (longer than 1s in the worst scenario).

• WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):

8:12 AM Changeset in webkit [126587] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Extend LayerFilterRenderer in preparation for CSS Shaders
​https://bugs.webkit.org/show_bug.cgi?id=94724

Patch by Joshua Netterfield <​jnetterfield@rim.com> on 2012-08-24
Reviewed by George Staikos.

LayerFilterRenderer defines a CSS Filter in terms of one or more Actions.
A LayerFilterRendererAction holds a vertex shader, a fragment shader, and
zero or more Parameters. A Parameter is a uniform, varying, or other
information which is needed to render a filter.

This patch implements certain new Parameter types, including vertex/element
buffers and vertex attributes which are needed to implement composited
CSS Shaders on BB10. In addition, a new drawing mode is required in order
to draw CSS Shaders meshes from vertex/element buffers.

No new tests, because this patch introduces no new functionality. When
the patch which enables CSS Shaders on BB10 in upstreamed, tests for
CSS Shaders will prove this code to be correct.

• platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::operationTypeToProgramID):
(WebCore::Uniform::Uniform):
(WebCore::Uniform1f::create):
(WebCore::Uniform1f::Uniform1f):
(WebCore):
(WebCore::Uniform1i::apply):
(WebCore::Uniform1i::create):
(WebCore::Uniform1i::Uniform1i):
(WebCore::Uniform2f::create):
(WebCore::Uniform2f::Uniform2f):
(WebCore::Uniform3f::create):
(WebCore::Uniform3f::Uniform3f):
(WebCore::Uniform4f::apply):
(WebCore::Uniform4f::create):
(WebCore::Uniform4f::Uniform4f):
(WebCore::Matrix4fv::apply):
(WebCore::Matrix4fv::create):
(WebCore::Matrix4fv::Matrix4fv):
(WebCore::Matrix4fv::~Matrix4fv):
(WebCore::Buffer::apply):
(WebCore::Buffer::restoreState):
(WebCore::Buffer::create):
(WebCore::Buffer::Buffer):
(WebCore::VertexAttribf::apply):
(WebCore::VertexAttribf::restoreState):
(WebCore::VertexAttribf::create):
(WebCore::VertexAttribf::VertexAttribf):
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::useActionOn):
(WebCore::LayerFilterRendererAction::restoreState):
(WebCore::LayerFilterRenderer::LayerFilterRenderer):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):

• platform/graphics/blackberry/LayerFilterRenderer.h:

(Parameter):
(WebCore::Parameter::restoreState):
(WebCore::Parameter::~Parameter):
(WebCore::Parameter::Parameter):
(WebCore):
(Uniform):
(WebCore::Uniform::~Uniform):
(Uniform1f):
(Uniform1i):
(Uniform2f):
(Uniform3f):
(Uniform4f):
(Matrix4fv):
(Buffer):
(VertexAttribf):
(WebCore::LayerFilterRendererAction::appendParameter):
(LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::drawingMode):
(WebCore::LayerFilterRendererAction::setDrawingMode):
(WebCore::LayerFilterRendererAction::drawingModeParameter):
(WebCore::LayerFilterRendererAction::setDrawingModeParameter):

8:10 AM Changeset in webkit [126586] by tommyw@google.com

• 18 edits
  2 adds in trunk

MediaStream API: Add readyState functionality to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=94813

Reviewed by Adam Barth.

Source/Platform:

• chromium/public/WebRTCPeerConnectionHandler.h:

(WebRTCPeerConnectionHandler):

• chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

This patch adds readyState functionality to RTCPeerConnection together with related callbacks and methods.

Test: fast/mediastream/RTCPeerConnection-state.html

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::readyState):
(WebCore):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didChangeReadyState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeReadyState):

• Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

• Modules/mediastream/RTCPeerConnection.idl:
• platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::stop):
(WebCore):

• platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

• platform/mediastream/RTCPeerConnectionHandlerClient.h:

(RTCPeerConnectionHandlerClient):

• platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::RTCPeerConnectionHandlerChromium):
(WebCore::RTCPeerConnectionHandlerChromium::stop):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeReadyState):

• platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

• src/AssertMatchingEnums.cpp:

Tools:

• DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::stop):

• DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

• fast/mediastream/RTCPeerConnection-state-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-state.html: Added.

7:39 AM Changeset in webkit [126585] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] A follow up to simplify code with nested closures
​https://bugs.webkit.org/show_bug.cgi?id=94931

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-08-24
Reviewed by Pavel Feldman.

Simplifies the code with nested closures.

• inspector/InjectedScriptWebGLModuleSource.js:

(.):

7:05 AM Changeset in webkit [126584] by vsevik@chromium.org

• 6 edits in trunk

Web Inspector: Get rid of frontendReused logic on front-end.
​https://bugs.webkit.org/show_bug.cgi?id=94929

Reviewed by Pavel Feldman.

Source/WebCore:

Removed frontendReused method from ResourceTreeModel.

• inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._frameNavigated):

• inspector/front-end/Workspace.js:

(WebInspector.Workspace): workspace doesn't need to listen for CachedResourcesLoaded event anymore.

• inspector/front-end/inspector.js: removed unused method.

LayoutTests:

• http/tests/inspector/resource-tree/resource-tree-events.html:

7:02 AM Changeset in webkit [126583] by g.czajkowski@samsung.com

• 5 edits
  2 moves
  1 add in trunk/Source/WebCore

Share WebKit-Gtk's Enchant implementation with others WebKit ports.
​https://bugs.webkit.org/show_bug.cgi?id=94320

Reviewed by Carlos Garcia Campos.

The main reason of this change is to share WebKit-Gtk implementation of spelling
with others ports that use the Enchant library.
This is the first step to enable spelling for WebKit-Efl (​https://bugs.webkit.org/show_bug.cgi?id=91854)

Files that implement spelling were moved to platform/text/enchant directory.

This patch stops using Pango backend to find the beginning/end of the word.
Those information are delivered through ICU interface by using TextBreakIterator.

• GNUmakefile.am: Added newly created 'enchant' directory to WebKit-Gtk's sources.
• GNUmakefile.list.am: Updated location of TextCheckerEnchant.{h,cpp} files.

• editing/visible_units.cpp: Removed 'static' modifier for 'isLogicalStartOfWord' and 'islogicalEndOfWord' functions.

(WebCore::isLogicalStartOfWord):
(WebCore::islogicalEndOfWord):

• editing/visible_units.h: Added isLogicalStartOfWord' and 'islogicalEndOfWord' functions to header as they are used by TextCheckerEnchant.cpp

• platform/text/enchant/TextCheckerEnchant.cpp: Renamed from Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp.

(enchantDictDescribeCallback): Added comments.
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString): Using ICU instead of Pango to find out the beginning/end of the word.
(TextCheckerEnchant::getGuessesForWord): Replaced gchar type to char.
(TextCheckerEnchant::updateSpellCheckingLanguages): Using WebCore::defaulLanguage() instead of Pango backend.
(TextCheckerEnchant::getSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):

• platform/text/enchant/TextCheckerEnchant.h: Renamed from Source/WebCore/platform/text/gtk/TextCheckerEnchant.h.

(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):

6:50 AM Changeset in webkit [126582] by abecsi@webkit.org

• 4 edits
  1 add in trunk/Source/WebKit2

[Qt][WK2] Fix custom device pixel ratio propagation and add QML API tests
​https://bugs.webkit.org/show_bug.cgi?id=88531

Reviewed by Kenneth Rohde Christiansen.

Defer setting the custom device pixel ratio until the page item has
a valid size to make sure that the scale factor reaches the web process.

QML test based on patch by Alexander Færøy.

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

• UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml: Added. Test case for the QML device pixel ratio API.

6:46 AM Changeset in webkit [126581] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL] Fix compile warning
​https://bugs.webkit.org/show_bug.cgi?id=94930

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-08-24
Reviewed by Kenneth Rohde Christiansen.

Fixed compile warning.

• UIProcess/API/efl/ewk_back_forward_list.cpp:

(ewk_back_forward_list_n_back_items_copy): NULL used in arithmetic [-Wpointer-arith]
(ewk_back_forward_list_n_forward_items_copy): NULL used in arithmetic [-Wpointer-arith]

6:30 AM Changeset in webkit [126580] by pfeldman@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: do not send profile headers to the front-end until explicitly requested.
​https://bugs.webkit.org/show_bug.cgi?id=94928

Reviewed by Vsevolod Vlasov.

Simple flag is added.

• inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):

• inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

6:25 AM Changeset in webkit [126579] by pfeldman@chromium.org

• 14 edits in trunk

Web Inspector: make ui component compile
​https://bugs.webkit.org/show_bug.cgi?id=94827

Reviewed by Vsevolod Vlasov.

Moved buildImagePreviewContents into the sdk-aware code.
Drive-by more compilation fixes.

• inspector/compile-front-end.py:
• inspector/front-end/DOMPresentationUtils.js:

(WebInspector.DOMPresentationUtils.buildImagePreviewContents.errorCallback):
(WebInspector.DOMPresentationUtils.buildImagePreviewContents.buildContent):
(WebInspector.DOMPresentationUtils.buildImagePreviewContents):

• inspector/front-end/Database.js:
• inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._createLink):

• inspector/front-end/ElementsPanel.js:
• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

• inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.prototype.get displayName):

• inspector/front-end/ResourceUtils.js:
• inspector/front-end/SourceFrame.js:

(WebInspector.TextEditorDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.createLink):

• inspector/front-end/TextEditor.js:

(WebInspector.TextEditorDelegate.prototype.populateTextAreaContextMenu):
(WebInspector.TextEditorDelegate.prototype.createLink):

• inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

• inspector/front-end/UIUtils.js:

6:21 AM Changeset in webkit [126578] by anilsson@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add WebPage API to reset block zoom
​https://bugs.webkit.org/show_bug.cgi?id=94863

PR 187478
This is an alternative to WebPage::blockZoomAnimationFinished() when
it's desirable to avoid rerendering of the whole web page at the end
of block zoom. This is the case when the planned "incremental zoom
factor" is used instead of zoomAboutPoint and it's relatives.

Ideally, the block zoom algorithm would be clever enough not to need
a reset or any form of callback when the animation finishes, but that
requires the implementation of said incremental zoom factor, which is
not done yet.

Reviewed by Antonio Gomes.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::resetBlockZoom):
(WebKit):

• Api/WebPage.h:

6:18 AM Changeset in webkit [126577] by Michael Brüning

• 2 edits in trunk/Tools

Unreviewed. Adding myself to committers list.

Also updated email information.

• Scripts/webkitpy/common/config/committers.py:

6:14 AM Changeset in webkit [126576] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

Not reviewed: fixing inspector/elements/iframe-load-event.html broken by r126572.

• inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.resolveURL):

6:04 AM Changeset in webkit [126575] by abecsi@webkit.org

• 2 edits in trunk/Source/WTF

[Qt] Be more explicit about the ICU dependency in the error message

Rubber-stamped by Simon Hausmann.

When building QtWebKit with a Qt5 which was not configured with libICU support
the error message is somewhat ambiguous about the indirect dependency.

• WTF.pri:

5:57 AM EFLWebKit edited by rafael.lobo@openbossa.org

Adding one more dependency (libffi-dev), required to compile glib-2.33.2 (diff)

5:23 AM Changeset in webkit [126574] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Implement custom wrap functions on GL context
​https://bugs.webkit.org/show_bug.cgi?id=94799

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-08-24
Reviewed by Pavel Feldman.

Implement custom wrap functions on WebGL rendering context for WebGL instrumentation.

• inspector/InjectedScriptWebGLModuleSource.js:

(.):

5:20 AM Changeset in webkit [126573] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

Web Inspector: three layout tests crashing with assertion failure
​https://bugs.webkit.org/show_bug.cgi?id=94829

Not reviewed: updating test expectations.

• platform/chromium/TestExpectations:

5:10 AM Changeset in webkit [126572] by pfeldman@chromium.org

• 19 edits in trunk

Web Inspector: resolve URLs upon creation, get rid of populateHrefContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=94900

Reviewed by Vsevolod Vlasov.

• This change makes sure we resolve URLs upon adding the to the UI. Then we treat them as absolute links in context menu, etc.
• There is no need to override context menu for links anymore - system menu will do.

• inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):

• inspector/front-end/ConsoleView.js:
• inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.descendantUserPropertyCount):
(WebInspector.DOMNode.prototype.resolveURL):

• inspector/front-end/ElementsPanel.js:
• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

• inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems):
(WebInspector.HandlerRegistry.prototype._appendContentProviderItems):
(WebInspector.HandlerRegistry.prototype._appendHrefItems):

• inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.completeURL):

• inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyRequestAsNode):

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

• inspector/front-end/UIUtils.js:

4:47 AM Changeset in webkit [126571] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

[EFL][WK2] Back-forward list API needs extension
​https://bugs.webkit.org/show_bug.cgi?id=94582

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-08-24
Reviewed by Kenneth Rohde Christiansen.

Added several new functions wrapping existing WK2 C back-forward list API
and returning list of items preceding or following the current one.
Corresponding API unit tests are also added.

• UIProcess/API/efl/ewk_back_forward_list.cpp:

(createEinaList):
(ewk_back_forward_list_n_back_items_copy):
(ewk_back_forward_list_n_forward_items_copy):

• UIProcess/API/efl/ewk_back_forward_list.h:
• UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:

(freeEinaList):
(TEST_F):

4:27 AM Changeset in webkit [126570] by Michael Brüning

• 6 edits in trunk

[Qt][WK2] Make viewport related experimental.test properties encapsulated.
​https://bugs.webkit.org/show_bug.cgi?id=88320

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Introducing a new viewport attribute to QWebKitTest to group the viewport related
attributes into one QJsonObject. Also adding a static method to convert a QSizeF to
a QJsonObject.

• UIProcess/API/qt/qwebkittest.cpp:

(qSizeFToJsonObject):
(QWebKitTest::viewport):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::contentsScale):

• UIProcess/API/qt/qwebkittest_p.h:
• UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::viewportAttributesChanged):

Tools:

Changed the access to the viewport attributes to use the viewport object that is introduced by this change.

• MiniBrowser/qt/qml/ViewportInfoItem.qml:

4:24 AM Changeset in webkit [126569] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Use the new 'feature_defines' variable to generate DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=94919

Patch by Xan Lopez <​xlopez@igalia.com> on 2012-08-24
Reviewed by Carlos Garcia Campos.

Update to use the new 'feature_defines' variable, otherwise the
bindings will be broken.

• bindings/gobject/GNUmakefile.am: ditto.

3:19 AM Changeset in webkit [126568] by zandobersek@gmail.com

• 1 edit
  1 delete in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for css3/flexbox/flexitem.html after r126503.

• platform/gtk/css3/flexbox: Removed.
• platform/gtk/css3/flexbox/flexitem-expected.txt: Removed.

3:08 AM Changeset in webkit [126567] by haraken@chromium.org

• 3 edits in trunk/Source/WebCore

Remove RefPtr from HTMLTextAreaElement::m_placeholder
​https://bugs.webkit.org/show_bug.cgi?id=94338

Reviewed by Kent Tamura.

To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

HTMLTextAreaElement::m_placeholder does not need to be a RefPtr<Node>,
because it is guaranteed to point to a shadow DOM tree of the
HTMLTextAreaElement node, which is guaranteed to exist in the subtree
of the HTMLTextAreaElement node.

No tests. No change in behavior.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
(WebCore::HTMLTextAreaElement::placeholderElement):
(WebCore::HTMLTextAreaElement::attach):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

• html/HTMLTextAreaElement.h:

(HTMLTextAreaElement):

2:40 AM Changeset in webkit [126566] by commit-queue@webkit.org

• 14 edits
  2 deletes in trunk/Source

[V8] Refactor away IsolatedWorld
​https://bugs.webkit.org/show_bug.cgi?id=93971

Patch by Dan Carney <​dcarney@google.com> on 2012-08-24
Reviewed by Kentaro Hara.

Source/WebCore:

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This paves the way towards a JSC-like use of DOMWrapperWorld.

No new tests. No change in functionality.

• UseV8.cmake:
• WebCore.gypi:
• bindings/v8/DOMWrapperWorld.cpp:

(WebCore):
(WebCore::DOMWrapperWorld::createUninitializedWorld):
(WebCore::DOMWrapperWorld::createMainWorld):
(WebCore::mainThreadNormalWorld):
(WebCore::isolatedWorldMap):
(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::getOrCreateIsolatedWorld):

• bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolatedWorldsExist):
(WebCore::DOMWrapperWorld::isMainWorld):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::extensionGroup):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::deref):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

• bindings/v8/IsolatedWorld.cpp: Removed.
• bindings/v8/IsolatedWorld.h: Removed.
• bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

• bindings/v8/V8DOMMap.cpp:

(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):

• bindings/v8/V8DOMMap.h:

(DOMDataStoreHandle):

• bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

• bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

• bindings/v8/V8IsolatedContext.h:

(V8IsolatedContext):
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):

• bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):

Source/WebKit/chromium:

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.

• src/WebViewImpl.cpp:

(WebKit::WebView::addUserScript):
(WebKit::WebView::addUserStyleSheet):

2:36 AM Changeset in webkit [126565] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Added missing SKIP keyword to platform/efl/TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=94781

Unreviewed. Removed unnecessary SKIP keyword.

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-08-24

• platform/efl/TestExpectations:

2:27 AM Changeset in webkit [126564] by abarth@webkit.org

• 9 edits in trunk/Source/WebCore

[V8] Improve the developer ergonomics of ScopedPersistent
​https://bugs.webkit.org/show_bug.cgi?id=94901

Reviewed by Kentaro Hara.

As requested by haraken, this patch adds some helper functions to
ScopedPersistent so that we don't need to call get() all the time.

• bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

• bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::get):
(WebCore::ScopedPersistent::operator->):
(ScopedPersistent):
(WebCore::ScopedPersistent::isEmpty):

• bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):

• bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):

• bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::~V8AbstractEventListener):
(WebCore::V8AbstractEventListener::getReceiverObject):

• bindings/v8/V8AbstractEventListener.h:

(WebCore::V8AbstractEventListener::hasExistingListenerObject):

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::isContextInitialized):
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::clearForClose):
(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
(WebCore::V8DOMWindowShell::updateDocumentWrapper):
(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
(WebCore::V8DOMWindowShell::clearDocumentWrapperCache):
(WebCore::V8DOMWindowShell::setSecurityToken):
(WebCore::V8DOMWindowShell::updateDocument):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
(WebCore::V8DOMWindowShell::updateSecurityOrigin):

• bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):

2:23 AM Changeset in webkit [126563] by pfeldman@chromium.org

• 5 edits in trunk/Source/WebCore

Web Inspector: move ResourceViews to "components" module - it is used from the Resources as well.
​https://bugs.webkit.org/show_bug.cgi?id=94904

Reviewed by Vsevolod Vlasov.

• WebCore.gypi:
• inspector/compile-front-end.py:
• inspector/front-end/NetworkPanel.js:
• inspector/front-end/inspector.html:

2:02 AM Changeset in webkit [126562] by commit-queue@webkit.org

• 19 edits
  4 deletes in trunk

Source/WebCore: Check argument count in the dispatch function for overloaded functions
​https://bugs.webkit.org/show_bug.cgi?id=94790

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2012-08-24
Reviewed by Kentaro Hara.

Throw NotEnoughArguments exception for overloaded functions if actual argument
count is less than the least mandatory argument count among all overloaded.

Reset JS and V8 binding tests result for the change.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateFunctionParametersCheck):
(GenerateOverloadedFunction):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionParametersCheck):
(GenerateOverloadedFunctionCallback):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):

LayoutTests: Remove platform specific expected files after the change
​https://bugs.webkit.org/show_bug.cgi?id=94790

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2012-08-24
Reviewed by Kentaro Hara.

1. Use the cross-platform expected files for the 2 tests in question.
2. Update other tests for overloaded functions and their expected files

affected by the change.

• fast/canvas/canvas-overloads-drawImage-expected.txt:
• fast/canvas/canvas-overloads-setFillColor-expected.txt:
• fast/canvas/canvas-overloads-setShadow-expected.txt:
• fast/canvas/canvas-overloads-setStrokeColor-expected.txt:
• fast/canvas/script-tests/canvas-overloads-drawImage.js:
• fast/canvas/script-tests/canvas-overloads-setFillColor.js:
• fast/canvas/script-tests/canvas-overloads-setShadow.js:
• fast/canvas/script-tests/canvas-overloads-setStrokeColor.js:
• fast/canvas/webgl/texImageTest-expected.txt:
• platform/chromium/fast/files/create-blob-url-crash-expected.txt: Removed.
• platform/chromium/fast/files/url-required-arguments-expected.txt: Removed.
• platform/gtk/fast/files/create-blob-url-crash-expected.txt: Removed.
• platform/gtk/fast/files/url-required-arguments-expected.txt: Removed.
• storage/indexeddb/index-get-key-argument-required-expected.txt:
• storage/indexeddb/objectStore-required-arguments-expected.txt:
• storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
• storage/indexeddb/transaction-storeNames-required-expected.txt:

1:54 AM Changeset in webkit [126561] by jhoneycutt@apple.com

• 2 edits in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Update skipped list with changes merged from r121428. Patch by Mark
Lam. Unreviewed.

• platform/wk2/Skipped:

1:51 AM Changeset in webkit [126560] by jhoneycutt@apple.com

• 2 edits in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Update skipped list with changes merged from r121440. Patch by Mark
Lam. Unreviewed.

• platform/mac-wk2/Skipped:

1:47 AM Changeset in webkit [126559] by jhoneycutt@apple.com

• 1 edit
  8 adds in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Update test expectations with changes merged from r126219. Patch by
Mark Lam. Unreviewed.

• platform/mac-lion/platform: Added.
• platform/mac-lion/platform/mac-lion: Added.
• platform/mac-lion/platform/mac-lion/platform: Added.
• platform/mac-lion/platform/mac-lion/platform/mac: Added.
• platform/mac-lion/platform/mac-lion/platform/mac/fast: Added.
• platform/mac-lion/platform/mac-lion/platform/mac/fast/text: Added.
• platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
• platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.

1:44 AM Changeset in webkit [126558] by Simon Hausmann

• 5 edits in trunk/Source

Make it possible to build WebKit with Python 3 (and 2)
​https://bugs.webkit.org/show_bug.cgi?id=94814

Source/WebCore:

Exceptions need a hack to work with both.
string.join was already deprecated in Python 2.
Relative imports are no longer supported, use package name instead.

Patch by Frederik Gladhorn <​gladhorn@kde.org> on 2012-08-23
Reviewed by Ryosuke Niwa.

• inspector/CodeGeneratorInspector.py:

(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Generator.go):
(Generator.process_event):
(Generator.process_command):

Source/WebKit2:

Patch by Frederik Gladhorn <​gladhorn@kde.org> on 2012-08-23
Reviewed by Ryosuke Niwa.

Exceptions need a hack to work with both.
string.join was already deprecated in Python 2.
Relative imports are no longer supported, use package name instead.

• Scripts/webkit2/messages.py:
• Scripts/webkit2/parser.py:

1:43 AM Changeset in webkit [126557] by jhoneycutt@apple.com

• 1 edit
  13 adds in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Update test expectations. Patch by Mark Lam. Unreviewed.

• platform/mac-wk2/http/tests/loading: Added.
• platform/mac-wk2/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac-wk2/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac-wk2/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac-wk2/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac-wk2/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac-wk2/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt: Added.
• platform/mac/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Added.

1:40 AM Changeset in webkit [126556] by allan.jensen@nokia.com

• 4 edits in trunk/Source/WebCore

Get rid of m_useLatchedWheelEventNode
​https://bugs.webkit.org/show_bug.cgi?id=94684

Reviewed by Ryosuke Niwa.

Moves the setting of m_useLatchedWheelEventNode into PlatformWheelEvent.

• page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureScrollCore):

• page/EventHandler.h:
• platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::setUseLatchedEventNode):
(PlatformWheelEvent):
(WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
(WebCore::PlatformWheelEvent::useLatchedEventNode):

1:39 AM Changeset in webkit [126555] by jhoneycutt@apple.com

• 2 edits in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Merge changes to test from r125162. Patch by Mark Lam.

• fast/events/dom-character-data-modified-textarea-crash.html:

1:39 AM Changeset in webkit [126554] by yosin@chromium.org

• 5 edits in trunk

[Forms] Multiple fields time input UI should handle Delete key as Backspace key
​https://bugs.webkit.org/show_bug.cgi?id=94902

Reviewed by Kent Tamura.

Source/WebCore:

This patch adds treating "Delete" key as same as "Backspace" key for
multiple fields time input UI. This patch affects ports which enable
both ENABLE_INPUT_TYPE_TIME and ENABLES_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch adds a test case for "Delete" key to
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html

• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Changed
condition expression to check both Backspace(U+0008) key and
Delete(U+007F) key.

LayoutTests:

This patch adds a new test case for "Delete" key behavior for multiple
fields time input UI.

• fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation.
• fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Added "Delete" key test case.

1:29 AM Changeset in webkit [126553] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Gardening after r126442. Skip a test because of missing shadow feature.

Patch by János Badics <János Badics> on 2012-08-24
Reviewed by Csaba Osztrogonác.

• platform/qt/Skipped:

12:57 AM Changeset in webkit [126552] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r126546.
​http://trac.webkit.org/changeset/126546
​https://bugs.webkit.org/show_bug.cgi?id=94911

Caused inspector tests to timeout (Requested by dominicc on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-08-24

• WebCore.gypi:
• inspector/compile-front-end.py:
• inspector/front-end/NetworkPanel.js:
• inspector/front-end/inspector.html:

12:45 AM Changeset in webkit [126551] by sergio@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Purge unused favicons from IconDatabase after 30 days
​https://bugs.webkit.org/show_bug.cgi?id=82346

Reviewed by Gustavo Noronha Silva.

Favicons will be removed from the icon database after not being used
for more than 30 days. This will keep the database size under
control.

• loader/icon/IconDatabase.cpp:

(WebCore):
(WebCore::IconDatabase::performURLImport): filter icons older than
30 days.

12:40 AM Changeset in webkit [126550] by dominicc@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Narrow expected failures to Linux.

• platform/chromium/TestExpectations:

12:38 AM Changeset in webkit [126549] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit2

<​http://webkit.org/b/94910> Copy the entire webkit2 module in to the WebKit2 framework wrapper.

Reviewed by Dan Bernstein.

This will allow relative imports within the webkit2 module to be removed in the future without
requiring future changes to clients of the module.

• WebKit2.xcodeproj/project.pbxproj: Remove the webkit2 group from the project, and add it back

as a folder reference. This allows the directory and its contents to be copied in to the PrivateHeaders
directory. We also need to add a script phase to clean up any .pyc files that may be present in
the module.