Timeline



Aug 26, 2012:

11:52 PM Changeset in webkit [126728] by yosin@chromium.org
  • 3 edits
    2 adds in trunk

[Forms] Focus style of millisecond field in multiple fields time input UI is different from other fields
https://bugs.webkit.org/show_bug.cgi?id=95046

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes typo for input::-webkit-datetime-edit-millisecond-field:focus
selector to make all fields of multiple fields time input UI have same
style on focus.

Test: fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html

  • css/html.css: Fix typo for selector input::-webkit-datetime-edit-millisecond-field:focus

LayoutTests:

This patch adds a new test for checking focus style of all fields in
multiple fields time input UI.

We check appearance of focus field in fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html: Added.
11:50 PM Changeset in webkit [126727] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Initialized m_hasNonEmptyList to fix a valgrind uninitialized read
https://bugs.webkit.org/show_bug.cgi?id=95045

Reviewed by Kent Tamura.

Conditional jump or move depends on uninitialised value(s)
WebCore::HTMLInputElement::dataList() const (third_party/WebKit/Source/WebCore/html/HTMLInputElement.cpp:1523)
WebCore::RangeInputType::updateTickMarkValues() (third_party/WebKit/Source/WebCore/html/RangeInputType.cpp:351)
WebCore::RangeInputType::findClosestTickMarkValue(WebCore::Decimal const&) (third_party/WebKit/Source/WebCore/html/RangeInputType.cpp:370)
WebCore::HTMLInputElement::findClosestTickMarkValue(WebCore::Decimal const&) (third_party/WebKit/Source/WebCore/html/HTMLInputElement.cpp:324)
WebCore::SliderThumbElement::setPositionFromPoint(WebCore::FractionalLayoutPoint const&) (third_party/WebKit/Source/WebCore/html/shadow/SliderThumbElement.cpp:296)
WebCore::SliderThumbElement::dragFrom(WebCore::FractionalLayoutPoint const&) (third_party/WebKit/Source/WebCore/html/shadow/SliderThumbElement.cpp:246)
WebCore::RangeInputType::handleMouseDownEvent(WebCore::MouseEvent*) (third_party/WebKit/Source/WebCore/html/RangeInputType.cpp:159)
WebCore::HTMLInputElement::defaultEventHandler(WebCore::Event*) (third_party/WebKit/Source/WebCore/html/HTMLInputElement.cpp:1163)
WebCore::MediaControlTimelineElement::defaultEventHandler(WebCore::Event*) (third_party/WebKit/Source/WebCore/html/shadow/MediaControlElements.cpp:916)
WebCore::EventDispatcher::dispatchEventPostProcess(WTF::PassRefPtr<WebCore::Event>, void*) (third_party/WebKit/Source/WebCore/dom/EventDispatcher.cpp:357)
WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) (third_party/WebKit/Source/WebCore/dom/EventDispatcher.cpp:263)
WebCore::MouseEventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const (third_party/WebKit/Source/WebCore/dom/MouseEvent.cpp:238)
WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr<WebCore::EventDispatchMediator>) (third_party/WebKit/Source/WebCore/dom/EventDispatcher.cpp:129)
...
The report came from the media/audio-delete-while-slider-thumb-clicked.html'--pixel-test test.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::dataList):

11:22 PM Changeset in webkit [126726] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping http/tests/security/local-user-CSS-from-remote.html to green mac WK2 bots.
https://bugs.webkit.org/show_bug.cgi?id=95043.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Kentaro Hara.

  • platform/mac-wk2/Skipped:
11:10 PM Changeset in webkit [126725] by hbono@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

Merge 125757 - Prevent showing suggestions when right-clicking a selection range.
https://bugs.webkit.org/show_bug.cgi?id=94189

Reviewed by Hajime Morita.

To emulate Safari, my r120810 changes selection when right-clicking a misspelled
word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange
and it changes the existing selection when right-clicking a selection which
includes a misspelled word. This change uses VisibleSelection::isCaret to
prevent showing suggestions when right-clicking a selection range. (Neither does
Safari show suggestions when there is a selection range.)

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

TBR=hbono@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10868101

10:55 PM Changeset in webkit [126724] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping fast/forms/validation-message-user-modify.html to green mac WK2 bots.
https://bugs.webkit.org/show_bug.cgi?id=95042.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Kentaro Hara.

  • platform/mac-wk2/Skipped:
9:23 PM Changeset in webkit [126723] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix for builds without VALUE_PROFILING. I had forgotten that shouldEmitProfiling()
is designed to return true if DFG_JIT is disabled. I should be using canBeOptimized() instead.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

9:12 PM Changeset in webkit [126722] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't allocate space for arguments and call frame if arguments aren't captured
https://bugs.webkit.org/show_bug.cgi?id=95024

Reviewed by Phil Pizlo.

27% on v8-real-earley.

  • runtime/JSActivation.h:

(JSC::JSActivation::registerOffset): The offset is zero if we're skipping
the arguments and call frame because "offset" means space reserved for
those things.

(JSC::JSActivation::tearOff): Don't copy the scope chain and callee. We
don't need them for anything, and we're no longer guaranteed to have
space for them.

8:57 PM Changeset in webkit [126721] by ggaren@apple.com
  • 21 edits in trunk/Source

Removed the NULL checks from visitChildren functions
https://bugs.webkit.org/show_bug.cgi?id=95021

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

As of http://trac.webkit.org/changeset/126624, all values are NULL-checked
during GC, so explicit NULL checks aren't needed anymore.

Source/WebCore:

As of http://trac.webkit.org/changeset/126624, all values are NULL-checked
during GC, so explicit NULL checks aren't needed anymore.

8:48 PM Changeset in webkit [126720] by ggaren@apple.com
  • 5 edits in trunk/Source

Removed a JSC-specific hack from the web inspector
https://bugs.webkit.org/show_bug.cgi?id=95033

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added support for what the web inspector really wanted instead.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut): Added some explanation for these
checks, which were non-obvious to me.

(JSC::JSActivation::getOwnPropertySlot): It's impossible to access the
arguments property of an activation after it's been torn off, since the
only way to tear off an activation is to instantiate a new function,
which has its own arguments property in scope. However, the inspector
get special access to activations, and may try to perform this access,
so we need a special guard to maintain coherence and avoid crashing in
case the activation optimized out the arguments property.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertyDescriptor): Provide getOwnPropertyNames
and getOwnPropertyDescriptor implementations, to meet the web inspector's
needs. (User code can never call these.)

Source/WebCore:

The hack was never reviewed. If it had been, I suspect it would have
gotten an r- for making weird assumptions about the engine's implimentation.

  • inspector/InjectedScriptSource.js: It's not sound to assume that an

object has no properties except for "arguments" if and only if it's an
activation: non-activations can have a property named "arguments", and
activations can optimize out "arguments".

7:49 PM Changeset in webkit [126719] by commit-queue@webkit.org
  • 3 edits in trunk/Source

[chromium] Fix a bug where CCThreadProxy::canDraw() gets stuck at false on tab switch
https://bugs.webkit.org/show_bug.cgi?id=94903

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-08-26
Reviewed by James Robinson.

Suppose the impl thread deletes all textures via
releaseContentsTextures(). The impl thread will not be able to draw
again until resetContentsTexturesPurged() is called in
scheduledActionCommit(). When deleting the textures, the function
releaseContentsTextures() calls setNeedsCommitOnImplThread() to ensure
that a commit will come along to allow drawing again. If this commit
is aborted, then the page will not draw until a commit is scheduled,
which may be never.

Make beginFrameAborted() call setNeedsCommit(), so that the requested
commit will eventually occur.

No new tests, update to CCSchedulerStateMachineTest's
TestGoesInvisibleBeforeBeginFrameCompletes to require new
functionality (new test fails with old behavior).

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::beginFrameAborted):

5:49 PM Changeset in webkit [126718] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

Finally inlining should correctly track the catch context
https://bugs.webkit.org/show_bug.cgi?id=94986
<rdar://problem/11753784>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This fixes two behaviors:

1) Throwing from a finally block. Previously, we would seem to reenter the finally

block - though only once.


2) Executing a finally block from some nested context, for example due to a

'continue', 'break', or 'return' in the try. This would execute the finally
block in the context of of the try block, which could lead to either scope depth
mismatches or reexecutions of the finally block on throw, similarly to (1) but
for different reasons.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC):
(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::pushTry):
(JSC::BytecodeGenerator::popTryAndEmitCatch):

  • bytecompiler/BytecodeGenerator.h:

(FinallyContext):
(TryData):
(JSC):
(TryContext):
(TryRange):
(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::TryNode::emitBytecode):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/script-tests/throw-from-finally.js: Added.
  • fast/js/throw-from-finally.html: Added.
  • fast/js/throw-from-finally-expected.txt: Added.
4:48 PM Changeset in webkit [126717] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Remove parent pointer from StyleSheetContents and StyleRuleImport
https://bugs.webkit.org/show_bug.cgi?id=94926

Reviewed by Andreas Kling.

To be able to cache and share @imported stylesheets in the future there must not be any parent
pointers in the stylesheet tree.

Parent pointers are used during loading to invoke load completion callbacks and for
accessing document context information (like the security origin). They are not used after
the sheet load is complete. Instead of keeping the parent pointers around indefinitely as part of the
stylesheet data structure we just keep a pointer to the root CSSStyleSheet for the duration of the load.

This patch doesn't enable any new caching or generally change the behavior.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::rootStyleSheet):
(WebCore):
(WebCore::CSSStyleSheet::ownerDocument):

  • css/CSSStyleSheet.h:

(CSSStyleSheet):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::LoadContext::LoadContext):

Simplify by making StyleRuleImport CachedStyleSheetClient directly. LoadContext contains
fields that can be thrown away after load completes.

(WebCore):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::~StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::isLoading):
(WebCore::StyleRuleImport::hadLoadError):
(WebCore::StyleRuleImport::requestStyleSheet):

  • css/StyleRuleImport.h:

(StyleRuleImport):
(LoadContext):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::StyleSheetContents):

Remove now unnecessary constructor.

(WebCore::StyleSheetContents::isCacheable):
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::clearRules):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):
(WebCore::StyleSheetContents::requestImportedStyleSheets):
(WebCore):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseStringAtLine):
(WebCore::StyleSheetContents::checkImportedSheetLoadCompleted):
(WebCore::StyleSheetContents::checkLoadCompleted):
(WebCore::StyleSheetContents::getAncestors):
(WebCore::StyleSheetContents::hasImportCycle):

Move the cycle checking to the root stylesheet so we don't need to pass the entire chain around.
The extra work here is unlikely to cause problems, massive import trees don't really occur in
practice.

  • css/StyleSheetContents.h:

(WebCore::StyleSheetContents::create):
(StyleSheetContents):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

3:38 PM Changeset in webkit [126716] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid pointless string/number round-trip in applyRelativeFontStyleChange().
<http://webkit.org/b/95031>

Reviewed by Dan Bernstein.

Create a CSS_PX primitive value directly instead of passing String::number(foo) + "px" to the CSS parser.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

3:35 PM Changeset in webkit [126715] by fpizlo@apple.com
  • 25 edits in trunk/Source/JavaScriptCore

Array type checks and storage accesses should be uniformly represented and available to CSE
https://bugs.webkit.org/show_bug.cgi?id=95013

Reviewed by Oliver Hunt.

This uniformly breaks up all array accesses into up to three parts:

1) The type check, using a newly introduced CheckArray node, in addition to possibly

a CheckStructure node. We were already inserting the CheckStructure prior to this
patch. The CheckArray node will be automatically eliminated if the thing it was
checking for had already been checked for, either intentionally (a CheckStructure
inserted based on the array profile of this access) or accidentally (some checks,
typically a CheckStructure, inserted for some unrelated operations). The
CheckArray node may not be inserted if the array type is non-specific (Generic or
ForceExit).


2) The storage load using GetIndexedPropertyStorage. Previously, this only worked for

GetByVal. Now it works for all array accesses. The storage load may not be
inserted if the mode of array access does not permit CSE of storage loads (like
non-specific modes or Arguments).


3) The access itself: one of GetByVal, PutByVal, PutByValAlias, ArrayPush, ArrayPop,

GetArrayLength, StringCharAt, or StringCharCodeAt.


This means that the type check can be subjected to CSE even if the CFA isn't smart
enough to reason about it (yet!). It also means that the storage load can always be
subjected to CSE; previously CSE on storage load only worked for array loads and not
other forms of access. Finally, it removes the bizarre behavior that
GetIndexedPropertyStorage previously had: previously, it was responsible for the type
check in some cases, but not others; this made reasoning about the CFA really
confusing.

This change also disables late refinement of array mode, since I decided that
supporting that feature is both confusing and likely unprofitable. The array modes are
now locked in in the first fixup run after prediction propagation. Of course,
refinements from Generic to something else would not have been a problem; we could
reenable those if we thought we really needed to.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromStructure):
(DFG):
(JSC::DFG::refineArrayMode):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::lengthNeedsStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::checkStructureElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(DFG):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::vote):
(JSC::DFG::Graph::substitute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::setArrayMode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

3:15 PM Changeset in webkit [126714] by gavinp@chromium.org
  • 5 edits in trunk/Source/WebCore

Prerenderering should gracefully handle no PrerendererClient or PrerenderingPlatform being provided.
https://bugs.webkit.org/show_bug.cgi?id=95036

Reviewed by Adam Barth.

Some assertions made sure there was a prerendering platform and client, and this change should make prerendering just be a NOP when no platform is provided, and just continue without a client when there is no client provided. These assertions were causing crashes in chromium's content_shell target, and really for no good reason.

No new tests, because DumpRenderTree provides both a PrerenderingPlatform and a PrerendererClient. But there is a new layout test in chromium's WebKitBrowserTest for this behaviour, see http://codereview.chromium.org/10869068/

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::Prerenderer):
(WebCore::Prerenderer::render):
(WebCore::Prerenderer::client):

  • loader/Prerenderer.h:
  • loader/PrerendererClient.cpp:

(WebCore::PrerendererClient::from):

  • platform/chromium/Prerender.cpp:

(WebCore::Prerender::cancel):

2:11 PM Changeset in webkit [126713] by Dave Barton
  • 2 edits in trunk/Source/WebCore

Streamline mathml.css
https://bugs.webkit.org/show_bug.cgi?id=95039

Reviewed by Dan Bernstein.

Remove 3 no-op { margin: 0px } declarations, and combine several { display: inline-block } ones.

Tested by existing tests.

  • css/mathml.css:

(math):
(mo, mrow, mfenced, mfrac, msub, msup, msubsup, munder, mover, munderover, msqrt, mroot):
(mrow, mfenced):
(msubsup > *):
(mo, mn, mi, mtext):
(annotation, annotation-xml):
(msqrt):
(mroot):

12:53 PM Changeset in webkit [126712] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFGGraph.h has a bogus comment about the nature of StorageAccessData
https://bugs.webkit.org/show_bug.cgi?id=95035

Reviewed by Oliver Hunt.

The comment is both wrong (storage access instructions don't reference CheckStructure)
and highly redundant: of course it's the case that two structures may have the same
identifier. Our interference analyses currently don't care about this and make the
conservative assumptions when necessary (same identifier, same object -> must be same
property; same identifier, may be same object -> may be the same property). Better to
remove the bogus comment since the code that operates over this data structure is
fairly self-explanatory already.

  • dfg/DFGGraph.h:

(StorageAccessData):

12:41 PM Changeset in webkit [126711] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress Mac test requiring rebaseline after r126683.

Unreviewed gardening.

fast/repaint/control-clip.html was suppressed and failing already so remove it from
the tests requiring rebaseline after r126683.

  • platform/chromium/TestExpectations:
12:34 PM Changeset in webkit [126710] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress test requiring rebaseline after r126683

Unreviewed, gardening.

  • platform/chromium/TestExpectations:
11:42 AM Changeset in webkit [126709] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: make ConsoleView listen to the JavaScriptContextManager
https://bugs.webkit.org/show_bug.cgi?id=94940

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Otherwise, model is pushing data into the UI.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.clone):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContext):
(WebInspector.ConsoleView.prototype._contextRemoved):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contexts):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.completeURL):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.createLink):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/elements/elements-panel-rewrite-href-expected.txt:
  • inspector/styles/styles-url-linkify-expected.txt:
11:23 AM Changeset in webkit [126708] by fpizlo@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Don't allocate space for arguments and call frame if arguments aren't captured
https://bugs.webkit.org/show_bug.cgi?id=95024

Reviewed by Geoffrey Garen.

Test coverage for the case where an argument was legitimately captured.

  • fast/js/jsc-test-list:
  • fast/js/legitimately-captured-argument-expected.txt: Added.
  • fast/js/legitimately-captured-argument.html: Added.
  • fast/js/script-tests/legitimately-captured-argument.js: Added.
7:35 AM Changeset in webkit [126707] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress 6 failing tests on Qt.

Unreviewed gardening.

  • platform/qt/TestExpectations:
6:58 AM Changeset in webkit [126706] by pfeldman@chromium.org
  • 11 edits
    1 copy in trunk/Source/WebCore

Web Inspector: provide "show function definition" and "reveal in elements panel" using context menu provider.
https://bugs.webkit.org/show_bug.cgi?id=94932

Reviewed by Vsevolod Vlasov.

Moved corresponding context menu providers into scripts and elements panels.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.revealAndSelectNode):
(WebInspector.ElementsPanel.prototype.appendApplicableItems.selectNode):
(WebInspector.ElementsPanel.prototype.appendApplicableItems.revealElement):
(WebInspector.ElementsPanel.prototype.appendApplicableItems):

  • inspector/front-end/ElementsPanelDescriptor.js: Copied from Source/WebCore/inspector/front-end/ScriptsPanelDescriptor.js.

(WebInspector.ElementsPanelDescriptor):
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems.didGetDetails):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems.revealFunction):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems):

  • inspector/front-end/ScriptsPanelDescriptor.js:

(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

6:48 AM Changeset in webkit [126705] by anilsson@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT failed in WebPagePrivate::commitRootLayerIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=94921

PR 104676
As visibility changed due to WebPage::setVisible(true),
resumeRootLayerCommit() would call commitRootLayerIfNeeded(), without
layouting or rendering. If a one shot drawing sync was pending at this
time, it would cause the condition
ASSERT(!needsOneShotDrawingSynchronization()) to fail.

The comment immediately before the assert states that "In case of one
shot drawing synchronization, you should first layoutIfNeeded, render,
then commit and draw the layers". However, resumeRootLayerCommit() did
no such thing.

Fixed by removing the call to commitRootLayerIfNeeded() from
resumeRootLayerCommit(), because the latter is only called in a code
path where we're going to layout, render and then commit anyway. These
operations will be performed from resumeBackingStore() which is called
at the end of setVisible().

Reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):

6:30 AM Changeset in webkit [126704] by robert@webkit.org
  • 134 edits
    128 copies
    71 adds in trunk/LayoutTests

Rebaseline Mac test results after r126683.

Unreviewed gardening.

  • platform/mac-lion/animations/cross-fade-border-image-source-expected.txt: Copied from LayoutTests/platform/mac/animations/cross-fade-border-image-source-expected.txt.
  • platform/mac-lion/css1/box_properties/border_bottom-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_bottom-expected.txt.
  • platform/mac-lion/css1/box_properties/border_bottom_inline-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_bottom_inline-expected.txt.
  • platform/mac-lion/css1/box_properties/border_left-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_left-expected.txt.
  • platform/mac-lion/css1/box_properties/border_left_inline-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_left_inline-expected.txt.
  • platform/mac-lion/css1/box_properties/border_right-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_right-expected.txt.
  • platform/mac-lion/css1/box_properties/border_right_inline-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_right_inline-expected.txt.
  • platform/mac-lion/css1/units/length_units-expected.txt: Copied from LayoutTests/platform/mac/css1/units/length_units-expected.txt.
  • platform/mac-lion/css2.1/20110323/absolute-replaced-height-036-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/absolute-replaced-height-036-expected.txt.
  • platform/mac-lion/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/mac-lion/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-007-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-007-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-008-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-009-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-009-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-010-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-001-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-001-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-002-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-002-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-003-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-003-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-004-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-004-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-008-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt.
  • platform/mac-lion/css2.1/20110323/margin-applies-to-008-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/margin-applies-to-008-expected.txt.
  • platform/mac-lion/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/width-non-replaced-inline-001-expected.txt.
  • platform/mac-lion/css2.1/t040302-c61-phys-len-00-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.txt.
  • platform/mac-lion/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0804-c5507-padn-r-02-f-expected.txt.
  • platform/mac-lion/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt.
  • platform/mac-lion/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0804-c5509-padn-l-02-f-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-brdr-r-01-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-brdr-r-02-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5520-brdr-b-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-brdr-l-02-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt.
  • platform/mac-lion/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
  • platform/mac-lion/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
  • platform/mac-lion/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
  • platform/mac-lion/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
  • platform/mac-lion/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
  • platform/mac-lion/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
  • platform/mac-lion/editing/deleting/type-delete-after-quote-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/type-delete-after-quote-expected.txt.
  • platform/mac-lion/editing/execCommand/4580583-1-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/4580583-1-expected.txt.
  • platform/mac-lion/editing/execCommand/4580583-2-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/4580583-2-expected.txt.
  • platform/mac-lion/editing/inserting/5418891-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/5418891-expected.txt.
  • platform/mac-lion/editing/inserting/5510537-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/5510537-expected.txt.
  • platform/mac-lion/editing/inserting/6703873-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/6703873-expected.txt.
  • platform/mac-lion/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt.
  • platform/mac-lion/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/5006779-expected.txt.
  • platform/mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt.
  • platform/mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt.
  • platform/mac-lion/fast/block/float/012-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/012-expected.txt.
  • platform/mac-lion/fast/block/float/013-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/013-expected.txt.
  • platform/mac-lion/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/mac-lion/fast/block/margin-collapse/041-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/041-expected.txt.
  • platform/mac-lion/fast/block/margin-collapse/043-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/043-expected.txt.
  • platform/mac-lion/fast/block/margin-collapse/057-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/057-expected.txt.
  • platform/mac-lion/fast/block/positioning/inline-block-relposition-expected.txt: Copied from LayoutTests/platform/mac/fast/block/positioning/inline-block-relposition-expected.txt.
  • platform/mac-lion/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/mac-lion/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/mac-lion/fast/css/acid2-expected.txt: Copied from LayoutTests/platform/mac/http/tests/misc/acid2-expected.txt.
  • platform/mac-lion/fast/css/acid2-pixel-expected.txt: Copied from LayoutTests/platform/mac/fast/css/acid2-pixel-expected.txt.
  • platform/mac-lion/fast/css/border-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/border-height-expected.txt.
  • platform/mac-lion/fast/css/caption-width-absolute-position-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-absolute-position-expected.txt.
  • platform/mac-lion/fast/css/caption-width-absolute-position-offset-top-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt.
  • platform/mac-lion/fast/css/caption-width-fixed-position-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-fixed-position-expected.txt.
  • platform/mac-lion/fast/css/caption-width-fixed-position-offset-top-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt.
  • platform/mac-lion/fast/css/line-height-determined-by-primary-font-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt.
  • platform/mac-lion/fast/css/pseudo-first-line-border-width-expected.txt: Copied from LayoutTests/platform/mac/fast/css/pseudo-first-line-border-width-expected.txt.
  • platform/mac-lion/fast/css/rtl-ordering-expected.txt: Copied from LayoutTests/platform/mac/fast/css/rtl-ordering-expected.txt.
  • platform/mac-lion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
  • platform/mac-lion/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt.
  • platform/mac-lion/fast/forms/basic-buttons-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-buttons-expected.txt.
  • platform/mac-lion/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
  • platform/mac-lion/fast/forms/button-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.txt.
  • platform/mac-lion/fast/forms/button-cannot-be-nested-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-cannot-be-nested-expected.txt.
  • platform/mac-lion/fast/forms/button-generated-content-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-generated-content-expected.txt.
  • platform/mac-lion/fast/forms/button-inner-block-reuse-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-inner-block-reuse-expected.txt.
  • platform/mac-lion/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
  • platform/mac-lion/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
  • platform/mac-lion/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
  • platform/mac-lion/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
  • platform/mac-lion/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
  • platform/mac-lion/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
  • platform/mac-lion/fast/forms/select-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-baseline-expected.txt.
  • platform/mac-lion/fast/frames/viewsource-attribute-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/viewsource-attribute-expected.txt.
  • platform/mac-lion/fast/frames/viewsource-on-image-file-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/viewsource-on-image-file-expected.txt.
  • platform/mac-lion/fast/hidpi/image-set-border-image-comparison-expected.txt: Copied from LayoutTests/platform/mac/fast/hidpi/image-set-border-image-comparison-expected.txt.
  • platform/mac-lion/fast/hidpi/image-set-border-image-dynamic-expected.txt: Copied from LayoutTests/platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt.
  • platform/mac-lion/fast/inline/inline-padding-disables-text-quirk-expected.txt: Copied from LayoutTests/platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt.
  • platform/mac-lion/fast/inline/inline-text-quirk-bpm-expected.txt: Copied from LayoutTests/platform/mac/fast/inline/inline-text-quirk-bpm-expected.txt.
  • platform/mac-lion/fast/invalid/residual-style-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/residual-style-expected.txt.
  • platform/mac-lion/fast/layers/scroll-rect-to-visible-expected.txt: Copied from LayoutTests/platform/mac/fast/layers/scroll-rect-to-visible-expected.txt.
  • platform/mac-lion/fast/lists/007-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/007-expected.txt.
  • platform/mac-lion/fast/multicol/block-axis-horizontal-bt-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt.
  • platform/mac-lion/fast/multicol/block-axis-vertical-lr-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt.
  • platform/mac-lion/fast/multicol/block-axis-vertical-rl-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt.
  • platform/mac-lion/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/mac-lion/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/mac-lion/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/mac-lion/fast/overflow/overflow-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-rtl-expected.txt.
  • platform/mac-lion/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt.
  • platform/mac-lion/fast/repaint/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/control-clip-expected.txt.
  • platform/mac-lion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
  • platform/mac-lion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
  • platform/mac-lion/fast/table/append-cells2-expected.txt: Copied from LayoutTests/platform/mac/fast/table/append-cells2-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/003-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/003-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/003-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/003-vertical-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/rtl-border-collapsing-expected.txt.
  • platform/mac-lion/fast/table/colgroup-spanning-groups-rules-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colgroup-spanning-groups-rules-expected.txt.
  • platform/mac-lion/fast/table/remove-td-display-none-expected.txt: Copied from LayoutTests/platform/mac/fast/table/remove-td-display-none-expected.txt.
  • platform/mac-lion/fast/text/apply-start-width-after-skipped-text-expected.txt: Copied from LayoutTests/platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt.
  • platform/mac-lion/fast/text/basic/015-expected.txt: Copied from LayoutTests/platform/mac/fast/text/basic/015-expected.txt.
  • platform/mac-lion/fast/text/monospace-width-cache-expected.txt: Copied from LayoutTests/platform/mac/fast/text/monospace-width-cache-expected.txt.
  • platform/mac-lion/fast/writing-mode/broken-ideographic-font-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/mac-lion/http/tests/misc/acid2-expected.txt: Copied from LayoutTests/platform/mac/http/tests/misc/acid2-expected.txt.
  • platform/mac-lion/http/tests/misc/acid2-pixel-expected.txt: Copied from LayoutTests/platform/mac/fast/css/acid2-pixel-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt.
  • platform/mac-lion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/mac-lion/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
  • platform/mac-lion/tables/mozilla/core/table_rules-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/table_rules-expected.txt.
  • platform/mac-lion/tables/mozilla/marvin/x_table_rules_groups-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/x_table_rules_groups-expected.txt.
  • platform/mac-lion/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt.
  • platform/mac-lion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
  • platform/mac-lion/transforms/2d/transform-borderbox-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/transform-borderbox-expected.txt.
  • platform/mac-lion/transforms/2d/transform-origin-borderbox-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/transform-origin-borderbox-expected.txt.
  • platform/mac-lion/transitions/cross-fade-border-image-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/animations/cross-fade-border-image-source-expected.txt:
  • platform/mac/css1/box_properties/border_bottom-expected.txt:
  • platform/mac/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/mac/css1/box_properties/border_left-expected.txt:
  • platform/mac/css1/box_properties/border_left_inline-expected.txt:
  • platform/mac/css1/box_properties/border_right-expected.txt:
  • platform/mac/css1/box_properties/border_right_inline-expected.txt:
  • platform/mac/css1/units/length_units-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/mac/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/mac/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/mac/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/mac/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/mac/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/mac/editing/execCommand/4580583-1-expected.txt:
  • platform/mac/editing/execCommand/4580583-2-expected.txt:
  • platform/mac/editing/inserting/5418891-expected.txt:
  • platform/mac/editing/inserting/5510537-expected.txt:
  • platform/mac/editing/inserting/6703873-expected.txt:
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/mac/editing/pasteboard/5006779-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/mac/fast/block/float/012-expected.txt:
  • platform/mac/fast/block/float/013-expected.txt:
  • platform/mac/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/041-expected.txt:
  • platform/mac/fast/block/margin-collapse/043-expected.txt:
  • platform/mac/fast/block/margin-collapse/057-expected.txt:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/mac/fast/css/acid2-expected.txt:
  • platform/mac/fast/css/acid2-pixel-expected.txt:
  • platform/mac/fast/css/border-height-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/mac/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/mac/fast/forms/basic-buttons-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/button-align-expected.txt:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/mac/fast/forms/button-generated-content-expected.txt:
  • platform/mac/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/button-sizes-expected.txt:
  • platform/mac/fast/forms/button-style-color-expected.txt:
  • platform/mac/fast/forms/button-text-transform-expected.txt:
  • platform/mac/fast/forms/button-white-space-expected.txt:
  • platform/mac/fast/forms/control-clip-overflow-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/mac/fast/hidpi/image-set-border-image-comparison-expected.txt:
  • platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/mac/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/mac/fast/lists/007-expected.txt:
  • platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/mac/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/mac/fast/overflow/overflow-rtl-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/mac/fast/repaint/control-clip-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/selectors/064-expected.txt:
  • platform/mac/fast/table/append-cells2-expected.txt:
  • platform/mac/fast/table/border-collapsing/003-expected.txt:
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/mac/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/mac/fast/table/remove-td-display-none-expected.txt:
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/mac/fast/text/basic/015-expected.txt:
  • platform/mac/fast/text/monospace-width-cache-expected.txt:
  • platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/mac/http/tests/misc/acid2-expected.txt:
  • platform/mac/http/tests/misc/acid2-pixel-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/mac/tables/mozilla/core/table_rules-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/mac/transforms/2d/transform-borderbox-expected.txt:
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/mac/transitions/cross-fade-border-image-expected.txt: Added.
5:00 AM Changeset in webkit [126703] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Stop leaking a pthread_attr in CookieDatabaseBackingStore
https://bugs.webkit.org/show_bug.cgi?id=95029

Patch by Joe Mason <jmason@rim.com> on 2012-08-26
Reviewed by Rob Buis.

No new tests (no behaviour change)
RIM PR 198519

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::CookieDatabaseBackingStore): use pthread_attr_default
instead of pthread_attr_init

4:18 AM Changeset in webkit [126702] by robert@webkit.org
  • 87 edits
    9 adds in trunk/LayoutTests

Rebaseline Qt test results after r126683.

Unreviewed gardening.

  • platform/qt-4.8/TestExpectations:
  • platform/qt-linux/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/animations/cross-fade-border-image-source-expected.txt:
  • platform/qt/css1/box_properties/border_bottom-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left-expected.txt:
  • platform/qt/css1/box_properties/border_left_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right-expected.txt:
  • platform/qt/css1/box_properties/border_right_inline-expected.txt:
  • platform/qt/css1/units/length_units-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/qt/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/qt/editing/execCommand/4580583-1-expected.txt:
  • platform/qt/editing/execCommand/4580583-2-expected.txt:
  • platform/qt/editing/inserting/5418891-expected.txt:
  • platform/qt/editing/inserting/5510537-expected.txt:
  • platform/qt/editing/inserting/6703873-expected.txt:
  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/qt/fast/block/float/012-expected.txt:
  • platform/qt/fast/block/float/013-expected.txt:
  • platform/qt/fast/block/float/016-expected.txt:
  • platform/qt/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/041-expected.txt:
  • platform/qt/fast/block/margin-collapse/043-expected.txt:
  • platform/qt/fast/block/margin-collapse/057-expected.txt:
  • platform/qt/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/qt/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/qt/fast/css/acid2-expected.txt:
  • platform/qt/fast/css/acid2-pixel-expected.txt:
  • platform/qt/fast/css/border-height-expected.txt:
  • platform/qt/fast/css/caption-width-absolute-position-expected.txt:
  • platform/qt/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/qt/fast/css/caption-width-fixed-position-expected.txt:
  • platform/qt/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Added.
  • platform/qt/fast/frames/viewsource-attribute-expected.txt:
  • platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/qt/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/qt/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/qt/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/qt/fast/lists/007-expected.txt:
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/qt/fast/multicol/progression-reverse-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/qt/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/qt/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/qt/http/tests/misc/acid2-expected.txt:
  • platform/qt/http/tests/misc/acid2-pixel-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/qt/tables/mozilla/core/table_rules-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/transforms/2d/transform-borderbox-expected.txt:
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/qt/transitions/cross-fade-border-image-expected.txt:
3:47 AM Changeset in webkit [126701] by robert@webkit.org
  • 87 edits
    2 copies
    8 adds in trunk/LayoutTests

Rebaseline EFL test results after r126683.

Unreviewed gardening.

  • platform/efl/TestExpectations:
  • platform/efl/animations/cross-fade-border-image-source-expected.txt:
  • platform/efl/css1/box_properties/border_bottom-expected.txt:
  • platform/efl/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/efl/css1/box_properties/border_left-expected.txt:
  • platform/efl/css1/box_properties/border_left_inline-expected.txt:
  • platform/efl/css1/box_properties/border_right-expected.txt:
  • platform/efl/css1/box_properties/border_right_inline-expected.txt:
  • platform/efl/css1/units/length_units-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/efl/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/efl/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/efl/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/efl/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/efl/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/efl/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/efl/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/efl/editing/execCommand/4580583-1-expected.txt:
  • platform/efl/editing/execCommand/4580583-2-expected.txt:
  • platform/efl/fast/block/float/012-expected.txt:
  • platform/efl/fast/block/float/013-expected.txt:
  • platform/efl/fast/block/float/016-expected.txt: Added.
  • platform/efl/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/efl/fast/block/margin-collapse/041-expected.txt:
  • platform/efl/fast/block/margin-collapse/043-expected.txt:
  • platform/efl/fast/block/margin-collapse/057-expected.txt:
  • platform/efl/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/efl/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/efl/fast/css/acid2-expected.txt: Copied from LayoutTests/platform/efl/http/tests/misc/acid2-expected.txt.
  • platform/efl/fast/css/acid2-pixel-expected.txt: Copied from LayoutTests/platform/efl/http/tests/misc/acid2-expected.txt.
  • platform/efl/fast/css/border-height-expected.txt:
  • platform/efl/fast/css/caption-width-absolute-position-expected.txt:
  • platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/efl/fast/css/caption-width-fixed-position-expected.txt:
  • platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/efl/fast/frames/viewsource-attribute-expected.txt:
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/efl/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/efl/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/efl/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/efl/fast/lists/007-expected.txt:
  • platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/efl/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/efl/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/efl/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/efl/fast/overflow/overflow-rtl-expected.txt: Added.
  • platform/efl/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/efl/fast/table/border-collapsing/003-expected.txt:
  • platform/efl/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/efl/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/efl/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/efl/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/efl/fast/text/basic/015-expected.txt:
  • platform/efl/fast/text/monospace-width-cache-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/efl/http/tests/misc/acid2-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/efl/transforms/2d/transform-borderbox-expected.txt:
  • platform/efl/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/efl/transitions/cross-fade-border-image-expected.txt:
1:40 AM Changeset in webkit [126700] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping fast/block/float/016.html to green the platform mac bots.
https://bugs.webkit.org/show_bug.cgi?id=95028.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Filip Pizlo.

  • platform/mac/Skipped:
12:16 AM Changeset in webkit [126699] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Added test-generated expected results file for a few compositing
overflow tests.
https://bugs.webkit.org/show_bug.cgi?id=95023.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Filip Pizlo.

  • platform/mac/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/mac/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/mac/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/mac/compositing/overflow/remove-overflow-crash2-expected.txt: Added.

Aug 25, 2012:

9:03 PM Changeset in webkit [126698] by Dave Barton
  • 6 edits in trunk

Remove { vertical-align: baseline } declarations from mathml.css
https://bugs.webkit.org/show_bug.cgi?id=95015

Reviewed by Eric Seidel.

Source/WebCore:

The { vertical-align: baseline } declarations in mathml.css had no positive effect, and could
wrongly override a previous { vertical-align: sub } or { vertical-align: super } declaration.

Added 1 test to mathml/presentation/subsup.xhtml.

  • css/mathml.css:

(math):
(mrow, mfenced):
(msub, msup):
(msubsup):
(munder, mover, munderover):

  • Remove { vertical-align: baseline } declarations

LayoutTests:

Added 1 test to mathml/presentation/subsup.xhtml.

  • mathml/presentation/subsup.xhtml:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
8:58 PM Changeset in webkit [126697] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2012-08-25 Geoffrey Garen <ggaren@apple.com>

Try a little harder to fix the Linux build.

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
8:53 PM Changeset in webkit [126696] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-08-25 Geoffrey Garen <ggaren@apple.com>

Try to fix the Linux build.

  • runtime/JSActivation.cpp:
8:25 PM Changeset in webkit [126695] by ggaren@apple.com
  • 30 edits in trunk/Source/JavaScriptCore

Don't use malloc / destructors for activation objects
https://bugs.webkit.org/show_bug.cgi?id=94897

Reviewed by Oliver Hunt.

65% faster on v8-real-earley.

Lots of boilerplate here, but the jist is this:

(1) Use CopiedSpace instead of malloc to allocate the activation's
backing store.

(2) Use MarkedSpace instead of ref-counting to allocate the symbol table.

(3) ==> No more destructor.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::stronglyVisitStrongReferences):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(FunctionCodeBlock): SymbolTable is a GC object now, so it gets a write
barrier and visit calls instead of ref-counting. I changed all CodeBlocks
to use shared symbol tables because the distinction between shared and
unshared hurt my head.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Sometimes, a period just wants
to be an arrow. And then C++ is there to accommodate.

  • jit/JITDriver.h:

(JSC::jitCompileFunctionIfAppropriate):

  • runtime/Arguments.h:

(ArgumentsData):
(JSC::Arguments::setRegisters):
(Arguments):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::visitChildren):

  • runtime/Executable.h:

(JSC::FunctionExecutable::symbolTable):
(FunctionExecutable):

  • runtime/ExecutionHarness.h:

(JSC::prepareFunctionForExecution): I changed from WriteBarrier to
WriteBarrierBase so activations could reuse StorageBarrier and PropertyStorage.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation): Allocate the symbol table here,
after we're fully constructed, to avoid GC during initialization.

(JSC::JSActivation::visitChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSActivation.h:

(JSC::JSActivation::create):
(JSActivation):
(JSC::JSActivation::registerOffset):
(JSC):
(JSC::JSActivation::registerArraySize):
(JSC::JSActivation::registerArraySizeInBytes):
(JSC::JSActivation::tearOff): Tear-off zero-initializes all uncopied
registers. This makes it safe to copyAndAppend the full buffer in
visitChildren, without any extra checks.

  • runtime/JSCell.h:

(JSCell): Moved a shared default set of flags into this base class, so
I could use it in a few places.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData): New structure for symbol tables.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::addStaticGlobals):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::symbolTableHasProperty): We don't need an inline
symbol table -- JSSymbolTableObject will GC allocate one for us.

  • runtime/JSObject.h:

(JSObject):

  • runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):

  • runtime/JSStaticScopeObject.cpp:

(JSC):
(JSC::JSStaticScopeObject::visitChildren): NULL check our register store
because finishCreation allocates an object now, so we may get marked
before we've assigned to our register store.

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
(JSStaticScopeObject): No more destructor for this object, either, since
it no longer embeds a hash table.

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::visitChildren):
(JSC::JSSymbolTableObject::deleteProperty):
(JSC::JSSymbolTableObject::getOwnPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::symbolTable):
(JSSymbolTableObject):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes): SymbolTableObject allocates a symbol
table automatically if one isn't provided. (Activations provide their
own, which they get from compiled code.)

  • runtime/JSVariableObject.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::registerAt):
(JSC::JSVariableObject::addressOfRegisters):
(JSVariableObject):
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation): Removed a bunch of obsolete code.
Activations manage their registers directly now.

  • runtime/StorageBarrier.h:

(StorageBarrier):
(JSC::StorageBarrier::operator!):

  • runtime/SymbolTable.cpp:

(JSC):
(JSC::SharedSymbolTable::destroy):

  • runtime/SymbolTable.h:

(JSC::SharedSymbolTable::create):
(SharedSymbolTable):
(JSC::SharedSymbolTable::createStructure):
(JSC::SharedSymbolTable::SharedSymbolTable): Boilerplat code to
make shared symbol table GC-allocated.

6:51 PM Changeset in webkit [126694] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Texmap] Move TextureMapperGL to use GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=78672

Patch by Roland Takacs <rtakacs@inf.u-szeged.hu>, Helder Correia <Helder Correia> on 2012-08-25
Reviewed by Noam Rosenthal.

It is based on a previous patch by Helder Correia.

TextureMapperGL (TMGL) includes direct GL calls and
GraphicsContext3D (GC3D) offers many conveniences over the
former approach: using existing CSS shader code, ANGLE for
shader compilation, reusing WebCore::Texture, having shaders and
textures that can delete themselves.

A GC3D object is created by TMGL with the newly introduced
builder createForCurrentGLContext(), which in turn uses
the new RenderToCurrentGLContext flag underneath.

TMGL's dependency on OpenGLShims.h was completely removed.
However, GC3D does not map every single GL constant. Thus, it's
important to document the following:

  • GL_FALSE was mapped to false.
  • GL_UNPACK_ROW_LENGTH, GL_UNPACK_SKIP_PIXELS, GL_UNPACK_SKIP_ROWS, GL_TEXTURE_RECTANGLE_ARB, and GL_UNSIGNED_INT_8_8_8_8_REV were locally defined in TMGL.

The patch was originally developed by Helder Correia and finished
by Roland Takacs.

No new tests, refactoring.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::sharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::scissorClip):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawQuad):
(WebCore::TextureMapperGL::drawBorder):
(WebCore):
(WebCore::TextureMapperGL::drawTextureRectangleARB):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::viewportMatrix):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
(WebCore::TextureMapperGL::createTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::graphicsContext3D):
(TextureMapperGL):
(ClipStack):
(WebCore::BitmapTextureGL::textureTarget):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::initializeProgram):
(WebCore::TextureMapperShaderProgram::getUniformLocation):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::TextureMapperShaderProgramAntialiasingNoMask):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(WebCore::StandardFilterProgram::~StandardFilterProgram):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::StandardFilterProgram::create):
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::id):
(WebCore::TextureMapperShaderProgram::vertexAttrib):
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::matrixLocation):
(WebCore::TextureMapperShaderProgram::flipLocation):
(WebCore::TextureMapperShaderProgram::textureSizeLocation):
(WebCore::TextureMapperShaderProgram::sourceTextureLocation):
(WebCore::TextureMapperShaderProgram::maskTextureLocation):
(WebCore::TextureMapperShaderProgram::opacityLocation):
(WebCore::TextureMapperShaderProgram::isValidUniformLocation):
(StandardFilterProgram):
(WebCore::StandardFilterProgram::vertexAttrib):
(WebCore::StandardFilterProgram::texCoordAttrib):
(WebCore::StandardFilterProgram::textureUniform):
(WebCore::TextureMapperShaderProgramSimple::create):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::colorLocation):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::create):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadVerticesInTextureCoordinatesLocation):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadEdgesInScreenSpaceLocation):
(TextureMapperShaderProgramAntialiasingNoMask):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(TextureMapperShaderManager):

6:16 PM Changeset in webkit [126693] by pdr@google.com
  • 5 edits in trunk

Roll out r126056 and r126626
https://bugs.webkit.org/show_bug.cgi?id=95017

Reviewed by Dirk Schulze.

Source/WebCore:

This patch rolls out r126056 which regressed a test.
The getBBox() code removed turns out to be required for tight bounding
boxes in SVGPathElement::getBBox().

When this regression occurred the relevant test was skipped in r126626. This
patch reverts that skip.

No new tests.

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::getBBox):
(WebCore):

  • svg/SVGPathElement.h:

(SVGPathElement):

LayoutTests:

Removing skipped test.

  • platform/mac/Skipped:
4:58 PM Changeset in webkit [126692] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

op_call should have ArrayProfiling for the benefit of array intrinsics
https://bugs.webkit.org/show_bug.cgi?id=95014

Reviewed by Sam Weinig.

This is a performance-neutral change that just adds the profiling but does not
use it, yet. If in the future we wanted to make this kind of profiling cheaper
we could move it into specialized thunks for the relevant array intrinsics, but
I figure that if this much simpler change gives us what we need without any
discernable performance penalty then that's for the best.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
4:45 PM Changeset in webkit [126691] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping 4 compositing/overflow tests for gardening.
https://bugs.webkit.org/show_bug.cgi?id=95011.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-25
Reviewed by Sam Weinig.

compositing/overflow/overflow-auto-with-touch.html
compositing/overflow/overflow-overlay-with-touch.html
compositing/overflow/scrolling-content-clip-to-viewport.html
compositing/overflow/textarea-scroll-touch.html

  • platform/mac/Skipped:
4:06 PM Changeset in webkit [126690] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] V8NodeFilterCondition should use ScopedPersistent
https://bugs.webkit.org/show_bug.cgi?id=95010

Reviewed by Eric Seidel.

V8NodeFilterCondition just re-implements ScopedPersistent by hand.

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8NodeFilterCondition.h:

(WebCore):
(V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::create):

3:34 PM Changeset in webkit [126689] by fpizlo@apple.com
  • 6 edits
    2 deletes in trunk/Source/JavaScriptCore

The redundant phi elimination phase is not used and should be removed
https://bugs.webkit.org/show_bug.cgi?id=95006

Reviewed by Dan Bernstein.

Just removing dead code.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGDriver.cpp:
  • dfg/DFGRedundantPhiEliminationPhase.cpp: Removed.
  • dfg/DFGRedundantPhiEliminationPhase.h: Removed.
3:26 PM Changeset in webkit [126688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo Build Broken due to missing export definitions
https://bugs.webkit.org/show_bug.cgi?id=95007

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-08-25
Reviewed by Ryosuke Niwa.

Export symbols were missing from the def file for WinCairo port. Added
these missing symbols to avoid build break

  • win/WebKit2CFLite.def:
2:40 PM Changeset in webkit [126687] by Dave Barton
  • 2 edits in trunk/LayoutTests

Re-unskip 2 previously fixed tests that were accidentally re-skipped in r119192.

Unreviewed, gardening.

  • platform/mac/Skipped:
1:18 PM Changeset in webkit [126686] by zandobersek@gmail.com
  • 120 edits
    10 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after the changes made in r126683.

  • platform/gtk/TestExpectations:
  • platform/gtk/animations/cross-fade-border-image-source-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/gtk/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/gtk/editing/execCommand/4580583-1-expected.txt:
  • platform/gtk/editing/execCommand/4580583-2-expected.txt:
  • platform/gtk/editing/inserting/5418891-expected.txt:
  • platform/gtk/editing/inserting/5510537-expected.txt:
  • platform/gtk/editing/inserting/6703873-expected.txt:
  • platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/gtk/editing/pasteboard/5006779-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/gtk/fast/block/float/012-expected.txt:
  • platform/gtk/fast/block/float/013-expected.txt:
  • platform/gtk/fast/block/float/016-expected.txt: Added.
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/041-expected.txt:
  • platform/gtk/fast/block/margin-collapse/043-expected.txt:
  • platform/gtk/fast/block/margin-collapse/057-expected.txt:
  • platform/gtk/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/gtk/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/gtk/fast/css/acid2-expected.txt: Added.
  • platform/gtk/fast/css/acid2-pixel-expected.txt: Added.
  • platform/gtk/fast/css/border-height-expected.txt:
  • platform/gtk/fast/css/caption-width-absolute-position-expected.txt:
  • platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/gtk/fast/css/caption-width-fixed-position-expected.txt:
  • platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/gtk/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/fast/lists/007-expected.txt:
  • platform/gtk/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/gtk/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/gtk/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/gtk/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-rtl-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/gtk/fast/table/border-collapsing/003-expected.txt:
  • platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/gtk/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/gtk/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/gtk/fast/text/basic/015-expected.txt:
  • platform/gtk/fast/text/monospace-width-cache-expected.txt:
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/gtk/http/tests/misc/acid2-expected.txt:
  • platform/gtk/http/tests/misc/acid2-pixel-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-styling-strict-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/tables/mozilla/core/table_rules-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transitions/cross-fade-border-image-expected.txt:
11:42 AM Changeset in webkit [126685] by Dave Barton
  • 1 edit
    10 deletes in trunk/LayoutTests

Remove custom mac-snowleopard mathml test baselines
https://bugs.webkit.org/show_bug.cgi?id=95004

Reviewed by Eric Seidel.

These custom baselines are no longer needed, since the mac lion bots were upgraded to
OS X 10.7.4 in the fix for https://bugs.webkit.org/show_bug.cgi?id=94393.

  • platform/mac-snowleopard/mathml: Removed.
  • platform/mac-snowleopard/mathml/presentation: Removed.
  • platform/mac-snowleopard/mathml/presentation/attributes-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/fenced-mi-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/fractions-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/mo-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/over-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/roots-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/row-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/sub-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/tokenElements-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/underover-expected.txt: Removed.
10:25 AM Changeset in webkit [126684] by robert@webkit.org
  • 6 edits in trunk/LayoutTests

Update TestExpectations for Qt, EFL, GTK, Apple Win and Chromium after r126683.

Unreviewed, gardening.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
9:20 AM Changeset in webkit [126683] by robert@webkit.org
  • 10 edits
    2 adds in trunk

Tables with just border-style set on the cells do not get a grid
https://bugs.webkit.org/show_bug.cgi?id=84286

Reviewed by Julien Chaffraix.

Source/WebCore:

This is happening because every cell gets a zero-width border in createSharedCellStyle() if the table border is not explictly set.
FF and Opera don't do this, so leave the cell's border alone if there is no table border explicitly set.

Test: fast/css/table-rules-attribute-none-with-cell-borders.html

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject): Without this we would end up rebaselining a bunch of tests to report 'border: []'

rather than 'border: [none]'. The problem here was that writeRenderObject would only report the first border if it differed from
BorderValue(). What we want is for it to report the first border always and then any borders after that if they differ.

LayoutTests:

With the exception of the new test table-rules-attribute-none-with-cell-borders.html all
of these are rebaselines due to RenderTreeAsText now reporting the first border, even if it
is a default border.

  • fast/block/float/avoidance-rtl-expected.txt:
  • fast/borders/border-radius-wide-border-01-expected.txt:
  • fast/borders/only-one-border-with-width-expected.txt:
  • fast/css/table-rules-attribute-none-with-cell-borders-expected.html: Added.
  • fast/css/table-rules-attribute-none-with-cell-borders.html: Added.
  • fast/multicol/progression-reverse-expected.txt:
  • fast/multicol/vertical-lr/rules-with-border-before-expected.txt:
  • fast/multicol/vertical-rl/rules-with-border-before-expected.txt:
  • platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/chromium-win/animations/cross-fade-border-image-source-expected.txt:
  • platform/chromium-win/css1/box_properties/border_bottom-expected.txt:
  • platform/chromium-win/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/chromium-win/css1/box_properties/border_left-expected.txt:
  • platform/chromium-win/css1/box_properties/border_left_inline-expected.txt:
  • platform/chromium-win/css1/box_properties/border_right-expected.txt:
  • platform/chromium-win/css1/box_properties/border_right_inline-expected.txt:
  • platform/chromium-win/css1/units/length_units-expected.txt:
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/chromium-win/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/chromium-win/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/chromium-win/editing/execCommand/4580583-1-expected.txt:
  • platform/chromium-win/editing/execCommand/4580583-2-expected.txt:
  • platform/chromium-win/editing/inserting/5418891-expected.txt:
  • platform/chromium-win/editing/inserting/5510537-expected.txt:
  • platform/chromium-win/editing/inserting/6703873-expected.txt:
  • platform/chromium-win/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/chromium-win/editing/pasteboard/5006779-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/chromium-win/fast/block/float/012-expected.txt:
  • platform/chromium-win/fast/block/float/013-expected.txt:
  • platform/chromium-win/fast/block/float/016-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/041-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/043-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/057-expected.txt:
  • platform/chromium-win/fast/css/acid2-expected.txt:
  • platform/chromium-win/fast/css/acid2-pixel-expected.txt:
  • platform/chromium-win/fast/css/border-height-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-attribute-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/chromium-win/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/chromium-win/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/chromium-win/fast/lists/007-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/chromium-win/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/chromium-win/fast/text/basic/015-expected.txt:
  • platform/chromium-win/fast/text/monospace-width-cache-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/chromium-win/tables/mozilla/core/table_rules-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.txt:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/chromium-win/transitions/cross-fade-border-image-expected.txt:
  • platform/chromium/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt:
6:33 AM Changeset in webkit [126682] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: missing time ruler in Timeline and Network panels
https://bugs.webkit.org/show_bug.cgi?id=95001

Reviewed by Pavel Feldman.

Fixed a call site for Calculator.boundarySpan(), which is now a function rather than a property.

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

2:23 AM Changeset in webkit [126681] by Michelangelo De Simone
  • 5 edits in trunk

[Crash] Null pointer in CSSParser::parseMixFunction()
https://bugs.webkit.org/show_bug.cgi?id=94998

Reviewed by Benjamin Poulain.

Source/WebCore:

parseMixFunction() may try to access invalid memory when the arguments of the
mix() function are comma-terminated.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseMixFunction):

LayoutTests:

New test cases added to check invalid comma-terminated values within mix().

  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
Note: See TracTimeline for information about the timeline view.