⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 2, 2012:

11:57 PM Changeset in webkit [127401] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit2

WK2: Build failure on SnowLeopard after r127384
​https://bugs.webkit.org/show_bug.cgi?id=95665

Reviewed by Dan Bernstein.

Add SandboxExtension::consumePermanently(const Handle&) for !ENABLE(WEB_PROCESS_SANDBOX) to fix link error.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::consumePermanently):

11:03 PM Changeset in webkit [127400] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

[Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
​https://bugs.webkit.org/show_bug.cgi?id=95660

Reviewed by Kent Tamura.

This patch changes visible empty value of AM/PM field in multiple
fields time input UI to "-", "--", "---", and so on based on maximum
length of AM/PM labels. In current implementation, it is always "--"
regardless locale, although on Arabic, AM/PM are represented in one
character.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(makeVisibleEmptyValue): Build visible empty value from maximum length
of labels.
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
use m_visibleEmptyValue.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(WebCore::DateTimeSymbolicFieldElement): Added new member variable
m_visibleEmptyValue to hold visible empty value.

10:51 PM Changeset in webkit [127399] by bashi@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed test expectation update after r127398

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
9:03 PM Changeset in webkit [127398] by yosin@chromium.org
  • 4 edits in trunk/Source/WebCore

[Forms] AM/PM field of multiple fields time input UI should be fixed width
​https://bugs.webkit.org/show_bug.cgi?id=95542

Reviewed by Kent Tamura.

This patch changes width of AM/PM field of multiple field time input
UI fixed as maximum width of labels or "--".

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

  • css/html.css:

(input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
Added "text-align" property to "center".

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
(WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
(DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().

7:04 PM Changeset in webkit [127397] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu()
​https://bugs.webkit.org/show_bug.cgi?id=95355

Reviewed by Gyuyoung Kim.

Efl does not have a proper way to support nested loop so that applications
may change value after showPopupMenu() is finished.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp: Improved test case to cover this bug.

(selectItemAfterDelayed):
(showPopupMenu):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
Guard with !PLATFORM(EFL) to keep the activePopupMenu valid to call valueChangedForPopupMenu
outside showPopupMenu().

6:05 PM Changeset in webkit [127396] by yosin@chromium.org
  • 6 edits
    5 adds
    9 deletes in trunk/LayoutTests

[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
​https://bugs.webkit.org/show_bug.cgi?id=95545

Reviewed by Kent Tamura.

This patch changes test expectations to text output and pixel images
instead of structure of render tree and pixel images for multiple
fields time input UI. This patch helps us to avoid rebaseline when
we change DOM structure but keep appearance.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Changed to call testRunner.dumpAsText().
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
5:24 PM Changeset in webkit [127395] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectation update after r127362

  • platform/chromium/TestExpectations: Moved

fast/notifications/notifications-event-listener-crash.html to
http/tests/notifications.

4:52 PM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
4:45 PM Changeset in webkit [127394] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fixed failures seen on Linux bots.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_push_with_scope):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_push_with_scope):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h: push_*_scope doesn't have a destination operand anymore.

Accordingly, update these places in the baseline JIT, which I missed in my last patch.

2:27 PM Changeset in webkit [127393] by ggaren@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Refactored scope chain opcodes to support optimization for named function expressions
​https://bugs.webkit.org/show_bug.cgi?id=95658

Reviewed by Sam Weinig.

Renamed

push_scope => push_with_scope
push_new_scope => push_name_scope

to clarify the difference between them.

Changed push_with_scope and push_name_scope not to save the new scope in
a temporary register, since doing so made optimization harder.

(The old behavior was a hold-over from when the scope chain wasn't
a GC object, and wouldn't be marked otherwise. Now, the scope chain is
marked because it is a GC object pointed to by the call frame.)

Changed push_name_scope to accept an operand specifying the attributes
for the named property, instead of assuming DontDelete, because a named
function expression needs ReadOnly|DontDelete.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::highestUsedRegister): Removed this function,
which used to be related to preserving saved scope object temporaries,
because it had no callers.

1:26 PM Changeset in webkit [127392] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
​https://bugs.webkit.org/show_bug.cgi?id=95301

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-02
Reviewed by Darin Adler.

The static string convertedSpaceString() had a couple of annoying side effects:
-The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
-The string was kept in the heap for no particular reason.

This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.

The patch also make the binary a tiny bit smaller (700 bytes).

  • editing/HTMLInterchange.cpp:

(WebCore::convertHTMLTextToInterchangeFormat):

11:57 AM Changeset in webkit [127391] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build is broken when SVG is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=95653

Patch by Mike West <​mkwst@chromium.org> on 2012-09-02
Reviewed by Dirk Schulze.

Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

10:43 AM Changeset in webkit [127390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Add missing semicolon at the end of some lines.
​https://bugs.webkit.org/show_bug.cgi?id=95640

Patch by Byungwoo Lee <​bw80.lee@gmail.com> on 2012-09-02
Reviewed by Gyuyoung Kim.

EWK_VIEW_PRIV_GET_OR_RETURN macro and other related macro can be used
without semicolon, because it ends with a semicolon or complete block.
This can make a human mistake about missing semicolon.

Fixed the macros to require semicolon, and added missing semicolons.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_initialize):

10:09 AM Changeset in webkit [127389] by commit-queue@webkit.org
  • 4 edits
    1 move in trunk/LayoutTests

fast/html/marquee-alternate.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=94130

Patch by Jessie Berlin <​jberlin@apple.com> on 2012-09-02
Reviewed by Simon Fraser.

Disable the test because it is flakey on so many platforms. Remove it from the Skipped and
TestExpectations files so that run-webkit-tests doesn't go looking for it.

  • fast/html/marquee-alternate.html-disabled: Renamed from LayoutTests/fast/html/marquee-alternate.html.
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/qt-arm/Skipped:
3:34 AM Changeset in webkit [127388] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Repaints should not be deferred after initial page load is complete
​https://bugs.webkit.org/show_bug.cgi?id=95480

Reviewed by Simon Fraser

Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy.
This is not the intention of this code.

This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
load has completed. It also cleans up the code slightly.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):

Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.

  • page/FrameView.cpp:

(WebCore):

Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.

(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):

Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.

(WebCore::FrameView::flushDeferredRepaints):

We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
the latter.

(WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):

Factor the test for using load time repaint timings to a functions. The test for
initial page load having completed is new.

(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):

  • page/FrameView.h:

(FrameView):

1:34 AM Changeset in webkit [127387] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

Don't create access error strings if there is no access error
​https://bugs.webkit.org/show_bug.cgi?id=95652

Reviewed by Adam Barth.

This undoes the 50% performance regression in pdfjs caused by
​http://trac.webkit.org/changeset/126165

No new tests because behavior is unchanged.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):

Sep 1, 2012:

10:51 PM Changeset in webkit [127386] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unused member variable from WebProcess.

Rubber-stamped by Dan Bernstein.

  • WebProcess/WebProcess.h:

(WebProcess):
Remove m_applicationCachePathExtension.

9:31 PM Changeset in webkit [127385] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Refactoring the DumpRenderTreeSupportEfl
​https://bugs.webkit.org/show_bug.cgi?id=95544

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-01
Reviewed by Gyuyoung Kim.

There are lots of repeated codes for getting the WebCore::Frame
and WebCore::Page. To reduce these duplications, simple macros
are added.

No new tests, just refactoring.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):
(DumpRenderTreeSupportEfl::pageProperty):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::setDefersLoading):
(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::clearUserStyleSheets):
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled):
(DumpRenderTreeSupportEfl::isCommandEnabled):
(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled):
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportEfl::globalContextRefForFrame):
(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
(DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification):
(DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled):
(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):

8:08 PM Changeset in webkit [127384] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Use dynamic sandbox extension rather than sandbox parameters for paths provided by the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=95651

Reviewed by Dan Bernstein.

This is the first step to not relying on the initialization message to initialize
the sandbox.

  • Shared/SandboxExtension.h:

(SandboxExtension):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::consumePermanently):
Add static version of SandboxExtension::consumePermanently which takes a
SandboxExtension::Handle. There is no reason to create a SandboxExtension
just to consume it forever.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):
Add SandboxExtension::Handles for paths we need access to, and remove
webInspectorBaseDirectory, which is unused.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Create SandboxExtension::Handles for paths we need access to, and move
getting the presenterApplicationPid to platformInitializeWebProcess, since
it is Mac only.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Move setting the presenterApplicationPid to platformInitializeWebProcess.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
Replace the use of sandbox parameters for opening access for necessary paths
with permanent consumption of sandbox extensions.

  • WebProcess/com.apple.WebProcess.sb.in:

Remove sandbox rules that are now handled via extensions.

5:15 PM Changeset in webkit [127383] by krit@webkit.org
  • 5 edits
    18 adds in trunk

Use -webkit-clip-path shapes to clip SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=95620

Reviewed by Rob Buis.

Source/WebCore:

This patch adds a path segment for a BasicShape to a given Path object. This
path and it's wind rule are used to clip the context of the SVG element.

Tests: svg/clip-path/clip-path-shape-circle-1-expected.svg

svg/clip-path/clip-path-shape-circle-1.svg
svg/clip-path/clip-path-shape-circle-2-expected.svg
svg/clip-path/clip-path-shape-circle-2.svg
svg/clip-path/clip-path-shape-ellipse-1-expected.svg
svg/clip-path/clip-path-shape-ellipse-1.svg
svg/clip-path/clip-path-shape-ellipse-2-expected.svg
svg/clip-path/clip-path-shape-ellipse-2.svg
svg/clip-path/clip-path-shape-polygon-1-expected.svg
svg/clip-path/clip-path-shape-polygon-1.svg
svg/clip-path/clip-path-shape-polygon-2-expected.svg
svg/clip-path/clip-path-shape-polygon-2.svg
svg/clip-path/clip-path-shape-polygon-3-expected.svg
svg/clip-path/clip-path-shape-polygon-3.svg
svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg
svg/clip-path/clip-path-shape-rounded-rect-1.svg
svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg
svg/clip-path/clip-path-shape-rounded-rect-2.svg

  • rendering/style/BasicShapes.cpp: Added helper functions that apply path segments to a given path.

(WebCore::BasicShapeRectangle::path):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):

  • rendering/style/BasicShapes.h: Make BasicShape virtualized again, since new virtual functions were added.

(WebCore::BasicShape::~BasicShape):
(BasicShape):
(WebCore::BasicShape::windRule): Will return the wind rule of the shape - nonzero by default.
(WebCore::BasicShape::BasicShape):
(BasicShapeRectangle):
(WebCore::BasicShapeRectangle::type): Removed member variable and return type per inheriting class directly.
(WebCore::BasicShapeRectangle::BasicShapeRectangle):
(BasicShapeCircle):
(WebCore::BasicShapeCircle::type): Ditto.
(WebCore::BasicShapeCircle::BasicShapeCircle):
(BasicShapeEllipse):
(WebCore::BasicShapeEllipse::type): Ditto.
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(BasicShapePolygon):
(WebCore::BasicShapePolygon::windRule):
(WebCore::BasicShapePolygon::type): Ditto.
(WebCore::BasicShapePolygon::BasicShapePolygon):

  • rendering/svg/SVGRenderingContext.cpp: If -webkit-clip-path was defined, clip the context to the shape.

Right now -webkit-clip-path overrides clip-path, so that people don't use both at the same time. Current
clip-path property will be replaced, once -webkit-clip-path gets unprefixed.
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

New tests to check behavior of -webkit-clip-path on SVG elements.

  • svg/clip-path/clip-path-shape-circle-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-circle-1.svg: Added.
  • svg/clip-path/clip-path-shape-circle-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-circle-2.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-1.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-2.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-1.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-2.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-3-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-3.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-1.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-2.svg: Added.
1:29 PM Changeset in webkit [127382] by wangxianzhu@chromium.org
  • 4 edits
    1 add
    1 delete in trunk

[Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
​https://bugs.webkit.org/show_bug.cgi?id=95605

Reviewed by Dirk Pranke.

Tools:

Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.expectations_files):
(ChromiumAndroidPort.clean_up_test_run):

LayoutTests:

Moved the skipping rules for ANDROID into platform/chromium-android/TestExpectations.

  • platform/chromium/TestExpectations:
  • platform/chromium/test_expectations_android.txt: Removed.
  • platform/chromium-android/TestExpectations: Added.
12:46 PM Changeset in webkit [127381] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Regression(r126763): Heap-use-after-free in WebCore::nextBreakablePosition
​https://bugs.webkit.org/show_bug.cgi?id=95229

Patch by Ned Holbrook <​nholbrook@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.

Source/WebCore:

TextLayout and LazyLineBreakIterator cache a RenderText's string during line breaking but RenderCounter
and RenderQuote can replace that string during preferred width calculation. This patch adds a non-virtual member
function to RenderText named updateTextIfNeeded() that triggers immediate string replacement by calling
the new virtual updateText() if necessary, which in turn calls computePreferredLogicalWidths(). In this way
RenderBlock::LineBreaker::nextLineBreak() can ensure a RenderText's string is current before caching it.

Test: fast/css/content/content-quotes-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::dirtyLineBoxesForRenderer): Drive-by: replace existing code with the equivalent updateTextIfNeeded().
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use updateTextIfNeeded() prior to caching RenderText string.

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::updateText): Call computePreferredLogicalWidths().
(WebCore):

  • rendering/RenderCounter.h:

(RenderCounter):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::updateText): Call computePreferredLogicalWidths().
(WebCore):

  • rendering/RenderQuote.h:

(RenderQuote):

  • rendering/RenderText.h:

(WebCore::RenderText::updateTextIfNeeded): Only call virtual updateText() if necessary.
(RenderText):
(WebCore::RenderText::updateText): Add no-op default implementation for new virtual member function.

LayoutTests:

Ensure line breaking doesn't crash due to text of RenderText being changed.

  • fast/css/content/content-quotes-crash-expected.txt: Added.
  • fast/css/content/content-quotes-crash.html: Added.
12:42 PM Changeset in webkit [127380] by commit-queue@webkit.org
  • 9 edits in trunk

fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
​https://bugs.webkit.org/show_bug.cgi?id=85811

Patch by Li Yin <​li.yin@intel.com> on 2012-09-01
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When MessagePort invoked close function, the close status is needed to set,
regardless of whether the port is cloned or not.

Tests: fast/events/message-port-clone.html

fast/events/message-port-close.html

  • dom/MessagePort.cpp:

(WebCore::MessagePort::close): Must set m_closed to be true.

LayoutTests:

  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
12:26 PM Changeset in webkit [127379] by wangxianzhu@chromium.org
  • 2 edits
    2 adds
    2 deletes in trunk/LayoutTests

[Chromium-Android] Upstream layout test expectations (Part 4)
​https://bugs.webkit.org/show_bug.cgi?id=95594

Reviewed by Adam Barth.

Remove a font boosting test which has been removed in downstream.
Update canvas test expectations.
Rebaselined one canvas test (only one space diff).

  • platform/chromium-android/fast/canvas/fallback-content-expected.txt: Added.
  • platform/chromium-android/fast/font-boosting/various-tricky-cases-expected.txt: Removed.
  • platform/chromium-android/fast/font-boosting/various-tricky-cases.html: Removed.
  • platform/chromium/TestExpectations:
12:06 PM Changeset in webkit [127378] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium buildfix when use_libcc_for_compositor=1

This gyp target was renamed downstream.

  • WebKit.gyp:
11:16 AM Changeset in webkit [127377] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
​https://bugs.webkit.org/show_bug.cgi?id=95643

Unreviewed GTK gardening, rebaselining an accessibility test.

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Corrected.
10:49 AM Changeset in webkit [127376] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-01 Geoffrey Garen <​ggaren@apple.com>

Rolled back out a piece of <​http://trac.webkit.org/changeset/127293>
because it broke inspector tests on Windows.

Shrink activation objects by half
​https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

10:47 AM Changeset in webkit [127375] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Share inline style between cloned Nodes (copy on write.)
<​http://webkit.org/b/95451>

Reviewed by Antti Koivisto.

When cloning a Node, use an immutable StylePropertySet for the new Node's inline style.
If the old Node already had an immutable inline style, we now reuse that, avoiding a copy.
Copying is deferred until mutation (either via CSSOM or setting of the style attribute.)

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::cloneDataFrom):

  • css/StylePropertySet.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::immutableCopyIfNeeded):

Added. Simply returns 'this' if the object is already immutable, otherwise creates a new one.

10:36 AM Changeset in webkit [127374] by commit-queue@webkit.org
  • 25 edits
    1 copy
    2 adds in trunk/Source

LLInt C loop backend.
​https://bugs.webkit.org/show_bug.cgi?id=91052.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-09-01
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::bytecodeOffset):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC):

  • interpreter/Interpreter.h:
  • jit/JITStubs.h:

(JITStackFrame):
(JSC):

  • llint/LLIntCLoop.cpp: Added.

(JSC):
(LLInt):
(JSC::LLInt::CLoop::initialize):
(JSC::LLInt::CLoop::catchRoutineFor):
(JSC::LLInt::CLoop::hostCodeEntryFor):
(JSC::LLInt::CLoop::jsCodeEntryWithArityCheckFor):
(JSC::LLInt::CLoop::jsCodeEntryFor):

  • llint/LLIntCLoop.h: Added.

(JSC):
(LLInt):
(CLoop):

  • llint/LLIntData.cpp:

(JSC::LLInt::initialize):

  • llint/LLIntData.h:

(JSC):

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LLIntOpcode.h:
  • llint/LLIntThunks.cpp:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:

(LLInt):
(JSC::LLInt::Ints2Double):
(JSC):
(JSC::CLoop::execute):

  • llint/LowLevelInterpreter.h:

(JSC):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/asm.rb:
  • offlineasm/backends.rb:
  • offlineasm/cloop.rb: Added.
  • offlineasm/instructions.rb:
  • runtime/Executable.h:

(ExecutableBase):
(JSC::ExecutableBase::hostCodeEntryFor):
(JSC::ExecutableBase::jsCodeEntryFor):
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor):
(JSC::ExecutableBase::catchRoutineFor):
(NativeExecutable):

  • runtime/JSValue.h:

(JSC):
(LLInt):
(JSValue):

  • runtime/JSValueInlineMethods.h:

(JSC):
(JSC::JSValue::JSValue):

  • runtime/Options.cpp:

(JSC::Options::initialize):

Source/WTF:

Added configs for the llint C loop backend.

  • wtf/Platform.h:
10:22 AM Changeset in webkit [127373] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled back in a piece of <​http://trac.webkit.org/changeset/127293>.

Shrink activation objects by half
​https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

9:14 AM Changeset in webkit [127372] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Added #include <JavaScriptCore/Identifier.h>.
​https://bugs.webkit.org/show_bug.cgi?id=95641.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.

The code references JSC::Indentifier but was previously depending on
someone else to #include it. This results in build problems when
building for the llint C loop configuration.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
7:42 AM Changeset in webkit [127371] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the --minimal build after r127327
​https://bugs.webkit.org/show_bug.cgi?id=95639

Unreviewed attempt to fix Qt minimal build.

  • css/StyleBuilder.cpp:
7:02 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
7:01 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
3:51 AM Changeset in webkit [127370] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Gtk] No accessible caret-moved events found in certain content
​https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to expected accessible objects of DivRole
and ParagraphRole being ignored, in favor of including child blocks.

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAnonymousBlockChild):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
New method to return the first child which is an anonymous block.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Include paragraphs and divs which contain a non-nested anonymous block.

LayoutTests:

Added new test to verify that paragraphs and divs which contain anonymous
blocks are included in the accessible object hierarchy and have the correct
number of children with the expected role.

  • platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
  • platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.
3:47 AM Changeset in webkit [127369] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, rebaselining an accessibility test.

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
1:53 AM Changeset in webkit [127368] by zandobersek@gmail.com
  • 8 edits
    2 adds in trunk

[Gtk] No accessible caret-moved events found in certain content
​https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to extraneous accessible objects resulting
from unignored inline and block spans.

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(roleIsTextType): Add ListItem to the roles which should implement AtkText.

LayoutTests:

Added new test, updated the results of one test to reflect the fix,
corrected a test with a mismatched element tag.

  • platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
  • platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
  • platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
  • platform/gtk/accessibility/spans-expected.txt: Added.
  • platform/gtk/accessibility/spans.html: Added.
1:43 AM Changeset in webkit [127367] by zandobersek@gmail.com
  • 8 edits
    4 adds in trunk

[Gtk] Incorrect/unexpected characters in the text of certain accessibles
​https://bugs.webkit.org/show_bug.cgi?id=95180

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

The bug was caused by failing to properly handle anonymous block text
which had object replacement characters (multibyte) in it. Calculating
the string length based on the UTF-8 string meant that we were returning
more characters than were there and in danger of splitting a multibyte
character.

Tests: platform/gtk/accessibility/entry-and-password.html

platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetText): Convert the text returned by textForObject()
to Unicode before calculating its length.

Source/WebKit/gtk:

Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.

  • tests/testatk.c:

(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.

Tools:

The bug that was fixed stood in the way of fully implementing stringValue().
Testing that the bug is fixed requires stringValue() to be fully implemented
and object replacement characters to be printable.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(replaceCharactersForResults): New method which turns object replacement
characters into "<obj>" so that the characters can be properly shown in
Layout Test results. Also turns "\n" into "<
n>" so that printing the
accessible text of a single object in the accessible tree doesn't mess up
the readibility of the results.
(AccessibilityUIElement::stringValue): Remove the code that immediately
returned upon encountering an object of ATK_ROLE_PANEL and call the new
replaceCharactersForResults() prior to returning the accessible string
value.

LayoutTests:

Two new layout tests, plus one updated one.

  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
  • platform/gtk/accessibility/entry-and-password-expected.txt: Added.
  • platform/gtk/accessibility/entry-and-password.html: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.
1:20 AM Changeset in webkit [127366] by abarth@webkit.org
  • 17 edits in trunk/Source/WebCore

Remove all-but-one use of WTF::String::operator+= from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=95508

Reviewed by Benjamin Poulain.

This patch removes all the uses of WTF::String::operator+= from
WebCore, except those in WorkerScriptLoader (which need a more delicate
patch). There were actually a handful of legitimate use cases for += in
this group. I've replaced them with calls to String::append rather than
+= so that we can remove += and encourage most contributors to use
more efficient string idioms.

(There are likely some more uses in WebCore hiding in port-specific
code---this patch covers only those call sites found when compiling the
chromium-mac port.)

  • inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty):

  • This complicated function looks really inefficient, but I didn't have the heart to rewrite it.
  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::data):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureSVGFontData):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::data):

  • This decoder/flush pattern can probably be improved by combining the decode and flush operations, but I didn't do that in this patch.
  • page/FrameTree.cpp:

(WebCore::FrameTree::uniqueChildName):

  • I found this code very amusing. It's worried enough about efficiency to give a big speech about why snprintf is safe, but then it implicitly performs a large number of mallocs and memcpy operations.
  • page/Page.cpp:

(WebCore::Page::userStyleSheet):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):

  • This header-appending idiom looks like a reasonable use case for String::append.
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::setRequestHeaderInternal):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunTranslate::evaluate):

  • Fixes 6 year old FIXME.
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append):

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::doEnd):

  • Changed m_originalSourceForTransform to a SegmentedString so that we don't need to malloc and copy the entire document every time we get more data from the network.
12:54 AM Changeset in webkit [127365] by tommyw@google.com
  • 22 edits
    2 adds in trunk

MediaStream API: Add MediaStream management to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=95543

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamCenter.h:

(WebMediaStreamCenter):

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

This includes addStream/removeStream to RTCPeerConnection,
as well as didAddRemoteStream/didRemoveRemoteStream to RTCPeerConnectionHandlerClient.

Test: fast/mediastream/RTCPeerConnection-AddRemoveStream.html

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::localStreams):
(WebCore::RTCPeerConnection::remoteStreams):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

  • bindings/v8/Dictionary.h:

(Dictionary):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::removeStream):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

  • platform/mediastream/RTCPeerConnectionHandlerClient.h:

(WebCore):
(RTCPeerConnectionHandlerClient):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::removeStream):
(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream):
(WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html: Added.
12:49 AM Changeset in webkit [127364] by jonlee@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

[Tests] Add a test for all notification events
​https://bugs.webkit.org/show_bug.cgi?id=95609
<rdar://problem/12218309>

Reviewed by Jessie Berlin.

This test tests for the onshow, onclick, and onclose events. onerror is called only if the
origin did not have permission to show the notification, and that is covered in
http/tests/notifications/{legacy,}/show.html.

  • http/tests/notifications/events-expected.txt: Added.
  • http/tests/notifications/events.html: Added.
  • http/tests/notifications/legacy/events-expected.txt: Added.
  • http/tests/notifications/legacy/events.html: Added.
12:45 AM Changeset in webkit [127363] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

2012-09-01 Geoffrey Garen <​ggaren@apple.com>

Rolled back in a piece of <​http://trac.webkit.org/changeset/127293>.

Shrink activation objects by half
​https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::setGlobalThis): (JSC): (JSC::JSGlobalObject::visitChildren):
  • runtime/JSGlobalObject.h: (JSGlobalObject): (JSC::JSScope::globalThis): (JSC): (JSC::JSGlobalObject::globalThis):
  • runtime/JSNameScope.h: (JSC::JSNameScope::JSNameScope):
  • runtime/JSScope.cpp: (JSC::JSScope::visitChildren):
  • runtime/JSScope.h: (JSScope): (JSC::JSScope::JSScope): (JSC::JSScope::globalObject): (JSC::JSScope::globalData):
  • runtime/JSSegmentedVariableObject.h: (JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
  • runtime/JSSymbolTableObject.h: (JSC::JSSymbolTableObject::JSSymbolTableObject):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::JSVariableObject):
  • runtime/JSWithScope.h: (JSC::JSWithScope::JSWithScope):
  • runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::StrictEvalActivation):
12:38 AM Changeset in webkit [127362] by jonlee@apple.com
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

[Tests] Move fast/notifications/notifications-event-listener-crash.html to http/tests/notifications
​https://bugs.webkit.org/show_bug.cgi?id=95535
<rdar://problem/12213781>

Reviewed by Jessie Berlin.

This test is among a few that are being migrated from fast/notifications to http/tests/notifications because of permissions.
Since most notifications tests will involve permissions, it is easier to have all of them consolidated in the same directory.

This test has been slightly modified to take advantage of the new testRunner notifications API. The test itself also does not
need to be protected within the window.testRunner check since it does not use that object.

  • fast/notifications/notifications-event-listener-crash-expected.txt: Removed.
  • fast/notifications/notifications-event-listener-crash.html: Removed.
  • http/tests/notifications/event-listener-crash-expected.txt: Added.
  • http/tests/notifications/event-listener-crash.html: Added.
12:29 AM Changeset in webkit [127361] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Touch a file so that Chromium-win bots correctly re-build for OPENTYPE_VERTICAL
​https://bugs.webkit.org/show_bug.cgi?id=51450

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:
12:15 AM Changeset in webkit [127360] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-01 Geoffrey Garen <​ggaren@apple.com>

Rolled back out a piece of <​http://trac.webkit.org/changeset/127293>
because it broke Window inspector tests.

Shrink activation objects by half
​https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

  • runtime/JSActivation.h: (JSActivation):
Note: See TracTimeline for information about the timeline view.