Timeline
Sep 3, 2012:
- 11:37 PM Changeset in webkit [127440] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Port the Qt pixmap JS bindings to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=94702
Reviewed by Kenneth Rohde Christiansen.
Based on patch by Noam Rosenthal.
The conversion uses a simple JSClassRef based binding and only a few
uses of private JSC API for the HTML element DOM bindings remain.
This is essentially used for wrapping QPixmap and QImage types in
JavaScript and the other way around, for retrieving the image data
out of a HTML image element when converting from JS/DOM to Qt.
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::copyPixels):
(JSC::Bindings::toPixmap):
(JSC::Bindings::toImage):
(JSC::Bindings::imageSizeForVariant):
(JSC::Bindings::getPixmapWidth):
(JSC::Bindings::getPixmapHeight):
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::pixmapToImageData):
(JSC::Bindings::pixmapToDataUrl):
(JSC::Bindings::pixmapToString):
(JSC::Bindings::QtPixmapRuntime::toJS):
(JSC::Bindings::QtPixmapRuntime::toQt):
(JSC::Bindings::QtPixmapRuntime::canHandle):
(JSC::Bindings::QtPixmapRuntime::getClassRef):
- bridge/qt/qt_pixmapruntime.h:
(QtPixmapRuntime):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
- 10:26 PM Changeset in webkit [127439] by
-
- 2 edits5 deletes in trunk/LayoutTests
http/tests/incremental/partial-jpeg.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82480
Reviewed by Kent Tamura.
Remove this test: we have a more robust partial load test now in
http/tests/images/jpg-img-partial-load.html
- http/tests/incremental/partial-jpeg-expected.png: Removed.
- http/tests/incremental/partial-jpeg-expected.txt: Removed.
- http/tests/incremental/partial-jpeg.html: Removed.
- http/tests/incremental/resources/checkerboard.jpg: Removed.
- http/tests/incremental/resources/partial-jpeg.php: Removed.
- platform/chromium/TestExpectations:
- 7:19 PM Changeset in webkit [127438] by
-
- 7 edits in trunk/Source/WebCore
Share immutable ElementAttributeData between elements with identical attributes.
<http://webkit.org/b/94990>
Reviewed by Antti Koivisto.
Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
them in elements with identical attribute maps. ElementAttributeData is made ref-counted
to facilitate this. A copy-on-write mechanism is already in place, since mutating call
sites have to go via Element::mutableAttributeData().
The cache is held by Document and cleared in Document::finishedParsing() since the vast
majority of immutable ElementAttributeData will be constructed during parsing.
On the HTML5 spec at <http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
translating into a 3.5MB reduction in memory use.
- dom/Document.cpp:
(WebCore::Document::finishedParsing):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
- dom/Element.h:
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::makeMutable):
- 7:09 PM Changeset in webkit [127437] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: the URL of worker inspector window sometimes is invalid
https://bugs.webkit.org/show_bug.cgi?id=95334
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-03
Reviewed by Pavel Feldman.
In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.
No new tests case for this bug.
- inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._openInspectorWindow):
- 6:44 PM Changeset in webkit [127436] by
-
- 5 edits in trunk/Source
[EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95636
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.
Source/WebCore:
Check if the m_timer is active in stopUpdating()
to know the BatteryProvider is updating or not.
By checking the timer, stopUpdating() will be called
only BatteryProviderEfl is updating.
- platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::stopUpdating):
Source/WebKit/efl:
Invoke stopUpdating() in the destructor of BatteryClinetEfl()
to call e_ukit_shutdown() and e_dbus_shutdown() if and when
stopUpdating() has not been called explicitly.
- WebCoreSupport/BatteryClientEfl.cpp:
(BatteryClientEfl::~BatteryClientEfl):
- WebCoreSupport/BatteryClientEfl.h:
(BatteryClientEfl):
- 6:40 PM Changeset in webkit [127435] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Chromium] Unreviewed test expectations update after r127410
Removed further platform-specific text expectations.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- 6:21 PM Changeset in webkit [127434] by
-
- 4 edits in trunk
[WK2][WTR] Implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=95576
Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-03
Reviewed by Maciej Stachowiak.
Added a line of macro to implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
LayoutTests:
- platform/wk2/Skipped: Removed fast/repaint/no-caret-repaint-in-non-content-editable-element.html test case.
- 3:39 PM Changeset in webkit [127433] by
-
- 1 edit2 deletes in trunk/LayoutTests
[Chromium] Unreviewed test expectations update after r127410
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- 12:14 PM Changeset in webkit [127432] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Not all activated elements highlighted, but some frames are
https://bugs.webkit.org/show_bug.cgi?id=95683
Reviewed by Kenneth Rohde Christiansen.
Use the new function Node::willRespondToMouseClickEvents to better determine if the element
can be tap-activated and avoid documents and frames completely.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
- 12:14 PM WebKitGTK/1.10.x edited by
- r127124 merged (diff)
- 11:38 AM Changeset in webkit [127431] by
-
- 3 edits in trunk/Tools
[EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95689
Reviewed by Kenneth Rohde Christiansen.
In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
So, there are bugs that key events are always generated in url bar although
the user clicked the web view.
This patch recovers the focus of the web view when left button is pressed and
adds for MiniBrowser to toggle the focus when middle button is pressed
like EWebLauncher already did.
- EWebLauncher/main.c:
(on_mouse_down):
- MiniBrowser/efl/main.c:
(on_mouse_down):
(browserCreate):
- 11:37 AM Changeset in webkit [127430] by
-
- 5 edits in trunk
Added ANDROID_GDBSERVER definition for Ant
https://bugs.webkit.org/show_bug.cgi?id=95265
Patch by Tao Bai <michaelbai@chromium.org> on 2012-09-03
Reviewed by Adam Barth.
ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
is only used for finding the gdbserver.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 10:16 AM Changeset in webkit [127429] by
-
- 19 edits3 adds6 deletes in trunk
Unreviewed, rolling out r127427.
http://trac.webkit.org/changeset/127427
https://bugs.webkit.org/show_bug.cgi?id=95695
Breaks some inspector/debugger tests on JSC (Requested by
vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
- inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
- inspector/front-end/StylesUISourceCodeProvider.js: Added.
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/workspace-test.js: Removed.
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-script-tag-expected.txt:
- inspector/debugger/dynamic-script-tag.html:
- inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
- inspector/debugger/network-uisourcecode-provider.html: Removed.
- inspector/debugger/raw-source-code-expected.txt: Added.
- inspector/debugger/raw-source-code.html: Added.
- inspector/debugger/resource-script-mapping-expected.txt: Removed.
- inspector/debugger/resource-script-mapping.html: Removed.
- inspector/debugger/scripts-panel.html:
- 9:50 AM Changeset in webkit [127428] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 9:45 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:44 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:34 AM Changeset in webkit [127427] by
-
- 19 edits1 move5 adds2 deletes in trunk
Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.
Tests: inspector/debugger/network-uisourcecode-provider.html
inspector/debugger/resource-script-mapping.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
- inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):
- inspector/front-end/RawSourceCode.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/workspace-test.js: Added.
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-script-tag-expected.txt:
- inspector/debugger/dynamic-script-tag.html:
- inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
- inspector/debugger/network-uisourcecode-provider.html: Added.
- inspector/debugger/raw-source-code-expected.txt: Removed.
- inspector/debugger/raw-source-code.html: Removed.
- inspector/debugger/resource-script-mapping-expected.txt: Added.
- inspector/debugger/resource-script-mapping.html: Added.
- inspector/debugger/scripts-panel.html:
- inspector/debugger/source-frame-count.html:
- 9:09 AM Changeset in webkit [127426] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Make the injected resourceObject property non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=95682
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-03
Reviewed by Pavel Feldman.
Make the injected auxiliary property resourceObject non-enumerable to hide it from for..in iterations.
Ideally this property should be completely hidden from the user's code.
Drive-by: Fix couple of small FIXME's.
- inspector/InjectedScriptWebGLModuleSource.js:
(.):
- 9:08 AM Changeset in webkit [127425] by
-
- 25 edits2 copies5 adds in trunk
MediaStream API: Add Ice-related functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95565
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebRTCICECandidateDescriptor.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h.
(WebCore):
(WebKit):
(WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::~WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::operator=):
(WebKit::WebRTCICECandidateDescriptor::isNull):
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
- chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit):
(WebRTCPeerConnectionHandlerClient):
Source/WebCore:
Adds all Ice-related functionality to RTCPeerConnection, including
events, callbacks and methods.
Test: fast/mediastream/RTCPeerConnection-ice.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCIceCandidateEvent.cpp: Added.
(WebCore):
(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::candidate):
(WebCore::RTCIceCandidateEvent::interfaceName):
- Modules/mediastream/RTCIceCandidateEvent.h: Added.
(WebCore):
(RTCIceCandidateEvent):
- Modules/mediastream/RTCIceCandidateEvent.idl: Added.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::updateIce):
(WebCore):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didChangeIceState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeIceState):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- WebCore.gypi:
- dom/EventNames.h:
(WebCore):
- dom/EventNames.in:
- platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.
(WebKit):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::assign):
(WebKit::WebRTCICECandidateDescriptor::reset):
(WebKit::WebRTCICECandidateDescriptor::initialize):
(WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
(WebKit::WebRTCICECandidateDescriptor::candidate):
(WebKit::WebRTCICECandidateDescriptor::sdpMid):
(WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):
- platform/mediastream/RTCIceCandidateDescriptor.h:
(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
(WebCore):
(RTCPeerConnectionHandlerClient):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::updateIce):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
Tools:
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::updateICE):
(MockWebRTCPeerConnectionHandler::addICECandidate):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
LayoutTests:
- fast/mediastream/RTCPeerConnection-ice-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-ice.html: Added.
- 8:59 AM Changeset in webkit [127424] by
-
- 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore
Merge r127124 - 1.9.90 drops symbols, breaking compatibility
https://bugs.webkit.org/show_bug.cgi?id=93477
Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-30
Reviewed by Martin Robinson.
Add a bunch of compatibility methods to the GObject DOM bindings
to cope with recent renames.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_element_get_class_list):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):
- bindings/gobject/WebKitDOMCustom.h:
- 8:19 AM WebKitGTK/1.10.x edited by
- Fix initial branch revision (diff)
- 7:57 AM Changeset in webkit [127423] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r127421
- rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):
- 7:48 AM Changeset in webkit [127422] by
-
- 6 edits4 adds in trunk/Source/WebKit2
[EFL][WK2] Add ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=91206
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.
Add the ewk_settings which wraps the WKPreferencesRef.
The ewk_settings will be created by the ewk_view and it will be
destroyed when the ewk_view is destroyed. I make each view to have
its own group to make one ewk_settings sets preferences only for
one ewk_view.
The application can get the ewk_settings from ewk_view using
ewk_view_settings_get() API.
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_settings.cpp: Added.
(ewk_settings_enable_scripts_set):
(ewk_settings_enable_scripts_get):
(ewk_settings_auto_load_images_set):
(ewk_settings_auto_load_images_get):
- UIProcess/API/efl/ewk_settings.h: Added.
- UIProcess/API/efl/ewk_settings_private.h: Added.
(_Ewk_Settings):
(_Ewk_Settings::_Ewk_Settings):
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_settings_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp: Added.
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 7:41 AM Changeset in webkit [127421] by
-
- 17 edits in trunk/Source/WebCore
Move AllowShadowContent flag to HitTestRequest
https://bugs.webkit.org/show_bug.cgi?id=95685
Reviewed by Antonio Gomes.
Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
it can read the flag from HitTestRequest instead of from HitTestResult.
No change in functionality. No new tests.
- dom/Document.cpp:
(WebCore::Document::nodesFromRect):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- rendering/HitTestRequest.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
- rendering/HitTestResult.h:
(HitTestLocation):
(HitTestResult):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::nodeAtPoint):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
- 7:15 AM Changeset in webkit [127420] by
-
- 3 edits in trunk/Source/WebKit2
Wheel-events fails temporarily after reload
https://bugs.webkit.org/show_bug.cgi?id=94934
Reviewed by Kenneth Rohde Christiansen.
Set fixed visible content rect using visibleContentBounds instead of WebPage::size. Otherwise the
content rect will be incorrectly set to the entire document size, when resizesToContents is active.
Test: UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml
- UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- 7:01 AM Changeset in webkit [127419] by
-
- 7 edits in trunk
[EFL] Use WebKitVersion.h to get version information
https://bugs.webkit.org/show_bug.cgi?id=95669
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.
.:
WEBKIT_USER_AGENT_MAJOR_VERSION and WEBKIT_USER_AGENT_MINOR_VERSION
are defined as constant in the OptionsEfl.cmake. But we do not need
to define these here but can use the defined constant in WebKitVersion.h.
WebKitVersion.h is already generated with the version information
from the Source/WebCore/Configurations/Version.xcconfig.
- Source/cmake/OptionsEfl.cmake: Do not set WEBKIT_USER_AGENT_* variables.
- Source/cmakeconfig.h.cmake: Remove WEBKIT_USER_AGENT_* definitions
as no more port uses.
Source/WebKit/efl:
Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h
Relocate the StorageTracker.h to keep the sorted order.
- ewk/ewk_settings.cpp:
(ewk_settings_default_user_agent_get):
Source/WebKit2:
Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):
- 6:22 AM Changeset in webkit [127418] by
-
- 5 edits in trunk
Web Inspector: Unhide hidden characters
https://bugs.webkit.org/show_bug.cgi?id=93888
Reviewed by Pavel Feldman.
Source/WebCore:
Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
LayoutTests:
- inspector/elements/elements-panel-structure-expected.txt:
- inspector/elements/elements-panel-structure.html:
- 6:20 AM Changeset in webkit [127417] by
-
- 11 edits1 move in trunk/Source/WebCore
Web Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
https://bugs.webkit.org/show_bug.cgi?id=95677
Reviewed by Yury Semikhatsky.
- renamed the file and the usages
- renamed isolatedContextCreated to executionContextCreated for consistency.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/Inspector.json:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
- inspector/compile-front-end.py:
- inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.
(WebInspector.RuntimeModel):
(WebInspector.RuntimeModel.prototype._frameAdded):
(WebInspector.RuntimeModel.prototype._frameDetached):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.executionContextCreated):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 4:53 AM WebKitGTK/1.10.x edited by
- (diff)
- 4:17 AM WebKitGTK/1.10.x edited by
- (diff)
- 3:44 AM LineBreakingCSS3Mapping edited by
- Further update on 2010/2013. (diff)
- 3:43 AM LineBreakingCSS3Mapping edited by
- Update ICU(*) columns for BA class. Add issue needing verification. (diff)
- 3:26 AM Changeset in webkit [127416] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Unskipping message-port-close.html after bug 85811 was resolved.
- platform/efl/TestExpectations:
- 2:56 AM Changeset in webkit [127415] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
https://bugs.webkit.org/show_bug.cgi?id=95540
Reviewed by Pavel Feldman.
Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
fix closure compiler warning.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):
- 2:45 AM Changeset in webkit [127414] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fixed front-end compilation warnings.
Not reviewed.
- inspector/front-end/FilteredItemSelectionDialog.js:
- inspector/front-end/HeapSnapshotView.js:
- 2:42 AM Changeset in webkit [127413] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: paint grid on top of box highlight.
https://bugs.webkit.org/show_bug.cgi?id=95676
Reviewed by Alexander Pavlov.
Otherwise, ruler numbers are not visible when selecting body.
- inspector/InspectorOverlayPage.html:
- 1:54 AM Changeset in webkit [127412] by
-
- 6 edits in trunk
Web Inspector: get rid of context execution id fallback.
https://bugs.webkit.org/show_bug.cgi?id=95567
Reviewed by Yury Semikhatsky.
Source/WebCore:
We now assign execution context id upon changes in the UI.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContextList):
(WebInspector.ConsoleView.prototype._contextListRemoved):
(WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
(WebInspector.ConsoleView.prototype._appendExecutionContextOption):
(WebInspector.ConsoleView.prototype._executionContextChanged):
(WebInspector.ConsoleView.prototype._contextListUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
- inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contextLists):
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.FrameExecutionContextList):
(WebInspector.FrameExecutionContextList.prototype._frameNavigated):
(WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
(WebInspector.FrameExecutionContextList.prototype.executionContexts):
(WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):
LayoutTests:
- http/tests/inspector/console-cd-completions.html:
- http/tests/inspector/console-cd.html:
- 1:50 AM Changeset in webkit [127411] by
-
- 5 edits in trunk/Tools
[EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95670
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.
Fix layout issues related to the URL bar in Minibrowser
and EWebLauncher when the window is resized.
The URL bar was not resized accordingly and the Web
page was moved behing the URL bar, hiding part of it.
- EWebLauncher/main.c:
(on_ecore_evas_resize):
(closeWindow):
- EWebLauncher/url_bar.c:
(url_bar_width_set):
(url_bar_add):
- EWebLauncher/url_bar.h:
- MiniBrowser/efl/main.c:
(on_ecore_evas_resize):
(main):
- 1:39 AM Changeset in webkit [127410] by
-
- 2 edits15 adds in trunk/LayoutTests
Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:35 AM Changeset in webkit [127409] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark http/tests/incremental/slow-utf8-text.pl as flaky
https://bugs.webkit.org/show_bug.cgi?id=95673
Unreviewed EFL gardening.
Mark http/tests/incremental/slow-utf8-text.pl as flaky
as it does not always time out.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
- platform/efl/TestExpectations:
- 1:34 AM Changeset in webkit [127408] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.
- interpreter/Interpreter.h:
- 1:30 AM Changeset in webkit [127407] by
-
- 2 edits5 deletes in trunk/LayoutTests
Unreviewed, rolling out r127406.
http://trac.webkit.org/changeset/127406
https://bugs.webkit.org/show_bug.cgi?id=95674
Expectation images are missing (Requested by yosin1 on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium/TestExpectations:
- 1:22 AM Changeset in webkit [127406] by
-
- 2 edits5 adds in trunk/LayoutTests
Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:18 AM Changeset in webkit [127405] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage API test
https://bugs.webkit.org/show_bug.cgi?id=95671
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.
Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage
API test since it is flaky on the bots.
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
- 1:16 AM Changeset in webkit [127404] by
-
- 4 edits in trunk
[GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
https://bugs.webkit.org/show_bug.cgi?id=95436
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
To properly handle spellchecking of each word we need to iterate over the all available
dictionaries ('dictIter').
To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
of vector while spellchecking of the word. This ensures performing of spelling for word based on
at least one dictionary.
- platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.
LayoutTests:
'checkSpellingOfString' from the TextCheckerEnchant class can not mark multiplie words that are misspelled.
It's possible to mark misspeled string only by defining its location and length.
- platform/gtk/TestExpectations: Added spelling-backspace-between-lines.html to TestExpectations.
- 1:14 AM Changeset in webkit [127403] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Mark several inspector test as flaky
https://bugs.webkit.org/show_bug.cgi?id=95667
Unreviewed EFL gardening.
Mark several inspector test cases as flaky on
WebKit2 EFL.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
- platform/efl-wk2/TestExpectations:
- 12:35 AM Changeset in webkit [127402] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update TestExpectations for 2 fast/block tests
https://bugs.webkit.org/show_bug.cgi?id=95666
Unreviewed EFL gardening.
Update TestExpectations for 2 fast/block tests to
indicate that we expect TEXT only diff on the bot
since we don't run pixel tests.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
- platform/efl/TestExpectations:
Sep 2, 2012:
- 11:57 PM Changeset in webkit [127401] by
-
- 2 edits in trunk/Source/WebKit2
WK2: Build failure on SnowLeopard after r127384
https://bugs.webkit.org/show_bug.cgi?id=95665
Reviewed by Dan Bernstein.
Add SandboxExtension::consumePermanently(const Handle&) for !ENABLE(WEB_PROCESS_SANDBOX) to fix link error.
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):
- 11:03 PM Changeset in webkit [127400] by
-
- 3 edits in trunk/Source/WebCore
[Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
https://bugs.webkit.org/show_bug.cgi?id=95660
Reviewed by Kent Tamura.
This patch changes visible empty value of AM/PM field in multiple
fields time input UI to "-", "--", "---", and so on based on maximum
length of AM/PM labels. In current implementation, it is always "--"
regardless locale, although on Arabic, AM/PM are represented in one
character.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(makeVisibleEmptyValue): Build visible empty value from maximum length
of labels.
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
use m_visibleEmptyValue.
- html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement): Added new member variable
m_visibleEmptyValue to hold visible empty value.
- 10:51 PM Changeset in webkit [127399] by
-
- 5 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed test expectation update after r127398
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- 9:03 PM Changeset in webkit [127398] by
-
- 4 edits in trunk/Source/WebCore
[Forms] AM/PM field of multiple fields time input UI should be fixed width
https://bugs.webkit.org/show_bug.cgi?id=95542
Reviewed by Kent Tamura.
This patch changes width of AM/PM field of multiple field time input
UI fixed as maximum width of labels or "--".
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.
- css/html.css:
(input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
Added "text-align" property to "center".
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.
- html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
(WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
(DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().
- 7:04 PM Changeset in webkit [127397] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu()
https://bugs.webkit.org/show_bug.cgi?id=95355
Reviewed by Gyuyoung Kim.
Efl does not have a proper way to support nested loop so that applications
may change value after showPopupMenu() is finished.
- UIProcess/API/efl/tests/test_ewk2_view.cpp: Improved test case to cover this bug.
(selectItemAfterDelayed):
(showPopupMenu):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
Guard with !PLATFORM(EFL) to keep the activePopupMenu valid to call valueChangedForPopupMenu
outside showPopupMenu().
- 6:05 PM Changeset in webkit [127396] by
-
- 6 edits5 adds9 deletes in trunk/LayoutTests
[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
https://bugs.webkit.org/show_bug.cgi?id=95545
Reviewed by Kent Tamura.
This patch changes test expectations to text output and pixel images
instead of structure of render tree and pixel images for multiple
fields time input UI. This patch helps us to avoid rebaseline when
we change DOM structure but keep appearance.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Changed to call testRunner.dumpAsText().
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- 5:24 PM Changeset in webkit [127395] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectation update after r127362
- platform/chromium/TestExpectations: Moved
fast/notifications/notifications-event-listener-crash.html to
http/tests/notifications.
- 4:52 PM WebKitGTK/1.10.x edited by
- (diff)
- 4:45 PM Changeset in webkit [127394] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fixed failures seen on Linux bots.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_push_with_scope):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_push_with_scope):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: push_*_scope doesn't have a destination operand anymore.
Accordingly, update these places in the baseline JIT, which I missed in my last patch.
- 2:27 PM Changeset in webkit [127393] by
-
- 16 edits in trunk/Source/JavaScriptCore
Refactored scope chain opcodes to support optimization for named function expressions
https://bugs.webkit.org/show_bug.cgi?id=95658
Reviewed by Sam Weinig.
Renamed
push_scope => push_with_scope
push_new_scope => push_name_scope
to clarify the difference between them.
Changed push_with_scope and push_name_scope not to save the new scope in
a temporary register, since doing so made optimization harder.
(The old behavior was a hold-over from when the scope chain wasn't
a GC object, and wouldn't be marked otherwise. Now, the scope chain is
marked because it is a GC object pointed to by the call frame.)
Changed push_name_scope to accept an operand specifying the attributes
for the named property, instead of assuming DontDelete, because a named
function expression needs ReadOnly|DontDelete.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::highestUsedRegister): Removed this function,
which used to be related to preserving saved scope object temporaries,
because it had no callers.
- 1:26 PM Changeset in webkit [127392] by
-
- 2 edits in trunk/Source/WebCore
Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
https://bugs.webkit.org/show_bug.cgi?id=95301
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-02
Reviewed by Darin Adler.
The static string convertedSpaceString() had a couple of annoying side effects:
-The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
-The string was kept in the heap for no particular reason.
This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.
The patch also make the binary a tiny bit smaller (700 bytes).
- editing/HTMLInterchange.cpp:
(WebCore::convertHTMLTextToInterchangeFormat):
- 11:57 AM Changeset in webkit [127391] by
-
- 2 edits in trunk/Source/WebCore
Build is broken when SVG is disabled.
https://bugs.webkit.org/show_bug.cgi?id=95653
Patch by Mike West <mkwst@chromium.org> on 2012-09-02
Reviewed by Dirk Schulze.
Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 10:43 AM Changeset in webkit [127390] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Add missing semicolon at the end of some lines.
https://bugs.webkit.org/show_bug.cgi?id=95640
Patch by Byungwoo Lee <bw80.lee@gmail.com> on 2012-09-02
Reviewed by Gyuyoung Kim.
EWK_VIEW_PRIV_GET_OR_RETURN macro and other related macro can be used
without semicolon, because it ends with a semicolon or complete block.
This can make a human mistake about missing semicolon.
Fixed the macros to require semicolon, and added missing semicolons.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_initialize):
- 10:09 AM Changeset in webkit [127389] by
-
- 4 edits1 move in trunk/LayoutTests
fast/html/marquee-alternate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=94130
Patch by Jessie Berlin <jberlin@apple.com> on 2012-09-02
Reviewed by Simon Fraser.
Disable the test because it is flakey on so many platforms. Remove it from the Skipped and
TestExpectations files so that run-webkit-tests doesn't go looking for it.
- fast/html/marquee-alternate.html-disabled: Renamed from LayoutTests/fast/html/marquee-alternate.html.
- platform/chromium/TestExpectations:
- platform/efl/Skipped:
- platform/qt-arm/Skipped:
- 3:34 AM Changeset in webkit [127388] by
-
- 4 edits in trunk/Source/WebCore
Repaints should not be deferred after initial page load is complete
https://bugs.webkit.org/show_bug.cgi?id=95480
Reviewed by Simon Fraser
Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy.
This is not the intention of this code.
This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
load has completed. It also cleans up the code slightly.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.
- page/FrameView.cpp:
(WebCore):
Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):
Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.
(WebCore::FrameView::flushDeferredRepaints):
We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
the latter.
(WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
Factor the test for using load time repaint timings to a functions. The test for
initial page load having completed is new.
(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
- page/FrameView.h:
(FrameView):
- 1:34 AM Changeset in webkit [127387] by
-
- 2 edits in trunk/Source/WebCore
Don't create access error strings if there is no access error
https://bugs.webkit.org/show_bug.cgi?id=95652
Reviewed by Adam Barth.
This undoes the 50% performance regression in pdfjs caused by
http://trac.webkit.org/changeset/126165
No new tests because behavior is unchanged.
- bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):
