⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 4, 2012:

11:35 PM Changeset in webkit [127558] by keishi@webkit.org
  • 11 edits
    3 copies
    1 add in trunk/Source

Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
​https://bugs.webkit.org/show_bug.cgi?id=95681

Reviewed by Kent Tamura.

Source/WebCore:

We are moving calendar picker PagePopupClient to WebKit layer so ports
can use their platform native chooser UI if they have one.
DateTimeChooser, DateTimeChooserClient etc. will be reused when we
implement the week picker and month picker.

No new tests. No behavior change. Covered by existing calendar picker tests.

  • WebCore.gypi:
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::~CalendarPickerElement):
(WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
(WebCore):
(WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
(WebCore::CalendarPickerElement::openPopup):
(WebCore::CalendarPickerElement::closePopup):

  • html/shadow/CalendarPickerElement.h:

(CalendarPickerElement):

  • loader/EmptyClients.cpp:

(WebCore):
(WebCore::EmptyChromeClient::openDateTimeChooser):

  • loader/EmptyClients.h:

(EmptyChromeClient):

  • page/ChromeClient.h:

(WebCore):
(ChromeClient):

  • platform/DateTimeChooser.h:

(WebCore):
(DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
(DateTimeChooser):
(WebCore::DateTimeChooser::~DateTimeChooser):

  • platform/DateTimeChooserClient.h:

(WebCore):
(DateTimeChooserClient):
(WebCore::DateTimeChooserClient::~DateTimeChooserClient):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::openDateTimeChooser):

  • src/ChromeClientImpl.h:

(WebCore):
(ChromeClientImpl):

  • src/DateTimeChooserImpl.cpp: Added.

(WebKit):
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::endChooser):
(WebKit::DateTimeChooserImpl::contentSize):
(WebKit::DateTimeChooserImpl::writeDocument):
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
(WebKit::DateTimeChooserImpl::didClosePopup):

  • src/DateTimeChooserImpl.h:

(WebCore):
(WebKit):
(DateTimeChooserImpl):

11:28 PM Changeset in webkit [127557] by mikelawther@chromium.org
  • 3 edits
    2 adds in trunk

CSS3 calc: expressions with 'em' units do not zoom correctly.
​https://bugs.webkit.org/show_bug.cgi?id=95705

Reviewed by Ojan Vafai.

Source/WebCore:

Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
independently. Previously the multiplier and a single scale factor was applied to the expression
as a whole, but this failed to account for expressions involving font relative units. This is
because the multiplier should not be applied to font relative units.

Test: css3/calc/zoom-with-em.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

LayoutTests:

  • css3/calc/zoom-with-em-expected.txt: Added.
  • css3/calc/zoom-with-em.html: Added.
11:07 PM Changeset in webkit [127556] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Prevent compositor ticking if it can't draw
​https://bugs.webkit.org/show_bug.cgi?id=95399

Patch by Brian Anderson <​brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.

Background extensions had an always ticking compositor even though
they couldn't draw. This patch disables the ticks when canDraw is false
and adds a notification mechanism for when canDraw changes states so
we can recover properly.

Tests updated for new interfaces.
Regression test added to make sure ticking stops when canDraw is false.
notifyIfCanDrawChanged test added to make sure notifications are sent
for any changes that might affect canDraw.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::notifyIfCanDrawChanged):
(WebCore):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::initializeRenderer):
(WebCore::CCLayerTreeHostImpl::setViewportSize):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(WebCore::CCLayerTreeHostImpl::resetContentsTexturesPurged):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setCanDraw):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::toString):
(WebCore):
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onCanDrawStateChanged):
(WebCore):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:
10:33 PM Changeset in webkit [127555] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
​https://bugs.webkit.org/show_bug.cgi?id=95800

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-04
Reviewed by Benjamin Poulain.

This patch is a re-spin of part of the patch from
​https://bugs.webkit.org/show_bug.cgi?id=95502, but with the tests
fixed. :)

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):

10:14 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
10:12 PM Changeset in webkit [127554] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Allow the YarrJIT to use the assembler even when useJIT() is false.
Introduce the useYarrJIT() option.
​https://bugs.webkit.org/show_bug.cgi?id=95809.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:

(JSC):

10:12 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
10:08 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Expand "Japanse or Chinese" to "Chinese, Japanese, or Korean". (diff)
9:53 PM Changeset in webkit [127553] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged
​https://bugs.webkit.org/show_bug.cgi?id=95701

Reviewed by Kent Tamura.

Source/WebCore:

MediaSlider and MediaVolumeSlider thumbs didn't match mouse when dragged because of the negative margin applied to the thumb.

Test: platform/chromium/media/media-volume-slider-hit-test.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint): Account for margins when calculating the position.

LayoutTests:

  • platform/chromium/media/media-volume-slider-hit-test-expected.txt: Added.
  • platform/chromium/media/media-volume-slider-hit-test.html: Added.
9:40 PM Changeset in webkit [127552] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Use explicit constructor in InjectedBundle.
​https://bugs.webkit.org/show_bug.cgi?id=95746

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-04
Reviewed by Sam Weinig.

Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

9:27 PM Changeset in webkit [127551] by tkent@chromium.org
  • 5 edits in trunk/LayoutTests

[Chromium] Update test expectation
​https://bugs.webkit.org/show_bug.cgi?id=95395

  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium/TestExpectations:
9:16 PM Changeset in webkit [127550] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectatino update.

  • platform/chromium/TestExpectations:

japanese-ruby-vertical-*.html might be flaky on Windows too.

9:14 PM Changeset in webkit [127549] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Add a const version of RenderBox::computeLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=95787

Reviewed by Ojan Vafai.

After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
to make it clear that it is modifying values.

No new tests, this should just be a refactor.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
(WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
(WebCore::RenderBox::computeLogicalHeightUsing): Make const.
(WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
(WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
is already using a const_cast.

  • rendering/RenderBox.h:

(RenderBox): Add const to method signatures.

8:57 PM Changeset in webkit [127548] by krit@webkit.org
  • 3 edits
    2 adds in trunk

-webkit-clip-path does not apply origin for polygon()
​https://bugs.webkit.org/show_bug.cgi?id=95656

Reviewed by Tim Horton.

Source/WebCore:

The polygon() shape function did not apply origin of bouding box on created path. The shape was
not moved to the correct position.

Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg

svg/clip-path/clip-path-shape-polygon-relative.svg

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::path): Apply origin of bounding box.

LayoutTests:

Check that the origin of the bounding box gets applied to the clip path.

  • svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
8:45 PM Changeset in webkit [127547] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Have NRWT log more output when crash logs are missing
​https://bugs.webkit.org/show_bug.cgi?id=95814

Reviewed by Dan Bernstein.

Log the stderr and stdout of the test, in order to provide slightly more
context when the WebProcess times out while running tests.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

8:33 PM Changeset in webkit [127546] by bashi@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127534

  • platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
7:48 PM Changeset in webkit [127545] by jchaffraix@webkit.org
  • 1 edit
    1 copy in branches/chromium/1229

Merge 127520 - REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
​https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

  • ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

TBR=​jchaffraix@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10908086

7:36 PM Changeset in webkit [127544] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

inc/dec behave incorrectly operating on a resolved const
​https://bugs.webkit.org/show_bug.cgi?id=95815

Reviewed by Geoff Garen.

Source/JavaScriptCore:

There are two bugs here.

(1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code.

However if the value being incremented is not a primitive & has a valueOf conversion, then this should be being called.

(2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then

add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const
value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we
need to use a temporary location.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):

  • always at least perform a toNumber conversion, use tempDestination when reducing inc/dec to an add +/-1.

LayoutTests:

Added test cases.

  • fast/js/inc-const-valueOf-expected.txt: Added.
  • fast/js/inc-const-valueOf.html: Added.
  • fast/js/script-tests/inc-const-valueOf.js: Added.

(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):

test that 'a++' results in a valueOf call, where 'a' is const.

(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):

test that '++a' results in a valueOf call, where 'a' is const.

(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):

test that 'b = ++a' does not erroneously update 'b', where 'a' is const.

7:28 PM Changeset in webkit [127543] by tkent@chromium.org
  • 71 edits
    8 copies
    1 move
    25 adds
    4 deletes in trunk/LayoutTests

[Chromium] Test expectation update

Rebaseline vertical-writing tests.

  • platform/chromium-linux-x86/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
  • platform/chromium-mac/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt.
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-win-xp/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
  • platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/chromium-win/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-win/fast/text/international/text-spliced-font-expected.txt:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png:
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-win/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/chromium/TestExpectations:
6:55 PM Changeset in webkit [127542] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky media/video tests on Windows. Adding to skip list.
​https://bugs.webkit.org/show_bug.cgi?id=95806

  • platform/win/Skipped:
6:45 PM Changeset in webkit [127541] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list.
​https://bugs.webkit.org/show_bug.cgi?id=95805

  • platform/win/Skipped:
6:43 PM Changeset in webkit [127540] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
​https://bugs.webkit.org/show_bug.cgi?id=95798

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-04
Reviewed by Eric Seidel.

Source/WebCore:

This patch makes the chromium-linux port build without
WTF::String::operator+=. There are a couple places that require some
more careful study, and I've whitelisted those uses by defining
WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
​https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
WTF_DEPRECATED_STRING_OPERATORS.)

  • css/StylePropertySet.cpp:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawNodeHighlight):

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):

Source/WebKit/chromium:

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::keyboardShortcut):

  • Remove use of WTF::String::operator+=
  • src/WebPageSerializerImpl.cpp:
    • Whitelist use of WTF::String::operator+=. Remove this use will take some more careful thought.
6:38 PM Changeset in webkit [127539] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
​https://bugs.webkit.org/show_bug.cgi?id=95803

  • platform/win/Skipped:
6:31 PM Changeset in webkit [127538] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Use TrackedRendererListHashSet typedef for percentHeightDescendants()
​https://bugs.webkit.org/show_bug.cgi?id=95791

Reviewed by Ojan Vafai.

There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.

No new tests, this is just a refactor.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):

6:30 PM Changeset in webkit [127537] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky inspector tests on Windows. Adding to skip list.
​https://bugs.webkit.org/show_bug.cgi?id=95802

  • platform/win/Skipped:
6:27 PM Changeset in webkit [127536] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
​https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Rolling back in after fixing the negative index case.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:56 PM Changeset in webkit [127535] by commit-queue@webkit.org
  • 13 edits
    3 deletes in trunk/Source

IndexedDB: remove final createIndex backend glue
​https://bugs.webkit.org/show_bug.cgi?id=95385

Patch by Alec Flett <​alecflett@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Source/WebCore:

Remove all code that created index keys in the IndexedDB backend.

No new tests, this is just removal of dead code.

  • Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed.
  • Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed.
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • storage/chromium/IDBKeyPathBackendImpl.cpp: Removed.

Source/WebKit/chromium:

Remove chromium glue for old key-generation code.

  • public/WebIDBKey.h:

(WebIDBKey):

  • src/WebIDBKey.cpp:
5:40 PM Changeset in webkit [127534] by commit-queue@webkit.org
  • 8 edits
    1 copy
    4 adds in trunk

Frame element doesn't always unload its child frame.
​https://bugs.webkit.org/show_bug.cgi?id=94717

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2012-09-04
Reviewed by Hajime Morita.

Source/WebCore:

It's possible for a frame element that has been removed from the document
to retain an active child frame. This inconsistent state may become a source
of security vulnerabilities.

The patch adds a global HashSet to store the nodes currently processed by
ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
the processing is complete.

Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
followed by the actual removal.

Test: fast/frames/out-of-document-iframe-has-child-frame.html

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
(WebCore::ContainerNode::removeChild): Rearrange some event firing code.
(WebCore::ContainerNode::removeChildren): Ditto.

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::rootNodes):
(WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
(WebCore::ChildFrameDisconnector::nodeHasDisconnector):
(WebCore):

  • dom/Node.cpp:

(WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.

LayoutTests:

  • fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
  • fast/frames/out-of-document-iframe-has-child-frame.html: Added.
  • fast/innerHTML/innerHTML-iframe-expected.txt:
  • platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
  • platform/chromium/fast/innerHTML: Added.
  • platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
5:28 PM Changeset in webkit [127533] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation update after r127457

  • platform/chromium/TestExpectations:
5:25 PM Changeset in webkit [127532] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list.
It fails on both Windows and Mac: ​https://bugs.webkit.org/show_bug.cgi?id=94374.

  • platform/win/Skipped:
5:23 PM Changeset in webkit [127531] by mrowe@apple.com
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

5:21 PM Changeset in webkit [127530] by mrowe@apple.com
  • 1 copy in tags/Safari-536.26.13

New tag.

5:21 PM Changeset in webkit [127529] by mrowe@apple.com
  • 1 delete in tags/Safari-536.26.13

Remove tag.

5:18 PM Changeset in webkit [127528] by mrowe@apple.com
  • 1 edit in branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Build fix.

5:09 PM Changeset in webkit [127527] by roger_fong@apple.com
  • 7 edits in trunk/LayoutTests

Unreviewed. Rebaseline tests after ​http://trac.webkit.org/changeset/127354.

  • platform/win/fast/text/international/text-spliced-font-expected.txt:
  • platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
5:07 PM Changeset in webkit [127526] by bashi@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Attempt to fix build failure on Win

Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi,
which was added in r127501, but doesn't exist. Unreviewed.

  • Platform.gypi:
4:58 PM Changeset in webkit [127525] by weinig@apple.com
  • 19 edits
    1 move in trunk/Source

Part 1 of removing PlatformString.h, move remaining functions to new homes
​https://bugs.webkit.org/show_bug.cgi?id=95702

Reviewed by Beth Dakin.

Source/WebCore:

Move utf8Buffer() to SharedBuffer.h/cpp
Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Update projects.

  • platform/text/TextAllInOne.cpp:

Add TextBreakIterator.cpp.

  • editing/Editor.h:

Forward declare SharedBuffer, now that PlatformString.h doesn't.

  • html/InputType.cpp:

#include TextBreakIterator.h.

  • loader/appcache/ApplicationCacheStorage.h:

Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.

  • platform/LocalizedStrings.cpp:

Replace inclusion of PlatformString.h with TextBreakIterator.h

  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:

Move utf8Buffer() here.

  • platform/text/PlatformString.h:

Remove everything except the #include of WTFString.h.

  • platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

  • platform/text/TextBreakIterator.h:

Move numGraphemeClusters() and numCharactersInGraphemeClusters() here.

Source/WebKit2:

  • UIProcess/WebPageProxy.h:

Forward declare SharedBuffer.

4:56 PM Changeset in webkit [127524] by mrowe@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127319.

4:56 PM Changeset in webkit [127523] by mrowe@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127272.

4:56 PM Changeset in webkit [127522] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-536.26-branch

Merge r127047.

4:45 PM Changeset in webkit [127521] by mrowe@apple.com
  • 1 copy in tags/Safari-536.26.13

New tag.

4:39 PM Changeset in webkit [127520] by jchaffraix@webkit.org
  • 3 edits
    1 add in trunk

REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
​https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

  • ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

4:34 PM Changeset in webkit [127519] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in ​http://trac.webkit.org/changeset/126865.
Test added to skip list.

​https://bugs.webkit.org/show_bug.cgi?id=95795

  • platform/win/Skipped:
4:34 PM Changeset in webkit [127518] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
​https://bugs.webkit.org/show_bug.cgi?id=95777

Reviewed by Tony Chang.

IDBRequests are kept alive as long as they may fire events, which includes
if the associated IDBCursor object can be advanced. When the transaction
is finished the IDBCursor is notified which in turn tells the IDBRequest
that the cursor won't be the source of more events. However, if this occurs
and no further events fire the IDBRequest doesn't clear it's "has pending
activity flag". Clear the flag on the notification if the request is
otherwise complete.

No new tests - ActiveDOMObjects and leaks are persnickety.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::finishCursor):

3:53 PM Changeset in webkit [127517] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
​https://bugs.webkit.org/show_bug.cgi?id=93870

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-09-04
Reviewed by Dirk Schulze.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted directly
from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
the author's shader.

[1]: ​https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Add test to check that the DOM element texture blends correctly with the css_MixColor
variable from the author's shader for each blend mode.

  • css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
  • css3/filters/custom/custom-filter-blend-modes.html: Added.
  • css3/filters/resources/mix-color.fs: Added.
3:34 PM Changeset in webkit [127516] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r127503.
​http://trac.webkit.org/changeset/127503
​https://bugs.webkit.org/show_bug.cgi?id=95788

broke some tests (fast/js/dfg-negative-array-index, fast/js
/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-04

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:27 PM Changeset in webkit [127515] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
​https://bugs.webkit.org/show_bug.cgi?id=95783

Reviewed by Antonio Gomes.

Use the correct enum values.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::cachingStrategy):

3:22 PM Changeset in webkit [127514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix style for Event.h
​https://bugs.webkit.org/show_bug.cgi?id=95779

Patch by Nikhil Bhargava <​nbhargava@google.com> on 2012-09-04
Reviewed by Eric Seidel.

Changes indenting for Event.h to match style guidelines for namespaces

  • dom/Event.h:
3:20 PM Changeset in webkit [127513] by jpfau@apple.com
  • 6 edits
    12 adds in trunk

Make plugins respect third-party storage blocking setting
​https://bugs.webkit.org/show_bug.cgi?id=94888

Reviewed by Brady Eidson.

Source/WebCore:

Added functions for discerning if a plugin should be able to access its storage in its current origin.

Tests: http/tests/security/cross-origin-plugin-allowed.html

http/tests/security/cross-origin-plugin.html

  • WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
  • page/SecurityOrigin.h: Added canAccessPluginStorage

(WebCore::SecurityOrigin::canAccessPluginStorage):

Source/WebKit2:

Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context.
(WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context.

LayoutTests:

Created tests for plugins in a third party and first party context when third-party blocking is on and off.

  • http/tests/security/cross-origin-plugin-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-allowed.html: Added.
  • http/tests/security/cross-origin-plugin-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added.
  • http/tests/security/cross-origin-plugin.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added.
  • platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added.
  • platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
3:14 PM Changeset in webkit [127512] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
​https://bugs.webkit.org/show_bug.cgi?id=95770

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver._get_last_stacktrace):
(ChromiumAndroidDriver._get_crash_log):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._start_once.deadlock_detector):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidDriverTest.test_get_crash_log):

3:14 PM Changeset in webkit [127511] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt.
One of the results in the test now passes.

  • platform/win/accessibility/canvas-description-and-role-expected.txt:
2:48 PM Changeset in webkit [127510] by wangxianzhu@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed. Update test expectations for Android.

  • platform/chromium-android/TestExpectations:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
  • platform/chromium/TestExpectations:
2:35 PM Changeset in webkit [127509] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
​https://bugs.webkit.org/show_bug.cgi?id=95632

Reviewed by Abhishek Arya.

Source/WebCore:

Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
and they will never get cleared out during relayout.

Tests: fast/css/intruding-floats-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloatsIfNeeded):

LayoutTests:

  • fast/css/intruding-floats-crash-expected.txt: Added.
  • fast/css/intruding-floats-crash.html: Added.
2:32 PM Changeset in webkit [127508] by msaboff@apple.com
  • 3 edits
    2 adds in trunk

equal() in CSSParser.cpp should check the length of characters
​https://bugs.webkit.org/show_bug.cgi?id=95706

Source/WebCore:

Reviewed by Abhishek Arya.

Pass the length of string literals to CSSParser static functions equal() and
equalIgnoringCase() so that checks won't access out of bounds memory.

Added test fast/css/crash-comparing-equal.html.

  • css/CSSParser.cpp:

(WebCore::equal): Use template to retrieve the length of string literal.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*

LayoutTests:

Added test from duplicate defect ​https://bugs.webkit.org/show_bug.cgi?id=95634.

Reviewed by Abhishek Arya.

  • fast/css/crash-comparing-equal-expected.txt: Added.
  • fast/css/crash-comparing-equal.html: Added.
2:23 PM Changeset in webkit [127507] by satish@chromium.org
  • 2 edits in trunk/Tools

Run git commands within the checkout directory
​https://bugs.webkit.org/show_bug.cgi?id=95742

Reviewed by Eric Seidel.

git commands run from scm/git.py are sometimes run with cwd set to the
checkout_root and other times with whatever directory was the default cwd.
Instead all these should run with the checkout root set as the cwd
(except where we explicitly need a different path)

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git._run_git):
(Git.find_checkout_root):
(Git.discard_local_commits):
(Git.local_commits):
(Git.working_directory_is_clean):
(Git.clean_working_directory):
(Git.add_list):
(Git.delete_list):
(Git.exists):
(Git._current_branch):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git.svn_revision):
(Git._run_git_svn_find_rev):
(Git.contents_at_revision):
(Git.diff_for_file):
(Git.show_head):
(Git.committer_email_for_revision):
(Git.apply_reverse_diff):
(Git.revert_files):
(Git.commit_with_message):
(Git._commit_on_branch):
(Git.svn_commit_log):
(Git.last_svn_commit_log):
(Git.svn_blame):
(Git._branch_ref_exists):
(Git.delete_branch):
(Git.remote_merge_base):
(Git.commit_locally_with_message):
(Git.push_local_commits_to_server):
(Git.commit_ids_from_commitish_arguments):
(Git.commit_message_for_local_commit):
(Git.files_changed_summary_for_commit):

2:21 PM Changeset in webkit [127506] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in ​http://trac.webkit.org/changeset/127035.
​https://bugs.webkit.org/show_bug.cgi?id=95428

  • platform/win/Skipped:
2:19 PM Changeset in webkit [127505] by benjamin@webkit.org
  • 39 edits in trunk/Source/JavaScriptCore

Improve JSC use of Strings after the UString->String change
​https://bugs.webkit.org/show_bug.cgi?id=95633

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

This patch improve the use of strings in the JSC runtime.

The initialization of Identifier is left for future patches.

The improvements are the following:
-5% faster to raise one of the modified exception.
-3 times faster to execute Boolean::toString()

Most of the changes are just about using the new methods
for string literals.

With the changes, the binary on x86_64 gets 176 bytes smaller.

  • API/JSCallbackObjectFunctions.h:

(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):

  • bytecode/CodeBlock.cpp:

(JSC::valueToSourceString):
(JSC::CodeBlock::nameForRegister):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::addStackTraceIfNecessary):

  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/ArrayPrototype.cpp:

(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString): Instead of instanciating new strings, reuse the
keywords available in SmallStrings. Avoiding the creation of the JSString and StringImpl
makes the method significantly faster.

  • runtime/DateConversion.cpp:

(JSC::formatDateTime):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::formateDateInstance):
(JSC::dateProtoFuncToISOString):
Change the way we use snprintf() for clarity and performance.

Instead of allocating one extra byte to put a zero "just in case", we use the size returned
by snprintf().
To prevent any overflow from a programming mistake, we explicitely test for overflow and
return an empty string.

(JSC::dateProtoFuncToJSON):

  • runtime/Error.cpp:

(JSC::createNotEnoughArgumentsError):
(JSC::throwTypeError):
(JSC::throwSyntaxError):

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::create):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):
(JSC::errorProtoFuncToString):
Using a null String is correct because (8) uses jsString(), (9) tests for a length of 0.

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
(JSC::createStackOverflowError):
(JSC::createOutOfMemoryError):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::FunctionExecutable::paramString):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::create):
Using a null String for the name is correct because InternalFunction uses jsString()
to create the name value.

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
There is no need to create an empty string for a null string, jsString() handle both
cases as empty JSString.

  • runtime/JSArray.cpp:

(JSC::reject):
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::put):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation): Same issue as InternalFunction::finishCreation.

(JSC::JSFunction::callerGetter):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler): Use CFSTR() instead of CFStringCreateWithCString().
CFStringCreateWithCString() copy the content and may choose to decode the data.
CFSTR() is much more efficient.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
JSFunction uses jsString() to create the name, we can use null strings instead
of creating empty strings.

(JSC::JSGlobalObject::createThrowTypeError): ditto.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSString.cpp:

Return an empty JSString to avoid the creation of a temporary empty String.

(JSC::JSRopeString::getIndexSlowCase):

  • runtime/JSString.h:

(JSC): Remove the versions of jsNontrivialString() taking a char*. All the callers
have been replaced by calls using ASCIILiteral.

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lex):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncToString):

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpObject.cpp:

(JSC::reject):
(JSC::regExpObjectSource):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • runtime/StringObject.cpp:

(JSC::StringObject::defineOwnProperty):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):

2:16 PM Changeset in webkit [127504] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

2:15 PM Changeset in webkit [127503] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
​https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:10 PM Changeset in webkit [127502] by tonikitoo@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
​https://bugs.webkit.org/show_bug.cgi?id=95778
PR #202252

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>
Internally reviewed by Arvid Nilsson.

Upstream has switch away from using the parent scroll layer's bounds origin
in order to translate contents of all its child layers. Instead now, it directly
sets the scroll position of the child scrollable contents layer.

Source/WebCore:

No new tests, since it is a catch-up with upstreaming code.

Source/WebCore:

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::updateAnimations):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerOverride::LayerOverride):
(LayerOverride):

  • platform/graphics/blackberry/LayerData.h:

(LayerData):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::updateLayersRecursive):

  • platform/graphics/blackberry/LayerWebKitThread.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/blackberry:

Source/WebKit/blackberry:

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

No new tests, since it is a catch-up with upstreaming code.

2:02 PM Changeset in webkit [127501] by tommyw@google.com
  • 19 edits
    7 copies
    6 adds in trunk

MediaStream API: Add the async createOffer functionality to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=95734

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCSessionDescriptionDescriptor.h: Added.

(WebCore):
(WebKit):
(WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::~WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::operator=):
(WebKit::WebRTCSessionDescriptionDescriptor::isNull):

  • chromium/public/WebRTCSessionDescriptionRequest.h: Added.

(WebCore):
(WebKit):
(WebRTCSessionDescriptionRequest):
(ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::~WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::operator=):
(WebKit::WebRTCSessionDescriptionRequest::isNull):

Source/WebCore:

createOffer sends a request to the platform implementer requesting it to gather up all candidates.
This can take some time, therefore the request is async.

Test: fast/mediastream/RTCPeerConnection-createOffer.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCErrorCallback):
(WebCore::RTCErrorCallback::~RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionCallback):
(WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Added.

(WebCore):
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::stop):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionRequestImpl):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCSessionDescriptionDescriptor.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::assign):
(WebKit::WebRTCSessionDescriptionDescriptor::reset):
(WebKit::WebRTCSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::RTCSessionDescriptionDescriptor>):
(WebKit::WebRTCSessionDescriptionDescriptor::initialize):
(WebKit::WebRTCSessionDescriptionDescriptor::type):
(WebKit::WebRTCSessionDescriptionDescriptor::setType):
(WebKit::WebRTCSessionDescriptionDescriptor::sdp):
(WebKit::WebRTCSessionDescriptionDescriptor::setSDP):

  • platform/chromium/support/WebRTCSessionDescriptionRequest.cpp: Added.

(WebKit):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::assign):
(WebKit::WebRTCSessionDescriptionRequest::reset):
(WebKit::WebRTCSessionDescriptionRequest::requestSucceeded):
(WebKit::WebRTCSessionDescriptionRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCSessionDescriptionRequest::extraData):
(WebKit::WebRTCSessionDescriptionRequest::setExtraData):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createOffer):
(WebCore):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCSessionDescriptionDescriptor.h:

(WebCore::RTCSessionDescriptionDescriptor::type):
(WebCore::RTCSessionDescriptionDescriptor::sdp):

  • platform/mediastream/RTCSessionDescriptionRequest.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionRequest):
(ExtraData):
(WebCore::RTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebCore::RTCSessionDescriptionRequest::~RTCSessionDescriptionRequest):
(WebCore::RTCSessionDescriptionRequest::extraData):
(WebCore::RTCSessionDescriptionRequest::setExtraData):
(WebCore::RTCSessionDescriptionRequest::RTCSessionDescriptionRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::createOffer):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::taskList):
(SuccessCallbackTask):
(FailureCallbackTask):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-createOffer.html: Added.
1:58 PM Changeset in webkit [127500] by mitz@apple.com
  • 12 edits in trunk

Reverted r127468 (the fix for <​http://webkit.org/b/93443>) because the test it included caused
an assertion failure in Document::updateStyleIfNeeded().

Source/WebCore:

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
1:41 PM Changeset in webkit [127499] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.12

New Tag.

1:35 PM Changeset in webkit [127498] by Lucas Forschler
  • 9 edits
    2 deletes in branches/safari-536.26-branch

Rollout 127252.

1:34 PM Changeset in webkit [127497] by Simon Fraser
  • 4 edits
    2 adds in trunk

Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
​https://bugs.webkit.org/show_bug.cgi?id=95754

Reviewed by Dave Hyatt.

Source/WebCore:

It's possible to have a renderer with position:fixed or sticky style,
but no layer, for example a RenderScrollBarPart. Don't register such
renderers with the FrameView.

Moved the code that registers/unregisters with the FrameView from
styleWillChange() to styleDidChange(), since in the latter case
we can check if we have a RenderLayer. Only register renderers with layers.
We always unregister, which required removing an assertion in
FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.

Test: fast/css/remove-fixed-resizer-crash.html

  • page/FrameView.cpp:

(WebCore::FrameView::removeFixedObject):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):

LayoutTests:

Testcase with a position:fixed resizer and scrolling.

  • fast/css/remove-fixed-resizer-crash-expected.txt: Added.
  • fast/css/remove-fixed-resizer-crash.html: Added.
1:30 PM Changeset in webkit [127496] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Rollout r127276.

1:30 PM Changeset in webkit [127495] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebCore

ResourceErrorBase needs to identify timeouts
​https://bugs.webkit.org/show_bug.cgi?id=95755

Reviewed by Alexey Proskuryakov.

Adding a property to check whether this ResourceError was raised due to a timeout.
This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
I need to identify some layers up whether the original network problem has been a timeout.

No new tests, no change in behavior yet.

  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::copy): Copying new member.
(WebCore::ResourceErrorBase::compare): Comparing new member.

  • platform/network/ResourceErrorBase.h:

(WebCore::ResourceErrorBase::setIsTimeout): New setter.
(WebCore::ResourceErrorBase::isTimeout): New getter.
(ResourceErrorBase),
(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.

1:25 PM Changeset in webkit [127494] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Rename WebViewClient::handleDisambiguationPopup
​https://bugs.webkit.org/show_bug.cgi?id=95529

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.

  • public/WebViewClient.h:

(WebKit::WebViewClient::didTapMultipleTargets):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

  • tests/WebFrameTest.cpp:
1:22 PM Changeset in webkit [127493] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix memory leak in InputHandler
​https://bugs.webkit.org/show_bug.cgi?id=95771

Reviewed by Rob Buis.

Simply delete the arrays at function exit.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

1:18 PM Changeset in webkit [127492] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

1:14 PM Changeset in webkit [127491] by roger_fong@apple.com
  • 9 edits in trunk/LayoutTests

Unreviewed. Removing accidentally added executable properties on test files.

  • platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable.
  • platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable.
1:05 PM Changeset in webkit [127490] by Lucas Forschler
  • 1 copy in tags/Safari-537.8/trunk

New Tag.

1:03 PM Changeset in webkit [127489] by staikos@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
​https://bugs.webkit.org/show_bug.cgi?id=95766

Reviewed by Rob Buis.

Passing the frame status through will allow the client to make better
decisions about how to act on the onload.

  • Api/WebPageClient.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):

12:59 PM Changeset in webkit [127488] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Output time and thread info in crash log
​https://bugs.webkit.org/show_bug.cgi?id=95768

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.

12:48 PM Changeset in webkit [127487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove use of deprecated QInputMethod method
​https://bugs.webkit.org/show_bug.cgi?id=95741

Patch by Pekka Vuorela <​pvuorela@iki.fi> on 2012-09-04
Reviewed by Simon Hausmann.

Adapt from deprecated QInputMethod::visible() to isVisible().

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):

12:46 PM Changeset in webkit [127486] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
​https://bugs.webkit.org/show_bug.cgi?id=95769

Reviewed by NOBODY (OOPS!).

Also remove WTF prefixes.

  • Api/DumpRenderTreeClient.h:
12:43 PM Changeset in webkit [127485] by tommyw@google.com
  • 16 edits in trunk

MediaStream API: Change the MediaStreamTrackList track added/removed signaling
​https://bugs.webkit.org/show_bug.cgi?id=95721

Reviewed by Adam Barth.

Source/Platform:

Adding the signaling to the WebKit interface.

  • chromium/public/WebMediaStreamCenter.h:

(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):

Source/WebCore:

This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.

Patch covered by expanded existing test.

  • Modules/mediastream/MediaStreamTrackList.cpp:

(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):

  • platform/mediastream/MediaStreamCenter.h:

(MediaStreamCenter):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:

(WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:

(MediaStreamCenterBlackBerry):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):

  • platform/mediastream/chromium/MediaStreamCenterChromium.h:

(MediaStreamCenterChromium):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:

(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

(MediaStreamCenterGStreamer):

Tools:

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:

(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h:

(MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrackList.html:
12:35 PM Changeset in webkit [127484] by zoltan@webkit.org
  • 13 edits in trunk/Source

Extend the coverage of the Custom Allocation Framework in WTF and in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=95737

Reviewed by Eric Seidel.

Add WTF_MAKE_FAST_ALLOCATED macro to the following class declarations because these are instantiated by operator new.

Source/JavaScriptCore:

  • wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
  • heap/MachineStackMarker.cpp:

(MachineThreads::Thread): Thread is instantiated at heap/MachineStackMarker.cpp:196.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(FixedVMPoolExecutableAllocator): FixedVMPoolExecutableAllocator is instantiated at jit/ExecutableAllocatorFixedVMPool.cpp:111

  • parser/SourceProviderCache.h:

(SourceProviderCache): SourceProviderCache is instantiated at parser/SourceProvider.h:49.

  • parser/SourceProviderCacheItem.h:

(SourceProviderCacheItem): SourceProviderCacheItem is instantiated at parser/Parser.cpp:843.

  • runtime/GCActivityCallback.h:

(GCActivityCallback): GCActivityCallback is instantiated at runtime/GCActivityCallback.h:96.

  • tools/CodeProfile.h:

(CodeProfile): CodeProfile is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:140.

Source/WTF:

  • wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
  • wtf/MediaTime.h: MediaTime is instantiated at wtf/MediaTime.cpp:288.
  • wtf/MetaAllocator.h:

(MetaAllocatorTracker): MetaAllocatorTracker is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:120.

  • wtf/ThreadingPthreads.cpp:

(PthreadState): PthreadState is instantiated at wtf/ThreadingPthreads.cpp:165.

  • wtf/text/AtomicString.cpp:

(AtomicStringTable): AtomicStringTable is instantiated at wtf/text/AtomicString.cpp:43.

12:27 PM WebKitGTK/1.10.x edited by jdiggs@igalia.com
(diff)
12:23 PM Changeset in webkit [127483] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
​https://bugs.webkit.org/show_bug.cgi?id=95740

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.

Testing via unit test because a non-flaky layout test crasher could not
be found.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.

Source/WebKit/gtk:

Updated unit test.

  • tests/testatk.c:

(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.

12:11 PM Changeset in webkit [127482] by ojan@chromium.org
  • 2 edits in trunk/Tools

Elide test names when running new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=95626

Patch by Tony Chang <​tony@chromium.org> on 2012-09-04
Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(test_test_status_line): Test for _test_status_line.

11:58 AM Changeset in webkit [127481] by commit-queue@webkit.org
  • 3 edits
    2 moves
    3 adds
    3 deletes in trunk

Automatic features should work in sandboxed iframes if "allow-scripts" flag is set
​https://bugs.webkit.org/show_bug.cgi?id=93961

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04
Reviewed by Adam Barth.

Source/WebCore:

Allow automatic features (video autoplay and form control
autofocus) in a sandboxed iframe that has "allow-scripts"
flag set. This behavior is according to the latest
specification at:
​http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin

This sandboxed automatic features browsing context flag is
relaxed by the same keyword as scripts, because when
scripts are enabled these features are trivially possible
anyway, and it would be unfortunate to force authors to
use script to do them when sandboxed rather than allowing
them to use the declarative features.

Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html

media/auto-play-in-sandbox-with-allow-scripts.html

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

LayoutTests:

Add layout tests to check that automatic features (video
autoplay and form control autofocus) are allowed / working
in sandboxed iframes if the "allow-scripts" flag is set.
This behavior is according to the latest specification at:
​http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin

The tests to check that automatic features are blocked in
sandboxed iframes have been removed since they relied on
the "allow-scripts" flag to work.

  • fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added.
  • fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html.
  • fast/forms/no-autofocus-in-sandbox-expected.txt: Removed.
  • media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added.
  • media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html.
  • media/no-auto-play-in-sandbox-expected.txt: Removed.
  • media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added.
  • media/resources/no-auto-play-in-sandbox-iframe.html: Removed.
11:54 AM Changeset in webkit [127480] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Register scrolling layers with ScrollingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=78862

Patch by Sami Kyostila <​skyostil@google.com> on 2012-09-04
Reviewed by James Robinson.

In order to allow scrollable child layers to be scrolled off the main
thread, register them with the ScrollingCoordinator. These layers are
also removed from the non-fast scrollable region.

Whenever the scroll offset or other scroll geometry related attribute of
a compositor scrolled layer changes, the ScrollingCoordinator is
informed to allow it to update its internal representation of the
scrollable layer.

No tests because the ScrollingCoordinator is currently not testable.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion): Composited scrolling layers
can be scrolled off the main thread.
(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
Callback to ScrollingCoordinator about changes the composited scrolling layers.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::usesCompositedScrolling):

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateScrollingLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

11:46 AM Changeset in webkit [127479] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot
​https://bugs.webkit.org/show_bug.cgi?id=95510

Reviewed by Oliver Hunt.

More refactoring to get rid of ClassInfo checks in the DFG.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):

11:45 AM Changeset in webkit [127478] by tony@chromium.org
  • 4 edits in trunk/Tools

Elide test names when running new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=95626

Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(test_test_status_line): Test for _test_status_line.

11:42 AM Changeset in webkit [127477] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Rollout r127322.

11:37 AM Changeset in webkit [127476] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[chromium] Do not allow infinite pending frames in CCFrameRateController
​https://bugs.webkit.org/show_bug.cgi?id=94254

Patch by Brian Anderson <​brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.

Removes support for infinite pending frames in CCFrameRateController
if swap acks are available.

Functionality covered by existing tests.

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::setMaxFramesPending):
(WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
(WebCore):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):

  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setSwapBuffersCompleteSupported):
(WebCore):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeRendererOnImplThread):

11:33 AM Changeset in webkit [127475] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Print API missing documentation when generating gtkdoc
​https://bugs.webkit.org/show_bug.cgi?id=95703

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-09-04
Reviewed by Carlos Garcia Campos.

Print out API missing documentation when generating gtkdoc. This makes it
easier to fix documentation errors.

  • gtk/generate-gtkdoc:

(print_missing_api): Added.
(generate_doc): Inline the rebase step, since it now reports an error
when you try to rebase without generating documentation first.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): Raise an error when rebasing without
generating documentation first to enable a small cleanup at the caller.
(GTKDoc.api_missing_documentation): Added.

11:31 AM Changeset in webkit [127474] by timothy_horton@apple.com
  • 7 edits
    2 adds in trunk

ASSERTion failure when SVG element is removed from document and readded
​https://bugs.webkit.org/show_bug.cgi?id=95517
<rdar://problem/12175583>

Reviewed by Brady Eidson.

Previously, SVG animations would cease to animate when their parent
<svg> element was removed and re-added to the document.

Instead, to match Firefox and Opera, we should continue the animation
with the same beginTime (i.e. the animation continues as if it had never
been removed from the document).

Test: svg/animations/reinserting-svg-into-document.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::isStarted): Added.

  • svg/animation/SMILTimeContainer.h: Add isStarted().
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
their parent SMILTimeContainer when they are inserted into the document, otherwise
they are lost (and never again update) when their subtree is removed and then
readded to the document.

Add a test that ensures that removing an SVG element from the document
and readding it continues SMIL animations.

  • svg/animations/reinserting-svg-into-document.html: Added.
11:08 AM Changeset in webkit [127473] by scheib@chromium.org
  • 8 edits in trunk

[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=95628

Reviewed by James Robinson.

Tools:

Future tests need the ability to respond asynchronously that
pointer lock requests have been accepted or rejected. This patch
adds the following:

testRunner.setPointerLockWillRespondAsynchronously();
testRunner.didAcquirePointerLock();
testRunner.didNotAcquirePointerLock();

Tested in existing test:

pointerlockchange-pointerlockerror-events.html

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::didAcquirePointerLock):
(DRTTestRunner::didNotAcquirePointerLock):
(DRTTestRunner::setPointerLockWillRespondAsynchronously):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestPointerLock):
(WebViewHost::didAcquirePointerLock):
(WebViewHost::didNotAcquirePointerLock):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::setPointerLockWillRespondAsynchronously):

LayoutTests:

Add testing for testRunner.setPointerLockWillRespondAsynchronously().

  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
10:47 AM Changeset in webkit [127472] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
​https://bugs.webkit.org/show_bug.cgi?id=95645

Patch by Andrei Bucur <​abucur@adobe.com> on 2012-09-04
Reviewed by Abhishek Arya.

Source/WebCore:

This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.

Tests: fast/regions/moved-content-node-crash.html

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):

LayoutTests:

Simple test case that triggers an ASSERT in debug mode and causes a crash in release.
The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode
ASSERT(it != m_mapNamedFlowContentNodes.end());

It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed
without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach
in the parent document.

  • fast/regions/moved-content-node-crash-expected.txt: Added.
  • fast/regions/moved-content-node-crash.html: Added.
9:50 AM Changeset in webkit [127471] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
​https://bugs.webkit.org/show_bug.cgi?id=95744

Patch by Koji Ishii <Koji Ishii> on 2012-09-04
Unreviewed build fix, verified by Scott Graham.

The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
because '/opentype/' was already included to webcore_remaining.
It was not only redundant but also breaks incremental linking.

No new tests are required because no behavior changes.

Patch by Koji Ishii <Koji Ishii> on 2012-09-04

  • WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.
8:47 AM Changeset in webkit [127470] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
​https://bugs.webkit.org/show_bug.cgi?id=95747

PR199729

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-04
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.

If the browser has never saved a secure protocol cookie in its mapping before,
and it tries to set and retreive a secure cookie over a non-secure
protocol, it will not show up because the link between the secure and
non-secure mapping isn't created until a cookie (sent through secure) is set.

The fix is to also check for the linkage in getRawCookies. Note that we cannot
map the secure CookieMap to the non-secure one because getRawCookies is a const
function.

Manually tested using our Browser Test suite.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

8:45 AM Changeset in webkit [127469] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
​https://bugs.webkit.org/show_bug.cgi?id=95751

Reviewed by Martin Robinson.

In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.

However the only place where we used this is in the HTTP source
element and only if appsrc < 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::didReceiveResponse):

8:32 AM Changeset in webkit [127468] by vsevik@chromium.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
​https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <​poenaru@adobe.com> on 2012-09-04
Reviewed by Pavel Feldman.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
8:11 AM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
6:48 AM Changeset in webkit [127467] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix IDL dependency generation correctly
​https://bugs.webkit.org/show_bug.cgi?id=95730

Patch by Jonathan Liu <​net147@gmail.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

IDL dependency generation is still not working after
​https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.

  • DerivedSources.pri:
6:43 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:40 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:38 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:38 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
Add proposed merges for 1.9.92 (diff)
6:36 AM Changeset in webkit [127466] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
​https://bugs.webkit.org/show_bug.cgi?id=95618

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.

LayoutTests:

New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.

  • platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
  • platform/gtk/accessibility/aria-listbox-crash.html: Added.
6:34 AM Changeset in webkit [127465] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] [TextureMapper] Assertion failure in TextureMapperGL
​https://bugs.webkit.org/show_bug.cgi?id=95713

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-09-04
Reviewed by Noam Rosenthal.

Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
This is important because TextureMapperGL uses the platform context to perform hashing.

No new tests. This is covered by existing accelerated compositing tests.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
when getting the platform context for private GraphicsContext3DPrivates that render
to the currently active context.

6:32 AM Changeset in webkit [127464] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
​https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.

  • platform/efl/SoundEfl.cpp:

(WebCore::systemBeep):

LayoutTests:

Unskipped two layout tests that were crashing.

  • platform/efl/TestExpectations:
6:30 AM Changeset in webkit [127463] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][WK2] CSS3 Media Queries functionality is broken
​https://bugs.webkit.org/show_bug.cgi?id=95680

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

In WK2, WebProcess doesn't have access to ewk_view evas object.
Methods that get screen rect or screen depth either return incorrect value or crash.
This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
to get screen rectangle or color depth of the screen.

  • platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
  • platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration

(WebCore):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):

LayoutTests:

Unskipped passing CSS3 Media Query tests.

  • platform/efl-wk2/TestExpectations:
6:20 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:20 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:19 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:13 AM Changeset in webkit [127462] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

.: [EFL] Context menu restore.
​https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port

Source/WebCore: [EFL] Context menu restore.
​https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

Source/WebKit: [EFL] Context menu restore.
​https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • PlatformEfl.cmake: Added ContextMenuClientEfl.cpp file to sources list.

Source/WebKit/efl: [EFL] Context menu restore.
​https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • WebCoreSupport/ContextMenuClientEfl.cpp: Added.

(WebCore):
(WebCore::ContextMenuClientEfl::contextMenuDestroyed):
(WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems):
(WebCore::ContextMenuClientEfl::contextMenuItemSelected):
(WebCore::ContextMenuClientEfl::downloadURL):
(WebCore::ContextMenuClientEfl::lookUpInDictionary):
(WebCore::ContextMenuClientEfl::speak):
(WebCore::ContextMenuClientEfl::isSpeaking):
(WebCore::ContextMenuClientEfl::stopSpeaking):
(WebCore::ContextMenuClientEfl::searchWithGoogle):

  • WebCoreSupport/ContextMenuClientEfl.h: Added.

(WebCore):
(ContextMenuClientEfl):

  • ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation.

(ewk_context_menu_destroy): Added freeing context menu.
(ewk_context_menu_new): Added filling ewk_contextmenu list.
(ewk_context_menu_item_append):

  • ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition.
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_forward_event):

5:51 AM Changeset in webkit [127461] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Web Inspector: Skip inspector WebGL tests where WebGL is disabled
​https://bugs.webkit.org/show_bug.cgi?id=95733

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

This is to update Skipped and TestExpectations files.

  • platform/efl/TestExpectations:
  • platform/win/Skipped:
5:34 AM Changeset in webkit [127460] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening of failing tests
​https://bugs.webkit.org/show_bug.cgi?id=95725

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-09-04

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
5:30 AM Changeset in webkit [127459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
​https://bugs.webkit.org/show_bug.cgi?id=95687

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

5:11 AM Changeset in webkit [127458] by Carlos Garcia Campos
  • 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Revert r127442 (Merge r126715)

Patch causes crashes and makes inspector unit tests to fail in both
WebKit1 and WebKit2

5:05 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
4:56 AM Changeset in webkit [127457] by allan.jensen@nokia.com
  • 22 edits
    7 adds in trunk

Allow child-frame content in hit-tests.
​https://bugs.webkit.org/show_bug.cgi?id=95204

.:

Reviewed by Antonio Gomes.

Update exported symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Reviewed by Antonio Gomes.

Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.

Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html

touchadjustment/iframe-boundary.html

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::allowChildFrameContent):
(WebCore::HitTestRequest::childFrameHitTest):
(WebCore::HitTestRequest::testChildFrameScrollBars):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):
(WebCore):

  • rendering/RenderFrameBase.h:

(RenderFrameBase):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Reviewed by Antonio Gomes.

Update symbols for the Windows build-system.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Reviewed by Antonio Gomes.
Touch-Adjustment test by Kevin Ellis

Two new tests for hit-testing child frame content. One for testing it as an option to
nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.

  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
  • fast/dom/nodesFromRect/resources/child-frame.html: Added.
  • fast/dom/nodesFromRect/resources/nodesFromRect.js:

(check):
(checkShadowContent):
(checkRect):
(nodesFromRectAsString):

  • touchadjustment/iframe-boundary-expected.txt: Added.
  • touchadjustment/iframe-boundary.html: Added.
  • touchadjustment/resources/inner-content-page.html: Added.
  • touchadjustment/resources/inner-navigation-frame.html: Added.
4:52 AM Changeset in webkit [127456] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed tests fix.

  • http/tests/inspector/workspace-test.js:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
4:25 AM Changeset in webkit [127455] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build error in NetworkStateNotifierEfl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=95724

Unreviewed EFL build fix.

Make sure <sys/socket.h> is included before
<linux/netlink.h> to fix build errors on some
systems (e.g. Ubuntu 11.10).

No new tests, no behavior change.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04

  • platform/network/efl/NetworkStateNotifierEfl.cpp:
3:48 AM Changeset in webkit [127454] by vsevik@chromium.org
  • 22 edits
    1 move
    5 adds
    2 deletes in trunk

Web Inspector: Create JavaScriptSources based on network resources.
​https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html

inspector/debugger/resource-script-mapping.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Added.

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
  • inspector/debugger/network-uisourcecode-provider.html: Added.
  • inspector/debugger/raw-source-code-expected.txt: Removed.
  • inspector/debugger/raw-source-code.html: Removed.
  • inspector/debugger/resource-script-mapping-expected.txt: Added.
  • inspector/debugger/resource-script-mapping.html: Added.
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
3:38 AM Changeset in webkit [127453] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r127447.
​http://trac.webkit.org/changeset/127447
​https://bugs.webkit.org/show_bug.cgi?id=95726

Mistake, did not reliably pass yet. (Requested by drott on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-04

  • platform/efl/TestExpectations:
2:37 AM Changeset in webkit [127452] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
​https://bugs.webkit.org/show_bug.cgi?id=95443

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Save gl.getError() status before taking the GL snapshot and restore it afterwards.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

LayoutTests:

Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.

  • inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
  • inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
  • inspector/profiler/webgl/webgl-profiler-test.js: Added.

(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):
(createWebGLContext):

2:25 AM Changeset in webkit [127451] by commit-queue@webkit.org
  • 2 edits in trunk

[CMAKE] Update cmakeconfig.h.cmake
​https://bugs.webkit.org/show_bug.cgi?id=95712

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.

Update feature definitions which are missing compared to WebKitFeatures.cmake

  • Source/cmakeconfig.h.cmake:
2:20 AM Changeset in webkit [127450] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] REGRESSION(r127321): It made 3 notification test timeout
​https://bugs.webkit.org/show_bug.cgi?id=95638

Patch by Jon Lee <​jonlee@apple.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

Dispatch show event instead of display after r127321.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::sendDisplayEvent):

1:55 AM Changeset in webkit [127449] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: More directional control characters for debugging in inspector
​https://bugs.webkit.org/show_bug.cgi?id=95696

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).

  • inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
1:53 AM Changeset in webkit [127448] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: new CPU Profiles are not shown after reattach
​https://bugs.webkit.org/show_bug.cgi?id=95686

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
to true and clear all profiles on the front-end since there are no
collected profiles yet immediately after render process sitching.

1:53 AM EFLWebKit edited by tmpsantos@gmail.com
(diff)
1:39 AM Changeset in webkit [127447] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
from skipped crashers section, after ​https://bugs.webkit.org/show_bug.cgi?id=94458#c14

  • platform/efl/TestExpectations: Previously crashing test removed.
1:38 AM Changeset in webkit [127446] by Carlos Garcia Campos
  • 20 edits
    6 adds in releases/WebKitGTK/webkit-1.10

Merge r127070 - Source/WebCore: [Gtk] Process Gtk 3.4 smooth scroll events properly.
​https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <​jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

Test: fast/events/continuous-platform-wheelevent-in-scrolling-div.html

  • platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

Source/WebKit/gtk: [Gtk] Process Gtk 3.4 smooth scroll events properly.
​https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <​jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_realize):

Source/WebKit2: [Gtk] Process Gtk 3.4 smooth scroll events properly.
​https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <​jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):

Tools: [Gtk] Process Gtk 3.4 smooth scroll events properly
​https://bugs.webkit.org/show_bug.cgi?id=88070

Added continousMouseScrollBy support in WebKitTestRunner, and added
implementation for gtk, and stub for Qt, mac and EFL.

Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.

Patch by José Dapena Paz <​jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/EventSender.cpp:

(mouseScrollByCallback):
(continuousMouseScrollByCallback):

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseScrollBy):
(WTR):
(WTR::EventSendingController::continuousMouseScrollBy):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR):
(WTR::EventSenderProxy::continuousMouseScrollBy):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::continuousScrollBy):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR):

LayoutTests: [Gtk] Process Gtk 3.4 smooth scroll events properly.
​https://bugs.webkit.org/show_bug.cgi?id=88070

Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.

Patch by José Dapena Paz <​jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • platform/gtk-wk2/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk-wk2/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
1:38 AM Changeset in webkit [127445] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add webplatform and browser to build info
​https://bugs.webkit.org/show_bug.cgi?id=95715

Reviewed by George Staikos.

PR# 202102

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::buildPage):

1:31 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
1:27 AM Changeset in webkit [127444] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source

[EFL] Drop default theme concept
​https://bugs.webkit.org/show_bug.cgi?id=94778

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

  • ewk/ewk_view.h:

Updated doxygen document not to mention default theme.

Source/WebKit2:

  • PlatformEfl.cmake: Removed DEFAULT_THEME_PATH definitions.
  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize): Removed default theme concept.

  • UIProcess/API/efl/ewk_view.h:

Updated doxygen document not to mention default theme.

1:23 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
1:19 AM Changeset in webkit [127443] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
​https://bugs.webkit.org/show_bug.cgi?id=95716

Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::collectDomTreeInfo):

12:25 AM Changeset in webkit [127442] by Carlos Garcia Campos
  • 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge r126715 - Array type checks and storage accesses should be uniformly represented and available to CSE
​https://bugs.webkit.org/show_bug.cgi?id=95013

Reviewed by Oliver Hunt.

This uniformly breaks up all array accesses into up to three parts:

1) The type check, using a newly introduced CheckArray node, in addition to possibly

a CheckStructure node. We were already inserting the CheckStructure prior to this
patch. The CheckArray node will be automatically eliminated if the thing it was
checking for had already been checked for, either intentionally (a CheckStructure
inserted based on the array profile of this access) or accidentally (some checks,
typically a CheckStructure, inserted for some unrelated operations). The
CheckArray node may not be inserted if the array type is non-specific (Generic or
ForceExit).

2) The storage load using GetIndexedPropertyStorage. Previously, this only worked for

GetByVal. Now it works for all array accesses. The storage load may not be
inserted if the mode of array access does not permit CSE of storage loads (like
non-specific modes or Arguments).

3) The access itself: one of GetByVal, PutByVal, PutByValAlias, ArrayPush, ArrayPop,

GetArrayLength, StringCharAt, or StringCharCodeAt.

This means that the type check can be subjected to CSE even if the CFA isn't smart
enough to reason about it (yet!). It also means that the storage load can always be
subjected to CSE; previously CSE on storage load only worked for array loads and not
other forms of access. Finally, it removes the bizarre behavior that
GetIndexedPropertyStorage previously had: previously, it was responsible for the type
check in some cases, but not others; this made reasoning about the CFA really
confusing.

This change also disables late refinement of array mode, since I decided that
supporting that feature is both confusing and likely unprofitable. The array modes are
now locked in in the first fixup run after prediction propagation. Of course,
refinements from Generic to something else would not have been a problem; we could
reenable those if we thought we really needed to.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromStructure):
(DFG):
(JSC::DFG::refineArrayMode):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::lengthNeedsStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::checkStructureElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(DFG):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::vote):
(JSC::DFG::Graph::substitute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::setArrayMode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

12:08 AM Changeset in webkit [127441] by Carlos Garcia Campos
  • 28 edits
    2 deletes in releases/WebKitGTK/webkit-1.10

Merge r127228 - Unreviewed, rolling out r126127.
​http://trac.webkit.org/changeset/126127

This breaks gobject bindings.

Source/WebCore:

  • dom/Attr.cpp:

(WebCore::Attr::cloneNode):

  • dom/Attr.h:
  • dom/CDATASection.cpp:

(WebCore::CDATASection::cloneNode):

  • dom/CDATASection.h:

(CDATASection):

  • dom/Comment.cpp:

(WebCore::Comment::cloneNode):

  • dom/Comment.h:

(Comment):

  • dom/Document.cpp:

(WebCore::Document::cloneNode):

  • dom/Document.h:

(Document):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::cloneNode):

  • dom/DocumentFragment.h:

(DocumentFragment):

  • dom/DocumentType.cpp:

(WebCore::DocumentType::cloneNode):

  • dom/DocumentType.h:

(DocumentType):

  • dom/Element.cpp:

(WebCore::Element::cloneNode):

  • dom/Element.h:

(Element):

  • dom/EntityReference.cpp:

(WebCore::EntityReference::cloneNode):

  • dom/EntityReference.h:

(EntityReference):

  • dom/Node.h:

(Node):

  • dom/Node.idl:
  • dom/Notation.cpp:

(WebCore::Notation::cloneNode):

  • dom/Notation.h:

(Notation):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::cloneNode):

  • dom/ProcessingInstruction.h:

(ProcessingInstruction):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::cloneNode):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/Text.cpp:

(WebCore::Text::cloneNode):

  • dom/Text.h:

(Text):

LayoutTests:

  • fast/dom/shadow/shadowroot-clonenode-expected.txt: Removed.
  • fast/dom/shadow/shadowroot-clonenode.html: Removed.
12:08 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)

Sep 3, 2012:

11:37 PM Changeset in webkit [127440] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

[Qt] Port the Qt pixmap JS bindings to use the JSC C API
​https://bugs.webkit.org/show_bug.cgi?id=94702

Reviewed by Kenneth Rohde Christiansen.

Based on patch by Noam Rosenthal.

The conversion uses a simple JSClassRef based binding and only a few
uses of private JSC API for the HTML element DOM bindings remain.

This is essentially used for wrapping QPixmap and QImage types in
JavaScript and the other way around, for retrieving the image data
out of a HTML image element when converting from JS/DOM to Qt.

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::copyPixels):
(JSC::Bindings::toPixmap):
(JSC::Bindings::toImage):
(JSC::Bindings::imageSizeForVariant):
(JSC::Bindings::getPixmapWidth):
(JSC::Bindings::getPixmapHeight):
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::pixmapToImageData):
(JSC::Bindings::pixmapToDataUrl):
(JSC::Bindings::pixmapToString):
(JSC::Bindings::QtPixmapRuntime::toJS):
(JSC::Bindings::QtPixmapRuntime::toQt):
(JSC::Bindings::QtPixmapRuntime::canHandle):
(JSC::Bindings::QtPixmapRuntime::getClassRef):

  • bridge/qt/qt_pixmapruntime.h:

(QtPixmapRuntime):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

10:26 PM Changeset in webkit [127439] by noel.gordon@gmail.com
  • 2 edits
    5 deletes in trunk/LayoutTests

http/tests/incremental/partial-jpeg.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=82480

Reviewed by Kent Tamura.

Remove this test: we have a more robust partial load test now in
http/tests/images/jpg-img-partial-load.html

  • http/tests/incremental/partial-jpeg-expected.png: Removed.
  • http/tests/incremental/partial-jpeg-expected.txt: Removed.
  • http/tests/incremental/partial-jpeg.html: Removed.
  • http/tests/incremental/resources/checkerboard.jpg: Removed.
  • http/tests/incremental/resources/partial-jpeg.php: Removed.
  • platform/chromium/TestExpectations:
7:19 PM Changeset in webkit [127438] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

Share immutable ElementAttributeData between elements with identical attributes.
<​http://webkit.org/b/94990>

Reviewed by Antti Koivisto.

Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
them in elements with identical attribute maps. ElementAttributeData is made ref-counted
to facilitate this. A copy-on-write mechanism is already in place, since mutating call
sites have to go via Element::mutableAttributeData().

The cache is held by Document and cleared in Document::finishedParsing() since the vast
majority of immutable ElementAttributeData will be constructed during parsing.

On the HTML5 spec at <​http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
translating into a 3.5MB reduction in memory use.

  • dom/Document.cpp:

(WebCore::Document::finishedParsing):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

  • dom/Element.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::makeMutable):

7:09 PM Changeset in webkit [127437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: the URL of worker inspector window sometimes is invalid
​https://bugs.webkit.org/show_bug.cgi?id=95334

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-09-03
Reviewed by Pavel Feldman.

In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.

No new tests case for this bug.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._openInspectorWindow):

6:44 PM Changeset in webkit [127436] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=95636

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

Source/WebCore:

Check if the m_timer is active in stopUpdating()
to know the BatteryProvider is updating or not.
By checking the timer, stopUpdating() will be called
only BatteryProviderEfl is updating.

  • platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::stopUpdating):

Source/WebKit/efl:

Invoke stopUpdating() in the destructor of BatteryClinetEfl()
to call e_ukit_shutdown() and e_dbus_shutdown() if and when
stopUpdating() has not been called explicitly.

  • WebCoreSupport/BatteryClientEfl.cpp:

(BatteryClientEfl::~BatteryClientEfl):

  • WebCoreSupport/BatteryClientEfl.h:

(BatteryClientEfl):

6:40 PM Changeset in webkit [127435] by bashi@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127410

Removed further platform-specific text expectations.

  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
6:21 PM Changeset in webkit [127434] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WTR] Implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference
​https://bugs.webkit.org/show_bug.cgi?id=95576

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-03
Reviewed by Maciej Stachowiak.

Added a line of macro to implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

LayoutTests:

  • platform/wk2/Skipped: Removed fast/repaint/no-caret-repaint-in-non-content-editable-element.html test case.
3:39 PM Changeset in webkit [127433] by bashi@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127410

  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
12:14 PM Changeset in webkit [127432] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Not all activated elements highlighted, but some frames are
​https://bugs.webkit.org/show_bug.cgi?id=95683

Reviewed by Kenneth Rohde Christiansen.

Use the new function Node::willRespondToMouseClickEvents to better determine if the element
can be tap-activated and avoid documents and frames completely.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

12:14 PM WebKitGTK/1.10.x edited by Carlos Garcia Campos
r127124 merged (diff)
11:38 AM Changeset in webkit [127431] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

[EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=95689

Reviewed by Kenneth Rohde Christiansen.

In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
So, there are bugs that key events are always generated in url bar although
the user clicked the web view.

This patch recovers the focus of the web view when left button is pressed and
adds for MiniBrowser to toggle the focus when middle button is pressed
like EWebLauncher already did.

  • EWebLauncher/main.c:

(on_mouse_down):

  • MiniBrowser/efl/main.c:

(on_mouse_down):
(browserCreate):

11:37 AM Changeset in webkit [127430] by commit-queue@webkit.org
  • 5 edits in trunk

Added ANDROID_GDBSERVER definition for Ant
​https://bugs.webkit.org/show_bug.cgi?id=95265

Patch by Tao Bai <​michaelbai@chromium.org> on 2012-09-03
Reviewed by Adam Barth.

ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
is only used for finding the gdbserver.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
10:16 AM Changeset in webkit [127429] by commit-queue@webkit.org
  • 19 edits
    3 adds
    6 deletes in trunk

Unreviewed, rolling out r127427.
​http://trac.webkit.org/changeset/127427
​https://bugs.webkit.org/show_bug.cgi?id=95695

Breaks some inspector/debugger tests on JSC (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-03

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/StylesUISourceCodeProvider.js: Added.

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Removed.
  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
  • inspector/debugger/network-uisourcecode-provider.html: Removed.
  • inspector/debugger/raw-source-code-expected.txt: Added.
  • inspector/debugger/raw-source-code.html: Added.
  • inspector/debugger/resource-script-mapping-expected.txt: Removed.
  • inspector/debugger/resource-script-mapping.html: Removed.
  • inspector/debugger/scripts-panel.html:
9:50 AM Changeset in webkit [127428] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
9:45 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
9:44 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
9:34 AM Changeset in webkit [127427] by vsevik@chromium.org
  • 19 edits
    1 move
    5 adds
    2 deletes in trunk

Web Inspector: Create JavaScriptSources based on network resources.
​https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html

inspector/debugger/resource-script-mapping.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Added.

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
  • inspector/debugger/network-uisourcecode-provider.html: Added.
  • inspector/debugger/raw-source-code-expected.txt: Removed.
  • inspector/debugger/raw-source-code.html: Removed.
  • inspector/debugger/resource-script-mapping-expected.txt: Added.
  • inspector/debugger/resource-script-mapping.html: Added.
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
9:09 AM Changeset in webkit [127426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Make the injected resourceObject property non-enumerable
​https://bugs.webkit.org/show_bug.cgi?id=95682

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-03
Reviewed by Pavel Feldman.

Make the injected auxiliary property resourceObject non-enumerable to hide it from for..in iterations.
Ideally this property should be completely hidden from the user's code.
Drive-by: Fix couple of small FIXME's.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

9:08 AM Changeset in webkit [127425] by tommyw@google.com
  • 25 edits
    2 copies
    5 adds in trunk

MediaStream API: Add Ice-related functionality to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=95565

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCICECandidateDescriptor.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h.

(WebCore):
(WebKit):
(WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::~WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::operator=):
(WebKit::WebRTCICECandidateDescriptor::isNull):

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

Adds all Ice-related functionality to RTCPeerConnection, including
events, callbacks and methods.

Test: fast/mediastream/RTCPeerConnection-ice.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCIceCandidateEvent.cpp: Added.

(WebCore):
(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::candidate):
(WebCore::RTCIceCandidateEvent::interfaceName):

  • Modules/mediastream/RTCIceCandidateEvent.h: Added.

(WebCore):
(RTCIceCandidateEvent):

  • Modules/mediastream/RTCIceCandidateEvent.idl: Added.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::updateIce):
(WebCore):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didChangeIceState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeIceState):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:
  • platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.

(WebKit):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::assign):
(WebKit::WebRTCICECandidateDescriptor::reset):
(WebKit::WebRTCICECandidateDescriptor::initialize):
(WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
(WebKit::WebRTCICECandidateDescriptor::candidate):
(WebKit::WebRTCICECandidateDescriptor::sdpMid):
(WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):

  • platform/mediastream/RTCIceCandidateDescriptor.h:

(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCPeerConnectionHandlerClient.h:

(WebCore):
(RTCPeerConnectionHandlerClient):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::updateIce):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::updateICE):
(MockWebRTCPeerConnectionHandler::addICECandidate):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-ice-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-ice.html: Added.
8:59 AM Changeset in webkit [127424] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge r127124 - 1.9.90 drops symbols, breaking compatibility
​https://bugs.webkit.org/show_bug.cgi?id=93477

Patch by Xan Lopez <​xlopez@igalia.com> on 2012-08-30
Reviewed by Martin Robinson.

Add a bunch of compatibility methods to the GObject DOM bindings
to cope with recent renames.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_element_get_class_list):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):

  • bindings/gobject/WebKitDOMCustom.h:
8:19 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
Fix initial branch revision (diff)
7:57 AM Changeset in webkit [127423] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r127421

  • rendering/HitTestResult.cpp:

(WebCore::HitTestLocation::HitTestLocation):

7:48 AM Changeset in webkit [127422] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk/Source/WebKit2

[EFL][WK2] Add ewk_settings.
​https://bugs.webkit.org/show_bug.cgi?id=91206

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

Add the ewk_settings which wraps the WKPreferencesRef.
The ewk_settings will be created by the ewk_view and it will be
destroyed when the ewk_view is destroyed. I make each view to have
its own group to make one ewk_settings sets preferences only for
one ewk_view.
The application can get the ewk_settings from ewk_view using
ewk_view_settings_get() API.

  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_settings.cpp: Added.

(ewk_settings_enable_scripts_set):
(ewk_settings_enable_scripts_get):
(ewk_settings_auto_load_images_set):
(ewk_settings_auto_load_images_get):

  • UIProcess/API/efl/ewk_settings.h: Added.
  • UIProcess/API/efl/ewk_settings_private.h: Added.

(_Ewk_Settings):
(_Ewk_Settings::_Ewk_Settings):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_settings_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp: Added.

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

7:41 AM Changeset in webkit [127421] by allan.jensen@nokia.com
  • 17 edits in trunk/Source/WebCore

Move AllowShadowContent flag to HitTestRequest
​https://bugs.webkit.org/show_bug.cgi?id=95685

Reviewed by Antonio Gomes.

Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
it can read the flag from HitTestRequest instead of from HitTestResult.

No change in functionality. No new tests.

  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • rendering/HitTestRequest.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):

  • rendering/HitTestResult.h:

(HitTestLocation):
(HitTestResult):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::nodeAtPoint):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::nodeAtPoint):

7:15 AM Changeset in webkit [127420] by allan.jensen@nokia.com
  • 3 edits in trunk/Source/WebKit2

Wheel-events fails temporarily after reload
​https://bugs.webkit.org/show_bug.cgi?id=94934

Reviewed by Kenneth Rohde Christiansen.

Set fixed visible content rect using visibleContentBounds instead of WebPage::size. Otherwise the
content rect will be incorrectly set to the entire document size, when resizesToContents is active.

Test: UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml

  • UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

7:01 AM Changeset in webkit [127419] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] Use WebKitVersion.h to get version information
​https://bugs.webkit.org/show_bug.cgi?id=95669

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

.:

WEBKIT_USER_AGENT_MAJOR_VERSION and WEBKIT_USER_AGENT_MINOR_VERSION
are defined as constant in the OptionsEfl.cmake. But we do not need
to define these here but can use the defined constant in WebKitVersion.h.

WebKitVersion.h is already generated with the version information
from the Source/WebCore/Configurations/Version.xcconfig.

  • Source/cmake/OptionsEfl.cmake: Do not set WEBKIT_USER_AGENT_* variables.
  • Source/cmakeconfig.h.cmake: Remove WEBKIT_USER_AGENT_* definitions

as no more port uses.

Source/WebKit/efl:

Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h

Relocate the StorageTracker.h to keep the sorted order.

  • ewk/ewk_settings.cpp:

(ewk_settings_default_user_agent_get):

Source/WebKit2:

Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::standardUserAgent):

6:22 AM Changeset in webkit [127418] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Unhide hidden characters
​https://bugs.webkit.org/show_bug.cgi?id=93888

Reviewed by Pavel Feldman.

Source/WebCore:

Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):

LayoutTests:

  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
6:20 AM Changeset in webkit [127417] by pfeldman@chromium.org
  • 11 edits
    1 move in trunk/Source/WebCore

Web Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
​https://bugs.webkit.org/show_bug.cgi?id=95677

Reviewed by Yury Semikhatsky.

  • renamed the file and the usages
  • renamed isolatedContextCreated to executionContextCreated for consistency.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/Inspector.json:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::notifyContextCreated):

  • inspector/compile-front-end.py:
  • inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.

(WebInspector.RuntimeModel):
(WebInspector.RuntimeModel.prototype._frameAdded):
(WebInspector.RuntimeModel.prototype._frameDetached):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.executionContextCreated):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
4:53 AM WebKitGTK/1.10.x edited by mario@webkit.org
(diff)
4:17 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
3:44 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Further update on 2010/2013. (diff)
3:43 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Update ICU(*) columns for BA class. Add issue needing verification. (diff)
3:26 AM Changeset in webkit [127416] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskipping message-port-close.html after bug 85811 was resolved.

  • platform/efl/TestExpectations:
2:56 AM Changeset in webkit [127415] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
​https://bugs.webkit.org/show_bug.cgi?id=95540

Reviewed by Pavel Feldman.

Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
fix closure compiler warning.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):

2:45 AM Changeset in webkit [127414] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fixed front-end compilation warnings.
Not reviewed.

  • inspector/front-end/FilteredItemSelectionDialog.js:
  • inspector/front-end/HeapSnapshotView.js:
2:42 AM Changeset in webkit [127413] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: paint grid on top of box highlight.
​https://bugs.webkit.org/show_bug.cgi?id=95676

Reviewed by Alexander Pavlov.

Otherwise, ruler numbers are not visible when selecting body.

  • inspector/InspectorOverlayPage.html:
1:54 AM Changeset in webkit [127412] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: get rid of context execution id fallback.
​https://bugs.webkit.org/show_bug.cgi?id=95567

Reviewed by Yury Semikhatsky.

Source/WebCore:

We now assign execution context id upon changes in the UI.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContextList):
(WebInspector.ConsoleView.prototype._contextListRemoved):
(WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
(WebInspector.ConsoleView.prototype._appendExecutionContextOption):
(WebInspector.ConsoleView.prototype._executionContextChanged):
(WebInspector.ConsoleView.prototype._contextListUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contextLists):
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.FrameExecutionContextList):
(WebInspector.FrameExecutionContextList.prototype._frameNavigated):
(WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
(WebInspector.FrameExecutionContextList.prototype.executionContexts):
(WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):

LayoutTests:

  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/console-cd.html:
1:50 AM Changeset in webkit [127411] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

[EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=95670

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.

Fix layout issues related to the URL bar in Minibrowser
and EWebLauncher when the window is resized.

The URL bar was not resized accordingly and the Web
page was moved behing the URL bar, hiding part of it.

  • EWebLauncher/main.c:

(on_ecore_evas_resize):
(closeWindow):

  • EWebLauncher/url_bar.c:

(url_bar_width_set):
(url_bar_add):

  • EWebLauncher/url_bar.h:
  • MiniBrowser/efl/main.c:

(on_ecore_evas_resize):
(main):

1:39 AM Changeset in webkit [127410] by yosin@chromium.org
  • 2 edits
    15 adds in trunk/LayoutTests

Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
  • platform/chromium/TestExpectations:
1:35 AM Changeset in webkit [127409] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark http/tests/incremental/slow-utf8-text.pl as flaky
​https://bugs.webkit.org/show_bug.cgi?id=95673

Unreviewed EFL gardening.

Mark http/tests/incremental/slow-utf8-text.pl as flaky
as it does not always time out.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03

  • platform/efl/TestExpectations:
1:34 AM Changeset in webkit [127408] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.

  • interpreter/Interpreter.h:
1:30 AM Changeset in webkit [127407] by yosin@chromium.org
  • 2 edits
    5 deletes in trunk/LayoutTests

Unreviewed, rolling out r127406.
​http://trac.webkit.org/changeset/127406
​https://bugs.webkit.org/show_bug.cgi?id=95674

Expectation images are missing (Requested by yosin1 on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-03

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium/TestExpectations:
1:22 AM Changeset in webkit [127406] by yosin@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium/TestExpectations:
1:18 AM Changeset in webkit [127405] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage API test
​https://bugs.webkit.org/show_bug.cgi?id=95671

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.

Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage
API test since it is flaky on the bots.

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(TEST_F):

1:16 AM Changeset in webkit [127404] by g.czajkowski@samsung.com
  • 4 edits in trunk

[GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
​https://bugs.webkit.org/show_bug.cgi?id=95436

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
To properly handle spellchecking of each word we need to iterate over the all available
dictionaries ('dictIter').

To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
of vector while spellchecking of the word. This ensures performing of spelling for word based on
at least one dictionary.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.

LayoutTests:

'checkSpellingOfString' from the TextCheckerEnchant class can not mark multiplie words that are misspelled.
It's possible to mark misspeled string only by defining its location and length.

  • platform/gtk/TestExpectations: Added spelling-backspace-between-lines.html to TestExpectations.
1:14 AM Changeset in webkit [127403] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Mark several inspector test as flaky
​https://bugs.webkit.org/show_bug.cgi?id=95667

Unreviewed EFL gardening.

Mark several inspector test cases as flaky on
WebKit2 EFL.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03

  • platform/efl-wk2/TestExpectations:
12:35 AM Changeset in webkit [127402] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update TestExpectations for 2 fast/block tests
​https://bugs.webkit.org/show_bug.cgi?id=95666

Unreviewed EFL gardening.

Update TestExpectations for 2 fast/block tests to
indicate that we expect TEXT only diff on the bot
since we don't run pixel tests.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03

  • platform/efl/TestExpectations:
Note: See TracTimeline for information about the timeline view.