⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 6, 2012:

11:29 PM Changeset in webkit [127834] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for two MathML tests after r127769.

Removing failure expectations for tests fixed by changes in r127798,
rollout in r127774 and rebaseline in r127825.

  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.txt:
11:26 PM Changeset in webkit [127833] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Regression: Web Inspector tool-tips pixellated with --force-device-scale-factor=2
​https://bugs.webkit.org/show_bug.cgi?id=95875

Reviewed by Vsevolod Vlasov.

The overlay canvas is scaled according to the actual devicePixelRatio of the inspected page, while retaining its original CSS size.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::reset):

  • inspector/InspectorOverlayPage.html:
11:15 PM Changeset in webkit [127832] by loislo@chromium.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r127822.
​http://trac.webkit.org/changeset/127822
​https://bugs.webkit.org/show_bug.cgi?id=96073

It broke compilation on chromium debug bots (Requested by
loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

  • platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):
(WebCore::CCRenderPass::copy):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::copy):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(WebCore):
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

  • tests/CCDrawQuadTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCRenderPassTest.cpp:

(WebCore::TEST):

  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

10:59 PM Changeset in webkit [127831] by annacc@chromium.org
  • 5 edits in trunk/Source/WebCore

The CC button should have chrome-specific rendering for Mac.
​https://bugs.webkit.org/show_bug.cgi?id=95981

Reviewed by Eric Carlson.

This patch allows RenderThemeChromiumMac to define its own behavior for the CC button.

No new tests. Button should display graphics from chromium resources.

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
Adjust styling for the chromium graphics.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaClosedCaptionsButton):
Check whether closed captions are visible to decide how to draw the button.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Override the paint function for the CC button.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore):
(WebCore::RenderThemeChromiumMac::paintMediaToggleClosedCaptionsButton):
Call the chromium-specific painting function.

10:54 PM Changeset in webkit [127830] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Tests] Skip Dialog element tests on Win
​https://bugs.webkit.org/show_bug.cgi?id=96051

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-09-06
Reviewed by Hajime Morita.

Dialog is not yet enabled except on Chromium. Dialog tests should have
been added to the Win port's skipped list as part of r122420.

  • platform/win/Skipped:
10:53 PM Changeset in webkit [127829] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JSC should have a zombie mode
​https://bugs.webkit.org/show_bug.cgi?id=96047

Reviewed by Geoffrey Garen.

To aid clients of JSC while they are debugging memory issues, we should add a zombie
mode that scribbles into objects in the MarkedSpace after they are found to be dead
to prevent a sort of "use after free" situation. As a first cut we should support a
mode that just scribbles on objects prior to their being reused (i.e. while they are
"zombies") and a mode in which, in addition to scribbling on zombies, once an object
has been marked its mark bit will never be cleared, thus giving us "immortal" zombies.

These two modes will be enabled through the use of environment variables. For now these
will be "JSZombieEnabled" and "JSImmortalZombieEnabled". Setting them to any value will
result in the use of the appropriate mode.

  • heap/Heap.cpp:

(JSC::Heap::collect): Zombifies dead objects at the end of collection if zombie mode is enabled.
(ZombifyCellFunctor):
(JSC::ZombifyCellFunctor::ZombifyCellFunctor): Sets marked bits for dead objects if in immortal mode and writes 0xbbadbeef into them.
(JSC::ZombifyCellFunctor::operator()):
(JSC):
(ZombifyBlockFunctor):
(JSC::ZombifyBlockFunctor::operator()):
(JSC::Heap::zombifyDeadObjects): Eagerly sweeps so that we don't write garbage into an object before it
is finalized/destroyed.

  • heap/Heap.h:

(Heap):

  • heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::forEachDeadCell): Used to iterate over dead cells at the end of collection if zombie mode is enabled.
(JSC):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:

(JSC):

10:34 PM Changeset in webkit [127828] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Deploy StringBuilder in more places in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=95924

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-06
Reviewed by Benjamin Poulain.

Deploy StringBuilder to concatenate strings more efficiently.

  • Shared/WebMemorySampler.cpp:

(WebKit):
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::stop):
(WebKit::WebMemorySampler::writeHeaders):
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

  • Shared/WebMemorySampler.h:

(WebMemorySampler):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::capitalizeRFC822HeaderFieldName):

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

10:32 PM Changeset in webkit [127827] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(127810): It broke inspector/debugger/debugger-expand-scope.html
​https://bugs.webkit.org/show_bug.cgi?id=96065

Unreviewed, reverting the expected file change.

  • inspector/debugger/debugger-expand-scope-expected.txt:
10:22 PM Changeset in webkit [127826] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Add methods to CounterDirectives to clean up StyleBuilder and RenderCounter.
​https://bugs.webkit.org/show_bug.cgi?id=94587

Patch by Elliott Sprehn <​esprehn@chromium.org> on 2012-09-06
Reviewed by Julien Chaffraix.

Source/WebCore:

Adds several methods to CounterDirectives and an accessor method to RenderStyle for
getting the CounterDirectives by idenfitier and uses those methods to clean up
the code in StyleBuilder and RenderCounter. This also switches to using AtomicString
directly instead of AtomicStringImpl and calling get() everywhere.

The refactor fixes the unitialized read in WKBug 94642.

Test: fast/css/counters/counter-reset-inherit-bug-94642.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue): Use new accessors.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue): Use new inherit methods.
(WebCore::ApplyPropertyCounter::applyValue): Use new setters.

  • rendering/RenderCounter.cpp:

(WebCore):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):

  • rendering/style/CounterDirectives.cpp:

(WebCore::operator==):

  • rendering/style/CounterDirectives.h: Added new accessors and switched to using AtomicString directly.

(CounterDirectives):
(WebCore::CounterDirectives::CounterDirectives):
(WebCore::CounterDirectives::isReset):
(WebCore::CounterDirectives::resetValue):
(WebCore::CounterDirectives::setResetValue):
(WebCore::CounterDirectives::clearReset):
(WebCore::CounterDirectives::inheritReset):
(WebCore::CounterDirectives::isIncrement):
(WebCore::CounterDirectives::incrementValue):
(WebCore::CounterDirectives::addIncrementValue):
(WebCore::CounterDirectives::clearIncrement):
(WebCore::CounterDirectives::inheritIncrement):
(WebCore::CounterDirectives::isDefined): If either reset or increment is used.
(WebCore::CounterDirectives::combinedValue): Combined local value of the counter.
(WebCore):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCounterDirectives): New method which always returns a CounterDirectives instance by identifier.
(WebCore):

  • rendering/style/RenderStyle.h:

LayoutTests:

Tests for bug 94642 exposing an unitialized read when using counter-reset and
counter-increment: inherit.

  • fast/css/counters/counter-reset-inherit-bug-94642-expected.html: Added.
  • fast/css/counters/counter-reset-inherit-bug-94642.html: Added.
10:09 PM Changeset in webkit [127825] by commit-queue@webkit.org
  • 4 edits in trunk

[Gtk] accessibility/canvas-description-and-role expected results needed
​https://bugs.webkit.org/show_bug.cgi?id=95644

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-06
Reviewed by Martin Robinson.

Source/WebCore:

The new accessibility CanvasRole should be mapped to ATK_ROLE_CANVAS
rather than ATK_ROLE_IMAGE.

No new test because the CanvasRole came with a new layout test lacking
expected results for Gtk. The generated expected results for that test
reflect the revised mapping to ATK_ROLE_CANVAS.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

Generated expected results for Gtk. These results reflect the revised
mapping of CanvasRole to ATK_ROLE_CANVAS rather than ATK_ROLE_IMAGE.

  • platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
10:03 PM Changeset in webkit [127824] by hbono@chromium.org
  • 4 edits in trunk/Source

A build fix for Chromium Windows
​https://bugs.webkit.org/show_bug.cgi?id=96062

Reviewed by James Robinson.

Source/Platform:

This change fixes a build break on Chromium Windows (debug) caused by r127796
<​http://trac.webkit.org/changeset/127796>. It removes a redundant WEBKIT_EXPORT.

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

This change fixes a build break on Chromium Windows caused by r127801
<​http://trac.webkit.org/changeset/127801>. It replaces characters() with
characters16().

No new tests because this change is a build fix.

  • platform/graphics/chromium/UniscribeHelperTextRun.cpp:

(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):

10:00 PM Changeset in webkit [127823] by ryuan.choi@samsung.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add API unit tests for ewk_view_theme_set.
​https://bugs.webkit.org/show_bug.cgi?id=94670

Reviewed by Gyuyoung Kim.

Added unit tests for ewk_view_theme_set.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::pathForResource):
Added to get path of resource.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:

Ditto.

  • UIProcess/API/efl/tests/resources/big_button_theme.edj:

Added test theme file which has text_confinement of button as
rel1 { ... offset : 150 8; } rel2 { ... offset : -150 -11; }.

  • UIProcess/API/efl/tests/resources/empty_theme.edj:

Added test theme file which includes nothing.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

Added unit test for ewk_view_theme_set.

9:49 PM Changeset in webkit [127822] by danakj@chromium.org
  • 18 edits in trunk/Source

[chromium] Make RenderPass ids hold both generating layer id and an index
​https://bugs.webkit.org/show_bug.cgi?id=95500

Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to avoid complex renderPassId mappings between
compositors for ubercomp. The ubercomp layer needs to add a number
of RenderPasses to the frame, and these must not conflict with other
RenderPasses in the frame. By using its layer id along with an extra
value it determines, the layer can create a unique id without needing
access to any global state or id generator.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

  • platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(Id):
(WebCore::CCRenderPass::Id::Id):
(WebCore::CCRenderPass::Id::operator==):
(WebCore::CCRenderPass::Id::operator!=):
(WebCore::CCRenderPass::Id::operator<):
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::renderPassId):
(WebCore):
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

9:48 PM Changeset in webkit [127821] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

StringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents
​https://bugs.webkit.org/show_bug.cgi?id=96029

Reviewed by Benjamin Poulain.

Added 8 bit path when creating an AtomicString from a partial 8 bit buffer.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::toAtomicString):

9:39 PM Changeset in webkit [127820] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[chromium] Do not delete texture backing structures on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=96018

Patch by Christopher Cameron <​ccameron@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Do not delete CCPrioritizedTexture::Backing structures on the main
thread. Instead, unlink them from their owning CCPrioritizedTexture
in the main thread, and have the impl thread then delete all unlinked
textures.

This is towards having the main thread not access the m_backings set,
which will allow the impl thread to traverse that set when deleting
resources in response to GPU memory management events.

Tested by existing eviction tests (CCLayerTreeHostTest's
TestEvictTextures, LostContextAfterEvictTextures)

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::unlinkAllContentTextures):
(WebCore):
(WebCore::CCLayerTreeHost::deleteUnlinkedTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::unlinkAllBackings):
(WebCore):
(WebCore::CCPrioritizedTextureManager::deleteAllUnlinkedBackings):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

9:37 PM Changeset in webkit [127819] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Fix debug Windows build
​https://bugs.webkit.org/show_bug.cgi?id=96008

Reviewed by Tor Arne Vestbø.

Add a few more files to the AllInOne configuration to reduce the number of object files
and their total size, allowing a debug build with MSVC again.

  • Target.pri:
9:21 PM Changeset in webkit [127818] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix text encoding detecting
​https://bugs.webkit.org/show_bug.cgi?id=96014

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Since we rely on ICU now, we might as well use the actually implemented text encoding
detector instead of the dummy "none" one.

I could not locate any layout tests that actually cover this :(

  • Target.pri:
9:18 PM Changeset in webkit [127817] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit

[BlackBerry] Implement a color picker
​https://bugs.webkit.org/show_bug.cgi?id=96001

Patch by Crystal Zhang <​haizhang@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Source/WebKit:

Add color picker files into building system.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Add files for color picker, replace old hook to AIR color picker.

  • WebCoreSupport/ColorPickerClient.cpp: Added.

(WebCore):
(WebCore::ColorPickerClient::ColorPickerClient):
(WebCore::ColorPickerClient::~ColorPickerClient):
(WebCore::ColorPickerClient::generateHTML):
(WebCore::ColorPickerClient::closePopup):
(WebCore::ColorPickerClient::contentSize):
(WebCore::ColorPickerClient::htmlSource):
(WebCore::ColorPickerClient::setValueAndClosePopup):
(WebCore::ColorPickerClient::didClosePopup):
(WebCore::ColorPickerClient::writeDocument):

  • WebCoreSupport/ColorPickerClient.h: Added.

(WebKit):
(WebCore):
(ColorPickerClient):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openColorPopup):

9:14 PM Changeset in webkit [127816] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
​https://bugs.webkit.org/show_bug.cgi?id=96017

Unreviewed Qt-WK2 buildfix after r127783.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::syncFixedLayers):

8:35 PM Changeset in webkit [127815] by yosin@chromium.org
  • 6 edits in trunk/Source

We should have localized strings of date time fields for accessibility
​https://bugs.webkit.org/show_bug.cgi?id=96050

Reviewed by Kent Tamura.

Source/Platform:

This patch adds localized string enum fields for accessibility support
in multiple fields date time related input types for Chromium ports.

  • chromium/public/WebLocalizedString.h: Adds AXAMPMFieldText, AXDayOfMonthField,

AXHourFieldText, AXMillisecondFieldText, AXMinuteFieldText, AXMonthField,
AXSecondFieldText, AXWeekOfYearFieldText, and AXYearFieldText.

Source/WebCore:

This patch adds declarations of function for getting localized string
of date time field for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

  • platform/LocalizedStrings.h:

(WebCore): Added declarations of AXAMPMFieldText(), AXDayOfMonthFieldText(),
AXHourFieldText(), AXMillisecondFieldText(), AXMinuteFieldText(), AXMonthFieldText(),
AXSecondFieldText(), AXWeekOfYearFieldText(), and AXYearFieldText().

Source/WebKit/chromium:

This patch adds functions for getting localized strings of date time
fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

  • src/LocalizedStrings.cpp:

(WebCore::AXAMPMFieldText): Added.
(WebCore::AXDayOfMonthFieldText): Added.
(WebCore::AXHourFieldText): Added.
(WebCore::AXMillisecondFieldText): Added.
(WebCore::AXMinuteFieldText): Added.
(WebCore::AXMonthFieldText): Added.
(WebCore::AXSecondFieldText): Added.
(WebCore::AXWeekOfYearFieldText): Added.
(WebCore::AXYearFieldText): Added.

8:17 PM Changeset in webkit [127814] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r127808.
​http://trac.webkit.org/changeset/127808
​https://bugs.webkit.org/show_bug.cgi?id=96057

geoff rolled back in his change, but not this part (Requested
by thorton on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-06

  • inspector/debugger/debugger-expand-scope-expected.txt:
7:45 PM Changeset in webkit [127813] by commit-queue@webkit.org
  • 3 edits
    2 adds
    26 deletes in trunk/LayoutTests

fast/table/empty-row-crash.html and fast/table/inline-form-assert.html should be dumpAsText tests
​https://bugs.webkit.org/show_bug.cgi?id=95613

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-09-06
Reviewed by Julien Chaffraix.

Modified the test cases empty-row-crash.html and inline-form-assert.html to dumpAsText tests.
As the testcases check for crash/assert and not for the correctness of content layout or painting
they can be safely modified to dumpAsText tests.

  • fast/table/empty-row-crash-expected.txt: Added. New expected file.
  • fast/table/empty-row-crash.html: Added a short description about the testcase.
  • fast/table/inline-form-assert-expected.txt: Added. New expected file.
  • fast/table/inline-form-assert.html:
  • platform/chromium-linux/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-linux/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-mac/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-mac/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-win/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-win/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/chromium-win/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-win/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/efl/fast/table/empty-row-crash-expected.png: Removed.
  • platform/efl/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/efl/fast/table/inline-form-assert-expected.png: Removed.
  • platform/efl/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/gtk/fast/table/empty-row-crash-expected.png: Removed.
  • platform/gtk/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/gtk/fast/table/inline-form-assert-expected.png: Removed.
  • platform/gtk/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/mac/fast/table/empty-row-crash-expected.png: Removed.
  • platform/mac/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/mac/fast/table/inline-form-assert-expected.png: Removed.
  • platform/mac/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/qt/fast/table/empty-row-crash-expected.png: Removed.
  • platform/qt/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/qt/fast/table/inline-form-assert-expected.png: Removed.
  • platform/qt/fast/table/inline-form-assert-expected.txt: Removed. Removed obsolete baselines.
7:43 PM Changeset in webkit [127812] by tony@chromium.org
  • 4 edits in trunk/Source/WebCore

Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const
​https://bugs.webkit.org/show_bug.cgi?id=95907

Reviewed by Ojan Vafai.

This is refactoring to make RenderBox::computeLogicalWidth const. Make some methods that
get called by computeLogicalWidth const. We path in a struct that we populate with values.

No new tests, this is just a refactoring.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion): Make a LogicalExtentComputedValues to
hold results.
(WebCore::RenderBox::computePositionedLogicalWidth): Make const.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Change output to use LogicalExtentComputedValues
instead of 4 separate params.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Make const.

  • rendering/RenderBox.h:

(RenderBox): Add const and change out params to LogicalExtentComputedValues.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth): Make a LogicalExtentComputedValues to
hold results.

7:25 PM Changeset in webkit [127811] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
​https://bugs.webkit.org/show_bug.cgi?id=95831

Reviewed by Dimitri Glazkov.

Originally, the availability of author shadows was decided by ShadowRoot class.
This change moves that responsibility to each Element subclasses to make future
author shadow support improvement local to each replaced elements, rather than
touching ShadowRoot.cpp for reach.

No new tests. Should have no behavioral change.

  • dom/Element.h:
  • dom/ShadowRoot.cpp:

(WebCore::allowsAuthorShadowRoot):

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • svg/SVGElement.h:

(SVGElement):

6:42 PM Changeset in webkit [127810] by ggaren@apple.com
  • 17 edits
    2 adds in trunk

Source/JavaScriptCore: Rolled back in <​http://trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html, which
is to make sure that function declarations don't put their names in scope.

Reviewed by Gavin Barraclough.

Named functions should not allocate scope objects for their names
​https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

LayoutTests: Rolled back in <​http://trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Added a more explicit test for the feature I broke in
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Reviewed by Gavin Barraclough.

Named functions should not allocate scope objects for their names
​https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

  • fast/dom/HTMLScriptElement/script-reexecution.html:
  • fast/js/function-name-is-in-scope-expected.txt: Added.
  • fast/js/function-name-is-in-scope.html: Added.
6:29 PM Changeset in webkit [127809] by msaboff@apple.com
  • 4 edits in trunk/Source

16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
​https://bugs.webkit.org/show_bug.cgi?id=95810

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Added 8 bit path that copies the contents of an 8 bit fiber to the 16 bit buffer
when resolving a 16 bit rope.

  • runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeSlowCase):

Source/WTF:

New copy routine that takes an 8 bit source and a 16 bit destination. Used when copying
the contents of an 8 bit fiber to the 16 bit buffer when resolving a 16 bit rope.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::copyChars):
(StringImpl):

6:29 PM Changeset in webkit [127808] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, revert part of ​http://trac.webkit.org/changeset/127698
which accidentally didn't get reverted in
​http://trac.webkit.org/changeset/127774.

  • inspector/debugger/debugger-expand-scope-expected.txt:
6:16 PM Changeset in webkit [127807] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Qt] Unskip two encoding tests that pass now
​https://bugs.webkit.org/show_bug.cgi?id=96013

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

The result for frame-default-enc was incorrect and we succeed in
producing the existing cross-platform result. The other test passes
just fine.

  • platform/qt/Skipped:
  • platform/qt/fast/encoding/frame-default-enc-expected.txt: Removed.
5:57 PM Changeset in webkit [127806] by abarth@webkit.org
  • 64 edits in trunk/Source/WebCore

[V8] Weave creationContext through toV8 and related functions
​https://bugs.webkit.org/show_bug.cgi?id=96039

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-06
Reviewed by Eric Seidel.

In order to give DOM wrappers the correct prototype chain, we need to
know what the creationContext ought to be for each wrapper. This patch
weaves that information through toV8 and related functions.

This patch doesn't yet use the information. That will take place in a
separate patch. For that reason, this patch should not have any
behavior change.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::callFunction):

  • bindings/v8/IDBCustomBindings.cpp:

(WebCore::V8IDBCursorWithValue::valueAccessorGetter):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::V8ValueTraits::arrayV8Value):

  • bindings/v8/V8Collection.h:

(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

  • bindings/v8/V8ThrowException.cpp:

(WebCore):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):
(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::memoryAccessorGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::toV8):
(WebCore::V8Document::createTouchListCallback):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::getNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):
(WebCore::V8HTMLElement::itemValueAccessorGetter):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLOutputElementCustom.cpp:

(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):

  • bindings/v8/custom/V8PerformanceCustom.cpp:

(WebCore):
(WebCore::V8Performance::memoryAccessorGetter):

  • bindings/v8/custom/V8PerformanceEntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

  • dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

5:43 PM Changeset in webkit [127805] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed fix to r127799.
​https://bugs.webkit.org/show_bug.cgi?id=95807

Unreviewed fix.

Removed extraneous "static". This code is hidden behind STRING_STATS define and
therefore is not enabled by default.

  • wtf/text/StringImpl.cpp:
5:36 PM Changeset in webkit [127804] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[EFL] 2 mathml tests need rebaseline after r127769
​https://bugs.webkit.org/show_bug.cgi?id=96009

Unreviewed EFL gardening.

Update baselines for 2 mathml test cases needed after
r127769.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

  • platform/efl/mathml/presentation/roots-expected.png:
  • platform/efl/mathml/presentation/roots-expected.txt:
  • platform/efl/mathml/presentation/sup-expected.png:
  • platform/efl/mathml/presentation/sup-expected.txt:
5:21 PM Changeset in webkit [127803] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium Linux EWS bots and CQ bots are flaky
​https://bugs.webkit.org/show_bug.cgi?id=96041

Reviewed by Adam Barth.

Skip platform/chromium-linux/compositing/gestures tests on the
Chromium Linux EWS and CQ bots. By marking them as flaky, they won't
be run (the bots use --skip-failing-tests which causes them to skip
these tests). These will still run on the waterfall bots.

  • platform/chromium/TestExpectations:
4:54 PM Changeset in webkit [127802] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Qt] Deprecate String += operator
​https://bugs.webkit.org/show_bug.cgi?id=95895

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Source/WebCore:

Replaced String +=() with append.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::extraMediaControlsStyleSheet):

Source/WTF:

Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard.

  • wtf/Platform.h:
4:52 PM Changeset in webkit [127801] by msaboff@apple.com
  • 17 edits in trunk/Source/WebCore

Add 8 bit string data path to TextRun
​https://bugs.webkit.org/show_bug.cgi?id=95812

Reviewed by Dan Bernstein.

Added 8 bit string path to TextRun. Refactored TextRun::data() and ::characters into
8 and 16 bit versions. Made corresponding changes to users of TextRun.
For efl, gtk, qt and win platform specific code using TextRun, only the methods have
been renamed and the creation of 8 bit TextRuns has been disabled via compilation
flags. Someone knowledgeable in those platforms will need to make corresponding changes
to enable 8 bit processing of TextRuns.

No changes to functionality - behavior covered by existing tests.

  • platform/graphics/Font.cpp:

(WebCore::normalizeSpacesInternal):
(WebCore::Font::normalizeSpaces):
(WebCore::Font:normalizeSpaces):
(WebCore::Font::codePath):
(WebCore::Font::expansionOpportunityCount):

  • platform/graphics/Font.h:

(WebCore::Font::characterRangeCodePath):
(WebCore::Font::normalizeSpaces):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawBidiText):

  • platform/graphics/TextRun.cpp:

(ExpectedTextRunSize):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::subRun):
(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):
(WebCore::TextRun::characters8):
(WebCore::TextRun::characters16):
(WebCore::TextRun::is8Bit):
(WebCore::TextRun::setText):
(WebCore::TextRun::setCharactersLength):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advance):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::collectComplexTextRuns):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/pango/FontPango.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computeCanUseSimpleFontCodePath):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

4:50 PM Changeset in webkit [127800] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
​https://bugs.webkit.org/show_bug.cgi?id=96024

Reviewed by Adam Barth.

When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
We don't need to link anything in to WebKit.dll.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
4:41 PM Changeset in webkit [127799] by msaboff@apple.com
  • 3 edits in trunk/Source/WTF

ENH: Add Logging to StringImpl to track String Types
​https://bugs.webkit.org/show_bug.cgi?id=95807

Reviewed by Benjamin Poulain.

Added StringsStats class that keeps track of the number of strings, number of 8 and 16 bit
strings as well as the number of 8 bit strings up converted to 16 bits. The number of characrters
for each type is also accumulated. These statistics are output via DataLog every 5000
calls to StringImpl destructor. The 5000 can be adjusted via s_printStringStatsFrequency.
This StringStats code is disabled by default and enabled by defining STRING_STATS in
wtf/text/StringImpl.h.

  • wtf/text/StringImpl.cpp:

(WTF::StringStats::removeString):
(WTF::StringStats::printStats):
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::getData16SlowCase):

  • wtf/text/StringImpl.h:

(WTF::StringStats::add8BitString):
(StringStats):
(WTF::StringStats::add16BitString):
(WTF::StringStats::addUpconvertedString):
(WTF::StringImpl::StringImpl):
(StringImpl):
(WTF::StringImpl::isSubString):
(WTF::StringImpl::stringStats):

4:40 PM Changeset in webkit [127798] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

New tests introduced in r127704 fail
​https://bugs.webkit.org/show_bug.cgi?id=95952

Reviewed by Dan Bernstein.

Use the testRunner rather than layoutTestController because
layoutTestControler doesn't exist anymore.

  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:
4:23 PM Changeset in webkit [127797] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JS test suite puts incorrect limitations on Function.toString()
​https://bugs.webkit.org/show_bug.cgi?id=3975

Reviewed by Geoff Garen.

The result of function toString is implementation defined;
these test cases were looking for specific whitespace formatting
that matches mozilla's, and for redundant braces to be inserted
around if/else blocks. Stop that.

  • tests/mozilla/expected.html:
  • tests/mozilla/js1_2/function/tostring-1.js:

(simplify):

  • reduce whitespace differences
  • tests/mozilla/js1_2/function/tostring-2.js:

(simplify):

  • reduce whitespace differences

(TestOr):
(TestAnd):

  • added braces to match expected output
4:21 PM Changeset in webkit [127796] by jamesr@google.com
  • 2 edits in trunk/Source/Platform

[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
​https://bugs.webkit.org/show_bug.cgi?id=96025

Reviewed by Adrienne Walker.

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

4:21 PM Changeset in webkit [127795] by Simon Fraser
  • 9 edits
    2 adds in trunk/Source/WebCore

Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling
​https://bugs.webkit.org/show_bug.cgi?id=96026

Reviewed by James Robinson.

Lay some groundwork for threaded scrolling with fixed position and sticky
position objects, by packaging up logic related to how to reposition
fixed and sticky things on viewport changes into "constraints" classes.

ScrollingConstraints contains a 'ViewportConstraints' base class
that is subclassed for sticky position. These classes store
data about the constraints that govern the position of an object outside
of the render tree, and know how to compute a new position when the
viewport changes using only data in the class.

This patch changes RenderBoxModelObject to use the StickyPositionViewportConstraints
class for computing stick offsets at layout time. In the future, we'll have
the scrolling tree store copies of the constraint data for threaded scrolling.

  • CMakeLists.txt: Add ScrollingConstraints.* to the build.
  • GNUmakefile.list.am: Ditto
  • Target.pri: Ditto
  • WebCore.gypi: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto
  • WebCore.xcodeproj/project.pbxproj: Ditto
  • page/scrolling/ScrollingConstraints.cpp: Added.

(WebCore::StickyPositionViewportConstraints::computeStickyOffset):
(WebCore::StickyPositionViewportConstraints::layerPositionForViewportRect):

  • page/scrolling/ScrollingConstraints.h: Added.

(WebCore::ViewportConstraints::ViewportConstraints):
(WebCore::ViewportConstraints::~ViewportConstraints):
(WebCore::ViewportConstraints::anchorEdges):
(WebCore::ViewportConstraints::hasAnchorEdge):
(WebCore::ViewportConstraints::addAnchorEdge):
(WebCore::ViewportConstraints::alignmentOffset):
(WebCore::ViewportConstraints::setAlignmentOffset):
(StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::stickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setStickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::layerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setLayerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::leftOffset):
(WebCore::StickyPositionViewportConstraints::rightOffset):
(WebCore::StickyPositionViewportConstraints::topOffset):
(WebCore::StickyPositionViewportConstraints::bottomOffset):
(WebCore::StickyPositionViewportConstraints::setLeftOffset):
(WebCore::StickyPositionViewportConstraints::setRightOffset):
(WebCore::StickyPositionViewportConstraints::setTopOffset):
(WebCore::StickyPositionViewportConstraints::setBottomOffset):
(WebCore::StickyPositionViewportConstraints::setAbsoluteContainingBlockRect):
(WebCore::StickyPositionViewportConstraints::setAbsoluteStickyBoxRect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints): Fill out
data in the supplied StickyPositionViewportConstraints instance.
(WebCore::RenderBoxModelObject::stickyPositionOffset): Create a
StickyPositionViewportConstraints object on the stack and use it to
compute the sticky offset.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

4:17 PM Changeset in webkit [127794] by jamesr@google.com
  • 26 edits
    1 add in trunk

[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
​https://bugs.webkit.org/show_bug.cgi?id=96007

Reviewed by Adrienne Walker.

Source/Platform:

Updates comment to reference WebCompositorSupport instead of WebCompositor.

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Calls WebCompositorSupport functions instead of WebCompositor statics.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

Source/WebKit/chromium:

Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
WebCompositorInitializer RAII class to simplify this somewhat tedious process.

  • WebKit.gypi:
  • public/WebCompositorInputHandlerClient.h:

(WebCompositorInputHandlerClient):

  • src/WebCompositorInputHandlerImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::scheduleComposite):

  • tests/CCPrioritizedTextureTest.cpp:

(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(CCPrioritizedTextureTest):

  • tests/CCRendererGLTest.cpp:

(CCRendererGLTest::CCRendererGLTest):
(CCRendererGLTest::SetUp):
(CCRendererGLTest):

  • tests/CCTextureUpdateControllerTest.cpp:
  • tests/CCThreadedTest.cpp:

(WebKitTests::CCThreadedTest::runTest):

  • tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):

  • tests/LayerChromiumTest.cpp:
  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

  • tests/TextureLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/WebCompositorInitializer.h: Added.

(WebKit):
(WebKitTests):
(WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::TEST):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):

  • tests/WebLayerTest.cpp:
  • tests/WebLayerTreeViewTest.cpp:

Tools:

Fixes initialization / settings code to use WebCompositorSupport.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::setPerTilePaintingEnabled):

4:17 PM Changeset in webkit [127793] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
​https://bugs.webkit.org/show_bug.cgi?id=95995

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Provide proper implementation for PlatformWebView::windowFrame()
in EFL's WebKitTestRunner.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::windowFrame):

4:16 PM Changeset in webkit [127792] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-06

  • DEPS:
4:14 PM Changeset in webkit [127791] by commit-queue@webkit.org
  • 4 edits in trunk/Source

IndexedDB: make IDBKeyPath's string and array constructors explicit
​https://bugs.webkit.org/show_bug.cgi?id=96004

Patch by Alec Flett <​alecflett@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Source/WebCore:

Making these explicit to avoid accidental implicit conversions.

No new tests, existing tests cover correctness.

  • Modules/indexeddb/IDBKeyPath.h:

(IDBKeyPath):

Source/WebKit/chromium:

Fix test to use explicit constructor for IDBKeyPath.

  • tests/IDBDatabaseBackendTest.cpp:
3:48 PM Changeset in webkit [127790] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
​https://bugs.webkit.org/show_bug.cgi?id=96002

Reviewed by James Robinson.

This is a compositor unit test, so it shouldn't reference things
outside of the compositor like GraphicsContext. The
OpaqueRectTrackingContentLayerDelegateTest already tests opaque
tracking right at the time of paint. This test is about verifying that
transformed canvases work properly, so can just fake the opaque rect
coming back from the paint.

  • tests/ContentLayerChromiumTest.cpp:

(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

3:23 PM Changeset in webkit [127789] by commit-queue@webkit.org
  • 17 edits in trunk/Source

[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
​https://bugs.webkit.org/show_bug.cgi?id=95094

Patch by Jeff Timanus <​twiz@chromium.org> on 2012-09-06
Reviewed by Adrienne Walker.

Source/Platform:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
contentsScale behaviour.

  • chromium/public/WebContentLayer.h:

(WebContentLayer):

Export setBoundsContainPageScale() family of routines.

Source/WebCore:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
contentsScale behaviour.

Testing covered by existing compositor layout and unit tests.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setAppliesPageScale):
(WebCore::GraphicsLayer::appliesPageScale):

These routines are now virtual, so that they can push the notification to setDisregardsContentsScale in
LayerChromium.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore):
(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):

Now forwards the appliesPageScaleStatus to the owned layer.

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):
(WebCore):
(WebCore::LayerChromium::setBoundsContainPageScale):

setAppliesPageScale is renamed to setBoundsContainPageScale in LayerChromium.

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::boundsContainPageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore):
(WebCore::setScale):
(WebCore::updateLayerScale):
(WebCore::CCLayerTreeHost::updateLayers):

The contents scale of a layer is now applied in this routine.

Source/WebKit/chromium:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
contentsScale behaviour.
This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

Inform the layer associated with the NCCH that it is to disregard the page scale factor.
Also remove now unused m_deviceScaleFactor and associated routines.

(WebKit::NonCompositedContentHost::setViewport):

  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::setBoundsContainPageScale):
(WebKit):
(WebKit::WebContentLayerImpl::boundsContainPageScale):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • tests/CCLayerTreeHostTest.cpp:

(NoScaleContentLayerChromium):
(WebKitTests::NoScaleContentLayerChromium::create):
(WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
(WebKitTests):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):

Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the
scale on the draw transforms remain identity.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit): Remove now obsolete unit-test.

3:07 PM Changeset in webkit [127788] by alokp@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove failures for acceletared-drawing tests.

Unreviewed.

Update chromium TestExpectations to remove failures for accelerated-painting.
They were fixed in r127294.

  • platform/chromium/TestExpectations:
2:44 PM Changeset in webkit [127787] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Split platform geometry types into separate static target
​https://bugs.webkit.org/show_bug.cgi?id=96021

Reviewed by Tony Chang.

This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
This library is relatively standalone and useful to statically link against in other contexts.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
2:41 PM Changeset in webkit [127786] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Fuzzy load the Edje theme for HTML forms
​https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Antonio Gomes.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):

Add some convenience macros.

(WebCore::applyColorCallback):

Use just one callback from the edje theme, which just calls
setColorFromThemeClass.

(WebCore::fillColorsFromEdjeClass):

Add convenience method for receiving colors from Edje and
storing them in Color's.

(WebCore::RenderThemeEfl::setColorFromThemeClass):

Set the class Color variabled with the values from the theme
color class.

(WebCore::RenderThemeEfl::setThemePath):

Don't apply the theme immediately.

(WebCore::RenderThemeEfl::loadTheme):

Load the new theme and free the current one. If it fails,
it will continue using the old one, if exists.

(WebCore::RenderThemeEfl::adjustSizeConstraints):
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformFocusRingColor):

Ensure the theme is loaded.

(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):

Ensure the theme is loaded.

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(WebCore::RenderThemeEfl::loadThemeIfNeeded):

Remove unneeded methods and add a method for loading a theme
in the case it is not loaded yet.

2:24 PM Changeset in webkit [127785] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Classify several test cases in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=95947

Unreviewed EFL gardening.

Update TestExpectations to classify a few test case failures
as being caused by lack on undo/redo stack implementation
in EFL WK2.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

  • platform/efl-wk2/TestExpectations:
2:23 PM Changeset in webkit [127784] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
​https://bugs.webkit.org/show_bug.cgi?id=95994

Reviewed by James Robinson.

This compositor test shouldn't depend on code outside the compositor.

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::FakeWebScrollbar::create):
(FakeWebScrollbar):
(WebCore::TEST):

2:04 PM Changeset in webkit [127783] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
​https://bugs.webkit.org/show_bug.cgi?id=96017

Reviewed by James Robinson.

FrameView already has a HashSet of RenderObjects whose position
is affected by the viewport rect; this contains fixed and sticky-postion
objects. RenderView::setFixedPositionedObjectsNeedLayout() was using
the RenderView's list of postioned objects, but this omitted sticky-position
objects whose container was not the RenderView. So it's simpler to use
FrameView's set of fixed/sticky objects.

Changed the terminology from "fixed" to "viewport-constrained" for this set
of objects.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):

  • page/FrameView.h:

(WebCore::FrameView::viewportConstrainedObjects):
(WebCore::FrameView::hasViewportConstrainedObjects):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::styleDidChange):

  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
2:00 PM Changeset in webkit [127782] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

Add data-blackberry-webworks-context attribute and set the custom context when
getting context.
​https://bugs.webkit.org/show_bug.cgi?id=95993

Patch by Genevieve Mak <​gmak@rim.com> on 2012-09-06
Reviewed by Antonio Gomes.

PR #193726
Reviewed Internally by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

  • Check for custom WebWorks context and add it if there.
  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::webWorksContext):
(DOMSupport):

  • WebKitSupport/DOMSupport.h:
    • Add a method that checks a given element for the data-webworks-context attribute and returns its value if present.
1:55 PM Changeset in webkit [127781] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Put chromium implementations of WTF symbols in separate static library
​https://bugs.webkit.org/show_bug.cgi?id=95933

Reviewed by Adam Barth.

A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
component build is a DLL. This moves these files into a static library that webkit depends on so targets can
statically link in wtf and these support files without depending directly on webkit.

  • WebKit.gyp:
1:19 PM Changeset in webkit [127780] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
​https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <​poenaru@adobe.com> on 2012-09-06
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
1:06 PM Changeset in webkit [127779] by annacc@chromium.org
  • 3 edits
    2 adds in trunk

ASSERT reached when TextTrack.mode is set to DISABLED.
​https://bugs.webkit.org/show_bug.cgi?id=94651

Reviewed by Eric Carlson.

This patch ensures that cues that have already been added to the
cueTree in HTMLMediaElement, are not added again.

Source/WebCore:

Test: media/track/track-mode-disabled-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackAddCue): Do not add the cue if it already
exists in m_cueTree.

LayoutTests:

  • media/track/track-mode-disabled-crash-expected.txt: Added.
  • media/track/track-mode-disabled-crash.html: Added.
12:54 PM Changeset in webkit [127778] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Performance regressions on 32-bit platforms with revisions 125637 and 126387
​https://bugs.webkit.org/show_bug.cgi?id=95953

Reviewed by Filip Pizlo.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val): Fix the typo.

12:53 PM Changeset in webkit [127777] by ggaren@apple.com
  • 3 edits in trunk/LayoutTests

Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
because I rolled out the patch that broke it.

  • platform/qt/Skipped:
  • platform/win/Skipped:
12:52 PM Changeset in webkit [127776] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
​https://bugs.webkit.org/show_bug.cgi?id=93998

Patch by Iain Merrick <​husky@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

These provide the same functionality selectRange(WebPoint, WebPoint),
with finer-grained control needed on the Android platform. By passing
allowCollapsedSelection=false, we can ensure the selection stays at
least one character wide.

I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
calling the new methods. The existing test passes, and I've added new
tests for the new methods.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit):
(WebKit::WebFrameImpl::moveSelectionStart):
(WebKit::WebFrameImpl::moveSelectionEnd):
(WebKit::WebFrameImpl::moveCaret):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • tests/WebFrameTest.cpp:
  • tests/data/text_selection.html: Added.
12:50 PM Changeset in webkit [127775] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Fix WTF.Lrint on 32-bit platforms
​https://bugs.webkit.org/show_bug.cgi?id=96003

Patch by Fady Samuel <​fsamuel@chromium.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Fixed failing WTF.Lrint test on 32-bit platforms.

  • TestWebKitAPI/Tests/WTF/MathExtras.cpp:

(TestWebKitAPI::TEST):

12:45 PM Changeset in webkit [127774] by ggaren@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Rolled out <​http://trac.webkit.org/changeset/127698> because it broke
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html

Named functions should not allocate scope objects for their names
​https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

12:29 PM Changeset in webkit [127773] by commit-queue@webkit.org
  • 33 edits
    23 deletes in trunk/LayoutTests

[chromium] Need to rebaseline chromium tests after hidpi changes
​https://bugs.webkit.org/show_bug.cgi?id=95579

Patch by Alex Sakhartchouk <​alexst@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Adding double resolution files for hidpi tests and updating expectations for broken image tests.

  • platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
  • platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
  • platform/chromium-linux/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Removed.
  • platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/chromium-mac/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png:
  • platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png:
  • platform/chromium-win/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png:
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium/TestExpectations:
12:22 PM Changeset in webkit [127772] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Allow overscroll to composited scroll layers
​https://bugs.webkit.org/show_bug.cgi?id=95998
PR #195305

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>
Internally reviewed by Gen Mak.

No need to reset the overscroll limit factor at creation to 0.
It is already 0 by default, and later on the client sets the
appropriated value.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

12:20 PM Changeset in webkit [127771] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Another unreviewed GTK build fix.

The ENABLE_DATALIST_ELEMENT should default to 0, as it did in stable
release versions before r127760. The feature define can be switched
on later, when its stability is determined and the test results are
rebaselined.

  • GNUmakefile.features.am:
12:16 PM Changeset in webkit [127770] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping failing test: fast/forms/number/number-interactive-validation-required.html
Interactive form validation is not enabled on Windows. It's fine to skip this test.

  • platform/win/Skipped:
12:04 PM Changeset in webkit [127769] by Dave Barton
  • 9 edits in trunk

mathml.css: Add more { white-space: nowrap } declarations
​https://bugs.webkit.org/show_bug.cgi?id=95404

Reviewed by Eric Seidel.

mathml.css declared { white-space: nowrap } for mrow, mfenced, msqrt. It is also needed
for other tags such as msub, msup, msubsup.

Added a test to mathml/presentation/sup.xhtml, and a regression test to roots.xhtml.

Source/WebCore:

  • css/mathml.css:

(mo, mrow, mfenced, mfrac, msub, msup, msubsup, munder, mover, munderover, msqrt, mroot):

LayoutTests:

  • mathml/presentation/roots.xhtml:
  • mathml/presentation/sup.xhtml:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
12:02 PM Changeset in webkit [127768] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecution.html
​https://bugs.webkit.org/show_bug.cgi?id=95944

  • platform/win/Skipped:
11:54 AM Changeset in webkit [127767] by rjkroege@chromium.org
  • 8 edits in trunk/Source

[chromium] Enable different fling behaviour for touchscreen and touchpad
​https://bugs.webkit.org/show_bug.cgi?id=95756

Reviewed by James Robinson.

Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
events by their originating device and pass this flag to a factory that produces
different device specific fling curves based on the value of the flag.

Source/WebCore:

Covered by existing layout and unit tests.

  • platform/chromium/support/PlatformGestureCurveFactory.cpp: Modified factory

entry point for constructing fling curve for different devices.
(WebKit::PlatformGestureCurveFactory::createCurve):

  • platform/chromium/support/PlatformGestureCurveFactory.h:

(PlatformGestureCurveFactory):

Source/WebKit/chromium:

  • public/WebActiveWheelFlingParameters.h:

(WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):

  • public/WebInputEvent.h: Added source device flag to WebGestureEvent.
  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to
obtain device-appropriate fling curve.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
fling curve.
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):

11:50 AM Changeset in webkit [127766] by tommyw@google.com
  • 25 edits
    7 copies
    2 adds in trunk

MediaStream API: Add the local and remote description functionality to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=95839

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):

Source/WebCore:

As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.

Tests: fast/mediastream/RTCPeerConnection-localDescription.html

fast/mediastream/RTCPeerConnection-remoteDescription.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h:

(RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h:

(RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:

(RTCSessionDescriptionRequestImpl):

  • Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.

(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):

  • Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.

(WebCore):
(RTCVoidRequestImpl):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.

(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
11:43 AM Changeset in webkit [127765] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix one of the Qt builds.

  • dom/TransformSource.h:
11:40 AM Changeset in webkit [127764] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix.

CSS Compositing is not currently supported on the GTK port, so
the feature define should default to 0.

  • GNUmakefile.features.am:
11:16 AM Changeset in webkit [127763] by zandobersek@gmail.com
  • 2 edits
    21 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Generating required platform-specific baselines after r127608.

Adding failure expectations for regressions introduced in r127698 and r127704.

Fixing and removing duplicate expectations to get the file to pass linting.

  • platform/gtk/TestExpectations:
  • platform/gtk/css3/masking: Added.
  • platform/gtk/css3/masking/clip-path-circle-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-polygon-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Added.
11:13 AM Changeset in webkit [127762] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

SharedGraphicsContext3D shouldn't depend on CCProxy
​https://bugs.webkit.org/show_bug.cgi?id=95921

Reviewed by Adrienne Walker.

This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
code in WTF to do that.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):

11:06 AM Changeset in webkit [127761] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Fix export macros in IntegerToStringConversion.h
​https://bugs.webkit.org/show_bug.cgi?id=95900

Reviewed by Benjamin Poulain.

The WTF_EXPORT_STRING_API must be used only for symbols which are compiled
on windows in "non-WTF" binaries too. Since this isn't valid for the
IntegerToStringConversion function replace it with WTF_EXPORT_PRIVATE.

  • wtf/text/IntegerToStringConversion.h:
10:58 AM Changeset in webkit [127760] by zandobersek@gmail.com
  • 5 edits in trunk

[Gtk] Remove configuration options for features that are not supported by the Gtk port
​https://bugs.webkit.org/show_bug.cgi?id=87664

Reviewed by Martin Robinson.

.:

Remove configuration options for features that are completely unsupported by the GTK port.
They only bloat the configure.ac file. They should be re-added when the feature becomes
supported and introduces an external dependency that the users might want to avoid.

  • configure.ac:

Source/WebCore:

Remove addition of macros to feature_defines for features that are completely
unsupported by the Gtk port. They're not required anymore since the accompanying
configuration flags are also being removed.

No new tests - no new functionality.

  • GNUmakefile.am:
  • bindings/gobject/GNUmakefile.am:
10:52 AM Changeset in webkit [127759] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit2

Merge r127750 - [GTK] [WK2] Crash when navigating between pages
​https://bugs.webkit.org/show_bug.cgi?id=95949

Reviewed by Martin Robinson.

Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.

  • UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didInitiateLoadForResource):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted):

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
10:52 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
10:44 AM Changeset in webkit [127758] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
​https://bugs.webkit.org/show_bug.cgi?id=95891

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-09-06
Reviewed by Dean Jackson.

Now we unbind the vertex attributes after a custom filter is applied.

Before this patch, Chromium's GPU process would sometimes print the following error message:
"ERROR:gles2_cmd_decoder.cc(5142)] 002CA47B: GL ERROR :GL_INVALID_OPERATION :
glDrawElements: attempt to render with no buffer attached to enabled attribute 2"

This would happen in the following situation:
1) There are two FECustomFilters on the page.
2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The

detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached
FECustomFilter.

3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound.
4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer

attached to the a_triangleCoord attribute.

No new tests. We can't create an automated test for this because it only reproduces using
Chromium's GPU process. DRT does not use Chromium's GPU process.

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::applyShader):

Unbind the vertex attributes after the drawElements call.

(WebCore::FECustomFilter::unbindVertexAttribute):
(WebCore):
(WebCore::FECustomFilter::unbindVertexAttributes):

Unbind all of the attributes that we bound earlier.

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

10:36 AM Changeset in webkit [127757] by weinig@apple.com
  • 556 edits
    1 delete in trunk/Source

Part 2 of removing PlatformString.h, remove PlatformString.h
​https://bugs.webkit.org/show_bug.cgi?id=95931

Reviewed by Adam Barth.

Remove PlatformString.h

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/filesystem/AsyncFileWriter.h:
  • Modules/filesystem/DOMFilePath.h:
  • Modules/filesystem/DOMFileSystemBase.h:
  • Modules/filesystem/DirectoryEntry.h:
  • Modules/filesystem/DirectoryEntrySync.h:
  • Modules/filesystem/DirectoryReader.h:
  • Modules/filesystem/DirectoryReaderBase.h:
  • Modules/filesystem/DirectoryReaderSync.h:
  • Modules/filesystem/EntryBase.cpp:
  • Modules/filesystem/EntrySync.h:
  • Modules/filesystem/FileEntrySync.h:
  • Modules/filesystem/FileSystemCallbacks.h:
  • Modules/filesystem/LocalFileSystem.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/Geoposition.h:
  • Modules/geolocation/PositionError.h:
  • Modules/indexeddb/IDBAny.h:
  • Modules/indexeddb/IDBDatabaseBackendInterface.h:
  • Modules/indexeddb/IDBDatabaseCallbacks.h:
  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
  • Modules/indexeddb/IDBDatabaseError.h:
  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBIndex.h:
  • Modules/indexeddb/IDBIndexBackendInterface.h:
  • Modules/indexeddb/IDBKey.h:
  • Modules/indexeddb/IDBKeyPath.h:
  • Modules/indexeddb/IDBMetadata.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/IDBUpgradeNeededEvent.h:
  • Modules/indexeddb/IDBVersionChangeEvent.h:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/networkinfo/NetworkInfoConnection.h:
  • Modules/notifications/DOMWindowNotifications.h:
  • Modules/speech/SpeechGrammar.h:
  • Modules/speech/SpeechRecognition.h:
  • Modules/speech/SpeechRecognitionAlternative.h:
  • Modules/speech/SpeechRecognitionClient.h:
  • Modules/speech/SpeechRecognitionError.h:
  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/AudioParam.h:
  • Modules/webdatabase/AbstractDatabase.h:
  • Modules/webdatabase/ChangeVersionWrapper.h:
  • Modules/webdatabase/DOMWindowWebDatabase.h:
  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseAuthorizer.cpp:
  • Modules/webdatabase/DatabaseAuthorizer.h:
  • Modules/webdatabase/DatabaseDetails.h:
  • Modules/webdatabase/DatabaseSync.h:
  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginUsageRecord.h:
  • Modules/webdatabase/SQLError.h:
  • Modules/webdatabase/SQLStatement.h:
  • Modules/webdatabase/SQLStatementSync.h:
  • Modules/webdatabase/SQLTransaction.cpp:
  • Modules/webdatabase/SQLTransactionSync.cpp:
  • Modules/webdatabase/SQLTransactionSync.h:
  • Modules/webdatabase/WorkerContextWebDatabase.h:
  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
  • Modules/webdatabase/chromium/QuotaTracker.h:
  • Modules/websockets/ThreadableWebSocketChannel.cpp:
  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WebSocketHandshake.h:
  • Modules/websockets/WebSocketHandshakeResponse.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/ConvertToUTF8String.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSImageDataCustom.cpp:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/js/JSLazyEventListener.h:
  • bindings/js/JSStorageCustom.cpp:
  • bindings/js/JSXSLTProcessorCustom.cpp:
  • bindings/js/JavaScriptCallFrame.cpp:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptHeapSnapshot.h:
  • bindings/js/ScriptValue.h:
  • bindings/js/SerializedScriptValue.h:
  • bindings/objc/DOMCustomXPathNSResolver.mm:
  • bindings/objc/DOMXPath.mm:
  • bindings/objc/WebScriptObject.mm:
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(AddIncludesForSVGAnimatedType):

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • bindings/v8/Dictionary.h:
  • bindings/v8/JavaScriptCallFrame.h:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/ScriptFunctionCall.h:
  • bindings/v8/ScriptHeapSnapshot.h:
  • bindings/v8/ScriptProfile.h:
  • bindings/v8/ScriptProfileNode.h:
  • bindings/v8/ScriptProfiler.h:
  • bindings/v8/ScriptSourceCode.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8LazyEventListener.h:
  • bindings/v8/V8NPUtils.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bridge/IdentifierRep.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/c/c_utility.cpp:
  • css/CSSBasicShapes.h:
  • css/CSSBorderImageSliceValue.cpp:
  • css/CSSCharsetRule.h:
  • css/CSSCursorImageValue.cpp:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSGradientValue.cpp:
  • css/CSSInheritedValue.cpp:
  • css/CSSInitialValue.cpp:
  • css/CSSLineBoxContainValue.cpp:
  • css/CSSMediaRule.h:
  • css/CSSProperty.cpp:
  • css/CSSPropertySourceData.cpp:
  • css/CSSPropertySourceData.h:
  • css/CSSReflectValue.cpp:
  • css/CSSTimingFunctionValue.cpp:
  • css/CSSUnicodeRangeValue.cpp:
  • css/CSSValueList.cpp:
  • css/Counter.h:
  • css/FontFeatureValue.h:
  • css/FontValue.cpp:
  • css/MediaQuery.h:
  • css/MediaQueryEvaluator.h:
  • css/MediaQueryListListener.h:
  • css/ShadowValue.cpp:
  • css/StyleMedia.h:
  • css/StyleSheet.h:
  • css/StyleSheetList.cpp:
  • css/WebKitCSSMatrix.h:
  • css/WebKitCSSTransformValue.cpp:
  • dom/DOMStringList.h:
  • dom/DOMStringMap.h:
  • dom/DocumentMarker.h:
  • dom/ErrorEvent.h:
  • dom/ExceptionBase.h:
  • dom/MessagePortChannel.h:
  • dom/MutationRecord.h:
  • dom/TransformSource.h:
  • dom/ViewportArguments.cpp:
  • editing/DOMTransactionStep.h:
  • editing/EditingStyle.h:
  • editing/MarkupAccumulator.h:
  • editing/SmartReplaceICU.cpp:
  • editing/SpellChecker.h:
  • editing/SurroundingText.h:
  • fileapi/AsyncFileStream.cpp:
  • fileapi/Blob.h:
  • fileapi/BlobURL.cpp:
  • fileapi/File.h:
  • history/HistoryItem.h:
  • history/blackberry/HistoryItemViewState.h:
  • history/cf/HistoryPropertyList.h:
  • html/DOMFormData.cpp:
  • html/DOMURL.h:
  • html/MicroDataItemValue.h:
  • html/PublicURLManager.h:
  • html/canvas/CanvasPattern.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasStyle.h:
  • html/canvas/WebGLActiveInfo.h:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.h:
  • html/parser/CSSPreloadScanner.h:
  • html/parser/HTMLEntitySearch.h:
  • html/parser/HTMLEntityTable.h:
  • html/parser/HTMLMetaCharsetParser.cpp:
  • inspector/CodeGeneratorInspector.py:

(InspectorFrontend_h):

  • inspector/ContentSearchUtils.h:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScriptBase.cpp:
  • inspector/InjectedScriptManager.h:
  • inspector/InjectedScriptModule.h:
  • inspector/InjectedScriptWebGLModule.h:
  • inspector/InspectorAgent.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorState.h:
  • inspector/InspectorStyleSheet.h:
  • inspector/InspectorStyleTextEditor.h:
  • inspector/InspectorValues.h:
  • inspector/InspectorWebGLAgent.h:
  • inspector/InspectorWorkerResource.h:
  • inspector/ScriptArguments.h:
  • inspector/ScriptBreakpoint.h:
  • inspector/ScriptCallFrame.h:
  • inspector/ScriptDebugListener.h:
  • inspector/TimelineRecordFactory.h:
  • inspector/generate-inspector-protocol-version:

(main):

  • loader/DocumentLoader.cpp:
  • loader/DocumentWriter.h:
  • loader/FTPDirectoryParser.h:
  • loader/FormState.h:
  • loader/HistoryController.h:
  • loader/PolicyChecker.h:
  • loader/ResourceLoadScheduler.h:
  • loader/SubframeLoader.h:
  • loader/SubstituteData.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/archive/ArchiveFactory.cpp:
  • loader/archive/ArchiveResourceCollection.h:
  • loader/cache/CachedResource.h:
  • loader/cache/MemoryCache.h:
  • loader/icon/IconRecord.h:
  • loader/icon/PageURLRecord.h:
  • loader/mac/LoaderNSURLExtras.mm:
  • loader/win/DocumentLoaderWin.cpp:
  • page/Console.cpp:
  • page/Coordinates.h:
  • page/DOMSelection.cpp:
  • page/EventSource.cpp:
  • page/GroupSettings.h:
  • page/NavigatorBase.cpp:
  • page/OriginAccessEntry.h:
  • page/Page.h:
  • page/SecurityOrigin.h:
  • page/SpeechInputResult.h:
  • page/UserContentURLPattern.h:
  • page/WindowFeatures.cpp:
  • page/WindowFeatures.h:
  • page/WorkerNavigator.h:
  • page/animation/AnimationControllerPrivate.h:
  • platform/AsyncFileSystem.h:
  • platform/AsyncFileSystemCallbacks.h:
  • platform/ContentType.h:
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h:
  • platform/Cookie.h:
  • platform/CrossThreadCopier.cpp:
  • platform/DateComponents.cpp:
  • platform/FileChooser.h:
  • platform/FileStream.cpp:
  • platform/FileSystem.h:
  • platform/KURL.cpp:

(WebCore):

  • platform/KURL.h:
  • platform/KURLHash.h:
  • platform/KillRing.h:
  • platform/Language.cpp:
  • platform/Length.cpp:
  • platform/LinkHash.cpp:
  • platform/Logging.cpp:
  • platform/MIMETypeRegistry.h:
  • platform/SSLKeyGenerator.h:
  • platform/SchemeRegistry.h:
  • platform/SharedBuffer.h:
  • platform/Theme.h:
  • platform/UUID.h:
  • platform/animation/Animation.h:
  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieMap.h:
  • platform/blackberry/DragDataBlackBerry.cpp:
  • platform/blackberry/KURLBlackBerry.cpp:
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:
  • platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
  • platform/blackberry/TemporaryLinkStubs.cpp:
  • platform/cf/FileSystemCF.cpp:
  • platform/cf/SchedulePair.h:
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardUtilitiesChromium.cpp:
  • platform/chromium/DragDataChromium.cpp:
  • platform/chromium/FileSystemChromium.cpp:
  • platform/chromium/FileSystemChromiumMac.mm:
  • platform/chromium/LanguageChromium.cpp:
  • platform/chromium/SSLKeyGeneratorChromium.cpp:
  • platform/cocoa/KeyEventCocoa.mm:
  • platform/efl/ErrorsEfl.h:
  • platform/efl/LanguageEfl.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:
  • platform/efl/LoggingEfl.cpp:
  • platform/efl/PasteboardEfl.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/FontPlatformData.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/SegmentedFontData.cpp:
  • platform/graphics/blackberry/IconBlackBerry.cpp:
  • platform/graphics/blackberry/LayerData.h:
  • platform/graphics/blackberry/LayerFilterRenderer.cpp:
  • platform/graphics/blackberry/LayerRenderer.cpp:
  • platform/graphics/blackberry/skia/PlatformSupport.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/PlatformCALayerClient.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cg/ImageSourceCGMac.mm:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:
  • platform/graphics/chromium/IconChromium.cpp:
  • platform/graphics/chromium/IconChromiumAndroid.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/efl/IconEfl.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
  • platform/graphics/mac/IconMac.mm:
  • platform/graphics/mac/ImageMac.mm:
  • platform/graphics/opentype/OpenTypeUtilities.h:
  • platform/graphics/openvg/PathOpenVG.cpp:
  • platform/graphics/pango/FontPlatformDataPango.cpp:
  • platform/graphics/qt/FontCacheQt.cpp:
  • platform/graphics/qt/FontPlatformDataQt.cpp:
  • platform/graphics/qt/IconQt.cpp:
  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/skia/FontCustomPlatformData.h:
  • platform/graphics/skia/ImageSkia.cpp:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontPlatformDataCGWin.cpp:
  • platform/graphics/win/FontPlatformDataCairoWin.cpp:
  • platform/graphics/win/FontPlatformDataWin.cpp:
  • platform/graphics/win/IconWin.cpp:
  • platform/graphics/win/ImageCGWin.cpp:
  • platform/graphics/win/ImageCairoWin.cpp:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/wince/FontCustomPlatformData.h:
  • platform/graphics/wince/FontPlatformData.cpp:
  • platform/graphics/wince/ImageWinCE.cpp:
  • platform/graphics/wince/MediaPlayerProxy.cpp:
  • platform/graphics/wince/PathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.cpp:
  • platform/graphics/wx/FontCacheWx.cpp:
  • platform/graphics/wx/FontPlatformDataWx.cpp:
  • platform/graphics/wx/IconWx.cpp:
  • platform/graphics/wx/PathWx.cpp:
  • platform/gtk/ErrorsGtk.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/GtkPopupMenu.h:
  • platform/gtk/KeyBindingTranslator.h:
  • platform/gtk/LanguageGtk.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/gtk/LoggingGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/image-decoders/ImageDecoder.h:
  • platform/leveldb/LevelDBSlice.h:
  • platform/mac/FileSystemMac.mm:
  • platform/mediastream/MediaStreamSource.h:
  • platform/mock/GeolocationClientMock.h:
  • platform/network/BlobData.h:
  • platform/network/BlobRegistryImpl.h:
  • platform/network/BlobResourceHandle.h:
  • platform/network/Credential.h:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.cpp:
  • platform/network/HTTPRequest.h:
  • platform/network/HTTPValidation.cpp:
  • platform/network/ProtectionSpace.h:
  • platform/network/ResourceErrorBase.h:
  • platform/network/SocketStreamErrorBase.h:
  • platform/network/blackberry/DNSBlackBerry.cpp:
  • platform/network/blackberry/DeferredData.h:
  • platform/network/blackberry/NetworkJob.h:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/curl/CookieJarCurl.cpp:
  • platform/network/curl/ResourceHandleManager.h:
  • platform/network/qt/DnsPrefetchHelper.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp:
  • platform/network/soup/ResourceResponseSoup.cpp:
  • platform/network/win/CookieJarWin.cpp:
  • platform/posix/FileSystemPOSIX.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/CookieJarQt.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/qt/LanguageQt.cpp:
  • platform/qt/LocalizedStringsQt.cpp:
  • platform/qt/LoggingQt.cpp:
  • platform/qt/PlatformSupport.h:
  • platform/sql/SQLValue.h:
  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteFileSystem.h:
  • platform/text/DecodeEscapeSequences.h:
  • platform/text/LineEnding.cpp:
  • platform/text/ParserUtilities.h:
  • platform/text/PlatformString.h: Removed.
  • platform/text/RegularExpression.h:
  • platform/text/SegmentedString.h:
  • platform/text/StringWithDirection.h:
  • platform/text/SuffixTree.h:
  • platform/text/TextBreakIteratorICU.cpp:
  • platform/text/TextCodec.cpp:
  • platform/text/TextCodec.h:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF16.cpp:
  • platform/text/TextCodecUserDefined.cpp:
  • platform/text/TextEncoding.cpp:
  • platform/text/blackberry/StringBlackBerry.cpp:
  • platform/text/cf/StringCF.cpp:
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
  • platform/text/gtk/TextCodecGtk.cpp:
  • platform/text/mac/StringMac.mm:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/qt/TextCodecQt.cpp:
  • platform/text/win/TextCodecWin.h:
  • platform/text/wince/TextBreakIteratorWinCE.cpp:
  • platform/win/BString.cpp:
  • platform/win/DragDataWin.cpp:
  • platform/win/GDIObjectCounter.h:
  • platform/win/LoggingWin.cpp:
  • platform/win/WCDataObject.cpp:
  • platform/wince/DragDataWinCE.cpp:
  • platform/wx/ClipboardWx.cpp:
  • platform/wx/FileSystemWx.cpp:
  • platform/wx/LanguageWx.cpp:
  • platform/wx/LocalizedStringsWx.cpp:
  • platform/wx/LoggingWx.cpp:
  • platform/wx/PasteboardWx.cpp:
  • platform/wx/PopupMenuWx.cpp:
  • plugins/PluginData.h:
  • plugins/PluginDatabase.h:
  • plugins/PluginDebug.cpp:
  • plugins/PluginPackage.h:
  • plugins/PluginStream.h:
  • rendering/style/StyleDashboardRegion.h:
  • storage/Storage.cpp:
  • storage/StorageArea.h:
  • storage/StorageEvent.h:
  • storage/StorageEventDispatcher.h:
  • storage/StorageMap.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.h:
  • storage/StorageTask.h:
  • storage/StorageTracker.h:
  • svg/SVGPathByteStreamBuilder.h:
  • svg/SVGPathParser.h:
  • svg/SVGPathStringSource.h:
  • svg/SVGStyledElement.cpp:
  • svg/animation/SMILTimeContainer.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp:
  • svg/graphics/filters/SVGFilterBuilder.h:
  • testing/Internals.h:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/WorkerLocation.cpp:
  • workers/WorkerThread.cpp:
  • xml/DOMParser.cpp:
  • xml/NativeXPathNSResolver.cpp:
  • xml/XMLSerializer.cpp:
  • xml/XMLSerializer.h:
  • xml/XPathExpression.cpp:
  • xml/XPathValue.h:
  • xml/XSLTUnicodeSort.cpp:

Source/WebKit/blackberry:

  • Api/DumpRenderTreeClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/InspectorClientBlackBerry.h:
  • WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
  • WebKitSupport/AboutData.h:

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::createFrontendSettings):

Source/WebKit/chromium:

  • src/ContextMenuClientImpl.cpp:
  • src/EditorClientImpl.cpp:
  • src/InspectorFrontendClientImpl.cpp:
  • src/LocalFileSystemChromium.cpp:
  • src/SpeechInputClientImpl.cpp:
  • src/SpeechRecognitionClientProxy.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsFrontendImpl.cpp:
  • src/WebDevToolsFrontendImpl.h:
  • src/WebEntities.h:
  • src/WebFrameImpl.h:
  • src/WorkerFileSystemCallbacksBridge.h:
  • tests/UniscribeHelperTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.cpp:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
  • gdom/ConvertToGCharPrivate.h:
  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebresource.cpp:

Source/WebKit/mac:

  • History/WebHistoryItem.mm:
  • Misc/WebStringTruncator.mm:
  • Plugins/Hosted/NetscapePluginHostManager.h:

(NetscapePluginHostManager):

  • Plugins/WebPluginController.mm:
  • Storage/WebStorageTrackerClient.mm:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebIconDatabaseClient.mm:
  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):
(WebInspectorFrontendClient):

  • WebView/WebRenderLayer.mm:
  • WebView/WebViewData.h:

Source/WebKit/qt:

  • Api/qwebdatabase_p.h:
  • Api/qwebframe_p.h:
  • Api/qwebhistory.cpp:
  • Api/qwebhistoryinterface.cpp:
  • Api/qwebpage_p.h:
  • Api/qwebsettings.cpp:
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/InspectorClientQt.cpp:

Source/WebKit/win:

  • DOMCSSClasses.cpp:
  • DefaultPolicyDelegate.cpp:
  • MarshallingHelpers.cpp:
  • WebCoreSupport/WebInspectorClient.h:
  • WebDownload.h:
  • WebFrame.h:
  • WebHistoryItem.h:
  • WebIconDatabase.cpp:
  • WebKitDLL.h:
  • WebKitGraphics.cpp:
  • WebKitSystemBits.cpp:
  • WebLocalizableStrings.cpp:
  • WebNotificationCenter.cpp:
  • WebResource.h:

Source/WebKit/wx:

  • WebFrame.cpp:
  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/EditorClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/InspectorClientWx.cpp:
  • WebSettings.cpp:
  • WebView.cpp:
10:29 AM Changeset in webkit [127756] by danakj@chromium.org
  • 6 edits in trunk/Source

[chromium] Add a customized copy() method to CCRenderPassDrawQuad
​https://bugs.webkit.org/show_bug.cgi?id=95871

Reviewed by Adrienne Walker.

Source/WebCore:

CCRenderPassDrawQuad is special because a copied quad will need to
point to a different RenderPass id, since new ids are given to copied
RenderPasses. Add a custom copy() method to CCRenderPassDrawQuad that
takes as input the new RenderPass id that should appear in the copied
quad.

Test: CCDrawQuad.copyRenderPassDrawQuad

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::copy):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

Source/WebKit/chromium:

  • tests/CCDrawQuadTest.cpp:

(WebCore):
(WebCore::TEST):

10:26 AM Changeset in webkit [127755] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

gradient-with-scaled-ancestor.html is not calling setDeviceScaleFactor
​https://bugs.webkit.org/show_bug.cgi?id=95847

Patch by Alex Sakhartchouk <​alexst@chromium.org> on 2012-09-06
Reviewed by Beth Dakin.

Setting the device scale factor in the layout test and updating expectations until we can rebase

  • fast/hidpi/gradient-with-scaled-ancestor.html:
  • platform/chromium/TestExpectations:
10:16 AM Changeset in webkit [127754] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

[WK2] Annotate multi-process FIXMEs with bug numbers
​https://bugs.webkit.org/show_bug.cgi?id=95916

Reviewed by Eric Carlson.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::setProcessModel): Ensure that plug-in process is enabled. Comments in WebPluginSiteDataManager said that it's required for multi-process. (WebKit::WebContext::createNewWebProcess): Added a bug number. (WebKit::WebContext::disconnectProcess): Ditto. (WebKit::WebContext::createWebPage): Ditto. (WebKit::WebContext::download): Ditto. (WebKit::WebContext::getWebCoreStatistics): Ditto.
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData): Removed FIXMEs - some ports haven't switched to plugin process yet, but that doesn't stop others from having a multi-process model. Added an ASSERT to document this requirement (in addition to the check in WebContext).
  • UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel): (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): (WebKit::DownloadProxy::startTransfer):
  • UIProcess/WebApplicationCacheManagerProxy.cpp: (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
  • UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
  • UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): (WebKit::WebDatabaseManagerProxy::deleteAllDatabases): (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): (WebKit::WebIconDatabase::didFinishURLImport):
  • UIProcess/WebKeyValueStorageManagerProxy.cpp: (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
  • UIProcess/WebMediaCacheManagerProxy.cpp: (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin): (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Added bug numbers.
10:14 AM Changeset in webkit [127753] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 IPC always sends strings using 16 bit data format
​https://bugs.webkit.org/show_bug.cgi?id=95811

Reviewed by Benjamin Poulain.

Changed string encoding to pass an 8bit flag and then send either 8 or 16 bit
character data.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::decodeStringText): New templatized string creation and decoder method.
(CoreIPC::::decode):

10:13 AM Changeset in webkit [127752] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
​https://bugs.webkit.org/show_bug.cgi?id=95780

Patch by Nikhil Bhargava <​nbhargava@google.com> on 2012-09-06
Reviewed by Eric Seidel.

Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
and Clipboard. There is a minor compile-time performance boost.

  • Modules/mediastream/MediaStreamEvent.h:
  • dom/Event.cpp:
  • dom/Event.h:

(WebCore):

  • dom/EventDispatchMediator.cpp:
  • dom/EventListenerMap.cpp:
  • dom/MouseRelatedEvent.h:
  • dom/UIEvent.cpp:
  • html/FormAssociatedElement.h:

(WebCore):

  • inspector/TimelineRecordFactory.cpp:
  • platform/graphics/FontPlatformData.h:
  • rendering/RenderLineBoxList.h:
  • rendering/style/RenderStyle.h:

(WebCore):

  • svg/SVGAnimatedType.h:
  • svg/SVGExternalResourcesRequired.cpp:
  • svg/SVGExternalResourcesRequired.h:

(WebCore):

  • svg/SVGURIReference.h:

(WebCore):

10:11 AM Changeset in webkit [127751] by mitz@apple.com
  • 8 edits in trunk

REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
​https://bugs.webkit.org/show_bug.cgi?id=95972

Source/WebCore:

Reverted r127712, because it was based on the false premise that “[Optional] works the way
XMLHttpRequest expects”.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openCallback):
(WebCore):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl:

LayoutTests:

Removed the failing test from the skipped list.

  • platform/qt/Skipped:
9:57 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:56 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:53 AM Changeset in webkit [127750] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] [WK2] Crash when navigating between pages
​https://bugs.webkit.org/show_bug.cgi?id=95949

Reviewed by Martin Robinson.

Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.

  • UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didInitiateLoadForResource):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted):

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
9:49 AM Changeset in webkit [127749] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit/gtk

[GTK] Add API to get/set the security policy of a given URI scheme
​https://bugs.webkit.org/show_bug.cgi?id=95549

Reviewed by Martin Robinson.

Add WebKitSecurityPolicy enum with flags that represent the
security policy of a URI scheme. Add methods to get and set the
security policy flags for a given URI scheme.

  • docs/webkitgtk-sections.txt: Add new symbols.
  • tests/testglobals.c:

(test_globals_security_policy):
(main):

  • webkit/webkitglobals.cpp:

(webkit_set_security_policy_for_uri_scheme):
(webkit_get_security_policy_for_uri_scheme):

  • webkit/webkitglobals.h:
9:41 AM Changeset in webkit [127748] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Use native function bind in page popups
​https://bugs.webkit.org/show_bug.cgi?id=95976

Reviewed by Kent Tamura.

We should be using Function.prototype.bind instead of our own bind implementation.

No new tests. No behavior change.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._attachLeftButtonsTo):
(YearMonthController.prototype._attachRightButtonsTo):
(DaysTable.prototype.attachTo):

  • Resources/pagepopups/colorSuggestionPicker.js:

(ColorPicker):
(ColorPicker.prototype._layout):

  • Resources/pagepopups/pickerCommon.js:
9:25 AM Changeset in webkit [127747] by abecsi@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] Fix the build with gcc 4.7
​https://bugs.webkit.org/show_bug.cgi?id=95989

Reviewed by Csaba Osztrogonác.

The build fails because of a bogus warning about the auto-generated
pplval variable. Unfortunately the warning is called -Wuninitialized
in gcc 4.6 and -Wmaybe-uninitialized in gcc 4.7 thus we also need to
ignore unknown pragmas not to break the build with compilers that do
not recognize these options.

  • src/compiler/preprocessor/new/ExpressionParser.y:
9:00 AM Changeset in webkit [127746] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
​https://bugs.webkit.org/show_bug.cgi?id=95731

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-09-06
Reviewed by Yury Semikhatsky.

Now scrolling is sluggish on large datasets.
Performance degrades, because each refresh causes DFS on all recorded items.
Solution: caching/invalidation of DFS (filtering) results.

Also fixed "truncate selected record range on mode change" glitch.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
Add flag for cache invalidation.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.invalidateFilteredRecords):
Added.
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
Caching/using cached results.

8:54 AM Changeset in webkit [127745] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPopupMenuProxy
​https://bugs.webkit.org/show_bug.cgi?id=95862

Reviewed by Simon Hausmann.

Bail out early if the PageClient does not create a PopupMenuProxy for us.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):

8:42 AM Changeset in webkit [127744] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[EFL] Gardening after r127728, r127534
​https://bugs.webkit.org/show_bug.cgi?id=95975

Unreviewed gardening.

Following tests were added to TestExpectations:
http/tests/xmlhttprequest/basic-auth.html fails after r127728.
fast/innerHTML/innerHTML-iframe.html fails after r127534.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-06

  • platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
  • platform/efl/TestExpectations:
8:40 AM Changeset in webkit [127743] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed rebaseline for Web Inspector NMI test. It was broken at r127738.

  • inspector/profiler/memory-instrumentation-cached-images-expected.txt:
  • inspector/profiler/memory-instrumentation-cached-images.html:
8:31 AM Changeset in webkit [127742] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix build on Mac OS X 10.6
​https://bugs.webkit.org/show_bug.cgi?id=95200

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Tor Arne Vestbø.

The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
10.7 and newer.

  • qmake/mkspecs/features/features.prf:
8:04 AM Changeset in webkit [127741] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed Web Inspector: test fix.

  • tests/MemoryInstrumentationTest.cpp:

(StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::reportMemoryUsage):
(WebCore):
(WebCore::TEST):

7:38 AM Changeset in webkit [127740] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unnecessary logic in ewk_frame_source_get.
​https://bugs.webkit.org/show_bug.cgi?id=95828

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Removed unnecessary logic that checks if <html> tag exists in document.
WebKit automatically fill out <html></html> tags if they are not existed.

  • ewk/ewk_frame.cpp:

(ewk_frame_source_get):

7:36 AM Changeset in webkit [127739] by commit-queue@webkit.org
  • 6 edits in trunk

[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
​https://bugs.webkit.org/show_bug.cgi?id=95973

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Tools:

Correctly map "addSelectionKey" to "Control" modifier
in WKTR's EventSender on other OSes than Mac OS X,
instead of mapping it to the "Meta" modifier.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::parseModifier):

LayoutTests:

Unskip several test cases that are passing on WebKit2
now that "addSelectionKey" is properly mapped to
"Control" modifier on other OSes than Mac OS X, in
WKTR's EventSender.

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/Skipped:
  • platform/win-wk2/Skipped:
7:25 AM Changeset in webkit [127738] by loislo@chromium.org
  • 11 edits in trunk/Source

Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
​https://bugs.webkit.org/show_bug.cgi?id=95957

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each type of memory will be counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

  • dom/MemoryInstrumentation.cpp:

(WebCore):

  • dom/MemoryInstrumentation.h:

(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

Source/WebKit/chromium:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each memory type is counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::InstrumentedUndefined::InstrumentedUndefined):
(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::InstrumentedDOM::InstrumentedDOM):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(InstrumentedDOM):
(WebCore::TEST):

7:00 AM Changeset in webkit [127737] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

CSS 3 'overflow-wrap' property implementation
​https://bugs.webkit.org/show_bug.cgi?id=94475

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-06
Reviewed by Ojan Vafai.

Source/WebCore:

Added 'overflow-wrap' property implementation according to
​http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
The specification declares that 'word-wrap' as a shorthand
for the 'overflow-wrap' property. So what was basically done
is declaring of new 'overflow-wrap' property and renaming
of the internal data structures from 'WordWrap' to 'OverflowWrap'.
Both 'overflow-wrap' and 'word-wrap' properties share the same
handlers and thus have the same behaviour.

Test: fast/text/overflow-wrap.html

  • WebCore.order: Rename exported setWordWrap to setOverflowWrap.
  • css/CSSComputedStyleDeclaration.cpp: Add CSSPropertyOverflowWrap to computedProperties.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp: Validation for the 'overflow-wrap' property.

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): CSSPropertyOverflowWrap is inherited.

  • css/CSSPropertyNames.in: Declare new 'overflow-wrap' property.
  • css/StyleBuilder.cpp: Assign property handler (same as for 'word-wrap').

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Renaming.

  • rendering/RenderTextControl.cpp: Ditto.

(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControlSingleLine.cpp: Ditto.

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

  • rendering/style/RenderStyle.cpp: Ditto.

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h: Ditto.
  • rendering/style/RenderStyleConstants.h: Ditto.
  • rendering/style/StyleRareInheritedData.cpp: Ditto.

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h: Ditto.

(StyleRareInheritedData):

LayoutTests:

Added 'overflow-wrap' property implementation according to
​http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
New ref-test is added to check the simularity
in behaviour of 'overflow-wrap' and 'word-wrap' properties.

  • fast/text/overflow-wrap-expected.html: Added.
  • fast/text/overflow-wrap.html: Added.
6:41 AM Changeset in webkit [127736] by anilsson@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Always log shader compilation failure
​https://bugs.webkit.org/show_bug.cgi?id=95948

Reviewed by George Staikos.

Also add shader source to the logs. In addition, don't bail on the
first failure, run through all shaders so we get a complete set of
logs.

No new tests: no change in functionality.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::loadShader):
(WebCore::LayerRenderer::initializeSharedGLObjects):

6:23 AM Changeset in webkit [127735] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html
​https://bugs.webkit.org/show_bug.cgi?id=95970

Unreviewed EFL gardening.

Update WK2-EFL TestExpectations to add bug number for:
fast/events/tab-focus-link-in-canvas.html

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

  • platform/efl-wk2/TestExpectations:
6:21 AM Changeset in webkit [127734] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
​https://bugs.webkit.org/show_bug.cgi?id=95710

Reviewed by Dirk Pranke.

The stdout / stderr output can be None so make sure
we won't raise an exception in this case.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

6:05 AM Changeset in webkit [127733] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
​https://bugs.webkit.org/show_bug.cgi?id=95943

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
in EFL WK2.

  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

LayoutTests:

Unskip several test cases that are passing now that EFL WK2
has a proper implementation for
WebPage::performDefaultBehaviorForKeyEvent().

  • platform/efl-wk2/TestExpectations:
5:54 AM Changeset in webkit [127732] by Patrick Gansterer
  • 8 edits in trunk/Source

Remove String::operator+=() from windows platform code
​https://bugs.webkit.org/show_bug.cgi?id=95904

Reviewed by Benjamin Poulain.

Use StringBuilder and operator+() to concatenate strings instead of operator+=().

Source/WebCore:

  • platform/win/ClipboardWin.cpp:

(WebCore::filesystemPathFromUrlOrTitle):

Source/WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::get_accKeyboardShortcut):

  • WebDownload.cpp:

(WebDownload::bundlePathForTargetPath):

  • WebView.cpp:

(imeCompositionArgumentNames):

Source/WebKit2:

  • UIProcess/win/WebView.cpp:

(WebKit::imeCompositionArgumentNames):

5:29 AM Changeset in webkit [127731] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CMake] Add notifications path to the WebKit2/CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=95843

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-09-06
Reviewed by Laszlo Gombos.

Add WebCore/Modules/Notifications to the WebKit2_INCLUDE_DIRECTORIES of WebKit2/CMakeLists.txt.
There are some build errors when ENABLE_NOTIFICATIONS feature is enabled.

  • CMakeLists.txt:
5:21 AM Changeset in webkit [127730] by mikelawther@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Rewrite zooming test to no longer output pixel numbers
​https://bugs.webkit.org/show_bug.cgi?id=95922

Reviewed by Dan Bernstein.

The original version of this test output pixel sizes, which had different results on
different ports. The test has been rewritten to suppress the pixel size output.

  • css3/calc/zoom-with-em-expected.txt:
  • css3/calc/zoom-with-em.html:
  • platform/chromium/css3/calc/zoom-with-em-expected.txt: Removed.
5:06 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
4:44 AM Changeset in webkit [127729] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Tools

[EFL] Sanitize URLs in EWebLauncher / Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=95849

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Sanitize URLs passed by the user as program
argument or typed in the URL bar in order to
be more tolerant.

  • EWebLauncher/CMakeLists.txt:
  • EWebLauncher/main.c:

(main):

  • EWebLauncher/url_bar.c:

(_url_bar_url_get_with_protocol):
(on_urlbar_key_down):

  • EWebLauncher/url_utils.c: Added.

(has_scheme):
(url_from_user_input): Add utility function to construct a
URL from user input.

  • EWebLauncher/url_utils.h: Added.
  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(main):

4:22 AM Changeset in webkit [127728] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip one more failing test,
because we like regressions in the trunk. :)

  • platform/qt/Skipped:
4:05 AM Changeset in webkit [127727] by keishi@webkit.org
  • 6 edits in trunk

Refactor CalendarPicker to not use global variables.
​https://bugs.webkit.org/show_bug.cgi?id=95830

Reviewed by Kent Tamura.

Source/WebCore:

Introduce CalendarPicker so we can have multiple Pickers in one page
popup in the future.

No new tests. No behavior change.

  • Resources/pagepopups/calendarPicker.js:

(initialize):
(resetMain):
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday):
(CalendarPicker.prototype.handleClear):
(CalendarPicker.prototype.fixWindowSize):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._redraw):
(YearMonthController.prototype._handleYearMonthChange):
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(DaysTable.prototype.attachTo):
(CalendarPicker.prototype.stepMismatch):
(CalendarPicker.prototype.outOfRange):
(CalendarPicker.prototype.isValidDate):
(DaysTable.prototype._renderMonth):
(DaysTable.prototype._navigateToMonth):
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleDayClick):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):

  • Resources/pagepopups/colorSuggestionPicker.js:

(ColorPicker):
(ColorPicker.prototype._layout):
(ColorPicker.prototype._handleKeyDown):
(ColorPicker.prototype._handleSwatchClick):

  • Resources/pagepopups/pickerCommon.js:

(Picker):
(Picker.prototype.submitValue):
(Picker.prototype.handleCancel):
(Picker.prototype.chooseOtherColor):

LayoutTests:

  • fast/forms/date/calendar-picker-appearance-pre-100.html:
4:02 AM Changeset in webkit [127726] by Simon Hausmann
  • 9 edits in trunk

[Qt] Various small Windows / MSVC build fixes
​https://bugs.webkit.org/show_bug.cgi?id=95934

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • Shared/LayerTreeContext.h: Include stdint.h due to the use of uint32_t as layer id.
  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit): Fix struct vs. class forward declaration mismatch, causing linking errors.

  • UIProcess/API/qt/tests/bytearraytestdata.h: Remove export macro from internal test class

that is not used anymore. Using the export macro from a DLL when the code in question is not
part of the DLL results in the export macro expanding to dllimport, giving incorrect linkage
for the unit test.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt): Removed explicit call to srandom(), which is not available on Windows.
The call appears to be unnecessary in the light of the WTF::initializeThreading() call below, which
in turn calls WTF::initializeRandomNumberGenerator(), which does the same thing already (and isn't
needed on Windows, as per comment in wtf/RandomNumberSeed.h)

Source/WTF:

For the Qt build on Windows, do not enable WTF_USE_UNIX_DOMAIN_SOCKETS for
WebKit2 IPC.

  • wtf/Platform.h:

Tools:

setFocus takes a boolean as argument: Don't try to implicitly convert
an enum to a boolean, MSVC doesn't like that. The intent here is to
enable focus, so just pass true.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::focus):

3:59 AM Changeset in webkit [127725] by Simon Hausmann
  • 1 edit in trunk/Source/WebKit2/Target.pri

Small typo I forgot to land as part of r127724

3:55 AM Changeset in webkit [127724] by Simon Hausmann
  • 14 edits
    5 adds in trunk

[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
​https://bugs.webkit.org/show_bug.cgi?id=95965

Reviewed by Tor Arne Vestbø.

.:

Add ANGLE as separate static library to the build and dependencies.

  • Source/api.pri:
  • WebKit.pro:

Source/ThirdParty/ANGLE:

Add build rules to build ANGLE as a static library for the Qt port.

  • ANGLE.pri: Added.
  • ANGLE.pro: Added.
  • DerivedSources.pri: Added.
  • Target.pri: Added.

Source/WebCore:

Moved all ANGLE build rules from here to Source/Thirty/ANGLE and
instead depend on the new library with a simple WEBKIT += ANGLE.

  • DerivedSources.pri:
  • Target.pri:
  • platform/graphics/ANGLEWebKitBridge.h: Simplify the include statement

for the internal shader compiler API, aligned with the other platforms.

Source/WebKit:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

  • WebKit1.pro:

Source/WebKit2:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

  • Target.pri:

Tools:

Add ANGLE as a static library module to the Qt WebKit build system.

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/modules/angle.prf: Added.
3:47 AM Changeset in webkit [127723] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Keep placeholder text visible until first input from user.
​https://bugs.webkit.org/show_bug.cgi?id=95851

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-06
Reviewed by Gyuyoung Kim.

Current specification, ​http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Therefore, this patch enabled it.

  • platform/efl/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):

3:47 AM Changeset in webkit [127722] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r127620, r127698 and r127704
​https://bugs.webkit.org/show_bug.cgi?id=95963

Unreviewed gardening.

Following tests were added to TestExpectations:
compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620.
fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698.
fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704.
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-06

  • platform/efl/TestExpectations:
3:40 AM Changeset in webkit [127721] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Win build fix attempt after r127715

  • tests/CCRenderPassTest.cpp:

(WebCore::TEST):

3:36 AM Changeset in webkit [127720] by abecsi@webkit.org
  • 15 edits
    1 move
    4 adds
    1 delete in trunk

[WK2] Make [Qt]ViewportHandler cross platform
​https://bugs.webkit.org/show_bug.cgi?id=91257

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

Since QtViewportHandler includes behaviour that is not platform
specific together with hooks to the QtQuick API layer, a platform
independent implementation would allow other ports to use the
viewport controlling functionality provided.

This patch removes QtViewportHandler and introduces a platform
independent PageViewportController class that is responsible
for handling requests from the web process (eg. content size
changes, viewport attributes changes and scroll position requests).
Requests from the web process are acted on by a platform specific
client class which implements the PageViewportControllerClient
interface which provides hooks to the platform specific API layer.

The PageViewportController is also responsible to notify the web
process about changes in the viewport state (eg. viewport size,
visible rect, content scale and movement trajectory).
The client is responsible to delegate these UI changes to the
PageViewportController.

For now only PageViewportControllerClientQt implements the client
interface besides providing other QQuick specific functionality
(gestures, animations, etc).

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate::pageViewportControllerClient):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::viewport):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::contentsScale):

  • UIProcess/PageViewportController.cpp: Added.

(WebKit):
(WebKit::bound):
(WebKit::fuzzyCompare):
(WebKit::boundPosition):
(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::convertFromViewport):
(WebKit::PageViewportController::convertToViewport):
(WebKit::PageViewportController::innerBoundedContentsScale):
(WebKit::PageViewportController::outerBoundedContentsScale):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::setViewportSize):
(WebKit::PageViewportController::setVisibleContentsRect):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::suspendContent):
(WebKit::PageViewportController::resumeContent):
(WebKit::PageViewportController::positionRangeForContentAtScale):

  • UIProcess/PageViewportController.h: Added.

(WebCore):
(WebKit):
(ViewportUpdateDeferrer):
(PageViewportController):
(WebKit::PageViewportController::~PageViewportController):
(WebKit::PageViewportController::hasSuspendedContent):
(WebKit::PageViewportController::hadUserInteraction):
(WebKit::PageViewportController::allowsUserScaling):
(WebKit::PageViewportController::contentsLayoutSize):
(WebKit::PageViewportController::devicePixelRatio):
(WebKit::PageViewportController::minimumContentsScale):
(WebKit::PageViewportController::maximumContentsScale):
(WebKit::PageViewportController::setHadUserInteraction):

  • UIProcess/PageViewportControllerClient.h: Added.

(WebKit):
(PageViewportControllerClient):
(WebKit::PageViewportControllerClient::PageViewportControllerClient):
(WebKit::PageViewportControllerClient::~PageViewportControllerClient):

  • UIProcess/qt/PageViewportControllerClientQt.cpp: Added.

(WebKit):
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::updateCurrentValue):
(WebKit::PageViewportControllerClientQt::~PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setContentRectVisiblePositionAtScale):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setContentsPosition):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::didResumeContent):
(WebKit::PageViewportControllerClientQt::allowsUserScaling):
(WebKit::PageViewportControllerClientQt::devicePixelRatio):
(WebKit::PageViewportControllerClientQt::minimumContentsScale):
(WebKit::PageViewportControllerClientQt::maximumContentsScale):
(WebKit::PageViewportControllerClientQt::currentContentsScale):
(WebKit::PageViewportControllerClientQt::contentsLayoutSize):
(WebKit::PageViewportControllerClientQt::scrollAnimationActive):
(WebKit::PageViewportControllerClientQt::panGestureActive):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::panGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::panGestureEnded):
(WebKit::PageViewportControllerClientQt::panGestureCancelled):
(WebKit::PageViewportControllerClientQt::scaleAnimationActive):
(WebKit::PageViewportControllerClientQt::cancelScrollAnimation):
(WebKit::PageViewportControllerClientQt::interruptScaleAnimation):
(WebKit::PageViewportControllerClientQt::pinchGestureActive):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::visibleContentsRect):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
(WebKit::PageViewportControllerClientQt::didChangeVisibleContents):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):
(WebKit::PageViewportControllerClientQt::updateViewportController):
(WebKit::PageViewportControllerClientQt::scaleContent):
(WebKit::PageViewportControllerClientQt::viewportScaleForRect):

  • UIProcess/qt/PageViewportControllerClientQt.h: Added.

(WebKit):
(PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setController):
(ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleStackItem::ScaleStackItem):
(ScaleStackItem):

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::viewportController):

  • UIProcess/qt/QtGestureRecognizer.h:

(WebKit):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit::QtPanGestureRecognizer::cancel):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
(WebKit::QtPinchGestureRecognizer::cancel):

  • UIProcess/qt/QtViewportHandler.cpp: Removed.
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::setViewportController):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::handleInputEvent):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
(WebKit::QtWebPageEventHandler::didFindZoomableArea):

  • UIProcess/qt/QtWebPageEventHandler.h:

(WebKit):
(QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::viewportController):

Tools:

Reviewed by Kenneth Rohde Christiansen.

Remove initial scale from viewport info item since it is
set to -1 after applied thus it does not hold any valuable
information.

  • MiniBrowser/qt/qml/ViewportInfoItem.qml:
3:13 AM Changeset in webkit [127719] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Renamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in
which inadvertantly allows the ASM llint to use the baseline JIT when
useRegExpJIT() is true.
​https://bugs.webkit.org/show_bug.cgi?id=95918.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-09-06
Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler):
(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):
(JSGlobalData):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:

(JSC):

3:05 AM Changeset in webkit [127718] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive
​https://bugs.webkit.org/show_bug.cgi?id=95519

Patch by Elliott Sprehn <​esprehn@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

Add new V8DependentRetained that allows keeping a v8::Object alive as long as another
v8::Object is alive. This is useful for keeping callbacks attached to wrappers without
keeping strong references to v8::Objects in the C++ side which can result in leaks
when cycles are created.

No new tests needed, this will be used to fix MutationObservers which will have tests.

  • WebCore.gypi:
  • bindings/v8/V8DependentRetained.h: Added.

(WebCore):
(V8DependentRetained):
(WebCore::V8DependentRetained::V8DependentRetained):
(WebCore::V8DependentRetained::~V8DependentRetained):
(WebCore::V8DependentRetained::get): Gets the v8::Object value.
(WebCore::V8DependentRetained::isEmpty): Checks if the value is still alive.
(WebCore::V8DependentRetained::createPropertyName):
(WebCore::V8DependentRetained::ownerWeakCallback): Clear the value when the owner is released.
(WebCore::V8DependentRetained::valueWeakCallback):
(WebCore::V8DependentRetained::release):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::hiddenReferenceName): Modified to allow creating hidden String or Symbol names.

  • bindings/v8/V8HiddenPropertyName.h:

(V8HiddenPropertyName):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::nextDependentRetainedId): Returns the next available hidden property index.
(V8PerIsolateData):

2:54 AM Changeset in webkit [127717] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:52 AM Changeset in webkit [127716] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Removing String operator += uses in Cookie Files
​https://bugs.webkit.org/show_bug.cgi?id=95884

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Replacing all usages of String operator += in the Cookie code because it is being deprecated.
String concats are now done using + or StringBuilder.

PR 203054

Tested using Browser Test Cookie suite on browsertest01.rim.net/networking/cookies.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
(WebCore::CookieDatabaseBackingStore::invokeOpen):
(WebCore::CookieDatabaseBackingStore::invokeRemoveAll):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

2:48 AM Changeset in webkit [127715] by danakj@chromium.org
  • 5 edits
    1 add in trunk/Source

[chromium] Add a copy() method to CCRenderPass
​https://bugs.webkit.org/show_bug.cgi?id=95485

Reviewed by Adrienne Walker.

Source/WebCore:

This method allows the ubercomp layer to make a clone of its delegated
RenderPasses to insert into the current frame.

Tests: CCRenderPassTest.copyShouldBeIdenticalExceptIdAndQuads

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCRenderPassTest.cpp: Added.

(CCTestRenderPass):
(CCTestRenderPass::quadList):
(CCTestRenderPass::sharedQuadStateList):
(CCRenderPassSize):
(TEST):

2:46 AM Changeset in webkit [127714] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Chromium Mac build fix after revision r127711
​https://bugs.webkit.org/show_bug.cgi?id=95958

Unreviewed build fix.

This is a clear typo in the source file, so changing the function to
call locationModifiersFromWindowsKeyCode instead.

  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

2:42 AM Changeset in webkit [127713] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] WebMemorySampler.cpp is included twice.
​https://bugs.webkit.org/show_bug.cgi?id=95910

Reviewed by Kentaro Hara.

Now WebMemorySampler.cpp is in CMakeLists.txt and PlatformEfl.cmake.

  • PlatformEfl.cmake: Removed WebMemorySampler.cpp from source lists.
2:38 AM Changeset in webkit [127712] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

XMLHttpRequest.open does not need custom bindings
​https://bugs.webkit.org/show_bug.cgi?id=95903

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

There doesn't appear to be any reason that XMLHttpRequest.open needs
custom bindings now that [Optional] works the way XMLHttpRequest
expects.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore):
(WebCore::XMLHttpRequest::internalOpen):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl:
2:19 AM Changeset in webkit [127711] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
​https://bugs.webkit.org/show_bug.cgi?id=94142

Patch by Raymes Khoury <​raymes@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Previously we distinguished between left/right Shift/Ctrl/Alt in
WebInputEvents by using the location-specific virtual keycodes (e.g.
VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
always returns the non-locational version (e.g. VK_SHIFT).
Furthermore, KeyboardEvent also returns
non-locational keycodes and separates the location information which
matches the behavior described in the DOM3
spec ​http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
should be consistent with this in our representation of key events.
This patch changes WebInputEvents so they always store the
non-locational keycode and location information is stored in
modifiers. Since this only changes internal representation, no new
tests are added.

This patch also ensures that when KeyboardEvents are converted back to
WebInputEvents location information is preserved (which was not
happening before). This is important so that key location information
is passed on to plugins. A unittest is added for this.

  • WebKit.gypi:
  • public/WebInputEvent.h:

(WebKeyboardEvent):

  • src/WebInputEvent.cpp:

(WebKit):
(WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
(WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):

  • src/android/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):

  • src/gtk/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):

  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

  • src/win/WebInputEventFactory.cpp:

(WebKit::getLocationModifier):
(WebKit::WebInputEventFactory::keyboardEvent):

  • tests/WebInputEventConversionTest.cpp: Added.
2:17 AM Changeset in webkit [127710] by commit-queue@webkit.org
  • 10 edits in trunk

Three XSLTProcessor functions don't need to be [Custom]
​https://bugs.webkit.org/show_bug.cgi?id=95899

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Source/WebCore:

These functions are marked [Custom] because they predate our
improvements to [Optional]. Now that we have
[Optional=DefaultIsUndefined], we can autogenerate these functions.

There is a (slight!) difference in behavior. Now, in the case of a type
error, we return null instead of undefined. This change is unlikely to
cause compatibility problems because the vast majority of folks will
pass the correct arguments, and, in the few cases where folks pass the
wrong argument types, null and undefined will likely work similarly
(e.g., they're both falsy and throw when you try to access properties).

  • bindings/js/JSXSLTProcessorCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::transformToDocument):
(WebCore::XSLTProcessor::transformToFragment):

  • xml/XSLTProcessor.h:

(WebCore::XSLTProcessor::importStylesheet):

  • xml/XSLTProcessor.idl:

LayoutTests:

Update results to show that we return null rather than undefined on a
type error.

  • fast/xsl/transform-xhr-doc-expected.txt:
  • fast/xsl/xslt-processor-expected.txt:
  • platform/chromium/fast/xsl/transform-xhr-doc-expected.txt:
2:02 AM Changeset in webkit [127709] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the failing tests.

  • platform/qt/Skipped:
1:56 AM Changeset in webkit [127708] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Remove String::operator+=() from plugin code
​https://bugs.webkit.org/show_bug.cgi?id=95896

Reviewed by Adam Barth.

Use operator+() to concatenate strings instead of operator+=().

  • plugins/PluginView.cpp:

(WebCore::parseRFC822HeaderFields):

1:33 AM Changeset in webkit [127707] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for Interpreter after r127698.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

12:47 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt versions on the bots (diff)
12:47 AM Changeset in webkit [127706] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

More fixes for String::operator+=() in Debug mode
​https://bugs.webkit.org/show_bug.cgi?id=95888

Patch by Patrick Gansterer <Patrick Gansterer> on 2012-09-06
Reviewed by Adam Barth.

Use StringBuilder to concatenate strings instead of operator+=().

  • dom/Element.cpp:

(WebCore::Element::formatForDebugger):

  • dom/Node.cpp:

(WebCore::appendAttributeDesc):
(WebCore::Node::showNode):
(WebCore::traverseTreeAndMark):
(WebCore::Node::formatForDebugger):

  • dom/Position.cpp:

(WebCore::Position::formatForDebugger):

  • dom/Range.cpp:

(WebCore):
(WebCore::Range::formatForDebugger):

  • dom/Text.cpp:

(WebCore::Text::formatForDebugger):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::formatForDebugger):

12:40 AM Changeset in webkit [127705] by vsevik@chromium.org
  • 15 edits in trunk

Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation.
​https://bugs.webkit.org/show_bug.cgi?id=95752

Reviewed by Alexander Pavlov.

Source/WebCore:

NetworkUISourceCodeProvider does not receive ResourceAdded event until resource is finished anymore.
StylesSourceMapping now listens for workspace event instead of being called directly by NetworkUISourceCodeProvider.
StylesSourceMapping is now created from inspector.js.
ProjectDidReset event introduced instead of setTimeout hacks in mappings.

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectDidReset):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._projectWillReset):
(WebInspector.ScriptSnippetModel.prototype._projectDidReset):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._addUISourceCode):
(WebInspector.StylesSourceMapping.prototype._reset):

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController.prototype._mainFrameNavigated):
(WebInspector.Project.prototype.reset):

  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content-expected.txt:
  • http/tests/inspector/network/network-request-revision-content.html:
  • inspector/console/console-uncaught-exception-expected.txt:
  • inspector/debugger/network-uisourcecode-provider-expected.txt:
  • inspector/debugger/network-uisourcecode-provider.html:
  • inspector/debugger/script-snippet-model.html:
  • inspector/debugger/scripts-panel.html:
12:35 AM Changeset in webkit [127704] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
​https://bugs.webkit.org/show_bug.cgi?id=91110

Reviewed by Tony Chang.

Source/WebKit/chromium:

Prior to this patch, we were ignoring the user-scalable property of
viewport meta tags. This patch enforces the user-scalable property by
claming the minimum-scale and maximum-scale values, effectively
preventing user scaling. This approach isn't perfect, as discussed in
​https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
over the status quo.

This approach is also used by EFL, GTK, and Qt.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

LayoutTests:

Test that the scale limits are clamped when user-scalable is set to no.

  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt: Added.
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: Added.
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt: Added.
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: Added.
12:28 AM Changeset in webkit [127703] by vsevik@chromium.org
  • 12 edits in trunk

Unreviewed, rolling out r127700.
​http://trac.webkit.org/changeset/127700
​https://bugs.webkit.org/show_bug.cgi?id=95941

Breaks inspector closure compilation, uses not defined
variables. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
12:28 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
12:21 AM Changeset in webkit [127702] by abarth@webkit.org
  • 3 edits in trunk/Source/WTF

Remove WTF::String::operator+=
​https://bugs.webkit.org/show_bug.cgi?id=95797

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-06
Reviewed by Sam Weinig.

This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.

  • wtf/Platform.h
  • wtf/text/WTFString.h:
12:16 AM Changeset in webkit [127701] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[V8] V8HTMLDocument has two out-of-style function names
​https://bugs.webkit.org/show_bug.cgi?id=95893

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Just a simple style cleanup.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):
(WebCore::V8HTMLDocument::getNamedProperty):

Sep 5, 2012:

11:49 PM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:48 PM Changeset in webkit [127700] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
​https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <​poenaru@adobe.com> on 2012-09-05
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
11:26 PM Changeset in webkit [127699] by danakj@chromium.org
  • 7 edits
    1 add in trunk/Source

[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
​https://bugs.webkit.org/show_bug.cgi?id=95374

Reviewed by Adrienne Walker.

Source/WebCore:

The ubercomp layer will hold a RenderPass full of DrawQuads, and needs
to add quads to the current frame in appendQuads(). It will do this by
copying the quads it has in its RenderPass into the frame's RenderPass.

These methods allows it to make a clone of its quads.

Test: CCDrawQuadTest.copySharedQuadState

CCDrawQuadTest.copyCheckerboardDrawQuad
CCDrawQuadTest.copyDebugBorderDrawQuad
CCDrawQuadTest.copyIOSurfaceDrawQuad
CCDrawQuadTest.copyRenderPassDrawQuad
CCDrawQuadTest.copySolidColorDrawQuad
CCDrawQuadTest.copyStreamVideoDrawQuad
CCDrawQuadTest.copyTextureDrawQuad
CCDrawQuadTest.copyTileDrawQuadcopy
CCDrawQuadTest.copyYUVVideoDrawQuad

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(CCDrawQuad):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCDrawQuadTest.cpp: Added.

(TEST):
(createSharedQuadState):
(compareDrawQuad):

11:17 PM Changeset in webkit [127698] by ggaren@apple.com
  • 17 edits in trunk

Named functions should not allocate scope objects for their names
​https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

In most cases, we can merge a function expression's name into its symbol
table. This reduces memory footprint per closure from three objects
(function + activation + name scope) to two (function + activation),
speeds up closure allocation, and speeds up recursive calls.

In the case of a named function expression that contains a non-strict
eval, the rules are so bat-poop crazy that I don't know how to model
them without an extra object. Since functions now default to not having
such an object, this case needs to allocate the object on function
entry.

Therefore, this patch makes the slow case a bit slower so the fast case
can be faster and more memory-efficient. (Note that the slow case already
allocates an activation on entry, and until recently also allocated a
scope chain node on entry, so adding one allocation on entry shouldn't
break the bank.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Caught a missed initializer. No behavior change.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Put the callee in static scope
during compilation so it doesn't need to be in dynamic scope at runtime.

(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::addCallee): Helper functions for either statically
resolving the callee or adding a dynamic scope that will resolve to it,
depending on whether you're in the fast path.

We move the callee into a var location if it's captured because activations
prefer to have contiguous ranges of captured variables.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::registerFor):
(BytecodeGenerator):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL): This is the point of the patch: remove
one allocation in the case of a named function expression.

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:

(JSC::Scope::declareCallee):
(Scope):
(Parser):
(JSC::parse):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode): Pipe the callee's name through
the parser so we get accurate information on whether the callee was captured.

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/Executable.h:

(JSC::FunctionExecutable::create):
(FunctionExecutable):
(JSC::FunctionExecutable::finishCreation): I had to refactor function
creation to support the following function constructor quirk: the function
gets a name, but its name is not in lexical scope.

To simplify this, FunctionExecutable now automatically extracts all the
data it needs from the parsed node. The special "fromGlobalCode" path
used by the function constructor creates an anonymous function, and then
quirkily sets the value used by the .name property to be non-null, even
though the parsed name is null.

  • runtime/JSNameScope.h:

(JSC::JSNameScope::create):
(JSC::JSNameScope::JSNameScope): Added support for explicitly specifying
your container scope. The compiler uses this for named function expressions.

LayoutTests:

Added coverage for some extra-tricky cases.

  • fast/js/named-function-expression-expected.txt:
  • fast/js/script-tests/named-function-expression.js:

(shouldBeTrueWithDescription): I rolled my own shouldBeTrue() here to avoid the
built-in shouldBe()'s eval scoping, which can change the variable
resolution rules I'm trying to test.

  • inspector/debugger/debugger-expand-scope-expected.txt: Not sure why this

result used to miss the function name scope, but the new result is a
progression, so I've updated the expected results.

11:06 PM Changeset in webkit [127697] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new fasiling tests.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
10:57 PM Changeset in webkit [127696] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally
slipped into ​http://trac.webkit.org/changeset/127474.

This change will be properly landed shortly as part of
​https://bugs.webkit.org/show_bug.cgi?id=93898.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):

10:51 PM Changeset in webkit [127695] by Nate Chapin
  • 11 edits in trunk/Source/WebCore

Remove duplicate error() impls in CachedResource subclasses
​https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Antti Koivisto.

No new tests, refactor only.

  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.h: Make checkNotify()

virtual, so the right checkNotify() gets called in error().

  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
  • loader/cache/CachedXSLStyleSheet.h:
10:41 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Move section on migrating to unprefixed line-break. (diff)
10:41 PM LineBreaking edited by glenn@skynav.com
Move section on migrating to unprefixed line-break. (diff)
10:37 PM Changeset in webkit [127694] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] platform/qt/plugins/qt-qwidget-plugin.html fails
​https://bugs.webkit.org/show_bug.cgi?id=92141

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-09-05
Reviewed by Simon Hausmann.

Only Qt WK2 does not support Qt plugins. Moving skip to proper place.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:

Updated test to point to a existing image.

  • platform/qt/plugins/qt-qwidget-plugin.html:
10:28 PM Changeset in webkit [127693] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed chromium windows build fix.

Some of the rules in webcore_remaining only apply to files under WebCore/platform/. Since r127687 moved all such
files from the webcore_files variable to webcore_platform_files, these rules have to be applied to
webcore_platform instead. This also means that these files link into webcore_platform instead of
webcore_remaining, which makes a lot more sense, and we can delete several redundant rules.

  • WebCore.gyp/WebCore.gyp:
10:10 PM Changeset in webkit [127692] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F): Disabled applyScrollToScrollableArea()

10:06 PM Changeset in webkit [127691] by tony@chromium.org
  • 4 edits in trunk

[chromium] Remove dependency on webkit_user_agent
​https://bugs.webkit.org/show_bug.cgi?id=95886

Reviewed by Adam Barth.

Source/WebKit/chromium:

The code isn't used by webkit_unit_tests.

  • WebKitUnitTests.gyp:

Tools:

The code isn't used by DumpRenderTree.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9:48 PM Changeset in webkit [127690] by Nate Chapin
  • 4 edits in trunk/Source

Source/WebCore: [chromium] Some SubstituteData loads broken after r121912
​https://bugs.webkit.org/show_bug.cgi?id=91685

Reviewed by Adam Barth.

Test: WebFrameTest.ReplaceNavigationAfterHistoryNavigation in chromium's webkit_unit_tests.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): receivedFirstData() should be called exactly once per load,

on the first commit. I had mistakely assumed in r121912 that isReplacing() was true only for multipart
loads, and only after the first commit (chromium uses it for some SubstituteData loads to ensure the error page
replaces the failed load). We need to check whether we are loading multipart content before assuming isReplacing()
will tell us what we need to know.

Source/WebKit/chromium: Test for ​https://bugs.webkit.org/show_bug.cgi?id=91685

Reviewed by Adam Barth.

  • tests/WebFrameTest.cpp:
9:46 PM Changeset in webkit [127689] by commit-queue@webkit.org
  • 7 edits in trunk

Source/WebKit/chromium: Use new type-specific WebGestureEvent fields
​https://bugs.webkit.org/show_bug.cgi?id=95573

Patch by Rick Byers <​rbyers@chromium.org> on 2012-09-05
Reviewed by James Robinson.

Chromium has been updated to store gesture-type specific details in the
new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and
crrev.com/154959), so we can now rely on them.

  • src/WebCompositorInputHandlerImpl.cpp:

Update the compositor scroll, pinch and fling handling to use these new fields.
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

  • src/WebInputEventConversion.cpp:

Update PlatformGestureEvent/WebGestureEvent conversion to use the new
fields, storing into the existing overloaded PlatformGestureEvent
fields (which will be cleaned up in my next CL).
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
Update fling scrolling implementation for correct location of velocity.

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::TEST_F):
Update tests to use the new fields.

Tools: Update chromium DumpRenderTree for new WebGestureEvent fields
​https://bugs.webkit.org/show_bug.cgi?id=95573

Patch by Rick Byers <​rbyers@chromium.org> on 2012-09-05
Reviewed by James Robinson.

Update EventSender to write gesture details into the appropriate
type-specific WebGestureEvent fields.

  • DumpRenderTree/chromium/TestRunner/EventSender.cpp:

(EventSender::gestureEvent):
(EventSender::gestureFlingStart):

9:37 PM Changeset in webkit [127688] by dpranke@chromium.org
  • 2 edits in trunk/Tools

NRWT lies about the number of tests that it's skipping when used with --repeat-each
​https://bugs.webkit.org/show_bug.cgi?id=95789

Reviewed by Ojan Vafai.

Fix miscalculation in log message.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_found):

9:27 PM Changeset in webkit [127687] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
​https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
8:58 PM Changeset in webkit [127686] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Implement missing feature to support <select> tag
​https://bugs.webkit.org/show_bug.cgi?id=95708

Reviewed by Gyuyoung Kim.

Added missing APIs for select tag.

This patch provides all functionality of current WebPopupItem to applications.

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(_Ewk_Popup_Menu_Item):
(_Ewk_Popup_Menu_Item::_Ewk_Popup_Menu_Item):
(ewk_popup_menu_item_new):
(ewk_popup_menu_item_text_direction_get):
(ewk_popup_menu_item_text_direction_override_get):
(ewk_popup_menu_item_tooltip_get):
(ewk_popup_menu_item_accessibility_text_get):
(ewk_popup_menu_item_enabled_get):
(ewk_popup_menu_item_is_label_get):
(ewk_popup_menu_item_selected_get):

  • UIProcess/API/efl/ewk_popup_menu_item.h:
  • UIProcess/API/efl/ewk_popup_menu_item_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_popup_menu_request):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(checkBasicPopupMenuItem):
(showPopupMenu): Updated test case to cover new APIs.
(TEST_F):

8:54 PM Changeset in webkit [127685] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

IndexedDB: Large integer versions not persisted correctly
​https://bugs.webkit.org/show_bug.cgi?id=95873

Reviewed by Tony Chang.

Source/WebCore:

Correctly encode AND decode integer versions numbers as VarInts.

Test: storage/indexeddb/intversion-encoding.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::getVarInt):
(WebCore):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):

LayoutTests:

Verify large integer versions that encode differently as Ints vs. VarInts.

  • storage/indexeddb/intversion-encoding-expected.txt: Added.
  • storage/indexeddb/intversion-encoding.html: Added.
  • storage/indexeddb/resources/intversion-encoding.js: Added.

(test):
(openFirstTime.request.onupgradeneeded):
(openFirstTime.request.onsuccess):
(openFirstTime):
(openSecondTime.request.onsuccess):
(openSecondTime):

8:20 PM Changeset in webkit [127684] by commit-queue@webkit.org
  • 10 edits
    22 deletes in trunk

Unreviewed, rolling out r127596.
​http://trac.webkit.org/changeset/127596
​https://bugs.webkit.org/show_bug.cgi?id=95928

newly added tests are failing (Requested by bashi1 on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-05

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

  • fast/regions/autowidth-abspos-expected.html: Removed.
  • fast/regions/autowidth-abspos-regionchain-expected.html: Removed.
  • fast/regions/autowidth-abspos-regionchain.html: Removed.
  • fast/regions/autowidth-abspos.html: Removed.
  • fast/regions/autowidth-float-expected.html: Removed.
  • fast/regions/autowidth-float.html: Removed.
  • fast/regions/autowidth-inlineblock-expected.html: Removed.
  • fast/regions/autowidth-inlineblock.html: Removed.
  • fast/regions/autowidth-nonreplaced-abspos-expected.html: Removed.
  • fast/regions/autowidth-nonreplaced-abspos.html: Removed.
  • fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Removed.
  • fast/regions/autowidth-nonreplacedblock-normalflow.html: Removed.
  • fast/regions/autowidth-normalflow-expected.html: Removed.
  • fast/regions/autowidth-normalflow-maxwidth-expected.html: Removed.
  • fast/regions/autowidth-normalflow-maxwidth.html: Removed.
  • fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Removed.
  • fast/regions/autowidth-normalflow-minmaxwidth.html: Removed.
  • fast/regions/autowidth-normalflow-minwidth-expected.html: Removed.
  • fast/regions/autowidth-normalflow-minwidth.html: Removed.
  • fast/regions/autowidth-normalflow-vertrl-expected.html: Removed.
  • fast/regions/autowidth-normalflow-vertrl.html: Removed.
  • fast/regions/autowidth-normalflow.html: Removed.
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/render-region-renderer-expected.html:
  • fast/regions/top-overflow-out-of-second-region.html:
8:14 PM Changeset in webkit [127683] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build failure with accelerated compositing disabled
​https://bugs.webkit.org/show_bug.cgi?id=95872

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2012-09-05
Reviewed by James Robinson.

Define DrawingBuffer::markContextChanged even when accelerated
compositing is not used.

No functional change, so no new tests.

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::markContentsChanged):
(DrawingBuffer):

7:54 PM Changeset in webkit [127682] by Michelangelo De Simone
  • 16 edits
    2 adds in trunk

Parse the array() function for custom filters
​https://bugs.webkit.org/show_bug.cgi?id=94226

Reviewed by Dirk Schulze.

Source/WebCore:

The patch adds the support for the array() function parsing;
according to the specs this function - to be used within custom
filters - accepts number (float) values. This patch parses array()
arguments using comma as separator: the spec will be updated
accordingly shortly.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilterArrayFunction): New method to
parse the content of array() function.
(WebCore):
(WebCore::CSSParser::parseCustomFilter): parseCustomFilterArrayFunction is
called whenever a "array(" function is encountered.

  • css/CSSParser.h:

(WebCore):

  • css/CSSValue.cpp:

(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSArrayFunctionValue):

  • css/WebKitCSSArrayFunctionValue.cpp: Added.

(WebCore):
(WebCore::WebKitCSSArrayFunctionValue::WebKitCSSArrayFunctionValue):
(WebCore::WebKitCSSArrayFunctionValue::customCssText):
(WebCore::WebKitCSSArrayFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSArrayFunctionValue::reportDescendantMemoryUsage):

  • css/WebKitCSSArrayFunctionValue.h: Added.

(WebCore):
(WebKitCSSArrayFunctionValue):
(WebCore::WebKitCSSArrayFunctionValue::create):

LayoutTests:

New negative and positive test cases have been added for the array()
function parsing.

Also a new test case has been added to further test multiple 3d-transforms.

  • css3/filters/custom/custom-filter-property-parsing-expected.txt:
  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
7:24 PM Changeset in webkit [127681] by commit-queue@webkit.org
  • 13 edits
    2 copies
    2 adds in trunk

Vertically center non-anchored <dialog> elements
​https://bugs.webkit.org/show_bug.cgi?id=90670

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-09-05
Reviewed by Ojan Vafai.

Source/WebCore:

This adjusts the static default position of non-anchored
dialog elements so they are vertically centered in or at the top of
the viewport, as per the spec.

The approach is to add a RenderDialog class whose layout()
function adjusts the position after normal RenderBlock::layout runs.

Test: fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::createRenderer):
(WebCore):

  • html/HTMLDialogElement.h:

(HTMLDialogElement):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapAbsoluteToLocalPoint): Remove assertion since now absoluteToLocal is called during layout.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint): Ditto.

  • rendering/RenderDialog.cpp: Added.

(WebCore):
(WebCore::RenderDialog::layout): Compute the desired top position in the absolute coordinate system, and then set top to the
corresponding local coordinate.

  • rendering/RenderDialog.h: Added.

(WebCore):
(RenderDialog):
(WebCore::RenderDialog::RenderDialog):
(WebCore::RenderDialog::~RenderDialog):
(WebCore::RenderDialog::renderName):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::isDialog):

  • rendering/RenderingAllInOne.cpp:

LayoutTests:

  • fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt: Added.
  • fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html: Added.
7:12 PM Changeset in webkit [127680] by jason.liu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove feature about:cache/disable and about:cache/enable
​https://bugs.webkit.org/show_bug.cgi?id=95820

Reviewed by Rob Buis.

Remove this feature since we need to add a button in settings.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::cachePage):

7:11 PM Changeset in webkit [127679] by bashi@chromium.org
  • 25 edits
    9 deletes in trunk

Unreviewed, rolling out r127612, r127660, and r127664.
​http://trac.webkit.org/changeset/127612
​http://trac.webkit.org/changeset/127660
​http://trac.webkit.org/changeset/127664
​https://bugs.webkit.org/show_bug.cgi?id=95920

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCVoidRequest.h: Removed.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h:

(WebCore):
(RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h:

(WebCore):
(RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:

(RTCSessionDescriptionRequestImpl):

  • Modules/mediastream/RTCVoidRequestImpl.cpp: Removed.
  • Modules/mediastream/RTCVoidRequestImpl.h: Removed.
  • WebCore.gypi:
  • platform/chromium/support/WebRTCVoidRequest.cpp: Removed.
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
(RTCPeerConnectionHandler):
(WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):

  • platform/mediastream/RTCVoidRequest.h: Removed.
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):
(SuccessCallbackTask):
(FailureCallbackTask):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Removed.
  • fast/mediastream/RTCPeerConnection-localDescription.html: Removed.
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Removed.
  • fast/mediastream/RTCPeerConnection-remoteDescription.html: Removed.
7:07 PM Changeset in webkit [127678] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
​https://bugs.webkit.org/show_bug.cgi?id=95819

Patch by James Robinson <​jamesr@chromium.org> on 2012-09-05
Reviewed by Adam Barth.

This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode
upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from
webkit.dll in the component build.

  • tests/WebLayerTest.cpp:
7:03 PM Changeset in webkit [127677] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove deprecated dialog connections.
​https://bugs.webkit.org/show_bug.cgi?id=95868

Reviewed by Rob Buis.

PR 187481.
Remove deprecated logic for unsupported
Dialog types.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):

7:02 PM Changeset in webkit [127676] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

a = data[a]++; sets the wrong key in data
​https://bugs.webkit.org/show_bug.cgi?id=91270

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Postfix inc/dec is unsafely using finalDestination, can trample base/subscript prior to the result being put.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):

  • Remove redundant parens.

(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):

  • Refactored to use tempDestination instead of finalDestination.

(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):

  • Should be using emitPreIncOrDec.

LayoutTests:

Added test cases.

  • fast/js/post-inc-assign-overwrites-expected.txt: Added.
  • fast/js/post-inc-assign-overwrites.html: Added.
  • fast/js/script-tests/post-inc-assign-overwrites.js: Added.

(postIncDotAssignToBase):
(postIncBracketAssignToBase):
(postIncBracketAssignToSubscript):

6:58 PM Changeset in webkit [127675] by vrk@chromium.org
  • 13 edits
    2 adds in trunk

Add the duration attribute to MediaSource
​https://bugs.webkit.org/show_bug.cgi?id=95149

Reviewed by Eric Carlson.

Add support for the duration attribute recently added to the MediaSource spec.
​http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-duration-changed.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::duration): Added duration method.
(WebCore):
(WebCore::MediaSource::setDuration): Added duration setter.

  • Modules/mediasource/MediaSource.h:

(MediaSource):

  • Modules/mediasource/MediaSource.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceSetDuration): Add empty definition.
(WebCore::MediaPlayer::sourceSetDuration): Forward call to m_private.
(WebCore):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceSetDuration): Add empty definition.

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer.
(WebKit):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • http/tests/media/media-source/media-source.js:

(MediaSourceTest.SegmentHelper): Add parameter to specify whether full file should be loaded.
(MediaSourceTest.SegmentHelper.prototype.appendAllMediaSegments): Added method to append all file segments.
(MediaSourceTest.roundedEquals_): Added to see if values are equivalent after rounding.
(MediaSourceTest.expectDuration): Added to check for expected duration.
(MediaSourceTest.expectBufferedRange): Added to check for the expected buffered attribute value.

  • http/tests/media/media-source/video-media-source-duration-changed-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-duration-changed.html: Added.
6:32 PM Changeset in webkit [127674] by mihaip@chromium.org
  • 7 edits in trunk/Source

[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
​https://bugs.webkit.org/show_bug.cgi?id=95865

Reviewed by Darin Fisher.

Source/WebCore:

r55549 made them be runtime-enabled (since the Chromium implementation
was not complete at the time), but they've been enabled by default
since ​http://crrev.com/41850

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • page/History.idl:

Source/WebKit/chromium:

Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
no-ops.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePushState):
(WebKit::WebRuntimeFeatures::isPushStateEnabled):

6:31 PM Changeset in webkit [127673] by bashi@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] unreviewed gardening after r127564

Added missing text expectation.

  • fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
6:16 PM Changeset in webkit [127672] by jamesr@google.com
  • 8 edits in trunk/Source

[chromium] Move static WebCompositor functions to WebCompositorSupport
​https://bugs.webkit.org/show_bug.cgi?id=95785

Reviewed by Darin Fisher.

The statics on WebCompositor need to be moved to WebCompositorSupport so the embedder can inject an
implementation for these via PlatformSupport. This adds the interface for the statics to WebCompositorSupport.
After an implementation of these lands on the chromium side, I'll switch all callers over to use these and
remove the WebCompositor interface from the API.

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::initialize):
(WebKit::WebCompositorSupport::threadingEnabled):
(WebKit::WebCompositorSupport::shutdown):
(WebKit::WebCompositorSupport::setPerTilePaintingEnabled):
(WebKit::WebCompositorSupport::setPartialSwapEnabled):
(WebKit::WebCompositorSupport::setAcceleratedAnimationEnabled):

6:16 PM Changeset in webkit [127671] by staikos@webkit.org
  • 2 edits in trunk

[BlackBerry] Match th ebuild flags from the platform library
​https://bugs.webkit.org/show_bug.cgi?id=95423

Reviewed by Antonio Gomes.

Unaligned build flags can cause crashes and other strange behavior.
These two were not defined here but were defined on the system.

  • Source/cmake/OptionsBlackBerry.cmake:
6:11 PM Changeset in webkit [127670] by staikos@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Assignment operators missing self-check
​https://bugs.webkit.org/show_bug.cgi?id=95774

Reviewed by Rob Buis.

Add a test for self-assignment.

  • Api/WebAnimation.cpp:

(BlackBerry::WebKit::WebAnimation::operator=):

  • Api/WebString.cpp:

(BlackBerry::WebKit::WebString::operator=):

6:07 PM Changeset in webkit [127669] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

IndexedDB: Integer version lost after first open/close/open cycle
​https://bugs.webkit.org/show_bug.cgi?id=95864

Reviewed by Tony Chang.

Source/WebCore:

New backing stores were being created with an old schema version, causing migration
to occur when the backing store was re-opened, which would overwrite valid integer
version metadata. New backing stores should be created with the latest schema version
since no migration is desired.

Test: storage/indexeddb/intversion-persistence.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::setUpMetadata):

LayoutTests:

Ensure integer versions are persisted across open/close/open cycles.

Note that although this is a useful and valid test in general, the specific bug that
prompted adding this test will only repro if the origin has no pre-existing backing
store, which is not guaranteed by DRT or other shells. See ​http://webkit.org/b/92166

  • storage/indexeddb/intversion-persistence-expected.txt: Added.
  • storage/indexeddb/intversion-persistence.html: Added.
  • storage/indexeddb/resources/intversion-persistence.js: Added.

(test):
(openFirstTime.request.onupgradeneeded):
(openFirstTime.request.onsuccess):
(openFirstTime):
(openSecondTime.request.onsuccess):
(openSecondTime):

6:01 PM Changeset in webkit [127668] by yosin@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Tests] We should have mouse events test for multiple fields time input UI
​https://bugs.webkit.org/show_bug.cgi?id=95829

Reviewed by Kent Tamura.

This patch adds test cases of mouse actions on multiple fields time
input UI.

The test checks:

  • Mouse click to set focus to field under mouse pointer
  • Mouse click on spin button

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Added.
6:00 PM Changeset in webkit [127667] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] unreviewed test expectation update

  • platform/chromium/TestExpectations:
5:55 PM Changeset in webkit [127666] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

Bug, assignment within subscript of prefix/postfix increment of bracket access
​https://bugs.webkit.org/show_bug.cgi?id=95913

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

javascript:alert((function(){ var a = { x:1 }; var b = { x:1 }; a[a=b,"x"]++; return a.x; })())

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitBracket):
(JSC::PrefixNode::emitBracket):

  • Should check for assigments in the subscript when loading the base.
  • parser/Nodes.h:

(JSC::BracketAccessorNode::subscriptHasAssignments):
(BracketAccessorNode):

  • Used by emitBracket methods.

LayoutTests:

Added test cases.

  • fast/js/inc-bracket-assign-subscript-expected.txt: Added.
  • fast/js/inc-bracket-assign-subscript.html: Added.
  • fast/js/script-tests/inc-bracket-assign-subscript.js: Added.

(testPreIncBracketAccessWithAssignSubscript):
(testPostIncBracketAccessWithAssignSubscript):

  • Tests a pre/post increment to a bracket access, where subscript contains assignment.
5:52 PM Changeset in webkit [127665] by Lucas Forschler
  • 1 delete in tags/Safari-536.26.14

Remove Tag.

5:19 PM Changeset in webkit [127664] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed, build fix attempt after r127660

Make clang happy.

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
Use ASSERT_UNUSED() to suppress -Wunused-private-field warning

5:18 PM Changeset in webkit [127663] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.14

New Tag.

5:12 PM Changeset in webkit [127662] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Renamed a misnamed expected result.

  • platform/mac/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Copied from LayoutTests/platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt.
  • platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Removed.
4:53 PM Changeset in webkit [127661] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for Windows.

  • rendering/RenderThemeWin.cpp: Added missing header include.
4:34 PM Changeset in webkit [127660] by bashi@chromium.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Unreviewed, build fix attempt on win

r127612 breaks chromium win build.

  • WebCore.gypi:
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
(WebCore):
(WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

4:12 PM Changeset in webkit [127659] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1229

Merge 126251
BUG=137413
Review URL: ​https://chromiumcodereview.appspot.com/10909089

4:10 PM Changeset in webkit [127658] by cevans@google.com
  • 2 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 126107
BUG=137413
Review URL: ​https://chromiumcodereview.appspot.com/10916130

4:08 PM Changeset in webkit [127657] by cevans@google.com
  • 10 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 126048
BUG=137413
Review URL: ​https://chromiumcodereview.appspot.com/10911116

4:05 PM Changeset in webkit [127656] by cevans@google.com
  • 9 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 125737
BUG=137413
Review URL: ​https://chromiumcodereview.appspot.com/10914111

4:04 PM Changeset in webkit [127655] by commit-queue@webkit.org
  • 9 edits
    1 move
    1 delete in trunk

[EFL][WK2] Provide implementation for WebProcess functions
​https://bugs.webkit.org/show_bug.cgi?id=95857

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add implementation for getVolumeFreeSizeForPath()
in FileSystem which is required by soup-related
code in WebKit2.

No new tests, no behavior change.

  • platform/FileSystem.h:

(WebCore):

  • platform/efl/FileSystemEfl.cpp:

(WebCore::getVolumeFreeSizeForPath):
(WebCore):

Source/WebKit2:

Rename WebProcessGtk to WebProcessSoup and reuse it in
EFL port since all the code is soup-related. We now
have a proper implementation for the WebProcess
platform methods.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • WebProcess/efl/WebProcessEfl.cpp: Removed.
  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Enable soup cache for the soup session similarly to GTK port.

  • WebProcess/soup/WebProcessSoup.cpp: Renamed from Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp.

(WebKit):
(WebKit::getCacheDiskFreeSize):
(WebKit::getMemorySize):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::buildAcceptLanguages):
(WebKit::setSoupSessionAcceptLanguage):
(WebKit::languageChanged):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):

LayoutTests:

Unskip several test cases that are now passing on
WK2 EFL since WebProcess platform functions have been
implemented.

  • platform/efl-wk2/TestExpectations:
4:00 PM Changeset in webkit [127654] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Merge prefix/postfix nodes
​https://bugs.webkit.org/show_bug.cgi?id=95898

Reviewed by Geoff Garen.

Simplify the AST.
This will also mean we have access to m_subscriptHasAssignments when generating a prefix/postfix op applied to a bracket access.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):

  • was PostfixResolveNode::emitBytecode

(JSC::PostfixNode::emitBracket):

  • was PostfixBracketNode::emitBytecode

(JSC::PostfixNode::emitDot):

  • was PostfixDotNode::emitBytecode

(JSC::PostfixNode::emitBytecode):

  • was PostfixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.

(JSC::PrefixNode::emitResolve):

  • was PrefixResolveNode::emitBytecode

(JSC::PrefixNode::emitBracket):

  • was PrefixBracketNode::emitBytecode

(JSC::PrefixNode::emitDot):

  • was PrefixDotNode::emitBytecode

(JSC::PrefixNode::emitBytecode):

  • was PrefixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::makePrefixNode):

  • Just makes a PrefixNode!

(JSC::ASTBuilder::makePostfixNode):

  • Just makes a PostfixNode!
  • parser/NodeConstructors.h:

(JSC::PostfixNode::PostfixNode):

  • Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.

(JSC::PrefixNode::PrefixNode):

  • Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
  • parser/Nodes.h:

(PostfixNode):

  • Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.

(PrefixNode):

  • Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
3:55 PM Changeset in webkit [127653] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r127635.
​http://trac.webkit.org/changeset/127635
​https://bugs.webkit.org/show_bug.cgi?id=95905

breaks chromium win and mac build (Requested by bashi1 on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-05

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
3:33 PM Changeset in webkit [127652] by cevans@google.com
  • 5 edits in branches/chromium/1229/Source

Merge 126609
BUG=144704
Review URL: ​https://chromiumcodereview.appspot.com/10907083

3:26 PM Changeset in webkit [127651] by jchaffraix@webkit.org
  • 1 edit
    3 deletes in branches/chromium/1229

Revert 122501 - Percentage width replaced element in zero percent/fixed width container block incorrectly rendered.
​https://bugs.webkit.org/show_bug.cgi?id=9493

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-07-12
Reviewed by Andy Estes.

Source/WebCore:

When the width of the container is zero percent/fixed value then the width of the replaced element must also be zero.

Test: fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

When the containing block's available width is zero there can be two cases.
The containing block is floated/positioned in which case the width of the replaced child element must be its instrinsic width.
On the other hand if the width of the container is specified to be either zero percent or fixed value then the width of the
replaced elment must be zero.

LayoutTests:

  • fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html: Added.
  • fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html: Added.
  • fast/css/resources/red-box.png: Added. Image resource file for the test case.

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10918085

3:02 PM Changeset in webkit [127650] by leoyang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob
​https://bugs.webkit.org/show_bug.cgi?id=95897

Reviewed by Antonio Gomes.

Bail out the loop early if one of the not-rendered rectangle is
not current regular render job.

No behavior change, just code optimization.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):

2:50 PM Changeset in webkit [127649] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make RenderStyle::colorIncludingFallback use private getters
​https://bugs.webkit.org/show_bug.cgi?id=95863

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-09-05
Reviewed by Eric Seidel.

For readibility and maintanability reasons, it is better to use getters for
visited* color variables than accessing them directly.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorIncludingFallback):

2:46 PM Changeset in webkit [127648] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove use of JSCell::classInfoOffset() from tryCacheGetByID
​https://bugs.webkit.org/show_bug.cgi?id=95860

Reviewed by Oliver Hunt.

We should just do the indirection through the Structure instead.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

2:44 PM Changeset in webkit [127647] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Throw exceptions when assigning to const in strict mode
​https://bugs.webkit.org/show_bug.cgi?id=95894

Reviewed by Oliver Hunt.

Currently, this never happens; but it will start happening once the
callee is a local const register. In this patch, there's no change in
behavior.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded): Helper function
for doing the throwing.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode): Call the helper function.

2:12 PM Changeset in webkit [127646] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
​https://bugs.webkit.org/show_bug.cgi?id=95803

  • platform/win/Skipped:
2:01 PM Changeset in webkit [127645] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added expected results for this test from r127620 for the Mac port, which does not have
OVERFLOW_SCROLLING enabled at this time.

  • platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Added.
1:58 PM Changeset in webkit [127644] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] JavaScriptVariant can crash when operator= is called with itself
​https://bugs.webkit.org/show_bug.cgi?id=95859

Patch by Benjamin C Meyer <​bmeyer@rim.com> on 2012-09-05
Reviewed by George Staikos.

  • Api/JavaScriptVariant.cpp:

(BlackBerry::WebKit::JavaScriptVariant::operator=):
When JavaScriptVariant contains a string and operator= is
called with itself the memory will be free'd in 'this' and
then a copy will be attempted from 'that' resulting in a crash.

1:50 PM Changeset in webkit [127643] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Refactored callee access in the DFG to support it in the general case
​https://bugs.webkit.org/show_bug.cgi?id=95887

Reviewed by Phil Pizlo and Gavin Barraclough.

To support named function expressions, the DFG needs to understand the
callee register being used in arbitrary expressions, and not just
create_this.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::getCallee): Remap access to the callee register
into a GetCallee node. Otherwise, we get confused and think we have a
negatively indexed argument.

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand): Inlining also
needs to remap, but to the callee in the inline frame, and not the caller's
callee.

(JSC::DFG::ByteCodeParser::parseBlock): Since we support the callee in
the general case now, there's no need to handle it in a special way for
create_this.

1:48 PM Changeset in webkit [127642] by allan.jensen@nokia.com
  • 3 edits in trunk/Tools

Ignore-metrics includes scroll offsets.
​https://bugs.webkit.org/show_bug.cgi?id=95845

Reviewed by Dirk Pranke.

Strip scroll-offsets the same way scroll-height and scroll-width is stripped.

  • Scripts/old-run-webkit-tests:

(stripMetrics):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverOutput):

1:43 PM Changeset in webkit [127641] by cevans@google.com
  • 3 edits
    4 copies in branches/chromium/1229

Merge 125162
BUG=139530
Review URL: ​https://chromiumcodereview.appspot.com/10916125

1:40 PM Changeset in webkit [127640] by cevans@google.com
  • 9 edits
    2 copies in branches/chromium/1229

Merge 125147
BUG=139530
Review URL: ​https://chromiumcodereview.appspot.com/10917095

1:31 PM Changeset in webkit [127639] by benjamin@webkit.org
  • 9 edits in trunk/Source

More fixes for String::operator+=() on Mac
​https://bugs.webkit.org/show_bug.cgi?id=95880

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-05
Reviewed by Adam Barth.

Source/WebCore:

Followup for r127574, I forgot some use of strings.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getShorthandValue): Use String builder to construct the shorthand.

Source/WebKit/mac:

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]): Use StringBuilder to concatenate the class names
efficiently.

  • WebView/WebView.mm:

(+[WebView _decodeData:]): This is a legitimate use of String::append(), there
is no other concatenation done on that string.

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): This is a legitimate use of append(),
there is no other concatenation outside that branch.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parseRFC822HeaderFields): Use string operators instead of +=.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent): Another legitimate use of append().

1:28 PM Changeset in webkit [127638] by cevans@google.com
  • 1 edit in branches/chromium/1229/Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp

Merge 126901
BUG=144899
Review URL: ​https://chromiumcodereview.appspot.com/10913094

12:52 PM Changeset in webkit [127637] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 126657
BUG=143604
Review URL: ​https://chromiumcodereview.appspot.com/10911109

12:47 PM Changeset in webkit [127636] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1229

Merge 127082
BUG=144671
Review URL: ​https://chromiumcodereview.appspot.com/10908101

12:46 PM Changeset in webkit [127635] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
​https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:41 PM Changeset in webkit [127634] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 126063
BUG=140484
Review URL: ​https://chromiumcodereview.appspot.com/10928003

12:37 PM Changeset in webkit [127633] by cevans@google.com
  • 10 edits in branches/chromium/1229/Source

Merge 125500
BUG=137852
Review URL: ​https://chromiumcodereview.appspot.com/10905105

12:35 PM Changeset in webkit [127632] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r127629.
​http://trac.webkit.org/changeset/127629
​https://bugs.webkit.org/show_bug.cgi?id=95876

Broke build

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:29 PM Changeset in webkit [127631] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125343
BUG=131815
Review URL: ​https://chromiumcodereview.appspot.com/10913091

12:27 PM Changeset in webkit [127630] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 127117
BUG=143609
Review URL: ​https://chromiumcodereview.appspot.com/10909084

12:20 PM Changeset in webkit [127629] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
​https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:17 PM Changeset in webkit [127628] by leoyang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
​https://bugs.webkit.org/show_bug.cgi?id=95870

Reviewed by George Staikos.
Reviewed internally by Jacky Jiang.

Use the new zoom to fit scale if the page was zoomed to fit initial scale
When a page is reloaded the layout size may be changed. So the contents
size on which the initial scale depends may be changed. Use the new initial
scale in this case to make sure the page will be zoomed to correct scale.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

12:15 PM Changeset in webkit [127627] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1229

Merge 125635
BUG=137052
Review URL: ​https://chromiumcodereview.appspot.com/10915102

12:14 PM Changeset in webkit [127626] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[EFL] Slider progress bar goes crazy with negative ranges
​https://bugs.webkit.org/show_bug.cgi?id=95753

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Now the calculation of what the current value represents in terms
of progress (from 0 to 1) is correctly done.

Test: fast/forms/range/input-range-progress-indicator.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):

LayoutTests:

Added ref test to check if rendering results of sliders using
negative value ranges are coherent.

  • fast/forms/range/input-range-progress-indicator-expected.html: Added.
  • fast/forms/range/input-range-progress-indicator.html: Added.
12:07 PM Changeset in webkit [127625] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove use of JSCell::classInfoOffset() from virtualForThunkGenerator
​https://bugs.webkit.org/show_bug.cgi?id=95821

Reviewed by Oliver Hunt.

We can replace the load of the ClassInfo from the object with a load from the Structure.

  • dfg/DFGThunks.cpp:

(JSC::DFG::virtualForThunkGenerator):

12:06 PM Changeset in webkit [127624] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1229

Merge 125476
BUG=135173
Review URL: ​https://chromiumcodereview.appspot.com/10919103

12:04 PM Changeset in webkit [127623] by pilgrim@chromium.org
  • 10 edits
    2 copies in trunk/Source

[Chromium] Remove getRenderStyleForStrike from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=95363

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/linux/WebFontInfo.h: Added.

(WebKit):
(WebFontInfo):

  • chromium/public/linux/WebFontRenderStyle.h: Added.

(WebKit):

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::getRenderStyleForStrike):
(WebCore):
(WebCore::FontPlatformData::querySystemForRenderStyle):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

  • public/linux/WebFontInfo.h:
  • public/linux/WebFontRenderStyle.h:
  • src/PlatformSupport.cpp:

(WebCore):

12:03 PM Changeset in webkit [127622] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1229

Merge 125448
BUG=135173
Review URL: ​https://chromiumcodereview.appspot.com/10911108

11:54 AM Changeset in webkit [127621] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge r126551 - [GTK] Purge unused favicons from IconDatabase after 30 days
​https://bugs.webkit.org/show_bug.cgi?id=82346

Reviewed by Gustavo Noronha Silva.

Favicons will be removed from the icon database after not being used
for more than 30 days. This will keep the database size under
control.

  • loader/icon/IconDatabase.cpp:

(WebCore):
(WebCore::IconDatabase::performURLImport): filter icons older than
30 days.

11:54 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:53 AM Changeset in webkit [127620] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Enable/disable composited scrolling based on overflow
​https://bugs.webkit.org/show_bug.cgi?id=95323

Patch by Sami Kyostila <​skyostil@google.com> on 2012-09-05
Reviewed by Simon Fraser.

Source/WebCore:

When an overflow:{auto,overlay} and -webkit-overflow-scrolling:touch
element gains or loses overflow, we should correspondingly enable and
disable composited scrolling depending on whether the element can be
scrolled or not.

The previous logic in RenderLayer::usesCompositedScrolling() already
checked for actual overflow, but we also need to recompute the
compositing requirements when the amount of overflow changes during
layout. Additionally, layers using composited scrolling are marked as
self-painting to ensure they are always promoted to composited layers
when needed.

Test: compositing/overflow/overflow-auto-with-touch-toggle.html

Note that the behavior for maintaining a stacking context even without
the presense of overflow is covered by platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

LayoutTests:

Added a new test for making sure composited scrolling is enabled when overflow
is introduced.

Note that this test will pass only if OVERFLOW_SCROLLING is enabled.

  • compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
  • compositing/overflow/overflow-auto-with-touch-toggle.html: Added.
  • platform/chromium/TestExpectations:
11:46 AM Changeset in webkit [127619] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10/Source

Merge r127483 - [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
​https://bugs.webkit.org/show_bug.cgi?id=95740

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.

Testing via unit test because a non-flaky layout test crasher could not
be found.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.

Source/WebKit/gtk:

Updated unit test.

  • tests/testatk.c:

(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.

11:46 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:40 AM Changeset in webkit [127618] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge r127466 - [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
​https://bugs.webkit.org/show_bug.cgi?id=95618

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.

LayoutTests:

New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.

  • platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
  • platform/gtk/accessibility/aria-listbox-crash.html: Added.
11:40 AM Changeset in webkit [127617] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: WebInspector: remove accidentally committed speed test.

  • tests/MemoryInstrumentationTest.cpp:
11:40 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:33 AM Changeset in webkit [127616] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed test fix.

Including a plugin source file into the build that was added in r127595.

  • GNUmakefile.am:
11:26 AM Changeset in webkit [127615] by commit-queue@webkit.org
  • 32 edits
    2 deletes in trunk/LayoutTests

[CSS Shaders] Update custom filter tests to use the new security model
​https://bugs.webkit.org/show_bug.cgi?id=95760

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-09-05
Reviewed by Dirk Schulze.

This patch updates the custom filter tests to not sample u_texture and not write
to gl_FragColor. Now, the tests use the new security model by writing to
css_MixColor and indirectly blending with the DOM element texture.

This patch prepares us to remove direct DOM texture access via "u_texture":
​https://bugs.webkit.org/show_bug.cgi?id=93871

  • css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png:
  • css3/filters/custom/custom-filter-shader-cache-expected.png:
  • css3/filters/custom/custom-filter-shader-cache.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/effect-color-check-expected.png:
  • css3/filters/custom/effect-color-check.html:

Use the CSS mix function with the updated color-fill.fs.

  • css3/filters/custom/effect-custom-combined-missing-expected.png:
  • css3/filters/custom/effect-custom-combined-missing.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/effect-custom-expected.png:
  • css3/filters/custom/effect-custom-parameters-expected.png:
  • css3/filters/custom/effect-custom-parameters.html:

Use the mix-color.fs shader instead of color-offset-parameters.fs.

  • css3/filters/custom/effect-custom.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • css3/filters/custom/filter-repaint-custom-clipped.html:

Use the mix-color.fs shader instead of color-add.fs.

  • css3/filters/custom/filter-repaint-custom-expected.png:
  • css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • css3/filters/custom/filter-repaint-custom-rotated.html:

Use the mix-color.fs shader instead of color-add.fs. Fix a small typo in a comment.

  • css3/filters/custom/filter-repaint-custom.html:

Use the mix-color.fs shader instead of color-add.fs.

  • css3/filters/custom/invalid-custom-filter-shader.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/missing-custom-filter-shader-expected.png:
  • css3/filters/custom/missing-custom-filter-shader.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/resources/color-add.fs:

Removed. The mix-color.fs shader can perform this shader's function.

  • css3/filters/resources/color-fill.fs:

Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
to gl_FragColor.

  • css3/filters/resources/color-offset-parameters.fs:

Removed. The mix-color.fs shader can perform this shader's function.

  • css3/filters/resources/color-offset.fs:

Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
to gl_FragColor.

  • platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium/TestExpectations:
11:21 AM Changeset in webkit [127614] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Make visited link tracking work in multi-process mode
​https://bugs.webkit.org/show_bug.cgi?id=95869

Reviewed by Dan Bernstein.

  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): m_webProcessHasVisitedLinkState was making no sense in multi-process world, so it was let go. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Track new processes. (WebKit::VisitedLinkProvider::processDidClose): Clean up pointers that are going to become stale. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added comments. Fixed a bug where we would churn table size in some cases. Added debug logging in failure case. Re-implemented messaging code to work with multiple web processes.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Pass process proxy pointer to m_visitedLinkProvider, as it now needs to track processes. (WebKit::WebContext::disconnectProcess): Ditto. Also re-enabled visited link provider cleanup in multi-process mode.
11:19 AM WebInspector edited by zandobersek@gmail.com
Removing spam links. (diff)
11:16 AM Changeset in webkit [127613] by mifenton@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
​https://bugs.webkit.org/show_bug.cgi?id=95773

Reviewed by Rob Buis.

Properly initialize the passed variables even
though we haven't implemented the modifier state
to ensure the values are deterministic.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

11:01 AM Changeset in webkit [127612] by tommyw@google.com
  • 25 edits
    7 copies
    2 adds in trunk

MediaStream API: Add the local and remote description functionality to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=95839

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):

Source/WebCore:

As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.

Tests: fast/mediastream/RTCPeerConnection-localDescription.html

fast/mediastream/RTCPeerConnection-remoteDescription.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h:

(RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h:

(RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:

(RTCSessionDescriptionRequestImpl):

  • Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.

(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):

  • Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.

(WebCore):
(RTCVoidRequestImpl):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.

(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
10:58 AM Changeset in webkit [127611] by cevans@google.com
  • 6 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 125220 - Reimplement RenderQuote placement algorithm
BUG=135173
Review URL: ​https://chromiumcodereview.appspot.com/10912102

10:55 AM Changeset in webkit [127610] by cevans@google.com
  • 6 edits in branches/chromium/1229/Source/WebCore/rendering

Revert 127609 - Merge 124969
BUG=135173

TBR=​cevans@google.com
Review URL: ​https://chromiumcodereview.appspot.com/10913088

10:50 AM Changeset in webkit [127609] by cevans@google.com
  • 6 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 124969
BUG=135173
Review URL: ​https://chromiumcodereview.appspot.com/10911104

10:48 AM Changeset in webkit [127608] by krit@webkit.org
  • 11 edits
    32 adds in trunk

Use -webkit-clip-path shapes to clip HTML elements
​https://bugs.webkit.org/show_bug.cgi?id=95646

Reviewed by Dean Jackson.

Source/WebCore:

-webkit-clip-path creates a new layer for HTML elements now. The border,
background and content gets clipped by the clip path after any filter was
applied.

Tests: css3/masking/clip-path-circle-filter.html

css3/masking/clip-path-circle-overflow.html
css3/masking/clip-path-circle-overflow-hidden.html
css3/masking/clip-path-circle-relative-overflow.html
css3/masking/clip-path-circle.html
css3/masking/clip-path-ellipse.html
css3/masking/clip-path-polygon-evenodd.html
css3/masking/clip-path-polygon-nonzero.html
css3/masking/clip-path-polygon.html
css3/masking/clip-path-rectangle.html

  • rendering/RenderBox.h: Create new layer on clip-path.
  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer): Create new layer on clip-path.

  • rendering/RenderInline.h:

(WebCore::RenderInline::requiresLayer): Create new layer on clip-path.

  • rendering/RenderLayer.cpp: Apply clip-path on context of object.

(WebCore::RenderLayer::paintLayerContents): Create new layer on clip-path.

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasClipPath): Indicates that renderer needs to be clipped by clip-path.

  • rendering/RenderTableRow.h: Create new layer on clip-path.

LayoutTests:

Added new tests for the -webkit-clip-path property applied to HTML content.

  • css3/masking/clip-path-circle-filter.html: Added.
  • css3/masking/clip-path-circle-overflow.html: Added.
  • css3/masking/clip-path-circle-relative-overflow.html: Added.
  • css3/masking/clip-path-circle-overflow-hidden.html: Added.
  • css3/masking/clip-path-circle.html: Added.
  • css3/masking/clip-path-ellipse.html: Added.
  • css3/masking/clip-path-polygon-evenodd.html: Added.
  • css3/masking/clip-path-polygon-nonzero.html: Added.
  • css3/masking/clip-path-polygon.html: Added.
  • css3/masking/clip-path-rectangle.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/css3/masking/clip-path-circle-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-filter-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/mac/css3/masking/clip-path-ellipse-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/mac/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/mac/css3/masking/clip-path-polygon-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/mac/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/mac/css3/masking/clip-path-rectangle-expected.txt: Added.
10:33 AM Changeset in webkit [127607] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Use explicit constructor in RenderThemeEfl.
​https://bugs.webkit.org/show_bug.cgi?id=95853

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-05
Reviewed by Kentaro Hara.

Added explicit keyword in constructor of RenderThemeEfl in order to avoid implicit type conversion.

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

10:31 AM Changeset in webkit [127606] by scheib@chromium.org
  • 7 edits
    2 adds in trunk

webkitPointerLockElement returns null when pointer lock request is pending.
​https://bugs.webkit.org/show_bug.cgi?id=91186

Reviewed by Dimitri Glazkov.

Source/WebCore:

Script should wait for a pointerlockchange event before detecting
if it has acquired lock. However, if a script attempted to poll
pointerLockElement it could be confused when lock was still pending.
This change ensures that if lock is not yet acquired then
pointerLockElement will return null.

Test: pointer-lock/pointerlockelement-null-when-pending.html

  • dom/Document.cpp:

(WebCore::Document::webkitPointerLockElement):

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::elementRemoved):
(WebCore::PointerLockController::documentDetached):
(WebCore::PointerLockController::lockPending):
(WebCore):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::clearElement):

  • page/PointerLockController.h:

(PointerLockController):

LayoutTests:

  • pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-iframe-removed-from-dom.html:

Updated to reflect new behavior of null returned when lock is pending.

  • pointer-lock/pointerlockelement-null-when-pending-expected.txt: Added.
  • pointer-lock/pointerlockelement-null-when-pending.html: Added.

New test specifically for testing null return when lock is pending.

10:25 AM Changeset in webkit [127605] by commit-queue@webkit.org
  • 16 edits
    1 add in trunk/Source

[chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
​https://bugs.webkit.org/show_bug.cgi?id=95679

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-09-05
Reviewed by James Robinson.

Source/Platform:

Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.

  • Platform.gypi:
  • chromium/public/WebLayer.h:

(WebKit):
(WebLayer):

  • chromium/public/WebLayerScrollClient.h:

Source/WebCore:

Implement scrollable sublayers in ScrollingCoordinatorChromium and introduce a
WebLayerScrollClient which is notified of scroll events on its associated
scroll layer. GraphicsLayerChromium uses it to apply scroll events targeted to
its platform layer to a ScrollableArea, i.e., the RenderLayer corresponding to
the scrollable element.

Tests: GraphicsLayerChromiumTest.applyScrollToScrollableArea

WebLayerTest.ScrollClient

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::didScroll):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(WebCore::GraphicsLayerChromium::setScrollableArea):
(WebCore::GraphicsLayerChromium::scrollableArea):
(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:

(WebKit):
(WebCore):
(WebCore::LayerChromium::setLayerScrollClient):
(LayerChromium):

Source/WebKit/chromium:

Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::setMaxScrollPosition):
(WebKit):
(WebKit::WebLayerImpl::setScrollClient):
(WebKit::WebLayerImpl::scrollBy):

  • src/WebLayerImpl.h:

(WebLayerImpl):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/GraphicsLayerChromiumTest.cpp:

(MockScrollableArea):
(WebKit):
(WebKit::TEST_F):

  • tests/WebLayerTest.cpp:
10:05 AM Changeset in webkit [127604] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Remove '+=' usage in String
​https://bugs.webkit.org/show_bug.cgi?id=95808

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-05
Reviewed by Benjamin Poulain.

Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_source_get): Removed unnecessary strlen usage.

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(descriptionSuitableForTestResult):

9:44 AM Changeset in webkit [127603] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation
​https://bugs.webkit.org/show_bug.cgi?id=95649

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-09-05
Reviewed by Yury Semikhatsky.

Generator is extended to generate callback object for each asynchronous command.

  • inspector/CodeGeneratorInspector.py:

(Writer.append_multiline):
(Writer):
(Writer.get_indent):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(InspectorBackendDispatcherImpl):
(CallbackBase):
(Generator.process_event):
(Generator):
(Generator.EventMethodStructTemplate):
(Generator.EventMethodStructTemplate.append_prolog):
(Generator.EventMethodStructTemplate.append_epilog):
(Generator.process_command):
(Generator.CallbackMethodStructTemplate):
(Generator.CallbackMethodStructTemplate.append_prolog):
(Generator.CallbackMethodStructTemplate.append_epilog):
(Generator.generate_send_method):

9:33 AM Changeset in webkit [127602] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
​https://bugs.webkit.org/show_bug.cgi?id=95842

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Provide proper implementation for TestRunner::pathToLocalResource()
in EFL WKTR, identical to the one for DumpRenderTree.

Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
/tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
are found my WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:

(WTR::TestRunner::pathToLocalResource):

LayoutTests:

Unskip fast/dom/frame-loading-via-document-write.html that
was failing due to incomplete implementation for
TestRunner::pathToLocalResource() in EFL WKTR.

  • platform/efl-wk2/TestExpectations:
9:33 AM Changeset in webkit [127601] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge r127370 - [Gtk] No accessible caret-moved events found in certain content
​https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to expected accessible objects of DivRole
and ParagraphRole being ignored, in favor of including child blocks.

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAnonymousBlockChild):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
New method to return the first child which is an anonymous block.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Include paragraphs and divs which contain a non-nested anonymous block.

LayoutTests:

Added new test to verify that paragraphs and divs which contain anonymous
blocks are included in the accessible object hierarchy and have the correct
number of children with the expected role.

  • platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
  • platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.
9:32 AM Changeset in webkit [127600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not release shared backingstore memory prematurely
​https://bugs.webkit.org/show_bug.cgi?id=95841
PR #202517

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.

The BackingStore memory is shared by all web pages. We should check if
the current backingStore is active before create/release this shared memory.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):

9:32 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:19 AM Changeset in webkit [127599] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/LayoutTests

Merge r127377 - [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
​https://bugs.webkit.org/show_bug.cgi?id=95643

Unreviewed GTK gardening, rebaselining an accessibility test.

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Corrected.
9:19 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:16 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:15 AM Changeset in webkit [127598] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/LayoutTests

Merge r127369 - Unreviewed GTK gardening, rebaselining an accessibility test.

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
8:58 AM Changeset in webkit [127597] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Unify size of popup menu for touch and non-touch.
​https://bugs.webkit.org/show_bug.cgi?id=95606

Patch by Kevin Ellis <​kevers@chromium.org> on 2012-09-05
Reviewed by Adam Barth.

Use minimum height for popup menus entries regardless of whether the
popup menu is displayed on a touch screen. Replaces use of touch
padding. Height meets minimum size requirement for a low error rate
while still looking aesthetic for non-touch.

Covered by existing tests.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):

  • platform/chromium/PopupMenuChromium.h:

(PopupMenuChromium):

8:56 AM Changeset in webkit [127596] by mihnea@adobe.com
  • 10 edits
    22 adds in trunk

[CSS Regions] Auto width is not working for Regions
​https://bugs.webkit.org/show_bug.cgi?id=74135

Reviewed by Julien Chaffraix.

Source/WebCore:

It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(​http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).
When a region has width:auto, the computation of width should be done using normal block/box sizing code, instead of replaced element code.
Contains code contributed by Alexandru Chiculita(Alexandru Chiculita).

Tests: fast/regions/autowidth-abspos-regionchain.html

fast/regions/autowidth-abspos.html
fast/regions/autowidth-float.html
fast/regions/autowidth-inlineblock.html
fast/regions/autowidth-nonreplaced-abspos.html
fast/regions/autowidth-nonreplacedblock-normalflow.html
fast/regions/autowidth-normalflow-maxwidth.html
fast/regions/autowidth-normalflow-minmaxwidth.html
fast/regions/autowidth-normalflow-minwidth.html
fast/regions/autowidth-normalflow-vertrl.html
fast/regions/autowidth-normalflow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth): For positioned auto-width regions, skip the code path for replaced elements.

  • rendering/RenderRegion.cpp:

(WebCore): Override min/maxPreferredLogicalWidth as they are used in the process of computing width for regions with auto width.
As this moment, a region is still a RenderReplaced element, so this code needs to be revisited when the region will become a RenderBlock.
Also, for min/max-width, we support only <length> values. We will extend support for other values in a following patch.
(WebCore::RenderRegion::minPreferredLogicalWidth):
(WebCore::RenderRegion::maxPreferredLogicalWidth):

  • rendering/RenderRegion.h:

(RenderRegion):
Override isInlineBlockOrInlineTable() and shouldComputeSizeAsReplaced() to ensure that computation for width auto follows the normal
block/box sizing code.

LayoutTests:

It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(​http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).

Besides adding new tests, i have modified existing tests that were having regions with width:auto as they were failing after this patch.

  • fast/regions/autowidth-abspos-expected.html: Added.
  • fast/regions/autowidth-abspos-regionchain-expected.html: Added.
  • fast/regions/autowidth-abspos-regionchain.html: Added.
  • fast/regions/autowidth-abspos.html: Added.
  • fast/regions/autowidth-float-expected.html: Added.
  • fast/regions/autowidth-float.html: Added.
  • fast/regions/autowidth-inlineblock-expected.html: Added.
  • fast/regions/autowidth-inlineblock.html: Added.
  • fast/regions/autowidth-nonreplaced-abspos-expected.html: Added.
  • fast/regions/autowidth-nonreplaced-abspos.html: Added.
  • fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Added.
  • fast/regions/autowidth-nonreplacedblock-normalflow.html: Added.
  • fast/regions/autowidth-normalflow-expected.html: Added.
  • fast/regions/autowidth-normalflow-maxwidth-expected.html: Added.
  • fast/regions/autowidth-normalflow-maxwidth.html: Added.
  • fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Added.
  • fast/regions/autowidth-normalflow-minmaxwidth.html: Added.
  • fast/regions/autowidth-normalflow-minwidth-expected.html: Added.
  • fast/regions/autowidth-normalflow-minwidth.html: Added.
  • fast/regions/autowidth-normalflow-vertrl-expected.html: Added.
  • fast/regions/autowidth-normalflow-vertrl.html: Added.
  • fast/regions/autowidth-normalflow.html: Added.
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/render-region-renderer-expected.html:
  • fast/regions/top-overflow-out-of-second-region.html:
8:39 AM Changeset in webkit [127595] by beidson@apple.com
  • 9 edits
    3 adds in trunk

Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
<rdar://problem/12142226> and ​https://bugs.webkit.org/show_bug.cgi?id=95026

Source/WebKit2:

Patch partially by Andras Becsi <​andras.becsi@nokia.com>

Reviewed by Andy Estes.

If a plug-in fails to initialize then the m_plugin pointer is cleared out.
When accessing the script object it is appropriate to unconditionally null check m_plugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scriptObject): Null check m_plugin before trying to use it.

Tools:

Reviewed by Andy Estes.

Add a plug-in that always fails to initialize:

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.

(NPPNewFails):
(NPPNewFails::NPPNewFails):
(NPPNewFails::NPP_New):

Add it to all the project files:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

LayoutTests:

Reviewed by Andy Estes.

  • plugins/npp-new-fails-expected.txt: Added.
  • plugins/npp-new-fails.html: Added.
8:38 AM Changeset in webkit [127594] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Implement number of matches and current active match index for find-on-page
​https://bugs.webkit.org/show_bug.cgi?id=95801

Patch by Andy Chen <​andchen@rim.com> on 2012-09-05
Reviewed by Antonio Gomes.

  • Calculate current match index for find-on-page
  • Notify client when number of matches and current match index update.

PR 162090 162091.
Internally reviewed by Mike Fenton and Joe Mason

  • Api/WebPageClient.h:
  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):

  • WebKitSupport/InPageSearchManager.h:

(InPageSearchManager):

8:11 AM Changeset in webkit [127593] by loislo@chromium.org
  • 115 edits in trunk/Source

Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
​https://bugs.webkit.org/show_bug.cgi?id=95850

Reviewed by Yury Semikhatsky.

I'd like to extract MemoryObjectTypes into separate classes.
After that we will be able to move core NMI instrumentation code to WTF.

Source/WebCore:

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::reportDescendantMemoryUsage):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::reportDescendantMemoryUsage):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::reportDescendantMemoryUsage):

  • css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):

  • css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::reportDescendantMemoryUsage):

  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportDescendantMemoryUsage):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reportDescendantMemoryUsage):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::reportDescendantMemoryUsage):

  • css/CSSRule.cpp:

(WebCore::CSSRule::reportBaseClassMemoryUsage):

  • css/CSSRuleList.cpp:

(WebCore::StaticCSSRuleList::reportMemoryUsage):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::reportMemoryUsage):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reportDescendantMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/CSSTimingFunctionValue.cpp:

(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):

  • css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::reportDescendantMemoryUsage):

  • css/CSSValue.cpp:

(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::reportDescendantMemoryUsage):

  • css/CSSVariableValue.h:

(WebCore::CSSVariableValue::reportDescendantMemoryUsage):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::reportDescendantMemoryUsage):

  • css/FontValue.cpp:

(WebCore::FontValue::reportDescendantMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::reportDescendantMemoryUsage):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::reportDescendantMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):

  • css/WebKitCSSMixFunctionValue.cpp:

(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):

  • dom/Attribute.h:

(WebCore::Attribute::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/Event.cpp:

(WebCore::Event::reportMemoryUsage):

  • dom/MemoryInstrumentation.cpp:

(WebCore):

  • dom/MemoryInstrumentation.h:

(WebCore):
(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::reportMemoryUsage):

  • loader/SubstituteData.cpp:

(WebCore::SubstituteData::reportMemoryUsage):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::reportMemoryUsage):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::reportMemoryUsage):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::reportMemoryUsage):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::reportMemoryUsage):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::reportMemoryUsage):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::reportMemoryUsage):

  • platform/graphics/Image.cpp:

(WebCore::Image::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsage):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::reportMemoryUsage):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::reportMemoryUsage):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::reportDescendantMemoryUsage):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::reportDescendantMemoryUsage):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::reportMemoryUsage):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::Instrumented::reportMemoryUsage):
(WebCore::InstrumentedRefPtr::reportMemoryUsage):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
(WebCore::InstrumentedOther::reportMemoryUsage):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(WebCore::TEST):
(WebCore::NonVirtualInstrumented::reportMemoryUsage):

7:52 AM Changeset in webkit [127592] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: NMI: extract overloaded instrumentation members for WebCore classes from core NMI code.
​https://bugs.webkit.org/show_bug.cgi?id=95834

Reviewed by Yury Semikhatsky.

I'd like to remove custom instrumentation methods from MemoryInstrumentation class
before upstreaming it to WTF. I've done it with help of MemoryInstrumentationTraits template helper.

Unfortunately it is not possible to use template class because mac-ews bot reports warning: redundant redeclaration of 'something' in same scope.
I've found that it is an old problem in gcc that is forced by -Wredundant-decls flag on the bot. See ​http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15867

  • dom/MemoryInstrumentation.cpp:

(WebCore::::addInstrumentedObject):
(WebCore):

  • dom/MemoryInstrumentation.h:

(WebCore):
(MemoryInstrumentationTraits):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::addObject):
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
(WebCore::MemoryInstrumentation::OwningTraits::addObject):
(WebCore::::addInstrumentedObject):
(WebCore::::addObject):
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(MemoryClassInfo):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryInstrumentation::addObjectImpl):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):
(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationImpl::totalSize):
(MemoryInstrumentationImpl):

7:37 AM WebInspector edited by janeparker991@gmail.com
(diff)
7:36 AM Changeset in webkit [127591] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r127590.
​http://trac.webkit.org/changeset/127590

Broke the Chromium bots because of a compile error in the compositor.

  • DEPS:
7:23 AM Changeset in webkit [127590] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:18 AM Changeset in webkit [127589] by Carlos Garcia Campos
  • 8 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge r127368 - [Gtk] No accessible caret-moved events found in certain content
​https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to extraneous accessible objects resulting
from unignored inline and block spans.

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(roleIsTextType): Add ListItem to the roles which should implement AtkText.

LayoutTests:

Added new test, updated the results of one test to reflect the fix,
corrected a test with a mismatched element tag.

  • platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
  • platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
  • platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
  • platform/gtk/accessibility/spans-expected.txt: Added.
  • platform/gtk/accessibility/spans.html: Added.
7:18 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
7:11 AM Changeset in webkit [127588] by Carlos Garcia Campos
  • 8 edits
    4 adds in releases/WebKitGTK/webkit-1.10

Merge r127367 - [Gtk] Incorrect/unexpected characters in the text of certain accessibles
​https://bugs.webkit.org/show_bug.cgi?id=95180

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

The bug was caused by failing to properly handle anonymous block text
which had object replacement characters (multibyte) in it. Calculating
the string length based on the UTF-8 string meant that we were returning
more characters than were there and in danger of splitting a multibyte
character.

Tests: platform/gtk/accessibility/entry-and-password.html

platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetText): Convert the text returned by textForObject()
to Unicode before calculating its length.

Source/WebKit/gtk:

Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.

  • tests/testatk.c:

(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.

Tools:

The bug that was fixed stood in the way of fully implementing stringValue().
Testing that the bug is fixed requires stringValue() to be fully implemented
and object replacement characters to be printable.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(replaceCharactersForResults): New method which turns object replacement
characters into "<obj>" so that the characters can be properly shown in
Layout Test results. Also turns "\n" into "<
n>" so that printing the
accessible text of a single object in the accessible tree doesn't mess up
the readibility of the results.
(AccessibilityUIElement::stringValue): Remove the code that immediately
returned upon encountering an object of ATK_ROLE_PANEL and call the new
replaceCharactersForResults() prior to returning the accessible string
value.

LayoutTests:

Two new layout tests, plus one updated one.

  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
  • platform/gtk/accessibility/entry-and-password-expected.txt: Added.
  • platform/gtk/accessibility/entry-and-password.html: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.
7:10 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
7:04 AM Changeset in webkit [127587] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix on OS X

Copy/paste-error resulted in us compiling InspectorPageOverlay.h

Reviewed by Ossy.

6:59 AM Changeset in webkit [127586] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-1.10

Merge r126941 - Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
​https://bugs.webkit.org/show_bug.cgi?id=95185

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-08-28
Reviewed by Chris Fleizach.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::titleUIElement): Implemented
Gets the ATK_RELATION_LABELLED_BY target.
(AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
bug 95180 is fixed.

LayoutTests:

Updated layout test expected results. In all three cases below:
1) Remove objects from the tree representation which did not belong,
but were included as a side effect of AccessibilityUIElement::stringValue()
not having been implemented.
2) Add the stringValue() return value to the tree representation.
Note that the implementation of AccessibilityUIElement::titleUIElement()
will be tested by the existing legend.html layout text. See bug 84137.

  • platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Updated.
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
  • platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Updated.
6:59 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:47 AM Changeset in webkit [127585] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge r126886 - [GTK] LLint build fails with -g -02
​https://bugs.webkit.org/show_bug.cgi?id=90098

Patch by Alban Browaeys <​prahal@yahoo.com> on 2012-08-28
Reviewed by Filip Pizlo.

Avoid duplicate offsets for llint, discarding them.

  • offlineasm/offsets.rb:
6:47 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:25 AM Changeset in webkit [127584] by dominik.rottsches@intel.com
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening.

Adding a platform specififc baseline after r127534.

  • platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
6:11 AM Changeset in webkit [127583] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix makefile race condition between derived sources and target

r121966 removed too much of the old qmake logic, including the rule
that ensured that qmake_all would not trigger dual runs of qmake --
one of the derived sources -qmake-all rule, and one for making the
derived sources.

We now follow a similar pattern as before, by introducing a custom
target that explicitly depends on the derived sources' qmake-all before
doing a manual run of make. That ensures a single qmake run for the derived
sources.

​https://bugs.webkit.org/show_bug.cgi?id=93847

Reviewed by Csaba Osztrogonác.

  • qmake/mkspecs/features/functions.prf:
6:06 AM Changeset in webkit [127582] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk

[EFL][WK2] Provide implementation for WebFrameNetworkingContext
​https://bugs.webkit.org/show_bug.cgi?id=95826

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Remove EFL-specific and empty implementation for WebFrameNetworkingContext
and use the existing soup implementation instead.

  • PlatformEfl.cmake:
  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Removed.

LayoutTests:

Unskip several cookie-related test cases for WK2 EFL
now that WebFrameNetworkingContext is implemented.

  • platform/efl-wk2/TestExpectations:
5:34 AM Changeset in webkit [127581] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r127573.
​http://trac.webkit.org/changeset/127573
​https://bugs.webkit.org/show_bug.cgi?id=95844

Breaks EFL Debug bot tests. (Requested by drott on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-05

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::createCanvas):
(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyPartDescriptions):
(WebCore::RenderThemeEfl::themeChanged):
(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

5:09 AM Changeset in webkit [127580] by morrita@google.com
  • 5 edits
    2 adds in trunk

ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
​https://bugs.webkit.org/show_bug.cgi?id=91704

Reviewed by Kentaro Hara.

Source/WebCore:

This change implement ShadowRoot::cloneNode() which throws an exception.
This also adds an overloaded version cloneNode() to ShadowRoot.idl
which is enabled only for JavaScript instead of changing the
signature of Node::cloneNode().

Note that changing the existing signature can break GObject bindings
compatibility.

Test: fast/dom/shadow/shadowroot-clonenode.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::cloneNode):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRoot.idl:

LayoutTests:

  • fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
  • fast/dom/shadow/shadowroot-clonenode.html: Added.
4:53 AM Changeset in webkit [127579] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed trivial build fix: Use DOMAllInOne.cpp only if we have xslt available.

  • Target.pri:
4:44 AM Changeset in webkit [127578] by commit-queue@webkit.org
  • 9 edits in trunk

WKTR doesn't implement dumpWillCacheResponse()
​https://bugs.webkit.org/show_bug.cgi?id=94607

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Define shouldCacheResponse() callback in resource
load client and provide implementation for
dumpWillCacheResponse() in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldCacheResponse):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpWillCacheResponse):
(WTR::TestRunner::shouldDumpWillCacheResponse):
(TestRunner):

LayoutTests:

Unskip http/tests/misc/willCacheResponse-delegate-callback.html
now that WebKitTestRunner implements dumpWillCacheResponse().

  • platform/efl-wk2/TestExpectations:
  • platform/wk2/Skipped:
4:36 AM Changeset in webkit [127577] by Kaustubh Atrawalkar
  • 49 edits in trunk

[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
​https://bugs.webkit.org/show_bug.cgi?id=92735

Reviewed by Hajime Morita.

.:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Added symbols for GTK builds for corresponding APIs.

  • Source/autotools/symbols.filter:

Source/WebCore:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

Covered by existing test cases.

  • testing/Internals.cpp:

(WebCore::Internals::numberOfPages):
(WebCore):
(WebCore::Internals::pageProperty):
(WebCore::Internals::pageSizeAndMarginsInPixels):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Kept the function defination and declaration to keep binary compatibility for IWebFramePrivate.idl

  • WebFrame.cpp:

(WebFrame::numberOfPages):

Source/WebKit2:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Add symbols for Mac Win builds for corresponding newly added APIs.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::addUserStyleSheet):

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::hasCustomPageSizeStyle):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::abortModal):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Fixed test cases to use internals API instead of testRunner.

  • printing/numberOfPages-expected.txt:
  • printing/page-count-layout-overflow.html:
  • printing/page-count-relayout-shrink.html:
  • printing/page-count-with-one-word.html:
  • printing/page-format-data-display-none.html:
  • printing/page-format-data-expected.txt:
  • printing/page-format-data.html:
  • printing/page-rule-selection-expected.txt:
  • printing/page-rule-selection.html:
  • printing/resources/paged-media-test-utils.js:

(numberOfPagesShouldBe):

  • printing/script-tests/numberOfPages.js:
  • printing/zoomed-document.html:
4:26 AM Changeset in webkit [127576] by Simon Hausmann
  • 3 edits
    1 add in trunk

[Qt] Automate the use of AllInOne files in the Qt build
​https://bugs.webkit.org/show_bug.cgi?id=95837

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Replace the manual use of SVGAllInOne.cpp with automated use through
the ALL_IN_ONE_SOURCES variable. This adds a few more all-in-one sources
to the build and leaves out some that do not compile yet due to various
platform-dependant pre-processor macro issues.

  • Target.pri:

Tools:

New feature file that implements the all-in-one file automation by
adding the requested all-in-one files to SOURCES and removing the files
it includes from SOURCES.

  • qmake/mkspecs/features/use_all_in_one_files.prf: Added.
4:24 AM Changeset in webkit [127575] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r127513

Marking plugin third-party storage tests as failing on EFL.

  • platform/efl/TestExpectations:
4:04 AM Changeset in webkit [127574] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Fix the uses of String::operator+=() for Mac
​https://bugs.webkit.org/show_bug.cgi?id=95818

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-05
Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • jsc.cpp:

(functionJSCStack): Use StringBuilder to create the stack dump, it is faster
and avoid String::operator+=().

  • parser/Parser.h:

(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
Use the String operators (and makeString) to concatenate the strings.

Source/WebCore:

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::putDelegate):
This is a legitimate use of String::append(), it is the only
concatenation in this function.

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest): Ditto.

4:02 AM Changeset in webkit [127573] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Fuzzy load the Edje theme for HTML forms
​https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Gyuyoung Kim.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::edje):
(WebCore::RenderThemeEfl::applyPartDescriptions):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

3:56 AM Changeset in webkit [127572] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Blackberry] Add document url and securityOrigin to platform request.
​https://bugs.webkit.org/show_bug.cgi?id=95822

Patch by Chris Guan <​chris.guan@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.
Internally Reviewed by Joe Mason.

It is a webworks requirement.

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

3:00 AM WebKitGTK/1.10.x edited by sergio@webkit.org
(diff)
2:19 AM Changeset in webkit [127571] by loislo@chromium.org
  • 8 edits in trunk/Source

Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
​https://bugs.webkit.org/show_bug.cgi?id=95739

Reviewed by Yury Semikhatsky.

When we go deeper into different parts of browser like skia, chromium itself etc.
we can't use a single enum for all reported object types.
The current idea is to use plain simple strings as ObjectType identifiers.
In the future patches we will extract these identifiers into separate class or namespace
and and split it between components.

Source/WebCore:

  • dom/MemoryInstrumentation.cpp:

(WebCore):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::addMemoryBlockFor):
(WebCore):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationImpl::totalSize):
(WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):
(MemoryInstrumentationImpl):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

2:07 AM WebKitGTK/1.10.x edited by plaes@plaes.org
Added bug 90098 (diff)
1:55 AM WebKitGTK edited by plaes@plaes.org
Removed spam, updated stable release link to 1.10.x (diff)
1:50 AM Changeset in webkit [127570] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.9.91

Tagging the WebKitGTK+ 1.9.91 release

1:49 AM Changeset in webkit [127569] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.9.90

Tagging the WebKitGTK+ 1.9.90 release

1:41 AM Changeset in webkit [127568] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r127525.

  • platform/graphics/wince/FontCustomPlatformData.h:

(WebCore):

1:41 AM Changeset in webkit [127567] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
​https://bugs.webkit.org/show_bug.cgi?id=95827

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-05

  • platform/qt/Skipped: skip failing test after r127534.
1:40 AM EFLWebKit edited by l.slachciak@samsung.com
Added debian command for dependent packages installation (diff)
1:29 AM Changeset in webkit [127566] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10

Unreviewed. Update NEWS and configure.ac for 1.9.90 release

1:15 AM Changeset in webkit [127565] by zandobersek@gmail.com
  • 6 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after r126911, r127163 and r127534.

Adding a platform-specific baseline for accessibility/canvas-description-and-role.html
that's required after r127084. The baseline is currently the same as Chromium's,
expecting 'AXCanvas' as the AXRole for the canvas element. The GTK port currently
reports 'image' as the AXRole - this is probably not intended so the text failure
expectation is also added for this test.

  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
  • platform/gtk/fast/block/float/024-expected.txt:
  • platform/gtk/fast/block/margin-collapse/025-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
1:05 AM Changeset in webkit [127564] by yosin@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests

[Tests] We should have interactive validation of required value for the "input" element
​https://bugs.webkit.org/show_bug.cgi?id=95817

Reviewed by Kent Tamura.

This patch adds tests for required attribute handling on form
submission of input types. The test script is parametrized for
input type and expected type. Each test file simply call one test
script in common-interactive-validation-required.js.

The test script checks:

  • Don't submit form when required value isn't presented.
  • Submit form when required value is presented.
  • fast/forms/date/date-interactive-validation-required-expected.txt: Added.
  • fast/forms/date/date-interactive-validation-required.html: Added.
  • fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
  • fast/forms/datetime/datetime-interactive-validation-required.html: Added.
  • fast/forms/datetimelocal/datetimelocal-interactive-validation-required-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-interactive-validation-required.html: Added.
  • fast/forms/month/month-interactive-validation-required-expected.txt: Added.
  • fast/forms/month/month-interactive-validation-required.html: Added.
  • fast/forms/number/number-interactive-validation-required-expected.txt: Added.
  • fast/forms/number/number-interactive-validation-required.html: Added.
  • fast/forms/resources/common-interactive-validation-required.js: Added.
  • fast/forms/time/time-interactive-validation-required-expected.txt: Added.
  • fast/forms/time/time-interactive-validation-required.html: Added.
  • fast/forms/week/week-interactive-validation-required-expected.txt: Added.
  • fast/forms/week/week-interactive-validation-required.html: Added.
1:00 AM Changeset in webkit [127563] by mikelawther@chromium.org
  • 2 edits
    1 copy
    1 add
    1 delete in trunk/LayoutTests

Moved mac results to be the generic results, and the existing result to be the chromium
platform result. The current result uses subpixel layout, which is not the norm.

Original results were added in r127557. Mac results were added in r127560.

  • css3/calc/zoom-with-em-expected.txt:
  • platform/chromium/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
  • platform/mac/css3/calc/zoom-with-em-expected.txt: Removed.
12:56 AM Changeset in webkit [127562] by yosin@chromium.org
  • 3 edits in trunk/LayoutTests

Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI
​https://bugs.webkit.org/show_bug.cgi?id=95824

Reviewed by Kent Tamura.

This patch adds test cases for Up/Down key behavior on field which has
maximum/minimum value in multiple fields time input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation for new test cases.
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Changed to add test cases for Up key behavior for "23:59:59.999" (11:59:59.999PM in UI) and Down key behavior for "01:00:00.000" (01:00:00.000 AM in UI)
12:51 AM Changeset in webkit [127561] by rgabor@webkit.org
  • 6 edits in trunk/Source

DFG JIT doesn't work properly on ARM hardfp
​https://bugs.webkit.org/show_bug.cgi?id=95684

Reviewed by Filip Pizlo.

Add hardfp support to DFG JIT. The patch is created with the
help of Zoltan Herczeg.

Source/JavaScriptCore:

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):

  • dfg/DFGFPRInfo.h:

(FPRInfo):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

Source/WTF:

  • wtf/Platform.h:
12:22 AM Changeset in webkit [127560] by mitz@apple.com
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

Added Mac-specific expected results for a test added in r127557. The generic results are
probably from a build with subpixel layout.

  • platform/mac/css3/calc: Added.
  • platform/mac/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
12:16 AM Changeset in webkit [127559] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QRawWebViewPrivate does not initialize some members
​https://bugs.webkit.org/show_bug.cgi?id=95709

Reviewed by Luiz Agostini.

Don't miss initializing the bool flags.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebViewPrivate::QRawWebViewPrivate):

Note: See TracTimeline for information about the timeline view.