Context Navigation

← Previous Period
Next Period →

Timeline

Sep 7, 2012:

11:57 PM Changeset in webkit [127963] by dmazzoni@google.com

7 edits in trunk/LayoutTests

Rebaselining accessibility test expectations

11:49 PM Changeset in webkit [127962] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove browser from the build info page
https://bugs.webkit.org/show_bug.cgi?id=96162

Patch by Ming Xie <mxie@rim.com> on 2012-09-07
Reviewed by George Staikos.
Internal reviewed by Jeff Rogers.

WebKit build should not have the build info for browser which is
built on top of webkit.

WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::buildPage):

11:21 PM Changeset in webkit [127961] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix the build of OpenGLShims on Windows
https://bugs.webkit.org/show_bug.cgi?id=96123

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

OpenGL functions on Windows are generally defined as stdcall, so we need to make sure
that we declare our own "copies" of those functions with the same calling convention.

This is also required for the situation where we build against ANGLE, because then we
initialize the function table entries with a direct assignment (entry = ::glMyFunction())
and the assignment does not compile if the types don't match, i.e. if RHS has a different
calling convention than LHS.

The approach chosen is basically the same as in the Khronos headers,
using a GLAPIENTRY macro.

platform/graphics/OpenGLShims.h:

11:16 PM Changeset in webkit [127960] by benjamin@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed prospective build fix.

tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include.

Remove the using directive from r127959.

10:53 PM Changeset in webkit [127959] by Simon Hausmann

2 edits in trunk/Source/WebKit/chromium

Unreviewed prospective build fix.

Use WTF namespace like in other files in the same directory to resolve unqualified
adoptPtr correctly.

tests/WebCompositorInputHandlerImplTest.cpp:

10:46 PM Changeset in webkit [127958] by benjamin@webkit.org

47 edits in trunk

Rename the ustring() accessor to string()
https://bugs.webkit.org/show_bug.cgi?id=95919

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-07
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Rename ustring() to string() to make the accessor name more logical after
r127191.

API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):
(JSObjectMakeFunction):
(JSObjectCopyPropertyNames):

API/JSProfilerPrivate.cpp:

(JSStartProfiling):
(JSEndProfiling):

API/JSValueRef.cpp:

(JSValueMakeString):
(JSValueMakeFromJSONString):

API/OpaqueJSString.cpp:

(OpaqueJSString::string):

API/OpaqueJSString.h:

(OpaqueJSString):

bytecode/CodeBlock.cpp:

(JSC::idName):
(JSC::CodeBlock::dump):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):

bytecompiler/NodesCodegen.cpp:

(JSC::RegExpNode::emitBytecode):
(JSC::processClauseList):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jsc.cpp:

(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createRegExp):

parser/Parser.cpp:

(JSC::::parsePrimaryExpression):

parser/Parser.h:

(JSC::Scope::declareVariable):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createRegExp):

runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):

runtime/Executable.cpp:

(JSC::FunctionExecutable::paramString):

runtime/Executable.h:

(JSC::FunctionExecutable::finishCreation):

runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

runtime/Identifier.h:

(JSC::Identifier::string):

runtime/JSFunction.cpp:

(JSC::JSFunction::calculatedDisplayName):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSONObject.cpp:

(JSC::PropertyNameForFunctionCall::value):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::finishCreation):

runtime/JSScope.cpp:

(JSC::JSScope::resolveBase):

runtime/JSString.h:

(JSC::inlineJSValueNotStringtoString):

runtime/LiteralParser.cpp:

(JSC::::parse):

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):

Source/WebCore:

bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

bindings/js/SerializedScriptValue.cpp:

Simplify a few String constructions which were still using type conversion
through StringImpl.

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::CachedString::string):
(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::CloneDeserializer::deserialize):

bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

Source/WebKit/efl:

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::sendWebIntentResponse):
(DumpRenderTreeSupportEfl::deliverWebIntent):
Aslo update the code from the UString->String conversion through StringImpl.

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

Tools:

Update EFL's DRT.

Fix some string conversion that have been made useless
with recent changes.

DumpRenderTree/efl/EventSender.cpp:

(keyPadNameFromJSValue):
(keyNameFromJSValue):

DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::queueLoad):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::elementDoesAutoCompleteForElementWithId):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::pauseAnimationAtTimeOnElementWithId):
(TestRunner::pauseTransitionAtTimeOnElementWithId):
(toInt):
(TestRunner::overridePreference):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::setTextDirection):

DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

10:02 PM Changeset in webkit [127957] by commit-queue@webkit.org

21 edits
2 adds in trunk

Unreviewed, rolling out r127955.
http://trac.webkit.org/changeset/127955
https://bugs.webkit.org/show_bug.cgi?id=96174

Hits an ASSERT (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Added.

7:05 PM Changeset in webkit [127956] by jpfau@apple.com

28 edits
2 copies
4 adds in trunk

Extend third-party storage blocking API to optionally allow blocking all storage
https://bugs.webkit.org/show_bug.cgi?id=95915

Reviewed by Brady Eidson.

Source/WebCore:

Replace boolean API with tri-state API that allows for blocking no, third-party, or all storage.

Tests: http/tests/security/same-origin-shared-worker-blocked.html

http/tests/security/same-origin-storage-blocked.html
http/tests/security/same-origin-websql-blocked.html

dom/Document.cpp:

(WebCore::Document::initSecurityContext):

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::canAccessStorage):

page/SecurityOrigin.h:

(WebCore::SecurityOrigin::setStorageBlockingPolicy):
(SecurityOrigin):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setStorageBlockingPolicy):
(WebCore::Settings::storageBlockingPolicy):
(Settings):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setStorageBlockingPolicy):

testing/InternalSettings.h:

(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit2:

Update WK2 API to use revised Settings API.

Shared/WebPreferencesStore.h:

(WebKit):

UIProcess/API/C/WKAPICast.h:

(WebKit::toStorageBlockingPolicy):
(WebKit):
(WebKit::toAPI):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetStorageBlockingPolicy):
(WKPreferencesGetStorageBlockingPolicy):

UIProcess/API/C/WKPreferences.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Modified API test to use new revised API.

TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

Update tests to use revised API.

http/tests/security/cross-origin-local-storage.html:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html:
http/tests/security/cross-origin-plugin.html:
http/tests/security/cross-origin-session-storage.html:
http/tests/security/cross-origin-shared-worker.html:
http/tests/security/cross-origin-websql.html:
http/tests/security/cross-origin-worker-websql.html:
http/tests/security/resources/document-for-cross-origin-worker-websql.html:
http/tests/security/same-origin-document-domain-storage-allowed.html:
http/tests/security/same-origin-shared-worker-blocked-expected.txt: Added.
http/tests/security/same-origin-shared-worker-blocked.html: Added.
http/tests/security/same-origin-storage-blocked-expected.txt: Added.
http/tests/security/same-origin-storage-blocked.html: Added.
http/tests/security/same-origin-websql-blocked-expected.txt: Added.
http/tests/security/same-origin-websql-blocked.html: Added.
platform/chromium/TestExpectations:

6:39 PM Changeset in webkit [127955] by abarth@webkit.org

21 edits
1 delete in trunk

[V8] DOM wrapper creation involves a bunch of sketchy code related to finding the Frame
https://bugs.webkit.org/show_bug.cgi?id=96147

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

Source/WebCore:

Previously, we used the Frame when instantiating DOM wrappers. That's
sketchy because not all DOM wrappers know how to find their Frame, and
the Frame might be displaying a different document now anyway. This
patch now gets all the information directly from the creation context.

In addition, this patch gets the proper creation context in a few more
cases, including Location.

bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCallback.cpp:

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

bindings/v8/V8PerContextData.cpp:

(WebCore):
(WebCore::V8PerContextData::current):
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

The V8 results for this test now match the JSC results. We can remove
the chromium-specific baseline.

platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Removed.

6:36 PM Changeset in webkit [127954] by jamesr@google.com

2 edits in trunk/LayoutTests

Skip some tests that appear to be making bots unstable.

platform/chromium/TestExpectations:

6:33 PM Changeset in webkit [127953] by jamesr@google.com

2 edits in trunk/Source/Platform

[chromium] Remove unused WebScrollbarThemePainter::isNull
https://bugs.webkit.org/show_bug.cgi?id=96169

Reviewed by Adrienne Walker.

This doesn't appear to be used anywhere and triggers MSVS C4800 in any chromium file that #includes this header.

chromium/public/WebScrollbarThemePainter.h:

6:32 PM Changeset in webkit [127952] by jamesr@google.com

11 edits in trunk/Source

[chromium] Remove transitional WebCompositorSupport fallback code
https://bugs.webkit.org/show_bug.cgi?id=96155

Reviewed by Adrienne Walker.

Source/WebCore:

The implementation of WebCompositorSupport has rolled out everywhere and the static ::create() functions are
going way.

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::createWebAnimation):

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimation):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::readyStateChanged):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

6:30 PM Changeset in webkit [127951] by Lucas Forschler

4 edits in trunk/Source

Versioning.

6:30 PM Changeset in webkit [127950] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix compilation of TextureMapperShaderManager.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=96121

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Named variadic parameters in macros appear to be a GCC extension. Fortunately VA_ARGS seems
to work with GCC and MSVC here.

platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::StandardFilterProgram::StandardFilterProgram):

6:28 PM Changeset in webkit [127949] by vrk@chromium.org

3 edits
2 adds in trunk

Seek to end after duration change in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=95986

Reviewed by Eric Carlson.

This seeks the media element to the end of the media resource if the current playback
position has become greater than the duration after a duration change.
http://dev.w3.org/html5/spec/media-elements.html#durationChange

Source/WebCore:

Test: http/tests/media/media-source/seek-to-end-after-duration-change.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerDurationChanged): After firing the duration change event, checks to see if current time exceeds duration and if so, seeks to duration.

LayoutTests:

http/tests/media/media-source/seek-to-end-after-duration-change-expected.txt: Added.
http/tests/media/media-source/seek-to-end-after-duration-change.html: Added.

6:22 PM Changeset in webkit [127948] by jamesr@google.com

25 edits
3 copies
1 add in trunk/Source

[chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
https://bugs.webkit.org/show_bug.cgi?id=96151

Reviewed by Adrienne Walker.

Source/Platform:

This adds public input handling interfaces for the compositor.

chromium/public/WebInputHandler.h:

(WebKit):
(WebInputHandler):
(WebKit::WebInputHandler::~WebInputHandler):

chromium/public/WebInputHandlerClient.h:

(WebKit):
(WebInputHandlerClient):
(WebKit::WebInputHandlerClient::~WebInputHandlerClient):

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

chromium/public/WebLayerTreeViewClient.h:

(WebKit):
(WebKit::WebLayerTreeViewClient::createInputHandler):
(WebLayerTreeViewClient):

Source/WebCore:

Reworks the CC hookup for input handling to be more similar to the OutputSurface handling. If on compositor
startup we want to initialize threaded input handling, we ask the embedder for a CCInputHandler implementation
via CCLayerTreeHostClient. If the client provides one, we later bind this to a CCInputHandlerClient (actually
CCLayerTreeHostImpl) from the compositor thread.

platform/graphics/chromium/cc/CCInputHandler.h:

(WebCore):
(CCInputHandler):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::createInputHandler):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHostClient.h:

(WebCore):
(CCLayerTreeHostClient):

platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals.
WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is
provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC.

WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl
and storing its identifier for the didActivateCompositor call. From this point on the setup is the same as
before.

WCIHI changes covered by unit tests, overall scrolling behavior manually tested.

WebKit.gypi:
src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::fromIdentifier):
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::setClient):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::bindToClient):

src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::identifier):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createInputHandler):
(WebKit):

src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

src/WebToCCInputHandlerAdapter.cpp: Added.

(WebKit):
(WebKit::WebToCCInputHandlerAdapter::create):
(WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter):
(WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter):
(WebToCCInputHandlerAdapter::ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::bindToClient):
(WebKit::WebToCCInputHandlerAdapter::animate):

src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h.

(WebKit):
(WebToCCInputHandlerAdapter):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
(WebKit::WebViewImpl::createInputHandler):

src/WebViewImpl.h:

(WebViewImpl):

tests/CCThreadedTest.cpp:
tests/FakeCCLayerTreeHostClient.h:
tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):
(WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient):
(WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):
(WebKit::TEST_F):

6:20 PM Changeset in webkit [127947] by Lucas Forschler

1 copy in tags/Safari-537.9

New Tag.

6:17 PM Changeset in webkit [127946] by abarth@webkit.org

88 edits in trunk/Source/WebCore

[V8] Use a v8::Object rather than a v8::Context to represent the creationContext
https://bugs.webkit.org/show_bug.cgi?id=96154

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

This patch is a mechanical search-and-replace. Using a v8::Object
rather than a v8::Context lets us delay the call to CreationContext()
until we actually need to call it. This should not affect behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::toV8):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestCallback.cpp:

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::mutablePointAttrGetter):
(WebCore::TestObjV8Internal::immutablePointAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::callFunction):

bindings/v8/IDBCustomBindings.cpp:

(WebCore::V8IDBCursorWithValue::valueAccessorGetter):

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8Binding.h:

(WebCore::V8ValueTraits::arrayV8Value):

bindings/v8/V8Collection.h:

(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

bindings/v8/V8ThrowException.cpp:

(WebCore):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):
(WebCore::V8Blob::constructorCallback):

bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):

bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::memoryAccessorGetter):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::toV8):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::toV8):
(WebCore::V8Document::createTouchListCallback):

bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore::toV8):

bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::getNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
(WebCore::toV8):

bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):
(WebCore::V8HTMLElement::itemValueAccessorGetter):

bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

bindings/v8/custom/V8HTMLOutputElementCustom.cpp:

(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):

bindings/v8/custom/V8PerformanceCustom.cpp:

(WebCore::V8Performance::memoryAccessorGetter):

bindings/v8/custom/V8PerformanceEntryCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

6:09 PM Changeset in webkit [127945] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Check objects for null when recreating context
https://bugs.webkit.org/show_bug.cgi?id=95926

Patch by John Bauman <jbauman@chromium.org> on 2012-09-07
Reviewed by Dean Jackson.

Upon navigation the FrameViwe and other objects may go null, so detect
that and return rather than try to dereference them.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

5:59 PM Changeset in webkit [127944] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

CALLFRAME_OFFSET and EXCEPTION_OFFSET are same in ctiTrampoline on ARM Thumb2
https://bugs.webkit.org/show_bug.cgi?id=82013

Reviewed by Geoff Garen.

Neither of these values need to be stored. At all.

jit/JITStubs.cpp:

(JSC):
(JSC::ctiTrampoline):
(JSC::JITThunks::JITThunks):

Nothing to see here. Move along.

5:48 PM Changeset in webkit [127943] by Simon Fraser

5 edits
2 adds in trunk

box-shadow causes overlay scrollbars to be in the wrong position when element is composited
https://bugs.webkit.org/show_bug.cgi?id=85647

Reviewed by James Robinson.

Test overlay scrollbars in composited layers.

ManualTests/scrollbars/scrollbars-in-composited-layers.html: Added.

Source/WebCore:

The code that positioned the GraphicsLayers for scrollbars failed to take
into account any offset between the origin of the compositing layer,
and the renderer. This caused scrollbar layers to be misplaced or hidden
on layers with, for example, box-shadows.

Also moved the code that positions the scrollbar layers into RendderLayerBacking,
since this is where all the rest of the GraphicsLayer-positioning code lives.

Renamed an "offsetFromLayer" param to "offsetFromRoot" which is more accurate.

Manual test, since overlay scrollbars are not enabled in DRT/WTR:

ManualTests/scrollbars/scrollbars-in-composited-layers.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::positionOverflowControls):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

5:42 PM Changeset in webkit [127942] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] [WK2] Set theme for the inspector view
https://bugs.webkit.org/show_bug.cgi?id=96108

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Set the theme for the inspector view when it is created.

UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

5:32 PM Changeset in webkit [127941] by commit-queue@webkit.org

5 edits in trunk/Source

Unreviewed, rolling out r127938.
http://trac.webkit.org/changeset/127938
https://bugs.webkit.org/show_bug.cgi?id=96166

It broke the build (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/JavaScriptCore:

llint/LowLevelInterpreter.cpp:

(JSC):
(JSC::CLoop::execute):

offlineasm/cloop.rb:

Source/WTF:

wtf/Assertions.h:

5:25 PM Changeset in webkit [127940] by commit-queue@webkit.org

5 edits in trunk/Source

[Chromium] Multiple commits without invalidation allowed per redraw.
https://bugs.webkit.org/show_bug.cgi?id=95661

Patch by David Reveman <reveman@chromium.org> on 2012-09-07
Reviewed by James Robinson.

Source/WebCore:

Always enter COMMIT_STATE_WAITING_FOR_FIRST_DRAW after commit. This
ensures we draw before beginning a new frame.

Unit tests: CCLayerTreeHostTestContinuousCommit.runMultiThread

CCLayerTreeHostTestContinuousInvalidate.runMultiThread
CCLayerTreeHostTestContinuousAnimate.runMultiThread

platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::updateState):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestContinuousCommit):
(WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit):
(WebKitTests):
(WebKitTests::TEST_F):
(CCLayerTreeHostTestContinuousInvalidate):
(WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate):
(CCLayerTreeHostTestContinuousAnimate):
(WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate):

tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

4:59 PM Changeset in webkit [127939] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

Refactored bytecode generator initialization to support moving captured vars around
https://bugs.webkit.org/show_bug.cgi?id=96159

Reviewed by Gavin Barraclough.

This patch separates the stages of allocating registers, declaring identifiers
in the symbol table, and initializing registers, so you can change
allocation decisions without breaking the world.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Call a set of helper functions
instead of inlining all the code, to help clarity.

(JSC::BytecodeGenerator::allocateCapturedVars):
(JSC::BytecodeGenerator::allocateUncapturedVars):
(JSC::BytecodeGenerator::allocateActivationVar):
(JSC::BytecodeGenerator::allocateArgumentsVars):
(JSC::BytecodeGenerator::allocateCalleeVarUndeclared):
(JSC::BytecodeGenerator::declareParameters):
(JSC::BytecodeGenerator::declareCallee):
(JSC::BytecodeGenerator::initCalleeVar):
(JSC::BytecodeGenerator::initArgumentsVars):
(JSC::BytecodeGenerator::initActivationVar):
(JSC::BytecodeGenerator::initThisParameter):
(JSC::BytecodeGenerator::initFunctionDeclarations):
(JSC::BytecodeGenerator::declareParameter):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::createActivationIfNecessary): Factored these
helper functions out from pre-existing code.

bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::addVar):

parser/Nodes.h:

(JSC::DeclarationStacks::VarDeclaration::VarDeclaration):
(VarDeclaration):
(JSC::DeclarationStacks::FunctionDeclaration::FunctionDeclaration):
(FunctionDeclaration): Declaration stacks get a little more data now,
to support allocating registers before putting things in the symbol
table. I'm convinced that we should eventually just expand the symbol
table to understand these things.

4:58 PM Changeset in webkit [127938] by commit-queue@webkit.org

5 edits in trunk/Source

Source/JavaScriptCore: Fix a llint C++ interpreter bugs.
https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-07
Reviewed by Filip Pizlo.

llint/LowLevelInterpreter.cpp:

(JSC):
(JSC::CLoop::execute):

offlineasm/cloop.rb:

Source/WTF: Fixed ASSERT() and ASSERT_AT() macros so that they can be used in
comma expressions.
https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-07
Reviewed by Filip Pizlo.

wtf/Assertions.h:

(wtfAssert):

4:54 PM Changeset in webkit [127937] by tony@chromium.org

8 edits in trunk/Source/WebCore

Add OVERRIDE to computeLogical{Width,Height} overrides
https://bugs.webkit.org/show_bug.cgi?id=96153

Reviewed by Ojan Vafai.

I plan on renaming these functions to updateLogical{Width,Height} and
I want to be extra sure that I don't mess up.

No new tests, this is just a refactoring.

rendering/RenderFlowThread.h: Also mark the functions virtual!
rendering/RenderListBox.h:

(RenderListBox):

rendering/RenderMeter.h:

(RenderMeter):

rendering/RenderTable.h:

(RenderTable):

rendering/RenderTableCell.h:

(RenderTableCell):

rendering/RenderTextControl.h:

(RenderTextControl):

rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

4:46 PM Changeset in webkit [127936] by dmazzoni@google.com

15 edits
2 adds in trunk

AX: WebCore accessibility roles should be cross-platform
https://bugs.webkit.org/show_bug.cgi?id=94870

Reviewed by Chris Fleizach.

Source/WebCore:

Make 5 accessibility roles cross-platform rather than GTK-only.

Instead of mapping the HR tag to SplitterRole (which is an interactive
splitter control on Mac), create a new role HorizontalRuleRole.

Map all of the new roles to AXGroup on Mac, which matches the existing
behavior. Add a new test for these roles on Chromium.

Test: platform/chromium/accessibility/chromium-only-roles.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAAttributes):

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap):

Source/WebKit/chromium:

Add a new accessibility role.

public/WebAccessibilityRole.h:
src/AssertMatchingEnums.cpp:

Tools:

Add debug strings to Chromium for new accessibility roles.

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(roleToString):

LayoutTests:

Adds a test for some new accessibility roles that aren't present on all platforms.

platform/chromium/accessibility/chromium-only-roles-expected.txt: Added.
platform/chromium/accessibility/chromium-only-roles.html: Added.

4:27 PM Changeset in webkit [127935] by ojan@chromium.org

11 edits
1 move
1 delete in trunk/LayoutTests

Rebaselines after http://trac.webkit.org/changeset/127915.

fast/css/percent-top-value-with-relative-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/percent-top-value-with-relative-position-expected.txt.
platform/chromium-mac-snowleopard/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium-mac/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium-win/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/fast/css/percent-top-value-with-relative-position-expected.txt: Removed.
platform/mac/TestExpectations:
platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt:
platform/qt/TestExpectations:
platform/qt/fast/css/percent-top-value-with-relative-position-expected.txt:

4:19 PM Changeset in webkit [127934] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix build of GraphicsContext3DOpenGLCommon.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=96120

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Noam Rosenthal.

Variable stack arrays are a GCC extension. Replace their use with OwnArrayPtr, similar to
other functions in the same file.

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getActiveAttrib):

4:16 PM Changeset in webkit [127933] by eae@chromium.org

17 edits
3 adds in trunk

Prevent overflows in FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=95883

Reviewed by Eric Seidel.

Source/WebCore:

Avoid overflow in snapSizeToPixel by using the fraction of the
location instead of the full value.

Add safe versions of min/max, adjusted by half a pixel to allow
round to allow rounding without overflowing.

Avoid overflow when snapping a FractionalLayoutRect by using the
safe versions of min/max in infiniteRect.

Avoid overflow when converting from a Length to a LayoutUnit by
limiting the value to FractionalLayoutUnit min/max. This matches
the behavior of the non-subpixel code path where the values are
similarly limited.

Test: fast/sub-pixel/large-sizes.html

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Limit to FractionalLayoutUnit min/max.

platform/FractionalLayoutUnit.h:

(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::nearlyMax):
(WebCore::FractionalLayoutUnit::nearlyMin):
Reduce max/increase min by 1/2 to allow round to operate
without overflowing.

(WebCore::snapSizeToPixel):

platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::infiniteRect):
Use nearlyMin/nearlyMax.

(WebCore::pixelSnappedIntRect):
Change pixelSnappedIntRect to use snapSizeToPixel.

LayoutTests:

Add test for handling of large values.

fast/sub-pixel/large-sizes-expected.txt: Added.
fast/sub-pixel/large-sizes.html: Added.
platform/chromium-win/media/video-zoom-controls-expected.txt:
platform/chromium/fast/css/large-number-round-trip-expected.txt: Added.
platform/mac-lion/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac-wk2/Skipped:
platform/mac/Skipped:
platform/qt-4.8/Skipped:
platform/qt/Skipped:
platform/win-wk2/Skipped:
platform/win-xp/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

3:58 PM Changeset in webkit [127932] by commit-queue@webkit.org

11 edits
4 deletes in trunk

Unreviewed, rolling out r127920 and r127926.
http://trac.webkit.org/changeset/127920
http://trac.webkit.org/changeset/127926
https://bugs.webkit.org/show_bug.cgi?id=96152

billions and billions of assertion failures on mac debug
builds (Requested by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

WebCore.exp.in:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::registerCustomFont):
(WebCore):
(WebCore::Document::deleteCustomFonts):
(WebCore::Document::reportMemoryUsage):

dom/Document.h:

(WebCore):
(Document):

platform/graphics/FontData.h:
platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):

platform/graphics/FontFallbackList.h:

(FontFallbackList):
(WebCore::FontFallbackList::setGlyphPageZero):
(WebCore::FontFallbackList::setGlyphPages):

platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::pruneFontData):

LayoutTests:

fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Removed.
fast/frames/seamless/seamless-custom-font-pruning-crash.html: Removed.
fast/frames/seamless/seamless-nested-crash-expected.txt: Removed.
fast/frames/seamless/seamless-nested-crash.html: Removed.

3:55 PM Changeset in webkit [127931] by dmazzoni@google.com

7 edits in trunk

AX: Chromium needs access to canvasHasFallbackContent
https://bugs.webkit.org/show_bug.cgi?id=96124

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

Expose canvasHasFallbackContent on Chromium.

public/WebAccessibilityObject.h:

(WebAccessibilityObject):

src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::canvasHasFallbackContent):
(WebKit):

Tools:

Distinguish between canvas roles with and without fallback
content on Chromium.

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(getRole):

LayoutTests:

Update canvas test to distinguish between canvas elements with
fallback content on Chromium.

platform/chromium/accessibility/canvas-description-and-role-expected.txt:

3:50 PM Changeset in webkit [127930] by barraclough@apple.com

4 edits in trunk

Object.prototype.define{G,S}etter with non-callable second parameter should throw TypeError instead of SyntaxError
https://bugs.webkit.org/show_bug.cgi?id=93873

Reviewed by Sam Weinig.

Source/JavaScriptCore:

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):

throw TypeError instead of SyntaxError

(JSC::objectProtoFuncDefineSetter):

throw TypeError instead of SyntaxError

LayoutTests:

fast/js/property-getters-and-setters-expected.txt:
- updated results

3:39 PM Changeset in webkit [127929] by anilsson@rim.com

2 edits in trunk/Source/WebCore

[CSS Shaders] WebKitCSSMixFunctionValue.h needs forward declaration of MemoryObjectInfo
https://bugs.webkit.org/show_bug.cgi?id=96150

Reviewed by George Staikos.

Otherwise files that include it may fail to compile.

No new tests, because this patch implements no new functionality.

css/WebKitCSSMixFunctionValue.h:

(WebCore):

3:25 PM Changeset in webkit [127928] by msaboff@apple.com

2 edits in trunk/Source/WTF

StringImpl::find(StringImpl*) doesn't handle cases where search and match strings are different bitness
https://bugs.webkit.org/show_bug.cgi?id=96125

Reviewed by Benjamin Poulain.

Changed findInner and reverseFindInner to be templated on both search and match character types.
Changed both find's and reverseFind to use all four bitness combinations of findInner and
reverseFindInner.

wtf/text/StringImpl.cpp:

(WTF::findInner):
(WTF::StringImpl::find):
(WTF::reverseFindInner):
(WTF::StringImpl::reverseFind):

3:22 PM Changeset in webkit [127927] by ojan@chromium.org

8 edits in trunk/LayoutTests

Fix the remaining linter errors. These are all cases of paths
that don't actually exist or that are duplicated between TestExpectations
and Skipped files. I left in the Skipped file entries since those
were the ones that win out when duplicated.

platform/efl/TestExpectations:
platform/mac/TestExpectations:
platform/qt-4.8/TestExpectations:
platform/qt/Skipped:
platform/qt/TestExpectations:
platform/win/Skipped:
platform/win/TestExpectations:

3:13 PM Changeset in webkit [127926] by schenney@chromium.org

2 edits in trunk/Source/WebCore

Mac build fix.
https://bugs.webkit.org/show_bug.cgi?id=93640

Reviewed by Abhishek Arya.

The original patch for this bug broke the mac builds.

WebCore.exp.in: Adding const marker

3:06 PM Changeset in webkit [127925] by ojan@chromium.org

3 edits in trunk/Tools

Handle non-existant TestExpectations files gracefully
https://bugs.webkit.org/show_bug.cgi?id=96149

Reviewed by Eric Seidel.

Even when we get rid of Skipped files, we shouldn't have each port
require a TestExpectations file for each platform if it doesn't
need one.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.expectations_dict):

Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_nonexistant_expectations):

2:57 PM Changeset in webkit [127924] by rjkroege@chromium.org

8 edits
2 moves in trunk/Source

[chromium] Add touchscreen specific fling curve parametrization
https://bugs.webkit.org/show_bug.cgi?id=95997

Reviewed by James Robinson.

Added a new set of fling curve parameters with a good feel for touchscreen
initiated flings. Renamed TouchpadFlingPlatformGestureCurve to
TouchFlingPlatformGestureCurve to better reflect that the class
can serve for both touchscreen and touchpad flings when appropriately
parametrized. Updated build files as necessary for the rename.

No new tests - existing tests apply.

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::fireUpAnAnimation):

platform/TouchFlingPlatformGestureCurve.cpp: Renamed from Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp.

(WebCore):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):
Added with touchscreen parameters.
(WebCore::TouchFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::~TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::debugName):
(WebCore::TouchFlingPlatformGestureCurve::apply):

platform/TouchFlingPlatformGestureCurve.h: Renamed from Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h.

(WebCore):
(TouchFlingPlatformGestureCurve):

platform/chromium/support/PlatformGestureCurveFactory.cpp: invokes

createForTouchPad or createForTouchScreen as appropriate.
(WebKit::PlatformGestureCurveFactory::createCurve):

Source/WebKit/chromium:

tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor.

2:50 PM WebKit Team edited by Elliott Sprehn

David Barr doesn't work for Google anymore (diff)

2:49 PM WebKit Team edited by Elliott Sprehn

Add myself! (diff)

2:45 PM Changeset in webkit [127923] by commit-queue@webkit.org

11 edits in trunk

Enter the creationContext before creating DOM wrappers
https://bugs.webkit.org/show_bug.cgi?id=96044

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

Source/WebCore:

Now that we have the creationContext available when instantiating DOM
wrappers, we should use it! After this patch, we enter the creation
context so that the DOM wrapper is created in the right context (and
therefore has the right prototype chain).

This patch would have been tested by
fast/dom/prototype-inheritance.html, but that test was removed because
it was too much work to maintain. I'll post what the diff would have
been to the results for that test as an attachment to this bug.

Note: After this patch there are a number of cleanup patches to write,
but I'll do those separately.

bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

This patch also includes a minor bug fix to the JSC implementations of Geolocation and Notifications. Previously, JSC was using the current lexical context for the callback object, which makes very little sense as it neither cooresponds to the Geolocation (or Notification) object or the functions being used for the callback.

To be consistent with how we do callbacks elsewhere in WebKit, we
should use the context that corresponds to the Geolocation (or
Notification) object. This change happened automatically for V8
when this patch fixed the Geolocation (and Notifications) wrapper
to use the right context, but for JSC we need to change these lines
of code explicitly.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

LayoutTests:

Update the Geolocation tests to show that we now use the correct
context for these callback. Specifically, we use the context that
cooresponds to the Geolocation object itself, not whatever random
context we happened to be in when we first touched the Geolocation
object.

fast/dom/Geolocation/callback-to-deleted-context-expected.txt:
fast/dom/Geolocation/disconnected-frame-expected.txt:
fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
fast/dom/Geolocation/resources/callback-to-deleted-context-inner1.html:
fast/dom/Geolocation/script-tests/callback-to-deleted-context.js:

(onSecondIframeLoaded):

fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js:

(onIframeUnloaded.setTimeout):

fast/dom/Geolocation/script-tests/disconnected-frame.js:

(onIframeUnloaded.setTimeout):
(onIframeUnloaded):

2:28 PM Changeset in webkit [127922] by leoyang@rim.com

3 edits
3 adds in trunk

Appcache fallback URL match should use the longest candidate
https://bugs.webkit.org/show_bug.cgi?id=96126

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/appcache/multi-fallback.html

loader/appcache/ApplicationCache.cpp:

(WebCore::fallbackURLLongerThan):
(WebCore::ApplicationCache::setFallbackURLs):

LayoutTests:

Test with multiple candidates of fallback match.

http/tests/appcache/multi-fallback-expected.txt: Added.
http/tests/appcache/multi-fallback.html: Added.
http/tests/appcache/resources/multi-fallback.manifest: Added.

2:19 PM Changeset in webkit [127921] by Lucas Forschler

4 edits in branches/safari-536.26-branch/Source

Versioning.

2:17 PM Changeset in webkit [127920] by schenney@chromium.org

10 edits
4 adds in trunk

Font data is purged while fonts are still using it
https://bugs.webkit.org/show_bug.cgi?id=93640

Reviewed by Eric Seidel.

Source/WebCore:

Move the handling of custom font pruning from Document to FontFallbackList.
The previous inplementation allowed fonts to be removed before all their
clients were done. This change moves handling of custom font purging to the
FontFallbackList class, which is the shared object that is only removed
when all clients of a font are done with it. This fixes a crash in Angry
Birds due to a seamless iframe and some failing tests in fast/frames/seamless.

The specific element that causes problems is:
<iframe id="ingame_frame0" name="ingame_frame0" frameborder="0" seamless="true"

src="http://chrome.angrybirds.com/ingame_graphic.html"
onload="this.style.opacity = 1; parent.adLoaded();" scrolling="no"
style="opacity: 1; -webkit-transition: opacity 1s ease-in-out 0s;
position: absolute; border: 0px; width: 312px; height: 320px; z-index:
300; overflow: hidden; visibility: visible;"></iframe>

The source document uses the same font as the embedding document.

Tests: fast/frames/seamless/seamless-custom-font-pruning-crash.html

fast/frames/seamless/seamless-nested-crash.html

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Remove code to register the
font with the document.

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Remove code to register
the font with the document.

dom/Document.cpp:

(WebCore::Document::~Document): Remove code that records and purges
custom fonts.
(WebCore):
(WebCore::Document::reportMemoryUsage): Remove reference to removed
object.

dom/Document.h:

(Document): Remove method declarations for custom font handling.

platform/graphics/FontData.h: Add RefCounted to FontData. Previously, FontData

for custom fonts was owned by a Vector<OwnPtr<FontData>> in Document. Now it
is owned by FontFallbackList, and ref counting is required. A future patch will
add RefPtr code for all FontData use cases.

platform/graphics/FontFallbackList.cpp:

(WebCore): Add global custom font data cache, which owns the FontData pointers
used as keys.
(WebCore::FontFallbackList::appendFontData): Helper method increments
the ref count on custom FontData.
(WebCore::FontFallbackList::releaseFontData): Helper method decrements
the ref count on custom FontData.
(WebCore::FontFallbackList::fontDataAt): Add calls to register the
FontFallbackList as a client of custom fonts.

platform/graphics/FontFallbackList.h:

(WebCore::FontFallbackList::setGlyphPageZero): Moved this declaration.
(WebCore::FontFallbackList::setGlyphPages): Moved this declaration.
(FontFallbackList):

platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::pruneFontData): Removed unnecessary null check.

LayoutTests:

Tests for font purging. The seamless-custom-font-pruning-crash test
was only failing in Chromium Asan, while the seamless-nested-crash case
was only failing in Asan DumpRenderTree.

fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Added.
fast/frames/seamless/seamless-custom-font-pruning-crash.html: Added.
fast/frames/seamless/seamless-nested-crash-expected.txt: Added.
fast/frames/seamless/seamless-nested-crash.html: Added.

2:16 PM Changeset in webkit [127919] by Lucas Forschler

1 copy in tags/Safari-536.26.14

New Tag.

2:14 PM Changeset in webkit [127918] by jamesr@google.com

10 edits
3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r127911.
http://trac.webkit.org/changeset/127911
https://bugs.webkit.org/show_bug.cgi?id=96146

Patch breaks build with clang (Requested by rbuis on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore):
(MeshGenerator):
(WebCore::MeshGenerator::MeshGenerator):
(WebCore::MeshGenerator::vertices):
(WebCore::MeshGenerator::indices):
(WebCore::MeshGenerator::points):
(WebCore::MeshGenerator::pointsCount):
(WebCore::MeshGenerator::tiles):
(WebCore::MeshGenerator::tilesCount):
(WebCore::MeshGenerator::indicesCount):
(WebCore::MeshGenerator::floatsPerVertex):
(WebCore::MeshGenerator::verticesCount):
(WebCore::MeshGenerator::addTile):
(WebCore::MeshGenerator::addAttachedMeshIndex):
(WebCore::MeshGenerator::generateAttachedMesh):
(WebCore::MeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::MeshGenerator::generateDetachedMesh):
(WebCore::MeshGenerator::addPositionAttribute):
(WebCore::MeshGenerator::addTexCoordAttribute):
(WebCore::MeshGenerator::addMeshCoordAttribute):
(WebCore::MeshGenerator::addTriangleCoordAttribute):
(WebCore::MeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::MeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::MeshGenerator::dumpBuffers):
(WebCore::CustomFilterMesh::CustomFilterMesh):

platform/graphics/filters/CustomFilterMeshGenerator.cpp: Removed.
platform/graphics/filters/CustomFilterMeshGenerator.h: Removed.
platform/graphics/filters/CustomFilterValidatedProgram.cpp:

platform/graphics/filters/CustomFilterValidatedProgram.h:

(CustomFilterValidatedProgram):

platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Removed.

2:04 PM Changeset in webkit [127917] by ojan@chromium.org

3 edits in trunk/LayoutTests

Fix linter errors. The deleted lines are all tests that are passing
or that no longer exist at that path.

platform/efl/TestExpectations:
platform/mac/TestExpectations:

1:58 PM Changeset in webkit [127916] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove platform/chromium-linux/compositing/gestures
test skipping. All compositing tests seem to have the same failure.

platform/chromium/TestExpectations:

1:54 PM Changeset in webkit [127915] by ojan@chromium.org

10 edits
4 adds in trunk

Fix RenderBox::availableHeight to subtract scrollbars in the right places
https://bugs.webkit.org/show_bug.cgi?id=96031

Reviewed by Tony Chang.

Source/WebCore:

This matches Firefox 15 and IE9 rendering for the two new tests.

Tests: fast/block/positioning/percent-top-left-on-relative-position.html

fast/css/nested-percent-height-on-replaced.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Subtract scrollbars when recurring on percentage heights.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
This is the wrong place to subtract scrollbars. availableLogicalHeight
should return a value that doesn't include scrollbars.
(WebCore::RenderBox::availableLogicalHeightUsing):
Subtract scrollbars from specified heights. Also, consolidate the code to
use computeContentLogicalHeightUsing. This makes percentage heights use
the right containingBlock in quirks mode and makes viewport percentage heights work.

LayoutTests:

fast/block/positioning/percent-top-left-on-relative-position-expected.html: Added.
fast/block/positioning/percent-top-left-on-relative-position.html: Added.
fast/css/nested-percent-height-on-replaced-expected.txt: Added.
fast/css/nested-percent-height-on-replaced.html: Added.
platform/chromium-linux/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium-win/fast/css/percent-top-value-with-relative-position-expected.txt:

This is now correctly centering the 50%. It moved up 8px because that is half of the body's margin.
This matches other Firefox 15 and IE9.

1:50 PM Changeset in webkit [127914] by tony@chromium.org

3 edits in trunk/Source/WebCore

Make RenderBox::computeLogicalWidthInRegion const
https://bugs.webkit.org/show_bug.cgi?id=96129

Reviewed by Ojan Vafai.

Making computeLogicalWidthInRegion const allows us to get rid of the gross hack in
RenderBox::renderBoxRegionInfo.

No new tests, this is covered by existing layout tests.

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax): Make const.
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Make const.
(WebCore::RenderBox::computeLogicalWidth): Use a LogicalExtentComputedValues when calling computeLogicalWidthInRegion.
(WebCore::RenderBox::computeLogicalWidthInRegion): Make const. Fill in a LogicalExtentComputedValues struct instead.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Make const.
(WebCore::RenderBox::renderBoxRegionInfo): Remove hack and get region width values in a LogicalExtentComputedValues struct.

rendering/RenderBox.h:

(RenderBox):

1:47 PM Changeset in webkit [127913] by danakj@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Remove bad assert in CCRenderPass::Id
https://bugs.webkit.org/show_bug.cgi?id=96138

Reviewed by James Robinson.

The assert prevents HashMap from creating "deleted" and "empty" ids. We
assert that RenderPasses have correct ids already, and don't need to
assert inside the Id structure itself.

platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCRenderPass::Id::Id):

1:41 PM Changeset in webkit [127912] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Unreviewed, fix incorrect comment character(s) in Skipped list.

platform/mac/Skipped:

1:40 PM UsingGitWithWebKit edited by ojan@chromium.org

(diff)

1:19 PM Changeset in webkit [127911] by anilsson@rim.com

10 edits
4 adds in trunk/Source/WebCore

[CSS Shaders] [BlackBerry] Refactor CustomFilterMesh and CustomFilter*Program
https://bugs.webkit.org/show_bug.cgi?id=94725

Reviewed by Rob Buis.

Separate the MeshGenerator from the CustomFilterMesh into
CustomFilterMeshGenerator.h/cpp. This allows the BlackBerry port to
reuse the mesh generator in its accelerated compositing implementation.

Also add support for creating a "PlatformCompiledProgram" from a
CustomFilterValidatedProgram, so the BlackBerry port can reuse the
shader validation code in its accelerated compositing implementation.

It turns out the GraphicsContext3D is not needed for ANGLE to function,
so this patch removes an ASSERT that required a context before
validating the shaders using ANGLE. This allows the BlackBerry port to
reuse the validation code without triggering the assert. In the future,
the validation code could be moved to a separate class to make it more
obvious that it isn't really related to GraphicsContext3D.

In general, this refactoring can be useful for any port that uses
OpenGL to implement accelerated compositing.

Inspired by an original patch by Joshua Netterfield.

No new tests, because this patch implements no new functionality.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):

platform/graphics/filters/CustomFilterMeshGenerator.cpp: Added.

(WebCore):
(WebCore::CustomFilterMeshGenerator::CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshIndex):
(WebCore::CustomFilterMeshGenerator::generateAttachedMesh):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::CustomFilterMeshGenerator::generateDetachedMesh):
(WebCore::CustomFilterMeshGenerator::addPositionAttribute):
(WebCore::CustomFilterMeshGenerator::addTexCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addMeshCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addTriangleCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::dumpBuffers):

platform/graphics/filters/CustomFilterMeshGenerator.h: Added.

(WebCore):
(CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::vertices):
(WebCore::CustomFilterMeshGenerator::indices):
(WebCore::CustomFilterMeshGenerator::points):
(WebCore::CustomFilterMeshGenerator::pointsCount):
(WebCore::CustomFilterMeshGenerator::tiles):
(WebCore::CustomFilterMeshGenerator::tilesCount):
(WebCore::CustomFilterMeshGenerator::indicesCount):
(WebCore::CustomFilterMeshGenerator::floatsPerVertex):
(WebCore::CustomFilterMeshGenerator::verticesCount):
(WebCore::CustomFilterMeshGenerator::addTile):

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

platform/graphics/filters/CustomFilterValidatedProgram.h:

(WebCore):
(CustomFilterValidatedProgram):

platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Added.

(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

1:12 PM Changeset in webkit [127910] by tony@chromium.org

4 edits in trunk/Tools

Regression: check-webkit-style no longer checks TestExpectations for syntax errors
https://bugs.webkit.org/show_bug.cgi?id=96136

Reviewed by Ojan Vafai.

When we renamed the file to TestExpectations, it was no longer considered a text file so
it was no longer being checked. Since then, test_expectations_overrides() has been removed
from the port object, so I've removed that from the check. I'm not sure what it was
supposed to do.

Scripts/webkitpy/style/checker.py:

(CheckerDispatcher._file_type): Mark TestExpectations as a text file.

Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations): Remove overrides param.
(TestExpectationsChecker.check): Remove overrides param.

Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.assert_lines_lint): Remove overrides param.

1:04 PM Changeset in webkit [127909] by commit-queue@webkit.org

52 edits
1 add in trunk

[EFL] Use same default minimum logical font size in DRT and WTR
https://bugs.webkit.org/show_bug.cgi?id=96116

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07
Reviewed by Martin Robinson.

Source/WebKit/efl:

Add DRT helper function to set the minimum logical
font size setting.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setMinimumLogicalFontSize):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit2:

Add private bundle C API to set the minimum logicial font
size setting. This is needed by WebKitTestRunner.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetMinimumLogicalFontSize):

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setMinimumLogicalFontSize):
(WebKit):

WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
logical font size to 9 to match the value used in WTR.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting): Explicitly set the minimum
logical font size to 9 (default value in WK2)

LayoutTests:

Provide new baseline for several tests now that the minimum
logical font size setting is set to 9 in EFL's DRT.

Unskip several tests in EFL WK2 now that EFL's DRT uses
the same minimum logical font size and now that the tests
have been rebaselined.

platform/efl-wk2/TestExpectations:
platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
platform/efl/fast/ruby/nested-ruby-expected.png:
platform/efl/fast/ruby/nested-ruby-expected.txt:
platform/efl/fast/ruby/ruby-beforeafter-expected.png:
platform/efl/fast/ruby/ruby-beforeafter-expected.txt:
platform/efl/fast/ruby/ruby-empty-rt-expected.png:
platform/efl/fast/ruby/ruby-empty-rt-expected.txt:
platform/efl/fast/ruby/ruby-length-expected.png:
platform/efl/fast/ruby/ruby-length-expected.txt:
platform/efl/fast/ruby/ruby-run-break-expected.png:
platform/efl/fast/ruby/ruby-run-break-expected.txt:
platform/efl/fast/ruby/ruby-runs-expected.png:
platform/efl/fast/ruby/ruby-runs-expected.txt:
platform/efl/fast/ruby/ruby-runs-spans-expected.png:
platform/efl/fast/ruby/ruby-runs-spans-expected.txt:
platform/efl/fast/ruby/ruby-simple-expected.png:
platform/efl/fast/ruby/ruby-simple-expected.txt:
platform/efl/fast/ruby/ruby-simple-rp-expected.png:
platform/efl/fast/ruby/ruby-simple-rp-expected.txt:
platform/efl/fast/ruby/ruby-trailing-expected.png:
platform/efl/fast/ruby/ruby-trailing-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-rt-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-rt-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-text1-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-text1-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-text2-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-text2-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-text3-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-text3-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-text1-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-text1-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-text2-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-text2-expected.txt:
platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:

12:54 PM Changeset in webkit [127908] by commit-queue@webkit.org

1 edit
3 moves in trunk/LayoutTests

[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Move preserve-3d-toggle.html to the common compositing tests directory because
it isn't Chromium-specific.

compositing/preserve-3d-toggle-expected.png: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.png.
compositing/preserve-3d-toggle-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.txt.
compositing/preserve-3d-toggle.html: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle.html.

12:37 PM Changeset in webkit [127907] by danakj@chromium.org

18 edits in trunk/Source

[chromium] Make RenderPass ids hold both generating layer id and an index
https://bugs.webkit.org/show_bug.cgi?id=95500

Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to avoid complex renderPassId mappings between
compositors for ubercomp. The ubercomp layer needs to add a number
of RenderPasses to the frame, and these must not conflict with other
RenderPasses in the frame. By using its layer id along with an extra
value it determines, the layer can create a unique id without needing
access to any global state or id generator.

Covered by existing tests.

platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

platform/graphics/chromium/cc/CCRenderPass.h:

(Id):
(WebCore::CCRenderPass::Id::Id):
(WebCore::CCRenderPass::Id::operator==):
(WebCore::CCRenderPass::Id::operator!=):
(WebCore::CCRenderPass::Id::operator<):
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::renderPassId):
(WebCore):
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:
tests/CCLayerTreeHostTest.cpp:
tests/CCRenderSurfaceTest.cpp:
tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

12:30 PM Changeset in webkit [127906] by tommyw@google.com

20 edits
2 adds in trunk

MediaStream API: add RTCPeerConnection::createAnswer
https://bugs.webkit.org/show_bug.cgi?id=96092

Reviewed by Adam Barth.

Source/Platform:

chromium/public/WebRTCPeerConnectionHandler.h:

(WebRTCPeerConnectionHandler):

Source/WebCore:

Test: fast/mediastream/RTCPeerConnection-createAnswer.html

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createAnswer):
(WebCore):

Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

Modules/mediastream/RTCPeerConnection.idl:
platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createAnswer):
(WebCore):

platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::createAnswer):
(WebCore):

platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

Expanding and enhancing MockWebRTCPeerConnectionHandler.

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::createAnswer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

fast/mediastream/RTCPeerConnection-createAnswer-expected.txt: Added.
fast/mediastream/RTCPeerConnection-createAnswer.html: Added.
fast/mediastream/RTCPeerConnection-createOffer-expected.txt:
fast/mediastream/RTCPeerConnection-createOffer.html:
fast/mediastream/RTCPeerConnection-localDescription-expected.txt:
fast/mediastream/RTCPeerConnection-localDescription.html:
fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
fast/mediastream/RTCPeerConnection-remoteDescription.html:

12:20 PM Changeset in webkit [127905] by wangxianzhu@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Update test expectation media/video-set-rate-from-pause.html on Android.

platform/chromium/TestExpectations:

12:15 PM Changeset in webkit [127904] by commit-queue@webkit.org

6 edits in trunk/LayoutTests

[WK2][WTR] Unskip detached-stylesheet-without-wrapper.html test case.
https://bugs.webkit.org/show_bug.cgi?id=96069

Unreviewed EFL gardening.

fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html test case has been passed on EFL layout test.
WebKit EFL doesn't have to skip this.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-07

platform/gtk-wk2/Skipped:
platform/mac-wk2/Skipped:
platform/qt-5.0-wk2/Skipped:
platform/win-wk2/Skipped:
platform/wk2/Skipped:

12:04 PM Changeset in webkit [127903] by jsbell@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect
https://bugs.webkit.org/show_bug.cgi?id=96122

Reviewed by Adam Barth.

Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory
open() method now takes the "database callbacks", rather than being sent through
in a later call.

Also, delete an obsolete method.

public/WebIDBFactory.h:

(WebKit):
(WebIDBFactory): Delete pre-version overload of open().
(WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks.

11:51 AM Changeset in webkit [127902] by vsevik@chromium.org

4 edits
3 adds in trunk

Web Inspector: [REGRESSION] Content is not available for dynamically loaded script sometimes.
https://bugs.webkit.org/show_bug.cgi?id=95954

Reviewed by Yury Semikhatsky.

Source/WebCore:

Resource now loads content from request when it is available.
Content was loaded from PageAgent before where it might be not available if the resource was already GCed.

Test: http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html

inspector/front-end/Resource.js:

(WebInspector.Resource.prototype._innerRequestContent.contentLoaded):
(WebInspector.Resource.prototype._innerRequestContent.resourceContentLoaded):
(WebInspector.Resource.prototype._innerRequestContent):

LayoutTests:

http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache-expected.txt: Added.
http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html: Added.
http/tests/inspector/resource-tree/resources/dynamic-script.js: Added.

(foo):

http/tests/inspector/resources-test.js:

11:44 AM Changeset in webkit [127901] by dino@apple.com

2 edits in trunk/Tools

Unreviewed changes to watchlist.

Add new WebGL and Filters definitions
Add myself to OpenGL bugs

Scripts/webkitpy/common/config/watchlist:

11:39 AM Changeset in webkit [127900] by dmazzoni@google.com

2 edits in trunk/LayoutTests

Unreviewed, skip accessibility/spinbutton-value.html on win.

11:32 AM Changeset in webkit [127899] by abarth@webkit.org

2 edits in trunk/Source/WebCore

HTMLTokenizer should use the latest EfficientStrings hotness
https://bugs.webkit.org/show_bug.cgi?id=95276

Reviewed by Benjamin Poulain.

Using ASCIILiteral avoids memcpying the string into the heap and
therefore uses less total memory.

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

11:31 AM Changeset in webkit [127898] by fsamuel@chromium.org

1 edit
1 add in trunk/LayoutTests

Unreviewed rebaseline.

Colors changed slightly, but the test's intention is to verify scaling
works as expected and it continues to do so.

platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.

11:27 AM Changeset in webkit [127897] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Unreviewed, trying to get the cr-linux ews into a usable state.

platform/chromium/TestExpectations: Revert r127883 and skip http/tests/cache/cancel-during-revalidation-succeeded.html

on the cr-ews linux bots. This is causing the following 2 tests to fail.

11:26 AM Changeset in webkit [127896] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing
https://bugs.webkit.org/show_bug.cgi?id=95932

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to
properly scroll it.

tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F): Re-enable the test.

11:17 AM Changeset in webkit [127895] by peter@chromium.org

2 edits in trunk/Tools

Actually trigger the Android Tester
https://bugs.webkit.org/show_bug.cgi?id=96118

Reviewed by Adam Barth.

BuildSlaveSupport/build.webkit.org-config/config.json:

11:11 AM Changeset in webkit [127894] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Initialize caret rectangle with invalid location
https://bugs.webkit.org/show_bug.cgi?id=96011

Patch by Yongxin Dai <yodai@rim.com> on 2012-09-07
Reviewed by Rob Buis.

In SelectionHandler::selectionPositionChanged() method, startCaret and
endCaret are used to notify clients about new caret positions. This patch
initializes startCaret and endCaret with location(-1. -1), and keeps them
empty before they are assigned to valid values. This would help for other
classes to check validity of the caret correctly.

Internal reviewed by Mike Fenton.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

11:09 AM Changeset in webkit [127893] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Move some CC unit tests into correct gyp variable
https://bugs.webkit.org/show_bug.cgi?id=96048

Patch by James Robinson <jamesr@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.

These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable.

WebKit.gypi:

11:08 AM Changeset in webkit [127892] by fsamuel@chromium.org

4 edits in trunk/LayoutTests

Unreviewed rebaseline for chromium gardening.

platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:

10:57 AM Changeset in webkit [127891] by jamesr@google.com

10 edits
3 deletes in trunk/Source

[chromium] Remove dead CCActiveGestureAnimation code and related classes
https://bugs.webkit.org/show_bug.cgi?id=96075

Reviewed by Adrienne Walker.

Source/WebCore:

The CCGestureCurve / CCActiveGestureAnimation code isn't used and never has been used. Gesture curves are
evaluated by the CCInputHandlerClient (WebCompositorInputHandlerImpl), CC itself logically doesn't know anything
about gestures.

WebCore.gypi:
platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Removed.
platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Removed.
platform/graphics/chromium/cc/CCGestureCurve.h: Removed.
platform/graphics/chromium/cc/CCInputHandler.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
evaluate the curve itself without intermediate classes.

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):

src/WebCompositorInputHandlerImpl.h:

(WebCore):
(WebCompositorInputHandlerImpl):

tests/PlatformGestureCurveTest.cpp:
tests/WebCompositorInputHandlerImplTest.cpp:

10:57 AM Changeset in webkit [127890] by roger_fong@apple.com

2 edits in trunk/LayoutTests

http/tests/security/contentSecurityPolicy/blob-urls-match-self.html fails on Windows port.
https://bugs.webkit.org/show_bug.cgi?id=96133

Test fails on Windows port since added in http://trac.webkit.org/changeset/126785.
Blobs might be completely disabled on Windows. Adding to skip list for now.

platform/win/Skipped:

10:52 AM Changeset in webkit [127889] by Martin Robinson

6 edits
2 adds in trunk

[GTK] Move user agent helpers to WebCore
https://bugs.webkit.org/show_bug.cgi?id=95745

Reviewed by Carlos Garcia Campos.

Added an autoconf step for the new user agent shared code header in
WebCore. This is necessary so that we can use the user agent version
based on the information in the configure.ac file.

configure.ac:

Source/WebCore:

Moved the user agent determination code from WebKit1 to WebCore so that it can
be shared with WebKit2. Also add a method for creating the user agent given
a non-default application name.

GNUmakefile.list.am: Add new files to the list.
platform/gtk/UserAgentGtk.cpp: Added.
platform/gtk/UserAgentGtk.h.in: Added.

Source/WebKit/gtk:

Move the code for determining the user agent to WebCore and have WebKit1
use the new shared code.

webkit/webkitwebsettings.cpp: Use the WebCore code to determine the user

agent in WebKit1.

10:49 AM Changeset in webkit [127888] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up dependencies in ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96052

Patch by James Robinson <jamesr@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.

Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
*) WebScrollbarImpl.h is #included, but not use
*) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if

WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.

tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

10:46 AM Changeset in webkit [127887] by msaboff@apple.com

4 edits in trunk/Source/WTF

equalIgnoringCase of two StringImpls doesn't handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=96028

Reviewed by Benjamin Poulain.

Added 8 bit checks and paths to CaseFoldingHash::equal. Also cleaned up StringHash::equal(), removing
obvious and in one case wrong comments. Moved equalIgnoringCase(UChar*, UChar*) from StringImpl.cpp
to StringImpl.h.

wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):

wtf/text/StringImpl.cpp:
wtf/text/StringImpl.h:

(WTF::equalIgnoringCase):

10:25 AM Changeset in webkit [127886] by abarth@webkit.org

26 edits in trunk/Source/WebCore

Update bindings results after https://bugs.webkit.org/show_bug.cgi?id=96039

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::toV8):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestCallback.cpp:

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

10:22 AM Changeset in webkit [127885] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, fix overlapping test expectation.

platform/chromium/TestExpectations:

10:13 AM Changeset in webkit [127884] by commit-queue@webkit.org

9 edits
1 add in trunk/Source

[BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.
https://bugs.webkit.org/show_bug.cgi?id=95488
PR: 186597.

Internally reviewed by Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-09-07
Reviewed by Yong Li.

Source/WebCore:

The fix for this PR will come as 2 patches. This is the first patch which
will make the authentication challenge asynchronous inside WebKit. The
bext patch will add an AuthenticationChallengeManager that manages these
authentication requests asynchronously.

This patch add AuthenticationChallengeClient interface to define asynchronous
authentication challenge callback. And MediaPlayerPrivateBlackBerry and
NetworkJob are changed to inherit from AuthenticationChallengeClient to
support asynchronous authentication challenge.

Note: there is also an accompanying platform patch to make our PlatformPlayer
to support asychronous authentication, see PR 186597 for details.

No new tests as this is platform specific change.

platform/blackberry/AuthenticationChallengeManager.h: Added.

(WebCore):
(AuthenticationChallengeClient):

platform/blackberry/PageClientBlackBerry.h:

(WebCore):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
(WebCore):

platform/network/blackberry/NetworkJob.h:

(WebCore):
(NetworkJob):

Source/WebKit/blackberry:

Use new AuthenticationChallengeClient interface to make authentication
challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and
other module that will use HTTP authentication. WebPage itself still use
synchronous authentication though. Switching to asynchronous authentication
in WebPage will require bigger platform layer change and not very necessary
at the moment for this bug.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

10:09 AM Changeset in webkit [127883] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Unreviewed, trying to get the cr-linux ews into a usable state.

platform/chromium/TestExpectations: mark 2 http cache tests as flaky

10:07 AM Changeset in webkit [127882] by dmazzoni@google.com

13 edits
2 adds in trunk

Source/WebCore: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Make an ARIA spin button support ARIA range attributes like
aria-valuenow, aria-valuemin, etc. - just like slider, progressbar,
and scrollbar.

Test: accessibility/spinbutton-value.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::valueDescription):
(WebCore):
(WebCore::AccessibilityRenderObject::isAriaRange):
(WebCore::AccessibilityRenderObject::valueForRange):
(WebCore::AccessibilityRenderObject::maxValueForRange):
(WebCore::AccessibilityRenderObject::minValueForRange):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::isGenericFocusableElement):
(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Source/WebKit/chromium: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Expose supportsRangeValue to simplify Chromium logic for when to
extract a value from a range.

public/WebAccessibilityObject.h:

(WebAccessibilityObject):

src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::supportsRangeValue):
(WebKit):

Tools: New time input needs accessibility
https://bugs.webkit.org/show_bug.cgi?id=96032

Reviewed by Chris Fleizach.

Add support for valueDescription for testing.

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(getValueDescription):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::valueDescriptionGetterCallback):

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:

(AccessibilityUIElement):

LayoutTests: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Test that an ARIA spin button exposes ARIA range attributes like
aria-valuenow, aria-valuemin, etc.

accessibility/spinbutton-value-expected.txt: Added.
accessibility/spinbutton-value.html: Added.

10:02 AM Changeset in webkit [127881] by rwlbuis@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove feature about:cache/disable and about:cache/enable
https://bugs.webkit.org/show_bug.cgi?id=95820

Reviewed by Yong Li.

Fix warning that was caused by r127680.

WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::cachePage):

9:58 AM Changeset in webkit [127880] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Unreviewed, rolling out r127820.
http://trac.webkit.org/changeset/127820
https://bugs.webkit.org/show_bug.cgi?id=96117

Introduces crashes in Chromium compositing tests (Requested by
fsamuel on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::evictAllContentTextures):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::allBackingTexturesWereDeleted):

platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

9:55 AM Changeset in webkit [127879] by Patrick Gansterer

2 edits in trunk/Source/WTF

[WIN] Deprecate String += operator
https://bugs.webkit.org/show_bug.cgi?id=96083

Reviewed by Adam Barth.

wtf/Platform.h:

9:31 AM Changeset in webkit [127878] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Unskip test cases that are now passing consistently
https://bugs.webkit.org/show_bug.cgi?id=96090

Unreviewed EFL gardening.

Remove from TestExpectations several test cases that are now
passing consistently on EFL WK2 build bot.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07

platform/efl-wk2/TestExpectations:

9:27 AM Changeset in webkit [127877] by Simon Hausmann

2 edits in trunk/Source/WebCore

[Qt] Add another all-in-one source

Rubber-stamped by Tor Arne Vestbø.

Target.pri: We can safely add platform/text/TextAllInOne.cpp to ALL_IN_ONE_SOURCES for

even smaller combined builds.

9:09 AM Changeset in webkit [127876] by allan.jensen@nokia.com

46 edits in trunk

Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720

Reviewed by Antonio Gomes.

Update exported symbols.

Source/autotools/symbols.filter:

Source/WebCore:

The existing API was overloaded and could be simplified by passing all the bool arguments in
a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
state what they do.

WebCore.exp.in:
WebCore.order:
dom/Document.cpp:

(WebCore::Document::nodesFromRect):

dom/Document.h:

(Document):

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::createContextMenu):

page/DragController.cpp:

(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

page/EventHandler.cpp:

(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):

page/EventHandler.h:

(EventHandler):

page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):

page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

rendering/HitTestRequest.h:

(HitTestRequest):

testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

Update calls to new API.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtPoint):

WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

Update calls to new API.

src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):
(WebKit::WebViewImpl::computeBlockBounds):

Source/WebKit/efl:

Update calls to new API.

ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/mac:

Update calls to new API.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary):

WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

Update calls to new API.

Api/qwebframe.cpp:

(QWebFrame::hitTestContent):

Api/qwebpage.cpp:

(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
(QWebPage::updatePositionDependentActions):

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

Source/WebKit/win:

Update calls to new API.

WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

WebView.cpp:

(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):

Source/WebKit/wx:

Update calls to new API.

WebFrame.cpp:

(WebKit::WebFrame::HitTest):

Source/WebKit2:

Update calls to new API and update exported symbols.

WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation): Corrects the misplaced arguments while converting them.
(WebKit::WebPage::findZoomableAreaForPoint):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

win/WebKit2.def:
win/WebKit2CFLite.def:

9:06 AM Changeset in webkit [127875] by peter@chromium.org

2 edits in trunk/Tools

Add the google-android-tests build slave to the master's config
https://bugs.webkit.org/show_bug.cgi?id=96113

Reviewed by Csaba Osztrogonác.

BuildSlaveSupport/build.webkit.org-config/config.json:

9:05 AM Changeset in webkit [127874] by Simon Hausmann

2 edits in trunk/Source/WebCore

Build of OpenGLShims.cpp against EGL/GLES2 platforms is broken
https://bugs.webkit.org/show_bug.cgi?id=95556

Reviewed by Jocelyn Turcotte.

There were a few problems:

1) GL_ANGLE_framebuffer_blit is the name of the macro indicating the
availability of the _declaration_ of that ANGLE extension. It is not the
name of the actual function, which is glBlitFramebufferANGLE.

2) The presence of the preprocessor macros indicating the availability
of the declaration of the extension does not imply presence of the extension
prototypes at link time. Instead extensions need to be looked up dynamically
at run-time.

3) dlfcn.h was unconditionally included. We do not need it when building against
Qt (and there it breaks the Windows build)

This patch implements the dynamic lookup of glBlitFramebufferANGLE
(used in GraphicsContext3DOpenGLES.cpp) as well as the dynamic lookup of the
Angle and Apple renderbuffer multisampling extensions.

platform/graphics/OpenGLShims.cpp:

(WebCore):
(WebCore::initializeOpenGLShims):

9:03 AM Changeset in webkit [127873] by commit-queue@webkit.org

3 edits in trunk/Tools

[WK2] [EFL] Set theme for WebKit2 API test runner
https://bugs.webkit.org/show_bug.cgi?id=96100

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Set the theme generated by the build for the WebKit2 API test runner.

TestWebKitAPI/PlatformEfl.cmake:
TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

9:01 AM Changeset in webkit [127872] by zandobersek@gmail.com

4 edits in trunk

[GTK] Multiple feature defines in webcore_cppflags can occur
https://bugs.webkit.org/show_bug.cgi?id=95942

Reviewed by Martin Robinson.

Add the feature_defines_unstable variable that should control values of feature
defines for unstable features when unstable features are not enabled (e.g. release builds).

GNUmakefile.am:

Source/WebCore:

Any feature define that guards a feature deemed currently unstable (is intended
to be enabled in developer builds but not in release builds) should be added to the
newly-added feature_defines_unstable variable.

This moves away from adding such feature defines to the feature_defines_overrides variable
as this can cause duplicates in the later-generated feature_defines and webcore_cppflags
variables and further warnings of duplicate macros when generating bindings.

The feature_defines generation is now done by first checking if the bare feature define
is present in feature_defines_unstable, if not then feature_defines_overrides is also
checked before using the value from feature_defines_defaults.

No new tests - no new functionality.

GNUmakefile.am:

9:01 AM Changeset in webkit [127871] by fsamuel@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Disabled test paste-global-selection on Chromium Linux that was failing.

platform/chromium/TestExpectations:

8:53 AM Changeset in webkit [127870] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rendering issue after rotation
https://bugs.webkit.org/show_bug.cgi?id=96094
PR #201930

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-07
Reviewed by George Staikos.

The cause of the rendering issue is that the BackingStore tiles
are not reset after layout. This is a regression of r125680, which
overwrites a local variable that are used later in the function.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

8:36 AM Changeset in webkit [127869] by loislo@chromium.org

102 edits
1 move
1 add in trunk/Source

Web Inspector: NMI: move WebCore specific code to separate header
https://bugs.webkit.org/show_bug.cgi?id=96101

Reviewed by Yury Semikhatsky.

I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/ScriptWrappable.h:
bindings/v8/DOMDataStore.cpp:
bindings/v8/IntrusiveDOMWrapperMap.h:
bindings/v8/ScriptProfiler.cpp:
bindings/v8/ScriptWrappable.h:
bindings/v8/V8Binding.cpp:
bindings/v8/V8DOMMap.h:
css/CSSAspectRatioValue.cpp:
css/CSSBorderImageSliceValue.cpp:
css/CSSCalculationValue.cpp:
css/CSSCanvasValue.cpp:
css/CSSCharsetRule.cpp:
css/CSSComputedStyleDeclaration.cpp:
css/CSSCrossfadeValue.cpp:
css/CSSCursorImageValue.cpp:
css/CSSFontFaceRule.cpp:
css/CSSFontFaceSrcValue.cpp:
css/CSSFunctionValue.cpp:
css/CSSGradientValue.cpp:
css/CSSImageGeneratorValue.cpp:
css/CSSImageSetValue.cpp:
css/CSSImageValue.cpp:
css/CSSImportRule.cpp:
css/CSSInheritedValue.cpp:
css/CSSInitialValue.cpp:
css/CSSLineBoxContainValue.cpp:
css/CSSMediaRule.cpp:
css/CSSPrimitiveValue.cpp:
css/CSSProperty.cpp:
css/CSSReflectValue.cpp:
css/CSSRuleList.h:
css/CSSSelectorList.cpp:
css/CSSStyleRule.cpp:
css/CSSStyleSheet.cpp:
css/CSSTimingFunctionValue.cpp:
css/CSSUnicodeRangeValue.cpp:
css/CSSUnknownRule.h:
css/CSSValue.cpp:
css/CSSValueList.cpp:
css/CSSVariableValue.h:
css/FontFeatureValue.cpp:
css/FontValue.cpp:
css/MediaList.cpp:
css/MediaQuery.cpp:
css/MediaQueryExp.cpp:
css/PropertySetCSSStyleDeclaration.cpp:
css/ShadowValue.cpp:
css/StyleResolver.cpp:
css/StyleRule.cpp:
css/StyleSheetContents.cpp:
css/WebKitCSSArrayFunctionValue.cpp:
css/WebKitCSSFilterValue.cpp:
css/WebKitCSSKeyframeRule.cpp:
css/WebKitCSSKeyframesRule.cpp:
css/WebKitCSSMixFunctionValue.cpp:
css/WebKitCSSSVGDocumentValue.cpp:
css/WebKitCSSShaderValue.cpp:
css/WebKitCSSTransformValue.cpp:
dom/CharacterData.cpp:
dom/Document.cpp:
dom/DocumentEventQueue.cpp:
dom/ElementAttributeData.cpp:
dom/Event.cpp:
dom/MemoryInstrumentation.h:
dom/Node.cpp:
dom/QualifiedName.h:
dom/WebCoreMemoryInstrumentation.cpp: Renamed from Source/WebCore/dom/MemoryInstrumentation.cpp.

(WebCore):
(WebCore::String):
(WebCore::StringImpl):
(WebCore::KURL):
(WebCore::AtomicString):

dom/WebCoreMemoryInstrumentation.h: Added.

(WebCore):
(WebCoreMemoryTypes):

loader/DocumentLoader.cpp:
loader/FrameLoader.cpp:
loader/SubresourceLoader.cpp:
loader/SubstituteData.cpp:
loader/cache/CachedCSSStyleSheet.cpp:
loader/cache/CachedFont.cpp:
loader/cache/CachedRawResource.cpp:
loader/cache/CachedResource.cpp:
loader/cache/CachedResourceHandle.cpp:
loader/cache/CachedScript.cpp:
loader/cache/CachedShader.cpp:
loader/cache/CachedXSLStyleSheet.cpp:
loader/cache/MemoryCache.cpp:
platform/SharedBuffer.cpp:
platform/graphics/BitmapImage.cpp:
platform/graphics/CrossfadeGeneratedImage.cpp:
platform/graphics/GeneratedImage.cpp:
platform/graphics/GeneratorGeneratedImage.h:
platform/graphics/Image.cpp:
platform/network/FormData.cpp:
platform/network/ResourceRequestBase.cpp:
platform/network/ResourceResponseBase.cpp:
rendering/style/RenderStyle.cpp:
rendering/style/StyleRareInheritedData.cpp:
rendering/style/StyleRareNonInheritedData.cpp:
svg/SVGColor.cpp:
svg/SVGPaint.cpp:

Source/WebKit/chromium:

tests/MemoryInstrumentationTest.cpp:

8:32 AM Changeset in webkit [127868] by vollick@chromium.org

9 edits in trunk/Source

[chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
https://bugs.webkit.org/show_bug.cgi?id=95855

Reviewed by James Robinson.

Source/Platform:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

chromium/public/WebTransformOperations.h:

(WebTransformOperations):

chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

Unit tests:

AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

platform/chromium/support/WebTransformOperations.cpp:

(WebKit::blendTransformOperations):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::canBlendWith):
(WebKit):
(WebKit::WebTransformOperations::blendInternal):

platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::blend):

platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::WebTransformAnimationCurve):

Source/WebKit/chromium:

Added the following unit tests:

AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):
(WebKit):

7:06 AM WebInspector edited by lindahomes9@gmail.com

(diff)

7:00 AM Changeset in webkit [127867] by apavlov@chromium.org

12 edits in trunk

Unreviewed, rolling out r127780 and r127859.
http://trac.webkit.org/changeset/127780
http://trac.webkit.org/changeset/127859
https://bugs.webkit.org/show_bug.cgi?id=96102

"inspector/styles/protocol-css-regions-commands.html crashing
on Chromium Linux Debug and timing out flakily on Release"
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

inspector/styles/protocol-css-regions-commands-expected.txt:
inspector/styles/protocol-css-regions-commands.html:

6:50 AM Changeset in webkit [127866] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Add passing expectations for a few specific sub-pixel and various input type
tests. These features are not yet supported by the GTK port but we're willing
to watch and monitor these tests' behavior.

platform/gtk/TestExpectations:

6:37 AM Changeset in webkit [127865] by commit-queue@webkit.org

3 edits
3 adds in trunk

[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Source/WebCore:

Fix removal of preserve-3d CSS attribute from a GraphicsLayerChromium.
It was broken by a refactor in http://trac.webkit.org/changeset/126378.

Test: platform/chromium/compositing/preserve-3d-toggle.html

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

LayoutTests:

Add test to verify dynamic removal of preserve-3d CSS attribute.

platform/chromium/compositing/preserve-3d-toggle-expected.png: Added.
platform/chromium/compositing/preserve-3d-toggle-expected.txt: Added.
platform/chromium/compositing/preserve-3d-toggle.html: Added.

6:24 AM Changeset in webkit [127864] by apavlov@chromium.org

11 edits in trunk

Web Inspector: Implement SCSS source highlighter
https://bugs.webkit.org/show_bug.cgi?id=95585

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change modifies the existing CSS highlighter to support SCSS as well. The "text/x-scss" mime-type is assigned to SASSSource.

inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.cssPropertiesMetainfoKeySet):

inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider): Enabled clients to supply the content mime-type.
(WebInspector.StaticContentProvider.prototype.mimeType):
(WebInspector.StaticContentProvider.prototype.requestContent): Use client-supplied content mime-type, if any.

inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSource): Construct StaticContentProvider with the "text/x-scss" mime-type.

inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):
(WebInspector.SourceCSSTokenizer.prototype.nextToken):

inspector/front-end/SourceCSSTokenizer.re2js: Extended with the SCSS syntax.
inspector/front-end/SourceTokenizer.js:

(WebInspector.SourceTokenizer.Registry):

inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-css-bang-keyword):

LayoutTests:

Test modified to cover the SCSS syntax as well.

inspector/syntax-highlight-css-expected.txt:
inspector/syntax-highlight-css.html:

5:59 AM Changeset in webkit [127863] by allan.jensen@nokia.com

4 edits in trunk/LayoutTests

Layout Test touchadjustment/iframe-boundary.html is failing
https://bugs.webkit.org/show_bug.cgi?id=95799

Unreviewed, fudge the test so it has a larger margin of error.

platform/chromium/TestExpectations:
touchadjustment/iframe-boundary.html:
touchadjustment/resources/inner-content-page.html:

5:51 AM Changeset in webkit [127862] by allan.jensen@nokia.com

27 edits
2 adds in trunk

X11 Global Selection
https://bugs.webkit.org/show_bug.cgi?id=88238

Reviewed by Tony Chang.

Source/WebCore:

In X11 global selection is the ability to share the active selection
between applications and pasting with middle mouse-button.

This patch moves the implementations of global selection from the
separate implementations in Qt WebKit, Chromium and GTK to WebCore,
by implementing a new EditorCommand for pasting the global selection.

Test: editing/pasteboard/paste-global-selection.html

editing/EditorCommand.cpp:

(WebCore::executePasteGlobalSelection):
(WebCore::createCommandMap):

page/EditorClient.h:

(EditorClient):
(WebCore::EditorClient::supportsGlobalSelection):

platform/Pasteboard.h:

(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):

Source/WebKit/chromium:

Use new editor command for pasting global selection.

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::supportsGlobalSelection):

src/EditorClientImpl.h:

(EditorClientImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):

Source/WebKit/qt:

Use new editor command for pasting global selection, and update it using
the respondToChangedSelection callback.

Api/qwebpage.cpp:

(QWebPagePrivate::handleClipboard):

WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::respondToChangedSelection):
(WebCore::EditorClientQt::supportsGlobalSelection):

WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit2:

Implements the hooks for supporting global selections in Qt WebKit2.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::updateGlobalSelection):
(WebKit::WebEditorClient::supportsGlobalSelection):

WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::updateGlobalSelection):

WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):

WebProcess/WebPage/WebPage.h:

(WebPage):

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::handleMouseReleaseEvent):

LayoutTests:

Adds a test for the new editor-command, and disables it an all platforms where it is not supported.

editing/pasteboard/paste-global-selection-expected.txt: Added.
editing/pasteboard/paste-global-selection.html: Added.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/Skipped:
platform/qt-mac/Skipped:
platform/win/Skipped:

5:32 AM Changeset in webkit [127861] by vsevik@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: Migrate Database to async protocol commands
https://bugs.webkit.org/show_bug.cgi?id=95983

Reviewed by Alexander Pavlov.

English.lproj/localizedStrings.js:
inspector/Inspector.json:
inspector/InspectorDatabaseAgent.cpp:

(WebCore):
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::executeSQL):

inspector/InspectorDatabaseAgent.h:

(InspectorDatabaseAgent):

inspector/front-end/Database.js:

(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):

5:29 AM Changeset in webkit [127860] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed single line follow-up change for r127856.

dom/MemoryInstrumentation.h:

(WebCore::MemoryClassInfo::MemoryClassInfo):

5:26 AM Changeset in webkit [127859] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed inspector closure compilation errors fix.

inspector/front-end/CSSStyleModel.js:

(WebInspector.NamedFlowCollection):

5:23 AM Changeset in webkit [127858] by vsevik@chromium.org

13 edits in trunk

Web Inspector: Migrate FileSystem to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95985

Reviewed by Alexander Pavlov.

Source/WebCore:

Migrated FileSystem domain to async protocol commands and removed boilerplate code.

inspector/Inspector.json:
inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::~InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::assertEnabled):

inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel):
(WebInspector.FileSystemModel.prototype._originAdded):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype.requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.prototype._requestFileContent):
(WebInspector.FileSystemModel.prototype._deleteEntry):

LayoutTests:

http/tests/inspector/filesystem/delete-entry.html:
http/tests/inspector/filesystem/directory-tree.html:
http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.MockEntry):

http/tests/inspector/filesystem/request-directory-content.html:
http/tests/inspector/filesystem/request-file-content.html:
http/tests/inspector/filesystem/request-filesystem-root.html:
http/tests/inspector/filesystem/request-metadata.html:

5:17 AM Changeset in webkit [127857] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Update TextExpectations for http/tests/appcache/load-from-appcache-defer-resume-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96091

Unreviewed EFL gardening.

Add bug number of http/tests/appcache/load-from-appcache-defer-resume-crash.html
in TestExpectations file.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07

platform/efl-wk2/TestExpectations:

5:10 AM Changeset in webkit [127856] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: NMI: remove DataRef instrumentation from the core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=96086

Reviewed by Yury Semikhatsky.

This patch is removing the last WebCore specific methods from core memory instrumentation code.

It is covered by webkit_unit_tests.

dom/MemoryInstrumentation.h:

(WebCore):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

rendering/style/DataRef.h:

(DataRef):
(WebCore::DataRef::reportMemoryUsage):

5:05 AM Changeset in webkit [127855] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unskip passing tests on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=96089

Unreviewed EFL gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07

platform/efl/TestExpectations:

4:57 AM Changeset in webkit [127854] by vsevik@chromium.org

10 edits in trunk

Web Inspector: Migrate IndexedDB to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95978

Reviewed by Alexander Pavlov.

Source/WebCore:

IndexedDB is now implemented using async protocol commands.
Removed boilerplate code used to emulate async commands before.

inspector/Inspector.json:
inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.prototype._requestData.innerCallback):
(WebInspector.IndexedDBModel.prototype._requestData):

LayoutTests:

http/tests/inspector/indexeddb/database-data.html:
http/tests/inspector/indexeddb/database-names.html:
http/tests/inspector/indexeddb/database-structure.html:
http/tests/inspector/indexeddb/resources-panel.html:

4:45 AM Changeset in webkit [127853] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed. Add Gábor Ballabás as contributor.

Scripts/webkitpy/common/config/committers.py:

4:04 AM Changeset in webkit [127852] by gyuyoung.kim@samsung.com

9 edits in trunk/Source/WebCore

Add *explicit* keyword to constructors in WebCore/xml
https://bugs.webkit.org/show_bug.cgi?id=96071

Reviewed by Kentaro Hara.

As a step to let *explicit* add to constructors which have only one parameter,
*explicit* is added to Source/WebCore/xml in order to avoid implicit type conversion.

No new tests. Covered by existing tests.

xml/NativeXPathNSResolver.h:

(NativeXPathNSResolver):

xml/XMLHttpRequestException.h:

(WebCore::XMLHttpRequestException::XMLHttpRequestException):

xml/XMLHttpRequestProgressEventThrottle.h:

(XMLHttpRequestProgressEventThrottle):

xml/XMLHttpRequestUpload.h:

(XMLHttpRequestUpload):

xml/XPathException.h:

(WebCore::XPathException::XPathException):

xml/XPathPredicate.h:

(Number):
(StringExpression):
(Predicate):

xml/XPathValue.h:

(WebCore::XPath::ValueData::ValueData):

xml/XPathVariableReference.h:

(VariableReference):

3:44 AM Changeset in webkit [127851] by commit-queue@webkit.org

2 edits in trunk/Tools

[Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
https://bugs.webkit.org/show_bug.cgi?id=96078

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-07
Reviewed by Tor Arne Vestbø.

Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.

qmake/mkspecs/features/default_pre.prf:

3:26 AM Changeset in webkit [127850] by commit-queue@webkit.org

5 edits
2 adds in trunk

[EFL] Add TestExpectations file for efl-wk1
https://bugs.webkit.org/show_bug.cgi?id=96019

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07
Reviewed by Gyuyoung Kim.

Tools:

Update TestExpectations cascading for EFL port
so that we use efl-wk1 -> efl search paths
for WebKit1 EFL.

Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._search_paths):

LayoutTests:

Add TestExpectations file for WebKit1 EFL.

platform/efl-wk1/TestExpectations: Added.
platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

3:01 AM Changeset in webkit [127849] by zandobersek@gmail.com

4 edits
1 add in trunk/Tools

[NRWT] XvfbDriver should stop the Xvfb more aggressively
https://bugs.webkit.org/show_bug.cgi?id=95097

Reviewed by Dirk Pranke.

The Xvfb process is now killed when the XvfbDriver is stopping. Simply
terminating the process does not always work as expected, leading to timeouts
in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
as it's not removed by the killed Xvfb process.

Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
is tested in different circumstances - whether pixel tests are enabled or not,
with an arbitrary worker number or with an Xorg process already running on the system.
The stopping of the driver is tested by checking that the Xvfb process is truly killed
and then set to None.

BuildSlaveSupport/kill-old-processes:

Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
is left running, potentially clogging up a display at a certain position.

Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.init):
The _running_pids is now a dictionary with process names as keys and pids
as values.
(MockExecutive.check_running_pid):
Check whether the passed-in pid is in the _running_pids dictionary's values.
(MockExecutive):
(MockExecutive.running_pids):
This method returns the list of all the process pids of which the name passes
through the process_name_filter.

Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

Use the Executive object of the port's host to check for running pids and open
new subprocesses or kill them throughout the class.
(XvfbDriver._start):
Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
start the server process after it's created.
(XvfbDriver.stop):
Now kills the Xvfb process instead of terminating it and waiting for it to close.

Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.

(XvfbDriverTest):
(XvfbDriverTest.make_driver):
(XvfbDriverTest.assertDriverStartSuccessful):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_start_existing_xorg_process):
(XvfbDriverTest.test_stop):
(XvfbDriverTest.test_stop.FakeXvfbProcess):

2:59 AM Changeset in webkit [127848] by gyuyoung.kim@samsung.com

6 edits in trunk/Source/WebKit/efl

Unreviewed, rolling out r127839.
http://trac.webkit.org/changeset/127839
https://bugs.webkit.org/show_bug.cgi?id=90603

This patch was landed with wrong implementation and policy.

WebCoreSupport/NotificationPresenterClientEfl.cpp:

(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

WebCoreSupport/NotificationPresenterClientEfl.h:

(NotificationPresenterClientEfl):

ewk/ewk_view.cpp:

(_ewk_view_priv_new):

ewk/ewk_view.h:
ewk/ewk_view_private.h:

2:20 AM Changeset in webkit [127847] by peter@chromium.org

2 edits in trunk/Tools

Introduce the Chromium Android Release (Tests) bot
https://bugs.webkit.org/show_bug.cgi?id=95980

Reviewed by Adam Barth.

This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
which will be running layout tests on actual Android devices. Right now,
four Galaxy Nexus phones are attached.

BuildSlaveSupport/build.webkit.org-config/config.json:

1:58 AM Changeset in webkit [127846] by nduca@chromium.org

2 edits in trunk/Source/Platform

[chromium] Allow enumeration of WebRenderingStats structure
https://bugs.webkit.org/show_bug.cgi?id=94565

Reviewed by James Robinson.

chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(Enumerator):
(WebKit::WebRenderingStats::Enumerator::~Enumerator):
(WebKit::WebRenderingStats::enumerateFields):

1:52 AM Changeset in webkit [127845] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] APIClientTraits<WKPageLoaderClient> and APIClientTraits<WKBundlePageLoaderClient> are not initialized properly
https://bugs.webkit.org/show_bug.cgi?id=96079

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

APIClientTraits<WKPageLoaderClient> was missing offset for version number 2 and
APIClientTraits<WKBundlePageLoaderClient> was missing offset for version number 3.

Shared/APIClientTraits.cpp:

(WebKit):

1:47 AM Changeset in webkit [127844] by annacc@chromium.org

3 edits
1 delete in trunk/LayoutTests

Rebaselines for windows due to r127831.

Unreviewed gardening.

platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:

1:46 AM Changeset in webkit [127843] by yosin@chromium.org

6 edits in trunk/Source

We should have a localized string of empty for date time field
https://bugs.webkit.org/show_bug.cgi?id=96081

Reviewed by Kent Tamura.

Source/Platform:

This patch adds a localized string enum field for empty field value
description text for accessibility support in multiple fields date
time related input types for Chromium ports.

chromium/public/WebLocalizedString.h: Added AXDateTimeFieldEmptyValueText

enum field.

Source/WebCore:

This patch add a declaration of function for getting localized string
of empty field value date time field for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

platform/LocalizedStrings.h:

(WebCore): Added a declaration of AXDateTimeFieldEmptyValueText().

Source/WebKit/chromium:

This patch add a function for getting localized string of empty field
value of date time fields for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

src/LocalizedStrings.cpp:

(WebCore::AXDateTimeFieldEmptyValueText): Added.

1:28 AM Changeset in webkit [127842] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs to enable or disable the mouse events of the ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=88631

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

We can turn on/off the mouse events of the ewk_view using the mouse
events enabling API. This API can be used when we want to turn off the
mouse events on the touchscreen device to process the touch events
instead of the mouse events.

UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_smart_add):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):

UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

1:19 AM Changeset in webkit [127841] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebCore

[EFL] Use ASCIILiteral for cursorStringMap.
https://bugs.webkit.org/show_bug.cgi?id=96072

Reviewed by Gyuyoung Kim.

This patch converts static strings of cursorStringMap to use ASCIILiteral
as recommended by http://trac.webkit.org/wiki/EfficientStrings.

platform/efl/EflScreenUtilities.cpp:

(WebCore::CursorMap::CursorMap):

1:08 AM Changeset in webkit [127840] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Scrolling performance logging should use WTFLogAlways instead of printf
https://bugs.webkit.org/show_bug.cgi?id=96080

Reviewed by Dan Bernstein.

Use WTF logging facilities instead of printf() for scrolling performance logging.

page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::logExposedUnfilledArea):

platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer logFilledFreshTile]):

12:56 AM Changeset in webkit [127839] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/efl

[EFL] Support the permission function of the Web Notification.
https://bugs.webkit.org/show_bug.cgi?id=90603

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

Implement permission related functions of Web Notifications.
checkPermission for Notification.permissionLevel().
requestPermission for Notification.requestPermission().
In addition, if the application(like a browser) has permitted domains already,
it can be cached using ewk_view_notification_permissions_store.

WebCoreSupport/NotificationPresenterClientEfl.cpp:

WebCoreSupport/NotificationPresenterClientEfl.h:

(WebCore):
(NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_notification_permission_store):
(ewk_view_notification_permissions_set):
(ewk_view_notification_permission_request):

ewk/ewk_view.h:
ewk/ewk_view_private.h:

12:48 AM Changeset in webkit [127838] by macpherson@chromium.org

4 edits in trunk/Source/WebCore

Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
https://bugs.webkit.org/show_bug.cgi?id=95938

Reviewed by Andreas Kling.

Several unit types have been added without updating the cleanup function, including CSS_VARIABLE_NAME.
I've added all the existing unit types back in and cast m_primitiveUnitType (a bitfield in CSSValue)
to the enum type to ensure the compiler catches any future errors.

No test added, but switch made to use enum type so we can't accidentally fail to update this function again.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cleanup):

12:45 AM Changeset in webkit [127837] by timothy_horton@apple.com

16 edits in trunk/Source

Add optional debug logging when we fall into/out of threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898
<rdar://problem/12089098>

Reviewed by Simon Fraser.

Add logging when we enter and exit the threaded scrolling mode, and logs the reasons we
fall into main-thread scrolling.

The logging output looks like this:

SCROLLING: Switching to main-thread scrolling mode. Time: 15843.554718 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15844.550866
SCROLLING: Switching to main-thread scrolling mode. Time: 15845.551214 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15846.552619
SCROLLING: Switching to main-thread scrolling mode. Time: 15847.553587 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15848.554084

No new tests, as this is just debugging logging.

WebCore.xcodeproj/project.pbxproj:

Expose ScrollingTreeState.h as a private header.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):

page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThreadReason):
(ScrollingTreeNode):

page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):
Rename updateShouldUpdateScrollLayerPositionOnMainThread to updateShouldUpdateScrollLayerPositionOnMainThreadReason (and related).

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerViewportConstrainedObjects):
Renamed from hasNonLayerFixedObjects to match the rest of the renames going on.
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThreadReason):
Construct a bitfield describing the reasons we fall into main-thread scrolling mode.

page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):
Add ReasonsForUpdatingScrollLayerPositionOnMainThread enum, with the current reasons that we might fallback to main-thread scrolling.

page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore):
(WebCore::ScrollingTreeNodeMac::update): Log every time scrolling mode changes.
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::logThreadedScrollingMode): Pretty-print the scrolling mode and shouldUpdateScrollLayerPositionOnMainThreadReason.

Update the scrolling tree's scrollingPerformanceLoggingEnabled preference
before the early-return if we don't have layer debugging borders on.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

12:04 AM Changeset in webkit [127836] by annacc@chromium.org

10 edits
1 add in trunk/LayoutTests

Rebaselines due to r127831.

Unreviewed gardening.

platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt:
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:

12:03 AM Changeset in webkit [127835] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Build fix for WinCE after r127801.

platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

Sep 6, 2012:

11:29 PM Changeset in webkit [127834] by zandobersek@gmail.com

4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for two MathML tests after r127769.

Removing failure expectations for tests fixed by changes in r127798,
rollout in r127774 and rebaseline in r127825.

platform/gtk/TestExpectations:
platform/gtk/mathml/presentation/roots-expected.txt:
platform/gtk/mathml/presentation/sup-expected.txt:

11:26 PM Changeset in webkit [127833] by apavlov@chromium.org

3 edits in trunk/Source/WebCore

[Chromium] Regression: Web Inspector tool-tips pixellated with --force-device-scale-factor=2
https://bugs.webkit.org/show_bug.cgi?id=95875

Reviewed by Vsevolod Vlasov.

The overlay canvas is scaled according to the actual devicePixelRatio of the inspected page, while retaining its original CSS size.

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::reset):

inspector/InspectorOverlayPage.html:

11:15 PM Changeset in webkit [127832] by loislo@chromium.org

18 edits in trunk/Source

Unreviewed, rolling out r127822.
http://trac.webkit.org/changeset/127822
https://bugs.webkit.org/show_bug.cgi?id=96073

It broke compilation on chromium debug bots (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):
(WebCore::CCRenderPass::copy):

platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::copy):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(WebCore):
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

tests/CCDrawQuadTest.cpp:

(WebCore::TEST):

tests/CCLayerTreeHostImplTest.cpp:
tests/CCLayerTreeHostTest.cpp:
tests/CCRenderPassTest.cpp:

(WebCore::TEST):

tests/CCRenderSurfaceTest.cpp:
tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

10:59 PM Changeset in webkit [127831] by annacc@chromium.org

5 edits in trunk/Source/WebCore

The CC button should have chrome-specific rendering for Mac.
https://bugs.webkit.org/show_bug.cgi?id=95981

Reviewed by Eric Carlson.

This patch allows RenderThemeChromiumMac to define its own behavior for the CC button.

No new tests. Button should display graphics from chromium resources.

css/mediaControlsChromium.css:

(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
Adjust styling for the chromium graphics.

rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaClosedCaptionsButton):
Check whether closed captions are visible to decide how to draw the button.

rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Override the paint function for the CC button.

rendering/RenderThemeChromiumMac.mm:

(WebCore):
(WebCore::RenderThemeChromiumMac::paintMediaToggleClosedCaptionsButton):
Call the chromium-specific painting function.

10:54 PM Changeset in webkit [127830] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[Tests] Skip Dialog element tests on Win
https://bugs.webkit.org/show_bug.cgi?id=96051

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-09-06
Reviewed by Hajime Morita.

Dialog is not yet enabled except on Chromium. Dialog tests should have
been added to the Win port's skipped list as part of r122420.

platform/win/Skipped:

10:53 PM Changeset in webkit [127829] by mhahnenberg@apple.com

6 edits in trunk/Source/JavaScriptCore

JSC should have a zombie mode
https://bugs.webkit.org/show_bug.cgi?id=96047

Reviewed by Geoffrey Garen.

To aid clients of JSC while they are debugging memory issues, we should add a zombie
mode that scribbles into objects in the MarkedSpace after they are found to be dead
to prevent a sort of "use after free" situation. As a first cut we should support a
mode that just scribbles on objects prior to their being reused (i.e. while they are
"zombies") and a mode in which, in addition to scribbling on zombies, once an object
has been marked its mark bit will never be cleared, thus giving us "immortal" zombies.

These two modes will be enabled through the use of environment variables. For now these
will be "JSZombieEnabled" and "JSImmortalZombieEnabled". Setting them to any value will
result in the use of the appropriate mode.

heap/Heap.cpp:

(JSC::Heap::collect): Zombifies dead objects at the end of collection if zombie mode is enabled.
(ZombifyCellFunctor):
(JSC::ZombifyCellFunctor::ZombifyCellFunctor): Sets marked bits for dead objects if in immortal mode and writes 0xbbadbeef into them.
(JSC::ZombifyCellFunctor::operator()):
(JSC):
(ZombifyBlockFunctor):
(JSC::ZombifyBlockFunctor::operator()):
(JSC::Heap::zombifyDeadObjects): Eagerly sweeps so that we don't write garbage into an object before it
is finalized/destroyed.

heap/Heap.h:

(Heap):

heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::forEachDeadCell): Used to iterate over dead cells at the end of collection if zombie mode is enabled.
(JSC):

runtime/Options.cpp:

(JSC::Options::initialize):

runtime/Options.h:

(JSC):

10:34 PM Changeset in webkit [127828] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit2

Deploy StringBuilder in more places in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=95924

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-06
Reviewed by Benjamin Poulain.

Deploy StringBuilder to concatenate strings more efficiently.

Shared/WebMemorySampler.cpp:

(WebKit):
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::stop):
(WebKit::WebMemorySampler::writeHeaders):
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

Shared/WebMemorySampler.h:

(WebMemorySampler):

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::capitalizeRFC822HeaderFieldName):

WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

10:32 PM Changeset in webkit [127827] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

REGRESSION(127810): It broke inspector/debugger/debugger-expand-scope.html
https://bugs.webkit.org/show_bug.cgi?id=96065

Unreviewed, reverting the expected file change.

inspector/debugger/debugger-expand-scope-expected.txt:

10:22 PM Changeset in webkit [127826] by commit-queue@webkit.org

9 edits
2 adds in trunk

Add methods to CounterDirectives to clean up StyleBuilder and RenderCounter.
https://bugs.webkit.org/show_bug.cgi?id=94587

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-06
Reviewed by Julien Chaffraix.

Source/WebCore:

Adds several methods to CounterDirectives and an accessor method to RenderStyle for
getting the CounterDirectives by idenfitier and uses those methods to clean up
the code in StyleBuilder and RenderCounter. This also switches to using AtomicString
directly instead of AtomicStringImpl and calling get() everywhere.

The refactor fixes the unitialized read in WKBug 94642.

Test: fast/css/counters/counter-reset-inherit-bug-94642.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue): Use new accessors.

css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue): Use new inherit methods.
(WebCore::ApplyPropertyCounter::applyValue): Use new setters.

rendering/RenderCounter.cpp:

(WebCore):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):

rendering/style/CounterDirectives.cpp:

(WebCore::operator==):

rendering/style/CounterDirectives.h: Added new accessors and switched to using AtomicString directly.

(CounterDirectives):
(WebCore::CounterDirectives::CounterDirectives):
(WebCore::CounterDirectives::isReset):
(WebCore::CounterDirectives::resetValue):
(WebCore::CounterDirectives::setResetValue):
(WebCore::CounterDirectives::clearReset):
(WebCore::CounterDirectives::inheritReset):
(WebCore::CounterDirectives::isIncrement):
(WebCore::CounterDirectives::incrementValue):
(WebCore::CounterDirectives::addIncrementValue):
(WebCore::CounterDirectives::clearIncrement):
(WebCore::CounterDirectives::inheritIncrement):
(WebCore::CounterDirectives::isDefined): If either reset or increment is used.
(WebCore::CounterDirectives::combinedValue): Combined local value of the counter.
(WebCore):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCounterDirectives): New method which always returns a CounterDirectives instance by identifier.
(WebCore):

rendering/style/RenderStyle.h:

LayoutTests:

Tests for bug 94642 exposing an unitialized read when using counter-reset and
counter-increment: inherit.

fast/css/counters/counter-reset-inherit-bug-94642-expected.html: Added.
fast/css/counters/counter-reset-inherit-bug-94642.html: Added.

10:09 PM Changeset in webkit [127825] by commit-queue@webkit.org

4 edits in trunk

[Gtk] accessibility/canvas-description-and-role expected results needed
https://bugs.webkit.org/show_bug.cgi?id=95644

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-06
Reviewed by Martin Robinson.

Source/WebCore:

The new accessibility CanvasRole should be mapped to ATK_ROLE_CANVAS
rather than ATK_ROLE_IMAGE.

No new test because the CanvasRole came with a new layout test lacking
expected results for Gtk. The generated expected results for that test
reflect the revised mapping to ATK_ROLE_CANVAS.

accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

Generated expected results for Gtk. These results reflect the revised
mapping of CanvasRole to ATK_ROLE_CANVAS rather than ATK_ROLE_IMAGE.

platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.

10:03 PM Changeset in webkit [127824] by hbono@chromium.org

4 edits in trunk/Source

A build fix for Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=96062

Reviewed by James Robinson.

Source/Platform:

This change fixes a build break on Chromium Windows (debug) caused by r127796
<http://trac.webkit.org/changeset/127796>. It removes a redundant WEBKIT_EXPORT.

chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

This change fixes a build break on Chromium Windows caused by r127801
<http://trac.webkit.org/changeset/127801>. It replaces characters() with
characters16().

No new tests because this change is a build fix.

platform/graphics/chromium/UniscribeHelperTextRun.cpp:

(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):

10:00 PM Changeset in webkit [127823] by ryuan.choi@samsung.com

4 edits
2 adds in trunk/Source/WebKit2

[EFL][WK2] Add API unit tests for ewk_view_theme_set.
https://bugs.webkit.org/show_bug.cgi?id=94670

Reviewed by Gyuyoung Kim.

Added unit tests for ewk_view_theme_set.

UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::pathForResource):
Added to get path of resource.

UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:

Ditto.

UIProcess/API/efl/tests/resources/big_button_theme.edj:

Added test theme file which has text_confinement of button as
rel1 { ... offset : 150 8; } rel2 { ... offset : -150 -11; }.

UIProcess/API/efl/tests/resources/empty_theme.edj:

Added test theme file which includes nothing.

UIProcess/API/efl/tests/test_ewk2_view.cpp:

Added unit test for ewk_view_theme_set.

9:49 PM Changeset in webkit [127822] by danakj@chromium.org

18 edits in trunk/Source

[chromium] Make RenderPass ids hold both generating layer id and an index
https://bugs.webkit.org/show_bug.cgi?id=95500

Reviewed by Adrienne Walker.

Source/WebCore:

Covered by existing tests.

platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

platform/graphics/chromium/cc/CCRenderPass.h:

platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::renderPassId):
(WebCore):
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:
tests/CCLayerTreeHostTest.cpp:
tests/CCRenderSurfaceTest.cpp:
tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

9:48 PM Changeset in webkit [127821] by msaboff@apple.com

2 edits in trunk/Source/WTF

StringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents
https://bugs.webkit.org/show_bug.cgi?id=96029

Reviewed by Benjamin Poulain.

Added 8 bit path when creating an AtomicString from a partial 8 bit buffer.

wtf/text/StringBuilder.h:

(WTF::StringBuilder::toAtomicString):

9:39 PM Changeset in webkit [127820] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[chromium] Do not delete texture backing structures on the main thread
https://bugs.webkit.org/show_bug.cgi?id=96018

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Do not delete CCPrioritizedTexture::Backing structures on the main
thread. Instead, unlink them from their owning CCPrioritizedTexture
in the main thread, and have the impl thread then delete all unlinked
textures.

This is towards having the main thread not access the m_backings set,
which will allow the impl thread to traverse that set when deleting
resources in response to GPU memory management events.

Tested by existing eviction tests (CCLayerTreeHostTest's
TestEvictTextures, LostContextAfterEvictTextures)

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::unlinkAllContentTextures):
(WebCore):
(WebCore::CCLayerTreeHost::deleteUnlinkedTextures):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::unlinkAllBackings):
(WebCore):
(WebCore::CCPrioritizedTextureManager::deleteAllUnlinkedBackings):

platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

9:37 PM Changeset in webkit [127819] by Simon Hausmann

2 edits in trunk/Source/WebCore

[Qt] Fix debug Windows build
https://bugs.webkit.org/show_bug.cgi?id=96008

Reviewed by Tor Arne Vestbø.

Add a few more files to the AllInOne configuration to reduce the number of object files
and their total size, allowing a debug build with MSVC again.

Target.pri:

9:21 PM Changeset in webkit [127818] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Fix text encoding detecting
https://bugs.webkit.org/show_bug.cgi?id=96014

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Since we rely on ICU now, we might as well use the actually implemented text encoding
detector instead of the dummy "none" one.

I could not locate any layout tests that actually cover this :(

Target.pri:

9:18 PM Changeset in webkit [127817] by commit-queue@webkit.org

4 edits
2 adds in trunk/Source/WebKit

[BlackBerry] Implement a color picker
https://bugs.webkit.org/show_bug.cgi?id=96001

Patch by Crystal Zhang <haizhang@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Source/WebKit:

Add color picker files into building system.

PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Add files for color picker, replace old hook to AIR color picker.

WebCoreSupport/ColorPickerClient.cpp: Added.

(WebCore):
(WebCore::ColorPickerClient::ColorPickerClient):
(WebCore::ColorPickerClient::~ColorPickerClient):
(WebCore::ColorPickerClient::generateHTML):
(WebCore::ColorPickerClient::closePopup):
(WebCore::ColorPickerClient::contentSize):
(WebCore::ColorPickerClient::htmlSource):
(WebCore::ColorPickerClient::setValueAndClosePopup):
(WebCore::ColorPickerClient::didClosePopup):
(WebCore::ColorPickerClient::writeDocument):

WebCoreSupport/ColorPickerClient.h: Added.

(WebKit):
(WebCore):
(ColorPickerClient):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openColorPopup):

9:14 PM Changeset in webkit [127816] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017

Unreviewed Qt-WK2 buildfix after r127783.

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::syncFixedLayers):

8:35 PM Changeset in webkit [127815] by yosin@chromium.org

6 edits in trunk/Source

We should have localized strings of date time fields for accessibility
https://bugs.webkit.org/show_bug.cgi?id=96050

Reviewed by Kent Tamura.

Source/Platform:

This patch adds localized string enum fields for accessibility support
in multiple fields date time related input types for Chromium ports.

chromium/public/WebLocalizedString.h: Adds AXAMPMFieldText, AXDayOfMonthField,

AXHourFieldText, AXMillisecondFieldText, AXMinuteFieldText, AXMonthField,
AXSecondFieldText, AXWeekOfYearFieldText, and AXYearFieldText.

Source/WebCore:

This patch adds declarations of function for getting localized string
of date time field for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

platform/LocalizedStrings.h:

(WebCore): Added declarations of AXAMPMFieldText(), AXDayOfMonthFieldText(),
AXHourFieldText(), AXMillisecondFieldText(), AXMinuteFieldText(), AXMonthFieldText(),
AXSecondFieldText(), AXWeekOfYearFieldText(), and AXYearFieldText().

Source/WebKit/chromium:

This patch adds functions for getting localized strings of date time
fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

src/LocalizedStrings.cpp:

(WebCore::AXAMPMFieldText): Added.
(WebCore::AXDayOfMonthFieldText): Added.
(WebCore::AXHourFieldText): Added.
(WebCore::AXMillisecondFieldText): Added.
(WebCore::AXMinuteFieldText): Added.
(WebCore::AXMonthFieldText): Added.
(WebCore::AXSecondFieldText): Added.
(WebCore::AXWeekOfYearFieldText): Added.
(WebCore::AXYearFieldText): Added.

8:17 PM Changeset in webkit [127814] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r127808.
http://trac.webkit.org/changeset/127808
https://bugs.webkit.org/show_bug.cgi?id=96057

geoff rolled back in his change, but not this part (Requested
by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

inspector/debugger/debugger-expand-scope-expected.txt:

7:45 PM Changeset in webkit [127813] by commit-queue@webkit.org

3 edits
2 adds
26 deletes in trunk/LayoutTests

fast/table/empty-row-crash.html and fast/table/inline-form-assert.html should be dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=95613

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-09-06
Reviewed by Julien Chaffraix.

Modified the test cases empty-row-crash.html and inline-form-assert.html to dumpAsText tests.
As the testcases check for crash/assert and not for the correctness of content layout or painting
they can be safely modified to dumpAsText tests.

fast/table/empty-row-crash-expected.txt: Added. New expected file.
fast/table/empty-row-crash.html: Added a short description about the testcase.

fast/table/inline-form-assert-expected.txt: Added. New expected file.
fast/table/inline-form-assert.html:

platform/chromium-linux/fast/table/empty-row-crash-expected.png: Removed.
platform/chromium-linux/fast/table/inline-form-assert-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/table/empty-row-crash-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/table/inline-form-assert-expected.png: Removed.
platform/chromium-mac/fast/table/empty-row-crash-expected.png: Removed.
platform/chromium-mac/fast/table/inline-form-assert-expected.png: Removed.
platform/chromium-win/fast/table/empty-row-crash-expected.png: Removed.
platform/chromium-win/fast/table/empty-row-crash-expected.txt: Removed.
platform/chromium-win/fast/table/inline-form-assert-expected.png: Removed.
platform/chromium-win/fast/table/inline-form-assert-expected.txt: Removed.
platform/efl/fast/table/empty-row-crash-expected.png: Removed.
platform/efl/fast/table/empty-row-crash-expected.txt: Removed.
platform/efl/fast/table/inline-form-assert-expected.png: Removed.
platform/efl/fast/table/inline-form-assert-expected.txt: Removed.
platform/gtk/fast/table/empty-row-crash-expected.png: Removed.
platform/gtk/fast/table/empty-row-crash-expected.txt: Removed.
platform/gtk/fast/table/inline-form-assert-expected.png: Removed.
platform/gtk/fast/table/inline-form-assert-expected.txt: Removed.
platform/mac/fast/table/empty-row-crash-expected.png: Removed.
platform/mac/fast/table/empty-row-crash-expected.txt: Removed.
platform/mac/fast/table/inline-form-assert-expected.png: Removed.
platform/mac/fast/table/inline-form-assert-expected.txt: Removed.
platform/qt/fast/table/empty-row-crash-expected.png: Removed.
platform/qt/fast/table/empty-row-crash-expected.txt: Removed.
platform/qt/fast/table/inline-form-assert-expected.png: Removed.
platform/qt/fast/table/inline-form-assert-expected.txt: Removed. Removed obsolete baselines.

7:43 PM Changeset in webkit [127812] by tony@chromium.org

4 edits in trunk/Source/WebCore

Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const
https://bugs.webkit.org/show_bug.cgi?id=95907

Reviewed by Ojan Vafai.

This is refactoring to make RenderBox::computeLogicalWidth const. Make some methods that
get called by computeLogicalWidth const. We path in a struct that we populate with values.

No new tests, this is just a refactoring.

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion): Make a LogicalExtentComputedValues to
hold results.
(WebCore::RenderBox::computePositionedLogicalWidth): Make const.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Change output to use LogicalExtentComputedValues
instead of 4 separate params.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Make const.

rendering/RenderBox.h:

(RenderBox): Add const and change out params to LogicalExtentComputedValues.

rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth): Make a LogicalExtentComputedValues to
hold results.

7:25 PM Changeset in webkit [127811] by morrita@google.com

5 edits in trunk/Source/WebCore

[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
https://bugs.webkit.org/show_bug.cgi?id=95831

Reviewed by Dimitri Glazkov.

Originally, the availability of author shadows was decided by ShadowRoot class.
This change moves that responsibility to each Element subclasses to make future
author shadow support improvement local to each replaced elements, rather than
touching ShadowRoot.cpp for reach.

No new tests. Should have no behavioral change.

dom/Element.h:
dom/ShadowRoot.cpp:

(WebCore::allowsAuthorShadowRoot):

html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

svg/SVGElement.h:

(SVGElement):

6:42 PM Changeset in webkit [127810] by ggaren@apple.com

17 edits
2 adds in trunk

Source/JavaScriptCore: Rolled back in <http://trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html, which
is to make sure that function declarations don't put their names in scope.

Reviewed by Gavin Barraclough.

Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

LayoutTests: Rolled back in <http://trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Added a more explicit test for the feature I broke in
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Reviewed by Gavin Barraclough.

Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

fast/dom/HTMLScriptElement/script-reexecution.html:
fast/js/function-name-is-in-scope-expected.txt: Added.
fast/js/function-name-is-in-scope.html: Added.

6:29 PM Changeset in webkit [127809] by msaboff@apple.com

4 edits in trunk/Source

16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
https://bugs.webkit.org/show_bug.cgi?id=95810

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Added 8 bit path that copies the contents of an 8 bit fiber to the 16 bit buffer
when resolving a 16 bit rope.

runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeSlowCase):

Source/WTF:

New copy routine that takes an 8 bit source and a 16 bit destination. Used when copying
the contents of an 8 bit fiber to the 16 bit buffer when resolving a 16 bit rope.

wtf/text/StringImpl.h:

(WTF::StringImpl::copyChars):
(StringImpl):

6:29 PM Changeset in webkit [127808] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Unreviewed, revert part of http://trac.webkit.org/changeset/127698
which accidentally didn't get reverted in
http://trac.webkit.org/changeset/127774.

inspector/debugger/debugger-expand-scope-expected.txt:

6:16 PM Changeset in webkit [127807] by commit-queue@webkit.org

2 edits
1 delete in trunk/LayoutTests

[Qt] Unskip two encoding tests that pass now
https://bugs.webkit.org/show_bug.cgi?id=96013

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

The result for frame-default-enc was incorrect and we succeed in
producing the existing cross-platform result. The other test passes
just fine.

platform/qt/Skipped:
platform/qt/fast/encoding/frame-default-enc-expected.txt: Removed.

5:57 PM Changeset in webkit [127806] by abarth@webkit.org

64 edits in trunk/Source/WebCore

[V8] Weave creationContext through toV8 and related functions
https://bugs.webkit.org/show_bug.cgi?id=96039

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Eric Seidel.

In order to give DOM wrappers the correct prototype chain, we need to
know what the creationContext ought to be for each wrapper. This patch
weaves that information through toV8 and related functions.

This patch doesn't yet use the information. That will take place in a
separate patch. For that reason, this patch should not have any
behavior change.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::callFunction):

bindings/v8/IDBCustomBindings.cpp:

(WebCore::V8IDBCursorWithValue::valueAccessorGetter):

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8Binding.h:

(WebCore::V8ValueTraits::arrayV8Value):

bindings/v8/V8Collection.h:

(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

bindings/v8/V8ThrowException.cpp:

(WebCore):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):
(WebCore::V8Blob::constructorCallback):

bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):

bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::memoryAccessorGetter):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::toV8):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::toV8):
(WebCore::V8Document::createTouchListCallback):

bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore):
(WebCore::toV8):

bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::getNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
(WebCore::toV8):

bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):
(WebCore::V8HTMLElement::itemValueAccessorGetter):

bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

bindings/v8/custom/V8HTMLOutputElementCustom.cpp:

(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):

bindings/v8/custom/V8PerformanceCustom.cpp:

(WebCore):
(WebCore::V8Performance::memoryAccessorGetter):

bindings/v8/custom/V8PerformanceEntryCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

5:43 PM Changeset in webkit [127805] by msaboff@apple.com

2 edits in trunk/Source/WTF

Unreviewed fix to r127799.
https://bugs.webkit.org/show_bug.cgi?id=95807

Unreviewed fix.

Removed extraneous "static". This code is hidden behind STRING_STATS define and
therefore is not enabled by default.

wtf/text/StringImpl.cpp:

5:36 PM Changeset in webkit [127804] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

[EFL] 2 mathml tests need rebaseline after r127769
https://bugs.webkit.org/show_bug.cgi?id=96009

Unreviewed EFL gardening.

Update baselines for 2 mathml test cases needed after
r127769.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

platform/efl/mathml/presentation/roots-expected.png:
platform/efl/mathml/presentation/roots-expected.txt:
platform/efl/mathml/presentation/sup-expected.png:
platform/efl/mathml/presentation/sup-expected.txt:

5:21 PM Changeset in webkit [127803] by tony@chromium.org

2 edits in trunk/LayoutTests

Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Reviewed by Adam Barth.

Skip platform/chromium-linux/compositing/gestures tests on the
Chromium Linux EWS and CQ bots. By marking them as flaky, they won't
be run (the bots use --skip-failing-tests which causes them to skip
these tests). These will still run on the waterfall bots.

platform/chromium/TestExpectations:

4:54 PM Changeset in webkit [127802] by commit-queue@webkit.org

4 edits in trunk/Source

[Qt] Deprecate String += operator
https://bugs.webkit.org/show_bug.cgi?id=95895

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Source/WebCore:

Replaced String +=() with append.

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::extraMediaControlsStyleSheet):

Source/WTF:

Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard.

wtf/Platform.h:

4:52 PM Changeset in webkit [127801] by msaboff@apple.com

17 edits in trunk/Source/WebCore

Add 8 bit string data path to TextRun
https://bugs.webkit.org/show_bug.cgi?id=95812

Reviewed by Dan Bernstein.

Added 8 bit string path to TextRun. Refactored TextRun::data() and ::characters into
8 and 16 bit versions. Made corresponding changes to users of TextRun.
For efl, gtk, qt and win platform specific code using TextRun, only the methods have
been renamed and the creation of 8 bit TextRuns has been disabled via compilation
flags. Someone knowledgeable in those platforms will need to make corresponding changes
to enable 8 bit processing of TextRuns.

No changes to functionality - behavior covered by existing tests.

platform/graphics/Font.cpp:

(WebCore::normalizeSpacesInternal):
(WebCore::Font::normalizeSpaces):
(WebCore::Font:normalizeSpaces):
(WebCore::Font::codePath):
(WebCore::Font::expansionOpportunityCount):

platform/graphics/Font.h:

(WebCore::Font::characterRangeCodePath):
(WebCore::Font::normalizeSpaces):

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawBidiText):

platform/graphics/TextRun.cpp:

(ExpectedTextRunSize):

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::subRun):
(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):
(WebCore::TextRun::characters8):
(WebCore::TextRun::characters16):
(WebCore::TextRun::is8Bit):
(WebCore::TextRun::setText):
(WebCore::TextRun::setCharactersLength):

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advance):

platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):

platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::collectComplexTextRuns):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

platform/graphics/pango/FontPango.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):

rendering/RenderText.cpp:

(WebCore::RenderText::computeCanUseSimpleFontCodePath):

rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics):

rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

4:50 PM Changeset in webkit [127800] by jamesr@google.com

5 edits in trunk/Source

[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
https://bugs.webkit.org/show_bug.cgi?id=96024

Reviewed by Adam Barth.

When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
We don't need to link anything in to WebKit.dll.

Source/WebCore:

WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

WebKit.gyp:

4:41 PM Changeset in webkit [127799] by msaboff@apple.com

3 edits in trunk/Source/WTF

ENH: Add Logging to StringImpl to track String Types
https://bugs.webkit.org/show_bug.cgi?id=95807

Reviewed by Benjamin Poulain.

Added StringsStats class that keeps track of the number of strings, number of 8 and 16 bit
strings as well as the number of 8 bit strings up converted to 16 bits. The number of characrters
for each type is also accumulated. These statistics are output via DataLog every 5000
calls to StringImpl destructor. The 5000 can be adjusted via s_printStringStatsFrequency.
This StringStats code is disabled by default and enabled by defining STRING_STATS in
wtf/text/StringImpl.h.

wtf/text/StringImpl.cpp:

(WTF::StringStats::removeString):
(WTF::StringStats::printStats):
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::getData16SlowCase):

wtf/text/StringImpl.h:

(WTF::StringStats::add8BitString):
(StringStats):
(WTF::StringStats::add16BitString):
(WTF::StringStats::addUpconvertedString):
(WTF::StringImpl::StringImpl):
(StringImpl):
(WTF::StringImpl::isSubString):
(WTF::StringImpl::stringStats):

4:40 PM Changeset in webkit [127798] by abarth@webkit.org

4 edits in trunk/LayoutTests

New tests introduced in r127704 fail
https://bugs.webkit.org/show_bug.cgi?id=95952

Reviewed by Dan Bernstein.

Use the testRunner rather than layoutTestController because
layoutTestControler doesn't exist anymore.

fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:

4:23 PM Changeset in webkit [127797] by barraclough@apple.com

4 edits in trunk/Source/JavaScriptCore

JS test suite puts incorrect limitations on Function.toString()
https://bugs.webkit.org/show_bug.cgi?id=3975

Reviewed by Geoff Garen.

The result of function toString is implementation defined;
these test cases were looking for specific whitespace formatting
that matches mozilla's, and for redundant braces to be inserted
around if/else blocks. Stop that.

tests/mozilla/expected.html:
tests/mozilla/js1_2/function/tostring-1.js:

(simplify):

reduce whitespace differences

tests/mozilla/js1_2/function/tostring-2.js:

(simplify):

reduce whitespace differences

(TestOr):
(TestAnd):

added braces to match expected output

4:21 PM Changeset in webkit [127796] by jamesr@google.com

2 edits in trunk/Source/Platform

[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=96025

Reviewed by Adrienne Walker.

chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

4:21 PM Changeset in webkit [127795] by Simon Fraser

9 edits
2 adds in trunk/Source/WebCore

Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=96026

Reviewed by James Robinson.

Lay some groundwork for threaded scrolling with fixed position and sticky
position objects, by packaging up logic related to how to reposition
fixed and sticky things on viewport changes into "constraints" classes.

ScrollingConstraints contains a 'ViewportConstraints' base class
that is subclassed for sticky position. These classes store
data about the constraints that govern the position of an object outside
of the render tree, and know how to compute a new position when the
viewport changes using only data in the class.

This patch changes RenderBoxModelObject to use the StickyPositionViewportConstraints
class for computing stick offsets at layout time. In the future, we'll have
the scrolling tree store copies of the constraint data for threaded scrolling.

CMakeLists.txt: Add ScrollingConstraints.* to the build.
GNUmakefile.list.am: Ditto
Target.pri: Ditto
WebCore.gypi: Ditto
WebCore.vcproj/WebCore.vcproj: Ditto
WebCore.xcodeproj/project.pbxproj: Ditto
page/scrolling/ScrollingConstraints.cpp: Added.

(WebCore::StickyPositionViewportConstraints::computeStickyOffset):
(WebCore::StickyPositionViewportConstraints::layerPositionForViewportRect):

page/scrolling/ScrollingConstraints.h: Added.

(WebCore::ViewportConstraints::ViewportConstraints):
(WebCore::ViewportConstraints::~ViewportConstraints):
(WebCore::ViewportConstraints::anchorEdges):
(WebCore::ViewportConstraints::hasAnchorEdge):
(WebCore::ViewportConstraints::addAnchorEdge):
(WebCore::ViewportConstraints::alignmentOffset):
(WebCore::ViewportConstraints::setAlignmentOffset):
(StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::stickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setStickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::layerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setLayerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::leftOffset):
(WebCore::StickyPositionViewportConstraints::rightOffset):
(WebCore::StickyPositionViewportConstraints::topOffset):
(WebCore::StickyPositionViewportConstraints::bottomOffset):
(WebCore::StickyPositionViewportConstraints::setLeftOffset):
(WebCore::StickyPositionViewportConstraints::setRightOffset):
(WebCore::StickyPositionViewportConstraints::setTopOffset):
(WebCore::StickyPositionViewportConstraints::setBottomOffset):
(WebCore::StickyPositionViewportConstraints::setAbsoluteContainingBlockRect):
(WebCore::StickyPositionViewportConstraints::setAbsoluteStickyBoxRect):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints): Fill out
data in the supplied StickyPositionViewportConstraints instance.
(WebCore::RenderBoxModelObject::stickyPositionOffset): Create a
StickyPositionViewportConstraints object on the stack and use it to
compute the sticky offset.

rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

4:17 PM Changeset in webkit [127794] by jamesr@google.com

26 edits
1 add in trunk

[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
https://bugs.webkit.org/show_bug.cgi?id=96007

Reviewed by Adrienne Walker.

Source/Platform:

Updates comment to reference WebCompositorSupport instead of WebCompositor.

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Calls WebCompositorSupport functions instead of WebCompositor statics.

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

Source/WebKit/chromium:

Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
WebCompositorInitializer RAII class to simplify this somewhat tedious process.

WebKit.gypi:
public/WebCompositorInputHandlerClient.h:

(WebCompositorInputHandlerClient):

src/WebCompositorInputHandlerImpl.h:
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::scheduleComposite):

tests/CCPrioritizedTextureTest.cpp:

(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(CCPrioritizedTextureTest):

tests/CCRendererGLTest.cpp:

(CCRendererGLTest::CCRendererGLTest):
(CCRendererGLTest::SetUp):
(CCRendererGLTest):

tests/CCTextureUpdateControllerTest.cpp:
tests/CCThreadedTest.cpp:

(WebKitTests::CCThreadedTest::runTest):

tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):

tests/LayerChromiumTest.cpp:
tests/LinkHighlightTest.cpp:

(WebCore::TEST):

tests/TextureLayerChromiumTest.cpp:
tests/TiledLayerChromiumTest.cpp:
tests/WebCompositorInitializer.h: Added.

(WebKit):
(WebKitTests):
(WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):

tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::TEST):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):

tests/WebLayerTest.cpp:
tests/WebLayerTreeViewTest.cpp:

Tools:

Fixes initialization / settings code to use WebCompositorSupport.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::setPerTilePaintingEnabled):

4:17 PM Changeset in webkit [127793] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
https://bugs.webkit.org/show_bug.cgi?id=95995

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Provide proper implementation for PlatformWebView::windowFrame()
in EFL's WebKitTestRunner.

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::windowFrame):

4:16 PM Changeset in webkit [127792] by jamesr@google.com

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

DEPS:

4:14 PM Changeset in webkit [127791] by commit-queue@webkit.org

4 edits in trunk/Source

IndexedDB: make IDBKeyPath's string and array constructors explicit
https://bugs.webkit.org/show_bug.cgi?id=96004

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Source/WebCore:

Making these explicit to avoid accidental implicit conversions.

No new tests, existing tests cover correctness.

Modules/indexeddb/IDBKeyPath.h:

(IDBKeyPath):

Source/WebKit/chromium:

Fix test to use explicit constructor for IDBKeyPath.

tests/IDBDatabaseBackendTest.cpp:

3:48 PM Changeset in webkit [127790] by enne@google.com

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96002

Reviewed by James Robinson.

This is a compositor unit test, so it shouldn't reference things
outside of the compositor like GraphicsContext. The
OpaqueRectTrackingContentLayerDelegateTest already tests opaque
tracking right at the time of paint. This test is about verifying that
transformed canvases work properly, so can just fake the opaque rect
coming back from the paint.

tests/ContentLayerChromiumTest.cpp:

(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

3:23 PM Changeset in webkit [127789] by commit-queue@webkit.org

17 edits in trunk/Source

[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=95094

Patch by Jeff Timanus <twiz@chromium.org> on 2012-09-06
Reviewed by Adrienne Walker.

Source/Platform:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
contentsScale behaviour.

chromium/public/WebContentLayer.h:

(WebContentLayer):

Export setBoundsContainPageScale() family of routines.

Source/WebCore:

Testing covered by existing compositor layout and unit tests.

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setAppliesPageScale):
(WebCore::GraphicsLayer::appliesPageScale):

These routines are now virtual, so that they can push the notification to setDisregardsContentsScale in
LayerChromium.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore):
(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):

Now forwards the appliesPageScaleStatus to the owned layer.

platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):
(WebCore):
(WebCore::LayerChromium::setBoundsContainPageScale):

setAppliesPageScale is renamed to setBoundsContainPageScale in LayerChromium.

platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::boundsContainPageScale):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore):
(WebCore::setScale):
(WebCore::updateLayerScale):
(WebCore::CCLayerTreeHost::updateLayers):

The contents scale of a layer is now applied in this routine.

Source/WebKit/chromium:

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

Inform the layer associated with the NCCH that it is to disregard the page scale factor.
Also remove now unused m_deviceScaleFactor and associated routines.

(WebKit::NonCompositedContentHost::setViewport):

src/NonCompositedContentHost.h:

(NonCompositedContentHost):

src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::setBoundsContainPageScale):
(WebKit):
(WebKit::WebContentLayerImpl::boundsContainPageScale):

src/WebContentLayerImpl.h:

(WebContentLayerImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

tests/CCLayerTreeHostTest.cpp:

(NoScaleContentLayerChromium):
(WebKitTests::NoScaleContentLayerChromium::create):
(WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
(WebKitTests):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):

Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the
scale on the draw transforms remain identity.

tests/GraphicsLayerChromiumTest.cpp:

(WebKit): Remove now obsolete unit-test.

3:07 PM Changeset in webkit [127788] by alokp@chromium.org

2 edits in trunk/LayoutTests

[chromium] Remove failures for acceletared-drawing tests.

Unreviewed.

Update chromium TestExpectations to remove failures for accelerated-painting.
They were fixed in r127294.

platform/chromium/TestExpectations:

2:44 PM Changeset in webkit [127787] by jamesr@google.com

3 edits in trunk/Source/WebCore

[chromium] Split platform geometry types into separate static target
https://bugs.webkit.org/show_bug.cgi?id=96021

Reviewed by Tony Chang.

This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
This library is relatively standalone and useful to statically link against in other contexts.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

2:41 PM Changeset in webkit [127786] by kenneth@webkit.org

3 edits in trunk/Source/WebCore

[EFL] Fuzzy load the Edje theme for HTML forms
https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Antonio Gomes.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

platform/efl/RenderThemeEfl.cpp:

(WebCore):

Add some convenience macros.

(WebCore::applyColorCallback):

Use just one callback from the edje theme, which just calls
setColorFromThemeClass.

(WebCore::fillColorsFromEdjeClass):

Add convenience method for receiving colors from Edje and
storing them in Color's.

(WebCore::RenderThemeEfl::setColorFromThemeClass):

Set the class Color variabled with the values from the theme
color class.

(WebCore::RenderThemeEfl::setThemePath):

Don't apply the theme immediately.

(WebCore::RenderThemeEfl::loadTheme):

Load the new theme and free the current one. If it fails,
it will continue using the old one, if exists.

(WebCore::RenderThemeEfl::adjustSizeConstraints):
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformFocusRingColor):

Ensure the theme is loaded.

(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):

Ensure the theme is loaded.

platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(WebCore::RenderThemeEfl::loadThemeIfNeeded):

Remove unneeded methods and add a method for loading a theme
in the case it is not loaded yet.

2:24 PM Changeset in webkit [127785] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Classify several test cases in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=95947

Unreviewed EFL gardening.

Update TestExpectations to classify a few test case failures
as being caused by lack on undo/redo stack implementation
in EFL WK2.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

platform/efl-wk2/TestExpectations:

2:23 PM Changeset in webkit [127784] by enne@google.com

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=95994

Reviewed by James Robinson.

This compositor test shouldn't depend on code outside the compositor.

tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::FakeWebScrollbar::create):
(FakeWebScrollbar):
(WebCore::TEST):

2:04 PM Changeset in webkit [127783] by Simon Fraser

7 edits in trunk/Source/WebCore

Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017

Reviewed by James Robinson.

FrameView already has a HashSet of RenderObjects whose position
is affected by the viewport rect; this contains fixed and sticky-postion
objects. RenderView::setFixedPositionedObjectsNeedLayout() was using
the RenderView's list of postioned objects, but this omitted sticky-position
objects whose container was not the RenderView. So it's simpler to use
FrameView's set of fixed/sticky objects.

Changed the terminology from "fixed" to "viewport-constrained" for this set
of objects.

page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):

page/FrameView.h:

(WebCore::FrameView::viewportConstrainedObjects):
(WebCore::FrameView::hasViewportConstrainedObjects):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::styleDidChange):

rendering/RenderView.cpp:
rendering/RenderView.h:

2:00 PM Changeset in webkit [127782] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

Add data-blackberry-webworks-context attribute and set the custom context when
getting context.
https://bugs.webkit.org/show_bug.cgi?id=95993

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-06
Reviewed by Antonio Gomes.

PR #193726
Reviewed Internally by Mike Fenton.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

Check for custom WebWorks context and add it if there.

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::webWorksContext):
(DOMSupport):

WebKitSupport/DOMSupport.h:
- Add a method that checks a given element for the data-webworks-context attribute and returns its value if present.

1:55 PM Changeset in webkit [127781] by jamesr@google.com

2 edits in trunk/Source/WebKit/chromium

[chromium] Put chromium implementations of WTF symbols in separate static library
https://bugs.webkit.org/show_bug.cgi?id=95933

Reviewed by Adam Barth.

A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
component build is a DLL. This moves these files into a static library that webkit depends on so targets can
statically link in wtf and these support files without depending directly on webkit.

WebKit.gyp:

1:19 PM Changeset in webkit [127780] by commit-queue@webkit.org

12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-06
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp:

(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

inspector/styles/protocol-css-regions-commands-expected.txt:
inspector/styles/protocol-css-regions-commands.html:

1:06 PM Changeset in webkit [127779] by annacc@chromium.org

3 edits
2 adds in trunk

ASSERT reached when TextTrack.mode is set to DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=94651

Reviewed by Eric Carlson.

This patch ensures that cues that have already been added to the
cueTree in HTMLMediaElement, are not added again.

Source/WebCore:

Test: media/track/track-mode-disabled-crash.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackAddCue): Do not add the cue if it already
exists in m_cueTree.

LayoutTests:

media/track/track-mode-disabled-crash-expected.txt: Added.
media/track/track-mode-disabled-crash.html: Added.

12:54 PM Changeset in webkit [127778] by yuqiang.xian@intel.com

2 edits in trunk/Source/JavaScriptCore

Performance regressions on 32-bit platforms with revisions 125637 and 126387
https://bugs.webkit.org/show_bug.cgi?id=95953

Reviewed by Filip Pizlo.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val): Fix the typo.

12:53 PM Changeset in webkit [127777] by ggaren@apple.com

3 edits in trunk/LayoutTests

Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
because I rolled out the patch that broke it.

platform/qt/Skipped:
platform/win/Skipped:

12:52 PM Changeset in webkit [127776] by commit-queue@webkit.org

5 edits
1 add in trunk/Source/WebKit/chromium

[chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
https://bugs.webkit.org/show_bug.cgi?id=93998

Patch by Iain Merrick <husky@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

These provide the same functionality selectRange(WebPoint, WebPoint),
with finer-grained control needed on the Android platform. By passing
allowCollapsedSelection=false, we can ensure the selection stays at
least one character wide.

I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
calling the new methods. The existing test passes, and I've added new
tests for the new methods.

public/WebFrame.h:

(WebFrame):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit):
(WebKit::WebFrameImpl::moveSelectionStart):
(WebKit::WebFrameImpl::moveSelectionEnd):
(WebKit::WebFrameImpl::moveCaret):

src/WebFrameImpl.h:

(WebFrameImpl):

tests/WebFrameTest.cpp:
tests/data/text_selection.html: Added.

12:50 PM Changeset in webkit [127775] by benjamin@webkit.org

2 edits in trunk/Tools

Fix WTF.Lrint on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=96003

Patch by Fady Samuel <fsamuel@chromium.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Fixed failing WTF.Lrint test on 32-bit platforms.

TestWebKitAPI/Tests/WTF/MathExtras.cpp:

(TestWebKitAPI::TEST):

12:45 PM Changeset in webkit [127774] by ggaren@apple.com

13 edits in trunk/Source/JavaScriptCore

Rolled out <http://trac.webkit.org/changeset/127698> because it broke
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html

Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

12:29 PM Changeset in webkit [127773] by commit-queue@webkit.org

33 edits
23 deletes in trunk/LayoutTests

[chromium] Need to rebaseline chromium tests after hidpi changes
https://bugs.webkit.org/show_bug.cgi?id=95579

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Adding double resolution files for hidpi tests and updating expectations for broken image tests.

platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
platform/chromium-linux/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Removed.
platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png:
platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
platform/chromium-mac/fast/hidpi/focus-rings-expected.png:
platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png:
platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png:
platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png:
platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png:
platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png:
platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png:
platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png:
platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png:
platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png:
platform/chromium-mac/fast/hidpi/image-set-simple-expected.png:
platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png:
platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png:
platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png:
platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png:
platform/chromium-win/fast/hidpi/focus-rings-expected.png:
platform/chromium-win/fast/hidpi/image-set-as-background-expected.png:
platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png:
platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png:
platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png:
platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png:
platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png:
platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png:
platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png:
platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png:
platform/chromium-win/fast/hidpi/image-set-simple-expected.png:
platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png:
platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png:
platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
platform/chromium/TestExpectations:

12:22 PM Changeset in webkit [127772] by tonikitoo@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Allow overscroll to composited scroll layers
https://bugs.webkit.org/show_bug.cgi?id=95998
PR #195305

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Gen Mak.

No need to reset the overscroll limit factor at creation to 0.
It is already 0 by default, and later on the client sets the
appropriated value.

WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

12:20 PM Changeset in webkit [127771] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Another unreviewed GTK build fix.

The ENABLE_DATALIST_ELEMENT should default to 0, as it did in stable
release versions before r127760. The feature define can be switched
on later, when its stability is determined and the test results are
rebaselined.

GNUmakefile.features.am:

12:16 PM Changeset in webkit [127770] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Skipping failing test: fast/forms/number/number-interactive-validation-required.html
Interactive form validation is not enabled on Windows. It's fine to skip this test.

platform/win/Skipped:

12:04 PM Changeset in webkit [127769] by Dave Barton

9 edits in trunk

mathml.css: Add more { white-space: nowrap } declarations
https://bugs.webkit.org/show_bug.cgi?id=95404

Reviewed by Eric Seidel.

mathml.css declared { white-space: nowrap } for mrow, mfenced, msqrt. It is also needed
for other tags such as msub, msup, msubsup.

Added a test to mathml/presentation/sup.xhtml, and a regression test to roots.xhtml.

Source/WebCore:

css/mathml.css:

(mo, mrow, mfenced, mfrac, msub, msup, msubsup, munder, mover, munderover, msqrt, mroot):

LayoutTests:

mathml/presentation/roots.xhtml:
mathml/presentation/sup.xhtml:
platform/mac/mathml/presentation/roots-expected.png:
platform/mac/mathml/presentation/roots-expected.txt:
platform/mac/mathml/presentation/sup-expected.png:
platform/mac/mathml/presentation/sup-expected.txt:

12:02 PM Changeset in webkit [127768] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecution.html
https://bugs.webkit.org/show_bug.cgi?id=95944

platform/win/Skipped:

11:54 AM Changeset in webkit [127767] by rjkroege@chromium.org

8 edits in trunk/Source

[chromium] Enable different fling behaviour for touchscreen and touchpad
https://bugs.webkit.org/show_bug.cgi?id=95756

Reviewed by James Robinson.

Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
events by their originating device and pass this flag to a factory that produces
different device specific fling curves based on the value of the flag.

Source/WebCore:

Covered by existing layout and unit tests.

platform/chromium/support/PlatformGestureCurveFactory.cpp: Modified factory

entry point for constructing fling curve for different devices.
(WebKit::PlatformGestureCurveFactory::createCurve):

platform/chromium/support/PlatformGestureCurveFactory.h:

(PlatformGestureCurveFactory):

Source/WebKit/chromium:

public/WebActiveWheelFlingParameters.h:

(WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):

public/WebInputEvent.h: Added source device flag to WebGestureEvent.
src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to
obtain device-appropriate fling curve.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
fling curve.
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):

11:50 AM Changeset in webkit [127766] by tommyw@google.com

25 edits
7 copies
2 adds in trunk

MediaStream API: Add the local and remote description functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95839

Reviewed by Adam Barth.

Source/Platform:

Platform.gypi:
chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):

Source/WebCore:

As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.

Tests: fast/mediastream/RTCPeerConnection-localDescription.html

fast/mediastream/RTCPeerConnection-remoteDescription.html

CMakeLists.txt:
GNUmakefile.list.am:
Modules/mediastream/RTCErrorCallback.h:

(RTCErrorCallback):

Modules/mediastream/RTCErrorCallback.idl:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):

Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

Modules/mediastream/RTCPeerConnection.idl:
Modules/mediastream/RTCSessionDescriptionCallback.h:

(RTCSessionDescriptionCallback):

Modules/mediastream/RTCSessionDescriptionCallback.idl:
Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

Modules/mediastream/RTCSessionDescriptionRequestImpl.h:

(RTCSessionDescriptionRequestImpl):

Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.

(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):

Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.

(WebCore):
(RTCVoidRequestImpl):

WebCore.gypi:
platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):

platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):

platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.

(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):

platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):

platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

fast/mediastream/RTCPeerConnection-createOffer.html:
fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.

11:43 AM Changeset in webkit [127765] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix one of the Qt builds.

dom/TransformSource.h:

11:40 AM Changeset in webkit [127764] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed GTK build fix.

CSS Compositing is not currently supported on the GTK port, so
the feature define should default to 0.

GNUmakefile.features.am:

11:16 AM Changeset in webkit [127763] by zandobersek@gmail.com

2 edits
21 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Generating required platform-specific baselines after r127608.

Adding failure expectations for regressions introduced in r127698 and r127704.

Fixing and removing duplicate expectations to get the file to pass linting.

platform/gtk/TestExpectations:
platform/gtk/css3/masking: Added.
platform/gtk/css3/masking/clip-path-circle-expected.png: Added.
platform/gtk/css3/masking/clip-path-circle-expected.txt: Added.
platform/gtk/css3/masking/clip-path-circle-filter-expected.png: Added.
platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Added.
platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Added.
platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Added.
platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
platform/gtk/css3/masking/clip-path-ellipse-expected.png: Added.
platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Added.
platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
platform/gtk/css3/masking/clip-path-polygon-expected.png: Added.
platform/gtk/css3/masking/clip-path-polygon-expected.txt: Added.
platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
platform/gtk/css3/masking/clip-path-rectangle-expected.png: Added.
platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Added.

11:13 AM Changeset in webkit [127762] by jamesr@google.com

2 edits in trunk/Source/WebCore

SharedGraphicsContext3D shouldn't depend on CCProxy
https://bugs.webkit.org/show_bug.cgi?id=95921

Reviewed by Adrienne Walker.

This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
code in WTF to do that.

platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):

11:06 AM Changeset in webkit [127761] by Patrick Gansterer

2 edits in trunk/Source/WTF

Fix export macros in IntegerToStringConversion.h
https://bugs.webkit.org/show_bug.cgi?id=95900

Reviewed by Benjamin Poulain.

The WTF_EXPORT_STRING_API must be used only for symbols which are compiled
on windows in "non-WTF" binaries too. Since this isn't valid for the
IntegerToStringConversion function replace it with WTF_EXPORT_PRIVATE.

wtf/text/IntegerToStringConversion.h:

10:58 AM Changeset in webkit [127760] by zandobersek@gmail.com

5 edits in trunk

[Gtk] Remove configuration options for features that are not supported by the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=87664

Reviewed by Martin Robinson.

Remove configuration options for features that are completely unsupported by the GTK port.
They only bloat the configure.ac file. They should be re-added when the feature becomes
supported and introduces an external dependency that the users might want to avoid.

configure.ac:

Source/WebCore:

Remove addition of macros to feature_defines for features that are completely
unsupported by the Gtk port. They're not required anymore since the accompanying
configuration flags are also being removed.

No new tests - no new functionality.

GNUmakefile.am:
bindings/gobject/GNUmakefile.am:

10:52 AM Changeset in webkit [127759] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit2

Merge r127750 - [GTK] [WK2] Crash when navigating between pages
https://bugs.webkit.org/show_bug.cgi?id=95949

Reviewed by Martin Robinson.

Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.

UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didInitiateLoadForResource):

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted):

UIProcess/API/gtk/WebKitWebViewPrivate.h:

10:52 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos

(diff)

10:44 AM Changeset in webkit [127758] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
https://bugs.webkit.org/show_bug.cgi?id=95891

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-06
Reviewed by Dean Jackson.

Now we unbind the vertex attributes after a custom filter is applied.

Before this patch, Chromium's GPU process would sometimes print the following error message:
"ERROR:gles2_cmd_decoder.cc(5142)] 002CA47B: GL ERROR :GL_INVALID_OPERATION :
glDrawElements: attempt to render with no buffer attached to enabled attribute 2"

This would happen in the following situation:
1) There are two FECustomFilters on the page.
2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The

detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached
FECustomFilter.

3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound.
4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer

attached to the a_triangleCoord attribute.

No new tests. We can't create an automated test for this because it only reproduces using
Chromium's GPU process. DRT does not use Chromium's GPU process.

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::applyShader):

Unbind the vertex attributes after the drawElements call.

(WebCore::FECustomFilter::unbindVertexAttribute):
(WebCore):
(WebCore::FECustomFilter::unbindVertexAttributes):

Unbind all of the attributes that we bound earlier.

platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

10:36 AM Changeset in webkit [127757] by weinig@apple.com

556 edits
1 delete in trunk/Source

Part 2 of removing PlatformString.h, remove PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=95931

Reviewed by Adam Barth.

Remove PlatformString.h

Source/WebCore:

GNUmakefile.list.am:
Modules/filesystem/AsyncFileWriter.h:
Modules/filesystem/DOMFilePath.h:
Modules/filesystem/DOMFileSystemBase.h:
Modules/filesystem/DirectoryEntry.h:
Modules/filesystem/DirectoryEntrySync.h:
Modules/filesystem/DirectoryReader.h:
Modules/filesystem/DirectoryReaderBase.h:
Modules/filesystem/DirectoryReaderSync.h:
Modules/filesystem/EntryBase.cpp:
Modules/filesystem/EntrySync.h:
Modules/filesystem/FileEntrySync.h:
Modules/filesystem/FileSystemCallbacks.h:
Modules/filesystem/LocalFileSystem.h:
Modules/geolocation/GeolocationError.h:
Modules/geolocation/Geoposition.h:
Modules/geolocation/PositionError.h:
Modules/indexeddb/IDBAny.h:
Modules/indexeddb/IDBDatabaseBackendInterface.h:
Modules/indexeddb/IDBDatabaseCallbacks.h:
Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
Modules/indexeddb/IDBDatabaseError.h:
Modules/indexeddb/IDBFactory.h:
Modules/indexeddb/IDBFactoryBackendInterface.h:
Modules/indexeddb/IDBIndex.h:
Modules/indexeddb/IDBIndexBackendInterface.h:
Modules/indexeddb/IDBKey.h:
Modules/indexeddb/IDBKeyPath.h:
Modules/indexeddb/IDBMetadata.h:
Modules/indexeddb/IDBObjectStore.h:
Modules/indexeddb/IDBObjectStoreBackendInterface.h:
Modules/indexeddb/IDBTransactionBackendInterface.h:
Modules/indexeddb/IDBUpgradeNeededEvent.h:
Modules/indexeddb/IDBVersionChangeEvent.h:
Modules/mediastream/MediaStreamTrack.h:
Modules/networkinfo/NetworkInfoConnection.h:
Modules/notifications/DOMWindowNotifications.h:
Modules/speech/SpeechGrammar.h:
Modules/speech/SpeechRecognition.h:
Modules/speech/SpeechRecognitionAlternative.h:
Modules/speech/SpeechRecognitionClient.h:
Modules/speech/SpeechRecognitionError.h:
Modules/webaudio/AudioContext.cpp:
Modules/webaudio/AudioParam.h:
Modules/webdatabase/AbstractDatabase.h:
Modules/webdatabase/ChangeVersionWrapper.h:
Modules/webdatabase/DOMWindowWebDatabase.h:
Modules/webdatabase/Database.h:
Modules/webdatabase/DatabaseAuthorizer.cpp:
Modules/webdatabase/DatabaseAuthorizer.h:
Modules/webdatabase/DatabaseDetails.h:
Modules/webdatabase/DatabaseSync.h:
Modules/webdatabase/DatabaseTask.h:
Modules/webdatabase/DatabaseTracker.h:
Modules/webdatabase/OriginUsageRecord.h:
Modules/webdatabase/SQLError.h:
Modules/webdatabase/SQLStatement.h:
Modules/webdatabase/SQLStatementSync.h:
Modules/webdatabase/SQLTransaction.cpp:
Modules/webdatabase/SQLTransactionSync.cpp:
Modules/webdatabase/SQLTransactionSync.h:
Modules/webdatabase/WorkerContextWebDatabase.h:
Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
Modules/webdatabase/chromium/QuotaTracker.h:
Modules/websockets/ThreadableWebSocketChannel.cpp:
Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Modules/websockets/WebSocketHandshake.h:
Modules/websockets/WebSocketHandshakeResponse.h:
Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
Modules/websockets/WorkerThreadableWebSocketChannel.h:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/gobject/ConvertToUTF8String.cpp:
bindings/js/JSCSSStyleDeclarationCustom.cpp:
bindings/js/JSClipboardCustom.cpp:
bindings/js/JSImageDataCustom.cpp:
bindings/js/JSInspectorFrontendHostCustom.cpp:
bindings/js/JSLazyEventListener.h:
bindings/js/JSStorageCustom.cpp:
bindings/js/JSXSLTProcessorCustom.cpp:
bindings/js/JavaScriptCallFrame.cpp:
bindings/js/ScheduledAction.h:
bindings/js/ScriptDebugServer.h:
bindings/js/ScriptHeapSnapshot.h:
bindings/js/ScriptValue.h:
bindings/js/SerializedScriptValue.h:
bindings/objc/DOMCustomXPathNSResolver.mm:
bindings/objc/DOMXPath.mm:
bindings/objc/WebScriptObject.mm:
bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(AddIncludesForSVGAnimatedType):

bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

bindings/v8/Dictionary.h:
bindings/v8/JavaScriptCallFrame.h:
bindings/v8/NPV8Object.cpp:
bindings/v8/ScriptDebugServer.h:
bindings/v8/ScriptFunctionCall.h:
bindings/v8/ScriptHeapSnapshot.h:
bindings/v8/ScriptProfile.h:
bindings/v8/ScriptProfileNode.h:
bindings/v8/ScriptProfiler.h:
bindings/v8/ScriptSourceCode.h:
bindings/v8/V8Binding.cpp:
bindings/v8/V8DOMWrapper.h:
bindings/v8/V8LazyEventListener.h:
bindings/v8/V8NPUtils.cpp:
bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
bindings/v8/custom/V8LocationCustom.cpp:
bridge/IdentifierRep.cpp:
bridge/NP_jsobject.cpp:
bridge/c/c_utility.cpp:
css/CSSBasicShapes.h:
css/CSSBorderImageSliceValue.cpp:
css/CSSCharsetRule.h:
css/CSSCursorImageValue.cpp:
css/CSSFontFaceSrcValue.h:
css/CSSGradientValue.cpp:
css/CSSInheritedValue.cpp:
css/CSSInitialValue.cpp:
css/CSSLineBoxContainValue.cpp:
css/CSSMediaRule.h:
css/CSSProperty.cpp:
css/CSSPropertySourceData.cpp:
css/CSSPropertySourceData.h:
css/CSSReflectValue.cpp:
css/CSSTimingFunctionValue.cpp:
css/CSSUnicodeRangeValue.cpp:
css/CSSValueList.cpp:
css/Counter.h:
css/FontFeatureValue.h:
css/FontValue.cpp:
css/MediaQuery.h:
css/MediaQueryEvaluator.h:
css/MediaQueryListListener.h:
css/ShadowValue.cpp:
css/StyleMedia.h:
css/StyleSheet.h:
css/StyleSheetList.cpp:
css/WebKitCSSMatrix.h:
css/WebKitCSSTransformValue.cpp:
dom/DOMStringList.h:
dom/DOMStringMap.h:
dom/DocumentMarker.h:
dom/ErrorEvent.h:
dom/ExceptionBase.h:
dom/MessagePortChannel.h:
dom/MutationRecord.h:
dom/TransformSource.h:
dom/ViewportArguments.cpp:
editing/DOMTransactionStep.h:
editing/EditingStyle.h:
editing/MarkupAccumulator.h:
editing/SmartReplaceICU.cpp:
editing/SpellChecker.h:
editing/SurroundingText.h:
fileapi/AsyncFileStream.cpp:
fileapi/Blob.h:
fileapi/BlobURL.cpp:
fileapi/File.h:
history/HistoryItem.h:
history/blackberry/HistoryItemViewState.h:
history/cf/HistoryPropertyList.h:
html/DOMFormData.cpp:
html/DOMURL.h:
html/MicroDataItemValue.h:
html/PublicURLManager.h:
html/canvas/CanvasPattern.cpp:
html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasStyle.h:
html/canvas/WebGLActiveInfo.h:
html/canvas/WebGLGetInfo.h:
html/canvas/WebGLRenderingContext.h:
html/parser/CSSPreloadScanner.h:
html/parser/HTMLEntitySearch.h:
html/parser/HTMLEntityTable.h:
html/parser/HTMLMetaCharsetParser.cpp:
inspector/CodeGeneratorInspector.py:

(InspectorFrontend_h):

inspector/ContentSearchUtils.h:
inspector/InjectedScript.cpp:
inspector/InjectedScriptBase.cpp:
inspector/InjectedScriptManager.h:
inspector/InjectedScriptModule.h:
inspector/InjectedScriptWebGLModule.h:
inspector/InspectorAgent.h:
inspector/InspectorCSSAgent.h:
inspector/InspectorController.h:
inspector/InspectorDOMDebuggerAgent.h:
inspector/InspectorDOMStorageAgent.h:
inspector/InspectorDatabaseAgent.h:
inspector/InspectorDatabaseResource.h:
inspector/InspectorFrontendClientLocal.cpp:
inspector/InspectorFrontendClientLocal.h:
inspector/InspectorFrontendHost.h:
inspector/InspectorIndexedDBAgent.h:
inspector/InspectorPageAgent.h:
inspector/InspectorProfilerAgent.h:
inspector/InspectorResourceAgent.h:
inspector/InspectorState.h:
inspector/InspectorStyleSheet.h:
inspector/InspectorStyleTextEditor.h:
inspector/InspectorValues.h:
inspector/InspectorWebGLAgent.h:
inspector/InspectorWorkerResource.h:
inspector/ScriptArguments.h:
inspector/ScriptBreakpoint.h:
inspector/ScriptCallFrame.h:
inspector/ScriptDebugListener.h:
inspector/TimelineRecordFactory.h:
inspector/generate-inspector-protocol-version:

(main):

loader/DocumentLoader.cpp:
loader/DocumentWriter.h:
loader/FTPDirectoryParser.h:
loader/FormState.h:
loader/HistoryController.h:
loader/PolicyChecker.h:
loader/ResourceLoadScheduler.h:
loader/SubframeLoader.h:
loader/SubstituteData.h:
loader/WorkerThreadableLoader.h:
loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheGroup.h:
loader/archive/ArchiveFactory.cpp:
loader/archive/ArchiveResourceCollection.h:
loader/cache/CachedResource.h:
loader/cache/MemoryCache.h:
loader/icon/IconRecord.h:
loader/icon/PageURLRecord.h:
loader/mac/LoaderNSURLExtras.mm:
loader/win/DocumentLoaderWin.cpp:
page/Console.cpp:
page/Coordinates.h:
page/DOMSelection.cpp:
page/EventSource.cpp:
page/GroupSettings.h:
page/NavigatorBase.cpp:
page/OriginAccessEntry.h:
page/Page.h:
page/SecurityOrigin.h:
page/SpeechInputResult.h:
page/UserContentURLPattern.h:
page/WindowFeatures.cpp:
page/WindowFeatures.h:
page/WorkerNavigator.h:
page/animation/AnimationControllerPrivate.h:
platform/AsyncFileSystem.h:
platform/AsyncFileSystemCallbacks.h:
platform/ContentType.h:
platform/ContextMenu.h:
platform/ContextMenuItem.h:
platform/Cookie.h:
platform/CrossThreadCopier.cpp:
platform/DateComponents.cpp:
platform/FileChooser.h:
platform/FileStream.cpp:
platform/FileSystem.h:
platform/KURL.cpp:

(WebCore):

platform/KURL.h:
platform/KURLHash.h:
platform/KillRing.h:
platform/Language.cpp:
platform/Length.cpp:
platform/LinkHash.cpp:
platform/Logging.cpp:
platform/MIMETypeRegistry.h:
platform/SSLKeyGenerator.h:
platform/SchemeRegistry.h:
platform/SharedBuffer.h:
platform/Theme.h:
platform/UUID.h:
platform/animation/Animation.h:
platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
platform/blackberry/CookieManager.h:
platform/blackberry/CookieMap.h:
platform/blackberry/DragDataBlackBerry.cpp:
platform/blackberry/KURLBlackBerry.cpp:
platform/blackberry/LocalizedStringsBlackBerry.cpp:
platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
platform/blackberry/TemporaryLinkStubs.cpp:
platform/cf/FileSystemCF.cpp:
platform/cf/SchedulePair.h:
platform/chromium/ChromiumDataObject.h:
platform/chromium/ClipboardUtilitiesChromium.cpp:
platform/chromium/DragDataChromium.cpp:
platform/chromium/FileSystemChromium.cpp:
platform/chromium/FileSystemChromiumMac.mm:
platform/chromium/LanguageChromium.cpp:
platform/chromium/SSLKeyGeneratorChromium.cpp:
platform/cocoa/KeyEventCocoa.mm:
platform/efl/ErrorsEfl.h:
platform/efl/LanguageEfl.cpp:
platform/efl/LocalizedStringsEfl.cpp:
platform/efl/LoggingEfl.cpp:
platform/efl/PasteboardEfl.cpp:
platform/efl/PlatformScreenEfl.cpp:
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/BitmapImage.cpp:
platform/graphics/FontPlatformData.cpp:
platform/graphics/GlyphPageTreeNode.cpp:
platform/graphics/GraphicsContext3D.h:
platform/graphics/GraphicsTypes.cpp:
platform/graphics/SegmentedFontData.cpp:
platform/graphics/blackberry/IconBlackBerry.cpp:
platform/graphics/blackberry/LayerData.h:
platform/graphics/blackberry/LayerFilterRenderer.cpp:
platform/graphics/blackberry/LayerRenderer.cpp:
platform/graphics/blackberry/skia/PlatformSupport.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/PlatformCALayerClient.h:
platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
platform/graphics/cairo/ImageBufferCairo.cpp:
platform/graphics/cairo/PathCairo.cpp:
platform/graphics/cg/ImageSourceCGMac.mm:
platform/graphics/cg/PathCG.cpp:
platform/graphics/chromium/FontUtilsChromiumWin.cpp:
platform/graphics/chromium/GraphicsLayerChromium.cpp:
platform/graphics/chromium/IconChromium.cpp:
platform/graphics/chromium/IconChromiumAndroid.cpp:
platform/graphics/cocoa/FontPlatformDataCocoa.mm:
platform/graphics/efl/IconEfl.cpp:
platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/SourceAlpha.cpp:
platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.cpp:
platform/graphics/filters/SourceGraphic.h:
platform/graphics/freetype/FontPlatformDataFreeType.cpp:
platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
platform/graphics/mac/IconMac.mm:
platform/graphics/mac/ImageMac.mm:
platform/graphics/opentype/OpenTypeUtilities.h:
platform/graphics/openvg/PathOpenVG.cpp:
platform/graphics/pango/FontPlatformDataPango.cpp:
platform/graphics/qt/FontCacheQt.cpp:
platform/graphics/qt/FontPlatformDataQt.cpp:
platform/graphics/qt/IconQt.cpp:
platform/graphics/qt/ImageQt.cpp:
platform/graphics/qt/PathQt.cpp:
platform/graphics/skia/FontCustomPlatformData.h:
platform/graphics/skia/ImageSkia.cpp:
platform/graphics/win/FontCustomPlatformData.h:
platform/graphics/win/FontPlatformDataCGWin.cpp:
platform/graphics/win/FontPlatformDataCairoWin.cpp:
platform/graphics/win/FontPlatformDataWin.cpp:
platform/graphics/win/IconWin.cpp:
platform/graphics/win/ImageCGWin.cpp:
platform/graphics/win/ImageCairoWin.cpp:
platform/graphics/win/SimpleFontDataCGWin.cpp:
platform/graphics/wince/FontCustomPlatformData.h:
platform/graphics/wince/FontPlatformData.cpp:
platform/graphics/wince/ImageWinCE.cpp:
platform/graphics/wince/MediaPlayerProxy.cpp:
platform/graphics/wince/PathWinCE.cpp:
platform/graphics/wince/PlatformPathWinCE.cpp:
platform/graphics/wx/FontCacheWx.cpp:
platform/graphics/wx/FontPlatformDataWx.cpp:
platform/graphics/wx/IconWx.cpp:
platform/graphics/wx/PathWx.cpp:
platform/gtk/ErrorsGtk.h:
platform/gtk/FileSystemGtk.cpp:
platform/gtk/GtkPopupMenu.h:
platform/gtk/KeyBindingTranslator.h:
platform/gtk/LanguageGtk.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/gtk/LoggingGtk.cpp:
platform/gtk/PasteboardGtk.cpp:
platform/image-decoders/ImageDecoder.h:
platform/leveldb/LevelDBSlice.h:
platform/mac/FileSystemMac.mm:
platform/mediastream/MediaStreamSource.h:
platform/mock/GeolocationClientMock.h:
platform/network/BlobData.h:
platform/network/BlobRegistryImpl.h:
platform/network/BlobResourceHandle.h:
platform/network/Credential.h:
platform/network/FormData.h:
platform/network/FormDataBuilder.h:
platform/network/HTTPParsers.cpp:
platform/network/HTTPRequest.h:
platform/network/HTTPValidation.cpp:
platform/network/ProtectionSpace.h:
platform/network/ResourceErrorBase.h:
platform/network/SocketStreamErrorBase.h:
platform/network/blackberry/DNSBlackBerry.cpp:
platform/network/blackberry/DeferredData.h:
platform/network/blackberry/NetworkJob.h:
platform/network/cf/CookieJarCFNet.cpp:
platform/network/curl/CookieJarCurl.cpp:
platform/network/curl/ResourceHandleManager.h:
platform/network/qt/DnsPrefetchHelper.cpp:
platform/network/soup/ResourceRequestSoup.cpp:
platform/network/soup/ResourceResponseSoup.cpp:
platform/network/win/CookieJarWin.cpp:
platform/posix/FileSystemPOSIX.cpp:
platform/qt/ClipboardQt.cpp:
platform/qt/CookieJarQt.cpp:
platform/qt/FileSystemQt.cpp:
platform/qt/LanguageQt.cpp:
platform/qt/LocalizedStringsQt.cpp:
platform/qt/LoggingQt.cpp:
platform/qt/PlatformSupport.h:
platform/sql/SQLValue.h:
platform/sql/SQLiteDatabase.h:
platform/sql/SQLiteFileSystem.h:
platform/text/DecodeEscapeSequences.h:
platform/text/LineEnding.cpp:
platform/text/ParserUtilities.h:
platform/text/PlatformString.h: Removed.
platform/text/RegularExpression.h:
platform/text/SegmentedString.h:
platform/text/StringWithDirection.h:
platform/text/SuffixTree.h:
platform/text/TextBreakIteratorICU.cpp:
platform/text/TextCodec.cpp:
platform/text/TextCodec.h:
platform/text/TextCodecLatin1.cpp:
platform/text/TextCodecUTF16.cpp:
platform/text/TextCodecUserDefined.cpp:
platform/text/TextEncoding.cpp:
platform/text/blackberry/StringBlackBerry.cpp:
platform/text/cf/StringCF.cpp:
platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
platform/text/gtk/TextCodecGtk.cpp:
platform/text/mac/StringMac.mm:
platform/text/mac/TextCodecMac.cpp:
platform/text/qt/TextCodecQt.cpp:
platform/text/win/TextCodecWin.h:
platform/text/wince/TextBreakIteratorWinCE.cpp:
platform/win/BString.cpp:
platform/win/DragDataWin.cpp:
platform/win/GDIObjectCounter.h:
platform/win/LoggingWin.cpp:
platform/win/WCDataObject.cpp:
platform/wince/DragDataWinCE.cpp:
platform/wx/ClipboardWx.cpp:
platform/wx/FileSystemWx.cpp:
platform/wx/LanguageWx.cpp:
platform/wx/LocalizedStringsWx.cpp:
platform/wx/LoggingWx.cpp:
platform/wx/PasteboardWx.cpp:
platform/wx/PopupMenuWx.cpp:
plugins/PluginData.h:
plugins/PluginDatabase.h:
plugins/PluginDebug.cpp:
plugins/PluginPackage.h:
plugins/PluginStream.h:
rendering/style/StyleDashboardRegion.h:
storage/Storage.cpp:
storage/StorageArea.h:
storage/StorageEvent.h:
storage/StorageEventDispatcher.h:
storage/StorageMap.h:
storage/StorageNamespace.h:
storage/StorageNamespaceImpl.h:
storage/StorageSyncManager.h:
storage/StorageTask.h:
storage/StorageTracker.h:
svg/SVGPathByteStreamBuilder.h:
svg/SVGPathParser.h:
svg/SVGPathStringSource.h:
svg/SVGStyledElement.cpp:
svg/animation/SMILTimeContainer.h:
svg/graphics/filters/SVGFilterBuilder.cpp:
svg/graphics/filters/SVGFilterBuilder.h:
testing/Internals.h:
workers/DefaultSharedWorkerRepository.cpp:
workers/WorkerLocation.cpp:
workers/WorkerThread.cpp:
xml/DOMParser.cpp:
xml/NativeXPathNSResolver.cpp:
xml/XMLSerializer.cpp:
xml/XMLSerializer.h:
xml/XPathExpression.cpp:
xml/XPathValue.h:
xml/XSLTUnicodeSort.cpp:

Source/WebKit/blackberry:

Api/DumpRenderTreeClient.h:
WebCoreSupport/ChromeClientBlackBerry.cpp:
WebCoreSupport/InspectorClientBlackBerry.h:
WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
WebKitSupport/AboutData.h:

Source/WebKit/cf:

WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::createFrontendSettings):

Source/WebKit/chromium:

src/ContextMenuClientImpl.cpp:
src/EditorClientImpl.cpp:
src/InspectorFrontendClientImpl.cpp:
src/LocalFileSystemChromium.cpp:
src/SpeechInputClientImpl.cpp:
src/SpeechRecognitionClientProxy.h:
src/WebDevToolsAgentImpl.cpp:
src/WebDevToolsFrontendImpl.cpp:
src/WebDevToolsFrontendImpl.h:
src/WebEntities.h:
src/WebFrameImpl.h:
src/WorkerFileSystemCallbacksBridge.h:
tests/UniscribeHelperTest.cpp:

Source/WebKit/efl:

WebCoreSupport/ChromeClientEfl.cpp:
WebCoreSupport/InspectorClientEfl.cpp:

Source/WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/InspectorClientGtk.cpp:
gdom/ConvertToGCharPrivate.h:
webkit/webkitsecurityorigin.cpp:
webkit/webkitwebdatasource.cpp:
webkit/webkitwebhistoryitem.cpp:
webkit/webkitwebresource.cpp:

Source/WebKit/mac:

History/WebHistoryItem.mm:
Misc/WebStringTruncator.mm:
Plugins/Hosted/NetscapePluginHostManager.h:

(NetscapePluginHostManager):

Plugins/WebPluginController.mm:
Storage/WebStorageTrackerClient.mm:
WebCoreSupport/WebChromeClient.mm:
WebCoreSupport/WebEditorClient.mm:
WebCoreSupport/WebFrameLoaderClient.mm:
WebCoreSupport/WebIconDatabaseClient.mm:
WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):
(WebInspectorFrontendClient):

WebView/WebRenderLayer.mm:
WebView/WebViewData.h:

Source/WebKit/qt:

Api/qwebdatabase_p.h:
Api/qwebframe_p.h:
Api/qwebhistory.cpp:
Api/qwebhistoryinterface.cpp:
Api/qwebpage_p.h:
Api/qwebsettings.cpp:
WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/InspectorClientQt.cpp:

Source/WebKit/win:

DOMCSSClasses.cpp:
DefaultPolicyDelegate.cpp:
MarshallingHelpers.cpp:
WebCoreSupport/WebInspectorClient.h:
WebDownload.h:
WebFrame.h:
WebHistoryItem.h:
WebIconDatabase.cpp:
WebKitDLL.h:
WebKitGraphics.cpp:
WebKitSystemBits.cpp:
WebLocalizableStrings.cpp:
WebNotificationCenter.cpp:
WebResource.h:

Source/WebKit/wx:

WebFrame.cpp:
WebKitSupport/ChromeClientWx.cpp:
WebKitSupport/EditorClientWx.cpp:
WebKitSupport/FrameLoaderClientWx.cpp:
WebKitSupport/InspectorClientWx.cpp:
WebSettings.cpp:
WebView.cpp:

10:29 AM Changeset in webkit [127756] by danakj@chromium.org

6 edits in trunk/Source

[chromium] Add a customized copy() method to CCRenderPassDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=95871

Reviewed by Adrienne Walker.

Source/WebCore:

CCRenderPassDrawQuad is special because a copied quad will need to
point to a different RenderPass id, since new ids are given to copied
RenderPasses. Add a custom copy() method to CCRenderPassDrawQuad that
takes as input the new RenderPass id that should appear in the copied
quad.

Test: CCDrawQuad.copyRenderPassDrawQuad

platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::copy):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::copy):
(WebCore):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

Source/WebKit/chromium:

tests/CCDrawQuadTest.cpp:

(WebCore):
(WebCore::TEST):

10:26 AM Changeset in webkit [127755] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

gradient-with-scaled-ancestor.html is not calling setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=95847

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-09-06
Reviewed by Beth Dakin.

Setting the device scale factor in the layout test and updating expectations until we can rebase

fast/hidpi/gradient-with-scaled-ancestor.html:
platform/chromium/TestExpectations:

10:16 AM Changeset in webkit [127754] by ap@apple.com

11 edits in trunk/Source/WebKit2

[WK2] Annotate multi-process FIXMEs with bug numbers
https://bugs.webkit.org/show_bug.cgi?id=95916

Reviewed by Eric Carlson.

UIProcess/WebContext.cpp: (WebKit::WebContext::setProcessModel): Ensure that plug-in process is enabled. Comments in WebPluginSiteDataManager said that it's required for multi-process. (WebKit::WebContext::createNewWebProcess): Added a bug number. (WebKit::WebContext::disconnectProcess): Ditto. (WebKit::WebContext::createWebPage): Ditto. (WebKit::WebContext::download): Ditto. (WebKit::WebContext::getWebCoreStatistics): Ditto.

UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData): Removed FIXMEs - some ports haven't switched to plugin process yet, but that doesn't stop others from having a multi-process model. Added an ASSERT to document this requirement (in addition to the check in WebContext).

UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel): (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): (WebKit::DownloadProxy::startTransfer):
UIProcess/WebApplicationCacheManagerProxy.cpp: (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): (WebKit::WebDatabaseManagerProxy::deleteAllDatabases): (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): (WebKit::WebIconDatabase::didFinishURLImport):
UIProcess/WebKeyValueStorageManagerProxy.cpp: (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
UIProcess/WebMediaCacheManagerProxy.cpp: (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin): (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Added bug numbers.

10:14 AM Changeset in webkit [127753] by msaboff@apple.com

2 edits in trunk/Source/WebKit2

WebKit2 IPC always sends strings using 16 bit data format
https://bugs.webkit.org/show_bug.cgi?id=95811

Reviewed by Benjamin Poulain.

Changed string encoding to pass an 8bit flag and then send either 8 or 16 bit
character data.

Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::decodeStringText): New templatized string creation and decoder method.
(CoreIPC::::decode):

10:13 AM Changeset in webkit [127752] by commit-queue@webkit.org

21 edits in trunk/Source

Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
https://bugs.webkit.org/show_bug.cgi?id=95780

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-06
Reviewed by Eric Seidel.

Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
and Clipboard. There is a minor compile-time performance boost.

Modules/mediastream/MediaStreamEvent.h:
dom/Event.cpp:
dom/Event.h:

(WebCore):

dom/EventDispatchMediator.cpp:
dom/EventListenerMap.cpp:
dom/MouseRelatedEvent.h:
dom/UIEvent.cpp:
html/FormAssociatedElement.h:

(WebCore):

inspector/TimelineRecordFactory.cpp:
platform/graphics/FontPlatformData.h:
rendering/RenderLineBoxList.h:
rendering/style/RenderStyle.h:

(WebCore):

svg/SVGAnimatedType.h:
svg/SVGExternalResourcesRequired.cpp:
svg/SVGExternalResourcesRequired.h:

(WebCore):

svg/SVGURIReference.h:

(WebCore):

10:11 AM Changeset in webkit [127751] by mitz@apple.com

8 edits in trunk

REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
https://bugs.webkit.org/show_bug.cgi?id=95972

Source/WebCore:

Reverted r127712, because it was based on the false premise that “[Optional] works the way
XMLHttpRequest expects”.

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openCallback):
(WebCore):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore):

xml/XMLHttpRequest.h:

(XMLHttpRequest):

xml/XMLHttpRequest.idl:

LayoutTests:

Removed the failing test from the skipped list.

platform/qt/Skipped:

9:57 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos

(diff)

9:56 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos

(diff)

9:53 AM Changeset in webkit [127750] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

[GTK] [WK2] Crash when navigating between pages
https://bugs.webkit.org/show_bug.cgi?id=95949

Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didInitiateLoadForResource):

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted):

UIProcess/API/gtk/WebKitWebViewPrivate.h:

9:49 AM Changeset in webkit [127749] by Carlos Garcia Campos

5 edits in trunk/Source/WebKit/gtk

[GTK] Add API to get/set the security policy of a given URI scheme
https://bugs.webkit.org/show_bug.cgi?id=95549

Reviewed by Martin Robinson.

Add WebKitSecurityPolicy enum with flags that represent the
security policy of a URI scheme. Add methods to get and set the
security policy flags for a given URI scheme.

docs/webkitgtk-sections.txt: Add new symbols.
tests/testglobals.c:

(test_globals_security_policy):
(main):

webkit/webkitglobals.cpp:

(webkit_set_security_policy_for_uri_scheme):
(webkit_get_security_policy_for_uri_scheme):

webkit/webkitglobals.h:

9:41 AM Changeset in webkit [127748] by keishi@webkit.org

4 edits in trunk/Source/WebCore

Use native function bind in page popups
https://bugs.webkit.org/show_bug.cgi?id=95976

Reviewed by Kent Tamura.

We should be using Function.prototype.bind instead of our own bind implementation.

No new tests. No behavior change.

Resources/pagepopups/calendarPicker.js:

(CalendarPicker):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._attachLeftButtonsTo):
(YearMonthController.prototype._attachRightButtonsTo):
(DaysTable.prototype.attachTo):

Resources/pagepopups/colorSuggestionPicker.js:

(ColorPicker):
(ColorPicker.prototype._layout):

Resources/pagepopups/pickerCommon.js:

9:25 AM Changeset in webkit [127747] by abecsi@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] Fix the build with gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=95989

Reviewed by Csaba Osztrogonác.

The build fails because of a bogus warning about the auto-generated
pplval variable. Unfortunately the warning is called -Wuninitialized
in gcc 4.6 and -Wmaybe-uninitialized in gcc 4.7 thus we also need to
ignore unknown pragmas not to break the build with compilers that do
not recognize these options.

src/compiler/preprocessor/new/ExpressionParser.y:

9:00 AM Changeset in webkit [127746] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
https://bugs.webkit.org/show_bug.cgi?id=95731

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-09-06
Reviewed by Yury Semikhatsky.

Now scrolling is sluggish on large datasets.
Performance degrades, because each refresh causes DFS on all recorded items.
Solution: caching/invalidation of DFS (filtering) results.

Also fixed "truncate selected record range on mode change" glitch.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
Add flag for cache invalidation.

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.invalidateFilteredRecords):
Added.
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
Caching/using cached results.

8:54 AM Changeset in webkit [127745] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPopupMenuProxy
https://bugs.webkit.org/show_bug.cgi?id=95862

Reviewed by Simon Hausmann.

Bail out early if the PageClient does not create a PopupMenuProxy for us.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):

8:42 AM Changeset in webkit [127744] by commit-queue@webkit.org

2 edits
1 delete in trunk/LayoutTests

[EFL] Gardening after r127728, r127534
https://bugs.webkit.org/show_bug.cgi?id=95975

Unreviewed gardening.

Following tests were added to TestExpectations:
http/tests/xmlhttprequest/basic-auth.html fails after r127728.
fast/innerHTML/innerHTML-iframe.html fails after r127534.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06

platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
platform/efl/TestExpectations:

8:40 AM Changeset in webkit [127743] by loislo@chromium.org

3 edits in trunk/LayoutTests

Unreviewed rebaseline for Web Inspector NMI test. It was broken at r127738.

inspector/profiler/memory-instrumentation-cached-images-expected.txt:
inspector/profiler/memory-instrumentation-cached-images.html:

8:31 AM Changeset in webkit [127742] by commit-queue@webkit.org

2 edits in trunk/Tools

[Qt] Fix build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=95200

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Tor Arne Vestbø.

The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
10.7 and newer.

qmake/mkspecs/features/features.prf:

8:04 AM Changeset in webkit [127741] by loislo@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed Web Inspector: test fix.

tests/MemoryInstrumentationTest.cpp:

(StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::reportMemoryUsage):
(WebCore):
(WebCore::TEST):

7:38 AM Changeset in webkit [127740] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Remove unnecessary logic in ewk_frame_source_get.
https://bugs.webkit.org/show_bug.cgi?id=95828

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Removed unnecessary logic that checks if <html> tag exists in document.
WebKit automatically fill out <html></html> tags if they are not existed.

ewk/ewk_frame.cpp:

(ewk_frame_source_get):

7:36 AM Changeset in webkit [127739] by commit-queue@webkit.org

6 edits in trunk

[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
https://bugs.webkit.org/show_bug.cgi?id=95973

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Tools:

Correctly map "addSelectionKey" to "Control" modifier
in WKTR's EventSender on other OSes than Mac OS X,
instead of mapping it to the "Meta" modifier.

WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::parseModifier):

LayoutTests:

Unskip several test cases that are passing on WebKit2
now that "addSelectionKey" is properly mapped to
"Control" modifier on other OSes than Mac OS X, in
WKTR's EventSender.

platform/efl-wk2/TestExpectations:
platform/gtk-wk2/Skipped:
platform/win-wk2/Skipped:

7:25 AM Changeset in webkit [127738] by loislo@chromium.org

11 edits in trunk/Source

Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
https://bugs.webkit.org/show_bug.cgi?id=95957

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each type of memory will be counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

dom/MemoryInstrumentation.cpp:

(WebCore):

dom/MemoryInstrumentation.h:

(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):

inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):

inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::countObjectSize):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::reportMemoryUsage):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

Source/WebKit/chromium:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each memory type is counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

tests/MemoryInstrumentationTest.cpp:

(WebCore::InstrumentedUndefined::InstrumentedUndefined):
(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::InstrumentedDOM::InstrumentedDOM):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(InstrumentedDOM):
(WebCore::TEST):

7:00 AM Changeset in webkit [127737] by commit-queue@webkit.org

17 edits
2 adds in trunk

CSS 3 'overflow-wrap' property implementation
https://bugs.webkit.org/show_bug.cgi?id=94475

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06
Reviewed by Ojan Vafai.

Source/WebCore:

Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
The specification declares that 'word-wrap' as a shorthand
for the 'overflow-wrap' property. So what was basically done
is declaring of new 'overflow-wrap' property and renaming
of the internal data structures from 'WordWrap' to 'OverflowWrap'.
Both 'overflow-wrap' and 'word-wrap' properties share the same
handlers and thus have the same behaviour.

Test: fast/text/overflow-wrap.html

WebCore.order: Rename exported setWordWrap to setOverflowWrap.
css/CSSComputedStyleDeclaration.cpp: Add CSSPropertyOverflowWrap to computedProperties.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp: Validation for the 'overflow-wrap' property.

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): CSSPropertyOverflowWrap is inherited.

css/CSSPropertyNames.in: Declare new 'overflow-wrap' property.
css/StyleBuilder.cpp: Assign property handler (same as for 'word-wrap').

(WebCore::StyleBuilder::StyleBuilder):

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Renaming.

rendering/RenderTextControl.cpp: Ditto.

(WebCore::RenderTextControl::computeLogicalHeight):

rendering/RenderTextControlSingleLine.cpp: Ditto.

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

rendering/style/RenderStyle.cpp: Ditto.

(WebCore::RenderStyle::diff):

rendering/style/RenderStyle.h: Ditto.
rendering/style/RenderStyleConstants.h: Ditto.
rendering/style/StyleRareInheritedData.cpp: Ditto.

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

rendering/style/StyleRareInheritedData.h: Ditto.

(StyleRareInheritedData):

LayoutTests:

Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
New ref-test is added to check the simularity
in behaviour of 'overflow-wrap' and 'word-wrap' properties.

fast/text/overflow-wrap-expected.html: Added.
fast/text/overflow-wrap.html: Added.

6:41 AM Changeset in webkit [127736] by anilsson@rim.com

2 edits in trunk/Source/WebCore

[BlackBerry] Always log shader compilation failure
https://bugs.webkit.org/show_bug.cgi?id=95948

Reviewed by George Staikos.

Also add shader source to the logs. In addition, don't bail on the
first failure, run through all shaders so we get a complete set of
logs.

No new tests: no change in functionality.

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::loadShader):
(WebCore::LayerRenderer::initializeSharedGLObjects):

6:23 AM Changeset in webkit [127735] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html
https://bugs.webkit.org/show_bug.cgi?id=95970

Unreviewed EFL gardening.

Update WK2-EFL TestExpectations to add bug number for:
fast/events/tab-focus-link-in-canvas.html

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

platform/efl-wk2/TestExpectations:

6:21 AM Changeset in webkit [127734] by kbalazs@webkit.org

2 edits in trunk/Tools

[nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
https://bugs.webkit.org/show_bug.cgi?id=95710

Reviewed by Dirk Pranke.

The stdout / stderr output can be None so make sure
we won't raise an exception in this case.

Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

6:05 AM Changeset in webkit [127733] by commit-queue@webkit.org

4 edits in trunk

[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
https://bugs.webkit.org/show_bug.cgi?id=95943

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
in EFL WK2.

WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

LayoutTests:

Unskip several test cases that are passing now that EFL WK2
has a proper implementation for
WebPage::performDefaultBehaviorForKeyEvent().

platform/efl-wk2/TestExpectations:

5:54 AM Changeset in webkit [127732] by Patrick Gansterer

8 edits in trunk/Source

Remove String::operator+=() from windows platform code
https://bugs.webkit.org/show_bug.cgi?id=95904

Reviewed by Benjamin Poulain.

Use StringBuilder and operator+() to concatenate strings instead of operator+=().

Source/WebCore:

platform/win/ClipboardWin.cpp:

(WebCore::filesystemPathFromUrlOrTitle):

Source/WebKit/win:

AccessibleBase.cpp:

(AccessibleBase::get_accKeyboardShortcut):

WebDownload.cpp:

(WebDownload::bundlePathForTargetPath):

WebView.cpp:

(imeCompositionArgumentNames):

Source/WebKit2:

UIProcess/win/WebView.cpp:

(WebKit::imeCompositionArgumentNames):

5:29 AM Changeset in webkit [127731] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[CMake] Add notifications path to the WebKit2/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=95843

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-06
Reviewed by Laszlo Gombos.

Add WebCore/Modules/Notifications to the WebKit2_INCLUDE_DIRECTORIES of WebKit2/CMakeLists.txt.
There are some build errors when ENABLE_NOTIFICATIONS feature is enabled.

CMakeLists.txt:

5:21 AM Changeset in webkit [127730] by mikelawther@chromium.org

3 edits
1 delete in trunk/LayoutTests

Rewrite zooming test to no longer output pixel numbers
https://bugs.webkit.org/show_bug.cgi?id=95922

Reviewed by Dan Bernstein.

The original version of this test output pixel sizes, which had different results on
different ports. The test has been rewritten to suppress the pixel size output.

css3/calc/zoom-with-em-expected.txt:
css3/calc/zoom-with-em.html:
platform/chromium/css3/calc/zoom-with-em-expected.txt: Removed.

5:06 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos

(diff)

4:44 AM Changeset in webkit [127729] by commit-queue@webkit.org

6 edits
2 adds in trunk/Tools

[EFL] Sanitize URLs in EWebLauncher / Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95849

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Sanitize URLs passed by the user as program
argument or typed in the URL bar in order to
be more tolerant.

EWebLauncher/CMakeLists.txt:
EWebLauncher/main.c:

(main):

EWebLauncher/url_bar.c:

(_url_bar_url_get_with_protocol):
(on_urlbar_key_down):

EWebLauncher/url_utils.c: Added.

(has_scheme):
(url_from_user_input): Add utility function to construct a
URL from user input.

EWebLauncher/url_utils.h: Added.
MiniBrowser/efl/CMakeLists.txt:
MiniBrowser/efl/main.c:

(main):

4:22 AM Changeset in webkit [127728] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip one more failing test,
because we like regressions in the trunk. :)

platform/qt/Skipped:

4:05 AM Changeset in webkit [127727] by keishi@webkit.org

6 edits in trunk

Refactor CalendarPicker to not use global variables.
https://bugs.webkit.org/show_bug.cgi?id=95830

Reviewed by Kent Tamura.

Source/WebCore:

Introduce CalendarPicker so we can have multiple Pickers in one page
popup in the future.

No new tests. No behavior change.

Resources/pagepopups/calendarPicker.js:

(initialize):
(resetMain):
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday):
(CalendarPicker.prototype.handleClear):
(CalendarPicker.prototype.fixWindowSize):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._redraw):
(YearMonthController.prototype._handleYearMonthChange):
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(DaysTable.prototype.attachTo):
(CalendarPicker.prototype.stepMismatch):
(CalendarPicker.prototype.outOfRange):
(CalendarPicker.prototype.isValidDate):
(DaysTable.prototype._renderMonth):
(DaysTable.prototype._navigateToMonth):
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleDayClick):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):

Resources/pagepopups/colorSuggestionPicker.js:

(ColorPicker):
(ColorPicker.prototype._layout):
(ColorPicker.prototype._handleKeyDown):
(ColorPicker.prototype._handleSwatchClick):

Resources/pagepopups/pickerCommon.js:

(Picker):
(Picker.prototype.submitValue):
(Picker.prototype.handleCancel):
(Picker.prototype.chooseOtherColor):

LayoutTests:

fast/forms/date/calendar-picker-appearance-pre-100.html:

4:02 AM Changeset in webkit [127726] by Simon Hausmann

9 edits in trunk

[Qt] Various small Windows / MSVC build fixes
https://bugs.webkit.org/show_bug.cgi?id=95934

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Shared/LayerTreeContext.h: Include stdint.h due to the use of uint32_t as layer id.
UIProcess/API/qt/qquickwebview_p.h:

(WebKit): Fix struct vs. class forward declaration mismatch, causing linking errors.

UIProcess/API/qt/tests/bytearraytestdata.h: Remove export macro from internal test class

that is not used anymore. Using the export macro from a DLL when the code in question is not
part of the DLL results in the export macro expanding to dllimport, giving incorrect linkage
for the unit test.

WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt): Removed explicit call to srandom(), which is not available on Windows.
The call appears to be unnecessary in the light of the WTF::initializeThreading() call below, which
in turn calls WTF::initializeRandomNumberGenerator(), which does the same thing already (and isn't
needed on Windows, as per comment in wtf/RandomNumberSeed.h)

Source/WTF:

For the Qt build on Windows, do not enable WTF_USE_UNIX_DOMAIN_SOCKETS for
WebKit2 IPC.

wtf/Platform.h:

Tools:

setFocus takes a boolean as argument: Don't try to implicitly convert
an enum to a boolean, MSVC doesn't like that. The intent here is to
enable focus, so just pass true.

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::focus):

3:59 AM Changeset in webkit [127725] by Simon Hausmann

1 edit in trunk/Source/WebKit2/Target.pri

Small typo I forgot to land as part of r127724

3:55 AM Changeset in webkit [127724] by Simon Hausmann

14 edits
5 adds in trunk

[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
https://bugs.webkit.org/show_bug.cgi?id=95965

Reviewed by Tor Arne Vestbø.

Add ANGLE as separate static library to the build and dependencies.

Source/api.pri:
WebKit.pro:

Source/ThirdParty/ANGLE:

Add build rules to build ANGLE as a static library for the Qt port.

ANGLE.pri: Added.
ANGLE.pro: Added.
DerivedSources.pri: Added.
Target.pri: Added.

Source/WebCore:

Moved all ANGLE build rules from here to Source/Thirty/ANGLE and
instead depend on the new library with a simple WEBKIT += ANGLE.

DerivedSources.pri:
Target.pri:
platform/graphics/ANGLEWebKitBridge.h: Simplify the include statement

for the internal shader compiler API, aligned with the other platforms.

Source/WebKit:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

WebKit1.pro:

Source/WebKit2:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

Target.pri:

Tools:

Add ANGLE as a static library module to the Qt WebKit build system.

qmake/mkspecs/features/default_post.prf:
qmake/mkspecs/modules/angle.prf: Added.

3:47 AM Changeset in webkit [127723] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] Keep placeholder text visible until first input from user.
https://bugs.webkit.org/show_bug.cgi?id=95851

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-06
Reviewed by Gyuyoung Kim.

Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Therefore, this patch enabled it.

platform/efl/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):

3:47 AM Changeset in webkit [127722] by dominik.rottsches@intel.com

2 edits in trunk/LayoutTests

[EFL] Gardening after r127620, r127698 and r127704
https://bugs.webkit.org/show_bug.cgi?id=95963

Unreviewed gardening.

Following tests were added to TestExpectations:
compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620.
fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698.
fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704.
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06

platform/efl/TestExpectations:

3:40 AM Changeset in webkit [127721] by bashi@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Win build fix attempt after r127715

tests/CCRenderPassTest.cpp:

(WebCore::TEST):

3:36 AM Changeset in webkit [127720] by abecsi@webkit.org

15 edits
1 move
4 adds
1 delete in trunk

[WK2] Make [Qt]ViewportHandler cross platform
https://bugs.webkit.org/show_bug.cgi?id=91257

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

Since QtViewportHandler includes behaviour that is not platform
specific together with hooks to the QtQuick API layer, a platform
independent implementation would allow other ports to use the
viewport controlling functionality provided.

This patch removes QtViewportHandler and introduces a platform
independent PageViewportController class that is responsible
for handling requests from the web process (eg. content size
changes, viewport attributes changes and scroll position requests).
Requests from the web process are acted on by a platform specific
client class which implements the PageViewportControllerClient
interface which provides hooks to the platform specific API layer.

The PageViewportController is also responsible to notify the web
process about changes in the viewport state (eg. viewport size,
visible rect, content scale and movement trajectory).
The client is responsible to delegate these UI changes to the
PageViewportController.

For now only PageViewportControllerClientQt implements the client
interface besides providing other QQuick specific functionality
(gestures, animations, etc).

Target.pri:
UIProcess/API/qt/qquickwebpage_p_p.h:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate::pageViewportControllerClient):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::viewport):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::contentsScale):

UIProcess/PageViewportController.cpp: Added.

(WebKit):
(WebKit::bound):
(WebKit::fuzzyCompare):
(WebKit::boundPosition):
(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::convertFromViewport):
(WebKit::PageViewportController::convertToViewport):
(WebKit::PageViewportController::innerBoundedContentsScale):
(WebKit::PageViewportController::outerBoundedContentsScale):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::setViewportSize):
(WebKit::PageViewportController::setVisibleContentsRect):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::suspendContent):
(WebKit::PageViewportController::resumeContent):
(WebKit::PageViewportController::positionRangeForContentAtScale):

UIProcess/PageViewportController.h: Added.

(WebCore):
(WebKit):
(ViewportUpdateDeferrer):
(PageViewportController):
(WebKit::PageViewportController::~PageViewportController):
(WebKit::PageViewportController::hasSuspendedContent):
(WebKit::PageViewportController::hadUserInteraction):
(WebKit::PageViewportController::allowsUserScaling):
(WebKit::PageViewportController::contentsLayoutSize):
(WebKit::PageViewportController::devicePixelRatio):
(WebKit::PageViewportController::minimumContentsScale):
(WebKit::PageViewportController::maximumContentsScale):
(WebKit::PageViewportController::setHadUserInteraction):

UIProcess/PageViewportControllerClient.h: Added.

(WebKit):
(PageViewportControllerClient):
(WebKit::PageViewportControllerClient::PageViewportControllerClient):
(WebKit::PageViewportControllerClient::~PageViewportControllerClient):

UIProcess/qt/PageViewportControllerClientQt.cpp: Added.

(WebKit):
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::updateCurrentValue):
(WebKit::PageViewportControllerClientQt::~PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setContentRectVisiblePositionAtScale):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setContentsPosition):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::didResumeContent):
(WebKit::PageViewportControllerClientQt::allowsUserScaling):
(WebKit::PageViewportControllerClientQt::devicePixelRatio):
(WebKit::PageViewportControllerClientQt::minimumContentsScale):
(WebKit::PageViewportControllerClientQt::maximumContentsScale):
(WebKit::PageViewportControllerClientQt::currentContentsScale):
(WebKit::PageViewportControllerClientQt::contentsLayoutSize):
(WebKit::PageViewportControllerClientQt::scrollAnimationActive):
(WebKit::PageViewportControllerClientQt::panGestureActive):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::panGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::panGestureEnded):
(WebKit::PageViewportControllerClientQt::panGestureCancelled):
(WebKit::PageViewportControllerClientQt::scaleAnimationActive):
(WebKit::PageViewportControllerClientQt::cancelScrollAnimation):
(WebKit::PageViewportControllerClientQt::interruptScaleAnimation):
(WebKit::PageViewportControllerClientQt::pinchGestureActive):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::visibleContentsRect):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
(WebKit::PageViewportControllerClientQt::didChangeVisibleContents):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):
(WebKit::PageViewportControllerClientQt::updateViewportController):
(WebKit::PageViewportControllerClientQt::scaleContent):
(WebKit::PageViewportControllerClientQt::viewportScaleForRect):

UIProcess/qt/PageViewportControllerClientQt.h: Added.

(WebKit):
(PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setController):
(ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleStackItem::ScaleStackItem):
(ScaleStackItem):

UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::viewportController):

UIProcess/qt/QtGestureRecognizer.h:

(WebKit):

UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit::QtPanGestureRecognizer::cancel):

UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
(WebKit::QtPinchGestureRecognizer::cancel):

UIProcess/qt/QtViewportHandler.cpp: Removed.
UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::setViewportController):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::handleInputEvent):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
(WebKit::QtWebPageEventHandler::didFindZoomableArea):

UIProcess/qt/QtWebPageEventHandler.h:

(WebKit):
(QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::viewportController):

Tools:

Reviewed by Kenneth Rohde Christiansen.

Remove initial scale from viewport info item since it is
set to -1 after applied thus it does not hold any valuable
information.

MiniBrowser/qt/qml/ViewportInfoItem.qml:

3:13 AM Changeset in webkit [127719] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

Renamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in
which inadvertantly allows the ASM llint to use the baseline JIT when
useRegExpJIT() is true.
https://bugs.webkit.org/show_bug.cgi?id=95918.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-06
Reviewed by Geoffrey Garen.

runtime/JSGlobalData.cpp:

(JSC::enableAssembler):
(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):
(JSGlobalData):

runtime/Options.cpp:

(JSC::Options::initialize):

runtime/Options.h:

(JSC):

3:05 AM Changeset in webkit [127718] by commit-queue@webkit.org

6 edits
1 add in trunk/Source/WebCore

Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive
https://bugs.webkit.org/show_bug.cgi?id=95519

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

Add new V8DependentRetained that allows keeping a v8::Object alive as long as another
v8::Object is alive. This is useful for keeping callbacks attached to wrappers without
keeping strong references to v8::Objects in the C++ side which can result in leaks
when cycles are created.

No new tests needed, this will be used to fix MutationObservers which will have tests.

WebCore.gypi:
bindings/v8/V8DependentRetained.h: Added.

(WebCore):
(V8DependentRetained):
(WebCore::V8DependentRetained::V8DependentRetained):
(WebCore::V8DependentRetained::~V8DependentRetained):
(WebCore::V8DependentRetained::get): Gets the v8::Object value.
(WebCore::V8DependentRetained::isEmpty): Checks if the value is still alive.
(WebCore::V8DependentRetained::createPropertyName):
(WebCore::V8DependentRetained::ownerWeakCallback): Clear the value when the owner is released.
(WebCore::V8DependentRetained::valueWeakCallback):
(WebCore::V8DependentRetained::release):

bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::hiddenReferenceName): Modified to allow creating hidden String or Symbol names.

bindings/v8/V8HiddenPropertyName.h:

(V8HiddenPropertyName):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::nextDependentRetainedId): Returns the next available hidden property index.
(V8PerIsolateData):

2:54 AM Changeset in webkit [127717] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

2:52 AM Changeset in webkit [127716] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] Removing String operator += uses in Cookie Files
https://bugs.webkit.org/show_bug.cgi?id=95884

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Replacing all usages of String operator += in the Cookie code because it is being deprecated.
String concats are now done using + or StringBuilder.

PR 203054

Tested using Browser Test Cookie suite on browsertest01.rim.net/networking/cookies.

platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
(WebCore::CookieDatabaseBackingStore::invokeOpen):
(WebCore::CookieDatabaseBackingStore::invokeRemoveAll):

platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

2:48 AM Changeset in webkit [127715] by danakj@chromium.org

5 edits
1 add in trunk/Source

[chromium] Add a copy() method to CCRenderPass
https://bugs.webkit.org/show_bug.cgi?id=95485

Reviewed by Adrienne Walker.

Source/WebCore:

This method allows the ubercomp layer to make a clone of its delegated
RenderPasses to insert into the current frame.

Tests: CCRenderPassTest.copyShouldBeIdenticalExceptIdAndQuads

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::copy):
(WebCore):

platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCRenderPassTest.cpp: Added.

(CCTestRenderPass):
(CCTestRenderPass::quadList):
(CCTestRenderPass::sharedQuadStateList):
(CCRenderPassSize):
(TEST):

2:46 AM Changeset in webkit [127714] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Chromium Mac build fix after revision r127711
https://bugs.webkit.org/show_bug.cgi?id=95958

Unreviewed build fix.

This is a clear typo in the source file, so changing the function to
call locationModifiersFromWindowsKeyCode instead.

src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

2:42 AM Changeset in webkit [127713] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit2

[EFL][WK2] WebMemorySampler.cpp is included twice.
https://bugs.webkit.org/show_bug.cgi?id=95910

Reviewed by Kentaro Hara.

Now WebMemorySampler.cpp is in CMakeLists.txt and PlatformEfl.cmake.

PlatformEfl.cmake: Removed WebMemorySampler.cpp from source lists.

2:38 AM Changeset in webkit [127712] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

XMLHttpRequest.open does not need custom bindings
https://bugs.webkit.org/show_bug.cgi?id=95903

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

There doesn't appear to be any reason that XMLHttpRequest.open needs
custom bindings now that [Optional] works the way XMLHttpRequest
expects.

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore):
(WebCore::XMLHttpRequest::internalOpen):

xml/XMLHttpRequest.h:

(XMLHttpRequest):

xml/XMLHttpRequest.idl:

2:19 AM Changeset in webkit [127711] by commit-queue@webkit.org

9 edits
1 add in trunk/Source/WebKit/chromium

Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
https://bugs.webkit.org/show_bug.cgi?id=94142

Patch by Raymes Khoury <raymes@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Previously we distinguished between left/right Shift/Ctrl/Alt in
WebInputEvents by using the location-specific virtual keycodes (e.g.
VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
always returns the non-locational version (e.g. VK_SHIFT).
Furthermore, KeyboardEvent also returns
non-locational keycodes and separates the location information which
matches the behavior described in the DOM3
spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
should be consistent with this in our representation of key events.
This patch changes WebInputEvents so they always store the
non-locational keycode and location information is stored in
modifiers. Since this only changes internal representation, no new
tests are added.

This patch also ensures that when KeyboardEvents are converted back to
WebInputEvents location information is preserved (which was not
happening before). This is important so that key location information
is passed on to plugins. A unittest is added for this.

WebKit.gypi:
public/WebInputEvent.h:

(WebKeyboardEvent):

src/WebInputEvent.cpp:

(WebKit):
(WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
(WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):

src/WebInputEventConversion.cpp:

(WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):

src/android/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):

src/gtk/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):

src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

src/win/WebInputEventFactory.cpp:

(WebKit::getLocationModifier):
(WebKit::WebInputEventFactory::keyboardEvent):

tests/WebInputEventConversionTest.cpp: Added.

2:17 AM Changeset in webkit [127710] by commit-queue@webkit.org

10 edits in trunk

Three XSLTProcessor functions don't need to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=95899

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Source/WebCore:

These functions are marked [Custom] because they predate our
improvements to [Optional]. Now that we have
[Optional=DefaultIsUndefined], we can autogenerate these functions.

There is a (slight!) difference in behavior. Now, in the case of a type
error, we return null instead of undefined. This change is unlikely to
cause compatibility problems because the vast majority of folks will
pass the correct arguments, and, in the few cases where folks pass the
wrong argument types, null and undefined will likely work similarly
(e.g., they're both falsy and throw when you try to access properties).

bindings/js/JSXSLTProcessorCustom.cpp:
bindings/v8/custom/V8XSLTProcessorCustom.cpp:
xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::transformToDocument):
(WebCore::XSLTProcessor::transformToFragment):

xml/XSLTProcessor.h:

(WebCore::XSLTProcessor::importStylesheet):

xml/XSLTProcessor.idl:

LayoutTests:

Update results to show that we return null rather than undefined on a
type error.

fast/xsl/transform-xhr-doc-expected.txt:
fast/xsl/xslt-processor-expected.txt:
platform/chromium/fast/xsl/transform-xhr-doc-expected.txt:

2:02 AM Changeset in webkit [127709] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the failing tests.

platform/qt/Skipped:

1:56 AM Changeset in webkit [127708] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Remove String::operator+=() from plugin code
https://bugs.webkit.org/show_bug.cgi?id=95896

Reviewed by Adam Barth.

Use operator+() to concatenate strings instead of operator+=().

plugins/PluginView.cpp:

(WebCore::parseRFC822HeaderFields):

1:33 AM Changeset in webkit [127707] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Build fix for Interpreter after r127698.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

12:47 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt versions on the bots (diff)

12:47 AM Changeset in webkit [127706] by abarth@webkit.org

7 edits in trunk/Source/WebCore

More fixes for String::operator+=() in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=95888

Patch by Patrick Gansterer <Patrick Gansterer> on 2012-09-06
Reviewed by Adam Barth.

Use StringBuilder to concatenate strings instead of operator+=().

dom/Element.cpp:

(WebCore::Element::formatForDebugger):

dom/Node.cpp:

(WebCore::appendAttributeDesc):
(WebCore::Node::showNode):
(WebCore::traverseTreeAndMark):
(WebCore::Node::formatForDebugger):

dom/Position.cpp:

(WebCore::Position::formatForDebugger):

dom/Range.cpp:

(WebCore):
(WebCore::Range::formatForDebugger):

dom/Text.cpp:

(WebCore::Text::formatForDebugger):

editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::formatForDebugger):

12:40 AM Changeset in webkit [127705] by vsevik@chromium.org

15 edits in trunk

Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation.
https://bugs.webkit.org/show_bug.cgi?id=95752

Reviewed by Alexander Pavlov.

Source/WebCore:

NetworkUISourceCodeProvider does not receive ResourceAdded event until resource is finished anymore.
StylesSourceMapping now listens for workspace event instead of being called directly by NetworkUISourceCodeProvider.
StylesSourceMapping is now created from inspector.js.
ProjectDidReset event introduced instead of setTimeout hacks in mappings.

inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectDidReset):

inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._projectWillReset):
(WebInspector.ScriptSnippetModel.prototype._projectDidReset):

inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._addUISourceCode):
(WebInspector.StylesSourceMapping.prototype._reset):

inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController.prototype._mainFrameNavigated):
(WebInspector.Project.prototype.reset):

inspector/front-end/inspector.js:

LayoutTests:

http/tests/inspector/network/network-request-revision-content-expected.txt:
http/tests/inspector/network/network-request-revision-content.html:
inspector/console/console-uncaught-exception-expected.txt:
inspector/debugger/network-uisourcecode-provider-expected.txt:
inspector/debugger/network-uisourcecode-provider.html:
inspector/debugger/script-snippet-model.html:
inspector/debugger/scripts-panel.html:

12:35 AM Changeset in webkit [127704] by abarth@webkit.org

3 edits
4 adds in trunk

Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
https://bugs.webkit.org/show_bug.cgi?id=91110

Reviewed by Tony Chang.

Source/WebKit/chromium:

Prior to this patch, we were ignoring the user-scalable property of
viewport meta tags. This patch enforces the user-scalable property by
claming the minimum-scale and maximum-scale values, effectively
preventing user scaling. This approach isn't perfect, as discussed in
https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
over the status quo.

This approach is also used by EFL, GTK, and Qt.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

LayoutTests:

Test that the scale limits are clamped when user-scalable is set to no.

fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt: Added.
fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: Added.
fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt: Added.
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: Added.

12:28 AM Changeset in webkit [127703] by vsevik@chromium.org

12 edits in trunk

Unreviewed, rolling out r127700.
http://trac.webkit.org/changeset/127700
https://bugs.webkit.org/show_bug.cgi?id=95941

Breaks inspector closure compilation, uses not defined
variables. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp:

inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

inspector/front-end/CSSStyleModel.js:

rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

inspector/styles/protocol-css-regions-commands-expected.txt:
inspector/styles/protocol-css-regions-commands.html:

12:28 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

12:21 AM Changeset in webkit [127702] by abarth@webkit.org

3 edits in trunk/Source/WTF

Remove WTF::String::operator+=
https://bugs.webkit.org/show_bug.cgi?id=95797

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Sam Weinig.

This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.

wtf/Platform.h
wtf/text/WTFString.h:

12:16 AM Changeset in webkit [127701] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[V8] V8HTMLDocument has two out-of-style function names
https://bugs.webkit.org/show_bug.cgi?id=95893

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Just a simple style cleanup.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):
(WebCore::V8HTMLDocument::getNamedProperty):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed