Context Navigation

← Previous Period
Next Period →

Timeline

Sep 8, 2012:

11:48 PM Changeset in webkit [127976] by abarth@webkit.org

3 edits in trunk/Source/WebCore

[V8] unsafeHandleToCurrentWorldContext doesn't need to exist
https://bugs.webkit.org/show_bug.cgi?id=96191

Reviewed by Kentaro Hara.

Previously, we used this function when instantiating DOM wrappers. Now
we get the context from the creationContext, so we don't need access to
this unsafe handle. This patch inlines the function into its one other
caller.

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::currentWorldContext):

bindings/v8/ScriptController.h:

(ScriptController):

9:29 PM Changeset in webkit [127975] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
https://bugs.webkit.org/show_bug.cgi?id=96027

Patch by Max Feil <mfeil@rim.com> on 2012-09-08
Reviewed by Antonio Gomes.

The changes for bug 87337 (landed as trunk svn revision 119119)
introduced a bug. The same conditions are not checked on enter
fullscreen vs. exit. Web sites such as http://videojs.com
and youtube's mobile HTML5 player make the div container
of the video element go fullscreen. This is allowed in
WebPagePrivate::enterFullScreenForElement() but disallowed in
WebPagePrivate::exitFullScreenForElement(). I am fixing this by
allowing containers of video elements to exit fullscreen.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

5:35 PM Changeset in webkit [127974] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Specialize nextBreakablePosition depending on breakNBSP
https://bugs.webkit.org/show_bug.cgi?id=96042

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-08
Reviewed by Eric Seidel.

The speed of isBreakableSpace() is limited by the speed of the inner loop of nextBreakablePosition().
The branches done to handle noBreakSpace can be simplified outside the loop
to reduce the number of tests inside the loop.

This patch split the code of nextBreakablePosition() in two function, depending if breakNBSP is true
or false.

If breakNBSP is true, isBreakableSpace() would return true on noBreakSpace.
->There is no need to test that value again for needsLineBreakIterator().
->There is no need to special case the switch() of isBreakableSpace() for noBreakSpace.

If breakNBSP is false:
->isBreakableSpace() does not need to test for noBreakSpace.

On x86_64, this improves PerformanceTests/Layout/line-layout.html by 2.8%.

rendering/break_lines.cpp:

(WebCore::isBreakableSpace):
(WebCore::nextBreakablePositionIgnoringNBSP):
(WebCore::nextBreakablePosition):

rendering/break_lines.h:

(WebCore::isBreakable): Remove the default value for breakNBSP, no caller is using it.

12:50 PM Changeset in webkit [127973] by kling@webkit.org

2 edits in trunk/Source/WTF

Give AtomicString SimpleClassVectorTraits.
<http://webkit.org/b/96186>

Reviewed by Karl Anders Carlsson.

AtomicString can be initialized/moved/compared with memset/memcpy/memcmp,
so add a VectorTraits<AtomicString> to make Vector<AtomicString> a little
more efficient.

wtf/VectorTraits.h:

11:17 AM Changeset in webkit [127972] by commit-queue@webkit.org

24 edits
1 delete in trunk

[V8] DOM wrapper creation involves a bunch of sketchy code related to finding the Frame
https://bugs.webkit.org/show_bug.cgi?id=96147

Patch by Adam Barth <abarth@chromium.org> on 2012-09-08
Reviewed by Eric Seidel.

Source/WebCore:

Previously, we used the Frame when instantiating DOM wrappers. That's
sketchy because not all DOM wrappers know how to find their Frame, and
the Frame might be displaying a different document now anyway. This
patch now gets all the information directly from the creation context.

In addition, this patch gets the proper creation context in a few more
cases, including Location.

bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

bindings/v8/V8PerContextData.cpp:

(WebCore):
(WebCore::V8PerContextData::current):
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

The V8 results for this test now match the JSC results. We can remove
the chromium-specific baseline.

platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Removed.

8:24 AM Changeset in webkit [127971] by jchaffraix@webkit.org

12 edits
2 moves
5 deletes in trunk/LayoutTests

[Chromium] Layout Tests tables/mozilla/bugs/bug27038*.html are failing
https://bugs.webkit.org/show_bug.cgi?id=93006

Unreviewed Chromium rebaselining.

The tests were not rebaselined after bug 81826 (the TestExpectations were wrongly pointing
to bug 37244). The new rebaselines are expected as we add the extra logical height to the
last section, which was our original behavior before bug 37244.

platform/chromium-linux/tables/mozilla/bugs/bug27038-1-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.txt: Removed.
platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.txt:
platform/chromium/TestExpectations:
platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt: Removed.
tables/mozilla/bugs/bug27038-1-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt.
tables/mozilla/bugs/bug27038-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt.

5:21 AM Changeset in webkit [127970] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

LLInt buildfix for case sensitive filesystems
https://bugs.webkit.org/show_bug.cgi?id=96099

Reviewed by Michael Saboff.

llint/LowLevelInterpreter.cpp: Fix filenames.

4:37 AM Changeset in webkit [127969] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] Gardening of failing tests after r127939
https://bugs.webkit.org/show_bug.cgi?id=96182

Unreviewed EFL gardening of failing tests after r127939.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-08

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

3:57 AM Changeset in webkit [127968] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Minibrowser crashes on right mouse click
https://bugs.webkit.org/show_bug.cgi?id=95955

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-08
Reviewed by Simon Hausmann.

Make early return if the PageClient does not create a ContextMenuProxy.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

3:50 AM Changeset in webkit [127967] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt] Fix CoreIPC setup between ProcessLauncher and WebProcessMain on Windows
https://bugs.webkit.org/show_bug.cgi?id=96179

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-08
Reviewed by Kenneth Rohde Christiansen.

UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Hide Unixy platform specific code
and includes behind appropriate platform #ifdefs and use
CoreIPC::Connection::createServerAndClientIdentifiers to set up the IPC pipes.
We also need to tell Windows about our intent of using the client handle in
the child web process.

WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt): After retrieving the IPC identifier we call
WebKit::WebProcess::shared().initialize with it. That function actually
cares a CIPC::Connection::Identifier as argument, which happens to be an
int on Unix, but it's actually a HANDLE on Windows. Change the parameter
type according to and a reinterpret_cast from the converted unsigned integer,
similar to WebProcessMainWin.cpp.

3:48 AM Changeset in webkit [127966] by commit-queue@webkit.org

11 edits in trunk

[WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
https://bugs.webkit.org/show_bug.cgi?id=95329

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add implementation for overriding the WebKitTabToLinksPreferenceKey
preference as well as the corresponding WKPreferences API that
is needed by WebKitTestRunner.

Shared/WebPreferencesStore.h:

(WebKit):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTabToLinksEnabled):
(WKPreferencesGetTabToLinksEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setTabToLinksEnabled):
(WebKit::WebPage::tabToLinksEnabled):

Tools:

Explicitely disable TabToLinks setting in WebKitTestRunner.
Tests override the "WebKitTabToLinksPreferenceKey" preference
to enable it.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Unskip fast/events/tab-focus-link-in-canvas for WK2 now that WebKitTestRunner
supports overriding the "WebKitTabToLinksPreferenceKey" preference.

platform/efl-wk2/TestExpectations:
platform/wk2/Skipped:

12:36 AM Changeset in webkit [127965] by bashi@chromium.org

2 edits in trunk/Tools

webkit.py gdb pretty printer can't print CString
https://bugs.webkit.org/show_bug.cgi?id=96068

Reviewed by Tony Chang.

Update WTFCStringPrinter to follow r126191.

gdb/webkit.py:

(WTFCStringPrinter.to_string):

12:31 AM Changeset in webkit [127964] by anilsson@rim.com

10 edits
3 adds in trunk/Source/WebCore

[CSS Shaders] [BlackBerry] Refactor CustomFilterMesh and CustomFilter*Program
https://bugs.webkit.org/show_bug.cgi?id=94725

Reviewed by George Staikos.

Separate the MeshGenerator from the CustomFilterMesh into
CustomFilterMeshGenerator.h/cpp. This allows the BlackBerry port to
reuse the mesh generator in its accelerated compositing implementation.

Also add support for creating a "PlatformCompiledProgram" from a
CustomFilterValidatedProgram, so the BlackBerry port can reuse the
shader validation code in its accelerated compositing implementation.

It turns out the GraphicsContext3D is not needed for ANGLE to function,
so this patch removes an ASSERT that required a context before
validating the shaders using ANGLE. This allows the BlackBerry port to
reuse the validation code without triggering the assert. In the future,
the validation code could be moved to a separate class to make it more
obvious that it isn't really related to GraphicsContext3D.

In general, this refactoring can be useful for any port that uses
OpenGL to implement accelerated compositing.

Inspired by an original patch by Joshua Netterfield.

No new tests, because this patch implements no new functionality.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):

platform/graphics/filters/CustomFilterMeshGenerator.cpp: Added.

(WebCore):
(WebCore::CustomFilterMeshGenerator::CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshIndex):
(WebCore::CustomFilterMeshGenerator::generateAttachedMesh):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::CustomFilterMeshGenerator::generateDetachedMesh):
(WebCore::CustomFilterMeshGenerator::addPositionAttribute):
(WebCore::CustomFilterMeshGenerator::addTexCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addMeshCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addTriangleCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::dumpBuffers):

platform/graphics/filters/CustomFilterMeshGenerator.h: Added.

(WebCore):
(CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::vertices):
(WebCore::CustomFilterMeshGenerator::indices):
(WebCore::CustomFilterMeshGenerator::points):
(WebCore::CustomFilterMeshGenerator::pointsCount):
(WebCore::CustomFilterMeshGenerator::tiles):
(WebCore::CustomFilterMeshGenerator::tilesCount):
(WebCore::CustomFilterMeshGenerator::indicesCount):
(WebCore::CustomFilterMeshGenerator::floatsPerVertex):
(WebCore::CustomFilterMeshGenerator::verticesCount):
(WebCore::CustomFilterMeshGenerator::addTile):

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

platform/graphics/filters/CustomFilterValidatedProgram.h:

(WebCore):
(CustomFilterValidatedProgram):

platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Added.

(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

Sep 7, 2012:

11:57 PM Changeset in webkit [127963] by dmazzoni@google.com

7 edits in trunk/LayoutTests

Rebaselining accessibility test expectations

11:49 PM Changeset in webkit [127962] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove browser from the build info page
https://bugs.webkit.org/show_bug.cgi?id=96162

Patch by Ming Xie <mxie@rim.com> on 2012-09-07
Reviewed by George Staikos.
Internal reviewed by Jeff Rogers.

WebKit build should not have the build info for browser which is
built on top of webkit.

WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::buildPage):

11:21 PM Changeset in webkit [127961] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix the build of OpenGLShims on Windows
https://bugs.webkit.org/show_bug.cgi?id=96123

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

OpenGL functions on Windows are generally defined as stdcall, so we need to make sure
that we declare our own "copies" of those functions with the same calling convention.

This is also required for the situation where we build against ANGLE, because then we
initialize the function table entries with a direct assignment (entry = ::glMyFunction())
and the assignment does not compile if the types don't match, i.e. if RHS has a different
calling convention than LHS.

The approach chosen is basically the same as in the Khronos headers,
using a GLAPIENTRY macro.

platform/graphics/OpenGLShims.h:

11:16 PM Changeset in webkit [127960] by benjamin@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed prospective build fix.

tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include.

Remove the using directive from r127959.

10:53 PM Changeset in webkit [127959] by Simon Hausmann

2 edits in trunk/Source/WebKit/chromium

Unreviewed prospective build fix.

Use WTF namespace like in other files in the same directory to resolve unqualified
adoptPtr correctly.

tests/WebCompositorInputHandlerImplTest.cpp:

10:46 PM Changeset in webkit [127958] by benjamin@webkit.org

47 edits in trunk

Rename the ustring() accessor to string()
https://bugs.webkit.org/show_bug.cgi?id=95919

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-07
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Rename ustring() to string() to make the accessor name more logical after
r127191.

API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):
(JSObjectMakeFunction):
(JSObjectCopyPropertyNames):

API/JSProfilerPrivate.cpp:

(JSStartProfiling):
(JSEndProfiling):

API/JSValueRef.cpp:

(JSValueMakeString):
(JSValueMakeFromJSONString):

API/OpaqueJSString.cpp:

(OpaqueJSString::string):

API/OpaqueJSString.h:

(OpaqueJSString):

bytecode/CodeBlock.cpp:

(JSC::idName):
(JSC::CodeBlock::dump):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):

bytecompiler/NodesCodegen.cpp:

(JSC::RegExpNode::emitBytecode):
(JSC::processClauseList):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jsc.cpp:

(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createRegExp):

parser/Parser.cpp:

(JSC::::parsePrimaryExpression):

parser/Parser.h:

(JSC::Scope::declareVariable):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createRegExp):

runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):

runtime/Executable.cpp:

(JSC::FunctionExecutable::paramString):

runtime/Executable.h:

(JSC::FunctionExecutable::finishCreation):

runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

runtime/Identifier.h:

(JSC::Identifier::string):

runtime/JSFunction.cpp:

(JSC::JSFunction::calculatedDisplayName):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSONObject.cpp:

(JSC::PropertyNameForFunctionCall::value):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::finishCreation):

runtime/JSScope.cpp:

(JSC::JSScope::resolveBase):

runtime/JSString.h:

(JSC::inlineJSValueNotStringtoString):

runtime/LiteralParser.cpp:

(JSC::::parse):

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):

Source/WebCore:

bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

bindings/js/SerializedScriptValue.cpp:

Simplify a few String constructions which were still using type conversion
through StringImpl.

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::CachedString::string):
(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::CloneDeserializer::deserialize):

bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

Source/WebKit/efl:

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::sendWebIntentResponse):
(DumpRenderTreeSupportEfl::deliverWebIntent):
Aslo update the code from the UString->String conversion through StringImpl.

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

Tools:

Update EFL's DRT.

Fix some string conversion that have been made useless
with recent changes.

DumpRenderTree/efl/EventSender.cpp:

(keyPadNameFromJSValue):
(keyNameFromJSValue):

DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::queueLoad):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::elementDoesAutoCompleteForElementWithId):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::pauseAnimationAtTimeOnElementWithId):
(TestRunner::pauseTransitionAtTimeOnElementWithId):
(toInt):
(TestRunner::overridePreference):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::setTextDirection):

DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

10:02 PM Changeset in webkit [127957] by commit-queue@webkit.org

21 edits
2 adds in trunk

Unreviewed, rolling out r127955.
http://trac.webkit.org/changeset/127955
https://bugs.webkit.org/show_bug.cgi?id=96174

Hits an ASSERT (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCallback.cpp:

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Added.

7:05 PM Changeset in webkit [127956] by jpfau@apple.com

28 edits
2 copies
4 adds in trunk

Extend third-party storage blocking API to optionally allow blocking all storage
https://bugs.webkit.org/show_bug.cgi?id=95915

Reviewed by Brady Eidson.

Source/WebCore:

Replace boolean API with tri-state API that allows for blocking no, third-party, or all storage.

Tests: http/tests/security/same-origin-shared-worker-blocked.html

http/tests/security/same-origin-storage-blocked.html
http/tests/security/same-origin-websql-blocked.html

dom/Document.cpp:

(WebCore::Document::initSecurityContext):

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::canAccessStorage):

page/SecurityOrigin.h:

(WebCore::SecurityOrigin::setStorageBlockingPolicy):
(SecurityOrigin):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setStorageBlockingPolicy):
(WebCore::Settings::storageBlockingPolicy):
(Settings):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setStorageBlockingPolicy):

testing/InternalSettings.h:

(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit2:

Update WK2 API to use revised Settings API.

Shared/WebPreferencesStore.h:

(WebKit):

UIProcess/API/C/WKAPICast.h:

(WebKit::toStorageBlockingPolicy):
(WebKit):
(WebKit::toAPI):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetStorageBlockingPolicy):
(WKPreferencesGetStorageBlockingPolicy):

UIProcess/API/C/WKPreferences.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Modified API test to use new revised API.

TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

Update tests to use revised API.

http/tests/security/cross-origin-local-storage.html:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html:
http/tests/security/cross-origin-plugin.html:
http/tests/security/cross-origin-session-storage.html:
http/tests/security/cross-origin-shared-worker.html:
http/tests/security/cross-origin-websql.html:
http/tests/security/cross-origin-worker-websql.html:
http/tests/security/resources/document-for-cross-origin-worker-websql.html:
http/tests/security/same-origin-document-domain-storage-allowed.html:
http/tests/security/same-origin-shared-worker-blocked-expected.txt: Added.
http/tests/security/same-origin-shared-worker-blocked.html: Added.
http/tests/security/same-origin-storage-blocked-expected.txt: Added.
http/tests/security/same-origin-storage-blocked.html: Added.
http/tests/security/same-origin-websql-blocked-expected.txt: Added.
http/tests/security/same-origin-websql-blocked.html: Added.
platform/chromium/TestExpectations:

6:39 PM Changeset in webkit [127955] by abarth@webkit.org

21 edits
1 delete in trunk

[V8] DOM wrapper creation involves a bunch of sketchy code related to finding the Frame
https://bugs.webkit.org/show_bug.cgi?id=96147

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

Source/WebCore:

In addition, this patch gets the proper creation context in a few more
cases, including Location.

bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCallback.cpp:

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

bindings/v8/V8PerContextData.cpp:

(WebCore):
(WebCore::V8PerContextData::current):
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

The V8 results for this test now match the JSC results. We can remove
the chromium-specific baseline.

platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Removed.

6:36 PM Changeset in webkit [127954] by jamesr@google.com

2 edits in trunk/LayoutTests

Skip some tests that appear to be making bots unstable.

platform/chromium/TestExpectations:

6:33 PM Changeset in webkit [127953] by jamesr@google.com

2 edits in trunk/Source/Platform

[chromium] Remove unused WebScrollbarThemePainter::isNull
https://bugs.webkit.org/show_bug.cgi?id=96169

Reviewed by Adrienne Walker.

This doesn't appear to be used anywhere and triggers MSVS C4800 in any chromium file that #includes this header.

chromium/public/WebScrollbarThemePainter.h:

6:32 PM Changeset in webkit [127952] by jamesr@google.com

11 edits in trunk/Source

[chromium] Remove transitional WebCompositorSupport fallback code
https://bugs.webkit.org/show_bug.cgi?id=96155

Reviewed by Adrienne Walker.

Source/WebCore:

The implementation of WebCompositorSupport has rolled out everywhere and the static ::create() functions are
going way.

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::createWebAnimation):

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimation):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::readyStateChanged):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

6:30 PM Changeset in webkit [127951] by Lucas Forschler

4 edits in trunk/Source

Versioning.

6:30 PM Changeset in webkit [127950] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix compilation of TextureMapperShaderManager.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=96121

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Named variadic parameters in macros appear to be a GCC extension. Fortunately VA_ARGS seems
to work with GCC and MSVC here.

platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::StandardFilterProgram::StandardFilterProgram):

6:28 PM Changeset in webkit [127949] by vrk@chromium.org

3 edits
2 adds in trunk

Seek to end after duration change in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=95986

Reviewed by Eric Carlson.

This seeks the media element to the end of the media resource if the current playback
position has become greater than the duration after a duration change.
http://dev.w3.org/html5/spec/media-elements.html#durationChange

Source/WebCore:

Test: http/tests/media/media-source/seek-to-end-after-duration-change.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerDurationChanged): After firing the duration change event, checks to see if current time exceeds duration and if so, seeks to duration.

LayoutTests:

http/tests/media/media-source/seek-to-end-after-duration-change-expected.txt: Added.
http/tests/media/media-source/seek-to-end-after-duration-change.html: Added.

6:22 PM Changeset in webkit [127948] by jamesr@google.com

25 edits
3 copies
1 add in trunk/Source

[chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
https://bugs.webkit.org/show_bug.cgi?id=96151

Reviewed by Adrienne Walker.

Source/Platform:

This adds public input handling interfaces for the compositor.

chromium/public/WebInputHandler.h:

(WebKit):
(WebInputHandler):
(WebKit::WebInputHandler::~WebInputHandler):

chromium/public/WebInputHandlerClient.h:

(WebKit):
(WebInputHandlerClient):
(WebKit::WebInputHandlerClient::~WebInputHandlerClient):

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

chromium/public/WebLayerTreeViewClient.h:

(WebKit):
(WebKit::WebLayerTreeViewClient::createInputHandler):
(WebLayerTreeViewClient):

Source/WebCore:

Reworks the CC hookup for input handling to be more similar to the OutputSurface handling. If on compositor
startup we want to initialize threaded input handling, we ask the embedder for a CCInputHandler implementation
via CCLayerTreeHostClient. If the client provides one, we later bind this to a CCInputHandlerClient (actually
CCLayerTreeHostImpl) from the compositor thread.

platform/graphics/chromium/cc/CCInputHandler.h:

(WebCore):
(CCInputHandler):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::createInputHandler):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHostClient.h:

(WebCore):
(CCLayerTreeHostClient):

platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals.
WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is
provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC.

WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl
and storing its identifier for the didActivateCompositor call. From this point on the setup is the same as
before.

WCIHI changes covered by unit tests, overall scrolling behavior manually tested.

WebKit.gypi:
src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::fromIdentifier):
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::setClient):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::bindToClient):

src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::identifier):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createInputHandler):
(WebKit):

src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

src/WebToCCInputHandlerAdapter.cpp: Added.

(WebKit):
(WebKit::WebToCCInputHandlerAdapter::create):
(WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter):
(WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter):
(WebToCCInputHandlerAdapter::ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::bindToClient):
(WebKit::WebToCCInputHandlerAdapter::animate):

src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h.

(WebKit):
(WebToCCInputHandlerAdapter):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
(WebKit::WebViewImpl::createInputHandler):

src/WebViewImpl.h:

(WebViewImpl):

tests/CCThreadedTest.cpp:
tests/FakeCCLayerTreeHostClient.h:
tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):
(WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient):
(WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):
(WebKit::TEST_F):

6:20 PM Changeset in webkit [127947] by Lucas Forschler

1 copy in tags/Safari-537.9

New Tag.

6:17 PM Changeset in webkit [127946] by abarth@webkit.org

88 edits in trunk/Source/WebCore

[V8] Use a v8::Object rather than a v8::Context to represent the creationContext
https://bugs.webkit.org/show_bug.cgi?id=96154

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

This patch is a mechanical search-and-replace. Using a v8::Object
rather than a v8::Context lets us delay the call to CreationContext()
until we actually need to call it. This should not affect behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::toV8):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestCallback.cpp:

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::mutablePointAttrGetter):
(WebCore::TestObjV8Internal::immutablePointAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::callFunction):

bindings/v8/IDBCustomBindings.cpp:

(WebCore::V8IDBCursorWithValue::valueAccessorGetter):

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8Binding.h:

(WebCore::V8ValueTraits::arrayV8Value):

bindings/v8/V8Collection.h:

(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

bindings/v8/V8ThrowException.cpp:

(WebCore):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):
(WebCore::V8Blob::constructorCallback):

bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):

bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::memoryAccessorGetter):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::toV8):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::toV8):
(WebCore::V8Document::createTouchListCallback):

bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore::toV8):

bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::getNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
(WebCore::toV8):

bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):
(WebCore::V8HTMLElement::itemValueAccessorGetter):

bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

bindings/v8/custom/V8HTMLOutputElementCustom.cpp:

(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):

bindings/v8/custom/V8PerformanceCustom.cpp:

(WebCore::V8Performance::memoryAccessorGetter):

bindings/v8/custom/V8PerformanceEntryCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

6:09 PM Changeset in webkit [127945] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Check objects for null when recreating context
https://bugs.webkit.org/show_bug.cgi?id=95926

Patch by John Bauman <jbauman@chromium.org> on 2012-09-07
Reviewed by Dean Jackson.

Upon navigation the FrameViwe and other objects may go null, so detect
that and return rather than try to dereference them.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

5:59 PM Changeset in webkit [127944] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

CALLFRAME_OFFSET and EXCEPTION_OFFSET are same in ctiTrampoline on ARM Thumb2
https://bugs.webkit.org/show_bug.cgi?id=82013

Reviewed by Geoff Garen.

Neither of these values need to be stored. At all.

jit/JITStubs.cpp:

(JSC):
(JSC::ctiTrampoline):
(JSC::JITThunks::JITThunks):

Nothing to see here. Move along.

5:48 PM Changeset in webkit [127943] by Simon Fraser

5 edits
2 adds in trunk

box-shadow causes overlay scrollbars to be in the wrong position when element is composited
https://bugs.webkit.org/show_bug.cgi?id=85647

Reviewed by James Robinson.

Test overlay scrollbars in composited layers.

ManualTests/scrollbars/scrollbars-in-composited-layers.html: Added.

Source/WebCore:

The code that positioned the GraphicsLayers for scrollbars failed to take
into account any offset between the origin of the compositing layer,
and the renderer. This caused scrollbar layers to be misplaced or hidden
on layers with, for example, box-shadows.

Also moved the code that positions the scrollbar layers into RendderLayerBacking,
since this is where all the rest of the GraphicsLayer-positioning code lives.

Renamed an "offsetFromLayer" param to "offsetFromRoot" which is more accurate.

Manual test, since overlay scrollbars are not enabled in DRT/WTR:

ManualTests/scrollbars/scrollbars-in-composited-layers.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::positionOverflowControls):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

5:42 PM Changeset in webkit [127942] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] [WK2] Set theme for the inspector view
https://bugs.webkit.org/show_bug.cgi?id=96108

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Set the theme for the inspector view when it is created.

UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

5:32 PM Changeset in webkit [127941] by commit-queue@webkit.org

5 edits in trunk/Source

Unreviewed, rolling out r127938.
http://trac.webkit.org/changeset/127938
https://bugs.webkit.org/show_bug.cgi?id=96166

It broke the build (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/JavaScriptCore:

llint/LowLevelInterpreter.cpp:

(JSC):
(JSC::CLoop::execute):

offlineasm/cloop.rb:

Source/WTF:

wtf/Assertions.h:

5:25 PM Changeset in webkit [127940] by commit-queue@webkit.org

5 edits in trunk/Source

[Chromium] Multiple commits without invalidation allowed per redraw.
https://bugs.webkit.org/show_bug.cgi?id=95661

Patch by David Reveman <reveman@chromium.org> on 2012-09-07
Reviewed by James Robinson.

Source/WebCore:

Always enter COMMIT_STATE_WAITING_FOR_FIRST_DRAW after commit. This
ensures we draw before beginning a new frame.

Unit tests: CCLayerTreeHostTestContinuousCommit.runMultiThread

CCLayerTreeHostTestContinuousInvalidate.runMultiThread
CCLayerTreeHostTestContinuousAnimate.runMultiThread

platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::updateState):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestContinuousCommit):
(WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit):
(WebKitTests):
(WebKitTests::TEST_F):
(CCLayerTreeHostTestContinuousInvalidate):
(WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate):
(CCLayerTreeHostTestContinuousAnimate):
(WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate):

tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

4:59 PM Changeset in webkit [127939] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

Refactored bytecode generator initialization to support moving captured vars around
https://bugs.webkit.org/show_bug.cgi?id=96159

Reviewed by Gavin Barraclough.

This patch separates the stages of allocating registers, declaring identifiers
in the symbol table, and initializing registers, so you can change
allocation decisions without breaking the world.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Call a set of helper functions
instead of inlining all the code, to help clarity.

(JSC::BytecodeGenerator::allocateCapturedVars):
(JSC::BytecodeGenerator::allocateUncapturedVars):
(JSC::BytecodeGenerator::allocateActivationVar):
(JSC::BytecodeGenerator::allocateArgumentsVars):
(JSC::BytecodeGenerator::allocateCalleeVarUndeclared):
(JSC::BytecodeGenerator::declareParameters):
(JSC::BytecodeGenerator::declareCallee):
(JSC::BytecodeGenerator::initCalleeVar):
(JSC::BytecodeGenerator::initArgumentsVars):
(JSC::BytecodeGenerator::initActivationVar):
(JSC::BytecodeGenerator::initThisParameter):
(JSC::BytecodeGenerator::initFunctionDeclarations):
(JSC::BytecodeGenerator::declareParameter):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::createActivationIfNecessary): Factored these
helper functions out from pre-existing code.

bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::addVar):

parser/Nodes.h:

(JSC::DeclarationStacks::VarDeclaration::VarDeclaration):
(VarDeclaration):
(JSC::DeclarationStacks::FunctionDeclaration::FunctionDeclaration):
(FunctionDeclaration): Declaration stacks get a little more data now,
to support allocating registers before putting things in the symbol
table. I'm convinced that we should eventually just expand the symbol
table to understand these things.

4:58 PM Changeset in webkit [127938] by commit-queue@webkit.org

5 edits in trunk/Source

Source/JavaScriptCore: Fix a llint C++ interpreter bugs.
https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-07
Reviewed by Filip Pizlo.

llint/LowLevelInterpreter.cpp:

(JSC):
(JSC::CLoop::execute):

offlineasm/cloop.rb:

Source/WTF: Fixed ASSERT() and ASSERT_AT() macros so that they can be used in
comma expressions.
https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-07
Reviewed by Filip Pizlo.

wtf/Assertions.h:

(wtfAssert):

4:54 PM Changeset in webkit [127937] by tony@chromium.org

8 edits in trunk/Source/WebCore

Add OVERRIDE to computeLogical{Width,Height} overrides
https://bugs.webkit.org/show_bug.cgi?id=96153

Reviewed by Ojan Vafai.

I plan on renaming these functions to updateLogical{Width,Height} and
I want to be extra sure that I don't mess up.

No new tests, this is just a refactoring.

rendering/RenderFlowThread.h: Also mark the functions virtual!
rendering/RenderListBox.h:

(RenderListBox):

rendering/RenderMeter.h:

(RenderMeter):

rendering/RenderTable.h:

(RenderTable):

rendering/RenderTableCell.h:

(RenderTableCell):

rendering/RenderTextControl.h:

(RenderTextControl):

rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

4:46 PM Changeset in webkit [127936] by dmazzoni@google.com

15 edits
2 adds in trunk

AX: WebCore accessibility roles should be cross-platform
https://bugs.webkit.org/show_bug.cgi?id=94870

Reviewed by Chris Fleizach.

Source/WebCore:

Make 5 accessibility roles cross-platform rather than GTK-only.

Instead of mapping the HR tag to SplitterRole (which is an interactive
splitter control on Mac), create a new role HorizontalRuleRole.

Map all of the new roles to AXGroup on Mac, which matches the existing
behavior. Add a new test for these roles on Chromium.

Test: platform/chromium/accessibility/chromium-only-roles.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAAttributes):

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap):

Source/WebKit/chromium:

Add a new accessibility role.

public/WebAccessibilityRole.h:
src/AssertMatchingEnums.cpp:

Tools:

Add debug strings to Chromium for new accessibility roles.

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(roleToString):

LayoutTests:

Adds a test for some new accessibility roles that aren't present on all platforms.

platform/chromium/accessibility/chromium-only-roles-expected.txt: Added.
platform/chromium/accessibility/chromium-only-roles.html: Added.

4:27 PM Changeset in webkit [127935] by ojan@chromium.org

11 edits
1 move
1 delete in trunk/LayoutTests

Rebaselines after http://trac.webkit.org/changeset/127915.

fast/css/percent-top-value-with-relative-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/percent-top-value-with-relative-position-expected.txt.
platform/chromium-mac-snowleopard/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium-mac/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium-win/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/fast/css/percent-top-value-with-relative-position-expected.txt: Removed.
platform/mac/TestExpectations:
platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt:
platform/qt/TestExpectations:
platform/qt/fast/css/percent-top-value-with-relative-position-expected.txt:

4:19 PM Changeset in webkit [127934] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix build of GraphicsContext3DOpenGLCommon.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=96120

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Noam Rosenthal.

Variable stack arrays are a GCC extension. Replace their use with OwnArrayPtr, similar to
other functions in the same file.

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getActiveAttrib):

4:16 PM Changeset in webkit [127933] by eae@chromium.org

17 edits
3 adds in trunk

Prevent overflows in FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=95883

Reviewed by Eric Seidel.

Source/WebCore:

Avoid overflow in snapSizeToPixel by using the fraction of the
location instead of the full value.

Add safe versions of min/max, adjusted by half a pixel to allow
round to allow rounding without overflowing.

Avoid overflow when snapping a FractionalLayoutRect by using the
safe versions of min/max in infiniteRect.

Avoid overflow when converting from a Length to a LayoutUnit by
limiting the value to FractionalLayoutUnit min/max. This matches
the behavior of the non-subpixel code path where the values are
similarly limited.

Test: fast/sub-pixel/large-sizes.html

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Limit to FractionalLayoutUnit min/max.

platform/FractionalLayoutUnit.h:

(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::nearlyMax):
(WebCore::FractionalLayoutUnit::nearlyMin):
Reduce max/increase min by 1/2 to allow round to operate
without overflowing.

(WebCore::snapSizeToPixel):

platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::infiniteRect):
Use nearlyMin/nearlyMax.

(WebCore::pixelSnappedIntRect):
Change pixelSnappedIntRect to use snapSizeToPixel.

LayoutTests:

Add test for handling of large values.

fast/sub-pixel/large-sizes-expected.txt: Added.
fast/sub-pixel/large-sizes.html: Added.
platform/chromium-win/media/video-zoom-controls-expected.txt:
platform/chromium/fast/css/large-number-round-trip-expected.txt: Added.
platform/mac-lion/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac-wk2/Skipped:
platform/mac/Skipped:
platform/qt-4.8/Skipped:
platform/qt/Skipped:
platform/win-wk2/Skipped:
platform/win-xp/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

3:58 PM Changeset in webkit [127932] by commit-queue@webkit.org

11 edits
4 deletes in trunk

Unreviewed, rolling out r127920 and r127926.
http://trac.webkit.org/changeset/127920
http://trac.webkit.org/changeset/127926
https://bugs.webkit.org/show_bug.cgi?id=96152

billions and billions of assertion failures on mac debug
builds (Requested by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

WebCore.exp.in:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::registerCustomFont):
(WebCore):
(WebCore::Document::deleteCustomFonts):
(WebCore::Document::reportMemoryUsage):

dom/Document.h:

(WebCore):
(Document):

platform/graphics/FontData.h:
platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):

platform/graphics/FontFallbackList.h:

(FontFallbackList):
(WebCore::FontFallbackList::setGlyphPageZero):
(WebCore::FontFallbackList::setGlyphPages):

platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::pruneFontData):

LayoutTests:

fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Removed.
fast/frames/seamless/seamless-custom-font-pruning-crash.html: Removed.
fast/frames/seamless/seamless-nested-crash-expected.txt: Removed.
fast/frames/seamless/seamless-nested-crash.html: Removed.

3:55 PM Changeset in webkit [127931] by dmazzoni@google.com

7 edits in trunk

AX: Chromium needs access to canvasHasFallbackContent
https://bugs.webkit.org/show_bug.cgi?id=96124

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

Expose canvasHasFallbackContent on Chromium.

public/WebAccessibilityObject.h:

(WebAccessibilityObject):

src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::canvasHasFallbackContent):
(WebKit):

Tools:

Distinguish between canvas roles with and without fallback
content on Chromium.

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(getRole):

LayoutTests:

Update canvas test to distinguish between canvas elements with
fallback content on Chromium.

platform/chromium/accessibility/canvas-description-and-role-expected.txt:

3:50 PM Changeset in webkit [127930] by barraclough@apple.com

4 edits in trunk

Object.prototype.define{G,S}etter with non-callable second parameter should throw TypeError instead of SyntaxError
https://bugs.webkit.org/show_bug.cgi?id=93873

Reviewed by Sam Weinig.

Source/JavaScriptCore:

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):

throw TypeError instead of SyntaxError

(JSC::objectProtoFuncDefineSetter):

throw TypeError instead of SyntaxError

LayoutTests:

fast/js/property-getters-and-setters-expected.txt:
- updated results

3:39 PM Changeset in webkit [127929] by anilsson@rim.com

2 edits in trunk/Source/WebCore

[CSS Shaders] WebKitCSSMixFunctionValue.h needs forward declaration of MemoryObjectInfo
https://bugs.webkit.org/show_bug.cgi?id=96150

Reviewed by George Staikos.

Otherwise files that include it may fail to compile.

No new tests, because this patch implements no new functionality.

css/WebKitCSSMixFunctionValue.h:

(WebCore):

3:25 PM Changeset in webkit [127928] by msaboff@apple.com

2 edits in trunk/Source/WTF

StringImpl::find(StringImpl*) doesn't handle cases where search and match strings are different bitness
https://bugs.webkit.org/show_bug.cgi?id=96125

Reviewed by Benjamin Poulain.

Changed findInner and reverseFindInner to be templated on both search and match character types.
Changed both find's and reverseFind to use all four bitness combinations of findInner and
reverseFindInner.

wtf/text/StringImpl.cpp:

(WTF::findInner):
(WTF::StringImpl::find):
(WTF::reverseFindInner):
(WTF::StringImpl::reverseFind):

3:22 PM Changeset in webkit [127927] by ojan@chromium.org

8 edits in trunk/LayoutTests

Fix the remaining linter errors. These are all cases of paths
that don't actually exist or that are duplicated between TestExpectations
and Skipped files. I left in the Skipped file entries since those
were the ones that win out when duplicated.

platform/efl/TestExpectations:
platform/mac/TestExpectations:
platform/qt-4.8/TestExpectations:
platform/qt/Skipped:
platform/qt/TestExpectations:
platform/win/Skipped:
platform/win/TestExpectations:

3:13 PM Changeset in webkit [127926] by schenney@chromium.org

2 edits in trunk/Source/WebCore

Mac build fix.
https://bugs.webkit.org/show_bug.cgi?id=93640

Reviewed by Abhishek Arya.

The original patch for this bug broke the mac builds.

WebCore.exp.in: Adding const marker

3:06 PM Changeset in webkit [127925] by ojan@chromium.org

3 edits in trunk/Tools

Handle non-existant TestExpectations files gracefully
https://bugs.webkit.org/show_bug.cgi?id=96149

Reviewed by Eric Seidel.

Even when we get rid of Skipped files, we shouldn't have each port
require a TestExpectations file for each platform if it doesn't
need one.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.expectations_dict):

Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_nonexistant_expectations):

2:57 PM Changeset in webkit [127924] by rjkroege@chromium.org

8 edits
2 moves in trunk/Source

[chromium] Add touchscreen specific fling curve parametrization
https://bugs.webkit.org/show_bug.cgi?id=95997

Reviewed by James Robinson.

Added a new set of fling curve parameters with a good feel for touchscreen
initiated flings. Renamed TouchpadFlingPlatformGestureCurve to
TouchFlingPlatformGestureCurve to better reflect that the class
can serve for both touchscreen and touchpad flings when appropriately
parametrized. Updated build files as necessary for the rename.

No new tests - existing tests apply.

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::fireUpAnAnimation):

platform/TouchFlingPlatformGestureCurve.cpp: Renamed from Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp.

(WebCore):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):
Added with touchscreen parameters.
(WebCore::TouchFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::~TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::debugName):
(WebCore::TouchFlingPlatformGestureCurve::apply):

platform/TouchFlingPlatformGestureCurve.h: Renamed from Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h.

(WebCore):
(TouchFlingPlatformGestureCurve):

platform/chromium/support/PlatformGestureCurveFactory.cpp: invokes

createForTouchPad or createForTouchScreen as appropriate.
(WebKit::PlatformGestureCurveFactory::createCurve):

Source/WebKit/chromium:

tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor.

2:50 PM WebKit Team edited by Elliott Sprehn

David Barr doesn't work for Google anymore (diff)

2:49 PM WebKit Team edited by Elliott Sprehn

Add myself! (diff)

2:45 PM Changeset in webkit [127923] by commit-queue@webkit.org

11 edits in trunk

Enter the creationContext before creating DOM wrappers
https://bugs.webkit.org/show_bug.cgi?id=96044

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

Source/WebCore:

Now that we have the creationContext available when instantiating DOM
wrappers, we should use it! After this patch, we enter the creation
context so that the DOM wrapper is created in the right context (and
therefore has the right prototype chain).

This patch would have been tested by
fast/dom/prototype-inheritance.html, but that test was removed because
it was too much work to maintain. I'll post what the diff would have
been to the results for that test as an attachment to this bug.

Note: After this patch there are a number of cleanup patches to write,
but I'll do those separately.

bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

This patch also includes a minor bug fix to the JSC implementations of Geolocation and Notifications. Previously, JSC was using the current lexical context for the callback object, which makes very little sense as it neither cooresponds to the Geolocation (or Notification) object or the functions being used for the callback.

To be consistent with how we do callbacks elsewhere in WebKit, we
should use the context that corresponds to the Geolocation (or
Notification) object. This change happened automatically for V8
when this patch fixed the Geolocation (and Notifications) wrapper
to use the right context, but for JSC we need to change these lines
of code explicitly.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

LayoutTests:

Update the Geolocation tests to show that we now use the correct
context for these callback. Specifically, we use the context that
cooresponds to the Geolocation object itself, not whatever random
context we happened to be in when we first touched the Geolocation
object.

fast/dom/Geolocation/callback-to-deleted-context-expected.txt:
fast/dom/Geolocation/disconnected-frame-expected.txt:
fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
fast/dom/Geolocation/resources/callback-to-deleted-context-inner1.html:
fast/dom/Geolocation/script-tests/callback-to-deleted-context.js:

(onSecondIframeLoaded):

fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js:

(onIframeUnloaded.setTimeout):

fast/dom/Geolocation/script-tests/disconnected-frame.js:

(onIframeUnloaded.setTimeout):
(onIframeUnloaded):

2:28 PM Changeset in webkit [127922] by leoyang@rim.com

3 edits
3 adds in trunk

Appcache fallback URL match should use the longest candidate
https://bugs.webkit.org/show_bug.cgi?id=96126

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/appcache/multi-fallback.html

loader/appcache/ApplicationCache.cpp:

(WebCore::fallbackURLLongerThan):
(WebCore::ApplicationCache::setFallbackURLs):

LayoutTests:

Test with multiple candidates of fallback match.

http/tests/appcache/multi-fallback-expected.txt: Added.
http/tests/appcache/multi-fallback.html: Added.
http/tests/appcache/resources/multi-fallback.manifest: Added.

2:19 PM Changeset in webkit [127921] by Lucas Forschler

4 edits in branches/safari-536.26-branch/Source

Versioning.

2:17 PM Changeset in webkit [127920] by schenney@chromium.org

10 edits
4 adds in trunk

Font data is purged while fonts are still using it
https://bugs.webkit.org/show_bug.cgi?id=93640

Reviewed by Eric Seidel.

Source/WebCore:

Move the handling of custom font pruning from Document to FontFallbackList.
The previous inplementation allowed fonts to be removed before all their
clients were done. This change moves handling of custom font purging to the
FontFallbackList class, which is the shared object that is only removed
when all clients of a font are done with it. This fixes a crash in Angry
Birds due to a seamless iframe and some failing tests in fast/frames/seamless.

The specific element that causes problems is:
<iframe id="ingame_frame0" name="ingame_frame0" frameborder="0" seamless="true"

src="http://chrome.angrybirds.com/ingame_graphic.html"
onload="this.style.opacity = 1; parent.adLoaded();" scrolling="no"
style="opacity: 1; -webkit-transition: opacity 1s ease-in-out 0s;
position: absolute; border: 0px; width: 312px; height: 320px; z-index:
300; overflow: hidden; visibility: visible;"></iframe>

The source document uses the same font as the embedding document.

Tests: fast/frames/seamless/seamless-custom-font-pruning-crash.html

fast/frames/seamless/seamless-nested-crash.html

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Remove code to register the
font with the document.

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Remove code to register
the font with the document.

dom/Document.cpp:

(WebCore::Document::~Document): Remove code that records and purges
custom fonts.
(WebCore):
(WebCore::Document::reportMemoryUsage): Remove reference to removed
object.

dom/Document.h:

(Document): Remove method declarations for custom font handling.

platform/graphics/FontData.h: Add RefCounted to FontData. Previously, FontData

for custom fonts was owned by a Vector<OwnPtr<FontData>> in Document. Now it
is owned by FontFallbackList, and ref counting is required. A future patch will
add RefPtr code for all FontData use cases.

platform/graphics/FontFallbackList.cpp:

(WebCore): Add global custom font data cache, which owns the FontData pointers
used as keys.
(WebCore::FontFallbackList::appendFontData): Helper method increments
the ref count on custom FontData.
(WebCore::FontFallbackList::releaseFontData): Helper method decrements
the ref count on custom FontData.
(WebCore::FontFallbackList::fontDataAt): Add calls to register the
FontFallbackList as a client of custom fonts.

platform/graphics/FontFallbackList.h:

(WebCore::FontFallbackList::setGlyphPageZero): Moved this declaration.
(WebCore::FontFallbackList::setGlyphPages): Moved this declaration.
(FontFallbackList):

platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::pruneFontData): Removed unnecessary null check.

LayoutTests:

Tests for font purging. The seamless-custom-font-pruning-crash test
was only failing in Chromium Asan, while the seamless-nested-crash case
was only failing in Asan DumpRenderTree.

fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Added.
fast/frames/seamless/seamless-custom-font-pruning-crash.html: Added.
fast/frames/seamless/seamless-nested-crash-expected.txt: Added.
fast/frames/seamless/seamless-nested-crash.html: Added.

2:16 PM Changeset in webkit [127919] by Lucas Forschler

1 copy in tags/Safari-536.26.14

New Tag.

2:14 PM Changeset in webkit [127918] by jamesr@google.com

10 edits
3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r127911.
http://trac.webkit.org/changeset/127911
https://bugs.webkit.org/show_bug.cgi?id=96146

Patch breaks build with clang (Requested by rbuis on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore):
(MeshGenerator):
(WebCore::MeshGenerator::MeshGenerator):
(WebCore::MeshGenerator::vertices):
(WebCore::MeshGenerator::indices):
(WebCore::MeshGenerator::points):
(WebCore::MeshGenerator::pointsCount):
(WebCore::MeshGenerator::tiles):
(WebCore::MeshGenerator::tilesCount):
(WebCore::MeshGenerator::indicesCount):
(WebCore::MeshGenerator::floatsPerVertex):
(WebCore::MeshGenerator::verticesCount):
(WebCore::MeshGenerator::addTile):
(WebCore::MeshGenerator::addAttachedMeshIndex):
(WebCore::MeshGenerator::generateAttachedMesh):
(WebCore::MeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::MeshGenerator::generateDetachedMesh):
(WebCore::MeshGenerator::addPositionAttribute):
(WebCore::MeshGenerator::addTexCoordAttribute):
(WebCore::MeshGenerator::addMeshCoordAttribute):
(WebCore::MeshGenerator::addTriangleCoordAttribute):
(WebCore::MeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::MeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::MeshGenerator::dumpBuffers):
(WebCore::CustomFilterMesh::CustomFilterMesh):

platform/graphics/filters/CustomFilterMeshGenerator.cpp: Removed.
platform/graphics/filters/CustomFilterMeshGenerator.h: Removed.
platform/graphics/filters/CustomFilterValidatedProgram.cpp:

platform/graphics/filters/CustomFilterValidatedProgram.h:

(CustomFilterValidatedProgram):

platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Removed.

2:04 PM Changeset in webkit [127917] by ojan@chromium.org

3 edits in trunk/LayoutTests

Fix linter errors. The deleted lines are all tests that are passing
or that no longer exist at that path.

platform/efl/TestExpectations:
platform/mac/TestExpectations:

1:58 PM Changeset in webkit [127916] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove platform/chromium-linux/compositing/gestures
test skipping. All compositing tests seem to have the same failure.

platform/chromium/TestExpectations:

1:54 PM Changeset in webkit [127915] by ojan@chromium.org

10 edits
4 adds in trunk

Fix RenderBox::availableHeight to subtract scrollbars in the right places
https://bugs.webkit.org/show_bug.cgi?id=96031

Reviewed by Tony Chang.

Source/WebCore:

This matches Firefox 15 and IE9 rendering for the two new tests.

Tests: fast/block/positioning/percent-top-left-on-relative-position.html

fast/css/nested-percent-height-on-replaced.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Subtract scrollbars when recurring on percentage heights.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
This is the wrong place to subtract scrollbars. availableLogicalHeight
should return a value that doesn't include scrollbars.
(WebCore::RenderBox::availableLogicalHeightUsing):
Subtract scrollbars from specified heights. Also, consolidate the code to
use computeContentLogicalHeightUsing. This makes percentage heights use
the right containingBlock in quirks mode and makes viewport percentage heights work.

LayoutTests:

fast/block/positioning/percent-top-left-on-relative-position-expected.html: Added.
fast/block/positioning/percent-top-left-on-relative-position.html: Added.
fast/css/nested-percent-height-on-replaced-expected.txt: Added.
fast/css/nested-percent-height-on-replaced.html: Added.
platform/chromium-linux/fast/css/percent-top-value-with-relative-position-expected.png:
platform/chromium-win/fast/css/percent-top-value-with-relative-position-expected.txt:

This is now correctly centering the 50%. It moved up 8px because that is half of the body's margin.
This matches other Firefox 15 and IE9.

1:50 PM Changeset in webkit [127914] by tony@chromium.org

3 edits in trunk/Source/WebCore

Make RenderBox::computeLogicalWidthInRegion const
https://bugs.webkit.org/show_bug.cgi?id=96129

Reviewed by Ojan Vafai.

Making computeLogicalWidthInRegion const allows us to get rid of the gross hack in
RenderBox::renderBoxRegionInfo.

No new tests, this is covered by existing layout tests.

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax): Make const.
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Make const.
(WebCore::RenderBox::computeLogicalWidth): Use a LogicalExtentComputedValues when calling computeLogicalWidthInRegion.
(WebCore::RenderBox::computeLogicalWidthInRegion): Make const. Fill in a LogicalExtentComputedValues struct instead.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Make const.
(WebCore::RenderBox::renderBoxRegionInfo): Remove hack and get region width values in a LogicalExtentComputedValues struct.

rendering/RenderBox.h:

(RenderBox):

1:47 PM Changeset in webkit [127913] by danakj@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Remove bad assert in CCRenderPass::Id
https://bugs.webkit.org/show_bug.cgi?id=96138

Reviewed by James Robinson.

The assert prevents HashMap from creating "deleted" and "empty" ids. We
assert that RenderPasses have correct ids already, and don't need to
assert inside the Id structure itself.

platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCRenderPass::Id::Id):

1:41 PM Changeset in webkit [127912] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Unreviewed, fix incorrect comment character(s) in Skipped list.

platform/mac/Skipped:

1:40 PM UsingGitWithWebKit edited by ojan@chromium.org

(diff)

1:19 PM Changeset in webkit [127911] by anilsson@rim.com

10 edits
4 adds in trunk/Source/WebCore

[CSS Shaders] [BlackBerry] Refactor CustomFilterMesh and CustomFilter*Program
https://bugs.webkit.org/show_bug.cgi?id=94725

Reviewed by Rob Buis.

Separate the MeshGenerator from the CustomFilterMesh into
CustomFilterMeshGenerator.h/cpp. This allows the BlackBerry port to
reuse the mesh generator in its accelerated compositing implementation.

In general, this refactoring can be useful for any port that uses
OpenGL to implement accelerated compositing.

Inspired by an original patch by Joshua Netterfield.

No new tests, because this patch implements no new functionality.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):

platform/graphics/filters/CustomFilterMeshGenerator.cpp: Added.

platform/graphics/filters/CustomFilterMeshGenerator.h: Added.

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

platform/graphics/filters/CustomFilterValidatedProgram.h:

(WebCore):
(CustomFilterValidatedProgram):

platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Added.

(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

1:12 PM Changeset in webkit [127910] by tony@chromium.org

4 edits in trunk/Tools

Regression: check-webkit-style no longer checks TestExpectations for syntax errors
https://bugs.webkit.org/show_bug.cgi?id=96136

Reviewed by Ojan Vafai.

When we renamed the file to TestExpectations, it was no longer considered a text file so
it was no longer being checked. Since then, test_expectations_overrides() has been removed
from the port object, so I've removed that from the check. I'm not sure what it was
supposed to do.

Scripts/webkitpy/style/checker.py:

(CheckerDispatcher._file_type): Mark TestExpectations as a text file.

Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations): Remove overrides param.
(TestExpectationsChecker.check): Remove overrides param.

Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.assert_lines_lint): Remove overrides param.

1:04 PM Changeset in webkit [127909] by commit-queue@webkit.org

52 edits
1 add in trunk

[EFL] Use same default minimum logical font size in DRT and WTR
https://bugs.webkit.org/show_bug.cgi?id=96116

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07
Reviewed by Martin Robinson.

Source/WebKit/efl:

Add DRT helper function to set the minimum logical
font size setting.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setMinimumLogicalFontSize):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit2:

Add private bundle C API to set the minimum logicial font
size setting. This is needed by WebKitTestRunner.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetMinimumLogicalFontSize):

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setMinimumLogicalFontSize):
(WebKit):

WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
logical font size to 9 to match the value used in WTR.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting): Explicitly set the minimum
logical font size to 9 (default value in WK2)

LayoutTests:

Provide new baseline for several tests now that the minimum
logical font size setting is set to 9 in EFL's DRT.

Unskip several tests in EFL WK2 now that EFL's DRT uses
the same minimum logical font size and now that the tests
have been rebaselined.

platform/efl-wk2/TestExpectations:
platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
platform/efl/fast/ruby/nested-ruby-expected.png:
platform/efl/fast/ruby/nested-ruby-expected.txt:
platform/efl/fast/ruby/ruby-beforeafter-expected.png:
platform/efl/fast/ruby/ruby-beforeafter-expected.txt:
platform/efl/fast/ruby/ruby-empty-rt-expected.png:
platform/efl/fast/ruby/ruby-empty-rt-expected.txt:
platform/efl/fast/ruby/ruby-length-expected.png:
platform/efl/fast/ruby/ruby-length-expected.txt:
platform/efl/fast/ruby/ruby-run-break-expected.png:
platform/efl/fast/ruby/ruby-run-break-expected.txt:
platform/efl/fast/ruby/ruby-runs-expected.png:
platform/efl/fast/ruby/ruby-runs-expected.txt:
platform/efl/fast/ruby/ruby-runs-spans-expected.png:
platform/efl/fast/ruby/ruby-runs-spans-expected.txt:
platform/efl/fast/ruby/ruby-simple-expected.png:
platform/efl/fast/ruby/ruby-simple-expected.txt:
platform/efl/fast/ruby/ruby-simple-rp-expected.png:
platform/efl/fast/ruby/ruby-simple-rp-expected.txt:
platform/efl/fast/ruby/ruby-trailing-expected.png:
platform/efl/fast/ruby/ruby-trailing-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-rt-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-rt-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-text1-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-text1-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-text2-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-text2-expected.txt:
platform/efl/fast/ruby/rubyDOM-insert-text3-expected.png:
platform/efl/fast/ruby/rubyDOM-insert-text3-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-text1-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-text1-expected.txt:
platform/efl/fast/ruby/rubyDOM-remove-text2-expected.png:
platform/efl/fast/ruby/rubyDOM-remove-text2-expected.txt:
platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:

12:54 PM Changeset in webkit [127908] by commit-queue@webkit.org

1 edit
3 moves in trunk/LayoutTests

[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Move preserve-3d-toggle.html to the common compositing tests directory because
it isn't Chromium-specific.

compositing/preserve-3d-toggle-expected.png: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.png.
compositing/preserve-3d-toggle-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.txt.
compositing/preserve-3d-toggle.html: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle.html.

12:37 PM Changeset in webkit [127907] by danakj@chromium.org

18 edits in trunk/Source

[chromium] Make RenderPass ids hold both generating layer id and an index
https://bugs.webkit.org/show_bug.cgi?id=95500

Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to avoid complex renderPassId mappings between
compositors for ubercomp. The ubercomp layer needs to add a number
of RenderPasses to the frame, and these must not conflict with other
RenderPasses in the frame. By using its layer id along with an extra
value it determines, the layer can create a unique id without needing
access to any global state or id generator.

Covered by existing tests.

platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

platform/graphics/chromium/cc/CCRenderPass.h:

(Id):
(WebCore::CCRenderPass::Id::Id):
(WebCore::CCRenderPass::Id::operator==):
(WebCore::CCRenderPass::Id::operator!=):
(WebCore::CCRenderPass::Id::operator<):
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::renderPassId):
(WebCore):
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:
tests/CCLayerTreeHostTest.cpp:
tests/CCRenderSurfaceTest.cpp:
tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

12:30 PM Changeset in webkit [127906] by tommyw@google.com

20 edits
2 adds in trunk

MediaStream API: add RTCPeerConnection::createAnswer
https://bugs.webkit.org/show_bug.cgi?id=96092

Reviewed by Adam Barth.

Source/Platform:

chromium/public/WebRTCPeerConnectionHandler.h:

(WebRTCPeerConnectionHandler):

Source/WebCore:

Test: fast/mediastream/RTCPeerConnection-createAnswer.html

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createAnswer):
(WebCore):

Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

Modules/mediastream/RTCPeerConnection.idl:
platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createAnswer):
(WebCore):

platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::createAnswer):
(WebCore):

platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

Expanding and enhancing MockWebRTCPeerConnectionHandler.

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::createAnswer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

fast/mediastream/RTCPeerConnection-createAnswer-expected.txt: Added.
fast/mediastream/RTCPeerConnection-createAnswer.html: Added.
fast/mediastream/RTCPeerConnection-createOffer-expected.txt:
fast/mediastream/RTCPeerConnection-createOffer.html:
fast/mediastream/RTCPeerConnection-localDescription-expected.txt:
fast/mediastream/RTCPeerConnection-localDescription.html:
fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
fast/mediastream/RTCPeerConnection-remoteDescription.html:

12:20 PM Changeset in webkit [127905] by wangxianzhu@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Update test expectation media/video-set-rate-from-pause.html on Android.

platform/chromium/TestExpectations:

12:15 PM Changeset in webkit [127904] by commit-queue@webkit.org

6 edits in trunk/LayoutTests

[WK2][WTR] Unskip detached-stylesheet-without-wrapper.html test case.
https://bugs.webkit.org/show_bug.cgi?id=96069

Unreviewed EFL gardening.

fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html test case has been passed on EFL layout test.
WebKit EFL doesn't have to skip this.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-07

platform/gtk-wk2/Skipped:
platform/mac-wk2/Skipped:
platform/qt-5.0-wk2/Skipped:
platform/win-wk2/Skipped:
platform/wk2/Skipped:

12:04 PM Changeset in webkit [127903] by jsbell@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect
https://bugs.webkit.org/show_bug.cgi?id=96122

Reviewed by Adam Barth.

Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory
open() method now takes the "database callbacks", rather than being sent through
in a later call.

Also, delete an obsolete method.

public/WebIDBFactory.h:

(WebKit):
(WebIDBFactory): Delete pre-version overload of open().
(WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks.

11:51 AM Changeset in webkit [127902] by vsevik@chromium.org

4 edits
3 adds in trunk

Web Inspector: [REGRESSION] Content is not available for dynamically loaded script sometimes.
https://bugs.webkit.org/show_bug.cgi?id=95954

Reviewed by Yury Semikhatsky.

Source/WebCore:

Resource now loads content from request when it is available.
Content was loaded from PageAgent before where it might be not available if the resource was already GCed.

Test: http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html

inspector/front-end/Resource.js:

(WebInspector.Resource.prototype._innerRequestContent.contentLoaded):
(WebInspector.Resource.prototype._innerRequestContent.resourceContentLoaded):
(WebInspector.Resource.prototype._innerRequestContent):

LayoutTests:

http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache-expected.txt: Added.
http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html: Added.
http/tests/inspector/resource-tree/resources/dynamic-script.js: Added.

(foo):

http/tests/inspector/resources-test.js:

11:44 AM Changeset in webkit [127901] by dino@apple.com

2 edits in trunk/Tools

Unreviewed changes to watchlist.

Add new WebGL and Filters definitions
Add myself to OpenGL bugs

Scripts/webkitpy/common/config/watchlist:

11:39 AM Changeset in webkit [127900] by dmazzoni@google.com

2 edits in trunk/LayoutTests

Unreviewed, skip accessibility/spinbutton-value.html on win.

11:32 AM Changeset in webkit [127899] by abarth@webkit.org

2 edits in trunk/Source/WebCore

HTMLTokenizer should use the latest EfficientStrings hotness
https://bugs.webkit.org/show_bug.cgi?id=95276

Reviewed by Benjamin Poulain.

Using ASCIILiteral avoids memcpying the string into the heap and
therefore uses less total memory.

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

11:31 AM Changeset in webkit [127898] by fsamuel@chromium.org

1 edit
1 add in trunk/LayoutTests

Unreviewed rebaseline.

Colors changed slightly, but the test's intention is to verify scaling
works as expected and it continues to do so.

platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.

11:27 AM Changeset in webkit [127897] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Unreviewed, trying to get the cr-linux ews into a usable state.

platform/chromium/TestExpectations: Revert r127883 and skip http/tests/cache/cancel-during-revalidation-succeeded.html

on the cr-ews linux bots. This is causing the following 2 tests to fail.

11:26 AM Changeset in webkit [127896] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing
https://bugs.webkit.org/show_bug.cgi?id=95932

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to
properly scroll it.

tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F): Re-enable the test.

11:17 AM Changeset in webkit [127895] by peter@chromium.org

2 edits in trunk/Tools

Actually trigger the Android Tester
https://bugs.webkit.org/show_bug.cgi?id=96118

Reviewed by Adam Barth.

BuildSlaveSupport/build.webkit.org-config/config.json:

11:11 AM Changeset in webkit [127894] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Initialize caret rectangle with invalid location
https://bugs.webkit.org/show_bug.cgi?id=96011

Patch by Yongxin Dai <yodai@rim.com> on 2012-09-07
Reviewed by Rob Buis.

In SelectionHandler::selectionPositionChanged() method, startCaret and
endCaret are used to notify clients about new caret positions. This patch
initializes startCaret and endCaret with location(-1. -1), and keeps them
empty before they are assigned to valid values. This would help for other
classes to check validity of the caret correctly.

Internal reviewed by Mike Fenton.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

11:09 AM Changeset in webkit [127893] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Move some CC unit tests into correct gyp variable
https://bugs.webkit.org/show_bug.cgi?id=96048

Patch by James Robinson <jamesr@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.

These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable.

WebKit.gypi:

11:08 AM Changeset in webkit [127892] by fsamuel@chromium.org

4 edits in trunk/LayoutTests

Unreviewed rebaseline for chromium gardening.

platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:

10:57 AM Changeset in webkit [127891] by jamesr@google.com

10 edits
3 deletes in trunk/Source

[chromium] Remove dead CCActiveGestureAnimation code and related classes
https://bugs.webkit.org/show_bug.cgi?id=96075

Reviewed by Adrienne Walker.

Source/WebCore:

The CCGestureCurve / CCActiveGestureAnimation code isn't used and never has been used. Gesture curves are
evaluated by the CCInputHandlerClient (WebCompositorInputHandlerImpl), CC itself logically doesn't know anything
about gestures.

WebCore.gypi:
platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Removed.
platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Removed.
platform/graphics/chromium/cc/CCGestureCurve.h: Removed.
platform/graphics/chromium/cc/CCInputHandler.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
evaluate the curve itself without intermediate classes.

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):

src/WebCompositorInputHandlerImpl.h:

(WebCore):
(WebCompositorInputHandlerImpl):

tests/PlatformGestureCurveTest.cpp:
tests/WebCompositorInputHandlerImplTest.cpp:

10:57 AM Changeset in webkit [127890] by roger_fong@apple.com

2 edits in trunk/LayoutTests

http/tests/security/contentSecurityPolicy/blob-urls-match-self.html fails on Windows port.
https://bugs.webkit.org/show_bug.cgi?id=96133

Test fails on Windows port since added in http://trac.webkit.org/changeset/126785.
Blobs might be completely disabled on Windows. Adding to skip list for now.

platform/win/Skipped:

10:52 AM Changeset in webkit [127889] by Martin Robinson

6 edits
2 adds in trunk

[GTK] Move user agent helpers to WebCore
https://bugs.webkit.org/show_bug.cgi?id=95745

Reviewed by Carlos Garcia Campos.

Added an autoconf step for the new user agent shared code header in
WebCore. This is necessary so that we can use the user agent version
based on the information in the configure.ac file.

configure.ac:

Source/WebCore:

Moved the user agent determination code from WebKit1 to WebCore so that it can
be shared with WebKit2. Also add a method for creating the user agent given
a non-default application name.

GNUmakefile.list.am: Add new files to the list.
platform/gtk/UserAgentGtk.cpp: Added.
platform/gtk/UserAgentGtk.h.in: Added.

Source/WebKit/gtk:

Move the code for determining the user agent to WebCore and have WebKit1
use the new shared code.

webkit/webkitwebsettings.cpp: Use the WebCore code to determine the user

agent in WebKit1.

10:49 AM Changeset in webkit [127888] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up dependencies in ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96052

Patch by James Robinson <jamesr@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.

Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
*) WebScrollbarImpl.h is #included, but not use
*) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if

WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.

tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

10:46 AM Changeset in webkit [127887] by msaboff@apple.com

4 edits in trunk/Source/WTF

equalIgnoringCase of two StringImpls doesn't handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=96028

Reviewed by Benjamin Poulain.

Added 8 bit checks and paths to CaseFoldingHash::equal. Also cleaned up StringHash::equal(), removing
obvious and in one case wrong comments. Moved equalIgnoringCase(UChar*, UChar*) from StringImpl.cpp
to StringImpl.h.

wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):

wtf/text/StringImpl.cpp:
wtf/text/StringImpl.h:

(WTF::equalIgnoringCase):

10:25 AM Changeset in webkit [127886] by abarth@webkit.org

26 edits in trunk/Source/WebCore

Update bindings results after https://bugs.webkit.org/show_bug.cgi?id=96039

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::toV8):
(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestCallback.cpp:

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

10:22 AM Changeset in webkit [127885] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, fix overlapping test expectation.

platform/chromium/TestExpectations:

10:13 AM Changeset in webkit [127884] by commit-queue@webkit.org

9 edits
1 add in trunk/Source

[BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.
https://bugs.webkit.org/show_bug.cgi?id=95488
PR: 186597.

Internally reviewed by Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-09-07
Reviewed by Yong Li.

Source/WebCore:

The fix for this PR will come as 2 patches. This is the first patch which
will make the authentication challenge asynchronous inside WebKit. The
bext patch will add an AuthenticationChallengeManager that manages these
authentication requests asynchronously.

This patch add AuthenticationChallengeClient interface to define asynchronous
authentication challenge callback. And MediaPlayerPrivateBlackBerry and
NetworkJob are changed to inherit from AuthenticationChallengeClient to
support asynchronous authentication challenge.

Note: there is also an accompanying platform patch to make our PlatformPlayer
to support asychronous authentication, see PR 186597 for details.

No new tests as this is platform specific change.

platform/blackberry/AuthenticationChallengeManager.h: Added.

(WebCore):
(AuthenticationChallengeClient):

platform/blackberry/PageClientBlackBerry.h:

(WebCore):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
(WebCore):

platform/network/blackberry/NetworkJob.h:

(WebCore):
(NetworkJob):

Source/WebKit/blackberry:

Use new AuthenticationChallengeClient interface to make authentication
challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and
other module that will use HTTP authentication. WebPage itself still use
synchronous authentication though. Switching to asynchronous authentication
in WebPage will require bigger platform layer change and not very necessary
at the moment for this bug.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

10:09 AM Changeset in webkit [127883] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Unreviewed, trying to get the cr-linux ews into a usable state.

platform/chromium/TestExpectations: mark 2 http cache tests as flaky

10:07 AM Changeset in webkit [127882] by dmazzoni@google.com

13 edits
2 adds in trunk

Source/WebCore: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Make an ARIA spin button support ARIA range attributes like
aria-valuenow, aria-valuemin, etc. - just like slider, progressbar,
and scrollbar.

Test: accessibility/spinbutton-value.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::valueDescription):
(WebCore):
(WebCore::AccessibilityRenderObject::isAriaRange):
(WebCore::AccessibilityRenderObject::valueForRange):
(WebCore::AccessibilityRenderObject::maxValueForRange):
(WebCore::AccessibilityRenderObject::minValueForRange):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::isGenericFocusableElement):
(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Source/WebKit/chromium: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Expose supportsRangeValue to simplify Chromium logic for when to
extract a value from a range.

public/WebAccessibilityObject.h:

(WebAccessibilityObject):

src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::supportsRangeValue):
(WebKit):

Tools: New time input needs accessibility
https://bugs.webkit.org/show_bug.cgi?id=96032

Reviewed by Chris Fleizach.

Add support for valueDescription for testing.

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(getValueDescription):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::valueDescriptionGetterCallback):

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:

(AccessibilityUIElement):

LayoutTests: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Test that an ARIA spin button exposes ARIA range attributes like
aria-valuenow, aria-valuemin, etc.

accessibility/spinbutton-value-expected.txt: Added.
accessibility/spinbutton-value.html: Added.

10:02 AM Changeset in webkit [127881] by rwlbuis@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove feature about:cache/disable and about:cache/enable
https://bugs.webkit.org/show_bug.cgi?id=95820

Reviewed by Yong Li.

Fix warning that was caused by r127680.

WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::cachePage):

9:58 AM Changeset in webkit [127880] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Unreviewed, rolling out r127820.
http://trac.webkit.org/changeset/127820
https://bugs.webkit.org/show_bug.cgi?id=96117

Introduces crashes in Chromium compositing tests (Requested by
fsamuel on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::evictAllContentTextures):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::allBackingTexturesWereDeleted):

platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

9:55 AM Changeset in webkit [127879] by Patrick Gansterer

2 edits in trunk/Source/WTF

[WIN] Deprecate String += operator
https://bugs.webkit.org/show_bug.cgi?id=96083

Reviewed by Adam Barth.

wtf/Platform.h:

9:31 AM Changeset in webkit [127878] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Unskip test cases that are now passing consistently
https://bugs.webkit.org/show_bug.cgi?id=96090

Unreviewed EFL gardening.

Remove from TestExpectations several test cases that are now
passing consistently on EFL WK2 build bot.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07

platform/efl-wk2/TestExpectations:

9:27 AM Changeset in webkit [127877] by Simon Hausmann

2 edits in trunk/Source/WebCore

[Qt] Add another all-in-one source

Rubber-stamped by Tor Arne Vestbø.

Target.pri: We can safely add platform/text/TextAllInOne.cpp to ALL_IN_ONE_SOURCES for

even smaller combined builds.

9:09 AM Changeset in webkit [127876] by allan.jensen@nokia.com

46 edits in trunk

Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720

Reviewed by Antonio Gomes.

Update exported symbols.

Source/autotools/symbols.filter:

Source/WebCore:

The existing API was overloaded and could be simplified by passing all the bool arguments in
a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
state what they do.

WebCore.exp.in:
WebCore.order:
dom/Document.cpp:

(WebCore::Document::nodesFromRect):

dom/Document.h:

(Document):

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::createContextMenu):

page/DragController.cpp:

(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

page/EventHandler.cpp:

(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):

page/EventHandler.h:

(EventHandler):

page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):

page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

rendering/HitTestRequest.h:

(HitTestRequest):

testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

Update calls to new API.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtPoint):

WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

Update calls to new API.

src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):
(WebKit::WebViewImpl::computeBlockBounds):

Source/WebKit/efl:

Update calls to new API.

ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/mac:

Update calls to new API.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary):

WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

Update calls to new API.

Api/qwebframe.cpp:

(QWebFrame::hitTestContent):

Api/qwebpage.cpp:

(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
(QWebPage::updatePositionDependentActions):

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

Source/WebKit/win:

Update calls to new API.

WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

WebView.cpp:

(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):

Source/WebKit/wx:

Update calls to new API.

WebFrame.cpp:

(WebKit::WebFrame::HitTest):

Source/WebKit2:

Update calls to new API and update exported symbols.

WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation): Corrects the misplaced arguments while converting them.
(WebKit::WebPage::findZoomableAreaForPoint):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

win/WebKit2.def:
win/WebKit2CFLite.def:

9:06 AM Changeset in webkit [127875] by peter@chromium.org

2 edits in trunk/Tools

Add the google-android-tests build slave to the master's config
https://bugs.webkit.org/show_bug.cgi?id=96113

Reviewed by Csaba Osztrogonác.

BuildSlaveSupport/build.webkit.org-config/config.json:

9:05 AM Changeset in webkit [127874] by Simon Hausmann

2 edits in trunk/Source/WebCore

Build of OpenGLShims.cpp against EGL/GLES2 platforms is broken
https://bugs.webkit.org/show_bug.cgi?id=95556

Reviewed by Jocelyn Turcotte.

There were a few problems:

1) GL_ANGLE_framebuffer_blit is the name of the macro indicating the
availability of the _declaration_ of that ANGLE extension. It is not the
name of the actual function, which is glBlitFramebufferANGLE.

2) The presence of the preprocessor macros indicating the availability
of the declaration of the extension does not imply presence of the extension
prototypes at link time. Instead extensions need to be looked up dynamically
at run-time.

3) dlfcn.h was unconditionally included. We do not need it when building against
Qt (and there it breaks the Windows build)

This patch implements the dynamic lookup of glBlitFramebufferANGLE
(used in GraphicsContext3DOpenGLES.cpp) as well as the dynamic lookup of the
Angle and Apple renderbuffer multisampling extensions.

platform/graphics/OpenGLShims.cpp:

(WebCore):
(WebCore::initializeOpenGLShims):

9:03 AM Changeset in webkit [127873] by commit-queue@webkit.org

3 edits in trunk/Tools

[WK2] [EFL] Set theme for WebKit2 API test runner
https://bugs.webkit.org/show_bug.cgi?id=96100

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Set the theme generated by the build for the WebKit2 API test runner.

TestWebKitAPI/PlatformEfl.cmake:
TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

9:01 AM Changeset in webkit [127872] by zandobersek@gmail.com

4 edits in trunk

[GTK] Multiple feature defines in webcore_cppflags can occur
https://bugs.webkit.org/show_bug.cgi?id=95942

Reviewed by Martin Robinson.

Add the feature_defines_unstable variable that should control values of feature
defines for unstable features when unstable features are not enabled (e.g. release builds).

GNUmakefile.am:

Source/WebCore:

Any feature define that guards a feature deemed currently unstable (is intended
to be enabled in developer builds but not in release builds) should be added to the
newly-added feature_defines_unstable variable.

This moves away from adding such feature defines to the feature_defines_overrides variable
as this can cause duplicates in the later-generated feature_defines and webcore_cppflags
variables and further warnings of duplicate macros when generating bindings.

The feature_defines generation is now done by first checking if the bare feature define
is present in feature_defines_unstable, if not then feature_defines_overrides is also
checked before using the value from feature_defines_defaults.

No new tests - no new functionality.

GNUmakefile.am:

9:01 AM Changeset in webkit [127871] by fsamuel@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Disabled test paste-global-selection on Chromium Linux that was failing.

platform/chromium/TestExpectations:

8:53 AM Changeset in webkit [127870] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rendering issue after rotation
https://bugs.webkit.org/show_bug.cgi?id=96094
PR #201930

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-07
Reviewed by George Staikos.

The cause of the rendering issue is that the BackingStore tiles
are not reset after layout. This is a regression of r125680, which
overwrites a local variable that are used later in the function.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

8:36 AM Changeset in webkit [127869] by loislo@chromium.org

102 edits
1 move
1 add in trunk/Source

Web Inspector: NMI: move WebCore specific code to separate header
https://bugs.webkit.org/show_bug.cgi?id=96101

Reviewed by Yury Semikhatsky.

I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/ScriptWrappable.h:
bindings/v8/DOMDataStore.cpp:
bindings/v8/IntrusiveDOMWrapperMap.h:
bindings/v8/ScriptProfiler.cpp:
bindings/v8/ScriptWrappable.h:
bindings/v8/V8Binding.cpp:
bindings/v8/V8DOMMap.h:
css/CSSAspectRatioValue.cpp:
css/CSSBorderImageSliceValue.cpp:
css/CSSCalculationValue.cpp:
css/CSSCanvasValue.cpp:
css/CSSCharsetRule.cpp:
css/CSSComputedStyleDeclaration.cpp:
css/CSSCrossfadeValue.cpp:
css/CSSCursorImageValue.cpp:
css/CSSFontFaceRule.cpp:
css/CSSFontFaceSrcValue.cpp:
css/CSSFunctionValue.cpp:
css/CSSGradientValue.cpp:
css/CSSImageGeneratorValue.cpp:
css/CSSImageSetValue.cpp:
css/CSSImageValue.cpp:
css/CSSImportRule.cpp:
css/CSSInheritedValue.cpp:
css/CSSInitialValue.cpp:
css/CSSLineBoxContainValue.cpp:
css/CSSMediaRule.cpp:
css/CSSPrimitiveValue.cpp:
css/CSSProperty.cpp:
css/CSSReflectValue.cpp:
css/CSSRuleList.h:
css/CSSSelectorList.cpp:
css/CSSStyleRule.cpp:
css/CSSStyleSheet.cpp:
css/CSSTimingFunctionValue.cpp:
css/CSSUnicodeRangeValue.cpp:
css/CSSUnknownRule.h:
css/CSSValue.cpp:
css/CSSValueList.cpp:
css/CSSVariableValue.h:
css/FontFeatureValue.cpp:
css/FontValue.cpp:
css/MediaList.cpp:
css/MediaQuery.cpp:
css/MediaQueryExp.cpp:
css/PropertySetCSSStyleDeclaration.cpp:
css/ShadowValue.cpp:
css/StyleResolver.cpp:
css/StyleRule.cpp:
css/StyleSheetContents.cpp:
css/WebKitCSSArrayFunctionValue.cpp:
css/WebKitCSSFilterValue.cpp:
css/WebKitCSSKeyframeRule.cpp:
css/WebKitCSSKeyframesRule.cpp:
css/WebKitCSSMixFunctionValue.cpp:
css/WebKitCSSSVGDocumentValue.cpp:
css/WebKitCSSShaderValue.cpp:
css/WebKitCSSTransformValue.cpp:
dom/CharacterData.cpp:
dom/Document.cpp:
dom/DocumentEventQueue.cpp:
dom/ElementAttributeData.cpp:
dom/Event.cpp:
dom/MemoryInstrumentation.h:
dom/Node.cpp:
dom/QualifiedName.h:
dom/WebCoreMemoryInstrumentation.cpp: Renamed from Source/WebCore/dom/MemoryInstrumentation.cpp.

(WebCore):
(WebCore::String):
(WebCore::StringImpl):
(WebCore::KURL):
(WebCore::AtomicString):

dom/WebCoreMemoryInstrumentation.h: Added.

(WebCore):
(WebCoreMemoryTypes):

loader/DocumentLoader.cpp:
loader/FrameLoader.cpp:
loader/SubresourceLoader.cpp:
loader/SubstituteData.cpp:
loader/cache/CachedCSSStyleSheet.cpp:
loader/cache/CachedFont.cpp:
loader/cache/CachedRawResource.cpp:
loader/cache/CachedResource.cpp:
loader/cache/CachedResourceHandle.cpp:
loader/cache/CachedScript.cpp:
loader/cache/CachedShader.cpp:
loader/cache/CachedXSLStyleSheet.cpp:
loader/cache/MemoryCache.cpp:
platform/SharedBuffer.cpp:
platform/graphics/BitmapImage.cpp:
platform/graphics/CrossfadeGeneratedImage.cpp:
platform/graphics/GeneratedImage.cpp:
platform/graphics/GeneratorGeneratedImage.h:
platform/graphics/Image.cpp:
platform/network/FormData.cpp:
platform/network/ResourceRequestBase.cpp:
platform/network/ResourceResponseBase.cpp:
rendering/style/RenderStyle.cpp:
rendering/style/StyleRareInheritedData.cpp:
rendering/style/StyleRareNonInheritedData.cpp:
svg/SVGColor.cpp:
svg/SVGPaint.cpp:

Source/WebKit/chromium:

tests/MemoryInstrumentationTest.cpp:

8:32 AM Changeset in webkit [127868] by vollick@chromium.org

9 edits in trunk/Source

[chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
https://bugs.webkit.org/show_bug.cgi?id=95855

Reviewed by James Robinson.

Source/Platform:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

chromium/public/WebTransformOperations.h:

(WebTransformOperations):

chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

Unit tests:

AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

platform/chromium/support/WebTransformOperations.cpp:

(WebKit::blendTransformOperations):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::canBlendWith):
(WebKit):
(WebKit::WebTransformOperations::blendInternal):

platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::blend):

platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::WebTransformAnimationCurve):

Source/WebKit/chromium:

Added the following unit tests:

AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):
(WebKit):

7:06 AM WebInspector edited by lindahomes9@gmail.com

(diff)

7:00 AM Changeset in webkit [127867] by apavlov@chromium.org

12 edits in trunk

Unreviewed, rolling out r127780 and r127859.
http://trac.webkit.org/changeset/127780
http://trac.webkit.org/changeset/127859
https://bugs.webkit.org/show_bug.cgi?id=96102

"inspector/styles/protocol-css-regions-commands.html crashing
on Chromium Linux Debug and timing out flakily on Release"
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

inspector/styles/protocol-css-regions-commands-expected.txt:
inspector/styles/protocol-css-regions-commands.html:

6:50 AM Changeset in webkit [127866] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Add passing expectations for a few specific sub-pixel and various input type
tests. These features are not yet supported by the GTK port but we're willing
to watch and monitor these tests' behavior.

platform/gtk/TestExpectations:

6:37 AM Changeset in webkit [127865] by commit-queue@webkit.org

3 edits
3 adds in trunk

[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Source/WebCore:

Fix removal of preserve-3d CSS attribute from a GraphicsLayerChromium.
It was broken by a refactor in http://trac.webkit.org/changeset/126378.

Test: platform/chromium/compositing/preserve-3d-toggle.html

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

LayoutTests:

Add test to verify dynamic removal of preserve-3d CSS attribute.

platform/chromium/compositing/preserve-3d-toggle-expected.png: Added.
platform/chromium/compositing/preserve-3d-toggle-expected.txt: Added.
platform/chromium/compositing/preserve-3d-toggle.html: Added.

6:24 AM Changeset in webkit [127864] by apavlov@chromium.org

11 edits in trunk

Web Inspector: Implement SCSS source highlighter
https://bugs.webkit.org/show_bug.cgi?id=95585

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change modifies the existing CSS highlighter to support SCSS as well. The "text/x-scss" mime-type is assigned to SASSSource.

inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.cssPropertiesMetainfoKeySet):

inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider): Enabled clients to supply the content mime-type.
(WebInspector.StaticContentProvider.prototype.mimeType):
(WebInspector.StaticContentProvider.prototype.requestContent): Use client-supplied content mime-type, if any.

inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSource): Construct StaticContentProvider with the "text/x-scss" mime-type.

inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):
(WebInspector.SourceCSSTokenizer.prototype.nextToken):

inspector/front-end/SourceCSSTokenizer.re2js: Extended with the SCSS syntax.
inspector/front-end/SourceTokenizer.js:

(WebInspector.SourceTokenizer.Registry):

inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-css-bang-keyword):

LayoutTests:

Test modified to cover the SCSS syntax as well.

inspector/syntax-highlight-css-expected.txt:
inspector/syntax-highlight-css.html:

5:59 AM Changeset in webkit [127863] by allan.jensen@nokia.com

4 edits in trunk/LayoutTests

Layout Test touchadjustment/iframe-boundary.html is failing
https://bugs.webkit.org/show_bug.cgi?id=95799

Unreviewed, fudge the test so it has a larger margin of error.

platform/chromium/TestExpectations:
touchadjustment/iframe-boundary.html:
touchadjustment/resources/inner-content-page.html:

5:51 AM Changeset in webkit [127862] by allan.jensen@nokia.com

27 edits
2 adds in trunk

X11 Global Selection
https://bugs.webkit.org/show_bug.cgi?id=88238

Reviewed by Tony Chang.

Source/WebCore:

In X11 global selection is the ability to share the active selection
between applications and pasting with middle mouse-button.

This patch moves the implementations of global selection from the
separate implementations in Qt WebKit, Chromium and GTK to WebCore,
by implementing a new EditorCommand for pasting the global selection.

Test: editing/pasteboard/paste-global-selection.html

editing/EditorCommand.cpp:

(WebCore::executePasteGlobalSelection):
(WebCore::createCommandMap):

page/EditorClient.h:

(EditorClient):
(WebCore::EditorClient::supportsGlobalSelection):

platform/Pasteboard.h:

(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):

Source/WebKit/chromium:

Use new editor command for pasting global selection.

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::supportsGlobalSelection):

src/EditorClientImpl.h:

(EditorClientImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):

Source/WebKit/qt:

Use new editor command for pasting global selection, and update it using
the respondToChangedSelection callback.

Api/qwebpage.cpp:

(QWebPagePrivate::handleClipboard):

WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::respondToChangedSelection):
(WebCore::EditorClientQt::supportsGlobalSelection):

WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit2:

Implements the hooks for supporting global selections in Qt WebKit2.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::updateGlobalSelection):
(WebKit::WebEditorClient::supportsGlobalSelection):

WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::updateGlobalSelection):

WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):

WebProcess/WebPage/WebPage.h:

(WebPage):

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::handleMouseReleaseEvent):

LayoutTests:

Adds a test for the new editor-command, and disables it an all platforms where it is not supported.

editing/pasteboard/paste-global-selection-expected.txt: Added.
editing/pasteboard/paste-global-selection.html: Added.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/Skipped:
platform/qt-mac/Skipped:
platform/win/Skipped:

5:32 AM Changeset in webkit [127861] by vsevik@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: Migrate Database to async protocol commands
https://bugs.webkit.org/show_bug.cgi?id=95983

Reviewed by Alexander Pavlov.

English.lproj/localizedStrings.js:
inspector/Inspector.json:
inspector/InspectorDatabaseAgent.cpp:

(WebCore):
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::executeSQL):

inspector/InspectorDatabaseAgent.h:

(InspectorDatabaseAgent):

inspector/front-end/Database.js:

(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):

5:29 AM Changeset in webkit [127860] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed single line follow-up change for r127856.

dom/MemoryInstrumentation.h:

(WebCore::MemoryClassInfo::MemoryClassInfo):

5:26 AM Changeset in webkit [127859] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed inspector closure compilation errors fix.

inspector/front-end/CSSStyleModel.js:

(WebInspector.NamedFlowCollection):

5:23 AM Changeset in webkit [127858] by vsevik@chromium.org

13 edits in trunk

Web Inspector: Migrate FileSystem to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95985

Reviewed by Alexander Pavlov.

Source/WebCore:

Migrated FileSystem domain to async protocol commands and removed boilerplate code.

inspector/Inspector.json:
inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::~InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::assertEnabled):

inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel):
(WebInspector.FileSystemModel.prototype._originAdded):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype.requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.prototype._requestFileContent):
(WebInspector.FileSystemModel.prototype._deleteEntry):

LayoutTests:

http/tests/inspector/filesystem/delete-entry.html:
http/tests/inspector/filesystem/directory-tree.html:
http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.MockEntry):

http/tests/inspector/filesystem/request-directory-content.html:
http/tests/inspector/filesystem/request-file-content.html:
http/tests/inspector/filesystem/request-filesystem-root.html:
http/tests/inspector/filesystem/request-metadata.html:

5:17 AM Changeset in webkit [127857] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Update TextExpectations for http/tests/appcache/load-from-appcache-defer-resume-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96091

Unreviewed EFL gardening.

Add bug number of http/tests/appcache/load-from-appcache-defer-resume-crash.html
in TestExpectations file.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07

platform/efl-wk2/TestExpectations:

5:10 AM Changeset in webkit [127856] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: NMI: remove DataRef instrumentation from the core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=96086

Reviewed by Yury Semikhatsky.

This patch is removing the last WebCore specific methods from core memory instrumentation code.

It is covered by webkit_unit_tests.

dom/MemoryInstrumentation.h:

(WebCore):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

rendering/style/DataRef.h:

(DataRef):
(WebCore::DataRef::reportMemoryUsage):

5:05 AM Changeset in webkit [127855] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unskip passing tests on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=96089

Unreviewed EFL gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07

platform/efl/TestExpectations:

4:57 AM Changeset in webkit [127854] by vsevik@chromium.org

10 edits in trunk

Web Inspector: Migrate IndexedDB to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95978

Reviewed by Alexander Pavlov.

Source/WebCore:

IndexedDB is now implemented using async protocol commands.
Removed boilerplate code used to emulate async commands before.

inspector/Inspector.json:
inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.prototype._requestData.innerCallback):
(WebInspector.IndexedDBModel.prototype._requestData):

LayoutTests:

http/tests/inspector/indexeddb/database-data.html:
http/tests/inspector/indexeddb/database-names.html:
http/tests/inspector/indexeddb/database-structure.html:
http/tests/inspector/indexeddb/resources-panel.html:

4:45 AM Changeset in webkit [127853] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed. Add Gábor Ballabás as contributor.

Scripts/webkitpy/common/config/committers.py:

4:04 AM Changeset in webkit [127852] by gyuyoung.kim@samsung.com

9 edits in trunk/Source/WebCore

Add *explicit* keyword to constructors in WebCore/xml
https://bugs.webkit.org/show_bug.cgi?id=96071

Reviewed by Kentaro Hara.

As a step to let *explicit* add to constructors which have only one parameter,
*explicit* is added to Source/WebCore/xml in order to avoid implicit type conversion.

No new tests. Covered by existing tests.

xml/NativeXPathNSResolver.h:

(NativeXPathNSResolver):

xml/XMLHttpRequestException.h:

(WebCore::XMLHttpRequestException::XMLHttpRequestException):

xml/XMLHttpRequestProgressEventThrottle.h:

(XMLHttpRequestProgressEventThrottle):

xml/XMLHttpRequestUpload.h:

(XMLHttpRequestUpload):

xml/XPathException.h:

(WebCore::XPathException::XPathException):

xml/XPathPredicate.h:

(Number):
(StringExpression):
(Predicate):

xml/XPathValue.h:

(WebCore::XPath::ValueData::ValueData):

xml/XPathVariableReference.h:

(VariableReference):

3:44 AM Changeset in webkit [127851] by commit-queue@webkit.org

2 edits in trunk/Tools

[Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
https://bugs.webkit.org/show_bug.cgi?id=96078

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-07
Reviewed by Tor Arne Vestbø.

Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.

qmake/mkspecs/features/default_pre.prf:

3:26 AM Changeset in webkit [127850] by commit-queue@webkit.org

5 edits
2 adds in trunk

[EFL] Add TestExpectations file for efl-wk1
https://bugs.webkit.org/show_bug.cgi?id=96019

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07
Reviewed by Gyuyoung Kim.

Tools:

Update TestExpectations cascading for EFL port
so that we use efl-wk1 -> efl search paths
for WebKit1 EFL.

Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._search_paths):

LayoutTests:

Add TestExpectations file for WebKit1 EFL.

platform/efl-wk1/TestExpectations: Added.
platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

3:01 AM Changeset in webkit [127849] by zandobersek@gmail.com

4 edits
1 add in trunk/Tools

[NRWT] XvfbDriver should stop the Xvfb more aggressively
https://bugs.webkit.org/show_bug.cgi?id=95097

Reviewed by Dirk Pranke.

The Xvfb process is now killed when the XvfbDriver is stopping. Simply
terminating the process does not always work as expected, leading to timeouts
in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
as it's not removed by the killed Xvfb process.

Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
is tested in different circumstances - whether pixel tests are enabled or not,
with an arbitrary worker number or with an Xorg process already running on the system.
The stopping of the driver is tested by checking that the Xvfb process is truly killed
and then set to None.

BuildSlaveSupport/kill-old-processes:

Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
is left running, potentially clogging up a display at a certain position.

Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.init):
The _running_pids is now a dictionary with process names as keys and pids
as values.
(MockExecutive.check_running_pid):
Check whether the passed-in pid is in the _running_pids dictionary's values.
(MockExecutive):
(MockExecutive.running_pids):
This method returns the list of all the process pids of which the name passes
through the process_name_filter.

Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

Use the Executive object of the port's host to check for running pids and open
new subprocesses or kill them throughout the class.
(XvfbDriver._start):
Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
start the server process after it's created.
(XvfbDriver.stop):
Now kills the Xvfb process instead of terminating it and waiting for it to close.

Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.

(XvfbDriverTest):
(XvfbDriverTest.make_driver):
(XvfbDriverTest.assertDriverStartSuccessful):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_start_existing_xorg_process):
(XvfbDriverTest.test_stop):
(XvfbDriverTest.test_stop.FakeXvfbProcess):

2:59 AM Changeset in webkit [127848] by gyuyoung.kim@samsung.com

6 edits in trunk/Source/WebKit/efl

Unreviewed, rolling out r127839.
http://trac.webkit.org/changeset/127839
https://bugs.webkit.org/show_bug.cgi?id=90603

This patch was landed with wrong implementation and policy.

WebCoreSupport/NotificationPresenterClientEfl.cpp:

(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

WebCoreSupport/NotificationPresenterClientEfl.h:

(NotificationPresenterClientEfl):

ewk/ewk_view.cpp:

(_ewk_view_priv_new):

ewk/ewk_view.h:
ewk/ewk_view_private.h:

2:20 AM Changeset in webkit [127847] by peter@chromium.org

2 edits in trunk/Tools

Introduce the Chromium Android Release (Tests) bot
https://bugs.webkit.org/show_bug.cgi?id=95980

Reviewed by Adam Barth.

This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
which will be running layout tests on actual Android devices. Right now,
four Galaxy Nexus phones are attached.

BuildSlaveSupport/build.webkit.org-config/config.json:

1:58 AM Changeset in webkit [127846] by nduca@chromium.org

2 edits in trunk/Source/Platform

[chromium] Allow enumeration of WebRenderingStats structure
https://bugs.webkit.org/show_bug.cgi?id=94565

Reviewed by James Robinson.

chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(Enumerator):
(WebKit::WebRenderingStats::Enumerator::~Enumerator):
(WebKit::WebRenderingStats::enumerateFields):

1:52 AM Changeset in webkit [127845] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] APIClientTraits<WKPageLoaderClient> and APIClientTraits<WKBundlePageLoaderClient> are not initialized properly
https://bugs.webkit.org/show_bug.cgi?id=96079

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

APIClientTraits<WKPageLoaderClient> was missing offset for version number 2 and
APIClientTraits<WKBundlePageLoaderClient> was missing offset for version number 3.

Shared/APIClientTraits.cpp:

(WebKit):

1:47 AM Changeset in webkit [127844] by annacc@chromium.org

3 edits
1 delete in trunk/LayoutTests

Rebaselines for windows due to r127831.

Unreviewed gardening.

platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:

1:46 AM Changeset in webkit [127843] by yosin@chromium.org

6 edits in trunk/Source

We should have a localized string of empty for date time field
https://bugs.webkit.org/show_bug.cgi?id=96081

Reviewed by Kent Tamura.

Source/Platform:

This patch adds a localized string enum field for empty field value
description text for accessibility support in multiple fields date
time related input types for Chromium ports.

chromium/public/WebLocalizedString.h: Added AXDateTimeFieldEmptyValueText

enum field.

Source/WebCore:

This patch add a declaration of function for getting localized string
of empty field value date time field for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

platform/LocalizedStrings.h:

(WebCore): Added a declaration of AXDateTimeFieldEmptyValueText().

Source/WebKit/chromium:

This patch add a function for getting localized string of empty field
value of date time fields for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

src/LocalizedStrings.cpp:

(WebCore::AXDateTimeFieldEmptyValueText): Added.

1:28 AM Changeset in webkit [127842] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs to enable or disable the mouse events of the ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=88631

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

We can turn on/off the mouse events of the ewk_view using the mouse
events enabling API. This API can be used when we want to turn off the
mouse events on the touchscreen device to process the touch events
instead of the mouse events.

UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_smart_add):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):

UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

1:19 AM Changeset in webkit [127841] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebCore

[EFL] Use ASCIILiteral for cursorStringMap.
https://bugs.webkit.org/show_bug.cgi?id=96072

Reviewed by Gyuyoung Kim.

This patch converts static strings of cursorStringMap to use ASCIILiteral
as recommended by http://trac.webkit.org/wiki/EfficientStrings.

platform/efl/EflScreenUtilities.cpp:

(WebCore::CursorMap::CursorMap):

1:08 AM Changeset in webkit [127840] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Scrolling performance logging should use WTFLogAlways instead of printf
https://bugs.webkit.org/show_bug.cgi?id=96080

Reviewed by Dan Bernstein.

Use WTF logging facilities instead of printf() for scrolling performance logging.

page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::logExposedUnfilledArea):

platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer logFilledFreshTile]):

12:56 AM Changeset in webkit [127839] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/efl

[EFL] Support the permission function of the Web Notification.
https://bugs.webkit.org/show_bug.cgi?id=90603

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

Implement permission related functions of Web Notifications.
checkPermission for Notification.permissionLevel().
requestPermission for Notification.requestPermission().
In addition, if the application(like a browser) has permitted domains already,
it can be cached using ewk_view_notification_permissions_store.

WebCoreSupport/NotificationPresenterClientEfl.cpp:

WebCoreSupport/NotificationPresenterClientEfl.h:

(WebCore):
(NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_notification_permission_store):
(ewk_view_notification_permissions_set):
(ewk_view_notification_permission_request):

ewk/ewk_view.h:
ewk/ewk_view_private.h:

12:48 AM Changeset in webkit [127838] by macpherson@chromium.org

4 edits in trunk/Source/WebCore

Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
https://bugs.webkit.org/show_bug.cgi?id=95938

Reviewed by Andreas Kling.

Several unit types have been added without updating the cleanup function, including CSS_VARIABLE_NAME.
I've added all the existing unit types back in and cast m_primitiveUnitType (a bitfield in CSSValue)
to the enum type to ensure the compiler catches any future errors.

No test added, but switch made to use enum type so we can't accidentally fail to update this function again.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cleanup):

12:45 AM Changeset in webkit [127837] by timothy_horton@apple.com

16 edits in trunk/Source

Add optional debug logging when we fall into/out of threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898
<rdar://problem/12089098>

Reviewed by Simon Fraser.

Add logging when we enter and exit the threaded scrolling mode, and logs the reasons we
fall into main-thread scrolling.

The logging output looks like this:

SCROLLING: Switching to main-thread scrolling mode. Time: 15843.554718 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15844.550866
SCROLLING: Switching to main-thread scrolling mode. Time: 15845.551214 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15846.552619
SCROLLING: Switching to main-thread scrolling mode. Time: 15847.553587 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15848.554084

No new tests, as this is just debugging logging.

WebCore.xcodeproj/project.pbxproj:

Expose ScrollingTreeState.h as a private header.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):

page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThreadReason):
(ScrollingTreeNode):

page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThreadReason):

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):
Rename updateShouldUpdateScrollLayerPositionOnMainThread to updateShouldUpdateScrollLayerPositionOnMainThreadReason (and related).

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerViewportConstrainedObjects):
Renamed from hasNonLayerFixedObjects to match the rest of the renames going on.
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThreadReason):
Construct a bitfield describing the reasons we fall into main-thread scrolling mode.

page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):
Add ReasonsForUpdatingScrollLayerPositionOnMainThread enum, with the current reasons that we might fallback to main-thread scrolling.

page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore):
(WebCore::ScrollingTreeNodeMac::update): Log every time scrolling mode changes.
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::logThreadedScrollingMode): Pretty-print the scrolling mode and shouldUpdateScrollLayerPositionOnMainThreadReason.

Update the scrolling tree's scrollingPerformanceLoggingEnabled preference
before the early-return if we don't have layer debugging borders on.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

12:04 AM Changeset in webkit [127836] by annacc@chromium.org

10 edits
1 add in trunk/LayoutTests

Rebaselines due to r127831.

Unreviewed gardening.

platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt:
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:

12:03 AM Changeset in webkit [127835] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Build fix for WinCE after r127801.

platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed