Timeline



Sep 9, 2012:

11:54 PM Changeset in webkit [128020] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Clean up the code in XvfbDriver
​https://bugs.webkit.org/show_bug.cgi?id=96202

Reviewed by Philippe Normand.

Changes:

  • Remove unneeded imports,
  • assign the _lock_file member variable when the display number is determined,
  • no need for parentheses around a single string format argument,
  • use FileSystem.exists method when checking if lock file is present as it

makes the intention much more clearer.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):
(XvfbDriver.stop):

11:23 PM Changeset in webkit [128019] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding text failure expectations for three spatial navigation failures
that regressed after r128006.

  • platform/gtk/TestExpectations:
11:22 PM Changeset in webkit [128018] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

successCallback of ResolveLocalFileSystemURL should not be optional.
​https://bugs.webkit.org/show_bug.cgi?id=94802

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-09-09
Reviewed by Kent Tamura.

Spec says it should not optional.
​http://www.w3.org/TR/file-system-api/#widl-LocalFileSystem-resolveLocalFileSystemURL-void-DOMString-url-EntryCallback-successCallback-ErrorCallback-errorCallback

Source/WebCore:

Tests: fast/filesystem/entry-points-missing-arguments.html

  • Modules/filesystem/DOMWindowFileSystem.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:

LayoutTests:

  • fast/filesystem/entry-points-missing-arguments-expected.txt: Added.
  • fast/filesystem/entry-points-missing-arguments.html: Added.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
10:53 PM Changeset in webkit [128017] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests to paint the bots green.

  • platform/qt/Skipped:
10:25 PM Changeset in webkit [128016] by keishi@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r127558): Fix a crash in DateTimeChooserImpl::didClosePopup
​https://bugs.webkit.org/show_bug.cgi?id=96222

Reviewed by Kent Tamura.

DateTimeChooserClient will delete DateTimeChooserImpl inside didEndChooser()
so we shouldn't be changing the members after that.

Testing covered by fast/forms/date/calendar-picker-appearance-pre-100.html.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::didClosePopup):

9:25 PM Changeset in webkit [128015] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Source/JavaScriptCore: Fixed a few llint C++ interpreter bugs.
​https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-09-09
Reviewed by Geoffrey Garen.

  • llint/LLIntCLoop.h:

CLoop::execute()'s bootstrapOpcodeId does not need a default
value. There is no case when this function is called without
that parameter being specified.

  • llint/LowLevelInterpreter.asm:

Moved the dispatchAfterCall() call to where it is needed.
For the C_LOOP back-end, it generates unreachable code.

  • llint/LowLevelInterpreter.cpp:

#include <wtf/Assertions.h> because LLIntAssembly.h needs it.

(JSC):

Fixed bug in SIGN_BIT32() macro.
Placate a MSVC warning for t0, and t1 being uninitialized.

(JSC::CLoop::execute):

The bootstrapOpcodeId arg should always be specified.
MSVC doesn't like UNUSED_PARAM() for labels. Switch to using

the new UNUSED_LABEL() macro.

  • offlineasm/cloop.rb:
  • offlineasm/generate_offset_extractor.rb:

Resolved a compiler warning found via MSVC.

Source/WTF: Fixed ASSERT() and ASSERT_AT() macros so that they can be used in
comma expressions. Also, added UNUSED_LABEL().
​https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <​mark.lam@apple.com> on 2012-09-09
Reviewed by Geoffrey Garen.

  • wtf/Assertions.h:
  • wtf/UnusedParam.h: Added UNUSED_LABEL(). Removed an obsolete comment.
9:19 PM Changeset in webkit [128014] by Patrick Gansterer
  • 26 edits in trunk/Source

Add StringBuilder::appendNumber() and use it
​https://bugs.webkit.org/show_bug.cgi?id=96030

Reviewed by Eric Seidel.

Also fix a bunch of append() vs. appendLiteral() issues in the surrounding code.

Source/JavaScriptCore:

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • interpreter/Interpreter.h:

(JSC::StackFrame::toString):

Source/WebCore:

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::hostName):

  • bindings/v8/ScriptController.cpp:

(WebCore::resourceString):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::customCssText):

  • dom/Position.cpp:

(WebCore::Position::formatForDebugger):

  • dom/Range.cpp:

(WebCore::Range::formatForDebugger):

  • html/FormController.cpp:

(WebCore::FormKeyGenerator::formKey):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::font):

  • inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::addProcessIdPrefixTo):

  • page/FrameTree.cpp:

(WebCore::FrameTree::uniqueChildName):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toRawString):

  • platform/Decimal.cpp:

(WebCore::Decimal::toString):

  • platform/network/ProxyServer.cpp:

(WebCore::appendProxyServerString):

  • platform/text/TextStream.cpp:

(WebCore::TextStream::operator<<):

  • platform/text/TextStream.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::nodePosition):

  • xml/XMLErrors.cpp:

(WebCore::XMLErrors::appendErrorMessage):

Source/WTF:

  • wtf/DateMath.cpp:

(WTF::makeRFC2822DateString):

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendNumber):

  • wtf/text/StringBuilder.h:

(StringBuilder):

8:34 PM Changeset in webkit [128013] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Wrong rendering results for square-button-appearance.html
​https://bugs.webkit.org/show_bug.cgi?id=85493

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2012-09-09
Reviewed by Gyuyoung Kim.

Source/WebCore:

A square-button is an element that has '-webkit-appearance: square-button' style.

If it is a block element,
the RenderBlock::recomputeLogicalWidth recalculate the width from the padding values.

But the recalculated width became wrong because the RenderThemeEfl::adjustSizeConstraints
called from RenderThemeEfl::adjustButtonStyle adds padding values for a button.

So, the adjustSizeConstraints must not be called for a square-button(SquareButtonPart).

Test : fast/css/square-button-appearance.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustButtonStyle): Call adjustSizeConstrains only for PushButtonPart and ButtonPart

LayoutTests:

Remove fast/css/square-button-appearance.html from TestExpectations because it became PASS.

  • platform/efl/TestExpectations:
7:44 PM Changeset in webkit [128012] by bashi@chromium.org
  • 1 edit
    1 copy
    1 move
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r128002

  • platform/chromium-mac/inspector/console/command-line-api-getEventListeners-expected.txt: Copied from LayoutTests/platform/chromium/inspector/console/command-line-api-getEventListeners-expected.txt.
  • platform/chromium-win/inspector/console/command-line-api-getEventListeners-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console/command-line-api-getEventListeners-expected.txt.
7:33 PM Changeset in webkit [128011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WK2] Minibrowser locks up when right clicking editable filed
​https://bugs.webkit.org/show_bug.cgi?id=96074

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-09
Reviewed by Gyuyoung Kim.

WebProcess crashes when the context menu type is SubmenuType and non-CROSS_PLATFORM_CONTEXT_MENUS is used.
It is because platformSubMenu() in the ContextMenuItemEfl.cpp returns null. This patch implements the setSubMenu()
and platformSubMenu() to set and return the subMenuItems.

  • platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore):

7:08 PM Changeset in webkit [128010] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Pass full target idl file path to CodeGenerator as a constructor argument.
​https://bugs.webkit.org/show_bug.cgi?id=96190

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-09
Reviewed by Kentaro Hara.

Passing idl file path to CodeGenerator would be useful because CodeGenerator* family could manipulate it when creating derived header and cpp files.

  • bindings/scripts/CodeGenerator.pm:

(new):
(ProcessDocument):

  • bindings/scripts/generate-bindings.pl:
6:09 PM Changeset in webkit [128009] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

Try to fix the build after r128006.

  • dom/Element.cpp:

(WebCore::Element::boundsInRootViewSpace): Updated for rename.
(WebCore::Element::getBoundingClientRect): Ditto.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox): Renamed boundingBox() to this, to avoid clashing
with the virtual function on Node. The 'get' prefix also indicates that the result is
returned in an out parameter.

  • svg/SVGElement.h:

(SVGElement):

5:45 PM Changeset in webkit [128008] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Replace WTF::numberToString() with String::numberToStringECMAScript()
​https://bugs.webkit.org/show_bug.cgi?id=96130

Reviewed by Benjamin Poulain.

The String class provides a nice wrapper for this function
in the meantime, so just use it to avoid code duplication.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType):

  • platform/Decimal.cpp:

(WebCore::Decimal::fromDouble):

5:33 PM Changeset in webkit [128007] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening after r127907

Fix CCRenderPassTest::copyShouldBeIdenticalExceptIdAndQuads

  • tests/CCRenderPassTest.cpp:

(CCRenderPassSize): Changed type of m_id

5:29 PM Changeset in webkit [128006] by eae@chromium.org
  • 27 edits in trunk/Source

Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
​https://bugs.webkit.org/show_bug.cgi?id=81413

Reviewed by David Hyatt.

Source/WebCore:

Rename Node::getRect and getPixelSnappedRect to boundingBox and
pixelSnappedBoundingBox respectively.

Remove overridden getRect method from ContainerNode as it calculates the
same rect as the Node implementation but in a more complicated and
error-prone way. Also remove the getUpperLeftCorner/getLowerRightCorner
support functions as they are no longer needed.

No new tests, no change in functionality.

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):
Update to call boundingBox.

  • dom/ContainerNode.cpp:
  • dom/ContainerNode.h:

Remove overridden getRect method and the getUpperLeftCorner/
getLowerRightCorner support methods .

  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::updateFocusAppearance):
Update to call boundingBox.

  • dom/Node.h:
  • dom/Node.cpp:

(WebCore::Node::boundingBox):
Rename getRect to boundingBox.

(WebCore::Node::pixelSnappedBoundingBox):
Rename getPixelSnappedRect to pixelSnappedBoundingBox.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::elementRectRelativeToRootView):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollElementToRect):
(WebCore::FrameView::scrollToAnchor):

  • page/SpatialNavigation.cpp:

(WebCore::nodeRectInAbsoluteCoordinates):
Update to call boundingBox/pixelSnappedBoundingBox.

Source/WebKit/chromium:

Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/efl:

Update ewk_frame to call pixelSnappedBoundingBox.

  • ewk/ewk_frame.cpp:

(ewk_frame_focused_element_geometry_get):

Source/WebKit/gtk:

Update ChromeClientGtk and webkitwebview to call pixelSnappedBoundingBox.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::mouseDidMoveOverElement):

  • webkit/webkitwebview.cpp:

(getLocationForKeyboardGeneratedContextMenu):
(webkit_web_view_query_tooltip):

Source/WebKit/qt:

Update qwebelement and qwebpage to call pixelSnappedBoundingBox.

  • Api/qwebelement.cpp:

(QWebElement::geometry):
(QWebElement::render):

  • Api/qwebpage.cpp:

(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):

Source/WebKit2:

Update WebPage to call pixelSnappedBoundingBox.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

4:59 PM Changeset in webkit [128005] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[chromium] Do not delete texture backing structures on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=96018

Patch by Christopher Cameron <​ccameron@chromium.org> on 2012-09-09
Reviewed by James Robinson.

Do not delete CCPrioritizedTexture::Backing structures on the main
thread. Instead, unlink them from their owning CCPrioritizedTexture
in the main thread, and have the impl thread then delete all unlinked
textures.

This is towards having the main thread not access the m_backings set,
which will allow the impl thread to traverse that set when deleting
resources in response to GPU memory management events.

Tested by existing eviction tests (CCLayerTreeHostTest's
TestEvictTextures, LostContextAfterEvictTextures)

Fix a place where single thread proxy wasn't setting the main thread
blocked state correctly.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::unlinkAllContentTextures):
(WebCore):
(WebCore::CCLayerTreeHost::deleteUnlinkedTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::unlinkAllBackings):
(WebCore):
(WebCore::CCPrioritizedTextureManager::deleteAllUnlinkedBackings):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

3:49 PM Changeset in webkit [128004] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Rebaseline media/video-zoom-controls on chromium-mac for subpixel change.

  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
3:48 PM Changeset in webkit [128003] by weinig@apple.com
  • 12 edits in trunk

Switch to entering the sandbox directly from main(), rather than waiting for the initialization message
​https://bugs.webkit.org/show_bug.cgi?id=96194

Reviewed by Dan Bernstein.

Source/WebKit2:

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Pass a client identifier to WebProcess as a command line argument
so that it can be used to create private temporary and cache directories.

  • WebProcess/WebProcess.h:

(WebProcess):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
Expose the initializeSandbox() function and stop calling it from platformInitializeWebProcess()
since it is now going to be called from WebProcessMain. Also, move changing the current working
directory to sandbox initialization function and replace use of creation parameters with just
the client identifier.

  • WebProcess/com.apple.WebProcess.sb.in:

Add some new exceptions that come from entering the sandbox earlier in the AppKit
initialization process. Don't allow access to com.apple.coreservices.appleevents.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMainXPC):
(WebKit::WebProcessMain):
Enter the sandbox explicitly, not waiting until the initialization message. Also,
since we now have an extra parameter for the client identifier, make the WebProcess
launches the UIProcess code path work by extracting a client identifier from the
client executable path.

WebKitLibraries:

Update WKSI with SPI for getting the bundle URL from an executable URL.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:

Adds WKCopyBundleURLForExecutableURL().

3:26 PM Changeset in webkit [128002] by kling@webkit.org
  • 5 edits in trunk

EventListenerMap: Use Vector instead of HashMap as backend.
<​http://webkit.org/b/77982>

Reviewed by Geoff Garen.

Source/WebCore:

Refactor EventListenerMap to store pair<AtomicString, EventListenerVector> in a Vector
instead of using key/value HashMap stores. This is much more space efficient and actually
faster since we were spending more time/effort managing the hash map than it costs us
to iterate over and compare a couple of pointers. (It's very rare to have more than
4 different event types registered in a single EventListenerMap.)

This gets rid of the slightly hacky optimization for nodes with listeners of a single type,
reducing the complexity of EventListenerMap greatly.

~1.1MB progression on Membuster. Also strong (20+ MB on larger patches) savings on WebKit
bugzilla review pages, though they don't necessarily represent a common usecase.

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::eventTypes):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::nextListener):

  • dom/EventListenerMap.h:

(WebCore::EventListenerMap::isEmpty):
(WebCore::EventListenerMapEntry::EventListenerMapEntry):
(EventListenerMapEntry):
(EventListenerMap):
(EventListenerIterator):

LayoutTests:

Rebaseline inspector test whose output depended on the internal ordering of event
listeners (changed as listeners are no longer stored in an unordered HashMap.)

  • inspector/console/command-line-api-getEventListeners-expected.txt:
3:20 PM Changeset in webkit [128001] by Lucas Forschler
  • 2 edits in tags/Safari-537.9.1/Source/WebCore

Merged r127998.

3:16 PM Changeset in webkit [128000] by Lucas Forschler
  • 4 edits in tags/Safari-537.9.1/Source

Versioning.

3:14 PM Changeset in webkit [127999] by Lucas Forschler
  • 1 copy in tags/Safari-537.9.1

New Tag.

3:11 PM Changeset in webkit [127998] by Lucas Forschler
  • 2 edits in trunk/Source/WebCore

Build Fix. <rdar://problem/12260893>

  • platform/graphics/mac/WebGLLayer.mm:
2:21 PM Changeset in webkit [127997] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r127979.
​http://trac.webkit.org/changeset/127979
​https://bugs.webkit.org/show_bug.cgi?id=96217

Appears to have broken the windows and linux builds (Requested
by jamesr_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-09

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

2:05 PM Changeset in webkit [127996] by jamesr@google.com
  • 2 edits in trunk/Source/Platform

[chromium] Export WebFilterOperation(FilterType, SkScalar[20]) constructor
​https://bugs.webkit.org/show_bug.cgi?id=96215

Reviewed by Adrienne Walker.

Unlike the other WebFilterOperation constructors this one is defined out-of-line and so must be exported to be
usable outside of WebKit.dll

  • chromium/public/WebFilterOperation.h:

(WebFilterOperation):

2:04 PM Changeset in webkit [127995] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] webkit_platform should only be linked into the webkit target
​https://bugs.webkit.org/show_bug.cgi?id=96213

Reviewed by Adrienne Walker.

The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
2:04 PM Changeset in webkit [127994] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
​https://bugs.webkit.org/show_bug.cgi?id=96212

Reviewed by Adrienne Walker.

The static ::create()s the test references currently are going away soon.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::TEST_F):

2:02 PM Changeset in webkit [127993] by dmazzoni@google.com
  • 7 edits in trunk/LayoutTests

Unreviewed.\n\nRebaselining 5 mac accessibility tests, skipping one.\n\nhttps://bugs.webkit.org/show_bug.cgi?id=96173

1:52 PM Changeset in webkit [127992] by dmazzoni@google.com
  • 7 edits in trunk/LayoutTests

Unreviewed, rolling out r127963.
​http://trac.webkit.org/changeset/127963
​https://bugs.webkit.org/show_bug.cgi?id=96173

Inappropriately modified test, and not just expectations,
without review. Will land changes to expectations only, and then
upload a patch to modify the test for review.

  • accessibility/transformed-element-expected.txt:
  • platform/mac/accessibility/image-map2-expected.txt:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/accessibility/table-one-cell-expected.txt:
  • platform/mac/accessibility/update-children-when-aria-role-changes.html:
1:48 PM Changeset in webkit [127991] by Patrick Gansterer
  • 17 edits
    1 delete in trunk

Make the String initialization on the function side of String::number()
​https://bugs.webkit.org/show_bug.cgi?id=95940

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Source/WTF:

Un-Inline String::number() to make the String initialization done on the function side
instead of being on the caller side.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/IntegerToStringConversion.cpp: Removed.
  • wtf/text/IntegerToStringConversion.h:

(WTF::numberToStringImpl):
(WTF::numberToStringSigned):
(WTF::numberToStringUnsigned):

  • wtf/text/WTFString.cpp:

(WTF::String::number):

  • wtf/text/WTFString.h:

Tools:

  • TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:

(testBoundaries):
(testNumbers):

10:40 AM Changeset in webkit [127990] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Mark sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A5.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=96210

Unreviewed EFL gardening.

Mark additional sputnik test as flaky on WK2 EFL build bot.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-09

  • platform/efl-wk2/TestExpectations:
10:34 AM Changeset in webkit [127989] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Mark fast/innerHTML/innerHTML-iframe.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=96209

Unreviewed EFL gardening.

Mark fast/innerHTML/innerHTML-iframe.html as flaky for
both WK1 and WK2 EFL.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-09

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
10:22 AM Changeset in webkit [127988] by pierre.rossi@gmail.com
  • 22 edits in trunk

[WK2] expose element rect for color input type
​https://bugs.webkit.org/show_bug.cgi?id=91664

Reviewed by Simon Hausmann.

Source/WebKit2:

In the same way we do for select elements already. This allows placing the picker
in a sensible location.

  • UIProcess/API/efl/PageClientImpl.cpp: Update the function's signature.

(WebKit::PageClientImpl::createColorChooserProxy): Ditto.

  • UIProcess/API/efl/PageClientImpl.h: Ditto.

(PageClientImpl):

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createColorChooserProxy): Ditto.

  • UIProcess/API/gtk/PageClientImpl.h: Ditto.

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.h: Ditto.

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createColorChooserProxy): Ditto.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebViewPrivate::createColorChooserProxy): Ditto.

  • UIProcess/API/qt/raw/qrawwebview_p_p.h: Ditto.

(QRawWebViewPrivate):

  • UIProcess/PageClient.h: Ditto.

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showColorChooser): Compute the rect mapped to the current view's transform.

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::createColorChooserProxy):

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • UIProcess/qt/WebColorChooserProxyQt.cpp:

(ColorChooserContextObject):
(WebKit::ColorChooserContextObject::ColorChooserContextObject):
(WebKit::ColorChooserContextObject::elementRect):
(WebKit::ColorChooserContextObject::accept):
(WebKit::WebColorChooserProxyQt::WebColorChooserProxyQt):

  • UIProcess/qt/WebColorChooserProxyQt.h:

(WebKit::WebColorChooserProxyQt::create):
(WebColorChooserProxyQt):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createColorChooserProxy): Update the function's signature.

  • UIProcess/win/WebView.h:

(WebView): Ditto.

  • WebProcess/WebCoreSupport/WebColorChooser.cpp:

(WebKit::WebColorChooser::WebColorChooser):

Tools:

Update the QML logic in MiniBrowser to take advantage of this.
The picker size is now hardcoded and we try to place it below the
input element if possible.

  • MiniBrowser/qt/qml/ColorChooser.qml:
10:10 AM Changeset in webkit [127987] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rolled out <​http://trac.webkit.org/changeset/127939> because it broke
fast/js/named-function-expression.html.

Refactored bytecode generator initialization to support moving captured vars around
​https://bugs.webkit.org/show_bug.cgi?id=96159

Reviewed by Gavin Barraclough.

9:46 AM Changeset in webkit [127986] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Add missing files to the WebKit2 build on Windows
​https://bugs.webkit.org/show_bug.cgi?id=96177

Reviewed by Kenneth Rohde Christiansen.

For the build on Windows we can re-use existing functionality from the Safari/Windows
build, such as the IPC implementation.

  • Target.pri:
9:44 AM Changeset in webkit [127985] by rakuco@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[EFL][WK2] Gardening to make the bot green
​https://bugs.webkit.org/show_bug.cgi?id=96208

Unreviewed EFL gardening.

Update TestExpectations to make the EFL WK2 bot green.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-09

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/fast/events/mouseup-from-button2-expected.txt: Added. Test

needs baseline for wk2 (better output).

9:34 AM Changeset in webkit [127984] by anilsson@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix flicker due to introduction of the fence extension.
​https://bugs.webkit.org/show_bug.cgi?id=96207

Reviewed by George Staikos.

Don't immediately add fence to garbage list, so it is destroyed
after only one swap, for a set of tiles just because one tile in
the set gets a new fence, the old fence may still not be signalled
and before rendering the other tiles in the set we have to wait for it.

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::Fence::~Fence):
(WebKit):

  • WebKitSupport/BackingStoreTile.h:

(WebKit):
(Fence):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
(WebKit):
(BlackBerry::WebKit::SurfacePool::destroyPlatformSync):

  • WebKitSupport/SurfacePool.h:

(SurfacePool):

7:46 AM Changeset in webkit [127983] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2] Fix PLATFORM(WIN) vs. OS(WINDOWS) in various files
​https://bugs.webkit.org/show_bug.cgi?id=96178

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-09-09
Reviewed by Kenneth Rohde Christiansen.

PLATFORM(WIN) is used in various places, where it is safe to use OS(WINDOWS) to allow
the re-use of that code path in ports beyond Safari/Windows.

  • Platform/CoreIPC/BinarySemaphore.h:

(BinarySemaphore):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/SharedMemory.h:

(Handle):
(SharedMemory):

  • Platform/WorkQueue.h:
7:37 AM Changeset in webkit [127982] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Unskip test cases passing reliably on the bots
​https://bugs.webkit.org/show_bug.cgi?id=96204

Unreviewed EFL gardening.

Unskip test cases that are passing reliably on the
EFL build bots.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-09

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:57 AM Changeset in webkit [127981] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build break when MEDIA_STREAM is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=96063

Unreviewed. Fix build break when MEDIA_STREAM is enabled.

  • CMakeLists.txt:
1:00 AM Changeset in webkit [127980] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding expectations for two crashing tests and two regressions.

  • platform/gtk/TestExpectations:
12:47 AM Changeset in webkit [127979] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] convertEventTargetToV8Object doesn't need to be overloaded
​https://bugs.webkit.org/show_bug.cgi?id=96195

Reviewed by Kentaro Hara.

WTF::getPtr solves this problem for us.

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

12:39 AM Changeset in webkit [127978] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] V8PerContextData holds m_context using a v8::Handle rather than a v8::Persistent
​https://bugs.webkit.org/show_bug.cgi?id=96193

Reviewed by Kentaro Hara.

There are two types of handles in V8: Local and Persistent. We are now
permitted to keep Local handles in the heap because they get
deallocated when the C++ stack unwinds and v8::HandleScope objects are
destructed.

V8PerContextData holds its m_context using the non-specific v8::Handle
type. If we used a Local handle here, we'd have a memory safety
problem. Thankfully, we use a Persistent handle, which need to be
allocated and freed manually.

This patch makes the type of V8PerContextData::m_context more specific
to ensure that we never try to store a local handle in this variable.
This patch should not have any behavior change because we were already
storing a Persistent handle.

  • bindings/v8/V8PerContextData.h:

(WebCore::V8PerContextData::create):
(WebCore::V8PerContextData::V8PerContextData):
(V8PerContextData):

12:27 AM Changeset in webkit [127977] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] V8DOMWindowShell does not need to be RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=96192

Reviewed by Kentaro Hara.

V8DOMWindowShell holds a raw Frame pointer, which would point to
unallocated memory if any object that wasn't owned by the frame took a
reference to a V8DOMWindowShell. Thankfully, the only object that takes
a reference to the V8DOMWindowShell is ScriptController, which is owned
by the Frame.

This patch stops V8DOMWindowShell from being RefCounted so that no
other objects are tempted to take a reference to it in the future.

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::create):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

Sep 8, 2012:

11:48 PM Changeset in webkit [127976] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] unsafeHandleToCurrentWorldContext doesn't need to exist
​https://bugs.webkit.org/show_bug.cgi?id=96191

Reviewed by Kentaro Hara.

Previously, we used this function when instantiating DOM wrappers. Now
we get the context from the creationContext, so we don't need access to
this unsafe handle. This patch inlines the function into its one other
caller.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/ScriptController.h:

(ScriptController):

9:29 PM Changeset in webkit [127975] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
​https://bugs.webkit.org/show_bug.cgi?id=96027

Patch by Max Feil <​mfeil@rim.com> on 2012-09-08
Reviewed by Antonio Gomes.

The changes for bug 87337 (landed as trunk svn revision 119119)
introduced a bug. The same conditions are not checked on enter
fullscreen vs. exit. Web sites such as ​http://videojs.com
and youtube's mobile HTML5 player make the div container
of the video element go fullscreen. This is allowed in
WebPagePrivate::enterFullScreenForElement() but disallowed in
WebPagePrivate::exitFullScreenForElement(). I am fixing this by
allowing containers of video elements to exit fullscreen.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

5:35 PM Changeset in webkit [127974] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Specialize nextBreakablePosition depending on breakNBSP
​https://bugs.webkit.org/show_bug.cgi?id=96042

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-08
Reviewed by Eric Seidel.

The speed of isBreakableSpace() is limited by the speed of the inner loop of nextBreakablePosition().
The branches done to handle noBreakSpace can be simplified outside the loop
to reduce the number of tests inside the loop.

This patch split the code of nextBreakablePosition() in two function, depending if breakNBSP is true
or false.

If breakNBSP is true, isBreakableSpace() would return true on noBreakSpace.
->There is no need to test that value again for needsLineBreakIterator().
->There is no need to special case the switch() of isBreakableSpace() for noBreakSpace.

If breakNBSP is false:
->isBreakableSpace() does not need to test for noBreakSpace.

On x86_64, this improves PerformanceTests/Layout/line-layout.html by 2.8%.

  • rendering/break_lines.cpp:

(WebCore::isBreakableSpace):
(WebCore::nextBreakablePositionIgnoringNBSP):
(WebCore::nextBreakablePosition):

  • rendering/break_lines.h:

(WebCore::isBreakable): Remove the default value for breakNBSP, no caller is using it.

12:50 PM Changeset in webkit [127973] by kling@webkit.org
  • 2 edits in trunk/Source/WTF

Give AtomicString SimpleClassVectorTraits.
<​http://webkit.org/b/96186>

Reviewed by Karl Anders Carlsson.

AtomicString can be initialized/moved/compared with memset/memcpy/memcmp,
so add a VectorTraits<AtomicString> to make Vector<AtomicString> a little
more efficient.

  • wtf/VectorTraits.h:
11:17 AM Changeset in webkit [127972] by commit-queue@webkit.org
  • 24 edits
    1 delete in trunk

[V8] DOM wrapper creation involves a bunch of sketchy code related to finding the Frame
​https://bugs.webkit.org/show_bug.cgi?id=96147

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-08
Reviewed by Eric Seidel.

Source/WebCore:

Previously, we used the Frame when instantiating DOM wrappers. That's
sketchy because not all DOM wrappers know how to find their Frame, and
the Frame might be displaying a different document now anyway. This
patch now gets all the information directly from the creation context.

In addition, this patch gets the proper creation context in a few more
cases, including Location.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8PerContextData.cpp:

(WebCore):
(WebCore::V8PerContextData::current):
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

  • bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

The V8 results for this test now match the JSC results. We can remove
the chromium-specific baseline.

  • platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Removed.
8:24 AM Changeset in webkit [127971] by jchaffraix@webkit.org
  • 12 edits
    2 moves
    5 deletes in trunk/LayoutTests

[Chromium] Layout Tests tables/mozilla/bugs/bug27038*.html are failing
​https://bugs.webkit.org/show_bug.cgi?id=93006

Unreviewed Chromium rebaselining.

The tests were not rebaselined after bug 81826 (the TestExpectations were wrongly pointing
to bug 37244). The new rebaselines are expected as we add the extra logical height to the
last section, which was our original behavior before bug 37244.

  • platform/chromium-linux/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.txt: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt: Removed.
  • tables/mozilla/bugs/bug27038-1-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt.
  • tables/mozilla/bugs/bug27038-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt.
5:21 AM Changeset in webkit [127970] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

LLInt buildfix for case sensitive filesystems
​https://bugs.webkit.org/show_bug.cgi?id=96099

Reviewed by Michael Saboff.

  • llint/LowLevelInterpreter.cpp: Fix filenames.
4:37 AM Changeset in webkit [127969] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening of failing tests after r127939
​https://bugs.webkit.org/show_bug.cgi?id=96182

Unreviewed EFL gardening of failing tests after r127939.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-09-08

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:57 AM Changeset in webkit [127968] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Minibrowser crashes on right mouse click
​https://bugs.webkit.org/show_bug.cgi?id=95955

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-08
Reviewed by Simon Hausmann.

Make early return if the PageClient does not create a ContextMenuProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

3:50 AM Changeset in webkit [127967] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Fix CoreIPC setup between ProcessLauncher and WebProcessMain on Windows
​https://bugs.webkit.org/show_bug.cgi?id=96179

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-09-08
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Hide Unixy platform specific code
and includes behind appropriate platform #ifdefs and use
CoreIPC::Connection::createServerAndClientIdentifiers to set up the IPC pipes.
We also need to tell Windows about our intent of using the client handle in
the child web process.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt): After retrieving the IPC identifier we call
WebKit::WebProcess::shared().initialize with it. That function actually
cares a CIPC::Connection::Identifier as argument, which happens to be an
int on Unix, but it's actually a HANDLE on Windows. Change the parameter
type according to and a reinterpret_cast from the converted unsigned integer,
similar to WebProcessMainWin.cpp.

3:48 AM Changeset in webkit [127966] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
​https://bugs.webkit.org/show_bug.cgi?id=95329

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add implementation for overriding the WebKitTabToLinksPreferenceKey
preference as well as the corresponding WKPreferences API that
is needed by WebKitTestRunner.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTabToLinksEnabled):
(WKPreferencesGetTabToLinksEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setTabToLinksEnabled):
(WebKit::WebPage::tabToLinksEnabled):

Tools:

Explicitely disable TabToLinks setting in WebKitTestRunner.
Tests override the "WebKitTabToLinksPreferenceKey" preference
to enable it.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Unskip fast/events/tab-focus-link-in-canvas for WK2 now that WebKitTestRunner
supports overriding the "WebKitTabToLinksPreferenceKey" preference.

  • platform/efl-wk2/TestExpectations:
  • platform/wk2/Skipped:
12:36 AM Changeset in webkit [127965] by bashi@chromium.org
  • 2 edits in trunk/Tools

webkit.py gdb pretty printer can't print CString
​https://bugs.webkit.org/show_bug.cgi?id=96068

Reviewed by Tony Chang.

Update WTFCStringPrinter to follow r126191.

  • gdb/webkit.py:

(WTFCStringPrinter.to_string):

12:31 AM Changeset in webkit [127964] by anilsson@rim.com
  • 10 edits
    3 adds in trunk/Source/WebCore

[CSS Shaders] [BlackBerry] Refactor CustomFilterMesh and CustomFilter*Program
​https://bugs.webkit.org/show_bug.cgi?id=94725

Reviewed by George Staikos.

Separate the MeshGenerator from the CustomFilterMesh into
CustomFilterMeshGenerator.h/cpp. This allows the BlackBerry port to
reuse the mesh generator in its accelerated compositing implementation.

Also add support for creating a "PlatformCompiledProgram" from a
CustomFilterValidatedProgram, so the BlackBerry port can reuse the
shader validation code in its accelerated compositing implementation.

It turns out the GraphicsContext3D is not needed for ANGLE to function,
so this patch removes an ASSERT that required a context before
validating the shaders using ANGLE. This allows the BlackBerry port to
reuse the validation code without triggering the assert. In the future,
the validation code could be moved to a separate class to make it more
obvious that it isn't really related to GraphicsContext3D.

In general, this refactoring can be useful for any port that uses
OpenGL to implement accelerated compositing.

Inspired by an original patch by Joshua Netterfield.

No new tests, because this patch implements no new functionality.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

  • platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):

  • platform/graphics/filters/CustomFilterMeshGenerator.cpp: Added.

(WebCore):
(WebCore::CustomFilterMeshGenerator::CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshIndex):
(WebCore::CustomFilterMeshGenerator::generateAttachedMesh):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::CustomFilterMeshGenerator::generateDetachedMesh):
(WebCore::CustomFilterMeshGenerator::addPositionAttribute):
(WebCore::CustomFilterMeshGenerator::addTexCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addMeshCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addTriangleCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::dumpBuffers):

  • platform/graphics/filters/CustomFilterMeshGenerator.h: Added.

(WebCore):
(CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::vertices):
(WebCore::CustomFilterMeshGenerator::indices):
(WebCore::CustomFilterMeshGenerator::points):
(WebCore::CustomFilterMeshGenerator::pointsCount):
(WebCore::CustomFilterMeshGenerator::tiles):
(WebCore::CustomFilterMeshGenerator::tilesCount):
(WebCore::CustomFilterMeshGenerator::indicesCount):
(WebCore::CustomFilterMeshGenerator::floatsPerVertex):
(WebCore::CustomFilterMeshGenerator::verticesCount):
(WebCore::CustomFilterMeshGenerator::addTile):

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(WebCore):
(CustomFilterValidatedProgram):

  • platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Added.

(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

Note: See TracTimeline for information about the timeline view.