Context Navigation

← Previous Period
Next Period →

Timeline

Sep 15, 2012:

11:20 PM Changeset in webkit [128705] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Following the Butterfly refactoring, the comment for lastArraySize was not updated
https://bugs.webkit.org/show_bug.cgi?id=96877

Reviewed by Sam Weinig.

runtime/JSObject.cpp:

(JSC):

11:08 PM Changeset in webkit [128704] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Fixed JSLock to use the platform abstraction for Mutex instead of
depending on pthreads.
https://bugs.webkit.org/show_bug.cgi?id=96858.

Reviewed by Filip Pizlo.

This fixes a synchronization problem on the Windows port and makes
it more reliable when running the layout tests.

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

runtime/JSLock.cpp:

(JSC):
(JSC::GlobalJSLock::GlobalJSLock):
(JSC::GlobalJSLock::~GlobalJSLock):
(JSC::GlobalJSLock::initialize):

runtime/JSLock.h:

(GlobalJSLock):
(JSLock):

10:17 PM Changeset in webkit [128703] by commit-queue@webkit.org

12 edits
10 adds in trunk

Source/WebCore: Pause inspector when inline scripts are blocked by Content Security Policy.
https://bugs.webkit.org/show_bug.cgi?id=93865

Patch by Mike West <mkwst@chromium.org> on 2012-09-15
Reviewed by Pavel Feldman.

When Content Security Policy blocks an inline script that's been
injected after the document is parsed, a fairly unhelpful console
warning is generated; it points at line 1, regardless of where the error
occurred. This patch adjusts CSP to not only warn on the console, but
also to notify the inspector that it should pause execution if the
developer has toggled "Break on Exceptions". Developers will have a
better chance of tracking down the error, as they'll have a complete
call stack to work with.

Tests: inspector/debugger/debugger-pause-on-blocked-event-handler.html

inspector/debugger/debugger-pause-on-blocked-script-injection.html
inspector/debugger/debugger-pause-on-blocked-script-url.html

English.lproj/localizedStrings.js:

Adding localizable string for the new friendly pause message.

inspector/Inspector.json:

Add CSPViolation as a recognized reason for pausing execution.

inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):

Teach the InspectorDebuggerAgent about script blocking. If pause on
exceptions is enabled, call 'InspectorDebuggerAgent::breakProgram',
and pass in an error object with a description that points to CSP
as the culprit.

(WebCore):

inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSPImpl):

Wire 'InspectorInstrumentation::scriptExecutionBlockedByCSP' to
the InspectorDebuggerAgent backend.

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):

The public interface that should be kicked whenever CSP blocks
script execution.

(WebCore):

inspector/front-end/DebuggerModel.js:

Add CSPViolation as a recognized reason for pausing execution.

inspector/front-end/ScriptsPanel.js:

Add a friendly call stack status message for CSP violations.

page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):

If script is blocked because the nonce doesn't match, report the
blocked script to the inspector.

(WebCore::CSPDirectiveList::checkInlineAndReportViolation):

If inline script is blocked, report the blocked script to the
inspector. This requires adding a bool parameter to differentiate
blocking inline script from inline style.

(WebCore::CSPDirectiveList::allowJavaScriptURLs):

Tell 'checkInlineAndReportViolation' that we're dealing with script.

(WebCore::CSPDirectiveList::allowInlineEventHandlers):

Tell 'checkInlineAndReportViolation' that we're dealing with script.

(WebCore::CSPDirectiveList::allowInlineScript):

Tell 'checkInlineAndReportViolation' that we're dealing with script.

(WebCore::CSPDirectiveList::allowInlineStyle):

Tell 'checkInlineAndReportViolation' that we're not dealing with script.

(WebCore::ContentSecurityPolicy::reportBlockedScriptExecutionToInspector):

Public interface for the various CSP* classes to poke the inspector.

(WebCore):

page/ContentSecurityPolicy.h:

LayoutTests: Break on inline scripts blocked by CSP.
https://bugs.webkit.org/show_bug.cgi?id=93865

Patch by Mike West <mkwst@chromium.org> on 2012-09-15
Reviewed by Pavel Feldman.

inspector/debugger/debugger-pause-on-blocked-event-handler-expected.txt: Added.
inspector/debugger/debugger-pause-on-blocked-event-handler.html: Added.
inspector/debugger/debugger-pause-on-blocked-script-injection-expected.txt: Added.
inspector/debugger/debugger-pause-on-blocked-script-injection.html: Added.
inspector/debugger/debugger-pause-on-blocked-script-url-expected.txt: Added.
inspector/debugger/debugger-pause-on-blocked-script-url.html: Added.
inspector/debugger/resources/pause-on-blocked-by-csp.js: Added.

(test.setStatus):
(test.step1):
(test.step2):
(test):

inspector/debugger/resources/pause-on-blocked-event-handler.js: Added.

(testAction):

inspector/debugger/resources/pause-on-blocked-script-injection.js: Added.

(testAction):

inspector/debugger/resources/pause-on-blocked-script-url.js: Added.

(testAction):

10:03 PM Changeset in webkit [128702] by fmalita@chromium.org

3 edits
2 adds in trunk

<use> not working when the SVG doc is embedded as <object> data
https://bugs.webkit.org/show_bug.cgi?id=96816

Reviewed by Dirk Schulze.

Source/WebCore:

Updated SVGURIReference::isExternalURIReference() to correctly classify fragment-only URIs.
Also, since the fragment-only test is cheap, it should be the first thing to try.

Test: svg/custom/object-data-href.html

svg/SVGURIReference.h:

(WebCore::SVGURIReference::isExternalURIReference):

LayoutTests:

svg/custom/object-data-href-expected.html: Added.
svg/custom/object-data-href.html: Added.

9:34 PM Changeset in webkit [128701] by benjamin@webkit.org

9 edits in trunk/Source

Fix the build with WTF URL
https://bugs.webkit.org/show_bug.cgi?id=96875

Reviewed by Adam Barth.

Source/WebCore:

Fix reportMemoryUsage, the implementation was only partial.

WebCore.exp.in: Export two more symbols as needed by API tests.
platform/KURLWTFURL.cpp:

(WebCore::KURL::string): emptyString() return a reference,
it makes more sense than nullAtom() here.

platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WTF:

Add support for MemoryInstrumentation to WTF's URL classes.

wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::reportMemoryUsage):

wtf/url/api/ParsedURL.h:

(ParsedURL):

wtf/url/api/URLString.cpp:

(WTF::URLString::reportMemoryUsage):

wtf/url/api/URLString.h:

(URLString):

9:24 PM Changeset in webkit [128700] by krit@webkit.org

11 edits
1 add in trunk/Source/WebCore

Add ClipPathOperation for -webkit-clip-path organization
https://bugs.webkit.org/show_bug.cgi?id=95619

Reviewed by Dean Jackson.

This patch adds a new class ClipPathOperation to manage the values of the
-webkit-clip-path property. ClipPathOperation stores a Path object for clipping and is
a preparation for IRI references of the SVG 'clipPath' element.

The structure of ClipPathOperation is simular to FilterOperation.

ClipPathOperation will be extended to support IRI references directly in a second patch.

No new tests. The changes just affect the backend.

GNUmakefile.list.am: Added new ClipPathOperation class.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
css/CSSComputedStyleDeclaration.cpp: Use ClipPathOperation instead of BasicShape.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

css/StyleBuilder.cpp: Ditto.

(WebCore):
(WebCore::ApplyPropertyClipPath::setValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyClipPath::createHandler):

rendering/ClipPathOperation.h: Added. New handler for property values (BasicShape, references).

(WebCore):
(ClipPathOperation):
(WebCore::ClipPathOperation::~ClipPathOperation):
(WebCore::ClipPathOperation::operator!=):
(WebCore::ClipPathOperation::getOperationType): Return the operation type.
(WebCore::ClipPathOperation::isSameType): Helper function for =operator.
(WebCore::ClipPathOperation::ClipPathOperation):
(ShapeClipPathOperation): Inheriting class for managing BasicShapes.
(WebCore::ShapeClipPathOperation::create):
(WebCore::ShapeClipPathOperation::basicShape):
(WebCore::ShapeClipPathOperation::windRule):
(WebCore::ShapeClipPathOperation::path):
(WebCore::ShapeClipPathOperation::operator==):
(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):

rendering/RenderLayer.cpp: Use ClipPathOperation to apply clipping.

(WebCore::RenderLayer::paintLayerContents):

rendering/style/RenderStyle.h:
rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

rendering/svg/SVGRenderingContext.cpp: Ditto.

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

7:36 PM Changeset in webkit [128699] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Structure check hoisting fails to consider the possibility of conflicting checks on the source of the first assignment to the hoisted variable
https://bugs.webkit.org/show_bug.cgi?id=96872

Reviewed by Oliver Hunt.

This does a few related things:

It turns off the use of ForceOSRExit for sure-to-fail CheckStructures, because I noticed that this would sometimes happen for a ForwardCheckStructure. The problem is that ForceOSRExit exits backwards, not forwards. Since the code that led to those ForceOSRExit's being inserted was written out of paranoia rather than need, I removed it. Specifically, I removed the m_isValid = false code for CheckStructure/StructureTransitionWatchpoint in AbstractState.

If a structure check causes a structure set to go empty, we don't want a PutStructure to revive the set. It should instead be smart enough to realize that an empty set implies that the code can't execute. This was the only "bug" that the use of m_isValid = false was preventing.

Finally, the main change: structure check hoisting looks at the source of the SetLocals on structure-check-hoistable variables and ensures that the source is not checked with a conflicting structure. This is O(n^{2) but it does not
show up at all in performance tests.}

The first two parts of this change were auxiliary bugs that were revealed by
the structure check hoister doing bad things.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

4:31 PM Changeset in webkit [128698] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

WinCairo build fix due to missing symbols for setImagesEnabled and setStorageBlockingPolicy
https://bugs.webkit.org/show_bug.cgi?id=96866

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-09-15
Reviewed by Kentaro Hara.

Adding missing symbol defines in the def file to fix the build break
for WinCairo

win/WebKit2CFLite.def:

4:16 PM Changeset in webkit [128697] by kling@webkit.org

6 edits
2 adds in trunk

REGRESSION(r127438): Google Docs to renders text too small.
<http://webkit.org/b/96554>

Reviewed by Antti Koivisto.

Source/WebCore:

Don't remove the inline StylePropertySet from ElementAttributeData in ~StyledElement.
This behavior broke sharing of ElementAttributeData between elements with inline style,
since destroying one element would effectively disable the inline style from all other
elements that shared the same attribute data.

What we actually want in ~StyledElement is to detach from any CSSOM wrapper that may
have been instantiated. Added ElementAttributeData::detachCSSOMWrapperIfNeeded for this
purpose and call that instead.

Test: fast/dom/shared-inline-style-after-node-removal.html

dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::detachCSSOMWrapperIfNeeded):
(WebCore::ElementAttributeData::destroyInlineStyle):

dom/ElementAttributeData.h:

(ElementAttributeData):

dom/StyledElement.cpp:

(WebCore::StyledElement::~StyledElement):
(WebCore::StyledElement::styleAttributeChanged):

dom/StyledElement.h:

(StyledElement):

LayoutTests:

Add a test that an element that shared its inline style with another element works as expected
after the other element is destroyed.

fast/dom/shared-inline-style-after-node-removal-expected.txt: Added.
fast/dom/shared-inline-style-after-node-removal.html: Added.

3:59 PM Changeset in webkit [128696] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Include missing header files in the tarball
https://bugs.webkit.org/show_bug.cgi?id=96860

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-09-15
Reviewed by Kentaro Hara.

Build fix; dist two additional headers that are needed for building on
Windows platform.

GNUmakefile.list.am:

3:48 PM Changeset in webkit [128695] by rakuco@webkit.org

2 edits in trunk/Source/WTF

llint: Implement LOCAL_LABEL_STRING for the BSD platforms.
https://bugs.webkit.org/show_bug.cgi?id=96870

Patch by Raphael Kubo da Costa <rakuco@FreeBSD.org> on 2012-09-15
Reviewed by Filip Pizlo.

wtf/InlineASM.h: Extend the definition of LOCAL_LABEL_STRING

currently used for OS(LINUX) to the BSDs, since they also normally
use GNU as, and clang/llvm seems to parse that syntax just fine as
well.

3:48 PM Changeset in webkit [128694] by msaboff@apple.com

3 edits in trunk/Source/WebCore

Add 8 bit handling to SpaceSplitString
https://bugs.webkit.org/show_bug.cgi?id=96823

Reviewed by Sam Weinig.

Added templated functions based on character type to handle 8 and 16 bit string data.

dom/SpaceSplitString.cpp:

(WebCore::hasNonASCIIOrUpper):
(WebCore::SpaceSplitStringData::createVector):

dom/SpaceSplitString.h:

(SpaceSplitStringData):

3:26 PM Changeset in webkit [128693] by mitz@apple.com

6 edits
2 adds in trunk

REGRESSION (r125578): The monospace code path in RenderText::widthFromCache disagrees with Font::width on word spacing
https://bugs.webkit.org/show_bug.cgi?id=96869

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/text/word-space-monospace.html
This also fixes fast/css/word-spacing-characters.html

rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache): Made the conditions for adding word spacing match the
ones in WidthIterator.

LayoutTests:

fast/text/word-space-monospace-expected.html: Added.
fast/text/word-space-monospace.html: Added.
platform/mac/TestExpectations: Removed fast/css/word-spacing-characters.html.
platform/mac/fast/css/word-space-extra-expected.png: Updated.
platform/mac/fast/css/word-space-extra-expected.txt: Updated.

12:20 PM Changeset in webkit [128692] by mitz@apple.com

7 edits in trunk

REGRESSION (r125578): Word spacing not applied to newline and tab characters that are treated as spaces
https://bugs.webkit.org/show_bug.cgi?id=96865

Reviewed by Sam Weinig.

Source/WebCore:

Fixes fast/css/word-space-extra.html.

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal): Changed back to apply word spacing to all characters
that are treated as spaces, except for tab characters when there are tab stops.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.

LayoutTests:

fast/text/atsui-negative-spacing-features.html: Reverted changes made in r128691, now that

both code paths handle newlines correctly.

fast/text/atsui-spacing-features.html: Ditto.
platform/mac/TestExpectations: Removed fast/css/word-space-extra.html.

9:27 AM Changeset in webkit [128691] by mitz@apple.com

6 edits in trunk

REGRESSION (r125578): The Mac complex text code path disagrees with the fast path on word spacing
https://bugs.webkit.org/show_bug.cgi?id=96857

Reviewed by Anders Carlsson.

Source/WebCore:

Fixes the following tests when run with run-webkit-tests --complex-text:
css2.1/20110323/c541-word-sp-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm

Fixes fast/css/word-spacing-characters-complex-text.html

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Made the conditions for adding
word spacing match the ones in WidthIterator again.

LayoutTests:

fast/text/atsui-negative-spacing-features.html: Removed some newlines from this test,

because now that the complex text code path matches the fast path, it too suffers from a bug
where word spacing is not added at a newline.

fast/text/atsui-spacing-features.html: Ditto.
platform/mac/TestExpectations: Removed fast/css/word-spacing-characters-complex-text.html.

8:15 AM Changeset in webkit [128690] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit2

[EFL][WK2] Provide implementation for PageClientImpl::processDidCrash()
https://bugs.webkit.org/show_bug.cgi?id=96197

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-15
Reviewed by Gyuyoung Kim.

WebKit2 EFL does not have an implementation for PageClientImpl::processDidCrash().
So when WebProcess has crashed, UI process does nothing and is left alone as it is.

This patch checks if loading was ongoing, if so, set the load progress as 1.
Then send a signal callback "webprocess,crashed" for an application to handle it.
If the application does not handle the crash event, show an Eina Log warning message
with a url at web process exit and load an error page.

UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::processDidCrash):

UIProcess/API/efl/ewk_private.h:
UIProcess/API/efl/ewk_view.cpp:

(ewk_view_webprocess_crashed):

UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/ewk_view_private.h:

2:02 AM Changeset in webkit [128689] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Update test expectation

platform/chromium/TestExpectations:

Don't run an inspector test on Mac.

2:00 AM Changeset in webkit [128688] by pierre.rossi@gmail.com

6 edits in trunk/Source

[Qt] QDoc fixes for Qt 5 documentation
https://bugs.webkit.org/show_bug.cgi?id=96796

Reviewed by Simon Hausmann.

Source/WebKit/qt:

Produce fewer warnings and a better documentation.
Having two QML modules providing a WebView component is a bit too much for poor old qdoc to
cope with (or would require a lot of painful disambiguation by hand). Since the plan is to have
QDeclarativeWebView living in the qtquick1 module, we can already take it out of the
documentation generation for now.

declarative/qdeclarativewebview.cpp: s/qmlclass/qmltype/ out of principle
docs/qtwebkit.qdocconf: Remove the \i alias that caused a warning. Use *.h as headers suffix, not sources.

Also remove QDeclarativeWebView from the documentation.

Source/WebKit2:

Fixup miscellaneous qdoc commands syntax.

UIProcess/API/qt/qquickwebview.cpp:
UIProcess/API/qt/qwebloadrequest.cpp:

1:55 AM Changeset in webkit [128687] by tkent@chromium.org

13 edits in trunk/Source/WebCore

Unreviewed, rolling out r128669.
http://trac.webkit.org/changeset/128669
https://bugs.webkit.org/show_bug.cgi?id=96637

Broke http/tests/workers/text-encoding.html on Chromium Linux (dbg)

bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

bindings/v8/ScopedPersistent.h:
bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

1:23 AM Changeset in webkit [128686] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed weekend gardening. Skip 4 new failing tests to paint the bot green.

platform/qt-5.0-wk2/Skipped:

1:01 AM Changeset in webkit [128685] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening. Skip 2 new tests, because
TestRunner::overridePreference() does not support the 'WebKitDisplayImagesKey' preference

platform/qt/Skipped:

12:01 AM Changeset in webkit [128684] by mrowe@apple.com

2 edits in trunk/Source/WTF

Roll out r128682 since it broke the Mac release builds.

Sep 14, 2012:

11:14 PM Changeset in webkit [128683] by gyuyoung.kim@samsung.com

19 edits in trunk/Source/WebKit2

Add *explicit* keyword to constructors to WebKit2/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=96732

Reviewed by Kentaro Hara.

As a step of *explicit* cleanup for constructors which have only one parameter,
*explicit* is added to WebKit2/UIProcess in order to avoid implicit type conversion.

UIProcess/Authentication/AuthenticationDecisionListener.h:

(AuthenticationDecisionListener):

UIProcess/Authentication/WebCredential.h:

(WebCredential):

UIProcess/Authentication/WebProtectionSpace.h:

(WebProtectionSpace):

UIProcess/GenericCallback.h:

(WebKit::CallbackBase::CallbackBase):

UIProcess/InspectorServer/WebSocketServer.h:
UIProcess/ResponsivenessTimer.h:

(ResponsivenessTimer):

UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

UIProcess/WebBackForwardList.h:

(WebBackForwardList):

UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):

UIProcess/WebFullScreenManagerProxy.h:

(WebFullScreenManagerProxy):

UIProcess/WebGrammarDetail.h:

(WebGrammarDetail):

UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

UIProcess/WebNavigationData.h:

(WebNavigationData):

UIProcess/WebOpenPanelResultListenerProxy.h:

(WebOpenPanelResultListenerProxy):

UIProcess/WebPopupMenuProxy.h:

(WebKit::WebPopupMenuProxy::WebPopupMenuProxy):

UIProcess/WebPreferences.h:

(WebPreferences):

9:36 PM Changeset in webkit [128682] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

WTFString::show doesn't dump non-ASCII characters in a readable manner
https://bugs.webkit.org/show_bug.cgi?id=96749

Patch by Glenn Adams <glenn@skynav.com> on 2012-09-14
Reviewed by Benjamin Poulain.

Dump non-ASCII characters in a useful form for debugging.

wtf/text/WTFString.cpp:

(asciiDebug):
Dump non-ASCII characters (i.e., UTF-16 code elements) as well as non-printable ASCII characters
using \uXXXX format.

9:18 PM Changeset in webkit [128681] by jamesr@google.com

1 edit
9 moves
16 deletes in trunk/LayoutTests

Unreviewed gardening - more position:fixed stacking context rebaselines.

fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt.
fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt.
platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
platform/chromium-mac/fast/block/positioning/016-expected.txt: Removed.
platform/chromium-mac/fast/block/positioning/025-expected.txt: Removed.
platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
platform/chromium-win/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png.
platform/chromium-win/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png.
platform/chromium-win/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png.
platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt.
platform/chromium/fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt.
platform/chromium/fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt.
platform/chromium/fast/block/positioning/fixed-position-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt.
platform/efl/fast/block/positioning/016-expected.txt: Removed.
platform/efl/fast/block/positioning/025-expected.txt: Removed.
platform/gtk/fast/block/positioning/016-expected.txt: Removed.
platform/gtk/fast/block/positioning/025-expected.txt: Removed.
platform/qt/fast/block/positioning/016-expected.txt: Removed.
platform/qt/fast/block/positioning/025-expected.txt: Removed.

8:29 PM Changeset in webkit [128680] by fpizlo@apple.com

9 edits
1 delete in trunk/Source/JavaScriptCore

All of the things in SparseArrayValueMap should be out-of-line
https://bugs.webkit.org/show_bug.cgi?id=96854

Reviewed by Andy Estes.

Those inline methods were buying us nothing.

GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSArray.cpp:
runtime/JSGlobalData.cpp:
runtime/JSObject.cpp:
runtime/RegExpMatchesArray.cpp:
runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC):
(JSC::SparseArrayValueMap::~SparseArrayValueMap):
(JSC::SparseArrayValueMap::finishCreation):
(JSC::SparseArrayValueMap::create):
(JSC::SparseArrayValueMap::destroy):
(JSC::SparseArrayValueMap::createStructure):
(JSC::SparseArrayValueMap::add):
(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::getNonSparseMode):
(JSC::SparseArrayValueMap::visitChildren):

runtime/SparseArrayValueMapInlineMethods.h: Removed.

6:43 PM Changeset in webkit [128679] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

Unreviewed, rolling out r128673.
http://trac.webkit.org/changeset/128673
https://bugs.webkit.org/show_bug.cgi?id=96847

Makes plugins/document-open.html crash (Requested by jamesr_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

dom/ContainerNode.cpp:

(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

dom/ContainerNode.h:
dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):

dom/Document.cpp:

(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

dom/EventTarget.cpp:

(WebCore):
(WebCore::forbidEventDispatch):
(WebCore::allowEventDispatch):
(WebCore::eventDispatchForbidden):
(WebCore::EventTarget::fireEventListeners):

dom/EventTarget.h:

(WebCore):
(WebCore::forbidEventDispatch):
(WebCore::allowEventDispatch):

dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal):

6:38 PM Changeset in webkit [128678] by Beth Dakin

3 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=96846
Tests failing on WK2 bots after giving fixed positioning its own
stacking context

Reviewed by Geoffrey Garen.

Tests are failing because I checked in updated results that expect
fixed positioning to create a stacking context. However,
WebKitTestRunner does not enable ScrollingCoordinator, so the code
that I added to enable stacking contexts for fixedPos is never
actually running. This patch moves that code to a place where it will
run for the testing tools, which matches the patch for WK1.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updatePreferences):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

6:24 PM Changeset in webkit [128677] by jchaffraix@webkit.org

24 edits
7 deletes in trunk

Revert r127457 and following fixes due to several hit-testing regressions
https://bugs.webkit.org/show_bug.cgi?id=96830

Reviewed by Antonio Gomes.

This change reverts r127457, r127863 and r128505.

Source/autotools/symbols.filter:

Source/WebCore:

This change reverts r127457, r127863 and r128505.

WebCore.exp.in:
WebCore.order:
dom/Document.cpp:

(WebCore::Document::nodesFromRect):

dom/Document.h:

(Document):

page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

rendering/HitTestRequest.h:
rendering/HitTestResult.cpp:

(WebCore::HitTestLocation::HitTestLocation):

rendering/HitTestResult.h:

(HitTestLocation):

rendering/RenderFrameBase.cpp:
rendering/RenderFrameBase.h:

(RenderFrameBase):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit/chromium:

This change reverts r127457, r127863 and r128505.

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Source/WebKit2:

This change reverts r127457, r127863 and r128505.

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

This change reverts r127457, r127863 and r128505. As the tests relies on the extended API
after r127457, we cannot keep them.

fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Removed.
fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Removed.
fast/dom/nodesFromRect/resources/child-frame.html: Removed.
fast/dom/nodesFromRect/resources/nodesFromRect.js:

(check):
(checkShadowContent):

touchadjustment/iframe-boundary-expected.txt: Removed.
touchadjustment/iframe-boundary.html: Removed.
touchadjustment/resources/inner-content-page.html: Removed.
touchadjustment/resources/inner-navigation-frame.html: Removed.

6:22 PM Changeset in webkit [128676] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Skip image load tests that requires queueReload in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96832

Tests added in reivison 128645.

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

platform/wk2/Skipped:

5:43 PM Changeset in webkit [128675] by dpranke@chromium.org

7 edits in trunk/Tools

nrwt: --additional-platform-dir is broken on chromium ports
https://bugs.webkit.org/show_bug.cgi?id=96840

Reviewed by Ojan Vafai.

Looks like I broke this when cleaning things up as part of
adding ML support. Fixing and adding a test.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.default_baseline_search_path):

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.default_baseline_search_path):

Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.default_baseline_search_path):

Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.init):

Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.setup_environ_for_server):

Scripts/webkitpy/layout_tests/port/port_testcase.py:

(test_check_build):
(test_additional_platform_directory):

5:08 PM Changeset in webkit [128674] by jsbell@chromium.org

7 edits in trunk

IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
https://bugs.webkit.org/show_bug.cgi?id=96807

Reviewed by Tony Chang.

Source/WebCore:

Per spec, if the database connection is closed before the success event fires, the request
should have an error event of type AbortError fired at it.

Test: storage/indexeddb/intversion-close-in-upgradeneeded.html

Modules/indexeddb/IDBDatabase.h:

(WebCore::IDBDatabase::isClosePending): Expose this state so an in-flight success can be morphed.

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::close): Fire the appropriate error at connections that are mid-opening.

Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onSuccess): If the connection was closed before the success is enqueued -
which can happen in multi-process ports with asynchronous messaging - convert the success to an error.

LayoutTests:

Update the test to match the spec behavior.

storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:

(deleteSuccess):
(upgradeNeeded.transaction.oncomplete):
(upgradeNeeded):
(openError):

5:04 PM Changeset in webkit [128673] by rniwa@webkit.org

11 edits in trunk/Source/WebCore

Turn forbidEventDispatch and allowEventDispatch into a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96717

Reviewed by Abhishek Arya.

Replaced forbidEventDispatch and allowEventDispatch by AssertNoEventDispatch.

dom/ContainerNode.cpp:

dom/ContainerNode.h:

(AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::~AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::isEventDispatchForbidden):
(WebCore):

dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):

dom/Document.cpp:

(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

dom/EventTarget.cpp:

(WebCore):
(WebCore::EventTarget::fireEventListeners):

dom/EventTarget.h:

(WebCore):

dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal):

4:41 PM Changeset in webkit [128672] by ojan@chromium.org

2 edits in trunk/LayoutTests

Mark svg/carto.net/selectionlist.svg as flaky because it depends on svg/carto.net/button.svg
running first in order to pass.

platform/chromium/TestExpectations:

4:37 PM Changeset in webkit [128671] by ojan@chromium.org

2 edits in trunk/LayoutTests

The cr-linux-ews thinks http/tests/cache/post-redirect-get.php and http/tests/cache/post-with-cached-subresources.php are MISSING results
https://bugs.webkit.org/show_bug.cgi?id=95215

Reviewed by Adam Barth.

Apparently, marking these as missing did not fix the EWS problem,
so remove them from TestExpectations.

platform/chromium/TestExpectations:

4:33 PM Changeset in webkit [128670] by commit-queue@webkit.org

24 edits in trunk

JSC should throw a more descriptive exception when blocking 'eval' via CSP.
https://bugs.webkit.org/show_bug.cgi?id=94331

Patch by Mike West <mkwst@chromium.org> on 2012-09-14
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Unless explicitly whitelisted, the 'script-src' Content Security Policy
directive blocks 'eval' and 'eval'-like constructs such as
'new Function()'. When 'eval' is encountered in code, an 'EvalError' is
thrown, but the associated message is poor: "Eval is disabled" doesn't
give developers enough information about why their code isn't behaving
as expected.

This patch adds an 'errorMessage' parameter to the JavaScriptCore method
used to disable 'eval'; ContentSecurityPolicy has the opportunity to
pass in a more detailed and descriptive error that contains more context
for the developer.

runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):

Drop the hard-coded "Eval is disabled" error message in favor of
reading the error message off the global object.

runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getCallData):

Drop the hard-coded "Function constructor is disabled" error message
in favor of reading the error message off the global object.

runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::evalEnabled):

Making this accessor method const.

(JSC::JSGlobalObject::evalDisabledErrorMessage):

Accessor for the error message set via 'setEvalDisabled'.

(JSC::JSGlobalObject::setEvalEnabled):

Adding an 'errorMessage' parameter which is stored on the global
object, and used when exceptions are thrown.

Source/WebCore:

The new error message is tested by adjusting existing tests; nothing new
is required.

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):

Read the error message off the document's ContentSecurityPolicy.

(WebCore::ScriptController::disableEval):

bindings/js/ScriptController.h:

(ScriptController):

Pipe the error message through to JSGlobalObject when disabling eval

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

bindings/js/WorkerScriptController.h:

(WorkerScriptController):

Pipe the error message through to JSGlobalObject when disabling eval

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::disableEval):

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

bindings/v8/WorkerScriptController.h:

(WorkerScriptController):

Placeholder for V8 piping to be built in webk.it/94332.

dom/Document.cpp:

(WebCore::Document::disableEval):

dom/Document.h:

(Document):

dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

Pipe the error message through to the ScriptController when
disabling eval.

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::evalDisabledErrorMessage):

Accessor for the error message that ought be displayed to developers
when 'eval' used while disabled for a specific directive list.

(WebCore::CSPDirectiveList::setEvalDisabledErrorMessage):

Mutator for the error message that ought be displayed to developers
when 'eval' used while disabled for a specific directive list.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::create):

Upon creation of a CSPDirectiveList, set the error message if the
directive list disables 'eval'.

(WebCore::ContentSecurityPolicy::didReceiveHeader):

Pass the error message into ScriptExecutionContext::disableEval.

(WebCore::ContentSecurityPolicy::evalDisabledErrorMessage):

Public accessor for the policy's error message; walks the list of
directive lists and returns the first error message found.

(WebCore):

page/ContentSecurityPolicy.h:
workers/WorkerContext.cpp:

(WebCore::WorkerContext::disableEval):

workers/WorkerContext.h:

(WorkerContext):

Pipe the error message through to the ScriptController when
disabling eval.

LayoutTests:

http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt:
http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt:

4:25 PM Changeset in webkit [128669] by commit-queue@webkit.org

13 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-09-14
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context but rather a smaller
object.

No new tests. No change in functionality.

bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::leakHandle):
(ScopedPersistent):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::toIsolatedContextData):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::clearIsolatedShell):
(WebCore):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(IsolatedContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::create):
(WebCore::V8DOMWindowShell::IsolatedContextData::world):
(WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::setSecurityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::securityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::IsolatedContextData):
(WebCore::V8DOMWindowShell::enteredIsolatedContext):
(WebCore::V8DOMWindowShell::enteredIsolatedContextData):

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

4:19 PM Changeset in webkit [128668] by ojan@chromium.org

2 edits in trunk/LayoutTests

Mark compositing/geometry/fixed-position-transform-composited-page-scale.html flaky
as it's flaky on all the Chromium bots.

platform/chromium/TestExpectations:

4:13 PM Changeset in webkit [128667] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

bbc homepage crashes immediately
https://bugs.webkit.org/show_bug.cgi?id=96812
<rdar://problem/12081386>

Reviewed by Oliver Hunt.

If you use the old storage pointer to write to space you thought was newly allocated,
you're going to have a bad time.

runtime/JSArray.cpp:

(JSC::JSArray::unshiftCount):

4:11 PM Changeset in webkit [128666] by Michelangelo De Simone

3 edits
12 adds in trunk

[CSS Shaders] u_textureSize uniform should be set to the size of the texture.
https://bugs.webkit.org/show_bug.cgi?id=95914

Reviewed by Dean Jackson.

Source/WebCore:

This adds support for the following shader uniform variables:

uniform vec2 u_textureSize
uniform vec4 u_meshBox
uniform vec2 u_tileSize
uniform vec2 u_meshSize

The relevant section of the specification is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

Tests: css3/filters/custom/custom-filter-u-mesh-box.html

css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-u-tile-size.html

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::bindProgramAndBuffers):

LayoutTests:

Tests for the following uniform variables:

uniform vec2 u_textureSize
uniform vec4 u_meshBox
uniform vec2 u_tileSize
uniform vec2 u_meshSize

The relevant section of the specification is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

css3/filters/custom/custom-filter-u-mesh-box-expected.html: Added.
css3/filters/custom/custom-filter-u-mesh-box.html: Added.
css3/filters/custom/custom-filter-u-mesh-size-expected.html: Added.
css3/filters/custom/custom-filter-u-mesh-size.html: Added.
css3/filters/custom/custom-filter-u-texture-size-expected.html: Added.
css3/filters/custom/custom-filter-u-texture-size.html: Added.
css3/filters/custom/custom-filter-u-tile-size-expected.html: Added.
css3/filters/custom/custom-filter-u-tile-size.html: Added.
css3/filters/resources/u-mesh-box-is-unit-square.fs: Added.
css3/filters/resources/u-mesh-size.fs: Added.
css3/filters/resources/u-texture-size.fs: Added.
css3/filters/resources/u-tile-size.fs: Added.

4:06 PM Changeset in webkit [128665] by ap@apple.com

2 edits in trunk/LayoutTests

Unreviewed.

A small improvement to this flaky test: use a correct URL, so that the test fails
quickly and understandably instead of timing out. This code path didn't use to be
taken before, so the URL was always wrong.

fast/loader/resources/submit-form-while-parsing-subframe.html:

3:49 PM Changeset in webkit [128664] by Stephanie Lewis

2 edits in trunk/LayoutTests

new fast/loader tests from r128645 fail on Mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=96832.

Unreviewed.

Update TestExpectations

platform/mac-wk2/TestExpectations:

3:49 PM Changeset in webkit [128663] by ojan@chromium.org

11 edits in trunk/Source

Provide a runtime setting to disable position:sticky
https://bugs.webkit.org/show_bug.cgi?id=96827

Reviewed by James Robinson.

Source/WebCore:

Have it be on by default so that only ports that both enable
the define and don't want it on by default need to do something special.

css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):

css/CSSParserMode.h:

(CSSParserContext):

dom/Document.cpp:

(WebCore::Document::cssStickyPositionEnabled):
(WebCore):

dom/Document.h:

(Document):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(Settings):
(WebCore::Settings::setCSSStickyPositionEnabled):
(WebCore::Settings::cssStickyPositionEnabled):

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setCSSStickyPositionEnabled):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

3:48 PM Changeset in webkit [128662] by Stephanie Lewis

2 edits in trunk/Tools

mac-future ignores previous platform TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=96718.

Reviewed by Dirk Pranke.

TestExpectations match an expectation's configuraton against a list of configurations that are
valid for that port. That list does not contain mac-future so none of the expectations can be
applied.

Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

3:47 PM Changeset in webkit [128661] by ojan@chromium.org

2 edits in trunk/LayoutTests

Add expectations for tests that depend on other tests running before them.
Filed a bug for each with information on which test it depends on.

platform/chromium/TestExpectations:

3:26 PM Changeset in webkit [128660] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix builds with CSS_IMAGE_RESOLUTION enabled after r128656.

css/StyleBuilder.cpp:

(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):

3:21 PM Changeset in webkit [128659] by jamesr@google.com

1 edit
1 copy
4 moves
19 adds in trunk/LayoutTests

Unreviewed gardening.

Update fixpos layout test results. Chromium currently doesn't set the fixpos-forms-stacking-context setting in
DumpRenderTree.

fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/025-expected.png.
platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
platform/chromium-linux-x86/fast/block/positioning/016-expected.txt: Added.
platform/chromium-linux-x86/fast/block/positioning/025-expected.txt: Added.
platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
platform/chromium-linux/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/016-expected.png.
platform/chromium-linux/fast/block/positioning/016-expected.txt: Added.
platform/chromium-linux/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/025-expected.png.
platform/chromium-linux/fast/block/positioning/025-expected.txt: Added.
platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
platform/chromium-mac/fast/block/positioning/016-expected.png: Added.
platform/chromium-mac/fast/block/positioning/016-expected.txt: Added.
platform/chromium-mac/fast/block/positioning/025-expected.png: Added.
platform/chromium-mac/fast/block/positioning/025-expected.txt: Added.
platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.

3:04 PM Changeset in webkit [128658] by abarth@webkit.org

40 edits in trunk

Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=96577

Reviewed by Ojan Vafai.

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

webkitPostMessage works the same as postMessage. The spec and the
implementation have been stable for a while. We should no longer be
exposing this vendor-prefixed API.

This patch places the webkitPostMessage API behind an ENABLE flag.
We're going to try removing this API in the Chromium port. If we don't
run into trouble, we'll remove it in all the other ports as well.

This topic has been discussed on webkit-dev in
http://lists.webkit.org/pipermail/webkit-dev/2012-April/020237.html and
http://lists.webkit.org/pipermail/webkit-dev/2012-September/022189.html

This patch introduces the ENABLE(LEGACY_VENDOR_PREFIXES) flag. Rather
than having a flag for each vendor-prefixed API we're experimenting
with removing, we'll add vendor prefixed APIs to this ENABLE when we
want to try removing them. If we succeed, we'll just delete the APIs.
If we fail, we'll remove them from the ENABLE. That way we avoid the
churn of adding and removing many ENABLE macros.

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
GNUmakefile.features.am:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore):

bindings/js/JSDedicatedWorkerContextCustom.cpp:

(WebCore):

bindings/js/JSMessagePortCustom.cpp:

(WebCore):

bindings/js/JSWorkerCustom.cpp:

(WebCore):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore):

bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore):

bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore):

bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore):

dom/MessagePort.idl:
page/DOMWindow.idl:
workers/DedicatedWorkerContext.idl:
workers/Worker.idl:

Source/WebKit/chromium:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

features.gypi:

Source/WebKit/mac:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

Configurations/FeatureDefines.xcconfig:

Tools:

Add ENABLE_LEGACY_VENDOR_PREFIXES flag.

Scripts/webkitperl/FeatureList.pm:
qmake/mkspecs/features/features.pri:

LayoutTests:

Update tests to rely only upon the unprefixed API.

fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:

(wrapSend):
(wrapFailSend):

fast/dom/Window/post-message-crash.html:
fast/dom/Window/window-postmessage-args-expected.txt:
fast/dom/Window/window-postmessage-args.html:
fast/events/message-port.html:
fast/events/resources/message-port-multi.js:
fast/workers/resources/worker-call.js:
fast/workers/worker-call-expected.txt:

2:57 PM Changeset in webkit [128657] by ap@apple.com

2 edits in trunk/Source/WTF

Minimize collisions when hashing pairs
https://bugs.webkit.org/show_bug.cgi?id=96022

Build fix (with newer clang?)

wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from 64 bit to 32 bit.

2:52 PM Changeset in webkit [128656] by Simon Fraser

6 edits
2 adds in trunk

REGRESSION: transition doesn’t always override transition-property
https://bugs.webkit.org/show_bug.cgi?id=96658

Reviewed by Dean Jackson.

Source/WebCore:

Setting the animation property on an Animation in CSSToStyleMap::mapAnimationProperty()
is special because we have to call setAnimationMode(Animation::AnimateAll) as well
as setting the property to CSSPropertyInvalid if it's for the initial state
of the transition-property property.

In order to fix this via StyleBuilder PropertyHandlers, we have to know,
in ApplyPropertyAnimation::applyInitialValue(), which property is getting applied.
This requires passing the CSSPropertyID down through all of the "apply" methods.

Do some unrelated cleanup in CSSParser::parseTransitionShorthand(); the existing code
was not safe with respect to adding new properties to the shorthand.

Test: transitions/longhand-vs-shorthand-initial.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseTransitionShorthand):

css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue): If the property is
CSSPropertyWebkitTransitionProperty, call setAnimationMode(Animation::AnimateAll).
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):

css/StyleBuilder.h:

(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Pass in the property ID.

LayoutTests:

Test with longhand transition-property rule, followed by shorthand
with missing property value. This test should pass, and not assert.

transitions/longhand-vs-shorthand-initial-expected.txt: Added.
transitions/longhand-vs-shorthand-initial.html: Added.

2:43 PM Changeset in webkit [128655] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Support constructor-type attribute in idls other than DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=96821

Patch by Chang Shu <cshu@webkit.org> on 2012-09-14
Reviewed by Kentaro Hara.

In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor
attribute. So for other interfaces, we should pass castedThis->globalObject()
instead of castedThis.

Test: bindings/scripts/test/JS/JSTestObj.idl

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):

2:34 PM Changeset in webkit [128654] by tsepez@chromium.org

5 edits
2 adds in trunk

ImageLoader can't be cleared when video element poster attribute removed.
https://bugs.webkit.org/show_bug.cgi?id=96301

Reviewed by Abhishek Arya.

Source/WebCore:

Same problem as in https://bugs.webkit.org/show_bug.cgi?id=90801. We can't
clear the image loader when the src attribute is cleared, because we might be
inside a handler called on top of an image loader event dispatch. Instead we
will rely on the OwnPtr relationship between the Element and the Image Loader
to limit the lifetime of the loader to that of the element.

Test: fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute):
Remove permature clearing of m_imageLoader.

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseAttribute):
Remove permature clearing of m_imageLoader.

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseAttribute):
Remove permature clearing of m_imageLoader.

LayoutTests:

Added test case.

fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt: Added.
fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html: Added.

2:30 PM Changeset in webkit [128653] by jpfau@apple.com

28 edits
25 adds in trunk

Allow third-party storage blocking setting to change while a page is loaded
https://bugs.webkit.org/show_bug.cgi?id=95790

Reviewed by Brady Eidson.

Update exported symbols.

Source/autotools/symbols.filter:

Source/WebCore:

Pipe through changes to the storage blocking policy to each document and plugin.

Tests: http/tests/security/storage-blocking-loosened-local-storage.html

http/tests/security/storage-blocking-loosened-plugin.html
http/tests/security/storage-blocking-loosened-private-browsing-plugin.html
http/tests/security/storage-blocking-loosened-shared-worker.html
http/tests/security/storage-blocking-loosened-websql.html
http/tests/security/storage-blocking-strengthened-local-storage.html
http/tests/security/storage-blocking-strengthened-plugin.html
http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html
http/tests/security/storage-blocking-strengthened-shared-worker.html
http/tests/security/storage-blocking-strengthened-websql.html

WebCore.exp.in:
dom/Document.cpp: Pipe changes through to the Document's SecurityOrigin.

(WebCore::Document::storageBlockingStateDidChange):
(WebCore):

dom/Document.h:

(Document):

page/DOMWindow.cpp: Check to make sure access is allowed before returning a cached storage area.

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

page/Page.cpp:

(WebCore::Page::collectPluginViews): Refactored out into a function.
(WebCore):
(WebCore::Page::storageBlockingStateChanged): Pipe changes through to each PluginView.
(WebCore::Page::privateBrowsingStateChanged):

page/Page.h:

(Page):

page/Settings.cpp:

(WebCore::Settings::setStorageBlockingPolicy): Tell Pages about changes to the storage blocking policy.
(WebCore):

page/Settings.h:

(Settings):

plugins/PluginViewBase.h:

(WebCore::PluginViewBase::storageBlockingStateChanged):

Source/WebKit2:

Inform plugins about changes to the storage blocking policy by way of the private browsing feature.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::storageBlockingStateChanged):
(WebKit):

PluginProcess/PluginControllerProxy.h:

(PluginControllerProxy):

PluginProcess/PluginControllerProxy.messages.in: Add WK2 message for storageBlockingStateChanged.
WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::storageBlockingStateChanged):
(WebKit):
(WebKit::NetscapePlugin::privateBrowsingStateChanged):
(WebKit::NetscapePlugin::updateNPNPrivateMode): Set plugin's private browsing if either private browsing or storage blocking is enabled.

WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

WebProcess/Plugins/PDF/BuiltInPDFView.h:

(BuiltInPDFView):

WebProcess/Plugins/PDF/BuiltInPDFView.mm: Treat storageBlockingStateChanged as a no-op.

(WebKit::BuiltInPDFView::storageBlockingStateChanged):
(WebKit):

WebProcess/Plugins/Plugin.h: Add pure virtual storageBlockingStateChanged method.

(Plugin):

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::storageBlockingStateChanged):
(WebKit):

WebProcess/Plugins/PluginProxy.h:

(PluginProxy):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::storageBlockingStateChanged):
(WebKit):

WebProcess/Plugins/PluginView.h:

(PluginView):

win/WebKit2.def:

LayoutTests:

Tested combinations of loosening and strengthening the storage blocking policy on various types of storage.

http/tests/security/resources/iframe-for-storage-blocking-changed-local-storage.html: Added.
http/tests/security/resources/iframe-for-storage-blocking-changed-shared-worker.html: Added.
http/tests/security/resources/iframe-for-storage-blocking-changed-websql.html: Added.
http/tests/security/storage-blocking-loosened-local-storage-expected.txt: Added.
http/tests/security/storage-blocking-loosened-local-storage.html: Added.
http/tests/security/storage-blocking-loosened-plugin-expected.txt: Added.
http/tests/security/storage-blocking-loosened-plugin.html: Added.
http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt: Added.
http/tests/security/storage-blocking-loosened-private-browsing-plugin.html: Added.
http/tests/security/storage-blocking-loosened-shared-worker-expected.txt: Added.
http/tests/security/storage-blocking-loosened-shared-worker.html: Added.
http/tests/security/storage-blocking-loosened-websql-expected.txt: Added.
http/tests/security/storage-blocking-loosened-websql.html: Added.
http/tests/security/storage-blocking-strengthened-local-storage-expected.txt: Added.
http/tests/security/storage-blocking-strengthened-local-storage.html: Added.
http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
http/tests/security/storage-blocking-strengthened-plugin.html: Added.
http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.
http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html: Added.
http/tests/security/storage-blocking-strengthened-shared-worker-expected.txt: Added.
http/tests/security/storage-blocking-strengthened-shared-worker.html: Added.
http/tests/security/storage-blocking-strengthened-websql-expected.txt: Added.
http/tests/security/storage-blocking-strengthened-websql.html: Added.
platform/chromium/TestExpectations: Skip shared worker and plugin tests.
platform/mac-wk2/http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
platform/mac-wk2/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.

2:24 PM Changeset in webkit [128652] by Beth Dakin

12 edits
6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=96688
Put position:fixed elements in their own layers and allow them to
create a stacking context
-and corresponding-
<rdar://problem/11467961>

Reviewed by Simon Fraser.

Source/WebKit/mac:

Enable these settings in WK1 too for consistency.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Soon we want pages with fixed positioned elements to be able to be
scrolled by the ScrollingCoordinator. As a part of that work, we have
to composite fixed position elements, and we have to allow those
elements to create a stacking context.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

LayoutTests:

A few test result differences. These first three tests actually
render differently now.

platform/mac/fast/block/positioning/016-expected.png:
platform/mac/fast/block/positioning/016-expected.txt:
platform/mac/fast/block/positioning/025-expected.png:
platform/mac/fast/block/positioning/025-expected.txt:
platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.

These tests just have different layer trees.

platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
platform/mac/compositing/rtl: Added.
platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.

2:09 PM Changeset in webkit [128651] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Prevent workers from calling back into other worlds
https://bugs.webkit.org/show_bug.cgi?id=96790

Patch by Dan Carney <dcarney@google.com> on 2012-09-14
Reviewed by Adam Barth.

Added a few sanity checks to ensure callbacks are always using the correct world.

No new tests. No new change in functionality.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getEventListener):

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):
(WebCore::WorldContextHandle::adjustedContext):

bindings/v8/WorldContextHandle.h:

2:00 PM Changeset in webkit [128650] by danakj@chromium.org

13 edits in trunk/Source

Minimize collisions when hashing pairs
https://bugs.webkit.org/show_bug.cgi?id=96022

Reviewed by Adrienne Walker.

Source/WebCore:

Use WTF::pairIntHash() to hash pairs of integers.

dom/Document.cpp:

(WebCore::ImmutableAttributeDataCacheKey::hash):

dom/StyledElement.cpp:

(WebCore::computePresentationAttributeCacheHash):

platform/graphics/Gradient.cpp:

(WebCore::Gradient::hash):

platform/graphics/IntPointHash.h:

(WTF::IntPointHash::hash):

platform/graphics/IntRectHash.h:
platform/graphics/IntSizeHash.h:
platform/graphics/blackberry/LayerTileIndex.h:
platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::SubimageCacheHash::hash):

Source/WebKit/blackberry:

Use WTF::pairIntHash() to hash a pair of integers.

WebKitSupport/TileIndexHash.h:

Source/WTF:

The current hash function for pairs has poor performance as it does a
nice hash function on 64 bits, but then just drops the top 32 bits. The
hash method for pairs tries to use Thomas Wang's 64 bit Mix Function,
but this requires not dropping any bits in order to retain the
characteristics mentioned by Thomas.

A better method of hashing sets of 32-bit integers is to use
multiplication in 64 bits with random integers. This method is a
provably almost-universal hash function. Testing shows that this
method decreases the time required, when compared with the current
method, by more than 20% due to better hashing characteristics.

wtf/HashFunctions.h:

(WTF):
(WTF::pairIntHash):
Implments the hashing method for a pair of unsigned integers.

(WTF::PairHash::hash):
Use pairIntHash() on the hash results of each object in the pair.

(WTF::IntPairHash::hash):
Implement an integer-specific PairHash class that does not need to
hash each object in the pair. It uses pairIntHash on the two
integers in the pair directly.

(WTF::IntPairHash::equal):
(IntPairHash):

1:51 PM Changeset in webkit [128649] by rniwa@webkit.org

2 edits in trunk/PerformanceTests

Use performance.webkitNow in PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92826

Reviewed by Eric Seidel.

Use performance.webkitNow with Date.now as a fallback for more accurate time measurements.

resources/runner.js:

(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

1:39 PM Changeset in webkit [128648] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

DEPS:

1:18 PM Changeset in webkit [128647] by rwlbuis@webkit.org

5 edits in trunk/Source/WebCore

[BlackBerry] Use StringBuilder more in BlackBerry RSS classes
https://bugs.webkit.org/show_bug.cgi?id=96820

Reviewed by Antonio Gomes.

Use append/appendLiteral where possible.

platform/MIMETypeRegistry.cpp:

(WebCore::mimeTypeAssociationMap):

platform/network/blackberry/rss/RSSAtomParser.cpp:

(WebCore::RSSAtomParser::parseContent):
(WebCore::RSSAtomParser::parseAuthor):

platform/network/blackberry/rss/RSSGenerator.cpp:

(WebCore::RSSGenerator::generateHtml):

platform/network/blackberry/rss/RSSParserBase.cpp:

(WebCore::textFromXMLAttr):
(WebCore::textFromXMLNode):

1:08 PM Changeset in webkit [128646] by Alexandru Chiculita

3 edits in trunk/Source/WebCore

[CSS Shaders] Enable anti-aliasing on the FECustomFilter
https://bugs.webkit.org/show_bug.cgi?id=96668

Reviewed by Dean Jackson.

Added multisample frame buffer for the FECustomFilter. It will try to allocate a multisample framebuffer
with a maximum sample count of 4. At the end it will blit the samples back to the original frame buffer,
so that we can read the pixels back.

This patch uses extensions GL_ANGLE_framebuffer_multisample, GL_ANGLE_framebuffer_blit
and GL_OES_rgb8_rgba8.

No new tests, multisampling is not working in Chromium DRT and has not pixel effect on WebKit Mac.

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore):
(WebCore::FECustomFilter::deleteMultisampleRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore::FECustomFilter::createMultisampleBuffer):
(WebCore::FECustomFilter::resolveMultisampleBuffer):
(WebCore::FECustomFilter::canUseMultisampleBuffers):
(WebCore::FECustomFilter::resizeMultisampleBuffers):
(WebCore::FECustomFilter::resizeContext):

platform/graphics/filters/FECustomFilter.h:

1:04 PM Changeset in webkit [128645] by commit-queue@webkit.org

24 edits
4 adds in trunk

Add in-place reload behavior to ImagesEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=95478

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Export WebCore::Settings::setImagesEnabled symbol.

Source/autotools/symbols.filter:

Source/WebCore:

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Store ImagesEnabled setting in CachedResourceLoader similar to
AutoLoadImages. Move FrameLoaderClient::allowImage to after a
CachedImage has been created and store the cache for reload if it is
blocked.

Make sure when image loads are deferred by either ImagesEnabled or
LoadImagesAutomatically, onload is not called.

Added ImagesEnabled to InternalSettings for layout tests.

Tests: fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html

fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

WebCore.exp.in:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):

loader/cache/CachedImage.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

loader/cache/CachedResource.h:

(WebCore::CachedResource::stillNeedsLoad):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):
(WebCore::CachedResourceLoader::imagesEnabled):

page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

page/Settings.h:

(Settings):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

testing/InternalSettings.h:

(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit2:

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Export WebCore::Settings::setImagesEnabled symbol.

win/WebKit2.def:

LayoutTests:

Add tests to check autoLoadImages and imagesEnabled can block
images and can reload them in place when setting is set to unblock.

image-permissions tests are updated to reflect that onerror will no
longer be called when images are blocked.

Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
platform/chromium/permissionclient/image-permissions-expected.txt:
platform/chromium/permissionclient/image-permissions.html:
platform/chromium/permissionclient/resources/image.html:

1:01 PM Changeset in webkit [128644] by eae@chromium.org

5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=96226
REGRESSION (r128006): Three spatial navigation tests are failing

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix spatial navigation regression by reverting parts of r128006.
Specifically the change to remove the overridden boundingBox
method in ContainerNode.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore):
(WebCore::ContainerNode::getLowerRightCorner):
(WebCore::ContainerNode::boundingBox):

dom/ContainerNode.h:

(ContainerNode):

LayoutTests:

Remove spatial navigation tests from Skipped list.

platform/mac/Skipped:

1:00 PM Changeset in webkit [128643] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[chromium] add touch area to gestureTapDown data
https://bugs.webkit.org/show_bug.cgi?id=96806

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
Reviewed by Adam Barth.

Add width/height for GestureTapDown as for GestureTap/LongPress so that
we can eventually do fuzzing on it.

public/WebInputEvent.h:
src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

12:49 PM Changeset in webkit [128642] by jamesr@google.com

161 edits in trunk

Unreviewed, rolling out r128627.
http://trac.webkit.org/changeset/128627
https://bugs.webkit.org/show_bug.cgi?id=96575

Breaks indexeddb content_browsertests in chromium

Source/WebCore:

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):

Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

LayoutTests:

http/tests/inspector/indexeddb/database-data-expected.txt:
http/tests/inspector/indexeddb/database-structure-expected.txt:
http/tests/inspector/indexeddb/resources-panel-expected.txt:
storage/indexeddb/create-and-remove-object-store-expected.txt:
storage/indexeddb/create-object-store-options-expected.txt:
storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
storage/indexeddb/createObjectStore-null-name-expected.txt:
storage/indexeddb/cursor-added-bug-expected.txt:
storage/indexeddb/cursor-advance-expected.txt:
storage/indexeddb/cursor-continue-dir-expected.txt:
storage/indexeddb/cursor-continue-expected.txt:
storage/indexeddb/cursor-continue-validity-expected.txt:
storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-inconsistency-expected.txt:
storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-key-order-expected.txt:
storage/indexeddb/cursor-overloads-expected.txt:
storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
storage/indexeddb/cursor-primary-key-order-expected.txt:
storage/indexeddb/cursor-reverse-bug-expected.txt:
storage/indexeddb/cursor-skip-deleted-expected.txt:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/cursor-update-value-argument-required-expected.txt:
storage/indexeddb/cursor-value-expected.txt:
storage/indexeddb/data-corruption-expected.txt:
storage/indexeddb/database-basics-expected.txt:
storage/indexeddb/database-close-expected.txt:
storage/indexeddb/database-closepending-flag-expected.txt:
storage/indexeddb/database-deletepending-flag-expected.txt:
storage/indexeddb/delete-closed-database-object-expected.txt:
storage/indexeddb/delete-range-expected.txt:
storage/indexeddb/deleteIndex-expected.txt:
storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
storage/indexeddb/deleteObjectStore-null-name-expected.txt:
storage/indexeddb/deleted-objects-expected.txt:
storage/indexeddb/deletedatabase-transaction-expected.txt:
storage/indexeddb/duplicates-expected.txt:
storage/indexeddb/error-causes-abort-by-default-expected.txt:
storage/indexeddb/exception-in-event-aborts-expected.txt:
storage/indexeddb/exceptions-expected.txt:
storage/indexeddb/factory-deletedatabase-expected.txt:
storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
storage/indexeddb/get-keyrange-expected.txt:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics-workers-expected.txt:
storage/indexeddb/index-count-expected.txt:
storage/indexeddb/index-cursor-expected.txt:
storage/indexeddb/index-duplicate-keypaths-expected.txt:
storage/indexeddb/index-get-key-argument-required-expected.txt:
storage/indexeddb/index-multientry-expected.txt:
storage/indexeddb/index-population-expected.txt:
storage/indexeddb/index-unique-expected.txt:
storage/indexeddb/intversion-and-setversion-expected.txt:
storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
storage/indexeddb/intversion-long-queue-expected.txt:
storage/indexeddb/invalid-keys-expected.txt:
storage/indexeddb/key-generator-expected.txt:
storage/indexeddb/key-sort-order-across-types-expected.txt:
storage/indexeddb/key-sort-order-date-expected.txt:
storage/indexeddb/key-type-array-expected.txt:
storage/indexeddb/key-type-infinity-expected.txt:
storage/indexeddb/keypath-arrays-expected.txt:
storage/indexeddb/keypath-basics-expected.txt:
storage/indexeddb/keypath-edges-expected.txt:
storage/indexeddb/keypath-fetch-key-expected.txt:
storage/indexeddb/keypath-intrinsic-properties-expected.txt:
storage/indexeddb/lazy-index-population-expected.txt:
storage/indexeddb/legacy-constants-expected.txt:
storage/indexeddb/list-ordering-expected.txt:
storage/indexeddb/metadata-expected.txt:
storage/indexeddb/mozilla/add-twice-failure-expected.txt:
storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
storage/indexeddb/mozilla/bad-keypath-expected.txt:
storage/indexeddb/mozilla/clear-expected.txt:
storage/indexeddb/mozilla/create-index-unique-expected.txt:
storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
storage/indexeddb/mozilla/cursors-expected.txt:
storage/indexeddb/mozilla/delete-result-expected.txt:
storage/indexeddb/mozilla/event-source-expected.txt:
storage/indexeddb/mozilla/global-data-expected.txt:
storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
storage/indexeddb/mozilla/indexes-expected.txt:
storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-expected.txt:
storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
storage/indexeddb/mozilla/object-cursors-expected.txt:
storage/indexeddb/mozilla/object-identity-expected.txt:
storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
storage/indexeddb/mozilla/objectstorenames-expected.txt:
storage/indexeddb/mozilla/odd-result-order-expected.txt:
storage/indexeddb/mozilla/put-get-values-expected.txt:
storage/indexeddb/mozilla/readonly-transactions-expected.txt:
storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
storage/indexeddb/mozilla/readyState-expected.txt:
storage/indexeddb/mozilla/remove-index-expected.txt:
storage/indexeddb/mozilla/remove-objectstore-expected.txt:
storage/indexeddb/mozilla/versionchange-abort-expected.txt:
storage/indexeddb/mozilla/versionchange-expected.txt:
storage/indexeddb/mutating-cursor-expected.txt:
storage/indexeddb/noblobs-expected.txt:
storage/indexeddb/objectStore-required-arguments-expected.txt:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics-workers-expected.txt:
storage/indexeddb/objectstore-clear-expected.txt:
storage/indexeddb/objectstore-count-expected.txt:
storage/indexeddb/objectstore-cursor-expected.txt:
storage/indexeddb/objectstore-removeobjectstore-expected.txt:
storage/indexeddb/odd-strings-expected.txt:
storage/indexeddb/open-close-version-expected.txt:
storage/indexeddb/open-cursor-expected.txt:
storage/indexeddb/open-during-transaction-expected.txt:
storage/indexeddb/opencursor-key-expected.txt:
storage/indexeddb/pending-activity-expected.txt:
storage/indexeddb/pending-activity-workers-expected.txt:
storage/indexeddb/pending-version-change-on-exit-expected.txt:
storage/indexeddb/persistence-expected.txt:
storage/indexeddb/prefetch-bugfix-108071-expected.txt:
storage/indexeddb/queued-commands-expected.txt:
storage/indexeddb/readonly-expected.txt:
storage/indexeddb/readonly-properties-expected.txt:
storage/indexeddb/request-continue-abort-expected.txt:
storage/indexeddb/request-event-propagation-expected.txt:
storage/indexeddb/setVersion-null-expected.txt:
storage/indexeddb/set_version_blocked-expected.txt:
storage/indexeddb/set_version_queue-expected.txt:
storage/indexeddb/structured-clone-expected.txt:
storage/indexeddb/three-setversion-calls-expected.txt:
storage/indexeddb/transaction-abort-expected.txt:
storage/indexeddb/transaction-active-flag-expected.txt:
storage/indexeddb/transaction-after-close-expected.txt:
storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
storage/indexeddb/transaction-complete-workers-expected.txt:
storage/indexeddb/transaction-crash-on-abort-expected.txt:
storage/indexeddb/transaction-error-expected.txt:
storage/indexeddb/transaction-event-propagation-expected.txt:
storage/indexeddb/transaction-read-only-expected.txt:
storage/indexeddb/transaction-rollback-expected.txt:
storage/indexeddb/transaction-storeNames-required-expected.txt:
storage/indexeddb/tutorial-expected.txt:
storage/indexeddb/two-version-changes-expected.txt:
storage/indexeddb/value-undefined-expected.txt:
storage/indexeddb/values-odd-types-expected.txt:
storage/indexeddb/version-change-abort-expected.txt:
storage/indexeddb/version-change-exclusive-expected.txt:
storage/indexeddb/versionchangerequest-activedomobject-expected.txt:

12:31 PM Changeset in webkit [128641] by Alexandru Chiculita

4 edits in trunk/Source/WebCore

[CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations
https://bugs.webkit.org/show_bug.cgi?id=96801

Reviewed by Dean Jackson.

I've refactored the FECustomFilter to allow FECustomFilterSkia.cpp to use the rendering part
from outside.

Also removed the Texture class as it is not available on some platforms.

The changes for Skia will land in a different patch:
https://bugs.webkit.org/show_bug.cgi?id=96579

No new tests, the existing custom filters tests should already cover this.

platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore):
(WebCore::FECustomFilter::prepareForDrawing):
(WebCore::FECustomFilter::programNeedsInputTexture):
(WebCore::FECustomFilter::applyShader):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::ensureInputTexture):
(WebCore::FECustomFilter::uploadInputTexture):
(WebCore::FECustomFilter::ensureFrameBuffer):
(WebCore::FECustomFilter::resizeContextIfNeeded):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):

platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

12:22 PM Changeset in webkit [128640] by ojan@chromium.org

2 edits in trunk/LayoutTests

Comment out bug URL. This fixes a lint warning.

platform/qt/Skipped:

12:19 PM Changeset in webkit [128639] by ojan@chromium.org

2 edits
58 adds in trunk/LayoutTests

Update all the MISSING lines in chromium's TestExpectations.
If the test always passed, removed the line. In some cases, they just needed
obvious rebaselines. In others, they haven't reported MISSING in the past
500 runs on the bots, so removed that expectation.

platform/chromium-linux-x86/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
platform/chromium-linux-x86/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
platform/chromium-linux/css3/masking/clip-path-circle-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-polygon-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
platform/chromium-linux/css3/masking/clip-path-rectangle-expected.png: Added.
platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.png: Added.
platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
platform/chromium-linux/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
platform/chromium-mac-snowleopard/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
platform/chromium-mac-snowleopard/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
platform/chromium-mac-snowleopard/fast/overflow/paged-x-with-column-gap-expected.png: Added.
platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-circle-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-polygon-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
platform/chromium-mac/css3/masking/clip-path-rectangle-expected.png: Added.
platform/chromium-mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
platform/chromium-mac/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
platform/chromium-mac/fast/overflow/paged-x-with-column-gap-expected.png: Added.
platform/chromium-win-xp/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
platform/chromium-win-xp/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
platform/chromium-win/css3/masking/clip-path-circle-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-ellipse-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-polygon-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
platform/chromium-win/css3/masking/clip-path-rectangle-expected.png: Added.
platform/chromium-win/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.png: Added.
platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
platform/chromium/TestExpectations:
platform/chromium/perf/nested-combined-selectors-expected.txt: Added.

12:08 PM Changeset in webkit [128638] by ap@apple.com

2 edits in trunk/Tools

[WK2] webarchive/loading/javascript-url-iframe-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=96817

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback got overlooked when adding logging elsewhere.

12:04 PM Changeset in webkit [128637] by ap@apple.com

13 edits in trunk/Source/WebCore

REGRESSION(r126717): It made inspector/styles/media-queries.html fail/flakey
https://bugs.webkit.org/show_bug.cgi?id=95070

Roll out r126717, and another change that depends on it.
r126717: Remove parent pointer from StyleSheetContents and StyleRuleImport
r127123: Cache and share parsed imported stylesheets

css/CSSImportRule.cpp:
css/CSSImportRule.h:
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::willMutateRules): (WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers): (WebCore::CSSStyleSheet::insertRule): (WebCore::CSSStyleSheet::ownerDocument):
css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::clearOwnerRule):
css/StyleRuleImport.cpp: (WebCore::StyleRuleImport::StyleRuleImport): (WebCore::StyleRuleImport::~StyleRuleImport): (WebCore::StyleRuleImport::setCSSStyleSheet): (WebCore::StyleRuleImport::isLoading): (WebCore::StyleRuleImport::requestStyleSheet):
css/StyleRuleImport.h: (WebCore::StyleRuleImport::parentStyleSheet): (WebCore::StyleRuleImport::setParentStyleSheet): (WebCore::StyleRuleImport::clearParentStyleSheet): (ImportedStyleSheetClient): (WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient): (WebCore::StyleRuleImport::ImportedStyleSheetClient::~ImportedStyleSheetClient): (WebCore::StyleRuleImport::ImportedStyleSheetClient::setCSSStyleSheet):
css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::StyleSheetContents): (WebCore::StyleSheetContents::isCacheable): (WebCore::StyleSheetContents::parserAppendRule): (WebCore::StyleSheetContents::clearRules): (WebCore::StyleSheetContents::wrapperInsertRule): (WebCore::StyleSheetContents::wrapperDeleteRule): (WebCore::StyleSheetContents::parseAuthorStyleSheet): (WebCore::StyleSheetContents::parseStringAtLine): (WebCore::StyleSheetContents::checkLoaded): (WebCore::StyleSheetContents::notifyLoadedSheet): (WebCore::StyleSheetContents::startLoadingDynamicSheet): (WebCore::StyleSheetContents::rootStyleSheet): (WebCore::StyleSheetContents::singleOwnerNode): (WebCore::StyleSheetContents::singleOwnerDocument): (WebCore::StyleSheetContents::parentStyleSheet):
css/StyleSheetContents.h: (WebCore::StyleSheetContents::create): (StyleSheetContents): (WebCore::StyleSheetContents::ownerRule): (WebCore::StyleSheetContents::clearOwnerRule):
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::parseStyleSheet):
dom/StyleElement.cpp: (WebCore::StyleElement::createSheet):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

11:53 AM Changeset in webkit [128636] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] RefPtr<Evas_Object> unit tests fails
https://bugs.webkit.org/show_bug.cgi?id=96809

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Added missing return.

UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::canvas):

11:52 AM Changeset in webkit [128635] by ojan@chromium.org

2 edits
3 copies
1 move
1 add in trunk/LayoutTests

Complete forgotten rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=96751.
The results all look like they pass.

platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.

11:48 AM Changeset in webkit [128634] by ojan@chromium.org

4 edits
6 adds
1 delete in trunk/LayoutTests

Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916.
All the differences were anti-aliasing/form-controls.

platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
platform/chromium/TestExpectations:

11:42 AM Changeset in webkit [128633] by ojan@chromium.org

3 edits in trunk/Source/WebCore

Simplify some code in RenderBox::computePercentageLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=96704

Reviewed by Tony Chang.

This is strictly code cleanup. No behavior change.
Also removed some comments that were what comments and/or were
getting stale.

rendering/RenderBox.cpp:

(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
(WebCore):
(WebCore::RenderBox::computePercentageLogicalHeight):

rendering/RenderBox.h:

(RenderBox):

11:26 AM Changeset in webkit [128632] by peter@chromium.org

2 edits in trunk/Tools

[Chromium] Build fix for DumpRenderTree following r128628
https://bugs.webkit.org/show_bug.cgi?id=96808

Reviewed by Tony Chang.

When building DumpRenderTree from the Chromium project, a compile error
shows up because including the header ForwardIOStreamsAndroid.h cannot
be located. TestWebKitAPI does this correctly.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

11:20 AM Changeset in webkit [128631] by danakj@chromium.org

3 edits in trunk/Tools

Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=96805

Reviewed by Dirk Pranke.

Scripts/webkitpy/common/config/committers.py:
Scripts/webkitpy/common/config/watchlist:

10:59 AM Changeset in webkit [128630] by danakj@chromium.org

3 edits
1 add in trunk/Source/Platform

[chromium] Add the ubercomp WebDelegatedRendererLayer
https://bugs.webkit.org/show_bug.cgi?id=94145

Reviewed by Adrienne Walker.

Expose a WebDelegatedRendererLayer to allow the browser compositor to
embed such a layer in its tree. This layer will be connected to IPC
machinery in the compositor that is yet TBD which will give a set of
RenderPasses with DrawQuads to the impl copy of the layer.

Platform.gypi:
chromium/public/WebCompositorSupport.h:

(WebKit):
(WebKit::WebCompositorSupport::createDelegatedRendererLayer):
(WebCompositorSupport):

chromium/public/WebDelegatedRendererLayer.h: Added.

(WebKit):
(WebDelegatedRendererLayer):
(WebKit::WebDelegatedRendererLayer::~WebDelegatedRendererLayer):

10:54 AM Changeset in webkit [128629] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Unreviewed, a workaround for a mysterious crash on Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=96636

testing/InternalSettings.cpp:

Touch RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled only if
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):

testing/InternalSettings.h:

(Backup):

10:37 AM Changeset in webkit [128628] by peter@chromium.org

7 edits
1 copy
1 add in trunk

[Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=96687

Reviewed by Tony Chang.

Android's DumpRenderTree currently supports these arguments, implemented
as part of TestShellAndroid:
http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496

They're used by the layout test runner to get the STDOUT and STDERR while
a layout test run is in process, which is a safer alternative to parsing
all the logcat output manually. The implementation can be seen here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590

This patch generalizes parsing of and applying the effects of these arguments
so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
After this patch, this will make it possible to pull out the output-reading
code from Android's layout test port and generalize it so it can be re-used
in the new test-runner for the other two test suites.

This has no effect when compiling and running these tests as part of Chromium
code, which has a much more advanced test-runner that does parse complete log
output, but also directly depends on code licensed under Apache 2.

Source/WebKit/chromium:

WebKit.gypi:
tests/ForwardIOStreamsAndroid.cpp: Added.

(WebKit):
(WebKit::maybeInitIOStreamForwardingForAndroid):

tests/ForwardIOStreamsAndroid.h: Added.

(WebKit):

tests/RunAllTests.cpp:

(main):

Tools:

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/chromium/TestShellAndroid.cpp:

(platformInit):

TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

10:28 AM Changeset in webkit [128627] by dgrogan@chromium.org

161 edits in trunk

IndexedDB: Print console warning about setVersion
https://bugs.webkit.org/show_bug.cgi?id=96575

Reviewed by Tony Chang.

Source/WebCore:

setVersion has been out of the spec for almost a year but there are
still a lot of users.

We show the warning once per database object as an approximation for
once per page.

No new tests, but 150-something rebaselines.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):

Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

LayoutTests:

http/tests/inspector/indexeddb/database-data-expected.txt:
http/tests/inspector/indexeddb/database-structure-expected.txt:
http/tests/inspector/indexeddb/resources-panel-expected.txt:
storage/indexeddb/create-and-remove-object-store-expected.txt:
storage/indexeddb/create-object-store-options-expected.txt:
storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
storage/indexeddb/createObjectStore-null-name-expected.txt:
storage/indexeddb/cursor-added-bug-expected.txt:
storage/indexeddb/cursor-advance-expected.txt:
storage/indexeddb/cursor-continue-dir-expected.txt:
storage/indexeddb/cursor-continue-expected.txt:
storage/indexeddb/cursor-continue-validity-expected.txt:
storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-inconsistency-expected.txt:
storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-key-order-expected.txt:
storage/indexeddb/cursor-overloads-expected.txt:
storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
storage/indexeddb/cursor-primary-key-order-expected.txt:
storage/indexeddb/cursor-reverse-bug-expected.txt:
storage/indexeddb/cursor-skip-deleted-expected.txt:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/cursor-update-value-argument-required-expected.txt:
storage/indexeddb/cursor-value-expected.txt:
storage/indexeddb/data-corruption-expected.txt:
storage/indexeddb/database-basics-expected.txt:
storage/indexeddb/database-close-expected.txt:
storage/indexeddb/database-closepending-flag-expected.txt:
storage/indexeddb/database-deletepending-flag-expected.txt:
storage/indexeddb/delete-closed-database-object-expected.txt:
storage/indexeddb/delete-range-expected.txt:
storage/indexeddb/deleteIndex-expected.txt:
storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
storage/indexeddb/deleteObjectStore-null-name-expected.txt:
storage/indexeddb/deleted-objects-expected.txt:
storage/indexeddb/deletedatabase-transaction-expected.txt:
storage/indexeddb/duplicates-expected.txt:
storage/indexeddb/error-causes-abort-by-default-expected.txt:
storage/indexeddb/exception-in-event-aborts-expected.txt:
storage/indexeddb/exceptions-expected.txt:
storage/indexeddb/factory-deletedatabase-expected.txt:
storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
storage/indexeddb/get-keyrange-expected.txt:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics-workers-expected.txt:
storage/indexeddb/index-count-expected.txt:
storage/indexeddb/index-cursor-expected.txt:
storage/indexeddb/index-duplicate-keypaths-expected.txt:
storage/indexeddb/index-get-key-argument-required-expected.txt:
storage/indexeddb/index-multientry-expected.txt:
storage/indexeddb/index-population-expected.txt:
storage/indexeddb/index-unique-expected.txt:
storage/indexeddb/intversion-and-setversion-expected.txt:
storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
storage/indexeddb/intversion-long-queue-expected.txt:
storage/indexeddb/invalid-keys-expected.txt:
storage/indexeddb/key-generator-expected.txt:
storage/indexeddb/key-sort-order-across-types-expected.txt:
storage/indexeddb/key-sort-order-date-expected.txt:
storage/indexeddb/key-type-array-expected.txt:
storage/indexeddb/key-type-infinity-expected.txt:
storage/indexeddb/keypath-arrays-expected.txt:
storage/indexeddb/keypath-basics-expected.txt:
storage/indexeddb/keypath-edges-expected.txt:
storage/indexeddb/keypath-fetch-key-expected.txt:
storage/indexeddb/keypath-intrinsic-properties-expected.txt:
storage/indexeddb/lazy-index-population-expected.txt:
storage/indexeddb/legacy-constants-expected.txt:
storage/indexeddb/list-ordering-expected.txt:
storage/indexeddb/metadata-expected.txt:
storage/indexeddb/mozilla/add-twice-failure-expected.txt:
storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
storage/indexeddb/mozilla/bad-keypath-expected.txt:
storage/indexeddb/mozilla/clear-expected.txt:
storage/indexeddb/mozilla/create-index-unique-expected.txt:
storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
storage/indexeddb/mozilla/cursors-expected.txt:
storage/indexeddb/mozilla/delete-result-expected.txt:
storage/indexeddb/mozilla/event-source-expected.txt:
storage/indexeddb/mozilla/global-data-expected.txt:
storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
storage/indexeddb/mozilla/indexes-expected.txt:
storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-expected.txt:
storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
storage/indexeddb/mozilla/object-cursors-expected.txt:
storage/indexeddb/mozilla/object-identity-expected.txt:
storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
storage/indexeddb/mozilla/objectstorenames-expected.txt:
storage/indexeddb/mozilla/odd-result-order-expected.txt:
storage/indexeddb/mozilla/put-get-values-expected.txt:
storage/indexeddb/mozilla/readonly-transactions-expected.txt:
storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
storage/indexeddb/mozilla/readyState-expected.txt:
storage/indexeddb/mozilla/remove-index-expected.txt:
storage/indexeddb/mozilla/remove-objectstore-expected.txt:
storage/indexeddb/mozilla/versionchange-abort-expected.txt:
storage/indexeddb/mozilla/versionchange-expected.txt:
storage/indexeddb/mutating-cursor-expected.txt:
storage/indexeddb/noblobs-expected.txt:
storage/indexeddb/objectStore-required-arguments-expected.txt:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics-workers-expected.txt:
storage/indexeddb/objectstore-clear-expected.txt:
storage/indexeddb/objectstore-count-expected.txt:
storage/indexeddb/objectstore-cursor-expected.txt:
storage/indexeddb/objectstore-removeobjectstore-expected.txt:
storage/indexeddb/odd-strings-expected.txt:
storage/indexeddb/open-close-version-expected.txt:
storage/indexeddb/open-cursor-expected.txt:
storage/indexeddb/open-during-transaction-expected.txt:
storage/indexeddb/opencursor-key-expected.txt:
storage/indexeddb/pending-activity-expected.txt:
storage/indexeddb/pending-activity-workers-expected.txt:
storage/indexeddb/pending-version-change-on-exit-expected.txt:
storage/indexeddb/persistence-expected.txt:
storage/indexeddb/prefetch-bugfix-108071-expected.txt:
storage/indexeddb/queued-commands-expected.txt:
storage/indexeddb/readonly-expected.txt:
storage/indexeddb/readonly-properties-expected.txt:
storage/indexeddb/request-continue-abort-expected.txt:
storage/indexeddb/request-event-propagation-expected.txt:
storage/indexeddb/setVersion-null-expected.txt:
storage/indexeddb/set_version_blocked-expected.txt:
storage/indexeddb/set_version_queue-expected.txt:
storage/indexeddb/structured-clone-expected.txt:
storage/indexeddb/three-setversion-calls-expected.txt:
storage/indexeddb/transaction-abort-expected.txt:
storage/indexeddb/transaction-active-flag-expected.txt:
storage/indexeddb/transaction-after-close-expected.txt:
storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
storage/indexeddb/transaction-complete-workers-expected.txt:
storage/indexeddb/transaction-crash-on-abort-expected.txt:
storage/indexeddb/transaction-error-expected.txt:
storage/indexeddb/transaction-event-propagation-expected.txt:
storage/indexeddb/transaction-read-only-expected.txt:
storage/indexeddb/transaction-rollback-expected.txt:
storage/indexeddb/transaction-storeNames-required-expected.txt:
storage/indexeddb/tutorial-expected.txt:
storage/indexeddb/two-version-changes-expected.txt:
storage/indexeddb/value-undefined-expected.txt:
storage/indexeddb/values-odd-types-expected.txt:
storage/indexeddb/version-change-abort-expected.txt:
storage/indexeddb/version-change-exclusive-expected.txt:
storage/indexeddb/versionchangerequest-activedomobject-expected.txt:

10:17 AM Changeset in webkit [128626] by Michelangelo De Simone

18 edits
1 copy
3 adds in trunk

Use arrays in shaders
https://bugs.webkit.org/show_bug.cgi?id=95223

Reviewed by Dean Jackson.

Source/WebCore:

Custom Filters' support for array() is introduced. Values within
the array() function will be passed as uniforms to shaders.

Values within array() are comma-separated; the specification will be
updated accordingly: https://www.w3.org/Bugs/Public/show_bug.cgi?id=18839

Test: css3/filters/custom/custom-filter-array.html

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForCustomFilterArrayParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

css/StyleResolver.h:

(StyleResolver):

platform/graphics/filters/CustomFilterArrayParameter.h: Container for array()

parameter values.
(WebCore):
(CustomFilterArrayParameter):
(WebCore::CustomFilterArrayParameter::create):
(WebCore::CustomFilterArrayParameter::size):
(WebCore::CustomFilterArrayParameter::valueAt):
(WebCore::CustomFilterArrayParameter::addValue):
(WebCore::CustomFilterArrayParameter::blend):
(WebCore::CustomFilterArrayParameter::operator==):
(WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):

platform/graphics/filters/CustomFilterParameter.h:
platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::bindProgramArrayParameters):
(WebCore):
(WebCore::FECustomFilter::bindProgramParameters):

platform/graphics/filters/FECustomFilter.h:

(WebCore):
(FECustomFilter):

LayoutTests:

New tests have been added for checking the correctness of array()
within shaders.

css3/filters/custom/custom-filter-array-expected.html: Added.
css3/filters/custom/custom-filter-array.html: Added.
css3/filters/custom/custom-filter-property-computed-style-expected.txt:
css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
css3/filters/resources/fragment-color.fs: Added.
css3/filters/script-tests/custom-filter-property-computed-style.js:
css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:

10:09 AM Changeset in webkit [128625] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

Always send mouse events on pages that don't scroll even if there
is no mouse move listener attatched.
PR #208228
https://bugs.webkit.org/show_bug.cgi?id=96800

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-14
Reviewed by Antonio Gomes.

Reviewed Internally By Antonio Gomes.

WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

10:05 AM Changeset in webkit [128624] by zoltan@webkit.org

3 edits in trunk/Tools

check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
https://bugs.webkit.org/show_bug.cgi?id=96656

Reviewed by Adam Barth.

We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
macros in 1 line.

Scripts/webkitpy/style/checkers/cpp.py:

(check_style.definitions):
(check_style): Add rule.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_line_breaking): Add unittest.

9:59 AM Changeset in webkit [128623] by commit-queue@webkit.org

16 edits in trunk

WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
https://bugs.webkit.org/show_bug.cgi?id=57570

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add new didExceedDatabaseQuota callback to WKBundlePageUIClient
and call it from WebChromeClient::exceededDatabaseQuota().
This is needed by WebKitTestRunner to dump information about
database callbacks.

Shared/APIClientTraits.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setDatabaseQuota): Call WebDatabaseManager::setQuotaForOrigin()
with "file0" instead of "file:///" as origin identifier. WebDatabaseManager expects
a database identifier, not a string representation of the security origin. "file0" is
the string that is used as databaseIdentifier of local files. This bug was causing the
database quota not to be set. The test cases would therefore fail due to the quota being
0 instead of the value explicitly set.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
(WebKit):

WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

Tools:

Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
and dump the information expected by the test cases.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting): Explicitly set the default
database quota.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::securityOriginToStr): New convenience function to convert
a security origin to the string expected in test results.
(WTR):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didExceedDatabaseQuota):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
refactoring to share code with didExceedDatabaseQuota.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpDatabaseCallbacks):
(WTR::TestRunner::shouldDumpDatabaseCallbacks):
(TestRunner):

LayoutTests:

Unskip several test cases which require implementation of
testRunner.dumpDatabaseCallbacks in WebKitTestRunner.

platform/wk2/Skipped:

9:58 AM Changeset in webkit [128622] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update the minimum zoom scale when focusing an input field.
https://bugs.webkit.org/show_bug.cgi?id=96789

Reviewed by Antonio Gomes.

PR 188751.

Increase the minimum font fix and base it on mm instead of pixels.

Reviewed Internally by Gen Mak.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

9:55 AM Changeset in webkit [128621] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=96795

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14

platform/efl-wk2/TestExpectations:

9:30 AM Changeset in webkit [128620] by sergio@webkit.org

2 edits in trunk/LayoutTests

[GTK] [WK2] Unreviewed gardening.

Added a bunch of tests failing in the WK2 tests bot to the Skipped
list with the proper links to each bug.

platform/gtk-wk2/Skipped:

9:27 AM Changeset in webkit [128619] by vestbo@webkit.org

2 edits in trunk/Tools

[Qt] Set force_static_libs_as_shared early enough to be caught by configure

Rubber-stamped by Simon Hausmann.

9:21 AM Changeset in webkit [128618] by vestbo@webkit.org

6 edits in trunk

[Qt] Remove old cruft from the qmake build system

Rubber-stamped by Simon Hausmann.

8:58 AM Changeset in webkit [128617] by vestbo@webkit.org

2 edits in trunk/Tools

[Qt] Enable force_static_libs_as_shared for development

Not enabled for buildbots or production-builds (part of Qt5)

Reviewed by Simon Hausmann.

8:58 AM Changeset in webkit [128616] by vestbo@webkit.org

11 edits in trunk

[Qt] Make force_static_libs_as_shared work on Mac OS

We had to move a few LIBS += around that were in the wrong place,
and not caught when everything was just linked into the final
QtWebKit library.

Reviewed by Simon Hausmann.

8:55 AM Changeset in webkit [128615] by commit-queue@webkit.org

3 edits
2 adds in trunk

Gesture events sent to wrong node when page is scrolled
https://bugs.webkit.org/show_bug.cgi?id=96788

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
Reviewed by Antonio Gomes.

Source/WebCore:

Adjust the co-ordinate space correctly when doing hit testing for
gesture events (as for all other event handling code here).

Test: platform/chromium/plugins/gesture-events-scrolled.html

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

Add layout test based on gesture-events.html which tests the case when
the document is scrolled (so that client co-ordinates don't equal page
co-ordinates).

platform/chromium/plugins/gesture-events-scrolled-expected.txt: Added.
platform/chromium/plugins/gesture-events-scrolled.html: Added.

8:47 AM Changeset in webkit [128614] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Fix handling of debug/release/debug_and_release/build_all

We now pick up the defaults from Qt, in default_pre (CONFIG already
contains the appropriate values for debug and release). We then let
the command line arguments to qmake, or the project files themselves,
override the configuration, and finally we sanitize the configuration
in default_post.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-09-14
Reviewed by Simon Hausmann.

Source/api.pri:

8:38 AM Changeset in webkit [128613] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL][WK2] Unskip test cases that are now passing
https://bugs.webkit.org/show_bug.cgi?id=96762

Unreviewed EFL gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

8:18 AM Changeset in webkit [128612] by commit-queue@webkit.org

12 edits in trunk

WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
https://bugs.webkit.org/show_bug.cgi?id=42691

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add WKBundleFrame private API to stop loading of a frame.
This is needed by WebKitTestRunner to implement
testrunner.setStopProvisionalFrameLoads.

Original patch by Alexey Proskuryakov.

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameStopLoading):

WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::stopLoading):
(WebKit):

WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

Add implementation for testrunner.setStopProvisionalFrameLoads()
in WebKitTestRunner.

Original patch by Alexey Proskuryakov.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):
(WTR::TestRunner::setStopProvisionalFrameLoads):
(WTR::TestRunner::shouldStopProvisionalFrameLoads):

LayoutTests:

Unskip fast/loader/stop-provisional-loads.html now that WebKitTestRunner
implements testrunner.setStopProvisionalFrameLoads().

platform/wk2/Skipped:

7:55 AM Changeset in webkit [128611] by Simon Hausmann

2 edits in trunk/Source/JavaScriptCore

Fix interpreter build
https://bugs.webkit.org/show_bug.cgi?id=96617

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-09-14
Reviewed by Simon Hausmann.

Make compile.

interpreter/Interpreter.cpp:

7:30 AM Changeset in webkit [128610] by kenneth@webkit.org

3 edits
1 add in trunk/Source/WebKit2

[EFL] Add unit test for RefPtr<Evas_Object>
https://bugs.webkit.org/show_bug.cgi?id=96776

Reviewed by Simon Hausmann.

Basic testing of the new EFL specific RefPtr type.

PlatformEfl.cmake:
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::backingStore):
(EWK2UnitTest::EWK2UnitTestBase::canvas):

Add some new accessors for Ecore_Evas and Evas*.

UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp: Added.

(TEST_F):

7:08 AM Changeset in webkit [128609] by loislo@chromium.org

7 edits in trunk/Source/WTF

Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.
https://bugs.webkit.org/show_bug.cgi?id=96759

Reviewed by Yury Semikhatsky.

Now when MemoryInstrumentation.h is a part of WTF we can move reportMemoryUsage functions to cpp file.

wtf/text/AtomicString.cpp:

(WTF::AtomicString::reportMemoryUsage):
(WTF):

wtf/text/AtomicString.h:

(WTF):
(AtomicString):

wtf/text/StringImpl.cpp:

(WTF::StringImpl::reportMemoryUsage):
(WTF):

wtf/text/StringImpl.h:

(WTF):
(StringImpl):

wtf/text/WTFString.cpp:

(WTF::String::reportMemoryUsage):
(WTF):

wtf/text/WTFString.h:

(WTF):
(String):

7:02 AM Changeset in webkit [128608] by vestbo@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Move .mm file to OBJECTIVE_SOURCES

Reviewed by Simon Hausmann.

Target.pri:

7:01 AM Changeset in webkit [128607] by commit-queue@webkit.org

3 edits
2 adds in trunk

[EFL] Attempt to create a theme for 0 sized element leads to assertion hit
https://bugs.webkit.org/show_bug.cgi?id=96743

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

Test: fast/forms/range/slider-zero-size-crash.html

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):

LayoutTests:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

fast/forms/range/slider-zero-size-crash-expected.txt: Added.
fast/forms/range/slider-zero-size-crash.html: Added.

6:41 AM Changeset in webkit [128606] by vestbo@webkit.org

8 edits in trunk

[Qt] Fix handling of debug/release/debug_and_release/build_all

Reviewed by Simon Hausmann.

6:37 AM Changeset in webkit [128605] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=96646

Unreviewed EFL gardening of flaky tests on wk1.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14

platform/efl-wk1/TestExpectations:

6:27 AM Changeset in webkit [128604] by commit-queue@webkit.org

14 edits in trunk

WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
https://bugs.webkit.org/show_bug.cgi?id=42687

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Implement testRunner.setTabKeyCyclesThroughElements for
WebKitTestRunner.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetTabKeyCyclesThroughElements):

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setTabKeyCyclesThroughElements):
(WebKit):

WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Implement testRunner.setTabKeyCyclesThroughElements for
WebKitTestRunner.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setTabKeyCyclesThroughElements):
(WTR):

WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

fast/events/keypress-insert-tab.html is passing now on wk2. So, unskip
in common skipped files and re-skip it on efl-wk1 until WK82864 is fixed.

platform/efl-wk1/TestExpectations:
platform/efl/Skipped:
platform/wk2/Skipped:

6:27 AM Changeset in webkit [128603] by tonikitoo@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove the ability to schedule a zoom about point call.
https://bugs.webkit.org/show_bug.cgi?id=96696

[FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (Part I)
PR #180866

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Internally reviewed by Jacky Hajiang and Arvid Nilsson.

Patch replaces the async call to zoomAboutPoint (via scheduling it with a one-shot-0-timer).
Instead, at its single call site, we inline most of the previous scheduleZoomAboutPoint code,
and in the end call zoomAboutPoint directly.

Change was estimulated by Arvid's comment on PRzilla: "There is no longer any reason to have
"zoom about point" be async.. That was a hack I did for BB6, back when we were doing everything
on the WK read and needed manual time slicing betwren rendering and user interaction."

The bigger goal though is to be able to remove screen glitches while entering/leaving
fullscreen mode: since we could accurately use the count-based suspend/resume backing
store mechanism to prevent it.

Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

Api/WebPage_p.h:

(WebPagePrivate):

6:19 AM Changeset in webkit [128602] by commit-queue@webkit.org

5 edits in trunk

EventSendingController::keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=96727

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Add support for handling a string as modifier argument to
EventSendingController::keyDown.

WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::parseModifierArray):

LayoutTests:

Unskip passing test fast/forms/legend-access-key.html

platform/efl-wk2/TestExpectations:
platform/gtk-wk2/Skipped:

6:10 AM Changeset in webkit [128601] by vsevik@chromium.org

1 edit
1 move in trunk/LayoutTests

Unreviewed skipping failing test.

http/tests/inspector/network/network-xhr-replay.html_disabled: Renamed from LayoutTests/http/tests/inspector/network/network-xhr-replay.html.

6:09 AM Changeset in webkit [128600] by commit-queue@webkit.org

5 edits in trunk

WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=42546

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Exported TestRunner::setCustomPolicyDelegate() method.
Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

LayoutTests:

Unskipped corresponding test cases. Distributed those which still not passing to appropriate groups in Skipped file.

platform/wk2/Skipped:

6:08 AM Changeset in webkit [128599] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of
webkit in order to include libraries of slog2
https://bugs.webkit.org/show_bug.cgi?id=96391

Patch by Parth Patel <parpatel@rim.com> on 2012-09-14
Reviewed by Yong Li.

Changes in Cmake files of JavaScriptCore of webkit to include slog2 libs in build
files of webkit in response to switching from Slogger to Slogger2.

shell/PlatformBlackBerry.cmake:

6:07 AM Changeset in webkit [128598] by caseq@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=96755

Reviewed by Alexander Pavlov.

remove AuditProgressMonitor, use WebInspector.ProgressIndicator instead;
add annotations for a bunch of audit methods;
simplify control flow -- remove callbacks where possible.

English.lproj/localizedStrings.js:
inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked.onAuditStarted):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):

inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun.sheetsCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet.sheetCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):

inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype.initiateAudit.else.onReload):
(WebInspector.AuditsPanel.prototype.initiateAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):

inspector/front-end/ProgressBar.js:

(WebInspector.Progress.prototype.worked):
(WebInspector.ProgressIndicator):
(WebInspector.ProgressIndicator.prototype.cancel):
(WebInspector.ProgressIndicator.prototype.setWorked):
(WebInspector.ProgressIndicator.prototype.worked):
(WebInspector.SubProgress.prototype.setWorked):
(WebInspector.SubProgress.prototype.worked):

inspector/front-end/auditsPanel.css:

(.audit-launcher-view .progress-bar-container):
(.audit-launcher-view .progress-bar-container .progress-bar-stop-button):

5:45 AM Changeset in webkit [128597] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed inspector ui polish.

inspector/front-end/inspector.css:

(#floating-status-bar-resizer):

5:43 AM Changeset in webkit [128596] by zandobersek@gmail.com

7 edits in trunk

[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::clearApplicationCache):

WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Call the new DumpRenderTreeSupportGtk method to clear application cache
after each test in DumpRenderTree.

Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
as well. It's now being set in XvfbDriver._start so that each driver is assigned
a cache directory that's constructed out of the driver's name and its worker
number. These directories are located in the layout tests results directory.
At least on the builders this ensures a driver-specific empty cache directory
with each test run.

DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

5:42 AM Changeset in webkit [128595] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Get rid of setting values to innerHTML in inspector front-end.
https://bugs.webkit.org/show_bug.cgi?id=96758

Reviewed by Alexander Pavlov.

Removed innerHTML from WebGLProfileView.

inspector/front-end/WebGLProfileView.js:

(WebInspector.WebGLProfileView.prototype._showTraceLog):

5:40 AM Changeset in webkit [128594] by tkent@chromium.org

10 edits
2 adds in trunk

Make time input lang attribute aware for testing
https://bugs.webkit.org/show_bug.cgi?id=96728

Patch by Keishi Hattori <keishi@webkit.org> on 2012-09-14
Reviewed by Kent Tamura.

Source/WebCore:

This patch implements partial lang attribute support for input type=time
that turns on only when enabled through InternalSettings.

Test: fast/forms/time-multiple-fields/time-multiple-fields-localization.html

dom/Document.cpp:

(WebCore::Document::getLocalizer): Returns a localizer for a given locale. Localizers are cached for repeated use.
(WebCore):

dom/Document.h:

(WebCore):
(Document):

html/TimeInputType.cpp:

(WebCore::TimeInputType::updateInnerTextValue): Use the locale for the input element.

html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditElement::layout):
(WebCore::DateTimeEditElement::setValueAsDate):
(WebCore::DateTimeEditElement::setEmptyValue):

html/shadow/DateTimeEditElement.h:

(WebCore):
(DateTimeEditElement):

Source/WebKit/chromium:

tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::localizedDateFormatText):
(LocalizedDateICUTest::localizedShortDateFormatText):

LayoutTests:

fast/forms/resources/common.js:

(getUserAgentShadowTextContent): Used to get the text inside an input element.

fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Added.
platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Added.
platform/chromium/TestExpectations:

5:34 AM Changeset in webkit [128593] by tkent@chromium.org

13 edits in trunk/Source/WebCore

Unreviewed, rolling out r128566.
http://trac.webkit.org/changeset/128566
https://bugs.webkit.org/show_bug.cgi?id=96760

Assertion failure in http/tests/websocket/tests/hybi/workers
/close-code-and-reason.html (Requested by tkent1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

bindings/v8/ScopedPersistent.h:
bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

bindings/v8/V8DOMWindowShell.cpp:

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

5:19 AM Changeset in webkit [128592] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Fix front end closure compilation errors.
https://bugs.webkit.org/show_bug.cgi?id=96753

Reviewed by Alexander Pavlov.

Closure compilation fix.
Also fixed wrong parameters passed to JavaScriptSource constructor from CompilerScriptMapping.

inspector/front-end/CompilerScriptMapping.js:
inspector/front-end/Resource.js:

5:06 AM Changeset in webkit [128591] by yosin@chromium.org

3 edits in trunk/LayoutTests

REGRESSION(r128575): fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html is failed on Chromium-Win
https://bugs.webkit.org/show_bug.cgi?id=96754

Reviewed by Kent Tamura.

The root cause of this failure is Chromium-Win port has a second field
event if step=60 due by Windows platform API.

This patch changes test sample to have a second field to get rid of
such difference.

fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updates expectation.
fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to add "step=1" to

test sample and to add a second field value to expectation.

5:05 AM Changeset in webkit [128590] by commit-queue@webkit.org

8 edits
3 adds in trunk/Source/WebCore

Web Inspector: Display Named Flows in the "CSS Named Flows" drawer
https://bugs.webkit.org/show_bug.cgi?id=90871

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-14
Reviewed by Alexander Pavlov.

Implemented CSS Regions support in WebInspector as a drawer. (feature is under an experimental flag)

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/CSSNamedFlowCollectionsView.js: Added.

(WebInspector.CSSNamedFlowCollectionsView):
(WebInspector.CSSNamedFlowCollectionsView.prototype.showInDrawer):
(WebInspector.CSSNamedFlowCollectionsView.prototype.reset):
(WebInspector.CSSNamedFlowCollectionsView.prototype._setDocument):
(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._setSidebarHasContent):
(WebInspector.CSSNamedFlowCollectionsView.prototype._appendNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._removeNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._updateNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._resetNamedFlows):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowRemoved):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._hashNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._showNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectNamedFlowInSidebar):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
(WebInspector.CSSNamedFlowCollectionsView.prototype._showNamedFlowForNode):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
(WebInspector.ElementsPanel.prototype._showNamedFlowCollections):

inspector/front-end/Images/namedFlowOverflow.png: Added.
inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/WebKit.qrc:
inspector/front-end/cssNamedFlows.css: Added.

(.css-named-flow-collections-view .split-view-sidebar-left):
(.css-named-flow-collections-view .tabbed-pane-header):
(.css-named-flow-collections-view .info):
(.css-named-flow-collections-view .split-view-sidebar-left .sidebar-content):
(.css-named-flow-collections-view .split-view-sidebar-left .selection):
(.css-named-flow-collections-view .split-view-contents .title):
(.css-named-flow-collections-view .split-view-sidebar-left .named-flow-overflow::before):

4:57 AM Changeset in webkit [128589] by yosin@chromium.org

3 edits in trunk/Source/WebCore

Unreviewed fix for build break on Chromium-Linux Debug build.

html/DateTimeFieldsState.cpp: Initialize DateTimeFieldStates::emptyValue.
html/DateTimeFieldsState.h: Remove initialization of public static member variable emptyValue.

4:49 AM Changeset in webkit [128588] by tkent@chromium.org

5 edits
1 add in trunk/Source/WebCore

Create Localizer factory method for LocaleNone
https://bugs.webkit.org/show_bug.cgi?id=96745

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-09-14
Reviewed by Kent Tamura.

This patch introduces Localizer class and LocaleNone class which
prodices a constructor of Localizer class for ports which don't use
LocaleICU, LocaleMac nor LocaleWin.

No new tests. This patch doesn't change behavior.

CMakeLists.txt: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp.
GNUmakefile.list.am: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
Target.pri: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp
WebCore.vcproj/WebCore.vcproj: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
platform/text/LocaleNone.cpp: Added.

(WebCore::Localizer::create):
(WebCore::LocaleNone::~LocaleNone):
(WebCore::LocaleNone::initializeLocalizerData):

4:42 AM Changeset in webkit [128587] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Fix linking on Windows

Reviewed by Tor Arne Vestbø.

When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
the QtWebKit.dll creation in the build process and be off afterwards. This is done in
win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.

r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
after the module. Therefore QT did never contain webkit anymore and we always passed
QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.

This patch introduces a creating_module configuration that is used to
scope the qt/pkgconfig sanitization.

qmake/mkspecs/features/default_post.prf:

4:24 AM Changeset in webkit [128586] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed r128580 follow up: fixed qt minimal compilation.

loader/DocumentThreadableLoader.cpp:

4:22 AM Changeset in webkit [128585] by commit-queue@webkit.org

4 edits in trunk

[WK2][WKTR] TestRunner is not dumping some frame load callbacks information
https://bugs.webkit.org/show_bug.cgi?id=96740

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Dump information expected by the test cases about the following
frame load callbacks:
"didDisplayInsecureContentForFrame"
"didRunInsecureContentForFrame"
"didDetectXSSForFrame"

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
as expected by test results by calling pathSuitableForTestResult() instead
of printing raw URL.
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::didDetectXSSForFrame):

LayoutTests:

Unskip test cases which were failing due to missing
frame load callbacks information dumping with
WebKitTestRunner.

platform/wk2/Skipped:

4:17 AM Changeset in webkit [128584] by keishi@webkit.org

16 edits in trunk/Source

Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods
https://bugs.webkit.org/show_bug.cgi?id=96726

Reviewed by Kent Tamura.

Source/WebCore:

Refactoring time format related methods on LocaleWin/Mac/ICU so that
they override Localizer methods. We can call them from the Localizer
from now on.

No new tests. No behavior change. Covered by existing tests.

platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeDateTimeFormat): m_timeAMPMLabels is no longer a OwnPtr so we account for that.
(WebCore::LocaleICU::timeFormat): Removing Text from end of function
name because *FormatText() shoud return human readable text like "Day/Month/Year".
(WebCore::LocaleICU::shortTimeFormat):
(WebCore::LocaleICU::timeAMPMLabels):

platform/text/LocaleICU.h:

(LocaleICU):

platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::timeFormat):
(WebCore::LocaleWin::shortTimeFormat):
(WebCore::LocaleWin::timeAMPMLabels):

platform/text/LocaleWin.h:

(LocaleWin):

platform/text/LocalizedDateICU.cpp:

(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):

platform/text/LocalizedDateWin.cpp:

(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):

platform/text/Localizer.cpp:

(WebCore):
(WebCore::Localizer::timeFormat):
(WebCore::Localizer::shortTimeFormat):
(WebCore::Localizer::timeAMPMLabels):

platform/text/Localizer.h:

(Localizer): We unified some of the member variables like m_timeAMPMLabels into this class.

platform/text/mac/LocaleMac.h:

(LocaleMac):

platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::timeFormat):
(WebCore::LocaleMac::shortTimeFormat):

platform/text/mac/LocalizedDateMac.cpp:

(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):

Source/WebKit/chromium:

tests/LocaleMacTest.cpp:

(LocaleMacTest::timeFormat):
(LocaleMacTest::shortTimeFormat):
(TEST_F):

tests/LocaleWinTest.cpp:

(LocaleWinTest::timeFormat):
(LocaleWinTest::shortTimeFormat):
(TEST_F):

tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::localizedDateFormatText):
(LocalizedDateICUTest::localizedShortDateFormatText):

4:11 AM Changeset in webkit [128583] by keishi@webkit.org

12 edits in trunk

Add runtime flag that enables lang attribute for form controls in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=96636

Reviewed by Kent Tamura.

Source/autotools/symbols.filter:

Source/WebCore:

Lang attribute support for form controls will be incomplete and just for LayoutTests.

No new tests. No behavior change.

WebCore.exp.in:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
(RuntimeEnabledFeatures):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
(WebCore):

testing/InternalSettings.h:

(Backup):
(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

3:59 AM Changeset in webkit [128582] by keishi@webkit.org

4 edits in trunk/Source

LocaleMac should fallback to defaultLanguage for an invalid locale
https://bugs.webkit.org/show_bug.cgi?id=96744

Reviewed by Kent Tamura.

Source/WebCore:

There is no way to tell if a locale identifier is valid or not in Cocoa
so we look if we have a matching language in the list of
ISOLanguageCodes given by NSLocale.

Covered in LocaleMacTest.invalidLocale.

platform/text/mac/LocaleMac.mm:

(WebCore):
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::create):

Source/WebKit/chromium:

tests/LocaleMacTest.cpp:

(TEST_F):

3:58 AM Changeset in webkit [128581] by peter@chromium.org

3 edits in trunk/Tools

The runtime/unsigned category should be valid in the cpp style-checker.
https://bugs.webkit.org/show_bug.cgi?id=96748

Reviewed by Csaba Osztrogonác.

This is causing the webkitpy tests to fail because it's not listed in the
category array. Furthermore, change an "int" to "long" because it's
throwing a double error in one of the earlier asserts.

Scripts/webkitpy/style/checkers/cpp.py:

(CppChecker):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_names):

3:41 AM Changeset in webkit [128580] by vsevik@chromium.org

16 edits
2 adds in trunk

Web Inspector: Add ability to replay XHR in network panel.
https://bugs.webkit.org/show_bug.cgi?id=95187

Reviewed by Yury Semikhatsky.

Source/WebCore:

Patch based on Pavel Chadnov's patch.
This patch implements Replay XHR feature in web inspector.
XMLHttpRequest's ThreadableLoaderClient is now used to map XMLHttpRequest object to ResourceLoader request identifiers.
Before initiating load all XHR parameters are now sent to inspector.
XMLHttpRequest parameters are stored in inspector's network request cache in XHRReplayData class.
When XHR replay is requested, a new XMLHttpRequest is created based on stored data.

Test: http/tests/inspector/network/network-xhr-replay.html

inspector/Inspector.json:
inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):

inspector/InspectorConsoleAgent.h:

(InspectorConsoleAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClientImpl):
(WebCore::InspectorInstrumentation::willLoadXHRImpl):
(WebCore::InspectorInstrumentation::didFailXHRLoadingImpl):
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):

inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::didFailXHRLoading):
(WebCore::InspectorInstrumentation::didFinishXHRLoading):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient):
(WebCore):
(WebCore::InspectorResourceAgent::willLoadXHR):
(WebCore::InspectorResourceAgent::didFailXHRLoading):
(WebCore::InspectorResourceAgent::didFinishXHRLoading):
(WebCore::InspectorResourceAgent::replayXHR):

inspector/InspectorResourceAgent.h:

(WebCore):
(InspectorResourceAgent):

inspector/NetworkResourcesData.cpp:

(WebCore::XHRReplayData::create):
(WebCore):
(WebCore::XHRReplayData::addHeader):
(WebCore::XHRReplayData::XHRReplayData):
(WebCore::NetworkResourcesData::xhrReplayData):
(WebCore::NetworkResourcesData::setXHRReplayData):
(WebCore::NetworkResourcesData::reuseXHRReplayData):
(WebCore::NetworkResourcesData::clear):

inspector/NetworkResourcesData.h:

(XHRReplayData):
(WebCore::XHRReplayData::method):
(WebCore::XHRReplayData::url):
(WebCore::XHRReplayData::async):
(WebCore::XHRReplayData::formData):
(WebCore::XHRReplayData::headers):
(WebCore::XHRReplayData::includeCredentials):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::xhrReplayData):
(WebCore::NetworkResourcesData::ResourceData::setXHRReplayData):
(ResourceData):
(NetworkResourcesData):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._replayXHR):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest): added documentThreadableLoaderStartedLoadingForClient instrumentation
so that inspector could map XMLHttpRequest to ResourceLoader's identifiers.

loader/cache/CachedResource.h:

(WebCore::CachedResource::loader): DocumentThreadableLoader uses CachedResource::loader() to get ResourceLoader identifier.
(CachedResource):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::sendFromInspector): Added a method for sending XMLHttpRequests based on request body stored in inspector.
(WebCore):
(WebCore::XMLHttpRequest::createRequest): Replaced will/didLoadXHRSynchonously instrumentations with willLoadXHR instrumentation.
(WebCore::XMLHttpRequest::internalAbort): Added didFailXHRLoadingInstrumentation
(WebCore::XMLHttpRequest::didFinishLoading): Added didFinishXHRLoading instrumentation

xml/XMLHttpRequest.h:

(XMLHttpRequest):

LayoutTests:

Added XHR replay test.

http/tests/inspector/network/network-xhr-replay-expected.txt: Added.
http/tests/inspector/network/network-xhr-replay.html: Added.

3:40 AM Changeset in webkit [128579] by Csaba Osztrogonác

2 edits in trunk/PerformanceTests

Unreviewed, rolling out r128562.
http://trac.webkit.org/changeset/128562
https://bugs.webkit.org/show_bug.cgi?id=96747

It broke perf tests on Qt and Chromium (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

resources/runner.js:

(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

3:22 AM Changeset in webkit [128578] by anilsson@rim.com

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add renderTreeAsText API to WebPage
https://bugs.webkit.org/show_bug.cgi?id=96629

Reviewed by Antonio Gomes.

This will be used for automated testing.

PR #198595

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::renderTreeAsText):
(WebKit):

Api/WebPage.h:

3:15 AM Changeset in webkit [128577] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[WK2] Move globalhistory tests to their correct section in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=96738

Unreviewed gardening.

Move 2 globalhistory tests to their correct section in WK2
Skipped list.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-14

platform/wk2/Skipped:

3:10 AM Changeset in webkit [128576] by loislo@chromium.org

2 edits in trunk/Source/WTF

Web Inspector: NMI: remove current traits helper class because it is customizing the instrumentation at a wrong place and is not necessary at the moment.
https://bugs.webkit.org/show_bug.cgi?id=96737

Reviewed by Yury Semikhatsky.

wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
WTF::MemoryInstrumentationTraits): removed
(WTF::MemoryInstrumentation::OwningTraits::addInstrumentedObject): direct call inserted
(WTF::MemoryInstrumentation::OwningTraits::addObject):direct call inserted

3:09 AM Changeset in webkit [128575] by yosin@chromium.org

15 edits
2 adds in trunk

[Forms] multiple fields time input UI should save/restore its value even if it has an empty field.
https://bugs.webkit.org/show_bug.cgi?id=96714

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes multiple fields time input UI to save/restore value
of fields rather than time value. For this change, storage format of
input type "time" is also changed.

Before this patch, if user populates time fiels partially, all fields
are reset to initial value after back/forward navigation.

After this patch, partially populated fields are preserved after
back/forward navigation.

Fields of DateTimeEditElement are represented as 9 elements of
string vector in FormControlState regardless actual fields in
DateTimeEditElement for ease of restoring/saving.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Existing test fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html
convers this change.

WebCore.gypi: Chagned to add DateTimeFieldsState.{cpp.h}
html/DateTimeFieldsState.cpp: Added.

(WebCore::getNumberFromFormControlState): Extracts unsigned integer or empty value from FormControlState.
(WebCore::getAMPMFromFormControlState): Extracts AM/PM value or empty value from FormControlState.
(WebCore::DateTimeFieldsState::DateTimeFieldsState): Initializes fields with empty value.
(WebCore::DateTimeFieldsState::restoreFormControlState): Makes DateTimeFieldsState instance from FormControlState.
(WebCore::DateTimeFieldsState::saveFormControlState): Makes FormControlState from DateTimeFieldsState.

html/DateTimeFieldsState.h: Added.

(DateTimeFieldsState):
(WebCore::DateTimeFieldsState::ampm): Returns AM/PM field value.
(WebCore::DateTimeFieldsState::dayOfMonth): Returns day of month field value.
(WebCore::DateTimeFieldsState::hour): Reutrns hour field value.
(WebCore::DateTimeFieldsState::millisecond): Returns millisecond field value.
(WebCore::DateTimeFieldsState::minute): Returns minute field value.
(WebCore::DateTimeFieldsState::month): Returns month field value.
(WebCore::DateTimeFieldsState::second): Returns second field value.
(WebCore::DateTimeFieldsState::weekOfYear): Returns week of year field.
(WebCore::DateTimeFieldsState::year): Returns year field value.
(WebCore::DateTimeFieldsState::hasAMPM): Returns true if AM/PM field has value.
(WebCore::DateTimeFieldsState::hasDayOfMonth): Returns true if day of month field has value.
(WebCore::DateTimeFieldsState::hasHour): Returns true if hour field has value.
(WebCore::DateTimeFieldsState::hasMillisecond): Returns true if millisecond field has value.
(WebCore::DateTimeFieldsState::hasMinute): Returns true if minute field has value.
(WebCore::DateTimeFieldsState::hasMonth): Returns true if month field has value.
(WebCore::DateTimeFieldsState::hasSecond): Returns true if second field has value.
(WebCore::DateTimeFieldsState::hasWeekOfYear): Returns true if week of year field has value.
(WebCore::DateTimeFieldsState::hasYear): Returns true if year field has value.
(WebCore::DateTimeFieldsState::setAMPM): Sets AM/PM field.
(WebCore::DateTimeFieldsState::setDayOfMonth): Sets day of month field.
(WebCore::DateTimeFieldsState::setHour): Sets hour field.
(WebCore::DateTimeFieldsState::setMillisecond): Sets millisecond field.
(WebCore::DateTimeFieldsState::setMinute): Sets minute field.
(WebCore::DateTimeFieldsState::setMonth): Sets month field.
(WebCore::DateTimeFieldsState::setSecond): Set second field.
(WebCore::DateTimeFieldsState::setWeekOfYear): Sets week of year field.
(WebCore::DateTimeFieldsState::setYear): Sets year field.

html/FormController.cpp:

(WebCore::formStateSignature): Increment version number to 8 for incompatible change of FormControlState.

html/TimeInputType.cpp:

(WebCore::TimeInputType::restoreFormControlState): Added to call DateTimeFieldsState::restoreFormControlState().
(WebCore::TimeInputType::saveFormControlState): Added to call DateTimeFieldsState::saveFormControlState().

html/TimeInputType.h:

(TimeInputType): Added declarations for restoreFormControlState() and saveFormControlState().

html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::setValueAsDateTimeFieldsState): Added to set fields from DateTimeFieldsState.
(WebCore::DateTimeEditElement::valueAsDateTimeFieldsState): Added to make DateTimeFieldsState from fields.

html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Added declarations for setValueAsDateTimeFieldsState() and valueAsDateTimeFieldsState().

html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Added declarations for populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().

html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeAMPMFieldElement::populateDateTimeFieldsState): Added to set AM/PM value to DateTimeFieldsState.
(WebCore::DateTimeAMPMFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): Added to set hour value to DateTimeFieldsState.
(WebCore::DateTimeHourFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeMillisecondFieldElement::populateDateTimeFieldsState): Added to set millisecond value to DateTimeFieldsState.
(WebCore::DateTimeMillisecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeMinuteFieldElement::populateDateTimeFieldsState): Added to set minute value to DateTimeFieldsState.
(WebCore::DateTimeMinuteFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
(WebCore::DateTimeSecondFieldElement::populateDateTimeFieldsState): Added to set second value to DateTimeFieldsState.
(WebCore::DateTimeSecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.

html/shadow/DateTimeFieldElements.h:

(DateTimeAMPMFieldElement): Added declarations of populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Extend accessibility of maximum() and setEmptyValue() to protected.

html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement): Extend accessibility of hasValue(), setEmptyValue() and valueAsInteger() to protected.

LayoutTests:

This patch changes time-multiple-fields-preserve-value-after-history-back.html
to check partial value is saved and restored rather than resetting value.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updated for new expectation.
fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to check partially populated fields of input element.

2:37 AM Changeset in webkit [128574] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r128568.
http://trac.webkit.org/changeset/128568
https://bugs.webkit.org/show_bug.cgi?id=96739

It broke 3 tests everywhere (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14

bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

2:27 AM Changeset in webkit [128573] by kenneth@webkit.org

12 edits
2 moves in trunk

Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Source/WebCore:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

PlatformEfl.cmake:
platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):

platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

Source/WTF:

Reviewed by Gyuyoung Kim.

Remove OwnPtr support for Evas_Object* and add support for it
with RefPtr instead (the latter moved from WebCore).

wtf/PlatformEfl.cmake:
wtf/efl/OwnPtrEfl.cpp:
wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.

(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):

wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.

(WTF):

Tools:

Reviewed by Adam Barth.

Replace OwnPtr<Evas_Object> with RefPtr.

DumpRenderTree/efl/ImageDiff.cpp:

(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

2:12 AM Changeset in webkit [128572] by zoltan@webkit.org

106 edits in trunk/Source/WebCore

Extend the coverage of the Custom Allocation Framework in WebCore
https://bugs.webkit.org/show_bug.cgi?id=96512

Reviewed by Eric Seidel.

Add WTF_MAKE_FAST_ALLOCATED macro to the following class/struct declarations because these
or their child classes are instantiated by operator new.

Covered by existing tests.

Modules/websockets/WebSocketDeflateFramer.cpp:

(WebSocketExtensionDeflateFrame):

Modules/websockets/WebSocketDeflateFramer.h:

(DeflateResultHolder):
(InflateResultHolder):

Modules/websockets/WebSocketDeflater.h:

(WebSocketDeflater):
(WebSocketInflater):

Modules/websockets/WebSocketHandshake.h:

(WebSocketHandshake):

bindings/js/ScriptDebugServer.h:

(Task):

css/CSSCalculationValue.cpp:

(CSSCalcPrimitiveValue):

css/CSSParserMode.h:

(CSSParserContext):

css/CSSValuePool.h:

(CSSValuePool):

css/StyleBuilder.h:

(StyleBuilder):

css/StylePropertyShorthand.h:

(StylePropertyShorthand):

css/StyleResolver.cpp:

(RuleSet):

css/StyleRule.h:

(StyleRuleBase):
(StyleRule):

css/StyleRuleImport.h:

(StyleRuleImport):

css/WebKitCSSKeyframeRule.h:

(StyleKeyframe):

dom/CheckedRadioButtons.cpp:

(RadioButtonGroup):

dom/ContextFeatures.h:

(ContextFeaturesClient):

dom/DOMImplementation.h:

(DOMImplementation):
(XMLMIMETypeRegExp):

dom/Document.cpp:

(ImmutableAttributeDataCacheKey):

dom/ElementShadow.h:

(ElementShadow):

dom/GenericEventQueue.h:

(GenericEventQueue):

dom/IdTargetObserverRegistry.h:

(IdTargetObserverRegistry):

dom/NamedNodeMap.h:

(NamedNodeMap):

dom/ScopedEventQueue.h:

(ScopedEventQueue):

dom/StyledElement.cpp:

(PresentationAttributeCacheEntry):
(PresentationAttributeCacheCleaner):

editing/EditingStyle.cpp:

(HTMLElementEquivalent):

editing/SpellChecker.h:

(SpellChecker):

fileapi/ThreadableBlobRegistry.cpp:

(BlobRegistryContext):

html/FormAssociatedElement.cpp:

(FormAttributeTargetObserver):

html/FormController.h:

(FormController):

html/HTMLInputElement.cpp:

(ListAttributeTargetObserver):

html/PublicURLManager.h:

(PublicURLManager):

html/StepRange.h:

(StepDescription):

html/ValidationMessage.h:

(ValidationMessage):

html/canvas/WebGLExtension.h:

(WebGLExtension):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebGLRenderingContextLostCallback):
(WebGLRenderingContextErrorMessageCallback):

html/parser/HTMLElementStack.h:

(ElementRecord):

html/parser/HTMLMetaCharsetParser.h:

(HTMLMetaCharsetParser):

inspector/DOMEditor.h:

(DOMEditor):

inspector/InjectedScriptHost.h:

(InspectableObject):

inspector/InjectedScriptManager.h:

(InjectedScriptManager):

inspector/InspectorCSSAgent.cpp:

(SelectorProfile):

inspector/InspectorCounters.h:

(ThreadLocalInspectorCounters):

inspector/InspectorDOMAgent.cpp:

(RevalidateStyleAttributeTask):

inspector/InspectorFrontendClientLocal.cpp:

(InspectorBackendDispatchTask):

inspector/InspectorHistory.h:

(InspectorHistory):
(Action):

inspector/InspectorOverlay.h:

(HighlightConfig):
(InspectorOverlay):

inspector/InspectorState.h:

(InspectorState):

inspector/InspectorStyleSheet.cpp:

(ParsedStyleSheet):

inspector/InspectorWorkerAgent.cpp:

(InspectorWorkerAgent::WorkerFrontendChannel):

inspector/NetworkResourcesData.h:

(NetworkResourcesData):
(ResourceData):

inspector/WorkerInspectorController.cpp:
loader/EmptyClients.h:

(EmptyChromeClient):

loader/ResourceLoadScheduler.h:

(ResourceLoadScheduler):
(HostInformation):

loader/icon/IconDatabase.cpp:

(DefaultIconDatabaseClient):
(ClientWorkItem):

page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):

page/ContentSecurityPolicy.h:

(ContentSecurityPolicy):

page/FrameActionScheduler.h:

(FrameActionScheduler):

page/MemoryInfo.cpp:

(HeapSizeCache):

platform/CalculationValue.h:

(CalcExpressionNode):

platform/Cursor.h:

(Cursor):

platform/Decimal.h:

(Decimal):

platform/Length.cpp:

(CalculationValueHandleMap):

platform/MemoryPressureHandler.h:

(MemoryPressureHandler):

platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

platform/ScrollAnimator.h:

(ScrollAnimator):

platform/graphics/GlyphPageTreeNode.h:

(GlyphPageTreeNode):

platform/graphics/GraphicsContext.h:

(GraphicsContextStateSaver):

platform/graphics/GraphicsLayer.h:

(AnimationValue):

platform/graphics/IntRect.h:

(IntRect):

platform/graphics/ShadowBlur.cpp:

(ScratchBuffer):

platform/graphics/TextRun.h:

(TextRun):

platform/graphics/TiledBackingStoreBackend.h:

(TiledBackingStoreBackend):

platform/graphics/WidthIterator.h:

(WidthIterator):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient):

platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

platform/graphics/texmap/TextureMapper.h:

(TextureMapper):

platform/graphics/texmap/TextureMapperGL.cpp:

(TextureMapperGLData):

platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

platform/image-decoders/bmp/BMPImageReader.h:

(BMPImageReader):

platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameReader):
(GIFImageReader):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(JPEGImageReader):

platform/image-decoders/png/PNGImageDecoder.cpp:

(PNGImageReader):

platform/network/BlobRegistryImpl.h:

(BlobRegistryImpl):

platform/network/ResourceResponseBase.h:

(CrossThreadResourceResponseDataBase):

platform/text/TextCodecICU.h:

(ICUConverterWrapper):

rendering/FlowThreadController.h:

(FlowThreadController):

rendering/RenderBoxRegionInfo.h:

(RenderBoxRegionInfo):

rendering/RenderLayer.h:

(ClipRects):
(ClipRectsCache):

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

rendering/WrapShapeInfo.h:

(WrapShapeInfo):

rendering/style/NinePieceImage.h:

(NinePieceImageData):

rendering/svg/RenderSVGResourceFilter.h:

(FilterData):

rendering/svg/RenderSVGResourceGradient.h:

(GradientData):

rendering/svg/RenderSVGResourcePattern.h:

(PatternData):

rendering/svg/SVGResources.h:

(ClipperFilterMaskerData):
(MarkerData):
(FillStrokeData):

svg/SVGAngle.h:

(SVGAngle):

svg/SVGLength.h:

(SVGLength):

svg/SVGPreserveAspectRatio.h:

(SVGPreserveAspectRatio):

svg/graphics/SVGImageCache.h:

(SVGImageCache):

svg/properties/SVGPropertyInfo.h:

(SVGPropertyInfo):

workers/WorkerEventQueue.h:

(WorkerEventQueue):

xml/parser/MarkupTokenBase.h:

(DoctypeDataBase):

xml/parser/XMLDocumentParserLibxml2.cpp:

(PendingCallbacks):
(OffsetBuffer):

xml/parser/XMLToken.h:

(XMLDeclarationData):

2:02 AM Changeset in webkit [128571] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Refactoring: move the proxy wrapping method up to the base class
https://bugs.webkit.org/show_bug.cgi?id=96515

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-14
Reviewed by Vsevolod Vlasov.

Move the proxyObject() method up from WebGLRenderingContextResource to the Resource class, so that it could be reused later for wrapping a 2D context.

inspector/InjectedScriptWebGLModuleSource.js:

(.):

1:42 AM Changeset in webkit [128570] by commit-queue@webkit.org

45 edits in trunk/Source/WebCore

Fix unused parameter compile warnings in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=96712

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-14
Reviewed by Ryosuke Niwa.

Fixed unused parameter compile warning messages(-Wunused-parameter) during EFL build.
There are two kinds of stuff related to this warnings.
First one is that the parameter value has not been used anywhere inside the function.
Other one is that usability of parameter value is depended on option, i.e. ACCESSIBILITY.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::postNotification):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setGeolocationOverride):

loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::registerIntentService):

page/Frame.cpp:

(WebCore::Frame::layerTreeAsText):

page/FrameView.cpp:

(WebCore::FrameView::setScrollingPerformanceLoggingEnabled):

page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::tabsToAllFormControls):
(WebCore::EventHandler::passMouseDownEventToWidget):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::scrollLayerForFrameView):

platform/RuntimeApplicationChecks.cpp:

(WebCore::mainBundleIsEqualTo):

platform/ScrollView.cpp:

(WebCore::ScrollView::platformSetScrollOrigin):

platform/cairo/WidgetBackingStoreCairo.cpp:

(WebCore::createSurfaceForBackingStore):

platform/efl/ContextMenuEfl.cpp:

(WebCore::platformMenuDescription):

platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::ContextMenuItem):

platform/efl/DragDataEfl.cpp:

(WebCore::DragData::asFilenames):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):

platform/efl/GamepadsEfl.cpp:

(WebCore::GamepadsEfl::onGamePadChange):

platform/efl/LocalizedStringsEfl.cpp:

(WebCore::imageTitle):
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):

platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::documentFragment):

platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::systemFont):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):

platform/efl/ScrollbarEfl.cpp:

(scrollbarEflEdjeMessage):

platform/efl/ScrollbarThemeEfl.cpp:

(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):

platform/efl/TemporaryLinkStubs.cpp:

(WebCore::signedPublicKeyAndChallengeString):

platform/efl/WidgetEfl.cpp:

(WebCore::Widget::setFocus):
(WebCore::Widget::paint):

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setPlatformTextDrawingMode):

platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::orientationAtIndex):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsType):

platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::Font::drawComplexText):

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::adjustFocusRingLineWidth):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::fillRoundedRect):

platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(WebCore::GraphicsContextPlatformPrivate::syncContext):

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData):

platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):

platform/graphics/efl/IconEfl.cpp:

(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):

platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):

platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::gstGWorldSyncMessageCallback):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkMarshalVoidAndMiniObject):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcUriHandlerInit):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(StreamingClient::didReceiveData):

platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp:

(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzCairoGetTable):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readColorProfile):
(WebCore::init_source):
(WebCore::fill_input_buffer):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):

platform/network/soup/CookieStorageSoup.cpp:

(WebCore::setCookieStoragePrivateBrowsingEnabled):

platform/network/soup/DNSSoup.cpp:

(WebCore::resolvedCallback):

platform/network/soup/ProxyResolverSoup.cpp:

(soup_proxy_resolver_wk_init):
(soupProxyResolverWkGetProxyURIAsync):
(soupProxyResolverWkGetProxyURISync):

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::addFormElementsToSoupMessage):
(WebCore::requestStartedCallback):
(WebCore::closeCallback):
(WebCore::readCallback):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustRepaintRect):

1:36 AM Changeset in webkit [128569] by vsevik@chromium.org

36 edits in trunk/LayoutTests

Web Inspector: [Tests] Extract a common method for sending XHRs from tests.
https://bugs.webkit.org/show_bug.cgi?id=96662

Reviewed by Alexander Pavlov.

Extracted InspectorTest.makeXHR() methods to simplify tests.

http/tests/inspector/appcache/appcache-swap-expected.txt:
http/tests/inspector/appcache/appcache-swap.html:
http/tests/inspector/console-xhr-logging-async-expected.txt:
http/tests/inspector/console-xhr-logging-async.html:
http/tests/inspector/console-xhr-logging.html:
http/tests/inspector/network-test.js:

(xhrLoadedCallback):
(initialize_NetworkTest.InspectorTest.makeSimpleXHR):
(initialize_NetworkTest.InspectorTest.makeSimpleXHRWithPayload):
(initialize_NetworkTest.InspectorTest.makeXHR.innerCallback):
(initialize_NetworkTest.InspectorTest.makeXHR):
(doSimpleXHR):
(doSimpleXHRWithPayload):
(doXHR):
(makeXHR):

http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
http/tests/inspector/network/async-xhr-json-mime-type.html:
http/tests/inspector/network/network-clear-cache.html-disabled:
http/tests/inspector/network/network-clear-cookies.html-disabled:
http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
http/tests/inspector/network/network-content-replacement-xhr.html:
http/tests/inspector/network/network-cyrillic-xhr-expected.txt:
http/tests/inspector/network/network-cyrillic-xhr.html:
http/tests/inspector/network/network-disable-cache-xhrs-expected.txt:
http/tests/inspector/network/network-disable-cache-xhrs.html:
http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt:
http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
http/tests/inspector/network/network-empty-xhr-expected.txt:
http/tests/inspector/network/network-empty-xhr.html:
http/tests/inspector/network/network-sidebar-width-expected.txt:
http/tests/inspector/network/network-sidebar-width.html:
http/tests/inspector/network/network-size-sync.html:
http/tests/inspector/network/network-xhr-async-double-expected.txt:
http/tests/inspector/network/network-xhr-async-double.html:
http/tests/inspector/network/network-xhr-async-expected.txt:
http/tests/inspector/network/network-xhr-async.html:
http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt:
http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
http/tests/inspector/network/network-xhr-sync-expected.txt:
http/tests/inspector/network/network-xhr-sync.html:
http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt:
http/tests/inspector/resource-tree/resource-tree-no-xhrs.html:
platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:

1:27 AM Changeset in webkit [128568] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebCore

Need to clear exception in JSDictionary for operations that might have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by Kentaro Hara.

Clear the exception if failed to convert the value inside the JSDictionary.
Otherwise, it might impact the following operations on the dictionary.

No new tests, the existing test at LayoutTest/storage/indexeddb/tutorial.html should work for JSC binding.

bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

1:09 AM Changeset in webkit [128567] by g.czajkowski@samsung.com

5 edits in trunk/Source

Add method to get the list of all available dictionaries
https://bugs.webkit.org/show_bug.cgi?id=96518

Reviewed by Carlos Garcia Campos.

Source/WebCore:

There is lack of the method in the TextCheckerEnchant class to get
the list of all available/installed dictionaries. To set the
dictionaries the client has to 'guess/hard code' the names of
dictionaries that are not obvious and depend on OS configuration
and installed packages. The list can be used by WebKit's GTK and
EFL API for instance:
webkit_web_context_set_spell_checking_languages(),
ewk_text_checker_setting_spell_checking_languages_set()
to set dictionaries used by Enchant.

To avoid names conflict a new one has been introduced for former
getSpellCheckingLanguages. It has been changed to loadedSpellCheckingLanguages
as it gets the current (in use) dictionaries. Additionally the 'get' prefix
has been removed according to WebKit coding style.

platform/text/enchant/TextCheckerEnchant.cpp:

(TextCheckerEnchant::loadedSpellCheckingLanguages):
Changed name from getSpellCheckingLanguages and added const modifier.

(TextCheckerEnchant::availableSpellCheckingLanguages):
A newly added method to get available/installed dictionaries.
Its output can be used as input for updateSpellCheckingLanguages().

platform/text/enchant/TextCheckerEnchant.h:

(TextCheckerEnchant):

Source/WebKit2:

UIProcess/API/gtk/WebKitTextChecker.cpp:

(WebKitTextChecker::getSpellCheckingLanguages):
Update the method name that is called inside getSpellCheckingLanguages.
This replace doesn't affect any on API changes.

12:51 AM Changeset in webkit [128566] by commit-queue@webkit.org

13 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-09-14
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context but rather a smaller
object.

No new tests. No change in functionality.

bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::leakHandle):
(ScopedPersistent):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):

bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):

bindings/v8/V8DOMWindowShell.cpp:

bindings/v8/V8DOMWindowShell.h:

bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

12:12 AM Changeset in webkit [128565] by gyuyoung.kim@samsung.com

12 edits
2 moves in trunk

Unreviewed, rolling out r128507.
http://trac.webkit.org/changeset/128507
https://bugs.webkit.org/show_bug.cgi?id=96659

Source/WebCore:

Revert. r128507 makes too many crashes in EFL layout test bots.

PlatformEfl.cmake:
platform/efl/RefPtrEfl.cpp: Renamed from Source/WTF/wtf/efl/RefPtrEfl.cpp.

(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):

platform/efl/RefPtrEfl.h: Renamed from Source/WTF/wtf/efl/RefPtrEfl.h.

(WTF):

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):

platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Revert. r128507 makes too many crashes in EFL layout test bots.

tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

Source/WTF:

Revert. r128507 makes too many crash in EFL layout test bots.

wtf/PlatformEfl.cmake:
wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):
(WTF):

Tools:

Revert. r128507 makes too many crashes in EFL layout test bots.

DumpRenderTree/efl/ImageDiff.cpp:

(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

12:09 AM QtWebKitBuildBots edited by Csaba Osztrogonác

update bots (diff)

12:09 AM Changeset in webkit [128564] by Patrick Gansterer

6 edits in trunk/Source/WebCore

Reuse floating point formatting of TextStream in [SVG]RenderTreeAsText.cpp
https://bugs.webkit.org/show_bug.cgi?id=96264

Reviewed by Benjamin Poulain.

RenderTreeAsText uses the same format for streaming out floats as TextStream
does. Replace formatNumberRespectingIntegers() with a new overload to the
operator<< to reuse the special cases for numbers which take advantage of
StringBuilder::appendNumber() and avoid a temporary StringImpl.

platform/text/TextStream.cpp:

(WebCore::hasFractions):
(WebCore::TextStream::operator<<):

platform/text/TextStream.h:
rendering/RenderTreeAsText.cpp:

(WebCore::operator<<):

rendering/RenderTreeAsText.h:
rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

12:06 AM Changeset in webkit [128563] by mhahnenberg@apple.com

6 edits in trunk/Source/JavaScriptCore

Remove the Zapped BlockState
https://bugs.webkit.org/show_bug.cgi?id=96708

Reviewed by Geoffrey Garen.

The Zapped block state is rather confusing. It indicates that a block is in one of two different states that we
can't tell the difference between:

1) I have run all destructors of things that are zapped, and I have not allocated any more objects. This block

is ready for reclaiming if you so choose.

2) I have run all the destructors of things that are zapped, but I have allocated more stuff since then, so it

is not safe to reclaim this block.

This state adds a lot of complexity to our state transition model for MarkedBlocks. We should get rid of it.
We can replace this state by making sure mark bits represent all of the liveness information we need when running
our conservative stack scan. Instead of zapping the free list when canonicalizing cell liveness data prior to
a conservative scan, we can instead mark all objects in the block except for those in the free list. This should
incur no performance penalty since we're doing it on a very small O(1) number of blocks at the beginning of the collection.

For the time being we still need to use zapping to determine whether we have run an object's destructor or not.

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): Renaming stuff.

heap/MarkedAllocator.h: Renamed zapFreeList to canonicalizeCellLivenessData to match.

(MarkedAllocator):
(JSC::MarkedAllocator::canonicalizeCellLivenessData): Same as old zapFreeList, but just call canonicalize instead.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep): Remove the check for Zapped block stuff. Also change the block state to Marked
instead of Zapped if we're not producing a FreeList since that's the only other state that really makes any sense.
(JSC::MarkedBlock::sweepHelper): Remove Zapped related code.
(SetAllMarksFunctor): Functor to set all the mark bits in the block since there's not a simple function to call on
the Bitmap itself.
(JSC::SetAllMarksFunctor::operator()):
(JSC):
(JSC::MarkedBlock::canonicalizeCellLivenessData): Remove all the stuff for Zapped. For FreeListed, set all the mark bits
and then clear the ones for the objects in the FreeList. This ensures that only the things that were in the FreeList
are considered to be dead by the conservative scan, just like if we were to have zapped the FreeList like before.

heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::clearMarked): Add function to clear individual mark bits, since we need that functionality now.
(JSC):
(JSC::MarkedBlock::isLive): Remove code for Zapped stuff. Marked handles all interesting cases now.
(JSC::MarkedBlock::forEachCell): Add new iterator function that iterates over all cells in the block, regardless of
whether they're live or a dead.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::canonicalizeCellLivenessData): Change to call the renamed canonicalize function.

12:03 AM Changeset in webkit [128562] by rniwa@webkit.org

2 edits in trunk/PerformanceTests

Use performance.webkitNow in PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92826

Reviewed by Eric Seidel.

Use performance.webkitNow with Date.now as a fallback for more acurate time measurements.

Context Navigation

Timeline

Sep 15, 2012:

Sep 14, 2012:

Download in other formats: