Timeline
Sep 16, 2012:
- 11:44 PM Changeset in webkit [128719] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
https://bugs.webkit.org/show_bug.cgi?id=96895
Unreviewed EFL gardening.
Skip http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html for
EFL port since it sometimes asserts in MessagePort::contextDestroyed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-16
- platform/efl/TestExpectations:
- 11:42 PM Changeset in webkit [128718] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Mark inspector/elements/delete-from-document.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=96897
Unreviewed EFL gardening.
Mark inspector/elements/delete-from-document.html as flaky.
It sometimes times out of the WK2-EFL bot.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-16
- platform/efl-wk2/TestExpectations:
- 11:38 PM Changeset in webkit [128717] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-16
- DEPS:
- 9:56 PM WebKitGTK/1.10.x edited by
- Added r128712 as proposed merge (diff)
- 9:41 PM Changeset in webkit [128716] by
-
- 2 edits in trunk/Source/WebCore
Chromium win build fix - listing a file that doesn't exist is a fatal errors in the msvs gyp generator.
- WebCore.gypi:
- 9:00 PM Changeset in webkit [128715] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening. Rebaseline after r128691
https://bugs.webkit.org/show_bug.cgi?id=96892
Rebaseline fast/css/word-space-extra.html for chromium.
- platform/chromium-linux/fast/css/word-space-extra-expected.txt: Added.
- 4:38 PM Changeset in webkit [128714] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fixed a typo in the last entry noticed by Eric Seidel.
- 4:36 PM Changeset in webkit [128713] by
-
- 4 edits2 adds in trunk
REGRESSION (r126763): css1/pseudo/firstline.html fails when using the complex text code path
https://bugs.webkit.org/show_bug.cgi?id=96890
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/text/stale-TextLayout-from-first-line.html
When a first-line style specifies a font, different pieces of the same RednerText can be
laid out using different fonts, requiring a differet TextLayout for each piece.
- rendering/RenderBlock.h:
(RenderTextInfo): Added m_font data member.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::RenderTextInfo::RenderTextInfo): Added initializer for new data member.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Added code to update the text layout in
renderTextInfo if the font has changed.
LayoutTests:
- fast/text/stale-TextLayout-from-first-line-expected.html: Added.
- fast/text/stale-TextLayout-from-first-line.html: Added.
- 3:54 PM Changeset in webkit [128712] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Missing dllexport causing linking errors on Windows platform
https://bugs.webkit.org/show_bug.cgi?id=96888
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-09-16
Reviewed by Kentaro Hara.
Define BUILDING_WebCore during the build to properly mark
FrameDestructionObserver symbols with declspec(dllexport) attribute.
- GNUmakefile.am:
- 3:01 PM WebInspector edited by
- (diff)
- 3:00 PM WebInspector edited by
- (diff)
- 9:57 AM Changeset in webkit [128711] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
https://bugs.webkit.org/show_bug.cgi?id=96884
Unreviewed EFL gardening.
Skip fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
because EFL's DRT does not support overriding 'WebKitDisplayImagesKey'
preference yet.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-16
- platform/efl-wk1/TestExpectations:
- 8:21 AM Changeset in webkit [128710] by
-
- 3 edits in trunk/LayoutTests
[EFL] Update TestExpectations for tests requiring plugins support
https://bugs.webkit.org/show_bug.cgi?id=96882
Unreviewed EFL gardening.
Regroup all test requiring plugins support in TestExpectation file
and update their bug number.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-16
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- 8:06 AM WebKitGTK/1.10.x edited by
- Added r128696 as proposed merge (diff)
- 8:03 AM Changeset in webkit [128709] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark inspector/debugger/dynamic-script-tag.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=96887
Unreviewed EFL gardening.
Mark inspector/debugger/dynamic-script-tag.html as flaky
in EFL's TestExpectations.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-16
- platform/efl/TestExpectations:
- 7:52 AM Changeset in webkit [128708] by
-
- 2 edits in trunk/LayoutTests
[EFL] 3 spatial navigation tests can be unskipped after r128644
https://bugs.webkit.org/show_bug.cgi?id=96880
Unreviewed EFL gardening.
Unskip 3 spatial navigation tests that have been fixed in r128644.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-16
- platform/efl/TestExpectations:
- 7:46 AM Changeset in webkit [128707] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/events/message-port-constructor-for-deleted-document.html
https://bugs.webkit.org/show_bug.cgi?id=96885
Unreviewed EFL gardening.
Causes assertion failure in MessagePort::contextDestroyed in
http/tests/security/MessagePort/event-listener-context.html, usually
attributed to later tests. We need to skip the test for now.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-16
- platform/efl/TestExpectations:
- 12:22 AM Changeset in webkit [128706] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSObject.cpp and JSArray.cpp have inconsistent tests for the invalid array index case
https://bugs.webkit.org/show_bug.cgi?id=96878
Reviewed by Sam Weinig.
Removed the uses of UNLIKELY() because I don't believe they are buying us anything,
since we're already on the slow path. Also found other places where we're testing for
the invalid array index case using unusual predicates rather than just using
MAX_ARRAY_INDEX. With this change, I believe that all of our tests for invalid
array indices (i.e. indices that should be treated as non-indexed properties)
uniformly use MAX_ARRAY_INDEX and PropertyName::NotAnIndex.
- runtime/JSArray.cpp:
(JSC::JSArray::push):
- runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::defineOwnIndexedProperty):
Sep 15, 2012:
- 11:20 PM Changeset in webkit [128705] by
-
- 2 edits in trunk/Source/JavaScriptCore
Following the Butterfly refactoring, the comment for lastArraySize was not updated
https://bugs.webkit.org/show_bug.cgi?id=96877
Reviewed by Sam Weinig.
- runtime/JSObject.cpp:
(JSC):
- 11:08 PM Changeset in webkit [128704] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fixed JSLock to use the platform abstraction for Mutex instead of
depending on pthreads.
https://bugs.webkit.org/show_bug.cgi?id=96858.
Reviewed by Filip Pizlo.
This fixes a synchronization problem on the Windows port and makes
it more reliable when running the layout tests.
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSLock.cpp:
(JSC):
(JSC::GlobalJSLock::GlobalJSLock):
(JSC::GlobalJSLock::~GlobalJSLock):
(JSC::GlobalJSLock::initialize):
- runtime/JSLock.h:
(GlobalJSLock):
(JSLock):
- 10:17 PM Changeset in webkit [128703] by
-
- 12 edits10 adds in trunk
Source/WebCore: Pause inspector when inline scripts are blocked by Content Security Policy.
https://bugs.webkit.org/show_bug.cgi?id=93865
Patch by Mike West <mkwst@chromium.org> on 2012-09-15
Reviewed by Pavel Feldman.
When Content Security Policy blocks an inline script that's been
injected after the document is parsed, a fairly unhelpful console
warning is generated; it points at line 1, regardless of where the error
occurred. This patch adjusts CSP to not only warn on the console, but
also to notify the inspector that it should pause execution if the
developer has toggled "Break on Exceptions". Developers will have a
better chance of tracking down the error, as they'll have a complete
call stack to work with.
Tests: inspector/debugger/debugger-pause-on-blocked-event-handler.html
inspector/debugger/debugger-pause-on-blocked-script-injection.html
inspector/debugger/debugger-pause-on-blocked-script-url.html
- English.lproj/localizedStrings.js:
Adding localizable string for the new friendly pause message.
- inspector/Inspector.json:
Add CSPViolation as a recognized reason for pausing execution.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):
Teach the InspectorDebuggerAgent about script blocking. If pause on
exceptions is enabled, call 'InspectorDebuggerAgent::breakProgram',
and pass in an error object with a description that points to CSP
as the culprit.
(WebCore):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSPImpl):
Wire 'InspectorInstrumentation::scriptExecutionBlockedByCSP' to
the InspectorDebuggerAgent backend.
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):
The public interface that should be kicked whenever CSP blocks
script execution.
(WebCore):
- inspector/front-end/DebuggerModel.js:
Add CSPViolation as a recognized reason for pausing execution.
- inspector/front-end/ScriptsPanel.js:
Add a friendly call stack status message for CSP violations.
- page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
If script is blocked because the nonce doesn't match, report the
blocked script to the inspector.
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
If inline script is blocked, report the blocked script to the
inspector. This requires adding a bool parameter to differentiate
blocking inline script from inline style.
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
Tell 'checkInlineAndReportViolation' that we're dealing with script.
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
Tell 'checkInlineAndReportViolation' that we're dealing with script.
(WebCore::CSPDirectiveList::allowInlineScript):
Tell 'checkInlineAndReportViolation' that we're dealing with script.
(WebCore::CSPDirectiveList::allowInlineStyle):
Tell 'checkInlineAndReportViolation' that we're not dealing with script.
(WebCore::ContentSecurityPolicy::reportBlockedScriptExecutionToInspector):
Public interface for the various CSP* classes to poke the inspector.
(WebCore):
- page/ContentSecurityPolicy.h:
LayoutTests: Break on inline scripts blocked by CSP.
https://bugs.webkit.org/show_bug.cgi?id=93865
Patch by Mike West <mkwst@chromium.org> on 2012-09-15
Reviewed by Pavel Feldman.
- inspector/debugger/debugger-pause-on-blocked-event-handler-expected.txt: Added.
- inspector/debugger/debugger-pause-on-blocked-event-handler.html: Added.
- inspector/debugger/debugger-pause-on-blocked-script-injection-expected.txt: Added.
- inspector/debugger/debugger-pause-on-blocked-script-injection.html: Added.
- inspector/debugger/debugger-pause-on-blocked-script-url-expected.txt: Added.
- inspector/debugger/debugger-pause-on-blocked-script-url.html: Added.
- inspector/debugger/resources/pause-on-blocked-by-csp.js: Added.
(test.setStatus):
(test.step1):
(test.step2):
(test):
- inspector/debugger/resources/pause-on-blocked-event-handler.js: Added.
(testAction):
- inspector/debugger/resources/pause-on-blocked-script-injection.js: Added.
(testAction):
- inspector/debugger/resources/pause-on-blocked-script-url.js: Added.
(testAction):
- 10:03 PM Changeset in webkit [128702] by
-
- 3 edits2 adds in trunk
<use> not working when the SVG doc is embedded as <object> data
https://bugs.webkit.org/show_bug.cgi?id=96816
Reviewed by Dirk Schulze.
Source/WebCore:
Updated SVGURIReference::isExternalURIReference() to correctly classify fragment-only URIs.
Also, since the fragment-only test is cheap, it should be the first thing to try.
Test: svg/custom/object-data-href.html
- svg/SVGURIReference.h:
(WebCore::SVGURIReference::isExternalURIReference):
LayoutTests:
- svg/custom/object-data-href-expected.html: Added.
- svg/custom/object-data-href.html: Added.
- 9:34 PM Changeset in webkit [128701] by
-
- 9 edits in trunk/Source
Fix the build with WTF URL
https://bugs.webkit.org/show_bug.cgi?id=96875
Reviewed by Adam Barth.
Source/WebCore:
Fix reportMemoryUsage, the implementation was only partial.
- WebCore.exp.in: Export two more symbols as needed by API tests.
- platform/KURLWTFURL.cpp:
(WebCore::KURL::string): emptyString() return a reference,
it makes more sense than nullAtom() here.
- platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::reportMemoryUsage):
Source/WTF:
Add support for MemoryInstrumentation to WTF's URL classes.
- wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::reportMemoryUsage):
- wtf/url/api/ParsedURL.h:
(ParsedURL):
- wtf/url/api/URLString.cpp:
(WTF::URLString::reportMemoryUsage):
- wtf/url/api/URLString.h:
(URLString):
- 9:24 PM Changeset in webkit [128700] by
-
- 11 edits1 add in trunk/Source/WebCore
Add ClipPathOperation for -webkit-clip-path organization
https://bugs.webkit.org/show_bug.cgi?id=95619
Reviewed by Dean Jackson.
This patch adds a new class ClipPathOperation to manage the values of the
-webkit-clip-path property. ClipPathOperation stores a Path object for clipping and is
a preparation for IRI references of the SVG 'clipPath' element.
The structure of ClipPathOperation is simular to FilterOperation.
ClipPathOperation will be extended to support IRI references directly in a second patch.
No new tests. The changes just affect the backend.
- GNUmakefile.list.am: Added new ClipPathOperation class.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSComputedStyleDeclaration.cpp: Use ClipPathOperation instead of BasicShape.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
- css/StyleBuilder.cpp: Ditto.
(WebCore):
(WebCore::ApplyPropertyClipPath::setValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyClipPath::createHandler):
- rendering/ClipPathOperation.h: Added. New handler for property values (BasicShape, references).
(WebCore):
(ClipPathOperation):
(WebCore::ClipPathOperation::~ClipPathOperation):
(WebCore::ClipPathOperation::operator!=):
(WebCore::ClipPathOperation::getOperationType): Return the operation type.
(WebCore::ClipPathOperation::isSameType): Helper function for =operator.
(WebCore::ClipPathOperation::ClipPathOperation):
(ShapeClipPathOperation): Inheriting class for managing BasicShapes.
(WebCore::ShapeClipPathOperation::create):
(WebCore::ShapeClipPathOperation::basicShape):
(WebCore::ShapeClipPathOperation::windRule):
(WebCore::ShapeClipPathOperation::path):
(WebCore::ShapeClipPathOperation::operator==):
(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):
- rendering/RenderLayer.cpp: Use ClipPathOperation to apply clipping.
(WebCore::RenderLayer::paintLayerContents):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
- rendering/svg/SVGRenderingContext.cpp: Ditto.
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- 7:36 PM Changeset in webkit [128699] by
-
- 3 edits in trunk/Source/JavaScriptCore
Structure check hoisting fails to consider the possibility of conflicting checks on the source of the first assignment to the hoisted variable
https://bugs.webkit.org/show_bug.cgi?id=96872
Reviewed by Oliver Hunt.
This does a few related things:
- It turns off the use of ForceOSRExit for sure-to-fail CheckStructures, because I noticed that this would sometimes happen for a ForwardCheckStructure. The problem is that ForceOSRExit exits backwards, not forwards. Since the code that led to those ForceOSRExit's being inserted was written out of paranoia rather than need, I removed it. Specifically, I removed the m_isValid = false code for CheckStructure/StructureTransitionWatchpoint in AbstractState.
- If a structure check causes a structure set to go empty, we don't want a PutStructure to revive the set. It should instead be smart enough to realize that an empty set implies that the code can't execute. This was the only "bug" that the use of m_isValid = false was preventing.
- Finally, the main change: structure check hoisting looks at the source of the SetLocals on structure-check-hoistable variables and ensures that the source is not checked with a conflicting structure. This is O(n2) but it does not show up at all in performance tests.
The first two parts of this change were auxiliary bugs that were revealed by
the structure check hoister doing bad things.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 4:31 PM Changeset in webkit [128698] by
-
- 2 edits in trunk/Source/WebKit2
WinCairo build fix due to missing symbols for setImagesEnabled and setStorageBlockingPolicy
https://bugs.webkit.org/show_bug.cgi?id=96866
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-09-15
Reviewed by Kentaro Hara.
Adding missing symbol defines in the def file to fix the build break
for WinCairo
- win/WebKit2CFLite.def:
- 4:16 PM Changeset in webkit [128697] by
-
- 6 edits2 adds in trunk
REGRESSION(r127438): Google Docs to renders text too small.
<http://webkit.org/b/96554>
Reviewed by Antti Koivisto.
Source/WebCore:
Don't remove the inline StylePropertySet from ElementAttributeData in ~StyledElement.
This behavior broke sharing of ElementAttributeData between elements with inline style,
since destroying one element would effectively disable the inline style from all other
elements that shared the same attribute data.
What we actually want in ~StyledElement is to detach from any CSSOM wrapper that may
have been instantiated. Added ElementAttributeData::detachCSSOMWrapperIfNeeded for this
purpose and call that instead.
Test: fast/dom/shared-inline-style-after-node-removal.html
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::detachCSSOMWrapperIfNeeded):
(WebCore::ElementAttributeData::destroyInlineStyle):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::~StyledElement):
(WebCore::StyledElement::styleAttributeChanged):
- dom/StyledElement.h:
(StyledElement):
LayoutTests:
Add a test that an element that shared its inline style with another element works as expected
after the other element is destroyed.
- fast/dom/shared-inline-style-after-node-removal-expected.txt: Added.
- fast/dom/shared-inline-style-after-node-removal.html: Added.
- 3:59 PM Changeset in webkit [128696] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Include missing header files in the tarball
https://bugs.webkit.org/show_bug.cgi?id=96860
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-09-15
Reviewed by Kentaro Hara.
Build fix; dist two additional headers that are needed for building on
Windows platform.
- GNUmakefile.list.am:
- 3:48 PM Changeset in webkit [128695] by
-
- 2 edits in trunk/Source/WTF
llint: Implement LOCAL_LABEL_STRING for the BSD platforms.
https://bugs.webkit.org/show_bug.cgi?id=96870
Patch by Raphael Kubo da Costa <rakuco@FreeBSD.org> on 2012-09-15
Reviewed by Filip Pizlo.
- wtf/InlineASM.h: Extend the definition of LOCAL_LABEL_STRING
currently used for OS(LINUX) to the BSDs, since they also normally
use GNU as, and clang/llvm seems to parse that syntax just fine as
well.
- 3:48 PM Changeset in webkit [128694] by
-
- 3 edits in trunk/Source/WebCore
Add 8 bit handling to SpaceSplitString
https://bugs.webkit.org/show_bug.cgi?id=96823
Reviewed by Sam Weinig.
Added templated functions based on character type to handle 8 and 16 bit string data.
- dom/SpaceSplitString.cpp:
(WebCore::hasNonASCIIOrUpper):
(WebCore::SpaceSplitStringData::createVector):
- dom/SpaceSplitString.h:
(SpaceSplitStringData):
- 3:26 PM Changeset in webkit [128693] by
-
- 6 edits2 adds in trunk
REGRESSION (r125578): The monospace code path in RenderText::widthFromCache disagrees with Font::width on word spacing
https://bugs.webkit.org/show_bug.cgi?id=96869
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/text/word-space-monospace.html
This also fixes fast/css/word-spacing-characters.html
- rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache): Made the conditions for adding word spacing match the
ones in WidthIterator.
LayoutTests:
- fast/text/word-space-monospace-expected.html: Added.
- fast/text/word-space-monospace.html: Added.
- platform/mac/TestExpectations: Removed fast/css/word-spacing-characters.html.
- platform/mac/fast/css/word-space-extra-expected.png: Updated.
- platform/mac/fast/css/word-space-extra-expected.txt: Updated.
- 12:20 PM Changeset in webkit [128692] by
-
- 7 edits in trunk
REGRESSION (r125578): Word spacing not applied to newline and tab characters that are treated as spaces
https://bugs.webkit.org/show_bug.cgi?id=96865
Reviewed by Sam Weinig.
Source/WebCore:
Fixes fast/css/word-space-extra.html.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal): Changed back to apply word spacing to all characters
that are treated as spaces, except for tab characters when there are tab stops.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.
LayoutTests:
- fast/text/atsui-negative-spacing-features.html: Reverted changes made in r128691, now that
both code paths handle newlines correctly.
- fast/text/atsui-spacing-features.html: Ditto.
- platform/mac/TestExpectations: Removed fast/css/word-space-extra.html.
- 9:27 AM Changeset in webkit [128691] by
-
- 6 edits in trunk
REGRESSION (r125578): The Mac complex text code path disagrees with the fast path on word spacing
https://bugs.webkit.org/show_bug.cgi?id=96857
Reviewed by Anders Carlsson.
Source/WebCore:
Fixes the following tests when run with run-webkit-tests --complex-text:
css2.1/20110323/c541-word-sp-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm
Fixes fast/css/word-spacing-characters-complex-text.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Made the conditions for adding
word spacing match the ones in WidthIterator again.
LayoutTests:
- fast/text/atsui-negative-spacing-features.html: Removed some newlines from this test,
because now that the complex text code path matches the fast path, it too suffers from a bug
where word spacing is not added at a newline.
- fast/text/atsui-spacing-features.html: Ditto.
- platform/mac/TestExpectations: Removed fast/css/word-spacing-characters-complex-text.html.
- 8:15 AM Changeset in webkit [128690] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Provide implementation for PageClientImpl::processDidCrash()
https://bugs.webkit.org/show_bug.cgi?id=96197
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-15
Reviewed by Gyuyoung Kim.
WebKit2 EFL does not have an implementation for PageClientImpl::processDidCrash().
So when WebProcess has crashed, UI process does nothing and is left alone as it is.
This patch checks if loading was ongoing, if so, set the load progress as 1.
Then send a signal callback "webprocess,crashed" for an application to handle it.
If the application does not handle the crash event, show an Eina Log warning message
with a url at web process exit and load an error page.
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::processDidCrash):
- UIProcess/API/efl/ewk_private.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_webprocess_crashed):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- 2:02 AM Changeset in webkit [128689] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectation
- platform/chromium/TestExpectations:
Don't run an inspector test on Mac.
- 2:00 AM Changeset in webkit [128688] by
-
- 6 edits in trunk/Source
[Qt] QDoc fixes for Qt 5 documentation
https://bugs.webkit.org/show_bug.cgi?id=96796
Reviewed by Simon Hausmann.
Source/WebKit/qt:
Produce fewer warnings and a better documentation.
Having two QML modules providing a WebView component is a bit too much for poor old qdoc to
cope with (or would require a lot of painful disambiguation by hand). Since the plan is to have
QDeclarativeWebView living in the qtquick1 module, we can already take it out of the
documentation generation for now.
- declarative/qdeclarativewebview.cpp: s/qmlclass/qmltype/ out of principle
- docs/qtwebkit.qdocconf: Remove the \i alias that caused a warning. Use *.h as headers suffix, not sources.
Also remove QDeclarativeWebView from the documentation.
Source/WebKit2:
Fixup miscellaneous qdoc commands syntax.
- UIProcess/API/qt/qquickwebview.cpp:
- UIProcess/API/qt/qwebloadrequest.cpp:
- 1:55 AM Changeset in webkit [128687] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r128669.
http://trac.webkit.org/changeset/128669
https://bugs.webkit.org/show_bug.cgi?id=96637
Broke http/tests/workers/text-encoding.html on Chromium Linux (dbg)
- bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
- bindings/v8/ScopedPersistent.h:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
- bindings/v8/V8Binding.cpp:
(WebCore::perContextDataForCurrentWorld):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
- bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
- 1:23 AM Changeset in webkit [128686] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed weekend gardening. Skip 4 new failing tests to paint the bot green.
- platform/qt-5.0-wk2/Skipped:
- 1:01 AM Changeset in webkit [128685] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening. Skip 2 new tests, because
TestRunner::overridePreference() does not support the 'WebKitDisplayImagesKey' preference
- platform/qt/Skipped:
- 12:01 AM Changeset in webkit [128684] by
-
- 2 edits in trunk/Source/WTF
Roll out r128682 since it broke the Mac release builds.
