Timeline

Sep 19, 2012:

11:56 PM Changeset in webkit [129098] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unskip JS tests that are no longer crashing after r129065
​https://bugs.webkit.org/show_bug.cgi?id=97174

Unreviewed EFL gardening.

Unskip several JS tests that are no longer crashing now that
the fix has landed.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/TestExpectations:

11:55 PM Changeset in webkit [129097] by mitz@apple.com

• 15 edits in trunk/Source

Source/WebCore: WebCore part of adding a setting and API for disabling screen font substitution
​https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

• WebCore.exp.in: Added an entry for Settings::setScreenFontSubstitutionEnabled.
• css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use printer fonts if
screen font substitution is not enabled.

• page/Settings.cpp:

(WebCore::Settings::Settings): Added initializer for new m_screenFontSubstitutionEnabled
member variable. The initial value is true, matching existing behavior.
(WebCore::Settings::setScreenFontSubstitutionEnabled): Added this setter, which updated the
member variable and forces a style recalc in all pages using this Settings.

• page/Settings.h:

(Settings): Added m_screenFontSubstitutionEnabled boolean member variable.
(WebCore::Settings::screenFontSubstitutionEnabled): Added this getter.

Source/WebKit/mac: WebKit/mac part of adding a setting and API for disabling screen font substitution
​https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

• WebView/WebPreferenceKeysPrivate.h: Defined WebKitScreenFontSubstitutionEnabledKey.
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Added a default value of YES for the new preference key.
(-[WebPreferences setScreenFontSubstitutionEnabled:]): Added this setter.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference down to Settings.

Source/WebKit2: WebKit2 part of adding a setting and API for disabling screen font substitution
​https://bugs.webkit.org/show_bug.cgi?id=97168

Reviewed by Tim Horton.

• Shared/WebPreferencesStore.h:

(WebKit): Defined ScreenFontSubstitutionEnabled key with a default value of true.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetScreenFontSubstitutionEnabled): Added this setter.
(WKPreferencesGetScreenFontSubstitutionEnabled): Added this getter.

• UIProcess/API/C/WKPreferencesPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference into Settings.

11:52 PM Changeset in webkit [129096] by commit-queue@webkit.org

• 68 edits in trunk/Source

Fix unused parameter compile warnings in WebKit/WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=96742

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-19
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Fix unused parameter compile warning messages(-Wunused-parameter) in WebKit during EFL build.
WebCore's warning messages were fixed in r128570.

• WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::createWindow):
(WebCore::ChromeClientEfl::mouseDidMoveOverElement):
(WebCore::ChromeClientEfl::print):
(WebCore::ChromeClientEfl::reachedMaxAppCacheSize):
(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):

• WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::handleInputMethodKeydown):
(WebCore::EditorClientEfl::getGuessesForWord):

• WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::createFrame):
(WebCore::FrameLoaderClientEfl::createJavaAppletWidget):
(WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem):
(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
(WebCore::FrameLoaderClientEfl::setTitle):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientEfl::dispatchDidLoadResourceFromMemoryCache):
(WebCore::FrameLoaderClientEfl::setMainDocumentError):

• WebCoreSupport/FullscreenVideoControllerEfl.cpp:

(FullscreenVideoController::showHud):
(FullscreenVideoController::setVolume):
(FullscreenVideoController::setCurrentTime):

• WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::notifyWebInspectorDestroy):
(WebCore::InspectorFrontendSettingsEfl::getProperty):
(WebCore::InspectorFrontendSettingsEfl::setProperty):

• WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

• ewk/ewk_auth_soup.cpp:

(ewk_auth_soup_dialog_class_init):
(ewk_auth_soup_dialog_init):
(ewk_auth_soup_dialog_session_feature_init):
(session_authenticate):

• ewk/ewk_file_chooser.cpp:

(ewk_file_chooser_allows_directory_upload_get):

• ewk/ewk_frame.cpp:

(ewk_frame_feed_focus_out):
(ewk_frame_view_state_save):
(ewk_frame_plugin_create):

• ewk/ewk_js.cpp:

(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_view_get):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):
(ewk_js_variant_array_free):

• ewk/ewk_tiled_model.cpp:

(tile_account):
(_ewk_tile_account_allocated):
(_ewk_tile_account_freed):

• ewk/ewk_view.cpp:

(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_smart_move):
(_ewk_view_smart_contents_resize):
(_ewk_view_editor_command_string_get):
(ewk_view_popup_new):
(ewk_view_js_object_add):
(ewk_view_accelerated_compositing_object_create):
(ewk_view_accelerated_compositing_context_get):
(ewk_view_setting_web_audio_get):
(ewk_view_setting_web_audio_set):

• ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_bg_color_set):

• ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_bg_color_set):

Source/WebKit2:

Fix unused parameter compile warning messages(-Wunused-parameter) in WebKit2 during EFL build.
WebCore's warning messages were fixed in r128570.

• Shared/FontInfo.cpp:

(WebKit::FontInfo::encode):
(WebKit::FontInfo::decode):

• Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):

• Shared/SandboxExtension.h:

(WebKit::SandboxExtension::createHandleForTemporaryFile):

• Shared/ShareableSurface.cpp:

(WebKit::ShareableSurface::create):

• Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

• UIProcess/API/C/WKPage.cpp:

(WKPageGetContentsAsMHTMLData):

• UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):

• UIProcess/API/efl/BatteryProvider.cpp:

(startUpdatingCallback):
(stopUpdatingCallback):

• UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent):

• UIProcess/API/efl/VibrationProvider.cpp:

(vibrateCallback):
(cancelVibrationCallback):

• UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didCreateDestination):

• UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_smart_move):
(ewk_view_contents_size_changed):

• UIProcess/API/efl/ewk_view_find_client.cpp:

(didFindString):

• UIProcess/API/efl/ewk_view_form_client.cpp:

(willSubmitForm):

• UIProcess/API/efl/ewk_view_loader_client.cpp:

(didReceiveIntentForFrame):
(registerIntentServiceForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didChangeBackForwardList):

• UIProcess/API/efl/ewk_view_policy_client.cpp:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForResponseCallback):

• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didUpdateBackingStoreState):

• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::updateAcceleratedCompositingMode):

• UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

• UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

• UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::setHTTPPipeliningEnabled):

• UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

• UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):

• UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

• UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::standardUserAgent):
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):

• WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::didDecideDestination):
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):

• WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):

• WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):

• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyWebArchiveFilteringSubframes):

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):
(WebKit::InjectedBundle::didReceiveMessage):
(WebKit::InjectedBundle::webNotificationID):

• WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::notificationIDForTesting):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::addMessageToConsole):
(WebKit::WebChromeClient::contentsSizeChanged):
(WebKit::WebChromeClient::customHighlightRect):
(WebKit::WebChromeClient::paintCustomHighlight):
(WebKit::WebChromeClient::supportsFullScreenForElement):

• WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::downloadURL):

• WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::dragSourceActionMaskForPoint):

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
(WebKit::WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebKit::WebFrameLoaderClient::shouldStopLoadingForHistoryItem):
(WebKit::WebFrameLoaderClient::canShowMIMEType):
(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML):
(WebKit::WebFrameLoaderClient::representationExistsForURLScheme):
(WebKit::WebFrameLoaderClient::generatedMIMETypeForURLScheme):
(WebKit::WebFrameLoaderClient::createFrame):
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
(WebKit::WebFrameLoaderClient::registerForIconNotification):

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::drawRect):

• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::forceRepaintAsync):
(WebKit::DrawingArea::updateBackingStoreState):

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::mouseEvent):

• WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

• WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::forceRepaintAsync):

• WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::drawRect):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getWebArchiveOfFrame):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):

• WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendFinish):

• WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(webkitSoupRequestInputStreamReadAsync):
(webkitSoupRequestInputStreamReadFinish):

11:13 PM Changeset in webkit [129095] by yosin@chromium.org

• 2 edits in trunk/Source/WebCore

[Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
​https://bugs.webkit.org/show_bug.cgi?id=97169

Reviewed by Kent Tamura.

This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.

• html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):

11:02 PM Changeset in webkit [129094] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
​https://bugs.webkit.org/show_bug.cgi?id=97165

Reviewed by Kent Tamura.

The regression was caused because NoFocusRing class was being removed
from then main element inside resetMain().

No new tests. Covered by calendar-picker-appearance.html.

• Resources/pagepopups/calendarPicker.js:

(initialize):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.

10:52 PM Changeset in webkit [129093] by noel.gordon@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed test expectations update.

• platform/mac/TestExpectations: Change bug number reference.

10:50 PM Changeset in webkit [129092] by Csaba Osztrogonác

• 3 edits
  1 delete in trunk/Tools

Unreviewed, rolling out r129007.
​http://trac.webkit.org/changeset/129007
​https://bugs.webkit.org/show_bug.cgi?id=97172

It broke the build on the Qt bots (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-19

• qmake/config.tests/gccdepends/empty.cpp:
• qmake/config.tests/gccdepends/gccdepends.pro:
• qmake/mkspecs/features/default_pre.prf:

10:14 PM Changeset in webkit [129091] by rniwa@webkit.org

• 9 edits in trunk

run-perf-tests should record indivisual value instead of statistics
​https://bugs.webkit.org/show_bug.cgi?id=97155

Reviewed by Hajime Morita.

PerformanceTests:

Report the list of values as "values" so that run-perf-tests can parse them.

• resources/runner.js:

(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools:

Parse the list of indivisual value reported by tests and include them as "values".
We strip "values" from the output JSON when uploading it to the perf-o-matic
since it doesn't know how to parse "values" or ignore it.

• Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):
(PerfTest.parse_output): Parse and report "values".
(PageLoadingPerfTest.run): Report indivisual page loading time in "values".

• Scripts/webkitpy/performance_tests/perftest_unittest.py:

(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_and_show_results): Strip "values" from each result
until we update perf-o-matic.

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):

LayoutTests:

The expected result now contains indivisual value.

• fast/harness/perftests/runs-per-second-log-expected.txt:

9:49 PM Changeset in webkit [129090] by dgrogan@chromium.org

• 160 edits in trunk

IndexedDB: Print console warning about setVersion
​https://bugs.webkit.org/show_bug.cgi?id=96575

Reviewed by Tony Chang.

Source/WebCore:

setVersion has been out of the spec for almost a year but there are
still a lot of users.

We show the warning once per database object as an approximation for
once per page.

No new tests, but 150-something rebaselines.

• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):

• Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

LayoutTests:

• http/tests/inspector/indexeddb/database-data-expected.txt:
• http/tests/inspector/indexeddb/database-structure-expected.txt:
• http/tests/inspector/indexeddb/resources-panel-expected.txt:
• storage/indexeddb/create-and-remove-object-store-expected.txt:
• storage/indexeddb/create-object-store-options-expected.txt:
• storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
• storage/indexeddb/createObjectStore-null-name-expected.txt:
• storage/indexeddb/cursor-added-bug-expected.txt:
• storage/indexeddb/cursor-advance-expected.txt:
• storage/indexeddb/cursor-continue-dir-expected.txt:
• storage/indexeddb/cursor-continue-expected.txt:
• storage/indexeddb/cursor-continue-validity-expected.txt:
• storage/indexeddb/cursor-delete-expected.txt:
• storage/indexeddb/cursor-inconsistency-expected.txt:
• storage/indexeddb/cursor-index-delete-expected.txt:
• storage/indexeddb/cursor-key-order-expected.txt:
• storage/indexeddb/cursor-overloads-expected.txt:
• storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
• storage/indexeddb/cursor-primary-key-order-expected.txt:
• storage/indexeddb/cursor-reverse-bug-expected.txt:
• storage/indexeddb/cursor-skip-deleted-expected.txt:
• storage/indexeddb/cursor-update-expected.txt:
• storage/indexeddb/cursor-update-value-argument-required-expected.txt:
• storage/indexeddb/cursor-value-expected.txt:
• storage/indexeddb/data-corruption-expected.txt:
• storage/indexeddb/database-basics-expected.txt:
• storage/indexeddb/database-close-expected.txt:
• storage/indexeddb/database-closepending-flag-expected.txt:
• storage/indexeddb/database-deletepending-flag-expected.txt:
• storage/indexeddb/delete-closed-database-object-expected.txt:
• storage/indexeddb/delete-range-expected.txt:
• storage/indexeddb/deleteIndex-expected.txt:
• storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
• storage/indexeddb/deleteObjectStore-null-name-expected.txt:
• storage/indexeddb/deleted-objects-expected.txt:
• storage/indexeddb/deletedatabase-transaction-expected.txt:
• storage/indexeddb/duplicates-expected.txt:
• storage/indexeddb/error-causes-abort-by-default-expected.txt:
• storage/indexeddb/exception-in-event-aborts-expected.txt:
• storage/indexeddb/exceptions-expected.txt:
• storage/indexeddb/factory-deletedatabase-expected.txt:
• storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
• storage/indexeddb/get-keyrange-expected.txt:
• storage/indexeddb/index-basics-expected.txt:
• storage/indexeddb/index-basics-workers-expected.txt:
• storage/indexeddb/index-count-expected.txt:
• storage/indexeddb/index-cursor-expected.txt:
• storage/indexeddb/index-duplicate-keypaths-expected.txt:
• storage/indexeddb/index-get-key-argument-required-expected.txt:
• storage/indexeddb/index-multientry-expected.txt:
• storage/indexeddb/index-population-expected.txt:
• storage/indexeddb/index-unique-expected.txt:
• storage/indexeddb/intversion-and-setversion-expected.txt:
• storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
• storage/indexeddb/intversion-long-queue-expected.txt:
• storage/indexeddb/invalid-keys-expected.txt:
• storage/indexeddb/key-generator-expected.txt:
• storage/indexeddb/key-sort-order-across-types-expected.txt:
• storage/indexeddb/key-sort-order-date-expected.txt:
• storage/indexeddb/key-type-array-expected.txt:
• storage/indexeddb/key-type-infinity-expected.txt:
• storage/indexeddb/keypath-arrays-expected.txt:
• storage/indexeddb/keypath-basics-expected.txt:
• storage/indexeddb/keypath-edges-expected.txt:
• storage/indexeddb/keypath-fetch-key-expected.txt:
• storage/indexeddb/keypath-intrinsic-properties-expected.txt:
• storage/indexeddb/lazy-index-population-expected.txt:
• storage/indexeddb/legacy-constants-expected.txt:
• storage/indexeddb/list-ordering-expected.txt:
• storage/indexeddb/metadata-expected.txt:
• storage/indexeddb/mozilla/add-twice-failure-expected.txt:
• storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
• storage/indexeddb/mozilla/bad-keypath-expected.txt:
• storage/indexeddb/mozilla/clear-expected.txt:
• storage/indexeddb/mozilla/create-index-unique-expected.txt:
• storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
• storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
• storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
• storage/indexeddb/mozilla/cursor-mutation-expected.txt:
• storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
• storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
• storage/indexeddb/mozilla/cursors-expected.txt:
• storage/indexeddb/mozilla/delete-result-expected.txt:
• storage/indexeddb/mozilla/event-source-expected.txt:
• storage/indexeddb/mozilla/global-data-expected.txt:
• storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
• storage/indexeddb/mozilla/indexes-expected.txt:
• storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
• storage/indexeddb/mozilla/key-requirements-expected.txt:
• storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
• storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
• storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
• storage/indexeddb/mozilla/object-cursors-expected.txt:
• storage/indexeddb/mozilla/object-identity-expected.txt:
• storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
• storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
• storage/indexeddb/mozilla/objectstorenames-expected.txt:
• storage/indexeddb/mozilla/odd-result-order-expected.txt:
• storage/indexeddb/mozilla/put-get-values-expected.txt:
• storage/indexeddb/mozilla/readonly-transactions-expected.txt:
• storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
• storage/indexeddb/mozilla/readyState-expected.txt:
• storage/indexeddb/mozilla/remove-index-expected.txt:
• storage/indexeddb/mozilla/remove-objectstore-expected.txt:
• storage/indexeddb/mozilla/versionchange-abort-expected.txt:
• storage/indexeddb/mozilla/versionchange-expected.txt:
• storage/indexeddb/mutating-cursor-expected.txt:
• storage/indexeddb/noblobs-expected.txt:
• storage/indexeddb/objectStore-required-arguments-expected.txt:
• storage/indexeddb/objectstore-autoincrement-expected.txt:
• storage/indexeddb/objectstore-basics-expected.txt:
• storage/indexeddb/objectstore-basics-workers-expected.txt:
• storage/indexeddb/objectstore-clear-expected.txt:
• storage/indexeddb/objectstore-count-expected.txt:
• storage/indexeddb/objectstore-cursor-expected.txt:
• storage/indexeddb/objectstore-removeobjectstore-expected.txt:
• storage/indexeddb/odd-strings-expected.txt:
• storage/indexeddb/open-close-version-expected.txt:
• storage/indexeddb/open-cursor-expected.txt:
• storage/indexeddb/open-during-transaction-expected.txt:
• storage/indexeddb/opencursor-key-expected.txt:
• storage/indexeddb/pending-activity-expected.txt:
• storage/indexeddb/pending-activity-workers-expected.txt:
• storage/indexeddb/pending-version-change-on-exit-expected.txt:
• storage/indexeddb/persistence-expected.txt:
• storage/indexeddb/prefetch-bugfix-108071-expected.txt:
• storage/indexeddb/queued-commands-expected.txt:
• storage/indexeddb/readonly-expected.txt:
• storage/indexeddb/readonly-properties-expected.txt:
• storage/indexeddb/request-continue-abort-expected.txt:
• storage/indexeddb/request-event-propagation-expected.txt:
• storage/indexeddb/setVersion-null-expected.txt:
• storage/indexeddb/set_version_blocked-expected.txt:
• storage/indexeddb/set_version_queue-expected.txt:
• storage/indexeddb/structured-clone-expected.txt:
• storage/indexeddb/three-setversion-calls-expected.txt:
• storage/indexeddb/transaction-abort-expected.txt:
• storage/indexeddb/transaction-active-flag-expected.txt:
• storage/indexeddb/transaction-after-close-expected.txt:
• storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
• storage/indexeddb/transaction-basics-expected.txt:
• storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
• storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
• storage/indexeddb/transaction-complete-workers-expected.txt:
• storage/indexeddb/transaction-crash-on-abort-expected.txt:
• storage/indexeddb/transaction-error-expected.txt:
• storage/indexeddb/transaction-event-propagation-expected.txt:
• storage/indexeddb/transaction-read-only-expected.txt:
• storage/indexeddb/transaction-rollback-expected.txt:
• storage/indexeddb/transaction-storeNames-required-expected.txt:
• storage/indexeddb/tutorial-expected.txt:
• storage/indexeddb/two-version-changes-expected.txt:
• storage/indexeddb/value-undefined-expected.txt:
• storage/indexeddb/values-odd-types-expected.txt:
• storage/indexeddb/version-change-abort-expected.txt:
• storage/indexeddb/version-change-exclusive-expected.txt:
• storage/indexeddb/versionchangerequest-activedomobject-expected.txt:

9:44 PM Changeset in webkit [129089] by ggaren@apple.com

• 8 edits in trunk/Source

OSR exit sometimes neglects to create the arguments object
​https://bugs.webkit.org/show_bug.cgi?id=97162

Reviewed by Filip Pizlo.

../JavaScriptCore:

No performance change.

I don't know of any case where this is a real problem in TOT, but it
will become a problem if we start compiling eval, with, or catch, and/or
sometimes stop doing arguments optimizations in the bytecode.

• dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run): Account for a
CreateArguments that has transformed into PhantomArguments. We used to
clear our reference to the CreateArguments node, but now we hold onto it,
so we need to account for it transforming.

Don't replace a SetLocal(CreateArguments) with a SetLocal(JSValue())
because that doesn't leave enough information behind for OSR exit to do
the right thing. Instead, maintain our reference to CreateArguments, and
rely on CreateArguments transforming into PhantomArguments after
optimization. SetLocal(PhantomArguments) is efficient, and it's a marker
for OSR exit to create the arguments object.

Don't ASSERT that all PhantomArguments are unreferenced because we now
leave them in the graph as SetLocal(PhantomArguments), and that's harmless.

• dfg/DFGArgumentsSimplificationPhase.h:

(NullableHashTraits):
(JSC::DFG::NullableHashTraits::emptyValue): Export our special hash table
for inline call frames so the OSR exit compiler can use it.

• dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit): Don't load the 'arguments'
register to decide if we need to create the arguments object. Optimization
may have eliminated the initializing store to this register, in which
case we'll load garbage. Instead, use the global knowledge that all call
frames that optimized out 'arguments' now need to create it, and use a hash
table to make sure we do so only once per call frame.

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): SetLocal(PhantomArguments) is unique
because we haven't just changed a value's format or elided a load or store;
instead, we've replaced an object with JSValue(). We could try to account
for this in a general way, but for now it's a special-case optimization,
so we give it a specific OSR hint instead.

../WTF:

• wtf/HashTraits.h:

(NullableHashTraits):
(WTF::NullableHashTraits::emptyValue):
(WTF):

9:27 PM Changeset in webkit [129088] by noel.gordon@gmail.com

• 2 edits
  5 adds in trunk/LayoutTests

Add partial load test for PNG images with no alpha
​https://bugs.webkit.org/show_bug.cgi?id=96064

Reviewed by Simon Fraser.

Partial load test for a PNG image with no alpha: receive a partial number of image
bytes and stall forever. The partial image should be decoded and drawn and the green
<img> background should be visible.

• fast/images/resources/lenna.png: Added: this PNG image has no alpha.
• http/tests/images/png-partial-load-no-alpha-expected.png: Added.
• http/tests/images/png-partial-load-no-alpha-expected.txt: Added.
• http/tests/images/png-partial-load-no-alpha.html: Added.
• platform/chromium/http/tests/images/png-partial-load-no-alpha-expected.png: Added.
• platform/mac/TestExpectations: Add an IMAGE failure for the mac port.

7:34 PM Changeset in webkit [129087] by commit-queue@webkit.org

• 7 edits in trunk/Source

[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
​https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-09-19
Reviewed by Rob Buis.

Source/WebCore:

This patch enable reading credentials from the persistent credential storage
when it is not private browsing mode and there is not a credential in the RAM
for the requested resource.

Since we don't load persistent stored credentials into RAM at the starting time,
even we have saved the credentials at the last browsing, after restarting the browser,
it will still challenge for credentials for the requesting resources.

No new tests, it uses the original authentication tests. There is no way to
clear all credentials or restarting browsers to test this feature.

• platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::getProtectionSpace):
(WebCore):

• platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

• platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

Source/WebKit/blackberry:

Make the FrameLoaderClient use credential storage according to the macro
BLACKBERRY_CREDENTIAL_PERSIST

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
(WebCore):

• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

7:07 PM Changeset in webkit [129086] by shinyak@chromium.org

• 9 edits in trunk/Source/WebCore

[Refactoring] ButtonInputType of <input> element should have innerElement to make <input> AuthorShadowDOM-ready
​https://bugs.webkit.org/show_bug.cgi?id=95939

Reviewed by Dimitri Glazkov.

We had 2 ways to show text in RenderButton. One is to use RenderButton::setText() and the other is to add renderer
as a child of RenderButton. <input type="button"> used the former one, and <button> used the latter one.
The former makes RenderButton a bit messy, and also prevents from making <input> AuthorShadowDOM ready.

So we remove RenderButton::setText() and refactor <input type="button"> to use a Shadow DOM to show text.

Since the text in <input type="button"> should create RenderTextFragment, we introduce TextForButtonInputType
class. RenderText will allow us to select the inner text of <input>, but it should not.

No new tests, existing tests should cover the change.

• html/BaseButtonInputType.cpp:

(TextForButtonInputType): Special Text node which creates RenderTextFragment.
(WebCore):
(WebCore::TextForButtonInputType::create):
(WebCore::TextForButtonInputType::TextForButtonInputType):
(WebCore::TextForButtonInputType::createRenderer):
(WebCore::BaseButtonInputType::BaseButtonInputType):
(WebCore::BaseButtonInputType::createShadowSubtree):
(WebCore::BaseButtonInputType::destroyShadowSubtree):
(WebCore::BaseButtonInputType::valueAttributeChanged): When a button value is changed, we reflect the value to
the text node in ShadowDOM.

• html/BaseButtonInputType.h:

(BaseButtonInputType):

• html/FileInputType.cpp:

(WebCore::UploadButtonElement::create): Creates Shadow DOM subtree.
(WebCore::UploadButtonElement::createForMultiple): Creates Shadow DOM subtree.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

• html/InputType.cpp:

(WebCore::InputType::valueAttributeChanged):
(WebCore):

• html/InputType.h:

(InputType):

• rendering/RenderButton.cpp:

(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange): Removed unnecessary text related code.

• rendering/RenderButton.h:

(RenderButton):

7:05 PM Changeset in webkit [129085] by abarth@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Remove webkitPostMessage
​https://bugs.webkit.org/show_bug.cgi?id=96577

Reviewed by Ojan Vafai.

Actually disable webkitPostMessage. See
​http://trac.webkit.org/changeset/128658 for more information.

• features.gypi:

7:05 PM Changeset in webkit [129084] by jason.liu@torchmobile.com.cn

• 2 edits in trunk/Source/WebCore

[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
​https://bugs.webkit.org/show_bug.cgi?id=96994

Reviewed by Rob Buis.

We should remove the wrong credentials before calling sendRequestWithCredentials again.
#PR 200226
Reviewed internally by Jonathan Dong.

No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived):

6:52 PM Changeset in webkit [129083] by dpranke@chromium.org

• 2 edits in trunk/Tools

Fix regex groups for bug matching in flakiness dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(htmlForBugs):

6:41 PM Changeset in webkit [129082] by abarth@webkit.org

• 6 edits in trunk/Source/WebCore

Remove Blob.webkitSlice
​https://bugs.webkit.org/show_bug.cgi?id=96715

Reviewed by Darin Fisher.

Based on these usage metrics, it appears that it is safe to remove
Blob.webkitSlice. Folks that were previously calling webkitSlice should
just call slice instead. They do the same thing.

Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
Ratio of Blob.webkitSlice calls to Document creation: 0.0053%

• fileapi/Blob.cpp:

(WebCore::Blob::slice):

• fileapi/Blob.h:

(Blob):

• fileapi/Blob.idl:
• fileapi/File.h:

(File):

• inspector/front-end/FileUtils.js:

(WebInspector.ChunkedFileReader.prototype._loadChunk):

6:34 PM Changeset in webkit [129081] by dpranke@chromium.org

• 2 edits in trunk/Tools

nrwt: print unexpected results using new TestExpectations syntax
​https://bugs.webkit.org/show_bug.cgi?id=97159

Unreviewed, build fix.

Change new-run-webkit-tests to print out failures using the new
syntax when there are unexpected results, e.g.:

52 tests ran as expected, 19 didn't:

Regressions: Unexpected failures : (2)

failures/flaky/text.html [ Failure ]
failures/unexpected/text-image-checksum.html [ Failure ]

and so forth

• Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._print_unexpected_results):

6:22 PM TestExpectations edited by dpranke@chromium.org

note that the new syntax is now being used. (diff)

6:13 PM Changeset in webkit [129080] by dpranke@chromium.org

• 3 edits in trunk/Tools

update flakiness dashboard after cutover to new test expectations syntax
​https://bugs.webkit.org/show_bug.cgi?id=97152

Unreviewed, build fix.

Handle (??) the new Bug notations as well. Hopefully we don't
still need the old ones.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(filterBugs):
(htmlForBugs):

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

5:59 PM Changeset in webkit [129079] by dpranke@chromium.org

• 3 edits in trunk/Tools

update flakiness dashboard after cutover to new test expectations syntax
​https://bugs.webkit.org/show_bug.cgi?id=97152

Reviewed by Ryosuke Niwa.

This change clones the TestExpectation parsing state machine
from python into javascript.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(parsedExpectations.lines.forEach):
(parsedExpectations):

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

5:58 PM Changeset in webkit [129078] by jchaffraix@webkit.org

• 11 edits in trunk/Source/WebCore

The collapsing border code needs direction-aware border getters
​https://bugs.webkit.org/show_bug.cgi?id=96710

Reviewed by Ojan Vafai.

This refactoring is needed to extend our collapsing border support for mixed directionality
at the table cell level (we currently wrongly ignore any direction below the row-group). For
now, the new helpers are dumb and return exactly the old result but they will be made
direction-aware in a follow-up change.

Refactoring covered by existing tests.

• rendering/RenderBox.h:

(WebCore::RenderBox::hasSameDirectionAs):
Added this helper function. For now, it's only used to compare against
the table direction but we will reuse it to compare the current cell
direction against the other table parts.

• rendering/RenderTableCell.h:

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Transitioned those 2 functions to using the new direction-aware functions.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):

• rendering/RenderTableCell.h:

(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):

• rendering/RenderTableSection.h:

(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated those call sites to use RenderBox::hasSameDirectionAs.

• rendering/RenderTableCell.h:

(WebCore::RenderTableCell::borderAdjoiningNextCell):
(WebCore::RenderTableCell::borderAdjoiningPreviousCell):

• rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::borderAdjoiningCellStartBorder):
(WebCore::RenderTableCol::borderAdjoiningCellEndBorder):
(WebCore::RenderTableCol::borderAdjoiningCellBefore):
(WebCore::RenderTableCol::borderAdjoiningCellAfter):

• rendering/RenderTableCol.h:
• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):

• rendering/RenderTableRow.h:

(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
New direction-aware functions. Added some ASSERT to ensure
we don't call them with the wrong parameters.

5:41 PM Changeset in webkit [129077] by haraken@chromium.org

• 2 edits in trunk/Source/WebCore

[V8] ScriptController::compileAndRunScript() can crash
​https://bugs.webkit.org/show_bug.cgi?id=96567

Reviewed by Adam Barth.

See chromium bug: ​http://code.google.com/p/chromium/issues/detail?id=146776

The root cause is that v8::PreCompile() can return 0 when the stack of
V8's parser overflows (c.f. ​http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/src/parser.cc&exact_package=chromium&q=kPreParseStackOverflow&type=cs&l=6021).

This patch adds the 0 check to the caller side. Given that precompileScript()
is just trying to speculatively precompile a script, it's OK to give up
precompiling for such edge cases.

Manually tested with the html generated by the following shell script:

echo '<script language="JavaScript" type="text/javascript" src="asan-crash.js"></script>' > asan-crash.html
echo 'if(wURLF.search("")>=0) {}' > asan-crash.js
for i in seq 14830
do

echo 'else if(wURLF.search("")>=0) {}' >> asan-crash.js

done

I didn't add the test because '14380' depends on an environment
and because we don't want to add a huge html test.

• bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::precompileScript):

5:12 PM Changeset in webkit [129076] by jsbell@chromium.org

• 3 edits in trunk/Source/WebCore

IndexedDB: Pending call cleanup
​https://bugs.webkit.org/show_bug.cgi?id=96952

Reviewed by Tony Chang.

Replace RefPtr usage with OwnPtr for PendingXXXCalls (since they're never referenced twice)
and replace queue of "second half open" calls with a single item.

No new tests - no functional changes.

• Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::close):

• Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

5:06 PM Changeset in webkit [129075] by Simon Fraser

• 18 edits in trunk/LayoutTests

Attempt to unskip some tests by removing them from the Skipped list.

Added new baselines for those that need them.

• platform/mac/Skipped:
• platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
• platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
• platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt:
• platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
• platform/mac/fast/layers/video-layer-expected.txt:
• platform/mac/fast/table/cell-pref-width-invalidation-expected.txt:
• platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
• platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
• platform/mac/media/video-empty-source-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2123-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2509-expected.txt:
• platform/mac/tables/mozilla/bugs/bug34176-expected.txt:
• platform/mac/tables/mozilla/bugs/bug44505-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

5:00 PM Changeset in webkit [129074] by bashi@chromium.org

• 3 edits in trunk/Source/WebCore

[Chromium] Improve glyph positioning of HarfBuzzShaper
​https://bugs.webkit.org/show_bug.cgi?id=97093

Reviewed by Tony Chang.

For proper positioning, HarfBuzzShaper requires the positions(offsets and advance)
of the previous glyph. This mean we need to shape all HarfBuzzRuns before glyph positioning.
Collect and shape HarfBuzzRuns, then set positions of glyphs.

No new tests. Tests that uses spacing for complex text (e.g. fast/text/atsui-negative-spacing-features.html)
should close in the expectations. (not the identical, maybe there are subtle differences between
harfbuzz old and harfbuzz ng)

• platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Allocate m_offsets.
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions): Renamed and set offset too.
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::shape): Call fillGlyphBuffer() if we need to fill glyphBuffer.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Removed glyph positioning code.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Ditto.
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun): Added.
(WebCore):
(WebCore::HarfBuzzShaper::fillGlyphBuffer): Added.

• platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes): Added.
(HarfBuzzShaper):

4:59 PM Changeset in webkit [129073] by danakj@chromium.org

• 2 edits in trunk/Tools

Add ​backer@chromium.org as contributor
​https://bugs.webkit.org/show_bug.cgi?id=97150

• Scripts/webkitpy/common/config/committers.py:

4:58 PM Changeset in webkit [129072] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html

Unreviewed, exepectations change.

• platform/chromium/TestExpectations:

4:55 PM Changeset in webkit [129071] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

Fix v8 bug urls after syntax conversion

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

4:53 PM Changeset in webkit [129070] by simonjam@chromium.org

• 4 edits
  3 adds in trunk

[Chromium] Disable resource load scheduling
​https://bugs.webkit.org/show_bug.cgi?id=97131

Reviewed by Nate Chapin.

Source/WebCore:

We'll use Chrome's network stack for scheduling instead.

No new tests.

• loader/ResourceLoadScheduler.cpp:
• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::preload):

LayoutTests:

The preload scanner loads resources sooner and these tests are affected.

• platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
• platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.

4:49 PM Changeset in webkit [129069] by dpranke@chromium.org

• 9 edits in trunk

fix MISSING after TestExpectations conversion
​https://bugs.webkit.org/show_bug.cgi?id=97148

Tools:

Unreviewed, expectations change / build fix.

• Scripts/convert-test-expectations:
• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):

LayoutTests:

Unreviewed, expectations change.

• platform/chromium/TestExpectations:
• platform/efl/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt-4.8/TestExpectations:
• platform/qt-mac/TestExpectations:

4:37 PM Changeset in webkit [129068] by mitz@apple.com

• 3 edits
  2 adds in trunk

When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths
​https://bugs.webkit.org/show_bug.cgi?id=97146

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/text/word-space-with-kerning.html

• rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): When kerning is enabled, words are
measured with their trailing space, if there is one, then the width of a space is subtracted.
Changed that width, stored in the local variable wordTrailingSpaceWidth, to include the
word spacing, since it is included in the result of widthFromCache().

LayoutTests:

• fast/text/word-space-with-kerning-expected.html: Added.
• fast/text/word-space-with-kerning.html: Added.

4:29 PM Changeset in webkit [129067] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

Fix lines missed (??) in mac-wk2/TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=97143

Unreviewed, expectations change.

• platform/mac-wk2/TestExpectations:

4:27 PM Changeset in webkit [129066] by jsbell@chromium.org

• 13 edits in trunk/Source

IndexedDB: Remove "current transaction" concept from backing store
​https://bugs.webkit.org/show_bug.cgi?id=96663

Reviewed by Tony Chang.

Source/WebCore:

IndexedDB should allow multiple transactions to run in parallel within and
across databases within an origin. As an initial step to enabling this, the
backing store should not hold a "current transaction" - instead, operations
should be done relative to a transaction managed by the database.

No new tests - no functional changes.

• Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

• Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):

• Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

• Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

• Modules/indexeddb/IDBIndexBackendImpl.h:

(IDBIndexBackendImpl):

• Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::Transaction::Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::begin):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):

• Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransaction):
(Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransactionFrom):

• Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):

• Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Update fake class with new method signatures.

• tests/IDBFakeBackingStore.h:

4:27 PM Changeset in webkit [129065] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r128802): It made some JS tests crash
​https://bugs.webkit.org/show_bug.cgi?id=97001

Reviewed by Mark Hahnenberg.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

4:25 PM Changeset in webkit [129064] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

convert chromium android TestExpectations to the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=97145

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

• platform/chromium-android/TestExpectations:

4:23 PM Changeset in webkit [129063] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

nrwt: convert chromium TestExpectations to the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=97139

Reviewed by Ryosuke Niwa.

Actually land the file supposedly landed below :).

• platform/chromium/TestExpectations:

4:19 PM Changeset in webkit [129062] by dpranke@chromium.org

• 4 edits in trunk/LayoutTests

convert apple win TestExpectations files to the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=97144

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

• platform/win-wk2/TestExpectations:
• platform/win-xp/TestExpectations:
• platform/win/TestExpectations:

4:17 PM Changeset in webkit [129061] by dpranke@chromium.org

• 5 edits in trunk/LayoutTests

convert apple mac TestExpectations files to the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=97143

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

• platform/mac-lion/TestExpectations:
• platform/mac-snowleopard/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

4:15 PM Changeset in webkit [129060] by dpranke@chromium.org

• 4 edits in trunk/LayoutTests

convert Efl TestExpectations to the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=97142

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

• platform/efl-wk1/TestExpectations:
• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:

4:11 PM Changeset in webkit [129059] by dpranke@chromium.org

• 3 edits in trunk/LayoutTests

convert Gtk TestExpectations files to the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=97141

Unreviewed, expectations change.

Files converted with Tools/Scripts/convert-test-expectations.

• platform/gtk-wk2/TestExpectations:
• platform/gtk/TestExpectations:

4:02 PM Changeset in webkit [129058] by dpranke@chromium.org

• 6 edits in trunk/LayoutTests

nrwt: convert Qt TestExpectations to the new format
​https://bugs.webkit.org/show_bug.cgi?id=97140

Unreviewed, expectations change.

Files were converted using Tools/Scripts/convert-test-expectations.

• platform/qt-4.8/TestExpectations:
• platform/qt-5.0-wk2/TestExpectations:
• platform/qt-arm/TestExpectations:
• platform/qt-mac/TestExpectations:
• platform/qt/TestExpectations:

4:00 PM Changeset in webkit [129057] by dpranke@chromium.org

• 2 edits
  1 add in trunk

nrwt: convert chromium TestExpectations to the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=97139

Tools:

Reviewed by Ryosuke Niwa.

Add in a file temporarily that does the conversion of
test expectations formats

• Tools/Scripts/convert-test-expectations: Added.

LayoutTests:

Reviewed by Ryosuke Niwa.

This does a wholesale change of the file from

BUGS MODIFIERS : test = EXPECTATIONS

to

Bugs [ Modifiers] test [ Expectations ]

as per the new syntax.

• platform/chromium/TestExpectations:

3:53 PM Changeset in webkit [129056] by jsbell@chromium.org

• 3 edits in trunk/LayoutTests

Unreviewed - remove debugging code from a pair of tests.

During development these tests had their own timers to terminate early
rather than timing out, so partial script output could be seen. Removing,
as it could cause the tests to flake under load.

• storage/indexeddb/lazy-index-population.html:
• storage/indexeddb/resources/cursor-finished.js:

3:48 PM Changeset in webkit [129055] by rniwa@webkit.org

• 3 edits in trunk/Tools

REGRESSION: run-perf-tests no longer reports the total test time
​https://bugs.webkit.org/show_bug.cgi?id=97138

Reviewed by Tony Chang.

Report the finished time as a info-level log as opposed to a debug level log.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._run_single_test):

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_memory_test):
(_test_run_with_json_output):

3:43 PM Changeset in webkit [129054] by commit-queue@webkit.org

• 10 edits in trunk

[chromium] Store the contents scale factor in PlatformContextSkia on initialization
​https://bugs.webkit.org/show_bug.cgi?id=96137

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-09-19
Reviewed by Stephen White.

Source/WebCore:

When the compositor creates a PlatformContextSkia, the scale on |canvas| will
be equal to the content scale factor (which, without pinch-to-zoom, will be
the same as the device scale factor). Set this value as a member on PlatformContextSkia,
which will be used to correctly render glyphs when hinting is used and the device
scale factor is not 1.

Tests: added two new unit tests.

• platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

• platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):

• platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):
(WebCore::PlatformContextSkia::setHintingScaleFactor):
(WebCore::PlatformContextSkia::hintingScaleFactor):

Source/WebKit/chromium:

Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used
for the skia patch here: ​https://codereview.appspot.com/6506099/.
Also added two new unit tests.

• features.gypi:
• tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:

(WebCore):
(WebCore::HintingScaleCallback::HintingScaleCallback):
(HintingScaleCallback):
(WebCore::HintingScaleCallback::operator()):
(WebCore::TEST_F):

• tests/PlatformContextSkiaTest.cpp:

(WebCore):
(WebCore::TEST):

LayoutTests:

These tests will fail due to a font hinting/rasterization issue with
chromium DRT pixel tests having a page/device scale factor of 2.
See crbug.com/150682.

• platform/chromium/TestExpectations:

3:36 PM Changeset in webkit [129053] by fpizlo@apple.com

• 4 edits in trunk/Source/JavaScriptCore

DFG should not assume that a ByVal access is generic just because it was unprofiled
​https://bugs.webkit.org/show_bug.cgi?id=97088

Reviewed by Geoffrey Garen.

We were not disambiguating between "Undecided" in the sense that the array profile
has no useful information versus "Undecided" in the sense that the array profile
knows that the access has not executed. That's an important distinction, since
the former form of "Undecided" means that we should consult value profiling, while
the latter means that we should force exit unless the value profiling indicates
that the access must be generic (base is not cell or property is not int).

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

• dfg/DFGArrayMode.h:

(JSC::DFG::canCSEStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):

3:36 PM Changeset in webkit [129052] by dpranke@chromium.org

• 7 edits in trunk/Tools

Support new TestExpectations format alongside old one
​https://bugs.webkit.org/show_bug.cgi?id=96588

Reviewed by Ojan Vafai.

This patch adds support for actually reading in lines formatted
in the new style, and when we re-serialize/write out the file,
all lines will be written in the new style. Note that reading in
the old style is still supported, and no updates are being made
to the actual TestExpectations files as part of this change.

This change updates most but not all of the unit tests to use
the new syntax. I will update the rest when (or before where
possible) I drop support for the old format.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser._tokenize_line):
(TestExpectationParser._tokenize_line_using_new_format):
(TestExpectationLine.to_string):
(TestExpectationLine._format_line):
(TestExpectations):

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_warning):
(SkippedTests.test_skipped_entry_dont_exist):
(NewExpectationSyntaxTests.test_warnings):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(RebaseliningTest.test_no_get_rebaselining_failures):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationSerializationTests.test_unparsed_to_string):
(TestExpectationSerializationTests.test_unparsed_list_to_string):
(TestExpectationSerializationTests.test_parsed_to_string):
(TestExpectationSerializationTests.test_format_line):
(TestExpectationSerializationTests.test_string_roundtrip):
(TestExpectationSerializationTests.test_list_roundtrip):
(TestExpectationSerializationTests.test_reconstitute_only_these):
(TestExpectationSerializationTests.test_string_whitespace_stripping):

• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(LintTest.test_lint_test_fileserrors):

• Scripts/webkitpy/tool/commands/queries_unittest.py:

(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):

• Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations.execute):

• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_expectations_noop):
(test_overrides_are_included_correctly):

3:29 PM Changeset in webkit [129051] by dpranke@chromium.org

• 3 edits in trunk/Tools

implement first part of support for the new TestExpectations syntax
​https://bugs.webkit.org/show_bug.cgi?id=96569

Reviewed by Ryosuke Niwa.

This patch implements support for parsing a line of the new
format for the TestExpectations file and converting it back into
the old format for compatibility. This routine is not yet used
by anything.

The new format is documented at:

​http://trac.webkit.org/wiki/TestExpectations

but, in short:

[bugs] [ "modifiers" ] test_name [ "expectations" ]

• Comments are indicated with "#" instead of ""
• If no expectations are specified we default to Skip for compatibility with the Skipped files (these two changes make Skipped files a subset of TestExpectations files)

• All of the tokens are now CamelCase instead of ALLCAPS.
• FAIL -> Failure
• IMAGE -> ImageOnlyFailure
• WONTFIX -> WontFix
• modifiers refer to just the platforms and configurations (release/debug) that the line applies to.
• WontFix, Rebaseline, Slow, and Skip move to the right-hand side as expectations
• expectations will typically be written out in lexicographic order
• We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke) instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser._tokenize_line_using_new_format):

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(NewExpectationSyntaxTests):
(NewExpectationSyntaxTests.assert_exp):
(NewExpectationSyntaxTests.test_bare_name):
(NewExpectationSyntaxTests.test_bare_name_and_bugs):
(NewExpectationSyntaxTests.test_comments):
(NewExpectationSyntaxTests.test_config_modifiers):
(NewExpectationSyntaxTests.test_unknown_config):
(NewExpectationSyntaxTests.test_unknown_expectation):
(NewExpectationSyntaxTests.test_skip):
(NewExpectationSyntaxTests.test_slow):
(NewExpectationSyntaxTests.test_wontfix):
(NewExpectationSyntaxTests.test_blank_line):
(NewExpectationSyntaxTests.test_warnings):

3:29 PM Changeset in webkit [129050] by bashi@chromium.org

• 2 edits in trunk/Source/WebCore

[Chromium] HarfBuzzShaper should take into account combining characters
​https://bugs.webkit.org/show_bug.cgi?id=97069

Reviewed by Tony Chang.

When dividing a text run into HarfBuzzRuns, try to find suitable SimpleFontData for
combining character sequence if there are one or more mark characters are followed.
If there is no combined glyphs in the font, use fallback font for mark characters.

No new tests.
In platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html,
U+0947 (devanagari vowel sign e) should be displayed.
In fast/text/wide-zero-width-space.html, &eacute; and e&#0301; should look identical.

• platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore):
(WebCore::fontDataForCombiningCharacterSequence): Added.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): See above description.

3:23 PM Changeset in webkit [129049] by psolanki@apple.com

• 2 edits in trunk/Source/WebKit2

Warning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=97137

Reviewed by Benjamin Poulain.

m_size is only used when WEB_PROCESS_SANDBOX is enabled, so move its declaration inside
#if ENABLE(WEB_PROCESS_SANDBOX).

• Shared/SandboxExtension.h:

(HandleArray):

3:01 PM Changeset in webkit [129048] by dgrogan@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Disable some failing IDB tests
​https://bugs.webkit.org/show_bug.cgi?id=97135

Reviewed by Nate Chapin.

They were broken in r129037.

• tests/IDBDatabaseBackendTest.cpp:

2:51 PM Changeset in webkit [129047] by dpranke@chromium.org

• 28 edits in trunk

nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
​https://bugs.webkit.org/show_bug.cgi?id=96845

Reviewed by Ojan Vafai.

In preparation for the new TestExpectations syntax, we replace
all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
make switching to the new syntax lossless (i.e., we lose
information now, not then).

Tools:

Note that we can still parse in results.json files that have the
old data for backwards compatibility.

• Scripts/webkitpy/common/net/resultsjsonparser.py:

(JSONTestResult._failure_types_from_actual_result):

• Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:

(ResultsJSONParserTest):
(test_basic):

• Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_summarized_results_wontfix):

• Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator):

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):
(TestExpectations.remove_pixel_failures):
(TestExpectations.has_pixel_failures):
(TestExpectations.suffixes_for_expectations):
(TestExpectations.get_rebaselining_failures):
(TestExpectations.remove_configuration_from_test):

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(assert_bad_expectations):
(BasicTests):
(BasicTests.test_basic):
(MiscTests):
(MiscTests.test_multiple_results):
(MiscTests.test_result_was_expected):
(MiscTests.test_remove_pixel_failures):
(MiscTests.test_suffixes_for_expectations):
(test_get_expectations_string):
(test_parse_warning):
(test_error_on_different_platform):
(test_error_on_different_build_type):
(test_overrides):
(test_overridesdirectory):
(test_overridesduplicate):
(test_pixel_tests_flag):
(test_more_specific_override_resets_skip):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(SemanticTests.test_rebaseline):
(test_missing_file):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(TestExpectationSerializationTests.test_serialize_parsed_expectations):

• Scripts/webkitpy/layout_tests/models/test_failures.py:

(determine_result_type):

• Scripts/webkitpy/layout_tests/port/port_testcase.py:

(test_test_expectations):

• Scripts/webkitpy/layout_tests/port/test.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_missing_and_unexpected_results):
(MainTest.test_retrying_and_flaky_tests):

• Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_valid_expectations):

• Scripts/webkitpy/tool/commands/queries_unittest.py:

(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
(PrintExpectationsTest.test_csv):

• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_does_not_include_overrides):
(test_overrides_are_included_correctly):

LayoutTests:

• platform/chromium-android/TestExpectations:
• platform/chromium/TestExpectations:
• platform/efl-wk1/TestExpectations:
• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt-4.8/TestExpectations:
• platform/qt-arm/TestExpectations:
• platform/qt-mac/TestExpectations:
• platform/qt/TestExpectations:

2:47 PM Changeset in webkit [129046] by tony@chromium.org

• 3 edits in trunk/Source/WebCore

Remove RenderIFrame::updateLogicalHeight and RenderIFrame::updateLogicalWidth
​https://bugs.webkit.org/show_bug.cgi?id=97049

Reviewed by Ojan Vafai.

This is an incremental step in making updateLogicalHeight non-virtual so it's
possible to call computeLogicalHeight on any RenderBox and get the right
version of the function.

The code in RenderIFrame::layout was calling flattenFrame(), which would
query it's bounding box size. Since we hadn't done a layout yet, the size
is unknown. The fix is to only call flattenFrame() after calling
updateLogicalWidth and updateLogicalHeight. We can then fixup the size of
the iframe.

No new tests, existing tests in fast/frames/flattening should continue to pass.

• rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::layout):

• rendering/RenderIFrame.h:

(RenderIFrame):

2:43 PM Changeset in webkit [129045] by fpizlo@apple.com

• 16 edits in trunk/Source/JavaScriptCore

DFG should not emit PutByVal hole case unless it has to
​https://bugs.webkit.org/show_bug.cgi?id=97080

Reviewed by Geoffrey Garen.

This causes us to generate less code for typical PutByVal's. But if profiling tells us
that the hole case is being hit, we generate the same code as we would have generated
before. This seems like a slight speed-up across the board.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::store8):
(MacroAssemblerARMv7):

• assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):
(JSC::MacroAssemblerX86::store8):

• assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::store8):

• assembler/X86Assembler.h:

(X86Assembler):
(JSC::X86Assembler::movb_i8m):

• bytecode/ArrayProfile.h:

(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::addressOfMayStoreToHole):
(JSC::ArrayProfile::mayStoreToHole):
(ArrayProfile):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::fromObserved):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

• dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::mayStoreToHole):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• jit/JIT.h:

(JIT):

• jit/JITInlineMethods.h:

(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

2:35 PM Changeset in webkit [129044] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] After zooming into an input field, zoom out when focus is lost.
​https://bugs.webkit.org/show_bug.cgi?id=97128

Reviewed by Rob Buis.

When the page has automatically zoomed in for input
focus, unzoom it when input focus is lost or keyboard hidden.

Reviewed Internally by Gen Mak.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

• WebKitSupport/InputHandler.h:

(InputHandler):

2:10 PM Changeset in webkit [129043] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Clean up the SpellingLog output
​https://bugs.webkit.org/show_bug.cgi?id=97129

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-09-19
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

2:09 PM Changeset in webkit [129042] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[chromium] compositing/geometry/fixed-position-iframe-composited-page-scale-down test needs rebaseline for r129023.
​https://bugs.webkit.org/show_bug.cgi?id=97130

Patch by Robert Flack <​flackr@chromium.org> on 2012-09-19
Reviewed by Nate Chapin.

Rebaseline compositing/geometry/fixed-position-iframe-composited-page-scale-down.html.

• platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
• platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:

1:52 PM Changeset in webkit [129041] by rwlbuis@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Fix vertical positioning problem for 'X' in search field
​https://bugs.webkit.org/show_bug.cgi?id=97126

Reviewed by Antonio Gomes.

We have the same problem as described in bug 30245, so integrate that code.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::convertToPaintingRect):
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):

1:43 PM Changeset in webkit [129040] by mifenton@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add SpellingLog for spell checking options request.
​https://bugs.webkit.org/show_bug.cgi?id=97125

Reviewed by Rob Buis.

Add spell checking log to indicate the calculated
text position for spell checking option requests.

Reviewed Internally by Nima Ghanavatian.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):

1:35 PM Changeset in webkit [129039] by hclam@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed. Build fix.

Not building WebImageTest.cpp for component build.

• WebKit.gyp:

1:35 PM Changeset in webkit [129038] by jsbell@chromium.org

• 6 edits
  3 adds in trunk

IndexedDB: Free up resources used by completed cursors earlier
​https://bugs.webkit.org/show_bug.cgi?id=97023

Reviewed by Tony Chang.

Source/WebCore:

Prior to this patch, IDBCursor objects are kept around by their parent
IDBTransaction until the transaction finishes. It's possible to release
references to them earlier, when the cursor has been "run to the end",
as no further events will fire and all calls to continue() etc should fail.

This change tells the cursor it's done when "null" finally comes through in
the IDBRequest, and the cursor then lets transaction know it can be
forgotten.

The added test doesn't distinguish the new behavior, but does exercise
"finished" cursors and apparently we didn't have tests for these before.

Test: storage/indexeddb/cursor-finished.html

• Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::close): Make idempotent; notify transaction.

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Tell cursor it's finished before releasing.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::OpenCursorNotifier::~OpenCursorNotifier):
(WebCore):
(WebCore::IDBTransaction::OpenCursorNotifier::cursorFinished): New method for explicit notification.

• Modules/indexeddb/IDBTransaction.h:

(OpenCursorNotifier):

LayoutTests:

Test to exercise cursor methods after the cursor has been run to the end.

• storage/indexeddb/cursor-finished-expected.txt: Added.
• storage/indexeddb/cursor-finished.html: Added.
• storage/indexeddb/resources/cursor-finished.js: Added.

(test):
(prepareDatabase):
(onDeleteSuccess):
(onUpgradeNeeded):
(onOpenSuccess):
(onCursorSuccess):

1:28 PM Changeset in webkit [129037] by dgrogan@chromium.org

• 27 edits
  1 move
  2 adds
  2 deletes in trunk

IndexedDB: fire upgradeneeded even without an explicit integer version
​https://bugs.webkit.org/show_bug.cgi?id=96444

Reviewed by Tony Chang.

Source/WebCore:

Also of note:

• New databases now get a default version of 1 instead of

the empty string when they are opened.

• We now allow databases with an integer version to revert to a string

version by calling setVersion.

Implementation detail: we store both an integer version and string
version for a particular database. If both are set we give preference
to the integer version and assume the db is on the integer track.

Test: storage/indexeddb/intversion-two-opens-no-versions.html

• Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
Now that this can be called even after an int version is set we have
to make it revoke the int version.

(WebCore::IDBDatabaseBackendImpl::openConnection):
Nested ifs were getting deep, so refactor to return early instead.

(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::resetVersion):
Now that an int version could have been set before setVersion was
called we have to reset the int version on abort.

• Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

• Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):

• Modules/indexeddb/IDBOpenDBRequest.cpp:

0 is now a valid integer version to store to leveldb if an idb
database is reverting to a string version.

(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
If the open request did not specify an integer version but
upgradeneeded is called, it means the database was given the default
version of 1.

LayoutTests:

Mostly updating expectations about getting an upgradeneeded on a new
database and the default version being 1 instead of "".

• http/tests/inspector/indexeddb/database-structure-expected.txt:
• storage/indexeddb/cursor-overloads-expected.txt:
• storage/indexeddb/cursor-overloads.html:
• storage/indexeddb/dont-commit-on-blocked-expected.txt:
• storage/indexeddb/dont-commit-on-blocked.html:
• storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
• storage/indexeddb/intversion-and-setversion-expected.txt:

Remove test that setVersion fires an error if an int version is set.
Change it to testing that an int version can replace a string version
that replaced an int version.

• storage/indexeddb/intversion-bad-parameters-expected.txt:
• storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt: Removed.

setVersion is no longer invalid so this test can be deleted.

• storage/indexeddb/intversion-omit-parameter-expected.txt:

We now fully pass this test.

• storage/indexeddb/intversion-two-opens-no-versions-expected.txt: Added.
• storage/indexeddb/intversion-two-opens-no-versions.html: Renamed from LayoutTests/storage/indexeddb/intversion-invalid-setversion-has-no-side-effects.html.
• storage/indexeddb/list-ordering-expected.txt:
• storage/indexeddb/noblobs-expected.txt:
• storage/indexeddb/noblobs.html:
• storage/indexeddb/open-during-transaction-expected.txt:

This test had a bug in it AND its behavior is changed. It was trying
to open one database twice and another once but was actually opening
three different databases. The behavior change is that now the
transaction finishes while the last call to open is firing
upgradeneeded.

• storage/indexeddb/pending-activity-expected.txt:
• storage/indexeddb/pending-activity-workers-expected.txt:
• storage/indexeddb/resources/intversion-and-setversion.js:

(deleteSuccess):
(initialUpgradeNeeded):
(openSuccess):
(firstUpgradeNeeded):
(transactionCompleted):
(firstOpenWithVersion):
(secondSetVersionCallback):
(setIntVersion2):
(versionChangeGoingFromStringToInt):
(version2ConnectionBlocked):
(version2ConnectionSuccess):
(errorWhenTryingLowVersion):

• storage/indexeddb/resources/intversion-invalid-setversion-has-no-side-effects.js: Removed.
• storage/indexeddb/resources/intversion-two-opens-no-versions.js: Added.

(test):
(deleteSuccess):
(connection1UpgradeNeeded):
(connection1OpenSuccess):
(connection2UpgradeNeeded):
(connection2OpenSuccess):

• storage/indexeddb/resources/list-ordering.js:
• storage/indexeddb/resources/open-during-transaction.js:

(startTransaction.trans.oncomplete):
(startTransaction):
(tryOpens.openreq3.onsuccess):
(tryOpens):

• storage/indexeddb/resources/pending-activity.js:
• storage/indexeddb/structured-clone-expected.txt:
• storage/indexeddb/structured-clone.html:

12:55 PM Changeset in webkit [129036] by dmazzoni@google.com

• 6 edits
  4 adds in trunk

AX: A few control types are returning the wrong answer for isReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html

platform/mac/accessibility/form-control-value-settable.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

• DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):

• DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:

(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

• platform/chromium/accessibility/readonly-expected.txt: Added.
• platform/chromium/accessibility/readonly.html: Added.
• platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
• platform/mac/accessibility/form-control-value-settable.html: Added.

12:49 PM Changeset in webkit [129035] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-09-19 Nate Chapin <Nate Chapin>

Chromium gardening.

A test is mistakenly marked as both SLOW and TIMEOUT.

• platform/chromium/TestExpectations:

12:33 PM Changeset in webkit [129034] by bfulgham@webkit.org

• 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed build correction to update Skipped list
to match current Windows list.

• platform/wincairo/Skipped: Updated to match Apple build.

12:19 PM Changeset in webkit [129033] by leviw@chromium.org

• 16 edits
  3 copies in branches/chromium/1229

Merge 128346 - Inline repainting can be off-by-one with sub-pixel enabled
​https://bugs.webkit.org/show_bug.cgi?id=95882

Reviewed by Eric Seidel.

Source/WebCore:

With sub-pixel layout enabled, context accumulated from containing renderers is used to properly
pixel snap. Selection repaint rects are stored outside the affected renderers, and are handed to
the embedder without the context to correctly determine the snapped values. This can result in
repaint areas smaller than what's needed.

This could be fixed three ways:

• by changing selection repaint rects to an IntRect and pixel snapping the values before storing them outside the render tree. This is the narrowest solution.
• by adapting layout to store pixel snapping hints along with the size/location of the renderer. This is the best possible solution, as it would help solve a lot of pixel snapping issues and reduce complexity of handling. I eventually intend on implementing this.
• by reverting repaintUsingContainer to IntRects and using pixel snapping when possible, and enclosingIntRect where we lack context.

This implements the last solution, as it's the least invasive, but can potentially fix numerous
sub-pixel repaint issues.

Test: fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloats):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

• rendering/RenderObject.h:

(RenderObject):

• rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::repaint):

LayoutTests:

Test that we properly repaint selection gaps inside tables with sub-pixel offsets.

• fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
• fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added.
• platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
• platform/chromium/TestExpectations:
• platform/mac-lion/Skipped:
• platform/mac-snowleopard/Skipped:
• platform/mac-wk2/Skipped:
• platform/mac/Skipped:
• platform/qt-4.8/Skipped:
• platform/qt/Skipped:
• platform/win-wk2/Skipped:
• platform/win-xp/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:
• platform/wk2/Skipped:

TBR=​leviw@chromium.org

12:17 PM Changeset in webkit [129032] by hclam@chromium.org

• 3 edits
  3 adds in trunk/Source/WebKit/chromium

[chromium] WebImage should use ImageDecoder directly
​https://bugs.webkit.org/show_bug.cgi?id=96135

Reviewed by Adam Barth.

This patch is for preparation of deferred image decoding.
ImageSource will be used as a portal to access deferred image decoder
by BitmapImage, it should not be accessible through WebKit APIs.

WebImage now calls ImageDecoder directly which is the actual
implementation of an image decoder.

Tests: WebImageTest.PNGImage

WebImageTest.ICOImage
WebImageTest.BadImage

• WebKit.gypi:
• src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):

• tests/WebImageTest.cpp: Added.

(WebKit):
(WebKit::readFile):
(WebKit::TEST):

• tests/data/black-and-white.ico: Added.
• tests/data/white-1x1.png: Added.

12:15 PM Changeset in webkit [129031] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-09-19 Nate Chapin <Nate Chapin>

Chromium gardening.
Mark a consistently passing test as such, tweak flakiness
of several tests based on recent build results.

• platform/chromium/TestExpectations:

12:12 PM Changeset in webkit [129030] by pilgrim@chromium.org

• 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in V8GCController
​https://bugs.webkit.org/show_bug.cgi?id=97118

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

• bindings/v8/V8GCController.cpp:

12:07 PM Changeset in webkit [129029] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/chromium

[chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
​https://bugs.webkit.org/show_bug.cgi?id=96112

Patch by Oli Lan <​olilan@chromium.org> on 2012-09-19
Reviewed by Adam Barth.

Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.

This will be used by the Android port to implement platform-specific gesture behaviour.

This is tested by the new test WebViewTest.ClientTapHandlers.

• public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::didHandleGestureEvent):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

• tests/WebViewTest.cpp:

12:03 PM Changeset in webkit [129028] by leviw@chromium.org

• 8 edits in branches/chromium/1229

Merge 126110 - [Sub-pixel Layout] Block selection gap repainting can leave one pixel gaps
​https://bugs.webkit.org/show_bug.cgi?id=94526

Reviewed by Eric Seidel.

Source/WebCore:

Reverting RenderLayer's m_blockSelectionGapsBounds to be an IntRect and applying enclosingIntRect to the
gapRects added to the bounds. Previously, we'd end multiple block gaps and pixel snap the result, which
can yield results one pixel off in width and height.

Covered by existing tests. This undoes some of the rebaselining from when sub-pixel was enabled for Chromium.

• rendering/RenderLayer.cpp:
• rendering/RenderLayer.h:

LayoutTests:

Correcting pixel gap repainting reverts a bunch of chromium expectations to their pre-sub-pixel layout
versions. This largely triggers 1-pixel image diffs in input fields.

• platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
• platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
• platform/chromium-mac/editing/pasteboard/4806874-expected.png:
• platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
• platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
• platform/chromium-mac/editing/selection/3690703-2-expected.png:
• platform/chromium-mac/editing/selection/3690703-expected.png:
• platform/chromium-mac/editing/selection/3690719-expected.png:
• platform/chromium-mac/editing/selection/4895428-3-expected.png:
• platform/chromium-mac/editing/selection/4975120-expected.png:
• platform/chromium-mac/editing/selection/drag-select-1-expected.png:
• platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
• platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
• platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
• platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
• platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
• platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
• platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
• platform/chromium-mac/fast/css/input-search-padding-expected.png:
• platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png:
• platform/chromium-mac/fast/css/line-height-expected.png:
• platform/chromium-mac/fast/css/square-button-appearance-expected.png:
• platform/chromium-mac/fast/css/text-overflow-input-expected.png:
• platform/chromium-mac/fast/dom/isindex-001-expected.png:
• platform/chromium-mac/fast/dom/isindex-002-expected.png:
• platform/chromium-mac/fast/events/autoscroll-expected.png:
• platform/chromium-mac/fast/events/context-no-deselect-expected.png:
• platform/chromium-mac/fast/forms/basic-buttons-expected.png:
• platform/chromium-mac/fast/forms/basic-inputs-expected.png:
• platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
• platform/chromium-mac/fast/forms/button-sizes-expected.png:
• platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
• platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
• platform/chromium-mac/fast/forms/encoding-test-expected.png:
• platform/chromium-mac/fast/forms/fieldset-align-expected.png:
• platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
• platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
• platform/chromium-mac/fast/forms/input-align-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
• platform/chromium-mac/fast/forms/input-baseline-expected.png:
• platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
• platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
• platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
• platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
• platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
• platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
• platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
• platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
• platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
• platform/chromium-mac/fast/forms/input-spaces-expected.png:
• platform/chromium-mac/fast/forms/input-table-expected.png:
• platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
• platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
• platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
• platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
• platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
• platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
• platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
• platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
• platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
• platform/chromium-mac/fast/forms/input-value-expected.png:
• platform/chromium-mac/fast/forms/input-width-expected.png:
• platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
• platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
• platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
• platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
• platform/chromium-mac/fast/forms/placeholder-position-expected.png:
• platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
• platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
• platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
• platform/chromium-mac/fast/forms/text-style-color-expected.png:
• platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
• platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
• platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
• platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
• platform/chromium-mac/fast/html/details-no-summary4-expected.png:
• platform/chromium-mac/fast/html/details-open-javascript-expected.png:
• platform/chromium-mac/fast/html/details-open2-expected.png:
• platform/chromium-mac/fast/html/details-open4-expected.png:
• platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
• platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
• platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
• platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
• platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
• platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
• platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
• platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
• platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
• platform/chromium-mac/fast/table/003-expected.png:
• platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
• platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
• platform/chromium-mac/fast/table/text-field-baseline-expected.png:
• platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
• platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
• platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
• platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
• platform/chromium-mac/svg/hixie/mixed/003-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
• platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
• platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
• platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
• platform/chromium/TestExpectations:

TBR=​leviw@chromium.org

11:56 AM Changeset in webkit [129027] by pilgrim@chromium.org

• 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
​https://bugs.webkit.org/show_bug.cgi?id=97117

Reviewed by Ryosuke Niwa.

Part of a refactoring series. See tracking bug 82948.

• bindings/v8/V8DOMWindowShell.cpp:

11:52 AM Changeset in webkit [129026] by haraken@chromium.org

• 5 edits in trunk/Source/WebCore

[V8] Remove WorkerContextExecutionProxy::runScript()
​https://bugs.webkit.org/show_bug.cgi?id=97060

Reviewed by Adam Barth.

To kill WorkerContextExecutionProxy, this patch removes
WorkerContextExecutionProxy::runScript() by replacing it
with ScriptRunner::runCompiledScript().

For the replacement, this patch moves TryCatch logic in
runCompiledScript() to the caller side. The reason why
we have to avoid nesting TryCatches is a V8 bug:
​http://code.google.com/p/v8/issues/detail?id=2166

No tests. No change in behavior.

• bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

• bindings/v8/ScriptRunner.cpp:

(WebCore::ScriptRunner::runCompiledScript):

• bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):

• bindings/v8/WorkerContextExecutionProxy.h:

(WorkerContextExecutionProxy):

11:04 AM Changeset in webkit [129025] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-09-19 Nate Chapin <Nate Chapin>

Chromium gardening, remove flaky tests that don't appear to
actually be flaky.
​https://bugs.webkit.org/show_bug.cgi?id=78725

• platform/chromium/TestExpectations:

11:03 AM Changeset in webkit [129024] by rwlbuis@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Remove custom painting code for searchCancel
​https://bugs.webkit.org/show_bug.cgi?id=97119

Reviewed by Antonio Gomes.

Remove the dynamic painting code for searchCancel, we use a png file now.

• platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::Image::loadPlatformResource):

10:58 AM Changeset in webkit [129023] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Support high DPI scroll bar on top level web frame.
​https://bugs.webkit.org/show_bug.cgi?id=95134

Patch by Robert Flack <​flackr@chromium.org> on 2012-09-19
Reviewed by Adrienne Walker.

Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled.

• src/NonCompositedContentHost.cpp:

(WebKit::setScrollbarBoundsContainPageScale):
(WebKit):
(WebKit::NonCompositedContentHost::setViewport):

10:57 AM Changeset in webkit [129022] by commit-queue@webkit.org

• 4 edits in trunk

[WTR] Memory leaks in TestRunner::deliverWebIntent()
​https://bugs.webkit.org/show_bug.cgi?id=97111

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Fix memory leaks in WKBundleIntentCreate() by adopting strings
created with WKStringCreateWithUTF8CString().

• WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:

(WKBundleIntentCreate):

Tools:

Fix memory leaks in deliverWebIntent() by adopting strings
created with WKStringCreateWithUTF8CString().

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::deliverWebIntent):

10:56 AM Changeset in webkit [129021] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-09-19 Nate Chapin <Nate Chapin>

Chromium gardening.
fast/filesystem/workers/detached-frame-crash.html does not appear to be
flakily crashing anymore.

• platform/chromium/TestExpectations:

10:53 AM Changeset in webkit [129020] by pilgrim@chromium.org

• 8 edits in trunk/Source

[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97116

Reviewed by Adam Barth.

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

• bindings/v8/V8Binding.cpp:

(WebCore::handleOutOfMemory):

• loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::didExhaustMemoryAvailableForScript):
(FrameLoaderClient):

• platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

• src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript):
(WebKit):

• src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

• src/PlatformSupport.cpp:

(WebCore):

10:52 AM Changeset in webkit [129019] by commit-queue@webkit.org

• 5 edits in trunk

[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=97082

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WebChromeClient::selectItemWritingDirectionIsNatural() now returns
true for EFL-WK2, consistently with EFL-WK1, so that the style
is properly adjusted in RenderMenuList::adjustInnerStyle().

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):

LayoutTests:

Rebaseline fast/forms/select-writing-direction-natural.html and
unskip it for efl-wk2.

• platform/efl-wk2/TestExpectations:
• platform/efl/fast/forms/select-writing-direction-natural-expected.png:

10:50 AM Changeset in webkit [129018] by krit@webkit.org

• 16 edits
  9 adds in trunk

Implement 'mask-type' for <mask>
​https://bugs.webkit.org/show_bug.cgi?id=97011

Reviewed by Andreas Kling.

Source/WebCore:

The CSS Masking specification defines the presentation attribute 'mask-type' to
switch between luminance and alpha masking. 'mask-type' just affects the SVG
mask element. The luminance masking is the current behavior of of SVG masking.
Alpha masking is simular to '-webkit-mask-image'.

This patch implements this property and make it possible to switch between both
masking modes. Since the default value is 'luminance', this does not break
exisiting content which is tested with exisiting tests.

​http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#the-mask-type

Tests: svg/css/mask-type.html

svg/masking/mask-type-alpha-expected.svg
svg/masking/mask-type-alpha.svg
svg/masking/mask-type-luminance-expected.svg
svg/masking/mask-type-luminance.svg
svg/masking/mask-type-not-set-expected.svg
svg/masking/mask-type-not-set.svg

• css/CSSComputedStyleDeclaration.cpp: Add mask-type property.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EMaskType):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

• css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

• css/SVGCSSPropertyNames.in: Add mask-type.
• css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

• css/SVGCSSValueKeywords.in:
• rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::diff):

• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialMaskType):
(WebCore::SVGRenderStyle::setMaskType):
(SVGRenderStyle):
(WebCore::SVGRenderStyle::maskType):
(WebCore::SVGRenderStyle::setBitDefaults):

• rendering/style/SVGRenderStyleDefs.h:
• rendering/svg/RenderSVGResourceMasker.cpp:

Switch between the two masking modes according to the
computed value of mask-type.

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

• svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::cssPropertyToTypeMap):

• svg/svgattrs.in: Add the new attribute to the attribute list.

LayoutTests:

Added new tests for switching the masking mode on <mask> element with 'mask-type'.

• svg/css/mask-type-expected.txt: Added.
• svg/css/mask-type.html: Added.
• svg/masking/mask-type-alpha-expected.svg: Added.
• svg/masking/mask-type-alpha.svg: Added.
• svg/masking/mask-type-luminance-expected.svg: Added.
• svg/masking/mask-type-luminance.svg: Added.
• svg/masking/mask-type-not-set-expected.svg: Added.
• svg/masking/mask-type-not-set.svg: Added.

10:47 AM Changeset in webkit [129017] by kareng@chromium.org

• 1 add in branches/chromium/1271/codereview.settings

adding for easy droverin

10:45 AM Changeset in webkit [129016] by pilgrim@chromium.org

• 5 edits in trunk/Source

[Chromium] Remove unused popupsAllowed function from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=96521

Reviewed by Eric Seidel.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

• bindings/v8/NPV8Object.cpp:

(WebCore::v8ObjectToNPObject):
(_NPN_Evaluate):
(_NPN_GetProperty):

• platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

• src/PlatformSupport.cpp:

(WebCore):

10:45 AM Changeset in webkit [129015] by kareng@chromium.org

• 1 copy in branches/chromium/1271

creating chromium branch for m23

10:37 AM Changeset in webkit [129014] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-09-19 Nate Chapin <Nate Chapin>

chromium TestExpectations update.
fast/filesystem/file-writer-write-overlapped.html and
fast/filesystem/workers/file-writer-write-overlapped.html
are flaky in WIN DEBUG only.

• platform/chromium/TestExpectations:

10:25 AM Changeset in webkit [129013] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-09-19 Nate Chapin <Nate Chapin>

TextExpectations update, remove entries for consistently passing tests.
​https://bugs.webkit.org/show_bug.cgi?id=74746

• platform/chromium/TestExpectations:

10:14 AM Changeset in webkit [129012] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding another flaky crasher expectation after r128802.

• platform/gtk/TestExpectations:

9:49 AM Changeset in webkit [129011] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebKit/efl

Unreviewed, rolling out r128995.
​http://trac.webkit.org/changeset/128995
​https://bugs.webkit.org/show_bug.cgi?id=97114

Causes the api tests to segfault. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-19

• tests/UnitTestUtils/EWKTestBase.cpp:

(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::runTest):

• tests/UnitTestUtils/EWKTestBase.h:

(EWKUnitTests):
(EWKTestBase):

• tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):

• tests/UnitTestUtils/EWKTestView.h:

(EWKTestEcoreEvas):
(EWKUnitTests):
(EWKTestView):

• tests/test_ewk_view.cpp:

(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):

• tests/test_runner.cpp:

(main):

8:54 AM Changeset in webkit [129010] by commit-queue@webkit.org

• 6 edits in trunk/Source

[BlackBerry] Add function playerId() in class PageClientBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=97099

Patch by Jonathan Dong <Jonathan Dong> on 2012-09-19
Reviewed by Yong Li.

Source/WebCore:

Added function playerID() in class PageClientBlackBerry.

Internally reviewed by Charles Wei.

No new tests since there's no functional change.

• platform/blackberry/PageClientBlackBerry.h:

Source/WebKit/blackberry:

Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
and replaced the implementation of FrameLoaderClientBlackBerry::playerId().

Internally reviewed by Charles Wei.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::playerID):
(WebKit):

• Api/WebPage_p.h:

(WebPagePrivate):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::playerId):

8:30 AM Changeset in webkit [129009] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined
​https://bugs.webkit.org/show_bug.cgi?id=96300

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-09-19
Reviewed by Yury Semikhatsky.

All CSS Regions APIs should be exposed only if CSS_REGIONS is enabled

No new tests because of no behavior changes.

• css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage): Fix compile without CSS_REGIONS enabled and added an ASSERT_NOT_REACHED as in other functions

• dom/Element.cpp: Compile webkitRegionOverset only if CSS_REGIONS is enabled

(WebCore):

• dom/Element.h:
• dom/Element.idl: Expose webkitRegionOverset only if CSS_REGIONS is enabled

8:12 AM Changeset in webkit [129008] by zandobersek@gmail.com

• 2 edits
  2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding another flaky crasher expectation after r128802.

Adding platform-specific baselines after r128861.

• platform/gtk/TestExpectations:
• platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Added.
• platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Added.

8:05 AM Changeset in webkit [129007] by Simon Hausmann

• 4 edits in trunk/Tools

[Qt] Fix incremental builds with all-in-one-files and gccdepends

Reviewed by Tor Arne Vestbø.

Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
are not only created for header files but also for .cpp files. AllInOne.cpp files
include other .cpp files, and when those are removed we need those dummy rules to
avoid a "No rule to make Foo.cpp required by AllInOne.o" error.

• qmake/config.tests/gccdepends/empty.cpp:

(main):

• qmake/config.tests/gccdepends/gccdepends.pro:
• qmake/mkspecs/features/default_pre.prf:

7:52 AM Changeset in webkit [129006] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
Added a missing 'if' statement.
​https://bugs.webkit.org/show_bug.cgi?id=96925

PR #180866

Internally Reviewed by Antonio Gomes.

Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)

Patch by Abbas Sherawala <​asherawala@rim.com> on 2012-09-19
Reviewed by Antonio Gomes.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

7:42 AM Changeset in webkit [129005] by Patrick Gansterer

• 7 edits in trunk/Source/WebCore

Remove all usages of M_PI from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=93109

Reviewed by Dirk Schulze.

<wtf/MathExtras.h> implements many functions dealing with M_PI.
Use them in WebCore instead of duplicating the functionality.

• platform/blackberry/PlatformTouchEventBlackBerry.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setFilters):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):

• platform/graphics/wx/FontPlatformDataWxMac.mm:
• platform/mac/WebWindowAnimation.mm:

(-[WebWindowScaleAnimation currentValue]):

• platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp:

(DegToRad):
(RadToDeg):

7:37 AM Changeset in webkit [129004] by commit-queue@webkit.org

• 21 edits in trunk/LayoutTests

[EFL] Rebaseline a few mozilla/table/bugs tests that were missed
​https://bugs.webkit.org/show_bug.cgi?id=97107

Unreviewed EFL rebaseline.

Rebaseline a few tables/mozilla/bugs tests that
were forgotten during my massive tables/mozilla
rebaseline.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/TestExpectations:
• platform/efl/tables/mozilla/bugs/45621-expected.png:
• platform/efl/tables/mozilla/bugs/bug9072-expected.png:
• platform/efl/tables/mozilla/bugs/bug9123-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug9123-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug92143-expected.png:
• platform/efl/tables/mozilla/bugs/bug92647-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug9271-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug9271-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug92868-expected.png:
• platform/efl/tables/mozilla/bugs/bug93363-expected.png:
• platform/efl/tables/mozilla/bugs/bug963-expected.png:
• platform/efl/tables/mozilla/bugs/bug96334-expected.png:
• platform/efl/tables/mozilla/bugs/bug96343-expected.png:
• platform/efl/tables/mozilla/bugs/bug965-expected.png:
• platform/efl/tables/mozilla/bugs/bug97138-expected.png:
• platform/efl/tables/mozilla/bugs/bug98196-expected.png:
• platform/efl/tables/mozilla/bugs/bug9879-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug99923-expected.png:
• platform/efl/tables/mozilla/bugs/bug99948-expected.png:

7:26 AM Changeset in webkit [129003] by vsevik@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Network request headers text fallback has typo.
​https://bugs.webkit.org/show_bug.cgi?id=96280

Reviewed by Pavel Feldman.

• inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):

7:12 AM Changeset in webkit [129002] by jochen@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Update test expectation for indexeddb test that is currently only run using content_browsertests

Unreviewed gardening.

• storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt:

7:11 AM Changeset in webkit [129001] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] remove static_cast which will cause video crash
​https://bugs.webkit.org/show_bug.cgi?id=97070

Patch by Jonathan Dong <Jonathan Dong> on 2012-09-19
Reviewed by Antonio Gomes.

Removed the static_cast to avoid layering violation which
will cause a runtime crash.
We won't create a real MediaPlayerPrivate object before we call
MediaPlayer::load(), so if we use player()->implementation()
before calling load() in some cases, it points to a
NullMediaPlayerPrivate object. Here we should not use static_cast,
instead we should use HTMLMediaElement::percentLoaded() to
avoid layering violation as we don't have the buffering bug which
the deleted comment refers to.

Internally reviewed by Max Feil.

Test case: media/video-size.html

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):

7:09 AM Changeset in webkit [129000] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/gtk

[gtk] add enable-media-stream to websettings
​https://bugs.webkit.org/show_bug.cgi?id=94361

Patch by Danilo Cesar Lemes de Paula <​danilo.cesar@collabora.co.uk> on 2012-09-19
Reviewed by Martin Robinson.

Applications should be allowed to enable/disable MediaStream on webkitwebsettings.

• webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

• webkit/webkitwebsettingsprivate.h:
• webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):

7:08 AM Changeset in webkit [128999] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

Do touch adjustment on GestureTapDown
​https://bugs.webkit.org/show_bug.cgi?id=96677

Patch by Rick Byers <​rbyers@chromium.org> on 2012-09-19
Reviewed by Antonio Gomes.

Source/WebCore:

Do touch adjustment on GestureTapDown exactly as for GestureTap today.

Test: touchadjustment/touch-links-active.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::adjustGesturePosition):

Tools:

Allow radius to be set for GestureTapDown events.

• DumpRenderTree/chromium/TestRunner/EventSender.cpp:

(EventSender::gestureEvent):

LayoutTests:

Make a few tweaks to the touchadjustment.js infrastructure to make it
simpler and easier to use. Add a test for touch-adjustment of
GestureTapDown events (based on touch-links-longpress).

• touchadjustment/resources/touchadjustment.js:

(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
(touchPoint.return.get y):
(touchPoint):
(offsetTouchPoint):

• touchadjustment/touch-links-active-expected.txt: Added.
• touchadjustment/touch-links-active.html: Added.

7:04 AM Changeset in webkit [128998] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Skip fast/dom/message-port-deleted-by-accessor.html
​https://bugs.webkit.org/show_bug.cgi?id=97105

Unreviewed EFL gardening.

Add fast/dom/message-port-deleted-by-accessor.html to
TestExpectations because it sometimes crashes on debug
build bots after r128802.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/TestExpectations:

7:03 AM Changeset in webkit [128997] by vsevik@chromium.org

• 2 edits in trunk/Source/WebCore

Unreviewed another follow up Apple Win build fix for r128992.

• inspector/InspectorAllInOne.cpp:

7:00 AM Changeset in webkit [128996] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
​https://bugs.webkit.org/show_bug.cgi?id=97092

Reviewed by Martin Robinson.

Calling resizeLater() from the constructor of
RedirectedXCompositeWindow can cause the callback to be called
later by the main loop after the RedirectedXCompositeWindow object
has been destroyed. Instead of calling resizeLater(), initialize
the usable size to the given initial size.

• platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):

6:53 AM Changeset in webkit [128995] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebKit/efl

[EFL][UT] Refactoring an implementation of testing framework for wk1.
​https://bugs.webkit.org/show_bug.cgi?id=94925

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2012-09-19
Reviewed by Gyuyoung Kim.

The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.

• tests/UnitTestUtils/EWKTestBase.cpp:

(EWKUnitTests::EWKTestBase::EWKTestBase): Added to initialize test view.
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize efl and test view.
(EWKUnitTests::EWKTestBase::TearDown):
TearDown is called as soon as test is completed.
Used this to properly shutdown efl and clean test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.

• tests/UnitTestUtils/EWKTestBase.h:
• tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Initialize test view.

• tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

• tests/test_ewk_view.cpp:

(TEST_F):

• tests/test_runner.cpp:

(main):

6:50 AM Changeset in webkit [128994] by vsevik@chromium.org

• 2 edits in trunk/Source/WebCore

Unreviewed follow up Apple Win build fix for r128992.

• inspector/InspectorAllInOne.cpp:

6:32 AM Changeset in webkit [128993] by commit-queue@webkit.org

• 15 edits
  2 adds in trunk

[EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
​https://bugs.webkit.org/show_bug.cgi?id=97100

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add DumpRenderTree support method to set the
'WebKitCSSRegionsEnabled' preference.

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):

• WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
preference, in order to match WebKitTestRunner functionality.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

• DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference):

LayoutTests:

Rebaseline and unskip several test cases now that EFL's DRT
supports overriding 'WebKitCSSRegionsEnabled' preference.

• platform/efl/Skipped:
• platform/efl/TestExpectations:
• platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
• platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
• platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
• platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
• platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
• platform/efl/fast/repaint/region-painting-invalidation-expected.png: Added.
• platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
• platform/efl/fast/repaint/region-painting-via-layout-expected.txt:

6:07 AM Changeset in webkit [128992] by commit-queue@webkit.org

• 25 edits
  8 moves in trunk

Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
​https://bugs.webkit.org/show_bug.cgi?id=96917

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-19
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Rename WebGLAgent* and WebGLInstrumentation* files to Canvas* as we will support both 2D and 3D/WebGL canvas instrumentation.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSHTMLCanvasElementCustom.cpp:
• bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
• inspector/CodeGeneratorInspector.py:
• inspector/InjectedScriptCanvasModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.cpp.

(WebCore):
(WebCore::InjectedScriptCanvasModule::InjectedScriptCanvasModule):
(WebCore::InjectedScriptCanvasModule::moduleForState):
(WebCore::InjectedScriptCanvasModule::source):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):

• inspector/InjectedScriptCanvasModule.h: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.h.

(WebCore):
(InjectedScriptCanvasModule):

• inspector/InjectedScriptCanvasModuleSource.js: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js.

(.):

• inspector/Inspector.json:
• inspector/InspectorAllInOne.cpp:
• inspector/InspectorCanvasAgent.cpp: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.cpp.

(WebCore):
(CanvasAgentState):
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::setFrontend):
(WebCore::InspectorCanvasAgent::clearFrontend):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModuleForTraceLogId):

• inspector/InspectorCanvasAgent.h: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.h.

(WebCore):
(InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::create):
(WebCore::InspectorCanvasAgent::enabled):

• inspector/InspectorCanvasInstrumentation.h: Renamed from Source/WebCore/inspector/InspectorWebGLInstrumentation.h.

(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

• inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorCanvasAgent):
(WebCore::InstrumentingAgents::setInspectorCanvasAgent):
(InstrumentingAgents):

• inspector/compile-front-end.py:
• inspector/front-end/CanvasProfileView.js: Renamed from Source/WebCore/inspector/front-end/WebGLProfileView.js.

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype.get statusBarItems):
(WebInspector.CanvasProfileView.prototype.get profile):
(WebInspector.CanvasProfileView.prototype.wasShown):
(WebInspector.CanvasProfileView.prototype.willHide):
(WebInspector.CanvasProfileView.prototype._showTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.get buttonTooltip):
(WebInspector.CanvasProfileType.prototype.buttonClicked.didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype.get treeItemTitle):
(WebInspector.CanvasProfileType.prototype.get description):
(WebInspector.CanvasProfileType.prototype.reset):
(WebInspector.CanvasProfileType.prototype.createTemporaryProfile):
(WebInspector.CanvasProfileType.prototype.createProfile):
(WebInspector.CanvasProfileHeader):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CanvasProfileHeader.prototype.createView):

• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

• inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

• inspector/front-end/WebKit.qrc:
• inspector/front-end/canvasProfiler.css: Renamed from Source/WebCore/inspector/front-end/webGLProfiler.css.

(.canvas-profile-view):
(.canvas-trace-log):
(.canvas-trace-log div):
(#canvas-replay-image-container):
(#canvas-replay-image):

LayoutTests:

• inspector/profiler/webgl/webgl-profiler-get-error.html:
• inspector/profiler/webgl/webgl-profiler-test.js:

(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):

5:56 AM Changeset in webkit [128991] by commit-queue@webkit.org

• 136 edits in trunk/LayoutTests

[EFL] tables/mozilla tests need rebaseline (Part 6)
​https://bugs.webkit.org/show_bug.cgi?id=97098

Unreviewed EFL rebaseline.

Rebaseline remaining tables/mozilla tests.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/tables/mozilla/bugs/bug40828-expected.png:
• platform/efl/tables/mozilla/bugs/bug4093-expected.png:
• platform/efl/tables/mozilla/bugs/bug41890-expected.png:
• platform/efl/tables/mozilla/bugs/bug42187-expected.png:
• platform/efl/tables/mozilla/bugs/bug42443-expected.png:
• platform/efl/tables/mozilla/bugs/bug4284-expected.png:
• platform/efl/tables/mozilla/bugs/bug43039-expected.png:
• platform/efl/tables/mozilla/bugs/bug43204-expected.png:
• platform/efl/tables/mozilla/bugs/bug4382-expected.png:
• platform/efl/tables/mozilla/bugs/bug4385-expected.png:
• platform/efl/tables/mozilla/bugs/bug43854-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug43854-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug4427-expected.png:
• platform/efl/tables/mozilla/bugs/bug4429-expected.png:
• platform/efl/tables/mozilla/bugs/bug44505-expected.png:
• platform/efl/tables/mozilla/bugs/bug44523-expected.png:
• platform/efl/tables/mozilla/bugs/bug4501-expected.png:
• platform/efl/tables/mozilla/bugs/bug45055-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug45055-expected.png:
• platform/efl/tables/mozilla/bugs/bug4520-expected.png:
• platform/efl/tables/mozilla/bugs/bug4523-expected.png:
• platform/efl/tables/mozilla/bugs/bug4527-expected.png:
• platform/efl/tables/mozilla/bugs/bug45350-expected.png:
• platform/efl/tables/mozilla/bugs/bug45486-expected.png:
• platform/efl/tables/mozilla/bugs/bug4576-expected.png:
• platform/efl/tables/mozilla/bugs/bug46268-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug46268-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
• platform/efl/tables/mozilla/bugs/bug46268-expected.png:
• platform/efl/tables/mozilla/bugs/bug46368-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug46368-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug46480-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug46480-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug46623-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug46623-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug46924-expected.png:
• platform/efl/tables/mozilla/bugs/bug46944-expected.png:
• platform/efl/tables/mozilla/bugs/bug4739-expected.png:
• platform/efl/tables/mozilla/bugs/bug47432-expected.png:
• platform/efl/tables/mozilla/bugs/bug48028-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug48028-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug4803-expected.png:
• platform/efl/tables/mozilla/bugs/bug4849-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug4849-expected.png:
• platform/efl/tables/mozilla/bugs/bug48827-expected.png:
• platform/efl/tables/mozilla/bugs/bug50695-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug51037-expected.png:
• platform/efl/tables/mozilla/bugs/bug51140-expected.png:
• platform/efl/tables/mozilla/bugs/bug51727-expected.png:
• platform/efl/tables/mozilla/bugs/bug5188-expected.png:
• platform/efl/tables/mozilla/bugs/bug52505-expected.png:
• platform/efl/tables/mozilla/bugs/bug52506-expected.png:
• platform/efl/tables/mozilla/bugs/bug53690-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug53891-expected.png:
• platform/efl/tables/mozilla/bugs/bug54450-expected.png:
• platform/efl/tables/mozilla/bugs/bug5538-expected.png:
• platform/efl/tables/mozilla/bugs/bug55527-expected.png:
• platform/efl/tables/mozilla/bugs/bug55545-expected.png:
• platform/efl/tables/mozilla/bugs/bug55694-expected.png:
• platform/efl/tables/mozilla/bugs/bug55789-expected.png:
• platform/efl/tables/mozilla/bugs/bug56201-expected.png:
• platform/efl/tables/mozilla/bugs/bug56405-expected.png:
• platform/efl/tables/mozilla/bugs/bug56563-expected.png:
• platform/efl/tables/mozilla/bugs/bug57300-expected.png:
• platform/efl/tables/mozilla/bugs/bug57378-expected.png:
• platform/efl/tables/mozilla/bugs/bug57828-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug57828-expected.png:
• platform/efl/tables/mozilla/bugs/bug5797-expected.png:
• platform/efl/tables/mozilla/bugs/bug5798-expected.png:
• platform/efl/tables/mozilla/bugs/bug5799-expected.png:
• platform/efl/tables/mozilla/bugs/bug5835-expected.png:
• platform/efl/tables/mozilla/bugs/bug5838-expected.png:
• platform/efl/tables/mozilla/bugs/bug58402-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug59354-expected.png:
• platform/efl/tables/mozilla/bugs/bug60013-expected.png:
• platform/efl/tables/mozilla/bugs/bug60749-expected.png:
• platform/efl/tables/mozilla/bugs/bug60804-expected.png:
• platform/efl/tables/mozilla/bugs/bug60807-expected.png:
• platform/efl/tables/mozilla/bugs/bug60992-expected.png:
• platform/efl/tables/mozilla/bugs/bug6184-expected.png:
• platform/efl/tables/mozilla/bugs/bug625-expected.png:
• platform/efl/tables/mozilla/bugs/bug6304-expected.png:
• platform/efl/tables/mozilla/bugs/bug63785-expected.png:
• platform/efl/tables/mozilla/bugs/bug6404-expected.png:
• platform/efl/tables/mozilla/bugs/bug641-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug641-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug650-expected.png:
• platform/efl/tables/mozilla/bugs/bug6674-expected.png:
• platform/efl/tables/mozilla/bugs/bug67864-expected.png:
• platform/efl/tables/mozilla/bugs/bug67915-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug68912-expected.png:
• platform/efl/tables/mozilla/bugs/bug68998-expected.png:
• platform/efl/tables/mozilla/bugs/bug69187-expected.png:
• platform/efl/tables/mozilla/bugs/bug69382-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug69382-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug709-expected.png:
• platform/efl/tables/mozilla/bugs/bug7112-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug7112-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug7121-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug72359-expected.png:
• platform/efl/tables/mozilla/bugs/bug727-expected.png:
• platform/efl/tables/mozilla/bugs/bug73321-expected.png:
• platform/efl/tables/mozilla/bugs/bug7342-expected.png:
• platform/efl/tables/mozilla/bugs/bug7471-expected.png:
• platform/efl/tables/mozilla/bugs/bug75250-expected.png:
• platform/efl/tables/mozilla/bugs/bug7714-expected.png:
• platform/efl/tables/mozilla/bugs/bug78162-expected.png:
• platform/efl/tables/mozilla/bugs/bug8032-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug80762-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug81934-expected.png:
• platform/efl/tables/mozilla/bugs/bug82946-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug82946-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug8361-expected.png:
• platform/efl/tables/mozilla/bugs/bug83786-expected.png:
• platform/efl/tables/mozilla/bugs/bug8381-expected.png:
• platform/efl/tables/mozilla/bugs/bug8411-expected.png:
• platform/efl/tables/mozilla/bugs/bug86220-expected.png:
• platform/efl/tables/mozilla/bugs/bug86708-expected.png:
• platform/efl/tables/mozilla/bugs/bug88035-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug88035-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug88524-expected.png:
• platform/efl/tables/mozilla/bugs/bug8858-expected.png:
• platform/efl/tables/mozilla/bugs/bug8950-expected.png:
• platform/efl/tables/mozilla/other/body_col-expected.png:
• platform/efl/tables/mozilla/other/cell_widths-expected.png:
• platform/efl/tables/mozilla/other/cellspacing-expected.png:
• platform/efl/tables/mozilla/other/move_row-expected.png:
• platform/efl/tables/mozilla/other/ms-expected.png:
• platform/efl/tables/mozilla/other/nested2-expected.png:
• platform/efl/tables/mozilla/other/nestedTables-expected.png:
• platform/efl/tables/mozilla/other/padding-expected.png:
• platform/efl/tables/mozilla/other/test3-expected.png:
• platform/efl/tables/mozilla/other/test6-expected.png:
• platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:

5:46 AM Changeset in webkit [128990] by commit-queue@webkit.org

• 212 edits
  1 add in trunk/LayoutTests

[EFL] tables/mozilla tests need rebaseline (Part 5)
​https://bugs.webkit.org/show_bug.cgi?id=97096

Unreviewed EFL rebaseline.

Rebaseline part of tables/mozilla/bugs/ test cases
for EFL port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/tables/mozilla/bugs/bug10009-expected.png:
• platform/efl/tables/mozilla/bugs/bug100334-expected.png:
• platform/efl/tables/mozilla/bugs/bug10036-expected.png:
• platform/efl/tables/mozilla/bugs/bug10039-expected.png:
• platform/efl/tables/mozilla/bugs/bug101201-expected.png:
• platform/efl/tables/mozilla/bugs/bug101674-expected.png:
• platform/efl/tables/mozilla/bugs/bug102145-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug102145-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug102145-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug102145-4-expected.png:
• platform/efl/tables/mozilla/bugs/bug10269-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug10269-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug10296-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug10296-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug1055-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug10565-expected.png:
• platform/efl/tables/mozilla/bugs/bug106158-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug106158-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug10633-expected.png:
• platform/efl/tables/mozilla/bugs/bug1067-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug1067-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug106816-expected.png:
• platform/efl/tables/mozilla/bugs/bug108340-expected.png:
• platform/efl/tables/mozilla/bugs/bug109043-expected.png:
• platform/efl/tables/mozilla/bugs/bug11026-expected.png:
• platform/efl/tables/mozilla/bugs/bug110566-expected.png:
• platform/efl/tables/mozilla/bugs/bug11321-expected.png:
• platform/efl/tables/mozilla/bugs/bug113235-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug113235-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug113235-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug113424-expected.png:
• platform/efl/tables/mozilla/bugs/bug11384q-expected.png:
• platform/efl/tables/mozilla/bugs/bug11384s-expected.png:
• platform/efl/tables/mozilla/bugs/bug1163-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug1188-expected.png:
• platform/efl/tables/mozilla/bugs/bug11944-expected.png:
• platform/efl/tables/mozilla/bugs/bug119786-expected.png:
• platform/efl/tables/mozilla/bugs/bug12008-expected.png:
• platform/efl/tables/mozilla/bugs/bug120364-expected.png:
• platform/efl/tables/mozilla/bugs/bug1220-expected.png:
• platform/efl/tables/mozilla/bugs/bug1224-expected.png:
• platform/efl/tables/mozilla/bugs/bug12268-expected.png:
• platform/efl/tables/mozilla/bugs/bug12384-expected.png:
• platform/efl/tables/mozilla/bugs/bug123862-expected.png:
• platform/efl/tables/mozilla/bugs/bug1261-expected.png:
• platform/efl/tables/mozilla/bugs/bug126742-expected.png:
• platform/efl/tables/mozilla/bugs/bug12709-expected.png:
• platform/efl/tables/mozilla/bugs/bug127267-expected.png:
• platform/efl/tables/mozilla/bugs/bug128229-expected.png:
• platform/efl/tables/mozilla/bugs/bug12908-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug12910-expected.png:
• platform/efl/tables/mozilla/bugs/bug1296-expected.png:
• platform/efl/tables/mozilla/bugs/bug1302-expected.png:
• platform/efl/tables/mozilla/bugs/bug131020-expected.png:
• platform/efl/tables/mozilla/bugs/bug131020_iframe-expected.png:
• platform/efl/tables/mozilla/bugs/bug13105-expected.png:
• platform/efl/tables/mozilla/bugs/bug13118-expected.png:
• platform/efl/tables/mozilla/bugs/bug1318-expected.png:
• platform/efl/tables/mozilla/bugs/bug13196-expected.png:
• platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug13484-expected.png:
• platform/efl/tables/mozilla/bugs/bug13526-expected.png:
• platform/efl/tables/mozilla/bugs/bug137388-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug138725-expected.png:
• platform/efl/tables/mozilla/bugs/bug139524-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug139524-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug139524-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug139524-4-expected.png:
• platform/efl/tables/mozilla/bugs/bug14159-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug14159-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug1430-expected.png:
• platform/efl/tables/mozilla/bugs/bug14323-expected.png:
• platform/efl/tables/mozilla/bugs/bug145572-expected.png:
• platform/efl/tables/mozilla/bugs/bug1474-expected.png:
• platform/efl/tables/mozilla/bugs/bug149275-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug149275-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug14929-expected.png:
• platform/efl/tables/mozilla/bugs/bug15247-expected.png:
• platform/efl/tables/mozilla/bugs/bug154780-expected.png:
• platform/efl/tables/mozilla/bugs/bug15544-expected.png:
• platform/efl/tables/mozilla/bugs/bug157890-expected.png:
• platform/efl/tables/mozilla/bugs/bug159108-expected.png:
• platform/efl/tables/mozilla/bugs/bug15933-expected.png:
• platform/efl/tables/mozilla/bugs/bug16012-expected.png:
• platform/efl/tables/mozilla/bugs/bug16252-expected.png:
• platform/efl/tables/mozilla/bugs/bug17130-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug17130-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug17138-expected.png:
• platform/efl/tables/mozilla/bugs/bug17168-expected.png:
• platform/efl/tables/mozilla/bugs/bug175455-4-expected.png:
• platform/efl/tables/mozilla/bugs/bug17548-expected.png:
• platform/efl/tables/mozilla/bugs/bug17587-expected.png:
• platform/efl/tables/mozilla/bugs/bug1800-expected.png:
• platform/efl/tables/mozilla/bugs/bug1802-expected.png:
• platform/efl/tables/mozilla/bugs/bug1802s-expected.png:
• platform/efl/tables/mozilla/bugs/bug1809-expected.png:
• platform/efl/tables/mozilla/bugs/bug1818-5-expected.png:
• platform/efl/tables/mozilla/bugs/bug1828-expected.png:
• platform/efl/tables/mozilla/bugs/bug18359-expected.png:
• platform/efl/tables/mozilla/bugs/bug18558-expected.png:
• platform/efl/tables/mozilla/bugs/bug18664-expected.png:
• platform/efl/tables/mozilla/bugs/bug18955-expected.png:
• platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug19356-expected.png:
• platform/efl/tables/mozilla/bugs/bug194024-expected.png:
• platform/efl/tables/mozilla/bugs/bug19599-expected.png:
• platform/efl/tables/mozilla/bugs/bug2050-expected.png:
• platform/efl/tables/mozilla/bugs/bug20579-expected.png:
• platform/efl/tables/mozilla/bugs/bug2065-expected.png:
• platform/efl/tables/mozilla/bugs/bug20804-expected.png:
• platform/efl/tables/mozilla/bugs/bug2123-expected.png:
• platform/efl/tables/mozilla/bugs/bug21299-expected.png:
• platform/efl/tables/mozilla/bugs/bug215629-expected.png:
• platform/efl/tables/mozilla/bugs/bug21918-expected.png:
• platform/efl/tables/mozilla/bugs/bug22019-expected.png:
• platform/efl/tables/mozilla/bugs/bug220536-expected.png:
• platform/efl/tables/mozilla/bugs/bug221784-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug221784-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug22246-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug22246-2a-expected.png:
• platform/efl/tables/mozilla/bugs/bug22246-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug22246-3a-expected.png:
• platform/efl/tables/mozilla/bugs/bug222846-expected.png:
• platform/efl/tables/mozilla/bugs/bug22513-expected.png:
• platform/efl/tables/mozilla/bugs/bug2267-expected.png:
• platform/efl/tables/mozilla/bugs/bug227123-expected.png:
• platform/efl/tables/mozilla/bugs/bug2296-expected.png:
• platform/efl/tables/mozilla/bugs/bug23072-expected.png:
• platform/efl/tables/mozilla/bugs/bug23151-expected.png:
• platform/efl/tables/mozilla/bugs/bug23235-expected.png:
• platform/efl/tables/mozilla/bugs/bug23299-expected.png:
• platform/efl/tables/mozilla/bugs/bug24200-expected.png:
• platform/efl/tables/mozilla/bugs/bug24503-expected.png:
• platform/efl/tables/mozilla/bugs/bug24627-expected.png:
• platform/efl/tables/mozilla/bugs/bug24661-expected.png:
• platform/efl/tables/mozilla/bugs/bug2469-expected.png:
• platform/efl/tables/mozilla/bugs/bug2479-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug2479-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug2479-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug2479-4-expected.png:
• platform/efl/tables/mozilla/bugs/bug24880-expected.png:
• platform/efl/tables/mozilla/bugs/bug25004-expected.png:
• platform/efl/tables/mozilla/bugs/bug25074-expected.png:
• platform/efl/tables/mozilla/bugs/bug25086-expected.png:
• platform/efl/tables/mozilla/bugs/bug2509-expected.png:
• platform/efl/tables/mozilla/bugs/bug2516-expected.png:
• platform/efl/tables/mozilla/bugs/bug25367-expected.png:
• platform/efl/tables/mozilla/bugs/bug25663-expected.png:
• platform/efl/tables/mozilla/bugs/bug2585-expected.png:
• platform/efl/tables/mozilla/bugs/bug26178-expected.png:
• platform/efl/tables/mozilla/bugs/bug26553-expected.png: Added.
• platform/efl/tables/mozilla/bugs/bug2684-expected.png:
• platform/efl/tables/mozilla/bugs/bug27038-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug275625-expected.png:
• platform/efl/tables/mozilla/bugs/bug2757-expected.png:
• platform/efl/tables/mozilla/bugs/bug2763-expected.png:
• platform/efl/tables/mozilla/bugs/bug2773-expected.png:
• platform/efl/tables/mozilla/bugs/bug278266-expected.png:
• platform/efl/tables/mozilla/bugs/bug278385-expected.png:
• platform/efl/tables/mozilla/bugs/bug27993-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug28341-expected.png:
• platform/efl/tables/mozilla/bugs/bug2886-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug2886-expected.png:
• platform/efl/tables/mozilla/bugs/bug28928-expected.png:
• platform/efl/tables/mozilla/bugs/bug29058-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug29058-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug29157-expected.png:
• platform/efl/tables/mozilla/bugs/bug29314-expected.png:
• platform/efl/tables/mozilla/bugs/bug29326-expected.png:
• platform/efl/tables/mozilla/bugs/bug29429-expected.png:
• platform/efl/tables/mozilla/bugs/bug2947-expected.png:
• platform/efl/tables/mozilla/bugs/bug2962-expected.png:
• platform/efl/tables/mozilla/bugs/bug2973-expected.png:
• platform/efl/tables/mozilla/bugs/bug2981-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug2981-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug2997-expected.png:
• platform/efl/tables/mozilla/bugs/bug30273-expected.png:
• platform/efl/tables/mozilla/bugs/bug30332-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug30332-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug3037-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug3037-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug30418-expected.png:
• platform/efl/tables/mozilla/bugs/bug30559-expected.png:
• platform/efl/tables/mozilla/bugs/bug30692-expected.png:
• platform/efl/tables/mozilla/bugs/bug30985-expected.png:
• platform/efl/tables/mozilla/bugs/bug3103-expected.png:
• platform/efl/tables/mozilla/bugs/bug3191-expected.png:
• platform/efl/tables/mozilla/bugs/bug32205-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug32205-3-expected.png:
• platform/efl/tables/mozilla/bugs/bug32205-5-expected.png:
• platform/efl/tables/mozilla/bugs/bug32447-expected.png:
• platform/efl/tables/mozilla/bugs/bug3260-expected.png:
• platform/efl/tables/mozilla/bugs/bug3263-expected.png:
• platform/efl/tables/mozilla/bugs/bug32841-expected.png:
• platform/efl/tables/mozilla/bugs/bug3309-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug3309-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug33137-expected.png:
• platform/efl/tables/mozilla/bugs/bug33855-expected.png:
• platform/efl/tables/mozilla/bugs/bug34176-expected.png:
• platform/efl/tables/mozilla/bugs/bug34538-expected.png:
• platform/efl/tables/mozilla/bugs/bug3454-expected.png:
• platform/efl/tables/mozilla/bugs/bug35662-expected.png:
• platform/efl/tables/mozilla/bugs/bug3681-1-expected.png:
• platform/efl/tables/mozilla/bugs/bug3681-2-expected.png:
• platform/efl/tables/mozilla/bugs/bug3718-expected.png:
• platform/efl/tables/mozilla/bugs/bug38916-expected.png:
• platform/efl/tables/mozilla/bugs/bug39209-expected.png:
• platform/efl/tables/mozilla/bugs/bug3977-expected.png:

5:03 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

4:32 AM Changeset in webkit [128989] by Carlos Garcia Campos

• 17 edits
  3 adds in trunk/Source

[GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=96497

Reviewed by Martin Robinson.

Source/WebCore:

• WebCore.exp.in: Add new exported symbols.

Source/WebKit2:

Add WebKitSecurityManager object associated to a WebKitWebContext
to get/set the security policy of a URI scheme.

• GNUmakefile.list.am: Add new files to compilation.
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode the list of
schemes to be reigstered as Local, NoAccess, DisplayIsolated and
CORSEnabled.
(WebKit::WebProcessCreationParameters::decode): Decode the list of
schemes to be reigstered as Local, NoAccess, DisplayIsolated and
CORSEnabled.

• Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters): Add new parameters to be able to
register schemes as Local, NoAccess, DisplayIsolated and
CORSEnabled.

• UIProcess/API/gtk/WebKitSecurityManager.cpp: Added.

(webkit_security_manager_init):
(webkitSecurityManagerFinalize):
(webkit_security_manager_class_init):
(webkitSecurityManagerCreate): Private function to create the
WebKitSecurityManager object associated to the given
WebKitWebContext.
(registerSecurityPolicyForURIScheme):
(checkSecurityPolicyForURIScheme):
(webkit_security_manager_register_uri_scheme_as_local):
(webkit_security_manager_uri_scheme_is_local):
(webkit_security_manager_register_uri_scheme_as_no_access):
(webkit_security_manager_uri_scheme_is_no_access):
(webkit_security_manager_register_uri_scheme_as_display_isolated):
(webkit_security_manager_uri_scheme_is_display_isolated):
(webkit_security_manager_register_uri_scheme_as_secure):
(webkit_security_manager_uri_scheme_is_secure):
(webkit_security_manager_register_uri_scheme_as_cors_enabled):
(webkit_security_manager_uri_scheme_is_cors_enabled):
(webkit_security_manager_register_uri_scheme_as_empty_document):
(webkit_security_manager_uri_scheme_is_empty_document):

• UIProcess/API/gtk/WebKitSecurityManager.h: Added.
• UIProcess/API/gtk/WebKitSecurityManagerPrivate.h: Added.
• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_get_security_manager): Return the
WebKitSecurityManager object, creating it before if it doesn't exist.

• UIProcess/API/gtk/WebKitWebContext.h:
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitSecurityManager.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
• UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextSecurityPolicy):
(beforeAll):

• UIProcess/API/gtk/webkit2.h: Add WebKitSecurityManager.h.
• UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess): Copy new vector
schemes.
(WebKit::WebContext::registerURLSchemeAsLocal): Send a message to
WebProcess to register the given URL scheme as Local.
(WebKit::WebContext::registerURLSchemeAsNoAccess): Send a message
to WebProcess to register the given URL scheme as NoAccess.
(WebKit::WebContext::registerURLSchemeAsDisplayIsolated): Send a
message to WebProcess to register the given URL scheme as
DisplayIsolated.
(WebKit::WebContext::registerURLSchemeAsCORSEnabled): Send a
message to WebProcess to register the given URL scheme as
CORSEnabled.

• UIProcess/WebContext.h:

(WebContext):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::registerURLSchemeAsLocal): Register the
given URL scheme as Local in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsNoAccess): Register the
given URL scheme as NoAccess in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsDisplayIsolated): Register
the given URL scheme as DisplayIsolated in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsCORSEnabled): Register the
given URL scheme as CORSEnabled in the SchemeRegistry.

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in: Add new messages.

4:15 AM Changeset in webkit [128988] by Patrick Gansterer

• 14 edits in trunk/Source

[WIN] Use BString in favour of BSTR to improve memory management
​https://bugs.webkit.org/show_bug.cgi?id=93128

Reviewed by Anders Carlsson.

BString automatically calls SysFreeString() in its destructor which helps
avoiding memory leaks. So it should be used instead of BSTR directly.
Add operator& to BString to allow its usage for out parameters too (like COMPtr).
This fixes already a few memory leaks in the existing code.

Source/WebCore:

• platform/win/BString.cpp:

(WebCore::BString::~BString):
(WebCore::BString::adoptBSTR):
(WebCore::BString::clear):
(WebCore):

• platform/win/BString.h:

(BString):
(WebCore::BString::operator&):

Source/WebKit/win:

• DefaultPolicyDelegate.cpp:

(DefaultPolicyDelegate::decidePolicyForNavigationAction):
(DefaultPolicyDelegate::decidePolicyForMIMEType):
(DefaultPolicyDelegate::unableToImplementPolicyWithError):

• MarshallingHelpers.cpp:

(MarshallingHelpers::KURLToBSTR):
(MarshallingHelpers::CFStringRefToBSTR):
(MarshallingHelpers::stringArrayToSafeArray):
(MarshallingHelpers::safeArrayToStringArray):

• WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::runJavaScriptPrompt):

• WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::checkGrammarOfString):
(WebEditorClient::getGuessesForWord):

• WebFrame.cpp:

(WebFrame::canProvideDocumentSource):

• WebHistory.cpp:

(WebHistory::removeItem):
(WebHistory::addItem):

• WebIconDatabase.cpp:

(WebIconDatabase::startUpIconDatabase):

• WebNotificationCenter.cpp:

(WebNotificationCenter::postNotification):

• WebPreferences.cpp:

(WebPreferences::setStringValue):

• WebView.cpp:

(toAtomicString):
(toString):
(toKURL):
(PreferencesChangedOrRemovedObserver::onNotify):
(WebView::close):
(WebView::canShowMIMEType):
(WebView::initWithFrame):
(WebView::setApplicationNameForUserAgent):
(WebView::setCustomUserAgent):
(WebView::userAgentForURL):
(WebView::setCustomTextEncodingName):
(WebView::customTextEncodingName):
(WebView::setPreferences):
(WebView::searchFor):
(WebView::executeCoreCommandByName):
(WebView::markAllMatchesForText):
(WebView::setGroupName):
(WebView::registerURLSchemeAsLocal):
(WebView::replaceSelectionWithText):
(WebView::onNotify):
(WebView::notifyPreferencesChanged):
(WebView::MIMETypeForExtension):
(WebView::standardUserAgentWithApplicationName):
(WebView::addAdditionalPluginDirectory):
(WebView::registerEmbeddedViewMIMEType):
(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::geolocationDidFailWithError):
(WebView::setDomainRelaxationForbiddenForURLScheme):
(WebView::setCompositionForTesting):
(WebView::confirmCompositionForTesting):

4:12 AM Changeset in webkit [128987] by Simon Hausmann

• 2 edits in trunk/Source/WebCore

[Qt] Link failure with bfd linker on --minimal build
​https://bugs.webkit.org/show_bug.cgi?id=97075

Reviewed by Tor Arne Vestbø.

Fix two dependency errors triggered by --minimal:

• GStreamerVersioning.cpp uses functions from libgstvideo (gst_video_format_parse_caps), so we need to pull

that module not only when video is enabled by generally when using gstreamer.

• GraphicsSurfaceGLX depends on Xlib (XOpenDisplay, etc.), so we need to do CONFIG += x11 to get that and not

implicitly rely on x11 netscape plugins being enabled.

• WebCore.pri:

3:55 AM Changeset in webkit [128986] by sergio@webkit.org

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Updated expectations for the WK2 GTK bot.

• platform/gtk-wk2/TestExpectations:

3:52 AM Changeset in webkit [128985] by commit-queue@webkit.org

• 140 edits in trunk/LayoutTests

[EFL] tables/mozilla tests need rebaseline (Part 3)
​https://bugs.webkit.org/show_bug.cgi?id=97090

Unreviewed EFL gardening.

Rebaseline pixel tests expectations for tables/mozilla/marvin/x_*
tests.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_caption_align_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_caption_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_caption_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_caption_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_span-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_width_pct-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_width_px-expected.png:
• platform/efl/tables/mozilla/marvin/x_col_width_rel-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_span-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
• platform/efl/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
• platform/efl/tables/mozilla/marvin/x_table-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_cellpadding-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_cellspacing-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_rules_groups-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_rules_none-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_width_pct-expected.png:
• platform/efl/tables/mozilla/marvin/x_table_width_px-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_colspan-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_height-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_nowrap-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_rowspan-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_td_width-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_colspan-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_height-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_nowrap-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_rowspan-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_th_width-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_class-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_id-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_style-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/x_tr_valign_top-expected.png:

3:45 AM Changeset in webkit [128984] by commit-queue@webkit.org

• 175 edits in trunk/LayoutTests

[EFL] tables/mozilla tests need rebaseline (Part 4)
​https://bugs.webkit.org/show_bug.cgi?id=97091

Unreviewed EFL gardening.

Rebaseline remaining pixel test expectations for
tables/mozilla/marvin/ tests.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/tables/mozilla/marvin/backgr_index-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
• platform/efl/tables/mozilla/marvin/body_col-expected.png:
• platform/efl/tables/mozilla/marvin/body_tbody-expected.png:
• platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
• platform/efl/tables/mozilla/marvin/body_thead-expected.png:
• platform/efl/tables/mozilla/marvin/col_span-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_span-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_width_pct-expected.png:
• platform/efl/tables/mozilla/marvin/colgroup_width_px-expected.png:
• platform/efl/tables/mozilla/marvin/table_frame_border-expected.png:
• platform/efl/tables/mozilla/marvin/table_frame_box-expected.png:
• platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.png:
• platform/efl/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.png:
• platform/efl/tables/mozilla/marvin/table_row_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/table_row_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/table_row_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/table_rules_all-expected.png:
• platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
• platform/efl/tables/mozilla/marvin/table_rules_none-expected.png:
• platform/efl/tables/mozilla/marvin/tables_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/tables_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/tables_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_black-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_blue-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_gray-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_green-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_lime-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_navy-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_olive-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_purple-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_red-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_silver-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_teal-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_white-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow-expected.png:
• platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tables_border_0-expected.png:
• platform/efl/tables/mozilla/marvin/tables_border_1-expected.png:
• platform/efl/tables/mozilla/marvin/tables_border_2-expected.png:
• platform/efl/tables/mozilla/marvin/tables_border_3-expected.png:
• platform/efl/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
• platform/efl/tables/mozilla/marvin/tables_caption_align_top-expected.png:
• platform/efl/tables/mozilla/marvin/tables_cellpadding-expected.png:
• platform/efl/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
• platform/efl/tables/mozilla/marvin/tables_cellspacing-expected.png:
• platform/efl/tables/mozilla/marvin/tables_class-expected.png:
• platform/efl/tables/mozilla/marvin/tables_default-expected.png:
• platform/efl/tables/mozilla/marvin/tables_id-expected.png:
• platform/efl/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
• platform/efl/tables/mozilla/marvin/tables_style-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_colspan-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_height-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_nowrap-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_rowspan-expected.png:
• platform/efl/tables/mozilla/marvin/tables_td_width-expected.png:
• platform/efl/tables/mozilla/marvin/tables_th_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/tables_th_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/tables_th_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/tables_th_colspan-expected.png:
• platform/efl/tables/mozilla/marvin/tables_th_height-expected.png:
• platform/efl/tables/mozilla/marvin/tables_th_rowspan-expected.png:
• platform/efl/tables/mozilla/marvin/tables_th_width-expected.png:
• platform/efl/tables/mozilla/marvin/tables_width_percent-expected.png:
• platform/efl/tables/mozilla/marvin/tables_width_px-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/td_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/td_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/th_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/th_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
• platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
• platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
• platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
• platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
• platform/efl/tables/mozilla/marvin/thead_char-expected.png:
• platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_black-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_blue-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_gray-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_green-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_lime-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_navy-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_olive-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_purple-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_red-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_silver-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_teal-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_white-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png:
• platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png:
• platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.png:
• platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.png:
• platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.png:
• platform/efl/tables/mozilla/marvin/tr_valign_top-expected.png:

3:17 AM Changeset in webkit [128983] by commit-queue@webkit.org

• 93 edits
  87 adds in trunk/LayoutTests

[EFL] tables/mozilla tests need rebaseline (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=97089

Unreviewed EFL gardening.

Rebaseline remaining tables/mozilla/ tests and unskip
them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/Skipped:
• platform/efl/tables/mozilla/bugs/45621-expected.txt:
• platform/efl/tables/mozilla/bugs/bug101674-expected.txt:
• platform/efl/tables/mozilla/bugs/bug10269-2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug10565-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug10633-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug106816-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug11026-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug113424-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug11384q-expected.txt:
• platform/efl/tables/mozilla/bugs/bug11384s-expected.txt:
• platform/efl/tables/mozilla/bugs/bug1163-1-expected.txt:
• platform/efl/tables/mozilla/bugs/bug1188-expected.txt:
• platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
• platform/efl/tables/mozilla/bugs/bug120107-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug12384-expected.txt:
• platform/efl/tables/mozilla/bugs/bug126742-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug1271-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug1296-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug1302-expected.txt:
• platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
• platform/efl/tables/mozilla/bugs/bug13118-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
• platform/efl/tables/mozilla/bugs/bug138725-expected.txt:
• platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug1430-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug14929-expected.txt:
• platform/efl/tables/mozilla/bugs/bug154780-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug15544-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug159108-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug17130-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug17130-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug17138-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug18359-expected.txt:
• platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug194024-expected.txt:
• platform/efl/tables/mozilla/bugs/bug196870-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug2123-expected.txt:
• platform/efl/tables/mozilla/bugs/bug215629-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug222846-expected.txt:
• platform/efl/tables/mozilla/bugs/bug24200-expected.txt:
• platform/efl/tables/mozilla/bugs/bug2479-1-expected.txt:
• platform/efl/tables/mozilla/bugs/bug2479-2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/efl/tables/mozilla/bugs/bug2479-4-expected.txt:
• platform/efl/tables/mozilla/bugs/bug2509-expected.txt:
• platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
• platform/efl/tables/mozilla/bugs/bug26553-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug28928-expected.txt:
• platform/efl/tables/mozilla/bugs/bug29058-3-expected.txt:
• platform/efl/tables/mozilla/bugs/bug29157-expected.txt:
• platform/efl/tables/mozilla/bugs/bug29314-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug29326-expected.txt:
• platform/efl/tables/mozilla/bugs/bug2947-expected.txt:
• platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug30559-expected.txt:
• platform/efl/tables/mozilla/bugs/bug30692-expected.txt:
• platform/efl/tables/mozilla/bugs/bug3309-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug3309-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug33137-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug33855-expected.txt:
• platform/efl/tables/mozilla/bugs/bug34176-expected.txt:
• platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
• platform/efl/tables/mozilla/bugs/bug39209-expected.txt:
• platform/efl/tables/mozilla/bugs/bug4093-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug42187-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug4284-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug4382-expected.txt:
• platform/efl/tables/mozilla/bugs/bug43854-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug4427-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug4429-expected.txt:
• platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
• platform/efl/tables/mozilla/bugs/bug46368-1-expected.txt:
• platform/efl/tables/mozilla/bugs/bug46368-2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug46480-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug46480-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug48028-1-expected.txt:
• platform/efl/tables/mozilla/bugs/bug48028-2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug50695-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug51037-expected.txt:
• platform/efl/tables/mozilla/bugs/bug51727-expected.txt:
• platform/efl/tables/mozilla/bugs/bug52505-expected.txt:
• platform/efl/tables/mozilla/bugs/bug52506-expected.txt:
• platform/efl/tables/mozilla/bugs/bug5538-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug55527-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug55545-expected.txt:
• platform/efl/tables/mozilla/bugs/bug56563-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug5797-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug5838-expected.txt:
• platform/efl/tables/mozilla/bugs/bug59354-expected.txt:
• platform/efl/tables/mozilla/bugs/bug60749-expected.txt:
• platform/efl/tables/mozilla/bugs/bug625-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
• platform/efl/tables/mozilla/bugs/bug6404-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug67915-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug69187-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug7112-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug7112-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug73321-expected.txt:
• platform/efl/tables/mozilla/bugs/bug7342-expected.txt:
• platform/efl/tables/mozilla/bugs/bug8032-1-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug8381-expected.txt:
• platform/efl/tables/mozilla/bugs/bug86708-expected.txt:
• platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Added.
• platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug9271-1-expected.txt:
• platform/efl/tables/mozilla/bugs/bug9271-2-expected.txt:
• platform/efl/tables/mozilla/bugs/bug96334-expected.txt:
• platform/efl/tables/mozilla/bugs/bug99948-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
• platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
• platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
• platform/efl/tables/mozilla/marvin/table_frame_border-expected.txt:
• platform/efl/tables/mozilla/marvin/table_frame_box-expected.txt:
• platform/efl/tables/mozilla/marvin/table_rules_all-expected.txt:
• platform/efl/tables/mozilla/marvin/table_rules_none-expected.txt:
• platform/efl/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
• platform/efl/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
• platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
• platform/efl/tables/mozilla/marvin/x_caption_class-expected.txt:
• platform/efl/tables/mozilla/marvin/x_caption_id-expected.txt:
• platform/efl/tables/mozilla/marvin/x_caption_style-expected.txt:
• platform/efl/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt: Added.
• platform/efl/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
• platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/other/cell_widths-expected.txt: Added.
• platform/efl/tables/mozilla/other/move_row-expected.txt:
• platform/efl/tables/mozilla/other/test3-expected.txt:
• platform/efl/tables/mozilla/other/test6-expected.txt:
• platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:

2:43 AM Changeset in webkit [128982] by tommyw@google.com

• 7 edits in trunk

MediaStream API: Rename the RTCIceServer uri parameter to url.
​https://bugs.webkit.org/show_bug.cgi?id=97086

Reviewed by Hajime Morita.

Source/WebCore:

Either the standard has changed or I can't read.
​http://dev.w3.org/2011/webrtc/editor/webrtc.html#dictionary-rtciceserver-members

Existing tests changed to cover this patch.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::parseConfiguration):

LayoutTests:

• fast/mediastream/RTCPeerConnection-expected.txt:
• fast/mediastream/RTCPeerConnection.html:
• fast/mediastream/constructors-expected.txt:
• fast/mediastream/constructors.html:

2:39 AM Changeset in webkit [128981] by rgabor@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails
​https://bugs.webkit.org/show_bug.cgi?id=97084

Unreviewed gardeing.

Patch by Balazs Ankes <​bank@inf.u-szeged.hu> on 2012-09-19

• platform/qt/Skipped:

2:10 AM Changeset in webkit [128980] by kbalazs@webkit.org

• 3 edits in trunk/Source/WebKit2

[Texmap] Potential crash in TextureMapperLayer because of referencing deleted mask/replica layer
​https://bugs.webkit.org/show_bug.cgi?id=96919

Reviewed by Noam Rosenthal.

Delay syncing deleted layers until flushPendingLayerChanges so the UI side state
will contain all changes related to the deletion of a layer. This saves us from
referencing a deleted layer.

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::detachLayer):

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

2:07 AM EFLWebKit edited by marcin.jabrzyk@gmail.com

(diff)

2:04 AM EFLHistoryApiTutorial created by marcin.jabrzyk@gmail.com

Initial version of the page.

1:50 AM Changeset in webkit [128979] by vsevik@chromium.org

• 25 edits
  8 moves in trunk

Unreviewed, rolling out r128976.
​http://trac.webkit.org/changeset/128976
​https://bugs.webkit.org/show_bug.cgi?id=97083

Breaks compilation on QT, Apple WIn (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-19

Source/WebCore:

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSHTMLCanvasElementCustom.cpp:
• bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
• inspector/CodeGeneratorInspector.py:
• inspector/InjectedScriptWebGLModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptCanvasModule.cpp.

(WebCore):
(WebCore::InjectedScriptWebGLModule::InjectedScriptWebGLModule):
(WebCore::InjectedScriptWebGLModule::moduleForState):
(WebCore::InjectedScriptWebGLModule::source):
(WebCore::InjectedScriptWebGLModule::wrapWebGLContext):
(WebCore::InjectedScriptWebGLModule::captureFrame):
(WebCore::InjectedScriptWebGLModule::dropTraceLog):
(WebCore::InjectedScriptWebGLModule::traceLog):
(WebCore::InjectedScriptWebGLModule::replayTraceLog):

• inspector/InjectedScriptWebGLModule.h: Renamed from Source/WebCore/inspector/InjectedScriptCanvasModule.h.

(WebCore):
(InjectedScriptWebGLModule):

• inspector/InjectedScriptWebGLModuleSource.js: Renamed from Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js.

(.):

• inspector/Inspector.json:
• inspector/InspectorAllInOne.cpp:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

• inspector/InspectorWebGLAgent.cpp: Renamed from Source/WebCore/inspector/InspectorCanvasAgent.cpp.

(WebCore):
(WebGLAgentState):
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::~InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::setFrontend):
(WebCore::InspectorWebGLAgent::clearFrontend):
(WebCore::InspectorWebGLAgent::restore):
(WebCore::InspectorWebGLAgent::enable):
(WebCore::InspectorWebGLAgent::disable):
(WebCore::InspectorWebGLAgent::dropTraceLog):
(WebCore::InspectorWebGLAgent::captureFrame):
(WebCore::InspectorWebGLAgent::getTraceLog):
(WebCore::InspectorWebGLAgent::replayTraceLog):
(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorWebGLAgent::injectedScriptWebGLModuleForTraceLogId):

• inspector/InspectorWebGLAgent.h: Renamed from Source/WebCore/inspector/InspectorCanvasAgent.h.

(WebCore):
(InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::create):
(WebCore::InspectorWebGLAgent::enabled):

• inspector/InspectorWebGLInstrumentation.h: Renamed from Source/WebCore/inspector/InspectorCanvasInstrumentation.h.

(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

• inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorWebGLAgent):
(WebCore::InstrumentingAgents::setInspectorWebGLAgent):

• inspector/compile-front-end.py:
• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

• inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

• inspector/front-end/WebGLProfileView.js: Renamed from Source/WebCore/inspector/front-end/CanvasProfileView.js.

(WebInspector.WebGLProfileView):
(WebInspector.WebGLProfileView.prototype.dispose):
(WebInspector.WebGLProfileView.prototype.get statusBarItems):
(WebInspector.WebGLProfileView.prototype.get profile):
(WebInspector.WebGLProfileView.prototype.wasShown):
(WebInspector.WebGLProfileView.prototype.willHide):
(WebInspector.WebGLProfileView.prototype._showTraceLog):
(WebInspector.WebGLProfileView.prototype._onTraceLogItemClick.didReplayTraceLog):
(WebInspector.WebGLProfileView.prototype._onTraceLogItemClick):
(WebInspector.WebGLProfileType):
(WebInspector.WebGLProfileType.prototype.get buttonTooltip):
(WebInspector.WebGLProfileType.prototype.buttonClicked.didStartCapturingFrame):
(WebInspector.WebGLProfileType.prototype.buttonClicked):
(WebInspector.WebGLProfileType.prototype.get treeItemTitle):
(WebInspector.WebGLProfileType.prototype.get description):
(WebInspector.WebGLProfileType.prototype.reset):
(WebInspector.WebGLProfileType.prototype.createTemporaryProfile):
(WebInspector.WebGLProfileType.prototype.createProfile):
(WebInspector.WebGLProfileHeader):
(WebInspector.WebGLProfileHeader.prototype.traceLogId):
(WebInspector.WebGLProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.WebGLProfileHeader.prototype.createView):

• inspector/front-end/WebKit.qrc:
• inspector/front-end/webGLProfiler.css: Renamed from Source/WebCore/inspector/front-end/canvasProfiler.css.

(.webgl-profile-view):
(.webgl-trace-log):
(.webgl-trace-log div):
(#webgl-replay-image-container):
(#webgl-replay-image):

LayoutTests:

• inspector/profiler/webgl/webgl-profiler-get-error.html:
• inspector/profiler/webgl/webgl-profiler-test.js:

(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):

1:43 AM Changeset in webkit [128978] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Qt][Win] Fix rendering of flash content when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=92905

Patch by Simon Hausmann <​simon.hausmann@digia.com> on 2012-09-19
Reviewed by Jocelyn Turcotte.

Fix rendering offset similar to r121441.

• plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paint):
(WebCore::PluginView::setNPWindowRect):

1:30 AM Changeset in webkit [128977] by sergio@webkit.org

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Updated the recently added TestExpectations file for WK2 with the
actual failures from the bot.

• platform/gtk-wk2/TestExpectations:

1:08 AM Changeset in webkit [128976] by commit-queue@webkit.org

• 25 edits
  8 moves in trunk

Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
​https://bugs.webkit.org/show_bug.cgi?id=96917

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-19
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Rename WebGLAgent* and WebGLInstrumentation* files to Canvas* as we will support both 2D and 3D/WebGL canvas instrumentation.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSHTMLCanvasElementCustom.cpp:
• bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
• inspector/CodeGeneratorInspector.py:
• inspector/InjectedScriptCanvasModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.cpp.

(WebCore):
(WebCore::InjectedScriptCanvasModule::InjectedScriptCanvasModule):
(WebCore::InjectedScriptCanvasModule::moduleForState):
(WebCore::InjectedScriptCanvasModule::source):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):

• inspector/InjectedScriptCanvasModule.h: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.h.

(WebCore):
(InjectedScriptCanvasModule):

• inspector/InjectedScriptCanvasModuleSource.js: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js.

(.):

• inspector/Inspector.json:
• inspector/InspectorAllInOne.cpp:
• inspector/InspectorCanvasAgent.cpp: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.cpp.

(WebCore):
(CanvasAgentState):
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::setFrontend):
(WebCore::InspectorCanvasAgent::clearFrontend):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModuleForTraceLogId):

• inspector/InspectorCanvasAgent.h: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.h.

(WebCore):
(InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::create):
(WebCore::InspectorCanvasAgent::enabled):

• inspector/InspectorCanvasInstrumentation.h: Renamed from Source/WebCore/inspector/InspectorWebGLInstrumentation.h.

(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

• inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorCanvasAgent):
(WebCore::InstrumentingAgents::setInspectorCanvasAgent):
(InstrumentingAgents):

• inspector/compile-front-end.py:
• inspector/front-end/CanvasProfileView.js: Renamed from Source/WebCore/inspector/front-end/WebGLProfileView.js.

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype.get statusBarItems):
(WebInspector.CanvasProfileView.prototype.get profile):
(WebInspector.CanvasProfileView.prototype.wasShown):
(WebInspector.CanvasProfileView.prototype.willHide):
(WebInspector.CanvasProfileView.prototype._showTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.get buttonTooltip):
(WebInspector.CanvasProfileType.prototype.buttonClicked.didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype.get treeItemTitle):
(WebInspector.CanvasProfileType.prototype.get description):
(WebInspector.CanvasProfileType.prototype.reset):
(WebInspector.CanvasProfileType.prototype.createTemporaryProfile):
(WebInspector.CanvasProfileType.prototype.createProfile):
(WebInspector.CanvasProfileHeader):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CanvasProfileHeader.prototype.createView):

• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

• inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

• inspector/front-end/WebKit.qrc:
• inspector/front-end/canvasProfiler.css: Renamed from Source/WebCore/inspector/front-end/webGLProfiler.css.

(.canvas-profile-view):
(.canvas-trace-log):
(.canvas-trace-log div):
(#canvas-replay-image-container):
(#canvas-replay-image):

LayoutTests:

• inspector/profiler/webgl/webgl-profiler-get-error.html:
• inspector/profiler/webgl/webgl-profiler-test.js:

(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):

1:04 AM Changeset in webkit [128975] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

[EFL][WK2] waitUntilTitleChangedTo() and waitUntilLoadFinished() needs timeout.
​https://bugs.webkit.org/show_bug.cgi?id=96910

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Currently, the waitUntilTitleChangedTo() and waitUntilLoadFinished()
functions doesn't handle timeout by itself.
And if there are some failed cases that loading is not finished or
title is not changed to the expected string, test case just stopped
with timeout and there is no more information about this such as line
number.

To handle timeout status more properly, timeout parameter is added to
these functions.

• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::LoadFinishedData::LoadFinishedData):
(LoadFinishedData):
(EWK2UnitTest::LoadFinishedData::~LoadFinishedData):
(EWK2UnitTest):
(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::timeOutWhileWaitingUntilLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
(EWK2UnitTest::TitleChangedData::TitleChangedData):
(TitleChangedData):
(EWK2UnitTest::TitleChangedData::~TitleChangedData):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilTitleChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):

• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

1:00 AM Changeset in webkit [128974] by commit-queue@webkit.org

• 68 edits
  4 adds in trunk/LayoutTests

[EFL] tables/mozilla tests need rebaseline (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=97079

Unreviewed EFL gardening.

Rebaseline a first part of the tables/mozilla tests
and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl/Skipped:
• platform/efl/tables/mozilla/collapsing_borders/bug127040-expected.png:
• platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
• platform/efl/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
• platform/efl/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
• platform/efl/tables/mozilla/core/bloomberg-expected.png:
• platform/efl/tables/mozilla/core/bloomberg-expected.txt: Added.
• platform/efl/tables/mozilla/core/borders-expected.png:
• platform/efl/tables/mozilla/core/box_sizing-expected.png:
• platform/efl/tables/mozilla/core/captions-expected.png:
• platform/efl/tables/mozilla/core/captions-expected.txt:
• platform/efl/tables/mozilla/core/cell_heights-expected.png:
• platform/efl/tables/mozilla/core/cell_heights-expected.txt:
• platform/efl/tables/mozilla/core/col_span-expected.png:
• platform/efl/tables/mozilla/core/col_widths_auto_auto-expected.png:
• platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
• platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Added.
• platform/efl/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
• platform/efl/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
• platform/efl/tables/mozilla/core/col_widths_auto_fix-expected.png:
• platform/efl/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
• platform/efl/tables/mozilla/core/col_widths_auto_per-expected.png:
• platform/efl/tables/mozilla/core/col_widths_fix_auto-expected.png:
• platform/efl/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
• platform/efl/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
• platform/efl/tables/mozilla/core/col_widths_fix_fix-expected.png:
• platform/efl/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
• platform/efl/tables/mozilla/core/col_widths_fix_per-expected.png:
• platform/efl/tables/mozilla/core/margins-expected.png:
• platform/efl/tables/mozilla/core/margins-expected.txt:
• platform/efl/tables/mozilla/core/misc-expected.png:
• platform/efl/tables/mozilla/core/misc-expected.txt: Added.
• platform/efl/tables/mozilla/core/nested1-expected.png:
• platform/efl/tables/mozilla/core/one_row-expected.png:
• platform/efl/tables/mozilla/core/row_span-expected.png:
• platform/efl/tables/mozilla/core/row_span-expected.txt: Added.
• platform/efl/tables/mozilla/core/table_frame-expected.png:
• platform/efl/tables/mozilla/core/table_heights-expected.png:
• platform/efl/tables/mozilla/core/table_rules-expected.png:
• platform/efl/tables/mozilla/core/table_rules-expected.txt:
• platform/efl/tables/mozilla/core/table_widths-expected.png:
• platform/efl/tables/mozilla/dom/appendCol2-expected.png:
• platform/efl/tables/mozilla/dom/appendRowsExpand1-expected.png:
• platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
• platform/efl/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
• platform/efl/tables/mozilla/dom/deleteCellsShrink1-expected.png:
• platform/efl/tables/mozilla/dom/deleteCellsShrink2-expected.png:
• platform/efl/tables/mozilla/dom/deleteCol1-expected.png:
• platform/efl/tables/mozilla/dom/deleteCol2-expected.png:
• platform/efl/tables/mozilla/dom/deleteCol3-expected.png:
• platform/efl/tables/mozilla/dom/deleteColGroup1-expected.png:
• platform/efl/tables/mozilla/dom/deleteColGroup2-expected.png:
• platform/efl/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
• platform/efl/tables/mozilla/dom/deleteRowsShrink1-expected.png:
• platform/efl/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
• platform/efl/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
• platform/efl/tables/mozilla/dom/insertCellsExpand1-expected.png:
• platform/efl/tables/mozilla/dom/insertCellsExpand2-expected.png:
• platform/efl/tables/mozilla/dom/insertCellsRebuild1-expected.png:
• platform/efl/tables/mozilla/dom/insertCellsRebuild2-expected.png:
• platform/efl/tables/mozilla/dom/insertColGroups1-expected.png:
• platform/efl/tables/mozilla/dom/insertColGroups2-expected.png:
• platform/efl/tables/mozilla/dom/insertCols1-expected.png:
• platform/efl/tables/mozilla/dom/insertCols2-expected.png:
• platform/efl/tables/mozilla/dom/insertCols3-expected.png:
• platform/efl/tables/mozilla/dom/insertCols4-expected.png:
• platform/efl/tables/mozilla/dom/insertCols5-expected.png:
• platform/efl/tables/mozilla/dom/insertRowsExpand1-expected.png:
• platform/efl/tables/mozilla/dom/insertRowsRebuild1-expected.png:
• platform/efl/tables/mozilla/dom/tableDom-expected.png:
• platform/efl/tables/mozilla/dom/tableDom-expected.txt:

12:26 AM Changeset in webkit [128973] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Skip inspector/extensions/extensions-panel.html
​https://bugs.webkit.org/show_bug.cgi?id=97078

Unreviewed EFL gardening.

Skip inspector/extensions/extensions-panel.html for
EFL port since it started failing after r128910.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19

• platform/efl-wk1/TestExpectations:

12:20 AM Changeset in webkit [128972] by tkent@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix crash in WebFrameImpl::loadHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=96352

Reviewed by Adam Barth.

We have some crash reports with the following stack:

• HistoryItem::shouldDoSameDocumentNavigationTo.
• WebFrameImpl::loadHistoryItem ...

We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.

12:00 AM Changeset in webkit [128971] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Skip several JS tests that crash after r128802
​https://bugs.webkit.org/show_bug.cgi?id=97074

Unreviewed EFL gardening.

Move several JS test cases to TestExpectations because
they are consistently crashing on our debug bots
after r128802.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18

• platform/efl/TestExpectations:

Sep 18, 2012:

11:56 PM Changeset in webkit [128970] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/LayoutTests

[EFL] Generate baseline for media/video-controls-visible-audio-only.html
​https://bugs.webkit.org/show_bug.cgi?id=97073

Unreviewed EFL gardening.

Generate missing baseline for media/video-controls-visible-audio-only.html
on EFL port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18

• platform/efl/media/video-controls-visible-audio-only-expected.txt: Added.

11:48 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

User agent done! (diff)

11:35 PM Changeset in webkit [128969] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[EFL] Move several test cases to efl-wk1 TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=97072

Unreviewed EFL gardening.

Move several test cases to efl-wk1 TestExpectations
since they don't fail on the WebKit2 bots.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18

• platform/efl-wk1/TestExpectations:
• platform/efl/TestExpectations:

11:19 PM Changeset in webkit [128968] by bashi@chromium.org

• 2 edits in trunk/Source/WebCore

[Chromium] SkiaGetGlyphWidthAndExtents() should invert y-axis
​https://bugs.webkit.org/show_bug.cgi?id=97067

Reviewed by Yuta Kitamura.

Invert skBounds.fTop and skBounds.height(). Don't call hb_font_set_ppem().

No new tests. Arabic shadda (U+0651) should be placed more higher when Arabic lam (U+0644) follows it.
Tests under svg/W3C-I18N contain such sequences so these tests cover this change.

• platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:

(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::HarfBuzzNGFace::createFont):

10:57 PM Changeset in webkit [128967] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit2

[EFL][WK2] Add javascript popup API.
​https://bugs.webkit.org/show_bug.cgi?id=95672

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.

Add smart class member function for javascript alert(), confirm() and prompt().

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_run_javascript_alert):
(ewk_view_run_javascript_confirm):
(ewk_view_run_javascript_prompt):

• UIProcess/API/efl/ewk_view.h:
• UIProcess/API/efl/ewk_view_private.h:
• UIProcess/API/efl/ewk_view_ui_client.cpp:

(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(ewk_view_ui_client_attach):

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

Added unit test for javascript popup smart class member function.
(checkAlert):
(TEST_F):
(checkConfirm):
(checkPrompt):

10:41 PM Changeset in webkit [128966] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
​https://bugs.webkit.org/show_bug.cgi?id=96181

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-18
Reviewed by Daniel Bates.

This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.

• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(new):
(_parseLicenseBlock):
(_parseLicenseBlockFromFile):
(_defaultLicenseBlock):
(_licenseBlock):
(_generateHeaderFile):
(_generateImplementationFile):

10:26 PM Changeset in webkit [128965] by bashi@chromium.org

• 2 edits in trunk/Source/WebCore

[Chromium] Don't treat tab as spaces for word-end in HarfBuzzShaper
​https://bugs.webkit.org/show_bug.cgi?id=97068

Reviewed by Yuta Kitamura.

No new tests. fast/text/wide-zero-width-space.html should cover this change.

• platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::normalizeCharacters): Don't treat tab as space.

9:21 PM Changeset in webkit [128964] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

Check settings before registering AVFoundation media engine.
​https://bugs.webkit.org/show_bug.cgi?id=97048
<rdar://problem/12313594>

Reviewed by Dan Bernstein.

Fix the bug introduced in r122676.

• platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Uncomment the call to check AVFoundation settings.

8:39 PM Changeset in webkit [128963] by commit-queue@webkit.org

• 32 edits
  2 adds in trunk

Chromium: Scrollbar with tickmarks doesn't respond to clicks
​https://bugs.webkit.org/show_bug.cgi?id=96049

Patch by Sailesh Agrawal <​sail@chromium.org> on 2012-09-18
Reviewed by Beth Dakin.

.:

Update exported symbols.

• Source/autotools/symbols.filter:

Source/Platform:

Added isAlphaLocked and setIsAlphaLocked.

• chromium/public/WebScrollbar.h:

(WebScrollbar):

Source/WebCore:

Currently when a scrollbar has tickmarks its forced to be visible by setting its alpha to 1.0. The alpha value is reset to its old value at the end of the drawing routine. This approach doesn't work with the hit testing code which relies on the scrollbar's alpha value

Unfortunately there doesn't seem to be anyway to force a scrollbar to be visible. The closest API is -[NSScrollerImpPair lockOverlayScrollerState:]. Unfortunately this locks both the horizontal and vertical scrollbar. It also doesn't expand the knob width.

My fix simply adds a new alphaLocked attribute to the scrollbar. If this attribute is set to true then hit testing will return true.

Test: fast/scrolling/scrollbar-tickmarks-hittest.html

• WebCore.exp.in:
• WebCore.order:
• page/Settings.cpp:

(WebCore):
(WebCore::Settings::setUsesOverlayScrollbars): Sets the usesOverlayScrollbars flag.
(WebCore::Settings::usesOverlayScrollbars): Gets the usesOverlayScrollbars flag.

• page/Settings.h:

(Settings):

• platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):

• platform/Scrollbar.h:

(WebCore::Scrollbar::isAlphaLocked):
(WebCore::Scrollbar::setIsAlphaLocked):
(Scrollbar):

• platform/ScrollbarThemeClient.h:

(ScrollbarThemeClient):

• platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint): Updated to set and unset the alphaLocked attribute.

• platform/chromium/support/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::isAlphaLocked):
(WebKit):
(WebKit::WebScrollbarImpl::setIsAlphaLocked):

• platform/chromium/support/WebScrollbarImpl.h:

(WebScrollbarImpl):

• platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isAlphaLocked):
(WebCore):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setIsAlphaLocked):

• platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbar):
(CCScrollbarLayerImpl):

• platform/mac/NSScrollerImpDetails.mm:

(WebCore::recommendedScrollerStyle): Check the usesOverlayScrollbars setting to see if overlay scrollbars should be forced on.

• platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::shouldScrollbarParticipateInHitTesting): Updated to check the alphaLocked attribute.

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::reset): Resets the usesOverlayScrollbars setting.
(WebCore::InternalSettings::setUsesOverlayScrollbars): Sets the usesOverlayScrollbars setting.
(WebCore):

• testing/InternalSettings.h:

(InternalSettings):

• testing/InternalSettings.idl: Add a new setUsesOverlayScrollbars function.

Source/WebKit/chromium:

Pipe isAlphaLocked and setIsAlphaLocked.

• src/WebPluginScrollbarImpl.cpp:

(WebKit::WebPluginScrollbarImpl::isAlphaLocked):
(WebKit):
(WebKit::WebPluginScrollbarImpl::setIsAlphaLocked):

• src/WebPluginScrollbarImpl.h:

(WebPluginScrollbarImpl):

• src/WebScrollbarThemeClientImpl.cpp:

(WebKit::WebScrollbarThemeClientImpl::isAlphaLocked):
(WebKit):
(WebKit::WebScrollbarThemeClientImpl::setIsAlphaLocked):

• src/WebScrollbarThemeClientImpl.h:

(WebScrollbarThemeClientImpl):

• tests/ScrollbarLayerChromiumTest.cpp:

Source/WebKit2:

Update exported symbols.

• win/WebKit2.def:
• win/WebKit2CFLite.def:

LayoutTests:

• fast/scrolling/scrollbar-tickmarks-hittest-expected.txt: Added.
• fast/scrolling/scrollbar-tickmarks-hittest.html: Added.

8:33 PM Changeset in webkit [128962] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add log macros for EINA_LOG_DOM_XXX series
​https://bugs.webkit.org/show_bug.cgi?id=97061

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.

EFL Webkit2 is using the EINA_LOG_DOM_XXX series in several places to log a message on the specified domain and format.
This patch adds log macros to simplify these logging codes.

• UIProcess/API/efl/ewk_main.cpp:

(ewk_init):

• UIProcess/API/efl/ewk_private.h:
• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_webprocess_crashed):

8:08 PM Changeset in webkit [128961] by noel.gordon@gmail.com

• 1 edit
  10 adds in trunk/LayoutTests

Add partial load tests for PNG images
​https://bugs.webkit.org/show_bug.cgi?id=95707

Reviewed by Adam Barth.

Partial load test: receive a partial number of image bytes and stall forever. The
partial image should be decoded and drawn and the blue <img> background should be
visible.

Progressive load test: receive a partial number of image bytes, stall for 1 second
and then continue to receive all the image bytes. The entire test image should be
decoded and drawn and the blue <img> background should be visible.

• fast/images/resources/dice.png: Added: test image has alpha transparency.
• http/tests/images/png-partial-load-expected.png: Added.
• http/tests/images/png-partial-load-expected.txt: Added.
• http/tests/images/png-partial-load.html: Added.
• http/tests/images/png-progressive-load-expected.png: Added.
• http/tests/images/png-progressive-load-expected.txt: Added.
• http/tests/images/png-progressive-load.html: Added.
• platform/chromium/http/tests/images/png-partial-load-expected.png: Added.
• platform/mac/http/tests/images/png-partial-load-expected.png: Added.

7:37 PM Changeset in webkit [128960] by Martin Robinson

• 7 edits in trunk/Source/WebKit2

[WebKit2] [GTK] Add API for controlling the user agent
​https://bugs.webkit.org/show_bug.cgi?id=95697

Reviewed by Carlos Garcia Campos.

Add API for changing the user agent in WebKit2. This adds two styles of
setting the user agent: complete override and a method that just inserts
the application name and version, but preserves the carefully crafted user agent
in the library.

• UIProcess/API/gtk/WebKitSettings.cpp:

(_WebKitSettingsPrivate): Added a new field to store the user agent.
This is stored in the private data structure, because we can only
set the user agent when attaching the settings to the page.
(webKitSettingsSetProperty): Add hooks for the new user agent property.
(webKitSettingsGetProperty): Ditto.
(webkit_settings_class_init): Ditto.
(webkitSettingsAttachSettingsToPage): Ditto.
(webkit_settings_get_user_agent): Added.
(webkit_settings_set_user_agent): Added.
(webkit_settings_set_user_agent_with_application_name): Added.

• UIProcess/API/gtk/WebKitSettings.h: Added new methods.
• UIProcess/API/gtk/WebKitWebView.cpp: Update the glue for the settings

when attaching and detaching from WebViews.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to

the documentation.

• UIProcess/API/gtk/tests/TestWebKitSettings.cpp: Test the new user agent

property.
(testWebKitSettingsUserAgent): Ditto.
(beforeAll): Ditto.

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::standardUserAgent): Now use the shared WebCore
code when setting the user agent.

6:36 PM WebKitIDL edited by toybabyyou@gmail.com

(diff)

6:36 PM Changeset in webkit [128959] by haraken@chromium.org

• 3 edits
  2 adds in trunk

[V8] Notification.requestPermission(function() {alert();}) crashes
​https://bugs.webkit.org/show_bug.cgi?id=94462

Reviewed by Adam Barth.

Source/WebCore:

Since Notification.requestPermission() is a static method,
we need to use getExecutionContext() instead of retrieving a context
from a DOM object.

Test: http/tests/notifications/notification-request-permission.html

• bindings/v8/custom/V8NotificationCustom.cpp:

(WebCore::V8Notification::requestPermissionCallback):

LayoutTests:

The added test checks if Notification.requestPermission() does not crash.

• http/tests/notifications/notification-request-permission-expected.txt: Added.
• http/tests/notifications/notification-request-permission.html: Added.

6:34 PM Drosera edited by toybabyyou@gmail.com

(diff)

6:33 PM Changeset in webkit [128958] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement PageClientImpl::isViewFocused.
​https://bugs.webkit.org/show_bug.cgi?id=97015

Reviewed by Gyuyoung Kim.

WebKit2/Efl always returns true for PageClientImpl::isViewFocused.
So window.onblur events will not be generated when webview lost focus.

This patch implements isViewFocused to return the current focus of webview.

• UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::isViewFocused):

6:32 PM WebInspector edited by toybabyyou@gmail.com

(diff)

6:20 PM Changeset in webkit [128957] by fpizlo@apple.com

• 24 edits in trunk/Source/JavaScriptCore

DFG should not call out to C++ every time that it tries to put to an object that doesn't yet have array storage
​https://bugs.webkit.org/show_bug.cgi?id=96983

Reviewed by Oliver Hunt.

Introduce more polymorphism into the DFG's array mode support. Use that to
introduce the notion of effectul array modes, where the check for the mode
will perform actions necessary to ensure that we have the mode we want, if
the object is not already in that mode. Also added profiling support for
checking if an object is of a type that would not allow us to create array
storage (like a typed array or a string for example).

This is a ~2x speed-up on loops that transform an object that did not have
indexed storage into one that does.

• JSCTypedArrayStubs.h:

(JSC):

• bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

• bytecode/ArrayProfile.h:

(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::mayInterceptIndexedAccesses):
(ArrayProfile):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::fromObserved):
(DFG):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

• dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeUsesButterfly):
(JSC::DFG::isSlowPutAccess):
(JSC::DFG::benefitsFromStructureCheck):
(JSC::DFG::isEffectful):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):

• dfg/DFGNodeType.h:

(DFG):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(DFG):

• dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• runtime/Arguments.h:

(Arguments):

• runtime/JSNotAnObject.h:

(JSNotAnObject):

• runtime/JSObject.h:

(JSObject):
(JSC::JSObject::ensureArrayStorage):

• runtime/JSString.h:

(JSC::JSString::createStructure):

6:04 PM Changeset in webkit [128956] by shinyak@chromium.org

• 3 edits in trunk/Source/WebCore

[Refactoring] ContentDistributor::distributeSelectionsTo should not change ContentDistribution pool.
​https://bugs.webkit.org/show_bug.cgi?id=96993

Reviewed by Dimitri Glazkov.

Since we would like to reuse ContentDistribution pool, it should not be updated in
ContentDistributor::distributeSelectionsTo. Instead, we should have Vector<bool> to indicate an element is
distributed or not.

No new tests, simple refactoring.

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::distributeSelectionsTo):

• html/shadow/ContentDistributor.h:

(ContentDistributor):

6:03 PM Changeset in webkit [128955] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

Adjust expectation for fast/workers/storage/interrupt-database.html
​https://bugs.webkit.org/show_bug.cgi?id=84696

Unreviewed, expectations change.

It looks like this test is just kinda slow and probably won't timeout if we mark it SLOW.

• platform/chromium/TestExpectations:

5:44 PM Changeset in webkit [128954] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] word-spacing-characters{,-complex} no longer fail on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=94008
​https://bugs.webkit.org/show_bug.cgi?id=94003

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:41 PM Changeset in webkit [128953] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] gradient-with-scaled-ancestor passes on mac lion gpu
​http://bugs.webkit.org/show_bug.cgi?id=96441

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:38 PM Changeset in webkit [128952] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Adjust expectation for fast/css/sticky/sticky-left-percentage.html
​http://webkit.org/b/95136

Unreviewed, expectations change.

The test is only failing on win and linux now.

• platform/chromium/TestExpectations:

5:35 PM Changeset in webkit [128951] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] overflow-auto-with-touch-toggle is no longer failing.
​https://bugs.webkit.org/show_bug.cgi?id=94353

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:32 PM Changeset in webkit [128950] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] fast/css/nested-rounded-corners.html is no longer failing.
​https://bugs.webkit.org/show_bug.cgi?id=94063

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:26 PM Changeset in webkit [128949] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] font-scale-factor.html and simple-paragraph.html are no longer failing.
​https://bugs.webkit.org/show_bug.cgi?id=90741

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:23 PM Changeset in webkit [128948] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] fast/table/border-collapsing/cached-69296.html is no longer failing.
​https://bugs.webkit.org/show_bug.cgi?id=70298

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:20 PM Changeset in webkit [128947] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] fast/js/kde/GlobalObject.html is no longer failing.
​https://bugs.webkit.org/show_bug.cgi?id=75468

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:15 PM Changeset in webkit [128946] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Mark LayoutTests/fullscreen/exit-full-screen-iframe.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=90704

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

5:11 PM Changeset in webkit [128945] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] 2d.imageData.object.round and canvas-ImageData-behavior are no longer failing
​https://bugs.webkit.org/show_bug.cgi?id=94246

Unreviewed, expectations change.

[chromium] The following suppressions appear to be no longer needed
(the tests are passing), so I'm removing them:

BUGWK94246 : canvas/philip/tests/2d.imageData.object.round.html = TEXT
BUGWK94246 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.object.round.html = TEXT
BUGWK94246 : fast/canvas/canvas-ImageData-behaviour.html = TEXT
BUGWK94246 : platform/chromium/virtual/gpu/fast/canvas/canvas-ImageData-behaviour.html = TEXT

• platform/chromium/TestExpectations:

5:06 PM Changeset in webkit [128944] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

fast/dom/Window/anonymous-slot-with-changes.html is no longer failing.
​http://code.google.com/p/chromium/issues/detail?id=33538

Unreviewed, expectations change.

• platform/chromium/TestExpectations:

4:49 PM Changeset in webkit [128943] by commit-queue@webkit.org

• 18 edits
  2 adds in trunk

Title string should be changed when document.title is set to .
​https://bugs.webkit.org/show_bug.cgi?id=96793

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

DocumentLoader::setTitle() function returns without anything (changing
m_pageTitle and calling FrameLoaderClient::setTitle()) when new title
string is empty.
So, when document.title is set to , title string of a browser cannot
be changed.
For applying the change of document.title properly, empty string check
should be removed.

Test: fast/dom/title-text-property-assigning-empty-string.html

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setTitle):

Source/WebKit2:

Added unit test for setting document.title and checking the title
string with title,changed signal and ewk_view_title_get() function.

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

Change dump format of dumpTitleChanges more understandable.
Uses single quotation marks for the title string.

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):

• DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didReceiveTitle):

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameTitleChanged):

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewTitleChanged):

• DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):

• DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::titleChanged):

• DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didReceiveTitle):

• DumpRenderTree/wx/DumpRenderTreeWx.cpp:

(LayoutWebViewEventHandler::OnReceivedTitleEvent):

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveTitleForFrame):

LayoutTests:

Added layout tests for assigning empty string to title text.
And modified expected results according to the change of
dumpTitleChanges.

• fast/dom/title-text-property-2-expected.txt: Modified expected result.
• fast/dom/title-text-property-assigning-empty-string-expected.txt: Added.
• fast/dom/title-text-property-assigning-empty-string.html: Added.
• fast/dom/title-text-property-expected.txt: Modified expected result.
• fast/dom/title-text-property.html: Apply modified dumpTitleChanges.

4:19 PM Changeset in webkit [128942] by hclam@chromium.org

• 3 edits
  3 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r128939.
​http://trac.webkit.org/changeset/128939
​https://bugs.webkit.org/show_bug.cgi?id=96135

Failing test_shell_tests.

• WebKit.gypi:
• src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):

• tests/WebImageTest.cpp: Removed.
• tests/data/black-and-white.ico: Removed.
• tests/data/white-1x1.png: Removed.

3:43 PM Changeset in webkit [128941] by Simon Fraser

• 3 edits in trunk/Source/WebCore

fast/forms/search-event-delay.html is asserting in markAllMisspellingsAndBadGrammarInRanges()
​https://bugs.webkit.org/show_bug.cgi?id=82761

Reviewed by Ryosuke Niwa.

Speculative fix for this assertion: have InternalSettings save
and restore the value of the "unifiedTextCheckerEnabled" setting
between tests, so that tests change the value of this setting don't
affect later tests.

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

• testing/InternalSettings.h:

(Backup):

3:38 PM Changeset in webkit [128940] by Lucas Forschler

• 1 copy in branches/safari-534.58-branch

New Branch.

3:29 PM Changeset in webkit [128939] by hclam@chromium.org

• 3 edits
  3 adds in trunk/Source/WebKit/chromium

[chromium] WebImage should use ImageDecoder directly
​https://bugs.webkit.org/show_bug.cgi?id=96135

Reviewed by Adam Barth.

This patch is for preparation of deferred image decoding.
ImageSource will be used as a portal to access deferred image decoder
by BitmapImage, it should not be accessible through WebKit APIs.

WebImage now calls ImageDecoder directly which is the actual
implementation of an image decoder.

Tests: WebImageTest.PNGImage

WebImageTest.ICOImage

• WebKit.gypi:
• src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):

• tests/WebImageTest.cpp: Added.

(WebKit):
(WebKit::readFile):
(WebKit::TEST):

• tests/data/black-and-white.ico: Added.
• tests/data/white-1x1.png: Added.

3:26 PM Changeset in webkit [128938] by Lucas Forschler

• 2 edits in branches/safari-536.27-branch/Source/WebCore

Merged r128845.

3:26 PM Changeset in webkit [128937] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Include PhantomArguments in DFGDisassembly
​https://bugs.webkit.org/show_bug.cgi?id=97043

Reviewed by Geoffrey Garen.

• dfg/DFGNode.h:

(JSC::DFG::Node::willHaveCodeGenOrOSR):

3:03 PM Changeset in webkit [128936] by Lucas Forschler

• 2 edits in branches/safari-536.27-branch/Source/WebCore

Merged r126666. <rdar://problem/12030952>

3:00 PM Changeset in webkit [128935] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Division by zero crash in BackingStore::scroll
​https://bugs.webkit.org/show_bug.cgi?id=97046
<rdar://problem/11722564>

Reviewed by Dan Bernstein.

It appears that DrawingAreaImpl::scroll can be called with an empty scroll rect. Do nothing
if that's the case. Also, assert that the scrolling rect in BackingStoreMac is never empty.

• UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::scroll):

• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):

2:39 PM Changeset in webkit [128934] by Lucas Forschler

• 4 edits in branches/safari-536.27-branch/Source

Versioning.

2:38 PM Changeset in webkit [128933] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
​https://bugs.webkit.org/show_bug.cgi?id=97033

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-09-18
Reviewed by Rob Buis.

Using these preferred public methods (the latter has a note to be made private) ensures that
the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
and spellCheckingRequestCancelled.

Internally reviewed by Mike Fenton.

By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::getSpellChecker):

• WebKitSupport/InputHandler.h:

(InputHandler):

2:37 PM Changeset in webkit [128932] by jchaffraix@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

More unreviewed rebaseline after r128906.

• platform/chromium-mac/fast/invalid/residual-style-expected.txt:
• platform/chromium-win-xp/fast/invalid/residual-style-expected.txt: Added.
• platform/chromium-win-xp/tables/mozilla/bugs/bug56563-expected.png: Added.

2:31 PM Changeset in webkit [128931] by ojan@chromium.org

• 1 edit
  5 adds in trunk/LayoutTests

​http://trac.webkit.org/changeset/128912 caused these tests to start failing.
Looks like a garden-o-matic/webkit-patch bug.

• platform/chromium-linux/css3/filters/filter-change-repaint-composited-expected.png: Added.
• platform/chromium-linux/css3/filters/filter-change-repaint-expected.png: Added.
• platform/chromium-linux/css3/filters/filter-repaint-child-layers-expected.png: Added.
• platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
• platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-expected.png: Added.

2:28 PM Changeset in webkit [128930] by Lucas Forschler

• 1 copy in branches/safari-536.27-branch

New Branch.

2:27 PM Changeset in webkit [128929] by fpizlo@apple.com

• 4 edits in trunk/LayoutTests

Unreviewed gardening after ​http://trac.webkit.org/changeset/128928

• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/qt/Skipped:

2:17 PM Changeset in webkit [128928] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r128802): It made some JS tests crash
​https://bugs.webkit.org/show_bug.cgi?id=97001

Reviewed by Mark Hahnenberg.

IndexingHeaderInlineMethods was incorrectly assuming that if the HasArrayStorage bit is clear, then that means that indexing payload capacity is zero.

• runtime/IndexingHeaderInlineMethods.h:

(JSC::IndexingHeader::preCapacity):
(JSC::IndexingHeader::indexingPayloadSizeInBytes):

1:40 PM Changeset in webkit [128927] by commit-queue@webkit.org

• 7 edits
  2 copies
  1 move
  3 adds
  1 delete in trunk

Text Autosizing: Ignore constrained heights in certain circumstances.
​https://bugs.webkit.org/show_bug.cgi?id=96848

Patch by John Mellor <​johnme@chromium.org> on 2012-09-18
Reviewed by Julien Chaffraix.

Source/WebCore:

Ignore constrained heights on html and body elements, as some sites
(e.g. wikipedia) set height:100% on these, without intending to
constrain the height of descendants.

Also ignore constrained heights on ancestors of floats and out-of-flow
positioned elements with no height set, since the height of these is
determined independently from their ancestors.

Test: fast/text-autosizing/constrained-height-body.html

fast/text-autosizing/constrained-out-of-flow.html
fast/text-autosizing/constrained-then-float-ancestors.html
fast/text-autosizing/constrained-then-position-absolute-ancestors.html
fast/text-autosizing/constrained-then-position-fixed-ancestors.html

• rendering/TextAutosizer.cpp:

(WebCore::contentHeightIsConstrained):

Adjusted constrainedness algorithm.

LayoutTests:

Added 3 tests, updated 2, and removed 1. See below.

• fast/text-autosizing/constrained-height-body-expected.html: Added.
• fast/text-autosizing/constrained-height-body.html: Added.

Checks that constrained height html & body are ignored.

• fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors-expected.html: Removed.
• fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors.html: Removed.

Removed because this situation is no longer possible now that
heightless position:absolute elements are always unconstrained.

• fast/text-autosizing/constrained-out-of-flow-expected.html: Added.
• fast/text-autosizing/constrained-out-of-flow.html: Added.

Checks that floats and out-of-flow positioned elements do not ignore
constraints on themselves.

• fast/text-autosizing/constrained-then-float-ancestors-expected.html: Added.
• fast/text-autosizing/constrained-then-float-ancestors.html: Added.

Checks that floats ignore constraints on ancestors.

• fast/text-autosizing/constrained-then-position-absolute-ancestors-expected.html:
• fast/text-autosizing/constrained-then-position-absolute-ancestors.html:

Added position:relative to emphasize that the ancestor's constrained
height is actually being ignored, not just skipped over; and updated
explanation.

• fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
• fast/text-autosizing/constrained-then-position-fixed-ancestors.html:

Updated explanation (since the test still passes, but for a
different reason).

1:35 PM Changeset in webkit [128926] by cevans@google.com

• 1 edit in branches/chromium/1229/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp

Merge 128415
BUG=147592
Review URL: ​https://codereview.chromium.org/10951014

1:34 PM Changeset in webkit [128925] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1229

Merge 128263
BUG=147592
Review URL: ​https://codereview.chromium.org/10948013

1:07 PM Changeset in webkit [128924] by tommyw@google.com

• 6 edits in trunk/Source

MediaStream API: Create a flag to enable PeerConnection00
​https://bugs.webkit.org/show_bug.cgi?id=96989

Reviewed by Adam Barth.

Adding the functionality to separately enable/disable PeerConnection00.
For now it is enabled by default.

Source/WebCore:

Not testable, nor likely to cause issues.

• bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

• bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::deprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setDeprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):
(RuntimeEnabledFeatures):

Source/WebKit/chromium:

• public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

• src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDeprecatedPeerConnection):
(WebKit):
(WebKit::WebRuntimeFeatures::isDeprecatedPeerConnectionEnabled):

12:55 PM Changeset in webkit [128923] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Date picker isn't inputting after 'OK'
​https://bugs.webkit.org/show_bug.cgi?id=97031

PR208052

Patch by Jessica Cao <​jecao@rim.com> on 2012-09-18
Reviewed by Rob Buis

Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.

• WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValueAndClosePopup):

12:37 PM Changeset in webkit [128922] by ap@apple.com

• 2 edits in trunk/LayoutTests

Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg is failing
​https://bugs.webkit.org/show_bug.cgi?id=93589

• platform/mac/Skipped: Skipping the test on Mac.

12:26 PM Changeset in webkit [128921] by yoli@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Popup page should reference the client with a weak pointer
​https://bugs.webkit.org/show_bug.cgi?id=97028

Reviewed by Rob Buis.

RIM PR# 209847.
Internally reviewed by Mike Fenton.

Store the pointer in a ref-coutned shared object, and clear the pointer
when the client is going to be destroyed, so it won't be accessed by
the JS function afterwards.

• WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
(WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
(WebCore::PagePopupBlackBerry::init):
(WebCore::setValueAndClosePopupCallback):
(WebCore::popUpExtensionFinalize):
(WebCore::PagePopupBlackBerry::installDOMFunction):
(WebCore::PagePopupBlackBerry::closePopup):

• WebCoreSupport/PagePopupBlackBerry.h:

(PagePopupBlackBerry):
(SharedClientPointer):
(WebCore::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
(WebCore::PagePopupBlackBerry::SharedClientPointer::clear):
(WebCore::PagePopupBlackBerry::SharedClientPointer::get):

12:09 PM Changeset in webkit [128920] by jsbell@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, add missing newline to expectation for test only run
as part of chromium's content_browsertests.

• storage/indexeddb/basics-shared-workers-expected.txt:

11:58 AM Changeset in webkit [128919] by ojan@chromium.org

• 2 edits in trunk/LayoutTests

Remove lines for tests that haven't failed on any Chromium bot for the last 500 runs.

• platform/chromium/TestExpectations:

11:56 AM Changeset in webkit [128918] by kareng@chromium.org

• 1 add in branches/chromium/1270/codereview.settings

adding for easy drover

11:54 AM Changeset in webkit [128917] by kareng@chromium.org

• 1 copy in branches/chromium/1270

creating m23 chrome branch for webkit

11:52 AM Changeset in webkit [128916] by jchaffraix@webkit.org

• 5 edits in trunk/LayoutTests

Rebaseline after r128906. All the differences were expected.

• platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
• platform/gtk/fast/invalid/residual-style-expected.txt:
• platform/mac/fast/invalid/residual-style-expected.txt:

11:26 AM Changeset in webkit [128915] by ojan@chromium.org

• 6 edits
  8 moves in trunk/LayoutTests

Complete some forgotten rebaselines. The new results match other ports/platforms.

• fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/024-expected.txt.
• fast/block/margin-collapse/025-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/025-expected.txt.
• fast/block/margin-collapse/block-inside-inline/025-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt.
• fast/block/margin-collapse/empty-clear-blocks-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt.
• platform/chromium-mac-snowleopard/fast/block/float/024-expected.png:
• platform/chromium-mac-snowleopard/fast/block/margin-collapse/empty-clear-blocks-expected.png:
• platform/chromium-mac/fast/block/float/024-expected.png:
• platform/chromium-mac/fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/024-expected.txt.
• platform/chromium-mac/fast/block/margin-collapse/025-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/025-expected.txt.
• platform/chromium-mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt.
• platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
• platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt.
• platform/chromium/TestExpectations:

11:18 AM Changeset in webkit [128914] by commit-queue@webkit.org

• 25 edits
  8 deletes in trunk

Revert 128780, 128676, 128645
​https://bugs.webkit.org/show_bug.cgi?id=97022

Patch by Bo Liu <​boliu@chromium.org> on 2012-09-18
Reviewed by Adam Barth.

I made these revisions to add in-place reload behavior to ImagesEnabled setting.
Reverting this for now due to them causing performance regression in
chromium, possibly caused by increased calls to
PermissionClient::imageAllowed.

.:

• Source/autotools/symbols.filter:

Source/WebCore:

• WebCore.exp.in:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):

• loader/cache/CachedImage.h:

(WebCore::CachedImage::stillNeedsLoad):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

• loader/cache/CachedResource.h:
• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):

• loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

• page/Settings.cpp:

(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
(WebCore::Settings::setImagesEnabled):

• page/Settings.h:

(Settings):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):

• testing/InternalSettings.h:

(Backup):
(InternalSettings):

• testing/InternalSettings.idl:

Source/WebKit2:

• win/WebKit2.def:

LayoutTests:

• fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
• fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
• fast/loader/resources/image1.html: Removed.
• fast/loader/resources/image2.html: Removed.
• platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
• platform/chromium/permissionclient/image-permissions-expected.txt:
• platform/chromium/permissionclient/image-permissions.html:
• platform/chromium/permissionclient/resources/image.html:
• platform/wk2/Skipped:

11:15 AM Changeset in webkit [128913] by sergio@webkit.org

• 1 edit
  1 add
  1 delete in trunk/LayoutTests

[GTK] [WK2] Replace Skipped with TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=97029

Reviewed by Martin Robinson.

Replace the Skipped file with a TestExpectations file which adds
lots of semantics.

• platform/gtk-wk2/Skipped: Removed.
• platform/gtk-wk2/TestExpectations: Added.

11:12 AM Changeset in webkit [128912] by ojan@chromium.org

• 5 edits
  5 adds in trunk/LayoutTests

Rebaseline tests. Mostly failing due to slight pixel differences.

• platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
• platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
• platform/chromium-win/css3/filters/effect-brightness-expected.png:

These two results are darker now, but this matches the mac/linux results.

• platform/chromium-win/css3/filters/filter-change-repaint-composited-expected.png: Added.
• platform/chromium-win/css3/filters/filter-change-repaint-expected.png: Added.
• platform/chromium-win/css3/filters/filter-repaint-child-layers-expected.png: Added.
• platform/chromium-win/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
• platform/chromium-win/css3/filters/filter-repaint-composited-fallback-expected.png: Added.
• platform/chromium/TestExpectations:

11:09 AM Changeset in webkit [128911] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Skipping large number of tests that have been failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=97026

Due to the state of the windows bots a large number of tests have been failing for quite some time and it is difficult to tell when the failure started.
For now I'm adding these tests to the skip list to get the bots greener and will come back to them later.

• platform/win/Skipped:

11:02 AM Changeset in webkit [128910] by commit-queue@webkit.org

• 6 edits in trunk

Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected
​https://bugs.webkit.org/show_bug.cgi?id=96148

Patch by John J. Barton <​johnjbarton@chromium.org> on 2012-09-18
Reviewed by Vsevolod Vlasov.

Source/WebCore:

ExtensionView ctor calls setDefaultFocusedElement with its iframe,
ExtensionPanel ctor calls setDefaultFocusedElement with the extensionView
and ExtensionPanel's setDefaultFocusedElement calls its grandparent impl

Tests: Added hasFocus test to extensions/extension-panel.html

• inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):

• inspector/front-end/ExtensionView.js:

(WebInspector.ExtensionView):

LayoutTests:

Add one line to verify that the panel's document has focus after show

• inspector/extensions/extensions-panel-expected.txt:
• inspector/extensions/extensions-panel.html:

11:00 AM Changeset in webkit [128909] by ojan@chromium.org

• 35 edits in trunk/LayoutTests

Rebaseline tests failing due to expected slight pixel differences.

• platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
• platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
• platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
• platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
• platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
• platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
• platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
• platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
• platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
• platform/chromium-mac/css3/filters/effect-combined-expected.png:
• platform/chromium-mac/css3/filters/effect-opacity-expected.png:
• platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
• platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
• platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
• platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
• platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
• platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
• platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
• platform/chromium-win/css3/filters/effect-combined-expected.png:
• platform/chromium-win/css3/filters/effect-opacity-expected.png:
• platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
• platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
• platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
• platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
• platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
• platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
• platform/chromium/TestExpectations:

10:57 AM Changeset in webkit [128908] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

WTFString::show doesn't dump non-ASCII characters in a readable manner
​https://bugs.webkit.org/show_bug.cgi?id=96749

Patch by Glenn Adams <​glenn@skynav.com> on 2012-09-18
Reviewed by Benjamin Poulain.

Dump non-ASCII characters in a useful form for debugging.

• wtf/text/WTFString.cpp:

(asciiDebug):
Dump non-ASCII characters (i.e., UTF-16 code elements) as well as non-printable ASCII characters
using \uXXXX format. Also escape \ as
in order to remove ambiguity.

10:54 AM Changeset in webkit [128907] by Martin Robinson

• 15 edits in trunk/Source

[GTK] [WebKit2] Use XComposite window for accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=94417

Reviewed by Carlos Garcia Campos.

Instead of rendering directly to the widget's native window, render to an
offscreen window redirected to a Pixmap with XComposite.

Source/WebCore:

No new tests. This will be covered by the existing accelerated compositing tests,
which should now give correct pixel results.

• platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::resize): Add a call to XFlush which ensures
that pending X11 operations complete.

• platform/gtk/RedirectedXCompositeWindow.h:

(WebCore::RedirectedXCompositeWindow::windowId): Added this accessor.

Source/WebKit2:

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Added a few members necessary to track the
offscreen window.
(webkit_web_view_base_init):
(renderAcceleratedCompositingResults): Added this helper functions which renders
the results of the accelerated compositing operations during the GTK+ draw loop.
(webkitWebViewBaseDraw): Call renderAcceleratedCompositingResults when appropriate.
(resizeWebKitWebViewBaseFromAllocation): Resize the offscreen window when appropriate.
(webkitWebViewBaseSizeAllocate): Do not call resizeWebKitWebViewBaseFromAllocation when
the actual size of the widget does not change. This prevents destroying and recreating
the offscreen window pixmap when it isn't necessary.
(webkitWebViewBaseMap): We no longer send the window id during map, instead it's sent
as soon as there is WebPageProxy.
(webkitWebViewBaseCreateWebPage): Send the window id of the redirected window to
the WebProcess.
(queueAnotherDrawOfAcceleratedCompositingResults): Added this helper which works
around the issue of slow updates of the pixmap backing the redirected XComposite window.
(webkitWebViewBaseQueueDrawOfAcceleratedCompositingResults): Added this method which
is what the WebProcess uses to force a redraw on the UIProcess side.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Added new method to the list of private methods.
• UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Exposed this method publically
so that it can be used from WebKitWebViewBase.

• UIProcess/WebPageProxy.h:

(WebPageProxy): Renamed widgetMapped to setAcceleratedCompositingWindowId.

• UIProcess/WebPageProxy.messages.in: Ditto.
• UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.

(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):

• WebProcess/WebPage/WebPage.h:

(WebPage): Ditto.

• WebProcess/WebPage/WebPage.messages.in: Ditto.
• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::sizeDidChange): Force a composite to the resized window right
away so that the new window pixmap is updated before the first draw.
(WebKit::LayerTreeHostGtk::compositeLayersToContext): If the composition is for a resize,
first clear the entire GL context so that we don't see black artifacts during resize.

• WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk): Update the signature of compositeLayersToContext.

• WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::setAcceleratedCompositingWindowId): Added.

10:51 AM Changeset in webkit [128906] by jchaffraix@webkit.org

• 58 edits
  4 adds in trunk

Tables without any descendant and auto logical width should have a 0px logical width
​https://bugs.webkit.org/show_bug.cgi?id=95521

Reviewed by Abhishek Arya.

Source/WebCore:

The code would wrongly add the border-spacing in the row direction to the table's logical
width even if we didn't have a column. The new behavior matches FireFox and Opera. IE
matches our old behavior for inline tables but our new behavior for normal tables which
is a bug on their side.

Tests: fast/table/empty-table-should-take-no-space.html

fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html

• rendering/RenderTable.h:

(WebCore::RenderTable::borderSpacingInRowDirection):
Added this new helper function to return the right border-spacing. Added a FIXME as the code always
return the horizontal dimension which is wrong in vertical-writing mode.

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
Changed to call borderSpacingInRowDirection. Added a comment as to why we don't add border-spacing on
border-collapse: separate tables.

LayoutTests:

• fast/table/empty-table-should-take-no-space-expected.html: Added.
• fast/table/empty-table-should-take-no-space.html: Added.
• fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout-expected.html: Added.
• fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html: Added.

2 new tests to check that empty tables have 0px logical width.

• platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
• platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
• platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
• platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
• tables/mozilla/bugs/bug56563-expected.txt:

Progression. The table now is 2px wide as it has a 1px right & left border.

• platform/chromium-linux/fast/invalid/residual-style-expected.txt:

Progression. The changes are due to the tables shrinking which is expected.

• platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt:
• platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
• platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt:
• platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt:
• platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt:
• platform/chromium-win/fast/invalid/017-expected.txt:
• platform/chromium-win/fast/invalid/018-expected.txt:
• platform/chromium-win/fast/invalid/020-expected.txt:
• platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
• platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
• platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
• platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
• platform/efl/fast/forms/file/file-input-disabled-expected.txt:
• platform/efl/fast/invalid/017-expected.txt:
• platform/efl/fast/invalid/018-expected.txt:
• platform/efl/fast/invalid/020-expected.txt:
• platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt:
• platform/efl/fast/invalid/table-residual-style-crash-expected.txt:
• platform/efl/tables/mozilla/bugs/bug23994-expected.txt:
• platform/efl/tables/mozilla/bugs/bug56405-expected.txt:
• platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
• platform/gtk/fast/invalid/017-expected.txt:
• platform/gtk/fast/invalid/018-expected.txt:
• platform/gtk/fast/invalid/020-expected.txt:
• platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
• platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug23994-expected.txt:
• platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
• platform/mac/fast/forms/file/file-input-disabled-expected.txt:
• platform/mac/fast/invalid/017-expected.txt:
• platform/mac/fast/invalid/018-expected.txt:
• platform/mac/fast/invalid/020-expected.txt:
• platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
• platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
• platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
• platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
• platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
• platform/qt/fast/forms/file/file-input-disabled-expected.txt:
• platform/qt/fast/invalid/017-expected.txt:
• platform/qt/fast/invalid/018-expected.txt:
• platform/qt/fast/invalid/020-expected.txt:
• platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
• platform/qt/fast/invalid/table-residual-style-crash-expected.txt:
• platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
• platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
• platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
• platform/win/fast/forms/file-input-disabled-expected.txt:
• platform/win/fast/forms/file/file-input-disabled-expected.txt:
• tables/mozilla/bugs/bug113235-2-expected.txt:

Progression. The tables now have a 0px logical width. In some cases, we add the border-spacing in the
block-flow direction if we have a row. This is not consistently handled by browsers and not very well
defined in CSS.

10:43 AM Changeset in webkit [128905] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GTK] Build is broken without option --enable-unstable-features
​https://bugs.webkit.org/show_bug.cgi?id=96996

Reviewed by Martin Robinson.

When searching for the bare feature define in feature_defines_unstable or
feature_defines_overrides, search for the bare define followed by = character.
This avoids incorrectly matching the ENABLE_VIDEO define to the ENABLE_VIDEO_TRACK
overriding define (and works as well for other similarly named feature defines).

No new tests - no new functionality.

• GNUmakefile.am:

10:42 AM Changeset in webkit [128904] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding expectations for flakily-crashing tests, these failures
are a regression from r128802.

• platform/gtk/TestExpectations:

10:23 AM Changeset in webkit [128903] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebKit/chromium

[Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange
​https://bugs.webkit.org/show_bug.cgi?id=96508

Patch by Iain Merrick <​husky@google.com> on 2012-09-18
Reviewed by Ryosuke Niwa.

These methods had "start" and "end" parameters, but this is incorrect.
selectRange() actually takes base and extent (where the user actually
touched), and selectionBounds() returns anchor and focus (base and extent
expanded to account for the selection granularity).

This patch fixes the parameter names, and updates selectRange, its test
and its documentation to reflect the correct usage. It also removes
moveSelectionStart/moveSelectionEnd/moveCaret (which aren't being used
yet), and updates WebFrameTest to show how these can be implemented via
selectRange.

• public/WebFrame.h:

(WebFrame):

• public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::selectionBounds):

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):

• src/WebFrameImpl.h:

(WebFrameImpl):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::selectionBounds):

• src/WebViewImpl.h:

(WebViewImpl):

• tests/WebFrameTest.cpp:

9:51 AM Changeset in webkit [128902] by enne@google.com

• 1 edit
  4 copies in branches/chromium/1229

Merge 128514 - Hide all ancestors of the full screen element when going full screen
​https://bugs.webkit.org/show_bug.cgi?id=96332

Reviewed by James Robinson.

Source/WebCore:

Since fixed position elements can now sometimes become stacking
contexts, explicitly set position: static on full-screen ancestors so
that there are no stacking context ancestors that could cause the full
screen element to become incorrectly sorted.

Test: fullscreen/full-screen-fixed-pos-parent.html

• css/fullscreen.css:

(:-webkit-full-screen-ancestor:not(iframe)):

LayoutTests:

This test has an all red image that (without this patch) incorrectly
sorts on top of the full screen element. With this patch, the all
green full screen element appears on top.

• fullscreen/full-screen-fixed-pos-parent-expected.png: Added.
• fullscreen/full-screen-fixed-pos-parent-expected.txt: Added.
• fullscreen/full-screen-fixed-pos-parent.html: Added.
• fullscreen/resources/green.html: Added.

TBR=​enne@google.com

9:21 AM Changeset in webkit [128901] by peter@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS to r157342
​https://bugs.webkit.org/show_bug.cgi?id=96963

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-09-18
Reviewed by Stephen White.

Roll chromium DEPS to r157342. Also include the top-level directory
google_apis as a dependency, which was required for r157130.

• DEPS:

9:13 AM Changeset in webkit [128900] by mhahnenberg@apple.com

• 4 edits in trunk/Source

Use WTF::HasTrivialDestructor instead of compiler-specific versions in JSC::NeedsDestructor
​https://bugs.webkit.org/show_bug.cgi?id=96980

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

• runtime/JSCell.h:

(JSC):
(NeedsDestructor):

Source/WTF:

• wtf/TypeTraits.h:

(WTF):

8:30 AM Changeset in webkit [128899] by commit-queue@webkit.org

• 3 edits in trunk/Tools

EWS shouldn't sleep if there are new patches in its queue
​https://bugs.webkit.org/show_bug.cgi?id=83038

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-09-18
Reviewed by Eric Seidel.

EWS tries to process a security patch. Of course it can't, because the EWS isn't
the member of the security group. But the problem is that after it can't process
the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
and push the security patch to the end of the queue.
Now it stays in the loop until it finds a patch or the queue gets empty.

• Scripts/webkitpy/tool/commands/queues.py:

(AbstractPatchQueue._next_patch):

• Scripts/webkitpy/tool/commands/queues_unittest.py:

(AbstractPatchQueueTest.test_next_patch):

8:22 AM Changeset in webkit [128898] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

DFGOperations doesn't use NativeCallFrameTracer in enough places
​https://bugs.webkit.org/show_bug.cgi?id=96987

Reviewed by Mark Hahnenberg.

Anything that can GC should use it.

• dfg/DFGOperations.cpp:

8:14 AM Changeset in webkit [128897] by rakuco@webkit.org

• 3 edits in trunk/LayoutTests

[EFL] Gardening.

Move fast/events/dont-loose-last-event.html from Skipped to
TestExpectations now that it has a proper bug tracking the
failure.

• platform/efl/Skipped:
• platform/efl/TestExpectations:

8:02 AM Changeset in webkit [128896] by caseq@chromium.org

• 3 edits in trunk/LayoutTests

Unreviewed. Avoid using a deprecated extension API parameter in test to avoid console warning,
that break expectations on EFL due to EFL's DRT logging inspector console output to test
expectations.

• inspector/extensions/extensions-audits-api.html:
• platform/efl/TestExpectations:

8:00 AM Changeset in webkit [128895] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
​https://bugs.webkit.org/show_bug.cgi?id=97014

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.

According to ​http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
be used for literals rather than WTF::StringBuilder::append().

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::booleanForKey):

7:57 AM Changeset in webkit [128894] by rakuco@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Gardening.

• platform/efl/TestExpectations: Skip

inspector/extensions/extensions-audits-api.html while we do not
solve the associated bug.

7:44 AM Changeset in webkit [128893] by rakuco@webkit.org

• 3 edits in trunk/LayoutTests

[EFL] Unreviewed daily gardening.

Re-skip a few tests which were unskipped in r128880 and r128882
and still fail both on my machine and on the bots.

• platform/efl/Skipped:
• platform/efl/TestExpectations:

7:14 AM Changeset in webkit [128892] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Extensions API] postpone requests to add extensions until extension server is initialized
​https://bugs.webkit.org/show_bug.cgi?id=97012

Reviewed by Vsevolod Vlasov.

• queue extensions being added unless initialization is complete;
• add queued extensions upon completion of initialization;

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.initExtensions):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):
(WebInspector.ExtensionServer.prototype._innerAddExtension):

7:11 AM Changeset in webkit [128891] by rakuco@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unskip the right ietestcenter tests after r128802.

• platform/efl/TestExpectations:

7:08 AM Changeset in webkit [128890] by Simon Hausmann

• 2 edits in trunk/Tools

Update my e-mail address.

• Scripts/webkitpy/common/config/committers.py:

7:05 AM Changeset in webkit [128889] by caio.oliveira@openbossa.org

• 3 edits in trunk/Source/WebKit/qt

[Qt] Use UndoStep::editingAction() to set the text of undo/redo actions
​https://bugs.webkit.org/show_bug.cgi?id=96921

Reviewed by Ryosuke Niwa.

Set the text of QUndoCommands we create for undo/redo actions based on the
editing action from UndoStep.

This change is visible using QtTestBrowser, and looking at the Edit menu after
doing HTML editing changes. I've used ​http://simple-rte.rniwa.com for testing.

• WebCoreSupport/UndoStepQt.cpp:

(undoNameForEditAction): This function returns a localized name of the action.
(UndoStepQt::UndoStepQt): Set the text based on UndoStep::editingAction.

• tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(tst_QWebPage::undoActionHaveCustomText): Create a new test to verify that the text
describing the undo action after inserting a text and indenting the text is different.

7:03 AM Changeset in webkit [128888] by abecsi@webkit.org

• 2 edits in trunk/Tools

Update my e-mail address.

Unreviewed.

• Scripts/webkitpy/common/config/committers.py:

6:58 AM Changeset in webkit [128887] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt] qt_webkit.pri should not be listed in Tools.pro

Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.

Since r128751 the module pri file is auto-generated
but it was still listed in OTHER_FILES.

Patch by Andras Becsi <​andras.becsi@digia.com> on 2012-09-18

• Tools.pro: Remove unneeded line.

6:51 AM Changeset in webkit [128886] by Simon Hausmann

• 2 edits
  3 adds in trunk/Tools

[Qt] Fix build with some versions of the gold linker

Reviewed by Tor Arne Vestbø.

Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
Instead run a compile/link test first to see if it works.

• qmake/config.tests/gnuld/gnuld.pro: Added.
• qmake/config.tests/gnuld/main.cpp: Added.

(main):

• qmake/mkspecs/features/unix/default_post.prf:

6:37 AM Changeset in webkit [128885] by Simon Hausmann

• 2 edits in trunk/Tools

[Qt] Remove forced use of gold.

Reviewed by Tor Arne Vestbø.

The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.

• qmake/mkspecs/features/unix/default_post.prf:

6:29 AM Changeset in webkit [128884] by Simon Hausmann

• 2 edits in trunk/Tools

[Qt] Prospective Qt/Windows cross-compiling fix

Reviewed by Tor Arne Vestbø.

The win32 scope is not set when cross-compiling from Linux to Windows.

• qmake/mkspecs/features/functions.prf:

6:23 AM Changeset in webkit [128883] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit2

Unreviewed, rolling out r128849.
​http://trac.webkit.org/changeset/128849
​https://bugs.webkit.org/show_bug.cgi?id=97007

Causes test_ewk2_view to time out. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-18

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_webprocess_crashed):

• UIProcess/API/efl/ewk_view.h:
• UIProcess/API/efl/ewk_view_private.h:
• UIProcess/API/efl/ewk_view_ui_client.cpp:

(ewk_view_ui_client_attach):

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

6:02 AM Changeset in webkit [128882] by commit-queue@webkit.org

• 81 edits
  17 adds
  1 delete in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97000

Unreviewed EFL gardening.

Rebaseline several test cases an unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18

• platform/efl/Skipped:
• platform/efl/TestExpectations:
• platform/efl/animations/additive-transform-animations-expected.txt: Added.
• platform/efl/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
• platform/efl/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
• platform/efl/fast/events/offsetX-offsetY-expected.txt: Removed.
• platform/efl/fast/events/pointer-events-2-expected.png:
• platform/efl/fast/events/pointer-events-2-expected.txt:
• platform/efl/fast/forms/001-expected.png:
• platform/efl/fast/forms/001-expected.txt:
• platform/efl/fast/forms/float-before-fieldset-expected.png:
• platform/efl/fast/forms/float-before-fieldset-expected.txt:
• platform/efl/fast/forms/form-element-geometry-expected.png:
• platform/efl/fast/forms/form-element-geometry-expected.txt:
• platform/efl/fast/forms/input-baseline-expected.png:
• platform/efl/fast/forms/input-baseline-expected.txt:
• platform/efl/fast/forms/input-placeholder-visibility-1-expected.png:
• platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
• platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.png:
• platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.txt:
• platform/efl/fast/forms/mailto/advanced-get-expected.txt: Added.
• platform/efl/fast/forms/mailto/advanced-put-expected.txt: Added.
• platform/efl/fast/forms/placeholder-position-expected.png:
• platform/efl/fast/forms/placeholder-position-expected.txt:
• platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
• platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.png:
• platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
• platform/efl/fast/gradients/generated-gradients-expected.png:
• platform/efl/fast/gradients/generated-gradients-expected.txt:
• platform/efl/fast/gradients/radial-centered-expected.png:
• platform/efl/fast/gradients/radial-centered-expected.txt:
• platform/efl/fast/inline-block/contenteditable-baseline-expected.png:
• platform/efl/fast/inline-block/contenteditable-baseline-expected.txt:
• platform/efl/fast/inline/continuation-outlines-with-layers-2-expected.png:
• platform/efl/fast/inline/continuation-outlines-with-layers-2-expected.txt:
• platform/efl/fast/inline/inline-box-background-expected.png:
• platform/efl/fast/inline/inline-box-background-expected.txt:
• platform/efl/fast/inline/inline-box-background-long-image-expected.png:
• platform/efl/fast/inline/inline-box-background-long-image-expected.txt:
• platform/efl/fast/inline/inline-box-background-repeat-x-expected.png:
• platform/efl/fast/inline/inline-box-background-repeat-x-expected.txt:
• platform/efl/fast/inline/inline-box-background-repeat-y-expected.png:
• platform/efl/fast/inline/inline-box-background-repeat-y-expected.txt:
• platform/efl/fast/invalid/nestedh3s-expected.png:
• platform/efl/fast/invalid/nestedh3s-expected.txt:
• platform/efl/fast/overflow/overflow-float-stacking-expected.png:
• platform/efl/fast/overflow/overflow-float-stacking-expected.txt:
• platform/efl/fast/overflow/overflow-stacking-expected.png:
• platform/efl/fast/overflow/overflow-stacking-expected.txt:
• platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.png:
• platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.txt:
• platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png:
• platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt:
• platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.png:
• platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt:
• platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
• platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
• platform/efl/fast/repaint/moving-shadow-on-path-expected.png:
• platform/efl/fast/repaint/moving-shadow-on-path-expected.txt:
• platform/efl/fast/repaint/repaint-svg-after-style-change-expected.png: Added.
• platform/efl/fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
• platform/efl/fast/repaint/table-section-repaint-expected.txt:
• platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.png:
• platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
• platform/efl/fast/replaced/width100percent-searchfield-expected.png:
• platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
• platform/efl/fast/table/027-expected.png:
• platform/efl/fast/table/027-expected.txt:
• platform/efl/fast/table/027-vertical-expected.png:
• platform/efl/fast/table/027-vertical-expected.txt:
• platform/efl/fast/table/032-expected.png:
• platform/efl/fast/table/032-expected.txt:
• platform/efl/fast/table/040-expected.png:
• platform/efl/fast/table/040-expected.txt:
• platform/efl/fast/table/040-vertical-expected.png:
• platform/efl/fast/table/040-vertical-expected.txt:
• platform/efl/fast/table/absolute-table-at-bottom-expected.png:
• platform/efl/fast/table/absolute-table-at-bottom-expected.txt:
• platform/efl/fast/table/border-collapsing/004-expected.png:
• platform/efl/fast/table/border-collapsing/004-expected.txt:
• platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
• platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
• platform/efl/fast/table/dynamic-caption-add-before-child-expected.png:
• platform/efl/fast/table/dynamic-caption-add-before-child-expected.txt:
• platform/efl/fast/table/frame-and-rules-expected.png:
• platform/efl/fast/table/frame-and-rules-expected.txt:
• platform/efl/fast/table/multiple-captions-display-expected.png: Added.
• platform/efl/fast/table/multiple-captions-display-expected.txt:
• platform/efl/media/video-colorspace-yuv420-expected.png: Added.
• platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
• platform/efl/media/video-colorspace-yuv422-expected.png: Added.
• platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
• platform/efl/perf/nested-combined-selectors-expected.txt: Added.
• platform/efl/userscripts/script-run-at-end-expected.txt: Added.

5:56 AM Changeset in webkit [128881] by rakuco@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Gardening after r128802.

• platform/efl/TestExpectations: Temporarily skip a few JS tests

which are crashing after r128802.

5:55 AM Changeset in webkit [128880] by commit-queue@webkit.org

• 4 edits in trunk

[EFL] min-device-width failures in media tests
​https://bugs.webkit.org/show_bug.cgi?id=96920

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Return a realistic value (800x600) for screen resolution if
it cannot be detected, instead of returning (0x0).

This allows for some tests to pass on the build bots
where X is not running.

No new tests, already covered by existing tests.

• platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):

LayoutTests:

Unskip several test cases which should pass on the
build bots now that we return a realistic screen
resolution whenever it cannot be detected.

• platform/efl/TestExpectations:

5:51 AM Changeset in webkit [128879] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL][WK2] Clarify TestExpectations file
​https://bugs.webkit.org/show_bug.cgi?id=97003

Unreviewed EFL gardening.

Slight reorganization and bug numbers updating
in EFL WK2 TestExpectations for clarity.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18

• platform/efl-wk2/TestExpectations:

5:39 AM Changeset in webkit [128878] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

REGRESSION(r128802): It made some JS tests crash
​https://bugs.webkit.org/show_bug.cgi?id=97001

Unreviewed gardening, skip the new _crashing_ tests to paint the bots green.

• platform/qt/Skipped:

5:21 AM Changeset in webkit [128877] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix compilation with Qt 5 on MeeGo 1.2 Harmattan
​https://bugs.webkit.org/show_bug.cgi?id=96937

Patch by Simon Hausmann <​simon.hausmann@digia.com> on 2012-09-18
Reviewed by Jocelyn Turcotte.

The gl2ext.h header file on the platform is outdated. Instead use the newer copy from Qt
through implicit inclusion of qopengl.h. Since Qt's declarations are based on newer Khronos
headers, the multi sampling extensions do have the PROC suffix, we need the same workaround
as QNX.

• platform/graphics/opengl/Extensions3DOpenGLES.h:

5:05 AM Changeset in webkit [128876] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[EFL] Remove background view on EWebLauncher and MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=96905

Patch by Seokju Kwon <​seokju.kwon@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.

The size of webview was changed after adding url bar.
And the background view is not necessary anymore, since it was used for debugging back in the day.

• EWebLauncher/main.c:

(_ELauncher):
(on_ecore_evas_resize):
(browserCreate):

• MiniBrowser/efl/main.c:

(_MiniBrowser):
(on_ecore_evas_resize):
(browserCreate):

4:41 AM Changeset in webkit [128875] by caseq@chromium.org

• 11 edits in trunk

Web Inspector: [Extensions API] explicitly manage extension audit progress
​https://bugs.webkit.org/show_bug.cgi?id=96803

Reviewed by Alexander Pavlov.

Source/WebCore:

• create a sub-progress per audit category;
• manage audit category progress within the category, not in the panel logic;
• consider audit is done when all categories are done;
• expose AuditResults.updateProgress(worked, totalWork) in the extensions API;
• retain old magic for computing audit progress if extension specifies extension results count.

• inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run.callbackWrapper):
(WebInspector.AuditCategory.prototype.run):

• inspector/front-end/ExtensionAPI.js:

(defineCommonExtensionSymbols):
(injectedExtensionAPI.Audits.prototype.addCategory):
(injectedExtensionAPI.AuditResultImpl.prototype.updateProgress):

• inspector/front-end/ExtensionAuditCategory.js:

(WebInspector.ExtensionAuditCategory.prototype.run):
(WebInspector.ExtensionAuditCategoryResults):
(WebInspector.ExtensionAuditCategoryResults.prototype.done):
(WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
(WebInspector.ExtensionAuditCategoryResults.prototype.updateProgress):

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onUpdateAuditProgress):
(WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):

• inspector/front-end/ProgressBar.js:

(WebInspector.ProgressIndicator.prototype.done): Assure only first call to done() has effect.

LayoutTests:

• inspector/extensions/extensions-audits-api-expected.txt: Added AuditResults.updateProgress()
• inspector/extensions/extensions-audits.html: Added a call to updateProgress()

4:36 AM WebInspector edited by abecsi@webkit.org

remove spam (diff)

4:33 AM Changeset in webkit [128874] by sergio@webkit.org

• 2 edits in trunk/Tools

[GTK] run-webkit-tests unable to find TestExpectations for WK2
​https://bugs.webkit.org/show_bug.cgi?id=96998

Reviewed by Philippe Normand.

We should look for TestExpectations files in all the locations where
we currently look for Skipped files. This will allow
run-webkit-tests to look for TestExpectations files in
platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.

• Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.expectations_files):

4:14 AM Changeset in webkit [128873] by rakuco@webkit.org

• 10 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Update some pixel expectations after a long time.
japanese-lr-selection-expected.png now actually shows a selection
background, some shadows are displayed properly and some fonts
have had rendering adjustments.

• platform/efl/fast/writing-mode/basic-vertical-line-expected.png:
• platform/efl/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
• platform/efl/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
• platform/efl/fast/writing-mode/box-shadow-vertical-lr-expected.png:
• platform/efl/fast/writing-mode/box-shadow-vertical-rl-expected.png:
• platform/efl/fast/writing-mode/english-bt-text-expected.png:
• platform/efl/fast/writing-mode/english-rl-text-expected.png:
• platform/efl/fast/writing-mode/fieldsets-expected.png:
• platform/efl/fast/writing-mode/japanese-lr-selection-expected.png:

4:05 AM clutter edited by tomeu.vizoso@collabora.com

(diff)

4:04 AM clutter edited by tomeu.vizoso@collabora.com

(diff)

3:57 AM Changeset in webkit [128872] by rakuco@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Gardening after r128802.

• platform/efl/TestExpectations: Unskip test that is now passing.

3:34 AM Changeset in webkit [128871] by Carlos Garcia Campos

• 6 edits in trunk/Source/WebKit2

[GTK] Set the area of tooltips in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=96618

Reviewed by Martin Robinson.

In GTK+ tooltips are associated to a widget, if the mouse is moved
inside the widget area, the tooltip position doesn't change even
if the tooltip text changes. To support multiple tooltips for the
same widget, we need to set the area of the widget for every
tooltip.

• Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::encode): Encode elementBoundingBox.
(WebKit::WebHitTestResult::Data::decode): Decode elementBoundingBox.

• Shared/WebHitTestResult.h:

(Data): Add elementBoundingBox to WebHitTestResult::Data.
(WebKit::WebHitTestResult::Data::elementBoundingBoxInWindowCoordinates):
Get the bounding box of the inner non shared node of the hit test
result in window coordinates.
(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::elementBoundingBox):
(WebHitTestResult):

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewMouseTargetChanged): Call webkitWebViewBaseSetTooltipArea.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseQueryTooltip): Use the tooltipArea if it's not empty.
(webkitWebViewBaseSetTooltipArea): Set the tooltipArea.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

3:29 AM Changeset in webkit [128870] by rakuco@webkit.org

• 24 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Update MathML expectations after r128837.

• platform/efl/mathml/presentation/attributes-expected.txt:
• platform/efl/mathml/presentation/fenced-expected.txt:
• platform/efl/mathml/presentation/fenced-mi-expected.png:
• platform/efl/mathml/presentation/fenced-mi-expected.txt:
• platform/efl/mathml/presentation/fractions-expected.txt:
• platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
• platform/efl/mathml/presentation/mo-stretch-expected.png:
• platform/efl/mathml/presentation/mo-stretch-expected.txt:
• platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
• platform/efl/mathml/presentation/roots-expected.txt:
• platform/efl/mathml/presentation/row-alignment-expected.png:
• platform/efl/mathml/presentation/row-alignment-expected.txt:
• platform/efl/mathml/presentation/style-expected.txt:
• platform/efl/mathml/presentation/sub-expected.txt:
• platform/efl/mathml/presentation/subsup-expected.png:
• platform/efl/mathml/presentation/subsup-expected.txt:
• platform/efl/mathml/presentation/sup-expected.txt:
• platform/efl/mathml/presentation/tables-expected.png:
• platform/efl/mathml/presentation/tables-expected.txt:
• platform/efl/mathml/presentation/tokenElements-expected.txt:
• platform/efl/mathml/presentation/under-expected.txt:
• platform/efl/mathml/presentation/underover-expected.txt:
• platform/efl/mathml/xHeight-expected.txt:

3:28 AM Changeset in webkit [128869] by allan.jensen@nokia.com

• 2 edits in trunk/Source/WebCore

Revert r127457 and following fixes due to several hit-testing regressions
​https://bugs.webkit.org/show_bug.cgi?id=96830

Reviewed by Antonio Gomes.

The revert misssed one related follow-up.

• dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

3:23 AM Changeset in webkit [128868] by vestbo@webkit.org

• 4 edits in trunk

[Qt] Fix build without the QtQuick module

Reviewed by Simon Hausmann.

2:42 AM Changeset in webkit [128867] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Not reviewed. Attempt at greening the WinCairo bot. Touching
LowLevelInterpreter.asm to trigger a rebuild of LLIntDesiredOffsets.
​https://bugs.webkit.org/show_bug.cgi?id=96992.

• llint/LowLevelInterpreter.asm:

2:40 AM BuildingQtOnLinux edited by vsevik@chromium.org

(diff)

2:32 AM Changeset in webkit [128866] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/LayoutTests

[EFL] Unskip fast/js/global-constructors.html
​https://bugs.webkit.org/show_bug.cgi?id=96984

Unreviewed EFL gardening.

Generate baseline for fast/js/global-constructors.html
and unskip test. The only differences in the expected
output are due to webkit prefix.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18

• fast/js/global-constructors-expected.txt: Added.
• platform/efl/Skipped:

2:11 AM Changeset in webkit [128865] by kadam@inf.u-szeged.hu

• 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r128790): It broke the ARM build
​https://bugs.webkit.org/show_bug.cgi?id=96968

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2012-09-18
Reviewed by Filip Pizlo.

Implement the missing or32 method in the MacroAssemblerARM.h.

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::or32):
(MacroAssemblerARM):

2:11 AM Changeset in webkit [128864] by Stephanie Lewis

• 2 edits in trunk/Tools

Build fix after ​http://trac.webkit.org/projects/webkit/changeset/128852.

Unreviewed.

• DumpRenderTree/mac/DumpRenderTree.mm:

(poseAsClass):

1:58 AM Changeset in webkit [128863] by kkristof@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Skipped failing tests because eventSender.gestureTap
is not implemented on Qt, ENABLE(SHADOW_DOM) is disabled and
WebKitDisplayImagesKey is not supported.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-09-18
Reviewed by Csaba Osztrogonác.

• platform/qt/Skipped:

1:46 AM Changeset in webkit [128862] by zandobersek@gmail.com

• 39 edits
  1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining MathML tests' baselines after r128837.

• platform/gtk/mathml/presentation/attributes-expected.png:
• platform/gtk/mathml/presentation/attributes-expected.txt:
• platform/gtk/mathml/presentation/fenced-expected.txt:
• platform/gtk/mathml/presentation/fenced-mi-expected.png:
• platform/gtk/mathml/presentation/fenced-mi-expected.txt:
• platform/gtk/mathml/presentation/fractions-expected.png:
• platform/gtk/mathml/presentation/fractions-expected.txt:
• platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
• platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
• platform/gtk/mathml/presentation/mo-expected.png:
• platform/gtk/mathml/presentation/mo-expected.txt:
• platform/gtk/mathml/presentation/mo-stretch-expected.png:
• platform/gtk/mathml/presentation/mo-stretch-expected.txt:
• platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
• platform/gtk/mathml/presentation/over-expected.png:
• platform/gtk/mathml/presentation/over-expected.txt:
• platform/gtk/mathml/presentation/roots-expected.png:
• platform/gtk/mathml/presentation/roots-expected.txt:
• platform/gtk/mathml/presentation/row-alignment-expected.png:
• platform/gtk/mathml/presentation/row-alignment-expected.txt:
• platform/gtk/mathml/presentation/row-expected.png:
• platform/gtk/mathml/presentation/row-expected.txt:
• platform/gtk/mathml/presentation/style-expected.png:
• platform/gtk/mathml/presentation/style-expected.txt:
• platform/gtk/mathml/presentation/sub-expected.png:
• platform/gtk/mathml/presentation/sub-expected.txt:
• platform/gtk/mathml/presentation/subsup-expected.png:
• platform/gtk/mathml/presentation/subsup-expected.txt:
• platform/gtk/mathml/presentation/sup-expected.png:
• platform/gtk/mathml/presentation/sup-expected.txt:
• platform/gtk/mathml/presentation/tables-expected.png:
• platform/gtk/mathml/presentation/tables-expected.txt:
• platform/gtk/mathml/presentation/tokenElements-expected.txt:
• platform/gtk/mathml/presentation/under-expected.png:
• platform/gtk/mathml/presentation/under-expected.txt:
• platform/gtk/mathml/presentation/underover-expected.png:
• platform/gtk/mathml/presentation/underover-expected.txt:
• platform/gtk/mathml/xHeight-expected.png: Added.
• platform/gtk/mathml/xHeight-expected.txt:

1:39 AM Changeset in webkit [128861] by mihnea@adobe.com

• 10 edits
  3 adds in trunk

[CSSRegions]Flag auto-height regions
​https://bugs.webkit.org/show_bug.cgi?id=96267

Reviewed by Julien Chaffraix.

Source/WebCore:

The regions having auto logical height should be flagged so that their height will computed as part of a 2 pass-layout mechanism.
A valid region is flagged as having auto logical height if:

• has auto logical height and is part of the normal flow
• has auto logical height, is not part of normal flow and does not have logical top/bottom specified

An invalid region (part of circular dependency) will not be marked even if its style matches the above situations.

Test: fast/regions/autoheight-regions-mark.html

• rendering/FlowThreadController.cpp: Keep a counter of auto logical height valid regions.

(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads): Verify that the current number of auto logical height regions is correct by iterating over all the regions attached to the flow threads
and compute the number of auto logical height regions on the spot.
(WebCore):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsFlagConsistent): Helper function that is used to verify the number of auto logical height regions.

• rendering/FlowThreadController.h:

(WebCore::FlowThreadController::hasAutoLogicalHeightRegions):
(WebCore::FlowThreadController::incrementAutoLogicalHeightRegions):
(WebCore::FlowThreadController::decrementAutoLogicalHeightRegions):
(FlowThreadController):

• rendering/RenderFlowThread.cpp:

(WebCore):
(WebCore::RenderFlowThread::autoLogicalHeightRegionsCount): Helper function that is used to count the number of regions marked as having auto logical height.

• rendering/RenderFlowThread.h:
• rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore):
(WebCore::RenderRegion::styleDidChange): For a region that is attached to a flow thread, verify whether the style change modified its auto logical height appearance.
(WebCore::RenderRegion::attachRegion): Handle the case of attaching region to a flow thread and the detach/attach sequence when the region is moved in the render tree.
(WebCore::RenderRegion::detachRegion):

• rendering/RenderRegion.h:

(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):
(WebCore::RenderRegion::hasAutoLogicalHeight):
(RenderRegion):

• rendering/RenderTreeAsText.cpp: For the regions that use auto logical height, modify the output to reflect that.

(WebCore::writeRenderNamedFlowThreads):

LayoutTests:

The regions having auto logical height should be flagged so that their height will computed as part of a 2 pass-layout mechanism.
Added a test that checks whether a region in several situations is marked properly.

• fast/regions/autoheight-regions-mark.html: Added.
• platform/mac/fast/regions/autoheight-regions-mark-expected.png: Added.
• platform/mac/fast/regions/autoheight-regions-mark-expected.txt: Added.
• platform/chromium/TestExpectations:

1:35 AM Changeset in webkit [128860] by mark.lam@apple.com

• 7 edits
  5 adds in trunk/Source/JavaScriptCore

Fix for WinCairo builds.
​https://bugs.webkit.org/show_bug.cgi?id=96992.

Reviewed by Filip Pizlo.

Adding additional vcproj build targets in LLIntDesiredOffsets.vcproj,
LLIntOffsetsExtractor.vcproj, and LLIntAssembly.vcproj to match those
in jsc.vcproj.

• JavaScriptCore.vcproj/LLIntAssembly/LLIntAssembly.vcproj:
• JavaScriptCore.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcproj:
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcproj:
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.vsprops: Added property svn:eol-style.
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.vsprops: Added property svn:eol-style.
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebugAll.vsprops: Added.
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebugCairoCFLite.vsprops: Added.
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorProduction.vsprops: Added.
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.vsprops: Added property svn:eol-style.
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorReleaseCairoCFLite.vsprops: Added.
• JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorReleasePGO.vsprops: Added.

1:21 AM Changeset in webkit [128859] by allan.jensen@nokia.com

• 2 edits in trunk/Tools

Unreviewed update of email addresses for Berlin QtWebKit office.

• Scripts/webkitpy/common/config/committers.py:

1:17 AM Changeset in webkit [128858] by anilsson@rim.com

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active
​https://bugs.webkit.org/show_bug.cgi?id=96750

Reviewed by Antonio Gomes.

The region of interest mechanism replaces the scrolling/zooming
functionality in InputHandler::ensureFocusTextElementVisible().

We introduce a new fine-grained setting for the various adjustment
modes. The WebKit embedder can disable all scroll types in favor of the
region of interest mechanism by using the new setting.

PR #208387

Reviewed internally by Mike Fenton.

• WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::configPage):

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

• WebKitSupport/InputHandler.h:

12:29 AM Changeset in webkit [128857] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix sloppy English in comment.

• runtime/JSGlobalObject.cpp:

(JSC):

12:28 AM Changeset in webkit [128856] by shinyak@chromium.org

• 43 edits in trunk

Disable adding an AuthorShadowRoot to replaced elements.
​https://bugs.webkit.org/show_bug.cgi?id=96978

Reviewed by Hajime Morita.

Source/WebCore:

We (people who implement Shadow DOM) have concluded that we don't support adding AuthorShadowRoot to
replaced elements in the current spec, since it turned out that a lot of difficulties exist and it brings
a lot of mess to our codebase.

For now, we just disable adding AuthorShadowRoot to these replaced elements.

Test: fast/dom/shadow/shadow-disable.html

• html/HTMLImageElement.h:
• html/HTMLKeygenElement.h:
• html/HTMLMeterElement.h:
• html/HTMLProgressElement.h:
• html/HTMLTextAreaElement.h:

LayoutTests:

Since we don't support AuthorShadowRoot for replaced elements for now, we enable a flat to
support AuthorShadowRoot in these tests.

Also, we have a test to check to reject adding ShadowRoot to repalced elements.

• fast/dom/shadow/select-image-with-shadow.html:
• fast/dom/shadow/shadow-disable-expected.txt:
• fast/dom/shadow/shadow-disable.html: Checks WebKit rejects adding ShadowRoot to repalced elements.
• fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html:
• fast/dom/shadow/shadowdom-for-image-alt-update.html:
• fast/dom/shadow/shadowdom-for-image-alt.html:
• fast/dom/shadow/shadowdom-for-image-content.html:
• fast/dom/shadow/shadowdom-for-image-dynamic.html:
• fast/dom/shadow/shadowdom-for-image-event-click.html:
• fast/dom/shadow/shadowdom-for-image-event.html:
• fast/dom/shadow/shadowdom-for-image-in-shadowdom.html:
• fast/dom/shadow/shadowdom-for-image-map.html:
• fast/dom/shadow/shadowdom-for-image-style.html:
• fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html:
• fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html:
• fast/dom/shadow/shadowdom-for-image-with-width-and-height.html:
• fast/dom/shadow/shadowdom-for-image.html:
• fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html:
• fast/dom/shadow/shadowdom-for-keygen-without-shadow.html:
• fast/dom/shadow/shadowdom-for-meter-dynamic.html:
• fast/dom/shadow/shadowdom-for-meter-multiple.html:
• fast/dom/shadow/shadowdom-for-meter-with-style.html:
• fast/dom/shadow/shadowdom-for-meter-without-appearance.html:
• fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html:
• fast/dom/shadow/shadowdom-for-meter.html:
• fast/dom/shadow/shadowdom-for-object-only-shadow.html:
• fast/dom/shadow/shadowdom-for-progress-dynamic.html:
• fast/dom/shadow/shadowdom-for-progress-multiple.html:
• fast/dom/shadow/shadowdom-for-progress-with-style.html:
• fast/dom/shadow/shadowdom-for-progress-without-appearance.html:
• fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html:
• fast/dom/shadow/shadowdom-for-progress.html:
• fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html:
• fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html:
• fast/dom/shadow/shadowdom-for-textarea-without-shadow.html:
• fast/dom/shadow/shadowdom-for-textarea.html:

12:20 AM Changeset in webkit [128855] by ryuan.choi@samsung.com

• 2 edits in trunk

[CMAKE] Fix build break because of memory exhausted.
​https://bugs.webkit.org/show_bug.cgi?id=77327

Reviewed by Gyuyoung Kim.

Added to avoid memory exhaustion on 32bit linux debug build.

• Source/cmake/OptionsCommon.cmake: