Timeline
Sep 22, 2012:
- 11:56 PM Changeset in webkit [129314] by
-
- 3 edits in trunk/Source/WTF
Add explicit conversion operator to RetainPtr for easier use in C++11 environments
https://bugs.webkit.org/show_bug.cgi?id=97403
Reviewed by Dan Bernstein.
- wtf/Compiler.h:
Add support for COMPILER_SUPPORTS(CXX_EXPLICIT_CONVERSIONS)
- wtf/RetainPtr.h:
(RetainPtr):
(WTF::RetainPtr::get):
(WTF::RetainPtr::operator PtrType):
Add the explicit conversion operator and group all the underlying
pointer accessors together.
- 11:31 PM Changeset in webkit [129313] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a failure expectation for http/tests/loading/redirect-with-no-location-crash.html,
the test started failing on the WebKit2 builder after it was unskipped in r129213.
- platform/gtk-wk2/TestExpectations:
- 6:03 PM MinimalFileStorage edited by
- (diff)
- 5:56 PM MinimalFileStorage edited by
- (diff)
- 5:53 PM MinimalFileStorage edited by
- (diff)
- 5:52 PM MinimalFileStorage edited by
- (diff)
- 5:50 PM MinimalFileStorage edited by
- (diff)
- 5:49 PM MinimalFileStorage edited by
- (diff)
- 5:47 PM MinimalFileStorage edited by
- (diff)
- 5:46 PM MinimalFileStorage edited by
- (diff)
- 5:45 PM MinimalFileStorage created by
- 5:29 PM Changeset in webkit [129312] by
-
- 4 edits in trunk/Source/WebKit2
Install WebProcess XPC services into the right places
https://bugs.webkit.org/show_bug.cgi?id=97385
Reviewed by Anders Carlsson.
- Configurations/WebProcessService.xcconfig:
Update INSTALL_PATH to go into WebKit2.framework/Versions/A/XPCServices.
- Configurations/WebProcessServiceForWebKitDevelopment.xcconfig:
Since this config file is almost identical to WebProcessService.xcconfig,
just #include it and change the one thing that is different, the INFOPLIST_FILE
- WebKit2.xcodeproj/project.pbxproj:
Follow XPC procedure and copy the services into the right place, WebKit2.framework/Versions/A/XPCServices
in all builds except production builds where it is not necessary. Also add a symlink like everyone else
does.
- 5:19 PM Changeset in webkit [129311] by
-
- 4 copies1 add in releases/Apple/OS X Lion Update 10.7.5
Added a tag for the OS X Lion Update 10.7.5 release.
OS X Lion v10.7.5 includes JavaScriptCore-7534.57.3, WebCore-7534.57.7, WebKit-7534.57.7, and WebKit2-7534.57.7.
- 5:12 PM Changeset in webkit [129310] by
-
- 4 copies1 add in releases/Apple/Safari 6.0.1
Added a tag for the Safari 6.0.1 release.
Safari 6.0.1 includes JavaScriptCore-x536.26.7, WebCore-x536.26.14, WebKit-x536.26.14, and WebKit2-x536.26.14.
- 3:18 PM Changeset in webkit [129309] by
-
- 5 edits in trunk/Source/WebKit2
Allow setting a custom path to where the plug-in sandbox profiles are being kept
https://bugs.webkit.org/show_bug.cgi?id=97399
Reviewed by Anders Carlsson.
Add a new default to allow controlling where to look for plug-in sandbox profiles
called "PlugInSandboxProfileDirectoryPath".
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeSandbox):
Use the passed in sandboxProfileDirectoryPath instead of hard coding /usr/share/sandbox/.
(WebKit::PluginProcess::platformInitialize):
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Grab the sandboxProfileDirectoryPath from standardUserDefaults and pass it to
the plug-in.
- 9:17 AM Changeset in webkit [129308] by
-
- 21 edits4 copies in trunk
AX: Layout tests would be easier to write if AccessibilityController could find an element by id
https://bugs.webkit.org/show_bug.cgi?id=97301
Reviewed by Chris Fleizach.
Source/WebCore:
Add a method to get the DOM "id" attribute from an accessible object, only for layout tests.
Makes existing test more cross-platform:
Tests: accessibility/aria-hidden-with-elements.html
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Adds a new accessibleElementById method to AccessibilityController, to make it
easier to write cross-platform layout tests.
Implemented for Chromium and for Mac (DRT and WKTR).
- DumpRenderTree/AccessibilityController.cpp:
(getAccessibleElementByIdCallback):
(AccessibilityController::getJSClass):
- DumpRenderTree/AccessibilityController.h:
(AccessibilityController):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::findAccessibleElementByIdRecursive):
(AccessibilityController::getAccessibleElementById):
(AccessibilityController::accessibleElementByIdGetterCallback):
- DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
(AccessibilityController):
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::accessibleElementById):
- DumpRenderTree/mac/AccessibilityCommonMac.h: added
- DumpRenderTree/mac/AccessibilityCommonMac.mm: added
(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(AccessibilityController):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
- WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::findAccessibleObjectById):
(WTR):
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
LayoutTests:
Modifies an existing test to use the new accessibleElementById
method of AccessibilityController, enabling the test to pass on
both Mac and Chromium.
- accessibility/aria-hidden-with-elements.html:
- platform/chromium/TestExpectations:
- 5:10 AM Changeset in webkit [129307] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, unskip now passing tests.
- platform/qt/TestExpectations:
- 4:50 AM Changeset in webkit [129306] by
-
- 2 edits in trunk/LayoutTests
[EFL] Garden IETestCenter Bugs
https://bugs.webkit.org/show_bug.cgi?id=97392
Unreviewed EFL gardening.
Unskip a couple of IETestCenter bugs now that they pass.
- platform/efl/TestExpectations:
- 4:33 AM QtWebKitGardening edited by
- add more info to how to build QtWebKit section, fix the URL of the PPA (diff)
- 4:32 AM Changeset in webkit [129305] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build is broken with GLib Unicode backend
https://bugs.webkit.org/show_bug.cgi?id=97308.
Patch by Thierry Reding <thierry.reding@avionic-design.de> on 2012-09-22
Reviewed by Carlos Garcia Campos.
The TextBreakIteratorGtk implementation uses ubrk_close() to delete
the iterator. However that function is ICU specific and not declared
when using the GLib backend. Instead the iterator can simply be freed
using the delete operator.
This commit is based on work by Martin Schlemmer who posted a fix for
this here:
http://permalink.gmane.org/gmane.os.opendarwin.webkit.gtk/1210
No new tests.
- platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator):
Free iterator using delete instead of ubrk_close().
- 3:31 AM Changeset in webkit [129304] by
-
- 8 edits3 adds in trunk/LayoutTests
[CSSRegions]Add test for accelerating compositing of elements in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=97387
Reviewed by Dirk Schulze.
At this moment, accelerated compositing is disabled for elements inside a RenderFlowThread. This patch adds
a specific test in compositing/regions that is expected to fail until https://bugs.webkit.org/show_bug.cgi?id=84900
is fixed. The code for the new test is taken out of the existing fast/regions/webkit-flow-renderer-layer.html.
- compositing/regions/webkit-flow-renderer-layer-compositing-expected.html: Added.
- compositing/regions/webkit-flow-renderer-layer-compositing.html: Added.
- fast/regions/webkit-flow-renderer-layer-expected.html:
- fast/regions/webkit-flow-renderer-layer.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/Skipped:
- 1:10 AM Changeset in webkit [129303] by
-
- 5 edits in trunk/Tools
Unexpected reftest passes are only reported when pixel testing is enabled
https://bugs.webkit.org/show_bug.cgi?id=97242
Reviewed by Dirk Pranke.
LayoutTestRunner should know whether the finished test it's handling is
a reftest. This is necessary when updating result summary for reftests
when pixel testing is not enabled - in these circumstances an unexpectedly
passing reftest was not reported as such due to pixel testing then being
determined by searching for reftest failures in failures list, which were
not found in an empty failure list of a passing test. Now the TestResult
objects have a member variable indicating the test is a reftest whenever
that's the case.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner._update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests.test_update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.run):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.init):
- 1:00 AM Changeset in webkit [129302] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marking mathml/presentation/subsup.xhtml as flaky, the flakiness
being observable after r128837.
Adding image failure expectation for fast/text/word-space-with-kerning-2.html,
introduced in r129233.
- platform/gtk/TestExpectations:
- 12:26 AM Changeset in webkit [129301] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, unskip now passing tests.
- platform/qt-5.0-wk1/Skipped:
- platform/qt/Skipped:
- 12:01 AM Changeset in webkit [129300] by
-
- 1 edit2 moves in trunk/LayoutTests
[Qt] New fast/text/kerning-with-TextLayout.html fails
https://bugs.webkit.org/show_bug.cgi?id=97388
Moved this test into platform/mac, as it is not platform-independent, and TextLayout is currently
used only on OS X.
- fast/text/kerning-with-TextLayout-expected.html: Removed.
- fast/text/kerning-with-TextLayout.html: Removed.
- platform/mac/fast/text/kerning-with-TextLayout-expected.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout-expected.html.
- platform/mac/fast/text/kerning-with-TextLayout.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout.html.
- 12:00 AM Changeset in webkit [129299] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
Sep 21, 2012:
- 11:43 PM Changeset in webkit [129298] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolled out a line I committed by accident.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- 11:34 PM Changeset in webkit [129297] by
-
- 18 edits in trunk
Optimized closures that capture arguments
https://bugs.webkit.org/show_bug.cgi?id=97358
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Previously, the activation object was responsible for capturing all
arguments in a way that was convenient for the arguments object. Now,
we move all captured variables into a contiguous region in the stack,
allocate an activation for exactly that size, and make the arguments
object responsible for knowing all the places to which arguments could
have moved.
This seems like the right tradeoff because
(a) Closures are common and long-lived, so we want them to be small.
(b) Our primary strategy for optimizing the arguments object is to make
it go away. If you're allocating arguments objects, you're already having
a bad time.
(c) It's common to use either the arguments object or named argument
closure, but not both.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::activationRegister):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::argumentIndexAfterCapture): m_numCapturedVars is gone
now -- we have an explicit range instead.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Move captured arguments
into the captured region of local variables for space efficiency. Record
precise data about where they moved for the sake of the arguments object.
Some of this data was previously wrong, but it didn't cause any problems
because the arguments weren't actually moving.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables): Don't
assume that captured vars are in any particular location -- always ask
the CodeBlock. This is better encapsulation.
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): I rename things sometimes.
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff): Account for a particularly nasty edge case.
(JSC::Arguments::didTearOffActivation): Don't allocate our slow arguments
data on tear-off. We need to allocate it eagerly instead, since we need
to know about displaced, captured arguments during access before tear-off.
- runtime/Arguments.h:
(JSC::Arguments::allocateSlowArguments):
(JSC::Arguments::argument): Tell our slow arguments array where all arguments
are, even if they are not captured. This simplifies some things, so we don't
have to account explicitly for the full matrix of (not torn off, torn off)
- (captured, not captured).
(JSC::Arguments::finishCreation): Allocate our slow arguments array eagerly
because we need to know about displaced, captured arguments during access
before tear-off.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(JSC::FunctionExecutable::parameterCount):
(FunctionExecutable):
- runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
- runtime/JSActivation.h:
(JSActivation):
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registerOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::allocationSize):
(JSC::JSActivation::isValid): This is really the point of the patch. All
the pointer math in Activations basically boils away, since we always
copy a contiguous region of captured variables now.
- runtime/SymbolTable.h:
(JSC::SlowArgument::SlowArgument):
(SlowArgument):
(SharedSymbolTable):
(JSC::SharedSymbolTable::captureCount):
(JSC::SharedSymbolTable::SharedSymbolTable): AllOfTheThings capture mode
is gone now -- that's the point of the patch. indexIfCaptured gets renamed
to index because we always have an index, even if not captured. (The only
time when the index is meaningless is when we're Deleted.)
LayoutTests:
- fast/js/dfg-arguments-alias-activation-expected.txt:
- fast/js/dfg-arguments-alias-activation.html:
- 9:44 PM Changeset in webkit [129296] by
-
- 3 edits1 add in trunk
HTMLMediaElement isn't garbage collected between document reloads
https://bugs.webkit.org/show_bug.cgi?id=97020
Reviewed by Eric Carlson.
.:
Manual test added: ManualTests/audio-freed-during-reload.html
- ManualTests/audio-freed-during-reload.html:
Source/WebCore:
JS-created (as opposed to DOM-created) Audio nodes never got collected, because they
appear to always hasPendingActivity(), because m_playing is never set to false.
Manual test added: ManualTests/audio-freed-during-reload.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::stop): set m_playing = false; explicitly.
- 8:18 PM Changeset in webkit [129295] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Lion and Snow Leopard builds.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessService):
- 8:04 PM Changeset in webkit [129294] by
-
- 3 edits in trunk/Source/WebCore
RenderMarquee causes ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) : WebCore::FloatRect WebCore::RenderGeometryMap::absoluteRect(const WebCore::FloatRect &) const
https://bugs.webkit.org/show_bug.cgi?id=92464
Reviewed by Sam Weinig.
Marquees could cause an updateCompositingLayersAfterScroll() to be called when
we're in the middle of updating layer positions. updateCompositingLayersAfterScroll()
does a full RenderLayer tree walk, but its use of RenderGeomeryMap reveals that
it's using layers whose positions haven't been updated yet.
Fix by avoiding the updateCompositingLayersAfterScroll() if we're in the process
of updating a marquee when updating layer positions. We'll do a compositing update
soon anyway.
Tested by fast/events/tabindex-focus-blur-all.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):
- rendering/RenderLayer.h:
(RenderLayer):
- 7:22 PM Changeset in webkit [129293] by
-
- 7 edits2 copies5 moves3 adds in trunk
WebProcess XPC services need have their environment set without disrupting all other XPC services
https://bugs.webkit.org/show_bug.cgi?id=95161
Reviewed by Anders Carlsson.
Source/WebKit2:
Replace the WebKit2Service with two new XPC services, the WebProcessService, which is only used
when installed on the system, and the WebProcessServiceForWebKitDevelopment which is used at all
other times. We need both services because XPC can't in general be configured to have a custom
environment at runtime, and thus WebProcessServiceForWebKitDevelopment has the ability to re-exec
itself into a desired state. That capability is rather undesirable for installed usage, where we
don't want to allow arbitrary changes to the environment of the service, which would allow breaking
the App Sandbox.
- Configurations/WebProcessService.xcconfig: Copied from Source/WebKit2/Configurations/WebKit2Service.xcconfig.
- Configurations/WebProcessServiceForWebKitDevelopment.xcconfig: Renamed from Source/WebKit2/Configurations/WebKit2Service.xcconfig.
Add new configuration files.
- Platform/mac/WorkQueueMac.cpp:
(WorkQueue::registerMachPortEventHandler):
(WorkQueue::unregisterMachPortEventHandler):
Add helpful assertions. Without them, we confusingly crash a bit later in HashTable code.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
Factor out environment additions to this helper function.
(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessServiceForWebKitDevelopment):
Add functionality to setup the webkit development service via re-exec.
(WebKit::createWebProcessService):
Add functionality to connect to the installed WebProcess service.
(WebKit::createProcess):
Factor out posix_spawn based launching into this helper function.
(WebKit::ProcessLauncher::launchProcess):
Call the correct process creation function based on launch data and install state.
- WebKit2.xcodeproj/project.pbxproj:
Add new files to the project.
- WebProcess/mac/WebProcessServiceEntryPoints.h: Renamed from Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.h.
- WebProcess/mac/WebProcessServiceEntryPoints.mm: Renamed from Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.mm.
(WebKit::WebProcessServiceEventHandler):
(WebProcessServiceMain):
(InitializeWebProcessForWebProcessServiceForWebKitDevelopment):
Rename to WebProcessServiceEntryPoints since this is now used for both the WebProcessService and the
WebProcessServiceForWebKitDevelopment.
- WebProcessService/Info.plist: Copied from Source/WebKit2/WebKit2Service/Info.plist.
- WebProcessService/WebProcessServiceMain.mm: Renamed from Source/WebKit2/WebKit2Service/MainMacService.mm.
Add main for the WebProcessService which just calls into the WebProcessServiceEntryPoints in WebKit2.framework.
- WebProcessServiceForWebKitDevelopment/Info.plist: Renamed from Source/WebKit2/WebKit2Service/Info.plist.
- WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm: Added.
Add main for the WebProcessServiceForWebKitDevelopment, which can't just call directly into WebProcessServiceEntryPoints
as the framework path might not be set up correctly. This is also where we re-exec ourselves when required.
Tools:
Remove setting the XPC_* environment variables.
- Scripts/webkitdirs.pm:
(setUpGuardMallocIfNeeded):
(runMacWebKitApp):
(execMacWebKitAppForDebugging):
- 7:06 PM Changeset in webkit [129292] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eeeep - broke early boyer in bug#97382
https://bugs.webkit.org/show_bug.cgi?id=97383
Rubber stamped by Sam Weinig.
missed a child3 -> child2!
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
- 6:50 PM Changeset in webkit [129291] by
-
- 2 edits in trunk/Tools
Fix typo in additional-platform-directory patch just landed
https://bugs.webkit.org/show_bug.cgi?id=97380
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.relative_test_filename):
(Port.relative_perf_test_filename):
- 6:35 PM Changeset in webkit [129290] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:34 PM Changeset in webkit [129289] by
-
- 5 edits in trunk/Source/JavaScriptCore
Pedantic test in Mozilla's JavaScript test suite fails. function-001.js function-001-n.js
https://bugs.webkit.org/show_bug.cgi?id=27219
Reviewed by Sam Weinig.
These tests are just wrong.
See ECMA 262 A.5, FunctionDelcaration does not require a semicolon.
- tests/mozilla/expected.html:
- tests/mozilla/js1_2/function/function-001-n.js:
- tests/mozilla/js1_3/Script/function-001-n.js:
- tests/mozilla/js1_3/regress/function-001-n.js:
- 6:27 PM Changeset in webkit [129288] by
-
- 4 edits4 adds in trunk
Remove bogus assertions from ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=97372
Reviewed by Ryosuke Niwa.
Source/WebCore:
Some asserts (and their accompanying comment) were trying to enforce
proper usage of ChildListMutationScope from WebCore, but in the
presence of MutationEvents they could fail due to arbitrary script
execution.
This change gets rid of those asserts and adds tests exercising
the (pre-existing) codepaths for handling these out-of-order cases.
Without this patch, these tests ASSERT in debug builds.
Tests: fast/mutation/added-out-of-order.html
fast/mutation/removed-out-of-order.html
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::childAdded):
(WebCore::ChildListMutationAccumulator::willRemoveChild):
- dom/ChildListMutationScope.h:
(WebCore):
LayoutTests:
- fast/mutation/added-out-of-order-expected.txt: Added.
- fast/mutation/added-out-of-order.html: Added.
- fast/mutation/removed-out-of-order-expected.txt: Added.
- fast/mutation/removed-out-of-order.html: Added.
- 6:18 PM Changeset in webkit [129287] by
-
- 16 edits in trunk/Source/JavaScriptCore
Remove redundant argument to op_instanceof
https://bugs.webkit.org/show_bug.cgi?id=97382
Reviewed by Geoff Garen.
No longer needed after my last change.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitInstanceOf):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::InstanceOfNode::emitBytecode):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 6:13 PM Changeset in webkit [129286] by
-
- 3 edits in trunk/Source/WebKit2
Fix WebKit2 sandbox profile.
Instead of using #pragmas, just disable all warnings in DerivedSources.make. I suspect
that passing -traditional to the preprocessor disables support for #pragmas but I'm afraid
to change it to something else.
- DerivedSources.make:
- WebProcess/com.apple.WebProcess.sb.in:
- 6:00 PM Changeset in webkit [129285] by
-
- 5 edits in trunk/Tools
nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=97380
Reviewed by Ojan Vafai.
There doesn't seem to be a good reason for this restriction and
it's useful to be able to point to directories outside the
checkout for results (e.g., for local failures due to a 10.7.4
install ;).
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.relative_test_filename):
(Port.relative_perf_test_filename):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._command_from_driver_input):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_additional_platform_directory):
- 6:00 PM Changeset in webkit [129284] by
-
- 3 edits2 adds in trunk
REGRESSION (r129176): Incorrect line breaking when kerning occurs between a space and the following character
https://bugs.webkit.org/show_bug.cgi?id=97377
Reviewed by Enrica Casucci.
Source/WebCore:
Test: fast/text/kerning-with-TextLayout.html
When kerning is enabled, the last character in a word may have its advance shortened because
of its trailing space. To account for that, words are measured along with the trailing space,
then the width of a space is subtracted from the result. This doesn’t work when the trailing
space itself has its advance shortened due to the character following it, which can happen
when using the TextLayout optimization. However, when the optimization is used, the advance
of the last character of the word is already adjusted for the trailing space, so there is no
need to measure with that space and subtract its advance.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Changed to not use the trailingSpaceWidth
mechanism when TextLayout is being used.
LayoutTests:
- fast/text/kerning-with-TextLayout-expected.html: Added.
- fast/text/kerning-with-TextLayout.html: Added.
- 5:53 PM Changeset in webkit [129283] by
-
- 2 edits in trunk/Source/Platform
[chromium] Forward-declare WebSize as a struct
https://bugs.webkit.org/show_bug.cgi?id=97381
Reviewed by James Robinson.
The mismatched "class" forward-declaration for WebSize in this file
will cause a Clang error when it's included in Chromium.
- chromium/public/WebCompositorSoftwareOutputDevice.h:
(WebKit):
- 5:46 PM Changeset in webkit [129282] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 5:43 PM Changeset in webkit [129281] by
-
- 29 edits in trunk
instanceof should not get the prototype for non-default HasInstance
https://bugs.webkit.org/show_bug.cgi?id=68656
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Instanceof is currently implemented as a sequance of three opcodes:
check_has_instance
get_by_id(prototype)
op_instanceof
There are three interesting types of base value that instanceof can be applied to:
(A) Objects supporting default instanceof behaviour (functions, other than those created with bind)
(B) Objects overriding the default instancecof behaviour with a custom one (API objects, bound functions)
(C) Values that do not respond to the HasInstance trap.
Currently check_has_instance handles case (C), leaving the op_instanceof opcode to handle (A) & (B). There are
two problems with this apporach. Firstly, this is suboptimal for case (A), since we have to check for
hasInstance support twice (once in check_has_instance, then for default behaviour in op_instanceof). Secondly,
this means that in cases (B) we also perform the get_by_id, which is both suboptimal and an observable spec
violation.
The fix here is to move handing of non-default instanceof (cases (B)) to the check_has_instance op, leaving
op_instanceof to handle only cases (A).
- API/JSCallbackObject.h:
(JSCallbackObject):
- API/JSCallbackObjectFunctions.h:
(JSC::::customHasInstance):
- API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
- renamed hasInstance to customHasInstance
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- added additional parameters to check_has_instance opcode
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- added additional parameters to check_has_instance opcode
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCheckHasInstance):
- added additional parameters to check_has_instance opcode
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- added additional parameters to check_has_instance opcode
- bytecompiler/NodesCodegen.cpp:
(JSC::InstanceOfNode::emitBytecode):
- added additional parameters to check_has_instance opcode
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- added additional parameters to check_has_instance opcode
- interpreter/Interpreter.cpp:
(JSC::isInvalidParamForIn):
(JSC::Interpreter::privateExecute):
- Add handling for non-default instanceof to op_check_has_instance
- jit/JITInlineMethods.h:
(JSC::JIT::emitArrayProfilingSiteForBytecodeIndex):
- Fixed no-LLInt no_DFG build
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emitSlow_op_check_has_instance):
- check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- no need to check for ImplementsDefaultHasInstance.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emitSlow_op_check_has_instance):
- check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- no need to check for ImplementsDefaultHasInstance.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- Add handling for non-default instanceof to op_check_has_instance
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- move check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.
- runtime/ClassInfo.h:
(MethodTable):
(JSC):
- renamed hasInstance to customHasInstance
- runtime/CommonSlowPaths.h:
(CommonSlowPaths):
- removed opInstanceOfSlow (this was whittled down to one function call!)
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::customHasInstance):
- runtime/JSBoundFunction.h:
(JSBoundFunction):
- renamed hasInstance to customHasInstance, reimplemented.
- runtime/JSCell.cpp:
(JSC::JSCell::customHasInstance):
- runtime/JSCell.h:
(JSCell):
- runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
(JSC):
(JSC::JSObject::defaultHasInstance):
- runtime/JSObject.h:
(JSObject):
LayoutTests:
- fast/js/function-bind-expected.txt:
- check in passing result.
- 5:31 PM DeprecatingFeatures edited by
- (diff)
- 5:31 PM DeprecatingFeatures edited by
- (diff)
- 5:30 PM Changeset in webkit [129280] by
-
- 4 edits in trunk/Source/WebCore
Simplify and optimize ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=97352
Reviewed by Ryosuke Niwa.
ChildListMutationScope is one of the most complicated bits of
MutationObserver implementation. This patch aims to simplify it for
clarity and improve its performance (mostly by just doing less).
The big change is to remove the MutationAccumulatorRouter class,
replacing it with lifetime-management logic in ChildListMutationAccumulator
ChildListMutationScope is expected to call getOrCreate() in
its constructor, and each scope holds a RefPtr to the accumulator.
When the last scope holding such a RefPtr is destroyed,
ChildListMutationAccumulator's destructor enqueues the accumulated record.
This greatly reduces the number of lines of code, and condenses
two HashMaps into one. It also reduces hash lookups, which now
occur only on scope creation and when the refcount for a given
accumulator reaches 0 (previously, each childAdded and willRemoveChild
call could result in two hash lookups each).
There are some minor changes as well: the ChildListMutationAccumulator::clear()
method is gone, as it was doing more work than necessary;
DEFINE_STATIC_LOCAL is now used instead of hand-rolled static-management
code; ChildListMutationAccumulator::m_lastAdded is no longer a RefPtr, since it
always points at a Node that's already being ref'd by the accumulator.
Also various minor syntactic cleanups.
No new tests, no change in behavior.
- dom/ChildListMutationScope.cpp:
(WebCore::accumulatorMap): Reduced two maps to one, and manage its lifetime with DEFINE_STATIC_LOCAL.
(WebCore::ChildListMutationAccumulator::ChildListMutationAccumulator): Remove unnecessary call to clear() (which itself has been removed).
(WebCore::ChildListMutationAccumulator::~ChildListMutationAccumulator): Enqueue record if not empty at destruction, and have the accumulator
remove itself from the map.
(WebCore::ChildListMutationAccumulator::getOrCreate): Replaces half of MutationAccumulatorRouter's job.
(WebCore::ChildListMutationAccumulator::childAdded): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::isRemovedNodeInOrder): Simplify RefPtr syntax.
(WebCore::ChildListMutationAccumulator::willRemoveChild): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord): Replace call to clear() with clearing m_lastAdded,
since it's the only bit not cleared by the MutationRecord creation call. Also remove
isEmpty check and replace with asserts now that it's a private method.
(WebCore::ChildListMutationAccumulator::isEmpty): Added more assertions about emptiness.
- dom/ChildListMutationScope.h:
(WebCore):
(ChildListMutationAccumulator): Extract the inner class to make everything easier to read.
(WebCore::ChildListMutationScope::ChildListMutationScope): Store m_accumulator rather than m_target.
(WebCore::ChildListMutationScope::~ChildListMutationScope): ditto
(WebCore::ChildListMutationScope::childAdded): ditto
(WebCore::ChildListMutationScope::willRemoveChild): ditto
(ChildListMutationScope):
- html/HTMLElement.cpp: Remove unused ChildListMutationScope.h #include.
- 5:16 PM Changeset in webkit [129279] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip this test because it relies on sandboxed-iframe-origin-add.html which was removed in http://trac.webkit.org/changeset/129262.
- platform/win/Skipped:
- 5:13 PM Changeset in webkit [129278] by
-
- 4 edits in trunk
fast/dom/Geolocation/disconnected-frame.html test asserts
https://bugs.webkit.org/show_bug.cgi?id=97376
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
In GeolocationPermissionRequestManager::cancelRequestForGeolocation, we access an iterator
after its value has been removed from the table.
There are two problems with that:
-The iterator is no longer valid after the container has been modified.
-If it was the last element, the table has been freed and the iterator points to deleted memory.
We solve the issue by keeping a copy of the ID. We could have inverted the order of the calls
but that would make the issue less visible for future change.
Testing covered by fast/dom/Geolocation/disconnected-frame.html.
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
LayoutTests:
- platform/wk2/Skipped:
- 4:58 PM Changeset in webkit [129277] by
-
- 4 edits in trunk/Source/WebCore
BiquadFilterNode must take audio-rate parameter changes into account
https://bugs.webkit.org/show_bug.cgi?id=97369
Reviewed by Kenneth Russell.
BiquadFilterNode is currently ignoring any timeline or audio-rate changes to its parameters.
We now check if any of its parameters have timeline or audio-rate changes and, if so, take
them into account. Otherwise, we use ordinary parameter smoothing/de-zippering which is
the case when the parameters are adjusted, for example, from a knob or slider in the UI.
- Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::checkForDirtyCoefficients):
- Modules/webaudio/BiquadProcessor.h:
(WebCore::BiquadProcessor::hasSampleAccurateValues):
(BiquadProcessor):
- 4:58 PM Changeset in webkit [129276] by
-
- 5 edits in trunk/LayoutTests
Unreviewed. Fix Windows specific accessibility test results.
Missed some new lines in http://trac.webkit.org/changeset/129255.
- platform/win/accessibility/aria-toggle-button-with-title-expected.txt:
- platform/win/accessibility/canvas-fallback-content-2-expected.txt:
- platform/win/accessibility/img-fallsback-to-title-expected.txt:
- platform/win/accessibility/svg-image-expected.txt:
- 4:47 PM Changeset in webkit [129275] by
-
- 13 edits2 adds in trunk
Add support for OES_vertex_array_object in chromium
https://bugs.webkit.org/show_bug.cgi?id=96578
Patch by Brandon Jones <bajones@google.com> on 2012-09-21
Reviewed by Kenneth Russell.
Source/Platform:
Added code to allow calls to the OES_vertex_array_object extension to interface
properly with the chromium WebGL implementation.
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createVertexArrayOES):
(WebKit::WebGraphicsContext3D::deleteVertexArrayOES):
(WebKit::WebGraphicsContext3D::isVertexArrayOES):
(WebKit::WebGraphicsContext3D::bindVertexArrayOES):
Source/WebCore:
Adding basic reference counting to WebGLBuffer objects to satisfy spec requirements
for the OES_vertex_array_object extension. Added code to allow calls to the
OES_vertex_array_object extension to interface properly with the chromium WebGL
implementation.
Test: fast/canvas/webgl/oes-vertex-array-object.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
- html/canvas/WebGLVertexArrayObjectOES.cpp:
(WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer):
(WebCore):
- html/canvas/WebGLVertexArrayObjectOES.h:
(WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::getVertexAttribStateSize):
- platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
LayoutTests:
Brought over KHRONOS conformance test for OES_vertex_array_object
- fast/canvas/webgl/oes-vertex-array-object-expected.txt: Added.
- fast/canvas/webgl/oes-vertex-array-object.html: Added.
- platform/efl/Skipped:
- platform/gtk-wk2/Skipped:
- platform/mac/Skipped:
- platform/wk2/Skipped:
- 4:40 PM Changeset in webkit [129274] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix ARM build.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::store8):
(MacroAssemblerARMv7):
- offlineasm/armv7.rb:
- 4:35 PM Changeset in webkit [129273] by
-
- 28 edits in trunk
[Chromium] Use OpenTypeVerticalData on Linux
https://bugs.webkit.org/show_bug.cgi?id=97277
Reviewed by Tony Chang.
Source/WebCore:
Remove HarfBuzz dependency from GlyphPageTreeNodeSkia. Use OpenTypeVerticalData instead.
No new tests. Rebaselined existing tests.
- WebCore.gyp/WebCore.gyp: Added OpenTypeTypes.h and OpenTypeVerticalData.(cpp|h) for linux and android.
- platform/graphics/FontCache.cpp:
Inserted a space between > and > in typedef of FontVerticalDataCache so that making some compilers happy.
(WebCore):
- platform/graphics/SimpleFontData.h:
(SimpleFontData): Moved declaration of m_verticalData to avoid compile warnings.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::verticalData): Added.
(WebCore::FontPlatformData::openTypeTable): Added.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(WebCore):
(FontPlatformData):
- platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Removed substituteWithVerticalGlyphs().
(WebCore::GlyphPage::fill):
Source/WebKit/chromium:
- features.gypi: Enable OPENTYPE_VERTICAL on linux and android.
LayoutTests:
Rebaselined vertical writing test expectations.
- platform/chromium-linux/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/chromium-linux/fast/dynamic/text-combine-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-linux/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
- 4:30 PM DeprecatingFeatures edited by
- (diff)
- 4:29 PM Changeset in webkit [129272] by
-
- 4 edits in trunk/Source/JavaScriptCore
REGRESSION (r128400): Opening Google Web Fonts page hangs or crashes
https://bugs.webkit.org/show_bug.cgi?id=97328
Reviewed by Mark Hahnenberg.
It's a bad idea to emit stub code that reallocates property storage when we're in indexed
storage mode. DFGRepatch.cpp knew this and had the appropriate check in one of the places,
but it didn't have it in all of the places.
This change also adds some more handy disassembly support, which I used to find the bug.
- assembler/LinkBuffer.h:
(JSC):
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
- jit/JITStubRoutine.h:
(JSC):
- 4:22 PM Changeset in webkit [129271] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/dom/Document.cpp
Merge 129270 - Crash in WebCore::Document::fullScreenChangeDelayTimerFired
BUG=147700
Review URL: https://codereview.chromium.org/10969052
- 4:21 PM DeprecatingFeatures edited by
- (diff)
- 4:20 PM Changeset in webkit [129270] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::Document::fullScreenChangeDelayTimerFired
https://bugs.webkit.org/show_bug.cgi?id=97367
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2012-09-21
Reviewed by Abhishek Arya.
The document could be destroyed during the processing of the
fullscreenchange event, if the document was destroyed as a result of
one of the dispatchEvent calls.
This bug isn't reliably reproducible, so no new tests.
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
- 4:18 PM Changeset in webkit [129269] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r120361) Warnings while preprocessing com.apple.WebProcess.sb.in
https://bugs.webkit.org/show_bug.cgi?id=91079
<rdar://problem/12332660>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in:
Add pragma to ignore the invalid preprocessor warnings.
- 4:16 PM DeprecatingFeatures edited by
- (diff)
- 4:15 PM Changeset in webkit [129268] by
-
- 2 edits in trunk/LayoutTests
Skip fast/dom/Geolocation/disconnected-frame.html until the assertion is fixed
Unreviewed. The test assert in Debug, skip it until this has been fixed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-21
- platform/wk2/Skipped:
- 4:07 PM Changeset in webkit [129267] by
-
- 2 edits in trunk/Source/WebCore
No need to pass order file for WebCoreTestSupport build
https://bugs.webkit.org/show_bug.cgi?id=97363
Reviewed by David Kilzer.
No new tests because no functional change.
- Configurations/WebCoreTestSupport.xcconfig:
- 3:59 PM Changeset in webkit [129266] by
-
- 5 edits3 adds in trunk
DFG CSE assumes that a holy PutByVal does not interfere with GetArrayLength, when it clearly does
https://bugs.webkit.org/show_bug.cgi?id=97373
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGGraph.h:
(Graph):
LayoutTests:
- fast/js/dfg-holy-put-by-val-interferes-with-get-array-length-expected.txt: Added.
- fast/js/dfg-holy-put-by-val-interferes-with-get-array-length.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-holy-put-by-val-interferes-with-get-array-length.js: Added.
(foo):
- 3:51 PM DeprecatingFeatures edited by
- (diff)
- 3:47 PM TestExpectations edited by
- delete description of the old syntax (diff)
- 3:39 PM DeprecatingFeatures edited by
- (diff)
- 3:35 PM Changeset in webkit [129265] by
-
- 3 edits in trunk/Tools
webkitpy: drop support for old TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97364
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._collect_matching_tests):
(TestExpectationParser):
(TestExpectationParser._tokenize_line):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SkippedTests.test_skipped_entry_dont_exist):
(ExpectationSyntaxTests.assert_tokenize_exp):
(ExpectationSyntaxTests.test_bare_name):
(ExpectationSyntaxTests.test_bare_name_and_bugs):
(ExpectationSyntaxTests.test_comments):
(ExpectationSyntaxTests.test_config_modifiers):
(ExpectationSyntaxTests.test_unknown_config):
(ExpectationSyntaxTests.test_unknown_expectation):
(ExpectationSyntaxTests.test_skip):
(ExpectationSyntaxTests.test_slow):
(ExpectationSyntaxTests.test_wontfix):
(ExpectationSyntaxTests.test_blank_line):
(ExpectationSyntaxTests.test_warnings):
(RebaseliningTest.test_no_get_rebaselining_failures):
- 3:33 PM Changeset in webkit [129264] by
-
- 2 edits in trunk/Tools
Improve WTR unresponsiveness output a little
https://bugs.webkit.org/show_bug.cgi?id=97370
Reviewed by Timothy Horton.
Distinguish between conditions that already set the errorMessage,
and unresponsiveness due to slow about:blank loads when WTR
reports unresponsiveness.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- 3:30 PM Changeset in webkit [129263] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS to r158095 to pick up typo fix in test_expectations.txt
Unreviewed, rolled DEPS.
- DEPS:
- 3:27 PM Changeset in webkit [129262] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skipping http/tests/security/sandboxed-iframe-origin-add.html.
https://bugs.webkit.org/show_bug.cgi?id=97271
- platform/win/Skipped:
- 3:26 PM DeprecatingFeatures edited by
- (diff)
- 3:22 PM Changeset in webkit [129261] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS to r158060
Unreviewed, rolled DEPS.
- DEPS:
- 3:13 PM DeprecatingFeatures edited by
- (diff)
- 3:12 PM Changeset in webkit [129260] by
-
- 27 edits in trunk
Add Web Audio support for deprecated/legacy APIs
https://bugs.webkit.org/show_bug.cgi?id=97050
Reviewed by Eric Carlson.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The Web Audio API specification has undergone much review and some small API changes
have been made (mostly naming-related changes). This patch adds an ENABLE_LEGACY_WEB_AUDIO
build option to allow ports to support the old names.
Tests changed:
audiobuffersource-playbackrate.html
audiobuffersource.html
note-grain-on-testing.js
oscillator-testing.js
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.features.am:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::startGrain):
(WebCore):
(WebCore::AudioBufferSourceNode::noteGrainOn):
- Modules/webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode):
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):
(WebCore):
(WebCore::AudioScheduledSourceNode::noteOn):
(WebCore::AudioScheduledSourceNode::noteOff):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/Oscillator.idl:
- page/FeatureObserver.h:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- webaudio/audiobuffersource-playbackrate.html:
- webaudio/audiobuffersource.html:
- webaudio/resources/note-grain-on-testing.js:
(playGrain):
- webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):
- 3:04 PM DeprecatingFeatures edited by
- (diff)
- 3:02 PM Changeset in webkit [129259] by
-
- 4 edits in trunk/Tools
webkitpy: update remaining tests to use the new expectation syntax
https://bugs.webkit.org/show_bug.cgi?id=97362
Reviewed by Ojan Vafai.
This patch updates all the unit tests that were still using the
old TestExpectations syntax to use the new syntax *except* for
the tests that were specifically testing that we parsed the old
syntax correctly.
Also, a block of tests for the new syntax were duplicated, so
I've deleted the duplicate.
Note that the old syntax is still supported so this change should
produce no visible changes.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(MiscTests.test_multiple_results):
(MiscTests.test_category_expectations):
(MiscTests.test_error_on_different_platform):
(MiscTests.test_error_on_different_build_type):
(MiscTests.test_overrides):
(MiscTests.test_overridesdirectory):
(MiscTests.test_overridesduplicate):
(MiscTests.test_more_specific_override_resets_skip):
(SkippedTests.check):
(SkippedTests.test_duplicate_skipped_test_fails_lint):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):
(ExpectationSyntaxTests.disabled_test_missing_expectation):
(ExpectationSyntaxTests.disabled_test_missing_colon):
(ExpectationSyntaxTests.disabled_test_too_many_colons):
(ExpectationSyntaxTests.disabled_test_too_many_equals_signs):
(ExpectationSyntaxTests):
(ExpectationSyntaxTests.test_unrecognized_expectation):
(ExpectationSyntaxTests.test_macro):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(SemanticTests.test_slow_and_timeout):
(SemanticTests.test_rebaseline):
(test_missing_file):
(test_ambiguous):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(OldExpectationParserTests):
(OldExpectationParserTests._tokenize):
(OldExpectationParserTests.test_tokenize_extra_colon):
(OldExpectationParserTests.test_tokenize_missing_equal):
(OldExpectationParserTests.test_tokenize_extra_equal):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_failing_tests):
(MainTest.test_additional_expectations):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_valid_expectations):
(TestExpectationsTestCase.test_invalid_expectations):
(TestExpectationsTestCase.test_tab):
- 2:57 PM DeprecatingFeatures edited by
- (diff)
- 2:57 PM Changeset in webkit [129258] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed. As in https://bugs.webkit.org/show_bug.cgi?id=92916, Windows specific results need to be added for various accessibility tests.
- platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Added.
- platform/win/accessibility/canvas-fallback-content-2-expected.txt: Added.
- platform/win/accessibility/img-fallsback-to-title-expected.txt: Added.
- platform/win/accessibility/svg-image-expected.txt: Added.
- 2:46 PM DeprecatingFeatures edited by
- (diff)
- 2:43 PM Changeset in webkit [129257] by
-
- 11 edits2 adds in trunk/Source
[Chromium] remove getFontFamilyForCharacters from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96282
Reviewed by Tony Chang.
Migrating away from PlatformSupport. getFontFamilyForCharacters is
moved to FontCache.h and overridden by the two platforms that
need it (Chromium Linux and Blackberry). New files for the overrides.
Part of a larger refactoring series. See tracking bug 82948.
Source/WebCore:
- PlatformBlackBerry.cmake:
- WebCore.gypi:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/graphics/FontCache.h:
(SimpleFontFamily):
(FontCache):
- platform/graphics/blackberry/FontCacheBlackberry.cpp: Added.
(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):
- platform/graphics/blackberry/skia/PlatformSupport.cpp:
(WebCore):
- platform/graphics/blackberry/skia/PlatformSupport.h:
(PlatformSupport):
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/chromium/FontCacheChromiumLinux.cpp: Added.
(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):
- platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 2:40 PM Changeset in webkit [129256] by
-
- 2 edits in branches/safari-536.27-branch/Source/JavaScriptCore
Enable opportunistic garbage collecting on Windows.
Patch by Roger Fong <roger_fong@apple.com> on 2012-09-20
Reviewed by Mark Hahnenberg
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:39 PM Changeset in webkit [129255] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed. Creating some Windows specific tests.
http://trac.webkit.org/changeset/128652 changed results for these tests on Mac but Windows results should stay the same.
- platform/win/fast/block/positioning: Added.
- platform/win/fast/block/positioning/016-expected.txt: Added.
- platform/win/fast/block/positioning/025-expected.txt: Added.
- platform/win/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
- 2:27 PM Changeset in webkit [129254] by
-
- 6 edits2 adds in trunk
Source/WebCore: AX: WebKit exposes incorrect bounds for embedded SVG in HTML
https://bugs.webkit.org/show_bug.cgi?id=96168
Reviewed by Eric Seidel.
Override absoluteFocusRingQuads() for SVG objects because the default
implementation relies on addFocusRingRects(). In addFocusRingRects(), SVG
objects adds local positions for its rects instead of absolute positions.
Test: accessibility/svg-bounds.html
- rendering/RenderObject.h:
(RenderObject):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore):
(WebCore::RenderSVGModelObject::absoluteFocusRingQuads):
- rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
LayoutTests: WebKit exposes incorrect bounds for embedded SVG in HTML
https://bugs.webkit.org/show_bug.cgi?id=96168
Reviewed by Eric Seidel.
- accessibility/svg-bounds.html: Added.
- platform/chromium/TestExpectations:
- platform/mac/accessibility/svg-bounds-expected.txt: Added.
- 2:24 PM Changeset in webkit [129253] by
-
- 1 edit in branches/chromium/1271/Source/WebKit/chromium/features.gypi
Merge 125155 - Disable iframe seamless for m23.
Review URL: https://codereview.chromium.org/10970046
- 2:06 PM Changeset in webkit [129252] by
-
- 22 edits2 adds in trunk
[WK2] Add basic testing support for Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97278
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
- Shared/API/c/WKNumber.h: Fix an unfortunate copy-paste :)
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Remove the code forcing the Geolocation permissions. It was working around the normal
Geolocation code and updating all the GeolocationController, which is a terrible idea.
Tools:
Update the Geolocation testing to use the proper API in the UIProcess.
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/GNUmakefile.am:
- WebKitTestRunner/GeolocationProviderMock.cpp: Added.
(WTR::startUpdatingCallback):
(WTR::stopUpdatingCallback):
(WTR::GeolocationProviderMock::GeolocationProvierMock):
(WTR::GeolocationProviderMock::setMockGeolocationPosition):
(WTR::GeolocationProviderMock::startUpdating):
(WTR::GeolocationProviderMock::stopUpdating):
(GeolocationProviderMock):
The GeolocationProvider store the location update and deliver them as needed.
WebCore GeolocationController do not support asynchronous update on start/stop. This is not
a problem in this case because all the messages between the WebProcess and the UIProcess are
asynchronous. Because of this, unlike GeolocationClientMock, we do not use a timer for event
delivery.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::setGeolocationPermission):
(WTR::InjectedBundle::setMockGeolocationPosition):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setGeolocationPermission):
(WTR::TestRunner::setMockGeolocationPosition):
From the InjectedBundle, we now pass the information to the UIProcess so that
GeolocationProvider and the TestController can respond appropriately.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::decidePolicyForGeolocationPermissionRequest):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::setMockGeolocationPosition):
- WebKitTestRunner/TestController.h:
(TestController):
(WTR::TestController::setGeolocationPermission):
(WTR::TestController::isGeolocationPermissionAllowed):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/win/WebKitTestRunner.vcproj:
LayoutTests:
- platform/wk2/Skipped: Unskip the passing tests.
- 2:02 PM Changeset in webkit [129251] by
-
- 12 edits1 add in trunk/Source
[BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.
https://bugs.webkit.org/show_bug.cgi?id=97348
Internal PR: 186597.
Internally reviewed by Yong Li, Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-09-21
Reviewed by Yong Li.
Source/WebCore:
Add a singleton AuthenticationChallengeManager to manage authentication
challenge dialog. It does following things:
Record page creation/deletion, so it knows what page is present or not.
Record page visibility change so it knows when to display a dialog or not.
Accept authentication challenge, and decide whether to postpone the
challenge dialog based on whether there is active authentication challenge
dialog already and whether its page is visible or not.
When a challenge result comes back, notify the result to all clients
authenticating for the same protection space, and then start the next
authentication challenge from the same page, if there is one.
When a page becomes visible, start the first authentication challenge
dialog that has been blocked before.
And to support this new AuthenticationChallengeManager, and making the
challenge really asynchronous, NetworkJob has been updated to support
the concept of "freeze", which means buffering all network loading status
change but don't send them to NetworkJob clients.
This is necessary when authentication challenge is asynchronous, as the
previous network loading status will likely come before user make any
decision.
No new tests for platform specific internal change.
- PlatformBlackBerry.cmake:
- platform/blackberry/AuthenticationChallengeManager.cpp: Added.
(WebCore):
(ChallengeInfo):
(WebCore::ChallengeInfo::ChallengeInfo):
(AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::resumeAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::startAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::pageExists):
(WebCore::AuthenticationChallengeManager::AuthenticationChallengeManager):
(WebCore::AuthenticationChallengeManager::pageCreated):
(WebCore::AuthenticationChallengeManager::pageDeleted):
(WebCore::AuthenticationChallengeManager::pageVisibilityChanged):
(WebCore::AuthenticationChallengeManager::authenticationChallenge):
(WebCore::AuthenticationChallengeManager::cancelAuthenticationChallenge):
(WebCore::AuthenticationChallengeManager::notifyChallengeResult):
(WebCore::AuthenticationChallengeManager::instance):
(WebCore::AuthenticationChallengeManager::init):
- platform/blackberry/AuthenticationChallengeManager.h:
(WebCore):
(AuthenticationChallengeManager):
- platform/blackberry/PageClientBlackBerry.h:
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::~NetworkJob):
(WebCore):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
Source/WebKit/blackberry:
Update WebPage to use new AuthenticationChallengeManager.
Register page creation/deletion and visibility change to the new
AuthenticationChallengeManager.
Initialize AuthenticationChallengeManager in GlobalInitialize() function.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):
- Api/WebPage_p.h:
(WebPagePrivate):
- 1:32 PM Changeset in webkit [129250] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Make Web Inspector work in multiple web process mode
https://bugs.webkit.org/show_bug.cgi?id=97354
Reviewed by Timothy Hatcher.
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):
Tell WKView that it's related to original page, making inspector page be in the same process.
- 1:16 PM Changeset in webkit [129249] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r129248.
http://trac.webkit.org/changeset/129248
https://bugs.webkit.org/show_bug.cgi?id=96000
Broke win build
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- rendering/RenderingAllInOne.cpp:
- 1:10 PM WebKitGTK/1.10.x edited by
- (diff)
- 1:09 PM Changeset in webkit [129248] by
-
- 4 edits in trunk/Source/WebCore
Make RenderingAllInOne.cpp usable for ports other than Apple/Win
https://bugs.webkit.org/show_bug.cgi?id=96000
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-21
Reviewed by Ryosuke Niwa.
RenderingAllInOne.cpp unconditionally includes RenderThemeWin. This patch separates
it out from the file.
- Target.pri: Add RenderingAllInOne.cpp to the list of supported all-in-one files.
- WebCore.vcproj/WebCore.vcproj: Compile RenderThemeWin.cpp separately.
- rendering/RenderingAllInOne.cpp: Don't include RenderThemeWin.cpp here.
- 1:03 PM Changeset in webkit [129247] by
-
- 6 edits1 add in trunk
REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=96196
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.
The "regression" is that a new test was added but the support was missing
in the Gtk port for spin buttons.
Source/WebCore:
No new tests. Instead the new test which had been skipped was unskipped
as part of this fix.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
(getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
the AtkValue interface.
Tools:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::valueDescription): Updated the FIXME comment to
indicate that this cannot be implemented until it is implemented in ATK.
URL of the newly-filed ATK bug included for reference.
LayoutTests:
- platform/gtk/TestExpectations: Unskip the new test.
- platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
- 12:40 PM Changeset in webkit [129246] by
-
- 3 edits2 adds in trunk
[GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=96932
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.
Source/WebCore:
Make the decision based on RenderObjects rather than AccessibilityObjects
to avoid the infinite recursion which occurs when remapAriaRoleDueToParent
gets called.
Test: platform/gtk/accessibility/remapped-aria-crash.html
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
Added a new test which replicates the recursion and crash.
- platform/gtk/accessibility/remapped-aria-crash-expected.txt: Added.
- platform/gtk/accessibility/remapped-aria-crash.html: Added.
- 12:35 PM Changeset in webkit [129245] by
-
- 2 edits in trunk/Tools
Fix test_skip_and_wontfix failure
https://bugs.webkit.org/show_bug.cgi?id=97225
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SemanticTests.test_skip_and_wontfix):
- 12:24 PM Changeset in webkit [129244] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] HTML5 media does not handle SSL certificate failures
https://bugs.webkit.org/show_bug.cgi?id=93324
Patch by Jonathan Dong <Jonathan Dong> on 2012-09-21
Reviewed by Eric Carlson.
RIM PR: 116205
Passed FrameLoaderClientBlackBerry's playerId to MMRPlayer::load()
because MMRPlayer::load() added playerId as a new parameter, which
is required to initiate a MediaSSLHandlerStream to deal with
certificate failure when loading a "https" media url.
Internally reviewed by Joe Mason <jmason@rim.com>.
No new tests since there's no functional change.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
- 11:47 AM Changeset in webkit [129243] by
-
- 4 edits in trunk/Source
[chromium] Add setters to WebFilterOperation for IPC pickling
https://bugs.webkit.org/show_bug.cgi?id=97147
Reviewed by James Robinson.
Source/Platform:
These methods allow us to restore a WebFilterOperation from a blob
of opaque data. The pickling code needs to be able to create an
empty object and then fill in the pieces, so these setters allow it
to do so.
Test: WebFilterOperationsTest.saveAndRestore
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createEmptyFilter):
(WebKit::WebFilterOperation::setType):
(WebKit::WebFilterOperation::setAmount):
(WebKit::WebFilterOperation::setDropShadowOffset):
(WebKit::WebFilterOperation::setDropShadowColor):
(WebKit::WebFilterOperation::setMatrix):
(WebKit::WebFilterOperation::setZoomRect):
- chromium/src/WebFilterOperation.cpp:
Source/WebKit/chromium:
- tests/FilterOperationsTest.cpp:
(WebKit):
(WebKit::TEST):
- 11:13 AM Changeset in webkit [129242] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico.
- WebKit.gyp:
- 11:09 AM Changeset in webkit [129241] by
-
- 5 edits in trunk
Global Math object should be configurable but isn't
https://bugs.webkit.org/show_bug.cgi?id=55343
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This has no performance impact.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- Make 'Math' a regular property.
LayoutTests:
Added test case.
- fast/js/math-expected.txt:
- fast/js/script-tests/math.js:
- Added test case.
- 10:43 AM Changeset in webkit [129240] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21
- DEPS:
- 10:28 AM Changeset in webkit [129239] by
-
- 3 edits in trunk/Source/WebCore
[WebSocket] Receiving a large message is really slow
https://bugs.webkit.org/show_bug.cgi?id=97237
Patch by Evan Wallace <evan.exe@gmail.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.
WebSocketChannel always reallocates its internal buffer when it receives
and appends new data which causes dramatic slowdowns for messages over
2 MB in size. This patch changes the internal buffer of WebSocketChannel
from a raw char array to a Vector<char> and uses its amortized append()
method. This brings the time to receive a 5 MB message from 5.2 seconds
to 0.25 seconds.
This patch is only for optimization. No new tests are needed.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::~WebSocketChannel):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::resume):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::skipBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::processFrame):
- Modules/websockets/WebSocketChannel.h:
- 9:50 AM Changeset in webkit [129238] by
-
- 9 edits1 copy in trunk
[GTK] Implement ViewState methods in PageClientImpl in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=97202
Reviewed by Martin Robinson.
Source/WebKit2:
Implement isViewWindowActive(), isViewFocused(), isViewVisible()
and isViewInWindow() in PageClientImpl.
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/C/gtk/WKView.cpp:
(WKViewSetFocus): New private method used by WTR to focus the
WebView.
- UIProcess/API/C/gtk/WKViewPrivate.h: Added.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::isViewWindowActive): Return
webkitWebViewBaseIsInWindowActive().
(WebKit::PageClientImpl::isViewFocused): Return
webkitWebViewBaseIsFocused().
(WebKit::PageClientImpl::isViewVisible): Return
webkitWebViewBaseIsVisible().
(WebKit::PageClientImpl::isViewInWindow): Return
webkitWebViewBaseIsInWindow().
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseNotifyResizerSize): Updated to not receive the
window as parameter since it's now saved in the instance struct.
(toplevelWindowResizeGripVisibilityChanged): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(toplevelWindowFocusInEvent): Update ViewWindowIsActive flag and
notify the WebPageProxy if it changed.
(toplevelWindowFocusOutEvent): Ditto.
(webkitWebViewBaseSetToplevelOnScreenWindow): Set the toplevel
on-screen window where the view is currently added and notify
WebPageProxy if it changed.
(webkitWebViewBaseRealize): Call
webkitWebViewBaseSetToplevelOnScreenWindow() if the view has been
added to an on-screen window.
(webkitWebViewBaseFinalize): Reset the toplevel on-screen window
to make sure all signals are disconnected when the view is
destroyed.
(webkit_web_view_base_init): Remove unneeded initialization.
(resizeWebKitWebViewBaseFromAllocation): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(webkitWebViewBaseMap): Update ViewIsVisible flag and notify
WebPageProxy if it changed.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseFocusInEvent): Call webkitWebViewBaseSetFocus()
passing true to focus the view.
(webkitWebViewBaseFocusOutEvent): Call webkitWebViewBaseSetFocus()
passing false to unfocus the view.
(webkitWebViewBaseParentSet): Reset the toplevel on-screen window
if the view is re-parented.
(webkit_web_view_base_class_init): Add implementations for map and
parent-set virtual functions.
(webkitWebViewBaseSetFocus): Update the ViewIsFocused and notify
WebPageProxy if it changed.
(webkitWebViewBaseIsInWindowActive):
(webkitWebViewBaseIsFocused):
(webkitWebViewBaseIsVisible):
(webkitWebViewBaseIsInWindow):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Use a GTK_WINDOW_TOPLEVEL instead of
POPUP for this test to make sure the view receives focus change
events.
Tools:
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::focus): Focus the view.
- 9:45 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:44 AM Changeset in webkit [129237] by
-
- 52 edits in branches/safari-534.58-branch
Source/WebCore: Update Localizable.strings after merging plug-in blacklisting changes.
- English.lproj/Localizable.strings:
Source/WebKit/mac: Merge r119543.
2012-06-05 Anders Carlsson <andersca@apple.com>
Build fix.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.
Source/WebKit/win: Merge r116687.
2012-05-10 Anders Carlsson <andersca@apple.com>
Rename the missing plug-in indicator to the unavailable plug-in indicator
https://bugs.webkit.org/show_bug.cgi?id=86136
Reviewed by Sam Weinig.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Source/WebKit2: Merge r117634.
2012-05-18 Anders Carlsson <andersca@apple.com>
Missing plugin msg becomes "insecure plugin version" after Real Player page refresh
https://bugs.webkit.org/show_bug.cgi?id=86903
<rdar://problem/11477163>
Reviewed by Andreas Kling.
Set blocked to false before returning early when the plug-in doesn't exist.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::getPluginPath):
Tools: Merge r116716.
2012-05-10 Anders Carlsson <andersca@apple.com>
WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86164
<rdar://problem/9551196>
Reviewed by Sam Weinig.
Update for WK2 API changes.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
WebKitLibraries: Merge r116695.
2012-05-10 Anders Carlsson <andersca@apple.com>
WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86150
<rdar://problem/9551196>
Reviewed by Sam Weinig.
Add WKShouldBlockPlugin.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 9:41 AM Changeset in webkit [129236] by
-
- 2 edits in trunk/Source/WebCore
Fix build with ENABLE_WEBGL=false
https://bugs.webkit.org/show_bug.cgi?id=97309
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-21
Reviewed by Eric Seidel.
WebKit no longer builds when WEBGL is not enabled.
- rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
- 9:32 AM Changeset in webkit [129235] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Media player won't resize for the following source when first source fail to load
https://bugs.webkit.org/show_bug.cgi?id=97342
Patch by Jonathan Dong <Jonathan Dong> on 2012-09-21
Reviewed by Yong Li.
As platformPlayer will notify MediaPlayerPrivate for size change
when loading metadata failed (in this case hasVideo() is false),
we should prevent MediaPlayerPrivate to set width and height
attribute of media element, otherwise we won't get the correct
dimension for the following media sources.
Internally reviewed by Max Feil.
Test case: media/video-size.html
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
- 9:26 AM Changeset in webkit [129234] by
-
- 6 edits1 add in trunk/LayoutTests
[Qt] REGRESSION: 5 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90687
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.
When sending null data via POST method in XMLHttpRequest the
expected Content-Type "application/x-www-form-urlencoded",
instead of "application/octet-stream". In fact that was the previously
expected value for Qt, but was changed to conform to Qt 4.8 results.
The cookie test result was updated to follow RFC 6265 behavior, as
already does chromium, gtk, and efl.
- platform/qt-5.0/Skipped:
- platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/methods-expected.txt:
- platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
- platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt:
- platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:
- 9:21 AM Changeset in webkit [129233] by
-
- 3 edits2 adds in trunk
REGRESSION (r126763): Incorrect line breaking when both kerning and word spacing are enabled
https://bugs.webkit.org/show_bug.cgi?id=97280
Reviewed by Adele Peterson.
Source/WebCore:
Font::width() never applies word spacing to the first character in the TextRun. The
TextLayout optimization tried to achieve this behavior by not applying word spacing to
any character, which led to this bug.
Test: fast/text/word-space-with-kerning-2.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::TextLayout::TextLayout): Changed to use the given font rather than a version
without word spacing.
(WebCore::TextLayout::width): Added a check if the run starts with a space at a non-zero
offset. If that is the case, then the ComplexTextController has added word spacing to that
space, so subtract it here in order to maintain the behavior described above.
LayoutTests:
- fast/text/word-space-with-kerning-2-expected.html: Added.
- fast/text/word-space-with-kerning-2.html: Added.
- 9:14 AM Changeset in webkit [129232] by
-
- 2 edits in trunk/Tools
[WTR] Memory leaks in InjectedBundleController::initialize()
https://bugs.webkit.org/show_bug.cgi?id=97329
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.
Fix leaks in InjectedBundleController::initialize() by adopting
strings created with WKStringCreateWithUTF8CString().
- TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):
- 9:11 AM Changeset in webkit [129231] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
https://bugs.webkit.org/show_bug.cgi?id=97235
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):
- 8:37 AM Changeset in webkit [129230] by
-
- 3 edits in trunk/LayoutTests
[EFL] Skip flaky tests to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=97340
Unreviewed EFL gardening. Skip flaky tests
in order to make the bots green.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 8:33 AM Changeset in webkit [129229] by
-
- 2 edits in trunk/Tools
Add MIPS build slave to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=96713
Patch by Gergely Kis <Gergely Kis> on 2012-09-21
Reviewed by Csaba Osztrogonác.
Added a build slave for MIPS, and enabled a builder for
Qt Linux MIPS32R2 little-endian release build.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 7:59 AM Changeset in webkit [129228] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Wrong seperator for viewport meta in Popup scripts
https://bugs.webkit.org/show_bug.cgi?id=97313
Reviewed by Yong Li.
The valid seperator for viewport meta is ',' instead of ';'.
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::generateHTML):
- 7:32 AM Changeset in webkit [129227] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r129219.
http://trac.webkit.org/changeset/129219
https://bugs.webkit.org/show_bug.cgi?id=97338
Presumably broke Apple Mac compilation (Requested by yurys_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorCanvasInstrumentation.h:
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- 7:25 AM Changeset in webkit [129226] by
-
- 3 edits in trunk/Tools
[Chromium] Switch back to a fixed fifo path for Android
https://bugs.webkit.org/show_bug.cgi?id=97230
Reviewed by Tony Chang.
Because not all external storage cards will be formated using a file
system that supports named pipes, Chromium has been changed to creating
the pipes in a temporary folder on the internal storage. Adapt this in
WebKit so we can continue to run layout tests.
This also includes an *unreviewed* fix for a breakage in the webkitpy
tests I made in r129221. Two lines and related to this code, so I decided
to include it in this change.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._update_version):
- 7:11 AM Changeset in webkit [129225] by
-
- 4 edits5 adds in trunk/Source
[chromium] Add test for ScrollingCoordinatorChromium
https://bugs.webkit.org/show_bug.cgi?id=96657
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-21
Reviewed by James Robinson.
Add tests for ScrollingCoordinatorChromium. These tests mainly verify that
fast (non-main thread) scrolling is enabled when necessary and that a proper
compositing layer structure is created for fixed position and accelerated
scrolling layers.
Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault
ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
ScrollingCoordinatorChromiumTest.nonFastScrollableRegion
ScrollingCoordinatorChromiumTest.wheelEventHandler
ScrollingCoordinatorChromiumTest.touchOverflowScrolling
- WebKit.gypi:
- tests/ScrollingCoordinatorChromiumTest.cpp: Added.
(WebKit):
(MockWebViewClient):
(ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl):
(WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad):
(WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer):
(WebKit::TEST_F):
- tests/data/fixed_position.html: Added.
- tests/data/non_fast_scrollable.html: Added.
- tests/data/touch_overflow_scrolling.html: Added.
- tests/data/wheel_event_handler.html: Added.
- 7:05 AM Changeset in webkit [129224] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip a test because layoutTestController.setBackingScaleFactor() is missing
on Qt. This test timeouts at the moment, which considerably increase the testing time.
- platform/qt/Skipped:
- 6:51 AM Changeset in webkit [129223] by
-
- 6 edits in trunk/Source/WebKit2
[GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97330
Reviewed by Xan Lopez.
WebKitWebView:is-loading property allows to monitor when the view
is loading something without having to deal with load-changed
signal and all the details of the load status. This also allows to
know when a new load is started before it goes to STARTED status.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): Implement getter for is-loading
property.
(webkit_web_view_class_init): Add is-loading property.
(webkitWebViewSetIsLoading): Set whether web view is loading a
page and emit notify signal if the is-loading property has
changed. Also update the active URI when a new load operation has
started.
(webkitWebViewEmitLoadChanged): Set is-loading to FALSE when load
finishes.
(webkitWebViewLoadFailed): Set is-loading to FALSE when load fails.
(webkit_web_view_load_uri): Set is-loading to TRUE.
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_is_loading): Return whether the view is loading a
page.
(webkit_web_view_go_back): Set is-loading to TRUE.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(loadChangedCallback):
(loadFailedCallback):
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebViewIsLoading):
(beforeAll):
- 6:38 AM Changeset in webkit [129222] by
-
- 11 edits2 deletes in trunk/Source/WebKit
[BlackBerry] Remove obsolete compositing surface code
https://bugs.webkit.org/show_bug.cgi?id=97314
Reviewed by Antonio Gomes.
Source/WebKit:
Remove compositing surface code from build system.
PR 208038.
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
The removed code allowed rendering of sublayers to a separate offscreen
surface.
Now that we composite root layer and all sublayers to the window
surface, this code is not needed anymore. In addition, we save some
memory by not allocating the unused offscreen surface.
PR 208038.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
- WebKitSupport/BackingStoreCompositingSurface.h: Removed.
- WebKitSupport/GLES2Context.cpp:
(BlackBerry::WebKit::GLES2Context::buffer):
(BlackBerry::WebKit::GLES2Context::surfaceSize):
(BlackBerry::WebKit::GLES2Context::swapBuffers):
- WebKitSupport/GLES2Context.h:
(GLES2Context):
- WebKitSupport/SurfacePool.cpp:
(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
- WebKitSupport/SurfacePool.h:
(SurfacePool):
- 6:36 AM Changeset in webkit [129221] by
-
- 8 edits2 deletes in trunk
Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
https://bugs.webkit.org/show_bug.cgi?id=97227
Reviewed by Tony Chang.
Source/WebKit/chromium:
Remove all fifo-related code together with the io_stream_forwarder_android
target defined in WebKitUnitTests.gyp.
- WebKitUnitTests.gyp:
- tests/ForwardIOStreamsAndroid.cpp: Removed.
- tests/ForwardIOStreamsAndroid.h: Removed.
- tests/RunAllTests.cpp:
(main):
Tools:
We switched Chromium to using FIFOs in order to achieve better consistency,
which was done by Marcus in r157541. Remove all custom WebKit code in
favor of Chromium's implementation.
Remove more FIFO code in the test runner itself, including the code in
DumpRenderTree that invoked it. We can now switch to Chromium's brand
new FIFO-creating code, which is being set-up for all test targets build
for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
This also changes the ChromiumAndroidDriver._remove_all_pipes method to
delete the files individually. "rm" would fail if one of the earlier files
does not exist, and the "-f" argument doesn't seem to be reliable.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._get_external_storage):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver.stop):
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 6:16 AM Changeset in webkit [129220] by
-
- 10 edits in trunk
[WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
https://bugs.webkit.org/show_bug.cgi?id=97326
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Tools:
Implement scheduleAsynchronousClick() in WebKitTestRunner's
EventSender by sending a "MouseDown" and a "MouseUp" message
asynchronously to the WebProcess.
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::createMouseMessageBody):
(WTR):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::scheduleAsynchronousClick):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
LayoutTests:
Unskip fast/events/popup-blocking-click-in-iframe.html for
WebKit2 now that WKTR's EventSender implements
scheduleAsynchronousClick.
- platform/efl-wk2/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/mac-wk2/Skipped:
- platform/qt-5.0-wk2/Skipped:
- 5:52 AM Changeset in webkit [129219] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
https://bugs.webkit.org/show_bug.cgi?id=97203
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-21
Reviewed by Yury Semikhatsky.
Implements wrapping a 2D canvas context through the injected canvas module script facility.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
- inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
- inspector/InspectorCanvasInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- 5:49 AM Changeset in webkit [129218] by
-
- 10 edits in trunk
Web Inspector: [refactoring] simplify interface to FileOutputStream
https://bugs.webkit.org/show_bug.cgi?id=97226
Reviewed by Yury Semikhatsky.
Source/WebCore:
- change OutputStream interface to match that of stream;
- fix OutputStream implementations (FileOutputStream and those in heap profiler);
- fix usages in Timeline and HeapProfiler.
- inspector/front-end/FileUtils.js:
(WebInspector.OutputStream.prototype.write):
(WebInspector.OutputStream.prototype.close):
(WebInspector.ChunkedFileReader.prototype.start):
(WebInspector.ChunkedFileReader.prototype._onChunkLoaded):
(WebInspector.ChunkedXHRReader.prototype.start):
(WebInspector.ChunkedXHRReader.prototype._onProgress):
(WebInspector.ChunkedXHRReader.prototype._onLoad):
(WebInspector.FileOutputStream):
(WebInspector.FileOutputStream.prototype.open.callbackWrapper):
(WebInspector.FileOutputStream.prototype.open):
(WebInspector.FileOutputStream.prototype.write):
(WebInspector.FileOutputStream.prototype.close):
(WebInspector.FileOutputStream.prototype._onAppendDone):
- inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.close):
(WebInspector.HeapSnapshotLoader.prototype.write):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotLoaderProxy.prototype.startTransfer):
(WebInspector.HeapSnapshotLoaderProxy.prototype.write):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype.transferChunk.callback):
(WebInspector.HeapProfileHeader.prototype.transferChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype._createFileWriter):
(WebInspector.TimelineModel.prototype.saveToFile.callback):
(WebInspector.TimelineModel.prototype.saveToFile):
(WebInspector.TimelineModelLoader):
(WebInspector.TimelineModelLoader.prototype.write):
(WebInspector.TimelineModelLoader.prototype.close):
(WebInspector.TimelineSaver):
(WebInspector.TimelineSaver.prototype.save):
(WebInspector.TimelineSaver.prototype._writeNextChunk):
LayoutTests:
- adjust tests to new FileOutputStream interface;
- inspector/profiler/heap-snapshot-loader.html:
- inspector/timeline/timeline-load.html:
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.StringOutputStream):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.write):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.close):
(initialize_Timeline):
- 5:49 AM Changeset in webkit [129217] by
-
- 4 edits in trunk
[Qt] Error out early if we don't have ICU available
Reviewed by Tor Arne Vestbø.
Source/WTF:
- WTF.pri:
Tools:
- qmake/mkspecs/features/configure.prf:
- 5:16 AM Changeset in webkit [129216] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 5:08 AM Changeset in webkit [129215] by
-
- 10 edits2 adds in trunk
-webkit-clip-path is applied on elements that are not descendant of the container
https://bugs.webkit.org/show_bug.cgi?id=97217
Reviewed by Dirk Schulze.
Source/WebCore:
The clip-path was set on the GraphicsContext, but was never restored, thus making all the layers
rendered in the same "group" of save/restore state use the same clip-path.
Test: css3/masking/clip-path-restore.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
clip-path property should create a stacking-context, otherwise the RenderLayers will not be nested,
meaning that the clip-path of the parent is not going to apply correctly.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
Added a test to check that the clip-path is removed from the GraphicsContext in the second paint call.
clip-path-circle-relative-overflow had incorrect result before, so I've udpated the results on Mac
and added test expectations for the others.
- css3/masking/clip-path-restore-expected.html: Added.
- css3/masking/clip-path-restore.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/qt/TestExpectations:
- platform/win/Skipped:
- 5:05 AM Changeset in webkit [129214] by
-
- 4 edits in trunk
[Qt] Bail out when trying to build WebKit with Qt != 5
Reviewed by Tor Arne Vestbø.
Moved check for Qt version out of default_pre into top-level WebKit.pro,
because we never reach default_pre.prf due to the lack of .qmake.conf support
in older versions of Qt/QMake.
.:
- WebKit.pro:
Tools:
- qmake/mkspecs/features/default_pre.prf:
- 5:00 AM Changeset in webkit [129213] by
-
- 6 edits in trunk
WebKitTestRunner needs to print frame load delegate information
https://bugs.webkit.org/show_bug.cgi?id=42705
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Tools:
Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
LayoutTests:
Unskipped corresponding test cases from wk2/Skipped, put those which still fail to an appropriate
group in wk2/Skipped.
Moved couple of http/tests/loading tests from platform/efl-wk1/TestExpectations to
platform/efl/TestExpectations as they actually fail for both WK1 EFL and WK2 EFL.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- platform/wk2/Skipped:
- 4:35 AM Changeset in webkit [129212] by
-
- 9 edits in trunk
[EFL] EventSender should mimic CTRL+o emacs shortcut
https://bugs.webkit.org/show_bug.cgi?id=97224
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit/efl:
Fix bad use of temporary object causing wrong editing
callback dumping.
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::shouldInsertText):
Tools:
Add support for mimicking CTRL+o emacs shortcut in EFL's
EventSender in DumpRenderTree and WebKitTestRunner.
- DumpRenderTree/efl/EventSender.cpp:
(sendKeyDown):
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::keyDown):
LayoutTests:
Rebaseline editing/input/emacs-ctrl-o.html test now
that EFL's EventSender supports mimicking CTRL+o
emacs keyboard shortcut and unskip the test for
EFL WK2 now that the output matches the one for
EFL WK1.
- platform/efl-wk2/TestExpectations:
- platform/efl/editing/input/emacs-ctrl-o-expected.png:
- platform/efl/editing/input/emacs-ctrl-o-expected.txt:
- 3:43 AM BadContent edited by
- add one more spammer (diff)
- 3:31 AM Changeset in webkit [129211] by
-
- 4 edits in trunk/LayoutTests
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=97317
Unreviewed EFL gardening.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
- platform/efl/TestExpectations:
- platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
- platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:
- 3:23 AM Changeset in webkit [129210] by
-
- 3 edits in trunk/Tools
[Qt] Re-fix clean builds
Reviewed by Tor Arne Vestbø.
Re-introduce the sanitization for LIBS when creating a module to use
LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
causes build issues when depending system libraries end up in LIBS before
LIBS_PRIVATE.
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/functions.prf:
- 3:17 AM Changeset in webkit [129209] by
-
- 3 edits24 adds in trunk/LayoutTests
[EFL] Move frame flattening tests to WK1 specific TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97315
Unreviewed EFL gardening.
Generate baselines for frame flattening tests using WK2 since the tests
are passing with it, and move the tests to WebKit1-specific
TestExpectations.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
- platform/efl-wk1/TestExpectations:
- platform/efl/Skipped:
- platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
- 3:13 AM Changeset in webkit [129208] by
-
- 6 edits in trunk/Source/WebCore
Remove unused functions of LocalizedDate.h
https://bugs.webkit.org/show_bug.cgi?id=97311
Reviewed by Kentaro Hara.
WebCore::localizedTimeFormatText, WebCore::localizedShortTimeFormatText,
and WebCore::timeAMPMLabels are not used any more because we switched to
the corresponding functions of Localizer.
No new tests because of no behavior changes.
- platform/text/Localizer.h:
(Localizer): Moved comments from LocalizedDate.h.
- platform/text/LocalizedDate.h:
(WebCore): Removed localizedTimeFormatText,
localizedShortTimeFormatText, and timeAMPMLabels.
- platform/text/LocalizedDateICU.cpp:
(WebCore): ditto.
- platform/text/LocalizedDateWin.cpp:
(WebCore): ditto.
- platform/text/mac/LocalizedDateMac.cpp:
(WebCore): ditto.
- 3:08 AM Changeset in webkit [129207] by
-
- 5 edits in trunk/Source
Add datalist suggestions into DateTimeChooserParameters
https://bugs.webkit.org/show_bug.cgi?id=97292
Reviewed by Kent Tamura.
Source/WebCore:
We read datalist suggestions, add them to DateTimeChooserParameters,
and pass them to the page popup.
No new tests. No behavior change yet.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): Read datalist suggestions and add them to DateTimeChooserParameters
- platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added localizedSuggestionValues so we can show localized values inside the page popup.
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker.
- 3:06 AM Changeset in webkit [129206] by
-
- 4 edits in trunk/Source/WebCore
[Forms] DateTimeEditElement::layout() should take date time format as a parameter
https://bugs.webkit.org/show_bug.cgi?id=97300
Reviewed by Kent Tamura.
This patch introduces DateTimeEditElement::LayoutParameters struct for
passing four parameters to DateTimeEditElement::layout() for passing
date time format from client of DateTimeEditElement instead of
DateTimeEditElement::layout() takes time or short time format.
This patch is a part of preparation of introducing multiple fields
date/datetime/month/week input UI.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. This patch doesn't change behavior.
- html/TimeInputType.cpp:
(WebCore::TimeInputType::updateInnerTextValue): Changed to use LayoutParmeters.
- html/shadow/DateTimeEditElement.cpp: Removed unused include files, LocalizedDate.h and LocalizedNumber.h.
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed parameters to LayoutParmeters.
(WebCore::DateTimeEditElement::LayoutParameters::shouldHaveSecondField): Moved from DateTimeEditBuilder::needSecondField().
(WebCore::DateTimeEditElement::layout): Changed to take LayoutParameters.
(WebCore::DateTimeEditElement::setValueAsDate): ditto
(WebCore::DateTimeEditElement::setEmptyValue): ditto
- html/shadow/DateTimeEditElement.h: Removed unused classe declarations DateComponents and DateTimeEditLayouter.
(LayoutParameters): Added to bundle parameters for layout().
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Added.
- 2:44 AM Changeset in webkit [129205] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: render grid scale to the right / at bottom in case box is close to 0 on that axis.
https://bugs.webkit.org/show_bug.cgi?id=97219
Reviewed by Vsevolod Vlasov.
Otherwise, it is hard to inspect objects close to (0, 0)
- inspector/InspectorOverlayPage.html:
- 2:22 AM Changeset in webkit [129204] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r129086.
http://trac.webkit.org/changeset/129086
https://bugs.webkit.org/show_bug.cgi?id=97312
Broke input rendering (Requested by shinyak on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21
- html/BaseButtonInputType.cpp:
(WebCore):
- html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType):
(BaseButtonInputType):
- html/FileInputType.cpp:
(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/InputType.cpp:
- html/InputType.h:
(InputType):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::updateFromElement):
(WebCore):
(WebCore::RenderButton::setText):
(WebCore::RenderButton::text):
- rendering/RenderButton.h:
(RenderButton):
- 2:16 AM Changeset in webkit [129203] by
-
- 2 edits in trunk/Source/WebCore
Remove useless class prototypes from Vibration.h
https://bugs.webkit.org/show_bug.cgi?id=97304
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-21
Reviewed by Kentaro Hara.
Remove two useless class prototype statements in the Vibration.h
- Modules/vibration/Vibration.h:
- 1:01 AM Changeset in webkit [129202] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Changed fast/text/international/hebrew-selection.html expectation
from Failure to ImageOnlyFailure to match the actual results.
- platform/chromium/TestExpectations:
- 12:58 AM Changeset in webkit [129201] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add MIPS or32 function
https://bugs.webkit.org/show_bug.cgi?id=97157
Patch by Chao-ying Fu <fu@mips.com> on 2012-09-21
Reviewed by Gavin Barraclough.
Add a missing or32 function.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32): New function.
(MacroAssemblerMIPS):
- 12:45 AM Changeset in webkit [129200] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark accessibility/loading-iframe-updates-axtree.html as crashing
intermittently on Linux in addition to Win and Mac.
- platform/chromium/TestExpectations:
- 12:31 AM Changeset in webkit [129199] by
-
- 39 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining MathML tests after r129146.
- platform/gtk/mathml/presentation/attributes-expected.png:
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.png:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.png:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.png:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
- platform/gtk/mathml/presentation/over-expected.png:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.png:
- platform/gtk/mathml/presentation/roots-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.png:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.png:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/sub-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/sup-expected.png:
- platform/gtk/mathml/presentation/sup-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.png:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/under-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.png:
- platform/gtk/mathml/presentation/underover-expected.txt:
- platform/gtk/mathml/xHeight-expected.png:
- platform/gtk/mathml/xHeight-expected.txt:
- 12:02 AM Changeset in webkit [129198] by
-
- 4 edits in trunk/Source/WebCore
Prepare CalendarPicker so we can add another picker, SuggetionPicker
https://bugs.webkit.org/show_bug.cgi?id=97193
Reviewed by Kent Tamura.
Preparation so we can add another picker to CalendarPicker and switch
between them.
No new tests. No behavior change.
- Resources/pagepopups/calendarPicker.css:
(.calendar-picker): Added so we can apply these styles just to calendar picker.
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.validateConfig): Renamed so each picker can validate the config object.
(initialize):
(closePicker): Call Picker.cleanup().
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype.cleanup): Cleanup event listener on document.body.
- Resources/pagepopups/pickerCommon.js:
(Picker.prototype.cleanup):
