Timeline
Sep 23, 2012:
- 11:28 PM Changeset in webkit [129328] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Duplicated RenderThemeEfl creation for same page
https://bugs.webkit.org/show_bug.cgi?id=88391
Reviewed by Gyuyoung Kim.
Other ports return one or two RenderTheme regardless of page.
But, WebKit/Efl can create different theme for each page and
themeForPage creates new RenderTheme whenever it is called with page.
So more than one RenderTheme can be created for a page.
This patches checks whether page already has RenderTheme not to create new
RenderTheme for same page.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderTheme::themeForPage):
- 11:27 PM Changeset in webkit [129327] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Add setting to toggle developer extensions
https://bugs.webkit.org/show_bug.cgi?id=96974
Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-09-23
Reviewed by Kenneth Rohde Christiansen.
This is required to allow the user to inspect pages. (Web inspector)
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- 9:39 PM Changeset in webkit [129326] by
-
- 8 edits2 adds in trunk
Add suggestionPicker to CalendarPicker
https://bugs.webkit.org/show_bug.cgi?id=97201
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Added tests for SuggestionPicker.
Source/WebCore:
This adds the suggestionPicker to CalendarPicker. It is not available yet as a datalist UI but it can be used inside ManualTests/forms/calendar-picker.html.
No new tests. Suggestion Picker can be tested in ManualTests/forms/calendar-picker.html.
- Resources/pagepopups/calendarPicker.js:
(initialize):
(openSuggestionPicker):
- Resources/pagepopups/pickerCommon.js:
(enclosingNodeOrSelfWithClass):
- Resources/pagepopups/suggestionPicker.css: Added.
(.suggestion-list):
(.suggestion-list-entry):
(.suggestion-list-entry:focus):
(.suggestion-list-entry:focus .label):
(.suggestion-list-entry .content):
(.suggestion-list-entry .title):
(.suggestion-list-entry .label):
(.measuring-width .suggestion-list-entry .label):
(.suggestion-list .separator):
- Resources/pagepopups/suggestionPicker.js: Added.
(SuggestionPicker):
(SuggestionPicker.validateConfig):
(SuggestionPicker.prototype.cleanup):
(SuggestionPicker.prototype._setColors): Creates css rules that sets highlight colors.
(SuggestionPicker.prototype._createSuggestionEntryElement): Creates an entry that when selected submits the value.
(SuggestionPicker.prototype._createActionEntryElement): Creates an entry that causes an action. (e.x. "Other...")
(SuggestionPicker.prototype._measureMaxContentWidth): Temporarily left align everything to measure the width.
(SuggestionPicker.prototype._fixWindowSize):
(SuggestionPicker.prototype._layout):
(SuggestionPicker.prototype.selectEntry):
(SuggestionPicker.prototype._handleEntryClick):
(SuggestionPicker.prototype._findFirstVisibleEntry):
(SuggestionPicker.prototype._findLastVisibleEntry):
(SuggestionPicker.prototype._handleBodyKeyDown):
(SuggestionPicker.prototype._handleEntryMouseOver):
(SuggestionPicker.prototype._handleMouseOut):
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args.
- 8:47 PM Changeset in webkit [129325] by
-
- 2 edits in trunk/Source/JavaScriptCore
PutScopedVar should not be marked as clobbering the world
https://bugs.webkit.org/show_bug.cgi?id=97416
Reviewed by Filip Pizlo.
No performance change.
PutScopedVar doesn't have arbitrary side-effects, so it shouldn't be marked
as such.
- dfg/DFGNodeType.h:
(DFG):
- 8:35 PM Changeset in webkit [129324] by
-
- 2 edits in trunk/Source/JavaScriptCore
2012-09-23 Geoffrey Garen <ggaren@apple.com>
I accidentally the whole 32-bit :(.
Unbreak the DFG in 32-bit with the 32-bit path I forgot in my last patch.
- dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
- 8:33 PM Changeset in webkit [129323] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r128239): Mutable ElementAttributeData leak their Attribute vectors.
<http://webkit.org/b/97423>
Reviewed by Anders Carlsson.
r128239 added a WTF::deleteOwnedPtr() override for ElementAttributeData*, but ElementAttributeData is
a ref-counted object. Fixed this by overriding deref() instead to call the appropriate subclass destructor.
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::deref):
- 8:28 PM Changeset in webkit [129322] by
-
- 3 edits2 copies in branches/chromium/1271
Merge 129106 - REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
https://bugs.webkit.org/show_bug.cgi?id=97166
Reviewed by Kent Tamura.
Source/WebCore:
Fixing bug in r127727 so arrow keys work properly.
Test: fast/forms/date/calendar-picker-key-operations.html
- Resources/pagepopups/calendarPicker.js:
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
LayoutTests:
- fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
- fast/forms/date/calendar-picker-key-operations.html: Added.
TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/10968055
- 7:29 PM Changeset in webkit [129321] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/html/TimeInputType.cpp
Merge 129095 - [Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
https://bugs.webkit.org/show_bug.cgi?id=97169
Reviewed by Kent Tamura.
This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.
- html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):
TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/10957058
- 6:16 PM Changeset in webkit [129320] by
-
- 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebFrameImpl.cpp
Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=96352
Reviewed by Adam Barth.
We have some crash reports with the following stack:
- HistoryItem::shouldDoSameDocumentNavigationTo.
- WebFrameImpl::loadHistoryItem ...
We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.
TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/10959062
- 6:02 PM Changeset in webkit [129319] by
-
- 20 edits in trunk/Source
Fix build warnings : -Wunused-parameter, -Wparentheses, -Wuninitialized.
https://bugs.webkit.org/show_bug.cgi?id=97306
Patch by Byungwoo Lee <bw80.lee@gmail.com> on 2012-09-23
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Fix build warning about -Wunused-parameter on MachineStackMarker.cpp,
LLIntSlowPaths.cpp, DatePrototype.cpp, Options.cpp by using
UNUSED_PARAM() macro or remove parameter name.
- heap/MachineStackMarker.cpp:
(JSC::pthreadSignalHandlerSuspendResume):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::entryOSR):
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- runtime/Options.cpp:
(JSC::computeNumberOfGCMarkers):
Source/WebCore:
Fix build warning about -Wunused-parameter on ImageBufferCairo.cpp,
ImageDecoder.h by using ASSERT_UNUSED() macro.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::encodeImage):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::rgbColorProfile):
(WebCore::ImageDecoder::inputDeviceColorProfile):
Source/WebKit/efl:
Fix build warning about -Wunused-parameter on FrameLoaderClientEfl.cpp
by using ASSERT_UNUSED() macro.
Fix build warning aboug -Wparentheses on ewk_frame.cpp by adding
additional brace for the assign statement.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
- ewk/ewk_frame.cpp:
(ewk_frame_resources_location_get):
Source/WebKit2:
Fix build warning about -Wunused-parameter on Connection.cpp,
WKEinaSharedString.cpp, ewk_view_loader_client.cpp, WebPage.cpp by
using ASSERT_UNUSED() macro or removing parameter name.
Fix build warning about -Wuninitialized on WebEventFactory.cpp by
continueing the loop at the default switch case not to use the
uninitialized variable.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::waitForSyncReply):
- Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):
- UIProcess/API/cpp/efl/WKEinaSharedString.cpp:
(WKEinaSharedString::WKEinaSharedString):
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didSameDocumentNavigationForFrame):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Source/WTF:
Fix build warning about -Wunused-parameter on FastMalloc.cpp,
OSAllocatorPosix.cpp by using UNUSED_PARAM() macro.
Fix header including order of FastMalloc.cpp.
- wtf/FastMalloc.cpp:
(WTF::fastMallocSize):
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
- 5:57 PM Changeset in webkit [129318] by
-
- 4 edits in trunk/Source/WebCore
Enable ElementAttributeData sharing for non-HTML elements.
<http://webkit.org/b/97413>
Reviewed by Anders Carlsson.
Use the whole qualified tag name when creating the ElementAttributeData cache key
instead of just the localName(). This allows sharing and caching of attribute data
for non-HTML elements and makes the code a little cleaner.
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
Enable the ElementAttributeData sharing path for non-HTML elements.
- dom/ElementAttributeData.h:
Make immutableAttributeArray() public so Document can call it instead of getting
the raw data address from a const_cast'ed attributeItem(0).
- dom/Document.cpp:
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheEntry::ImmutableAttributeDataCacheEntry):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):
Let the immutable attribute data cache use a QualifiedName/attributes key
instead of the AtomicString/attributes we were using before. We still grab the
existingHash() from the QualifiedName::localName() and use that for the actual
HashMap key.
- 4:37 PM Changeset in webkit [129317] by
-
- 3 edits3 adds in trunk
Sorting a non-array creates propreties (spec-violation)
https://bugs.webkit.org/show_bug.cgi?id=25477
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
We're just calling get() to get properties, which is converting missing properties to
undefined. Hole values should be retained, and moved to the end of the array.
- runtime/ArrayPrototype.cpp:
(JSC::getOrHole):
- Helper function, returns JSValue() instead of undefined for missing properties.
(JSC::arrayProtoFuncSort):
- Implemented per 15.4.4.11, see comments above.
LayoutTests:
Added test cases.
- fast/js/array-sort-sparse-expected.txt: Added.
- fast/js/array-sort-sparse.html: Added.
- fast/js/script-tests/array-sort-sparse.js: Added.
(testSort):
- 3:48 PM Changeset in webkit [129316] by
-
- 9 edits in trunk/Source/JavaScriptCore
CSE for access to closure variables (get_/put_scoped_var)
https://bugs.webkit.org/show_bug.cgi?id=97414
Reviewed by Oliver Hunt.
I separated loading a scope from loading its storage pointer, so we can
CSE the storage pointer load. Then, I copied the global var CSE and adjusted
it for closure vars.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute): Renamed GetScopeChain => GetScope to
reflect renames from a few weeks ago.
Added a case for the storage pointer load, similar to object storage pointer load.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): Added an independent node for
the storage pointer.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getScopeLoadElimination):
(JSC::DFG::CSEPhase::getScopeRegistersLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE): Copied globalVarLoad/StoreElimination
and adapted the same logic to closure vars.
- dfg/DFGNode.h:
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scope):
(Node):
- dfg/DFGNodeType.h:
(DFG): GetScopedVar and GetGlobalVar are no longer MustGenerate. I'm not
sure why they ever were. But these are simple load operations so, if they're
unused, they're truly dead.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Updated for renames and split-out
node for getting the storage pointer.
- 10:37 AM Changeset in webkit [129315] by
-
- 3 edits in trunk/Source/WebCore
Measure the usage of the "X-WebKit-CSP" header in the hopes of dropping the prefix completely.
https://bugs.webkit.org/show_bug.cgi?id=97408
Patch by Mike West <mkwst@chromium.org> on 2012-09-23
Reviewed by Adam Barth.
We plan on landing the unprefixed header in webkit.org/b/96765 once the
spec moves to CR. Though we plan to use it for experimentation in the
near future, we'll want to drop the prefixed header completely at some
point in the future. Starting to measure its usage now will give us a
good baseline when we start contemplating that decision.
No new functionality, so no new tests.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
- page/FeatureObserver.h:
Sep 22, 2012:
- 11:56 PM Changeset in webkit [129314] by
-
- 3 edits in trunk/Source/WTF
Add explicit conversion operator to RetainPtr for easier use in C++11 environments
https://bugs.webkit.org/show_bug.cgi?id=97403
Reviewed by Dan Bernstein.
- wtf/Compiler.h:
Add support for COMPILER_SUPPORTS(CXX_EXPLICIT_CONVERSIONS)
- wtf/RetainPtr.h:
(RetainPtr):
(WTF::RetainPtr::get):
(WTF::RetainPtr::operator PtrType):
Add the explicit conversion operator and group all the underlying
pointer accessors together.
- 11:31 PM Changeset in webkit [129313] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a failure expectation for http/tests/loading/redirect-with-no-location-crash.html,
the test started failing on the WebKit2 builder after it was unskipped in r129213.
- platform/gtk-wk2/TestExpectations:
- 6:03 PM MinimalFileStorage edited by
- (diff)
- 5:56 PM MinimalFileStorage edited by
- (diff)
- 5:53 PM MinimalFileStorage edited by
- (diff)
- 5:52 PM MinimalFileStorage edited by
- (diff)
- 5:50 PM MinimalFileStorage edited by
- (diff)
- 5:49 PM MinimalFileStorage edited by
- (diff)
- 5:47 PM MinimalFileStorage edited by
- (diff)
- 5:46 PM MinimalFileStorage edited by
- (diff)
- 5:45 PM MinimalFileStorage created by
- 5:29 PM Changeset in webkit [129312] by
-
- 4 edits in trunk/Source/WebKit2
Install WebProcess XPC services into the right places
https://bugs.webkit.org/show_bug.cgi?id=97385
Reviewed by Anders Carlsson.
- Configurations/WebProcessService.xcconfig:
Update INSTALL_PATH to go into WebKit2.framework/Versions/A/XPCServices.
- Configurations/WebProcessServiceForWebKitDevelopment.xcconfig:
Since this config file is almost identical to WebProcessService.xcconfig,
just #include it and change the one thing that is different, the INFOPLIST_FILE
- WebKit2.xcodeproj/project.pbxproj:
Follow XPC procedure and copy the services into the right place, WebKit2.framework/Versions/A/XPCServices
in all builds except production builds where it is not necessary. Also add a symlink like everyone else
does.
- 5:19 PM Changeset in webkit [129311] by
-
- 4 copies1 add in releases/Apple/OS X Lion Update 10.7.5
Added a tag for the OS X Lion Update 10.7.5 release.
OS X Lion v10.7.5 includes JavaScriptCore-7534.57.3, WebCore-7534.57.7, WebKit-7534.57.7, and WebKit2-7534.57.7.
- 5:12 PM Changeset in webkit [129310] by
-
- 4 copies1 add in releases/Apple/Safari 6.0.1
Added a tag for the Safari 6.0.1 release.
Safari 6.0.1 includes JavaScriptCore-x536.26.7, WebCore-x536.26.14, WebKit-x536.26.14, and WebKit2-x536.26.14.
- 3:18 PM Changeset in webkit [129309] by
-
- 5 edits in trunk/Source/WebKit2
Allow setting a custom path to where the plug-in sandbox profiles are being kept
https://bugs.webkit.org/show_bug.cgi?id=97399
Reviewed by Anders Carlsson.
Add a new default to allow controlling where to look for plug-in sandbox profiles
called "PlugInSandboxProfileDirectoryPath".
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeSandbox):
Use the passed in sandboxProfileDirectoryPath instead of hard coding /usr/share/sandbox/.
(WebKit::PluginProcess::platformInitialize):
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Grab the sandboxProfileDirectoryPath from standardUserDefaults and pass it to
the plug-in.
- 9:17 AM Changeset in webkit [129308] by
-
- 21 edits4 copies in trunk
AX: Layout tests would be easier to write if AccessibilityController could find an element by id
https://bugs.webkit.org/show_bug.cgi?id=97301
Reviewed by Chris Fleizach.
Source/WebCore:
Add a method to get the DOM "id" attribute from an accessible object, only for layout tests.
Makes existing test more cross-platform:
Tests: accessibility/aria-hidden-with-elements.html
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Adds a new accessibleElementById method to AccessibilityController, to make it
easier to write cross-platform layout tests.
Implemented for Chromium and for Mac (DRT and WKTR).
- DumpRenderTree/AccessibilityController.cpp:
(getAccessibleElementByIdCallback):
(AccessibilityController::getJSClass):
- DumpRenderTree/AccessibilityController.h:
(AccessibilityController):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::findAccessibleElementByIdRecursive):
(AccessibilityController::getAccessibleElementById):
(AccessibilityController::accessibleElementByIdGetterCallback):
- DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
(AccessibilityController):
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::accessibleElementById):
- DumpRenderTree/mac/AccessibilityCommonMac.h: added
- DumpRenderTree/mac/AccessibilityCommonMac.mm: added
(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(AccessibilityController):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
- WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::findAccessibleObjectById):
(WTR):
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
LayoutTests:
Modifies an existing test to use the new accessibleElementById
method of AccessibilityController, enabling the test to pass on
both Mac and Chromium.
- accessibility/aria-hidden-with-elements.html:
- platform/chromium/TestExpectations:
- 5:10 AM Changeset in webkit [129307] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, unskip now passing tests.
- platform/qt/TestExpectations:
- 4:50 AM Changeset in webkit [129306] by
-
- 2 edits in trunk/LayoutTests
[EFL] Garden IETestCenter Bugs
https://bugs.webkit.org/show_bug.cgi?id=97392
Unreviewed EFL gardening.
Unskip a couple of IETestCenter bugs now that they pass.
- platform/efl/TestExpectations:
- 4:33 AM QtWebKitGardening edited by
- add more info to how to build QtWebKit section, fix the URL of the PPA (diff)
- 4:32 AM Changeset in webkit [129305] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build is broken with GLib Unicode backend
https://bugs.webkit.org/show_bug.cgi?id=97308.
Patch by Thierry Reding <thierry.reding@avionic-design.de> on 2012-09-22
Reviewed by Carlos Garcia Campos.
The TextBreakIteratorGtk implementation uses ubrk_close() to delete
the iterator. However that function is ICU specific and not declared
when using the GLib backend. Instead the iterator can simply be freed
using the delete operator.
This commit is based on work by Martin Schlemmer who posted a fix for
this here:
http://permalink.gmane.org/gmane.os.opendarwin.webkit.gtk/1210
No new tests.
- platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator):
Free iterator using delete instead of ubrk_close().
- 3:31 AM Changeset in webkit [129304] by
-
- 8 edits3 adds in trunk/LayoutTests
[CSSRegions]Add test for accelerating compositing of elements in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=97387
Reviewed by Dirk Schulze.
At this moment, accelerated compositing is disabled for elements inside a RenderFlowThread. This patch adds
a specific test in compositing/regions that is expected to fail until https://bugs.webkit.org/show_bug.cgi?id=84900
is fixed. The code for the new test is taken out of the existing fast/regions/webkit-flow-renderer-layer.html.
- compositing/regions/webkit-flow-renderer-layer-compositing-expected.html: Added.
- compositing/regions/webkit-flow-renderer-layer-compositing.html: Added.
- fast/regions/webkit-flow-renderer-layer-expected.html:
- fast/regions/webkit-flow-renderer-layer.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/Skipped:
- 1:10 AM Changeset in webkit [129303] by
-
- 5 edits in trunk/Tools
Unexpected reftest passes are only reported when pixel testing is enabled
https://bugs.webkit.org/show_bug.cgi?id=97242
Reviewed by Dirk Pranke.
LayoutTestRunner should know whether the finished test it's handling is
a reftest. This is necessary when updating result summary for reftests
when pixel testing is not enabled - in these circumstances an unexpectedly
passing reftest was not reported as such due to pixel testing then being
determined by searching for reftest failures in failures list, which were
not found in an empty failure list of a passing test. Now the TestResult
objects have a member variable indicating the test is a reftest whenever
that's the case.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner._update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests.test_update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.run):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.init):
- 1:00 AM Changeset in webkit [129302] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marking mathml/presentation/subsup.xhtml as flaky, the flakiness
being observable after r128837.
Adding image failure expectation for fast/text/word-space-with-kerning-2.html,
introduced in r129233.
- platform/gtk/TestExpectations:
- 12:26 AM Changeset in webkit [129301] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, unskip now passing tests.
- platform/qt-5.0-wk1/Skipped:
- platform/qt/Skipped:
- 12:01 AM Changeset in webkit [129300] by
-
- 1 edit2 moves in trunk/LayoutTests
[Qt] New fast/text/kerning-with-TextLayout.html fails
https://bugs.webkit.org/show_bug.cgi?id=97388
Moved this test into platform/mac, as it is not platform-independent, and TextLayout is currently
used only on OS X.
- fast/text/kerning-with-TextLayout-expected.html: Removed.
- fast/text/kerning-with-TextLayout.html: Removed.
- platform/mac/fast/text/kerning-with-TextLayout-expected.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout-expected.html.
- platform/mac/fast/text/kerning-with-TextLayout.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout.html.
- 12:00 AM Changeset in webkit [129299] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
