Timeline

Sep 24, 2012:

11:51 PM Changeset in webkit [129462] by commit-queue@webkit.org

• 24 edits
  8 adds in trunk

Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
​https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <​boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

• Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

• WebCore.exp.in:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

• loader/cache/CachedImage.cpp:
• loader/cache/CachedImage.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

• loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::stillNeedsLoad):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

• loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

• page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

• page/Settings.h:

(Settings):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

• testing/InternalSettings.h:

(Backup):
(InternalSettings):

• testing/InternalSettings.idl:

Source/WebKit2:

• win/WebKit2.def:

LayoutTests:

• fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
• fast/loader/display-image-unset-allows-cached-image-load.html: Added.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
• fast/loader/resources/image1.html: Added.
• fast/loader/resources/image2.html: Added.
• platform/chromium/permissionclient/image-permissions-expected.txt:
• platform/chromium/permissionclient/image-permissions.html:
• platform/chromium/permissionclient/resources/image.html:
• platform/wk2/Skipped:

11:48 PM Changeset in webkit [129461] by barraclough@apple.com

• 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=97530
Regression, freeze applied to numeric properties of non-array objects

Reviewed by Filip Pizlo.

Object.freeze has a fast implementation in JSObject, but this hasn't been updated to take into account numeric properties in butterflies.
For now, just fall back to the generic implementation if the object has numeric properties.

Source/JavaScriptCore:

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorFreeze):

• fallback if the object has a non-zero indexed property vector length.

LayoutTests:

• fast/js/preventExtensions-expected.txt:
• fast/js/script-tests/preventExtensions.js:
  • Added a test case for freezing an object with a numeric property.

11:32 PM Changeset in webkit [129460] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectation for http/tests/security/xss-eval.html as the
test started failing after r129456.

• platform/gtk/TestExpectations:

11:17 PM Changeset in webkit [129459] by zandobersek@gmail.com

• 12 edits in trunk

Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
​https://bugs.webkit.org/show_bug.cgi?id=97426

Reviewed by Ojan Vafai.

Tools:

The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
member which is a set containing either '!=', '==', both or none if the test represented
by the object is not a reftest.

When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
if the test is a reftest. The value of this key is a list of all the reftest types of this test.

The test failure interpretation method has been refactored, it now reports only
missing results of various formats and image diff percent in case of image or
reftest mismatch.

Unit tests have been modified accordingly.

• Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._update_summary_with_result):

• Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests.test_update_summary_with_result):

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures):
(summarize_results):

• Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures):

• Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.run):
(SingleTestRunner._run_reftest):

• Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init):

• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Report unexpectedly passing reftests as well. Test cases included.

• fast/harness/resources/results-test.js:
• fast/harness/results-expected.txt:
• fast/harness/results.html:

11:12 PM Changeset in webkit [129458] by barraclough@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Bug in numeric accessors on global environment
​https://bugs.webkit.org/show_bug.cgi?id=97526

Reviewed by Geoff Garen.

I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/
The sparsemap is failing to map back from the global object to the window shell.
A test case would need to resolve a numeric property name against the global environment.

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):

• Add missing toThisObject calls.

10:27 PM Changeset in webkit [129457] by fpizlo@apple.com

• 6 edits
  3 adds in trunk

SerializedScriptValue isn't aware of indexed storage, but should be
​https://bugs.webkit.org/show_bug.cgi?id=97515
<rdar://problem/12361874>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Export a method that WebCore now uses.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• runtime/JSObject.h:

(JSObject):

Source/WebCore:

New test: fast/js/post-message-numeric-property.html

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

LayoutTests:

• fast/js/post-message-numeric-property-expected.txt: Added.
• fast/js/post-message-numeric-property.html: Added.
• fast/js/script-tests/post-message-numeric-property.js: Added.

(window.onmessage):

9:52 PM Changeset in webkit [129456] by barraclough@apple.com

• 7 edits in trunk/Source

Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
​https://bugs.webkit.org/show_bug.cgi?id=97519

Reviewed by Geoff Garen.

../JavaScriptCore:

unwrappedGlobalObject() was only needed because globalObject() doesn't always return a helpful result -
specifically for WebCore's window shell the structure's globalObject is set to null. We can fix this by
simply keeping the structure up to date as the window navigates, obviating the need for this function.

The only other use of unwrappedObject() came from globalFuncEval(), and this can be trivially removed
by flipping the way we perform this globalObject check (which we may also be able to remove!) - instead
of getting the globalObject from the provided this value & comparing to the expected globalObject, we
can get the this value from the expected globalObject, and compare to that provided.

• runtime/JSGlobalObject.cpp:
  • Call globalObject() instead of unwrappedGlobalObject().
• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

• Changed to compare this object values, instead of globalObjects - this means we only need to be able to map globalObject -> this, and not vice versa.

• runtime/JSObject.cpp:

(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::createInheritorID):

• Call globalObject() instead of unwrappedGlobalObject().

• runtime/JSObject.h:

(JSObject):

• Removed unwrappedGlobalObject(), unwrappedObject().

../WebCore:

JSDOMWindowShell::setWindow should update the structure's globalObject.

• bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::setWindow):

• Update the JSDOMWindowShell's structure's globalObject when the window changes.

9:50 PM EFLWebKit edited by Laszlo Gombos

Baseline minimal required tool versions (diff)

9:40 PM Changeset in webkit [129455] by yosin@chromium.org

• 7 edits in trunk/Source/WebCore

[Forms] We should remove DateTimeEditElement::valueAsDouble()
​https://bugs.webkit.org/show_bug.cgi?id=97327

Reviewed by Kent Tamura.

This patch removes unused function DateTimeEditElement::valueAsDouble()
and related functions in DateTimeFieldElement.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

• html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
• html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.

(DateTimeEditElement):

• html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
• html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.

(DateTimeFieldElement):

• html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
• html/shadow/DateTimeFieldElements.h:

(DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

9:33 PM Changeset in webkit [129454] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

WKProcessGroup can't load injected bundle with file URL
<rdar://problem/12322774>
​https://bugs.webkit.org/show_bug.cgi?id=97520

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
Fix typo. We need to pass the string as path, not as a URL.

9:30 PM Changeset in webkit [129453] by mark.lam@apple.com

• 20 edits in trunk/Source

Deleting the classic interpreter and cleaning up some build options.
​https://bugs.webkit.org/show_bug.cgi?id=96969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):

• bytecode/Instruction.h:

(JSC::Instruction::Instruction):

• interpreter/AbstractPC.cpp:

(JSC::AbstractPC::AbstractPC):

• interpreter/AbstractPC.h:

(AbstractPC):

• interpreter/CallFrame.h:

(ExecState):

• interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::retrieveLastCaller):

• interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):
(Interpreter):

• jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

• offlineasm/asm.rb:
• offlineasm/offsets.rb:
• runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

• runtime/Executable.h:

(JSC::NativeExecutable::create):
(NativeExecutable):
(JSC::NativeExecutable::finishCreation):

• runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):

• runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):

• runtime/Options.cpp:

(JSC::Options::initialize):

Source/WebKit/blackberry:

• WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

• wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

• wtf/Platform.h:

9:25 PM Changeset in webkit [129452] by Antti Koivisto

• 8 edits in trunk/Source/WebCore

Don't use StyleSheetList internally.
​https://bugs.webkit.org/show_bug.cgi?id=97504

Reviewed by Ryosuke Niwa.

StyleSheetList is a DOM type and should not be used internally. Use plain Vector instead and construct StyleSheetList on DOM access only.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::collectMatchingRulesForList):

• css/StyleSheetList.cpp:

(WebCore::StyleSheetList::StyleSheetList):
(WebCore::StyleSheetList::styleSheets):
(WebCore):
(WebCore::StyleSheetList::detachFromDocument):

Use live stylesheet vector of the documents stylesheet collection as long as we are attached to a document.
When detached copy the stylesheet vector to a member field and use that instead.

(WebCore::StyleSheetList::length):
(WebCore::StyleSheetList::item):
(WebCore::StyleSheetList::getNamedItem):

• css/StyleSheetList.h:

Removed StyleSheetVector typedef as Vector<RefPtr<StyleSheet> > is less opaque and not much longer.

(WebCore):
(WebCore::StyleSheetList::create):
(StyleSheetList):
(WebCore::StyleSheetList::document):

• dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::styleSheets):

• dom/Document.h:

(Document):

• dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

• dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollec

9:09 PM Changeset in webkit [129451] by weinig@apple.com

• 11 edits
  3 adds in trunk

Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=97514

Reviewed by Anders Carlsson.

Source/WebKit2:

• GNUmakefile.list.am:
• PlatformEfl.cmake:
• Target.pri:

Add new files.

• UIProcess/Launcher/ProcessLauncher.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connect):
Move platform specific launch options to a new function, platformConnect.

• UIProcess/WebProcessProxy.h:
• UIProcess/efl/WebProcessProxyEfl.cpp: Added.

Move Efl specific launch options here.

(WebKit::WebProcessProxy::platformConnect):

• UIProcess/gtk/WebProcessProxyGtk.cpp: Added.

Add stub.

(WebKit::WebProcessProxy::platformConnect):

• UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::platformConnect):
Move Mac specific launch option setting here, and switch from
using an environment variable to NSUserDefaults.

• UIProcess/qt/WebProcessProxyQt.cpp: Added.

(WebKit::WebProcessProxy::platformConnect):
Add stub.

• UIProcess/win/WebProcessProxyWin.cpp:

(WebKit::WebProcessProxy::platformConnect):
Add stub.

Tools:

• Scripts/webkitdirs.pm:

(argumentsForRunAndDebugMacWebKitApp):
Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
is provided to set the user default. Move adding of @ARGV to after custom additions as calling
shouldUseXPCServiceForWebProcess() can change @ARGV.

(runMacWebKitApp):
(execMacWebKitAppForDebugging):
Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.

8:55 PM Changeset in webkit [129450] by commit-queue@webkit.org

• 7 edits in trunk/Source

Source/WebCore: [GTK][EFL] Remove cairo prefix from include statements
​https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

No new tests as there is no new functionality.

• platform/cairo/WidgetBackingStoreCairo.cpp:
• platform/gtk/GtkWidgetBackingStoreX11.cpp:
• plugins/gtk/PluginViewGtk.cpp:

Source/WebKit2: [GTK][EFL] Remove cairo prefix from include statements
​https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

• UIProcess/cairo/BackingStoreCairo.cpp:
• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

8:53 PM Changeset in webkit [129449] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[GTK][EFL] Make sure cairo is built with fontconfig support
​https://bugs.webkit.org/show_bug.cgi?id=97513

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Martin Robinson.

The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.

• efl/jhbuild.modules:
• gtk/jhbuild.modules:

8:26 PM Changeset in webkit [129448] by yosin@chromium.org

• 4 edits
  1 copy
  3 adds in trunk

Document::adoptNode for multiple fields time input UI should not crash
​https://bugs.webkit.org/show_bug.cgi?id=97428

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch changes Document::removeFocusedNodeOfSubtree() to check
focused node in shadow DOM tree for avoiding Document::m_focusedNode
not to have dangling pointer to field owner in DateTimeFieldElement.

Test:

• fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
• fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
• fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.

• dom/Document.cpp:

(WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
focused node in shadow DOM tree in addition to descendant node.

LayoutTests:

This patch adds a test for checking removeChild() of shadow host
dispatches blur event if focused node in shadow tree, a test for
checking adoptNode() doesn't causes crash and dispatches blur event
during document.adoptNode() and updates expectation for focus/blur event test.

• fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
• fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
• fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
• fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
• fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.

8:22 PM Changeset in webkit [129447] by commit-queue@webkit.org

• 2 edits in trunk

[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
​https://bugs.webkit.org/show_bug.cgi?id=97419

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.

• CMakeLists.txt:

Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".

8:13 PM Changeset in webkit [129446] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Blackberry] Add a software rendering path for media player
​https://bugs.webkit.org/show_bug.cgi?id=97443

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-09-24
Reviewed by Yong Li.

This patch adds a software rendering path for media player. When accelerated rendering
is not supported by the media engine for the current media, the rendering will fallback
to this software path.

PR #212386
Reviewed internally by Max Feil.

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

7:56 PM Changeset in webkit [129445] by benjamin@webkit.org

• 9 edits in trunk/LayoutTests

We should not expect percent-escaped hostname for invalid URLs
​https://bugs.webkit.org/show_bug.cgi?id=97415

Reviewed by Adam Barth.

The URL layout tests encode some Chromium specific behavior.
Chromium does a partial canonicalization of invalid URLs. Neither Safari, nor Firefox nor Opera
do that.

This patch fix the tests and expectations for the IP tests.

• fast/url/invalid-urls-utf8-expected.txt:
• fast/url/invalid-urls-utf8.html:

Move the "empty authority" check from both IP tests to the invalid URLs test. An empty authority
for a standard URL causes an invalid URL, it should be kept as is.

• fast/url/ipv4-expected.txt:
• fast/url/ipv6-expected.txt:
• fast/url/script-tests/ipv4.js:
• fast/url/script-tests/ipv6.js: Extend a comment to clarify the rule.

Invalid URLs should not be escaped.

7:30 PM Changeset in webkit [129444] by benjamin@webkit.org

• 46 edits in trunk

Fix Geolocation error reporting in the test support
​https://bugs.webkit.org/show_bug.cgi?id=97386

Source/WebCore:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

GeolocationController currently expose GeolocationError which can be either
PermissionDenied or PositionUnavailable.

In practice, only PositionUnavailable is supported and tested, only Chrome
somewhat expose PermissionDenied.
The correct way to deny the permission is through Geolocation::setIsAllowed().

This patch does some of the initial cleanup toward that goal, reducing how
far GeolocationError is spread.

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:

Mac does not use GeolocationClientMock, it should not be compiled in WebCore.

• platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPosition):
(WebCore::GeolocationClientMock::setPositionUnavailableError):
This method replace setError(). It is limited to PositionUnavailable errors.

(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::controllerTimerFired):
(WebCore):
(WebCore::GeolocationClientMock::clearError):

• platform/mock/GeolocationClientMock.h:

(WebCore):
(GeolocationClientMock):

Source/WebKit/blackberry:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

• WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):

• WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/chromium:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

• public/WebGeolocationClientMock.h:

(WebGeolocationClientMock):

• src/WebGeolocationClientMock.cpp:

(WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError):

Source/WebKit/gtk:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):

• WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

• WebView/WebView.mm:

(-[WebView _geolocationDidFailWithMessage:]):

• WebView/WebViewPrivate.h:

Source/WebKit/qt:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

• WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):

• WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.
The TestRunner was exposing internal implementation details of
the Geolocation object through setMockGeolocationError().

In practice, only the error code PositionUnavailable is supported
or even implemented.

Exposing setMockGeolocationError() does not make sense for WebKit2 as
passing generic errors from the UIProcess is a bad idea. This is the
opportunity to clean TestRunner and prepare and interface suitable for WebKit2.

• DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionUnavailableErrorCallback):
(TestRunner::staticFunctions):

• DumpRenderTree/TestRunner.h:

(TestRunner):

• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

• DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setMockGeolocationPositionUnavailableError):

• DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

• DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

• DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

• DumpRenderTree/mac/MockGeolocationProvider.h:
• DumpRenderTree/mac/MockGeolocationProvider.mm:

(-[MockGeolocationProvider dealloc]):
(-[MockGeolocationProvider resetError]):
(-[MockGeolocationProvider setPosition:]):
(-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
(-[MockGeolocationProvider lastPosition]):
(-[MockGeolocationProvider timerFired]):

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPositionUnavailableError):

• DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

• DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

• DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

LayoutTests:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

Update the tests to use setMockGeolocationPositionUnavailableError() instead
of setMockGeolocationError().

Only PositionError.POSITION_UNAVAILABLE was supported, so this not change
anything for the test coverage.

• fast/dom/Geolocation/error-clear-watch.html:
• fast/dom/Geolocation/error-expected.txt:
• fast/dom/Geolocation/maximum-age-expected.txt:
• fast/dom/Geolocation/reentrant-error-expected.txt:
• fast/dom/Geolocation/script-tests/error.js:
• fast/dom/Geolocation/script-tests/maximum-age.js:

(checkError):
(testNonZeroMaximumAge):

• fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
• fast/dom/Geolocation/script-tests/reentrant-error.js:
• fast/dom/Geolocation/script-tests/watch.js:

(checkError):

• fast/dom/Geolocation/watch-expected.txt:

7:16 PM Changeset in webkit [129443] by tkent@chromium.org

• 7 edits
  1 copy
  1 add in trunk/Source

[Chromium] Implement ValidationMessageClient for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=97167

Reviewed by Hajime Morita.

Source/WebCore:

• page/ValidationMessageClient.h:

Add forward declaration for WTF::String.

Source/WebKit/chromium:

Introduce ValidationMessageClientImpl. However actual popup
implementation should be done in WebViewClient.

• WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}.
• public/WebViewClient.h:

(WebKit::WebViewClient::showValidationMessage): Added.
(WebKit::WebViewClient::hideValidationMessage): Added.

• src/ValidationMessageClientImpl.cpp: Added.

(WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl):
(WebKit::ValidationMessageClientImpl::create):
(WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl):
Make sure that a popup is closed.
(WebKit::ValidationMessageClientImpl::showValidationMessage):
Implementataion of ValidationMessageClient::showValidationMessage.
minimumSecondToShowValidationMessage and secondPerCharacter are same as
the corresponding values in the current Shadow DOM implementation.
(WebKit::ValidationMessageClientImpl::hideValidationMessage):
Implementataion of ValidationMessageClient::hideValidationMessage.
(WebKit::ValidationMessageClientImpl::isValidationMessageVisible):
Implementataion of ValidationMessageClient::isValidationMessageVisible.
(WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage):
This is a callback function for the timer.

• src/ValidationMessageClientImpl.h: Added.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

• Initialize m_validationMessage.
• Add a comment for PageClients.

• src/WebViewImpl.h:

Add m_validationMessage.

7:07 PM Changeset in webkit [129442] by mihaip@chromium.org

• 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
​https://bugs.webkit.org/show_bug.cgi?id=97506

Reviewed by Adam Barth.

These methods have been no-ops since r127674. All Chromium code that
called them was removed with ​http://crrev.com/155205.

• public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

• src/WebRuntimeFeatures.cpp:

6:48 PM Changeset in webkit [129441] by yosin@chromium.org

• 7 edits in trunk/Source/WebCore

[Forms] DateTimeEditElement should return string value for ease of implementing other date/time input types.
​https://bugs.webkit.org/show_bug.cgi?id=97303

Reviewed by Kent Tamura.

This patch introduces a function DateTimeEditElement::value() for
setting internal text value of TimeInputType with new function
EditControlOwner::formatDateTimeFieldsState() to utilize this protocl
in other date time input types.

We used DateTimeEditElement::valueAsDouble() and and BaseDateAndTimeInputType::serialize()
to make string value then setting internal text value of multiple
fields time input UI. Although, this steps doesn't work well for
other date/time input types.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

• html/DateTimeFieldsState.cpp:

(WebCore::DateTimeFieldsState::hour23): Added to convert 1 to 12 hour value to 0 to 23 hour.

• html/DateTimeFieldsState.h:

(DateTimeFieldsState): Added declaration of hour23().

• html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Added to format time.
(WebCore::TimeInputType::restoreFormControlState): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().

• html/TimeInputType.h:

(DateTimeEditControlOwnerImpl): Added a declaration of formatDateTimeFieldsState().

• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::value): Added.

• html/shadow/DateTimeEditElement.h:

(EditControlOwner): Added a declaration of formatDateTimeFieldsState().
(DateTimeEditElement): Added a declaration of value().

6:26 PM Changeset in webkit [129440] by fpizlo@apple.com

• 4 edits
  3 adds in trunk

Nested try/finally should not confuse the finally unpopper in BytecodeGenerator::emitComplexJumpScopes
​https://bugs.webkit.org/show_bug.cgi?id=97508
<rdar://problem/12361132>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

We're reusing some vector for multiple iterations of a loop, but we were forgetting to clear its
contents from one iteration to the next. Hence if you did multiple iterations of finally unpopping
(like in a nested try/finally and a jump out of both of them) then you'd get a corrupted try
context stack afterwards.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitComplexJumpScopes):

LayoutTests:

• fast/js/jsc-test-list:
• fast/js/script-tests/try-try-return-finally-finally.js: Added.

(foo):

• fast/js/try-try-return-finally-finally-expected.txt: Added.
• fast/js/try-try-return-finally-finally.html: Added.

6:14 PM Changeset in webkit [129439] by dino@apple.com

• 2 edits in trunk/Source/WebCore

[WebGL] Intel Mac needs built-in function emulation
​https://bugs.webkit.org/show_bug.cgi?id=96140

Reviewed by Sam Weinig.

Temporarily turn on built-in function emulation for Intel GPUs
on OS X. This is a work-around for a driver bug, and
will be removed once the driver is updated:
​https://bugs.webkit.org/show_bug.cgi?id=97503

This can be tested using the Khronos WebGL conformance
suite, in particular:

conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-length.html
conformance/glsl/functions/glsl-function-normalize.html
conformance/glsl/functions/glsl-function-reflect.html

Note that the faceforward built-in will still cause
problems on Intel GPUs, but this would require an unnecessary
change in the ANGLE project (remember, we're going to
remove this code once the driver is fixed).

• platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

Temporarily add "Intel" to the list of GPUs we do translation
for in the shader compiler.

6:05 PM Changeset in webkit [129438] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

There is a mistake in InspectorProfilerAgent::enable(bool skipRecompile)
​https://bugs.webkit.org/show_bug.cgi?id=97450

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Yury Semikhatsky.

The "InspectorProfilerAgent::enable()" should invokes "PageScriptDebugServer" in
no-worker thread.

No new test case.

• inspector/InspectorProfilerAgent.cpp:

(WebCore::PageProfilerAgent::recompileScript):
(PageProfilerAgent):
(WebCore::WorkerProfilerAgent::recompileScript):
(WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):

• inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

5:54 PM Changeset in webkit [129437] by commit-queue@webkit.org

• 5 edits in trunk

[EFL][WK2] TestRunner needs touch events support.
​https://bugs.webkit.org/show_bug.cgi?id=96465

Patch by Nikhil Bansal <​n.bansal@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

Tools:

Simulate touch events in WebkitTestRunner for touch related
layout tests. This patch uses ewk_view_feed_touch_event() to
generate touch events.

• WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

• WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR):
(WTR::setEvasModifiers):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

Touch events support added in WebKitTestRunner for layout tests.

• platform/efl-wk2/TestExpectations:

5:53 PM Changeset in webkit [129436] by vollick@chromium.org

• 2 edits in branches/chromium/1229/Source/WebCore

CCActiveAnimation should handle durations of zero gracefully

5:46 PM Changeset in webkit [129435] by fpizlo@apple.com

• 4 edits
  3 adds in trunk

ValueToInt32 bool case does bad things to registers
​https://bugs.webkit.org/show_bug.cgi?id=97505
<rdar://problem/12356331>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

LayoutTests:

• fast/js/dfg-bool-to-int32-reuse-expected.txt: Added.
• fast/js/dfg-bool-to-int32-reuse.html: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-bool-to-int32-reuse.js: Added.

(foo):

5:38 PM Changeset in webkit [129434] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Add cloopDo instruction for debugging the llint C++ backend.
​https://bugs.webkit.org/show_bug.cgi?id=97502.

Reviewed by Geoffrey Garen.

• offlineasm/cloop.rb:
• offlineasm/instructions.rb:
• offlineasm/parser.rb:

5:28 PM Changeset in webkit [129433] by Patrick Gansterer

• 5 edits in trunk/Source

Remove String::operator+=()
​https://bugs.webkit.org/show_bug.cgi?id=96172

Reviewed by Benjamin Poulain.

Source/WebCore:

Replace the last usage with String::append() in Gtk.

• platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::handleCommit):

Source/WTF:

• wtf/Platform.h:
• wtf/text/WTFString.h:

5:20 PM Changeset in webkit [129432] by fpizlo@apple.com

• 6 edits
  3 adds in trunk

JSArray::putByIndex asserts with readonly property on prototype
​https://bugs.webkit.org/show_bug.cgi?id=97435
<rdar://problem/12357084>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Boy, there were some problems:

• putDirectIndex() should know that it can set the index quickly even if it's a hole and we're in SlowPut mode, since that's the whole point of PutDirect.

• We should have a fast path for putByIndex().

• The LiteralParser should not use push(), since that may throw if we're having a bad time.

• interpreter/Interpreter.cpp:

(JSC::eval):

• runtime/JSObject.h:

(JSC::JSObject::putByIndexInline):
(JSObject):
(JSC::JSObject::putDirectIndex):

• runtime/LiteralParser.cpp:

(JSC::::parse):

LayoutTests:

• fast/js/concat-while-having-a-bad-time.html: Added.
• fast/js/concat-while-having-a-bad-time-expected.txt: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/concat-while-having-a-bad-time.js: Added.

5:12 PM Changeset in webkit [129431] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=95803

• platform/win/Skipped:

5:05 PM Changeset in webkit [129430] by commit-queue@webkit.org

• 9 edits in trunk

[WK2] TestRunner does not support overridePreference with value "0"
​https://bugs.webkit.org/show_bug.cgi?id=97457

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24
Reviewed by Alexey Proskuryakov.

Tools:

testRunner.overridePreference() was marked as taking a boolean
in argument in testRunner.idl even though the test cases are
passing strings to it. The current code works if the test
case wants to enable a setting and therefore passes "1" string.
However, if the test wants to disable a setting and passes "0"
string, the current code also evaluates this to true causing
certain test cases to fail.

The argument to testRunner.overridePreference() is now of string
type and a function has been added to convert the string passed
by the test to a boolean value.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::toBool):
(WTR):
(WTR::TestRunner::overridePreference):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip fast/regions/css-regions-disabled.html test case for
WebKit2 now that WebKitTestRunner actually supports overriding
a boolean preference with "0" value (to disable it).

• platform/efl-wk2/TestExpectations:
• platform/gtk-wk2/TestExpectations:
• platform/mac-wk2/Skipped:
• platform/qt-5.0-wk2/Skipped:

4:57 PM Changeset in webkit [129429] by pilgrim@chromium.org

• 5 edits in trunk/Source

[Chromium][Mac] Remove loadFont from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97360

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

• platform/chromium/PlatformSupport.h:

(PlatformSupport):

• platform/graphics/chromium/CrossProcessFontLoading.mm:

Source/WebKit/chromium:

• src/PlatformSupport.cpp:

(WebCore):

4:53 PM Changeset in webkit [129428] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
​https://bugs.webkit.org/show_bug.cgi?id=97496.

Reviewed by Filip Pizlo.

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

4:43 PM Changeset in webkit [129427] by tony@chromium.org

• 5 edits in trunk/Source/WebCore

Replace 2 uses of updateLogicalHeight with computeLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=97486

Reviewed by Ojan Vafai.

More work for bug 96804. This is just a refactoring.

No new tests, behavior should be the same as before.

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalHeight):

• rendering/RenderFlowThread.h:
• rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
(WebCore):

• rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

4:12 PM Changeset in webkit [129426] by ggaren@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Inlined activation tear-off in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=97487

Reviewed by Filip Pizlo.

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h: Activation tear-off is always inlined now, so I

removed its out-of-line implementation.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Inlined the variable copy and update
of JSVariableObject::m_registers. This usually turns into < 10 instructions,
which is close to pure win as compared to the operation function call.

• runtime/JSActivation.h:

(JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC):
(JSC::JSActivation::storageOffset):
(JSC::JSActivation::storage): Tiny bit of refactoring so the JIT can
share the pointer math helper functions we use internally.

3:23 PM Changeset in webkit [129425] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
investigates in ​https://bugs.webkit.org/show_bug.cgi?id=95530 in order to get the bots green.

• platform/win/Skipped:

3:18 PM Changeset in webkit [129424] by kbr@google.com

• 2 edits in trunk/Source/WebCore

[V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
​https://bugs.webkit.org/show_bug.cgi?id=96703

Reviewed by Adam Barth.

Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.

No tests because it is not guaranteed that buffers this large can actually be allocated.

• bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

3:14 PM Changeset in webkit [129423] by Antti Koivisto

• 30 edits
  1 copy
  1 add in trunk/Source

Split stylesheet related code out from Document
​https://bugs.webkit.org/show_bug.cgi?id=97353

Reviewed by Andreas Kling.

Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.

The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
DocumentStyleSheetCollection class. There are no functional changes.

The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.

• WebCore.xcodeproj/project.pbxproj:
• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::collectMatchingRulesForList):

• css/StyleResolver.h:

(WebCore::StyleResolver::usesBeforeAfterRules):
(Features):

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore):
(WebCore::Document::createStyleResolver):
(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore::Document::didRemoveAllPendingStylesheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::styleSheets):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::reportMemoryUsage):
(WebCore::Document::haveStylesheetsLoaded):

• dom/Document.h:

(WebCore):
(Document):
(WebCore::Document::styleSheetCollection):
(WebCore::Document::hasNodesWithPlaceholderStyle):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
(WebCore::Document::inStyleRecalc):

• dom/DocumentStyleSheetCollection.cpp: Added.

(WebCore):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

• dom/DocumentStyleSheetCollection.h: Added.

(WebCore):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::authorStyleSheets):
(WebCore::DocumentStyleSheetCollection::documentUserSheets):
(WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::addPendingSheet):
(WebCore::DocumentStyleSheetCollection::hasPendingSheets):
(WebCore::DocumentStyleSheetCollection::usesSiblingRules):
(WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesRemUnits):
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit):

• dom/Element.cpp:

(WebCore::Element::recalcStyle):

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

• dom/StyleElement.cpp:

(WebCore::StyleElement::insertedIntoDocument):
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearDocumentData):
(WebCore::StyleElement::createSheet):
(WebCore::StyleElement::sheetLoaded):
(WebCore::StyleElement::startLoadingDynamicSheet):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

• html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto):

• html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):

• mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto):

• page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

• page/PageGroup.cpp:

(WebCore::PageGroup::resetUserStyleCacheInAllFrames):

• rendering/RenderBR.cpp:

(WebCore::RenderBR::lineHeight):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::lineHeight):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::firstLineStyleSlowCase):

• rendering/RenderObject.h:

(WebCore::RenderObject::firstLineStyle):

• rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::updateBeforeAndAfterContent):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

3:08 PM Changeset in webkit [129422] by kareng@chromium.org

• 4 edits
  2 copies in branches/chromium/1271

Merge 128999 - Do touch adjustment on GestureTapDown
​https://bugs.webkit.org/show_bug.cgi?id=96677

Patch by Rick Byers <​rbyers@chromium.org> on 2012-09-19
Reviewed by Antonio Gomes.

Source/WebCore:

Do touch adjustment on GestureTapDown exactly as for GestureTap today.

Test: touchadjustment/touch-links-active.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::adjustGesturePosition):

Tools:

Allow radius to be set for GestureTapDown events.

• DumpRenderTree/chromium/TestRunner/EventSender.cpp:

(EventSender::gestureEvent):

LayoutTests:

Make a few tweaks to the touchadjustment.js infrastructure to make it
simpler and easier to use. Add a test for touch-adjustment of
GestureTapDown events (based on touch-links-longpress).

• touchadjustment/resources/touchadjustment.js:

(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
(touchPoint.return.get y):
(touchPoint):
(offsetTouchPoint):

• touchadjustment/touch-links-active-expected.txt: Added.
• touchadjustment/touch-links-active.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/10988006

3:06 PM Changeset in webkit [129421] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=97485

This test actually "passes" but is producing wrong output in whichever test proceeds it, thus causing that test to fail.

• platform/win/Skipped:

3:05 PM TestExpectations edited by dpranke@chromium.org

add comments about flaky tests (diff)

3:04 PM Changeset in webkit [129420] by Lucas Forschler

• 5 edits in branches/safari-534.58-branch/Source

Versioning.

2:59 PM Changeset in webkit [129419] by commit-queue@webkit.org

• 12 edits
  1 delete in trunk/Source

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Source/WebCore:

Revert "[BlackBerry] Reverting implementation for 407 error pages"
This reverts commit fda0a1b6ac40c06c03bb6293b4a7d7353c3ca238.

This revert also reverts commit 0cffe01961fb80204138505bcec29a83818efb73
due to dependency issues.

• PlatformBlackBerry.cmake:
• platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
• platform/blackberry/AuthenticationChallengeManager.h:
• platform/blackberry/PageClientBlackBerry.h:
• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):

• platform/network/blackberry/NetworkJob.h:

(NetworkJob):

Source/WebKit/blackberry:

Revert "[BlackBerry] Really fix bug 95488 that user can get the
authentication challenge dialog while the other tab has focus."
​https://bugs.webkit.org/show_bug.cgi?id=97348

This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.

• Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):

• Api/WebPage_p.h:

(WebPagePrivate):

2:55 PM Changeset in webkit [129418] by crogers@google.com

• 2 edits in trunk/Source/WebCore

[REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=97439

Reviewed by Kenneth Russell.

Fixes uninitialized member variable.

This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html

• Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

2:52 PM Changeset in webkit [129417] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

Narrow Chromium TestExpectations for some hidpi failures to be Linux-only.
crbug.com/150682

Unreviewed, expectations change.

Also remove a no-longer-failing Mac expectation for
compositing/overflow/overflow-scaled-descendant-overlapping.html

• platform/chromium/TestExpectations:

2:40 PM Changeset in webkit [129416] by Lucas Forschler

• 1 copy in tags/Safari-536.27.1

New Tag.

2:38 PM Changeset in webkit [129415] by dmazzoni@google.com

• 3 edits in branches/chromium/1271

Merge 129036 - AX: A few control types are returning the wrong answer for isReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html

platform/mac/accessibility/form-control-value-settable.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

• DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):

• DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:

(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

• platform/chromium/accessibility/readonly-expected.txt: Added.
• platform/chromium/accessibility/readonly.html: Added.
• platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
• platform/mac/accessibility/form-control-value-settable.html: Added.

TBR=​dmazzoni@google.com
Review URL: ​https://codereview.chromium.org/10984006

2:35 PM Changeset in webkit [129414] by tony@chromium.org

• 7 edits in trunk

flex-grow should be 1 when omitted from flex shorthand
​https://bugs.webkit.org/show_bug.cgi?id=97480

Reviewed by Ojan Vafai.

Source/WebCore:

We were using 0, based on an outdated version of the spec.

Tests: css3/flexbox/flex-property-parsing.html

css3/flexbox/flex-algorithm.html: New test case.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

Update tests due to default CSS value changes.

• css3/flexbox/flex-algorithm-expected.txt:
• css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
• css3/flexbox/flex-property-parsing-expected.txt:
• css3/flexbox/flex-property-parsing.html:

2:32 PM Changeset in webkit [129413] by benjamin@webkit.org

• 16 edits
  2 adds
  1 delete in trunk/Source

Add support for query encoding to WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=97422

Reviewed by Adam Barth.

Source/WebCore:

Add the Charset conversion on WebCore side.

• platform/KURLWTFURL.cpp:

(WebCore::KURL::KURL):
(CharsetConverter):
(WebCore::CharsetConverter::CharsetConverter):

• platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

Source/WTF:

Expose character conversion through the new abstract class URLQueryCharsetConverter.
URLQueryCharsetConverter is implemented by WebCore to expose the TextEncoding classes.

Unfortunatelly that forces us to bring over URLBuffer in the public API. We may be able
to mitigate that later when moving WTFURL to more templates.

The change fixes 2 of the URL layout tests.

• WTF.xcodeproj/project.pbxproj:
• wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):

• wtf/url/api/ParsedURL.h:

(ParsedURL):
ParsedURL was using the same constructor for ParsedURLString, and URL without a base.
That was a mistake on my part, I did not intend that, fixed it now :)

• wtf/url/api/URLBuffer.h: Renamed from Source/WTF/wtf/url/src/URLBuffer.h.

(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):

• wtf/url/api/URLQueryCharsetConverter.h: Added.

(URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::~URLQueryCharsetConverter):

• wtf/url/src/URLCanon.h:

(URLCanonicalizer):

• wtf/url/src/URLCanonFilesystemurl.cpp:

(WTF::URLCanonicalizer::canonicalizeFileSystemURL):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):

• wtf/url/src/URLCanonFileurl.cpp:

(WTF::URLCanonicalizer::CanonicalizeFileURL):
(WTF::URLCanonicalizer::ReplaceFileURL):

• wtf/url/src/URLCanonInternal.h:

(URLCanonicalizer):

• wtf/url/src/URLCanonQuery.cpp:

(WTF::URLCanonicalizer::CanonicalizeQuery):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):

• wtf/url/src/URLCanonRelative.cpp:

(WTF::URLCanonicalizer::resolveRelativeURL):

• wtf/url/src/URLCanonStdURL.cpp:

(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):

• wtf/url/src/URLUtil.cpp:

(URLUtilities):
(WTF::URLUtilities::canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):

• wtf/url/src/URLUtil.h:

(URLUtilities):

2:30 PM Changeset in webkit [129412] by benjamin@webkit.org

• 13 edits
  23 adds
  4 deletes in trunk/Source

Integrate most of GoogleURL in WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=97405

Reviewed by Adam Barth.

Source/WebCore:

Loosen KURLWTFURL to be able to run most tests in Debug.

• platform/KURLWTFURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::hasPort):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::query):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::fileSystemPath):

Source/WTF:

This patch brings almost all of the implementatation of Google-URL in WTFURL
with only minor changes.

The changes from the original code are mostly:
-Code cleaning.
-Replace url_parse::Parsed by URLSegments.
-Replace url_parse::Component by URLComponent
-More code cleaning.
-Adopt URLBuffer and RawURLBuffer instead of the CanonOutputT and RawCanonOutputT.
-Use URLCharacterTypes instead of the litany of characters functions.
-Some more code cleaning.
-Fix the style to match WebKit as much as possible.
-Rename the files to match WebKit style.

• WTF.xcodeproj/project.pbxproj:
• wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::segment):

• wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::isValid):

• wtf/url/src/RawURLBuffer.h:
• wtf/url/src/URLCanon.h: Added.

(URLCanonicalizer):
(CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::~CharsetConverter):
(CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::IsIPAddress):
(WTF::URLCanonicalizer::CanonHostInfo::AddressLength):
(URLComponentSource):
(WTF::URLCanonicalizer::URLComponentSource::URLComponentSource):
(Replacements):
(WTF::URLCanonicalizer::Replacements::Replacements):
(WTF::URLCanonicalizer::Replacements::SetScheme):
(WTF::URLCanonicalizer::Replacements::IsSchemeOverridden):
(WTF::URLCanonicalizer::Replacements::SetUsername):
(WTF::URLCanonicalizer::Replacements::ClearUsername):
(WTF::URLCanonicalizer::Replacements::IsUsernameOverridden):
(WTF::URLCanonicalizer::Replacements::SetPassword):
(WTF::URLCanonicalizer::Replacements::ClearPassword):
(WTF::URLCanonicalizer::Replacements::IsPasswordOverridden):
(WTF::URLCanonicalizer::Replacements::SetHost):
(WTF::URLCanonicalizer::Replacements::ClearHost):
(WTF::URLCanonicalizer::Replacements::IsHostOverridden):
(WTF::URLCanonicalizer::Replacements::SetPort):
(WTF::URLCanonicalizer::Replacements::ClearPort):
(WTF::URLCanonicalizer::Replacements::IsPortOverridden):
(WTF::URLCanonicalizer::Replacements::SetPath):
(WTF::URLCanonicalizer::Replacements::ClearPath):
(WTF::URLCanonicalizer::Replacements::IsPathOverridden):
(WTF::URLCanonicalizer::Replacements::SetQuery):
(WTF::URLCanonicalizer::Replacements::ClearQuery):
(WTF::URLCanonicalizer::Replacements::IsQueryOverridden):
(WTF::URLCanonicalizer::Replacements::SetRef):
(WTF::URLCanonicalizer::Replacements::ClearRef):
(WTF::URLCanonicalizer::Replacements::IsRefOverridden):
(WTF::URLCanonicalizer::Replacements::sources):
(WTF::URLCanonicalizer::Replacements::components):
(WTF::URLCanonicalizer::Replacements::Placeholder):

• wtf/url/src/URLCanonEtc.cpp: Added.

(WTF::URLCanonicalizer::removeURLWhitespace):
(URLCanonicalizer):
(WTF::URLCanonicalizer::canonicalSchemeChar):
(WTF::URLCanonicalizer::CanonicalizeScheme):
(WTF::URLCanonicalizer::CanonicalizeUserInfo):
(WTF::URLCanonicalizer::CanonicalizePort):
(WTF::URLCanonicalizer::CanonicalizeRef):

• wtf/url/src/URLCanonFilesystemurl.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeFileSystemURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):

• wtf/url/src/URLCanonFileurl.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeFileURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::FileCanonicalizePath):
(WTF::URLCanonicalizer::ReplaceFileURL):

• wtf/url/src/URLCanonHost.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeHost):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeHostVerbose):

• wtf/url/src/URLCanonICU.cpp: Added.

(WTF::URLCanonicalizer::IDNToASCII):
(URLCanonicalizer):
(WTF::URLCanonicalizer::readUTFChar):

• wtf/url/src/URLCanonIP.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeIPAddress):
(URLCanonicalizer):

• wtf/url/src/URLCanonInternal.cpp: Added.

(URLCanonicalizer):
(WTF::URLCanonicalizer::AppendInvalidNarrowString):
(WTF::URLCanonicalizer::ConvertUTF16ToUTF8):
(WTF::URLCanonicalizer::ConvertUTF8ToUTF16):
(WTF::URLCanonicalizer::SetupOverrideComponents):
(WTF::URLCanonicalizer::SetupUTF16OverrideComponents):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):

• wtf/url/src/URLCanonInternal.h: Added.

(URLCanonicalizer):
(WTF::URLCanonicalizer::hexCharToValue):
(WTF::URLCanonicalizer::isDot):
(WTF::URLCanonicalizer::appendURLEscapedCharacter):
(WTF::URLCanonicalizer::doAppendUTF8):
(WTF::URLCanonicalizer::AppendCharToOutput):
(WTF::URLCanonicalizer::AppendUTF8Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedValue):
(WTF::URLCanonicalizer::AppendUTF16Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedChar):
(WTF::URLCanonicalizer::Is8BitChar):
(WTF::URLCanonicalizer::DecodeEscaped):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):
(WTF::URLCanonicalizer::_strtoui64):

• wtf/url/src/URLCanonMailto.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeMailtoURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceMailtoURL):

• wtf/url/src/URLCanonPath.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizePath):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizePartialPath):

• wtf/url/src/URLCanonPathurl.cpp: Added.

(WTF::URLCanonicalizer::canonicalizePathURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplacePathURL):

• wtf/url/src/URLCanonQuery.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeQuery):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):

• wtf/url/src/URLCanonRelative.cpp: Added.

(WTF::URLCanonicalizer::isRelativeURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::resolveRelativeURL):

• wtf/url/src/URLCanonStdURL.cpp: Added.

(WTF::URLCanonicalizer::DefaultPortForScheme):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):

• wtf/url/src/URLCharacterTypes.cpp:
• wtf/url/src/URLCharacterTypes.h:

(WTF::URLCharacterTypes::isComponentChar):
(WTF::URLCharacterTypes::isHexChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isCharacterOfType):
(URLCharacterTypes):

• wtf/url/src/URLEscape.cpp: Removed.
• wtf/url/src/URLFile.h: Added.

(URLParser):
(WTF::URLParser::isWindowsDriveSeparator):
(WTF::URLParser::isWindowsDriveLetter):
(WTF::URLParser::findNextSlash):
(WTF::URLParser::doesBeginWindowsDriveSpec):
(WTF::URLParser::doesBeginUNCPath):

• wtf/url/src/URLParse.cpp: Added.

(WTF::URLParser::ExtractScheme):
(URLParser):
(WTF::URLParser::IsAuthorityTerminator):
(WTF::URLParser::ExtractFileName):
(WTF::URLParser::ExtractQueryKeyValue):
(WTF::URLParser::ParseAuthority):
(WTF::URLParser::ParsePort):
(WTF::URLParser::ParseStandardURL):
(WTF::URLParser::ParsePathURL):
(WTF::URLParser::ParseFileSystemURL):
(WTF::URLParser::ParseMailtoURL):
(WTF::URLParser::parsePathInternal):
(WTF::URLParser::ParseAfterScheme):

• wtf/url/src/URLParse.h: Added.

(URLParser):

• wtf/url/src/URLParseFile.cpp: Added.

(WTF):
(WTF::URLParser::ParseFileURL):
(URLParser):

• wtf/url/src/URLParseInternal.h: Added.

(URLParser):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::countConsecutiveSlashes):

• wtf/url/src/URLParser.h: Removed.
• wtf/url/src/URLQueryCanonicalizer.h: Removed.
• wtf/url/src/URLSegments.cpp:
• wtf/url/src/URLSegments.h:

(WTF::URLSegments::URLSegments):
(URLSegments):
(WTF::URLSegments::operator=):
(WTF::URLSegments::innerURLSegments):
(WTF::URLSegments::setInnerURLSegments):
(WTF::URLSegments::clearInnerURLSegments):

• wtf/url/src/URLUtil.cpp: Added.

(URLUtilities):
(WTF::URLUtilities::IsStandard):
(WTF::URLUtilities::FindAndCompareScheme):
(WTF::URLUtilities::Canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):
(WTF::URLUtilities::LowerCaseEqualsASCII):
(WTF::URLUtilities::DecodeURLEscapeSequences):
(WTF::URLUtilities::EncodeURIComponent):
(WTF::URLUtilities::CompareSchemeComponent):

• wtf/url/src/URLUtil.h: Added.

(URLUtilities):

• wtf/url/src/URLUtilInternal.h: Renamed from Source/WTF/wtf/url/src/URLEscape.h.

(URLUtilities):

2:18 PM Changeset in webkit [129411] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk

[CSS Exclusions] ExclusionShape API should use logical coordinates for input/output
​https://bugs.webkit.org/show_bug.cgi?id=96156

Patch by Hans Muller <​hmuller@adobe.com> on 2012-09-24
Reviewed by Dirk Schulze.

Source/WebCore:

Correct how ExclusionShapes deal with logical coordinates and enable
shape-inside exclusion layout for vertical writing-modes.

BasicShape's are defined in physical cooordinates, incoming line and box
dimensions are logical coordinates, and the ExclusionShape internals assume
that lines are aligned with the Y axis. The createExclusionShape() method
is responsible for converting the BasicShape to the internal coordinate
system when the writing-mode is vertical. Similarly, the getInclude,ExcludedIntervals()
methods are responsible for converting their logical line parameters to Y
values in the internal coordinate system. The min,maxYForLogicalLine()
methods do the conversion, based on the WritingMode the ExclusionShape
was created with. The getInclude,ExcludedIntervals() methods return the
logical left and right edges of line segments. No transformation is needed for this.

The ExclusionShape's internal coordinate system is essentially the
"logical" one, except that top/bottom always map to Y, no matter what
the writing-mode is. This is just to simplify writing geometrical shape
algorithms, notably the complex ones for polygons. The bug report includes a
pair of diagrams that clarify how internal coordinates are related to logical
and physical coordinates.

Test: fast/exclusions/shape-inside/shape-inside-vertical-text.html

• rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals): rename more accurately reflects return value
(WebCore::ExclusionRectangle::getIncludedIntervals): rename for consistency with "excluded" version

• rendering/ExclusionRectangle.h:
• rendering/ExclusionShape.cpp:

(WebCore):
(WebCore::ExclusionShape::createExclusionShape):

• rendering/ExclusionShape.h:

(LineSegment):
(WebCore::LineSegment::LineSegment): relocated from WrapShapeInfo.h
(WebCore):
(ExclusionShape):
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):
(WebCore::ExclusionShape::internalToLogicalBoundingBox):

• rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForRenderBlock):
(WebCore::WrapShapeInfo::computeShapeSize): pass writingMode to createExclusionShape()
(WebCore::WrapShapeInfo::computeSegmentsForLine): removed short-circuit for vertical writing-modes

• rendering/WrapShapeInfo.h:

(WebCore):

LayoutTests:

Verify that shape-inside respects the writing-mode, notably the vertical writing-modes.

• fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-vertical-text.html: Added.

2:13 PM Changeset in webkit [129410] by commit-queue@webkit.org

• 7 edits in trunk/LayoutTests

Rebaseline for r129389
​https://bugs.webkit.org/show_bug.cgi?id=97473

Unreviewed.

Patch by Alec Flett <​alecflett@chromium.org> on 2012-09-24

• platform/chromium-mac-snowleopard/fast/text/emphasis-expected.png:
• platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.png:
• platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt:
• platform/chromium-mac/fast/text/emphasis-expected.png:
• platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
• platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt:

2:11 PM Changeset in webkit [129409] by tony@chromium.org

• 3 edits in trunk/Source/WebCore

Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=97475

Reviewed by Ojan Vafai.

Using RenderMeter::computeLogicalHeight is part of bug 96804.
Also fix some code to be vertical writing mode aware. This doesn't actually cause
a behavioral difference because we use percentage heights/widths which don't depend on
updateLogicalWidth or computeLogicalHeight. You can still see bugs if you try to set
the min-width on a <meter> node in a vertical writing mode.

No new tests, no behavioral changes.

• rendering/RenderMeter.cpp:

(WebCore::RenderMeter::updateLogicalWidth): Make vertical writing mode aware.
(WebCore::RenderMeter::computeLogicalHeight): Switch from updateLogicalHeight and make vertical writing mode aware.

• rendering/RenderMeter.h:

(RenderMeter):

1:58 PM Changeset in webkit [129408] by Dimitri Glazkov

• 5 edits
  2 deletes in trunk

Remove unbaked support for :scope pseudo-class.
​https://bugs.webkit.org/show_bug.cgi?id=97467

Reviewed by Antti Koivisto.

It turns out, the Selectors 4 require ":scope" to match contextual reference element set, which would be the root node in querySelector:
​http://dev.w3.org/csswg/selectors4/#the-scope-pseudo

Right now, we simply make ":scope" equivalent to ":root", which is not correct. Let's remove the partial implementation until we have
time/energy to fully implement it.

Source/WebCore:

No new tests, removing half-baked feature.

• css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId): Removed all mentions of PseudoScope
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.

• css/CSSSelector.h: Ditto.
• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Ditto.

LayoutTests:

• fast/css/style-scoped/scope-pseudo-expected.txt: Removed.
• fast/css/style-scoped/scope-pseudo.html: Removed.

1:47 PM Changeset in webkit [129407] by Csaba Osztrogonác

• 4 edits in trunk

Unreviewed, rolling out r129343.
​http://trac.webkit.org/changeset/129343
​https://bugs.webkit.org/show_bug.cgi?id=97479

It broke the build (Requested by Ossy_NIGHT on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-24

.:

• Source/api.pri:

Tools:

• qmake/mkspecs/features/default_pre.prf:

1:34 PM Changeset in webkit [129406] by rniwa@webkit.org

• 10 edits in trunk/Source

suspend/resumeWidgetHierarchyUpdates should be a RAII object
​https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

• WebCore.exp.in: Export new symbols.
• dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

• dom/Document.cpp:

(WebCore::Document::recalcStyle):

• dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

• rendering/RenderWidget.cpp:

(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):

• rendering/RenderWidget.h:

(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]):

1:23 PM Changeset in webkit [129405] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. accessibility/svg-bounds.html crashes on Windows due to use of AX role which hasn't been properly implemented on Windows.

• platform/win/Skipped:

1:21 PM Changeset in webkit [129404] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Revert "[BlackBerry] Show custom error page when 407 is received"
This reverts commit e6d14529428fe47916fcb997528095b8acad2f2b.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

1:09 PM Changeset in webkit [129403] by cevans@google.com

• 1 edit in branches/chromium/1271/Source/WebCore/dom/Document.cpp

Merge 129270
BUG=147700
Review URL: ​https://codereview.chromium.org/10957065

1:07 PM Changeset in webkit [129402] by commit-queue@webkit.org

• 24 edits
  8 deletes in trunk

Unreviewed, rolling out r129388.
​http://trac.webkit.org/changeset/129388
​https://bugs.webkit.org/show_bug.cgi?id=97477

Caused an assertion in a WebKit2 unit test (Requested by
abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-24

.:

• Source/autotools/symbols.filter:

Source/WebCore:

• WebCore.exp.in:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

• loader/cache/CachedImage.cpp:
• loader/cache/CachedImage.h:

(WebCore::CachedImage::stillNeedsLoad):
(CachedImage):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

• loader/cache/CachedResource.h:

(WebCore):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):

• loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

• page/Settings.cpp:

(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
(WebCore::Settings::setImagesEnabled):

• page/Settings.h:

(Settings):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

• testing/InternalSettings.h:

(Backup):
(InternalSettings):

• testing/InternalSettings.idl:

Source/WebKit2:

• win/WebKit2.def:

LayoutTests:

• fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
• fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
• fast/loader/resources/image1.html: Removed.
• fast/loader/resources/image2.html: Removed.
• platform/chromium/permissionclient/image-permissions-expected.txt:
• platform/chromium/permissionclient/image-permissions.html:
• platform/chromium/permissionclient/resources/image.html:
• platform/wk2/Skipped:

1:06 PM Changeset in webkit [129401] by cevans@google.com

• 3 edits in branches/chromium/1271/Source/WebCore/rendering

Merge 129144
BUG=145530
Review URL: ​https://codereview.chromium.org/10970075

1:04 PM Changeset in webkit [129400] by arv@chromium.org

• 8 edits
  10 adds in trunk

DOM4 remove method
​https://bugs.webkit.org/show_bug.cgi?id=73885

Reviewed by Ojan Vafai.

This adds the DOM 4 remove method.

​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-childnode-remove

The remove method removes the node from its parent if it has a parent.

Source/WebCore:

Tests: fast/dom/Comment/remove.html

fast/dom/DocumentType/remove.html
fast/dom/Element/remove.html
fast/dom/Text/remove.html

• dom/CharacterData.idl:
• dom/DocumentType.idl:
• dom/Element.idl:
• dom/Node.cpp:

(WebCore::Node::remove): The spec says to do nothing if the node has no parent.

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody): Cleanup.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::removeDisplayTree): No need to check parenNode twice.

LayoutTests:

• fast/dom/Comment/remove-expected.txt: Added.
• fast/dom/Comment/remove.html: Added.
• fast/dom/DocumentType/remove-expected.txt: Added.
• fast/dom/DocumentType/remove.html: Added.
• fast/dom/Element/remove-expected.txt: Added.
• fast/dom/Element/remove.html: Added.
• fast/dom/Text/remove-expected.txt: Added.
• fast/dom/Text/remove.html: Added.

12:53 PM Changeset in webkit [129399] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

[GTK] Add Select All method to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=97460

Patch by Simon Pena <Simon Pena> on 2012-09-24
Reviewed by Martin Robinson.

Following the same approach used when added Cut, Copy and Paste,
the Select All method is added to the WebKit2 GTK+ API.

This introduces a new macro in the WebKitEditingCommands,
updates the documentation, and includes a new unit test.

• UIProcess/API/gtk/WebKitEditingCommands.h: Add a new macro for

the Select All command.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the Select All

command in the documentation.

• UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Cover the new command

with a unit test.
(testWebViewEditorSelectAll):
(beforeAll):

12:12 PM Changeset in webkit [129398] by roger_fong@apple.com

• 1 edit
  2 deletes in trunk/LayoutTests

Unreviewed. Removing Windows specific results for fast/text/international/float-as-only-child-of-isolate-crash that were added in ​https://bugs.webkit.org/show_bug.cgi?id=87998.
Test now passes properly.

• platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Removed.
• platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Removed.

11:56 AM Changeset in webkit [129397] by tommyw@google.com

• 8 edits in trunk

MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
​https://bugs.webkit.org/show_bug.cgi?id=97456

Reviewed by Adam Barth.

Renamed onnegotationneeded to onnegotiationneeded.

Source/WebCore:

Existing test updated.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::negotiationNeeded):

• Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

• Modules/mediastream/RTCPeerConnection.idl:
• dom/EventNames.h:

(WebCore):

LayoutTests:

• fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
• fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:

11:52 AM Changeset in webkit [129396] by tony@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

• DEPS:

11:49 AM Changeset in webkit [129395] by dominik.rottsches@intel.com

• 7 edits
  155 adds in trunk

[EFL][DRT] Enable Regions support
​https://bugs.webkit.org/show_bug.cgi?id=83897

Reviewed by Kenneth Rohde Christiansen.

.:

Default build setting for CSS regions set to on.

• Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

Activating CSS regions by default for EWK views.

• ewk/ewk_view.cpp: Switch CSS regions on by default.

(_ewk_view_priv_new):

LayoutTests:

New baselines for CSS regions, some CSS regions test still in TestExpectations.

• platform/efl-wk2/TestExpectations: fast/regions/css-regions-disabled.html still failing on wk2.
• platform/efl/TestExpectations: Some remaining CSS regions cases still skipped.
• platform/efl/fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Added.
• platform/efl/fast/regions/autoheight-regions-mark-expected.png: Added.
• platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Added.
• platform/efl/fast/regions/autowidth-attachedinvalidregion-expected.txt: Added.
• platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
• platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
• platform/efl/fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
• platform/efl/fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
• platform/efl/fast/regions/element-region-overset-state-expected.txt: Added.
• platform/efl/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
• platform/efl/fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
• platform/efl/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
• platform/efl/fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Added.
• platform/efl/fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Added.
• platform/efl/fast/regions/flexbox-in-region-crash-expected.txt: Added.
• platform/efl/fast/regions/flow-anonymous-children-expected.txt: Added.
• platform/efl/fast/regions/flow-content-basic-expected.png: Added.
• platform/efl/fast/regions/flow-content-basic-expected.txt: Added.
• platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Added.
• platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Added.
• platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
• platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
• platform/efl/fast/regions/flow-region-into-itself-crash-expected.txt: Added.
• platform/efl/fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
• platform/efl/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
• platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
• platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
• platform/efl/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
• platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
• platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
• platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Added.
• platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-display-none-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-text-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added.
• platform/efl/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added.
• platform/efl/fast/regions/get-regions-by-content-expected.txt: Added.
• platform/efl/fast/regions/get-regions-by-content-horiz-bt-expected.txt: Added.
• platform/efl/fast/regions/get-regions-by-content-horiz-tb-expected.txt: Added.
• platform/efl/fast/regions/get-regions-by-content-vert-lr-expected.txt: Added.
• platform/efl/fast/regions/get-regions-by-content-vert-rl-expected.txt: Added.
• platform/efl/fast/regions/get-regions-by-content2-expected.txt: Added.
• platform/efl/fast/regions/hit-test-float-expected.txt: Added.
• platform/efl/fast/regions/hit-test-region-expected.txt: Added.
• platform/efl/fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
• platform/efl/fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Added.
• platform/efl/fast/regions/moved-content-node-crash-expected.txt: Added.
• platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/no-split-line-box-expected.txt: Added.
• platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
• platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
• platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
• platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
• platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
• platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
• platform/efl/fast/regions/parse-incomplete-region-rule-expected.txt: Added.
• platform/efl/fast/regions/parsing-region-style-rule-expected.txt: Added.
• platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
• platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
• platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
• platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
• platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
• platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
• platform/efl/fast/regions/positioned-vrl-in-named-flow-expected.txt: Added.
• platform/efl/fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Added.
• platform/efl/fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Added.
• platform/efl/fast/regions/region-attached-wrong-flow-crash-expected.txt: Added.
• platform/efl/fast/regions/region-element-display-change-expected.txt: Added.
• platform/efl/fast/regions/region-element-display-restriction-expected.txt: Added.
• platform/efl/fast/regions/region-element-dynamic-attach-flow-expected.txt: Added.
• platform/efl/fast/regions/region-element-dynamic-detach-flow-expected.txt: Added.
• platform/efl/fast/regions/region-flow-reattach-crash-expected.txt: Added.
• platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
• platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
• platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
• platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
• platform/efl/fast/regions/region-range-for-box-crash-expected.txt: Added.
• platform/efl/fast/regions/region-style-block-background-color-expected.png: Added.
• platform/efl/fast/regions/region-style-block-background-color-expected.txt: Added.
• platform/efl/fast/regions/region-style-block-background-color2-expected.png: Added.
• platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Added.
• platform/efl/fast/regions/remove-flow-thread-crash-expected.txt: Added.
• platform/efl/fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
• platform/efl/fast/regions/select-in-region-crash-expected.txt: Added.
• platform/efl/fast/regions/set-box-style-in-region-crash-expected.txt: Added.
• platform/efl/fast/regions/svg-root-element-collected-expected.txt: Added.
• platform/efl/fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
• platform/efl/fast/regions/text-region-breaks-expected.txt: Added.
• platform/efl/fast/regions/text-region-split-after-resize-expected.txt: Added.
• platform/efl/fast/regions/text-region-split-expected.txt: Added.
• platform/efl/fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
• platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Added.
• platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
• platform/efl/fast/regions/text-region-split-vertical-expected.txt: Added.
• platform/efl/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
• platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
• platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
• platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
• platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
• platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
• platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
• platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
• platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
• platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
• platform/efl/fast/regions/webkit-flow-parsing-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-event-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-name-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-overset-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
• platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt: Added.
• platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
• platform/efl/fast/regions/webkit-region-rule-expected.txt: Added.

11:42 AM Changeset in webkit [129394] by peter@chromium.org

• 3 edits in trunk/Source/WebCore

Android's mock scrollbars shows up as a difference in layout test results
​https://bugs.webkit.org/show_bug.cgi?id=96382

Reviewed by Adam Barth.

Remove the exceptions made for layout tests in Android's scrollbar theme.
This will make our actual scrollbars show up in layout test pixel results,
bringing the tests closer to what we actually ship.

An important difference with other platforms is that scrollbars do not
take any width on Android, they're rendered on top of the content. Therefore
each test that has a visible scrollbar does not just need a new pixel
result, but will also need a new text result. This will be handled as part
of a larger rebaselining process.

Will be exercised by every layout test that has a scrollbar.

• platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):

• platform/chromium/ScrollbarThemeChromiumAndroid.h:

(ScrollbarThemeChromiumAndroid):

11:39 AM Changeset in webkit [129393] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. [Win] Failing test http/tests/inspector/network/network-xhr-replay.html
​https://bugs.webkit.org/show_bug.cgi?id=96942

• platform/win/Skipped: Skipping a test for the newly added feature.

11:34 AM Changeset in webkit [129392] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
​https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Rob Buis.

Fix a mistake of the commit 11fdc73c7c74bbd736ed4160248ff59636a01864
Trunk has been changed during reviewing that patch.

No new tests, this is to correct a build error.

• platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::getProtectionSpace):

11:32 AM Changeset in webkit [129391] by zandobersek@gmail.com

• 7 edits
  3 adds in trunk

[Gtk] Unskip the Shadow DOM layout tests
​https://bugs.webkit.org/show_bug.cgi?id=90776

Reviewed by Ryosuke Niwa.

Source/WebKit/gtk:

Add a method for enabling the Shadow DOM through RuntimeEnabledFeatures.
The method is called from DumpRenderTree when resetting state.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setShadowDOMEnabled):

• WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

Unskip Shadow DOM layout tests, adding two required baselines and failure
expectations for tests that still fail.

• platform/gtk/TestExpectations:
• platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt: Added.
• platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.

11:29 AM Changeset in webkit [129390] by jsbell@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening - re-enable IDB test that's now passing.
​https://bugs.webkit.org/show_bug.cgi?id=92776

• platform/chromium/TestExpectations:

11:18 AM Changeset in webkit [129389] by mitz@apple.com

• 12 edits in trunk

Source/WebCore: Reverted r129176, the fix for <​http://webkit.org/b/97269>, because it introduced a
discrepancy between line breaking and max width computation.

Rubber-stamped by Anders Carlsson.

• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests: Reveted r129176 and r129185.

Rubber-stamped by Anders Carlsson.

• platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:
• platform/mac/fast/text/emphasis-expected.png:
• platform/mac/fast/text/emphasis-expected.txt:
• platform/mac/fast/text/sticky-typesetting-features-expected.png:
• platform/mac/fast/text/sticky-typesetting-features-expected.txt:
• platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
• platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
• platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
• platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:

11:13 AM Changeset in webkit [129388] by commit-queue@webkit.org

• 24 edits
  8 adds in trunk

Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
​https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <​boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

• Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

• WebCore.exp.in:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

• loader/cache/CachedImage.cpp:
• loader/cache/CachedImage.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

• loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::stillNeedsLoad):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

• loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

• page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

• page/Settings.h:

(Settings):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

• testing/InternalSettings.h:

(Backup):
(InternalSettings):

• testing/InternalSettings.idl:

Source/WebKit2:

• win/WebKit2.def:

LayoutTests:

• fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
• fast/loader/display-image-unset-allows-cached-image-load.html: Added.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
• fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
• fast/loader/resources/image1.html: Added.
• fast/loader/resources/image2.html: Added.
• platform/chromium/permissionclient/image-permissions-expected.txt:
• platform/chromium/permissionclient/image-permissions.html:
• platform/chromium/permissionclient/resources/image.html:
• platform/wk2/Skipped:

10:45 AM Changeset in webkit [129387] by commit-queue@webkit.org

• 10 edits
  1 copy
  1 add
  2 deletes in trunk/Source

[GTK] Implement GraphicsLayer using Clutter
​https://bugs.webkit.org/show_bug.cgi?id=73767

Source/WebCore:

Patch by Joone Hur <​joone.hur@intel.com>, Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

No new tests. This will be covered by pixel tests for Qt/GTK+ accelerated
compositing and 3D transforms.

• GNUmakefile.list.am:
• platform/clutter/GRefPtrClutter.cpp: Removed.
• platform/clutter/GRefPtrClutter.h: Removed.
• platform/graphics/clutter/PlatformClutterLayerClient.h: Added.

(WebCore):
(PlatformClutterLayerClient):
(WebCore::PlatformClutterLayerClient::~PlatformClutterLayerClient):

• platform/graphics/clutter/TransformationMatrixClutter.cpp: Added to convert CoglMatrix to

TransformationMatrix.
(WebCore):
(WebCore::TransformationMatrix::operator CoglMatrix):

• platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit/gtk:

Patch by Joone Hur <​joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

• WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::scrollNonCompositedContents): Added to fix bulid break.
(WebKit):

Source/WebKit2:

Patch by Joone Hur <​joone.hur@intel.com>, Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

Fixed link errors by adding Clutter library and header to WebKit2 build.

• GNUmakefile.am:

Source/WTF:

Patch by Joone Hur <​joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

Add ClutterActor and GraphicsLayerActor to GTypedefs.h.

• wtf/gobject/GTypedefs.h:

10:18 AM Changeset in webkit [129386] by eae@chromium.org

• 2 edits
  1 delete in trunk/LayoutTests

Unreviewed chromium linux/windows rebaseline for r129370.

• platform/chromium-linux/media/video-zoom-controls-expected.txt: Removed.
• platform/chromium-win/media/video-zoom-controls-expected.txt:

10:17 AM Changeset in webkit [129385] by dgrogan@chromium.org

• 11 edits
  5 adds in trunk

Unprefix IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=96548

Reviewed by Adam Barth.

Source/WebCore:

We are largely compatible with the FF implementation and the w3c test
suite submitted by MS. The w3c test suite doesn't yet check
for lack of prefix; this is mostly to signal to devs that we think our
implementation is stable.

This patch uses the new FeatureObserver to get data about prefixed
vs unprefixed usage.

Tests: storage/indexeddb/unprefix-workers.html

storage/indexeddb/unprefix.html

• Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::indexedDB):

• Modules/indexeddb/DOMWindowIndexedDatabase.h:

(DOMWindowIndexedDatabase):

• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/WorkerContextIndexedDatabase.cpp:

(WebCore::WorkerContextIndexedDatabase::indexedDB):

• Modules/indexeddb/WorkerContextIndexedDatabase.h:

(WorkerContextIndexedDatabase):

• Modules/indexeddb/WorkerContextIndexedDatabase.idl:
• bindings/generic/RuntimeEnabledFeatures.h:

Making the auxiliary objects RuntimeEnabled didn't make much sense as
they are useless without the factory, so always enable them.

(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):

• bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

• page/FeatureObserver.h:

LayoutTests:

• storage/indexeddb/resources/unprefix.js: Added.

(test):

• storage/indexeddb/unprefix-expected.txt: Added.
• storage/indexeddb/unprefix-workers-expected.txt: Added.
• storage/indexeddb/unprefix-workers.html: Added.
• storage/indexeddb/unprefix.html: Added.

10:10 AM Changeset in webkit [129384] by wjmaclean@chromium.org

• 34 edits in trunk/LayoutTests

[chromium] Rebaseline gesture highlight test expectation images.
​https://bugs.webkit.org/show_bug.cgi?id=97248

Reviewed by Yuta Kitamura.

Updating image baselines for gesture highlight tests. There are subtle changes in the rendering of
text in the target links, impercetable to the eye but ImageDiff picks them up.

• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png:
• platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png:

9:59 AM Changeset in webkit [129383] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script
​https://bugs.webkit.org/show_bug.cgi?id=96746

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

First step towards the 2D canvas instrumentation from the WebGL injected script module side.
We trace and save all calls that affect the 2D canvas context state and it's resources (Gradient and Pattern)
so that we could replay the context and resources states later.
The 2D canvas context state consists of:

• current transformation matrix
• current default path
• current clipping region (affected by the "clip" command)
• current values of the context attributes (like strokeStyle, fillStyle, etc.)
• a stack of saved drawing states (affected by the "save" and "restore" commands)

• inspector/InjectedScriptCanvasModuleSource.js:

(.):

9:36 AM Changeset in webkit [129382] by rakuco@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Skip a few tests unskipped in r129372 and r129375 that still fail
on the bots.

• platform/efl/TestExpectations:

9:36 AM Changeset in webkit [129381] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Web Inspector: [TextEditor] conditional breakpoint popup not showing up the first time
​https://bugs.webkit.org/show_bug.cgi?id=97442

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

1) The conditional breakpoint popup may not show up the first time we click on the gutter.
This was the case because the popup decoration element would be deleted from the line while
it was being highlighted and appended afterwards. Now we do not remove decorations from the
DOM while highlighting.

2) Also the popup will close itself on any mouse click event, even if it's targeted to the
input box itself. This was due to pointer-events: none; CSS style for the parent element.
Now we just override this style for the input box.

• inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._insertTextNodeBefore):

• inspector/front-end/inspector.css:

(.source-frame-breakpoint-condition):

9:32 AM Changeset in webkit [129380] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] WebKitWebView:is-loading is not updated when the is loaded is started by link clicked navigation action
​https://bugs.webkit.org/show_bug.cgi?id=97458

Reviewed by Xan Lopez.

WebKitWebView:is-loading is set to TRUE when the load is started
by using the API. We want to make sure that both URI and
is-loading are updated before load-started is emitted, so we can
update both right before emitting load-started.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewEmitLoadChanged): Update both uri and is-loading
properties before emitting load-changed signal with
WEBKIT_LOAD_STARTED.
(webkit_web_view_load_uri): Don't call
webkitWebViewSetIsLoading().
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

9:25 AM Changeset in webkit [129379] by rakuco@webkit.org

• 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move some inspector tests from Skipped to TestExpectations with a
proper explanation and related bug report.

• platform/efl/Skipped:
• platform/efl/TestExpectations:

9:19 AM Changeset in webkit [129378] by jsbell@chromium.org

• 5 edits in trunk/LayoutTests

IndexedDB: Modernize some esoteric tests
​https://bugs.webkit.org/show_bug.cgi?id=97368

Reviewed by Tony Chang.

Change the logging - but not the flow or assertions - of some of our
more complex tests, to take advantage of our newer helper functions.

• storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
• storage/indexeddb/open-close-version-expected.txt:
• storage/indexeddb/resources/factory-deletedatabase-interactions.js:
• storage/indexeddb/resources/open-close-version.js:

9:15 AM Changeset in webkit [129377] by eae@chromium.org

• 2 edits
  1 add in trunk/LayoutTests

Unreviewed chromium rebaseline for video-zoom-controls for r129370.

• platform/chromium-linux/media/video-zoom-controls-expected.txt: Added.
• platform/chromium-mac/media/video-zoom-controls-expected.txt:

9:02 AM Changeset in webkit [129376] by rakuco@webkit.org

• 4 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move a test that is failing on both WK1 and WK2 to the common
TestExpectations file.

• platform/efl-wk1/TestExpectations:
• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:

8:58 AM Changeset in webkit [129375] by rakuco@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

• platform/efl/TestExpectations: Unskip passing inspector test.

8:58 AM WebKitGTK/WebKit2Roadmap edited by Martin Robinson

(diff)

8:47 AM Changeset in webkit [129374] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Web Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling enable command
​https://bugs.webkit.org/show_bug.cgi?id=97331

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

We should set CanvasAgent in InstrumentingAgents from enable() command and remove from disable(), instead of doing this in constructor and destructor.

• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):

• inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

• inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

8:46 AM Changeset in webkit [129373] by danakj@chromium.org

• 4 edits in trunk/Source

[chromium] Add setters to WebFilterOperation for IPC pickling
​https://bugs.webkit.org/show_bug.cgi?id=97147

Reviewed by James Robinson.

Source/Platform:

These methods allow us to restore a WebFilterOperation from a blob
of opaque data. The pickling code needs to be able to create an
empty object and then fill in the pieces, so these setters allow it
to do so.

Test: WebFilterOperationsTest.saveAndRestore

• chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createEmptyFilter):
(WebKit::WebFilterOperation::setType):
(WebKit::WebFilterOperation::setAmount):
(WebKit::WebFilterOperation::setDropShadowOffset):
(WebKit::WebFilterOperation::setDropShadowColor):
(WebKit::WebFilterOperation::setMatrix):
(WebKit::WebFilterOperation::setZoomRect):

• chromium/src/WebFilterOperation.cpp:

Source/WebKit/chromium:

• tests/FilterOperationsTest.cpp:

(WebKit):
(WebKit::TEST):

8:44 AM Changeset in webkit [129372] by rakuco@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

• platform/efl/Skipped: Unskip a few inspector-related tests which

are currently passing.

8:38 AM Changeset in webkit [129371] by Patrick Gansterer

• 4 edits in trunk/Source

Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files
​https://bugs.webkit.org/show_bug.cgi?id=97412

Reviewed by Adam Barth.

Source/WebCore:

• css/StylePropertySet.cpp: Removed useless define.

Source/WebKit/chromium:

• src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append().
(WebKit::WebPageSerializerImpl::endTagToString): Ditto.

8:35 AM Changeset in webkit [129370] by eae@chromium.org

• 14 edits
  2 adds in trunk

snapToSize rounds the incorrectly for negative locations
​https://bugs.webkit.org/show_bug.cgi?id=97265

Reviewed by Eric Seidel.

Source/WebCore:

Change snapSizeToPixel to preserve sign for location which
affects rounding.

Test: fast/sub-pixel/snap-negative-location.html

• platform/FractionalLayoutUnit.h:

(WebCore::snapSizeToPixel):

LayoutTests:

Add test for snapSizeToPixel handling of negative locations.
Skipped on platforms that do not enable subpixel layout.

• fast/sub-pixel/snap-negative-location-expected.html: Added.
• fast/sub-pixel/snap-negative-location.html: Added.
• platform/mac-lion/Skipped:
• platform/mac-snowleopard/Skipped:
• platform/mac-wk2/Skipped:
• platform/mac/Skipped:
• platform/qt-4.8/Skipped:
• platform/qt/Skipped:
• platform/win-wk2/Skipped:
• platform/win-xp/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:
• platform/wk2/Skipped:

8:33 AM Changeset in webkit [129369] by peter@chromium.org

• 2 edits in trunk/Websites/bugs.webkit.org

Allow robots to index bugs on Bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=95688

Reviewed by Eric Seidel.

This allows robots to access show_bug.cgi, thus granting them access to
index contents and discussion on WebKit bugs. All other pages, except
for the site index itself, still have indexing disabled.

• robots.txt:

8:09 AM Changeset in webkit [129368] by pfeldman@chromium.org

• 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorOverlay.cpp

Merge 129350 - Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
​https://bugs.webkit.org/show_bug.cgi?id=97446

Reviewed by Alexander Pavlov.

Added 0 check on frame view.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

TBR=​pfeldman@chromium.org
BUG=151559
Review URL: ​https://chromiumcodereview.appspot.com/10967070

8:05 AM Changeset in webkit [129367] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

MIPS: store8 functions added to MacroAssembler.

MIPS store8 functions
​https://bugs.webkit.org/show_bug.cgi?id=97243

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2012-09-24
Reviewed by Oliver Hunt.

Add MIPS store8 functions.

• assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::lhu): New function.
(MIPSAssembler):
(JSC::MIPSAssembler::sb): New function.
(JSC::MIPSAssembler::sh): New function.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::store8): New function.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::store16): New function.

7:53 AM Changeset in webkit [129366] by zandobersek@gmail.com

• 4 edits
  1 delete in trunk

REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=97404

Reviewed by Philippe Normand.

Tools:

Print out the 'didReceiveTitle' information when dumping frame load callbacks.

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewTitleChanged):

LayoutTests:

Remove WebKit2-specific failure expectation and GTK-specific baseline for the test in title.

• platform/gtk-wk2/TestExpectations:
• platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Removed.

7:40 AM Changeset in webkit [129365] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Use unsigned char for bitfield instead of unsigned.
​https://bugs.webkit.org/show_bug.cgi?id=97447

Patch by Jonathan Liu <​net147@gmail.com> on 2012-09-24
Reviewed by Andreas Kling.

Not all compilers will pad an unsigned bitfield to the smallest size.
Use unsigned char instead of unsigned to reduce padding for compilers
that pad to the underlying type.

No new tests. There is already a compile-time assertion.

• css/CSSRule.cpp:

(SameSizeAsCSSRule):

• css/CSSRule.h:

(CSSRule):

7:29 AM BuildingQtOnWindows edited by zeno@webkit.org

Add some information on how to create a sparse-checkout of the WebKit repo. (diff)

7:28 AM Changeset in webkit [129364] by commit-queue@webkit.org

• 68 edits
  6 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97452

Unreviewed EFL rebaseline.

Rebaseline several test cases in the EFL Skipped file
and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

• platform/efl/Skipped:
• platform/efl/fast/table/prepend-in-anonymous-table-expected.png:
• platform/efl/fast/table/prepend-in-anonymous-table-expected.txt:
• platform/efl/fast/text/basic/011-expected.png:
• platform/efl/fast/text/basic/011-expected.txt:
• platform/efl/fast/text/basic/013-expected.png:
• platform/efl/fast/text/basic/013-expected.txt:
• platform/efl/fast/text/bidi-embedding-pop-and-push-same-expected.png:
• platform/efl/fast/text/capitalize-boundaries-expected.png:
• platform/efl/fast/text/capitalize-boundaries-expected.txt:
• platform/efl/fast/text/cg-fallback-bolding-expected.png:
• platform/efl/fast/text/drawBidiText-expected.png:
• platform/efl/fast/text/emphasis-vertical-expected.png:
• platform/efl/fast/text/emphasis-vertical-expected.txt:
• platform/efl/fast/text/fallback-traits-fixup-expected.png:
• platform/efl/fast/text/fallback-traits-fixup-expected.txt:
• platform/efl/fast/text/firstline/001-expected.png:
• platform/efl/fast/text/firstline/001-expected.txt:
• platform/efl/fast/text/firstline/002-expected.png:
• platform/efl/fast/text/firstline/003-expected.png:
• platform/efl/fast/text/format-control-expected.png:
• platform/efl/fast/text/format-control-expected.txt:
• platform/efl/fast/text/hyphens-expected.png:
• platform/efl/fast/text/hyphens-expected.txt:
• platform/efl/fast/text/in-rendered-text-rtl-expected.png:
• platform/efl/fast/text/international/001-expected.png:
• platform/efl/fast/text/international/001-expected.txt:
• platform/efl/fast/text/international/002-expected.png:
• platform/efl/fast/text/international/002-expected.txt:
• platform/efl/fast/text/international/003-expected.png:
• platform/efl/fast/text/international/003-expected.txt:
• platform/efl/fast/text/international/bidi-L2-run-reordering-expected.png:
• platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.png:
• platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.txt:
• platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.png:
• platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.txt:
• platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
• platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
• platform/efl/fast/text/international/bidi-european-terminators-expected.png:
• platform/efl/fast/text/international/bidi-explicit-embedding-expected.png:
• platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
• platform/efl/fast/text/international/bidi-innertext-expected.png:
• platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png:
• platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
• platform/efl/fast/text/international/bidi-listbox-expected.png:
• platform/efl/fast/text/international/bidi-listbox-expected.txt: Added.
• platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
• platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
• platform/efl/fast/text/international/bidi-override-expected.png:
• platform/efl/fast/text/international/bidi-override-expected.txt: Added.
• platform/efl/fast/text/international/rtl-caret-expected.png:
• platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.png:
• platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
• platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
• platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
• platform/efl/fast/text/international/wrap-CJK-001-expected.png:
• platform/efl/fast/text/international/wrap-CJK-001-expected.txt:
• platform/efl/fast/text/midword-break-hang-expected.png:
• platform/efl/fast/text/midword-break-hang-expected.txt:
• platform/efl/fast/text/trailing-white-space-2-expected.png:
• platform/efl/fast/text/trailing-white-space-expected.png:
• platform/efl/fast/text/whitespace/024-expected.png:
• platform/efl/fast/text/whitespace/024-expected.txt:
• platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
• platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
• platform/efl/fast/writing-mode/border-vertical-lr-expected.png:
• platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
• platform/efl/fast/writing-mode/fallback-orientation-expected.png:
• platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
• platform/efl/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
• platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt:
• platform/efl/svg/as-border-image/svg-as-border-image-expected.png: Added.
• platform/efl/svg/as-border-image/svg-as-border-image-expected.txt:

7:24 AM Changeset in webkit [129363] by kareng@chromium.org

• 1 edit in branches/chromium/1271/Source/WebCore/platform/text/LocaleICU.cpp

Merge 129191 - [Platform] There are memory leak in LocaleICU
​https://bugs.webkit.org/show_bug.cgi?id=97289

Reviewed by Kent Tamura.

This patch adds udt_close() calls for medium time format and short
time format data used in LocaleICU class to avoid memory leak.

This memory leak is found by external tool Valgrind and reported in
Chromium bug repositry(​http://crbug.com/151006) with stack trace of
call path of leaked memory.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. External tool such as Valgrind will check this memory leak.

• platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat
and m_shortTimeFormat which have UDateFormat objects.

TBR=​yosin@chromium.org
Review URL: ​https://codereview.chromium.org/10958068

7:17 AM Changeset in webkit [129362] by apavlov@chromium.org

• 2 edits in branches/chromium/1271/Source/WebCore/inspector/front-end

Merge 129348 - Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
​https://bugs.webkit.org/show_bug.cgi?id=97249

Reviewed by Yury Semikhatsky.

Fix regression from r125871.

• inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

• inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentKeyDown):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/10963058

7:10 AM Changeset in webkit [129361] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: don't allow exception in front-end when expanding function scope
​https://bugs.webkit.org/show_bug.cgi?id=97346

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-09-24
Reviewed by Yury Semikhatsky.

A missing guard condition is added.

• inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

7:02 AM Changeset in webkit [129360] by kareng@chromium.org

• 1 edit in branches/chromium/1271/Source/WebCore/Resources/pagepopups/calendarPicker.js

Merge 129094 - REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
​https://bugs.webkit.org/show_bug.cgi?id=97165

Reviewed by Kent Tamura.

The regression was caused because NoFocusRing class was being removed
from then main element inside resetMain().

No new tests. Covered by calendar-picker-appearance.html.

• Resources/pagepopups/calendarPicker.js:

(initialize):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/10956071

7:01 AM Changeset in webkit [129359] by rgabor@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening. Skip new failing test.
​https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-24

• platform/qt/Skipped: Skip inspector-protocol/css-getSupportedCSSProperties.html.

6:51 AM Changeset in webkit [129358] by kareng@chromium.org

• 5 edits in branches/chromium/1271

Merge 128982 - MediaStream API: Rename the RTCIceServer uri parameter to url.
​https://bugs.webkit.org/show_bug.cgi?id=97086

Reviewed by Hajime Morita.

Source/WebCore:

Either the standard has changed or I can't read.
​http://dev.w3.org/2011/webrtc/editor/webrtc.html#dictionary-rtciceserver-members

Existing tests changed to cover this patch.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::parseConfiguration):

LayoutTests:

• fast/mediastream/RTCPeerConnection-expected.txt:
• fast/mediastream/RTCPeerConnection.html:
• fast/mediastream/constructors-expected.txt:
• fast/mediastream/constructors.html:

TBR=​tommyw@google.com
Review URL: ​https://codereview.chromium.org/10969068

6:39 AM Changeset in webkit [129357] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL][WK2] Mark fast/forms/select/select-state-restore.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=97449

Unreviewed EFL gardening.

fast/forms/select/select-state-restore.html sometimes times out on
the WebKit2 EFL debug build bot. Add it to TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

• platform/efl-wk2/TestExpectations:

6:34 AM Changeset in webkit [129356] by anilsson@rim.com

• 13 edits
  2 adds in trunk/Source

[BlackBerry] Add cookie database API
​https://bugs.webkit.org/show_bug.cgi?id=97102

Reviewed by Antonio Gomes.

Source/WebCore:

Add a CookieManager method that takes a list of strings to parse
instead of just one string. Expose CookieParser::parseOneCookie.

Reviewed internally by Otto D. Cheung.

No change in behavior, no new tests.

• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore):

• platform/blackberry/CookieManager.h:
• platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):
(WebCore):

• platform/blackberry/CookieParser.h:

(CookieParser):

Source/WebKit:

Add cookie database file to build system.

Reviewed internally by Otto D. Cheung.

• PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The cookie database is exposed through WebCookieJar, which has only two
methods: cookies() and setCookies().

Also add a new WebString::fromUTF8 overload that takes a const char*
and a length, in order to avoid a strlen call when converting from
other string classes to WebString. This is useful for callers of the
new cookie API when converting cookies to WebString.

Reviewed internally by Otto D. Cheung.

PR 209282

• Api/WebCookieJar.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebCookieJar::WebCookieJar):
(BlackBerry::WebKit::WebCookieJar::cookies):
(BlackBerry::WebKit::WebCookieJar::setCookies):

• Api/WebCookieJar.h: Added.

(WebKit):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::cookieJar):
(WebKit):

• Api/WebPage.h:

(WebKit):

• Api/WebPage_p.h:

(WebKit):
(WebPagePrivate):

• Api/WebString.cpp:

(BlackBerry::WebKit::WebString::fromUtf8):
(WebKit):

• Api/WebString.h:

6:17 AM Changeset in webkit [129355] by vsevik@chromium.org

• 5 edits in trunk

Web Inspector: Open resource dialog has too many false positive matches.
​https://bugs.webkit.org/show_bug.cgi?id=97332

Reviewed by Alexander Pavlov.

Source/WebCore:

Improved open resource dialog filtering to make the amount of false
positive search results less.

• inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem.get var):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem):

LayoutTests:

• inspector/filtered-item-selection-dialog-filtering-expected.txt:
• inspector/filtered-item-selection-dialog-filtering.html:

6:14 AM Changeset in webkit [129354] by commit-queue@webkit.org

• 47 edits
  49 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97448

Unreviewed EFL rebaseline.

Rebaseline several test cases in the Skipped file and unskip
them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

• platform/efl/Skipped:
• platform/efl/svg/as-image/animated-svg-as-image-expected.png: Added.
• platform/efl/svg/as-image/animated-svg-as-image-expected.txt:
• platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
• platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt:
• platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
• platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt:
• platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
• platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
• platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
• platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
• platform/efl/svg/as-image/same-image-two-instances-expected.png: Added.
• platform/efl/svg/as-image/same-image-two-instances-expected.txt:
• platform/efl/svg/as-image/svg-image-change-content-size-expected.png: Added.
• platform/efl/svg/as-image/svg-image-change-content-size-expected.txt:
• platform/efl/svg/batik/masking/maskRegions-expected.png: Added.
• platform/efl/svg/batik/masking/maskRegions-expected.txt:
• platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
• platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
• platform/efl/svg/css/path-gradient-stroke-shadow-expected.png: Added.
• platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt:
• platform/efl/svg/dom/css-transforms-expected.png: Added.
• platform/efl/svg/dom/css-transforms-expected.txt: Added.
• platform/efl/svg/hixie/error/012-expected.png: Added.
• platform/efl/svg/hixie/error/012-expected.txt:
• platform/efl/svg/hixie/error/013-expected.png: Added.
• platform/efl/svg/hixie/error/013-expected.txt:
• platform/efl/svg/hixie/mixed/003-expected.png: Added.
• platform/efl/svg/hixie/mixed/003-expected.txt:
• platform/efl/svg/hixie/mixed/004-expected.png: Added.
• platform/efl/svg/hixie/mixed/004-expected.txt:
• platform/efl/svg/hixie/mixed/005-expected.png: Added.
• platform/efl/svg/hixie/mixed/005-expected.txt:
• platform/efl/svg/hixie/mixed/006-expected.png: Added.
• platform/efl/svg/hixie/mixed/006-expected.txt:
• platform/efl/svg/hixie/mixed/007-expected.png: Added.
• platform/efl/svg/hixie/mixed/007-expected.txt:
• platform/efl/svg/hixie/mixed/008-expected.png: Added.
• platform/efl/svg/hixie/mixed/008-expected.txt:
• platform/efl/svg/hixie/mixed/009-expected.png: Added.
• platform/efl/svg/hixie/mixed/009-expected.txt:
• platform/efl/svg/hixie/mixed/010-expected.png: Added.
• platform/efl/svg/hixie/mixed/010-expected.txt:
• platform/efl/svg/hixie/mixed/011-expected.png: Added.
• platform/efl/svg/hixie/mixed/011-expected.txt:
• platform/efl/svg/hixie/perf/007-expected.png: Added.
• platform/efl/svg/hixie/perf/007-expected.txt:
• platform/efl/svg/hixie/processing-model/003-expected.png: Added.
• platform/efl/svg/hixie/processing-model/003-expected.txt:
• platform/efl/svg/hixie/processing-model/004-expected.png: Added.
• platform/efl/svg/hixie/processing-model/004-expected.txt:
• platform/efl/svg/hixie/rendering-model/003-expected.png: Added.
• platform/efl/svg/hixie/rendering-model/003-expected.txt:
• platform/efl/svg/hixie/rendering-model/004-expected.png: Added.
• platform/efl/svg/hixie/rendering-model/004-expected.txt:
• platform/efl/svg/hixie/text/003-expected.png: Added.
• platform/efl/svg/hixie/text/003-expected.txt:
• platform/efl/svg/in-html/by-reference-expected.png: Added.
• platform/efl/svg/in-html/by-reference-expected.txt:
• platform/efl/svg/in-html/circle-expected.png: Added.
• platform/efl/svg/in-html/circle-expected.txt:
• platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
• platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt:
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
• platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
• platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
• platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
• platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt:
• platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
• platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt:
• platform/efl/svg/transforms/svg-css-transforms-expected.png: Added.
• platform/efl/svg/transforms/svg-css-transforms-expected.txt:
• platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
• platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
• platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
• platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
• platform/efl/svg/wicd/rightsizing-grid-expected.png: Added.
• platform/efl/svg/wicd/rightsizing-grid-expected.txt:
• platform/efl/svg/wicd/test-rightsizing-a-expected.png: Added.
• platform/efl/svg/wicd/test-rightsizing-a-expected.txt:
• platform/efl/svg/wicd/test-rightsizing-b-expected.png: Added.
• platform/efl/svg/wicd/test-rightsizing-b-expected.txt:
• platform/efl/svg/wicd/test-scalable-background-image1-expected.png: Added.
• platform/efl/svg/wicd/test-scalable-background-image1-expected.txt:
• platform/efl/svg/wicd/test-scalable-background-image2-expected.png: Added.
• platform/efl/svg/wicd/test-scalable-background-image2-expected.txt:

6:01 AM Changeset in webkit [129353] by commit-queue@webkit.org

• 10 edits in trunk/Source/WebCore

Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
​https://bugs.webkit.org/show_bug.cgi?id=97203

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

Implements wrapping a 2D canvas context through the injected canvas module script facility.

• bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

• bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

• inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):

• inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

• inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

• inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

• inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

5:31 AM Changeset in webkit [129352] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

[EFL][WK2] Change the install path for libewk2UnitTestInjectedBundleSample.so.
​https://bugs.webkit.org/show_bug.cgi?id=97302

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

libewk2UnitTestInjectedBundleSample.so file is created under the
Source directory.
Change install directory for the library to under the build directory.

• PlatformEfl.cmake:
• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample):

5:20 AM Changeset in webkit [129351] by apavlov@chromium.org

• 1 edit in branches/chromium/1271/Source/WebCore/inspector/front-end/inspector.css

Merge 129117 - Web Inspector: [Elements] Word wrap disablement in the DOM tree broken
​https://bugs.webkit.org/show_bug.cgi?id=97185

Reviewed by Pavel Feldman.

Restored the effective "white-space: nowrap" for the tree elements.

• inspector/front-end/inspector.css:

(.nowrap):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/10975002

5:14 AM Changeset in webkit [129350] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
​https://bugs.webkit.org/show_bug.cgi?id=97446

Reviewed by Alexander Pavlov.

Added 0 check on frame view.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

5:09 AM Changeset in webkit [129349] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unskip proper shadow dom test case
​https://bugs.webkit.org/show_bug.cgi?id=97445

Unreviewed EFL gardening.

Skip again fast/dom/shadow/shadowdom-for-object-without-shadow.html
and unskip fast/dom/shadow/shadowdom-for-object-only-shadow.html
instead.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

• platform/efl/TestExpectations:

4:55 AM Changeset in webkit [129348] by apavlov@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
​https://bugs.webkit.org/show_bug.cgi?id=97249

Reviewed by Yury Semikhatsky.

Fix regression from r125871.

• inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

• inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentKeyDown):

4:53 AM Changeset in webkit [129347] by apavlov@chromium.org

• 5 edits in trunk/Source/WebCore

Web Inspector: Disable persistence of master switches in the "Overrides" settings tab
​https://bugs.webkit.org/show_bug.cgi?id=97440

Reviewed by Yury Semikhatsky.

Disables enforcement of device metrics, geolocation, and device orientation overrides on Web Inspector start.

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore):

• inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._onMetricsCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._onDeviceOrientationOverrideCheckboxClicked):

• inspector/front-end/UserAgentSupport.js:

(WebInspector.UserAgentSupport):
(WebInspector.UserAgentSupport.prototype.toggleDeviceMetricsOverride):
(WebInspector.UserAgentSupport.prototype.toggleGeolocationPositionOverride):
(WebInspector.UserAgentSupport.prototype.toggleDeviceOrientationOverride):

• inspector/front-end/externs.js:

4:38 AM Changeset in webkit [129346] by commit-queue@webkit.org

• 13 edits
  8 adds in trunk

Web Inspector: implement testing harness for pure protocol tests.
​https://bugs.webkit.org/show_bug.cgi?id=90675

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-09-24
Reviewed by Yury Semikhatsky.

.:

Added export symbols required for Gtk+ to support the Inspector Protocol
testing harness.

• Source/autotools/symbols.filter:

Source/WebCore:

Implementing the testing harness as the APIs of Internals object not
only reduced platform specific patching of DRTs but also minimized the
the effort required to open up the new dummy inspector Frontend.

The openDummyInspectorFrontend method will return the handle to newly
created DOMWindow. This DOMWindow object can be utilized inside the test
case to communicate using postMessage WebAPI.

The newly created DOMWindow will host the protocol-test.html which
will seed the necessary JS libraries to communicate with the
InspectorBackend.

Test: inspector-protocol/css-getSupportedCSSProperties.html

• WebCore.exp.in:
• WebCore.gypi:
• inspector/InspectorClient.h:

(InspectorClient):

• testing/Internals.cpp:

(InspectorFrontendClientDummy):
(WebCore::InspectorFrontendClientDummy::~InspectorFrontendClientDummy):
(WebCore):
(WebCore::InspectorFrontendClientDummy::InspectorFrontendClientDummy):
(InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::~InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
(WebCore::Internals::consoleMessageArgumentCounts):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):

• testing/Internals.h:

(WebCore):
(Internals):

• testing/Internals.idl:

Source/WebKit2:

Adding the export symbol definitions required on Apple Windows and WinCairo
ports to support Inspector Protocol testing harness.

• win/WebKit2.def:
• win/WebKit2CFLite.def:

LayoutTests:

Adding the resources required for the dummy frontend page to load minimal
frontend. These resources provide the mechanism to talk to the Inspector Backend.

Adding the inspector-protocol folder to host the relevant test cases
utilizing the inspector protocol test harness. Added an example test
case for getting all supported CSS properties using the inspector
protocol and searching for a particular property being supported.

• http/tests/inspector-protocol: Added.
• http/tests/inspector-protocol/resources: Added.
• http/tests/inspector-protocol/resources/InspectorTest.js: Added.

(InspectorTest.sendCommand):
(WebInspector.dispatchMessageFromBackend):
(InspectorTest.log):
(InspectorTest.completeTest):

• http/tests/inspector-protocol/resources/protocol-test.html: Added.
• http/tests/inspector-protocol/resources/protocol-test.js: Added.

(log):
(closeTest):
(runTest):

• inspector-protocol: Added.
• inspector-protocol/css-getSupportedCSSProperties-expected.txt: Added.
• inspector-protocol/css-getSupportedCSSProperties.html: Added.

4:19 AM Changeset in webkit [129345] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-1.10.0

Tagging the WebKitGTK+ 1.10.0 release

4:08 AM Changeset in webkit [129344] by keishi@webkit.org

• 5 edits in trunk

REGRESSION(r127727): Calendar picker focus doesn't loop in calendar-picker.html
​https://bugs.webkit.org/show_bug.cgi?id=97183

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug calendar-picker.html. The page popup behaves fine because
this code is only necessary in calendar-picker.html where the focus can
move outside of the picker because we are just using an iframe.

No new tests. Added tests to calendar-picker-key-operations.html.

• Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype.attachTo):
(CalendarPicker.prototype._handleBodyKeyDown):

LayoutTests:

• fast/forms/date/calendar-picker-key-operations-expected.txt:
• fast/forms/date/calendar-picker-key-operations.html:

4:07 AM Changeset in webkit [129343] by Simon Hausmann

• 4 edits in trunk

[Qt] Fix build with latest Qt 5

Reviewed by Tor Arne Vestbø.

.:

Define MODULE_BASE_DIR before loading qt_module.prf, which now calls syncqt. MODULE_BASE_DIR is
passed as last parameter (source dir) to syncqt now, so set it to the directory that contains
sync.profile.

• Source/api.pri:

Tools:

The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
remove them from default_pre.prf once we're past Qt 5 beta2.

• qmake/mkspecs/features/default_pre.prf:

4:03 AM Changeset in webkit [129342] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-1.10

Unreviewed. Update NEWS and configure.ac for 1.10.0 release

3:19 AM Changeset in webkit [129341] by caseq@chromium.org

• 3 edits in trunk/Source/WebCore

Unreviewed follow-up to r129336 -- fixed closure compiler warnings.

• inspector/front-end/HAREntry.js:
• inspector/front-end/TimelineModel.js:

3:15 AM Changeset in webkit [129340] by yurys@chromium.org

• 19 edits
  12 deletes in trunk/LayoutTests

Unreviewed. Update pixel results for 18 tests on Win.

• platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Removed.
• platform/chromium-win-xp/fast/invalid/residual-style-expected.txt: Removed.
• platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Removed.
• platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
• platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Removed.
• platform/chromium-win-xp/fast/transforms/shadows-expected.png: Removed.
• platform/chromium-win-xp/ietestcenter/css3/text/textshadow-002-expected.png: Removed.
• platform/chromium-win-xp/ietestcenter/css3/text/textshadow-010-expected.png: Removed.
• platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Removed.
• platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
• platform/chromium-win-xp/tables/mozilla/bugs/bug56563-expected.png: Removed.
• platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Removed.
• platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
• platform/chromium-win/fast/css/shadow-multiple-expected.png:
• platform/chromium-win/fast/invalid/residual-style-expected.txt:
• platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
• platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
• platform/chromium-win/fast/text/stroking-decorations-expected.png:
• platform/chromium-win/fast/text/stroking-expected.png:
• platform/chromium-win/fast/transforms/shadows-expected.png:
• platform/chromium-win/fast/writing-mode/english-lr-text-expected.png:
• platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png:
• platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png:
• platform/chromium-win/svg/css/composite-shadow-text-expected.png:
• platform/chromium-win/svg/css/shadow-changes-expected.png:
• platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
• platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
• platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
• platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:

2:39 AM Changeset in webkit [129339] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [TextEditor] Line numbers out of sync after closing breakpoint condition editor
​https://bugs.webkit.org/show_bug.cgi?id=96510

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Vsevolod Vlasov.

Sync line heights on adding/removing decorations.

• inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorGutterChunk):
(WebInspector.TextEditorGutterChunk.prototype.addDecoration):
(WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorGutterChunk.prototype._createRow):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):

2:38 AM Changeset in webkit [129338] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] Invalid featuring of INPUT_TYPE_COLOR in test_ewk2_view.
​https://bugs.webkit.org/show_bug.cgi?id=97430

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

The tests of ewk_view_context_get and ewk_view_feed_touch_event are not related to
INPUT_TYPE_COLOR. These tests should be moved to outside of INPUT_TYPE_COLOR block.

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

2:38 AM Changeset in webkit [129337] by yurys@chromium.org

• 4 edits in trunk/Source

Unreviewed, rolling out r122243.
​http://trac.webkit.org/changeset/129243
​https://bugs.webkit.org/show_bug.cgi?id=97441

WebFilterOperationsTest.saveAndRestore added in the change is failing.

Source/Platform:

• chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):

Source/WebKit/chromium:

• tests/FilterOperationsTest.cpp:

2:23 AM Changeset in webkit [129336] by caseq@chromium.org

• 8 edits
  2 adds in trunk

Web Inspector: support saving HAR with resources content
​https://bugs.webkit.org/show_bug.cgi?id=97341

Reviewed by Vsevolod Vlasov.

Source/WebCore:

• add WebInspector.HARWriter that writes HAR with content to a stream;
• replace Save all as HAR with Save all with Content as HAR in network's panel context menu;
• remove entries for copying/saving of individual request items to reduce clutter in context menu;
• a drive-by fix of an exception when invoking context menu not on a network item;

Test: http/tests/inspector/network/har-content.html

• English.lproj/localizedStrings.js:
• inspector/front-end/FileUtils.js:
• inspector/front-end/HAREntry.js:

(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._creator):
(WebInspector.HARWriter):
(WebInspector.HARWriter.prototype.write):
(WebInspector.HARWriter.prototype._onContentAvailable):
(WebInspector.HARWriter.prototype._beginWrite):
(WebInspector.HARWriter.prototype._writeNextChunk):

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createStatusBarItems):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._exportAll.openCallback):
(WebInspector.NetworkLogView.prototype._exportAll):

LayoutTests:

• moved StringOutputStream to inspector-test.js for reuse;
• added test for HARWriter and response content in HAR.

• http/tests/inspector/inspector-test.js:

(initialize_InspectorTest):
(initialize_InspectorTest.):

• http/tests/inspector/network/har-content-expected.txt: Added.
• http/tests/inspector/network/har-content.html: Added.
• inspector/timeline/timeline-test.js:

(initialize_Timeline):

2:15 AM Changeset in webkit [129335] by yurys@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed. Updated test expectations for webaudio/biquad-getFrequencyResponse.html

• platform/chromium/TestExpectations:

1:56 AM Changeset in webkit [129334] by commit-queue@webkit.org

• 29 edits
  30 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97437

Unreviewed EFL rebaseline.

Rebaseline several test cases from EFL Skipped list
and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

• platform/efl/Skipped:
• platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
• platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
• platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
• platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
• platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
• platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
• platform/efl/svg/batik/text/textOnPath-expected.png: Added.
• platform/efl/svg/batik/text/textOnPath-expected.txt:
• platform/efl/svg/batik/text/textProperties2-expected.png: Added.
• platform/efl/svg/batik/text/textProperties2-expected.txt:
• platform/efl/svg/hixie/perf/004-expected.png: Added.
• platform/efl/svg/hixie/perf/005-expected.png: Added.
• platform/efl/svg/hixie/perf/006-expected.png: Added.
• platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
• platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
• platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
• platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
• platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
• platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
• platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
• platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
• platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
• platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
• platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
• platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
• platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
• platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:

1:34 AM Changeset in webkit [129333] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unskip test cases that started passing after r129303
​https://bugs.webkit.org/show_bug.cgi?id=97433

Unreviewed EFL gardening.

Unskip several ref tests that are marked as unexpected
passes after r129303. r129303 fixed detection of ref
tests that are passing unexpectedly.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

• platform/efl/TestExpectations:

1:34 AM Changeset in webkit [129332] by thakis@chromium.org

• 1 edit
  2 deletes in trunk/Source/WebCore

[chromium] Remove BitLockerSkia. It's apparently not used.
​https://bugs.webkit.org/show_bug.cgi?id=97434

Reviewed by Kent Tamura.

• platform/graphics/skia/BitLockerSkia.cpp: Removed.
• platform/graphics/skia/BitLockerSkia.h: Removed.

1:10 AM MinimalFileStorageAlternate edited by mjs@apple.com

(diff)

12:53 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos

(diff)

12:49 AM MinimalFileStorageAlternate created by mjs@apple.com

12:47 AM Changeset in webkit [129331] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-1.10

Merge r126439 - [GTK] The tarball should be called webkitgtk-x.x.x.tar.xz
​https://bugs.webkit.org/show_bug.cgi?id=94572

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-08-23
Reviewed by Carlos Garcia Campos.

Change the name of the tarball to match the name of the library
and to disambiguate it from other WebKit ports.

• configure.ac: Update the tarball name.

12:41 AM Changeset in webkit [129330] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

Skeleton implementation of dialog.showModal()
​https://bugs.webkit.org/show_bug.cgi?id=97425

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-09-24
Reviewed by Kent Tamura.

Source/WebCore:

This adds a basic implementation of showModal(), so it later can be
used to test the top layer, once it is implemented. The main features
of showModal(), modality and the top layer, are not yet implemented.

Test: fast/dom/HTMLDialogElement/dialog-show-modal.html

• html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::showModal): The same as show(), but throws an error in the cases specified in the spec.
(WebCore):

• html/HTMLDialogElement.h:

(HTMLDialogElement):

• html/HTMLDialogElement.idl:

LayoutTests:

Add a test that showModal() opens the dialog or throws an error in the cases specified in the spec.

• fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt: Added.
• fast/dom/HTMLDialogElement/dialog-show-modal.html: Added.

12:24 AM Changeset in webkit [129329] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebCore

[EFL] Regression after r129328
​https://bugs.webkit.org/show_bug.cgi?id=97429

Unreviewed, rolling out r129328.

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

Sep 23, 2012:

11:28 PM Changeset in webkit [129328] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebCore

[EFL] Duplicated RenderThemeEfl creation for same page
​https://bugs.webkit.org/show_bug.cgi?id=88391

Reviewed by Gyuyoung Kim.

Other ports return one or two RenderTheme regardless of page.
But, WebKit/Efl can create different theme for each page and
themeForPage creates new RenderTheme whenever it is called with page.
So more than one RenderTheme can be created for a page.

This patches checks whether page already has RenderTheme not to create new
RenderTheme for same page.

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

11:27 PM Changeset in webkit [129327] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add setting to toggle developer extensions
​https://bugs.webkit.org/show_bug.cgi?id=96974

Patch by Seokju Kwon <​seokju.kwon@samsung.com> on 2012-09-23
Reviewed by Kenneth Rohde Christiansen.

This is required to allow the user to inspect pages. (Web inspector)

• UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):

• UIProcess/API/efl/ewk_settings.h:
• UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

9:39 PM Changeset in webkit [129326] by keishi@webkit.org

• 8 edits
  2 adds in trunk

Add suggestionPicker to CalendarPicker
​https://bugs.webkit.org/show_bug.cgi?id=97201

Reviewed by Kent Tamura.

.:

• ManualTests/forms/calendar-picker.html: Added tests for SuggestionPicker.

Source/WebCore:

This adds the suggestionPicker to CalendarPicker. It is not available yet as a datalist UI but it can be used inside ManualTests/forms/calendar-picker.html.

No new tests. Suggestion Picker can be tested in ManualTests/forms/calendar-picker.html.

• Resources/pagepopups/calendarPicker.js:

(initialize):
(openSuggestionPicker):

• Resources/pagepopups/pickerCommon.js:

(enclosingNodeOrSelfWithClass):

• Resources/pagepopups/suggestionPicker.css: Added.

(.suggestion-list):
(.suggestion-list-entry):
(.suggestion-list-entry:focus):
(.suggestion-list-entry:focus .label):
(.suggestion-list-entry .content):
(.suggestion-list-entry .title):
(.suggestion-list-entry .label):
(.measuring-width .suggestion-list-entry .label):
(.suggestion-list .separator):

• Resources/pagepopups/suggestionPicker.js: Added.

(SuggestionPicker):
(SuggestionPicker.validateConfig):
(SuggestionPicker.prototype.cleanup):
(SuggestionPicker.prototype._setColors): Creates css rules that sets highlight colors.
(SuggestionPicker.prototype._createSuggestionEntryElement): Creates an entry that when selected submits the value.
(SuggestionPicker.prototype._createActionEntryElement): Creates an entry that causes an action. (e.x. "Other...")
(SuggestionPicker.prototype._measureMaxContentWidth): Temporarily left align everything to measure the width.
(SuggestionPicker.prototype._fixWindowSize):
(SuggestionPicker.prototype._layout):
(SuggestionPicker.prototype.selectEntry):
(SuggestionPicker.prototype._handleEntryClick):
(SuggestionPicker.prototype._findFirstVisibleEntry):
(SuggestionPicker.prototype._findLastVisibleEntry):
(SuggestionPicker.prototype._handleBodyKeyDown):
(SuggestionPicker.prototype._handleEntryMouseOver):
(SuggestionPicker.prototype._handleMouseOut):

• WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

• src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args.

8:47 PM Changeset in webkit [129325] by ggaren@apple.com

• 2 edits in trunk/Source/JavaScriptCore

PutScopedVar should not be marked as clobbering the world
​https://bugs.webkit.org/show_bug.cgi?id=97416

Reviewed by Filip Pizlo.

No performance change.

PutScopedVar doesn't have arbitrary side-effects, so it shouldn't be marked
as such.

• dfg/DFGNodeType.h:

(DFG):

8:35 PM Changeset in webkit [129324] by ggaren@apple.com

• 2 edits in trunk/Source/JavaScriptCore

2012-09-23 Geoffrey Garen <​ggaren@apple.com>

I accidentally the whole 32-bit :(.

Unbreak the DFG in 32-bit with the 32-bit path I forgot in my last patch.

• dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):

8:33 PM Changeset in webkit [129323] by kling@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r128239): Mutable ElementAttributeData leak their Attribute vectors.
<​http://webkit.org/b/97423>

Reviewed by Anders Carlsson.

r128239 added a WTF::deleteOwnedPtr() override for ElementAttributeData*, but ElementAttributeData is
a ref-counted object. Fixed this by overriding deref() instead to call the appropriate subclass destructor.

• dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::deref):

8:28 PM Changeset in webkit [129322] by keishi@webkit.org

• 3 edits
  2 copies in branches/chromium/1271

Merge 129106 - REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=97166

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug in r127727 so arrow keys work properly.

Test: fast/forms/date/calendar-picker-key-operations.html

• Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):

LayoutTests:

• fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
• fast/forms/date/calendar-picker-key-operations.html: Added.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/10968055

7:29 PM Changeset in webkit [129321] by yosin@chromium.org

• 1 edit in branches/chromium/1271/Source/WebCore/html/TimeInputType.cpp

Merge 129095 - [Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
​https://bugs.webkit.org/show_bug.cgi?id=97169

Reviewed by Kent Tamura.

This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.

• html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):

TBR=​yosin@chromium.org
Review URL: ​https://codereview.chromium.org/10957058

6:16 PM Changeset in webkit [129320] by tkent@chromium.org

• 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=96352

Reviewed by Adam Barth.

We have some crash reports with the following stack:

• HistoryItem::shouldDoSameDocumentNavigationTo.
• WebFrameImpl::loadHistoryItem ...

We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/10959062

6:02 PM Changeset in webkit [129319] by commit-queue@webkit.org

• 20 edits in trunk/Source

Fix build warnings : -Wunused-parameter, -Wparentheses, -Wuninitialized.
​https://bugs.webkit.org/show_bug.cgi?id=97306

Patch by Byungwoo Lee <​bw80.lee@gmail.com> on 2012-09-23
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Fix build warning about -Wunused-parameter on MachineStackMarker.cpp,
LLIntSlowPaths.cpp, DatePrototype.cpp, Options.cpp by using
UNUSED_PARAM() macro or remove parameter name.

• heap/MachineStackMarker.cpp:

(JSC::pthreadSignalHandlerSuspendResume):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::entryOSR):

• runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

• runtime/Options.cpp:

(JSC::computeNumberOfGCMarkers):

Source/WebCore:

Fix build warning about -Wunused-parameter on ImageBufferCairo.cpp,
ImageDecoder.h by using ASSERT_UNUSED() macro.

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::encodeImage):

• platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::rgbColorProfile):
(WebCore::ImageDecoder::inputDeviceColorProfile):

Source/WebKit/efl:

Fix build warning about -Wunused-parameter on FrameLoaderClientEfl.cpp
by using ASSERT_UNUSED() macro.
Fix build warning aboug -Wparentheses on ewk_frame.cpp by adding
additional brace for the assign statement.

• WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):

• ewk/ewk_frame.cpp:

(ewk_frame_resources_location_get):

Source/WebKit2:

Fix build warning about -Wunused-parameter on Connection.cpp,
WKEinaSharedString.cpp, ewk_view_loader_client.cpp, WebPage.cpp by
using ASSERT_UNUSED() macro or removing parameter name.
Fix build warning about -Wuninitialized on WebEventFactory.cpp by
continueing the loop at the default switch case not to use the
uninitialized variable.

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):

• Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

• UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::WKEinaSharedString):

• UIProcess/API/efl/ewk_view_loader_client.cpp:

(didSameDocumentNavigationForFrame):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):

Source/WTF:

Fix build warning about -Wunused-parameter on FastMalloc.cpp,
OSAllocatorPosix.cpp by using UNUSED_PARAM() macro.
Fix header including order of FastMalloc.cpp.

• wtf/FastMalloc.cpp:

(WTF::fastMallocSize):

• wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

5:57 PM Changeset in webkit [129318] by kling@webkit.org

• 4 edits in trunk/Source/WebCore

Enable ElementAttributeData sharing for non-HTML elements.
<​http://webkit.org/b/97413>

Reviewed by Anders Carlsson.

Use the whole qualified tag name when creating the ElementAttributeData cache key
instead of just the localName(). This allows sharing and caching of attribute data
for non-HTML elements and makes the code a little cleaner.

• dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

Enable the ElementAttributeData sharing path for non-HTML elements.

• dom/ElementAttributeData.h:

Make immutableAttributeArray() public so Document can call it instead of getting
the raw data address from a const_cast'ed attributeItem(0).

• dom/Document.cpp:

(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheEntry::ImmutableAttributeDataCacheEntry):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):

Let the immutable attribute data cache use a QualifiedName/attributes key
instead of the AtomicString/attributes we were using before. We still grab the
existingHash() from the QualifiedName::localName() and use that for the actual
HashMap key.

4:37 PM Changeset in webkit [129317] by barraclough@apple.com

• 3 edits
  3 adds in trunk

Sorting a non-array creates propreties (spec-violation)
​https://bugs.webkit.org/show_bug.cgi?id=25477

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

We're just calling get() to get properties, which is converting missing properties to
undefined. Hole values should be retained, and moved to the end of the array.

• runtime/ArrayPrototype.cpp:

(JSC::getOrHole):

• Helper function, returns JSValue() instead of undefined for missing properties.

(JSC::arrayProtoFuncSort):

• Implemented per 15.4.4.11, see comments above.

LayoutTests:

Added test cases.

• fast/js/array-sort-sparse-expected.txt: Added.
• fast/js/array-sort-sparse.html: Added.
• fast/js/script-tests/array-sort-sparse.js: Added.

(testSort):

3:48 PM Changeset in webkit [129316] by ggaren@apple.com

• 9 edits in trunk/Source/JavaScriptCore

CSE for access to closure variables (get_/put_scoped_var)
​https://bugs.webkit.org/show_bug.cgi?id=97414

Reviewed by Oliver Hunt.

I separated loading a scope from loading its storage pointer, so we can
CSE the storage pointer load. Then, I copied the global var CSE and adjusted
it for closure vars.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute): Renamed GetScopeChain => GetScope to
reflect renames from a few weeks ago.

Added a case for the storage pointer load, similar to object storage pointer load.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Added an independent node for
the storage pointer.

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getScopeLoadElimination):
(JSC::DFG::CSEPhase::getScopeRegistersLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE): Copied globalVarLoad/StoreElimination
and adapted the same logic to closure vars.

• dfg/DFGNode.h:

(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scope):
(Node):

• dfg/DFGNodeType.h:

(DFG): GetScopedVar and GetGlobalVar are no longer MustGenerate. I'm not
sure why they ever were. But these are simple load operations so, if they're
unused, they're truly dead.

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Updated for renames and split-out
node for getting the storage pointer.

10:37 AM Changeset in webkit [129315] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Measure the usage of the "X-WebKit-CSP" header in the hopes of dropping the prefix completely.
​https://bugs.webkit.org/show_bug.cgi?id=97408

Patch by Mike West <​mkwst@chromium.org> on 2012-09-23
Reviewed by Adam Barth.

We plan on landing the unprefixed header in webkit.org/b/96765 once the
spec moves to CR. Though we plan to use it for experimentation in the
near future, we'll want to drop the prefixed header completely at some
point in the future. Starting to measure its usage now will give us a
good baseline when we start contemplating that decision.

No new functionality, so no new tests.

• page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):

• page/FeatureObserver.h: