Timeline



Sep 27, 2012:

11:18 PM Changeset in webkit [129854] by yosin@chromium.org
  • 4 edits in trunk/Source/WebCore

[Forms] Adding placeholder feature to DateTimeNumericElement, and update its existing subclasses.
​https://bugs.webkit.org/show_bug.cgi?id=97863

Reviewed by Kent Tamura.

This patch is a part of preparation of implementing multiple fields
date/time input UI.

This patch introduces placeholder feature to DateTimeNumericElement
to display date format guide in field, e.g. displaying "dd/mm/yyyy".

Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement): Changed to pass placeholder class to base class.
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement): ditto
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement): ditto
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement): ditto

  • html/shadow/DateTimeNumericFieldElement.cpp: Removed no more needed static function displaySizeOfNumbre().

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement): Changed to add new parameter to take placeholder.
(WebCore::DateTimeNumericFieldElement::visibleValue): Changed to use m_placholder.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Changed to add a member variable m_placholder to hold placholder to DateTimeNumbericElement class.

11:10 PM Changeset in webkit [129853] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

Empty URL gets through to acceptNavigationRequest()
​https://bugs.webkit.org/show_bug.cgi?id=97076

Reviewed by George Staikos.

Invalid URLs in iframe src results in an empty URL in platform request, we should reject
such URL as early as we identify it.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

10:21 PM Changeset in webkit [129852] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Make sure Localizer class is not copyable
​https://bugs.webkit.org/show_bug.cgi?id=97857

Reviewed by Kentaro Hara.

We don't intent Localizer obejcts are copyable.

  • platform/text/Localizer.h:

(Localizer): Add WTF_MAKE_NONCOPYABLE.

10:15 PM Changeset in webkit [129851] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

Delete some unused code. Found by -Wunused-function.
​https://bugs.webkit.org/show_bug.cgi?id=97858

Reviewed by Anders Carlsson.

No intended behavior change.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):

  • platform/graphics/chromium/CrossProcessFontLoading.mm:
  • platform/graphics/skia/GraphicsContextSkia.cpp:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore):

10:03 PM Changeset in webkit [129850] by pilgrim@chromium.org
  • 23 edits in trunk/Source/WebKit/chromium

[Chromium] Update WebVector.h references
​https://bugs.webkit.org/show_bug.cgi?id=97855

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/ApplicationCacheHost.cpp:
  • src/AudioDestinationChromium.h:
  • src/AutofillPopupMenuClient.cpp:
  • src/CompositionUnderlineBuilder.h:
  • src/CompositionUnderlineVectorBuilder.h:
  • src/ContextMenuClientImpl.cpp:
  • src/ExternalPopupMenu.cpp:
  • src/FrameLoaderClientImpl.cpp:
  • src/PlatformSupport.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebDragData.cpp:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WebHistoryItem.cpp:
  • src/WebIDBKeyPath.cpp:
  • src/WebIDBMetadata.cpp:
  • src/WebNode.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebPageSerializerImpl.cpp:
  • src/WebTextCheckingCompletionImpl.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
9:27 PM Changeset in webkit [129849] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] StringCache::v8ExternalString() can return a stale persistent handle
​https://bugs.webkit.org/show_bug.cgi?id=97767

Reviewed by Adam Barth.

For details, see the Chromium bug: ​http://code.google.com/p/chromium/issues/detail?id=151902

StringCache::v8ExternalString() can return a stale persistent handle
in the following scenario:

(1) Assume that StringImpl A with value "foo" is in m_stringCache.
(2) StringImpl B with value "foo" is accessed. At this point, m_lastStringImpl
points to B, and m_lastV8String points to B's handle.
(3) A minor GC is triggered and a weak callback is called back for StringImpl A.
At this point, "foo" is removed from m_stringCache. A's handle is disposed.
However, m_lastV8String is not cleared because m_lastStringImpl (i.e. StringImpl B)
is not equal to StringImpl A. As a result, m_lastV8String points to a stale
persistent handle.
(4) The persistent handle is eventually reused in V8 and made weak again.
(5) StringImpl B with value "foo" is accessed. Then StringCache::v8ExternalString()
returns the stale persistent handle, which is already used for another purpose.

To solve the problem, we need to clear m_stringImpl and m_lastV8String when any
string wrapper is disposed. Specifically, we need to change the code like this:

static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void* parameter)
{

StringImpl* stringImpl = static_cast<StringImpl*>(parameter);
V8PerIsolateData::current()->stringCache()->remove(stringImpl);
wrapper.Dispose();
stringImpl->deref();

}

void StringCache::remove(StringImpl* stringImpl)
{

m_stringCache.remove(stringImpl);
if (m_lastStringImpl.get() == stringImpl) { Remove this line.

m_lastStringImpl = 0;
m_lastV8String.Clear();

}

}

Note: Removing the line might be stronger than is needed. Instead of removing
the line, we can just replace the line with 'if (m_lastV8String == wrapper)'.
However, just in case (for correctness), I'd prefer removing the line.
Given that GC won't happen so frequently, clearing the cache in every weak callback
won't affect performance.

No tests because it depends on the GC behavior and I couldn't reproduce the bug.

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::remove):

9:18 PM Changeset in webkit [129848] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix after r129824.

  • DOM/resources/dom-perf.js:

(runBenchmarkSuite):

9:16 PM Changeset in webkit [129847] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Remove unused features and reduce code duplications in PerfTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=97852

Reviewed by Kentaro Hara.

Made the following refactoring changes:

  • Remove PerfTestRunner.info since it's never used.
  • Moved the js heap/malloc related functions up to where they belong.
  • Moved the initialization of _callsPerIteration, _test, and -description into _start, and stopped initializing _runFunction and _doneFunction since both test times now use _test object.
  • Made _measureTimeOnce and _measureRunsPerSecondOnce return the measured value instead of calling ignoreWarmUpAndLog and _runLoop to share the code; they're now called in _measureRunsPerSecondOnce.
  • resources/runner.js:

(PerfTestRunner.storeHeapResults): Moved.
(PerfTestRunner.getUsedMallocHeap): Moved.
(PerfTestRunner.getUsedJSHeap): Moved.
(PerfTestRunner.getAndPrintMemoryStatistics): Moved.
(PerfTestRunner._scheduleNextMeasurementOrNotifyDone): Renamed from _runLoop. Calls
ignoreWarmUpAndLog and schedules the next call.
(PerfTestRunner._measureTimeOnce): Renamed from _runner.
(PerfTestRunner._start): Renamed from initAndStartLoop.
(PerfTestRunner.measureTime):
(PerfTestRunner.runPerSecond):
(PerfTestRunner._measureRunsPerSecondOnce): Renamed from _measureRunsPerSecondOnce.
(PerfTestRunner._perSecondRunnerIterator):

9:04 PM Changeset in webkit [129846] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Update comment in WebFrameClient to point to new userAgent() function
​https://bugs.webkit.org/show_bug.cgi?id=97854

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • public/WebFrameClient.h:

(WebFrameClient):

8:57 PM Changeset in webkit [129845] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused PlatformSupport reference in ChromeClientImpl
​https://bugs.webkit.org/show_bug.cgi?id=97853

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/ChromeClientImpl.cpp:
8:51 PM Changeset in webkit [129844] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

CSSComputedStyleDeclaration::getPropertyCSSValue() triggering unnecessary relayouts and style recalcs
​https://bugs.webkit.org/show_bug.cgi?id=97760

Reviewed by Andreas Kling.

Currently getPropertyCSSValue() (which is also used to implement the more common getPropertyValue())
calls Document::updateLayoutIgnorePendingStylesheets() unconditionally. However only a few properties
are actually layout dependent, making many of these relayouts unnecessary. Moreover, triggering full
style recalc is also often unnecessary as the current node may already have valid style even if some
other parts of the tree require recalc.

  • Only trigger relayouts for layout dependent properties.
  • Trigger style recalc only if the style of the current element or its ancestors is dirty.


This is a significant (several percent) progression on some real world web content based page loading
benchmarks.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependentProperty):
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/StyleResolver.h:

(WebCore::StyleResolver::hasViewportDependentMediaQueries):

  • dom/Document.cpp:

(WebCore::Document::hasPendingStyleRecalc):

Renamed for consistency.

(WebCore::Document::hasPendingForcedStyleRecalc):
(WebCore):

  • dom/Document.h:

(Document):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

8:41 PM Changeset in webkit [129843] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in DraggedIsolatedFileSystem
​https://bugs.webkit.org/show_bug.cgi?id=97851

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
8:15 PM Changeset in webkit [129842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
​https://bugs.webkit.org/show_bug.cgi?id=95360

Patch by Andrew Lo <​anlo@rim.com> on 2012-09-27
Reviewed by Simon Fraser.

Remove unnecessary code introduced in ​http://trac.webkit.org/changeset/129808.

No new tests because it's already covered by fast/animation/request-animation-frame-iframe2.html.

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):

8:14 PM Changeset in webkit [129841] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in DateTimeChooserImpl
​https://bugs.webkit.org/show_bug.cgi?id=97847

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/DateTimeChooserImpl.cpp:
8:05 PM Changeset in webkit [129840] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in FontCacheSkia
​https://bugs.webkit.org/show_bug.cgi?id=97850

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/graphics/skia/FontCacheSkia.cpp:
8:03 PM Changeset in webkit [129839] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in ColorChooserUIController
​https://bugs.webkit.org/show_bug.cgi?id=97849

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/ColorChooserUIController.cpp:
8:01 PM Changeset in webkit [129838] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in PaintAggregator
​https://bugs.webkit.org/show_bug.cgi?id=97848

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/painting/PaintAggregator.cpp:
7:59 PM Changeset in webkit [129837] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid
​https://bugs.webkit.org/show_bug.cgi?id=97846

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
7:57 PM Changeset in webkit [129836] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in SocketStreamHandle
​https://bugs.webkit.org/show_bug.cgi?id=97843

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/SocketStreamHandle.cpp:
7:55 PM Changeset in webkit [129835] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in AudioDestinationChromium
​https://bugs.webkit.org/show_bug.cgi?id=97845

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/AudioDestinationChromium.cpp:
7:40 PM Changeset in webkit [129834] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in ClipboardChromium
​https://bugs.webkit.org/show_bug.cgi?id=97840

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/chromium/ClipboardChromium.cpp:
7:37 PM Changeset in webkit [129833] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused PlatformSupport reference in WebFrameImpl
​https://bugs.webkit.org/show_bug.cgi?id=97842

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/WebFrameImpl.cpp:
7:36 PM Changeset in webkit [129832] by tkent@chromium.org
  • 12 edits in trunk

DateTimeNumericFieldElement should use Localizer functions.
​https://bugs.webkit.org/show_bug.cgi?id=97318

Reviewed by Hajime Morita.

Source/WebCore:

Source/WebCore:

Use Localizer functions instead of functions in LocalizedNumber to test
i18n behavior. This affects only layout tests because
Document::getLocalizer() always returns a Localizer for the browser
locale.

To obtain a Localizer object for <input>'s locale from a deep shadow node,
we add localeIdentifier() function to DateTimeFieldElement::FieldOwner
and DateTimeEditElement::EditControlOwner interfaces.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-localization.html

  • html/shadow/DateTimeFieldElement.h:

(FieldOwner): Add localeIdentifier callback.
(DateTimeFieldElement): Add localeIdentifier().

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::localeIdentifier):
Added. Returns FieldOwner::localeIdentifier if m_fieldOwner is available.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Declare localizer().

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::localizer):
Returns a Localizer for DateTimeFieldElement::localeIdentifier()
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Use localizer().
(WebCore::DateTimeNumericFieldElement::value): Use localizer().

  • html/shadow/DateTimeEditElement.h:

(EditControlOwner): Add localeIdentifier() callback.
(DateTimeEditElement):
Declare localeIdentifier(), which implements FieldOwner::localeIdentifier().

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::localeIdentifier):
Added. Returns EditControlOwner::localeIdentifier if m_editControlOwner is available.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare localeIdentifier(),
which implements EditControlOwner::localeIdentifier().

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::localeIdentifier):
Added. Returns <input>'s inherited locale identifier.

LayoutTests:

  • platform/chromium/TestExpectations:

Need rebaseline for non-Mac results.

  • platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt:

Update "ar" locale result.

7:16 PM Changeset in webkit [129831] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement reviewer feedback that I missed on bug 95930.
​https://bugs.webkit.org/show_bug.cgi?id=97752

Reviewed by Alexey Proskuryakov.

This patch updates the indentation of function parameters in a few places,
and reserves an appropriate amount of space when using StringBuilder.

  • css/CSSBasicShapes.cpp:

(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore::CSSBasicShapeRectangle::serializeResolvingVariables):
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
(WebCore::CSSBasicShapeEllipse::serializeResolvingVariables):
(WebCore::buildPolygonString):

  • css/Rect.h:

(WebCore::Rect::serializeResolvingVariables):
(WebCore::Quad::serializeResolvingVariables):
(WebCore::Quad::generateCSSString):

6:43 PM Changeset in webkit [129830] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Put initializeHostCallReturnValue() behind #if ENABLE(JIT).
Fixes non JIT builds.
​https://bugs.webkit.org/show_bug.cgi?id=97838.

Reviewed by John Sullivan.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

6:23 PM FeatureFlags edited by yosin@chromium.org
Remove INPUT_TYPE_TIME_MULTIPLE_FIELDS (diff)
6:16 PM FeatureFlags edited by yosin@chromium.org
Add INPUT_MULTIPLE_FIELDS_UI (diff)
6:16 PM Changeset in webkit [129829] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r129823.
​http://trac.webkit.org/changeset/129823
​https://bugs.webkit.org/show_bug.cgi?id=97837

Cause a bunch of pixel failures on Chrome Linux that look like
real regressions (Requested by ojan on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-27

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph):

5:51 PM Changeset in webkit [129828] by andersca@apple.com
  • 6 edits
    2 deletes in trunk/Source/WebKit

Get rid of more unused WK1 plug-in code
​https://bugs.webkit.org/show_bug.cgi?id=97835

Reviewed by Mark Rowe.

Source/WebKit:

Remove WebNetscapeDeprecatedFunctions.c and WebNetscapeDeprecatedFunctions.h from the Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Plugins/WebBasePluginPackage.mm:

Remove JavaCFMPluginFilename #define.

(-[WebBasePluginPackage initWithPath:]):
#ifndef ppc is always true now.

(-[WebBasePluginPackage isJavaPlugIn]):
Remove JavaCFMPluginFilename.

  • Plugins/WebNetscapeDeprecatedFunctions.c: Removed.
  • Plugins/WebNetscapeDeprecatedFunctions.h: Removed.

Remove functions that nobody calls anymore.

  • Plugins/WebNetscapePluginPackage.mm:

Remove +initialize call, the earliest version of Shockwave we now support doesn't
require us to have a valid CurApRefNum file anymore.

(-[WebNetscapePluginPackage _tryLoad]):
Remove more unused code.

  • Plugins/WebPluginDatabase.h:

Remove CFM from a comment.

5:50 PM Changeset in webkit [129827] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixed CallFrameClosure::resetCallFrame() to use the valid
range of argument index values.
​https://bugs.webkit.org/show_bug.cgi?id=97836.

Reviewed by Gavin Barraclough.

  • interpreter/CallFrame.h:

(ExecState):

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::resetCallFrame):

5:46 PM Changeset in webkit [129826] by aelias@chromium.org
  • 11 edits
    2 copies
    2 adds in trunk

[chromium] DumpRenderTree support for software compositing
​https://bugs.webkit.org/show_bug.cgi?id=96853

Reviewed by James Robinson.

This adds software compositor support to DumpRenderTree. The only
thing needed is a minimal OutputSurfaceSoftware that holds a
viewport-sized bitmap. Then, I added virtual test suite
platform/chromium/virtual/softwarecompositing -- a mirror of the
compositing/ directory with --enable-software-compositing, and
expectations for not yet supported tests.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::softwareCompositingEnabled):
(TestShell::setSoftwareCompositingEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.cpp:

(WebKit::WebViewHostOutputSurface::create3d):
(WebKit):
(WebKit::WebViewHostOutputSurface::createSoftware):
(WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
(WebKit::WebViewHostOutputSurface::bindToClient):
(WebKit::WebViewHostOutputSurface::surfaceSoftware):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.h:

(WebKit):
(WebViewHostOutputSurface):

  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.

(WebKit):
(WebKit::WebViewHostSoftwareOutputDevice::lockForWrite):
(WebKit::WebViewHostSoftwareOutputDevice::unlockForWrite):
(WebKit::WebViewHostSoftwareOutputDevice::lockForRead):
(WebKit::WebViewHostSoftwareOutputDevice::unlockForRead):
(WebKit::WebViewHostSoftwareOutputDevice::viewportChanged):

  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.

(WebKit):
(WebViewHostSoftwareOutputDevice):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/chromium/virtual/softwarecompositing/README.txt: Added.
5:31 PM Changeset in webkit [129825] by pilgrim@chromium.org
  • 12 edits
    2 copies in trunk/Source

[Chromium] Remove screen-related functions from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97474

Reviewed by Adam Barth.

Source/Platform:

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

  • Platform.gypi:
  • chromium/public/WebScreenInfo.h: Added.

(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.
Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

  • WebCore.gypi:
  • platform/Widget.h:
  • platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.

(PageClientChromium):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

  • public/WebScreenInfo.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::screenInfo):
(WebKit):

  • src/ChromeClientImpl.h:

(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):

  • src/PlatformSupport.cpp:

(WebCore):

5:26 PM Changeset in webkit [129824] by rniwa@webkit.org
  • 16 edits in trunk/PerformanceTests

PerfTestRunner.run should take an object
​https://bugs.webkit.org/show_bug.cgi?id=97743

Reviewed by Kentaro Hara.

Rename PerfTestRunner.run to PerfTestRunner.measureTime and make it take an object instead of
5 arguments. Also get rid of PerfTestRunner._loopsPerRun since it's no longer used (it's always 1).

  • CSS/StyleSheetInsert.html:
  • DOM/resources/dom-perf.js:
  • Layout/floats_100_100.html:
  • Layout/floats_100_100_nested.html:
  • Layout/floats_20_100.html:
  • Layout/floats_20_100_nested.html:
  • Layout/floats_2_100.html:
  • Layout/floats_2_100_nested.html:
  • Layout/floats_50_100.html:
  • Layout/floats_50_100_nested.html:
  • Parser/html-parser.html:
  • Parser/html5-full-render.html:
  • SVG/SvgCubics.html:
  • SVG/SvgHitTesting.html:
  • resources/runner.js:
5:13 PM Changeset in webkit [129823] by bashi@chromium.org
  • 4 edits in trunk/Source/WebCore

[Chromium] FontHarfBuzz.cpp should not use drawTextOnPath().
​https://bugs.webkit.org/show_bug.cgi?id=97676

Reviewed by Tony Chang.

Use drawPosText() if possible for vertical text.
Use drawTextOnPath() only if the font doesn't have vhea/vmtx table.

No new tests. No change in behavior on LayoutTests.
Confirmed improvement in vertical text positioning using ipafont and Skia r5677.

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::drawVerticalTextWithBrokenIdeographs): Added.
(WebCore):
(WebCore::Font::drawGlyphs): Draw vertical text by drawPosText() in a similar manner of FontSkia.cpp.
(WebCore::Font::drawComplexText): Disable setVerticalText(). Complex path doesn't support it now.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint): Call setVertialText().

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph): Disable setVerticalText() if the font doesn't have vertical metrics.

5:07 PM Changeset in webkit [129822] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r129806.
​http://trac.webkit.org/changeset/129806
​https://bugs.webkit.org/show_bug.cgi?id=97831

Broke windows build due to missing header (Requested by jsbell
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-27

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):

5:05 PM Changeset in webkit [129821] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebKit/chromium: Remove unused methods from Chromium WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=95254

Patch by Nasko Oskov <​nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.

Removing methods, which are no longer in use.

  • public/WebFrame.h:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):

  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebFrameImpl):

Tools: Move DumpRenderTree to use newer version of the name method of
WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
​https://bugs.webkit.org/show_bug.cgi?id=95254

Patch by Nasko Oskov <​nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.

The WebFrame name() method is removed and replaced by better named
uniqueName() method, so DRT needs to be updated to use this new version.
Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
one more parameter, which had to be added in DRT.

  • DumpRenderTree/chromium/TestShell.cpp:

(dumpFramesAsText):
(dumpFramesAsPrintedText):
(dumpFrameScrollPosition):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::unableToImplementPolicyWithError):
(WebViewHost::willCheckAndDispatchMessageEvent):
(WebViewHost::printFrameDescription):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

5:02 PM Changeset in webkit [129820] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Delete test that no longer exists.

  • platform/chromium/TestExpectations:
4:57 PM Changeset in webkit [129819] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Remove the clang pragmas to disable warnings in Noncopyable.h
​https://bugs.webkit.org/show_bug.cgi?id=97826

Reviewed by Beth Dakin.

Warnings about C++11 extensions are already disabled project-wide now so there's no need
to keep these pragmas.

  • wtf/Noncopyable.h:
4:51 PM Changeset in webkit [129818] by leviw@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp

Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line
​https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

  • rendering/RenderText.cpp:

(WebCore::RenderText::setTextWithOffset):

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/10993072

4:39 PM Changeset in webkit [129817] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
​https://bugs.webkit.org/show_bug.cgi?id=97741

Reviewed by Antti Koivisto.

Reset the content in the iframe in each run so that the runtime from each run follows a normal distribution.
We can cleanup this code once my patch to replace the argument list of run by an object is landed.

  • CSS/StyleSheetInsert.html:
4:35 PM Changeset in webkit [129816] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Unreviewed. Minor appearance tweaks after r129813.

  • resources/results-template.html:
4:30 PM Changeset in webkit [129815] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

4:25 PM Changeset in webkit [129814] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r129186): Pressing enter at the end of a line deletes the line
​https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

  • rendering/RenderText.cpp:

(WebCore::RenderText::setTextWithOffset):

4:23 PM Changeset in webkit [129813] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Results page should warn about time-dependent distributions
​https://bugs.webkit.org/show_bug.cgi?id=97818

Reviewed by Ojan Vafai.

Add a simple linear regression analysis on results page to detect time-dependent distributions.
We add a warning sign (inline SVG) when the regression gave us a slope of at least 0.01 and a R2 of at least 0.6.
Also added time-series graphs per run under the bar graphs so that humans can manually inspect them.

A nice follow up would be to add some normality test (e.g. Shapiro-Wilk) to detect bi-modal distributions
but we probably need to restructure the code to run it asynchronously since normality tests are slow.

  • resources/results-template.html:
4:05 PM Changeset in webkit [129812] by Lucas Forschler
  • 4 edits in tags/Safari-537.12/Source/WebKit2

Merge r129810.

3:48 PM Changeset in webkit [129811] by Lucas Forschler
  • 1 copy in tags/Safari-537.12

New Tag.

3:37 PM Changeset in webkit [129810] by Beth Dakin
  • 4 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=97823
Need to bump the WKBundlePageLoaderClient version after the addition of didLayout

Reviewed by Brady Eidson.

Bump the version.

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
3:33 PM Changeset in webkit [129809] by jsbell@chromium.org
  • 1 edit
    8 copies
    2 moves
    20 adds
    4 deletes in trunk/LayoutTests

IndexedDB: Split up setVersion and deleteDatabase sequencing tests
​https://bugs.webkit.org/show_bug.cgi?id=97482

Reviewed by Tony Chang.

Final chapter in the trilogy of webkit.org/b/97051 and webkit.org/b/97368 -
split up some complex multi-part tests so they are easier to understand and manage.

  • Split open-close-setversion -> setversion-*
  • Split factory-deletedatabase-interactions -> deletedatabase-*
  • storage/indexeddb/deletedatabase-blocked-expected.txt: Added.
  • storage/indexeddb/deletedatabase-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt: Added.
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt: Added.
  • storage/indexeddb/deletedatabase-delayed-by-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/deletedatabase-not-blocked-expected.txt: Added.
  • storage/indexeddb/deletedatabase-not-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Removed.
  • storage/indexeddb/open-close-version-expected.txt: Removed.
  • storage/indexeddb/resources/deletedatabase-blocked.js: Added.
  • storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js: Added.
  • storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js: Added.
  • storage/indexeddb/resources/deletedatabase-not-blocked.js: Added.
  • storage/indexeddb/resources/factory-deletedatabase-interactions.js: Removed.
  • storage/indexeddb/resources/open-close-version.js: Removed.
  • storage/indexeddb/resources/setversion-blocked-by-versionchange-close-in-blocked.js: Added.
  • storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js: Added.
  • storage/indexeddb/resources/setversion-blocked.js: Added.
  • storage/indexeddb/resources/setversion-blocks-open.js: Added.
  • storage/indexeddb/resources/setversion-blocks-setversion.js: Added.
  • storage/indexeddb/resources/setversion-not-blocked.js: Added.
  • storage/indexeddb/setversion-blocked-by-versionchange-close-expected.txt: Added.
  • storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked-expected.txt: Added.
  • storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/setversion-blocked-by-versionchange-close.html: Renamed from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/setversion-blocked-expected.txt: Added.
  • storage/indexeddb/setversion-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/setversion-blocks-open-expected.txt: Added.
  • storage/indexeddb/setversion-blocks-open.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/setversion-blocks-setversion-expected.txt: Added.
  • storage/indexeddb/setversion-blocks-setversion.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/setversion-not-blocked-expected.txt: Added.
  • storage/indexeddb/setversion-not-blocked.html: Renamed from LayoutTests/storage/indexeddb/open-close-version.html.
3:25 PM Changeset in webkit [129808] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
​https://bugs.webkit.org/show_bug.cgi?id=95360

Patch by Andrew Lo <​anlo@rim.com> on 2012-09-27
Reviewed by Simon Fraser.

Source/WebCore:

DisplayRefreshMonitorManager::ensureMonitorForClient currently only adds the DisplayRefreshMonitorClient
to the appropriate DisplayRefreshMonitor when a new monitor is created.
It should also do so when it finds an existing monitor.

Test: fast/animation/request-animation-frame-iframe2.html

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):

LayoutTests:

Add a new test which does requestAnimationFrame in both a sub-frame and
main-frame, and checks that both were executed.

  • fast/animation/request-animation-frame-iframe2-expected.txt: Added.
  • fast/animation/request-animation-frame-iframe2.html: Added.
  • fast/animation/script-tests/request-animation-frame-subframe.html:

Remove element parameter from window.webkitRequestAnimationFrame.

3:15 PM Changeset in webkit [129807] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium debug build fix.

Two fixes makes one breakage

​http://trac.webkit.org/changeset/129785
​http://trac.webkit.org/changeset/129798

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArguments):

3:03 PM Changeset in webkit [129806] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Optimize encodeString/decodeString
​https://bugs.webkit.org/show_bug.cgi?id=97794

Reviewed by Tony Chang.

Optimize string encoding/decoding, which showed up as a CPU hot spot during profiling.
The backing store uses big-endian ordering of 16-bit code unit strings, so a memcopy
isn't sufficient, but the code used StringBuilder::append() character-by-character
and custom byte-swapping which was slow.

Ran a test w/ DumpRenderTree (to avoid multiprocess overhead) taking a 10k character string
and putting it 20k times and getting it 20k times. On my test box, mean time before the
patch was 8.2s, mean time after the patch was 4.6s.

Tested by Chromium's webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*String*'

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):

3:01 PM Changeset in webkit [129805] by abarth@webkit.org
  • 3 edits in trunk/Tools

Add webkit_unit_tests to the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=97814

Patch by Julie Parent <​jparent@chromium.org> on 2012-09-27
Reviewed by Dirk Pranke.

webkit_unit_tests run on the same bots as test_shell_tests.

  • TestResultServer/static-dashboards/builders.js:

(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

2:55 PM Changeset in webkit [129804] by fmalita@chromium.org
  • 2 edits in trunk/Tools

[Perftest] PerfTestRunner exception when using nested git checkouts
​https://bugs.webkit.org/show_bug.cgi?id=97796

Reviewed by Ryosuke Niwa.

In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
instantiate per-repository SCM objects when collecting revision information.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_results_dict):

2:54 PM Changeset in webkit [129803] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix 32-bit build.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]):
Add back the architecture check that i accidentally.

2:50 PM TestExpectations edited by dpranke@chromium.org
remove comments about ORWT and Skipped files (diff)
2:44 PM Changeset in webkit [129802] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
​https://bugs.webkit.org/show_bug.cgi?id=97805

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2012-09-27
Reviewed by Alexey Proskuryakov.

Add support for handling a string as modifier argument to keyDown().
This support has already been added to other ports, so implementing
this on Mac too, to be consistent with the other ports.

  • DumpRenderTree/mac/EventSendingController.mm:

(modifierFlags):
(buildModifierFlags):

2:36 PM Changeset in webkit [129801] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit/mac

Remove support for CFM plug-ins in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=97822

Reviewed by Mark Rowe.

I'm pretty sure that CFM style plug-ins haven't been used for the last ten years or so,
so it's safe to remove them (especially since they're PPC only).

  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage closeResourceFile:]):
(-[WebNetscapePluginPackage _initWithPath:]):
(-[WebNetscapePluginPackage _tryLoad]):
(-[WebNetscapePluginPackage _unloadWithShutdown:]):

  • Plugins/WebPluginDatabase.mm:

(PluginPackageCandidates::PluginPackageCandidates):
(PluginPackageCandidates::update):
(PluginPackageCandidates::bestCandidate):
(PluginPackageCandidates):

2:33 PM Changeset in webkit [129800] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on Mac debug
and is passing on all the other bots.

  • platform/chromium/TestExpectations:
2:25 PM Changeset in webkit [129799] by pilgrim@chromium.org
  • 6 edits in trunk/Source

[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97817

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarStateToThemeState):
(WebCore):
(WebCore::ScrollbarThemeChromiumMac::paint):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/PlatformSupport.cpp:

(WebCore):

2:03 PM Changeset in webkit [129798] by arv@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix issue with ClassList which was hitting an assert in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=97820

Reviewed by Ojan Vafai.

​http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.

No new tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArguments):

  • html/ClassList.h:
1:59 PM Changeset in webkit [129797] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip a couple of passing tests.

  • platform/efl/TestExpectations:
1:49 PM Changeset in webkit [129796] by pdr@google.com
  • 7 edits
    2 adds in trunk

Rewrite multithreaded filter job dispatching
​https://bugs.webkit.org/show_bug.cgi?id=97500

Reviewed by Dean Jackson.

Source/WebCore:

This patch solves the problem of splitting up images into subregions for multithreaded
filters. This fixes the way we partition the image array into equal-sized chunks.
If we have an array of length N and want to split it into K chunks, we calculate:

int jobSize = N / K; integer division, so this is floored
int jobSizeExtra = N % K; modulus produces the remainder

We then split the array into jobSizeExtra number of jobs with size jobSize + 1
and (K - jobSizeExtra) number of jobs with size jobSize. This pattern
is used in each of the 5 filters in this patch.

This patch primarily fixes an error in FEMorphology::platformApply where
the image array was partitioned into (1 + (N / K)) pieces with the last job
taking the remainder. Unfortunately, this can cause overruns in the 2nd-to-last job.
Consider N = 2373 and K = 64 jobs. Job 0 would take indices 0...38, job 1 would take
38...76, etc. Unfortunately the 62nd job takes 2356...2394 which overruns.

To prevent similar issues elsewhere this patch updates all of the filters
to use the same pattern as FEMorphology.

Test: svg/filters/feMorphology-crash.html

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApply):

Some special care is taken for Gaussian Blur because there is an
extraHeight parameter for sampling outside the image's dimensions.
This means we use the same partitioning algorithm but add
extraHeight padding on the lower and upper bounds.

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

Add test that shows the morphology filter no longer crashes.
Note: this is only reliably reproducable when run with libgmalloc.

  • svg/filters/feMorphology-crash-expected.txt: Added.
  • svg/filters/feMorphology-crash.html: Added.
1:26 PM Changeset in webkit [129795] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

Flakey compositing tests and another flakey dom/shadow test.

  • platform/chromium/TestExpectations:
1:21 PM Changeset in webkit [129794] by dpranke@chromium.org
  • 2 edits in trunk/Tools

efl wk2 bots weren't looking at platform/wk2/TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=97815

Unreviewed, build fix.

Should clean up this logic later so that we're just using the
implementation in base ...

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._search_paths):
(EflPort.expectations_files):

12:57 PM Changeset in webkit [129793] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

Marking fast/dom/shadow/base-in-shadow-tree.html as timeout flakey.

  • platform/chromium/TestExpectations:
12:48 PM Changeset in webkit [129792] by pilgrim@chromium.org
  • 8 edits in trunk/Source

[Chromium] Move UNIX-specific theme functions out of PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=96516

Reviewed by Adam Barth.

Call WebThemeEngine functions and use WebThemeEngine enums
directly from the new Platform/ directly; remove all
intermediate functions and enums and conversion functions from
PlatformSupport.
Part of a refactoring series; see tracking bug 82948.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:

(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::getWebThemeState):
(WebCore):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

12:44 PM Changeset in webkit [129791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
​https://bugs.webkit.org/show_bug.cgi?id=97745

Patch by Helder Correia <Helder Correia> on 2012-09-27
Reviewed by Martin Robinson.

In LayerTreeCoordinator::adoptImageBackingStore(), there is a
PLATFORM(QT) code path to check for identical images, but nothing is
done for Cairo, which results in the occurrence of avoidable resource
allocations.

The issue happens in e.g. ​http://www.webkit.org/blog-files/leaves/,
where there are many leaves flying around while they're produced out of
only four bitmaps.

This patch uses pointers to cairo_surface_t's as the key to the hashmap
that caches bitmaps. This can be safely done since we own the references.
We artificially increment the surface references in adoptImageBackingStore()
and decrement them in releaseImageBackingStore().

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

12:33 PM Changeset in webkit [129790] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Stop using dispatch_get_current_queue
​https://bugs.webkit.org/show_bug.cgi?id=97806
<rdar://problem/12379094>

Reviewed by Mark Rowe.

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueueAndFunction::WorkQueueAndFunction):
(WorkQueueAndFunction):
(WorkQueue::executeFunction):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
Keep track of the associated work queue so we can get it in WorkQueue::executeFunction.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::setUpTerminationNotificationHandler):
We don't care about which queue the termination notification is delivered on since we only want to call
waitpid on the child pid so we can just use a global queue.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):
Use dispatch_get_main_queue here.

12:24 PM Changeset in webkit [129789] by mario@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] IconDatabase: Add a way to notify when icon data is available
​https://bugs.webkit.org/show_bug.cgi?id=63945

Rubber stamped by Anders Carlsson.

Update version of WKIconDatabaseClient and API traits.

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKIconDatabase.h:
12:24 PM Changeset in webkit [129788] by dpranke@chromium.org
  • 17 edits
    1 move
    18 deletes in trunk/LayoutTests

merge Skipped file entries into TestExpectations, remove Skipped files
​https://bugs.webkit.org/show_bug.cgi?id=97750

Reviewed by Ojan Vafai.

Now that old-run-webkit-tests will skip any tests listed in
TestExpectations files, there is no need to have both Skipped
files and TestExpectations files. This change merges all of the
entries in the Skipped files into the TestExpectations files and
removes the Skipped files.

Subsequent changes will remove support for Skipped files from
both new-run-webkit-tests and old-run-webkit-tests to
complete the project.

  • platform/efl/Skipped: Removed.
  • platform/efl/TestExpectations:
  • platform/mac-lion/Skipped: Removed.
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/Skipped: Removed.
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/Skipped: Removed.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/Skipped: Removed.
  • platform/mac/TestExpectations:
  • platform/qt-4.8/Skipped: Removed.
  • platform/qt-4.8/TestExpectations:
  • platform/qt-5.0-wk1/Skipped: Removed.
  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/Skipped: Removed.
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0/Skipped: Removed.
  • platform/qt-5.0/TestExpectations:
  • platform/qt-arm/Skipped: Removed.
  • platform/qt-arm/TestExpectations:
  • platform/qt-linux/Skipped: Removed.
  • platform/qt-mac/Skipped: Removed.
  • platform/qt-mac/TestExpectations:
  • platform/qt-win/Skipped: Removed.
  • platform/qt/Skipped: Removed.
  • platform/qt/TestExpectations:
  • platform/win-wk2/Skipped: Removed.
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/Skipped: Removed.
  • platform/win-xp/TestExpectations:
  • platform/win/Skipped: Removed.
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations: Renamed from LayoutTests/platform/wincairo/Skipped.
  • platform/wk2/Skipped: Removed.
  • platform/wk2/TestExpectations:
12:23 PM Changeset in webkit [129787] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

[CSS Exclusions] Rename RenderStyle::wrapShapeInside/Outside to shapeInside/Outside
​https://bugs.webkit.org/show_bug.cgi?id=97707

Patch by Bear Travis <​betravis@adobe.com> on 2012-09-27
Reviewed by Antti Koivisto.

The exclusions specification has renamed wrap-shape-inside and wrap-shape-outside
to shape-inside and shape-outside. We should rename the getter/setter functions
in RenderStyle, and update the derived variable and function names accordingly.
For more information, see: ​http://dev.w3.org/csswg/css3-exclusions/#declaring-shapes

Covered by existing tests. No new functionality.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::StyleBuilder::StyleBuilder):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::computeShapeSize):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::exclusionShapeInsideInfo):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

12:04 PM Changeset in webkit [129786] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

ApplicationCacheStorage does not optimally handle 8 bit strings
​https://bugs.webkit.org/show_bug.cgi?id=97733

Reviewed by Alexey Proskuryakov.

Added 8 bit string paths.

No functional change, therefore no new tests.

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::urlHostHash):
(WebCore::ApplicationCacheStorage::store):
(WebCore::parseHeader):
(WebCore::parseHeaders):

12:03 PM Changeset in webkit [129785] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium debug build fix.

ASSERT contains an inequality of unmatched types. A cast should do the trick.

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArguments):

12:00 PM Changeset in webkit [129784] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: make warning about missing BUG identifiers per-port configurable
​https://bugs.webkit.org/show_bug.cgi?id=97751

Reviewed by Ojan Vafai.

Prior to this change linting TestExpectations files (checking their style)
would raise warnings if lines were missing a BUG modifier, even
though such a modifier is actually optional in the syntax. As we
migrate the entries over from the Skipped files, these warnings
will generate a lot of noise, and it's not yet clear that we
actually want to require the modifiers on all ports.

So, this change makes this per-port configurable so that they
will generate warnings in the Chromium TestExpectations and not
anywhere else.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_modifiers):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(MiscTests.test_parse_warning):
(SemanticTests.test_missing_bugid):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.warn_if_bug_missing_in_test_expectations):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.warn_if_bug_missing_in_test_expectations):

11:47 AM Changeset in webkit [129783] by wangxianzhu@chromium.org
  • 6 edits
    2 deletes in trunk

[Chromium-Android] Push more fonts for layout tests to match chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=97746

Tools:

Reviewed by Dirk Pranke.

  • DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf.
  • Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check.
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing.
(ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories.
(ChromiumAndroidPort._path_to_md5sum):
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):

LayoutTests:

Some original rebaselines will be unnecessary after this change.
Checked some rebaselines of chromium-android under fast/text,
but there should be more. Leave them to gardening.

Reviewed by Dirk Pranke.

  • platform/chromium-android/TestExpectations: Enabled some skipped tests because now we have the fonts.
  • platform/chromium-android/fast/text/complex-text-opacity-expected.txt: Removed. No more need rebaselining.
  • platform/chromium-android/fast/text/international/hindi-spacing-expected.txt: Removed. No more need rebaselining.
11:41 AM Changeset in webkit [129782] by kbalazs@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
​https://bugs.webkit.org/show_bug.cgi?id=97561

Reviewed by Noam Rosenthal.

Make sure we always send the very first RenderNextFrame message.
Before r128980 it was working accidentally because in the common
case the web process sent a DeleteCompositingLayer message at some
point before the forced repaint would time out and we was sending
the first RenderNextFrame when reacting to that.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::setActive): Set the LayerTreeRenderer to active
as well. In the QQuickWebView case it is handled by the QtWebPageSGNode.
(QRawWebView::layerTreeRenderer): Added a convenience getter
for the LayerTreeRenderer.
(QRawWebView::paint):

  • UIProcess/API/qt/raw/qrawwebview_p.h:

(WebKit):

  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:

(tst_qrawwebview::tst_qrawwebview): Added a call to addQtWebProcessToPath
to make my and the follower users of this test easier.

11:35 AM Changeset in webkit [129781] by adamk@chromium.org
  • 5 edits in trunk/Source/WebCore

Simplify and clarify MutationObserverRegistration interface and usage
​https://bugs.webkit.org/show_bug.cgi?id=97742

Reviewed by Ojan Vafai.

Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
remove the declaration of a no-longer-existing method.

No change in behavior.

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.

  • dom/MutationObserverRegistration.h:

(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous "inline" keyword.
(WebCore::MutationObserverRegistration::observer): const method.

  • dom/Node.cpp:

(WebCore):
(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.

  • dom/Node.h:

(Node): Remove old method, replaced by templatized static function.

11:30 AM Changeset in webkit [129780] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WTF

Clean up HasTrivialConstructor/Destructor
​https://bugs.webkit.org/show_bug.cgi?id=97754

Reviewed by Darin Adler.

Cleaned up HasTrivialConstructor and HasTrivialDestructor by defining them in terms of
other type traits we have. Also moved some ifdefs and comments to make things more clear.

  • wtf/TypeTraits.h:
11:05 AM Changeset in webkit [129779] by arv@chromium.org
  • 28 edits in trunk

DOM4: Add support for rest parameters to DOMTokenList
​https://bugs.webkit.org/show_bug.cgi?id=97335

Reviewed by Ojan Vafai.

This adds support for rest paramaters to DOMTokenList add and remove.
​http://dom.spec.whatwg.org/#domtokenlist

The code generator has been updated to understand variadic methods.
When a method has a rest parameter the remaining arguments are collected
into a WTF::Vector.

DOMTokenList, DOMSettableTokenList and ClassList were restructured a bit to
allow code to be shared better.

Source/WebCore:

Updated existing tests and includes new binding tests.

  • bindings/js/JSDOMBinding.h:

(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Updated to treat rest paramaters as optional.
(GenerateParametersCheck): Generate code for rest params.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionParametersCheck): Updated to treat rest paramaters as optional.
(GenerateArgumentsCountCheck): Ditto.
(GenerateParametersCheck): Generate code for rest params.

  • bindings/scripts/IDLParser.pm:

(parseOptionalOrRequiredArgument):

  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::variadicStringMethod):
(WebDOMTestObj::variadicDoubleMethod):
(WebDOMTestObj::variadicNodeMethod):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_variadic_string_method):
(webkit_dom_test_obj_variadic_double_method):
(webkit_dom_test_obj_variadic_node_method):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj variadicStringMethod:tail:]):
(-[DOMTestObj variadicDoubleMethod:tail:]):
(-[DOMTestObj variadicNodeMethod:tail:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.

  • html/ClassList.cpp:

(WebCore::ClassList::ClassList):

  • html/ClassList.h:

(WebCore):
(ClassList):

  • html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::containsInternal):
(WebCore::DOMSettableTokenList::add):
(WebCore::DOMSettableTokenList::addInternal):
(WebCore::DOMSettableTokenList::remove):
(WebCore::DOMSettableTokenList::removeInternal):
(WebCore::DOMSettableTokenList::setValue):

  • html/DOMSettableTokenList.h:

(DOMSettableTokenList):

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::validateTokens):
(WebCore):
(WebCore::DOMTokenList::contains): Moved implementation to base class to allow code sharing.
(WebCore::DOMTokenList::add): Ditto.
(WebCore::DOMTokenList::remove): Ditto.
(WebCore::DOMTokenList::toggle): Ditto.
(WebCore::DOMTokenList::addInternal): Ditto.
(WebCore::DOMTokenList::removeInternal): Ditto.
(WebCore::DOMTokenList::addToken): Ditto.
(WebCore::DOMTokenList::addTokens):
(WebCore::DOMTokenList::removeToken): Ditto.
(WebCore::DOMTokenList::removeTokens):

  • html/DOMTokenList.h:

(DOMTokenList):
(WebCore::DOMTokenList::toString):

  • html/DOMTokenList.idl:

LayoutTests:

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:

(element.classList.add):
(createElement):
(shouldBeEqualToString):
(element.classList.remove):

10:52 AM Changeset in webkit [129778] by peter@chromium.org
  • 1 edit
    347 adds in trunk/LayoutTests

[Chromium] Rebaseline more test directories for Android.

Unreviewed rebaselining.

Same as previous commits. Most changes are caused by the scrollbar, text selection
color and quality differences in image quality, causing minor (but acceptable)
differences. More information is available in bug 96398.

  • platform/chromium-android/svg/: 71 new results.
  • platform/chromium-android/tables/: 250 new results.
  • platform/chromium-android/transforms/: 5 new results.
  • platform/chromium-android/transitions/: 1 new result.
10:38 AM Changeset in webkit [129777] by peter@chromium.org
  • 13 edits
    277 adds in trunk/LayoutTests

[Chromium] Rebaseline several test directories for Android/.

Unreviewed rebaselining.

Most of these changes were caused by our different scrollbars and minor
positioning issues, and therefore are safe to rebase. With Xianzhu's
patch in the tree that adds additional fonts, more pass there as well.
Actual failures include more form items. Bugs will be filed.

  • platform/chromium-android/animations/: 4 new results.
  • platform/chromium-android/compositing/: 72 new results.
  • platform/chromium-android/css2.1/: 52 new results.
  • platform/chromium-android/css3/: 5 new results.
  • platform/chromium-android/editing/: 46 new results.
  • platform/chromium-android/fast/: 42 new results.
  • platform/chromium-android/fonts/: 12 new results.
  • platform/chromium-android/http/: 5 new results.
  • platform/chromium-android/ietestcenter/: 4 new results.
  • platform/chromium-android/platform/: 13 new results.
  • platform/chromium-android/printing/: 2 new results.
  • platform/chromium-android/scrollbars/: 2 new results.
  • platform/chromium-android/svg/: 4 new results.
10:23 AM Changeset in webkit [129776] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

332kB below DocumentEventQueue::create() on Membuster3.
<​http://webkit.org/b/97712>

Reviewed by Anders Carlsson.

Give DocumentEventQueue::m_queuedEvents an inline capacity of 16 (the default is 256.)
312kB progression on Membuster3.

  • dom/DocumentEventQueue.h:
  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::pendingEventTimerFired):

10:09 AM Changeset in webkit [129775] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
​https://bugs.webkit.org/show_bug.cgi?id=97783

Reviewed by Pavel Feldman.

BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):

10:09 AM Changeset in webkit [129774] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

Fix usage of COMPILER() macros
​https://bugs.webkit.org/show_bug.cgi?id=97642

Reviewed by Geoffrey Garen.

Add COMPILER(GCC) around compiler specific code and remove it from generic code.
This allows us to implement the DFG code for other compilers to in a next step.

  • dfg/DFGOperations.cpp:
  • jit/HostCallReturnValue.h:
10:04 AM Changeset in webkit [129773] by kling@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

3.20MB below FunctionParameters::create() on Membuster3.
<​http://webkit.org/b/97730>

Reviewed by Anders Carlsson.

Figure out the exact space needed for parameter identifiers and use reserveInitialCapacity().
Reduces memory consumption on Membuster3 by ~1.60 MB.

  • parser/Nodes.cpp:

(JSC::FunctionParameters::FunctionParameters):

10:01 AM Changeset in webkit [129772] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Page overlays are not updated when WebView is resized
​https://bugs.webkit.org/show_bug.cgi?id=97789

Reviewed by Vsevolod Vlasov.

Invalidate page overlays when view is resized.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sendResizeEventAndRepaint):

9:58 AM Changeset in webkit [129771] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Dropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
​https://bugs.webkit.org/show_bug.cgi?id=97759

Reviewed by Adam Barth.

InspectorInstrumentation.h includes two '#if USE(JSC)' blocks, which
I've been reliably informed should not appear in WebCore[1]. This patch
drops both blocks, and includes 'ScriptState.h' instead, which should
have the same practical effect.

There's no functional change, so this should be covered by existing tests.

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=94433#c55

  • inspector/InspectorInstrumentation.h:

(WebCore):

9:22 AM Changeset in webkit [129770] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-27

  • DEPS:
9:06 AM Changeset in webkit [129769] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused regular expressions from IDLStructure.pm
​https://bugs.webkit.org/show_bug.cgi?id=97790

Reviewed by Kentaro Hara.

After ​http://trac.webkit.org/changeset/129723 these regular expressions are no longer used.

No new tests, run-binding-tests generates the same output.

  • bindings/scripts/IDLStructure.pm:
8:54 AM Changeset in webkit [129768] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/profiler/apply.html fails with LLInt on 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=97791

Unreviewed gardening, skip the new failing test to paint the bots green.

  • platform/qt/Skipped:
8:42 AM Changeset in webkit [129767] by schenney@chromium.org
  • 4 edits
    3 deletes in trunk/LayoutTests

Unreviewed Chromium expectations

Expectations that were lagging at the last rebaseline.

  • platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date: Removed.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/date: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
  • platform/chromium/TestExpectations:
8:26 AM Changeset in webkit [129766] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2][WTR] Unskip two jQuery test cases.
​https://bugs.webkit.org/show_bug.cgi?id=97787

Unreviewed EFL gardening.

'jquery/data.html' and 'jquery/offset.html' cases seem to be passed consistently now.

For more information, BUG 81606 resolved some jQuery test cases
that need several seconds to finish its running by extending timeout value like WK1.

Seemingly, mentioned two cases took around 5 seconds for each on my laptop
and it would had been flaky in different hardware condition before BUG 81606.

Therefore, this patch unskipped those cases from TestExpections.

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-27

  • platform/efl-wk2/TestExpectations:
8:18 AM EFLWebKit edited by Laszlo Gombos
Found no evidence that 3.0.4 version of gperf would be really required (diff)
8:08 AM Changeset in webkit [129765] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Process touch events using mouse and multi events of Evas.
​https://bugs.webkit.org/show_bug.cgi?id=96906

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Provide default behavior for processing touch events in the ewk_view if
application wants to use it.
We can to process touch events using mouse and multi events because the
Evas creates mouse events for first touch and multi events for second and
third touch. It can be modified when Evas starts to support event type
for touch events.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_feed_touch_event_using_touch_point_list_of_evas):
(_ewk_view_on_touch_down):
(_ewk_view_on_touch_up):
(_ewk_view_on_touch_move):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
(EWK2UnitTest::EWK2UnitTestBase::mouseMove):
(EWK2UnitTest::EWK2UnitTestBase::multiDown):
(EWK2UnitTest::EWK2UnitTestBase::multiUp):
(EWK2UnitTest::EWK2UnitTestBase::multiMove):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

7:56 AM Changeset in webkit [129764] by tommyw@google.com
  • 9 edits in trunk

MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
​https://bugs.webkit.org/show_bug.cgi?id=97559

Reviewed by Adam Barth.

Source/Platform:

Refactored to mimic the new MediaConstraints api.

  • chromium/public/WebMediaConstraints.h:

(WebCore):
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebMediaConstraint):
(WebKit):
(WebMediaConstraints):

Source/WebCore:

Instead of just returning the names, return a pair of name and value.

Existing tests cover this patch.

  • Modules/mediastream/MediaConstraintsImpl.cpp:

(WebCore::MediaConstraintsImpl::initialize):
(WebCore::MediaConstraintsImpl::getMandatoryConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraintValue):

  • Modules/mediastream/MediaConstraintsImpl.h:

(MediaConstraintsImpl):

  • platform/chromium/support/WebMediaConstraints.cpp:

(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebKit):
(WebKit::WebMediaConstraints::getMandatoryConstraints):
(WebKit::WebMediaConstraints::getOptionalConstraints):

  • platform/mediastream/MediaConstraints.h:

(WebCore::MediaConstraint::MediaConstraint):
(MediaConstraint):
(WebCore):
(MediaConstraints):

Tools:

Refactoring for the new WebMediaConstraints api.

  • DumpRenderTree/chromium/MockConstraints.cpp:

(MockConstraints::verify):

6:51 AM Changeset in webkit [129763] by schenney@chromium.org
  • 26 edits
    23 adds
    35 deletes in trunk/LayoutTests

Unreviewed Chromium expectations

Cleanup after a night of building. I think some of these failures are
due to premature rebaselining earlier.

  • platform/chromium-linux-x86/fast/forms/placeholder-position-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/3d-corners-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-permanently-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-twice-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/render-surface-alpha-blending-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/text/line-breaks-expected.txt:
  • platform/chromium-win-xp/platform/chromium/compositing/3d-corners-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/layout-width-change-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/video-frame-size-change-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/date: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date: Added.
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/js/eval-cross-window-expected.txt: Replaced.
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Replaced.
  • platform/chromium/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
6:45 AM Changeset in webkit [129762] by loislo@chromium.org
  • 8 edits in trunk/Source

Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class.
​https://bugs.webkit.org/show_bug.cgi?id=97461

Reviewed by Yury Semikhatsky.

These methods and the data collected by them need to be used in the instrumentation code for other components.
As example when we are visiting bitmaps we need to visit platform specific objects.
These objects will be instrumented with help of component's own instrumentation code
but we have to keep the single set of visited objects and the map of counters.

Source/WebCore:

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::countObjectSize):
(WebCore):
(WebCore::MemoryInstrumentationClientImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationClientImpl::MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::selfSize):
(MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::visitedObjects):
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::addRootObject):
(WebCore::InstrumentationTestHelper::reportedSizeForAllTypes):
(WebCore::InstrumentationTestHelper::visitedObjects):
(WebCore::InstrumentationTestHelper::totalSize):
(WebCore):
(WebCore::TEST):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentationClient):
(WTF::MemoryInstrumentationClient::~MemoryInstrumentationClient):
(WTF):
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::countObjectSize):
(WTF::MemoryInstrumentation::visited):

6:44 AM Changeset in webkit [129761] by tommyw@google.com
  • 5 edits in trunk/Tools

MediaStream API: Rename MockConstraints::verify to verifyConstraints
​https://bugs.webkit.org/show_bug.cgi?id=97779

Reviewed by Csaba Osztrogonác.

The Mac OS X sdk has a macro called verify :/

  • DumpRenderTree/chromium/MockConstraints.cpp:

(MockConstraints::verifyConstraints):

  • DumpRenderTree/chromium/MockConstraints.h:

(MockConstraints):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::initialize):

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(WebUserMediaClientMock::requestUserMedia):

6:28 AM Changeset in webkit [129760] by Csaba Osztrogonác
  • 6 edits
    1 add in trunk/Source

[Qt] Enable the LLInt on Linux
​https://bugs.webkit.org/show_bug.cgi?id=95749

Patch by Csaba Osztrogonác <Csaba Osztrogonác>, Tor Arne Vestbø <​vestbo@webkit.org> on 2012-09-27
Reviewed by Simon Hausmann.

Source/JavaScriptCore:

  • DerivedSources.pri:
  • JavaScriptCore.pro:
  • LLIntOffsetsExtractor.pro: Added.
  • Target.pri:

Source/WTF:

  • wtf/Platform.h:
6:26 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:17 AM Changeset in webkit [129759] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMAKE] Remove unnecessary header files from CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=97771

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Kentaro Hara.

Remove the header files which are added in the source file list.

  • CMakeLists.txt:
6:00 AM Changeset in webkit [129758] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Add callback functions for WKPageFindClient
​https://bugs.webkit.org/show_bug.cgi?id=97431

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Laszlo Gombos.

Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.
The unit test for didFindString() and didFailToFindString() have beend added. The unit test for
didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet.
Additionaly, I changed the 'unsinged int' to 'unsigned' in the parameter type and removed unnecessary
type conversion.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_text_find):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_find_client.cpp:

(didFindString):
(didFailToFindString):
(didCountStringMatches):
(ewk_view_find_client_attach):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(onTextFound):
(TEST_F):

5:53 AM Changeset in webkit [129757] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, re-landing r129633 with the proper order of calls.
​https://bugs.webkit.org/show_bug.cgi?id=97659

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

5:21 AM Changeset in webkit [129756] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing test.
​https://bugs.webkit.org/show_bug.cgi?id=71896.

  • platform/wk2/Skipped:
5:15 AM Changeset in webkit [129755] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r129633.
​http://trac.webkit.org/changeset/129633
​https://bugs.webkit.org/show_bug.cgi?id=97659

Breaks inspector overlay in non-composited mode

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

4:46 AM Changeset in webkit [129754] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
​https://bugs.webkit.org/show_bug.cgi?id=97770

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
sync with what is in mediaControlsEfl.css.

We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
fullscreen mode, that is to say, the hiding of some controls.

No new tests, no behavior change for layout tests.

  • css/mediaControlsEflFullscreen.css:
4:39 AM Changeset in webkit [129753] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
​https://bugs.webkit.org/show_bug.cgi?id=97768

Reviewed by Pavel Feldman.

Source/WebCore:

Open resource dialog now assumes implicit wildcard in the beginning of the query.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
  • inspector/filtered-item-selection-dialog-filtering.html:
4:22 AM Changeset in webkit [129752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
​https://bugs.webkit.org/show_bug.cgi?id=97769

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Update Default theme files in PlatformEfl.cmake so that
changes to those files are properly picked up by CMake
when building incrementally.

  • PlatformEfl.cmake:
4:18 AM Changeset in webkit [129751] by pfeldman@chromium.org
  • 32 edits in trunk/Source/WebCore

Web Inspector: do not use InspectorInstrumentation::hasFrontends() check when collecting stacks
​https://bugs.webkit.org/show_bug.cgi?id=96730

Reviewed by Vsevolod Vlasov.

  • Introduced InspectorInstrumentation::console|timeline|runtime|canvasAgentEnabled
  • Using it all over the place instead of the hasFrontend (the latter is now only used once to guard hot path)
  • Introduced explicit "enabled" state of the console and runtime agents
  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::instrumentFunctionCall):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForConsole):

  • bindings/js/ScriptCallStackFactory.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallWith):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForConsole):

  • bindings/v8/ScriptCallStackFactory.h:

(WebCore):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::callFunctionWithInstrumentation):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore):
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

  • inspector/InspectorConsoleAgent.h:

(WebCore::InspectorConsoleAgent::enabled):
(InspectorConsoleAgent):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):

  • inspector/InspectorRuntimeAgent.h:

(WebCore::InspectorRuntimeAgent::enabled):
(WebCore::InspectorRuntimeAgent::enable):
(WebCore::InspectorRuntimeAgent::disable):
(InspectorRuntimeAgent):

  • inspector/PageRuntimeAgent.cpp:

(PageRuntimeAgentState):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didClearWindowObject):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:
  • inspector/WorkerRuntimeAgent.h:
  • inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype._didLoadCachedResources):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

4:12 AM Changeset in webkit [129750] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Unify event handling of middle mouse button.
​https://bugs.webkit.org/show_bug.cgi?id=97690

Patch by Allan Sandfeld Jensen <​allan.jensen@digia.com> on 2012-09-27
Reviewed by Tony Chang.

Source/WebCore:

Implement a unified version of middle mouse button press that can be shared between
all the ports with X11 support.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handlePasteGlobalSelection):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Remove port specific handling of middle mouse button press.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):

Source/WebKit/gtk:

Remove port specific handling of middle mouse button press.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::supportsGlobalSelection):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_button_press_event):

Source/WebKit/qt:

Remove port specific handling of middle mouse button press.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseReleaseEvent):

  • Api/qwebpage_p.h:

(QWebPagePrivate):

Source/WebKit2:

Remove Qt and GTK port specific handling of middle mouse button press.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit):

  • WebProcess/WebPage/qt/WebPageQt.cpp:
4:07 AM Changeset in webkit [129749] by tommyw@google.com
  • 21 edits
    2 copies in trunk

MediaStream API: Update getUserMedia to match the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=97540

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaConstraints.h:

(WebMediaConstraints):

Source/WebCore:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

Existing tests expanded to cover the new change.

  • Modules/mediastream/MediaConstraintsImpl.cpp:

(WebCore::MediaConstraintsImpl::create):
(WebCore):

  • Modules/mediastream/MediaConstraintsImpl.h:

(MediaConstraintsImpl):

  • Modules/mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::parseOptions):
(WebCore):
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::audioConstraints):
(WebCore::UserMediaRequest::videoConstraints):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

  • platform/chromium/support/WebMediaConstraints.cpp:

(WebKit::WebMediaConstraints::WebMediaConstraints):
(WebKit):

Source/WebKit/chromium:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

  • public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

Tools:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

  • public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

LayoutTests:

Expanding tests to cover the new getUserMedia behaviour.

  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html:
3:37 AM Changeset in webkit [129748] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector front-end closure compilation fix.

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):

3:05 AM Changeset in webkit [129747] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a test again after r129712.

  • platform/qt/Skipped:
2:55 AM Changeset in webkit [129746] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements
​https://bugs.webkit.org/show_bug.cgi?id=78595

Reviewed by Antti Koivisto.

Source/WebCore:

Do not use the same dynamicPseudo reference when recursively invoking checkSelector() for non-SubSelector selectors.

Test: fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Use new NOPSEUDO dynamic pseudoId values
for each non-SubSelector selector further in the tag history.

LayoutTests:

The original issue mentioned failures on selectors like ".foo.moo > .bar:before", while things worked fine for ".foo > .bar:before".
The test checks 2 and 3 selector levels for all conventional non-SubSelector relations (Child, Descendant, DirectAdjacent, IndirectAdjacent),
each selector in all levels but the last one containing a SubSelector relation.

  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html: Added.
  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt: Added.
2:44 AM Changeset in webkit [129745] by commit-queue@webkit.org
  • 5 edits
    2 adds
    1 delete in trunk/Source

[EFL] No way to exit video fullscreen mode once entered
​https://bugs.webkit.org/show_bug.cgi?id=97631

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Show fullscreen media control in fullscreen so that
we now have a way to exit fullscreen mode.

No new tests, no behavior change for layout tests.

  • css/mediaControlsEflFullscreen.css:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):

Source/WebKit/efl:

Fix default theme so that we have 2 fullscreen buttons, one
to enter fullscreen mode and another to exit it.

New icon by Alexander Shalamov.

  • DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Added.
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Added.
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Removed.
2:40 AM Changeset in webkit [129744] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed inspector test unskipped on qt, expectations updated.

  • http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
  • platform/qt/Skipped:
2:32 AM Changeset in webkit [129743] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[WK2] Injected bundle API implementation should use toWTFString()
​https://bugs.webkit.org/show_bug.cgi?id=97766

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Injected bundle API implementation should call toWTFString() rather than convert
WKStringRef and WKURLRef to their impls and then call string() method directly.
The rational for that are both safety (toWTFString checks the given pointer) and
code readability.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):
(WKBundlePostSynchronousMessage):
(WKBundleOverrideBoolPreferenceForTestRunner):
(WKBundleAddOriginAccessWhitelistEntry):
(WKBundleRemoveOriginAccessWhitelistEntry):
(WKBundleClearApplicationCacheForOrigin):
(WKBundleGetAppCacheUsageForOrigin):
(WKBundleSetApplicationCacheOriginQuota):
(WKBundleResetApplicationCacheOriginQuota):
(WKBundlePageNumberForElementById):
(WKBundleSetUserStyleSheetLocation):
(WKBundleSetWebNotificationPermission):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFramePauseAnimationOnElementWithId):
(WKBundleFramePauseTransitionOnElementWithId):
(WKBundleFrameAllowsFollowingLink):
(WKBundleFrameCopySuggestedFilenameForResourceWithURL):
(WKBundleFrameCopyMIMETypeForResourceWithURL):
(WKBundleFrameSetTextDirection):

  • WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:

(WKBundleInspectorEvaluateScriptForTest):

  • WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:

(WKBundleIntentCreate):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageExecuteEditingCommand):
(WKBundlePageIsEditingCommandEnabled):
(WKBundlePageHasLocalDataForURL):
(WKBundlePageFindString):
(WKBundlePageSetComposition):
(WKBundlePageConfirmCompositionWithText):
(WKBundlePageCanShowMIMEType):

2:28 AM WebKit Team edited by abecsi@webkit.org
Update affiliation of team members (diff)
2:24 AM Changeset in webkit [129742] by mario@webkit.org
  • 8 edits in trunk/Source/WebKit2

[WK2] IconDatabase: Add a way to notify when icon data is available
​https://bugs.webkit.org/show_bug.cgi?id=63945

Reviewed by Anders Carlsson.

Provide new API to notify the API layer when icon data is
available, and use it from the implementation layer when needed,
that is, either when the data has been loaded from the network or
imported from disk.

Added new callback to WKIconDatabaseClient API.

  • UIProcess/API/C/WKIconDatabase.h: Added new callback.
  • UIProcess/WebIconDatabaseClient.cpp:

(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):
Implementation of the new callback at this level in the UI
process, by using its implementation in the API layer if present.

  • UIProcess/WebIconDatabaseClient.h:

(WebIconDatabaseClient): Added new callback.

Implemented WebFrameLoaderClient::dispatchDidReceiveIcon, so we
get notified in the UI process when loading a new icon.

  • UIProcess/WebIconDatabase.messages.in: Added new message to

notify the UI process: DidReceiveIconForPageURL.

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::notifyIconDataReadyForPageURL): New
private helper function to notify the API layer both that new icon
data is ready and that the icon has changed.
(WebKit::WebIconDatabase::didReceiveIconForPageURL):
Implementation of the new message added, by calling
notifyIconDataReadyForPageURL() to notify the API layer.
(WebKit::WebIconDatabase::didImportIconDataForPageURL): Call
notifyIconDataReadyForPageURL() from here as well.

  • UIProcess/WebIconDatabase.h: Added new prototypes.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon): Send a
message to the UI process telling a new icon has been received.

1:57 AM Changeset in webkit [129741] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/dom/Geolocation to make LayoutTests faster
​https://bugs.webkit.org/show_bug.cgi?id=97765

Unreviewed EFL gardening.

Skip fast/dom/Geolocation for EFL port instead of marking
them with "Failure" expectation. This makes running
LayoutTests much faster.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27

  • platform/efl/TestExpectations:
1:36 AM Changeset in webkit [129740] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip http/tests/security/xss-eval.html again.

Fix was re-landed in r129712.

  • platform/efl/TestExpectations:
1:22 AM Changeset in webkit [129739] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

[Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing
​https://bugs.webkit.org/show_bug.cgi?id=97756

Reviewed by Kent Tamura.

This patch changes class hierarchy of BaseMultipleFieldsDateAndTimeInputType
to inherit from DateTimeEditElement::EditControlOwner rather than
containing an instance of DateTimeEditElement::EditControlOwner for
saving memory, although one pointer, and one memory fetch on using
HTMLInputElement.

Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp: DateTimeEditElement::EditControlOwner::DateTimeformatDateTimeFieldsState was removed. We no longer need to redirection. Each date/time input type classe implements it.

(WebCore::BaseMultipleFieldsDateAndTimeInputType::didBlurFromControl): Moved from DateTimeEditControlOwnerImpl and removed reference of m_dateTimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): Changed to pass BaseMultipleFieldsDateAndTimeInputType instead of DateTimeEditControlOwnerImpl.

  • html/BaseMultipleFieldsDateAndTimeInputType.h: Changed base class to have DateTImeEditElement::EditControlOwner.

(BaseMultipleFieldsDateAndTimeInputType): Removed DateTimeEditControlOwnerImpl class and member variable m_dateTimeEditControlOwner.

1:17 AM Changeset in webkit [129738] by keishi@webkit.org
  • 13 edits
    3 adds in trunk

SuggestionPicker should support rtl
​https://bugs.webkit.org/show_bug.cgi?id=97555

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added tests for Arabic with datalist.

Source/WebCore:

Add support for rtl to SuggestionPicker. We add another parameter
because text direction for the calendar picker should depend on the UI
language but the text direction for suggestion picker should depend on
the input element style.

Test: platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype._layout):

  • Resources/pagepopups/pickerCommon.css:

(.rtl): Added so we can change styles when in rtl mode.

  • Resources/pagepopups/suggestionPicker.css:

(.suggestion-list-entry .label):
(.rtl .suggestion-list-entry .label): Change float direction to left.

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._layout):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup): Set isAnchorElementRTL to true if the input element is rtl.

  • platform/DateTimeChooser.h:

(DateTimeChooserParameters): Added isAnchorElementRTL.

Source/WebKit/chromium:

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument):

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html: Added.
1:13 AM Changeset in webkit [129737] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Follow-up to r129723 to once more allow parsing of scoped names in IDL files.

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-09-27
Reviewed by Kentaro Hara.

This functionality was supported by the old IDL parser but was lost in the rewrite of the parser
in r129723. It is being reinstated to unbreak clients that currently depend on it, but will likely
be removed in the future once those clients have a chance to adopt an approach that more closely
follows the WebIDL syntax.

  • bindings/scripts/IDLParser.pm:

(parseDefinition):
(parseInheritance):
(parseImplementsStatement):
(parseExtendedAttribute):
(parseExtendedAttribute2):
(parseExtendedAttributeRest2):
(parseExtendedAttributeRest3):
(parseScopedNameListNoComma):
(parseNonAnyType):
(parseExceptionList):
(parseDefinitionOld):
(parseScopedName):
(parseAbsoluteScopedName):
(parseRelativeScopedName):
(parseScopedNameParts):
(parseScopedNameList):
(parseScopedNames):

1:12 AM Changeset in webkit [129736] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Fix build with static JavaScriptCore library

  • shell/CMakeLists.txt: Define STATICALLY_LINKED_WITH_JavaScriptCore if

JavaScriptCore_LIBRARY_TYPE is set to STATIC.

1:11 AM Changeset in webkit [129735] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] fast/layers/video-layer.html needs rebaselining after r129687
​https://bugs.webkit.org/show_bug.cgi?id=97764

Unreviewed EFL gardening.

Rebaseline fast/layers/video-layer.html due to r129687. The volume
button is no longer shown for that test.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27

  • platform/efl/fast/layers/video-layer-expected.png:
  • platform/efl/fast/layers/video-layer-expected.txt:
12:57 AM Changeset in webkit [129734] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: expose debug memory instrumentation debug data through the protocol
​https://bugs.webkit.org/show_bug.cgi?id=97683

Reviewed by Pavel Feldman.

Memory.getProcessMemoryDistribution command now returns number of instrumented
objects that were found and the number of the objects that were counted by
the instrumentation but were not actually allocated by the memory allocator.
These numbers are only added to the response if embedder provides access to the
set of all live heap objects. These numbers are intended to be used for testing
memory instrumentation.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::collectDomTreeInfo):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkCountedObject):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):
(WebCore::MemoryInstrumentationImpl::totalCountedObjects):
(WebCore::MemoryInstrumentationImpl::totalObjectsNotInAllocatedSet):
(MemoryInstrumentationImpl):

12:53 AM Changeset in webkit [129733] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions]Refactor RenderFlowThread::contentLogical(Width/Height/Left)OfFirstRegion
​https://bugs.webkit.org/show_bug.cgi?id=97577

Reviewed by Andreas Kling.

RenderFlowThread methods contentLogicalWidthOfFirstRegion, contentLogicalHeightOfFirstRegion, contentLogicalLeftOfFirstRegion
were using code to get the first valid region associated with the flow. We can use RenderFlowThread::firstRegion() method instead.

No new tests as this is just refactoring of existing code, the change is covered by existing regions tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):

12:30 AM Changeset in webkit [129732] by Patrick Gansterer
  • 2 edits in trunk

[WINCE] Enable JIT by default

  • Source/cmake/OptionsWinCE.cmake:
12:25 AM Changeset in webkit [129731] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for !USE(ICU_UNICODE) after r129662.

Convert LChar to UChar so we can call the existing function until the
other TextBreakIterator implemenations provide an overload for LChar.

  • platform/text/TextBreakIterator.cpp:

(WebCore):
(WebCore::acquireLineBreakIterator):

12:13 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:13 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:02 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:02 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:01 AM Changeset in webkit [129730] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Allow denormal floats in ARM VFP
​https://bugs.webkit.org/show_bug.cgi?id=97008

Patch by Cosmin Truta <​ctruta@rim.com> on 2012-09-26
Reviewed by Filip Pizlo.
Reviewed internally by Yong Li.

Cleared the Flush-to-Zero flag in the ARM FPSCR register on QNX.

  • wtf/ThreadingPthreads.cpp:

(WTF::enableIEEE754Denormal): Added.
(WTF::initializeThreading):
(WTF::initializeCurrentThreadInternal):

Sep 26, 2012:

11:46 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
11:43 PM Changeset in webkit [129729] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Forms] Move multiple fields related functions to BaseDateAndTimeInputType from TimeInputType
​https://bugs.webkit.org/show_bug.cgi?id=97521

Reviewed by Kent Tamura.

This patch introduces new class BaseMultipleFieldsDateAndTimeInputType
for sharing code among multiple fields date/time input UI.

Member functions in BaseMultipleFieldsDateAndTimeInputType are moved
from TimeInputType. BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
were copied from TimeInputType.{cpp,h} by r129721.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

  • WebCore.gypi: Changed to have html/BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Exposed setMillisecondToDateComponents as protected for BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState().

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::DateTimeEditControlOwnerImpl): Moved from TimeInputType::DateTimeEditControlOwnerImpl.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::~DateTimeEditControlOwnerImpl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didBlurFromControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Moved from TimeInputType::DateTimeEditControlOwnerImpl and changed to call formatDateTimeFieldsState() in BaseMultipleFieldsDateAndTimeInputTypeInputType class.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::hasCustomFocusLogic): Moved from TimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::blur): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::forwardEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::minOrMaxAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isTextField): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::saveFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldUseInputMethod): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::stepAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Moved from TimeInputType and changed to call setupLayoutParameters() to set date/time format by each input type.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Added.
(DateTimeEditControlOwnerImpl): Moved from TimeInputType.

  • html/TimeInputType.cpp: Moved multiple fields UI related functions to BaseMultipleFieldsDateAndTimeInputType.

(WebCore::TimeInputType::TimeInputType): Changed base class name to BaseTimeInput.
(WebCore::TimeInputType::formatDateTimeFieldsState): Moved from TimeINput::DateTImeEditControlOwnerImpl class.
(WebCore::TimeInputType::setupLayoutParameters): Added for set time format.

  • html/TimeInputType.h:

(TimeInputType): Chaned base class to BaseTimeInput which is alias of BaseDateAndTimeInputType or BaseMultipleFieldsDateAndTimeInputType.

11:36 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
11:30 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
11:22 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
10:52 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
10:48 PM DOMInJavaScript created by abarth@webkit.org
10:47 PM Changeset in webkit [129728] by yosin@chromium.org
  • 6 edits in trunk/Source

[Forms] Adding localization texts for multiple fields date/time input UI
​https://bugs.webkit.org/show_bug.cgi?id=97633

Reviewed by Kent Tamura.

Source/Platform:

This patch adds localized string enum fields for getting localized
strings used in multiple fields date/time input UI.

  • chromium/public/WebLocalizedString.h: Added PlaceholderForDayOfMonthField,

PlaceholderForMonthField, PlaceholderForYearField, MonthFormatInLDML,
and WeekFormatInLDML.

Source/WebCore:

This patch adds function declarations for getting localized strings
used in multiple fields date/time input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

New functions are:

  • placeholderForDayOfMonthField()

It returns localized placeholder text, e.g. "dd", for date field
used in multiple fields "date", "datetime", and "datetime-local"
input UI instead "--".

  • placeholderForfMonthField()

It returns localized placeholder text, e.g. "mm", for month field
used in multiple fields "date", "datetime", and "datetime-local"
input UI instead "--".

  • placeholderForYearField()

It returns localized placeholder text, e.g. "yyyy", for year field
used in multiple fields "date", "datetime", and "datetime-local"
input UI instead "----".

  • monthFormatInLDML()

It returns month and year format in LDML, Unicode technical
standard 35, Locale Data Markup Language, e.g. "MM-yyyyy" for
"month" input type.

  • monthFormatInLDML()

It returns week and year format in LDML, e.g. "WW-yyyyy" for
"week" input type.

No new tests. This patch doesn't change behavior.

  • platform/LocalizedStrings.h:

(WebCore): Added declarations of placeholderForDayOfMonthField(), placeholderForMonthField(),
placeholderForYearField(), monthFormatInLDML() and weekFormatInLDML().

Source/WebKit/chromium:

This patch adds functions for getting localized strings used in
multiple fields date/time input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

These functions will be used by DateInputType, DateTimeInputType,
DateTimeLocalInputType, MonthInputTypee, and WeekInputType.

  • src/LocalizedStrings.cpp:

(WebCore::placeholderForDayOfMonthField): Added.
(WebCore::placeholderForMonthField): Added.
(WebCore::placeholderForYearField): Added.
(WebCore::monthFormatInLDML): Added.
(WebCore::weekFormatInLDML): Added.

10:45 PM Changeset in webkit [129727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] Remove an unused member variable m_program in FECustomFilter.h
​https://bugs.webkit.org/show_bug.cgi?id=97755

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-09-26
Reviewed by Kentaro Hara.

No new tests. This patch doesn't change behavior.

  • platform/graphics/filters/FECustomFilter.h:

(WebCore):

9:27 PM Changeset in webkit [129726] by keishi@webkit.org
  • 2 edits
    11 adds in trunk/LayoutTests

Add tests for datalist UI for input type date
​https://bugs.webkit.org/show_bug.cgi?id=97551

Reviewed by Kent Tamura.

Adding tests for datalist UI for input type date.

  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium/TestExpectations: Mark as image failure for date-suggestion-picker-appearance.html
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html: Added.
9:13 PM Changeset in webkit [129725] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Update my e-mail address.

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-26

  • Scripts/webkitpy/common/config/committers.py:
8:15 PM Changeset in webkit [129724] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed build fix after 129707.

  • webkit/webkitwebview.cpp:

(webkit_web_view_forward_context_menu_event):

7:11 PM Changeset in webkit [129723] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Move IDL extended attributes to the location specified in WebIDL
​https://bugs.webkit.org/show_bug.cgi?id=26398

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-08-09
Reviewed by Kentaro Hara.

Recreated a new IDLParser based on the WebIDL spec:
​http://dev.w3.org/2006/webapi/WebIDL/

Firstly merges two grammars (editors draft and WebKit current IDL) and
generates IDL parser by using python script. The generated parser is
modified to generate the same outputs as the previous IDLParser.pm.
The new IDLParser.pm can parse both WebIDL grammar.

No new tests. Tested by comparing with sources generated by
the previous IDLParser.pm.

  • bindings/scripts/IDLParser.pm:

(new):
(assertTokenValue):
(assertTokenType):
(assertUnexpectedToken):
(Parse):
A method to start parsing a IDL file. Arguments and return values are
the same as the previous IDLParser.pm's Parse method.
(nextToken):
Implemented to see a next token, because of LL(1).
(getToken):
Returns current token, and update next and current token.
(getTokenInternal):
According to the regular expressions defined in WebIDL spec, extracts
one new token from a text string. The order of the regular expressions
to be tested is important, i.e. "0." should be considered as a float
token, but if firstly checks the integer regular expression, "0." is
considered as "0" and ".".
(parseDefinition):
(parseCallbackOrInterface):
(parseCallbackRestOrInterface):
(parseInterface):
(parsePartial):
(parsePartialDefinition):
(parsePartialInterface):
(parseInterfaceMember):
(parseDictionary):
(parseDictionaryMember):
(parsePartialDictionary):
(parseDefaultValue):
(parseException):
(parseExceptionMembers):
(parseEnum):
(parseEnumValueList):
(parseCallbackRest):
(parseTypedef):
(parseImplementsStatement):
(parseConst):
(parseConstValue):
(parseBooleanLiteral):
(parseFloatLiteral):
(parseAttributeOrOperationOrIterator):
(parseSerializer):
(parseSerializationPattern):
(parseQualifier):
(parseAttributeOrOperationRest):
(parseAttribute):
(parseAttributeRest):
(parseOperationOrIterator):
(parseSpecialOperation):
(parseSpecial):
(parseOperationOrIteratorRest):
(parseIteratorRest):
(parseOptionalIteratorInterfaceOrObject):
(parseOperationRest):
(parseArguments):
(parseArgument):
(parseOptionalOrRequiredArgument):
(parseArgumentName):
(parseExceptionMember):
(parseExceptionField):
(parseExtendedAttributeList):
(parseExtendedAttribute):
(parseExtendedAttributeRest2):
(parseArgumentNameKeyword):
(parseType):
(parseSingleType):
(parseUnionType):
(parseNonAnyType):
(parsePrimitiveType):
(parseUnrestrictedFloatType):
(parseFloatType):
(parseUnsignedIntegerType):
(parseNull):
(parseGet):
(parseInheritsGetter):
(parseSetGetRaises):
(parseGetRaises2):
(parseSetRaises):
(parseSetRaises3):
(parseDefinitionOld):
(parseModule):
(parseInterfaceOld):
(parseInterfaceMemberOld):
(parseDictionaryOld):
(parseDictionaryMemberOld):
(parseExceptionOld):
(parseEnumOld):
(parseAttributeOrOperationOrIteratorOld):
(parseAttributeOrOperationRestOld):
(parseAttributeOld):
(parseIn):
(parseOptionalSemicolon):
(applyMemberList):
(applyExtendedAttributeList):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::longAttr):
(WebDOMTestObj::setLongAttr):
(WebDOMTestObj::voidMethodWithArgs):
(WebDOMTestObj::longMethod):
(WebDOMTestObj::longMethodWithArgs):
(WebDOMTestObj::objMethodWithArgs):
(WebDOMTestObj::convert1):
(WebDOMTestObj::convert2):
(WebDOMTestObj::convert3):
(WebDOMTestObj::convert4):
(WebDOMTestObj::convert5):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_long_method):
(webkit_dom_test_obj_long_method_with_args):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert3):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_get_long_attr):
(webkit_dom_test_obj_set_long_attr):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjLongAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethod):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj longAttr]):
(-[DOMTestObj setLongAttr:]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj longMethod]):
(-[DOMTestObj longMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj convert1:]):
(-[DOMTestObj convert2:]):
(-[DOMTestObj convert3:]):
(-[DOMTestObj convert4:]):
(-[DOMTestObj convert5:]):

  • bindings/scripts/test/TestObj.idl:

Removed the line which has only "JSC, V8".
Added argument to convert1, ... convert5.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::longAttrAttrGetter):
(WebCore::TestObjV8Internal::longAttrAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • Modules/webaudio/AudioBufferSourceNode.idl:

As only restricted extended attribute syntax is supported, modify the
idl from [...] [...] to [..., ...].

6:43 PM Changeset in webkit [129722] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix XPCServices symlink to not be to an absolute path
in the build products directory.

Reviewed by Dan Bernstein.

  • WebKit2.xcodeproj/project.pbxproj:
6:25 PM Changeset in webkit [129721] by yosin@chromium.org
  • 1 edit
    2 copies in trunk/Source/WebCore

[Forms] Copy TimeInputType.{cpp,h} to BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=97649

Reviewed by Kent Tamura.

This patch copies TimeInput.{cpp,h} to BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
for sharing code related to multiple fields date/time input UI among date/time related
input types, such as "date", "datetime", "month", "time" and "week".

No new tests. This patch doesn't change behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp: Copied from Source/WebCore/html/TimeInputType.cpp.
  • html/BaseMultipleFieldsDateAndTimeInputType.h: Copied from Source/WebCore/html/TimeInputType.h.
6:20 PM Changeset in webkit [129720] by kenneth@webkit.org
  • 2 edits
    2 deletes in trunk/Source/WebCore

[Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port
​https://bugs.webkit.org/show_bug.cgi?id=73111

Reviewed by Gyuyoung Kim.

Remove unneeded files

  • PlatformEfl.cmake: Do not add the files any more.
  • platform/graphics/efl/GraphicsLayerEfl.cpp: Removed.
  • platform/graphics/efl/GraphicsLayerEfl.h: Removed.
6:18 PM Changeset in webkit [129719] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Proxy the global this in JSC
​https://bugs.webkit.org/show_bug.cgi?id=97734

Reviewed by Filip Pizlo.

Eeep – fix a bug - was leaving the global this proxy's structure's globalObject as 0,
and setting the proxy's prototype as the global object, rather than its prototype.

  • jsc.cpp:

(GlobalObject::create):

  • runtime/JSProxy.h:

(JSC::JSProxy::createStructure):

6:04 PM Changeset in webkit [129718] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

6:02 PM Changeset in webkit [129717] by dpranke@chromium.org
  • 2 edits in trunk/Tools

modify old-run-webkit-tests to support TestExpectations files a little
​https://bugs.webkit.org/show_bug.cgi?id=97276

Reviewed by Daniel Bates.

This patch adds minimal support to old-run-webkit-tests so that
it can read a TestExpectations file and skip the tests listed
there. It will skip *all* tests, regardless of the expectation
(even if the test is listed as [ Pass ]), and it will only look
at the TestExpectations file if there isn't a Skipped file next
to it.

This will allow us to switch to using just using
TestExpectations files without making old-run-webkit-tests
totally useless.

  • Scripts/old-run-webkit-tests:

(readSkippedFiles):
(processSkippedFileEntry): Added.
(startsWith): Added.

6:01 PM Changeset in webkit [129716] by dgrogan@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaselining.

dont-commit-on-blocked.html isn't run in DRT, only in chromium's
content_browsertests.

  • storage/indexeddb/dont-commit-on-blocked-expected.txt:
5:23 PM Changeset in webkit [129715] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, 32-bit build fix.

  • llint/LowLevelInterpreter32_64.asm:
5:09 PM Changeset in webkit [129714] by dpranke@chromium.org
  • 3 edits in trunk/Tools

The style bot spams about skia_test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=97699

Reviewed by Adam Barth.

Remove the warning about a missing skia_test_expectations.txt
file for now. There are some situations where it would be
helpful to get this warning as it might indicate that the user
is going to get results different than what they're expecting,
but at the moment it looks difficult if not impossible to get
those warnings and not also get warnings that we don't care
about, so the noise is outweighing the value of the signal.

This at least will stop the false negatives we're getting on the
style bots. If it turns out people do need the warning we can
add it back in in some other more conditional way.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.expectations_files):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_expectations):
(_assert_command):

5:04 PM Changeset in webkit [129713] by fpizlo@apple.com
  • 15 edits
    2 adds in trunk/Source/JavaScriptCore

jneq_ptr shouldn't have a pointer
​https://bugs.webkit.org/show_bug.cgi?id=97739

Reviewed by Oliver Hunt.

Slamming pointers directly into bytecode is sometimes cool, but in this case it's
unwieldy and confusing. Switched the instruction to use an enum instead. This has
zero effect on code gen behavior in the JITs. In the LLInt, there is now more
indirection, but that doesn't affect benchmarks.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/Instruction.h:

(JSC::Instruction::Instruction):
(Instruction):

  • bytecode/SpecialPointer.cpp: Added.

(JSC):
(JSC::actualPointerFor):

  • bytecode/SpecialPointer.h: Added.

(JSC):
(JSC::pointerIsFunction):
(JSC::pointerIsCell):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jneq_ptr):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_jneq_ptr):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::actualPointerFor):

4:25 PM Changeset in webkit [129712] by barraclough@apple.com
  • 11 edits in trunk

REGRESSION (r129456): http/tests/security/xss-eval.html is failing on JSC platforms
​https://bugs.webkit.org/show_bug.cgi?id=97529

Reviewed by Filip Pizlo.

A recent patch changed JSC's EvalError behaviour; bring this more into line with other browsers.

Source/JavaScriptCore:

JSC currently throws an EvalError if you try to call eval with a this object that doesn't
match the given eval function. This does not match other browsers, which generally just
ignore the this value that was passed, and eval the string in the eval function's environment.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • Remove EvalError, ignore passed this value.

LayoutTests:

  • fast/js/eval-cross-window-expected.txt:
  • fast/js/eval-cross-window.html:
    • Changed not to expect EvalErrors (this matches other browsers), and modified testThis to check that the this object is always set to the global object.
  • http/tests/security/resources/xss-eval2.html:
  • http/tests/security/resources/xss-eval3.html:
  • http/tests/security/xss-eval-expected.txt:
  • http/tests/security/xss-eval.html:
    • Updated. Access via the global environment is not a security risk, since the eval is accessing it's own document's informantion. Access via the shell attempts to access the navigated pages document, tripping an access check & throwing a TypeError.
3:50 PM Changeset in webkit [129711] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Proxy the global this in JSC
​https://bugs.webkit.org/show_bug.cgi?id=97734

Reviewed by Oliver Hunt.

Having jsc diverge from WebCore here is not beneficial; it potentially masks bugs and/or performance
problems from command line testing.

  • jsc.cpp:

(GlobalObject::create):

  • Create a this value proxy for the global object.
  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • Make setGlobalThis protected.
  • runtime/JSProxy.h:

(JSC::JSProxy::create):
(JSC::JSProxy::target):
(JSC::JSProxy::finishCreation):
(JSProxy):

  • Allow proxy target to be a JSObject, add target to create method.
3:01 PM Changeset in webkit [129710] by eae@chromium.org
  • 115 edits
    2 adds
    21 deletes in trunk/LayoutTests

Unreviewed chromium windows rebaseline for r129656.

  • platform/chromium-linux-x86/svg/wicd: Removed.
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.txt: Removed.
  • platform/chromium-linux/fast/borders/bidi-009a-expected.txt: Removed.
  • platform/chromium-linux/fast/borders/bidi-012-expected.txt: Removed.
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.txt: Removed.
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.txt: Removed.
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.txt: Removed.
  • platform/chromium-linux/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/007-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/css1/formatting_model/inline_elements-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-win/fast/borders/bidi-009a-expected.txt:
  • platform/chromium-win/fast/borders/bidi-012-expected.txt:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/css/hsl-color-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/chromium-win/fast/forms/007-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.png:
  • platform/chromium-win/fast/html/details-nested-2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary1-expected.png:
  • platform/chromium-win/fast/html/details-no-summary2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary3-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open1-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open3-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open5-expected.png:
  • platform/chromium-win/fast/html/details-open6-expected.png:
  • platform/chromium-win/fast/html/details-position-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-win/fast/html/details-replace-text-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/text/line-breaks-expected.txt:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-win/svg/custom/viewBox-hit-expected.png:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/gtk/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
  • svg/as-border-image/svg-as-border-image-expected.txt: Added.
2:43 PM Changeset in webkit [129709] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Stop using kCFURLHFSPathStyle
​https://bugs.webkit.org/show_bug.cgi?id=97731
<rdar://problem/12378980>

Reviewed by Tim Horton.

Stop passing Carbon style paths to the plug-in. Both WebKitPluginHost, WebKit2 and Firefox
pass POSIX style paths which makes more sense.

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::destroyStream):

2:36 PM Changeset in webkit [129708] by Dave Barton
  • 1 edit in trunk/Source/WebCore/rendering/RenderTableCell.cpp

Compile fix for Windows.

2:13 PM Changeset in webkit [129707] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

Rename Page::frameCount() to subframeCount(), and related
​https://bugs.webkit.org/show_bug.cgi?id=97729

Reviewed by Alexey Proskuryakov.

Rename member functions and variables on Page that refer to
"frame count" to use "subframe count", since the main frame is
not included in the count.

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::open):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):

  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::disconnectOwnerElement):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::checkSubframeCountConsistency):

  • page/Page.h:

(WebCore::Page::incrementSubframeCount):
(WebCore::Page::decrementSubframeCount):
(WebCore::Page::subframeCount):
(WebCore::Page::checkSubframeCountConsistency):

2:11 PM Changeset in webkit [129706] by jpetsovits@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove blitContents() in favor of blitVisibleContents().
​https://bugs.webkit.org/show_bug.cgi?id=97718

Reviewed by Antonio Gomes.

After the last calling sites of blitContents() have
been removed or reworked, the actual method itself
can now retire. All blits now go through
blitVisibleContents(). The knowledge that we always
blit the full visible surface can facilitate further
optimizations; we will get to that in time.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):

2:10 PM Changeset in webkit [129705] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop using CFURLCreateDataAndPropertiesFromResource
​https://bugs.webkit.org/show_bug.cgi?id=97728
<rdar://problem/12379035>

Reviewed by Tim Horton.

Replace a call to CFURLCreateDataAndPropertiesFromResource with -[NSData initWithContentsOfURL:]
and add the necessary casts to make the compiler happy.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::contentsOfPropertyListAtURL):

2:03 PM Changeset in webkit [129704] by reed@google.com
  • 2 edits in trunk/LayoutTests

update expectations for feTile.svg
​https://bugs.webkit.org/show_bug.cgi?id=97727

Reviewed by NOBODY

Expectations change only.
Skia change affected feTile.svg results (crbug 152503)

  • platform/chromium/TestExpectations:
1:57 PM Changeset in webkit [129703] by davidbarr@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Upgrade myself from contributor to committer.

  • Scripts/webkitpy/common/config/committers.py:
1:57 PM Changeset in webkit [129702] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

1:54 PM Changeset in webkit [129701] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

[WK2] Update WebPageProxy::reattachToWebProcess() for multi-web process mode
​https://bugs.webkit.org/show_bug.cgi?id=97726

Reviewed by Anders Carlsson.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureSharedWebProcess): createNewWebProcess() now takes care of adding the new process to m_processes. (WebKit::WebContext::createNewWebProcess): Every time we call this function, we need to add the result to m_processes. Better do it internally to avoid mistakes. (WebKit::WebContext::warmInitialProcess): Updated for the above. (WebKit::WebContext::createWebPage): Ditto. (WebKit::WebContext::relaunchProcessIfNecessary): This function makes no sense in multi-web process mode. Assert that we didnt get here accidentally.
  • UIProcess/WebContext.h: (WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary): Only call relaunchProcessIfNecessary in single process mode. The functionality that needs this behavior will be greatly refactored for multi-web process.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess): We already know that we need a new process, "relaunch if necessary" is not the right logic. Also added a few more assertions checking that process state is as expected.


  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): Removed relaunchProcessIfNecessary(). It will be called inside sendToAllProcessesRelaunchingThemIfNecessary().
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): Ditto. (WebKit::WebPluginSiteDataManager::clearSiteData): Ditto.
1:51 PM Changeset in webkit [129700] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Remove deprecated code from perftestrunner.py
​https://bugs.webkit.org/show_bug.cgi?id=97724

Reviewed by Adam Barth.

Remove the code deprecated in r129580 now that we have landed r129597,
which updated master.cfg to use new options, and restarted the buildbot master.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_with_slave_config_json):
(test_parse_args):

1:45 PM Changeset in webkit [129699] by cevans@google.com
  • 1 edit in branches/chromium/1271/Source/WebCore/rendering/RenderArena.cpp

Merge 129583
BUG=152354
Review URL: ​https://codereview.chromium.org/10993050

1:45 PM Changeset in webkit [129698] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed speculative build fix for clang.

Added explicit static_cast from int64_t to int32_t.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::uTextLatin1Clone):
(WebCore::uTextLatin1Extract):
(WebCore::uTextLatin1MapNativeIndexToUTF16):

1:34 PM Changeset in webkit [129697] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r129673.
​http://trac.webkit.org/changeset/129673
​https://bugs.webkit.org/show_bug.cgi?id=97723

Causing window build breakage (Requested by alecf on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::ensureFontLoaded):

1:30 PM Changeset in webkit [129696] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1271

Merge 129469
BUG=150966
Review URL: ​https://codereview.chromium.org/10989043

1:27 PM Changeset in webkit [129695] by Dave Barton
  • 13 edits in trunk

[MathML] Implement <mtd> rowspan and columnspan attributes
​https://bugs.webkit.org/show_bug.cgi?id=97401

Reviewed by Eric Seidel.

Source/WebCore:

These should behave like rowspan and colspan for HTMLTableCell. As in that case,
RenderTableCell accesses these attributes of its element as needed.

Tested by modifications to LayoutTests/mathml/presentation/tables.xhtml.

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::colSpan):
(WebCore::MathMLElement::rowSpan):
(WebCore::MathMLElement::parseAttribute):

  • mathml/MathMLElement.h:

(MathMLElement):
(WebCore::toMathMLElement):

  • mathml/mathattrs.in:
  • mathml/mathtags.in:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::isMathMLElement):
(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
(WebCore::RenderTableCell::colSpanOrRowSpanChanged):

  • rendering/RenderTableCell.h:

(RenderTableCell):

  • Changed m_hasAssociatedTableCellElement to m_hasHTMLTableCellElement.

LayoutTests:

  • mathml/presentation/tables.xhtml:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
1:25 PM Changeset in webkit [129694] by Beth Dakin
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=97629
http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after
being unskipped

Reviewed by Tim Horton.

The test was failing because we were failing to use the fake window origin. We
should really always use the fake origin. This patch eliminates
_shouldUseFakeOrigin in favor of always using it.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow setFrameOrigin:]):
(-[WebKitTestRunnerWindow setFrame:display:animate:]):
(-[WebKitTestRunnerWindow setFrame:display:]):
(-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):

1:21 PM Changeset in webkit [129693] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/1271

Merge 129585
BUG=145915
Review URL: ​https://codereview.chromium.org/10993046

1:10 PM Changeset in webkit [129692] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] load event fires on XMLHttpRequestUpload twice with Qt5
​https://bugs.webkit.org/show_bug.cgi?id=92669

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

When finishing, after the upload have already been done, Qt5's
QNetworkReply emits an uploadProgress signal with total bytes set to
zero. Since 0 of 0 bytes doesn't make any sense as progress, a
conditional was added to QNetworkReplyHandler::uploadProgress to make
do nothing with such values.

Unskip XMLHttpRequestUpload tests.

Source/WebCore:

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::uploadProgress):

LayoutTests:

  • platform/qt-5.0/Skipped:
1:08 PM Changeset in webkit [129691] by fpizlo@apple.com
  • 5 edits
    6 adds in trunk

JSObject::ensureArrayStorage() ignores the possibility that extensions have been prevented
​https://bugs.webkit.org/show_bug.cgi?id=97719

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::ensureArrayStorageSlow):
(JSC):

  • runtime/JSObject.h:

(JSC::JSObject::ensureArrayStorage):
(JSObject):

LayoutTests:

  • fast/js/dfg-arrayify-when-late-prevent-extensions-expected.txt: Added.
  • fast/js/dfg-arrayify-when-late-prevent-extensions.html: Added.
  • fast/js/dfg-arrayify-when-prevent-extensions-expected.txt: Added.
  • fast/js/dfg-arrayify-when-prevent-extensions.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arrayify-when-late-prevent-extensions.js: Added.

(foo):

  • fast/js/script-tests/dfg-arrayify-when-prevent-extensions.js: Added.

(foo):

1:06 PM Changeset in webkit [129690] by tony@chromium.org
  • 4 edits in trunk/Tools

C++ style checker should warn when the indentation is wrong
​https://bugs.webkit.org/show_bug.cgi?id=97602

Reviewed by Ojan Vafai.

Rewrite the indentation checker to ensure that indentation is always a factor of 4
and that we only indent 4 spaces from the previous line.

I deleted some of the old indentation checking code since it was filtered out
and didn't match the webkit style.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checkers/cpp.py:

(check_indentation_amount): New function that checks indentation. Intentionally runs after
other indentation checks.
(check_style): Delete the old indentation code since we were already filtering out the whitespace/labels warnings.
(CppChecker): Remove the whitespace/labels filter.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_multi_line_comments): Force 4 space indent.
(CppStyleTest.test_explicit_single_argument_constructors):
(CppStyleTest.test_explicit_single_argument_constructors.Foo):
(CppStyleTest.test_explicit_single_argument_constructors.Qualifier):
(CppStyleTest.test_slash_star_comment_on_single_line):
(CppStyleTest.test_braces):
(CppStyleTest.test_spacing_before_last_semicolon):
(CppStyleTest.test_static_or_global_stlstrings):
(CppStyleTest.test_indent): Added macro test case.
(CppStyleTest.test_build_class):
(NoNonVirtualDestructorsTest.test_no_error):
(NoNonVirtualDestructorsTest.test_no_error.Foo):
(NoNonVirtualDestructorsTest.test_no_error.Qualified):
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed):
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo):
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed):
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo):
(NoNonVirtualDestructorsTest.test_no_warn_when_derived):
(NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo):
(NoNonVirtualDestructorsTest.test_internal_braces):
(NoNonVirtualDestructorsTest.test_internal_braces.Foo):
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor):
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo):
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo):
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor):
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo):
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo):
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor):
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo):
(WebKitStyleTest.test_indentation):
(WebKitStyleTest.test_braces): Add test for call params spanning lines.

12:55 PM Changeset in webkit [129689] by commit-queue@webkit.org
  • 13 edits
    2 moves in trunk/Source/WebCore

[CSS Exclusions] Rename WrapShapeInfo to ExclusionShapeInfo
​https://bugs.webkit.org/show_bug.cgi?id=96157

Patch by Bear Travis <​betravis@adobe.com> on 2012-09-26
Reviewed by Dirk Schulze.

Rename WrapShapeInfo to the more specific ExclusionShapeInsideInfo, which is the only
information the class is currently tracking. This patch updates build files, class
instances and variable names. When shape-outside is added, there may be an additional
ExclusionShapeOutsideInfo class that shares a common parent class with
ExclusionShapeInsideInfo. This patch only changes names, there is no new functionality.

Covered by existing tests

  • CMakeLists.txt: Rename files from WrapShapeInfo to ExclusionShapeInsideInfo.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/ExclusionShapeInsideInfo.cpp: Renamed from Source/WebCore/rendering/WrapShapeInfo.cpp.

(WebCore): Renaming functions and variables to use ExclusionShapeInsideInfo rather than
WrapShapeInfo.
(WebCore::exclusionShapeInsideInfoMap):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::~ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ensureExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::computeShapeSize):
(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine):

  • rendering/ExclusionShapeInsideInfo.h: Renamed from Source/WebCore/rendering/WrapShapeInfo.h.

(WebCore):
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::create):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom):
(WebCore::ExclusionShapeInsideInfo::hasSegments):
(WebCore::ExclusionShapeInsideInfo::segments):
(WebCore::ExclusionShapeInsideInfo::dirtyShapeSize):
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore):
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::exclusionShapeInsideInfo):
(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
(WebCore::RenderBlock::computeExclusionShapeSize):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::exclusionShapeInsideInfo):
(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::layoutExclusionShapeInsideInfo):
(WebCore::LineWidth::LineWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

12:44 PM Changeset in webkit [129688] by eae@chromium.org
  • 12 edits
    2 copies in branches/chromium/1271

Merge 129370 - snapToSize rounds the incorrectly for negative locations
​https://bugs.webkit.org/show_bug.cgi?id=97265

Reviewed by Eric Seidel.

Source/WebCore:

Change snapSizeToPixel to preserve sign for location which
affects rounding.

Test: fast/sub-pixel/snap-negative-location.html

  • platform/FractionalLayoutUnit.h:

(WebCore::snapSizeToPixel):

LayoutTests:

Add test for snapSizeToPixel handling of negative locations.
Skipped on platforms that do not enable subpixel layout.

  • fast/sub-pixel/snap-negative-location-expected.html: Added.
  • fast/sub-pixel/snap-negative-location.html: Added.
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

TBR=​eae@chromium.org
Review URL: ​https://codereview.chromium.org/10996032

12:43 PM Changeset in webkit [129687] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

[EFL] Volume button should not be shown for videos without audio
​https://bugs.webkit.org/show_bug.cgi?id=97574

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The volume control is no longer shown for videos with
no audio.

No new tests, already tested by media/video-no-audio.html.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):
(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

LayoutTests:

Generate baseline for media/video-no-audio.html and unskip
it now that the volume control is no longer shown for
videos with no audio track.

Rebaseline several other media tests whose output changed
due to the fix.

  • platform/efl/Skipped:
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/video-empty-source-expected.png:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-no-audio-expected.png: Added.
  • platform/efl/media/video-no-audio-expected.txt: Added.
12:40 PM Changeset in webkit [129686] by leviw@chromium.org
  • 8 edits
    2 copies in branches/chromium/1271

Merge 129529 - [chromium] REGRESSION: Incorrect preferred width calculation for table cells
​https://bugs.webkit.org/show_bug.cgi?id=97497

Reviewed by Levi Weintraub.

Source/WebCore:

In fixing bug 93911 r125694 caused a problem with the preferred
width calculations for table cells with a fractional padding
where the logic to ensure that the cell is wide enough for the
content returns different results for cells with a fixed width
and cells with an automatic width.

Test: fast/sub-pixel/table-cells-have-stable-width.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Move the logic that ensures that a cell is wide enough from AutoTableLayout::recalcColumn to RenderBlock::computePreferredLogicalWidths to. This way it also applies to FixedTableLayout which had the same problem.

LayoutTests:

Added test for cell width calculation and reverted three svg tests to the results prior to r125694.

  • fast/sub-pixel/table-cells-have-stable-width-expected.txt: Added.
  • fast/sub-pixel/table-cells-have-stable-width.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:

TBR=​eae@chromium.org

12:39 PM Changeset in webkit [129685] by barraclough@apple.com
  • 19 edits
    3 moves in trunk/Source

Generalize JSGlobalThis as JSProxy
​https://bugs.webkit.org/show_bug.cgi?id=97716

Reviewed by Oliver Hunt.

../JavaScriptCore:

Generalize JSGlobalThis as JSProxy and move proxying functionality up from the window shell into JSProxy.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::toThisObject):

  • Hoist toThisObject from WebCore.

(JSC):

  • runtime/JSGlobalObject.h:
    • removed include.

(JSC::JSGlobalObject::finishCreation):

  • JSGlobalThis -> JSObject

(JSGlobalObject):

  • Hoist toThisObject from WebCore.
  • runtime/JSGlobalThis.cpp: Removed.
  • runtime/JSGlobalThis.h: Removed.
  • runtime/JSObject.cpp:
    • removed include.
  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::isProxy):

  • isGlobalThis -> isProxy
  • GlobalThisType -> ProxyType
  • runtime/JSProxy.cpp: Copied from Source/JavaScriptCore/runtime/JSGlobalThis.cpp.

(JSC):
(JSC::JSProxy::visitChildren):
(JSC::JSProxy::setTarget):
(JSC::JSProxy::className):
(JSC::JSProxy::getOwnPropertySlot):
(JSC::JSProxy::getOwnPropertySlotByIndex):
(JSC::JSProxy::getOwnPropertyDescriptor):
(JSC::JSProxy::put):
(JSC::JSProxy::putByIndex):
(JSC::JSProxy::putDirectVirtual):
(JSC::JSProxy::defineOwnProperty):
(JSC::JSProxy::deleteProperty):
(JSC::JSProxy::deletePropertyByIndex):
(JSC::JSProxy::getPropertyNames):
(JSC::JSProxy::getOwnPropertyNames):

  • Class cretaed from JSGlobalThis, JSDOMWindowShell.
  • runtime/JSProxy.h: Copied from Source/JavaScriptCore/runtime/JSGlobalThis.h.

(JSC::JSProxy::create):
(JSC::JSProxy::createStructure):
(JSProxy):
(JSC::JSProxy::target):
(JSC::JSProxy::JSProxy):

  • Class cretaed from JSGlobalThis, JSDOMWindowShell.
  • runtime/JSType.h:
    • GlobalThisType -> ProxyType

../WebCore:

This patch moves window shell functionality up to JSC::JSProxy.

  • ForwardingHeaders/runtime/JSGlobalThis.h: Removed.
  • ForwardingHeaders/runtime/JSProxy.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSGlobalThis.h.
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::finishCreation):

  • JSGlobalThis -> JSObject
  • bindings/js/JSDOMGlobalObject.h:

(JSDOMGlobalObject):

  • JSGlobalThis -> JSObject
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore):

  • Hoist toThisObject up into JSC.
  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • Hoist toThisObject up into JSC.
  • bindings/js/JSDOMWindowShell.cpp:

(WebCore):

  • JSGlobalThis -> JSProxy
  • moved JSObject callbacks to JSProxy
  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • JSGlobalThis -> JSProxy
  • moved JSObject callbacks to JSProxy

(WebCore::JSDOMWindowShell::window):

  • unwrappedObject() -> target()

(WebCore::JSDOMWindowShell::setWindow):

  • setUnwrappedObject() -> setTarget()

(WebCore::JSDOMWindowShell::createStructure):

  • GlobalThisType -> ProxyType
12:26 PM Changeset in webkit [129684] by abarth@webkit.org
  • 3 edits in trunk/Tools

Rollout messages should be clickable in bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=97711

Reviewed by Simon Fraser.

If we say Bug NNNN instead of just NNNN, bugzilla will autolink to the
actual bug.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.run):

12:20 PM Changeset in webkit [129683] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-perf-tests must expand environment variables in user provided paths
​https://bugs.webkit.org/show_bug.cgi?id=97686

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Ryosuke Niwa.

The run-perf-tests command line options that receive paths from the
user now expand any possible environment variables, because Python's
file handling methods do not handle those.

Examples:
run-perf-tests --platform=qt --release --output-json-path=~/perf-results
run-perf-tests --platform=qt --release --output-json-path=$HOME/perf-results

Also removed unused imports.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args._expand_path): expand environment variables in a path passed via command line
(PerfTestsRunner._parse_args):

12:10 PM Changeset in webkit [129682] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

4.95MB below RenderBlock::insertIntoTrackedRendererMaps() on Membuster3.
<​http://webkit.org/b/97687>

Reviewed by Anders Carlsson.

Give the TrackedRendererListHashSet typedef an inline capacity of 16 (the default is 256.)
Browsing around the web, I saw almost no cases with more than 20 entries in these lists,
and this simple change saves us ~4.68MB on the Membuster3 benchmark.

  • rendering/RenderBlock.h:
12:06 PM Changeset in webkit [129681] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

DelayNode must take sample-accurate delay times into account
​https://bugs.webkit.org/show_bug.cgi?id=97609

Reviewed by Kenneth Russell.

Currently DelayNode simply uses a coarse-grained k-rate smoothing of .delayTime
It should also be capable of supporting audio-rate control of .delayTime

  • Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::process):

  • Modules/webaudio/DelayDSPKernel.h:

(DelayDSPKernel):

11:59 AM Changeset in webkit [129680] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Reintroducing failure expectation for http/tests/security/xss-eval.html as
the fixing commit was rolled out. Also adding a flaky expectation for
mathml/presentation/msubsup-base-changed.html.

  • platform/gtk/TestExpectations:
11:57 AM Changeset in webkit [129679] by peter@chromium.org
  • 1 edit
    66 deletes in trunk/LayoutTests

Revert "[Chromium] Rebase a few of Mozilla's tests in tables/ for Android."
Unreviewed revert.

The rebaseline server hasn't been updated to rebaseline for the chromium-android/
target, and was left on the default of wk2/. Sorry for the noise! :-(.

11:50 AM Changeset in webkit [129678] by peter@chromium.org
  • 1 edit
    69 adds in trunk/LayoutTests

[Chromium] Rebase a few of Mozilla's tests in tables/ for Android.

Unreviewed rebaselining.

This rebaselines a few tests in Mozilla's suite for tables/. All of these
had differences because of Android's different scrollbar. For more context
on Android's baselining, see bug 96398.

  • platform/wk2/tables/mozilla/: 33 new results.
11:47 AM Changeset in webkit [129677] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Unreviewed, rolling out r129521.
​http://trac.webkit.org/changeset/129521
​https://bugs.webkit.org/show_bug.cgi?id=97710

Broke autocomplete on enter_bug.cgi (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

  • committers-autocomplete.js:
11:36 AM Changeset in webkit [129676] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add ability for JSArray::unshiftCount to unshift in middle of an array
​https://bugs.webkit.org/show_bug.cgi?id=97691

Reviewed by Filip Pizlo.

Changed JSArray::unshiftCount and unshiftCountSlowCase to handle unshifting from the middle of an
array. Depending on where the unshift point is, either the front part of the array will be moved
"left" or the back part will be moved right. Given that unshiftCount only works on contiguous
arrays it is safe to use memmove for the moves.

This change is worth 25% performance improvement on pdfjs. It doesn't seem to have any impact on
any other benchmarks.

  • runtime/ArrayPrototype.cpp:

(JSC::unshift):

  • runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::unshiftCount):

  • runtime/JSArray.h:

(JSArray):

11:16 AM Changeset in webkit [129675] by eae@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed chromium mac rebaseline.

  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
11:15 AM Changeset in webkit [129674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Do not dispatch touch-events to plugins unless they explicitly request for touch-events.
​https://bugs.webkit.org/show_bug.cgi?id=97685

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-09-26
Reviewed by Adam Barth.

Plugins need to call setIsAcceptingTouchEvents if they want to receive touch-events. So
avoid dispatching touch-events to plugins unless they have explicitly requested for them.

  • src/WebPluginContainerImpl.cpp:
11:14 AM Changeset in webkit [129673] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97696

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::ensureFontLoaded):

11:11 AM Changeset in webkit [129672] by commit-queue@webkit.org
  • 17 edits
    18 deletes in trunk

Unreviewed, rolling out r129654.
​http://trac.webkit.org/changeset/129654
​https://bugs.webkit.org/show_bug.cgi?id=97702

breaks chromium windows build (Requested by schenney on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

Source/Platform:

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCStatsRequest.h: Removed.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsCallback.h: Removed.
  • Modules/mediastream/RTCStatsCallback.idl: Removed.
  • Modules/mediastream/RTCStatsElement.cpp: Removed.
  • Modules/mediastream/RTCStatsElement.h: Removed.
  • Modules/mediastream/RTCStatsElement.idl: Removed.
  • Modules/mediastream/RTCStatsReport.cpp: Removed.
  • Modules/mediastream/RTCStatsReport.h: Removed.
  • Modules/mediastream/RTCStatsReport.idl: Removed.
  • Modules/mediastream/RTCStatsRequestImpl.cpp: Removed.
  • Modules/mediastream/RTCStatsRequestImpl.h: Removed.
  • Modules/mediastream/RTCStatsResponse.cpp: Removed.
  • Modules/mediastream/RTCStatsResponse.h: Removed.
  • Modules/mediastream/RTCStatsResponse.idl: Removed.
  • WebCore.gypi:
  • platform/chromium/support/WebRTCStatsRequest.cpp: Removed.
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCStatsRequest.h: Removed.
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt: Removed.
  • fast/mediastream/RTCPeerConnection-stats.html: Removed.
11:01 AM Changeset in webkit [129671] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Need implement isWordTextBreak for QT, and WinCE for visual word movement functionality
​https://bugs.webkit.org/show_bug.cgi?id=81136

Patch by Tullio Lucena <​tullio.lucena@openbossa.org> on 2012-09-26
Reviewed by Csaba Osztrogonác.

Unskip some tests that are passing.

  • platform/qt/Skipped:
10:53 AM Changeset in webkit [129670] by pdr@google.com
  • 7 edits in trunk/Source/WebCore

Refactor SMILTimeContainer to maintain animation information instead of recalculating it every frame
​https://bugs.webkit.org/show_bug.cgi?id=96697

Reviewed by Eric Seidel.

SVGTimeContainer can be improved by maintaining extra information about
animations during schedule/unschedule instead of re-calculating it
every frame.

After this patch, SMILTimeContainer maintains a GroupedAnimationsMap instead of
just a Vector. This map maps a list of animations to the specific ElementAttributePair
that will be animated.

On schedule/unschedule we modify this map instead of creating it in updateAnimations.
As a result, we need to be careful about always notifying (or, re-scheduling) the
time container when either an animation's target changes or an animation's attributeName
changes. This notification is managed by tracking changes with targetElementWillChange
and setAttributeName.

After this patch, updateAnimations only iterates over m_scheduledAnimations.
Furthermore, the sorting of animations by priority is now done over each Vector of
SVGSMILElements affecting a {SVGElement*, QualifiedName} pair instead of over all the
SVGSMILElements at once.

Lastly, a guard (m_preventScheduledAnimationsChanges) has been added
to prove that we do not modify the scheduled animations map out
from under ourselves.

No new tests as this is just a refactoring.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::hasValidAttributeType):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeName):

Per the spec, AnimateMotion is not affected by attributeName. Instead
of having a special case for this in SMILTimeContainer::updateAnimations
we simply implement this method.

(WebCore):

  • svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::updateAnimation):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore):
(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::~SMILTimeContainer):

This method now cleans up the map since we have dynamically allocated
Vectors in it.

(WebCore::SMILTimeContainer::schedule):

Here we are just adding an entry to the map. There is some special handling
for creating the Vector of one does not exist.

(WebCore::SMILTimeContainer::unschedule):
(WebCore::SMILTimeContainer::notifyIntervalsChanged):
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::startTimer):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:

(WebCore::SMILTimeContainer::create):
(SMILTimeContainer):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
(WebCore):
(WebCore::SVGSMILElement::hasValidAttributeName):
(WebCore::SVGSMILElement::svgAttributeChanged):
(WebCore::SVGSMILElement::setAttributeName):
(WebCore::SVGSMILElement::targetElementWillChange):
(WebCore::SVGSMILElement::resetTargetElement):
(WebCore::SVGSMILElement::resolveFirstInterval):
(WebCore::SVGSMILElement::beginListChanged):
(WebCore::SVGSMILElement::endListChanged):
(WebCore::SVGSMILElement::progress):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

10:51 AM Changeset in webkit [129669] by rniwa@webkit.org
  • 6 edits in trunk/PerformanceTests

Use runPerSecond in PerformanceTests/Bindings/typed-array* and event-target-wrapper
​https://bugs.webkit.org/show_bug.cgi?id=97625

Reviewed by Eric Seidel.

Use PerfTestRunner.runPerSecond instead of PerfTestRunner.run. Also reduce the fixed number of
elements and iterations in these tests by a factor of 10 since runPerSecond can dynamically
adjust the number of function calls.

  • Bindings/event-target-wrapper.html:
  • Bindings/typed-array-construct-from-array.html:
  • Bindings/typed-array-construct-from-same-type.html:
  • Bindings/typed-array-construct-from-typed.html:
  • Bindings/typed-array-set-from-typed.html:
10:43 AM Changeset in webkit [129668] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Update SVGFontData for 8 bit TextRun changes
​https://bugs.webkit.org/show_bug.cgi?id=97379

Reviewed by Geoffrey Garen.

Educated applySVGGlyphSelection to be 8 / 16 bit TextRun aware.

No change in funcitonality, therefore no new tests.

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

10:41 AM Changeset in webkit [129667] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix for Chromium TestExpectations

  • platform/chromium/TestExpectations:
10:27 AM Changeset in webkit [129666] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix find-in-page corner case for detached frames
​https://bugs.webkit.org/show_bug.cgi?id=97688

Reviewed by Adam Barth.

Adds a check to prevent crashes when running find-in-page requests
on detached frames.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):

10:27 AM Changeset in webkit [129665] by eae@chromium.org
  • 149 edits
    25 adds
    39 deletes in trunk/LayoutTests

Unreviewed chromium mac rebaseline for r129656.

  • css1/formatting_model/vertical_formatting-expected.txt: Added.
  • fast/box-sizing/box-sizing-expected.png: Added.
  • fast/css/hsl-color-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-styles-expected.txt: Replaced.
  • fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Replaced.
  • fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Replaced.
  • fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Replaced.
  • fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Replaced.
  • fast/multicol/span/span-as-nested-columns-child-expected.txt: Replaced.
  • fast/multicol/span/span-margin-collapsing-expected.txt: Replaced.
  • fast/text/whitespace/024-expected.txt: Added.
  • platform/chromium-linux-x86/fast/html: Removed.
  • platform/chromium-linux-x86/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.txt: Removed.
  • platform/chromium-linux/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/hsl-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/updateLayoutForHitTest-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.txt:
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-mac/fast/css/hsl-color-expected.png:
  • platform/chromium-mac/fast/css/hsl-color-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/line-breaks-expected.txt:
  • platform/chromium-mac/fast/text/whitespace/024-expected.txt:
  • platform/chromium-mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-mac/svg/custom/viewBox-hit-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.txt:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-mac/tables/mozilla/other/test3-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-win-xp/fast/box-sizing: Removed.
  • platform/chromium-win-xp/fast/box-sizing/box-sizing-expected.png: Removed.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/parser/style-script-head-test-expected.txt: Replaced.
  • platform/efl/css1/formatting_model/vertical_formatting-expected.txt: Removed.
  • platform/efl/fast/box-sizing/box-sizing-expected.png: Removed.
  • platform/efl/fast/css/hsl-color-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/efl/fast/text/whitespace/024-expected.txt: Removed.
  • platform/efl/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/efl/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug2479-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/other/test3-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Removed.
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Removed.
  • platform/gtk/fast/box-sizing/box-sizing-expected.png: Removed.
  • platform/gtk/fast/css/hsl-color-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/024-expected.txt: Removed.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug2479-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/other/test3-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Removed.
  • platform/win-future/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
  • svg/wicd/rightsizing-grid-expected.txt: Added.
  • svg/wicd/test-rightsizing-b-expected.txt: Added.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • tables/mozilla/bugs/bug2479-1-expected.txt: Added.
  • tables/mozilla/other/test3-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
10:26 AM Changeset in webkit [129664] by msaboff@apple.com
  • 6 edits in trunk/Source

Update ComplexTextController for 8 bit TextRun changes
​https://bugs.webkit.org/show_bug.cgi?id=97378

Reviewed by Geoffrey Garen.

Source/WebCore:

Since the ComplextTextController code is primarily used for UChar data, just upconvert an 8 bit
TextRun into a new String and hold on to the String with a vector for the life of the controller.

No change in functionality, therefore no new tests.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::collectComplexTextRuns):

  • platform/graphics/mac/ComplexTextController.h:

(ComplexTextController):

Source/WTF:

Add a new create method to make a 16 bit string from 8 bit source data. This is used in
ComplexTextController when we have LChar* + length text data, but we really want 16 bit
data for the complex text rendering code.

  • wtf/text/WTFString.cpp:

(WTF::String::make16BitFrom8BitSource):
(WTF):

  • wtf/text/WTFString.h:

(String):

10:24 AM Changeset in webkit [129663] by msaboff@apple.com
  • 2 edits in trunk/Tools

Unreviewed build change.

Reverting inadvertent change to project file.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:54 AM Changeset in webkit [129662] by msaboff@apple.com
  • 7 edits in trunk

Add Latin-1 Line Break Iterator to TextBreakIteratorICU.cpp
​https://bugs.webkit.org/show_bug.cgi?id=96935

Reviewed by Geoffrey Garen.

Added a Latin-1 UText implementation for the ICU library to use. Added a new acquireLineBreakIterator() for
8 bit strings that uses the Latin-1 UText implementation. This code path is not being called with the current
ToT code. Subsequent changes will enable calling the new code.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::uTextLatin1Clone):
(WebCore::uTextLatin1NativeLength):
(WebCore::uTextLatin1Access):
(WebCore::uTextLatin1Extract):
(WebCore::uTextLatin1MapOffsetToNative):
(WebCore::uTextLatin1MapNativeIndexToUTF16):
(WebCore::uTextLatin1Close):
(WebCore::UTextOpenLatin1):
(WebCore::acquireLineBreakIterator):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

9:47 AM Changeset in webkit [129661] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitJavascriptResult
​https://bugs.webkit.org/show_bug.cgi?id=96780

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:

(_WebKitJavascriptResult::_WebKitJavascriptResult):
(webkitJavascriptResultCreate):

  • UIProcess/API/gtk/WebKitJavascriptResultPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptCallback):

9:45 AM Changeset in webkit [129660] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-26
Reviewed by Rob Buis.

Last fix to NetworkJob to invoke AuthenticationChallenge by resetting
BlackBerryPlatformSettings's proxy credentials to "" if authentication
failed.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

9:44 AM Changeset in webkit [129659] by peter@chromium.org
  • 5 edits
    367 adds in trunk/LayoutTests

[Chromium] Second part of Android's fast/ rebaselining.

Unreviewed rebaselining.

Second part of baselining in fast/. Equal to the first part (r129642),
most of the tests were failing because of the scrollbar of text selection
color. Bugs will be filed for all genuine failures, and every test has
been looked at and compared with Linux individually.

General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/fast/block/: 71 new results.
  • platform/chromium-android/fast/multicol/: 93 new results.
  • platform/chromium-android/fast/overflow/: 52 new results.
  • platform/chromium-android/fast/repaint/: 67 new results.
  • platform/chromium-android/fast/table/: 44 new results.
  • platform/chromium-android/fast/text/: 22 new results.
9:33 AM Changeset in webkit [129658] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update padding in ensureFocusTextElementVisible to be DPI independent.
​https://bugs.webkit.org/show_bug.cgi?id=97684

Reviewed by Rob Buis.

Update padding in ensureFocusTextElementVisible to be DPI
independent and relative to the current zoom level.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

9:29 AM Changeset in webkit [129657] by kenneth@webkit.org
  • 5 edits in trunk/Source/WebCore

Reorder Cairo WebCore includes
​https://bugs.webkit.org/show_bug.cgi?id=97679

Reviewed by Simon Hausmann.

  • platform/graphics/cairo/FontCairo.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/TransformationMatrixCairo.cpp:
  • platform/wx/wxcode/cairo/non-kerned-drawing.cpp:
9:25 AM Changeset in webkit [129656] by eae@chromium.org
  • 98 edits
    2 adds in trunk

Change FractionalLayoutUnit denominator to 64 to reduce precision loss when converting to floating point
​https://bugs.webkit.org/show_bug.cgi?id=96139

Reviewed by Eric Seidel.

Source/WebCore:

We currently use a denominator of 60 in FractionalLayoutUnit,
this causes a loss of precision when converting to floating
point.

By changing the denominator to 64 the values can better be
represented as floating point (without loosing any precision for
many values), this in turn allows us to remove the tolerance
hack in the line break logic and avoids problems caused by this
precision for web sites that do their own layout based on
element measurements.

Test: fast/sub-pixel/float-precision.html

  • platform/FractionalLayoutUnit.h:

Change denominator to 64.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitsOnLine):
Remove epsilon tolerance hack.

LayoutTests:

Add new precision test and adjust expectations for existing tests as needed.

  • fast/sub-pixel/float-precision-expected.html: Added.
  • fast/sub-pixel/float-precision.html: Added.
  • fast/sub-pixel/float-wrap-with-subpixel-top-expected.html:
  • fast/sub-pixel/float-wrap-with-subpixel-top.html:
  • fast/sub-pixel/layout-boxes-with-zoom-expected.html:
  • fast/sub-pixel/layout-boxes-with-zoom.html:
  • fast/sub-pixel/size-of-box-with-zoom-expected.html:
  • fast/sub-pixel/size-of-box-with-zoom.html:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.txt:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-linux/fast/css/hsl-color-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-marker-style-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open1-expected.png:
  • platform/chromium-linux/fast/html/details-open3-expected.png:
  • platform/chromium-linux/fast/html/details-open5-expected.png:
  • platform/chromium-linux/fast/html/details-position-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-linux/fast/parser/style-script-head-test-expected.txt:
  • platform/chromium-linux/fast/text/line-breaks-expected.txt:
  • platform/chromium-linux/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-linux/svg/custom/viewBox-hit-expected.png:
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-win/fast/css/hsl-color-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/chromium-win/fast/text/whitespace/024-expected.txt:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/chromium-win/tables/mozilla/other/test3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
9:18 AM Changeset in webkit [129655] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix after r129647.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp: Revert incorrect include reordering.
9:16 AM Changeset in webkit [129654] by commit-queue@webkit.org
  • 17 edits
    2 copies
    16 adds in trunk

Implement the GetStats interface on PeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=95193

Source/Platform:

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):
(WebKit::WebRTCPeerConnectionHandler::getStats):

  • chromium/public/WebRTCStatsRequest.h: added.

(WebCore):
(WebKit):
(WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::~WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::operator=):

Source/WebCore:

Specification:
​http://dev.w3.org/2011/webrtc/editor/webrtc-20120920.html

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

The implementation consists of a pure virtual platform object
(RTCStatsRequest) that is implemented in WebCore, and stores
its information in a straightforward data hierarchy.
This patch adds the call path and the storage structures.
It does not add filling in data.

Test: fast/mediastream/RTCPeerConnection-stats.html

  • CMakeLists.txt:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsCallback.h: Added.

(WebCore):
(RTCStatsCallback):
(WebCore::RTCStatsCallback::~RTCStatsCallback):

  • Modules/mediastream/RTCStatsCallback.idl: Added.
  • Modules/mediastream/RTCStatsElement.cpp: Added.

(WebCore):
(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):
(WebCore::RTCStatsElement::stat):

  • Modules/mediastream/RTCStatsElement.h: Added.

(WebCore):
(RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.idl: Added.
  • Modules/mediastream/RTCStatsReport.cpp: Added.

(WebCore):
(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::RTCStatsReport):

  • Modules/mediastream/RTCStatsReport.h: Added.

(WebCore):
(RTCStatsReport):
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):

  • Modules/mediastream/RTCStatsReport.idl: Added.
  • Modules/mediastream/RTCStatsRequestImpl.cpp: Added.

(WebCore):
(WebCore::RTCStatsRequestImpl::create):
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::~RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::requestSucceeded):
(WebCore::RTCStatsRequestImpl::stop):
(WebCore::RTCStatsRequestImpl::clear):

  • Modules/mediastream/RTCStatsRequestImpl.h: Added.

(WebCore):
(RTCStatsRequestImpl):

  • Modules/mediastream/RTCStatsResponse.cpp: Added.

(WebCore):
(WebCore::RTCStatsResponse::create):
(WebCore::RTCStatsResponse::RTCStatsResponse):

  • Modules/mediastream/RTCStatsResponse.h: Added.

(WebCore):
(RTCStatsResponse):
(WebCore::RTCStatsResponse::result):

  • Modules/mediastream/RTCStatsResponse.idl: Added.
  • WebCore.gypi:
  • platform/chromium/support/WebRTCStatsRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCStatsRequest::WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::assign):
(WebKit::WebRTCStatsRequest::reset):
(WebKit::WebRTCStatsRequest::requestSucceeded):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCStatsRequest.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h.

(WebCore):
(RTCStatsRequest):
(WebCore::RTCStatsRequest::~RTCStatsRequest):
(WebCore::RTCStatsRequest::RTCStatsRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::getStats):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCStatsRequestSucceededTask):
(RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(MockWebRTCPeerConnectionHandler::getStats):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

  • fast/mediastream/RTCPeerConnection-stats-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-stats.html: Added.
9:12 AM Changeset in webkit [129653] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2][WTR] Policy client: dumping from decidePolicyForResponse callback
​https://bugs.webkit.org/show_bug.cgi?id=97034

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Exported WebCore::ResourceResponseBase::isAttachment() method for MAC port.

No new tests. No functionality added.

  • WebCore.exp.in:

Source/WebKit2:

Added suggested filename getter to WKURLResponse interface and also added a property showing whether the response
is attachment.

  • Shared/API/c/WKURLResponse.cpp:

(WKURLResponseSuggestedFilename):
(WKURLResponseIsAttachment):

  • Shared/API/c/WKURLResponse.h:

Tools:

Provided dumping from WTR Policy client 'decidePolicyForResponse' callback.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::decidePolicyForResponse):

LayoutTests:

Unskipped some of http/tests/download tests from wk2/Skipped, put those which still fail
to an appropriate group in wk2/Skipped file. All of the http/tests/download tests still fail
for EFL WK1.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/wk2/Skipped:
9:00 AM Changeset in webkit [129652] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

(Threaded scrolling) WebKit not scrolling to the correct location upon going back on macsurfer.com
<rdar://problem/12039913> and ​https://bugs.webkit.org/show_bug.cgi?id=97617

Reviewed by Anders Carlsson.

In the asynchronous land of threaded scrolling we lose the information about whether or not a scroll
is programmatic.

This caused all scrolls to be treated as user scrolls and to generated scroll events.

We can fix this by passing the programmatic bit to the scrolling thread and re-applying it back in the main thread.

Unable to test threaded scrolling at this time.

Include the "Is programmatic scroll" bit in the scroll state:

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setRequestedScrollPosition): Also set whether or not this represents a programmatic scroll.

  • page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):
(WebCore::ScrollingTreeState::representsProgrammaticScroll):

Pass that bit back to the ScrollingCoordinator:

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::updateMainFrameScrollPosition):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate): Pass the "is programmatic scroll" bit to the scrolling thread.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition): Reset the "is programmatic scroll" bit on the FrameView.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::inProgrammaticScroll): Expose setter/getters for the programmatic scroll flag.
(WebCore::FrameView::setInProgrammaticScroll):

8:53 AM Changeset in webkit [129651] by Martin Robinson
  • 19 edits in trunk

[GTK] Use XDamage to simplify RedirectedXCompositeWindow
​https://bugs.webkit.org/show_bug.cgi?id=97267

Reviewed by Alejandro G. Castro.

Use XDamage to queue redraws of the widget when redirecting accelerated compositing
to an offscreen window. This allows removing a finicky timer-based approach, improves
performance, and allows simplifying things greatly.

.:

  • configure.ac: Add support for finding XDamage via pkg-config.

Source/WebCore:

No new tests. This is covered by existing tests.

  • GNUmakefile.am: Add the XDamage CFLAGS in the appropriate place.
  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::getWindowHashMap): Added.
(WebCore::filterXDamageEvent): Added.
(WebCore::supportsXDamageAndXComposite): Added.
(WebCore::RedirectedXCompositeWindow::create): Fail to create the window if
the XServer doesn't support XDamage and XComposite.
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Add XDamage support and
remove the m_usable size distinction. Add the window the window HashMap now.
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow): Remove the window
from the window HashMap.
(WebCore::RedirectedXCompositeWindow::resize): Now just immediately update the size.
(WebCore::RedirectedXCompositeWindow::callDamageNotifyCallback): Added.

  • platform/gtk/RedirectedXCompositeWindow.h:

(WebCore::RedirectedXCompositeWindow::setDamageNotifyCallback): Added.

Source/WebKit/gtk:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS.
  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Change the signature of compositeLayersToContext
to accept an enum that explains the composite purpose.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::redirectedWindowDamagedCallback): Added.
(WebKit::AcceleratedCompositingContext::initialize): Handle the situation where
the RedirectedXCompositeWindow returns a null pointer.
(WebKit::AcceleratedCompositingContext::enabled): Ditto.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Remove the code handling
the usable size of the RedirectedXCompositeWindow. The usable size is now always equal
to the size.
(WebKit::AcceleratedCompositingContext::compositeLayersToContext): When drawing for a
resize, first clear the entire context. Remove the double swap-buffer, as it's no
longer necessary.
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer): Handle the case that
the redirected window is null.
(WebKit::AcceleratedCompositingContext::resizeRootLayer): Instead of doing another
immediate layer flush, just recomposite the current layer state and schedule a new
flush. This should make resizing faster.
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers): We no longer need to
queue a redraw, unless we want to force one.

Source/WebKit2:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS to the appropriate places.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Remove readyToRenderAcceleratedCompositingResults as
it's no longer necessary.
(webkit_web_view_base_init): Handle the situation where the RedirectedXCompositeWindow
is null.
(webkitWebViewRenderAcceleratedCompositingResults): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseCreateWebPage): Ditto.
(redirectedWindowDamagedCallback): Added.

  • UIProcess/WebPageProxy.h: Remove InvalidateWidget message.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::compositeLayersToContext): No longer need to
trigger the invalidateWindow message.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Ditto.
8:27 AM Changeset in webkit [129650] by schenney@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
8:21 AM Changeset in webkit [129649] by loislo@chromium.org
  • 12 edits
    1 copy in trunk/Source

Web Inspector: NMI: replace manual JS external resources counting with MemoryInstrumentation
​https://bugs.webkit.org/show_bug.cgi?id=97662

Reviewed by Yury Semikhatsky.

Source/WebCore:

Old schema uses sizeInBytes method on StringImpl. This method works incorrect for substrings.
Also we'd like to know exact pointers to strings and buffers for verification purposes.

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

Source/WebKit/chromium:

Old schema used sizeInBytes method on StringImpl. This method works incorrect for substrings.
Also we'd like to know exact pointers to strings and buffers for verification purposes.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

Source/WTF:

Old schema uses sizeInBytes method on StringImpl. This method works incorrect for substrings.
Also we'd like to know exact pointers to strings and buffers for verification purposes.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentationArrayBufferView.h:

(WTF):
(WTF::reportMemoryUsage):

8:19 AM Changeset in webkit [129648] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [REGRESSION] Revision support problems: revert and apply original content cause exceptions
​https://bugs.webkit.org/show_bug.cgi?id=97669

Reviewed by Pavel Feldman.

Source/WebCore:

Added missed callback parameters.

Test: inspector/uisourcecode-revisions.html

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):

LayoutTests:

  • inspector/uisourcecode-revisions-expected.txt: Added.
  • inspector/uisourcecode-revisions.html: Added.
8:17 AM Changeset in webkit [129647] by kenneth@webkit.org
  • 23 edits in trunk/Source/WebCore

Reorder Qt WebCore includes
​https://bugs.webkit.org/show_bug.cgi?id=97678

Reviewed by Noam Rosenthal.

  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_pixmapruntime.cpp:
  • bridge/qt/qt_runtime.cpp:
  • platform/graphics/qt/FontCacheQt.cpp:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/ImageDecoderQt.cpp:
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/qt/TransformationMatrixQt.cpp:
  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
  • platform/network/qt/DnsPrefetchHelper.h:
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/GamepadsQt.cpp:
  • platform/qt/PasteboardQt.cpp:
  • platform/qt/PlatformScreenQt.cpp:
  • platform/qt/RenderThemeQt.cpp:
  • platform/text/qt/TextBoundariesQt.cpp:
  • plugins/qt/PluginPackageQt.cpp:
  • plugins/qt/PluginViewQt.cpp:
8:13 AM Changeset in webkit [129646] by commit-queue@webkit.org
  • 23 edits
    1 add in trunk

[EFL] mediaControlsEflFullscreen.css overrides regular media controls styling
​https://bugs.webkit.org/show_bug.cgi?id=97671

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add missing ":-webkit-full-screen" in mediaControlsEflFullscreen.css so
that regular media controls styling is not overridden by full screen
styling when switching to full screen mode. This was causing a lot of
flakiness in our media tests.

No new tests, already covered by existing media tests.

  • css/mediaControlsEflFullscreen.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen:-webkit-full-page-media::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-mute-button):
(video:-webkit-full-screen::-webkit-media-controls-play-button):
(video:-webkit-full-screen::-webkit-media-controls-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-current-time-display):
(video:-webkit-full-screen::-webkit-media-controls-time-remaining-display):
(video:-webkit-full-screen::-webkit-media-controls-timeline):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider-container):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider):
(video:-webkit-full-screen::-webkit-media-controls-seek-back-button):
(video:-webkit-full-screen::-webkit-media-controls-seek-forward-button):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-button):
(video:-webkit-full-screen::-webkit-media-controls-rewind-button):
(video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
(video:-webkit-full-screen::-webkit-media-controls-toggle-closed-captions-button):

LayoutTests:

Unskip several media tests that are no longer flaky
now that we address media controls styling issues
when switching to full screen mode.

Some tests needed rebaselining. The rebaseline is unrelated
to this change but was needed in order to unskip the tests.

  • platform/efl/TestExpectations:
  • platform/efl/media/controls-after-reload-expected.png:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.png:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-without-preload-expected.png:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/media/sources-fallback-codecs-expected.txt: Added.
  • platform/efl/media/video-controls-rendering-expected.png:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.png:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/media/video-empty-source-expected.png:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.png:
  • platform/efl/media/video-zoom-controls-expected.txt:
8:04 AM Changeset in webkit [129645] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: display stack of last layout invalidation instead of first one
​https://bugs.webkit.org/show_bug.cgi?id=97677

Reviewed by Vsevolod Vlasov.

  • add a call to InspectorInstrumentation::didInvalidateLayout() when upgrading relayout root;
  • do not suppress timeline's Invalidate Layout records other than first.
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didInvalidateLayout):

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayoutOfSubtree):

7:52 AM Changeset in webkit [129644] by Antti Koivisto
  • 6 edits
    1 add in trunk

Optimize stylesheet insertions
​https://bugs.webkit.org/show_bug.cgi?id=97627

Reviewed by Andreas Kling.

PerformanceTests:

Add synthetic performance test for avoiding style recalcs on stylesheet inserts.

  • CSS/StyleSheetInsert.html: Added.

Source/WebCore:

We currently do scope analysis for stylesheets that are added to the end of the active stylesheet list to avoid unnecessary style
recalcs and StyleResolver rebuilding. However it is somewhat common to insert <style> elements dynamically to positions other than last.
In this case we currently simply force full style recalc. We should do scope analysis and partial style recalcs also in these cases.

PerformanceTests/CSS/StyleSheetInsert.html microbenchmark shows ~20x progression from the patch.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::resetAuthorStyle):

Add a way to reset author RuleSet without deleting the whole StyleResolver.

(WebCore):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):

Check if there have been insertions to the stylesheet list. If so we need to reset
the StyleResolver (to handle rule position changes) but don't need to force full
style recalc. Do scope analysis for inserted stylesheets as well.

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

  • dom/DocumentStyleSheetCollection.h:
7:35 AM Changeset in webkit [129643] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Gesture tap highlighting entire first line
​https://bugs.webkit.org/show_bug.cgi?id=97668

Patch by Allan Sandfeld Jensen <​allan.jensen@digia.com> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Keep better track if which part is the first, middle or last, and adjust the X-edges accordingly.

  • page/GestureTapHighlighter.cpp:
7:35 AM Changeset in webkit [129642] by peter@chromium.org
  • 2 edits
    408 adds in trunk/LayoutTests

[Chromium] First part of rebaselines for the fast/ directory.

Unreviewed rebaselining.

First part of the baselines for fast/. Most of these address, once again, the
different scrollbar appearance, layout size (due to overlay scrollbars) and
text selection color. Notable failures include that Kanji characters are
rendered bold and Android seems to limit styling abilities for selection text.
Bugs will be filed for these failures.

General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/fast/backgrounds/: 7 new results.
  • platform/chromium-android/fast/body-propagation/: 38 new results.
  • platform/chromium-android/fast/borders/: 32 new results.
  • platform/chromium-android/fast/box-shadow/: 2 new results..
  • platform/chromium-android/fast/box-sizing/: 2 new results.
  • platform/chromium-android/fast/canvas/: 7 new results.
  • platform/chromium-android/fast/clip/: 2 new results.
  • platform/chromium-android/fast/css-generated-content/: 4 new results.
  • platform/chromium-android/fast/css/: 77 new results.
  • platform/chromium-android/fast/dom/: 20 new results.
  • platform/chromium-android/fast/dynamic/: 7 new results.
  • platform/chromium-android/fast/encoding/: 4 new results.
  • platform/chromium-android/fast/events/: 7 new results.
  • platform/chromium-android/fast/flexbox/: 6 new results.
  • platform/chromium-android/fast/forms/: 25 new results.
  • platform/chromium-android/fast/frames/: 20 new results.
  • platform/chromium-android/fast/gradients/: 5 new results.
  • platform/chromium-android/fast/hidpi/: 2 new results.
  • platform/chromium-android/fast/html/: 4 new results.
  • platform/chromium-android/fast/images/: 6 new images.
  • platform/chromium-android/fast/inline-block/: 2 new results.
  • platform/chromium-android/fast/inline/: 8 new results.
  • platform/chromium-android/fast/invalid/: 2 new results.
  • platform/chromium-android/fast/js/: 2 new results.
  • platform/chromium-android/fast/layers/: 6 new results.
  • platform/chromium-android/fast/line-grid/: 4 new results.
  • platform/chromium-android/fast/lists/: 16 new results.
  • platform/chromium-android/fast/media/: 24 new results.
  • platform/chromium-android/fast/reflections/: 2 new results.
  • platform/chromium-android/fast/replaced/: 9 new results.
  • platform/chromium-android/fast/selectors/: 3 new results.
  • platform/chromium-android/fast/sub-pixel/: 3 new results.
  • platform/chromium-android/fast/transforms/: 4 new results.
  • platform/chromium-android/fast/writing-mode/: 15 new results.
  • platform/chromium-android/platform/chromium/fast/text/: 1 new result.
7:23 AM Changeset in webkit [129641] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: DefaultTextEditor throws exception sometimes.
​https://bugs.webkit.org/show_bug.cgi?id=97681

Reviewed by Alexander Pavlov.

Added a check that line number does not exceed text model line count.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._positionToSelection):

7:23 AM Changeset in webkit [129640] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][WTR] Build fix for MSVC.
​https://bugs.webkit.org/show_bug.cgi?id=97667

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-26
Reviewed by Csaba Osztrogonác.

WTR misses InjectedBundle headers. Adding $$PWD to Target.pri is required for MSVC. Clean build is necessary on Windows.

  • WebKitTestRunner/InjectedBundle/Target.pri:
7:14 AM Changeset in webkit [129639] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip http/tests/security/xss-eval.html again after r129629.

  • platform/qt/Skipped:
7:12 AM Changeset in webkit [129638] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

[TextureMapper] Remove unused method
​https://bugs.webkit.org/show_bug.cgi?id=97675

Reviewed by Simon Hausmann.

  • platform/graphics/texmap/TextureMapperGL.h: Remove uidForImage()
7:10 AM Changeset in webkit [129637] by loislo@chromium.org
  • 21 edits
    2 copies in trunk/Source

Web Inspector: extract HashSet instrumentation from core NMI code and put it into MemoryInstrumentationHashSet.h
​https://bugs.webkit.org/show_bug.cgi?id=97198

Reviewed by Yury Semikhatsky.

Current implementation has overloads for HashSet.
This prevents us from instrumenting complex cases like Vector<HashSet<...> >.

Source/WebCore:

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/HashSet.h:

(WTF):
(HashSet):

  • wtf/HashTable.h:

(WTF):
(HashTable):

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryClassInfo::addCollectionElements):
(WTF::MemoryClassInfo::addHashCountedSet):

  • wtf/MemoryInstrumentationHashSet.h: Added.

(WTF):
(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashTable.h: Added.

(WTF):
(WTF::reportMemoryUsage):

7:08 AM Changeset in webkit [129636] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebCore

[soup] Obey setTimeoutInterval in soup backend
​https://bugs.webkit.org/show_bug.cgi?id=94796

Reviewed by Gustavo Noronha Silva.

Implementing ResourceHandle's setTimeoutInterval support for the soup backend.
This is preparatory work for bug 74802, timeout support for XHR2. The patch
has been successfully tested in combination with my work-in-progress
for that bug.

No new tests yet, tests will be added with the patch in bug 74802.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal): Adding a timeout source.
(ResourceHandleInternal):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::cleanupSoupRequestOperation): Resetting the timer.
(WebCore::sendRequestCallback): Stopping the timer.
(WebCore::startHTTPRequest): Starting a timeout timer before the async request.
(WebCore::ResourceHandle::platformSetDefersLoading): Starting a timeout timer before the async request.
(WebCore::requestTimeoutCallback): Preparing a corresponding resource error and notifying clients of failure.
(WebCore::startNonHTTPRequest): Starting a timeout timer before the async request.

7:08 AM Changeset in webkit [129635] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r129629.

Marking http/tests/security/xss-eval.html as failing again because of the fix being rolled out.

  • platform/efl/TestExpectations:
7:07 AM Changeset in webkit [129634] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] [DRT] eventSender.keyDown() doesn't support Ctrl key modifier
​https://bugs.webkit.org/show_bug.cgi?id=97665

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2012-09-26
Reviewed by Rob Buis.

This patch fixes test fast/forms/input-text-option-delete.html.

  • DumpRenderTree/blackberry/EventSender.cpp:

(keyDownCallback):

7:05 AM Changeset in webkit [129633] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: paint inspector overlay on a transparency layer
​https://bugs.webkit.org/show_bug.cgi?id=97659

Reviewed by Pavel Feldman.

Set composite operation to copy and begin transparency layer before painting the

frame view of overlay page, so that text on transparent background is properly rendered.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

7:03 AM Changeset in webkit [129632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Make use of ASCIILiteral in PlatformKeyboardEventQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=97612

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Jocelyn Turcotte.

String literals returned by keyIdentifierForQtKeyCode and
keyTextForKeyEvent now make use of more efficient ASCIILiteral.

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::keyIdentifierForQtKeyCode):
(WebCore::keyTextForKeyEvent):

6:28 AM Changeset in webkit [129631] by dinu.s.jacob@intel.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
6:28 AM Changeset in webkit [129630] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Added failure expectations for fast/js tests:
fast/js/string-localeCompare.html
fast/js/dfg-array-push-bad-time.html
fast/js/dfg-array-push-slow-put.html

  • platform/chromium/TestExpectations:
6:21 AM Changeset in webkit [129629] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r129592.
​http://trac.webkit.org/changeset/129592
​https://bugs.webkit.org/show_bug.cgi?id=97670

Failures in Chromium security tests (Requested by schenney on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

Source/JavaScriptCore:

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

LayoutTests:

  • fast/js/eval-cross-window-expected.txt:
  • fast/js/eval-cross-window.html:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/resources/xss-eval2.html:
  • http/tests/security/resources/xss-eval3.html:
  • http/tests/security/xss-eval-expected.txt:
  • http/tests/security/xss-eval.html:
6:16 AM Changeset in webkit [129628] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Roll out ​http://trac.webkit.org/changeset/129502 since it broke cookie table.
​https://bugs.webkit.org/show_bug.cgi?id=97471

  • inspector/front-end/CookieParser.js:

(WebInspector.Cookie.prototype.expires):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._createGridNode):

5:55 AM Changeset in webkit [129627] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Remove color codes characters from run-gtk-tests output when not writing to a TTY
​https://bugs.webkit.org/show_bug.cgi?id=97660

Reviewed by Philippe Normand.

Remove also the '\r' characters returned by TTY output to try to fix
the double line endings of the script output in the bots.

  • Scripts/run-gtk-tests:

(TestRunner.init): Compile a regexp for color codes if stdout
it not a TTY.
(TestRunner._run_test_command.parse_line): Remove color codes and
'\r' characters from the line returned by the pseudo-terminal if
stdout is not a TTY.

  • gtk/common.py:

(parse_output_lines): Fix the last chunk check to make sure we
always send entire lines to the callback, otherwise color codes
regexp might fail if the line is not complete.

5:52 AM Changeset in webkit [129626] by vsevik@chromium.org
  • 21 edits in trunk

Web Inspector: Remove resource() getter from UISourceCode.
​https://bugs.webkit.org/show_bug.cgi?id=97557

Reviewed by Pavel Feldman.

Source/WebCore:

Resource getter removed from UISourceCode. Resource could be fetched from ResourceTreeModel directly.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSource):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):

  • inspector/front-end/StyleSource.js:

(WebInspector.StyleSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

LayoutTests:

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code-display-name.html:
  • inspector/debugger/ui-source-code.html:
5:50 AM Changeset in webkit [129625] by vsevik@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: Fix closure compilation errors.
​https://bugs.webkit.org/show_bug.cgi?id=97666

Reviewed by Alexander Pavlov.

Fixed closure compilation errors.
Changed contentProvider contentURL() method return type to string.
Removed redundant () in CookieTable.

  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/ContentProvider.js:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentURL):
(WebInspector.StaticContentProvider.prototype.contentURL):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._createGridNode):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMDocument):

  • inspector/front-end/FileContentView.js:
  • inspector/front-end/NetworkRequest.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Script.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/UISourceCode.js:
5:25 AM Changeset in webkit [129624] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] add a test for inspector overlay update frequency
​https://bugs.webkit.org/show_bug.cgi?id=97567

Reviewed by Yury Semikhatsky.

Added a test for reasonable number of frames caused by inspector page overlay.
We expect changes in nodes being inspected to cause an update, while just idling
should not cause large numbers of unexpected updates.

  • src/js/Tests.js:

(.TestSuite.prototype.testPageOverlayUpdate):
(.TestSuite.prototype.testPageOverlayUpdate.innerAddRecord):
(.TestSuite.prototype.testPageOverlayUpdate.populatePage):
(.TestSuite.prototype.testPageOverlayUpdate.step2):
(.TestSuite.prototype.testPageOverlayUpdate.step4):
(.TestSuite.prototype.testPageOverlayUpdate.step5):

5:09 AM Changeset in webkit [129623] by yurys@chromium.org
  • 15 edits in trunk/Source

Web Inspector: compare objects counted by the memory instrumentation with those allocated in the heap
​https://bugs.webkit.org/show_bug.cgi?id=97641

Reviewed by Pavel Feldman.

Source/WebCore:

Added code that allows to check if all objects counted by the memory instrumentation
were allocated by the underlying memory allocator. It requires support
from the memory allocator. The code works only if the set of allocated objects
is not empty and should only be used for debugging purposes.

  • inspector/InspectorClient.h:

(InspectorClient):
(WebCore::InspectorClient::getAllocatedObjects):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:

(WebCore):
(WebCore::InspectorMemoryAgent::create):
(InspectorMemoryAgent):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore):
(WebCore::MemoryInstrumentationImpl::checkCountedObject):

  • inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationImpl):

Source/WebKit/chromium:

Added code that allows to check if all objects counted by the memory instrumentation
were allocated by the underlying memory allocator. It requires support
from the memory allocator this is why WebDevToolsAgentClient API is extended with a
method that allows to visit pointers to all live heap objects if the memory allocator
supports that.

The code should only be used for debugging purposes.

  • public/WebDevToolsAgentClient.h:

(AllocatedObjectVisitor):
(WebKit::WebDevToolsAgentClient::AllocatedObjectVisitor::~AllocatedObjectVisitor):
(WebKit::WebDevToolsAgentClient::visitAllocatedObjects):
(WebDevToolsAgentClient):

  • src/InspectorClientImpl.cpp:

(WebKit):
(WebKit::InspectorClientImpl::getAllocatedObjects):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit):
(WebKit::WebDevToolsAgentImpl::getAllocatedObjects):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

Source/WTF:

Added a method for checking if reported object was actually allocated in the heap.

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addObjectImpl):

4:50 AM Changeset in webkit [129622] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

SuggestionPicker min width is two pixels wider than it should be
​https://bugs.webkit.org/show_bug.cgi?id=97645

Reviewed by Kent Tamura.

Suggestion picker's minimum width should match inputWidth.

No new tests. Added later in Bug 97645.

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._measureMaxContentWidth):
(SuggestionPicker.prototype._fixWindowSize): We shouldn't be adding ListBorder to inputWidth.

4:27 AM Changeset in webkit [129621] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for <style scoped> tests as the feature is
not being enabled at runtime in WebKitTestRunner.

  • platform/gtk-wk2/TestExpectations:
4:09 AM Changeset in webkit [129620] by rakuco@webkit.org
  • 142 edits in trunk/LayoutTests

[EFL] Rebaseline some remaining tables/mozilla_expected_failures tests.
​https://bugs.webkit.org/show_bug.cgi?id=95489

  • platform/efl/TestExpectations:
  • platform/efl/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/97619-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/standards1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
4:05 AM Changeset in webkit [129619] by peter@chromium.org
  • 1 edit
    162 adds in trunk/LayoutTests

[Chromium] Rebaselines for svg/ and tables/ for Android.

Unreviewed baselining.

Most differences are caused by Android's text selection color, and a few because of
reduced image resize quality and scrollbars. Real issues include slightly different
rendering for controls (most notable <button> and <select>), bugs for which will
be filed as well. General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/svg/: 135 new results.
  • platform/chromium-android/tables/: 13 new results.
3:54 AM WebKit Team edited by mkwst@chromium.org
Adding myself to the committers list. (diff)
3:08 AM Changeset in webkit [129618] by peter@chromium.org
  • 1 edit
    163 adds in trunk/LayoutTests

[Chromium] Rebaseline tests in css2.1/, css3/ and editing/ for Android

Unreviewed rebaselining.

Many differences are due to Android's scrollbars and different text selection
color. Various real failures showed up as well, I'll be filing separate bugs
for these. General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/css2.1/: 3 new results.
  • platform/chromium-android/css3/: 25 new results.
  • platform/chromium-android/editing/: 123 new results.
2:44 AM Changeset in webkit [129617] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r126983.

  • platform/efl/TestExpectations: Marking the RefTest harness check as WontFix as in Chromium.
2:26 AM Changeset in webkit [129616] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unskip test that seems to pass consistently on 32-bits.

It looks like the rounding issues are gone now that we use
jhbuild. While here, update the expected PNG, which was valid
before but had a different pixel hash.

  • platform/efl/TestExpectations:
  • platform/efl/fast/css/percentage-non-integer-expected.png:
2:26 AM Changeset in webkit [129615] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Mark one subpixel test added in r129529 as passing.
Reclassify fast/workers/shared-worker-load-error.html as flaky.
Remove expectations for fast/css/word-spacing-characters.html and
http/tests/security/xss-eval.html, both tests are now passing.

  • platform/gtk/TestExpectations:
2:17 AM Changeset in webkit [129614] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip test that seems to be passing now.

  • platform/efl/Skipped:
2:08 AM Changeset in webkit [129613] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: [TextEditor] fix tab unindent selection restore
​https://bugs.webkit.org/show_bug.cgi?id=97462

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-26
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Selection would be wrongly restored on tab unindent when the last line does not need to be unindented unlike the others.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype._unindentLines):

LayoutTests:

Added test for an unindentation corner case.

  • inspector/editor/indentation-expected.txt:
  • inspector/editor/indentation.html:
2:01 AM Changeset in webkit [129612] by yosin@chromium.org
  • 47 edits in trunk

Source/WebCore: Rename ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
​https://bugs.webkit.org/show_bug.cgi?id=97640

This patch renames ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS feature
flag to ENABLE_INPUT_MULTIPLE_FIELDS_UI for implementing multiple
fields date/time input UI other than input type "time".

No new tests. This patch doesn't change behavior.

  • css/html.css:
  • css/themeWin.css:
  • html/DateTimeFieldsState.cpp:
  • html/DateTimeFieldsState.h:
  • html/TimeInputType.cpp:

(WebCore):

  • html/TimeInputType.h:

(TimeInputType):

  • html/shadow/DateTimeEditElement.cpp:
  • html/shadow/DateTimeEditElement.h:
  • html/shadow/DateTimeFieldElement.cpp:
  • html/shadow/DateTimeFieldElement.h:
  • html/shadow/DateTimeFieldElements.cpp:
  • html/shadow/DateTimeFieldElements.h:
  • html/shadow/DateTimeNumericFieldElement.cpp:
  • html/shadow/DateTimeNumericFieldElement.h:
  • html/shadow/DateTimeSymbolicFieldElement.cpp:
  • html/shadow/DateTimeSymbolicFieldElement.h:
  • platform/LocalizedStrings.h:

(WebCore):

  • platform/text/DateTimeFormat.cpp:
  • platform/text/DateTimeFormat.h:
  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::LocaleICU):
(WebCore::LocaleICU::~LocaleICU):
(WebCore):

  • platform/text/LocaleICU.h:

(LocaleICU):

  • platform/text/LocaleWin.cpp:

(WebCore):

  • platform/text/LocaleWin.h:

(LocaleWin):

  • platform/text/LocalizedNumber.h:

(WebCore):

  • platform/text/LocalizedNumberICU.cpp:

(WebCore):

  • platform/text/LocalizedNumberNone.cpp:

(WebCore):

  • platform/text/Localizer.cpp:

(WebCore):

  • platform/text/Localizer.h:

(Localizer):

  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • platform/text/mac/LocaleMac.mm:

(WebCore):

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore):

  • platform/text/win/LocalizedNumberWin.cpp:

(WebCore):

Source/WebKit/chromium: Rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
​https://bugs.webkit.org/show_bug.cgi?id=97640

Reviewed by Kent Tamura.

This patch renames ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS feature
flag to ENABLE_INPUT_MULTIPLE_FIELDS_UI for implementing multiple
fields date/time input UI other than input type "time".

  • features.gypi:
  • src/LocalizedStrings.cpp:

(WebCore):

  • tests/DateTimeFormatTest.cpp:
  • tests/LocaleMacTest.cpp:

(LocaleMacTest):

  • tests/LocaleWinTest.cpp:

(LocaleWinTest):

  • tests/LocalizedDateICUTest.cpp:
  • tests/LocalizedNumberICUTest.cpp:

LayoutTests: Rename ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
​https://bugs.webkit.org/show_bug.cgi?id=97640

This patch renames ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS feature
flag to ENABLE_INPUT_MULTIPLE_FIELDS_UI for implementing multiple
fields date/time input UI other than input type "time".

  • platfrom/efl/TestExpectations: Update a comment which refers ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS.
  • platform/mac/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
1:50 AM Changeset in webkit [129611] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip that passes after r125813.

  • platform/efl/TestExpectations:
1:39 AM Changeset in webkit [129610] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Rebaseline after r125578.

  • platform/efl/TestExpectations:
  • platform/efl/fast/css/word-space-extra-expected.png:
  • platform/efl/fast/css/word-space-extra-expected.txt:
1:38 AM Changeset in webkit [129609] by Simon Hausmann
  • 5 edits
    23 deletes in trunk

[Qt] Remove Qt Quick 1 support

Reviewed by Kenneth Rohde Christiansen.

It is being moved to the Qt5 QtQuick1 module.

.:

  • Source/tests.pri:

Source/WebKit/qt:

A circular dependency exists otherwise in Qt, where QtWebKit would depend on QtQuick1,
which in turn depends on QtTools (for designer plugin), which in turn depends on QtWebKit
(for assistant help html rendering).

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

  • declarative/public.pri:
  • declarative/qdeclarativewebview.cpp: Removed.
  • declarative/qdeclarativewebview_p.h: Removed.
  • tests/qdeclarativewebview/qdeclarativewebview.pro: Removed.
  • tests/qdeclarativewebview/resources/basic.html: Removed.
  • tests/qdeclarativewebview/resources/basic.png: Removed.
  • tests/qdeclarativewebview/resources/basic.qml: Removed.
  • tests/qdeclarativewebview/resources/elements.html: Removed.
  • tests/qdeclarativewebview/resources/elements.qml: Removed.
  • tests/qdeclarativewebview/resources/forward.html: Removed.
  • tests/qdeclarativewebview/resources/forward.png: Removed.
  • tests/qdeclarativewebview/resources/javaScript.html: Removed.
  • tests/qdeclarativewebview/resources/javaScript.qml: Removed.
  • tests/qdeclarativewebview/resources/loadError.qml: Removed.
  • tests/qdeclarativewebview/resources/newwindows.html: Removed.
  • tests/qdeclarativewebview/resources/newwindows.qml: Removed.
  • tests/qdeclarativewebview/resources/propertychanges.qml: Removed.
  • tests/qdeclarativewebview/resources/sample.html: Removed.
  • tests/qdeclarativewebview/resources/sethtml.qml: Removed.
  • tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Removed.
  • tests/qdeclarativewebview/resources/webviewtest.qml: Removed.
  • tests/qdeclarativewebview/resources/webviewtestdefault.qml: Removed.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Removed.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.qrc: Removed.
1:34 AM Changeset in webkit [129608] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening.

  • platform/qt/Skipped: Unskip http/tests/security/xss-eval.html after r129592.
1:21 AM Changeset in webkit [129607] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviwed gardening.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-26

  • platform/qt-5.0-wk1/Skipped: skip http/tests/security/cross-origin-local-storage-wk1.html.
  • platform/qt-5.0-wk2/Skipped: skip fast/events/popup-blocked-from-fake-user-gesture.html.
1:02 AM Changeset in webkit [129606] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK1] REGRESSION(r123988) It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail
​https://bugs.webkit.org/show_bug.cgi?id=92636

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Csaba Osztrogonác.

Unskip passing test.

  • platform/qt-5.0-wk1/Skipped:
12:41 AM Changeset in webkit [129605] by rakuco@webkit.org
  • 6 edits in trunk

[DRT][WTR] Support overriding the 'WebKitDisplayImagesKey' preference
​https://bugs.webkit.org/show_bug.cgi?id=96883

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Add
support for changing
WebPreferencesKey::loadsImagesAutomaticallyKey().

Tools:

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference): Support the
'WebKitDisplayImagesKey' preference.

LayoutTests:

  • platform/efl/TestExpectations: Unskip test that only fails on

WK2.

12:38 AM Changeset in webkit [129604] by zandobersek@gmail.com
  • 12 edits in trunk

[GTK] Enable some of the unstable CSS features
​https://bugs.webkit.org/show_bug.cgi?id=97572

Reviewed by Martin Robinson.

.:

Export the required RuntimeEnabledFeatures symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

Enable the CSS sticky position, CSS3 text decoration and <style scoped>
features by default but disable them if unstable features are not meant
to be enabled.

No new tests - the related tests are being unskipped or are having failure
expectations removed.

  • GNUmakefile.am:
  • GNUmakefile.features.am:

Source/WebKit/gtk:

Add a helper DumpRenderTreeSupportGtk method for enabling
the <style scoped> support in WebCore. This is used in DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setShadowDOMEnabled): Add missing
ENABLE(SHADOW_DOM) compilation guards.
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk): Remove the 'enabled' parameter name from both
setShadowDOMEnabled and setStyleScopedEnabled method declarations as it adds
no information and is causing style warnings.

Tools:

Enable the <style scoped> support via DumpRenderTreeSupportGtk method
whenever resetting defualts to consistent values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

Remove expectations for the features being enabled and
add more specific failure expectations for tests that are
still failing.

  • platform/gtk/TestExpectations:
12:33 AM Changeset in webkit [129603] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix the typo in the ewk_view_fullscreen_exit()
​https://bugs.webkit.org/show_bug.cgi?id=97635

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-26
Reviewed by Gyuyoung Kim.

Fix the silly typo in the ewk_view_fullscreen_exit() API.

  • ewk/ewk_view.cpp:

(ewk_view_fullscreen_exit):

12:30 AM Changeset in webkit [129602] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix potential build error on LocalFileSystem::deleteFileSystem
​https://bugs.webkit.org/show_bug.cgi?id=97632

Patch by Dongwoo Joshua Im <​dw.im@samsung.com> on 2012-09-26
Reviewed by Yuta Kitamura.

Non-Chrome build of WebKit with FILE_SYSTEM flag will be broken at LocalFileSystem::deleteFileSystem.
Type of the third parameter is PassOwnPtr<AsyncFileSystemCallbacks> in header file,
but PassRefPtr<AsyncFileSystemCallbacks> in cpp file.

Non-Chrome WebKit build with FILE_SYSTEM should be finished successfully.

  • Modules/filesystem/LocalFileSystem.cpp:

(WebCore::LocalFileSystem::deleteFileSystem):

12:21 AM WebKitGtkLayoutTests edited by Philippe Normand
(diff)
12:20 AM Changeset in webkit [129601] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

String.localeCompare should normalize input
​https://bugs.webkit.org/show_bug.cgi?id=97639

Reviewed by Filip Pizlo.

From the spec: "It is strongly recommended that this function treat Strings that are
canonically equivalent according to the Unicode standard as identical (in other words,
compare the Strings as if they had both been converted to Normalised Form C or D first).
It is also recommended that this function not honour Unicode compatibility equivalences
or decompositions."

Source/WTF:

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::createCollator):

  • Enable normalization.

LayoutTests:

  • fast/js/script-tests/string-localeCompare.js: Added.
  • fast/js/string-localeCompare-expected.txt: Added.
  • fast/js/string-localeCompare.html: Added.
    • Add lests for localeCompare.
12:18 AM Changeset in webkit [129600] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

REGRESSION (r126189): No more mismatch-did-not-occur failures in reftests
​https://bugs.webkit.org/show_bug.cgi?id=97112

Reviewed by Dirk Pranke.

Don't use the reftest's image hash when gathering output of its reference.
This indirectly forces the driver to return the reference's image output
as well. This specifically solves the problem when the reftest and its
mismatch reference are equal but the unexpected match failure is not
reported due to missing image output of the reference file.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.diff_image):
(TestDriver.run_test):

12:03 AM Changeset in webkit [129599] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip passing test after r129592.

  • platform/efl/TestExpectations:
Note: See TracTimeline for information about the timeline view.