Timeline
Sep 30, 2012:
- 11:13 PM Changeset in webkit [130007] by
-
- 3 edits2 adds in trunk
Sign in front of keyframe selector causes stylesheet parsing to abort
https://bugs.webkit.org/show_bug.cgi?id=96844
Patch by Glenn Adams <glenn@skynav.com> on 2012-09-30
Reviewed by Simon Fraser.
Source/WebCore:
Allow optional unary operator (+) on PERCENTAGE in keyframe selector. Test: animations/keyframe-selector-negative-percentage.html
- css/CSSGrammar.y:
Add maybe_unary_operator to PERCENTAGE on keyframe selector. Negative keyframe
selector value is already ignored in StyleKeyframe::parseKeyString.
LayoutTests:
Add test case for correct handling of negative percentage in keyframe selector.
- animations/keyframe-selector-negative-percentage-expected.txt: Added.
- animations/keyframe-selector-negative-percentage.html: Added.
- 10:56 PM Changeset in webkit [130006] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=97988
Crash on FrameTree::scopedChildCount()
Reviewed by Kent Tamura.
The series of crash reports says that there are some null pointer
access in scopedChildCount(). This change added a null guard
against Frame::document(), that can return null.
No new tests. This is tied to some specific timing and is hard to reproduce.
- page/FrameTree.cpp:
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::scopedChild):
(WebCore):
- 10:50 PM Changeset in webkit [130005] by
-
- 8 edits in trunk/Source/WebCore
Make multiple fields date/time input UI related files to available all ports
https://bugs.webkit.org/show_bug.cgi?id=97989
Reviewed by Kent Tamura.
This patch adds multiple fields date/time input UI related files for
ports not using WebCore.gyp and simplifies include directive in
MonthInputType.h and TimeInputType.h.
Added files are:
- html/BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
- html/shadow/DateTimeEditElement.{cpp,h}
- html/shadow/DateTimeFieldElement.{cpp,h}
- html/shadow/DateTimeFieldElements.{cpp,h}
- html/shadow/DateTimeNumericFieldElement.{cpp,h}
- html/shadow/DateTimeSymbolicFieldElement.{cpp,h}
No new tests. This patch doesn't change behavior.
- CMakeLists.txt: Changed to add multiple fields date/time input UI related files.
- GNUmakefile.list.am: ditto
- Target.pri: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- html/MonthInputType.h: Changed to simplify include directive for base class.
- html/TimeInputType.h: ditto
- 9:32 PM FeatureFlags edited by
- Add SATURATED_LAYOUT_ARITHMETIC (diff)
- 8:57 PM Changeset in webkit [130004] by
-
- 3 edits2 adds in trunk
Web Inspector: Modifications in a shadow tree don't update the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=97056
Reviewed by Pavel Feldman.
Source/WebCore:
Send characterDataModified event for shadow dom nodes too so they update the elements panel.
Test: inspector/elements/shadow-dom-modify-chardata.html
- dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
LayoutTests:
- inspector/elements/shadow-dom-modify-chardata-expected.txt: Added.
- inspector/elements/shadow-dom-modify-chardata.html: Added.
- 7:45 PM Changeset in webkit [130003] by
-
- 5 edits in trunk/LayoutTests
Trivial test fix after r127534.
https://bugs.webkit.org/show_bug.cgi?id=95813
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-30
Reviewed by Kentaro Hara.
- fast/innerHTML/innerHTML-iframe-expected.txt:
- fast/innerHTML/innerHTML-iframe.html:
- platform/chromium/TestExpectations:
- platform/qt/TestExpectations:
- 7:44 PM Changeset in webkit [130002] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 7:34 PM WebKit Team edited by
- (diff)
- 6:57 PM Changeset in webkit [130001] by
-
- 4 edits2 adds in trunk
[chromium] Add a test to verify that a plugin does not receive touch-events unless it explicitly requests for them
https://bugs.webkit.org/show_bug.cgi?id=97975
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-09-30
Reviewed by Adam Barth.
Tools:
TestWebPlugin can now be configured to accept touch events or not. Use this
configurability to verify that a plugin does not receive touch events unless
it explicitly requests for them.
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::initialize):
(TestWebPlugin::parseBoolean):
- DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin):
LayoutTests:
- platform/chromium/plugins/touch-events-expected.txt: Added.
- platform/chromium/plugins/touch-events.html: Added.
- 6:30 PM Changeset in webkit [130000] by
-
- 4 edits in trunk/Source/WebCore
Split EventTargetData out of NodeRareData to reduce memory use.
<http://webkit.org/b/97987>
<rdar://problem/12403258>
Reviewed by Anders Carlsson.
Move EventTargetData to its own Node-flag/hashmap instead of piggybacking on NodeRareData.
This reduces memory consumption by 1.06MB on Membuster3. Note that NodeRareData shrinks by
one pointer as well.
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::eventTargetDataMap):
(WebCore::Node::eventTargetData):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::clearEventTargetData):
(WebCore::Node::handleLocalEvents):
- dom/Node.h:
(WebCore::Node::hasEventTargetData):
(WebCore::Node::setHasEventTargetData):
- dom/NodeRareData.h:
(NodeRareData):
- 5:28 PM Changeset in webkit [129999] by
-
- 2 edits in trunk/Source/WTF
Clean up HasTrivialConstructor/Destructor
https://bugs.webkit.org/show_bug.cgi?id=97754
Reviewed by Sam Weinig.
Mixed up the HasTrivialDestructor/Constructor case for VS2010 and later in the previous patch.
- wtf/TypeTraits.h:
- 4:31 PM Changeset in webkit [129998] by
-
- 9 edits in branches/safari-534.58-branch/Source
Merge r123907.
2012-07-27 Anders Carlsson <andersca@apple.com>
Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521
Reviewed by Sam Weinig.
Source/WebCore:
Now that <applet> behaves more like <embed> and <object>, make sure that we show the unavailable plug-in indicator
and call the correct error callbacks if we fail to instantiate the plug-in.
- WebCore.exp.in:
Export a symbol needed by WebKit2.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
Set the correct service type.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
Enable the unavailable plug-in indicator if we fail to create the java applet widget.
Source/WebKit/mac:
Check if the Java plug-in is blocked before trying to instantiate it.
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.
- 3:51 PM Changeset in webkit [129997] by
-
- 15 edits in branches/safari-534.58-branch/Source/WebCore
Merge r123811.
2012-07-26 Anders Carlsson <andersca@apple.com>
HTMLAppletElement should inherit from HTMLPlugInImageElement
https://bugs.webkit.org/show_bug.cgi?id=92320
Reviewed by Eric Seidel.
In order to simplify the class hierarchy and eventually merge HTMLPlugInImageElement and HMTLPlugInElement,
make HTMLAppletElement inherit from HTMLPlugInImageElement. While this does mean that HTMLAppletElement will grow by
a couple of words, in practice it won't matter.
Also, make RenderApplet inherit from RenderEmbeddedObject and move the plug-in instantiation to HTMLAppletElement which matches
both HTMLEmbedElement and HTMLObjectElement.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::create):
(WebCore::HTMLAppletElement::parseAttribute):
(WebCore::HTMLAppletElement::rendererIsNeeded):
(WebCore::HTMLAppletElement::createRenderer):
(WebCore):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
(WebCore::HTMLAppletElement::updateWidget):
- html/HTMLAppletElement.h:
(HTMLAppletElement):
- html/HTMLTagNames.in:
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
- loader/SubframeLoader.h:
(SubframeLoader):
- page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
- rendering/RenderApplet.cpp:
(WebCore::RenderApplet::RenderApplet):
- rendering/RenderApplet.h:
(RenderApplet):
- rendering/RenderEmbeddedObject.h:
(WebCore::toRenderEmbeddedObject):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
- rendering/RenderObject.h:
- 2:06 PM Changeset in webkit [129996] by
-
- 3 edits in trunk/Source/WebCore
444kB below CSSParser::parseDeprecatedGradient() on Membuster3.
<http://webkit.org/b/97981>
<rdar://problem/12403058>
Reviewed by Anders Carlsson.
Slap an inline capacity of 2 on the Vector<CSSGradientColorStop> in CSSGradientValue.
This covers the majority of gradient values, and reduces memory consumption by ~250kB on Membuster3.
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::stopCount):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseGradientColorStops):
- 12:35 PM Changeset in webkit [129995] by
-
- 2 edits in trunk/Source/WebCore
Remove FIXME comments refering to non-existent code in JSDOMBinding.cpp
https://bugs.webkit.org/show_bug.cgi?id=97977
Reviewed by Adam Barth.
I did a quick grep through the code to determine where these FIXME
comments were suggesting that code should be merged. So far as I can
tell, 'immediatelyReportUnsafeAccessTo' only exists in these comments.
Just cleanup, no functional change.
- bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):
- 11:40 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:38 AM Changeset in webkit [129994] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][GTK] Add API to get the favicon for a WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=96477
Reviewed by Carlos Garcia Campos.
Provide a new simple API to synchronously try to get the favicon
associated with a WebView, if any, and to keep track of changes on
it, through a new GObject property.
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate):
(webkitWebViewIconReadyCallback): Callback to handle the
'icon-ready' signal coming from WebKitFaviconDatabase.
(webkitWebViewWatchForChangesInFavicon): Connects to the
'icon-ready' signal from WebKitFaviconDatabase, to keep track of
changes in favicons, that must be related to the current view.
(webkitWebViewDisconnectFaviconDatabaseSignalHandlers):
Disconnects the handler for 'icon-ready' if needed.
(webkitWebViewGetProperty): Updated for the new "favicon" property .
(webkitWebViewFinalize): Disconnect the new signal handler.
(webkit_web_view_class_init): Definition of the new property.
(webkitWebViewEmitLoadChanged): Make sure we will be watching for
changes in the favicon from WEBKIT_LOAD_STARTED on.
(webkit_web_view_get_favicon): New API funtcion, returning the
current favicon for the WebView, if any, or NULL otherwise.
- UIProcess/API/gtk/WebKitWebView.h:
Internally expose a way to try to get the favicon associated to a
page URL synchronously, through WebKitFaviconDatabase.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseGetFaviconSync): New internal function, it
will return either 0 or a valid pointer to a cairo_surface_t.
- UIProcess/API/gtk/WebKitFaviconDatabasePrivate.h:
Add unit tests for checking this new API.
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testWebViewFavicon): New unit test.
(beforeAll): Add the test to the test suite.
- 10:08 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:46 AM EFLSettingsApiTutorial edited by
- (diff)
- 9:40 AM EFLWebKit edited by
- (diff)
- 9:28 AM Changeset in webkit [129993] by
-
- 7 edits in trunk/Source/WebCore
[TextureMapper] [WebKit2] Crash in WebCore::BitmapTextureGL::updateContents
https://bugs.webkit.org/show_bug.cgi?id=97394
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-30
Reviewed by Noam Rosenthal.
When a TextureMapper is destroyed, layers can still contain references
to textures obtained from that TextureMapper's texture pool. Trying to
access an unreffed TextureMapper in the BitmapTexture's destructor
causes a crash.
Instead of storing a raw pointer to a TextureMapper, we can simply store
a reference to the underlying GraphicsContext3D. All TextureMapper
implementations use the current GL context at this moment, so one GC3D
referencing the current context is the same as any other.
- platform/graphics/texmap/TextureMapper.h: Remove the clearTexturePool
method. It's no longer used.
(WebCore::BitmapTexture::applyFilters): Add a TextureMapper* argument.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::BitmapTextureGL): Keep a reference to the
GraphicsContext3D instead of the TextureMapper.
(WebCore::BitmapTextureGL::didReset): Use the GC3D reference.
(WebCore::BitmapTextureGL::updateContents): Ditto.
(WebCore::BitmapTextureGL::applyFilters): Accept the TextureMapper as an argument.
(WebCore::BitmapTextureGL::initializeStencil): Use the GC3D reference.
(WebCore::BitmapTextureGL::clearIfNeeded): Ditto.
(WebCore::BitmapTextureGL::createFboIfNeeded): Ditto.
(WebCore::BitmapTextureGL::bind): Accept the TextureMapper as an argument.
(WebCore::BitmapTextureGL::~BitmapTextureGL): Use the GC3D reference.
(WebCore::TextureMapperGL::~TextureMapperGL): Remove the call to clearTexturePool
as it's no longer necessary.
(WebCore::TextureMapperGL::bindSurface): Ditto.
- platform/graphics/texmap/TextureMapperGL.h:
(BitmapTextureGL): Keep a GC3D reference instead of a TextureMapper pointer.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters): Add a TextureMapper argument.
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::applyFilters): Ditto.
- 9:03 AM WebKitGTK/1.10.x edited by
- (diff)
- 7:56 AM Changeset in webkit [129992] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][GTK] Fix issues with WebKitFaviconDatabase in debug builds
https://bugs.webkit.org/show_bug.cgi?id=97966
Reviewed by Carlos Garcia Campos.
Fix failing ASSERTs detected when running the unit tests from
TestWebKitFaviconDatabase in debug builds.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseDispose): Close IconDatabase here, which is
the right place to do it according to GObject documentation.
(webkitFaviconDatabaseFinalize): Just destroy the private data
structure and chain up to parent class's finalize method.
(webkit_favicon_database_class_init): Override dispose method.
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseFinalizedCallback): Delete files when the
WebKitFaviconDatabase is being finalized, since by that time the
IconDatabase from WebCore will be already closed.
(afterAll): Add a weak reference to WebKitFaviconDatabase and
provide a GWeakNotify callback (webkitFaviconDatabaseFinalizedCallback).
- 6:59 AM FeatureFlags edited by
- Remove JAVA_BRIDGE (diff)
- 6:46 AM Changeset in webkit [129991] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Rebaseline for DateTimeNumericFieldElement should use Localizer functions.
https://bugs.webkit.org/show_bug.cgi?id=97318
- platform/chromium/TestExpectation:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt:
- 4:47 AM Changeset in webkit [129990] by
-
- 2 edits in trunk/LayoutTests
[EFL] Add proper bug links to the protocol handler crashes in efl-wk2.
- platform/efl-wk2/TestExpectations:
- 4:37 AM EFLSettingsApiTutorial edited by
- (diff)
- 4:32 AM EFLSettingsApiTutorial created by
- 4:19 AM Changeset in webkit [129989] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip a few seemingly passing tests with no associated bug.
- platform/efl-wk2/TestExpectations:
Sep 29, 2012:
- 7:29 PM Changeset in webkit [129988] by
-
- 6 edits in trunk/Source/WebCore
AsyncFileSystem::openFileSystem should have FileSystemType as a parameter.
https://bugs.webkit.org/show_bug.cgi?id=97963
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-09-29
Reviewed by Gyuyoung Kim.
FileSystemType is an important information to maintain the file system,
and AsyncFileSystem::openFileSystem need to get the type as a parameter.
And, there are "FIXME" comments about that in WebCore source codes.
No new functionality, no new tests.
- Modules/filesystem/LocalFileSystem.cpp: Add FileSystemType as a parameter of AsyncFileSystem::openFileSystem.
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):
- platform/AsyncFileSystem.cpp: ditto.
(WebCore::AsyncFileSystem::openFileSystem):
- platform/AsyncFileSystem.h: ditto.
(AsyncFileSystem):
- platform/blackberry/AsyncFileSystemBlackBerry.cpp: ditto.
(WebCore::AsyncFileSystem::openFileSystem):
- platform/gtk/AsyncFileSystemGtk.cpp: ditto.
(WebCore::AsyncFileSystem::openFileSystem):
- 3:20 PM Changeset in webkit [129987] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip test that seems to be passing now.
- platform/efl/TestExpectations:
- 3:13 PM Changeset in webkit [129986] by
-
- 2 edits2 adds in trunk/LayoutTests
[EFL] Unskip {horizontal,vertical}-scrollbar-in-rtl.html
The expectations in fast/dom are actually Mac-specific (cf.
r73063), and most other ports use their own platform-specific
results due to the differences in behavior of the Home/End keys.
The results being checked in here are in line with the other
ports, so everything seems to be OK.
- platform/efl/TestExpectations:
- platform/efl/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/efl/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
- 1:55 PM Changeset in webkit [129985] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r129982.
http://trac.webkit.org/changeset/129982
https://bugs.webkit.org/show_bug.cgi?id=97971
hit assert in fast/overflow/overflow-height-float-not-removed-
crash3.html (Requested by eae on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-29
- wtf/Platform.h:
- 1:29 PM Changeset in webkit [129984] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r129965.
http://trac.webkit.org/changeset/129965
https://bugs.webkit.org/show_bug.cgi?id=97970
Causes ASSERTs in workers (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-29
- bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
- bindings/v8/ScopedPersistent.h:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
- bindings/v8/V8Binding.cpp:
(WebCore::perContextDataForCurrentWorld):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
- bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
- 1:12 PM WebKitGTK/1.10.x edited by
- (diff)
- 11:37 AM Changeset in webkit [129983] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for chromium/clank.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
- 10:43 AM Changeset in webkit [129982] by
-
- 2 edits in trunk/Source/WTF
Enable SATURATED_LAYOUT_ARITHMETIC for chromium
https://bugs.webkit.org/show_bug.cgi?id=95053
Reviewed by Abhishek Arya.
Enable the SATURATED_LAYOUT_ARITHMETIC flag for the chromium port.
This changes the behavior of FractionalLayoutUnit to clamp to the
max or min value instead of overflowing.
This may very well impact performance so the current plan is to enable
it for a couple of hours to a day to collect performance data and then
disable it again until we've had a chance to review the perf data.
- wtf/Platform.h:
- 9:03 AM Changeset in webkit [129981] by
-
- 4 edits in trunk/LayoutTests
[EFL] Rebaseline test after r129695.
- platform/efl/TestExpectations:
- platform/efl/mathml/presentation/tables-expected.png:
- platform/efl/mathml/presentation/tables-expected.txt:
- 8:47 AM Changeset in webkit [129980] by
-
- 2 edits in trunk/LayoutTests
[EFL] Revert r129978.
Skip media/unsupported-rtsp.html again, as it still fails on the
bots. I have created a proper bug for the issue now.
- platform/efl/TestExpectations:
- 8:17 AM Changeset in webkit [129979] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip fast/css/device-aspect-ratio.html
This seems to be another test with no bug report that is now
passing.
- platform/efl/TestExpectations:
- 7:54 AM Changeset in webkit [129978] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip media/unsupported-rtsp.html
The test seems to be consistently passing at least locally, let's
see if the bots agree.
- platform/efl/TestExpectations:
- 7:40 AM Changeset in webkit [129977] by
-
- 2 edits in trunk/Source/WebCore
Fix build warning : -Wparentheses.
https://bugs.webkit.org/show_bug.cgi?id=97961
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-29
Reviewed by Kentaro Hara.
Explicit braces are added around the && statement to fix -Wparentheses warning.
- mathml/MathMLElement.h:
(WebCore::toMathMLElement):
- 5:51 AM Changeset in webkit [129976] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix build error : Link webkit2 library to ewk2UnitTestInjectedBundleSample.
https://bugs.webkit.org/show_bug.cgi?id=97622
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-29
Reviewed by Gyuyoung Kim.
There is no dependency between ewk2UnitTestInjectedBundleSample and
webkit2 library.
Because of this, on the first build, compiler tries to build
injected_bundle_sample.cpp before the forwarding headers are created.
This makes build error that the header file 'WebKit2/WKBaseSoup.h'
cannot be found.
To prevent this, webkit2 library is linked to ewk2UnitTestInjectedBundleSample.
- PlatformEfl.cmake:
- 3:22 AM Changeset in webkit [129975] by
-
- 6 edits2 adds in trunk
Scroll offset of flex items lost during relayout
https://bugs.webkit.org/show_bug.cgi?id=97706
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/flexbox/overflow-keep-scrollpos.html
Flex box does a second pass layout of the flex children.
We layout the child without scrollbars (to get the size
used for flexing), then we relayout the child at its final size.
We must not apply the scroll position during the first pass,
as it will be clamped to 0 (no scrolling possible).
- rendering/RenderBlock.h:
(RenderBlock):
Make updateScrollInfoAfterLayout public
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Delay applying scroll info until we clamp the size of the child
and get scrollbars back again. For this to work we use
RenderBlock::updateScrollInfoAfterLayout instead of the non-guarded
RenderLayer::updateScrollInfoAfterLayout.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
Add workaround for now to keep passing css3/flexbox/child-overflow.html
Basically do not postpone applying scroll changes for RenderBlocks
with opposite writing mode, as they need to have their content
overflow in the right direction.
LayoutTests:
Add a new test for testing that flex items scroll offsets are
not lost during relayout.
- css3/flexbox/overflow-keep-scrollpos-expected.txt: Added.
- css3/flexbox/overflow-keep-scrollpos.html: Added.
- css3/flexbox/child-overflow.html: Fix minor errors.
- 2:21 AM Changeset in webkit [129974] by
-
- 2 edits in trunk/Source/WebCore
Slightly improve clarity of the patch in bug 78595.
https://bugs.webkit.org/show_bug.cgi?id=97944
Reviewed by Andreas Kling.
Since all types of relations, except SubSelector are effectively ignoring the calculated value of pseudoId, make the code reflect that a bit more clearly.
No change in behavior, covered by test in bug 78595.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Added ignoreDynamicPseudo value that's given to all callsites that should ignore the result.
- 1:49 AM Changeset in webkit [129973] by
-
- 12 edits5 deletes in trunk/Source/WebCore
Remove LocalizedDate*.*
https://bugs.webkit.org/show_bug.cgi?id=97957
Reviewed by Kentaro Hara.
The functions declared in LocalizedDate.h are replaced with member
functions of Localizer. LocalizedDate.h and its implementations
are not needed any more.
No new tests. This should not change any behavior.
- GNUmakefile.list.am: Remove LocalizedDate.h and LocalizedDateNode.cpp
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- CMakeLists.txt: Remove LocalizedDateNone.cpp
- Target.pri: ditto.
- WebCore.gyp/WebCore.gyp: Remove LocalizedDate*.*. Update a comment.
- WebCore.gypi: Remove LocalizedDate*.*.
- html/BaseDateAndTimeInputType.cpp: Use Localizer functions.
(WebCore::BaseDateAndTimeInputType::localizeValue):
(WebCore::BaseDateAndTimeInputType::convertFromVisibleValue):
- html/DateInputType.cpp: ditto.
(WebCore::DateInputType::fixedPlaceholder):
- platform/text/Localizer.h:
(Localizer): Move comments from LocalziedDate.h.
- platform/text/mac/LocaleMac.mm:
Remove unnecessary include of LocalizedDate.h.
- platform/text/LocalizedDate.h: Removed.
- platform/text/LocalizedDateICU.cpp: Removed.
- platform/text/LocalizedDateNone.cpp: Removed.
- platform/text/LocalizedDateWin.cpp: Removed.
- platform/text/mac/LocalizedDateMac.cpp: Removed.
