Context Navigation

← Previous Period
Next Period →

Timeline

Oct 4, 2012:

11:58 PM Changeset in webkit [130472] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98334

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-04
Reviewed by Gyuyoung Kim.

Add callback functions for download requests to Minibrowser to set the destination path for download.
Set the destination path with suggested file name as (destination folder) + (suggested file name).
The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.

Additionally, for printing out the download status,
use the info macro and set the verbose variable to 1 to enable it.

MiniBrowser/efl/main.c:

(on_download_request):
(on_download_finished):
(on_download_failed):
(browserCreate):

11:57 PM Changeset in webkit [130471] by bashi@chromium.org

10 edits
2 adds in trunk/Source

[WebSocket] ExtensionParser should have its own file
https://bugs.webkit.org/show_bug.cgi?id=98475

Reviewed by Yuta Kitamura.

Source/WebCore:

Factor out ExtensionParser from WebSocketExtensionDispatcher and rename it as WebSocketExtensionParser.
WebSocketExtensionParser has its own file.

No changes in behavior. Added a test case for parsing Sec-WebSocket-Extensions field as a chromium unit test.

CMakeLists.txt: Added WebSocketExtensionParser.
GNUmakefile.list.am: Ditto.
Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::processHeaderValue):
Use WebSocketExtensionParser::parseExtension() to parser extension header value.

Modules/websockets/WebSocketExtensionParser.cpp: Added.

(WebCore):
(WebCore::WebSocketExtensionParser::finished): Moved from ExtensionParser.
(WebCore::WebSocketExtensionParser::parsedSuccessfully): Ditto.
(WebCore::isSeparator): Ditto.
(WebCore::WebSocketExtensionParser::skipSpaces): Ditto.
(WebCore::WebSocketExtensionParser::consumeToken): Ditto.
(WebCore::WebSocketExtensionParser::consumeQuotedString): Ditto.
(WebCore::WebSocketExtensionParser::consumeQuotedStringOrToken): Ditto.
(WebCore::WebSocketExtensionParser::consumeCharacter): Ditto.
(WebCore::WebSocketExtensionParser::parseExtension): Moved from WebSocketExtensionDispatcher.

Modules/websockets/WebSocketExtensionParser.h: Added.

(WebCore):
(WebSocketExtensionParser):
(WebCore::WebSocketExtensionParser::WebSocketExtensionParser):
(WebCore::WebSocketExtensionParser::currentToken):

Target.pri: Added WebSocketExtensionParser.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

Source/WebKit/chromium:

Add a test for parsing Sec-WebSocket-Extensions field.

tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore):
(WebCore::TEST_F):

11:55 PM Changeset in webkit [130470] by ryuan.choi@samsung.com

7 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_web_error_free is not a public API
https://bugs.webkit.org/show_bug.cgi?id=98482

Reviewed by Gyuyoung Kim.

Because Ewk_Web_Error is just passed as a parameter of callback function
and maintained internally, ewk_web_error_free should not be a public API.

This patch moves ewk_web_error_free from public header to private header.

UIProcess/API/efl/ewk_context_download_client.cpp:
UIProcess/API/efl/ewk_view_loader_client.cpp:
UIProcess/API/efl/ewk_view_resource_load_client.cpp:
UIProcess/API/efl/ewk_web_error.cpp:
UIProcess/API/efl/ewk_web_error.h:
UIProcess/API/efl/ewk_web_error_private.h:

11:41 PM Changeset in webkit [130469] by commit-queue@webkit.org

9 edits in trunk

<input> size attribute should throw INDEX_SIZE_ERR when set to 0
https://bugs.webkit.org/show_bug.cgi?id=61675

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-04
Reviewed by Kent Tamura.

Source/WebCore:

According to the spec, the size IDL attribute of input elements is limited
to only non-negative numbers greater than zero. It should throw INDEX_SIZE_ERR
exception when set to 0. New behavior matches both Firefox and IE.
Spec: http://www.w3.org/TR/html5/common-input-element-attributes.html#the-size-attribute

Test: fast/dom/HTMLInputElement/input-size-attribute.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setSize):

html/HTMLInputElement.h:

(HTMLInputElement):

html/HTMLInputElement.idl:

LayoutTests:

Added test case to verify that input.size throws INDEX_SIZE_ERR when set to 0.

Updated fast/forms/number/number-size.html to reflect new behavior.

fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
fast/dom/HTMLInputElement/input-size-attribute.html:
fast/forms/number/number-size.html:
fast/forms/number/number-size-expected.txt:

11:39 PM Changeset in webkit [130468] by bashi@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Improve SocketStreamHandle::send() stability
https://bugs.webkit.org/show_bug.cgi?id=98459

Reviewed by Yuta Kitamura.

Avoid null dereference in SocketStreamHandleInternal::send().
No changes in behavior.

src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::send):

11:24 PM Changeset in webkit [130467] by tkent@chromium.org

2 edits in trunk/Source/WebCore

Fix font for date/time input types.
https://bugs.webkit.org/show_bug.cgi?id=98478

Reviewed by Kentaro Hara.

input[type=date] should use monospace font if
ENABLE_INPUT_MULTIPLE_FIELDS_UI && ENABLE_INPUT_TYPE_DATE.

For other date/time types, they should use monospace font only
if their types are enabled. input[type="foo"] matches input
element with type="foo" even if the foo type is not supported.

The input[type=date] change is covered by
fast/forms/date/calendar-picker-appearance.html,
platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html

css/html.css:

(input[type="date"]):
(input[type="datetime"]):
(input[type="datetime-local"]):
(input[type="month"]):
(input[type="time"]):

11:22 PM Changeset in webkit [130466] by commit-queue@webkit.org

4 edits in trunk

[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement UIClient's focus callbacks in WebKitTestRunner.

WebKitTestRunner/TestController.cpp:

(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.

platform/efl-wk2/TestExpectations:

11:15 PM Changeset in webkit [130465] by morrita@google.com

9 edits
4 adds in trunk/Source/WebCore

[Refactoring] Some classes in StyleResolver.cpp/h could have its own file.
https://bugs.webkit.org/show_bug.cgi?id=98469

Reviewed by Dimitri Glazkov.

This change extracts RuleData, RuleSet, RuleFeature and Featurs class
to its own file: RuleSet.h/cpp and RuleFeature.h/cpp

RuleFeature class is moved fro StyleResolver inner class to plain WebCore class.
Feaures class is renamed to RuleFeatureSet to avoid possible name conflict.

No new tests. Just splitting file and doing simple rename.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
css/CSSAllInOne.cpp:
css/RuleFeature.cpp: Added.

(WebCore):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::reportMemoryUsage):

css/RuleFeature.h: Added.

(WebCore):
(RuleFeature):
(WebCore::RuleFeature::RuleFeature):
(RuleFeatureSet):
(WebCore::RuleFeatureSet::RuleFeatureSet):

css/RuleSet.cpp: Added.

(WebCore):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::selectorListContainsUncommonAttributeSelector):
(WebCore::isCommonAttributeSelectorAttribute):
(WebCore::containsUncommonAttributeSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleData::reportMemoryUsage):
(WebCore::reportAtomRuleMap):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromRuleData):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):

css/RuleSet.h: Added.

(WebCore):
(RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleData::selectorIndex):
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::specificity):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::isInRegionRule):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(SameSizeAsRuleData):
(RuleSet):
(WebCore::RuleSet::create):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::features):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(RuleSetSelectorPair):
(WebCore::RuleSet::RuleSet):

css/StyleResolver.cpp:

(WebCore):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectMatchingRulesForList):

css/StyleResolver.h:

(StyleResolver):

11:11 PM Changeset in webkit [130464] by commit-queue@webkit.org

3 edits
1 add in trunk/Source/WebKit2

[EFL][WK2] Implement window frame callbacks in UIClient
https://bugs.webkit.org/show_bug.cgi?id=98280

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Implement callbacks to set and query window geometry
in EwkView's UIClient.

UIProcess/API/efl/ewk_view_ui_client.cpp:

(getWindowFrame):
(setWindowFrame):
(ewk_view_ui_client_attach):

UIProcess/API/efl/tests/resources/window_move_resize.html: Added.
UIProcess/API/efl/tests/test_ewk2_view.cpp:

(windowMoveResizeTimedOut):
(TEST_F): Add corresponding unit test.

11:02 PM Changeset in webkit [130463] by abarth@webkit.org

3 edits in trunk/Source/WebCore

FeatureObserver should distinguish between legacy HTML and text notifications
https://bugs.webkit.org/show_bug.cgi?id=98441

Reviewed by Tony Chang.

We might be able to drop support for legacy HTML notifications before
we can drop support for legacy text notifications. We should measure
and find out.

Modules/notifications/NotificationCenter.idl:
page/FeatureObserver.h:

10:00 PM Changeset in webkit [130462] by dpranke@chromium.org

2 edits in trunk/Source/WebKit/chromium

Chromium DEPS roll r160281:160322

Unreviewed.

DEPS:

9:59 PM Changeset in webkit [130461] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment.
https://bugs.webkit.org/show_bug.cgi?id=98444

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-04
Reviewed by Eric Seidel.

The member variable m_wasMalformed of HTMLFormElement class was used to determine if the <form> tag was malformed or not.
This information was used elsewhere to decide if bottom margins have to be included for such a <form>.
However currently this member variable is not being set by any code following code refactoring in HTML parser class.

Code cleanup patch. No new tests required.

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):

Removed m_wasMalformed initialization.

html/HTMLFormElement.h:

(HTMLFormElement):

Removed m_wasMalformed variable.
Removed m_wasMalformed variable's setter and getter functions.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

Removed code fragment using/dependent on m_wasMalformed.

9:56 PM Changeset in webkit [130460] by commit-queue@webkit.org

16 edits in trunk

Turn Compositing on by default in WebKit build
https://bugs.webkit.org/show_bug.cgi?id=98315

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-04
Reviewed by Simon Fraser.

enable -webkit-blend-mode on trunk.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. Existing blending test were updated.

Configurations/FeatureDefines.xcconfig:
css/CSSPropertyNames.in:
css/CSSValueKeywords.in:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

css3/compositing/blend-mode-property-expected.txt:
css3/compositing/blend-mode-property-parsing-expected.txt:
css3/compositing/script-tests/blend-mode-property.js:

(testblendmode):

css3/compositing/should-have-compositing-layer-expected.txt:
platform/chromium/TestExpectations:

9:47 PM Changeset in webkit [130459] by hayato@chromium.org

4 edits
1 add in trunk

[Refactoring] Introduce a traversal strategy in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=97298

Reviewed by Antti Koivisto.

PerformanceTests:

Introduces querySelector() performance tests to check SelectorChecker performance.

CSS/PseudoClassSelectors.html: Added.

Source/WebCore:

We extract DOM traversal code from SelectorChecker so that we can use another traversal strategy.
Another traversal strategy will be introduced in Bug 96990.

Since this code path is very hot, we were very careful not to regress performance.
We will use template specialization to change the traversal implementation.

We confirmed that this patch does not regress SelectorCheckerPerformance. I have checked the performance of
the added test in my Linux Box using run-perf-tests.

The performance of the added test before using this patch was:

RESULT CSS: PseudoClassSelectors= 3399.68308031 runs/s
median= 3404.48685564 runs/s, stdev= 37.3480114449 runs/s, min= 3272.64871114 runs/s, max= 3438.72385184 runs/s

When we used this patch, the performance was:

RESULT CSS: PseudoClassSelectors= 3367.74473886 runs/s
median= 3367.12072755 runs/s, stdev= 14.1464547639 runs/s, min= 3348.55881171 runs/s, max= 3395.98212857 runs/s

Test: PerformanceTests/CSS/PseudoClass-Selectors.html

css/SelectorChecker.cpp:

(WebCore):
(WebCore::SelectorChecker::checkSelector): Make this a template method to accept another Context type.
Another Context type will be introduced in coming patch.
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsAfter):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeAfter):

css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):
(DOMTraversalStrategy): Extracted the DOM traversal code from SelectorChecker. Another traversal code
will be introduced the coming patch.

9:44 PM Changeset in webkit [130458] by tkent@chromium.org

4 edits in trunk/LayoutTests

Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390

Follow up of r130433. We still need offsetTop access.

fast/forms/date/calendar-picker-common.js:

(openPicker):

fast/forms/resources/suggestion-picker-common.js:

(openPicker):

platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:

Remove unnecessary width style.

9:37 PM Changeset in webkit [130457] by tony@chromium.org

19 edits
1 add in trunk/LayoutTests

Convert some flexbox tests to run in mozilla
https://bugs.webkit.org/show_bug.cgi?id=98464

Reviewed by Ojan Vafai.

Move properties with a small number of values into resources/flexbox.css
and start using it in some flexbox tests.

css3/flexbox/align-absolute-child.html:
css3/flexbox/align-baseline-expected.html:
css3/flexbox/align-baseline.html:
css3/flexbox/anonymous-block-merge-crash.html:
css3/flexbox/anonymous-block.html:
css3/flexbox/auto-height-dynamic.html:
css3/flexbox/auto-margins.html:
css3/flexbox/box-sizing-min-max-sizes.html:
css3/flexbox/box-sizing.html:
css3/flexbox/child-overflow-expected.html:
css3/flexbox/child-overflow.html:
css3/flexbox/columns-auto-size.html:
css3/flexbox/columns-height-set-via-top-bottom.html:
css3/flexbox/content-height-with-scrollbars.html:
css3/flexbox/cross-axis-scrollbar.html:
css3/flexbox/flex-algorithm-min-max.html:
css3/flexbox/flex-algorithm-with-margins.html:
css3/flexbox/flex-algorithm.html:
css3/flexbox/resources/flexbox.css: Added.

9:22 PM Changeset in webkit [130456] by eric@webkit.org

2 edits in trunk/Source/WebCore

SVGAttributeHashTranslator does not need to copy QualifiedName in the common case
https://bugs.webkit.org/show_bug.cgi?id=98473

Reviewed by Adam Barth.

I tested this using instruments on a test case which modified SVG attributes in a loop.
I believe pdr has some perf-tests in this area, but they weren't needed here. A simple sample showed this as a huge win,
since we're no longer creating a QualifiedName (and thus adding it to the hash) on each QualifiedName-based lookup in SVG.

svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):

9:14 PM Changeset in webkit [130455] by aelias@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Scale plugin container by frameScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=98468

Reviewed by Adam Barth.

Plugin containers (for invalid plugins) weren't taking into account
frameScaleFactor, looking cut off when that was non-1.

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):

8:56 PM Changeset in webkit [130454] by jchaffraix@webkit.org

5 edits in trunk/Source/WebCore

Split the intrinsic padding update code out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=98454

Reviewed by Eric Seidel.

RenderTableSection::layoutRows is very long and it's difficult to see what's
going on. This change moves the intrinsic padding update code into RenderTableCell
for clarity. While at it, cleaned up a bit the code (renaming variables, functions).

Change covered by existing table tests.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeIntrinsicPadding):
Added this new function that does the update. Removed the 'default' case, replaced by
the explicit label BASELINE_MIDDLE.

rendering/RenderTableCell.h:

(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
Moved those setters to the private section as we want other classes
to use computeIntrinsicPadding.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Replaced the code with a call to RenderTableCell::computeIntrinsicPadding.
Also moved 2 variables in the loop per our coding style.

rendering/RenderTableSection.h:

(WebCore::RenderTableSection::rowBaseline):
Renamed to match our coding style.

8:18 PM Changeset in webkit [130453] by Simon Fraser

2 edits in trunk/Source/WebKit2

Fix the Qt build by removing an errant paste at the top of the file.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

7:55 PM Changeset in webkit [130452] by dpranke@chromium.org

2 edits
2 copies
1 move
1 add in trunk/LayoutTests

Update chromium baselines for 5006779.html and paint-subrect-grid.html.

Unreviewed, rebaselining.

Updates after r130425 and r130411.

platform/chromium-linux/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Added.
platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/5006779-expected.txt.
platform/chromium-win/editing/pasteboard/5006779-expected.txt:
platform/chromium/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.

7:47 PM Changeset in webkit [130451] by hclam@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewd. Chromium DEPS roll. Update to r160281.

DEPS:

7:37 PM Changeset in webkit [130450] by ryuan.choi@samsung.com

6 edits
2 adds in trunk

[EFL][WK2] Add APIs to get/set the frame flattening.
https://bugs.webkit.org/show_bug.cgi?id=95982

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added new APIs and test case to support frame flattening.

UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_enable_frame_flattening_set):
(ewk_settings_enable_frame_flattening_get):

UIProcess/API/efl/ewk_settings.h:
UIProcess/API/efl/tests/resources/frame_flattening_test.html: Added.
UIProcess/API/efl/tests/resources/frame_flattening_test_subframe.html: Added.
UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Tools:

MiniBrowser/efl/main.c: Added frame flattening option to test.

(browserCreate):
(main):

7:31 PM Changeset in webkit [130449] by Nate Chapin

2 edits in trunk/Source/WebCore

Crash in EventHandler::mouseMoved().
https://bugs.webkit.org/show_bug.cgi?id=98460

Reviewed by Abhishek Arya.

No new tests, this fixes fast/events/mouse-moved-remove-frame-crash.html.

page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):

7:30 PM Changeset in webkit [130448] by pilgrim@chromium.org

41 edits in trunk/Source/WebKit/chromium

[Chromium] Update some #includes for Platform directory
https://bugs.webkit.org/show_bug.cgi?id=98440

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

src/ApplicationCacheHost.cpp:
src/AssociatedURLLoader.h:
src/AsyncFileWriterChromium.cpp:
src/AudioDestinationChromium.h:
src/AutofillPopupMenuClient.cpp:
src/ChromeClientImpl.cpp:
src/ContextMenuClientImpl.cpp:
src/DeliveredIntentClientImpl.h:
src/DragClientImpl.cpp:
src/DragScrollTimer.h:
src/FrameLoaderClientImpl.cpp:
src/InspectorClientImpl.cpp:
src/InspectorClientImpl.h:
src/InspectorFrontendClientImpl.cpp:
src/NotificationPresenterImpl.cpp:
src/PageWidgetDelegate.h:
src/SocketStreamHandle.cpp:
src/SocketStreamHandleInternal.h:
src/SpeechInputClientImpl.cpp:
src/StorageAreaProxy.cpp:
src/StorageNamespaceProxy.cpp:
src/UserMediaClientImpl.cpp:
src/WebAccessibilityObject.cpp:
src/WebAnimationControllerImpl.cpp:
src/WebCommon.cpp:
src/WebDOMEventListenerPrivate.h:
src/WebDOMMessageEvent.cpp:
src/WebDOMStringList.cpp:
src/WebDataSourceImpl.cpp:
src/WebDatabase.cpp:
src/WebDevToolsAgentImpl.cpp:
src/WebDevToolsAgentImpl.h:
src/WebDocument.cpp:
src/WebDocumentType.cpp:
src/WebDragData.cpp:
src/WebElement.cpp:
src/WebEntities.cpp:
src/WebFileChooserCompletionImpl.h:
src/WebFileSystemCallbacksImpl.cpp:
src/WebFontImpl.cpp:

7:26 PM Changeset in webkit [130447] by noel.gordon@gmail.com

53 edits in trunk/LayoutTests

[chromium] Unreviewed. Rebaseline mac/win results after r130355
https://bugs.webkit.org/show_bug.cgi?id=98472

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-04

platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png:
platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png:
platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png:
platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-mac/media/audio-controls-rendering-expected.png:
platform/chromium-mac/media/audio-repaint-expected.png:
platform/chromium-mac/media/controls-after-reload-expected.png:
platform/chromium-mac/media/controls-strict-expected.png:
platform/chromium-mac/media/controls-styling-expected.png:
platform/chromium-mac/media/controls-styling-strict-expected.png:
platform/chromium-mac/media/controls-without-preload-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-mac/media/video-controls-rendering-expected.png:
platform/chromium-mac/media/video-display-toggle-expected.png:
platform/chromium-mac/media/video-no-audio-expected.png:
platform/chromium-mac/media/video-playing-and-pause-expected.png:
platform/chromium-mac/media/video-zoom-controls-expected.png:
platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png:
platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png:
platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png:
platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-win/media/audio-controls-rendering-expected.png:
platform/chromium-win/media/audio-repaint-expected.png:
platform/chromium-win/media/controls-after-reload-expected.png:
platform/chromium-win/media/controls-strict-expected.png:
platform/chromium-win/media/controls-styling-expected.png:
platform/chromium-win/media/controls-styling-strict-expected.png:
platform/chromium-win/media/controls-without-preload-expected.png:
platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
platform/chromium-win/media/video-controls-rendering-expected.png:
platform/chromium-win/media/video-display-toggle-expected.png:
platform/chromium-win/media/video-no-audio-expected.png:
platform/chromium-win/media/video-playing-and-pause-expected.png:
platform/chromium-win/media/video-zoom-controls-expected.png:
platform/chromium/TestExpectations:

7:18 PM Changeset in webkit [130446] by abarth@webkit.org

3 edits in trunk/Source/WebCore

[V8] NotificationCenter leaks because it uses buggy custom bindings
https://bugs.webkit.org/show_bug.cgi?id=98445

Reviewed by Tony Chang.

There's no reason to use custom bindings here. All they do is cause leaks..

Modules/notifications/NotificationCenter.idl:
bindings/v8/custom/V8NotificationCenterCustom.cpp:

7:16 PM Changeset in webkit [130445] by keishi@webkit.org

4 edits
2 copies in branches/chromium/1271

Merge 130008 - REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893

Reviewed by Kent Tamura.

Source/WebCore:

There were two mistakes:

An if-statement to check step attribute validity was wrong, and
DateTiemChooserParameters.step was milleseconds when it should be number of days.

This will be changing the DateTimeChooserParameters.step to milliseconds so we can handle steps for other input types in the future.

Test: fast/forms/date/calendar-picker-appearance-with-step.html

Resources/pagepopups/calendarPicker.js:

(CalendarPicker):

html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup): If statement was wrong.

LayoutTests:

fast/forms/date/calendar-picker-appearance-with-step-expected.txt: Added.
fast/forms/date/calendar-picker-appearance-with-step.html: Added.

TBR=keishi@webkit.org

7:04 PM Changeset in webkit [130444] by commit-queue@webkit.org

2 edits
2 adds in trunk

Selector specificity categories "overflow" into higher categories
https://bugs.webkit.org/show_bug.cgi?id=98295

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-04
Reviewed by Eric Seidel.

This patch adds per-component overflow guards for CSS selector specificity.
Previously, we didn't guard against overflow.
Since we stored each component as a byte mapped into a single unsigned int for the whole specificity,
256 of a particular simple selector was equivalent to 1 of the next-higher-group selector.
This violated the Selectors specification,
which requires the components to be compared lexicographically.

Tests: /fast/selectors/specificity-overflow.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::specificity):

7:03 PM Changeset in webkit [130443] by enrica@apple.com

8 edits
2 adds in trunk

Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache.
https://bugs.webkit.org/show_bug.cgi?id=98452.

Reviewed by Dan Bernstein.

Source/WebCore:

The text orientation was considered only when there is a cache hit.
This change moves the logic to handle text orientation to a separate
inline function that is called also when the glyph is added to the cache.

Test: fast/text/vertical-rl-rtl-linebreak.html

platform/graphics/FontFastPath.cpp:

(WebCore::applyTextOrientationForCharacter): Added.
(WebCore::Font::glyphDataAndPageForCharacter): Modified to use the new function in
both cases of cold and warm cache.

LayoutTests:

The new test adds platform specific results for Mac, since it uses system fallback fonts.
I've added the expected failure for all the other platforms.

fast/text/vertical-rl-rtl-linebreak.html: Added.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
platform/qt/TestExpectations:
platform/win/TestExpectations:

6:57 PM FeatureFlags edited by tkent@chromium.org

Remove LEGACY_WEBKIT_BLOB_BUILDER. Add INPUT_TYPE_DATE_LEGACY_UI (diff)

6:02 PM Changeset in webkit [130442] by adamk@chromium.org

3 edits
2 adds in trunk

MutationRecord attributeName should be null for non attribute changes
https://bugs.webkit.org/show_bug.cgi?id=98438

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/mutation-record-nullity.html

dom/MutationRecord.idl:

LayoutTests:

fast/mutation/mutation-record-nullity-expected.txt: Added.
fast/mutation/mutation-record-nullity.html: Added.

5:54 PM Changeset in webkit [130441] by Simon Fraser

2 edits in trunk/Source/WebKit2

TiledCoreAnimationDrawingArea.mm should not include RenderLayerCompositor.h
https://bugs.webkit.org/show_bug.cgi?id=98471

Reviewed by Dean Jackson.

Remove #import of <WebCore/RenderLayerCompositor.h> from this file.
It is not required.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

5:46 PM Changeset in webkit [130440] by rniwa@webkit.org

6 edits
1 delete in trunk/LayoutTests

More Qt rebaselines after r130411.

platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
platform/qt/editing/pasteboard/5006779-expected.txt:
platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.

5:43 PM Changeset in webkit [130439] by Simon Fraser

58 edits in trunk/Source

Final part of "sync" to "flush" renaming
https://bugs.webkit.org/show_bug.cgi?id=98430

Reviewed by Tim Horton.

Change method names on GraphicsLayer and GraphicsLayerClient that
refer to "sync" to use the term "flush" instead, to be consistent
with the rest of the code.

Source/WebCore:

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::flushCompositingState):
(WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):

platform/graphics/GraphicsLayerClient.h:

(GraphicsLayerClient):

platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(WebCore::GraphicsLayerBlackBerry::notifyFlushRequired):

platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setNeedsCommit):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::positionForCloneRootLayer):
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):

platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::flushCompositingState):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::notifyFlushRequired):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::notifyFlushRequired):

Source/WebKit/blackberry:

Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):

Api/WebOverlay_p.h:

(WebOverlayPrivateWebKitThread):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):

Api/WebPage_p.h:

(WebPagePrivate):

WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):

WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):

WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):

WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

Source/WebKit/efl:

WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):

Source/WebKit/gtk:

WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

WebCoreSupport/AcceleratedCompositingContextCairo.cpp:

(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

Source/WebKit/mac:

WebView/WebView.mm:

Source/WebKit/qt:

WebCoreSupport/PageClientQt.cpp:

(WebCore::TextureMapperLayerClientQt::syncRootLayer):

Source/WebKit/win:

WebView.cpp:

(WebView::notifyFlushRequired):
(WebView::flushPendingGraphicsLayerChanges):

WebView.h:

Source/WebKit2:

UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit::LayerTreeRenderer::flushLayerChanges):

UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(WebKit::LayerTreeRenderer::notifyFlushRequired):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeLayerState):
(WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
(WebCore::CoordinatedGraphicsLayer::didChangeChildren):
(WebCore::CoordinatedGraphicsLayer::didChangeFilters):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::notifyFlushRequired):

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::notifyFlushRequired):
(WebKit::LayerTreeHostCA::flushPendingLayerChanges):

WebProcess/WebPage/ca/LayerTreeHostCA.h:

(LayerTreeHostCA):

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::notifyFlushRequired):
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):

WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::notifyFlushRequired):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

5:41 PM Changeset in webkit [130438] by rniwa@webkit.org

22 edits in trunk/LayoutTests

GTK+ rebaselines after r130411.

platform/gtk/editing/deleting/delete-block-merge-contents-018-expected.txt:
platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
platform/gtk/editing/deleting/delete-block-merge-contents-021-expected.txt:
platform/gtk/editing/deleting/delete-block-merge-contents-022-expected.txt:
platform/gtk/editing/deleting/merge-no-br-expected.txt:
platform/gtk/editing/execCommand/find-after-replace-expected.txt:
platform/gtk/editing/execCommand/paste-2-expected.txt:
platform/gtk/editing/pasteboard/4944770-2-expected.txt:
platform/gtk/editing/pasteboard/5006779-expected.txt:
platform/gtk/editing/pasteboard/5028447-expected.txt:
platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
platform/gtk/editing/pasteboard/merge-end-borders-expected.txt:
platform/gtk/editing/pasteboard/paste-line-endings-008-expected.txt:
platform/gtk/editing/pasteboard/paste-line-endings-009-expected.txt:
platform/gtk/editing/pasteboard/paste-line-endings-010-expected.txt:
platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
platform/gtk/editing/pasteboard/paste-xml-expected.txt:
platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt:
platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
platform/gtk/fast/lists/drag-into-marker-expected.txt:

5:35 PM Changeset in webkit [130437] by commit-queue@webkit.org

5 edits
2 adds in trunk

1ex should equal .5em when the font has no x-height metric
https://bugs.webkit.org/show_bug.cgi?id=80360

Patch by Tab Atkins <tabatkins@google.com> on 2012-10-04
Reviewed by Eric Seidel.

Source/WebCore:

Updated FontMetrics and CSSPrimitiveValue to have/use an explicit "hasXHeight" flag to determine how to size an 'ex' unit.

Updated a few of the platform font files to set the flag properly.

Patch cleanup by David Barr <davidbarr@chromium.org>.

Test: fast/css/ex-unit-with-no-x-height.html

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

platform/graphics/FontMetrics.h:

(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::setXHeight):
(FontMetrics):
(WebCore::FontMetrics::hasXHeight):
(WebCore::FontMetrics::setHasXHeight):
(WebCore::FontMetrics::reset):

platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

If a font has no x-height metric, 1ex should equal .5em.

Test layout tweaked by David Barr <davidbarr@chromium.org>.

fast/css/ex-unit-with-no-x-height-expected.txt: Added.
fast/css/ex-unit-with-no-x-height.html: Added.

5:34 PM Changeset in webkit [130436] by dpranke@chromium.org

2 edits in trunk/Source/WTF

Unreviewed, rolling out r130419.
http://trac.webkit.org/changeset/130419
https://bugs.webkit.org/show_bug.cgi?id=98406

broke editing/pasteboard/data-transfer-items.html on chromium

wtf/HashTraits.h:

4:52 PM Changeset in webkit [130435] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[Qt] New test introduced in r129346 inspector-protocol/css-getSupportedCSSProperties.html fails
https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Unskipping this test that is passing.

platform/qt/TestExpectations:

4:51 PM Changeset in webkit [130434] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement PageClientImpl::isViewVisible()
https://bugs.webkit.org/show_bug.cgi?id=98249

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Implement PageClientImpl::isViewVisible() for EFL port
by calling evas_object_visible_get() on the view.

UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::isViewVisible):

4:50 PM Changeset in webkit [130433] by tkent@chromium.org

12 edits in trunk/LayoutTests

Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390

Reviewed by Daniel Bates.

r130375 changed a behavior. A key bind to open a calendar picker
or a suggestion picker was changed from "Down" to "Alt + Down". We
need to update tests which open pickers for input[type=date].

fast/forms/date/calendar-picker-appearance-expected.txt:
fast/forms/date/calendar-picker-appearance-pre-100.html:

Use openPicker() in calendar-picker-common.js.

fast/forms/date/calendar-picker-appearance.html: Ditto.
fast/forms/date/calendar-picker-common.js:

(openPicker): Specify Alt modifier.
(sendKey): Add ctrlKey and altKey flags.

fast/forms/date/calendar-picker-with-step.html:

Use openPicker() in calendar-picker-common.js.

platform/chromium/TestExpectations:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:

Use openPicker() in suggestion-picker-common.js

platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html:

Ditto.

platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:

Ditto.

platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt:
platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html:

Use openPicker() and sendKey() in suggestion-picker-common.js.
Increase the internal timeout because it was too short on my machine.

3:54 PM Changeset in webkit [130432] by ap@apple.com

2 edits in trunk/Source/WebKit2

Improve initial empty process tracking
https://bugs.webkit.org/show_bug.cgi?id=98458

Reviewed by Sam Weinig.

UIProcess/WebContext.cpp: (WebKit::WebContext::disconnectProcess): Unset m_haveInitialEmptyProcess if we no longer do.

3:52 PM Changeset in webkit [130431] by Lucas Forschler

1 copy in tags/Safari-534.58.1

New Tag.

3:45 PM Changeset in webkit [130430] by hclam@chromium.org

3 edits in trunk/LayoutTests

Unreviewed. Chromium rebaselines.

Rebaseline pixel results after r130412.

platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:

3:40 PM Changeset in webkit [130429] by rniwa@webkit.org

4 edits in trunk

Source/WebCore: Build fix after r130411. Add the right offset.
Also use RefPtr instead of a raw pointer for next and previous pointers.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):

LayoutTests: Another rebaseline needed after r130411.

platform/mac/editing/pasteboard/5006779-expected.txt:

3:38 PM Changeset in webkit [130428] by alecflett@chromium.org

30 edits in trunk/Source

IndexedDB: promote objectstore/index backend ids to the frontend
https://bugs.webkit.org/show_bug.cgi?id=97834

Reviewed by Tony Chang.

Source/WebCore:

Expose int64-based database/objectStore/index ids to the renderer,
step 1 of 2. Support both styles of createObjectStore and
createIndex: those that take an explicit id, and those that take
-1, meaning to autogenerate an id on the backend. In part 2, after
the chromium side lands, support for the autogenerated ids will be
removed. (See https://bugs.webkit.org/show_bug.cgi?id=98085)

This is a part of larger refactoring work to ultimately make the interface
between the frontend and the backend simpler.

No new tests, extensive ASSERTs and existing tests cover correctness.

Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::metadata):

Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):

Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):
(WebCore::getMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::getMaxIndexId):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):

Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBDatabaseMetadata):
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
(IDBObjectStoreMetadata):
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(IDBIndexMetadata):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):

Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):

Modules/indexeddb/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Support for marshalling additional IDBMetadata and new calls to
createObjectStore/createIndex.

public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::createObjectStore):

public/WebIDBMetadata.h:

(ObjectStore):
(Index):

public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createObjectStore):
(WebKit):

src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit):

src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit):

src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit):

src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

3:32 PM Changeset in webkit [130427] by commit-queue@webkit.org

6 edits in trunk

[EFL] Add libxml 2.8.0 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=98418

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Laszlo Gombos.

Bump dependency for libxml to 2.8.0 to match
jhbuild.

Source/cmake/OptionsEfl.cmake:

Tools:

Add libxml 2.8.0 to EFL's jhbuild for consistency.

efl/jhbuild.modules:

LayoutTests:

Unskip fast/xsl/xslt-missing-namespace-in-xslt.xml
since it passes with libxml 2.8.0 and we now depend
on that version.

platform/efl/TestExpectations:

3:30 PM Changeset in webkit [130426] by tony@chromium.org

5 edits
1 copy
1 move
9 adds in trunk/LayoutTests

Unreviewed gardening. Landing render tree results for css3/flexbox/flexbox-baseline.html.
https://bugs.webkit.org/show_bug.cgi?id=98306

This pixel test was added in r130405.

platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png: Added.
platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png: Added.
platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png: Added.
platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt: Copied from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.
platform/chromium/TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/css3/flexbox/flexbox-baseline-expected.txt: Added.
platform/mac/TestExpectations:
platform/mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
platform/qt/TestExpectations:
platform/qt/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.

3:23 PM Changeset in webkit [130425] by hclam@chromium.org

1 edit
1 copy
1 move in trunk/LayoutTests

Unreviewed. Chromium rebaselines.

platform/chromium-mac/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.
platform/chromium-win/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.

1:27 PM Changeset in webkit [130424] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Crash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit const + 12
https://bugs.webkit.org/show_bug.cgi?id=98433

Reviewed by Jessie Berlin.

The problem is due to a String with a null StringImpl (i.e. a null string).
Added a length check before the is8Bit() check since length() checks for a null StringImpl. Changed the
characters16() call to characters() since it can handle a null StringImpl as well.

API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

1:18 PM Changeset in webkit [130423] by rniwa@webkit.org

34 edits
1 add
1 delete in trunk/LayoutTests

Chromium rebaselines after r130411.

platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt:
platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt:
platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt:
platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Removed.
platform/chromium-mac-snowleopard/editing/pasteboard/paste-xml-expected.txt: Added.
platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt:
platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
platform/chromium-win/editing/execCommand/paste-1-expected.txt:
platform/chromium-win/editing/execCommand/paste-2-expected.txt:
platform/chromium-win/editing/pasteboard/4944770-2-expected.txt:
platform/chromium-win/editing/pasteboard/5028447-expected.txt:
platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
platform/chromium-win/editing/pasteboard/paste-line-endings-007-expected.txt:
platform/chromium-win/editing/pasteboard/paste-line-endings-008-expected.txt:
platform/chromium-win/editing/pasteboard/paste-line-endings-009-expected.txt:
platform/chromium-win/editing/pasteboard/paste-line-endings-010-expected.txt:
platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
platform/chromium-win/editing/pasteboard/paste-text-009-expected.txt:
platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.txt:
platform/chromium-win/editing/pasteboard/unrendered-br-expected.txt:
platform/chromium-win/fast/lists/drag-into-marker-expected.txt:

1:09 PM Changeset in webkit [130422] by commit-queue@webkit.org

4 edits
2 adds in trunk

Layout broken after cloning and re-inserting a table with a misplaced <form>
https://bugs.webkit.org/show_bug.cgi?id=86746

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-04
Reviewed by Julien Chaffraix.

Source/WebCore:

There is a concept of demotion for a <form> contained in a table. A <form> is demoted if its immediate parent
is either a <table>, table sections (tbody, etc) or a table row (tr). A renderer for such a <form> is created only
if its display is one of the table display types (TABLE, INLINE_TABLE, TABLE_FOOTER_GROUP, etc).
However when a <table> containing a demoted <form> is cloned, the <form> does not retain its demotion state and
results in the table getting improperly rendered.

Test: fast/table/form-with-non-table-display-inside-table-elements.html

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::copyNonAttributePropertiesFromElement):

Extended the virtual function for HTMLFormElement class specific implementation.
The function is used to copy any necessary state information(member variables) associated with
the <form> element being cloned to the current node.
For HTMLFormElement node the member variable can be classified into five groups based on the
information they hold:

1) Variables containing information regarding <form> subtree and elements associated with it.

These get updated as and when an element is added to the <form> subtree.

2) Variables containing <form> submit state information.
3) Flag to hold information if reset() has been called.
4) Flag(m_wasDemoted) that indicates whether the form is demoted or not, based on which it needs to

be handled differently during creation of its renderer.
This information is currently being updated only during the HTML tree construction phase.

5) Flag(m_wasMalformed) to hold information if the <form> is malformed or not.

Variables of group (1) will be updated as and when elements are added to the <form> subtree. Whereas,
(2) and (3) hold instance specific information, thus copying them is not required. Also (5) is currently not
being used(not set by any code).

On the other hand, (4) is required to be copied during cloning as this information cannot be accessed
during the cloning process.

(WebCore):

html/HTMLFormElement.h: Added copyNonAttributePropertiesFromElement() declaration.

LayoutTests:

fast/table/form-with-non-table-display-inside-table-elements-expected.txt: Added.
fast/table/form-with-non-table-display-inside-table-elements.html: Added.

1:01 PM Changeset in webkit [130421] by rniwa@webkit.org

20 edits in trunk/LayoutTests

Qt rebaseline after r130411.

platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
platform/qt/editing/deleting/merge-no-br-expected.txt:
platform/qt/editing/execCommand/find-after-replace-expected.txt:
platform/qt/editing/execCommand/paste-1-expected.txt:
platform/qt/editing/execCommand/paste-2-expected.txt:
platform/qt/editing/pasteboard/4944770-2-expected.txt:
platform/qt/editing/pasteboard/5006779-expected.txt:
platform/qt/editing/pasteboard/5028447-expected.txt:
platform/qt/editing/pasteboard/8145-3-expected.txt:
platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
platform/qt/editing/pasteboard/paste-text-008-expected.txt:
platform/qt/editing/pasteboard/paste-text-009-expected.txt:
platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
platform/qt/editing/pasteboard/unrendered-br-expected.txt:

12:57 PM Changeset in webkit [130420] by Lucas Forschler

1 copy in tags/Safari-537.13

New Tag.

12:49 PM Changeset in webkit [130419] by kling@webkit.org

2 edits in trunk/Source/WTF

Lower minimum table size of WTF::HashTable to reduce memory usage.
<http://webkit.org/b/98406>
<rdar://problem/12432140>

Reviewed by Anders Carlsson.

Lower the default minimumTableSize for WTF hash tables from 64 to 8 entries.
This reduces WebProcess memory consumption by ~16MB on Membuster3 (a 6% progression!)

No significant movement on PLT or JSC benchmarks on my machine. If there's a perf regression somewhere
from this, we can tweak individual tables to have a larger minimumTableSize.

wtf/HashTraits.h:

12:34 PM Changeset in webkit [130418] by benjamin@webkit.org

2 edits in trunk/Source/JavaScriptCore

Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation
https://bugs.webkit.org/show_bug.cgi?id=98335

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-04
Reviewed by Michael Saboff.

Michael Saboff added an optimized version of UChar->LChar conversion in r125846.
Use this function in JSC::Identifier.

runtime/Identifier.cpp:

(JSC::IdentifierLCharFromUCharTranslator::translate):

12:31 PM Changeset in webkit [130417] by dino@apple.com

13 edits in trunk

Attribute and Uniform variable names need translation in shader
https://bugs.webkit.org/show_bug.cgi?id=70989

Reviewed by Tim Horton (and Darin Adler).

Source/WebCore:

WebGL specifies some maximum lengths for variable names (attributes
and uniforms). Also, some GL drivers have issues with long names. For
that reason, ANGLE has an option to rewrite the shader, translating
long names into short names. Turning this on helps shaders compile,
but we need to keep a mapping between the original names and the
translated names, so that we bind to the right location from user code
(which won't ever see the translated source).

This provided an opportunity to clean up some other bits of code:
CSS Filters examined the uniform names after a compilation; It can
now use the variable name map. I also added a typedef for the
HashMaps that keep the shader, the source code and the variable name
mappings.

I also opened a followup bug to make sure these tables are deleted
when the associated shaders (or linked programs) go away:
https://bugs.webkit.org/show_bug.cgi?id=98204

Covered by existing tests (with some enhancements):

fast/canvas/webgl/attrib-location-length-limits.html:
fast/canvas/webgl/uniform-location-length-limits.html:

platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo): Extracts all the information on symbols (either attributes
or uniforms) from the newly compiled shader.
(WebCore):
(WebCore::ANGLEWebKitBridge::compileShaderSource): New method name.

platform/graphics/ANGLEWebKitBridge.h:

(WebCore::getUniforms): Deleted this method.
(WebCore::ANGLEShaderSymbol::isSampler): Make sure the symbol is a uniform.
(ANGLEWebKitBridge):

platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo): A new object that
holds the size, type and translated name of a symbol from a WebGL shader.
(ShaderSourceEntry):
(WebCore::GraphicsContext3D::ShaderSourceEntry::ShaderSourceEntry): Now keeps track
of the translated source code and symbol mappings.
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap): Helper function to
get the member variable corresponding to the type of symbol you're asking fo.

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram): Calls new method
name which also produces a set of symbols to examine.

platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): We now can pass
in some extra compile options to do translation of long symbol names. Also fill the
map of translated symbol names.

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName): Returns the mapped name for
a shader symbol if it was translated during compilation.
(WebCore):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getUniformLocation):

LayoutTests:

Added subtests to exercise variables that are well under the limits but
not long enough to produce an error. This way we now test all three options:
under the limit, at the limit, over the limit.

Also, the tests are unskipped on Mac.

fast/canvas/webgl/attrib-location-length-limits-expected.txt:
fast/canvas/webgl/attrib-location-length-limits.html:
fast/canvas/webgl/uniform-location-length-limits-expected.txt:
fast/canvas/webgl/uniform-location-length-limits.html:
platform/mac/TestExpectations:

12:10 PM Changeset in webkit [130416] by benjamin@webkit.org

31 edits
2 adds in trunk

[WK2] Support all attributes of GeolocationPosition
https://bugs.webkit.org/show_bug.cgi?id=98212

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Sam Weinig.

Source/WebKit/mac:

Add an internal constructor for the sake of testing.
A similar API is used on iOS.

WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPosition initWithGeolocationPosition:]):

Source/WebKit2:

Add complete support for GeolocationPosition.

Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::WebGeolocationPosition):
(WebKit::WebGeolocationPosition::Data::encode):
(WebKit::WebGeolocationPosition::Data::decode):

Shared/WebGeolocationPosition.h:

(Data):
(WebKit::WebGeolocationPosition::create):
(WebKit::WebGeolocationPosition::canProvideAltitude):
(WebKit::WebGeolocationPosition::altitude):
(WebGeolocationPosition):
(WebKit::WebGeolocationPosition::canProvideAltitudeAccuracy):
(WebKit::WebGeolocationPosition::altitudeAccuracy):
(WebKit::WebGeolocationPosition::canProvideHeading):
(WebKit::WebGeolocationPosition::heading):
(WebKit::WebGeolocationPosition::canProvideSpeed):
(WebKit::WebGeolocationPosition::speed):
WebGeolocationPosition mirror the attributes of WebCore::GeolocationPosition.

UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate):
(WKGeolocationPositionCreate_b):
Add a new API exposing all the arguments.

UIProcess/API/C/WKGeolocationPosition.h:
WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):

Tools:

Expand WebKitTestRunner and DumpRenderTree to test all the attributes
of GeolocationPosition.

DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionCallback):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/efl/TestRunnerEfl.cpp: