Timeline
Oct 6, 2012:
- 6:55 PM Changeset in webkit [130593] by
-
- 7 edits in trunk/LayoutTests
Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=98479
Skip tests in fast/forms/date-multiple-fields/ because it needs
ENABLE_INPUT_MULTIPLE_FIELDS_UI.
- platform/chromium-android/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 6:35 PM Changeset in webkit [130592] by
-
- 9 edits8 adds in trunk
-webkit-clip-path should parse IRIs
https://bugs.webkit.org/show_bug.cgi?id=96381
Patch by Raul Hudea <rhudea@adobe.com> on 2012-10-06
Reviewed by Andreas Kling.
Source/WebCore:
Implemented the clipping via referencing a SVG clipPath. Currently it works only if the clipPath is defined
before using it on an HTML element. The forward reference issue is tracked via https://bugs.webkit.org/show_bug.cgi?id=90405.
Tests: css3/masking/clip-path-reference-userSpaceOnUse.html
css3/masking/clip-path-reference.html
fast/masking/parsing-clip-path-iri.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add handling for SVG clipPath references.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Add handling for SVG clipPath references.
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyClipPath::applyValue): Add handling for SVG references.
- rendering/ClipPathOperation.h:
(ReferenceClipPathOperation): Added a new class corresponding to SVG referenced clipPath.
(WebCore::ReferenceClipPathOperation::create):
(WebCore::ReferenceClipPathOperation::url):
(WebCore::ReferenceClipPathOperation::fragment):
(WebCore::ReferenceClipPathOperation::operator==):
(WebCore::ReferenceClipPathOperation::ReferenceClipPathOperation):
(WebCore):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): Add handling for ReferenceClipPathOperation.
- rendering/svg/RenderSVGResourceClipper.h:
(RenderSVGResourceClipper): Made applyClippingToContext public as it needs to be called directly for HTML elements.
LayoutTests:
Tests for SVG referenced clipPath with both types of clipPathUnits: "userSpaceOnUse" and "objectBoundingBox".
- css3/masking/clip-path-reference-expected.html: Added.
- css3/masking/clip-path-reference-userSpaceOnUse-expected.html: Added.
- css3/masking/clip-path-reference-userSpaceOnUse.html: Added.
- css3/masking/clip-path-reference.html: Added.
- fast/masking/parsing-clip-path-iri-expected.txt: Added.
- fast/masking/parsing-clip-path-iri.html: Added.
- platform/chromium/TestExpectations:
- 5:02 PM Changeset in webkit [130591] by
-
- 2 edits in trunk/Source/WebCore
Reduce calls to CGImageSourceCopyPropertiesAtIndex from frameSizeAtIndex
https://bugs.webkit.org/show_bug.cgi?id=98607
Reviewed by Dan Bernstein.
Refactor code so that we avoid a second call to CGImageSourceCopyPropertiesAtIndex under
ImageSource::frameSizeAtIndex().
No new tests because no functional change.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::orientationFromProperties):
(WebCore):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
- 2:51 PM Changeset in webkit [130590] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
Stop calling -[NSSliderCell setTitle:]. It's never done anything on OS X.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
- 1:03 PM Changeset in webkit [130589] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark media/audio-garbage-collect.html as flaky on WK2.
- platform/efl-wk2/TestExpectations:
- 12:14 PM Changeset in webkit [130588] by
-
- 22 edits in trunk/Source/WebCore
Clipboard::types() should return an ordered collection.
<http://webkit.org/b/98547>
Reviewed by Darin Adler.
Let Clipboard::types() return a ListHashSet<String> instead of a HashSet<String> to make sure
it retains the order in which type strings are added.
No test, this fixes an issue that was uncovered when lowering the default table size of WTF
hash tables, causing the HashSet<String> to rehash and reorder itself.
- bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
- dom/Clipboard.h:
(Clipboard):
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
- 11:51 AM Changeset in webkit [130587] by
-
- 2 edits in trunk/Source/WebCore
If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
https://bugs.webkit.org/show_bug.cgi?id=88834
Reviewed by Gavin Barraclough.
Follow-up patch to address some comments by Darin Adler.
- bindings/js/JSNodeCustom.h:
(WebCore::willCreatePossiblyOrphanedTreeByRemoval): Save some space by
collapsing comment lines. Use Node::hasChildNodes() for brevity.
- 11:44 AM Changeset in webkit [130586] by
-
- 4 edits in trunk/Source/WebCore
Fix weird use of KURL's protocolIs
https://bugs.webkit.org/show_bug.cgi?id=98584
Reviewed by Adam Barth.
Converting a KURL to string is a bad idea.
Invalid URLs can return a string that pass the tests, while an
invalid URL will fail protocolIs().
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
- platform/network/DataURL.cpp:
(WebCore::handleDataURL):
- 11:37 AM Changeset in webkit [130585] by
-
- 11 edits in trunk/Source
Source/WebCore: WebCore part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601
Reviewed by Darin Adler.
- WebCore.exp.in: Exported Font::setDefaultTypesettingFeatures().
- platform/graphics/Font.cpp:
(WebCore::Font::s_defaultTypesettingFeatures): Defined this static.
(WebCore::Font::setDefaultTypesettingFeatures): Added this setter.
(WebCore::Font::defaultTypesettingFeatures): Added this getter.
- platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures): Changed to use the value of the new static member
s_defaultTypesettingFeatures, rather than 0, if text-redering is set to auto.
Source/WebKit/mac: WebKit/mac part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601
Reviewed by Darin Adler.
- WebView/WebView.mm:
(+[WebView initialize]): Added a call to Font::setDefaultTypesettingFeatures() to enable
kerning and ligatures if the WebKitKerningAndLigaturesEnabledByDefault user default key has
the value YES.
Source/WebKit2: WebKit2 part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601
Reviewed by Darin Adler.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Added initializer for
to shouldEnableKerningAndLigaturesByDefault. The initial value is false.
(WebKit::WebProcessCreationParameters::encode): Added encoding of
shouldEnableKerningAndLigaturesByDefault.
(WebKit::WebProcessCreationParameters::decode): Added decoding of
shouldEnableKerningAndLigaturesByDefault.
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters): Added shouldEnableKerningAndLigaturesByDefault boolean
member variable.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess): Changed to set
shouldEnableKerningAndLigaturesByDefault in the process creation parameters according to
the value of the WebKitKerningAndLigaturesEnabledByDefault user defaults key.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Added a call to
Font::setDefaultTypesettingFeatures() to enable kerning and ligatures if requested in the
process creation parameters.
- 11:27 AM Changeset in webkit [130584] by
-
- 10 edits4 adds in trunk
If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
https://bugs.webkit.org/show_bug.cgi?id=88834
Reviewed by Gavin Barraclough.
Source/WebCore:
- bindings/js/JSNodeCustom.cpp:
(WebCore::isObservable): Clarified this comment, since it seems to have
misled some folks.
- bindings/js/JSNodeCustom.h:
(WebCore::willCreatePossiblyOrphanedTreeByRemoval): New helper function
to ensure that a disconnected tree is visible to JavaScript.
- bindings/js/ScriptState.cpp:
(WebCore::mainWorldScriptState): Need to check for null because a document's
frame can be null.
- dom/ContainerNode.cpp:
(WebCore::dispatchChildRemovalEvents): When we remove a subtree from the
document, we sever the reference that JavaScript previously held by
referencing its root. So, we give JavaScript an opportunity to establish
a reference to the new root.
LayoutTests:
- fast/dom/gc-12-expected.txt: Added.
- fast/dom/gc-12.html: Added. Test case matches an example cited by
Kentaro Hara <haraken@chromium.org> in bugzilla.
- fast/dom/gc-3-expected.txt:
- fast/dom/gc-3.html:
- fast/dom/gc-5-expected.txt:
- fast/dom/gc-5.html: Updated these tests to reflect new expected behavior.
We've decided that disconnected trees should persist in memory. This risks
a programmer accidentally retaining more memory than expected, but it
also makes the API more obvious.
- fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
- fast/dom/gc-dom-tree-lifetime.html: Added. Test case written by
Kentaro Hara <haraken@chromium.org>.
- 9:55 AM Changeset in webkit [130583] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening.
Skip fast/selectors/unqualified-hover-strict.html because it seems
to be flaky.
While here, correct its pixel expectation and fix its
svn:mime-type property.
- platform/efl/fast/selectors/unqualified-hover-strict-expected.png: Modified property svn:mime-type.
- 3:35 AM Changeset in webkit [130582] by
-
- 3 edits in trunk/Source/WebCore
Fix build warning : -Wunused-parameter.
https://bugs.webkit.org/show_bug.cgi?id=98583
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-06
Reviewed by Kentaro Hara.
Use ASSERT_UNUSED() macro to remove build warning.
- plugins/PluginStream.cpp:
(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::didReceiveResponse):
(WebCore::PluginStream::didReceiveData):
(WebCore::PluginStream::didFail):
(WebCore::PluginStream::didFinishLoading):
- plugins/PluginView.cpp:
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):
- 2:26 AM Changeset in webkit [130581] by
-
- 5 edits in trunk/Source
Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964
https://bugs.webkit.org/show_bug.cgi?id=98500
Reviewed by Benjamin Poulain.
Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter().
Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1.
Source/WebKit/chromium:
- tests/MemoryInstrumentationTest.cpp:
Source/WTF:
- wtf/MemoryInstrumentationString.h:
(WTF::reportMemoryUsage):
- wtf/text/StringImpl.h:
(WTF::StringImpl::hasInternalBuffer):
- 2:03 AM Changeset in webkit [130580] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=98590
Unreviewed EFL gardening.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
- platform/efl/TestExpectations: Skip
fast/writing-mode/vertical-subst-font-vert-no-dflt.html after r130570.
- platform/efl/http/tests/misc/acid3-expected.txt: Update baselines
after r130555.
- 2:01 AM Changeset in webkit [130579] by
-
- 2 edits4 adds in trunk/LayoutTests
[EFL] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=98576
Unreviewed EFL gardening.
Add platform-specific baselines after r130443 and r130489.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
- platform/efl/TestExpectations:
- platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
- platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
- platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
- platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
- 1:58 AM Changeset in webkit [130578] by
-
- 3 edits1 delete in trunk/LayoutTests
[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=98575
Unreviewed EFL gardening.
Skip failing tests in order to make the bots green.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/fast/replaced/object-with-embed-url-param-expected.txt: Removed. Current results
matches the base expectations on WK2.
- 1:08 AM Changeset in webkit [130577] by
-
- 3 edits in trunk/Source/WTF
Fix build of WTFURL after r130187
https://bugs.webkit.org/show_bug.cgi?id=98588
Reviewed by Kentaro Hara.
- wtf/MemoryInstrumentationParsedURL.h:
(WTF::reportMemoryUsage):
- wtf/url/api/ParsedURL.h:
(WTF::ParsedURL::spec):
Oct 5, 2012:
- 11:46 PM Changeset in webkit [130576] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding reftest failure expectations for a couple of tests that
were introduced in r130557 and r130570.
- platform/gtk/TestExpectations:
- 11:20 PM Changeset in webkit [130575] by
-
- 65 edits19 adds in trunk/LayoutTests
[Chromium] Rebaseline for recent INPUT_MULTIPLE_FIELDS_UI changes
- platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png:
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium/TestExpectations:
- 7:08 PM Changeset in webkit [130574] by
-
- 2 edits in trunk/Source/WebCore
[V8] toV8(Node*, ...) does more work than needed (6% faster on dom-traverse)
https://bugs.webkit.org/show_bug.cgi?id=98567
Reviewed by Kentaro Hara.
This patch introduces toV8Fast for Node*. This function works a
differently from the existing toV8 function in two ways:
1) It uses the inline wrapper cache in Node to determine if we're
executing in the main world. This is faster both in the case when
isolated worlds exist because we don't need to retrieve any state
for the current context.
2) It doesn't attempt to inline the hash table lookup used to find the
wrapper in the isolated world. There isn't a big need to inline this
code since performance in the isolated world case is dominated by
the hash table lookup.
Because of these two changes, toV8Fast is small enough to inline into
each attribute getter profitably. Over time, I would like to convert
all the performance critical uses of toV8(Node*) to toV8Fast. At that
point, we can delete toV8 and rename toV8Slow to toV8.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
- 6:28 PM Changeset in webkit [130573] by
-
- 6 edits in trunk/Source/WebCore
[mac] REGRESSION (r122215): Animated GIF outside the viewport doesn't play when scrolled into view.
https://bugs.webkit.org/show_bug.cgi?id=94874
Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-05
Reviewed by Simon Fraser.
Rollback previous patch because this patch caused two problems.
- GIF animation is occasionally paused when tiled scrolling is enabled.
- This change regressed Apple's Membuster benchmark by ~20% (80MB.)
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::shouldPauseAnimation):
- loader/cache/CachedImage.h:
(CachedImage):
- loader/cache/CachedResource.h:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToSize):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):
- 6:23 PM Changeset in webkit [130572] by
-
- 2 edits in trunk/Tools
Attempt to fix the SnowLeopard build to making the implementation of
-isPaginated come before its use.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController reload:]):
(-[WK1BrowserWindowController forceRepaint:]):
(-[WK1BrowserWindowController goBack:]):
(-[WK1BrowserWindowController goForward:]):
(-[WK1BrowserWindowController isPaginated]):
- 6:09 PM Changeset in webkit [130571] by
-
- 6 edits3 copies1 add in trunk/Tools
Provide a way to run WebKit1
https://bugs.webkit.org/show_bug.cgi?id=98568
Reviewed by Tim Horton.
Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.
Turn BrowserWindowController into a base class; subclassed by
WK1BrowserWindowController and WK2BrowserWindowController, each of
which implement the BrowserController protocol.
Use Command-N to get a WebKit1 window, and Command-Option-N to
get a WK2 window. Also add "Open Location" to focus the URL bar,
and code to add an http:// if missing.
Hook up window title callbacks; append " [WK1/2]" to window title
as appropriate.
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithWindow:]):
(-[BrowserWindowController windowDidLoad]):
(-[BrowserWindowController openLocation:]):
(-[BrowserWindowController loadURLString:]):
(-[BrowserWindowController applicationTerminating]):
(-[BrowserWindowController addProtocolIfNecessary:]):
- MiniBrowser/mac/MainMenu.xib:
- MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
(WebView):
- MiniBrowser/mac/WK1BrowserWindowController.m: Added.
(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController dealloc]):
(-[WK1BrowserWindowController loadURLString:]):
(-[WK1BrowserWindowController fetch:]):
(-[WK1BrowserWindowController showHideWebView:]):
(-[WK1BrowserWindowController removeReinsertWebView:]):
(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController reload:]):
(-[WK1BrowserWindowController forceRepaint:]):
(-[WK1BrowserWindowController goBack:]):
(-[WK1BrowserWindowController goForward:]):
(-[WK1BrowserWindowController validateUserInterfaceItem:]):
(-[WK1BrowserWindowController validateToolbar]):
(-[WK1BrowserWindowController windowShouldClose:]):
(-[WK1BrowserWindowController windowWillClose:]):
(-[WK1BrowserWindowController applicationTerminating]):
(-[WK1BrowserWindowController currentZoomFactor]):
(-[WK1BrowserWindowController canZoomIn]):
(-[WK1BrowserWindowController zoomIn:]):
(-[WK1BrowserWindowController canZoomOut]):
(-[WK1BrowserWindowController zoomOut:]):
(-[WK1BrowserWindowController canResetZoom]):
(-[WK1BrowserWindowController resetZoom:]):
(-[WK1BrowserWindowController toggleZoomMode:]):
(-[WK1BrowserWindowController isPaginated]):
(-[WK1BrowserWindowController togglePaginationMode:]):
(-[WK1BrowserWindowController find:]):
(-[WK1BrowserWindowController dumpSourceToConsole:]):
(-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
(-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
- MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
- MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.
(-[WK2BrowserWindowController initWithContext:pageGroup:]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController showHideWebView:]):
(-[WK2BrowserWindowController removeReinsertWebView:]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController reload:]):
(-[WK2BrowserWindowController forceRepaint:]):
(-[WK2BrowserWindowController goBack:]):
(-[WK2BrowserWindowController goForward:]):
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
(-[WK2BrowserWindowController validateToolbar]):
(-[WK2BrowserWindowController windowShouldClose:]):
(-[WK2BrowserWindowController windowWillClose:]):
(-[WK2BrowserWindowController applicationTerminating]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController canZoomIn]):
(-[WK2BrowserWindowController zoomIn:]):
(-[WK2BrowserWindowController canZoomOut]):
(-[WK2BrowserWindowController zoomOut:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController isPaginated]):
(-[WK2BrowserWindowController togglePaginationMode:]):
(-[WK2BrowserWindowController dumpSourceToConsole:]):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didSameDocumentNavigationForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):
(didRemoveFrameFromHierarchy):
(didDisplayInsecureContentForFrame):
(didRunInsecureContentForFrame):
(didDetectXSSForFrame):
(didStartProgress):
(didChangeProgress):
(didFinishProgress):
(didBecomeUnresponsive):
(didBecomeResponsive):
(processDidExit):
(didChangeBackForwardList):
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForResponse):
(createNewPage):
(showPage):
(closePage):
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(mouseDidMoveOverElement):
(getWindowFrame):
(setWindowFrame):
(runBeforeUnloadConfirmPanel):
(runOpenPanel):
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController didStartProgress]):
(-[WK2BrowserWindowController didChangeProgress:]):
(-[WK2BrowserWindowController didFinishProgress]):
(-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
(-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
(-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
(-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
(-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
(-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
(-[WK2BrowserWindowController didCommitLoadForFrame:]):
(-[WK2BrowserWindowController loadURLString:]):
(-[WK2BrowserWindowController performFindPanelAction:]):
(-[WK2BrowserWindowController find:]):
- 5:38 PM Changeset in webkit [130570] by
-
- 5 edits2 adds in trunk
OpenTypeVerticalData issue with DroidSansFallback.ttf on chromium-android and chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=97824
Reviewed by Tony Chang.
Source/WebCore:
The issue occurred when a font that contains vert GSUB table but doesn't have
a DFLT script and the first script doesn't have vert feature. Added logic to
handle the case.
Test: fast/writing-mode/vertical-subst-font-vert-no-dflt.html
- platform/graphics/opentype/OpenTypeVerticalData.cpp:
(FeatureList):
(WebCore::OpenType::FeatureList::findFeature): Added to find the matching feature in FeatureList.
(WebCore::OpenType::GSUBTable::feature): Added logic to handle the case of no DFLT script and no vert feature under the first script.
LayoutTests:
Ref test for the change. The punctuations in the vertical text are expected to
be substituted with the corresponding vertical forms.
- fast/writing-mode/vertical-subst-font-vert-no-dflt-expected.html: Added.
- fast/writing-mode/vertical-subst-font-vert-no-dflt.html: Added.
- platform/mac/TestExpectations: Added the new test as it fails on Mac because of https://bugs.webkit.org/show_bug.cgi?id=98560.
- 4:57 PM Changeset in webkit [130569] by
-
- 10 edits2 adds23 deletes in trunk
Form controls should always be horizontal
https://bugs.webkit.org/show_bug.cgi?id=98563
Reviewed by Ojan Vafai.
Source/WebCore:
Fix a regression where we didn't force form controls to be horizontal.
Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
fast/table/colspanMinWidth-vertical.html
- css/html.css:
(input, textarea, keygen, select, button, isindex, meter, progress):
LayoutTests:
Convert fast/dom/HTMLMeterElement/meter-writing-mode.html and
fast/dom/HTMLProgressElement/progress-writing-mode.html to be ref tests.
Also rebaseline fast/table/colspanMinWidth-vertical.html and mark the
test as needing a rebaseline on platforms other than Chromium Linux.
- fast/dom/HTMLMeterElement/meter-writing-mode-expected.html: Added.
- fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
- fast/dom/HTMLProgressElement/progress-writing-mode-expected.html: Added.
- fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
- fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
- platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
- platform/efl/TestExpectations:
- platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
- platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
- platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
- platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/qt/TestExpectations:
- platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
- platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
- 4:42 PM Changeset in webkit [130568] by
-
- 12 edits in trunk
[WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=98524
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Add implementation for testRunner.setSerializeHTTPLoads in
WebKitTestRunner.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetSerialLoadingEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setSerialLoadingEnabled):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Tools:
Add implementation for testRunner.setSerializeHTTPLoads in
WebKitTestRunner.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setSerializeHTTPLoads):
(WTR):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Unskip tests that are now passing.
- platform/wk2/TestExpectations:
- 4:28 PM Changeset in webkit [130567] by
-
- 30 edits1 delete in trunk
Unreviewed, rolling out r130556 and r130564.
http://trac.webkit.org/changeset/130556
http://trac.webkit.org/changeset/130564
https://bugs.webkit.org/show_bug.cgi?id=98572
The patch wasn't reviewed by a reviewer and it is breaking
Chromium Windows (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- css/mediaControls.css:
(video::-webkit-media-text-track-container):
(video::-webkit-media-text-track-past-nodes):
(video::-webkit-media-text-track-future-nodes):
(video::-webkit-media-text-track-display):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::attach):
(WebCore::HTMLMediaElement::userIsInterestedInThisLanguage):
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::updateClosedCaptionsControls):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/shadow/MediaControlElements.cpp:
(WebCore):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
- html/shadow/MediaControlElements.h:
(MediaControlTextTrackContainerElement):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::updateTextTrackDisplay):
- html/shadow/MediaControlRootElement.h:
(MediaControlRootElement):
- html/shadow/MediaControls.h:
(MediaControls):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::isValidKindKeyword):
(WebCore::TextTrack::setKind):
(WebCore::TextTrack::setMode):
(WebCore::TextTrack::mode):
- html/track/TextTrack.h:
(WebCore::TextTrack::create):
(WebCore::TextTrack::kind):
(TextTrack):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCueBox::shadowPseudoId):
(WebCore):
(WebCore::TextTrackCue::updateDisplayTree):
- html/track/TextTrackCue.h:
(TextTrackCueBox):
(TextTrackCue):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- rendering/CaptionPreferencesChangedListener.h: Removed.
- rendering/RenderTheme.h:
(WebCore):
(RenderTheme):
- rendering/RenderThemeMac.h:
(RenderThemeMac):
- rendering/RenderThemeMac.mm:
(WebCore):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries:
- WebKitSystemInterface.h:
LayoutTests:
- media/track/track-cue-rendering-expected.txt:
- media/track/track-cue-rendering.html:
- platform/chromium/TestExpectations:
- 3:59 PM Changeset in webkit [130566] by
-
- 2 edits in trunk/Source/WebKit2
Set the current working directory to TMPDIR when entering the sandbox in the plug-in process.
Based on a patch by Ivan Krstić.
Reviewed by Anders Carlsson.
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
(enterSandbox):
- 3:56 PM Changeset in webkit [130565] by
-
- 9 edits in trunk/Source
[cg] GraphicsContextCG should ask CG whether the shadow offset workaround is required
https://bugs.webkit.org/show_bug.cgi?id=98565
<rdar://problem/12436468>
Reviewed by Simon Fraser.
On Mountain Lion and above, CG can tell us whether we need to work around incorrect
shadow offsets. Prior to Mountain Lion, we should assume we need to apply the workaround.
No new tests, as this requires an obscure configuration to test.
- WebCore.exp.in:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::applyShadowOffsetWorkaroundIfNeeded):
(WebCore::GraphicsContext::setPlatformShadow):
- platform/mac/WebCoreSystemInterface.h: Add wkCGContextDrawsWithCorrectShadowOffsets.
- platform/mac/WebCoreSystemInterface.mm: Add wkCGContextDrawsWithCorrectShadowOffsets.
Add wkCGContextDrawsWithCorrectShadowOffsets.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 3:53 PM Changeset in webkit [130564] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the build.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::captionsWindowColor):
- 3:30 PM Changeset in webkit [130563] by
-
- 5 edits in trunk/WebKitLibraries
Update WebKitSystemInterface libraries and header.
Reviewed by Simon Fraser.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 3:30 PM Changeset in webkit [130562] by
-
- 3 edits in trunk/Tools
TestResultsServer does not display sync_integration_tests results
https://bugs.webkit.org/show_bug.cgi?id=98551
Patch by Richard Larocque <rlarocque@chromium.org> on 2012-10-05
Reviewed by Ojan Vafai.
Allow builders whose name contains "Sync" to pass through the
isChromiumWebkitDepsTestRunner filter.
The test expectations in flakiness_dashboard_unittests.js have been
updated to match the new behaviour.
- TestResultServer/static-dashboards/builders.js:
(isChromiumDepsGTestRunner):
- 3:13 PM Changeset in webkit [130561] by
-
- 2 edits8 adds4 deletes in trunk/LayoutTests
Unreviewed Chromium gardening.
- platform/chromium/TestExpectations:
Updated a wrong bug info and rebaselined 2 tests:
fast/reflections/inline-crash.html and fast/backgrounds/solid-color-context-restore.html
- fast/backgrounds/solid-color-context-restore-expected.txt: Added.
- fast/reflections/inline-crash-expected.txt: Added.
- platform/chromium-linux/fast/backgrounds/solid-color-context-restore-expected.png: Added.
- platform/chromium-linux/fast/reflections/inline-crash-expected.png: Added.
- platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.png: Added.
- platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
- platform/chromium-win/fast/reflections/inline-crash-expected.png: Added.
- platform/chromium-win/fast/reflections/inline-crash-expected.txt: Added.
- platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
- platform/efl/fast/reflections/inline-crash-expected.txt: Removed.
- platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
- platform/gtk/fast/reflections/inline-crash-expected.txt: Removed.
- 3:09 PM Changeset in webkit [130560] by
-
- 4 edits in trunk/Source/WebCore
Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
https://bugs.webkit.org/show_bug.cgi?id=98550
Reviewed by Andreas Kling.
This shaved another 5% (100ms) off of the runtime of resizecol.html microbenchmark:
http://www.robohornet.org/tests/resizecol.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- 3:08 PM Changeset in webkit [130559] by
-
- 2 edits in trunk/Tools
Tests in webkitpy involving child processes are flaky.
Skipping run_webkit_tests_integrationtest.py.
https://bugs.webkit.org/show_bug.cgi?id=98559
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_verbose_in_child_processes):
- 3:05 PM Changeset in webkit [130558] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS
https://bugs.webkit.org/show_bug.cgi?id=98526
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-05
Reviewed by Stephen White.
This is causing some problems with picture serialization between chrome
and the mainline skia tools. (Once this change lands and is gardened in,
I will make the corresponding change in chromium/skia/skia.gyp)
- features.gypi:
- 3:01 PM Changeset in webkit [130557] by
-
- 1 edit2 moves8 adds in trunk/LayoutTests
[CSS Exclusions] Add shape-inside tests for rounded rectangles
https://bugs.webkit.org/show_bug.cgi?id=96669
Patch by Bear Travis <betravis@adobe.com> on 2012-10-05
Reviewed by Levi Weintraub.
Adding multiple rounded rectangle tests. The more complex tests use float "sandbags"
to simulate the shape-inside area in the test expectations.
(See http://www.alistapart.com/articles/sandbags/)
In general, each line has its own pair of left and right floats (both lineHeight tall),
to position the text and appropriately limit its width. In the simple, 0 corner radius
cases, these floats can be merged because they all have the same width on the left and
right.
- fast/exclusions/resources/rounded-rectangle.js: Contains functionality for generating
a shape-inside, simulating one, and generating content that should roughly fill the
shape-inside.
(xFromEllipseCenter): The x distance from the center of an ellipse, based on its y
distance from center.
(xInset): The inset of a rounded rectangle from its bounding box.
(generateString): Generate a string that roughly fills a shape-inside's content area.
(simulateShape): Create floats to simulate a shape-inside area.
(simulateShapeOutline): Create an outline for the rounded rectangle shape-inside.
(generateSimulatedShapeElement): Simulate a shape-inside and appropriately fill it
with content.
(generateShapeElement): Create a shape-inside and fill it with content.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001-expected.html:
Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle-expected.html.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001.html:
Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
- 2:57 PM Changeset in webkit [130556] by
-
- 30 edits1 add in trunk
Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>
Patch by Eric Carlson <eric.carlson@apple.com> on 2012-10-04
Reviewed by Silvia Pfeiffer.
Source/WebCore:
- WebCore.exp.in: Export new WebkitSystemInterface functions.
- WebCore.xcodeproj/project.pbxproj: Add CaptionPreferencesChangedListener.h.
- css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,
background, and text independently.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
(WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
(WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as
un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.
(WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from
setClosedCaptionsVisible
- html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::userCaptionPreferencesChanged): New, if theme
has a captions style sheet override, inject it into the current page group, otherwise
remove injected sheet.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member
variable. Get caption font scale from theme instead of hard coding.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::userCaptionPreferencesChanged): New.
(WebCore::MediaControlRootElement::updateTextTrackDisplay):
- html/shadow/MediaControlRootElement.h: Add userCaptionPreferencesChanged, minor cleanup.
- html/shadow/MediaControls.h:
(WebCore::MediaControls::userCaptionPreferencesChanged): New.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the
shadow pseudo id so it can be used elsewhere.
(WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
(WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the
shadow pseudo id so it can be used elsewhere.
(WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
(WebCore::TextTrackCue::updateDisplayTree):
- html/track/TextTrackCue.h:
- platform/mac/WebCoreSystemInterface.h: Updated.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- rendering/CaptionPreferencesChangedListener.h: Added.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::userPrefersCaptions): New, default do-nothing implementation.
(WebCore::RenderTheme::userHasCaptionPreferences): Ditto.
(WebCore::RenderTheme::captionFontSizeScale): Ditto.
(WebCore::RenderTheme::captionsStyleSheetOverride): Ditto.
(WebCore::RenderTheme::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::RenderTheme::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::userCaptionPreferencesChangedNotificationCallback): New, receives preference changed notifications.
(WebCore::RenderThemeMac::RenderThemeMac): Initialize m_listeningForCaptionPreferenceNotifications.
(WebCore::RenderThemeMac::~RenderThemeMac): Unregister for notifications if necessary.
(WebCore::RenderThemeMac::userHasCaptionPreferences): New, passthrough to WKSI function.
(WebCore::RenderThemeMac::userPrefersCaptions): Ditto.
(WebCore::RenderThemeMac::captionsWindowColor): Return Color with user's caption window color preference.
(WebCore::RenderThemeMac::captionsBackgroundColor): Return Color with user's caption
background color preference.
(WebCore::RenderThemeMac::captionsTextColor): Return Color with user's caption text color preference.
(WebCore::RenderThemeMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
(WebCore::RenderThemeMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow
or webkit-text-stroke property.
(WebCore::RenderThemeMac::cssColorProperty): Return a String with css to set a property
with a color value.
(WebCore::RenderThemeMac::captionsTextEdgeStyle): Return a String with css to style caption
text with the user's preferred text edge stye.
(WebCore::RenderThemeMac::captionsDefaultFont): Return a String with css to style caption
text with the user's preferred font.
(WebCore::RenderThemeMac::captionsStyleSheetOverride): Return a String with css to style captions
with the user's preferred style.
(WebCore::RenderThemeMac::captionFontSizeScale): Return the user's preferred caption font scale.
(WebCore::RenderThemeMac::captionPreferencesChanged): Notify listeners of caption preference change.
(WebCore::RenderThemeMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences
changes listener.
(WebCore::RenderThemeMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences
changes listener.
Source/WebKit/mac:
Add WCSI support for new WKSI caption functions.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize new WKSI function pointers.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize new WKSI function pointers.
WebKitLibraries:
Update WKSI header with SPI for getting the user caption appearance preferences.
- WebKitSystemInterface.h:
LayoutTests:
- media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
- media/track/track-cue-rendering.html:
- platform/chromium/TestExpectations: Skip tests that need to be rebaselined.
- 2:54 PM Changeset in webkit [130555] by
-
- 6 edits4 adds in trunk
Inline continuations create :after generated content on style recalcs
https://bugs.webkit.org/show_bug.cgi?id=93170
Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-05
Reviewed by Abhishek Arya.
Source/WebCore:
The bug is caused by RenderInline::styleDidChange's setContinuation(0).
RenderObjectChildList uses continuation to know whether the given
renderer should have AFTER render object or not.
However, setContinuation(0) makes RenderObjectChildList to
misunderstand that all continuations are last continuation.
To avoid the misunderstanding, added a new flag to class
RenderObejctChildList to enable/disable updating :after content (and
also :before content).
Tests: fast/css-generated-content/after-with-inline-continuation.html
fast/css-generated-content/dynamic-apply-after-for-inline.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
Disable upating :after content for continuations which are not
the last one during setStyle just after setContinuation(0).
The setStyle invokes RenderInline::styleDidChange and also invokes
updateBeforeAfterContent via the styleDidChange. This means,
the last continuation's updateBeforeAfterContent is also invoked
after setContinuation(0). We have to update :after for the last
continuation.
- rendering/RenderObjectChildList.cpp:
(WebCore):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
If s_updateBeforeAfterContent is false, quickly exit
updateBeforeAfterContent.
- rendering/RenderObjectChildList.h:
(RenderObjectChildList):
Added a new flag s_enableUpdateBeforeAfterContent to enable/disable
updating :before or :after content.
LayoutTests:
- fast/css-generated-content/after-with-inline-continuation-expected.html: Added.
- fast/css-generated-content/after-with-inline-continuation.html: Added.
- fast/css-generated-content/dynamic-apply-after-for-inline-expected.html: Added.
- fast/css-generated-content/dynamic-apply-after-for-inline.html: Added.
- http/tests/misc/acid3-expected.txt:
The acid3-expected.txt has the duplicate RenderBlock (positioned).
Two 'layer at(638, 18) size 20x20, ... text run at (0,0) width 20: "X"'
exist. So did reset-results for acid3-expected.txt.
- 2:51 PM Changeset in webkit [130554] by
-
- 4 edits in trunk/Source/WebCore
Don't assume that TileCache layers are opaque
https://bugs.webkit.org/show_bug.cgi?id=98555
Reviewed by Dean Jackson.
TileCache previously set all its tile CALayers as opaque.
However, we will need non-opaque tile caches when we use this
tile cache for tiled layers, so add a member function to
control tile opacity.
RenderLayerBacking already calls m_graphicsLayer->setContentsOpaque()
using the FrameView's notion of opaqueness, so this change will
cause the main tile cache to be non-opaque if external forces have
set the FrameView to be non-opaque.
Also tweak the layer border widths on tiled layers.
- platform/graphics/ca/mac/TileCache.h:
(TileCache):
(WebCore::TileCache::tilesAreOpaque):
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
(WebCore::TileCache::setTilesOpaque):
(WebCore::TileCache::createTileLayer):
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setOpaque:]):
(-[WebTileCacheLayer isOpaque]):
(-[WebTileCacheLayer setBorderWidth:]):
- 2:39 PM Changeset in webkit [130553] by
-
- 5 edits in trunk
Fix margin box ascent computation in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98540
Reviewed by Ojan Vafai.
Source/WebCore:
The margin box ascent doesn't depend on the margin below the box.
Tests: css3/flexbox/flex-align.html: Fixed a test case and removed a FIXME.
css3/flexbox/flex-align-vertical-writing-mode.html: Similar test case.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::marginBoxAscentForChild):
LayoutTests:
Remove a FIXME and update the results.
- css3/flexbox/flex-align-vertical-writing-mode.html:
- css3/flexbox/flex-align.html:
- 2:38 PM Changeset in webkit [130552] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed.
Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on
some code that is conditionally compiled and therefore fails in some
configurations.
- tests/WebFrameTest.cpp:
- 2:22 PM Changeset in webkit [130551] by
-
- 4 edits1 move14 adds2 deletes in trunk
[chromium] Enhance support for transforms in LinkHighlight.
https://bugs.webkit.org/show_bug.cgi?id=94355
Reviewed by Adrienne Walker.
Improved handling of transformed highlight targets, where the transform goes beyond simple translation.
Source/WebKit/chromium:
- src/LinkHighlight.cpp:
(WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates.
(WebKit):
(WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::bestTouchLinkNode):
LayoutTests:
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.txt: Added.
- 2:13 PM Changeset in webkit [130550] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed build fix after r130545.
- tests/WebFrameTest.cpp:
Avoid a warning about truncating the double constant on Windows. While touching the variable, changed
it to be proper camelCase.
- 2:12 PM Changeset in webkit [130549] by
-
- 5 edits2 adds in trunk
Deprecated flexboxes subtract scrollbar width/height twice
https://bugs.webkit.org/show_bug.cgi?id=98552
Reviewed by Tony Chang.
Source/WebCore:
This is a regression from http://trac.webkit.org/changeset/119507.
The problem is that contentHeight subtracts the scrollbar and
RenderDeprecatedFlexbox subtracts the scrollbar.
-Make it so that we only access override sizes if one has been set.
I think this makes the calling code more clear.
-If we don't have one set, grab the height/width - borderAndPadding.
-Add a FIXME to change this all back to being borderbox sizes.
There's something trick with making table padding/border work right for that
though (noted in the original patch).
Test: fast/flexbox/flexing-overflow-scroll-item.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::contentWidthForChild):
(WebCore):
(WebCore::contentHeightForChild):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
LayoutTests:
- fast/flexbox/flexing-overflow-scroll-item-expected.txt: Added.
- fast/flexbox/flexing-overflow-scroll-item.html: Added.
- 1:47 PM Changeset in webkit [130548] by
-
- 3 edits in trunk/Source/WebCore
Make tables which don't use col/row span much faster to layout
https://bugs.webkit.org/show_bug.cgi?id=98221
Reviewed by Julien Chaffraix.
My sense is that most tables on webpages do not use colspan/rowspan
so I stole another bit from RenderTableCell::m_column to avoid
having to re-parse the colSpan/rowSpan attributes for every cell
when doing table layout.
This made these symbols disappear from biggrid.html/redraw.html (dglazkov's spreadsheets benchmarks)
as well as moved our robohornet/resizecol.html number from an average of 3221ms to 2608ms (~20%!).
I removed m_hasHTMLTableCellElement (from http://trac.webkit.org/changeset/97691)
since it was attempting to do the same sort of optimization.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::layout):
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
(RenderTableCell):
- 1:45 PM Changeset in webkit [130547] by
-
- 6 edits1 add in trunk/Source
Source/WebCore: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173
Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
Reviewed by Ryosuke Niwa.
Adds handling for GestureLongPress to EventHandler::handleGestureEvent, with a new
handleGestureLongPress method. On Android, this method selects the closest word
if the gesture event was over non-link text.
This is tested via a new chromium test WebViewTest.LongPressSelection.
- page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestWordFromHitTestResult):
(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):
- page/EventHandler.h:
(EventHandler):
Source/WebKit/chromium: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173
Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
Reviewed by Ryosuke Niwa.
This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent.
The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour
required for Android. This means that a long press gesture performed on word (that is not part of a link)
selects the word, without generating a context menu event.
A new test, WebViewTest.LongPressSelection has been added to test this.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebViewImpl):
- tests/WebViewTest.cpp:
- tests/data/longpress_selection.html: Added.
- 1:33 PM Changeset in webkit [130546] by
-
- 5 edits22 deletes in trunk/LayoutTests
GTK+ and Qt rebaselines after r130532.
- platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
- platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Removed.
- platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Removed.
- platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Removed.
- platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
- platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Removed.
- platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
- platform/chromium/svg/custom/delete-text-crash-expected.txt: Removed.
- platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
- platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
- platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
- 1:30 PM Changeset in webkit [130545] by
-
- 6 edits1 add in trunk/Source/WebKit/chromium
[chromium] Support zooming focused node for mobile devices
https://bugs.webkit.org/show_bug.cgi?id=97958
Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-10-05
Reviewed by Adam Barth.
This unforks the Android version of scrollFocusedNodeIntoRect().A new setting
autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all
platforms with ENABLE(GESTURE_EVENTS) want this.
Test: WebFrameTest.DivScrollIntoEditableTest
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
- tests/WebFrameTest.cpp:
- tests/data/get_scale_for_zoom_into_editable_test.html: Added.
- 1:25 PM Changeset in webkit [130544] by
-
- 10 edits11 adds in trunk/LayoutTests
Chromium and Mac rebaselines after r130532.
- platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Added.
- platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Added.
- platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Added.
- platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt:
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt:
- platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Added.
- platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Added.
- platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Added.
- platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
- platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt:
- platform/chromium/svg/custom/delete-text-crash-expected.txt: Added.
- platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Added.
- svg/custom/delete-text-crash-expected.txt:
- svg/custom/delete-text-innerText-crash-expected.txt:
- 12:55 PM Changeset in webkit [130543] by
-
- 5 edits in trunk
[Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
https://bugs.webkit.org/show_bug.cgi?id=91009
Reviewed by Martin Robinson.
Tools:
Include libxml2 into the jhbuild module. Version 2.8.0 introduces
a more correct (but not completely correct) behavior in the
fast/xsl/xslt-missing-namespace-in-xslt.html test.
- gtk/jhbuild.modules:
LayoutTests:
Update the test's baselines. The output now properly shows the error.
- platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
- platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- 12:46 PM Changeset in webkit [130542] by
-
- 2 edits in trunk/LayoutTests
Fix lint error in TestExpectations from previous change.
Unreviewed.
- platform/chromium/TestExpectations:
- 12:19 PM Changeset in webkit [130541] by
-
- 3 edits1 add15 deletes in trunk
<marquee> element forces itself to be at least 1em high, regardless of 'height' declaration
https://bugs.webkit.org/show_bug.cgi?id=18098
Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
Reviewed by Eric Seidel.
This restriction originally existed to match IE, but IE changed some time ago to be normal instead.
We're the last browser, afaict, to still enforce this de-facto restriction.
This patch makes <marquee> instead act like a normal element.
Tests: fast/css/MarqueeLayoutTest.html (rewritten from the older, bad version)
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::updateMarqueeStyle):
- 12:18 PM Changeset in webkit [130540] by
-
- 2 edits6 adds in trunk/LayoutTests
[chromium] tests failing after r130443.
https://bugs.webkit.org/show_bug.cgi?id=98545
Unreviewed, expectations change.
[chromium] fast/text/international/text-spliced-font.html and
fast/writing-mode/Kusa-Makura-background-canvas.html are failing on
the Mac after r130443 and we're not quite sure why ...
- platform/chromium-linux/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
- platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
- platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
- platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
- platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
- platform/chromium/TestExpectations:
- 12:05 PM Changeset in webkit [130539] by
-
- 6 edits2 copies4 adds in trunk
[chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel.
https://bugs.webkit.org/show_bug.cgi?id=97355
Reviewed by Adrienne Walker.
This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if
interrupted by GestureTap, and animate away if interrupted by GestureTapCancel.
Source/WebKit/chromium:
- src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded):
- src/LinkHighlight.h:
(LinkHighlight):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::enableTouchHighlight):
LayoutTests:
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: removed extra testRunner.display().
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.txt: Added.
- 12:01 PM Changeset in webkit [130538] by
-
- 6 edits in trunk
[BlackBerry] Implement TestRunner.setMockDeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=98542
Reviewed by Antonio Gomes.
PR 120681
Source/WebKit/blackberry:
Provide framework for mock device motion.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- WebKitSupport/DumpRenderTreeSupport.cpp:
(toDeviceOrientationClientMock):
(DumpRenderTreeSupport::setMockDeviceOrientation):
- WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):
Tools:
This fixes tests in fast/dom/DeviceOrientation.
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setMockDeviceOrientation):
- 11:50 AM Changeset in webkit [130537] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix regression in proxy auth
https://bugs.webkit.org/show_bug.cgi?id=98533
Patch by Joe Mason <jmason@rim.com> on 2012-10-05
Reviewed by Yong Li.
The proxy auth dialog gets the proxy address from
BlackBerry::Platform::Settings::proxyAddress, which returns
"host:port", but we try to parse it with a KURL, which expects
"scheme://host:port". Since this is an http proxy, add http:// to the
url to get it to parse.
PR 220567.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
- 11:41 AM Changeset in webkit [130536] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98527
Unreviewed gardening after r129479.
- platform/mac-wk2/TestExpectations:
- 11:35 AM Changeset in webkit [130535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing failure expectation for fast/text/vertical-rl-rtl-linebreak.html
since the test only needed platform-specific baselines (which were added
in r130524).
- platform/gtk/TestExpectations:
- 11:34 AM Changeset in webkit [130534] by
-
- 2 edits in trunk/Source/WebCore
No autorelease pool in place, causing buildup of autoreleased objects.
https://bugs.webkit.org/show_bug.cgi?id=98522
<rdar://problem/11647950>
Reviewed by Alexey Proskuryakov.
Wrap each timer callback in an AutodrainPool, ensuring an autorelease
pool is present during calls from C/C++ into ObjC.
- platform/cf/RunLoopTimerCF.cpp:
(WebCore::timerFired):
- 11:32 AM Changeset in webkit [130533] by
-
- 2 edits in trunk/LayoutTests
Have perf test assert worst order of magnitude
https://bugs.webkit.org/show_bug.cgi?id=98535
Reviewed by Tony Chang.
Really we only care if tests get order of magnitude slower.
Assert that tests are at least a certain magnitude.
Hopefully this will reduce flakiness some.
- resources/magnitude-perf.js:
(Magnitude._run):
- 11:26 AM Changeset in webkit [130532] by
-
- 8 edits2 adds in trunk
Deleting across multiple paragraphs can change the style of surrounding text
https://bugs.webkit.org/show_bug.cgi?id=97266
Reviewed by Levi Weintraub.
Source/WebCore:
Preserve editing styles from CSS rules in wrappingStyleForSerialization as well as inline styles
even when we're not annotating. We don't want to preserve all styles because it's against
the user expectation to keep borders, etc... when merging paragraphs. We also don't want to copy
styles from a mail blockquote because that's not a style the user has applied. See the comment
in EditingStyle::wrappingStyleForSerialization.
Test: editing/deleting/merge-paragraph-with-style-from-rule.html
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
LayoutTests:
Added a regression test and rebaselined tests.
- editing/deleting/delete-before-block-image-2-expected.txt:
- editing/deleting/merge-paragraph-from-p-with-style-expected.txt:
- editing/deleting/merge-paragraph-from-p-with-style.html: We changed the behavior. The editing style of p
is now preserved when merging paragraphs.
- editing/deleting/merge-paragraph-with-style-from-rule-expected.txt: Added.
- editing/deleting/merge-paragraph-with-style-from-rule.html: Added.
- platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
- 11:18 AM Changeset in webkit [130531] by
-
- 3 edits in trunk/Source/WebCore
Reversing a GlyphBuffer needlessly queries its size multiple times
https://bugs.webkit.org/show_bug.cgi?id=98530
Reviewed by Simon Fraser.
No new tests because there is no change in behavior.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Replaced the condition
(i < glyphBuffer.size() / 2) with the equivalent test (i < end).
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText): Ditto.
- 11:09 AM Changeset in webkit [130530] by
-
- 42 edits in trunk/Source/WebKit/chromium
[Chromium] Update some more #includes for Platform/ directory
https://bugs.webkit.org/show_bug.cgi?id=98534
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
- src/WebFormElement.cpp:
- src/WebFrameImpl.cpp:
- src/WebGeolocationClientMock.cpp:
- src/WebGeolocationError.cpp:
- src/WebGeolocationPermissionRequest.cpp:
- src/WebHistoryItem.cpp:
- src/WebHitTestResult.cpp:
- src/WebIDBTransactionImpl.h:
- src/WebIconLoadingCompletionImpl.h:
- src/WebImageDecoder.cpp:
- src/WebImageSkia.cpp:
- src/WebInputElement.cpp:
- src/WebKit.cpp:
- src/WebLabelElement.cpp:
- src/WebMediaStreamRegistry.cpp:
- src/WebNode.cpp:
- src/WebNotification.cpp:
- src/WebOptionElement.cpp:
- src/WebPageSerializer.cpp:
- src/WebPageSerializerImpl.cpp:
- src/WebPageSerializerImpl.h:
- src/WebPluginListBuilderImpl.cpp:
- src/WebPluginLoadObserver.h:
- src/WebPopupMenuImpl.cpp:
- src/WebPopupMenuImpl.h:
- src/WebRange.cpp:
- src/WebRegularExpression.cpp:
- src/WebScriptController.cpp:
- src/WebSecurityOrigin.cpp:
- src/WebSecurityPolicy.cpp:
- src/WebSelectElement.cpp:
- src/WebSerializedScriptValue.cpp:
- src/WebSessionDescriptionDescriptor.cpp:
- src/WebSettingsImpl.cpp:
- src/WebSocketImpl.cpp:
- src/WebSocketImpl.h:
- src/WebStorageEventDispatcherImpl.cpp:
- src/WebSurroundingText.cpp:
- src/WebURLLoadTiming.cpp:
- src/WorkerAsyncFileWriterChromium.cpp:
- src/WorkerFileSystemCallbacksBridge.cpp:
- 11:08 AM Changeset in webkit [130529] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed rebaseline after r130355.
r130447 forgot to update the Snow Leopard pixel baselines. The only differences are due to a different font used.
- platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- 11:03 AM Changeset in webkit [130528] by
-
- 2 edits in trunk/LayoutTests
Add expected result accidentally left out of http://trac.webkit.org/changeset/130337.
- perf/adding-radio-buttons-expected.txt:
- 10:57 AM Changeset in webkit [130527] by
-
- 1 edit1 delete in trunk/Source/WebKit/blackberry
[BlackBerry] Remove unnecessary html file.
https://bugs.webkit.org/show_bug.cgi?id=98531
Reviewed by Yong Li.
We now just use Source/WebCore/inspector/front-end/inspector.html
instead.
- WebCoreSupport/inspectorBB.html: Removed.
- 10:56 AM Changeset in webkit [130526] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/rendering/RenderLayer.cpp
Merge 130322 - [Sub-pixel layout] incorrect rendering when painting sub-layers as their own root
https://bugs.webkit.org/show_bug.cgi?id=97484
Reviewed by Eric Seidel.
When in compositing mode, layer painting can be triggered through the backing store. When this
happens, a non-top-level RenderLayer is called to paint as its own root. Normally, we attempt to preserve
the proper sub-pixel accumulation through layers to their children, but since we're not
starting with the top-level layer, we haven't properly accumulated one, and convertToLayerCoords,
another source of correctly getting the sub-pixel offset for a layer, also avoids crawling
past the listed root layer.
When painting a root layer, we're aligned to the surface we're painting to, so we round our
offset to avoid moving objects around.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/11031075
- 10:54 AM Changeset in webkit [130525] by
-
- 25 edits3 adds in trunk
[GTK] Add support for creating EGL contexts
https://bugs.webkit.org/show_bug.cgi?id=77921
Patch by José Dapena Paz <jdapena@igalia.com> on 2012-10-05
Reviewed by Martin Robinson.
This patch adds support for EGL, using OpenGL and OpenGL ES 2. Both
options are set up on compile time, with the configure options
--enable-egl and --enable-gles2.
The implementation only adds support for EGL on top of X11, to
isolate the changes to the minimum. More changes should come
later to enable EGL for other targets (as Wayland).
.:
- GNUmakefile.am:
- configure.ac: new configure options --enable-egl and --enable-gles2.
Source/WebCore:
No new tests required, as existing WebGL and AC tests should cover
the cases.
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
- platform/graphics/OpenGLESShims.h:
- platform/graphics/cairo/GLContext.cpp:
(WebCore):
(WebCore::GLContext::sharedX11Display):
(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::activeContextList):
(WebCore::GLContext::addActiveContext):
(WebCore::GLContext::removeActiveContext):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::createContextForWindow):
(WebCore::GLContext::createOffscreenContext):
- platform/graphics/cairo/GLContext.h:
(GLContext):
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/clutter/GraphicsContext3DClutter.cpp:
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
- platform/graphics/egl/GLContextEGL.cpp: Added.
(WebCore):
(WebCore::sharedEGLDisplay):
(WebCore::getEGLConfig):
(WebCore::GLContextEGL::createWindowContext):
(WebCore::GLContextEGL::createPbufferContext):
(WebCore::GLContextEGL::createPixmapContext):
(WebCore::GLContextEGL::createContext):
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::canRenderToDefaultFramebuffer):
(WebCore::GLContextEGL::defaultFrameBufferSize):
(WebCore::GLContextEGL::makeContextCurrent):
(WebCore::GLContextEGL::swapBuffers):
(WebCore::GLContextEGL::waitNative):
(WebCore::GLContextEGL::platformContext):
- platform/graphics/egl/GLContextEGL.h: Added.
(WebCore):
(GLContextEGL):
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::createWindowContext):
(WebCore::GLContextGLX::createPbufferContext):
(WebCore::GLContextGLX::createPixmapContext):
(WebCore::GLContextGLX::createContext):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::defaultFrameBufferSize):
(WebCore::GLContextGLX::makeContextCurrent):
(WebCore::GLContextGLX::swapBuffers):
(WebCore):
(WebCore::GLContextGLX::waitNative):
- platform/graphics/glx/GLContextGLX.h:
(GLContextGLX):
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::renderbufferStorage):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
- platform/graphics/texmap/TextureMapper.h:
- platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::resize):
- platform/gtk/RedirectedXCompositeWindow.h:
Source/WebKit2:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
- 10:53 AM Changeset in webkit [130524] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Adding platform-specific baselines after r130443 and r130489.
- platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
- platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
- platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
- platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
- 10:53 AM Changeset in webkit [130523] by
-
- 13 edits in trunk/Source
Add a setting to enable plugin snapshotting
https://bugs.webkit.org/show_bug.cgi?id=98319
<rdar://problem/12426480>
Reviewed by Brady Eidson.
Source/WebCore:
Add a new bit for this preference.
- page/Settings.cpp:
(WebCore::Settings::Settings): Preference is false by default.
- page/Settings.h: Added m_plugInSnapshottingEnabled bit.
(WebCore::Settings::setPlugInSnapshottingEnabled): Set the bit.
(WebCore::Settings::plugInSnapshottingEnabled): Return the bit.
Source/WebKit/mac:
Expose plugInSnapshottingEnabled preference to WebKit clients.
- WebView/WebPreferenceKeysPrivate.h: Add WebKitPlugInSnapshottingEnabled key.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Setting is turned off by default.
(-[WebPreferences plugInSnapshottingEnabled]):
(-[WebPreferences setPlugInSnapshottingEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Update settings based on preference.
Source/WebKit2:
Expose plugInSnapshottingEnabled preference to WebKit clients.
- Shared/WebPreferencesStore.h:
(WebKit):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPlugInSnapshottingEnabled):
(WKPreferencesGetPlugInSnapshottingEnabled):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update preference based on store.
- 10:39 AM Changeset in webkit [130522] by
-
- 4 edits in trunk
[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.
Tools:
Implement UIClient's focus callbacks for the main page in
WebKitTestRunner.
- WebKitTestRunner/TestController.cpp:
(WTR::focus):
(WTR::TestController::initialize):
LayoutTests:
Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.
- platform/efl-wk2/TestExpectations:
- 10:38 AM Changeset in webkit [130521] by
-
- 1 edit2 deletes in trunk/LayoutTests
Remove wrong expectations added in r130452.
- platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Removed.
- platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Removed.
- 10:35 AM Changeset in webkit [130520] by
-
- 15 edits2 adds in trunk
JSC should have a way to gather and log Heap memory use and pause times
https://bugs.webkit.org/show_bug.cgi?id=98431
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
In order to improve our infrastructure for benchmark-driven development, we should
have a centralized method of gathering and logging various statistics about the state
of the JS heap. This would allow us to create and to use other tools to analyze the
output of the VM after running various workloads.
The first two statistics that might be interesting is memory use by JSC and GC pause
times. We can control whether this recording happens through the use of the Options
class, allowing us to either use environment variables or command line flags.
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Heap.cpp:
(JSC::Heap::collect): If we finish a collection and are still over our set GC heap size,
we end the program immediately and report an error. Also added recording of pause times.
- heap/Heap.h:
(Heap):
(JSC::Heap::shouldCollect): When we set a specific GC heap size through Options, we
ignore all other heuristics on when we should collect and instead only ask if we're
greater than the amount specified in the Option value. This allows us to view time/memory
tradeoffs more clearly.
- heap/HeapStatistics.cpp: Added.
(JSC):
(JSC::HeapStatistics::initialize):
(JSC::HeapStatistics::recordGCPauseTime):
(JSC::HeapStatistics::logStatistics):
(JSC::HeapStatistics::exitWithFailure):
(JSC::HeapStatistics::reportSuccess):
(JSC::HeapStatistics::parseMemoryAmount):
(StorageStatistics):
(JSC::StorageStatistics::StorageStatistics):
(JSC::StorageStatistics::operator()):
(JSC::StorageStatistics::objectWithOutOfLineStorageCount):
(JSC::StorageStatistics::objectCount):
(JSC::StorageStatistics::storageSize):
(JSC::StorageStatistics::storageCapacity):
(JSC::HeapStatistics::showObjectStatistics): Moved the old showHeapStatistics (renamed to showObjectStatistics)
to try to start collecting our various memory statistics gathering/reporting mechanisms scattered throughout the
codebase into one place.
- heap/HeapStatistics.h: Added.
(JSC):
(HeapStatistics):
- jsc.cpp:
(main):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce): We need to initialize our data structures for recording
statistics if necessary.
- runtime/Options.cpp: Add new Options for the various types of statistics we'll be gathering.
(JSC::parse):
(JSC):
(JSC::Options::initialize): Initialize the various new options using environment variables.
(JSC::Options::dumpOption):
- runtime/Options.h:
(JSC):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(main): Added a check as to whether we should dump our JSC Heap statistics on exit.
- 9:51 AM Changeset in webkit [130519] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Plugins are completely broken with a custom device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=98518
Reviewed by Kenneth Rohde Christiansen.
Implement painting with scale factor in ShareableBitmap.
The backing store of the plugin are still overscaled in MiniBrowser
with this patch but this is only the effect of the fake device scale
factor defined in qml (1.5). We should probably remove it on desktop.
- Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):
- 9:37 AM Changeset in webkit [130518] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed inspector front-end closure compilaiton fixes.
- inspector/InjectedScriptCanvasModuleSource.js:
- inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.getInternalProperties):
- inspector/front-end/DockController.js:
- inspector/front-end/externs.js:
(InspectorFrontendHostAPI.prototype.requestSetDockSide):
- 9:30 AM Changeset in webkit [130517] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Fix mktemp() compilation warning in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98493
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.
Fix wrong mktemp usage causing a compilation warning
in MiniBrowser.
- MiniBrowser/efl/main.c:
(on_download_request):
- 9:28 AM Changeset in webkit [130516] by
-
- 8 edits in trunk/Source/WebCore
Replace uses of prefixed properties with unprefixed versions in the UA stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98453
Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
Reviewed by Ojan Vafai.
Switched 'border-radius' and 'box-shadow' to their unprefixed version in the UA stylesheets.
No new tests, because the unprefixed properties have the same behavior as the prefixed.
- css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
- css/html.css:
(keygen, select):
(select[size][multiple]):
(select[size="1"]):
(::-webkit-validation-bubble-message):
- css/themeBlackBerry.css:
(input, textarea):
- css/themeChromiumAndroid.css:
(select[size][multiple]):
- css/themeQtNoListboxes.css:
(select[size][multiple]):
- css/themeWin.css:
(select[size="1"]):
- css/view-source.css:
(.webkit-html-message-bubble):
- 9:16 AM Changeset in webkit [130515] by
-
- 2 edits in trunk/Tools
[WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
https://bugs.webkit.org/show_bug.cgi?id=98503
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.
Avoid the need for duplicating UIClient callbacks for main page
and other pages by passing the view as clientInfo
for those callbacks.
Previously, callbacks for the main page were passed the
TestController as clientInfo while the callbacks for other pages
were passed the PlatformWebView as clientInfo. This was error prone
and leads to useless code duplication.
- WebKitTestRunner/TestController.cpp:
(WTR::getWindowFrame):
(WTR::setWindowFrame):
(WTR::runBeforeUnloadConfirmPanel):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForNotificationPermissionRequest):
- 9:16 AM Changeset in webkit [130514] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 130313 - Crash when calling document.open during unload
https://bugs.webkit.org/show_bug.cgi?id=98287
Reviewed by Nate Chapin.
Source/WebCore:
Calling document.open results in us nulling out m_documentLoader. This
code doesn't properly handle that case and crashes.
Test: fast/parser/document-open-in-unload.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
LayoutTests:
Test that we don't crash when calling document.open during the unload event.
- fast/parser/document-open-in-unload-expected.txt: Added.
- fast/parser/document-open-in-unload.html: Added.
TBR=abarth@webkit.org
Review URL: https://codereview.chromium.org/11026067
- 9:15 AM Changeset in webkit [130513] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Only inflate the height of rows in a popup menu when a touch device is detected.
https://bugs.webkit.org/show_bug.cgi?id=98515
Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-05
Reviewed by Adam Barth.
Enforces a minimum row height for popup menus when a touch device is
detected. In a previous patch (r127597), the sizing of popup was
consolidated for touch and non-touch. Based on user feedback, reverting
to the old behavior for non-touch and only adding padding for touch
devices seems like a much safer strategy. This patch is not a direct
revert of r127567 since the padding previously used for touch is a bit
excessive.
Covered by existing tests.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::getRowHeight):
- platform/chromium/PopupMenuChromium.cpp:
(WebCore):
- platform/chromium/PopupMenuChromium.h:
(WebCore::PopupMenuChromium::optionRowHeightForTouch):
(WebCore::PopupMenuChromium::setOptionRowHeightForTouch):
(PopupMenuChromium):
- 9:13 AM Changeset in webkit [130512] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unskip fullscreen unit tests for EwkView
https://bugs.webkit.org/show_bug.cgi?id=98509
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.
Update 2 fullscreen unit tests for EwkView so that
they don't require a call to ecore_evas_fullscreen_set()
to succeed. ecore_evas_fullscreen_set() does not
seem to work in Xvfb and causes the tests to hang.
With this update, we can now run those tests again.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 9:00 AM Changeset in webkit [130511] by
-
- 6 edits2 adds in trunk
Web Inspector: [Styles] Unable to edit properties in broken stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98246
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Pop source data for invalid rules off the stack whenever we have consecutive CSSParser::markRuleHeaderStart() invocations.
Test: inspector/styles/parse-stylesheet-errors.html
- css/CSSParser.cpp:
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleBodyStart):
- css/CSSParser.h:
(CSSParser):
LayoutTests:
A small refactoring to share the CSS style data dumping code among tests.
- http/tests/inspector/elements-test.js:
(initialize_ElementTest):
- inspector/styles/parse-stylesheet-errors-expected.txt: Added.
- inspector/styles/parse-stylesheet-errors.html: Added.
- inspector/styles/styles-new-API.html:
- 8:55 AM Changeset in webkit [130510] by
-
- 2 edits in trunk/LayoutTests
[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98523
Unreviewed gardening after r130414.
- platform/mac/TestExpectations:
- 8:46 AM Changeset in webkit [130509] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitPrintOperation/print-errors gives runtime critical warnings
https://bugs.webkit.org/show_bug.cgi?id=98497
Reviewed by Martin Robinson.
The problem is that GTK+ tries to write in the IO channel that has
already been closed.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::print): Finish the surface when
printing fails because printing data is invalid.
- 8:31 AM Changeset in webkit [130508] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitWebResource/response fails
https://bugs.webkit.org/show_bug.cgi?id=98511
Reviewed by Martin Robinson.
Do not consider the favicon as a resource for the web resources
unit tests.
- UIProcess/API/gtk/tests/TestResources.cpp:
- 8:26 AM Changeset in webkit [130507] by
-
- 9 edits in trunk/Source/WebKit2
REGRESSION (r129989 - r130019): [WK2] TestResources test is failing
https://bugs.webkit.org/show_bug.cgi?id=98342
Reviewed by Martin Robinson.
Return 404 error in unit tests using a HTTP server for paths not
handled by the test. This way all tests should return now a 404
for /favicon.ico.
- UIProcess/API/gtk/tests/TestBackForwardList.cpp:
(serverCallback):
- UIProcess/API/gtk/tests/TestCookieManager.cpp:
(serverCallback):
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(serverCallback):
- UIProcess/API/gtk/tests/TestResources.cpp:
(serverCallback):
- UIProcess/API/gtk/tests/TestSSL.cpp:
(serverCallback):
- UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:
(serverCallback):
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(serverCallback):
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(serverCallback):
- 8:22 AM Changeset in webkit [130506] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][SOUP] Assertion hit in WebKit::DownloadManager::downloadFinished() when download fails
https://bugs.webkit.org/show_bug.cgi?id=97565
Reviewed by Gustavo Noronha Silva.
Make sure to notify the downlaod client that the response has been
received when the newly created download has already been added to
the DownloadManager downloads map.
- WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient): Initialize
m_handleResponseLaterID.
(WebKit::DownloadClient::~DownloadClient): Remove the source for
the delayed response notification if it hasn't been triggered.
(WebKit::DownloadClient::didReceiveData): If response hasn't been
handled yet, remove the source for the delayed response
notification and handle the resource before start writing the data
received to the output stream.
(WebKit::DownloadClient::handleResponse): Call
didReceiveResponse() with the delayed response.
(WebKit::DownloadClient::handleResponseLaterCallback): Call
handleResponse().
(WebKit::DownloadClient::handleResponseLater): Schedule an idle
callback to handle the response later, to make sure the download
has been added to the downloads map.
(WebKit::Download::startWithHandle): Call handleResponseLater()
with the given response to handle the response when the download
has been added to the downloads map.
- 8:21 AM Changeset in webkit [130505] by
-
- 8 edits1 add in trunk/LayoutTests
[Qt] Updates expected test results for the expanded coverage in testfonts
https://bugs.webkit.org/show_bug.cgi?id=98425
Unreviewed gardening after r130502.
- platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
- platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png:
- platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt:
- platform/qt/fast/images/icon-decoding-expected.png: Added.
- platform/qt/fast/images/icon-decoding-expected.txt:
- platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
- 7:42 AM Changeset in webkit [130504] by
-
- 8 edits3 adds in trunk
[chromium] Allow dragging into plugins.
https://bugs.webkit.org/show_bug.cgi?id=98277
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-05
Reviewed by Tony Chang.
Source/WebKit/chromium:
Allow plugins to receive drag events. This will make it possible to
perform drag-n-drop into browser plugins (and other plugins if desired).
- public/WebDragStatus.h: Added.
(WebKit):
- public/WebPlugin.h:
(WebKit):
(WebPlugin):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleMouseEvent):
(WebKit::WebPluginContainerImpl::handleDragEvent):
(WebKit):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
Tools:
Update the TestWebPlugin to receive drag events and print them out.
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin):
LayoutTests:
Add test to make sure that plugins receive the drag events correctly.
- platform/chromium/plugins/drag-events-expected.txt: Added.
- platform/chromium/plugins/drag-events.html: Added.
- 7:33 AM Changeset in webkit [130503] by
-
- 4 edits in trunk
[BlackBerry] Sync up CMake files
https://bugs.webkit.org/show_bug.cgi?id=98442
Reviewed by Gyuyoung Kim.
.:
Amongst others some internal paths changed.
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit:
Amongst others use InspectorOverlayBlackBerry.
- PlatformBlackBerry.cmake:
- 7:31 AM Changeset in webkit [130502] by
-
- 16 edits6 deletes in trunk/LayoutTests
[Qt] Updates expected test results for the expanded coverage in testfonts
https://bugs.webkit.org/show_bug.cgi?id=98425
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-10-05
Reviewed by Csaba Osztrogonác.
The Qt testfonts repository was expanded with the croscore set of
fonts, which provides a great number of new glyphs (e.g. hebrew
characters).
See the comments in the testfonts commit for detailed information:
https://gitorious.org/qtwebkit/testfonts/commit/f11a54548121ee9fb0688dc6f32acdbfec5d2d2f/diffs
- platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
- platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Removed.
- platform/qt-5.0/fast/forms/search-rtl-expected.png: Removed.
- platform/qt-5.0/fast/forms/search-rtl-expected.txt: Removed.
- platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
- platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/qt/fast/borders/bidi-012-expected.txt:
- platform/qt/fast/forms/listbox-bidi-align-expected.png:
- platform/qt/fast/forms/listbox-bidi-align-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.png:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
- platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
- platform/qt/fast/text/large-text-composed-char-expected.png:
- platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.png:
- platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt:
- 7:29 AM Changeset in webkit [130501] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Find a proper fix for the WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling hack
https://bugs.webkit.org/show_bug.cgi?id=98517
PR #137382
Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
We've generalized composited in-region scrolling, originally only applicable
to block elements, to inner frames (see PR #197093). Past that, we no longer
need to force repaints of offscreen areas when we finish scrolling, since translating
the Layer takes care of properly invalidating it. Thus, remove this method.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
- Api/WebPage_p.h:
(WebPagePrivate):
- 7:19 AM Changeset in webkit [130500] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update default input support style for single line inputs.
https://bugs.webkit.org/show_bug.cgi?id=98510
Reviewed by Antonio Gomes.
PR 219588.
Update style calculations to eliminate automatic changes
by default on single line input fields.
Reviewed Internally by Gen Mak.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::inputStyle):
- 6:59 AM Changeset in webkit [130499] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed Qt gardening.
The ICO decoder shouldn't be broken since it is the WebKit decoder.
Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-10-05
- platform/qt/TestExpectations:
- 6:42 AM Changeset in webkit [130498] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update an expected file for newer Qt5.
- platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
- platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
- 5:47 AM Changeset in webkit [130497] by
-
- 2 edits in trunk/Source/WebCore
Add ARM-NEON support to VectorMath in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=98131
Reviewed by Zoltan Herczeg.
Speed up vector operations in WebAudio with NEON intrinsics.
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsma):
(WebCore::VectorMath::vsmul):
(WebCore::VectorMath::vadd):
(WebCore::VectorMath::vmul):
(WebCore::VectorMath::zvmul):
(WebCore::VectorMath::vsvesq):
(WebCore::VectorMath::vmaxmgv):
- 5:36 AM Changeset in webkit [130496] by
-
- 6 edits4 moves4 deletes in trunk/Source
Unreviewed, rolling out r130495.
http://trac.webkit.org/changeset/130495
https://bugs.webkit.org/show_bug.cgi?id=98268
Source/WebCore:
Made WK2 tests crash.
- Target.pri:
- platform/qt/QStyleFacade.cpp: Removed.
- platform/qt/QStyleFacade.h: Removed.
Source/WebKit:
Made WK2 tests crash....
- WebKit1.pro:
Source/WebKit/qt:
Made WK2 tests crash.
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- WebCoreSupport/QStyleFacadeImp.cpp: Removed.
- WebCoreSupport/QStyleFacadeImp.h: Removed.
- WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
- WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
- WebCoreSupport/ScrollbarThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):
- WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.h.
(WebCore):
(ScrollbarThemeQStyle):
- 4:43 AM Changeset in webkit [130495] by
-
- 6 edits4 moves4 adds in trunk/Source
[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=98268
Reviewed by Tor Arne Vestbø.
Source/WebCore:
Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.
QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.
RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.
The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.
The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.
RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.
- Target.pri:
- platform/qt/QStyleFacade.cpp: Added.
(WebCore):
(WebCore::QStyleFacade::styleForPage):
- platform/qt/QStyleFacade.h: Added.
(WebCore):
(QStyleFacade):
(WebCore::QStyleFacade::~QStyleFacade):
(WebCore::QStyleFacadeOption::QStyleFacadeOption):
(QStyleFacadeOption):
- platform/qt/RenderThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::setStyleFactoryFunction):
(WebCore::RenderThemeQStyle::styleFactory):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
- platform/qt/RenderThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(WebCore::RenderThemeQStyle::qStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::paintButton):
(WebCore::StylePainterQStyle::paintTextField):
(WebCore::StylePainterQStyle::paintComboBox):
(WebCore::StylePainterQStyle::paintComboBoxArrow):
(WebCore::StylePainterQStyle::paintSliderTrack):
(WebCore::StylePainterQStyle::paintSliderThumb):
(WebCore::StylePainterQStyle::paintInnerSpinButton):
(WebCore::StylePainterQStyle::paintProgressBar):
(WebCore::StylePainterQStyle::paintScrollCorner):
(WebCore::StylePainterQStyle::paintScrollBar):
- platform/qt/ScrollbarThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::initSliderStyleOption):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
- platform/qt/ScrollbarThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.h.
(WebCore):
(ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::qStyle):
Source/WebKit:
- WebKit1.pro: Add new files to the build.
Source/WebKit/qt:
Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.
QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.
RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.
The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.
The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.
RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- WebCoreSupport/QStyleFacadeImp.cpp: Added.
(WebKit):
(WebKit::convertToQStyleState):
(WebKit::convertToQStyleSubControl):
(WebKit::initGenericStyleOption):
(WebKit::initSpecificStyleOption):
(MappedStyleOption):
(WebKit::MappedStyleOption::MappedStyleOption):
(WebKit::convertPixelMetric):
(WebKit::convertToQStyleFacadeSubControl):
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
(WebKit::QStyleFacadeImp::buttonSubElementRect):
(WebKit::QStyleFacadeImp::findFrameLineWidth):
(WebKit::QStyleFacadeImp::simplePixelMetric):
(WebKit::QStyleFacadeImp::buttonMargin):
(WebKit::QStyleFacadeImp::sliderLength):
(WebKit::QStyleFacadeImp::sliderThickness):
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::sizeFromContents):
(WebKit::QStyleFacadeImp::paintButton):
(WebKit::QStyleFacadeImp::paintTextField):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
(WebKit::QStyleFacadeImp::paintSliderTrack):
(WebKit::QStyleFacadeImp::paintSliderThumb):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintProgressBar):
(WebKit::QStyleFacadeImp::scrollBarExtent):
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
(WebKit::QStyleFacadeImp::paintScrollCorner):
(WebKit::QStyleFacadeImp::hitTestScrollBar):
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
(WebKit::QStyleFacadeImp::paintScrollBar):
(WebKit::QStyleFacadeImp::widgetForPainter):
(WebKit::QStyleFacadeImp::style):
- WebCoreSupport/QStyleFacadeImp.h: Added.
(WebCore):
(WebKit):
(QStyleFacadeImp):
(WebKit::QStyleFacadeImp::create):
(WebKit::QStyleFacadeImp::isValid):
- 4:33 AM Changeset in webkit [130494] by
-
- 16 edits3 moves in trunk
[EFL][WK2] Remove "web" word from ewk_web_error APIs
https://bugs.webkit.org/show_bug.cgi?id=97886
Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.
Remove "web" word from ewk_web_error APIs.
"web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.
Source/WebKit2:
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_context_download_client.cpp:
(didFail):
- UIProcess/API/efl/ewk_cookie_manager.cpp:
(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):
- UIProcess/API/efl/ewk_cookie_manager.h:
- UIProcess/API/efl/ewk_download_job_private.h:
- UIProcess/API/efl/ewk_error.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp.
(_Ewk_Error):
(_Ewk_Error::_Ewk_Error):
(_Ewk_Error::~_Ewk_Error):
(ewk_error_free):
(ewk_error_type_get):
(ewk_error_url_get):
(ewk_error_code_get):
(ewk_error_description_get):
(ewk_error_cancellation_get):
(ewk_error_new):
- UIProcess/API/efl/ewk_error.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error.h.
- UIProcess/API/efl/ewk_error_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error_private.h.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_resource_load_failed):
(ewk_view_download_job_failed):
(ewk_view_load_error):
(ewk_view_load_provisional_failed):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didFailLoadWithErrorForFrame):
(didFailProvisionalLoadWithErrorForFrame):
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_view_resource_load_client.cpp:
(didFailLoadForResource):
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):
- UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(on_download_failed):
Tools:
- MiniBrowser/efl/main.c:
(on_error):
- 4:30 AM Changeset in webkit [130493] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][GTK] WebPageAccessibilityObject leaking
https://bugs.webkit.org/show_bug.cgi?id=98502
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Carlos Garcia Campos.
Use GRefPtr on the accessibility object to fix the leak.
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):
- 3:59 AM Changeset in webkit [130492] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Add API to count the matching text
https://bugs.webkit.org/show_bug.cgi?id=97873
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.
Add an API, ewk_view_text_matches_count(), to count the matched text in the document.
This API does not highlight the matched text in the document unlike ewk_view_text_find().
ewk_view_text_find() finds the matching text and but also update the UI view,
but some applications may not want to affect the view, and just want to know the count.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_text_matches_count):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 3:23 AM Changeset in webkit [130491] by
-
- 4 edits in trunk/Source/WTF
[GTK] Add support for GBytes in GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98489
Patch by Simon Pena <Simon Pena> on 2012-10-05
Reviewed by Carlos Garcia Campos.
Adding support for GBytes in GRefPtr makes it easier
for them to be used when adding GResources support,
and is more consistent with the rest of the port.
This calls g_bytes_ref and g_bytes_unref in the implementation
of the refPtr and derefPtr template functions, in case the GLib
version is met. Otherwise, it does nothing.
- wtf/gobject/GRefPtr.cpp: Implement templates for ref and deref.
(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
(WTF):
- wtf/gobject/GTypedefs.h: Define the GBytes datatype.
- 2:19 AM Changeset in webkit [130490] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK][EFL] standard_output returned by g_spawn_sync must be freed
https://bugs.webkit.org/show_bug.cgi?id=98384
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Gyuyoung Kim.
Free the standard_output returned by g_spawn_sync() to avoid
a memory leak.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 2:09 AM Changeset in webkit [130489] by
-
- 6 edits5 adds in trunk
Incomplete repaint of boxes with inset box-shadow and padding when resized
https://bugs.webkit.org/show_bug.cgi?id=59863
Patch by Andrei Bucur <abucur@adobe.com> on 2012-10-05
Reviewed by Simon Fraser.
Source/WebCore:
The patch extends the repaint rectangle to include the inset shadow extent for renderers that resize and need to be repainted. The rectangle computations are also better fragmented and easier to read.
New Test: fast/repaint/box-shadow-inset-repaint.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore):
- rendering/style/RenderStyle.h:
LayoutTests:
The patch adds a new pixel test and expected PNG results for mac and chromium-mac. The test fails on Chromium Linux EWS (and maybe others)
so I've added a rule in the TestExpectations file.
- platform/chromium/TestExpectations:
- fast/repaint/box-shadow-inset-repaint.html: Added.
- platform/chromium-mac/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
- platform/mac/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
- platform/mac/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
- 2:00 AM Changeset in webkit [130488] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=98491
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-05
Reviewed by Jocelyn Turcotte.
This code was added long time ago for a Symbian related project and is
not needed anymore.
- Api/qwebframe.cpp:
- 1:49 AM Changeset in webkit [130487] by
-
- 10 edits1 delete in trunk/LayoutTests
Unreviewed GTK gardening.
Updating platform-specific baselines after r130411.
Removing platform-specific baselines for CSS compositing tests
and skipping these tests entirely as the feature is not yet enabled
on the GTK port.
- platform/gtk/TestExpectations:
- platform/gtk/css3/compositing: Removed.
- platform/gtk/css3/compositing/blend-mode-property-expected.txt: Removed.
- platform/gtk/css3/compositing/blend-mode-property-parsing-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/gtk/editing/execCommand/paste-1-expected.txt:
- platform/gtk/editing/pasteboard/8145-3-expected.txt:
- platform/gtk/editing/pasteboard/paste-line-endings-007-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
- platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
- platform/gtk/editing/pasteboard/unrendered-br-expected.txt:
- 1:33 AM Changeset in webkit [130486] by
-
- 3 edits1 move1 add in trunk
[Qt] Enable CSS compositing by default
https://bugs.webkit.org/show_bug.cgi?id=98490
Reviewed by Simon Hausmann.
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- platform/qt/css3/compositing/should-have-compositing-layer-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/css3/compositing/should-have-compositing-layer-expected.txt.
- 1:17 AM Changeset in webkit [130485] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=98481
r130477 affects month-multiple-fields tests too.
- platform/chromium/TestExpectations:
- 1:15 AM Changeset in webkit [130484] by
-
- 3 edits in branches/chromium/1229/Source/WebCore/inspector/front-end
Merge 124886 - Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359
Reviewed by Yury Semikhatsky.
Removed network tracking enabling/disabling machinery.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
TBR=vsevik@chromium.org
BUG=153748
Review URL: https://codereview.chromium.org/11068016
- 1:12 AM Changeset in webkit [130483] by
-
- 4 edits in trunk
Unreviewed, rolling out r130466.
http://trac.webkit.org/changeset/130466
https://bugs.webkit.org/show_bug.cgi?id=98495
It made 12 tests crash on Qt-WK2 (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::focus):
(WTR::TestController::initialize):
LayoutTests:
- platform/efl-wk2/TestExpectations:
- 1:11 AM Changeset in webkit [130482] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/inspector.css
Merge 125255 - Web Inspector: Search matches count view is flaky.
https://bugs.webkit.org/show_bug.cgi?id=93451
Patch by Sam D <dsam2912@gmail.com> on 2012-08-10
Reviewed by Pavel Feldman.
Modified css properties for aligning search panel.
No new tests.UI change.
- inspector/front-end/inspector.css:
(.search-results-matches):
TBR=commit-queue@webkit.org
BUG=153753
Review URL: https://codereview.chromium.org/11029044
- 1:09 AM Changeset in webkit [130481] by
-
- 4 edits in trunk/Source/WTF
Unreviewed, rolling out r130478.
http://trac.webkit.org/changeset/130478
https://bugs.webkit.org/show_bug.cgi?id=98494
It broke the Qt build (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05
- wtf/gobject/GRefPtr.cpp:
- wtf/gobject/GRefPtr.h:
(WTF):
- wtf/gobject/GTypedefs.h:
- 12:58 AM Changeset in webkit [130480] by
-
- 2 edits14 adds in trunk/LayoutTests
Add appearance tests for input[type=date] with multiple fields
https://bugs.webkit.org/show_bug.cgi?id=98479
Reviewed by Kentaro Hara.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html: Added.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium/TestExpectations:
- 12:46 AM Changeset in webkit [130479] by
-
- 7 edits3 moves in trunk/Source/WebKit2
[EFL][WK2] Remove "web" word from ewk_resource APIs
https://bugs.webkit.org/show_bug.cgi?id=97887
Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.
Remove "web" word from ewk_web_resource APIs.
"web" word was redundant because "ewk" means "EFL WebKit" and enough to understand the meaning with ewk_resource_XXX.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_resource.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource.cpp.
(_Ewk_Resource):
(_Ewk_Resource::_Ewk_Resource):
(_Ewk_Resource::~_Ewk_Resource):
(ewk_resource_ref):
(ewk_resource_unref):
(ewk_resource_url_get):
(ewk_resource_new):
(ewk_resource_main_resource_get):
- UIProcess/API/efl/ewk_resource.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource.h.
- UIProcess/API/efl/ewk_resource_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource_private.h.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_priv_loading_resources_clear):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_view_resource_load_client.cpp:
(didInitiateLoadForResource):
- 12:40 AM Changeset in webkit [130478] by
-
- 4 edits in trunk/Source/WTF
[GTK] Add support for GBytes in GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98489
Patch by Simon Pena <Simon Pena> on 2012-10-05
Reviewed by Carlos Garcia Campos.
Adding support for GBytes in GRefPtr makes it easier
for them to be used when adding GResources support,
and is more consistent with the rest of the port.
This calls g_bytes_ref and g_bytes_unref in the implementation
of the refPtr and derefPtr template functions.
- wtf/gobject/GRefPtr.cpp: Implement templates for ref and deref.
(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
(WTF):
- wtf/gobject/GTypedefs.h: Define the GBytes datatype.
- 12:35 AM Changeset in webkit [130477] by
-
- 11 edits in trunk
Fix sub-field width to the maximum width of a placeholder and the maximum value
https://bugs.webkit.org/show_bug.cgi?id=98481
Reviewed by Hajime Morita.
Source/WebCore:
We can't assume a placeholder text is shorter than the width of
digits. The placeholder string for the year field of
input[type=week] is "----", but input[type=date] will have a
localized string for it.
We should set the 'width' CSS property to the maximum of the
placeholder width and the maximum value width in order to prevent
the field width from growing/narrowing.
Before this patch, we secured four digits space for a year field,
and allowed the field to grow its width when a larger year is
set. After this patch, we don't allow it to grow because the
'width' property is set to the maximum width.
Update week-multiple-fields-appearance-basic.html, and the
following tests are affected.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
Enable customStyleForRenderer.
(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Added. The code is similar to DateTimeSymbolicFieldElement::customStyleForRenderer().
(WebCore::DateTimeNumericFieldElement::formatValue):
Made a function with the code in value(). This is used in
customStyleForRenderer() and value().
(WebCore::DateTimeNumericFieldElement::value): Use formatValue().
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Declare new functions.
LayoutTests:
Update a test and test expectations.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt:
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium/TestExpectations:
- 12:27 AM Changeset in webkit [130476] by
-
- 5 edits in trunk/Source/WebCore
Improve spelling and performance of Localizer.cpp
https://bugs.webkit.org/show_bug.cgi?id=98485
Reviewed by Kentaro Hara.
Some improvements pointed in webkit.org/b/98229#c5.
No new tests because of no behavior change.
- platform/text/Localizer.h:
(Localizer):
- Rename dateTimeFormatWithSecond to dateTimeFormatWithSeconds
- Rename dateTimeFormatWithoutSecond to dateTimeFormatWithoutSeconds
- Add data members: m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.
- platform/text/Localizer.cpp:
(WebCore::Localizer::timeFormat): Check isNull instead of isEmpty
(WebCore::Localizer::shortTimeFormat): Ditto.
(WebCore::Localizer::dateTimeFormatWithSeconds):
- Renamed.
- Cache the concatenation result to a data member.
(WebCore::Localizer::dateTimeFormatWithoutSeconds): Ditto.
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::setupLayoutParameters): Follow the renaming.
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.
- 12:21 AM Changeset in webkit [130475] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2][WTR] Unskip parser-tests-110.html test case.
https://bugs.webkit.org/show_bug.cgi?id=98484
Unreviewed EFL gardening.
fast/encoding/parser-tests-110.html test case has been passed consistently.
Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-05
- platform/efl-wk2/TestExpectations:
- 12:19 AM Changeset in webkit [130474] by
-
- 3 edits in trunk/LayoutTests
[Qt] Gardening, skip some failing test.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-05
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 12:16 AM Changeset in webkit [130473] by
-
- 6 edits in trunk
[EFL] Fix window resizing / moving in WK1 and WKTR
https://bugs.webkit.org/show_bug.cgi?id=98486
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Fix ChromeClientEfl::windowRect() code to use
ecore_evas_request_geometry_get() instead of
evas_object_geometry_get() and therefore avoid
returning incorrect values when the engine has
not processed a call to ecore_evas_move_resize()
yet. This fixes a couple of layout tests.
The code was also refactored a bit for
consistency with the WebKit2 EFL implementation.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):
Tools:
Fix PlatformWebView::windowFrame() and
PlatformWebView::setWindowFrame() in EFL's WKTR so
that it resizes / moves the window, not the view.
The new code matches the implementation in EwkView's
UIClient.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
LayoutTests:
Unskip 2 window resizing / moving tests now that
the implementation for those has been fixed in
WebKit1 EFL.
- platform/efl-wk1/TestExpectations:
