Timeline
Oct 9, 2012:
- 11:59 PM Changeset in webkit [130864] by
-
- 1 edit in branches/chromium/1180/Source/WebCore/svg/SVGElementInstance.cpp
Merge 130855 - Recursively detach SVGElementInstances
https://bugs.webkit.org/show_bug.cgi?id=98851
Reviewed by Ryosuke Niwa and Abhishek Arya
Before this patch, SVGElementInstance child nodes were not being detached. This
patch makes detach() recursively detach SVGElementInstances.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::detach):
TBR=pdr@google.com
Review URL: https://codereview.chromium.org/11017051
- 11:59 PM Changeset in webkit [130863] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/svg/SVGElementInstance.cpp
Merge 130855 - Recursively detach SVGElementInstances
https://bugs.webkit.org/show_bug.cgi?id=98851
Reviewed by Ryosuke Niwa and Abhishek Arya
Before this patch, SVGElementInstance child nodes were not being detached. This
patch makes detach() recursively detach SVGElementInstances.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::detach):
TBR=pdr@google.com
Review URL: https://codereview.chromium.org/11086043
- 11:58 PM Changeset in webkit [130862] by
-
- 2 edits in trunk/LayoutTests
Flush load-and-stall.php output after sleeping
https://bugs.webkit.org/show_bug.cgi?id=98862
Reviewed by Kent Tamura.
Should not be a behavioral change: testing the bots with this change to see if
it helps with chromium linux/win test flakyness.
- http/tests/resources/load-and-stall.php:
- 11:56 PM Changeset in webkit [130861] by
-
- 2 edits in trunk/LayoutTests
Note test failures after http://trac.webkit.org/changeset/130851. We
plan to follow up in the morning in
https://bugs.webkit.org/show_bug.cgi?id=98867.
- platform/chromium/TestExpectations:
- 11:46 PM Changeset in webkit [130860] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/inspector.css
Revert 130482 - Merge 125255 - Web Inspector: Search matches count view is flaky.
https://bugs.webkit.org/show_bug.cgi?id=93451
Patch by Sam D <dsam2912@gmail.com> on 2012-08-10
Reviewed by Pavel Feldman.
Modified css properties for aligning search panel.
No new tests.UI change.
- inspector/front-end/inspector.css:
(.search-results-matches):
TBR=commit-queue@webkit.org
BUG=153753
Review URL: https://codereview.chromium.org/11029044
TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/11090043
- 11:46 PM Changeset in webkit [130859] by
-
- 3 edits in branches/chromium/1229/Source/WebCore/inspector/front-end
Revert 130484 - Merge 124886 - Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359
Reviewed by Yury Semikhatsky.
Removed network tracking enabling/disabling machinery.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
TBR=vsevik@chromium.org
BUG=153748
Review URL: https://codereview.chromium.org/11068016
TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/11086042
- 11:45 PM Changeset in webkit [130858] by
-
- 1 edit2 deletes in branches/chromium/1229
Revert 130719 - Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710
Reviewed by Kent Tamura.
Source/WebCore:
This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.
HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.
Test: fast/forms/select/select-typeahead-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.
LayoutTests:
This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.
- fast/forms/select/select-typeahead-crash-expected.txt: Added.
- fast/forms/select/select-typeahead-crash.html: Added.
TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11091018
TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11090042
- 11:38 PM Changeset in webkit [130857] by
-
- 2 edits in trunk/LayoutTests
Tests failure on Chromium Mac after r130821.
https://bugs.webkit.org/show_bug.cgi?id=98865
Unreviewed.
Marking tests as failing.
- platform/chromium/TestExpectations:
- 11:34 PM Changeset in webkit [130856] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/svg/SVGElementInstance.cpp
Merge 130855 - Recursively detach SVGElementInstances
Review URL: https://codereview.chromium.org/11093040
- 11:31 PM Changeset in webkit [130855] by
-
- 2 edits in trunk/Source/WebCore
Recursively detach SVGElementInstances
https://bugs.webkit.org/show_bug.cgi?id=98851
Reviewed by Ryosuke Niwa and Abhishek Arya
Before this patch, SVGElementInstance child nodes were not being detached. This
patch makes detach() recursively detach SVGElementInstances.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::detach):
- 11:23 PM Changeset in webkit [130854] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Fix harfbuzz-ng related code after r130231
https://bugs.webkit.org/show_bug.cgi?id=98858
Reviewed by Kent Tamura.
Replace first/second with key/value.
No new tests. No changes in behavior.
- platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:
(WebCore::harfbuzzGetGlyph):
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
- 11:10 PM Changeset in webkit [130853] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed, rolling out r130838.
http://trac.webkit.org/changeset/130838
https://bugs.webkit.org/show_bug.cgi?id=98860
The patch is causing X errors (=> crashes) on GTK 64-bit
Release builder (Requested by zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09
- webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation):
(webkit_web_view_size_allocate):
(webkitWebViewMap):
- 11:02 PM Changeset in webkit [130852] by
-
- 2 edits in trunk/LayoutTests
Initialize $written variable in load-and-stall.php script
https://bugs.webkit.org/show_bug.cgi?id=98854
Reviewed by Kent Tamura.
- http/tests/resources/load-and-stall.php:
- 11:00 PM WebKitGTK/1.10.x edited by
- (diff)
- 10:48 PM Changeset in webkit [130851] by
-
- 7 edits in trunk/Source/WebCore
Only measure text once instead of twice when performing line layout.
https://bugs.webkit.org/show_bug.cgi?id=98317
<rdar://problem/12080821>
Reviewed by Dan Bernstein.
Since we are measuring each word to find out where the line break should occur,
we should cache that information to avoid measuring the run again when
creating the line box. The bulk of the change is in nextLineBreak, where
the measurements are collected and placed in a vector so that they can
be consumed in setLogicalWidthForTextRun where we used to measure the
text one more time.
Each entry in the vector is a WordMeasurement object that contains information
about the start and end offset in the run, the renderer, the measured width
and, possibly, a list of fallback fonts.
When we need to compute the width of the run to create the line box, we add
all the measurements for the given renderer in the run to get the total width.
This optiomization is currently disabled for platforms using HarfBuzz.
- platform/graphics/Font.cpp:
(WebCore::Font::width): Added fallback fonts parameter.
- platform/graphics/Font.h:
(Font): Added fallback fonts parameter to the width static member function.
This method is called when we compute the width using TextLayout.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::TextLayout::width): Added fallback fonts parameter.
(WebCore::Font::width):
(WebCore::ComplexTextController::advance):
- platform/graphics/mac/ComplexTextController.h:
(ComplexTextController): Added fallback fonts parameter to advance method.
- rendering/RenderBlock.h: Added WordMeasures parameter to few methods.
- rendering/RenderBlockLineLayout.cpp:
(WordMeasurement): Added new class to hold measurement information.
(WebCore::setLogicalWidthForTextRun): This is where we compute the run width using the
cached information.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added wordMeasures parameter.
(WebCore::RenderBlock::createLineBoxesFromBidiRuns): Added wordMeasures parameter.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added declaration of the WordMeasures
vector and its use.
(WebCore::textWidth): Added fallbackFonts parameter, since now we only measure once.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): This method has been modified to collect
the measurements of the individual words and add them to the vector.
- 10:28 PM Changeset in webkit [130850] by
-
- 3 edits in trunk/Source/WebCore
GlyphPageTreeNode should use HashMap<OwnPtr>.
<http://webkit.org/b/98845>
Reviewed by Dan Bernstein.
- Replace manual memory management by OwnPtrs.
- Added a GlyphPageTreeNodeMap typedef to make call sites look a bit nicer.
Changed some hashmap get()/remove() pairs to use the more efficient take() instead.
- Made the constructor private, it has no external clients.
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::getRoot):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::getChild):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):
- platform/graphics/GlyphPageTreeNode.h:
(GlyphPageTreeNode):
(WebCore::GlyphPageTreeNode::GlyphPageTreeNode):
- 10:25 PM Changeset in webkit [130849] by
-
- 1 edit1 move1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/fast/history/history-back-initial-vs-final-url-expected.txt: Renamed from LayoutTests/platform/qt/fast/history/history-back-initial-vs-final-url-expected.txt.
- 10:20 PM Changeset in webkit [130848] by
-
- 10 edits in trunk
Sub-fields in input[type=time] should not be focusable if the input is disabled or read-only
https://bugs.webkit.org/show_bug.cgi?id=98850
Reviewed by Kentaro Hara.
Source/WebCore:
Covered by additional test cases of
time-multiple-fields/time-multiple-fields-keyboard-events.html and
time-multiple-fields/time-multiple-fields-mouse-events.html.
- html/shadow/DateTimeFieldElement.h:
(FieldOwner): Add isFieldOwnerDisabledOrReadOnly.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::isFocusable):
Check isFieldOwnerDisabledOrReadOnly, and calls HTMLElement::isFocusable()
just in case.
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::isFieldOwnerDisabledOrReadOnly): Added.
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Declare isFieldOwnerDisabledOrReadOnly.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:
- 10:07 PM Changeset in webkit [130847] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName
https://bugs.webkit.org/show_bug.cgi?id=98714
Reviewed by Abhishek Arya.
- public/WebElement.h:
(WebElement):
- Add a comment to tagName().
- Add a comment to hasTagName().
- Declare hasHTMLTagName(), which is useful to check HTML tags.
- src/WebElement.cpp:
(WebKit::WebElement::hasHTMLTagName): Added.
- 9:56 PM Changeset in webkit [130846] by
-
- 2 edits in trunk/Source/WebCore
[chromium] revert fling deacceleration parameter change
https://bugs.webkit.org/show_bug.cgi?id=98820
Reviewed by Adrienne Walker.
After an extended discussion, it has been decided that a previous
adjustment to fling deacceleration parameters should be reverted.
Tested by existing unit tests.
- platform/TouchFlingPlatformGestureCurve.cpp:
(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):
- 9:55 PM Changeset in webkit [130845] by
-
- 4 edits in trunk/LayoutTests
[Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails
https://bugs.webkit.org/show_bug.cgi?id=88913
Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-09
Reviewed by Csaba Osztrogonác.
Blind fix to try to fix the test.
- http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html:
- http/tests/xmlhttprequest/resources/access-control-allow-lists.php:
- 9:50 PM Changeset in webkit [130844] by
-
- 11 edits in trunk/LayoutTests
[EFL] Update EFL baselines after r130840
https://bugs.webkit.org/show_bug.cgi?id=98846
Unreviewed EFL gardening.
Update baselines after the cairo update in r130840.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-09
- platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
- platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
- platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
- platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
- platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
- 9:49 PM Changeset in webkit [130843] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Change parameter and return type of loadUrlSync().
https://bugs.webkit.org/show_bug.cgi?id=97920
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-09
Reviewed by Gyuyoung Kim.
loadUrlSync() uses waitUntilLoadFinished() internally, and it has
a parameter and return value for timeout.
To set and check timeout, loadUrlSync() should have those.
A parameter for timeout interval is added to loadUrlSync() and it
returns the result of waitUntilLoadFinished() for checking timeout.
And I added codes to check the result of all the LoadUrlSync()
function calls with ASSERT_TRUE() macro.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_intents.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 9:48 PM Changeset in webkit [130842] by
-
- 2 edits in trunk/LayoutTests
[Qt] new test http/tests/cookies/single-quoted-value.html is failing
https://bugs.webkit.org/show_bug.cgi?id=86066
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Csaba Osztrogonác.
Unskipping test.
- platform/qt/TestExpectations:
- 8:26 PM Changeset in webkit [130841] by
-
- 2 edits in trunk/Tools
extract-localizable-strings script should be able to handle paths to files containing whitespaces.
https://bugs.webkit.org/show_bug.cgi?id=98844
Patch by Damian Kaleta <dkaleta@apple.com> on 2012-10-09
Reviewed by Dan Bernstein.
- Scripts/extract-localizable-strings: Added ability to handle whitespace.
- 7:15 PM Changeset in webkit [130840] by
-
- 55 edits in trunk
[Cairo] Bump Cairo to fix more canvas/philip tests
https://bugs.webkit.org/show_bug.cgi?id=97658
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-09
Reviewed by Martin Robinson.
Tools:
Bumping cairo to version 1.12.4 which fixes more canvas/philip tests.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
LayoutTests:
Update platform-specific baselines after the cairo update. Also,
unksip canvas/philip tests which are passing now.
- platform/efl/TestExpectations:
- platform/efl/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/efl/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/efl/fast/dynamic/window-scrollbars-test-expected.png:
- platform/efl/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png:
- platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/efl/svg/batik/text/smallFonts-expected.png:
- platform/efl/svg/batik/text/smallFonts-expected.txt:
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/efl/svg/batik/text/textOnPath-expected.png:
- platform/efl/svg/batik/text/textOnPath-expected.txt:
- platform/efl/svg/batik/text/textOnPath2-expected.png:
- platform/efl/svg/batik/text/textOnPath2-expected.txt:
- platform/efl/svg/batik/text/textOnPath3-expected.png:
- platform/efl/svg/batik/text/textOnPath3-expected.txt:
- platform/efl/svg/batik/text/textOnPathSpaces-expected.png:
- platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/efl/svg/batik/text/verticalTextOnPath-expected.png:
- platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
- platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
- platform/efl/transforms/2d/transform-fixed-container-expected.png:
- platform/gtk/TestExpectations:
- platform/gtk/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
- platform/gtk/svg/batik/text/smallFonts-expected.png:
- platform/gtk/svg/batik/text/smallFonts-expected.txt:
- platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
- platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/gtk/svg/batik/text/textOnPath-expected.png:
- platform/gtk/svg/batik/text/textOnPath-expected.txt:
- platform/gtk/svg/batik/text/textOnPath2-expected.png:
- platform/gtk/svg/batik/text/textOnPath2-expected.txt:
- platform/gtk/svg/batik/text/textOnPath3-expected.png:
- platform/gtk/svg/batik/text/textOnPath3-expected.txt:
- platform/gtk/svg/batik/text/textOnPathSpaces-expected.png:
- platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/gtk/svg/batik/text/verticalTextOnPath-expected.png:
- platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/gtk/svg/custom/js-update-path-changes-expected.png:
- platform/gtk/svg/custom/js-update-path-changes-expected.txt:
- platform/gtk/svg/custom/js-update-path-removal-expected.png:
- platform/gtk/svg/custom/js-update-path-removal-expected.txt:
- platform/gtk/svg/custom/path-textPath-simulation-expected.png:
- platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
- 7:14 PM Changeset in webkit [130839] by
-
- 21 edits2 adds in trunk/Source/JavaScriptCore
Typed arrays should not be 20x slower in the baseline JIT than in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=98605
Reviewed by Oliver Hunt and Gavin Barraclough.
This adds typed array get_by_val/put_by_val patching to the baseline JIT. It's
a big (~40%) win on benchmarks that have trouble staying in the DFG JIT. Even
if we fix those benchmarks, this functionality gives us the insurance that we
typically desire with all speculative optimizations: even if we bail to
baseline, we're still reasonably performant.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/MacroAssembler.cpp: Added.
(JSC):
- assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::patchableBranchPtr):
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::moveDoubleToInts):
(JSC::MacroAssemblerARMv7::moveIntsToDouble):
(JSC::MacroAssemblerARMv7::patchableBranchPtr):
- assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::moveDoubleToInts):
(JSC::MacroAssemblerX86::moveIntsToDouble):
- bytecode/ByValInfo.h:
(JSC::hasOptimizableIndexingForClassInfo):
(JSC):
(JSC::hasOptimizableIndexing):
(JSC::jitArrayModeForClassInfo):
(JSC::jitArrayModeForStructure):
(JSC::ByValInfo::ByValInfo):
(ByValInfo):
- dfg/DFGAssemblyHelpers.cpp:
(DFG):
- dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- jit/JIT.h:
(JIT):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSCell.h:
- runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::typedArrayDescriptor):
- runtime/TypedArrayDescriptor.h: Added.
(JSC):
(JSC::TypedArrayDescriptor::TypedArrayDescriptor):
(TypedArrayDescriptor):
- 7:11 PM Changeset in webkit [130838] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Plugins don't display
https://bugs.webkit.org/show_bug.cgi?id=98789
Patch by Daniel Drake <dsd@laptop.org> on 2012-10-09
Reviewed by Martin Robinson.
Fix a recent regression where plugin content was not being displayed.
Bringing webkit_web_view_size_allocate in line with the WebKit2
equivalent solves the issue.
- webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation): pass allocation request to children
even when the allocation size does not change.
(webkit_web_view_size_allocate): don't bail too early if the
allocation size does not change.
- 7:08 PM Changeset in webkit [130837] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/canvas-fillRect-gradient-shadow.html failing
https://bugs.webkit.org/show_bug.cgi?id=98760
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-09
Reviewed by Martin Robinson.
Adjust the test case to verify the pixel in the middle of the shadow,
instead of the outer edge, to make sure that the test will not fail
in case if there is any effect around the borders.
- fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js:
- 6:41 PM Changeset in webkit [130836] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Move timeout callback to the CallbackDataTimer class.
https://bugs.webkit.org/show_bug.cgi?id=97861
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-09
Reviewed by Gyuyoung Kim.
Timeout callbacks for waitUntil{LoadFinished,TitleChanged,URIChanged}
can be moved to the CallbackDataTimer class.
Moved the callback implementation to the CallbackDataTimer class.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::CallbackDataTimer::CallbackDataTimer):
(CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::timeOutCallback):
(EWK2UnitTest::CallbackDataExpectedValue::CallbackDataExpectedValue):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilURIChangedTo):
- 6:40 PM Changeset in webkit [130835] by
-
- 6 edits1 copy1 add in trunk
Should reject invalid dates constructed with multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98727
Reviewed by Hajime Morita.
Source/WebCore:
In input[type=date] with multiple fields UI, we allow users to set
day-of-month value to 1-31 regardless of the month value. So users can
construct an invalid date such as "2012-02-31". We should sanitize such
values.
This change affects platforms with ENABLE_INPUT_TYPE_DATE &&
ENABLE_INPUT_MULTIPLE_FIELDS_UI.
Test: fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html
- html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Make sanitizeValue protected to be called from
BaseMultipleFieldsDateAndTimeInputType.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged):
Apply sanitizeValue to a value constructed in UI.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):
Ditto.
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
- fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Updated the test. 275760-12 is not a valid month value.
- 6:23 PM Changeset in webkit [130834] by
-
- 2 edits in trunk/Source/WebCore
Check for null m_frame in NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=98830
Patch by Joe Mason <jmason@rim.com> on 2012-10-09
Reviewed by George Staikos.
PR 220025
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::storeCredentials):
- 6:21 PM Changeset in webkit [130833] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed, skipping http/tests/security/svg-image-leak.html
- platform/mac/TestExpectations:
- 6:18 PM Changeset in webkit [130832] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add tests to testapi for null OpaqueJSStrings
https://bugs.webkit.org/show_bug.cgi?id=98805
Reviewed by Geoffrey Garen.
Added tests that check that OpaqueJSString, which is wrapped via JSStringRef, properly returns
null strings and that a null string in a JSStringRef will return a NULL JSChar* and 0 length
via the JSStringGetCharactersPtr() and JSStringGetLength() APIs respectively. Added a check that
JSValueMakeFromJSONString() properly handles a null string as well.
- API/tests/testapi.c:
(main):
- 5:30 PM Changeset in webkit [130831] by
-
- 2 edits in trunk/Tools
Unreviewed Chromium Windows build fix after r130823.
- DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(roleToString): Re-added the 'default' label as some cases are not handled.
- 5:18 PM Changeset in webkit [130830] by
-
- 3 edits in trunk/LayoutTests
filesystem-url-in-iframe test is flaky
https://bugs.webkit.org/show_bug.cgi?id=95246
Reviewed by Eric Seidel.
This test was assuming that the navigation would complete before the
async JavaScript executed, which is true usually (but not always).
- http/tests/security/mixedContent/filesystem-url-in-iframe.html:
- platform/chromium/TestExpectations:
- 5:06 PM Changeset in webkit [130829] by
-
- 54 edits2 adds2 deletes in trunk
Update the CSS property used to support draggable regions.
https://bugs.webkit.org/show_bug.cgi?id=97156
Reviewed by Adam Barth.
Source/JavaScriptCore:
The CSS property to support draggable regions, guarded under
WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
confusion with DASHBOARD_SUPPORT feature.
- Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
Source/WebCore:
The CSS property to support draggable regions has been changed from
"-webkit-widget-region" to "-webkit-app-region" in the following syntax:
-webkit-app-region: drag|no-drag
The CSS parsing code for draggable regions is now different from the CSS
parsing code for dashboard regions since we have quite different syntax.
We still try to share as much rendering update code as possible for
these two features. To make the shared code easier to understand for
both features, the name "DashboardRegions" in the shared code is changed
to "AnnotatedRegions" to work for both dashboard regions and draggable
regions.
Note that we still using WIDGET_REGION as feature name in order not to
add more changes to this patch. It will be renamed to a more appropriate
name in next patch. WIDGET_REGION is now only turned on for the chromium
port.
Test: fast/css/draggable-region-parser.html
- Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
- WebCore.exp.in: Update the exported symbol due to renaming.
- css/CSSComputedStyleDeclaration.cpp: Update the CSS parsing.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: Update the CSS parsing.
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseDashboardRegions):
- css/CSSParserValues.cpp: Update the CSS parsing.
(WebCore::CSSParserValue::createCSSValue):
- css/CSSPrimitiveValue.cpp: Update the CSS parsing.
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
- css/CSSPrimitiveValue.h: Update the CSS parsing.
(CSSPrimitiveValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in: Rename the CSS property for draggable region.
- css/CSSValueKeywords.in: Add the keywords supported for the draggable region.
- css/DashboardRegion.h: Remove WIDGET_REGION guard.
(DashboardRegion):
- css/StyleResolver.cpp: Update the CSS parsing.
(WebCore::StyleResolver::collectMatchingRulesForList):
- dom/Document.cpp: Rename dashboardRegions to annotatedRegions.
(WebCore::Document::Document):
(WebCore::Document::annotatedRegions):
(WebCore::Document::setAnnotatedRegions):
(WebCore::Document::reportMemoryUsage):
- dom/Document.h: Rename dashboardRegions to annotatedRegions.
(WebCore):
(WebCore::Document::setAnnotatedRegionsDirty):
(WebCore::Document::annotatedRegionsDirty):
(WebCore::Document::hasAnnotatedRegions):
(WebCore::Document::setHasAnnotatedRegions):
(Document):
- page/Chrome.cpp: Rename dashboardRegions to annotatedRegions.
(WebCore::ChromeClient::annotatedRegionsChanged):
- page/ChromeClient.h: Rename dashboardRegions to annotatedRegions.
(ChromeClient):
- page/FrameView.cpp: Rename dashboardRegions to annotatedRegions.
(WebCore::FrameView::layout):
(WebCore::FrameView::updateAnnotatedRegions):
(WebCore::FrameView::paintContents):
- page/FrameView.h: Rename dashboardRegions to annotatedRegions.
(FrameView):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addAnnotatedRegions):
- rendering/RenderInline.h: Rename dashboardRegions to annotatedRegions.
(RenderInline):
- rendering/RenderLayer.cpp: Rename dashboardRegions to annotatedRegions.
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
- rendering/RenderListBox.cpp: Rename dashboardRegions to annotatedRegions.
(WebCore::RenderListBox::setHasVerticalScrollbar):
- rendering/RenderObject.cpp: Rename dashboardRegions to annotatedRegions.
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::addAnnotatedRegions):
(WebCore::RenderObject::collectAnnotatedRegions):
- rendering/RenderObject.h: Rename dashboardRegions to annotatedRegions.
(WebCore::AnnotatedRegionValue::operator==):
(WebCore::AnnotatedRegionValue::operator!=):
(AnnotatedRegionValue):
(RenderObject):
- rendering/style/RenderStyle.cpp: Update the CSS parsing.
(WebCore::RenderStyle::diff):
(WebCore):
- rendering/style/RenderStyle.h: Update the CSS parsing.
- rendering/style/RenderStyleConstants.h: Update the CSS parsing.
- rendering/style/StyleDashboardRegion.h: Update the CSS parsing.
- rendering/style/StyleRareNonInheritedData.cpp: Update the CSS parsing.
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h: Update the CSS parsing.
(WebCore):
(StyleRareNonInheritedData):
Source/WebKit/chromium:
Update the code to use the new name annotatedRegions to work for
both features.
- public/WebDraggableRegion.h: Rename dashboardRegions to annotatedRegions.
(WebDraggableRegion):
- src/ChromeClientImpl.cpp: Rename dashboardRegions to annotatedRegions.
(WebKit::ChromeClientImpl::annotatedRegionsChanged):
- src/ChromeClientImpl.h: Rename dashboardRegions to annotatedRegions.
(ChromeClientImpl):
- src/WebDocument.cpp: Rename dashboardRegions to annotatedRegions.
(WebKit::WebDocument::draggableRegions):
Source/WebKit/mac:
The CSS property to support draggable regions, guarded under
WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
confusion with DASHBOARD_SUPPORT feature.
Also update the code to use the new name annotatedRegions to work for
both features.
- Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
- WebCoreSupport/WebChromeClient.h: Rename dashboardRegions to annotatedRegions.
- WebCoreSupport/WebChromeClient.mm: Rename dashboardRegions to annotatedRegions.
(WebChromeClient::annotatedRegionsChanged):
- WebView/WebView.mm: Rename dashboardRegions to annotatedRegions.
(-[WebView _dashboardRegions]):
Source/WebKit2:
The CSS property to support draggable regions, guarded under
WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
confusion with DASHBOARD_SUPPORT feature.
Also update the code to use the new name annotatedRegions to work for
both features.
- Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Rename dashboardRegions to annotatedRegions.
(WebKit::WebChromeClient::annotatedRegionsChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h: Rename dashboardRegions to annotatedRegions.
(WebChromeClient):
LayoutTests:
Update the test and rename the files due to CSS property name and
syntax changes.
- fast/css/draggable-region-parser-expected.txt: Added.
- fast/css/draggable-region-parser.html: Added.
- fast/css/widget-region-parser-expected.txt: Removed.
- fast/css/widget-region-parser.html: Removed.
- platform/efl/TestExpectations: Rename the skipped test.
- platform/gtk/TestExpectations: Rename the skipped test.
- platform/mac/TestExpectations: Skip the renamed test since WIDGET_REGION is off.
- platform/qt/TestExpectations: Rename the skipped test.
- platform/win/TestExpectations: Rename the skipped test.
- platform/wincairo/TestExpectations: Rename the skipped test.
- 5:00 PM Changeset in webkit [130828] by
-
- 1 edit2 adds in trunk/Source/JavaScriptCore
Unreviewed, adding forgotten files.
- bytecode/ByValInfo.h: Added.
(JSC):
(JSC::isOptimizableIndexingType):
(JSC::jitArrayModeForIndexingType):
(JSC::ByValInfo::ByValInfo):
(ByValInfo):
(JSC::getByValInfoBytecodeIndex):
- runtime/IndexingType.cpp: Added.
(JSC):
(JSC::indexingTypeToString):
- 4:49 PM Changeset in webkit [130827] by
-
- 2 edits in trunk/LayoutTests
Fix coding style of layout test fast/dom/timer-throttling-hidden-page.html
https://bugs.webkit.org/show_bug.cgi?id=98828
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-09
Reviewed by Ojan Vafai.
Replaced tab characters with spaces, fixed position of braces and renamed
variables to be more explanatory.
- fast/dom/timer-throttling-hidden-page.html:
- 4:39 PM Changeset in webkit [130826] by
-
- 58 edits in trunk/Source
JSC should infer when indexed storage is contiguous, and optimize for it
https://bugs.webkit.org/show_bug.cgi?id=97288
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This introduces a new kind of indexed property storage called Contiguous,
which has the following properties:
- No header bits beyond IndexedHeader. This results in a 16 byte reduction in memory usage per array versus an ArrayStorage array. It also means that the total memory usage for an empty array is now just 3 * 8 on both 32-bit and 64-bit. Of that, only 8 bytes are array-specific; the rest is our standard object header overhead.
- No need for hole checks on store. This results in a ~4% speed-up on Kraken and a ~1% speed-up on V8v7.
- publicLength <= vectorLength. This means that doing new Array(blah) immediately allocates room for blah elements.
- No sparse map or index bias.
If you ever do things to an array that would require publicLength >
vectorLength, a sparse map, or index bias, then we switch to ArrayStorage
mode. This seems to never happen in any benchmark we track, and is unlikely
to happen very frequently on any website.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::JumpList::append):
- assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::patchableBranchTest32):
- bytecode/ByValInfo.h: Added.
(JSC):
(JSC::isOptimizableIndexingType):
(JSC::jitArrayModeForIndexingType):
(JSC::ByValInfo::ByValInfo):
(ByValInfo):
(JSC::getByValInfoBytecodeIndex):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::getByValInfo):
(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::numberOfByValInfos):
(JSC::CodeBlock::byValInfo):
- bytecode/SamplingTool.h:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
- dfg/DFGArrayMode.h:
(DFG):
(JSC::DFG::modeUsesButterfly):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::isInBoundsAccess):
(JSC::DFG::mayStoreToTail):
(JSC::DFG::mayStoreToHole):
(JSC::DFG::modeIsPolymorphic):
(JSC::DFG::polymorphicIncludesContiguous):
(JSC::DFG::polymorphicIncludesArrayStorage):
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):
(JSC::DFG::isEffectful):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(DFG):
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::putByValWillNeedExtraRegister):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileContiguousGetByVal):
(DFG):
(JSC::DFG::SpeculativeJIT::compileArrayStorageGetByVal):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compileArrayStoragePutByVal):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileContiguousGetByVal):
(DFG):
(JSC::DFG::SpeculativeJIT::compileArrayStorageGetByVal):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compileArrayStoragePutByVal):
(JSC::DFG::SpeculativeJIT::compile):
- interpreter/Interpreter.cpp:
(SamplingScope):
(JSC::SamplingScope::SamplingScope):
(JSC::SamplingScope::~SamplingScope):
(JSC):
(JSC::Interpreter::execute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::ByValCompilationInfo::ByValCompilationInfo):
(ByValCompilationInfo):
(JSC):
(JIT):
(JSC::JIT::compileGetByVal):
(JSC::JIT::compilePutByVal):
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSArray):
(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC):
(JSC::arrayProfileSaw):
(JSC::JIT::chooseArrayMode):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_argument_by_val):
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emitSlow_op_new_array):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitSlow_op_put_by_val):
- jit/JITStubs.cpp:
(JSC::getByVal):
(JSC):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::putByVal):
- jit/JITStubs.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ArrayConventions.h:
(JSC::isDenseEnoughForVector):
- runtime/ArrayPrototype.cpp:
(JSC):
(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
- runtime/Butterfly.h:
(Butterfly):
(JSC::Butterfly::fromPointer):
(JSC::Butterfly::pointer):
(JSC::Butterfly::publicLength):
(JSC::Butterfly::vectorLength):
(JSC::Butterfly::setPublicLength):
(JSC::Butterfly::setVectorLength):
(JSC::Butterfly::contiguous):
(JSC::Butterfly::fromContiguous):
- runtime/ButterflyInlineMethods.h:
(JSC::Butterfly::unshift):
(JSC::Butterfly::shift):
- runtime/IndexingHeaderInlineMethods.h:
(JSC::IndexingHeader::indexingPayloadSizeInBytes):
- runtime/IndexingType.cpp: Added.
(JSC):
(JSC::indexingTypeToString):
- runtime/IndexingType.h:
(JSC):
(JSC::hasContiguous):
- runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::setLength):
(JSC):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithArrayStorage):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::JSArray::sortNumericVector):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sort):
(JSC::JSArray::sortVector):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):
- runtime/JSArray.h:
(JSC::JSArray::shiftCountForShift):
(JSC::JSArray::shiftCountForSplice):
(JSArray):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCountForShift):
(JSC::JSArray::unshiftCountForSplice):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::isLengthWritable):
(JSC::createContiguousArrayButterfly):
(JSC):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::haveABadTime):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::arrayStructureWithArrayStorage):
(JSC::JSGlobalObject::addressOfArrayStructureWithArrayStorage):
(JSC::constructEmptyArray):
- runtime/JSObject.cpp:
(JSC::JSObject::visitButterfly):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createInitialContiguous):
(JSC):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::ensureIndexedStorageSlow):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::switchToSlowPutArrayStorage):
(JSC::JSObject::setPrototype):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthContiguousWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::countElementsInContiguous):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureContiguousLengthSlow):
(JSC::JSObject::getOwnPropertyDescriptor):
- runtime/JSObject.h:
(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::canSetIndexQuicklyForPutDirect):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSObject):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::ensureIndexedStorage):
(JSC::JSObject::ensureContiguousLength):
(JSC::JSObject::indexingData):
(JSC::JSObject::relevantLength):
- runtime/JSValue.cpp:
(JSC::JSValue::description):
- runtime/Options.cpp:
(JSC::Options::initialize):
- runtime/Structure.cpp:
(JSC::Structure::needsSlowPutIndexing):
(JSC):
(JSC::Structure::suggestedArrayStorageTransition):
- runtime/Structure.h:
(Structure):
- runtime/StructureTransitionTable.h:
(JSC::newIndexingType):
Source/WTF:
Moved out this helpful math utility to MathExtras, since we now use it in
multiple places.
- wtf/MathExtras.h:
(timesThreePlusOneDividedByTwo):
- 4:28 PM Changeset in webkit [130825] by
-
- 8 edits in trunk
[chromium] Add drop event for plugins.
https://bugs.webkit.org/show_bug.cgi?id=98827
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-09
Reviewed by Adam Barth.
Source/WebKit/chromium:
Add conversion for drop events.
- public/WebDragStatus.h:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleDragEvent):
Tools:
Update the test plugin to receive drop events.
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::handleDragStatusUpdate):
LayoutTests:
Updated the test to verify that a plugin can receive drop events. Note
that the plugin needs contentEditable set to true.
- platform/chromium/plugins/drag-events-expected.txt:
- platform/chromium/plugins/drag-events.html:
- 4:21 PM Changeset in webkit [130824] by
-
- 71 edits6 deletes in trunk
Unreviewed, rolling out r130811 and r130821.
http://trac.webkit.org/changeset/130811
http://trac.webkit.org/changeset/130821
https://bugs.webkit.org/show_bug.cgi?id=98831
Broke date-suggestion-picker-appearance-with-scroll-bar.html
(Requested by abarth|gardening on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09
Source/WebCore:
- WebCore.exp.in:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::computeRelativePosition):
- dom/Node.cpp:
(WebCore::Node::convertToPage):
(WebCore::Node::convertFromPage):
- editing/FrameSelection.cpp:
(WebCore::CaretBase::absoluteBoundsForLocalRect):
- editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::absoluteRect):
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::absoluteCaretBounds):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
- page/FrameView.cpp:
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::absoluteQuads):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::absoluteQuads):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::mapAbsoluteToLocalPoint):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::absolutePoint):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::mapLocalToContainer):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::absoluteToContents):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentsVisible):
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteFocusRingQuads):
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::localToAbsoluteQuad):
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
- rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::selectionBounds):
- rendering/RenderView.h:
(RenderView):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
- rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::mapLocalToContainer):
- rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::mapLocalToContainer):
(WebCore::RenderSVGModelObject::absoluteQuads):
- rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::mapLocalToContainer):
(WebCore::RenderSVGText::absoluteQuads):
- rendering/svg/RenderSVGText.h:
(RenderSVGText):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
Source/WebKit/chromium:
- src/FindInPageCoordinates.cpp:
(WebKit::toNormalizedRect):
- src/LinkHighlight.cpp:
(WebKit::convertTargetSpaceQuadToCompositedLayer):
- src/WebInputEventConversion.cpp:
(WebKit::convertLocationForRenderObject):
Source/WebKit/mac:
- WebView/WebFullScreenController.mm:
(screenRectOfContents):
- WebView/WebRenderNode.mm:
(copyRenderNode):
Source/WebKit2:
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::screenRectOfContents):
LayoutTests:
- fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: Removed.
- platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
- platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
- platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
- platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Removed.
- platform/mac-lion/TestExpectations:
- platform/mac-snowleopard/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt/TestExpectations:
- platform/win-wk2/TestExpectations:
- platform/win-xp/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 4:15 PM Changeset in webkit [130823] by
-
- 12 edits3 copies1 move2 deletes in trunk
AX: 5 accessibility tests just need minor tweaks to pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=98311
Reviewed by Chris Fleizach.
Tools:
Update roleToString on Chromium to include all missing roles,
which enables some layout tests to pass.
- DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(roleToString):
LayoutTests:
Modifies tests so that they log data that tends to vary between
platforms using debug(), rather than asserting a platform-specific
value. Gets rid of "forks" of tests in the gtk directory. Adds
expectations and unskips 5 tests on Chromium.
- accessibility/aria-list-and-listitem.html:
- accessibility/aria-option-role.html:
- accessibility/aria-tab-roles.html:
- platform/chromium/TestExpectations:
- platform/chromium/accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/chromium-win/accessibility/aria-fallback-roles-expected.txt.
- platform/chromium/accessibility/aria-list-and-listitem-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-list-and-listitem-expected.txt.
- platform/chromium/accessibility/aria-option-role-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt.
- platform/chromium/accessibility/aria-tab-roles-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-tab-roles-expected.txt.
- platform/gtk/accessibility/aria-list-and-listitem-expected.txt:
- platform/gtk/accessibility/aria-list-and-listitem.html: Removed.
- platform/gtk/accessibility/aria-option-role-expected.txt:
- platform/gtk/accessibility/aria-option-role.html: Removed.
- platform/mac/accessibility/aria-list-and-listitem-expected.txt:
- platform/mac/accessibility/aria-option-role-expected.txt:
- platform/mac/accessibility/aria-tab-roles-expected.txt:
- 3:45 PM Changeset in webkit [130822] by
-
- 2 edits in trunk/LayoutTests
Rolling back unintended change to iframe-copy-on-scroll.html from previous commit.
- compositing/iframes/iframe-copy-on-scroll.html:
- 3:31 PM Changeset in webkit [130821] by
-
- 4 edits3 adds in trunk/LayoutTests
Unreviewed gardening. Updating test expectations after r130811.
- compositing/iframes/iframe-copy-on-scroll.html:
- platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
- platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
- platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
- platform/chromium/TestExpectations:
- 3:24 PM Changeset in webkit [130820] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r130812.
http://trac.webkit.org/changeset/130812
https://bugs.webkit.org/show_bug.cgi?id=98826
Caused fast/text/shaping/shaping-selection-rect to fail
(Requested by abarth|gardening on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09
- platform/graphics/Font.cpp:
(WebCore::Font::width):
- platform/graphics/Font.h:
(Font):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::TextLayout::width):
(WebCore::Font::width):
(WebCore::ComplexTextController::advance):
- platform/graphics/mac/ComplexTextController.h:
- rendering/RenderBlock.h:
(WebCore):
(LineBreaker):
(RenderBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::createLineBoxesFromBidiRuns):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::textWidth):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- 3:19 PM Changeset in webkit [130819] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline-expectations doesn't work w/o failures specified
https://bugs.webkit.org/show_bug.cgi?id=98810
Reviewed by Ojan Vafai.
If you try to mark a test as foo.html [ Rebaseline ] it wasn't
getting picked up for rebaselining; we needed to think the test
was failing.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.get_rebaselining_failures):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(RebaseliningTest.test_get_rebaselining_failures):
- 3:19 PM Changeset in webkit [130818] by
-
- 2 edits in trunk/Source/WebCore
DOM/textarea-edit.html spends 35% of time in numGraphemeClusters
https://bugs.webkit.org/show_bug.cgi?id=98711
Reviewed by Kent Tamura.
Since the number of characters is always greater than the number of grapheme clusters,
we can avoid calling computeLengthForSubmission when the number of characters is less
than maxlength. We still have to count the number of LFs since they all need to be
converted into CRLFs. This improves WebKit's score on DOM/textarea-edit.html by 45%.
- html/HTMLTextAreaElement.cpp:
(WebCore::computeLengthForSubmission):
(WebCore::numberOfLineBreaks):
(WebCore::upperBoundForLengthForSubmission): Added.
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
(WebCore::HTMLTextAreaElement::tooLong):
- 2:58 PM Changeset in webkit [130817] by
-
- 9 edits in trunk/Source/WebCore
Make CachedResourceLoader RefCounted and have both Document
and DocumentLoader hold RefPtrs. This is in preparation for
caching main resources.
https://bugs.webkit.org/show_bug.cgi?id=86787
Reviewed by Adam Barth.
No new tests, no functionality changes at this time.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document): Only create our own CachedResourceLoader
if we were given a null frame.
(WebCore::Document::~Document):
(WebCore::Document::cachedResourceLoader):
(WebCore):
- dom/Document.h:
(Document):
- loader/DocumentLoader.cpp: Throughout, use our m_cachedResourceLoader instead
of the Document's pointer.
(WebCore::DocumentLoader::DocumentLoader): Create a CachedResourceLoader.
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::subresource):
(WebCore::DocumentLoader::getSubresources):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::cachedResourceLoader):
(DocumentLoader):
- loader/SubresourceLoader.cpp: Remove m_document, since it only existed to keep alive and access the CachedResourceLoader.
It can now be accessed from m_documentLoader.
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::~SubresourceLoader):
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::releaseResources):
- loader/SubresourceLoader.h:
(SubresourceLoader):
- loader/cache/CachedResourceLoader.cpp: Handle the possibility of a null Document in several places.
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::frame):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
(WebCore::CachedResourceLoader::loadDone):
- loader/cache/CachedResourceLoader.h:
(WebCore):
(WebCore::CachedResourceLoader::create): Add create(), make constructor private.
(CachedResourceLoader):
(WebCore::CachedResourceLoader::document):
(WebCore::CachedResourceLoader::setDocument):
(WebCore::CachedResourceLoader::clearDocumentLoader):
- 2:53 PM Changeset in webkit [130816] by
-
- 4 edits2 adds in trunk
CSS Style is not recalculated when media attribute of style element is changed
https://bugs.webkit.org/show_bug.cgi?id=96752
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-09
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
When "media" attribute of style element is changed, style should be recalculated.
This patch modifies HTMLStyleElement::parseAttribute, so that when the media attribute
is updated, new MediaQuerySet is created and applied to the style element then, document
style is recalculated. Since media query set is updated for CSSStyleSheet, CSSOM wrapper
for media query should be updated as well in order to sync with new media query set value.
Test: fast/media/mq-js-update-media.html
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::setMediaQueries):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute):
LayoutTests:
Added test to verify that when "media" attribute for style element is updated,
style is recalculated.
- fast/media/mq-js-update-media.html: Added.
- 2:50 PM Changeset in webkit [130815] by
-
- 5 edits in trunk/Source
[chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources()
https://bugs.webkit.org/show_bug.cgi?id=97689
Reviewed by Adam Barth.
Source/WebCore:
In addition to the WebKit/chromium side of the change, remove the
ASSERT in SecurityOrigin::grantLoadLocalResources(). Android WebView
is a legitimate user of this API in cases where neither of the
ASSERT'd conditions hold.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::grantLoadLocalResources): Remove ASSERT.
Source/WebKit/chromium:
This change exposes the WebCore::SecurityOrigin::grantLoadLocalResources()
function to the Chromium WebKit API layer. This is needed in Chromium
to implement the Android WebView.loadDataWithBaseUrl function in a
compatible manner.
Please see crbug.com/152223 for further information and the chromium
side patch.
- public/WebSecurityOrigin.h:
(WebSecurityOrigin): Add grantLoadLocalResources() API.
- src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::grantLoadLocalResources):
Implement the API by calling through to the WebCore function
of the same name.
(WebKit):
- 2:49 PM Changeset in webkit [130814] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Qt Windows.
- html/HTMLPlugInElement.h: Include Image.h.
- 2:35 PM Changeset in webkit [130813] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Chromium DEPS has a stray directory, turning our Win bots red
https://bugs.webkit.org/show_bug.cgi?id=98817
Reviewed by Dirk Pranke.
- DEPS: Removed the stray directory which solved the redness on several of our bots.
- 2:35 PM Changeset in webkit [130812] by
-
- 7 edits in trunk/Source/WebCore
Only measure text once instead of twice when performing line layout.
https://bugs.webkit.org/show_bug.cgi?id=98317
<rdar://problem/12080821>
Reviewed by Dan Bernstein.
Since we are measuring each word to find out where the line break should occur,
we should cache that information to avoid measuring the run again when
creating the line box. The bulk of the change is in nextLineBreak, where
the measurements are collected and placed in a vector so that they can
be consumed in setLogicalWidthForTextRun where we used to measure the
text one more time.
Each entry in the vector is a WordMeasurement object that contains information
about the start and end offset in the run, the renderer, the measured width
and, possibly, a list of fallback fonts.
When we need to compute the width of the run to create the line box, we add
all the measurements for the given renderer in the run to get the total width.
- platform/graphics/Font.cpp:
(WebCore::Font::width): Added fallback fonts parameter.
- platform/graphics/Font.h:
(Font): Added fallback fonts parameter to the width static member function.
This method is called when we compute the width using TextLayout.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::TextLayout::width): Added fallback fonts parameter.
(WebCore::Font::width):
(WebCore::ComplexTextController::advance):
- platform/graphics/mac/ComplexTextController.h:
(ComplexTextController): Added fallback fonts parameter to advance method.
- rendering/RenderBlock.h: Added WordMeasures parameter to few methods.
- rendering/RenderBlockLineLayout.cpp:
(WordMeasurement): Added new class to hold measurement information.
(WebCore::setLogicalWidthForTextRun): This is where we compute the run width using the
cached information.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added wordMeasures parameter.
(WebCore::RenderBlock::createLineBoxesFromBidiRuns): Added wordMeasures parameter.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added declaration of the WordMeasures
vector and its use.
(WebCore::textWidth): Added fallbackFonts parameter, since now we only measure once.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): This method has been modified to collect
the measurements of the individual words and add them to the vector.
- 2:31 PM Changeset in webkit [130811] by
-
- 68 edits3 adds in trunk
[Sub pixel layout] Fast-path iframe scrolling can picks up an extra pixel
https://bugs.webkit.org/show_bug.cgi?id=98571
Reviewed by Emil A Eklund.
Source/WebCore:
Refactoring all coordinate-switching functionality to use a single "mode" flag
as opposed to having a bunch of boolean values. This enables the same set of
options across the board, and a consistent interface. This was previously
done for mapLocalToContainer.
The imptetus for this for this stems from the one logical change in this patch
which only effects sub-pixel layout. FrameView::convertToRenderer and
convertFromRenderer return IntPoint coordinates, and need to also snap transform
offsets to determine proper rects for scrolling.
Unlabeled functions below are simply being updated to these new interfaces.
Test: fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html
- WebCore.exp.in:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):
- dom/Element.cpp:
(WebCore::Element::boundsInRootViewSpace):
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::computeRelativePosition):
- dom/Node.cpp:
(WebCore::Node::convertToPage):
(WebCore::Node::convertFromPage):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
- page/FrameView.cpp:
(WebCore::FrameView::convertToRenderer): Now pixel-snaps offsets before passing
them to TransformState, which transforms the coordinates.
(WebCore::FrameView::convertFromRenderer): Ditto.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::absoluteQuads):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::absoluteQuads):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::mapAbsoluteToLocalPoint):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::absolutePoint):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::mapLocalToContainer):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::absoluteToContents):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):
- rendering/RenderObject.h:
(RenderObject): MapLocalToContainerFlags is now MapCoordinatesFlags since it's
now used for other conversion methods.
(WebCore::RenderObject::localToAbsoluteQuad):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
- rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
- rendering/RenderView.h:
(RenderView):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
- rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::mapLocalToContainer):
- rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::mapLocalToContainer):
- rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::mapLocalToContainer):
- rendering/svg/RenderSVGText.h:
(RenderSVGText):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
LayoutTests:
Tests scrolling of sub-pixel layers on sub-pixel platforms (Chromium).
- fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: Added.
- platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
- platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
- platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
The repaint rect shrinks safely by one pixel.
- platform/chromium/TestExpectations:
- platform/mac-lion/TestExpectations:
- platform/mac-snowleopard/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt/TestExpectations:
- platform/win-wk2/TestExpectations:
- platform/win-xp/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 2:23 PM Changeset in webkit [130810] by
-
- 9 edits in trunk/Source
[WK2] Have plugins render offscreen to capture snapshot
https://bugs.webkit.org/show_bug.cgi?id=98326
<rdar://problem/12426658>
Reviewed by Simon Fraser.
Source/WebCore:
Change updateSnapshot() to use a PassRefPtr<Image> instead of Image*. WebKit2 ultimately
hands the image off to RenderSnapshottedPlugin. A CachedImage instance then manages the
lifetime of the Image.
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::updateSnapshot):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot):
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Updated to use the PassRefPtr<Image>
pointer.
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn):
Source/WebKit2:
Keep the plugin rendering without compositing to easily grab the snapshot.
PluginView now has two variables referring to snapshots, but are unrelated. The timer
is used to capture a snapshot that acts as a poster for a plugin. The ShareableBitmap
variable m_snapshot is used whenever the plugin paints in software, to avoid side effects
should the plugin run JS during painting.
- WebProcess/Plugins/PluginView.cpp:
(WebKit): Add a named constant for the time delay before a snapshot is taken.
(WebKit::PluginView::PluginView): Initialize a 3-second timer to get the snapshot.
(WebKit::PluginView::~PluginView): Refactor part of the destructor code out into
destroyPluginAndReset() for reuse.
(WebKit::PluginView::destroyPluginAndReset): Contains part of the destructor code.
In addition to destroying the plugin, the destructor cancels pending loads and streams.
(WebKit::PluginView::didInitializePlugin): If the plugin is in a state where it needs
to generate or display a poster, don't setup the compositing layer and start the timer.
(WebKit::PluginView::paint): Avoid painting if the plugin is not running.
(WebKit::PluginView::invalidateRect): Avoid painting if the plugin is not running.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Don't enable accelerated compositing
until the plugin is running.
(WebKit::PluginView::pluginSnapshotTimerFired): When the timer fires, get a snapshot, generate
an Image that WebCore can render, and destroy the plugin.
Rename m_snapshot to m_transientPaintingSnapshot.
- WebProcess/Plugins/PluginView.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
(WebKit::PluginView::notifyWidget):
(WebKit::PluginView::pluginSnapshotTimerFired):
- 2:20 PM Changeset in webkit [130809] by
-
- 2 edits in trunk/LayoutTests
These tests also fail with ImageOnlyFailures.
- platform/chromium/TestExpectations:
- 2:17 PM Changeset in webkit [130808] by
-
- 2 edits in trunk/LayoutTests
This test now appears to fail on the bots because
http://trac.webkit.org/changeset/130799 removed the ImageOnlyFailure
attribute.
- platform/chromium/TestExpectations:
- 2:09 PM Changeset in webkit [130807] by
-
- 1 edit1 move in trunk/Source/WebCore
Unreviewed. Move this file to where the build systems think it should
be. See https://bugs.webkit.org/show_bug.cgi?id=94755
- platform/graphics/CustomFilterConstants.h: Removed.
- platform/graphics/filters/CustomFilterConstants.h: Copied from Source/WebCore/platform/graphics/CustomFilterConstants.h.
- 1:38 PM Changeset in webkit [130806] by
-
- 2 edits in trunk/Source/WebCore
Use computeLogical* methods instead of updateLogical* methods in RenderImage
https://bugs.webkit.org/show_bug.cgi?id=98802
Reviewed by Eric Seidel.
We were storing the old values of width/height, calling updateLogical{Width,Height}, then restoring
the old values. Instead, use the computeLogical{Width,Height} methods so we don't have to overwrite
the current values.
No new tests, this is just a refactoring.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
- 1:36 PM Changeset in webkit [130805] by
-
- 7 edits in trunk/Tools
VCSUtils.pm doesn't support SVN 1.7 diff files
<https://bugs.webkit.org/show_bug.cgi?id=80762>
Reviewed by Eric Seidel.
Implement support for the SVN 1.7 diff format.
- Scripts/VCSUtils.pm:
(parseChunkRange): Modified to support parsing an SVN 1.7 chunk range
that begins and ends with "##" (e.g. ## -0,0 +1,7 ##). For comparison,
earlier versions of SVN parsed chunk ranges of the form "@@ -0,0 +1,7 @@".
(parseSvnDiffHeader): Modified to parse an SVN 1.7 binary diff; SVN 1.7
has an unusual display format for a binary diff. It repeats the first
two lines of the diff header.
(parseSvnProperty): Modified to ignore both an SVN 1.7 chunk range and
lines of the form "\ No newline at end of property". SVN 1.7 emits the latter
message after a property value that doesn't end in a newline.
(parseSvnPropertyValue): Stop parsing an SVN property value when we encounter
a line of the form "\ No newline at end of property" (emitted by svn diff as of
SVN 1.7).
- Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
- Added the following unit tests: "Line count is 0" "New line count is 1"
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
- Added the following unit tests: "svn:executable followed by custom property using SVN 1.7 syntax" "svn:executable followed by custom property without newline using SVN 1.7 syntax"
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Updated test results for test "binary file".
- Added unit test "binary file using SVN 1.7 syntax".
- Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following unit tests: "simple: add svn:executable using SVN 1.7 syntax" "simple: delete svn:executable using SVN 1.7 syntax" "add svn:mime-type and add svn:executable using SVN 1.7 syntax"
- Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following unit tests: "singe-line '+' change using SVN 1.7 syntax" "single-line '-' change using SVN 1.7 syntax"
- 1:35 PM Changeset in webkit [130804] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Cleanup FatFingers.cpp
https://bugs.webkit.org/show_bug.cgi?id=98806
Reviewed by Antonio Gomes.
Cleanup namespace usage and sync up FatFingers.cpp.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::compareDistanceBetweenPoints):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):
(BlackBerry::WebKit::FatFingers::checkForText):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
- 1:28 PM Changeset in webkit [130803] by
-
- 2 edits in trunk/Source/WebCore
[chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura-
background-canvas.html failing on the Mac after r130443
https://bugs.webkit.org/show_bug.cgi?id=98545
Reviewed by Tony Chang.
Adding back the ! removed by mistake before submitting r130779.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):
- 1:28 PM Changeset in webkit [130802] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r128488.
http://trac.webkit.org/changeset/128488
https://bugs.webkit.org/show_bug.cgi?id=96678
The bot is fixed now
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
- 1:12 PM Changeset in webkit [130801] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] EGL Context deleted prematurely in GraphicsContext3D destructor
https://bugs.webkit.org/show_bug.cgi?id=98796
Patch by Artem Simonov <asimonov@rim.com> on 2012-10-09
Reviewed by George Staikos.
Reordered destruction of GraphicsContext3D so that the compositing layer is
destroyed first.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
- 1:06 PM Changeset in webkit [130800] by
-
- 2 edits in trunk/Source/WebCore
Disable hinting when webkit-font-smoothing:antialiased is used on Mac.
https://bugs.webkit.org/show_bug.cgi?id=98061
Patch by Ben Wagner <bungeman@chromium.org> on 2012-10-09
Reviewed by Stephen White.
Normal anti-aliased text matches subpixel anti-aliased text.
However, text marked with webkit-font-smoothing:antialiased should be drawn without hinting to match Safari.
See crbug.com/152304 .
Test is fast/css/font-smoothing.html, but DRT runs with font smoothing disabled, so no change visible.
- platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
Set kNo_Hinting when webkit-font-smoothing is antialiased.
- 1:06 PM Changeset in webkit [130799] by
-
- 2 edits in trunk/LayoutTests
[Chromium] More TestExpectation updates for Android
https://bugs.webkit.org/show_bug.cgi?id=98818
Unreviewed test expectation updates.
List more failures (all with bugs assigned) in the TestExpectation file for
Android. Move an older block around, considering we may want to re-triage it.
- platform/chromium/TestExpectations:
- 12:55 PM Changeset in webkit [130798] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
- platform/chromium/TestExpectations:
Removed this entry: there was no need for new baselines.
- 12:48 PM Changeset in webkit [130797] by
-
- 8 edits1 add in trunk/Source/WebCore
[CSS Shaders] Create constants for vertex attribute sizes and offsets
https://bugs.webkit.org/show_bug.cgi?id=94755
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-09
Reviewed by Dean Jackson.
Factor out the vertex attribute size and offset constants into a new file,
CustomFilterConstants.h. Replace literals in CustomFilterMeshGenerator with the constants.
I could have added the constants to CustomFilterMeshGenerator.h, but this would make
FECustomFilter depend on CustomFilterMeshGenerator.
I also could have added the constants to CustomFilterMesh.h, but this would make
CustomFilterMeshGenerator depend on CustomFilterMesh.
No new tests. No change in behavior.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/CustomFilterConstants.h: Added.
(WebCore):
- platform/graphics/filters/CustomFilterMeshGenerator.h:
(WebCore::CustomFilterMeshGenerator::floatsPerVertex):
Use the new constants instead of literal values.
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::bindProgramAndBuffers):
Pull the constant definitions out of here.
- 12:44 PM Changeset in webkit [130796] by
-
- 11 edits in trunk/LayoutTests
dfg-cross-global tests are flaky because they misuse js-test-pre.js
https://bugs.webkit.org/show_bug.cgi?id=98813
Reviewed by Daniel Bates.
These tests have a race between js-test-pre's "done" message and the
timeout. This patch change then to use jsTestIsAsync and finishJSTest()
appropriately.
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js:
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js:
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js:
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js:
- fast/js/script-tests/dfg-cross-global-object-inline-new-array.js:
- 12:26 PM Changeset in webkit [130795] by
-
- 4 edits in trunk/Source/WebCore
MarkupAccumulator should optimally handle 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=98224
Reviewed by Ryosuke Niwa.
Updated appendCharactersReplacingEntities to take a string, offset and length and process 8 or 16 bit
data as appropriate. Also made it a member function of MarkupAccumulator.
No new tests, behavior covered by existing tests.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::appendAttributeValue):
(WebCore::MarkupAccumulator::appendNodeValue):
- editing/MarkupAccumulator.h:
(MarkupAccumulator):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::urlToMarkup):
- 12:25 PM Changeset in webkit [130794] by
-
- 5 edits in trunk
IndexedDB: Overflowing key generator should throw ConstraintError
https://bugs.webkit.org/show_bug.cgi?id=98807
Reviewed by Tony Chang.
Source/WebCore:
After the WebKit implementation landed throwing DataError, public-webapps
consensus was that the exception thrown should be ConstraintError. Trivial
change, and we pass one more W3C test submission.
Test: storage/indexeddb/key-generator.html
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
LayoutTests:
Verify that overflowing key generator throws ConstraintError.
- storage/indexeddb/key-generator-expected.txt:
- storage/indexeddb/resources/key-generator.js:
- 12:23 PM Changeset in webkit [130793] by
-
- 2 edits in trunk/LayoutTests
[chromium] Don't run perf/mouse-event on debug builds
Unreviewed, expectations change.
We don't normally run any perf tests on a debug build, but this
one was getting run due to an improperly scoped expectation
overriding the wontfix rule.
- platform/chromium/TestExpectations:
- 12:23 PM Changeset in webkit [130792] by
-
- 2 edits in trunk/Tools
XvfbDriver unit test is flaky on Linux builders
https://bugs.webkit.org/show_bug.cgi?id=98346
Reviewed by Adam Barth.
Temporarily skip the XvfbDriver test case that tests
the display number of the next free display. The test
is flaky on Linux builders.
- Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.disabled_test_next_free_display):
- 12:18 PM Changeset in webkit [130791] by
-
- 1 edit3 adds in trunk/LayoutTests
IndexedDB: open-in-upgradeneeded layout test
https://bugs.webkit.org/show_bug.cgi?id=95912
Reviewed by Tony Chang.
- storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt: Added.
- storage/indexeddb/intversion-open-in-upgradeneeded.html: Added.
- storage/indexeddb/resources/intversion-open-in-upgradeneeded.js: Added.
(test):
(deleteSuccess):
(upgradeNeeded1.transaction.oncomplete):
(upgradeNeeded1):
(openSuccess1):
(onVersionChange):
(onBlocked):
(upgradeNeeded2):
(openSuccess2):
- 12:16 PM Changeset in webkit [130790] by
-
- 3 edits in trunk/Tools
Don't duplicated build numbers when merging flakiness dashboard JSON
https://bugs.webkit.org/show_bug.cgi?id=98812
Reviewed by Dirk Pranke.
In general, build numbers are not unique, but we should basically never
get the same build number uploaded twice in a row. This is a workaround
for https://bugs.webkit.org/show_bug.cgi?id=97643, which frequently hits this
because we update results_small.json and timeout updating results.json and then
we retry the whole request.
- TestResultServer/model/jsonresults.py:
(JsonResults.merge):
- TestResultServer/model/jsonresults_unittest.py:
(JsonResultsTest.test_merge_duplicate_build_number):
- 12:16 PM Changeset in webkit [130789] by
-
- 2 edits in trunk/Source/WebCore
Fix the order of the statements in my previous build fix.
Reviewed by Gustavo Noronha Silva.
My previous build build fix for ResourceHandleSoup ordered the assignment
of the local ResourceHandleInternal incorrectly. Instead of being before
both assertions, it should be interspersed among them.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):
- 12:14 PM Changeset in webkit [130788] by
-
- 2 edits in trunk/LayoutTests
Need implement isWordTextBreak for QT, and WinCE for visual word movement functionality
https://bugs.webkit.org/show_bug.cgi?id=81136
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Caio Marcelo de Oliveira Filho.
Uskipping tests that are passing after the merge https://gitorious.org/qtwebkit/testfonts/merge_requests/1
- platform/qt/TestExpectations:
- 12:08 PM Changeset in webkit [130787] by
-
- 2 edits in trunk/LayoutTests
RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
https://bugs.webkit.org/show_bug.cgi?id=51517
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Caio Marcelo de Oliveira Filho.
Unskipping a test that is passing, with testfonts change in https://gitorious.org/qtwebkit/testfonts/merge_requests/1
- platform/qt/TestExpectations:
- 12:06 PM Changeset in webkit [130786] by
-
- 2 edits in trunk/LayoutTests
Note that this test is flaky.
- platform/chromium/TestExpectations:
- 11:59 AM Changeset in webkit [130785] by
-
- 2 edits in trunk/LayoutTests
Revert change to TestExpectations in http://trac.webkit.org/changeset/130779.
These tests still give the wrong results.
- platform/chromium/TestExpectations:
- 11:56 AM Changeset in webkit [130784] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
- platform/chromium/TestExpectations:
Fix new-run-webkit-tests --lint-test-files after r130778.
- 11:47 AM Changeset in webkit [130783] by
-
- 17 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=98457
ScrollingStateNodes should be referenced via IDs on
RenderLayerBacking
Reviewed by Simon Fraser.
This patch associates all ScrollingStateNodes with a
RenderLayerBacking via a HashMap from RenderLayerBackings to
ScrollingStateNodes on ScrollingCoordinator. Prior to this patch, the
root ScrollingStateNode was created immediately upon creation of the
ScrollingCoordinator, and it was constantly re-used for every main
FrameView. This doesn't work in the new model since that doesn't
allow that ScrollingStateNode to have a definite association with a
RenderLayerBacking. So this patch does also introduce some lifetime
differences with the ScrollingStateNodes.
If a page is going into the page cache, we should clear the state
tree. When the page is in the cache, we won't have access to the
RenderLayerBacking, and we don't want to be doing anything with the
ScrollingStateNodes anyway.
- dom/Document.cpp:
(WebCore::Document::setInPageCache):
When a page is restored from the page cache, call
frameViewRootLayerDidChange() to re-create the state tree.
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
This new FrameView function will return the scrollLayerID for a given FrameView.
- page/FrameView.cpp:
(WebCore::FrameView::scrollLayerID):
(WebCore):
- page/FrameView.h:
(FrameView):
There is a lot of unfortunate fiddling with the terrible
if-defs in ScrollingCoordinator. I added a FIXME to the header
noting how we can avoid this in the future.
- page/scrolling/ScrollingCoordinator.cpp:
All of this code used to refer to the rootStateNode directly.
Instead, now it looks up the proper ScrollingStateNode for the given
FrameView in the HashMap.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPosition):
(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):
(WebCore::ScrollingCoordinator::setScrollLayerForNode):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegionForNode):
(WebCore::ScrollingCoordinator::setScrollParametersForNode):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCountForNode):
Returns the existing ScrollingStateNode for a given FrameView by
looking it up in the HashMap.
(WebCore::ScrollingCoordinator::stateNodeForFrameView):
This is called when a RenderLayerBacking is destroyed. At that time,
its associated ScrollingStateNode is destroyed.
(WebCore::ScrollingCoordinator::detachFromStateTree):
clearStateTree() clears the HashMap and destroys all of the nodes in
the current state tree.
(WebCore::ScrollingCoordinator::clearStateTree):
Creates a new root state node for the given FrameView.
(WebCore::ScrollingCoordinator::ensureRootStateNodeForFrameView):
Some new functions for the new node stuff.
- page/scrolling/ScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::supportsFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinator::detachFromStateTree):
(WebCore::ScrollingCoordinator::clearStateTree):
(WebCore::ScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::setScrollParameters):
(WebCore::setWheelEventHandlerCount):
New remove functions are used when the sate tree is cleared and when
a RenderLayerBacking is destroyed.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::removeChild):
(WebCore):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::isScrollingStateScrollingNode):
(ScrollingStateNode):
(WebCore::ScrollingStateNode::parent):
New convenience function for casting to ScrollingStateScrollingNodes.
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::toScrollingStateScrollingNode):
(WebCore):
No longer automatically create a root node upon creation of the
ScrollingStateTree. We now want to wait to create the root node until
we have a RenderLayerBacking to associate it with.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::removeNode):
(WebCore):
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::setRootStateNode):
(ScrollingStateTree):
RenderLayerBacking has a new data member called m_scrollLayerID. If
this RenderLayerBacking is represented in the scrolling tree, then
the ID with be unique and non-zero.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::generateScrollLayerID):
(WebCore):
(WebCore::RenderLayerBacking::attachToScrollingCoordinator):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
(WebCore::RenderLayerBacking::scrollLayerID):
Move the call to ScrollingCooridinator::frameViewRootLayerDidChange()
from RenderLayerCompositor::attachRootLayer() to
RenderLayerCompositor:: updateBacking(). The problem with the old call
site is that there is no backing at that time, so we are trying to set
state on the root scrolling state node before we have enough
information to create that node and add it to the HashMap.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::attachRootLayer):
- 11:37 AM Changeset in webkit [130782] by
-
- 2 edits in trunk/LayoutTests
[Qt] modify-up-on-rtl-wrapping-text.html fails on DRT
https://bugs.webkit.org/show_bug.cgi?id=50291
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Csaba Osztrogonác.
Unskipping editing/selection/modify-up-on-rtl-wrapping-text.html
- platform/qt/TestExpectations:
- 11:37 AM Changeset in webkit [130781] by
-
- 2 edits in trunk/Tools
[GTK] Shadow builds are not working anymore.
https://bugs.webkit.org/show_bug.cgi?id=98785
Reviewed by Martin Robinson.
When setting WEBKITOUTPUTDIR the build was failing with a python
error : the os.execve expect three arguments. Also the condition
to check whether we build the GTK port with jhbuild or not was buggy
as it was always assuming an in source build. We can use now jhbuildutils
which has a convenient function to locate the directory where
the dependencies built with jhbuild are and take into account WEBKITOUTPUTDIR.
If the Dependencies path does not exist then the build was not done using
jhbuild so we can fallback to a regular build against system libraries.
- gtk/run-with-jhbuild:
- 11:36 AM Changeset in webkit [130780] by
-
- 2 edits in trunk/Source/WebCore
SVGResources should use HashSet<AtomicString> instead of HashSet<AtomicStringImpl*>
https://bugs.webkit.org/show_bug.cgi?id=98683
Reviewed by Darin Adler.
Eric's notes:
SVGResources should use HashSet<AtomicString> instead of HashSet<AtomicStringImpl*>
They do basically the same thing, and the former is much more common (and less code). It's
also safe, on the off-chance that we're using AtomicStrings which might otherwise go away.
No new tests, refactoring.
- rendering/svg/SVGResources.cpp:
(WebCore::clipperFilterMaskerTags):
(WebCore::markerTags):
(WebCore::fillAndStrokeTags):
(WebCore::chainableResourceTags):
(WebCore::SVGResources::buildCachedResources):
- 11:09 AM Changeset in webkit [130779] by
-
- 6 edits1 add in trunk
[chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura-background-canvas.html
failing on the Mac after r130443
https://bugs.webkit.org/show_bug.cgi?id=98545
Reviewed by Tony Chang.
Source/WebCore:
Fixes a regression introduced with r130443.
No new tests added since we already have tests covering this.
Updated TestExpectations for chromium and mac.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter): Text orientation should not be
taken into account if the character is an ideograph or a symbol.
LayoutTests:
Updated TextExpectations for Chromium and Mac.
Moved existing expected results from mac to mac-lion and added new results for Mountain Lion.
- platform/chromium/TestExpectations:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 11:06 AM Changeset in webkit [130778] by
-
- 2 edits in trunk/LayoutTests
Update expectations in preparation for enabling float-src-rect behavior in SkCanvas::drawBitmapRect
https://bugs.webkit.org/show_bug.cgi?id=98795
Reviewed by NOBODY.
Expectations change only.
- platform/chromium/TestExpectations:
- 10:49 AM Changeset in webkit [130777] by
-
- 13 edits5 adds in trunk
Prevent animation when CSS attributeType is invalid.
https://bugs.webkit.org/show_bug.cgi?id=94569
Reviewed by Dirk Schulze.
Source/WebCore:
This patch changes hasValidAttributeType() to return false when
we have attributeType=CSS with a non-CSS attribute name.
Previously we would animate non-CSS attributes when attributeType was
CSS which resulted in crashes. To track this case, this patch catches
changes to targetElement, attributeName, and attributeType and checks
if an invalid combination is present. If invalid, hasInvalidCSSAttributeType()
will return true causing hasValidAttributeType() to return false and prevent
the animation from running.
Tests: svg/animations/animate-css-xml-attributeType.html
svg/animations/invalid-css-attribute-crash-expected.svg
svg/animations/invalid-css-attribute-crash.svg
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::hasValidAttributeType):
(WebCore::SVGAnimateElement::targetElementWillChange):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::isSupportedAttribute):
This now supports the attributeType attribute which is stored in m_attributeType.
(WebCore::SVGAnimationElement::parseAttribute):
(WebCore::SVGAnimationElement::setAttributeType):
Changes to attributeType, attributeName, and targetElement need to be tracked
to determine when an invalid combination happens.
(WebCore::SVGAnimationElement::targetElementWillChange):
(WebCore):
(WebCore::SVGAnimationElement::setAttributeName):
(WebCore::SVGAnimationElement::checkInvalidCSSAttributeType):
- svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::attributeType):
(SVGAnimationElement):
(WebCore::SVGAnimationElement::hasInvalidCSSAttributeType):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::targetElement):
- svg/animation/SVGSMILElement.h:
(SVGSMILElement):
LayoutTests:
Adding a test to prove this patch works (invalid-css-attribute-crash.svg)
and an additional test to show that switching between XML and CSS
attributeTypes works as expected (animate-css-xml-attributeType.html).
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- svg/animations/animate-css-xml-attributeType-expected.txt: Added.
- svg/animations/animate-css-xml-attributeType.html: Added.
- svg/animations/invalid-css-attribute-crash-expected.svg: Added.
- svg/animations/invalid-css-attribute-crash.svg: Added.
- svg/animations/script-tests/animate-css-xml-attributeType.js: Added.
(sample1):
(sample6):
(executeTest):
- 10:17 AM Changeset in webkit [130776] by
-
- 19 edits in trunk
Remove DRT/WTR implementations of layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=98697
Reviewed by Tim Horton, James Robinson, Alexey Proskuryakov.
Tools:
Remove code related to layerTreeAsText(), which is now on window.internals.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
Fix a couple of tests missed in the previous chnage.
- compositing/geometry/preserve-3d-switching.html:
- compositing/visibility/visibility-image-layers-dynamic.html:
- 9:59 AM Changeset in webkit [130775] by
-
- 2 edits in trunk/Source/WebKit2
Add missing compile flag for compositing
https://bugs.webkit.org/show_bug.cgi?id=98681
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-09
Reviewed by Dirk Schulze.
This flag is needed in case there is a difference in API
when compositing is enabled
- Configurations/FeatureDefines.xcconfig:
- 9:55 AM Changeset in webkit [130774] by
-
- 3 edits2 adds in trunk
max-width property is does not overriding the width properties for css tables(display:table)
https://bugs.webkit.org/show_bug.cgi?id=98455
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-09
Reviewed by Tony Chang.
Source/WebCore:
The max-width property determines the maximum computed width an element can have. In case of css tables(display:table),
the computed was not being limited by the max-width property. The current patch fixes this issue.
Test: fast/table/css-table-max-width.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
Logic to compute the logical width of an element such that it does not exceed the max-width value.
Also when both min-width and max-width are present, the following contraint is used to compute the logical width:
1) min-width < Computed LogicalWidth < max-width, when min-width < max-width.
2) Computed LogicalWidth = min-width, when min-width > max-width.
LayoutTests:
- fast/table/css-table-max-width-expected.txt: Added.
- fast/table/css-table-max-width.html: Added.
- 9:50 AM Changeset in webkit [130773] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Expanding failure expectation for editing/pasteboard/drag-drop-list.html to
again include debug configurations as well.
- platform/gtk/TestExpectations:
- 9:25 AM Changeset in webkit [130772] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r130680.
http://trac.webkit.org/changeset/130680
https://bugs.webkit.org/show_bug.cgi?id=98720
this patch has a typo so was ineffective (Requested by
cabanier on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09
- Configurations/FeatureDefines.xcconfig:
- 9:21 AM Changeset in webkit [130771] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Test expectation updates for Android
https://bugs.webkit.org/show_bug.cgi?id=98786
Unreviewed test expectation update.
Update the test expectations for Android. Nineteen bugs were filed,
which are all blocking bug 96398.
- platform/chromium-android/TestExpectations:
- platform/chromium/TestExpectations:
- 9:03 AM Changeset in webkit [130770] by
-
- 2 edits in trunk/Tools
Unreviewed. Remove myself from QtWebKit2 subscriptions.
- Scripts/webkitpy/common/config/watchlist:
- 8:57 AM Changeset in webkit [130769] by
-
- 4 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 8:56 AM Changeset in webkit [130768] by
-
- 15 edits in trunk
Source/Platform: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.
https://bugs.webkit.org/show_bug.cgi?id=98753
Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.
- chromium/public/WebRTCStatsResponse.h:
(WebRTCStatsResponse):
Source/WebCore: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.
https://bugs.webkit.org/show_bug.cgi?id=98753
Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.
IDL of RTCStatsReport has been changed to make local/remote
single valued RTCStatsElement attributes.
The RTCStatsReport argument to index the list of RTCStatsElement
in the local and remote functions has been removed.
Tested by modifications to RTCPeerConnection-stats.html
- Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::addElement):
(WebCore::RTCStatsReport::addStatistic):
- Modules/mediastream/RTCStatsReport.h:
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):
(RTCStatsReport):
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::addElement):
(WebCore::RTCStatsResponse::addStatistic):
- Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
- platform/chromium/support/WebRTCStatsResponse.cpp:
(WebKit::WebRTCStatsResponse::addElement):
(WebKit::WebRTCStatsResponse::addStatistic):
- platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):
Tools: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.
https://bugs.webkit.org/show_bug.cgi?id=98753
Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):
LayoutTests: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.
https://bugs.webkit.org/show_bug.cgi?id=98753
Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.
- fast/mediastream/RTCPeerConnection-stats-expected.txt:
- fast/mediastream/RTCPeerConnection-stats.html:
- 8:54 AM Changeset in webkit [130767] by
-
- 3 edits3 adds in trunk/LayoutTests
Unreviewed. Add chromium-mac specific results for these tests. They
differ from the expected results only in text rendering.
- platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png:
- platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png:
- platform/chromium-mac/fast/text/hyphenate-character-expected.png: Added.
- platform/chromium-mac/fast/text/hyphenate-limit-before-after-expected.png: Added.
- platform/chromium-mac/fast/text/hyphens-expected.png: Added.
- 8:33 AM Changeset in webkit [130766] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark svg/text/selection-tripleclick.svg as flaky on WK2.
- platform/efl-wk2/TestExpectations:
- 8:13 AM Changeset in webkit [130765] by
-
- 7 edits2 adds in trunk
[chromium] Make sure events are transformed correctly for plugins.
https://bugs.webkit.org/show_bug.cgi?id=89250
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-09
Reviewed by Tony Chang.
Source/WebKit/chromium:
The events arriving in WebPluginContainerImpl are in the coordinate
space of the page containing the plugin. Before the events are
dispatched to the plugin, it is necessary to convert them into the
plugin's own coordinate system.
- src/WebInputEventConversion.cpp:
(WebKit::convertLocationForRenderObject): Transforms an event location for the specified RenderObject.
(WebKit):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent): Refactored code to reduce code-duplication for mouse and wheel events.
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
- src/WebInputEventConversion.h:
(WebCore):
(WebKit):
(WebMouseEventBuilder):
(WebMouseWheelEventBuilder):
(WebTouchEventBuilder):
(WebGestureEventBuilder):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleMouseEvent):
(WebKit::WebPluginContainerImpl::handleWheelEvent):
Tools:
Update the test plugin to print event details for mouse and gesture events.
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(printEventDetails):
LayoutTests:
Added tests to make sure that events are transformed properly. Note that
for touch-events, each point in the three touch-point lists in the
touch-event is printed, so the same touch-point is printed out three
times.
- platform/chromium/plugins/transformed-events-expected.txt: Added.
- platform/chromium/plugins/transformed-events.html: Added.
- 8:06 AM WebKit Team edited by
- (diff)
- 8:03 AM Changeset in webkit [130764] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden.
https://bugs.webkit.org/show_bug.cgi?id=98757
Reviewed by Kenneth Rohde Christiansen.
SVN r130720 exposed a bug in our code: the PageProxy is not
notified when one calls evas_object_show() or evas_object_hide()
on the view, so the visibility it has when the WebPageProxy is
constructed remained set forever.
This made the ewk_context_vibration_client_callbacks_set unit test
start running forever, because WebPageProxy's constructor now sets
the page's visibility to hidden by the default for us, since it is
called from within ewk_view_smart_add() and before
evas_object_show().
We now listen to the EVAS_CALLBACK_SHOW and EVAS_CALLBACK_HIDE
callbacks and update the WebPageProxy accordingly. Note that we
could not do this from the smart_show and smart_hide functions we
already had, since they are called before the object's actual
visibility is updated.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_add):
- 8:00 AM Changeset in webkit [130763] by
-
- 4 edits in trunk/Source
Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
https://bugs.webkit.org/show_bug.cgi?id=98756
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Source/WebCore:
No behavior change so no new tests.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- 7:48 AM Changeset in webkit [130762] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Corrected reviewer that webkit-patch got wrong.
- 7:46 AM Changeset in webkit [130761] by
-
- 2 edits in trunk/Source/JavaScriptCore
After r130344, OpaqueJSString::identifier() adds wrapped String to identifier table
https://bugs.webkit.org/show_bug.cgi?id=98693
REGRESSION (r130344): Install failed in Install Environment
<rdar://problem/12450118>
Reviewed by Filip Pizlo.
Use Identifier(LChar*, length) or Identifier(UChar*, length) constructors so that we don't
add the String instance in the OpaqueJSString to any identifier tables.
- API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):
- 7:15 AM Changeset in webkit [130760] by
-
- 2 edits in trunk/Tools
Unreviewed trivial Qt build fix: Remove stray closing braces from r130758.
- qmake/mkspecs/features/features.prf:
- 7:03 AM Changeset in webkit [130759] by
-
- 6 edits in trunk/Source
[Qt] Fix build with QtMultimedia
Reviewed by Tor Arne Vestbø.
Source/WebCore:
This is an initial rudimentary port to of the QtMultimedia back-end,
adapted to slight API changes and (more importantly) to the
implementation of QAbstractVideoSurface instead of using
QGraphicsVideoItem (which is in QtMultimediaWidgets).
- WebCore.pri:
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::supportsType):
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
(WebCore::MediaPlayerPrivateQt::totalBytes):
(WebCore::MediaPlayerPrivateQt::setVisible):
(WebCore::MediaPlayerPrivateQt::surfaceFormatChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::removeVideoItem):
(WebCore::MediaPlayerPrivateQt::restoreVideoItem):
(WebCore):
(WebCore::MediaPlayerPrivateQt::start):
(WebCore::MediaPlayerPrivateQt::supportedPixelFormats):
(WebCore::MediaPlayerPrivateQt::present):
(WebCore::MediaPlayerPrivateQt::paint):
(WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateQt::paintToTextureMapper):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
Source/WebKit:
- WebKit1.pri: WK1 needs QtMultimediaWidgets for QVideoWidget and friends.
- 7:02 AM Changeset in webkit [130758] by
-
- 2 edits in trunk/Tools
[Qt] Clean up Qt module detection
Reviewed by Tor Arne Vestbø.
Replace the use of MOBILITY_CONFIG (not supported anymore) with modern use of haveQtModule.
- qmake/mkspecs/features/features.prf:
- 6:45 AM Changeset in webkit [130757] by
-
- 2 edits in trunk/Tools
[GTK] Respect WEBKITOUTPUTDIR in run-with-jhbuild.
https://bugs.webkit.org/show_bug.cgi?id=98732
Reviewed by Gustavo Noronha Silva.
Follow-up to r113066: if the WEBKITOUTPUTDIR environment variable
was used when running update-webkitgtk-libs,
WebKitBuild/Dependencies will not exist, so we now check its
contents first and then fall back to WebKitBuild/.
- gtk/run-with-jhbuild:
- 6:43 AM Changeset in webkit [130756] by
-
- 7 edits in trunk/Source
Allow users to specify a different hover image for TextFieldDecorationElement
https://bugs.webkit.org/show_bug.cgi?id=93662
Patch by Garrett Casto <gcasto@chromium.org> on 2012-10-09
Reviewed by Kent Tamura.
Source/WebCore:
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::updateImage):
(WebCore::TextFieldDecorationElement::defaultEventHandler): Handles mouseover and mouseout events.
(WebCore::TextFieldDecorationElement::willRespondToMouseMoveEvents): Now returns true if the element is not disabled.
(WebCore):
- html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorator):
(TextFieldDecorationElement):
Source/WebKit/chromium:
- public/WebTextFieldDecoratorClient.h:
(WebTextFieldDecoratorClient):
(WebKit::WebTextFieldDecoratorClient::imageNameForHoverState): Allow users to specify the name of the image for mouseover.
- src/TextFieldDecoratorImpl.cpp:
(WebKit::TextFieldDecoratorImpl::imageForReadonlyState):
(WebKit::TextFieldDecoratorImpl::imageForHoverState):
(WebKit):
- src/TextFieldDecoratorImpl.h:
(TextFieldDecoratorImpl):
- 6:31 AM Changeset in webkit [130755] by
-
- 11 edits2 adds in trunk
[GTK] Add support for running JavaScript from GResources
https://bugs.webkit.org/show_bug.cgi?id=98488
Patch by Simon Pena <Simon Pena> on 2012-10-09
Reviewed by Carlos Garcia Campos.
GResources allow embedding certain resources, frequently used, in a "bundle"
which can be kept separated or stored in the binary. This patch adds
support for running JavaScript from GResources.
.:
- configure.ac: Add support for compiling GResources
Source/WebKit2:
For this, methods run_javascript_from_gresource and
run_javascript_from_gresource_finish are added, which load the resource
asynchronously and, when it is ready, run the JavaScript.
- UIProcess/API/gtk/WebKitWebView.cpp: Include the new methods.
(resourcesStreamReadCallback):
(webkit_web_view_run_javascript_from_gresource):
(webkit_web_view_run_javascript_from_gresource_finish):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the new
methods in the documentation.
- UIProcess/API/gtk/tests/GNUmakefile.am: Add the test resources to the
build infrastructure.
- UIProcess/API/gtk/tests/TestMain.cpp: Register the resources in the tests,
so that they can be accessed in all of them.
(register_gresource):
(main):
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Test the
run_javascript_from_gresource method.
(testWebViewRunJavaScript):
- UIProcess/API/gtk/tests/WebViewTest.cpp: Add a method for testing the
new run_javascript_from_gresource method.
(runJavaScriptFromGResourceReadyCallback):
(WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished):
- UIProcess/API/gtk/tests/WebViewTest.h:
- UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml: Added.
Resource bundle containing the resources.
- UIProcess/API/gtk/tests/resources/webkit2gtk-tests.test.js: Added.
Example JavaScript file to test the GResources support.
- 6:07 AM Changeset in webkit [130754] by
-
- 29 edits2 adds in trunk/LayoutTests
[EFL] Rebaseline some svg/text tests.
Some pixel tests now have the red rectangle drawn around some
areas like other ports.
While here, also add an expectation for selection-tripleclick.svg,
which seems to be passing now.
- platform/efl/TestExpectations:
- platform/efl/svg/text/foreignObject-text-clipping-bug-expected.png:
- platform/efl/svg/text/selection-tripleclick-expected.png: Added.
- platform/efl/svg/text/selection-tripleclick-expected.txt: Added.
- platform/efl/svg/text/text-align-01-b-expected.png:
- platform/efl/svg/text/text-align-02-b-expected.png:
- platform/efl/svg/text/text-align-03-b-expected.png:
- platform/efl/svg/text/text-align-04-b-expected.png:
- platform/efl/svg/text/text-align-05-b-expected.png:
- platform/efl/svg/text/text-align-06-b-expected.png:
- platform/efl/svg/text/text-altglyph-01-b-expected.png:
- platform/efl/svg/text/text-deco-01-b-expected.png:
- platform/efl/svg/text/text-fonts-01-t-expected.png:
- platform/efl/svg/text/text-fonts-02-t-expected.png:
- platform/efl/svg/text/text-intro-05-t-expected.png:
- platform/efl/svg/text/text-path-01-b-expected.png:
- platform/efl/svg/text/text-spacing-01-b-expected.png:
- platform/efl/svg/text/text-text-01-b-expected.png:
- platform/efl/svg/text/text-text-03-b-expected.png:
- platform/efl/svg/text/text-text-04-t-expected.png:
- platform/efl/svg/text/text-text-05-t-expected.png:
- platform/efl/svg/text/text-text-06-t-expected.png:
- platform/efl/svg/text/text-text-07-t-expected.png:
- platform/efl/svg/text/text-text-08-b-expected.png:
- platform/efl/svg/text/text-tref-01-b-expected.png:
- platform/efl/svg/text/text-tselect-01-b-expected.png:
- platform/efl/svg/text/text-tselect-02-f-expected.png:
- platform/efl/svg/text/text-tspan-01-b-expected.png:
- platform/efl/svg/text/text-ws-01-t-expected.png:
- platform/efl/svg/text/text-ws-02-t-expected.png:
- 6:00 AM Changeset in webkit [130753] by
-
- 5 edits in trunk
[Qt] Uploading images to Google+ using QtWebKit does not work.
https://bugs.webkit.org/show_bug.cgi?id=72329
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Implement handling of Blob FormData, including its extensions to the File FormData.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::appendBlobResolved):
(WebCore::FormDataIODevice::prepareFormElements):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::prepareCurrentElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
- platform/network/qt/QNetworkReplyHandler.h:
(FormDataIODevice):
LayoutTests:
Unskip the two BLOB tests that now passes. The rest of the BLOB tests unfortunately depend
on features we do not have.
- platform/qt/TestExpectations:
- 5:47 AM Changeset in webkit [130752] by
-
- 45 edits42 adds in trunk/LayoutTests
[Qt] Unskip and rebase now passing tests.
- platform/qt/TestExpectations:
- platform/qt/compositing/overflow/clip-descendents-expected.txt: Added.
- platform/qt/css1/formatting_model/floating_elements-expected.png:
- platform/qt/css1/formatting_model/floating_elements-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-expected.png:
- platform/qt/editing/selection/caret-ltr-2-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-left-expected.png:
- platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
- platform/qt/editing/selection/caret-ltr-expected.png:
- platform/qt/editing/selection/caret-ltr-expected.txt:
- platform/qt/editing/selection/caret-ltr-right-expected.png:
- platform/qt/editing/selection/caret-ltr-right-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-left-expected.png:
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
- platform/qt/editing/selection/caret-rtl-right-expected.png:
- platform/qt/editing/selection/caret-rtl-right-expected.txt:
- platform/qt/fast/backgrounds/size/zero-expected.png: Added.
- platform/qt/fast/backgrounds/size/zero-expected.txt:
- platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.png:
- platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
- platform/qt/fast/forms/basic-buttons-expected.png:
- platform/qt/fast/forms/basic-buttons-expected.txt:
- platform/qt/fast/multicol/overflow-across-columns-expected.png: Added.
- platform/qt/fast/multicol/overflow-across-columns-expected.txt: Added.
- platform/qt/fast/multicol/overflow-unsplittable-expected.png: Added.
- platform/qt/fast/multicol/overflow-unsplittable-expected.txt: Added.
- platform/qt/fast/multicol/positive-leading-expected.png: Added.
- platform/qt/fast/multicol/positive-leading-expected.txt: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/qt/fast/overflow/003-expected.png:
- platform/qt/fast/overflow/003-expected.txt:
- platform/qt/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
- platform/qt/fast/replaced/table-percent-height-expected.txt:
- platform/qt/fast/text/line-initial-and-final-swashes-expected.txt: Added.
- platform/qt/fonts/cursive-expected.png: Added.
- platform/qt/fonts/cursive-expected.txt: Added.
- platform/qt/fonts/default-expected.png: Added.
- platform/qt/fonts/default-expected.txt: Added.
- platform/qt/fonts/fantasy-expected.png: Added.
- platform/qt/fonts/fantasy-expected.txt: Added.
- platform/qt/fonts/monospace-expected.png: Added.
- platform/qt/fonts/monospace-expected.txt: Added.
- platform/qt/fonts/sans-serif-expected.png: Added.
- platform/qt/fonts/sans-serif-expected.txt: Added.
- platform/qt/fonts/serif-expected.png: Added.
- platform/qt/fonts/serif-expected.txt: Added.
- platform/qt/printing/page-count-relayout-shrink-expected.txt: Added.
- platform/qt/printing/return-from-printing-mode-expected.png: Added.
- platform/qt/printing/return-from-printing-mode-expected.txt: Added.
- platform/qt/printing/setPrinting-expected.png: Added.
- platform/qt/printing/setPrinting-expected.txt: Added.
- platform/qt/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
- platform/qt/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug10296-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug12384-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug12384-expected.txt:
- platform/qt/tables/mozilla/bugs/bug99948-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug99948-expected.txt:
- platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.png: Added.
- platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/qt/tables/mozilla/marvin/table_overflow_hidden_td-expected.png: Added.
- platform/qt/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png: Added.
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
- 4:55 AM Changeset in webkit [130751] by
-
- 3 edits in trunk/LayoutTests
[EFL] remove duplicate failure expectations
https://bugs.webkit.org/show_bug.cgi?id=98736
Unreviewed gardening.
Many tests are listed in both efl and wk2 expectations. Remove the efl expectations
in cases where the bug seems to be a wk2 issue.
Most expectations are also added into the efl-wk1 expectations (which is where
they should have been all along).
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-09
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 4:42 AM Changeset in webkit [130750] by
-
- 3 edits2 adds in trunk
Text decorations specified on the containing block are not properly applied when ::first-line is present.
https://bugs.webkit.org/show_bug.cgi?id=93829
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-09
Reviewed by Abhishek Arya.
Source/WebCore:
If a container's style and its pseudo :first-line style have unique
text-decorations specified for them, only the :first-line text-decoarations
were being applied.
The uploaded patch intends to first compute the text decoration colors
for the containing box, followed by that of the first-line (if specified).
This thus avoids the condition wherein our containing box's text-decorations
were not getting applied at all since initially we were only computing
for the first-line style.
Test: fast/css/text-decorations-on-first-line-and-containing-block.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
getTextDecorationColors() is first called for computing the containing box's
text-decoration values and then for first-line style's text-decorations,
if specified.
LayoutTests:
- fast/css/text-decorations-on-first-line-and-containing-block-expected.html: Added.
- fast/css/text-decorations-on-first-line-and-containing-block.html: Added.
Tests added for verifying the behavior of text-decorations when specified
both for the ::first-line as well as its containing block.
- 4:33 AM Changeset in webkit [130749] by
-
- 5 edits in trunk
Unreviewed, rolling out r130746.
http://trac.webkit.org/changeset/130746
https://bugs.webkit.org/show_bug.cgi?id=98749
It made 45 tests crash on Qt (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09
Source/WebCore:
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::getIODevice):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
- platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyHandler):
(FormDataIODevice):
LayoutTests:
- platform/qt/TestExpectations:
- 4:05 AM Changeset in webkit [130748] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening.
Skipping the accept-policy test in TestCookieManager API test that's
currently failing. The test failure is covered by
https://bugs.webkit.org/show_bug.cgi?id=98738.
- Scripts/run-gtk-tests:
(TestRunner):
- 3:49 AM Changeset in webkit [130747] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark a few tests skipped in r130745 as failures instead of timeouts.
- platform/efl/TestExpectations:
- 3:18 AM Changeset in webkit [130746] by
-
- 5 edits in trunk
[Qt] Uploading images to Google+ using QtWebKit does not work.
https://bugs.webkit.org/show_bug.cgi?id=72329
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Implement handling of Blob FormData, including its extensions to the File FormData.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::prepareCurrentElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::getIODevice):
(WebCore::QNetworkReplyHandler::handleBlobDataIfAny):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
- platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyHandler):
(FormDataIODevice):
LayoutTests:
Unskip the two BLOB tests that now passes. The rest of the BLOB tests unfortunately depend
on features we do not have.
- platform/qt/TestExpectations:
- 2:44 AM Changeset in webkit [130745] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip a few tests after r130699.
- platform/efl/TestExpectations:
- 2:35 AM Changeset in webkit [130744] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove comment added in r130650 now that I've run the GTK+ tests.
- platform/efl-wk1/TestExpectations:
- 2:18 AM Changeset in webkit [130743] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding more failure expectations for regressions after r130699.
- platform/gtk/TestExpectations:
- 2:11 AM Changeset in webkit [130742] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unskip now passing tests.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 2:09 AM Changeset in webkit [130741] by
-
- 2 edits in trunk/LayoutTests
[Qt] /editing/selection/caret-bidi-first-and-last-letters.html fails
https://bugs.webkit.org/show_bug.cgi?id=51884
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Ryosuke Niwa.
This test pass with this change in testfonts https://gitorious.org/qtwebkit/testfonts/merge_requests/1
- platform/qt/TestExpectations:
- 2:04 AM Changeset in webkit [130740] by
-
- 2 edits in trunk/LayoutTests
[Qt] editing/selection/caret-at-bidi-boundary.html fails
https://bugs.webkit.org/show_bug.cgi?id=66514
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Yuta Kitamura.
Unskipping test. The update in testfonts solved this bug.
- platform/qt/TestExpectations:
- 1:55 AM Changeset in webkit [130739] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unskip and rebase a now passing test.
- platform/qt/TestExpectations:
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- 1:50 AM Changeset in webkit [130738] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unskip fast/transforms/scrollIntoView-transformed.html.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 1:46 AM Changeset in webkit [130737] by
-
- 7 edits in trunk/LayoutTests
[Qt] Unskip and rebase now passing tests.
- platform/qt-5.0/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- 1:37 AM Changeset in webkit [130736] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for regressions after r130699 and
a failing multipart test introduced in r130651.
- platform/gtk/TestExpectations:
- 1:27 AM Changeset in webkit [130735] by
-
- 10 edits1 add1 delete in trunk/LayoutTests
[Qt] Unskip and rebasing now passing tests.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/fast/css/word-space-extra-expected.png:
- platform/qt/fast/css/word-space-extra-expected.txt:
- platform/qt/fast/history/history-back-initial-vs-final-url-expected.txt: Added.
- platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
- platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/qt/http/tests/navigation/postredirect-frames-expected.txt:
- platform/qt/http/tests/navigation/postredirect-goback2-expected.txt:
- 1:17 AM Changeset in webkit [130734] by
-
- 15 edits3 adds in trunk
Page popup should be smarter about its layout
https://bugs.webkit.org/show_bug.cgi?id=98499
Reviewed by Kent Tamura.
Source/WebCore:
This change fixes these two issues:
- Page popup should reposition itself so it won't get clipped by screen(Win/Linux) or rootview(Mac) bounds.
- Page popup should resize itself when it doesn't fit.
Test: platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html
- Resources/pagepopups/calendarPicker.js:
(initialize): We need to set global.params at the beginning because we need it for resizeWindow().
- Resources/pagepopups/colorSuggestionPicker.js: Added global.params.
(handleMessage):
(initialize):
(handleArgumentsTimeout):
- Resources/pagepopups/pickerCommon.js:
(Rect): Represents an axis aligned rectangle.
(Rect.prototype.get maxX): Gets position of right edge.
(Rect.prototype.get maxY): Gets position of bottom edge.
(Rect.prototype.toString):
(Rect.intersection): Returns the intersection of two rectangles.
(resizeWindow): Resize window to a certain size. Don't allow shrinking.
(adjustWindowRect): Calculates the best position and size for the popup.
(_adjustWindowRectVertically):
(_adjustWindowRectHorizontally):
(setWindowRect): Sets the position and size of the popup to the given rect.
- Resources/pagepopups/suggestionPicker.css:
(.suggestion-list): Don't show horizontal scroll bar.
- Resources/pagepopups/suggestionPicker.js:
(SuggestionPicker.prototype._fixWindowSize):
- page/PagePopupClient.cpp:
(WebCore::PagePopupClient::addProperty): For adding an int to JSON.
(WebCore::PagePopupClient::addProperty): For adding an IntRect to JSON.
(WebCore):
- page/PagePopupClient.h:
(PagePopupClient):
Source/WebKit/chromium:
- src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::init): We keep the originBoundsInRootView argument for MockPagePopupDriver.
(WebKit::WebPagePopupImpl::resize): WebPagePopupImpl isn't in charge of setting the popup position any more.
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
LayoutTests:
- platform/chromium/fast/forms/page-popup/page-popup-adjust-rect-expected.txt: Added.
- platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Added.
- platform/chromium-android/TestExpectations: Added platform/chromium/fast/forms/page-popup.
- 1:07 AM Changeset in webkit [130733] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip now passing tests.
- platform/qt/TestExpectations:
- 1:00 AM Changeset in webkit [130732] by
-
- 9 edits2 adds in trunk/Source/WebCore
[Refactoring] Scoped Style related code should have its own class.
https://bugs.webkit.org/show_bug.cgi?id=98244
Reviewed by Dimitri Glazkov.
This change extracts StyleScopeResolver from StyleResolver to clarify
the responsibility of the style scope handling. Now we can easily see
where the style scoping needs to be involed.
Coming Shadow DOM related change like @host rules will fit within this class.
No new tests, refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(StyleResolver):
- css/StyleScopeResolver.cpp: Added.
(WebCore):
(WebCore::StyleScopeResolver::StyleScopeResolver):
(WebCore::StyleScopeResolver::~StyleScopeResolver):
(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::ruleSetFor):
(WebCore::StyleScopeResolver::ensureRuleSetFor):
(WebCore::StyleScopeResolver::setupStack):
(WebCore::StyleScopeResolver::push):
(WebCore::StyleScopeResolver::pop):
(WebCore::StyleScopeResolver::collectFeaturesTo):
(WebCore::StyleScopeResolver::reportMemoryUsage):
- css/StyleScopeResolver.h: Added.
(WebCore):
(StyleScopeResolver):
(WebCore::StyleScopeResolver::StackFrame::StackFrame):
(StackFrame):
(WebCore::StyleScopeResolver::hasScopedStyles):
(WebCore::StyleScopeResolver::stackSize):
(WebCore::StyleScopeResolver::stackFrameAt):
(WebCore::StyleScopeResolver::matchesStyleBounds):
(WebCore::StyleScopeResolver::stackIsConsistent):
(WebCore::StyleScopeResolver::ensureStackConsistency):
(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::ensureRuleSetFor):
- 12:58 AM Changeset in webkit [130731] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip now passing tests.
- platform/qt/TestExpectations:
- 12:50 AM Changeset in webkit [130730] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unskip now passing tests.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0/TestExpectations:
- 12:40 AM Changeset in webkit [130729] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need API to control the DNS Prefetching
https://bugs.webkit.org/show_bug.cgi?id=98713
Reviewed by George Staikos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::enableDNSPrefetch):
(WebKit):
(BlackBerry::WebKit::WebPage::disableDNSPrefetch):
(BlackBerry::WebKit::WebPage::isDNSPrefetchEnabled):
- Api/WebPage.h:
- 12:22 AM Changeset in webkit [130728] by
-
- 2 edits in trunk/Tools
[Qt] Remove redundant JAVASCRIPTCORE_JIT variable
https://bugs.webkit.org/show_bug.cgi?id=50000
Patch by Laszlo Gombos <Laszlo Gombos> on 2012-10-09
Reviewed by Simon Hausmann.
Use ENABLE_JIT instead.
- qmake/mkspecs/features/valgrind.prf:
- 12:18 AM Changeset in webkit [130727] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gadening after r130709.
- fast/harness/results-expected.txt:
- 12:12 AM Changeset in webkit [130726] by
-
- 67 edits2 moves in trunk/Source/JavaScriptCore
Renamed RegisterFile to JSStack, and removed prototype of the
previously deleted Interpreter::privateExecute().
https://bugs.webkit.org/show_bug.cgi?id=98717.
Reviewed by Filip Pizlo.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/BytecodeConventions.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::alreadyInJSStack):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedCell):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedBoolean):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedDouble):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGGenerationInfo.h:
(GenerationInfo):
(JSC::DFG::GenerationInfo::needsSpill):
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::beginCall):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::spill):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::virtualForThunkGenerator):
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::isInJSStack):
(JSC::DFG::ValueSource::forSpeculation):
(JSC::DFG::ValueSource::isInJSStack):
(JSC::DFG::ValueSource::valueRecovery):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- heap/Heap.cpp:
(JSC::Heap::stack):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
- heap/Heap.h:
(JSC):
(Heap):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::stack):
- interpreter/CallFrame.h:
(JSC::ExecState::calleeAsValue):
(JSC::ExecState::callee):
(JSC::ExecState::codeBlock):
(JSC::ExecState::scope):
(JSC::ExecState::callerFrame):
(JSC::ExecState::returnPC):
(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::inlineCallFrame):
(JSC::ExecState::codeOriginIndexForDFG):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScope):
(JSC::ExecState::init):
(JSC::ExecState::argumentCountIncludingThis):
(JSC::ExecState::offsetFor):
(JSC::ExecState::setArgumentCountIncludingThis):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock):
(JSC::ExecState::setReturnPC):
(JSC::ExecState::setInlineCallFrame):
(ExecState):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::slideRegisterWindowForCall):
(JSC::eval):
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::endRepeatCall):
- interpreter/Interpreter.h:
(JSC::Interpreter::stack):
(Interpreter):
(JSC::Interpreter::execute):
(JSC):
- interpreter/JSStack.cpp: Copied from Source/JavaScriptCore/interpreter/RegisterFile.cpp.
(JSC::stackStatisticsMutex):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::initializeThreading):
(JSC::JSStack::committedByteCount):
(JSC::JSStack::addToCommittedByteCount):
- interpreter/JSStack.h: Copied from Source/JavaScriptCore/interpreter/RegisterFile.h.
(JSStack):
(JSC::JSStack::JSStack):
(JSC::JSStack::shrink):
(JSC::JSStack::grow):
- interpreter/RegisterFile.cpp: Removed.
- interpreter/RegisterFile.h: Removed.
- interpreter/VMInspector.cpp:
(JSC::VMInspector::dumpFrame):
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC):
(JIT):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
- jit/JITCode.h:
(JSC):
(JSC::JITCode::execute):
- jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
(JSC::JIT::emitPutImmediateToCallFrameHeader):
(JSC::JIT::emitGetFromCallFrameHeaderPtr):
(JSC::JIT::emitGetFromCallFrameHeader32):
(JSC::JIT::updateTopCallFrame):
(JSC::JIT::unmap):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::emit_op_resolve_global_dynamic):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
- jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::JITThunks::JITThunks):
(JSC):
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC):
(JITStackFrame):
- jit/JSInterfaceJIT.h:
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::genericCall):
- llint/LLIntSlowPaths.h:
(LLInt):
- llint/LowLevelInterpreter.asm:
- runtime/Arguments.cpp:
(JSC::Arguments::tearOffForInlineCallFrame):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::globalExec):
- runtime/JSGlobalObject.h:
(JSC):
(JSGlobalObject):
- runtime/JSLock.cpp:
(JSC):
- runtime/JSVariableObject.h:
(JSVariableObject):
- runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):
- 12:10 AM Changeset in webkit [130725] by
-
- 2 edits in trunk
Unreviewed GTK build fix after r130689.
Adding a required symbol to symbols.filter.
- Source/autotools/symbols.filter:
- 12:06 AM Changeset in webkit [130724] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unskip now passing tests.
- platform/qt-5.0-wk2/TestExpectations:
- 12:06 AM Changeset in webkit [130723] by
-
- 6 edits4 moves4 adds in trunk/Source
[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=98268
Reviewed by Tor Arne Vestbø.
Source/WebCore:
Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.
QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.
RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.
The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.
The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.
RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.
- Target.pri:
- platform/qt/QStyleFacade.cpp: Added.
(WebCore):
(WebCore::QStyleFacade::styleForPage):
- platform/qt/QStyleFacade.h: Added.
(WebCore):
(QStyleFacade):
(WebCore::QStyleFacade::~QStyleFacade):
(WebCore::QStyleFacadeOption::QStyleFacadeOption):
(QStyleFacadeOption):
- platform/qt/RenderThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::setStyleFactoryFunction):
(WebCore::RenderThemeQStyle::styleFactory):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
- platform/qt/RenderThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(WebCore::RenderThemeQStyle::qStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::paintButton):
(WebCore::StylePainterQStyle::paintTextField):
(WebCore::StylePainterQStyle::paintComboBox):
(WebCore::StylePainterQStyle::paintComboBoxArrow):
(WebCore::StylePainterQStyle::paintSliderTrack):
(WebCore::StylePainterQStyle::paintSliderThumb):
(WebCore::StylePainterQStyle::paintInnerSpinButton):
(WebCore::StylePainterQStyle::paintProgressBar):
(WebCore::StylePainterQStyle::paintScrollCorner):
(WebCore::StylePainterQStyle::paintScrollBar):
- platform/qt/ScrollbarThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::initSliderStyleOption):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
- platform/qt/ScrollbarThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.h.
(WebCore):
(ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::qStyle):
Source/WebKit:
- WebKit1.pro: Add new files to the build.
Source/WebKit/qt:
Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.
QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.
RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.
The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.
The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.
RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- WebCoreSupport/QStyleFacadeImp.cpp: Added.
(WebKit):
(WebKit::convertToQStyleState):
(WebKit::convertToQStyleSubControl):
(WebKit::initGenericStyleOption):
(WebKit::initSpecificStyleOption):
(MappedStyleOption):
(WebKit::MappedStyleOption::MappedStyleOption):
(WebKit::convertPixelMetric):
(WebKit::convertToQStyleFacadeSubControl):
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
(WebKit::QStyleFacadeImp::buttonSubElementRect):
(WebKit::QStyleFacadeImp::findFrameLineWidth):
(WebKit::QStyleFacadeImp::simplePixelMetric):
(WebKit::QStyleFacadeImp::buttonMargin):
(WebKit::QStyleFacadeImp::sliderLength):
(WebKit::QStyleFacadeImp::sliderThickness):
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::sizeFromContents):
(WebKit::QStyleFacadeImp::paintButton):
(WebKit::QStyleFacadeImp::paintTextField):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
(WebKit::QStyleFacadeImp::paintSliderTrack):
(WebKit::QStyleFacadeImp::paintSliderThumb):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintProgressBar):
(WebKit::QStyleFacadeImp::scrollBarExtent):
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
(WebKit::QStyleFacadeImp::paintScrollCorner):
(WebKit::QStyleFacadeImp::hitTestScrollBar):
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
(WebKit::QStyleFacadeImp::paintScrollBar):
(WebKit::QStyleFacadeImp::widgetForPainter):
(WebKit::QStyleFacadeImp::style):
- WebCoreSupport/QStyleFacadeImp.h: Added.
(WebCore):
(WebKit):
(QStyleFacadeImp):
(WebKit::QStyleFacadeImp::create):
(WebKit::QStyleFacadeImp::isValid):
- 12:01 AM TestExpectations edited by
- Fix spelling errors (diff)
Oct 8, 2012:
- 11:35 PM Changeset in webkit [130722] by
-
- 2 edits in trunk/LayoutTests
[Qt]REGRESSION(r128699): It made 2 fast/js/dfg tests assert
https://bugs.webkit.org/show_bug.cgi?id=96907
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Csaba Osztrogonác.
Unskipping tests.
- platform/qt/TestExpectations:
- 11:11 PM FeatureFlags edited by
- Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature flag. (diff)
- 11:01 PM Changeset in webkit [130721] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710
Reviewed by Kent Tamura.
Source/WebCore:
This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.
HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.
Test: fast/forms/select/select-typeahead-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.
LayoutTests:
This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.
- fast/forms/select/select-typeahead-crash-expected.txt: Added.
- fast/forms/select/select-typeahead-crash.html: Added.
TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11088020
- 10:45 PM Changeset in webkit [130720] by
-
- 42 edits2 adds in trunk
Throttle DOM timers on hidden pages.
https://bugs.webkit.org/show_bug.cgi?id=98474
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-08
Reviewed by Maciej Stachowiak.
Source/JavaScriptCore:
Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
When the visibility of a page changes to "hidden", all it's DOM timers are
updated to align their fire times on one second intervals. This limits the
number of CPU wakes due to a hidden pages to one per second.
Test: fast/dom/timer-throttling-hidden-page.html
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore):
(WebCore::Document::timerAlignmentInterval):
Read Page::timerAlignmentInterval and pass it along to DOMTimer.
- dom/Document.h:
(Document):
- dom/ScriptExecutionContext.cpp:
(WebCore):
(WebCore::ScriptExecutionContext::didChangeTimerAlignmentInterval):
Scan through self DOM Timers and tell them to recompute their fire
time based on the updated alignment interval.
(WebCore::ScriptExecutionContext::timerAlignmentInterval):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
- page/DOMTimer.cpp:
(WebCore):
(WebCore::DOMTimer::alignedFireTime):
If the document's alignment interval is non zero, round up the fire
time to the next multiple of alignment interval.
- page/DOMTimer.h:
(DOMTimer):
(WebCore::DOMTimer::defaultTimerAlignmentInterval):
(WebCore::DOMTimer::setDefaultTimerAlignmentInterval):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore):
(WebCore::Page::setTimerAlignmentInterval):
(WebCore::Page::timerAlignmentInterval):
(WebCore::Page::setVisibilityState):
Getter and Setter for alignment interval. Expose setVisibilityState
if either PAGE_VISIBILITY_API is enabled or if HIDDEN_PAGE_DOM_TIMER_REDUCTION
is enabled.
- page/Page.h:
(Page):
- page/Settings.cpp:
(WebCore):
(WebCore::Settings::setDefaultDOMTimerAlignmentInterval):
(WebCore::Settings::defaultDOMTimerAlignmentInterval):
(WebCore::Settings::setDOMTimerAlignmentInterval):
(WebCore::Settings::domTimerAlignmentInterval):
- page/Settings.h:
(Settings):
- page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::suspend):
Save the time remaining to the original unaligned fire time, so that
on resuming, the fire time will be correctly aligned using the latest
alignment interval.
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::sharedTimerFiredInternal):
Clear m_unalignedNextFireTime along with m_nextFireTime to keep
them always in sync.
- platform/Timer.cpp:
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::setNextFireTime):
Save the requested fire time in m_unalignedNextFireTime and
set m_nextFireTime to the aligned value. The unalinged value
is used to recompute fire time if alignment interval changes.
(WebCore):
(WebCore::TimerBase::didChangeAlignmentInterval):
Recompute next fire time from m_unalignedNextFireTime.
(WebCore::TimerBase::nextUnalignedFireInterval):
Interval from current time to the original unaligned fire time.
- platform/Timer.h:
(TimerBase):
(WebCore::TimerBase::alignedFireTime):
Source/WebKit/mac:
Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define and provide a SPI for
DumpRenderTree to modify the visibility state of a page. The latter
is needed to test throttling of timers on hidden pages through DumpRenderTree.
- Configurations/FeatureDefines.xcconfig:
- WebView/WebView.mm:
(-[WebView _setVisibilityState:isInitialState:]):
- WebView/WebViewPrivate.h:
Source/WebKit2:
Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define. Use existing code of
PAGE_VISIBILITY_API to detect changes to page visibility state.
- Configurations/FeatureDefines.xcconfig:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Check visibility state on construction.
(WebKit::WebPageProxy::initializeWebPage):
Send initial visibility state message if HIDDEN_PAGE_DOM_TIMER_THROTTLING
is enabled or if PAGE_VISIBILITY_API is enabled.
(WebKit::WebPageProxy::viewStateDidChange):
When PAGE_VISIBILITY_API is not enabled, compare new visibility against
WebPageProxy::m_isVisible, to minimize number of messages sent.
Remove unnecessary second call to PageClient::isViewVisible for updating
visibility state.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPageVisibilityState):
WebKitTestRunner uses this method to implement testRunner.setPageVisibility(),
hence enable it for testing hidden page timer throttling as well.
- WebProcess/WebPage/WebPage.cpp:
(WebKit):
(WebKit::WebPage::setVisibilityState):
Ensure Page::setVisibilityState is called either if PAGE_VISIBILITY_API is
enabled or if HIDDEN_PAGE_DOM_TIMER_THROTTLING is enabled.
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Implement testRunner.setPageVisibility on mac for testing throttling
of timers on hidden pages using DumpRenderTree.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
Fix build error on mac-ews bot. Add JSC copy of ICU headers to search path.
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
WebKitLibraries:
Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
Add a test for DOM timer throttling on hidden pages.
- fast/dom/timer-throttling-hidden-page-expected.txt: Added.
- fast/dom/timer-throttling-hidden-page.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
Skip the test since HIDDEN_PAGE_DOM_TIMER_THROTTLING is not enabled by default.
- 10:31 PM Changeset in webkit [130719] by
-
- 1 edit2 copies in branches/chromium/1229
Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710
Reviewed by Kent Tamura.
Source/WebCore:
This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.
HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.
Test: fast/forms/select/select-typeahead-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.
LayoutTests:
This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.
- fast/forms/select/select-typeahead-crash-expected.txt: Added.
- fast/forms/select/select-typeahead-crash.html: Added.
TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11091018
- 10:12 PM Changeset in webkit [130718] by
-
- 3 edits in trunk/Source/WebCore
1.18MB below RenderTableSection::setCachedCollapsedBorderValue() on Membuster3.
<http://webkit.org/b/98670>
<rdar://problem/12454276>
Reviewed by Anders Carlsson.
Refactor CollapsedBorderValue to only store the bits and pieces from the BorderValue
that it actually needs. Packed the whole thing into 64 bits.
Reduces memory consumption by 547kB on Membuster3.
- rendering/RenderTableCell.cpp:
Add compile-time size assertion for CollapsedBorderValue.
- rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::isSameIgnoringColor):
(CollapsedBorderValue):
Apply shrinkwrap to CollapsedBorderValue. Removed specialized copy constructor since
the class only has primitive members now.
- 9:47 PM Changeset in webkit [130717] by
-
- 3 edits2 adds in trunk
HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710
Reviewed by Kent Tamura.
Source/WebCore:
This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.
HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.
Test: fast/forms/select/select-typeahead-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.
LayoutTests:
This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.
- fast/forms/select/select-typeahead-crash-expected.txt: Added.
- fast/forms/select/select-typeahead-crash.html: Added.
- 7:18 PM Changeset in webkit [130716] by
-
- 3 edits2 adds in trunk
Take account of overflowing values for width calculation of a year sub-field
https://bugs.webkit.org/show_bug.cgi?id=98506
Reviewed by Eric Seidel.
Source/WebCore:
When we decide the width of a year field of an input[type=date]
with the multiple fields UI, we need to take account of the
current value width because we allow to set overflowing values to
the input[type=date].
This change affects only platforms with INPUT_TYPE_DATE &&
INPUT_MULTIPLE_FIELDS_UI.
Test: fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Take account of the current value width.
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Added.
- 6:52 PM Changeset in webkit [130715] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium DEPS roll r160657:160764.
Unreviewed.
- DEPS:
- 6:52 PM Changeset in webkit [130714] by
-
- 5 edits2 adds in trunk
image not displayed in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98611
Reviewed by Ojan Vafai.
Source/WebCore:
Flexbox will override the width of a child and when stretching, will override the height of the child.
When this happens, when an image loads, it checks to see if it's width/height has
changed, and if so, does a relayout. The overridden width/height was preventing this
relayout from happening.
To fix, we clear all the override sizes when we're done laying out the flex children.
Test: css3/flexbox/relayout-image-load.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Clear child override sizes.
(WebCore::RenderFlexibleBox::clearChildOverrideSizes):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): No longer need to clear the override size
here since it should have already been cleared.
- rendering/RenderFlexibleBox.h:
LayoutTests:
Load an image after flexbox layout has happened.
- css3/flexbox/relayout-image-load-expected.txt: Added.
- css3/flexbox/relayout-image-load.html: Added.
- platform/chromium/TestExpectations: Remove css3/flexbox/flexitem-stretch-image.html
since it should no longer be flaky.
- 6:48 PM Changeset in webkit [130713] by
-
- 2 edits in trunk/PerformanceTests
Skip Layout/subtree-detaching.html temporarily as it's very noisy and
takes 112s to run on Chromium Mac. This is tracked by the bug 98708.
- Skipped:
- 6:44 PM Changeset in webkit [130712] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r130643): editing/pasteboard/data-transfer-item is failing on chromium.
<http://webkit.org/b/98686>
Reviewed by Tony Chang.
Change ChromiumDataObject::createFromPasteboard() to use a ListHashSet instead of a HashSet so that
item order is preserved.
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createFromPasteboard):
- 6:43 PM Changeset in webkit [130711] by
-
- 2 edits in trunk/PerformanceTests
Perf. test results page is broken when runs have different sets of tests
https://bugs.webkit.org/show_bug.cgi?id=98691
Reviewed by Daniel Bates.
Add "missing" columns for tests that are missing some runs.
Also fix regressions from the previous patch:
- Make reference run switch work again
- Load jquery plugins from the remote server when the jquery is loaded from the remote server.
- resources/results-template.html:
- 6:39 PM Changeset in webkit [130710] by
-
- 3 edits in trunk/Source/WebCore
Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html
https://bugs.webkit.org/show_bug.cgi?id=98703
Reviewed by Emil A Eklund.
This is very small potatoes. There are much bigger wins for table layout yet, but
this was an easy win.
This function should probably be converted to use int's only, as table cells are pixel-sized
according to our subpixel-experts.
Also, I suspect there should be ways to early return with less-math in the common cases, but
I've saved such for a later patch.
Note that I changed from using paddingBefore/paddingAfter (which include the instrinsic padding)
to calling computedCSSPaddingBefore/computedCSSPaddingAfter directly as well.
This single function is about 11% of total time for robohornet's resizecol.
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
- 6:36 PM Changeset in webkit [130709] by
-
- 6 edits in trunk
results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
https://bugs.webkit.org/show_bug.cgi?id=98706
Reviewed by Ojan Vafai.
FAIL is supposed to map onto Failure which is supposed to map
onto the old [ TEXT, IMAGE_PLUS_TEXT, AUDIO ] mapping.
results.html was including IMAGE in this and garden-o-matic was
including CRASH and TIMEOUT as well :(.
Tools:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
LayoutTests:
- fast/harness/resources/results-test.js:
- fast/harness/results.html:
- 6:17 PM Changeset in webkit [130708] by
-
- 22 edits in trunk/Source
IndexedDB: remove autogenerated objectStore/index id code
https://bugs.webkit.org/show_bug.cgi?id=98085
Reviewed by Tony Chang.
Source/WebCore:
Remove support for backend-generated objectstore and index
ids. The frontend objects now manage that state during
versionchange transactions. The IDBDatabaseBackendInterface and
IDBObjectStoreBackendInterface methods will go away when
https://bugs.webkit.org/show_bug.cgi?id=98682 lands.
No new tests as this is part of a refactoring, existing indexeddb
tests cover correctness.
- Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
- Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
Source/WebKit/chromium:
Remove support for unused createObjectStore/createIndex. These
methods will go away entirely when
https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed.
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::createObjectStore):
- src/WebIDBDatabaseImpl.cpp:
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
- src/WebIDBObjectStoreImpl.cpp:
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
- 5:59 PM Changeset in webkit [130707] by
-
- 2 edits in trunk/Tools
[EFL] Build ControlTheme only when necessary
https://bugs.webkit.org/show_bug.cgi?id=98519
Reviewed by Eric Seidel.
- EWebLauncher/ControlTheme/CMakeLists.txt:
Added custom command keyword not to build ControlTheme every time.
In addition, removedALLkeyword because targets, which use ControlTheme,
already have dependency.
- 5:55 PM Changeset in webkit [130706] by
-
- 2 edits in trunk/Source/WebCore
[CAIRO] Adjust the source rect size when IMAGE_DECODER_DOWN_SAMPLING is enabled
https://bugs.webkit.org/show_bug.cgi?id=98630
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-08
Reviewed by Martin Robinson.
IMAGE_DECODER_DOWN_SAMPLING scales down the size of the big image.
CAIRO needs to adjust the source size to the scaled value.
No new tests.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw):
- 5:08 PM Changeset in webkit [130705] by
-
- 6 edits in trunk/Source/WebCore
Remove unused features of BlobBuilder
https://bugs.webkit.org/show_bug.cgi?id=98331
Reviewed by Eric Seidel.
Now that we don't expose BlobBuilder as a web platform API, we can
strip down the class to handle only those cases that are needed by the
Blob constructor.
I've also renamed the class from WebKitBlobBuilder to BlobBuilder and
made it stack allocated rather than RefCounted. A future patch will
actually move the files around. (I didn't want to mix moving code
around with modifying the code.)
- bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
- fileapi/WebKitBlobBuilder.cpp:
(WebCore):
(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::getBuffer):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::appendBytesData):
(WebCore::BlobBuilder::getBlob):
- fileapi/WebKitBlobBuilder.h:
(WebCore):
(BlobBuilder):
- page/FeatureObserver.h:
- 5:02 PM Changeset in webkit [130704] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the debug build after r130699
Move the assignment of the ResourceHandleInternal local to before
the include statement where it is used.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):
- 4:33 PM Changeset in webkit [130703] by
-
- 2 edits in trunk/Tools
Do not swallow fatal messages in qt/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=98211
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.
Fix condition in message type filtering.
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(messageHandler):
- 4:31 PM Changeset in webkit [130702] by
-
- 164 edits73 adds in trunk/LayoutTests
Not reviewed. Rebaselines for Chromium.
Rebaseline after r130412 which affected image scaling pixel tests.
- platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize15-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-slice-constrained-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png:
- platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/pointer-events-image-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/fast/borders/border-image-slice-constrained-expected.png: Added.
- platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png:
- platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
- platform/chromium-linux/fast/repaint/background-misaligned-expected.png:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
- platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png:
- platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-slice-constrained-expected.png:
- platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-expected.png:
- platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
- platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac/fast/repaint/background-misaligned-expected.png:
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win-xp/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
- platform/chromium-win-xp/fast/backgrounds/size/backgroundSize15-expected.png: Added.
- platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/chromium-win-xp/fast/borders/border-image-scale-transform-expected.png: Added.
- platform/chromium-win-xp/fast/borders/border-image-scaled-expected.png: Added.
- platform/chromium-win-xp/fast/borders/border-image-slice-constrained-expected.png: Added.
- platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/chromium-win-xp/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png:
- platform/chromium-win-xp/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
- platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
- platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-win-xp/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium-win-xp/svg/custom/image-small-width-height-expected.png: Added.
- platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/chromium-win-xp/svg/custom/pointer-events-image-expected.png: Added.
- platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png:
- platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png:
- platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
- platform/chromium-win/fast/borders/scaled-border-image-expected.png:
- platform/chromium-win/fast/repaint/background-misaligned-expected.png:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-win/svg/custom/image-small-width-height-expected.png:
- platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-win/svg/custom/pointer-events-image-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium/TestExpectations:
- 4:24 PM Changeset in webkit [130701] by
-
- 4 edits in trunk/Source
Versioning.
- 4:20 PM Changeset in webkit [130700] by
-
- 2 edits in trunk/Source/WebCore
Post-r130226 Cleanup: Comment a complicated if statement and make it a helper.
https://bugs.webkit.org/show_bug.cgi?id=98463
Reviewed by Eric Seidel.
No new tests, refactor only.
- rendering/RenderLayer.cpp:
(WebCore::frameElementAndViewPermitScroll):
(WebCore::RenderLayer::scrollRectToVisible):
- 4:12 PM Changeset in webkit [130699] by
-
- 5 edits in trunk/Source/WebCore
[Soup] Simplify the way that requests are started
https://bugs.webkit.org/show_bug.cgi?id=98532
Reviewed by Gustavo Noronha Silva.
Simplify the creation of the libsoup request and message when kicking off
requests, by elminating a bit of duplicate code.
No new tests. This should not change any behavior.
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::ResourceHandleInternal::soupSession): Ensure the session
is initialized when passing it to the caller.
(WebCore::createSoupMessageForHandleAndRequest): Added this helper which
takes care of creating the SoupMessage for HTTP/HTTPS requests.
(WebCore::createSoupRequestAndMessageForHandle): Collapsed the HTTP and
non-HTTP request creation into this helper.
(WebCore::ResourceHandle::start): Call the new helper now and then sendPendingRequest.
(WebCore::ResourceHandle::sendPendingRequest): Instead of having special
helpers to create and send the request, duplicating the logic for sending it
across the file, add this method which can be used in both cases.
(WebCore::waitingToSendRequest): Reworked the hasBeenSent method to answer
the question of whether or not the request is ready to be sent, but is unsent.
(WebCore::ResourceHandle::platformSetDefersLoading): Use the new helper.
- platform/network/soup/ResourceRequest.h:
(ResourceRequest): Added a new method for getting the URL string for soup.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::urlStringForSoup): Added.
- 3:59 PM Changeset in webkit [130698] by
-
- 5 edits in trunk/Source/WebCore
Make no-column table-layout cases a little faster with inlining
https://bugs.webkit.org/show_bug.cgi?id=98566
Reviewed by Julien Chaffraix.
This change is almost not worth it at only a couple percent boost on
http://www.robohornet.org/tests/resizecol.html
However, I think the logicalWidthFromTableColumn split it kinda nice
so I've decided to post it anyway.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::slowColElement):
- rendering/RenderTable.h:
(WebCore::RenderTable::colElement):
(RenderTable):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalWidthFromTableColumn):
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleOrColLogicalWidth):
(RenderTableCell):
- 3:58 PM BuildingOnWindows edited by
- (diff)
- 3:58 PM Changeset in webkit [130697] by
-
- 8 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
- platform/chromium/TestExpectations:
Marked a test as crashing on Lion.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
Rebaselined these tests after a change in Chromium compositor (Chromium r160671).
- 3:41 PM Changeset in webkit [130696] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself from Committer to Reviewer list.
http://lists.webkit.org/pipermail/webkit-dev/2012-October/022460.html
- Scripts/webkitpy/common/config/committers.py:
- 3:31 PM Changeset in webkit [130695] by
-
- 8 edits in trunk/Source/WTF
Generalize moving URLComponent's begin position
https://bugs.webkit.org/show_bug.cgi?id=98626
Reviewed by Adam Barth.
The patch r130609 introduced moving URLComponents's position.
It turns out this concept is really useful in the parser so
this patch generalize the idea.
- wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::removePort):
- wtf/url/src/URLCanonEtc.cpp:
- wtf/url/src/URLComponent.h:
(WTF::URLComponent::moveBy):
Rename URLComponent::move() to URLComponent::moveBy() for consistency
with some of WebCore types.
- wtf/url/src/URLParse.cpp:
- wtf/url/src/URLParseFile.cpp:
- wtf/url/src/URLSegments.cpp:
(WTF::URLSegments::moveFromComponentBy):
Change the semantic to everything from a certain component. This is
useful to move everything, including the scheme.
- wtf/url/src/URLSegments.h:
(URLSegments):
- 3:30 PM Changeset in webkit [130694] by
-
- 3 edits in trunk/Source/WebCore
Rename RenderObject::firstLineStyleSlowCase() to a more appropriate cachedFirstLineStyle()
https://bugs.webkit.org/show_bug.cgi?id=98631
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.
Renaming firstLineStyleSlowCase() to cachedFirstLineStyle().
The current name is confusing since the function actually gets the
the cached first-line styles.
It also makes the name more descriptive of its functionality
and in accordance with RenderObject::uncachedFirstLineStyle().
No new tests required for this change since no change in behavior is expected.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::cachedFirstLineStyle):
- rendering/RenderObject.h:
(WebCore::RenderObject::firstLineStyle):
(RenderObject):
Renamed RenderObject::firstLineStyleSlowCase() to cachedFirstLineStyle()
and made the associated changes.
- 3:22 PM Changeset in webkit [130693] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix Windows build by exporting Frame::layerTreeAsText().
- win/WebKit2.def:
- 3:15 PM Changeset in webkit [130692] by
-
- 4 edits1 add in trunk/Source
Some non-scrollable elements are added to non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=97927
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-08
Reviewed by James Robinson.
Source/WebCore:
Only RenderLayers that can actually be scrolled should be added to the
ScrollingCoordinator's non-fast scrollable region. Otherwise we may
needlessly fall back to main thread scrolling.
Test: ScrollingCoordinatorChromiumTest.clippedBodyTest
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
Source/WebKit/chromium:
Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable
region.
The test in this patch consists of a web page where both the html and
body elements clip horizontal overflow. This results in a hierarchy
where the body element gets a scrollable RenderLayer. However, that
layer isn't (interactively) scrollable because while the scroll geometry
is calculated based on the amount of overflow, the scroll bars are
hidden because of the "overflow-x: hidden" style.
Previously this layer would have made the entire page part of the
non-fast scrollable region. With this patch,
RenderLayer::allowScrolling() is used as a pre-requisite for expanding
the region, thus avoiding the problem.
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::TEST_F):
(WebKit):
- tests/data/clipped-body.html: Added.
- 3:07 PM Changeset in webkit [130691] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
Mac Chromium: Ignore system numpad modifier
https://bugs.webkit.org/show_bug.cgi?id=97161
Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-08
Reviewed by Tony Chang.
On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms.
My fix is to only rely on keycode to decide when to set the numpad modifier.
This code is not exersided by layout tests so I added a new unit test for this.
- WebKit.gypi:
- WebKitUnitTests.gyp:
- src/mac/WebInputEventFactory.mm:
(WebKit::isKeypadEvent): Removed check for numpad modifier.
- tests/WebInputEventFactoryTestMac.mm: Added.
(TEST): Added new test for WebInputEventFactory::keyboardEvent().
- 3:06 PM Changeset in webkit [130690] by
-
- 7 edits in trunk/Tools
nrwt: [chromium] run http tests in parallel on bigger machines
https://bugs.webkit.org/show_bug.cgi?id=98562
Reviewed by Eric Seidel.
The "locked tests" shard (which includes the http tests and the
perf tests) is the long pole on machines where we have 4 or more
workers, so we should start making sure that
we can run http tests in parallel, following the normal sharding
rules (all tests in the same directory are in the same shard by
default). We should still probably limit the number of workers
hitting the web server in parallel where we can; a heuristic of
no more than 25% of them seems okay for a start. This will
likely only affect developer workstations and a couple of bots
at first, so should be low risk and a good reward.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_max_locked_shards):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.default_max_locked_shards):
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_default_max_locked_shards):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_default_max_locked_shards):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_max_locked_shards):
- 2:55 PM Changeset in webkit [130689] by
-
- 132 edits in trunk
Move layerTreeAsText to window.internals
https://bugs.webkit.org/show_bug.cgi?id=98690
Reviewed by James Robinson.
Add window.internals.layerTreeAsText(document), and change the tests to use it.
I'll remove testRunner.layerTreeAsText() in a later patch.
Source/WebCore:
- testing/Internals.cpp:
(WebCore::Internals::layerTreeAsText):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- compositing/animation/animation-compositing.html:
- compositing/backing/no-backing-for-clip-overlap.html:
- compositing/backing/no-backing-for-clip.html:
- compositing/backing/no-backing-for-perspective.html:
- compositing/bounds-in-flipped-writing-mode.html:
- compositing/clip-child-by-non-stacking-ancestor.html:
- compositing/columns/composited-in-paginated.html:
- compositing/geometry/ancestor-overflow-change.html:
- compositing/geometry/bounds-clipped-composited-child.html:
- compositing/geometry/bounds-ignores-hidden-composited-descendant.html:
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html:
- compositing/geometry/bounds-ignores-hidden-dynamic.html:
- compositing/geometry/bounds-ignores-hidden.html:
- compositing/geometry/clip.html:
- compositing/geometry/composited-in-columns.html:
- compositing/geometry/fixed-position-composited-switch.html:
- compositing/geometry/flipped-writing-mode.html:
- compositing/geometry/foreground-layer.html:
- compositing/geometry/layer-due-to-layer-children-deep-switch.html:
- compositing/geometry/layer-due-to-layer-children-switch.html:
- compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
- compositing/geometry/limit-layer-bounds-fixed-positioned.html:
- compositing/geometry/limit-layer-bounds-opacity-transition.html:
- compositing/geometry/limit-layer-bounds-overflow-root.html:
- compositing/geometry/limit-layer-bounds-positioned-transition.html:
- compositing/geometry/limit-layer-bounds-positioned.html:
- compositing/geometry/limit-layer-bounds-transformed-overflow.html:
- compositing/geometry/limit-layer-bounds-transformed.html:
- compositing/geometry/preserve-3d-switching.html:
- compositing/iframes/become-composited-nested-iframes.html:
- compositing/iframes/become-overlapped-iframe.html:
- compositing/iframes/composited-parent-iframe.html:
- compositing/iframes/connect-compositing-iframe-delayed.html:
- compositing/iframes/connect-compositing-iframe.html:
- compositing/iframes/connect-compositing-iframe2.html:
- compositing/iframes/connect-compositing-iframe3.html:
- compositing/iframes/enter-compositing-iframe.html:
- compositing/iframes/iframe-resize.html:
- compositing/iframes/iframe-size-from-zero.html:
- compositing/iframes/iframe-size-to-zero.html:
- compositing/iframes/iframe-src-change.html:
- compositing/iframes/invisible-nested-iframe-hide.html:
- compositing/iframes/invisible-nested-iframe-show.html:
- compositing/iframes/leave-compositing-iframe.html:
- compositing/iframes/overlapped-iframe-iframe.html:
- compositing/iframes/overlapped-iframe.html:
- compositing/iframes/overlapped-nested-iframes.html:
- compositing/iframes/page-cache-layer-tree.html:
- compositing/iframes/resizer.html:
- compositing/iframes/scrolling-iframe.html:
- compositing/images/clip-on-directly-composited-image.html:
- compositing/layer-creation/animation-overlap-with-children.html:
- compositing/layer-creation/fixed-position-and-transform.html:
- compositing/layer-creation/fixed-position-out-of-view.html:
- compositing/layer-creation/fixed-position-under-transform.html:
- compositing/layer-creation/no-compositing-for-preserve-3d.html:
- compositing/layer-creation/overflow-scroll-overlap.html:
- compositing/layer-creation/overlap-animation.html:
- compositing/layer-creation/overlap-child-layer.html:
- compositing/layer-creation/overlap-clipping.html:
- compositing/layer-creation/overlap-transformed-and-clipped.html:
- compositing/layer-creation/overlap-transformed-layer.html:
- compositing/layer-creation/overlap-transforms.html:
- compositing/layer-creation/rotate3d-overlap.html:
- compositing/layer-creation/scroll-partial-update.html:
- compositing/layer-creation/spanOverlapsCanvas.html:
- compositing/layer-creation/stacking-context-overlap-nested.html:
- compositing/layer-creation/stacking-context-overlap.html:
- compositing/layer-creation/translatez-overlap.html:
- compositing/overflow-trumps-transform-style.html:
- compositing/overflow/clip-descendents.html:
- compositing/overflow/content-gains-scrollbars.html:
- compositing/overflow/content-loses-scrollbars.html:
- compositing/overflow/overflow-auto-with-touch-no-overflow.html:
- compositing/overflow/overflow-auto-with-touch-toggle.html:
- compositing/overflow/overflow-auto-with-touch.html:
- compositing/overflow/overflow-hidden-with-touch.html:
- compositing/overflow/overflow-overlay-with-touch-no-overflow.html:
- compositing/overflow/overflow-overlay-with-touch.html:
- compositing/overflow/overflow-scroll-with-touch-no-overflow.html:
- compositing/overflow/overflow-scrollbar-layers.html:
- compositing/overflow/overflow-visible-with-touch.html:
- compositing/overflow/resize-painting.html:
- compositing/overflow/scrolling-content-clip-to-viewport.html:
- compositing/overflow/textarea-scroll-touch.html:
- compositing/plugins/1x1-composited-plugin.html:
- compositing/plugins/large-to-small-composited-plugin.html:
- compositing/plugins/no-backing-store.html:
- compositing/plugins/small-to-large-composited-plugin.html:
- compositing/rtl/rtl-absolute-overflow-scrolled.html:
- compositing/rtl/rtl-absolute-overflow.html:
- compositing/rtl/rtl-absolute.html:
- compositing/rtl/rtl-fixed-overflow-scrolled.html:
- compositing/rtl/rtl-fixed-overflow.html:
- compositing/rtl/rtl-fixed.html:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html:
- compositing/rtl/rtl-iframe-absolute-overflow.html:
- compositing/rtl/rtl-iframe-absolute.html:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html:
- compositing/rtl/rtl-iframe-fixed-overflow.html:
- compositing/rtl/rtl-iframe-fixed.html:
- compositing/rtl/rtl-iframe-relative.html:
- compositing/rtl/rtl-relative.html:
- compositing/tiled-layers-hidpi.html:
- compositing/tiling/crash-reparent-tiled-layer.html:
- compositing/tiling/huge-layer-add-remove-child.html-disabled:
- compositing/tiling/huge-layer-img.html-disabled:
- compositing/tiling/huge-layer-resize.html-disabled:
- compositing/tiling/huge-layer-with-layer-children-resize.html-disabled:
- compositing/tiling/huge-layer-with-layer-children.html-disabled:
- compositing/tiling/huge-layer.html-disabled:
- compositing/video/video-poster.html:
- compositing/visibility/layer-visible-content.html:
- compositing/visibility/visibility-image-layers-dynamic.html:
- css3/compositing/should-have-compositing-layer.html:
- css3/filters/composited-during-animation-layertree.html:
- css3/filters/composited-during-transition-layertree.html:
- css3/filters/filtered-compositing-descendant.html:
- css3/filters/should-not-have-compositing-layer.html:
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html:
- platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
- platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
- platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
- platform/mac/compositing/canvas/accelerated-canvas-compositing.html:
- 2:27 PM Changeset in webkit [130688] by
-
- 17 edits2 adds in trunk/Source/WebCore
Add render object that paints plugin snapshots
https://bugs.webkit.org/show_bug.cgi?id=98322
<rdar://problem/12426546>
Reviewed by Simon Fraser.
First, teach plugins to maintain a set of states when plugin snapshotting is enabled.
Second, a new RenderSnapshottedPlugIn class is a RenderEmbeddedObject that knows how to paint
snapshots when the plugin is not visibly playing. It maintains a RenderImageResource to
the generated poster image.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement): By default all plugins play on load.
- html/HTMLPlugInElement.h: Move the inheritance of ImageLoaderClientBase down to
HTMLPlugInImageElement, since that is the class that actually deals with image-based plugins.
(WebCore::HTMLPlugInElement::displayState): Add bit for display state.
(WebCore::HTMLPlugInElement::setDisplayState):
(WebCore::HTMLPlugInElement::updateSnapshot):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): If plugin snapshotting is
enabled, plugin state is set to wait for a poster image.
(WebCore::HTMLPlugInImageElement::createRenderer): Create RenderSnapshottedPlugIn if
plugin snapshotting is enabled.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Once a snapshot is available, update the
renderer and set its state to wait for user input to start the plugin.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement):
- rendering/RenderObject.h:
(WebCore::RenderObject::isSnapshottedPlugIn): Add new function to identify
RenderSnapshottedPlugIn instances. Since RenderSnapshottedPlugIn inherits from
RenderEmbeddedObject, isEmbeddedObject() still returns true.
- rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject): Elevate a few virtual methods to protected for
RenderSnapshottedPlugIn to override.
- rendering/RenderSnapshottedPlugIn.cpp: Added.
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize snapshot
resource.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Shut down snapshot
image resource to remove the renderer as a client, and remove image from memory cache.
(WebCore::RenderSnapshottedPlugIn::plugInImageElement): Convenience function to get the
HTML element.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Cache the snapshot, and repaint.
(WebCore::RenderSnapshottedPlugIn::paint): If the plugin is not playing, paint like a
RenderImage does.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Paint the snapshot and overlay if the
plugin is not playing.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot): Inspired by
RenderImage::paintReplaced() and RenderImage::paintIntoRect().
- rendering/RenderSnapshottedPlugIn.h: Added.
(WebCore::RenderSnapshottedPlugIn::isSnapshottedPlugin): Returns true.
- rendering/RenderTheme.h: Add a function that paints the overlay on top of the snapshot.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintPlugInSnapshotOverlay):
- WebCore.xcodeproj/project.pbxproj: Add new RenderSnapshottedPlugIn class.
- CMakeLists.txt: Ditto.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- rendering/RenderingAllInOne.cpp: Ditto.
- 2:20 PM Changeset in webkit [130687] by
-
- 10 edits13 adds in trunk
[CSS Exclusions] Add support for polygonal shapes
https://bugs.webkit.org/show_bug.cgi?id=96811
Patch by Hans Muller <hmuller@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.
Source/WebCore:
Initial version of the layout support for polygonal exclusion shapes: the ExclusionPolygon class.
Supports the public ExclusionShape operations using the algorithm described here:
http://hansmuller-webkit.blogspot.com/2012/06/horizontal-box-polygon-intersection-for.html.
Although both the "included" and "excluded" operations are supported, only the former is
used, since only shape-inside is supported at the moment.
The ExclusionPolygon class stores the polygon's edges in an interval tree.
Polygon edges are represented by the ExclusionPolygonEdge struct, which records the indices of
the pair of vertices joined by the edge. Edge vertex index1 is usually less than index2, except
the last edge where index2 is 0. We plan to improve the algorithm that creates the edges
by spanning vertices contained in sequences of more than two colinear vertices. For example,
a triangular polygon might be specified with 5 vertices like this: 3,0 5,0, 5,5, 4,4 2,2, 0,0.
By spanning the extra colinear points: 0,0 5,0, 5,5, which implies index1-index2 edges: 5-1 1-2 2-5.
Although the implementation supports complex polygons, the layout code is limited to
essentially rectangular shapes until a patch for https://bugs.webkit.org/show_bug.cgi?id=96813
lands.
Tests: fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/ExclusionPolygon.cpp: Added.
(WebCore):
(EdgeIntersection): Internal description of the intersection of a polygon edge and a horizontal line.
(WebCore::ExclusionPolygon::ExclusionPolygon): See the introductory text above for a description of this type.
(WebCore::computeXIntersection): Find and classify the X intercept of a polygon edge with horizontal line, if any.
(WebCore::ExclusionPolygon::rightVertexY): This method is used to decide if a horizontal line "crosses" a vertex.
(WebCore::appendIntervalX): Append an x coordinate to a vector of ExclusionIntervals.
(WebCore::ExclusionPolygon::computeXIntersections): Return a vector of the intersections of a horizontal line with the polygon's edges.
(WebCore::ExclusionPolygon::computeEdgeIntersections): Return a vector of the X projections of the edges that overlap a horizonal rectangle.
(WebCore::ExclusionPolygon::getExcludedIntervals): Return a SegmentList of the X intervals within a horizontal rectangle that overlap the polygon.
(WebCore::ExclusionPolygon::getIncludedIntervals): Return the X intervals within a horizontal rectangle that fit inside the polygon.
- rendering/ExclusionPolygon.h: Added.
(WebCore):
(ExclusionPolygon):
(WebCore::ExclusionPolygon::getXAt): X coordinate of a polygon vertex
(WebCore::ExclusionPolygon::getYAt): Y coordinate of a polygon vertex
(WebCore::ExclusionPolygon::numberOfVertices):
(WebCore::ExclusionPolygon::fillRule): A WindRule value that defines "inside" for self-intersecting polygons.
(ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::vertex1):
(WebCore::ExclusionPolygonEdge::vertex2):
(WebCore::ExclusionPolygonEdge::minX):
(WebCore::ExclusionPolygonEdge::minY):
(WebCore::ExclusionPolygonEdge::maxX):
(WebCore::ExclusionPolygonEdge::maxY):
- rendering/ExclusionShape.cpp:
(WebCore::createExclusionPolygon): Return a new ExclusionPolygon.
(WebCore):
(WebCore::ExclusionShape::createExclusionShape): Added support for BasicShape::BASIC_SHAPE_POLYGON.
- rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock): Enable BASIC_SHAPE_POLYGON shapes for RenderBlocks.
LayoutTests:
Verify that a rectangular shape-inside specified as a polygon works as expected for all
writing-modes.
Added exclusions tests for non-complex concave shape-inside polygons as well.
The shapes in this set of tests are "rectangular" in the sense that
horizontal lines that overlap the polygon only cross the polygon twice.
The expected part of each test uses float "sandbags" to simulate the
shape-inside area in the test expectations. The tests use SVG to
display the polygon itself, to simplify visual inspection.
(See http://www.alistapart.com/articles/sandbags/).
- fast/exclusions/shape-inside/shape-inside-polygon-rectangle-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html: Added.
- fast/exclusions/resources/simple-polygon.js: Added.
(createPolygon):
(polygonXIntercepts):
(generatePolygonContentString):
(simulatePolygonShape):
(generateSimulatedPolygonShapeInsideElement):
(positionInformativeText):
(createPolygonShapeInsideTestCase):
(createPolygonShapeInsideTestCaseExpected):
- fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html: Added.
- fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html: Added.
- fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html: Added.
- fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html: Added.
- 2:16 PM Changeset in webkit [130686] by
-
- 5 edits in trunk/Source/WebCore
Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=98677
Reviewed by Ojan Vafai.
This is part of bug 96804. Convert RenderTextControl and RenderSVGForeignObject to
override the const computeLogicalHeight method rather than the updateLogicalHeight
setter method.
No new tests, there should be no behavior change as this is just a refactor.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight): Pass logicalHeight through rather than setting height.
This is a slight correctness fix, although we don't support vertical inputs yet.
- rendering/RenderTextControl.h:
(RenderTextControl):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::computeLogicalHeight):
- rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
- 2:16 PM Changeset in webkit [130685] by
-
- 2 edits8 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Add PNGs after r130653,
and skip tests on Qt-WK2, because they fail on it.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
- platform/qt/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
- platform/qt/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
- platform/qt/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
- platform/qt/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
- platform/qt/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
- platform/qt/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
- platform/qt/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
- 2:10 PM Changeset in webkit [130684] by
-
- 2 edits6 adds in trunk/LayoutTests
Unreviewed Chromium gardening.
Rebaselined those 2 tables/ tests that were forgotten in the rebaselining after r103875.
https://bugs.webkit.org/show_bug.cgi?id=74888 was opened to track those rebaselining but
it looks like some platform fell through the cracks.
- platform/chromium/TestExpectations:
Removed the 2 entries.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.txt: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.txt: Added.
Progression: the table captions are larger, which matches other browsers and other platforms' baselines.
- 1:58 PM Changeset in webkit [130683] by
-
- 2 edits in trunk/Source/WebCore
Upstream some tweaks for overlay play button on Android
https://bugs.webkit.org/show_bug.cgi?id=98671
Patch by Min Qin <qinmin@chromium.org> on 2012-10-08
Reviewed by Adam Barth.
This change stops displaying the overlay play button if video height is too small
No test for this. Will rebase layout test expectations for android later.
- css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-overlay-enclosure):
- 1:54 PM Changeset in webkit [130682] by
-
- 4 edits in trunk
GTK port should warn if bug modifier is missing in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98678
Reviewed by Dirk Pranke.
Tools:
Reimplement the warn_if_bug_missing_in_test_expectations method in
GtkPort, returning True for producing a warning in such cases.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.warn_if_bug_missing_in_test_expectations):
LayoutTests:
Add generic Bug(GTK) modifiers for two test expectations.
- platform/gtk/TestExpectations:
- 1:48 PM Changeset in webkit [130681] by
-
- 2 edits in trunk/LayoutTests
Suppress editing/pasteboard/data-transfer-items.html failure.
https://bugs.webkit.org/show_bug.cgi?id=98686
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 1:47 PM Changeset in webkit [130680] by
-
- 2 edits in trunk/Source/WebKit2
Add missing compile flag for compositing
https://bugs.webkit.org/show_bug.cgi?id=98681
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.
This flag is needed in case there is a difference in API
when compositing is enabled
- Configurations/FeatureDefines.xcconfig:
- 1:26 PM Changeset in webkit [130679] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaselining after r130598 and r130600.
- platform/chromium-linux-x86/svg/filters/filterRes-expected.txt:
This baseline was forgotten.
- 1:24 PM Changeset in webkit [130678] by
-
- 4 edits3 copies in branches/chromium/1271
Merge 130329 - Round image sizes when zooming
https://bugs.webkit.org/show_bug.cgi?id=98205
Reviewed by Eric Seidel.
Source/WebCore:
We currently floor image sizes when zooming which can result in
images being rendered at one pixel less than the actual size.
This is especially likely to happen for very large images.
Test: fast/sub-pixel/zoomed-image-tiles.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
LayoutTests:
Add test for zoomed large image tiles.
- fast/images/zoomed-img-size.html:
- fast/sub-pixel/zoomed-image-tiles-expected.html: Added.
- fast/sub-pixel/zoomed-image-tiles.html: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/chromium/fast/images/zoomed-img-size-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/mac-lion/TestExpectations:
- platform/mac-snowleopard/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt/TestExpectations:
- platform/win-wk2/TestExpectations:
- platform/win-xp/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 1:22 PM Changeset in webkit [130677] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=98663
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Laszlo Gombos.
EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test was
failing because the elements of a list were checked in a given
order but the list was not sorted beforehand.
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(sortHostNames):
(TEST_F):
- 1:10 PM Changeset in webkit [130676] by
-
- 16 edits in trunk/Source
Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer
https://bugs.webkit.org/show_bug.cgi?id=98574
Reviewed by Dean Jackson.
GraphicsLayerCA assumed that using a TileCache equated to being the main page tile
cache layer, which has some special considerations. Make these two concepts separate
to get closer to being able to use TileCaches in place of CATiledLayer.
Source/WebCore:
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer): Remove m_usingTileCache member, which was not appropriate
for this class to have.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer): Remove init of m_usingTileCache.
(WebCore::GraphicsLayer::debugBorderInfo): Can no longer use m_usingTileCache to
get the blue color, so moved code into a virtual debugBorderInfo() method.
(WebCore::GraphicsLayer::updateDebugIndicators): Call the virtual debugBorderInfo().
- platform/graphics/GraphicsLayerClient.h: Remove the usingTileCache() callback;
we now just cache this information in the GraphicsLayerCA on creation.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Init m_isPageTileCacheLayer to false,
then set to m_isPageTileCacheLayer if the client says we should create a tile cache.
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter): Overidden to avoid duplicate repaint
counters in the top-left tile.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): If this layer is the page tile cache layer,
we allow setting of its background color.
(WebCore::GraphicsLayerCA::debugBorderInfo): Overidden to use a blue color for tiles.
(WebCore::GraphicsLayerCA::requiresTiledLayer): Don't make CATiledLayers for the page tile cache.
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- platform/graphics/ca/PlatformCALayerClient.h:
(PlatformCALayerClient): Need to pass the platform layer into platformCALayerShowRepaintCounter()
so we can distinguish between calls for tiles, and calls for the tile cache layer itself.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::shouldShowRepaintCounters): Pass 0 to platformCALayerShowRepaintCounter() to
indicate that we're asking about a tile.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents): Now we can just rely on platformCALayerShowRepaintCounter() to tell us whether
to draw the repaint counter.
(-[WebLayer setNeedsDisplayInRect:]):
- platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer setNeedsDisplayInRect:]):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::usingTileCache):
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange): We can ask the RenderLayerBacking
whether it's for the tile cache, rather than going to the GraphicsLayer.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerShowRepaintCounter):
Source/WebKit/win:
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
- 12:46 PM Changeset in webkit [130675] by
-
- 2 edits in trunk/LayoutTests
[Qt] new test introduced in r120354 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91968
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Unskipping test.
- platform/qt/TestExpectations:
- 12:33 PM Changeset in webkit [130674] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-08
- DEPS:
- 12:18 PM Changeset in webkit [130673] by
-
- 2 edits in trunk/Tools
[EFL][DRT] Switch default backing store to single
https://bugs.webkit.org/show_bug.cgi?id=98591
Reviewed by Eric Seidel.
There are two backing stores for WebKit/Efl, Single Backing Store(SBS) and
Tiled Backing Store(TBS), and DRT/Efl has used TBS.
But, TBS is not suitable to run pixel tests because it does not have a good way
to render mock scrollbars well.
So, this patch changes the default backing store to SBS.
In addition, this changes the environment variable from DRT_USE_SINGLE_BACKING_STORE
to DRT_USE_TILED_BACKING_STORE.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(shouldUseTiledBackingStore):
(chooseAndInitializeAppropriateSmartClass):
- 12:14 PM Changeset in webkit [130672] by
-
- 4 edits in trunk
[Qt] Make ImageBufferQt use premultiplied converting functions in Color.h instead of its own mechanism.
https://bugs.webkit.org/show_bug.cgi?id=98582
Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-08
Reviewed by Eric Seidel.
Source/WebCore:
Only Qt port failed canvas/philip/tests/2d.imageData.put.unchanged.html because
ImageBufferQt converts from or to a premultiplied color using its own code. When
we convert twice from an unmultiplied color to a premultiplied color and then to
an unmultiplied color using this code, the calculated result are pretty
different against the input color. It is why Gtk passes this test although Qt
fails. Gtk port uses them in Color.h.
In addition, Qt should use the functions in Color.h to reduce duplicated codes.
Tests: canvas/philip/tests/2d.imageData.put.unchanged.html: Fixed a test case
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::convertBGRAToRGBA):
(WebCore::ImageBuffer::putByteArray):
LayoutTests:
Unskipping canvas/philip/tests/2d.imageData.put.unchanged.html that is passing.
- platform/qt/TestExpectations:
- 12:10 PM Changeset in webkit [130671] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Avoid useless converting to WKPage
https://bugs.webkit.org/show_bug.cgi?id=98516
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.
Use priv->pageProxy->findString() and priv->pageProxy->hideFindUI()
to avoid useless converting to WK.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
- 12:07 PM Changeset in webkit [130670] by
-
- 2 edits in trunk/LayoutTests
Fix video-test.js relativeURL() bug
https://bugs.webkit.org/show_bug.cgi?id=98546
Patch by Shadi Khalek <shadi@chromium.org> on 2012-10-08
Reviewed by Eric Seidel.
Some layout tests failed due to this bug (crbug.com/154157)
- media/video-test.js:
(testArraysEqual):
(relativeURL):
- 12:02 PM Changeset in webkit [130669] by
-
- 2 edits in trunk/PerformanceTests
Perf test pesults page takes forever to load on a machine with a slow Internet connection
https://bugs.webkit.org/show_bug.cgi?id=98561
Reviewed by Ojan Vafai.
Try loading jquery both locally and remotely, and use the same method to load the remaining
jquery plugins when either one succeeds.
- resources/results-template.html:
- 12:00 PM Changeset in webkit [130668] by
-
- 5 edits14 deletes in trunk
Remove "orphaned units" quirk
https://bugs.webkit.org/show_bug.cgi?id=98553
Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.
This patch removes our "orphaned units" quirk.
We have an "orphaned units" quirk to match IE, which allows things like "width: 20 px;".
But FF and Opera don't have it and aren't aware of bugs for it,
and it's not in Simon Pieters' Quirks Mode spec <http://dvcs.w3.org/hg/quirks-mode/raw-file/tip/Overview.html>
No new tests, because I'm killing a quirk.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSParser.h:
(CSSParser):
- 11:57 AM Changeset in webkit [130667] by
-
- 2 edits24 adds4 deletes in trunk/LayoutTests
Additional fast/repaint Chromium rebaseline.
Rebaselined more tests on Chromium Mac. Same as r130654 but there
is some anti-aliasing differences on transformed lines.
- platform/chromium/TestExpectations:
Removed the rebaselined tests.
- fast/repaint/table-section-repaint-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-outline-repaint-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/table-collapsed-border-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/text-append-dirty-lines-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/transform-relative-position-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/transform-repaint-descendants-expected.png: Added.
- platform/chromium-mac/fast/repaint/overflow-outline-repaint-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-col-background-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-collapsed-border-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-outer-border-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-row-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-section-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-section-repaint-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
- platform/chromium-mac/fast/repaint/text-append-dirty-lines-expected.png: Added.
- platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
- platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/transform-absolute-child-expected.png: Added.
- platform/chromium-mac/fast/repaint/transform-disable-layoutstate-expected.png: Added.
- platform/chromium-mac/fast/repaint/transform-relative-position-expected.png: Added.
- platform/chromium-mac/fast/repaint/transform-repaint-descendants-expected.png: Added.
- platform/chromium-win/fast/repaint/table-section-repaint-expected.txt: Removed.
- platform/chromium/fast/repaint/table-section-repaint-expected.txt: Added.
- platform/efl/fast/repaint/table-section-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/table-section-repaint-expected.txt: Removed.
- platform/qt/fast/repaint/table-section-repaint-expected.txt: Removed.
- 11:50 AM Changeset in webkit [130666] by
-
- 46 edits6 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining SVG tests after changes in r130599.
- platform/gtk/TestExpectations:
- platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
- platform/gtk/svg/batik/paints/gradientLimit-expected.png:
- platform/gtk/svg/batik/paints/gradientLimit-expected.txt:
- platform/gtk/svg/batik/paints/patternRegions-expected.png:
- platform/gtk/svg/batik/paints/patternRegions-expected.txt:
- platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.png:
- platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/gtk/svg/batik/text/textEffect-expected.png:
- platform/gtk/svg/batik/text/textEffect-expected.txt: Added.
- platform/gtk/svg/batik/text/textEffect3-expected.png:
- platform/gtk/svg/batik/text/textEffect3-expected.txt: Added.
- platform/gtk/svg/custom/gradient-deep-referencing-expected.png:
- platform/gtk/svg/custom/gradient-deep-referencing-expected.txt:
- platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
- platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.txt:
- platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
- platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
- platform/gtk/svg/custom/radialGradient-focal-radius-expected.png: Added.
- platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Added.
- platform/gtk/svg/custom/recursive-gradient-expected.png:
- platform/gtk/svg/custom/recursive-gradient-expected.txt:
- platform/gtk/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
- platform/gtk/svg/custom/stroked-pattern-expected.png:
- platform/gtk/svg/custom/stroked-pattern-expected.txt:
- platform/gtk/svg/hixie/perf/006-expected.png:
- platform/gtk/svg/hixie/perf/006-expected.txt:
- 11:46 AM Changeset in webkit [130665] by
-
- 2 edits in trunk/LayoutTests
audiobuffer.html need to include audio-testing.js file.
https://bugs.webkit.org/show_bug.cgi?id=98641
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.
As we discussed at the bug https://bugs.webkit.org/show_bug.cgi?id=88624,
WebAudio tests need to include audio-testing.js file to set WebKitWebAudioEnabled.
- webaudio/audiobuffer.html: Include audio-testing.js file.
- 11:46 AM Changeset in webkit [130664] by
-
- 2 edits in trunk/Source/JavaScriptCore
After r130344, OpaqueJSString() creates an empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417
Reviewed by Sam Weinig.
Changed create() of a null string to return 0. This is the same behavior as before r130344.
- API/OpaqueJSString.cpp:
(OpaqueJSString::create):
- 11:44 AM Changeset in webkit [130663] by
-
- 3 edits2 adds in trunk
Border, margin and padding of an inline's inline ancestors counted twice
https://bugs.webkit.org/show_bug.cgi?id=63074
Reviewed by David Hyatt.
Source/WebCore:
In a line such as '<span><span><img>Text' the border, padding and margin belonging
to the two spans was counted twice by RenderBlockLineLayout::nextLineBreak(): once
when adding the width of the <img> object to the line, and a second time when adding
the 'Text'. The result was that nextLineBreak() now had a length for the line that
exceeded the line's maximum length and inserted a bogus line break.
This all happened because the helper function that is used to add in the border etc.
from inline ancestors was crawling up the tree each time. It doesn't need to do that, it
should stop crawling up the tree when the current object is not the first or last sibling below a parent.
Test: fast/inline/bpm-inline-ancestors.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldAddBorderPaddingMargin): Broke this check out into a helper function so that it
can help inlineLogicalWidth() return early and also treat empty RenderTexts the same as no previous/next
sibling on the line. This ensures that collapsed leading space does not interfere with the decision to
crawl up the ancestors accumulating border, padding, and margin.
(WebCore):
(WebCore::inlineLogicalWidth): Return early once the current child is no longer on the edge of its line -
this ensures the border, padding and margin of ancestors is not counted twice.
LayoutTests:
- fast/inline/bpm-inline-ancestors-expected.html: Added.
- fast/inline/bpm-inline-ancestors.html: Added.
- 11:40 AM Changeset in webkit [130662] by
-
- 11 edits in trunk
[WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
https://bugs.webkit.org/show_bug.cgi?id=98638
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-08
Reviewed by Eric Seidel.
Source/WebKit2:
Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleDispatchPendingLoadRequests):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::dispatchPendingLoadRequests):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Tools:
Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::dispatchPendingLoadRequests):
(WTR):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Unskip http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
- platform/wk2/TestExpectations:
- 11:37 AM Changeset in webkit [130661] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip http/tests/multipart/multipart-html.php while we wait for kov's patch.
- platform/efl/TestExpectations:
- 11:37 AM Changeset in webkit [130660] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add support for window.close in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98667
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Laszlo Gombos.
When calling window.close() from JavaScript, MiniBrowser
now closes the given window.
- MiniBrowser/efl/main.c:
(window_close):
(on_ecore_evas_delete):
(on_close_window):
(window_create):
- 11:35 AM Changeset in webkit [130659] by
-
- 3 edits in trunk/Tools
Properly strip new tests from the test results json if they are pass/nodata/skip.
https://bugs.webkit.org/show_bug.cgi?id=98669
Reviewed by Eric Seidel.
In _merge_json, we had a codepath that didn't call _normalize_results_json
for tests that aren't already in the aggregated results.
Instead, now do all the merging first and then normalize the aggregated results.
- TestResultServer/model/jsonresults.py:
(JsonResults._merge_json):
(JsonResults._merge_tests):
(JsonResults._normalize_results):
(JsonResults):
(JsonResults._should_delete_leaf):
- TestResultServer/model/jsonresults_unittest.py:
Removed test_merge_build_directory_hierarchy_old_version since there is
no longer any version 3 json to support.
(JsonResultsTest.test_merge_remove_new_test):
(JsonResultsTest.test_merge_prune_extra_results_with_new_result_of_same_type):
- 11:23 AM Changeset in webkit [130658] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Simplify frame flattening support in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98657
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Simplify frame flattening support code in MiniBrowser to
avoid passing the setting around to window_create()
function().
- MiniBrowser/efl/main.c:
(on_key_down):
(on_new_window):
(window_create):
(main):
- 11:15 AM Changeset in webkit [130657] by
-
- 4 edits2 adds in trunk
Null-check for DOMWindow before feeding it to FeatureObserver.
https://bugs.webkit.org/show_bug.cgi?id=98624
Reviewed by Adam Barth.
Source/WebCore:
We shouldn't call out to FeatureObserver in
ContentSecurityPolicy::didReceiveHeader if the policy's document doesn't
have a DOMWindow.
Test: http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
Null check 'document->domWindow' before passing it on.
- page/FeatureObserver.cpp:
(WebCore::FeatureObserver::observe):
ASSERT 'domWindow'.
LayoutTests:
- http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html: Added.
This test shouldn't crash.
- 11:10 AM Changeset in webkit [130656] by
-
- 2 edits in trunk
[EFL] Add minimum version information for tool dependencies
https://bugs.webkit.org/show_bug.cgi?id=97592
Patch by Laszlo Gombos <Laszlo Gombos> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Capture the minimum version information for the tools that are required
to build the EFL port (or more generally WebKit).
- CMakeLists.txt:
- 11:05 AM Changeset in webkit [130655] by
-
- 13 edits5 deletes in trunk/LayoutTests
Unreviewed, new baseline for fast/table/colspanMinWidth-vertical.html.
The baseline changed in http://trac.webkit.org/changeset/130569 because
controls should all be horizontal.
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium/TestExpectations:
- platform/efl/fast/table/colspanMinWidth-vertical-expected.png: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.png: Removed.
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.png: Removed.
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/fast/table/colspanMinWidth-vertical-expected.png: Removed.
- platform/qt/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 10:54 AM Changeset in webkit [130654] by
-
- 3 edits43 adds1 delete in trunk/LayoutTests
Unreviewed fast/repaint Chromium rebaselining.
Rebaselined those tests on Chromium Mac. The differences fall in 3 buckets:
- the background has an alpha off-by-one (crbug.com/23473)
- the repaint rectangles are united (the Mac baselines don't do the union).
- On Lion, the font used is different.
- platform/chromium/TestExpectations:
Removed the rebaselined tests' entries.
- platform/chromium-mac-snowleopard/fast/repaint/bugzilla-5699-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/control-clip-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/create-layer-repaint-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/layout-state-only-positioned-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/line-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/list-marker-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/make-children-non-inline-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/outline-child-repaint-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/outline-repaint-glitch-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-scroll-delete-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/reflection-redraw-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/selection-after-delete-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/static-to-positioned-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/table-cell-move-expected.png: Added.
- platform/chromium-mac/fast/repaint/background-generated-expected.png: Added.
- platform/chromium-mac/fast/repaint/bugzilla-5699-expected.png: Added.
- platform/chromium-mac/fast/repaint/content-into-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/control-clip-expected.png: Added.
- platform/chromium-mac/fast/repaint/control-clip-expected.txt:
- platform/chromium-mac/fast/repaint/create-layer-repaint-expected.png: Added.
- platform/chromium-mac/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
- platform/chromium-mac/fast/repaint/intermediate-layout-position-expected.png: Added.
- platform/chromium-mac/fast/repaint/layout-state-only-positioned-expected.png: Added.
- platform/chromium-mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
- platform/chromium-mac/fast/repaint/line-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/list-marker-2-expected.png: Added.
- platform/chromium-mac/fast/repaint/make-children-non-inline-expected.png: Added.
- platform/chromium-mac/fast/repaint/outline-child-repaint-expected.png: Added.
- platform/chromium-mac/fast/repaint/outline-inset-expected.png: Added.
- platform/chromium-mac/fast/repaint/outline-repaint-glitch-expected.png: Added.
- platform/chromium-mac/fast/repaint/overflow-into-content-expected.png: Added.
- platform/chromium-mac/fast/repaint/overflow-scroll-delete-expected.png: Added.
- platform/chromium-mac/fast/repaint/reflection-redraw-expected.png: Added.
- platform/chromium-mac/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/selection-after-delete-expected.png: Added.
- platform/chromium-mac/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
- platform/chromium-mac/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/chromium-mac/fast/repaint/static-to-positioned-expected.png: Added.
- platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
- platform/chromium-win/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
- platform/mac-lion/fast/repaint: Removed.
- platform/mac-lion/fast/repaint/control-clip-expected.txt: Removed.
- 10:21 AM Changeset in webkit [130653] by
-
- 2 edits8 adds in trunk/LayoutTests
[Qt] Add baselines to passing ruby DOM tests.
Unreviewed gardening.
- platform/qt/TestExpectations:
- platform/qt/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
- platform/qt/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
- platform/qt/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
- platform/qt/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
- platform/qt/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
- platform/qt/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
- platform/qt/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
- platform/qt/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.
- 10:13 AM Changeset in webkit [130652] by
-
- 3 edits in trunk/Tools
[EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=98655
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Use "Ctrl+n" shortcut instead of "F9" to open a new window in
MiniBrowser and EWebLauncher. This is the shortcut that is
commonly used for this action.
- EWebLauncher/main.c:
(on_key_down):
- MiniBrowser/efl/main.c:
(on_key_down):
- 10:08 AM Changeset in webkit [130651] by
-
- 6 edits2 adds in trunk
Source/WebCore: Loader cleanup : Simplify FrameLoader/DocumentLoader setupForReplace()
https://bugs.webkit.org/show_bug.cgi?id=49072
Reviewed by Eric Seidel.
This patch contains one small known behavior change: multipart/x-mixed-replace main resources with text/html parts
will no longer load the text/html progressively. In practice, loading the html progressively causes the document
to get cleared as soon as the next part's data starts arriving, which leads to a blank page most of the time. This case
seems to be pathological, as IE, FF, Opera and WebKit all do something different currently. This patch will cause
us to behave like Firefox, which is the most sane of the current behaviors.
Test: http/tests/multipart/multipart-html.php
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData): Use isMultipartReplacingLoad() helper.
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setupForReplace): Renamed from setupForReplaceByMIMEType(). Call maybeFinishLoadingMultipartContent()
instead of doing identical work inline. After we call frameLoader()->setReplacing(), we will never load progressively, so remove
the if (doesProgressiveLoad(newMIMEType)) {} block.
(WebCore::DocumentLoader::isMultipartReplacingLoad):
(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): Inline the old DocumentLoader::setupForeReplace(), check
frameLoader()->isReplacing() instead of the delete doesProgressiveLoad().
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setupForReplace): Move all calls to revertToProvisionalState here.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse): Call setupForReplace(), renamed from setupForReplaceByMIMEType().
LayoutTests: Add a test for multipart/x-mixed-replace documents with text/html
parts.
https://bugs.webkit.org/show_bug.cgi?id=49072
Reviewed by Eric Seidel.
- http/tests/multipart/multipart-html-expected.txt: Added.
- http/tests/multipart/multipart-html.php: Added.
- 10:06 AM Changeset in webkit [130650] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip svg/text/caret-in-svg-text.xhtml in WK1.
- platform/efl-wk1/TestExpectations:
- 10:02 AM LayoutUnit edited by
- Updated article to reflect that we now use 1/64 instead of 1/60. (diff)
- 9:53 AM Changeset in webkit [130649] by
-
- 2 edits4 adds in trunk/LayoutTests
Unreviewed gardening after r130587.
Per discussion with Adam, this change lands the failing baselines to
get some coverage until V8 matches JSC. Fixing the baselines is
covered by https://bugs.webkit.org/show_bug.cgi?id=98658
- platform/chromium/TestExpectations:
Marked one of test as SLOW as it is timing out in Debug.
- platform/chromium/fast/dom/gc-12-expected.txt: Added.
- platform/chromium/fast/dom/gc-3-expected.txt: Added.
- platform/chromium/fast/dom/gc-5-expected.txt: Added.
- platform/chromium/fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
- 9:50 AM Changeset in webkit [130648] by
-
- 5 edits in trunk/LayoutTests
Unreviewed Qt gardening.
Rebaseline Qt expectations for these passing tests.
- platform/qt/TestExpectations:
- platform/qt/fast/text/basic/013-expected.txt:
- platform/qt/fast/text/basic/015-expected.txt:
- platform/qt/fast/text/line-breaks-expected.txt:
- 9:45 AM Changeset in webkit [130647] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark fast/dynamic/window-scrollbars-test.html as flaky.
- platform/efl/TestExpectations:
- 9:33 AM Changeset in webkit [130646] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add support for window.create in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98649
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Calling window.create() from JavaScript now creates a
new window in Minibrowser, as directed.
- MiniBrowser/efl/main.c:
(on_new_window):
(window_create):
- 9:14 AM Changeset in webkit [130645] by
-
- 2 edits128 adds in trunk/LayoutTests
[EFL] Unskip svg/text.
Most of the text cases are passing, the ones which don't have been
properly skipped.
- platform/efl/TestExpectations:
- platform/efl/svg/text/append-text-node-to-tspan-expected.png: Added.
- platform/efl/svg/text/append-text-node-to-tspan-expected.txt: Added.
- platform/efl/svg/text/bidi-embedded-direction-expected.png: Added.
- platform/efl/svg/text/bidi-embedded-direction-expected.txt: Added.
- platform/efl/svg/text/bidi-reorder-value-lists-expected.png: Added.
- platform/efl/svg/text/bidi-reorder-value-lists-expected.txt: Added.
- platform/efl/svg/text/bidi-text-anchor-direction-expected.png: Added.
- platform/efl/svg/text/bidi-text-anchor-direction-expected.txt: Added.
- platform/efl/svg/text/bidi-text-query-expected.png: Added.
- platform/efl/svg/text/bidi-text-query-expected.txt: Added.
- platform/efl/svg/text/bidi-tspans-expected.png: Added.
- platform/efl/svg/text/bidi-tspans-expected.txt: Added.
- platform/efl/svg/text/ems-display-none-expected.png: Added.
- platform/efl/svg/text/ems-display-none-expected.txt: Added.
- platform/efl/svg/text/exs-display-none-expected.png: Added.
- platform/efl/svg/text/exs-display-none-expected.txt: Added.
- platform/efl/svg/text/font-size-below-point-five-2-expected.png: Added.
- platform/efl/svg/text/font-size-below-point-five-2-expected.txt: Added.
- platform/efl/svg/text/font-size-below-point-five-expected.png: Added.
- platform/efl/svg/text/font-size-below-point-five-expected.txt: Added.
- platform/efl/svg/text/foreignObject-repaint-expected.png: Added.
- platform/efl/svg/text/foreignObject-repaint-expected.txt: Added.
- platform/efl/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
- platform/efl/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
- platform/efl/svg/text/kerning-expected.png: Added.
- platform/efl/svg/text/kerning-expected.txt: Added.
- platform/efl/svg/text/modify-text-node-in-tspan-expected.png: Added.
- platform/efl/svg/text/modify-text-node-in-tspan-expected.txt: Added.
- platform/efl/svg/text/multichar-glyph-expected.png: Added.
- platform/efl/svg/text/multichar-glyph-expected.txt: Added.
- platform/efl/svg/text/remove-text-node-from-tspan-expected.png: Added.
- platform/efl/svg/text/remove-text-node-from-tspan-expected.txt: Added.
- platform/efl/svg/text/remove-tspan-from-text-expected.png: Added.
- platform/efl/svg/text/remove-tspan-from-text-expected.txt: Added.
- platform/efl/svg/text/scaled-font-expected.png: Added.
- platform/efl/svg/text/scaled-font-expected.txt: Added.
- platform/efl/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
- platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
- platform/efl/svg/text/selection-background-color-expected.png: Added.
- platform/efl/svg/text/selection-background-color-expected.txt: Added.
- platform/efl/svg/text/selection-styles-expected.png: Added.
- platform/efl/svg/text/selection-styles-expected.txt: Added.
- platform/efl/svg/text/small-fonts-2-expected.png: Added.
- platform/efl/svg/text/small-fonts-2-expected.txt: Added.
- platform/efl/svg/text/small-fonts-3-expected.png: Added.
- platform/efl/svg/text/small-fonts-3-expected.txt: Added.
- platform/efl/svg/text/small-fonts-expected.png: Added.
- platform/efl/svg/text/small-fonts-in-html5-expected.png: Added.
- platform/efl/svg/text/small-fonts-in-html5-expected.txt: Added.
- platform/efl/svg/text/text-align-01-b-expected.png: Added.
- platform/efl/svg/text/text-align-01-b-expected.txt: Added.
- platform/efl/svg/text/text-align-02-b-expected.png: Added.
- platform/efl/svg/text/text-align-02-b-expected.txt: Added.
- platform/efl/svg/text/text-align-03-b-expected.png: Added.
- platform/efl/svg/text/text-align-03-b-expected.txt: Added.
- platform/efl/svg/text/text-align-04-b-expected.png: Added.
- platform/efl/svg/text/text-align-04-b-expected.txt: Added.
- platform/efl/svg/text/text-align-05-b-expected.png: Added.
- platform/efl/svg/text/text-align-05-b-expected.txt: Added.
- platform/efl/svg/text/text-align-06-b-expected.png: Added.
- platform/efl/svg/text/text-align-06-b-expected.txt: Added.
- platform/efl/svg/text/text-altglyph-01-b-expected.png: Added.
- platform/efl/svg/text/text-altglyph-01-b-expected.txt: Added.
- platform/efl/svg/text/text-deco-01-b-expected.png: Added.
- platform/efl/svg/text/text-deco-01-b-expected.txt: Added.
- platform/efl/svg/text/text-fill-opacity-expected.png: Added.
- platform/efl/svg/text/text-fill-opacity-expected.txt: Added.
- platform/efl/svg/text/text-fonts-01-t-expected.png: Added.
- platform/efl/svg/text/text-fonts-01-t-expected.txt: Added.
- platform/efl/svg/text/text-fonts-02-t-expected.png: Added.
- platform/efl/svg/text/text-fonts-02-t-expected.txt: Added.
- platform/efl/svg/text/text-gradient-positioning-expected.png: Added.
- platform/efl/svg/text/text-gradient-positioning-expected.txt: Added.
- platform/efl/svg/text/text-hkern-expected.png: Added.
- platform/efl/svg/text/text-hkern-expected.txt: Added.
- platform/efl/svg/text/text-hkern-on-vertical-text-expected.png: Added.
- platform/efl/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
- platform/efl/svg/text/text-intro-05-t-expected.png: Added.
- platform/efl/svg/text/text-intro-05-t-expected.txt: Added.
- platform/efl/svg/text/text-midpoint-split-bug-expected.png: Added.
- platform/efl/svg/text/text-midpoint-split-bug-expected.txt: Added.
- platform/efl/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
- platform/efl/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
- platform/efl/svg/text/text-path-01-b-expected.png: Added.
- platform/efl/svg/text/text-path-01-b-expected.txt: Added.
- platform/efl/svg/text/text-path-middle-align-expected.png: Added.
- platform/efl/svg/text/text-path-middle-align-expected.txt: Added.
- platform/efl/svg/text/text-repaint-rects-expected.png: Added.
- platform/efl/svg/text/text-repaint-rects-expected.txt: Added.
- platform/efl/svg/text/text-rescale-expected.png: Added.
- platform/efl/svg/text/text-rescale-expected.txt: Added.
- platform/efl/svg/text/text-spacing-01-b-expected.png: Added.
- platform/efl/svg/text/text-spacing-01-b-expected.txt: Added.
- platform/efl/svg/text/text-text-01-b-expected.png: Added.
- platform/efl/svg/text/text-text-01-b-expected.txt: Added.
- platform/efl/svg/text/text-text-03-b-expected.png: Added.
- platform/efl/svg/text/text-text-03-b-expected.txt: Added.
- platform/efl/svg/text/text-text-04-t-expected.png: Added.
- platform/efl/svg/text/text-text-04-t-expected.txt: Added.
- platform/efl/svg/text/text-text-05-t-expected.png: Added.
- platform/efl/svg/text/text-text-05-t-expected.txt: Added.
- platform/efl/svg/text/text-text-06-t-expected.png: Added.
- platform/efl/svg/text/text-text-06-t-expected.txt: Added.
- platform/efl/svg/text/text-text-07-t-expected.png: Added.
- platform/efl/svg/text/text-text-07-t-expected.txt: Added.
- platform/efl/svg/text/text-text-08-b-expected.png: Added.
- platform/efl/svg/text/text-text-08-b-expected.txt: Added.
- platform/efl/svg/text/text-tref-01-b-expected.png: Added.
- platform/efl/svg/text/text-tref-01-b-expected.txt: Added.
- platform/efl/svg/text/text-tselect-01-b-expected.png: Added.
- platform/efl/svg/text/text-tselect-01-b-expected.txt: Added.
- platform/efl/svg/text/text-tselect-02-f-expected.png: Added.
- platform/efl/svg/text/text-tselect-02-f-expected.txt: Added.
- platform/efl/svg/text/text-tspan-01-b-expected.png: Added.
- platform/efl/svg/text/text-tspan-01-b-expected.txt: Added.
- platform/efl/svg/text/text-viewbox-rescale-expected.png: Added.
- platform/efl/svg/text/text-vkern-expected.png: Added.
- platform/efl/svg/text/text-vkern-expected.txt: Added.
- platform/efl/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
- platform/efl/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
- platform/efl/svg/text/text-ws-01-t-expected.png: Added.
- platform/efl/svg/text/text-ws-01-t-expected.txt: Added.
- platform/efl/svg/text/text-ws-02-t-expected.png: Added.
- platform/efl/svg/text/text-ws-02-t-expected.txt: Added.
- platform/efl/svg/text/textPathBoundsBug-expected.png: Added.
- platform/efl/svg/text/textPathBoundsBug-expected.txt: Added.
- platform/efl/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/efl/svg/text/tspan-dynamic-positioning-expected.txt: Added.
- 8:16 AM Changeset in webkit [130644] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip svg/dom/altGlyph-dom.xhtml
Seems to be passing these days.
- platform/efl/TestExpectations:
- 8:11 AM Changeset in webkit [130643] by
-
- 2 edits in trunk/Source/WTF
Lower minimum table size of WTF::HashTable to reduce memory usage.
<http://webkit.org/b/98406>
<rdar://problem/12432140>
Reviewed by Anders Carlsson.
Lower the default minimumTableSize for WTF hash tables from 64 to 8 entries.
This reduces WebProcess memory consumption by ~16MB on Membuster3 (a 6% progression!)
No significant movement on PLT or JSC benchmarks on my machine. If there's a perf regression somewhere
from this, we can tweak individual tables to have a larger minimumTableSize.
- wtf/HashTraits.h:
- 8:05 AM Changeset in webkit [130642] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add a setting to enable/disable smooth scrolling to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=98646
Reviewed by Xan Lopez.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty): Implement setter for new property.
(webKitSettingsGetProperty): Implement getter for new property.
(webkit_settings_class_init): Add new property
enable-smooth-scrolling.
(webkit_settings_get_enable_smooth_scrolling):
(webkit_settings_set_enable_smooth_scrolling):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Test smooth scrolling setting API.
- 8:04 AM Changeset in webkit [130641] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing crash expectations for tests that were fixed in r130611.
Removing failure expectations for fast/xsl/xslt-missing-namespace-in-xslt.xml,
the test is working fine after r130543.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 7:50 AM Changeset in webkit [130640] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Qt gardening.
Adding expectations for tests under css2.1.
- platform/qt/TestExpectations:
- 7:44 AM Changeset in webkit [130639] by
-
- 4 edits in trunk
Using float/double as WTF hash table key is unreliable.
<http://webkit.org/b/98627>
Reviewed by Geoffrey Garen.
Source/WTF:
Change FloatHash::equal() to do a bitwise compare instead of a logical compare.
This fixes a problem where the keys with different binary representation but the
same logical value (e.g 0 and -0) could block each other from being found if they
ended up in the same hash bucket.
- wtf/HashFunctions.h:
(FloatHash):
(WTF::FloatHash::hash):
(WTF::FloatHash::equal):
Tools:
Add a test case checking that using double as the hash table key type won't
have problems distinguishing between keys that are considered equal by operator==
but have different binary representations.
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestDoubleHashTraits):
- 7:36 AM BadContent edited by
- add more spammer addresses (diff)
- 7:05 AM Changeset in webkit [130638] by
-
- 2 edits534 adds in trunk/LayoutTests
[EFL] Unskip svg/W3C-SVG-1.1.
All but one test case worked fine (compared to the expectations in
mac/).
- platform/efl/TestExpectations:
- platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-15-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-17-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-19-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
- platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
- platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
- 7:03 AM Changeset in webkit [130637] by
-
- 26 edits1 move in trunk
[EFL][WK2] Use URL instead of URI in the API
https://bugs.webkit.org/show_bug.cgi?id=98643
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Use URL instead of URI in WebKit2 EFL API. This change
was discussed on the mailing list and aims at making
the API more consistent.
- UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_original_url_get):
- UIProcess/API/efl/ewk_back_forward_list_item.h:
- UIProcess/API/efl/ewk_context.cpp:
(ewk_context_url_scheme_register):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_download_client.cpp:
(decideDestinationWithSuggestedFilename):
- UIProcess/API/efl/ewk_download_job.h:
- UIProcess/API/efl/ewk_resource_private.h:
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_url_update):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_load_finished):
(ewk_view_load_provisional_redirect):
(ewk_view_load_provisional_started):
(ewk_view_html_string_load):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didSameDocumentNavigationForFrame):
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
(EWK2UnitTest::onURLChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilURLChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilURLChangedTo):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::EWK2UnitTestServer):
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::getURLForPath):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:
(EWK2UnitTestServer):
- UIProcess/API/efl/tests/resources/redirect_url_to_default.html: Renamed from Source/WebKit2/UIProcess/API/efl/tests/resources/redirect_uri_to_default.html.
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(checkItem):
(urlFromTitle):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Tools:
Update Minibrowser to reflect API changes. We now
use URL instead of URI in WK2 EFL API.
- EWebLauncher/url_bar.c:
(on_urlbar_key_down):
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/efl/main.c:
(on_url_changed):
(window_create):
- 6:44 AM Changeset in webkit [130636] by
-
- 35 edits in trunk/Source
[Qt] r122720 causes performance regression with DirectFB on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=97548
Reviewed by Jocelyn Turcotte.
Revert the rest of r122720. This change modifies the NativeImagePtr from QImage* to QPixmap*.
Covered by existing tests.
Source/WebCore:
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):
- platform/DragImage.h:
(WebCore):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/Image.h:
(Image):
- platform/graphics/NativeImagePtr.h:
(WebCore):
- platform/graphics/gstreamer/ImageGStreamer.h:
- platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::pushTransparencyLayerInternal):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
- platform/graphics/qt/ImageBufferDataQt.h:
(ImageBufferData):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::ImageBufferData::toQImage):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageFrame::asNewNativeImage):
- platform/graphics/qt/ImageQt.cpp:
(graphics):
(loadResourcePixmap):
(WebCore::Image::loadPlatformResource):
(WebCore::Image::setPlatformResource):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::create):
- platform/graphics/qt/PatternQt.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::StillImage):
(WebCore::StillImage::~StillImage):
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore::StillImage::size):
(WebCore::StillImage::nativeImageForCurrentFrame):
(WebCore::StillImage::draw):
- platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::create):
(WebCore::StillImage::createForRendering):
(StillImage):
- platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
(TransparencyLayer):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore::GraphicsSurface::createReadOnlyImage):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::createDragImage):
(WebCore::ClipboardQt::declareAndWriteDragImage):
- platform/qt/CursorQt.cpp:
(WebCore::createCustomCursor):
- platform/qt/DragImageQt.cpp:
(WebCore::createDragImageFromImage):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage):
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
- Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
- Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):
(QWebSettings::setWebGraphic):
(QWebSettings::webGraphic):
- WebCoreSupport/DragClientQt.cpp:
(WebCore::DragClientQt::startDrag):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
Source/WebKit2:
- Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createImage):
- UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQPixmapToShareableBitmap):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
- 6:43 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 5:51 AM Changeset in webkit [130635] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r130629): It made touchadjustment/focusout-on-touch.html fail
https://bugs.webkit.org/show_bug.cgi?id=98642
Unreviewed gardening, skip the new failing test to paint the bot green.
- platform/qt-5.0-wk2/TestExpectations:
- 4:29 AM Changeset in webkit [130634] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header file to compilation.
- 4:04 AM Changeset in webkit [130633] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r130630
Explicit convertion is required from QSizeF to FloatSize.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
- 4:02 AM Changeset in webkit [130632] by
-
- 2 edits in trunk/LayoutTests
[Qt] plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=98640
Unreviewed gardening, skip the failing test.
- platform/qt/TestExpectations:
- 3:48 AM Changeset in webkit [130631] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix the mouse hover events transformation when devicePixelRatio != 1
https://bugs.webkit.org/show_bug.cgi?id=98429
Reviewed by Kenneth Rohde Christiansen.
This prevents the events from being transformed two or three times.
This is only noticeable in desktop mode.
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleHoverLeaveEvent):
(WebKit::QtWebPageEventHandler::handleHoverMoveEvent):
- 3:45 AM Changeset in webkit [130630] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Apply QQuickWebViewExperimental::devicePixelRatio to the desktop mode as well
https://bugs.webkit.org/show_bug.cgi?id=98428
Reviewed by Kenneth Rohde Christiansen.
This is handled by the PageViewportController when in flickable mode.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
- 3:41 AM Changeset in webkit [130629] by
-
- 5 edits in trunk/Source/WebKit2
[Qt] Prevent the PageViewportController from affecting the viewport in desktop mode
https://bugs.webkit.org/show_bug.cgi?id=98427
Reviewed by Kenneth Rohde Christiansen.
QQuickFlickable isn't tightly bound to it anymore, we can avoid creating it
completely in this case.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::onComponentComplete):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate::viewportController):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::viewportController):
(QQuickWebViewFlickablePrivate):
- UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::didRenderFrame):
(WebKit::QtPageClient::didChangeContentsSize):
(WebKit::QtPageClient::pageTransitionViewportReady):
- UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit::QtWebPageLoadClient::didCommitLoad):
- 3:29 AM Changeset in webkit [130628] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening, skip and update some failing test.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-08
- platform/qt/TestExpectations:
- platform/qt/http/tests/misc/acid3-expected.png:
- platform/qt/http/tests/misc/acid3-expected.txt:
- 2:57 AM Changeset in webkit [130627] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix a QSocketNotifier warning at startup
https://bugs.webkit.org/show_bug.cgi?id=98411
Reviewed by Simon Hausmann.
The actual warning:
QSocketNotifier: socket notifiers cannot be enabled from another thread
The problem was that QSocketNotifier::setEnabled was called on the main thread
after moveToThread was called. This hasn't had any effect since Connection
would dispatch a readyReadHandler call right after which would then call
setEnabled again from the correct thread from ~SocketNotifierResourceGuard.
Replace the call with a queued invoke to shut the warning.
- Platform/qt/WorkQueueQt.cpp:
(WorkQueue::registerSocketEventHandler):
- 2:47 AM Changeset in webkit [130626] by
-
- 2 edits in trunk
[EFL] Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=98635
Unreviewed build fix.
Build error is occurred because of the new flag, ENABLE_LEGACY_WEB_AUDIO,
which was introduced by https://bugs.webkit.org/show_bug.cgi?id=97050.
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-08
- Source/cmakeconfig.h.cmake: Add ENABLE_LEGACY_WEB_AUDIO.
- 2:28 AM Changeset in webkit [130625] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitWebView/populate-menu asserts in debug bots
https://bugs.webkit.org/show_bug.cgi?id=98507
Reviewed by Martin Robinson.
Make sure we retain the page URL before asking for the icon.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(getIconSurfaceSynchronously): Retain the page URL before asking
for the icon, and release it if we fail to get an icon.
(processPendingIconsForPageURL): Renamed to make it clear it
receives a Sring and not a char* and moved
getIconSurfaceSynchronously() call out of the loop to call it only
once even if there are multiple requests pending.
(iconDataReadyForPageURLCallback): Do not retain the page URL
here.
- 2:23 AM Changeset in webkit [130624] by
-
- 5 edits in trunk
[EFL] Add support for -webkit-sticky
https://bugs.webkit.org/show_bug.cgi?id=95182
Reviewed by Kenneth Rohde Christiansen.
Turn on CSS sticky position by default for WebKitEfl,
but most of the CSS sticky position test cases still do not pass on WK1.
.:
- Source/cmake/OptionsEfl.cmake:
LayoutTests:
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 1:49 AM Changeset in webkit [130623] by
-
- 7 edits in trunk
[Qt] Reenable plugin tests
https://bugs.webkit.org/show_bug.cgi?id=98528
Reviewed by Csaba Osztrogonác.
Tools:
Uncomment this function so we can pick up the test plugin.
It was commented out because of https://bugs.webkit.org/show_bug.cgi?id=86620
and that bug seems to be fixed now.
- WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeTestPluginDirectory):
LayoutTests:
Reenable plugin tests. Skip new failures.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0/TestExpectations:
- platform/qt/TestExpectations:
- 1:06 AM Changeset in webkit [130622] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r130619.
http://trac.webkit.org/changeset/130619
https://bugs.webkit.org/show_bug.cgi?id=98634
Causes many crashes on the EFL bots. (Requested by rakuco on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-08
Source/WebCore:
- platform/RunLoop.h:
(RunLoop):
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):
Source/WTF:
- wtf/efl/MainThreadEfl.cpp:
(WTF::pipeObject):
(WTF):
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
- 1:05 AM Changeset in webkit [130621] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] Don't use the C API internally in WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=96768
Reviewed by Martin Robinson.
Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.
- UIProcess/API/gtk/WebKitDownloadClient.cpp:
(didStart):
(didReceiveResponse):
(didReceiveData):
(decideDestinationWithSuggestedFilename):
(didCreateDestination):
(didFail):
(didCancel):
(didFinish):
(attachDownloadClientToContext):
- UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
(attachRequestManagerClientToContext):
- UIProcess/API/gtk/WebKitSecurityManager.cpp:
(registerSecurityPolicyForURIScheme):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_set_cache_model):
(webkit_web_context_get_cache_model):
(webkit_web_context_clear_cache):
(webkit_web_context_download_uri):
(webkit_web_context_get_cookie_manager):
(webkit_web_context_get_favicon_database_directory):
(webkit_web_context_get_favicon_database):
(webkit_web_context_set_additional_plugins_directory):
(webkitWebContextGetPluginThread):
(webkit_web_context_register_uri_scheme):
(webkitWebContextGetOrCreateDownload):
(webkitWebContextRemoveDownload):
(webkitWebContextGetContext):
(webkitWebContextGetRequestManager):
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed):
- 12:40 AM Changeset in webkit [130620] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Support multiple window creation for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=97884
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Implement the multiple window creation for MiniBrowser and bind the 'F9' key for opening a new window.
Also, refactored MiniBrowser codes according to EFL coding style.
- MiniBrowser/efl/main.c:
(_Browser_Window):
(window_free):
(main_signal_exit):
(on_ecore_evas_delete):
(on_ecore_evas_resize):
(on_key_down):
(on_title_changed):
(on_url_changed):
(on_progress):
(window_create):
(main):
- 12:20 AM Changeset in webkit [130619] by
-
- 5 edits in trunk/Source
[EFL] Use ecore_main_loop_thread_safe_call_async() to wakeup main loop.
https://bugs.webkit.org/show_bug.cgi?id=98505
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Instead of ecore_pipe_write(),
use ecore_main_loop_thread_safe_call_async() to wakeup ecore main loop.
According to the EFL API document, this function is designed to dispatch
a function on ecore main loop by avoiding dead lock or race condition.
With this function, webkit doesn't need to maintain ecore pipe also.
Source/WebCore:
No new tests. The function to wakeup main loop is changed.
- platform/RunLoop.h:
(RunLoop):
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):
Source/WTF:
- wtf/efl/MainThreadEfl.cpp:
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):