Timeline



Oct 13, 2012:

7:21 PM Changeset in webkit [131264] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

Use class extension rather than a void* member for new Objective-C WebProcessPlugIn SPI
https://bugs.webkit.org/show_bug.cgi?id=99256

Reviewed by Dan Bernstein.

A bit of good old fashion cleanup.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:

Remove the void* member.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

Move members from the WKWebProcessPlugInControllerData struct to a class extension.

(didCreatePage):
(willDestroyPage):
(-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
Directly access the members instead of using properties, now that it is not inconvenient.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:

Remove the void* member.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

Move members from the WKWebProcessPlugInBrowserContextControllerData struct to a class extension.

(-[WKWebProcessPlugInBrowserContextController _initWithBundlePageRef:]):
(-[WKWebProcessPlugInBrowserContextController _bundlePageRef]):
Remove unnecessary casts..

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

Add space before the parenthesis of a category to be consistent.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:

Remove unnecessary forward declare.

5:58 PM Changeset in webkit [131263] by aestes@apple.com
  • 3 edits
    1 add in trunk/Source/WebKit2

Add a private header for WKWebProcessPlugInBrowserContextController that defines a property for getting the WKBundlePageRef
https://bugs.webkit.org/show_bug.cgi?id=99252

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _bundlePageRef]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h: Added.
11:21 AM Changeset in webkit [131262] by crogers@google.com
  • 8 edits in trunk/Source

WebAudioBus needs support for resizing bus to a smaller size
https://bugs.webkit.org/show_bug.cgi?id=99215

Reviewed by Dimitri Glazkov.

Upgrade AudioBus and WebAudioBus to support resizing to a smaller size, once it has been created.
This is useful, for example, when decoding VBR formats and the actual length can't be exactly determined
until the entire file is decoded.

Source/Platform:

  • chromium/public/WebAudioBus.h:

(WebAudioBus):

Source/WebCore:

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::resizeSmaller):
(WebCore):

  • platform/audio/AudioBus.h:

(AudioBus):

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::resizeSmaller):
(WebCore):

  • platform/audio/AudioChannel.h:

(AudioChannel):

  • platform/chromium/support/WebAudioBus.cpp:

(WebKit::WebAudioBus::resizeSmaller):
(WebKit):

10:55 AM Changeset in webkit [131261] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add warning for unrenderable textures
https://bugs.webkit.org/show_bug.cgi?id=99235

Patch by Gregg Tavares <gman@google.com> on 2012-10-13
Reviewed by Kenneth Russell.

Unrenderable textures are often hard to debug. Adds a message to that
appears in the JavaScript console to help developers find the issue.

No new tests as no new functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::handleNPOTTextures):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

10:04 AM Changeset in webkit [131260] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Updated bindings test results.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex):

9:57 AM Changeset in webkit [131259] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[TestResultServer] Unit tests require an update after r131239
https://bugs.webkit.org/show_bug.cgi?id=99236

Reviewed by Ojan Vafai.

Replacing 'Webkit' with 'WebKit' in builder names througout the unit tests
after the Chromium builders have been renamed recently.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
9:46 AM Changeset in webkit [131258] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

I pity da foo' who's converting numbers to strings
https://bugs.webkit.org/show_bug.cgi?id=99197

Reviewed by Gavin Barraclough.

40% speedup on PerformanceTests/Dromaeo/dom-traverse.html. Probably speeds
some other things up too.

Credit to Eric Seidel for spotting this.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): getOwnPropertySlotByIndex doesn't need to prefer
string lookup in the static table because our static tables don't contain
properties that are numbers.

I believe this is low-hanging fruit left behind by Phil's
getOwnPropertySlotByIndex optimization, but it's also possible that this was a
regression at some point. I didn't check.

6:20 AM Changeset in webkit [131257] by jpetsovits@rim.com
  • 12 edits
    4 adds in trunk/Source/WebKit

[BlackBerry] Fetch blit rects from a viewport accessor
https://bugs.webkit.org/show_bug.cgi?id=98581
RIM PR 173292

Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson.

Source/WebKit:

Add new ViewportAccessor files to the build.
See Source/WebKit/blackberry/ChangeLog for the
verbose commit message.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The long-standing userInterfaceBlittedVisibleContentsRect()
method in WebPageClient has long been a major annoyance,
as it returns the source rect for WebKit contents but in
backingstore pixel coordinates. This makes it not only
unwieldy but also terribly fragile, especially when
both pinch zoom and a backingstore re-render both deal
with the same rectangle. On different threads, even.

BlackBerry::Platform now exposes a ViewportAccessor
interface, which can be used to get the various rects
in document coordinates or target pixel coordinates,
both being a better choice than the ones dependent
on an implentation detail.

This commit makes use of this new functionality.
Instead of relying on the passed rectangle to contain
implicit information about the scale factor, we now
track the scale of each backingstore geometry by making
a snapshot of the current WebKit-thread scale when the
geometry is generated. Once the geometry is swapped to
the front, we can then calculate the remaining
backingstore-to-viewport transformation in a threadsafe
way. We now only calculate this if we actually blit from
backingstore tiles and don't go through a configuration
of pure accelerated compositing.

As a result, we are now a lot more robust against
synchonization issues related to backingstore
geometry changes. As an additional gimmick, the scale
is also stored with each tile buffer to doubly secure
that a tile rendered in one scale is not transferred
to a different geometry and then rendered there without
being rerendered at the new scale, even if the rendered
pixel coordinates are still the same.

Having per-geometry scale information also opens up
opportunities to further improve backingstore rendering
later. For instance, we could pre-render a low-res
version of the page onto one buffer and combine that one
with a higher-res array of tiles covering a smaller area.
Or we could steal some tiles from the front geometry to
render them at a new scale while a pinch-zoom operation
is in progress.

No such thing is implemented in this patch though.

In adapting/fixing the backingstore visualization
debug mode and the default background painting in
renderDirectToWindow(), we also introduce new
ViewportAccessor subclasses that can subsequently
be used to replace methods from WebPage and elsewhere.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::scroll):
(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
(BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::updateTileMatrixIfNeeded):
(BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):

  • Api/BackingStore_p.h:

(BlackBerry):
(Platform):
(BlackBerry::WebKit::BackingStoreGeometry::BackingStoreGeometry):
(BlackBerry::WebKit::BackingStoreGeometry::scale):
(BlackBerry::WebKit::BackingStoreGeometry::setScale):
(BackingStoreGeometry):
(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::webkitThreadViewportAccessor):
(WebKit):

  • Api/WebPage.h:

(Platform):

  • Api/WebPageClient.h:

(Platform):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):

  • Api/WebPage_p.h:

(WebKit):
(WebPagePrivate):

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::TileBuffer):
(BlackBerry::WebKit::TileBuffer::isRendered):

  • WebKitSupport/BackingStoreTile.h:

(TileBuffer):
(BlackBerry::WebKit::TileBuffer::scale):
(BlackBerry::WebKit::TileBuffer::setScale):

  • WebKitSupport/BackingStoreVisualizationViewportAccessor.cpp: Added.

(WebKit):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::BackingStoreVisualizationViewportAccessor):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelContentsSize):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentContentsSize):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelScrollPosition):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentScrollPosition):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelViewportSize):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentViewportSize):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::destinationSurfaceOffset):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::scale):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::state):

  • WebKitSupport/BackingStoreVisualizationViewportAccessor.h: Added.

(BlackBerry):
(Platform):
(WebKit):
(BackingStoreVisualizationViewportAccessor):
(BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::~BackingStoreVisualizationViewportAccessor):

  • WebKitSupport/WebKitThreadViewportAccessor.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::WebKitThreadViewportAccessor):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::documentContentsSize):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::documentScrollPosition):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelViewportSize):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::destinationSurfaceOffset):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::scale):

  • WebKitSupport/WebKitThreadViewportAccessor.h: Added.

(BlackBerry):
(Platform):
(WebKit):
(WebKitThreadViewportAccessor):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::~WebKitThreadViewportAccessor):

12:18 AM Changeset in webkit [131256] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove dead code in Node.idl
https://bugs.webkit.org/show_bug.cgi?id=99237

Reviewed by Maciej Stachowiak.

We don't implement this feature. This code is dead and should be
removed.

  • dom/Node.idl:

Oct 12, 2012:

11:38 PM Changeset in webkit [131255] by abarth@webkit.org
  • 1 delete in trunk/Source/WebCore/notifications

Remove empty directory.

11:14 PM Changeset in webkit [131254] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

[TestResultServer] Add support for non-Chromium TestExpectations files
https://bugs.webkit.org/show_bug.cgi?id=98422

Reviewed by Ojan Vafai.

Loads TestExpectations files for several other non-Chromium ports, parses them and
properly distributes them per various platforms.

  • TestResultServer/static-dashboards/dashboard_base.js: g_expectations is replaced by

g_expectationsByPlatform, an object that holds raw TestExpectations file contents for
various platforms.
(requestExpectationsFiles): First traverses through the platforms tree to gather all
the TestExpectations files that should be loaded, then loads them in parallel.
(appendJSONScriptElements):

  • TestResultServer/static-dashboards/flakiness_dashboard.js: The platforms tree is reorganized

to describe each platform and possible subplatforms plainly yet in detail. The PLATFORM_FALLBACKS
object is removed as it's not used anywhere. g_allTestsByPlatformAndBuildType is now filled by
traversing the platforms tree.
(traversePlatformsTree.traverse):
(traversePlatformsTree): A helper function that traverses the platforms tree, invoking
callback on each leaf node.
(determineWKPlatform): A helper function to determine whether the builder is running WebKit1 or
WebKit2 layer of a given platform.
(chromiumPlatform): Chromium-specific platforms are now properly prefixed with 'CHROMIUM_'.
(TestTrie): A new class that holds all the tests in a trie. The trie is constructed by iterating
through the tests for each builder, adding each test to the trie.
(TestTrie.prototype.forEach.traverse):
(TestTrie.prototype.forEach): A helper function that traverses the tests trie, invoking callback on each leaf.
(TestTrie.prototype._addTest): Aligns the test into the specified trie based on the test's path.
(getAllTestsTrie): Instead of in list, the problematic tests from each builder are now stored in a trie.
(individualTestsForSubstringList): Modified to traverse the trie instead of iterating the list.
(allTestsWithResult): Ditto.
(platformObjectForName): Splits the platform name by underscores and finds the appropriate platform object.
(getParsedExpectations): Now operates on the passed-in parameter rather than on a global variable.
(addTestToAllExpectationsForPlatform): Links expectations and modifiers to the test on the specified platform
and any build type the modifiers might apply to (or all build types if there are no such modifiers).
(processExpectationsForPlatform): Determines if the expectation should actually be processed for the given
platform by checking if any platform's fallback platforms support platform modifier unions and if any modifiers
represent such an union. If so, the expectation is then only processed if the given platform is in the union
the modifier presents or there are no such modifiers.
(processExpectations): Processes all acquired expectations by traversing the platforms tree and taking into
account possible fallback platforms.
(processTestRunsForBuilder):
(realModifiers.return.modifiers.filter):
(realModifiers): Modifiers other than build configurations and bug handles are now filtered out only if they
are present in the platform's platform modifier unions or represent subplatforms of a platform that supports
platform modifier unions.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: The test cases are updated and expanded

where necessary to cover the changes.
(resetGlobals):
(test): Added a TestTrie test.

11:11 PM Changeset in webkit [131253] by abarth@webkit.org
  • 6 edits
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/fast/forms/form-associated-element-crash3-expected.txt: Removed.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
11:07 PM Changeset in webkit [131252] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Fix lint error in TestExpectations.

  • platform/chromium/TestExpectations:
10:46 PM Changeset in webkit [131251] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Fix build error on DFGSpeculativeJIT32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=99234

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-12
Reviewed by Anders Carlsson.

Seems BUG 98608 causes build error on 32bit machine so fix it.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:30 PM Changeset in webkit [131250] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

StringBuilder::append(StringBuilder&) doesn't take into account the bit size of the argument string
https://bugs.webkit.org/show_bug.cgi?id=99225

Reviewed by Benjamin Poulain.

Added 8 bit path.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):

8:56 PM Changeset in webkit [131249] by fpizlo@apple.com
  • 11 edits
    1 add in trunk/Source/JavaScriptCore

Contiguous array allocation should always be inlined
https://bugs.webkit.org/show_bug.cgi?id=98608

Reviewed by Oliver Hunt and Mark Hahnenberg.

This inlines contiguous array allocation in the most obvious way possible.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::branchSubPtr):
(MacroAssembler):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchSubPtr):
(MacroAssemblerX86_64):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h: Added.

(DFG):
(CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::generateInternal):
(CallArrayAllocatorWithVariableSizeSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::generateInternal):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateJSArray):
(DFG):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:16 PM Changeset in webkit [131248] by Simon Fraser
  • 3 edits
    6 adds in trunk

Fix GraphicsLayerCA visible rect computation in the face of perspective and preserve-3d
https://bugs.webkit.org/show_bug.cgi?id=99212

Reviewed by Tim Horton.

Source/WebCore:

GraphicsLayerCA::computeVisibleRect() was incorrect for layer trees with perspective
and preserve-3d, so fix that, and add some tests.

Perspective is implemented via childrenTransform(); if our parent has one,
we have to left-multiply this into the transformation matrix.

We have to test both this layer and its parent when deciding whether to accumulate
or flatten.

Use state.mappedQuad() rather than state.lastPlanarQuad(), because the last planar
quad might be for some distant ancestor, and there may be intermediate preserve-3d
layers.

Tests: compositing/visible-rect/3d-transform-style.html

compositing/visible-rect/3d-transformed.html
compositing/visible-rect/nested-transform.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::computeVisibleRect):

LayoutTests:

Layer tree tests that include visible rect information, to test visible rect
computation for more complex layer trees.

  • compositing/visible-rect/3d-transform-style-expected.txt: Added.
  • compositing/visible-rect/3d-transform-style.html: Added.
  • compositing/visible-rect/3d-transformed-expected.txt: Added.
  • compositing/visible-rect/3d-transformed.html: Added.
  • compositing/visible-rect/nested-transform-expected.txt: Added.
  • compositing/visible-rect/nested-transform.html: Added.
6:16 PM Changeset in webkit [131247] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Move TransformState code into its own member function, and remove a test that was prematurely added
https://bugs.webkit.org/show_bug.cgi?id=99117

Reviewed by Tim Horton.

The code that manipulates the TransformState and computes the visible rect is going to get
more complex, so move it into a new member function.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

6:16 PM Changeset in webkit [131246] by Simon Fraser
  • 10 edits
    7 adds in trunk

Add some initial visible rect tests and tweak the visible wash layer
https://bugs.webkit.org/show_bug.cgi?id=99095

Reviewed by Tim Horton.

Source/WebCore:

Make the m_visibleTileWashLayer more useful by showing it for all
layers with transforms, not just tiled layers. This is a debugging
layer normally disabled, but enabled by #defining VISIBLE_TILE_WASH.

Tests: compositing/visible-rect/2d-transformed.html

compositing/visible-rect/3d-transformed.html
compositing/visible-rect/clipped-by-viewport copy.html
compositing/visible-rect/clipped-by-viewport.html
compositing/visible-rect/clipped-visible-rect.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests:

Add some tests of the GraphicsLayerCA visibleRect for simple cases.

Skip these tests on platforms that don't log layer visible rects
(all non-Mac).

  • compositing/visible-rect/2d-transformed-expected.txt: Added.
  • compositing/visible-rect/2d-transformed.html: Added.
  • compositing/visible-rect/clipped-by-viewport-expected.txt: Added.
  • compositing/visible-rect/clipped-by-viewport.html: Added.
  • compositing/visible-rect/clipped-visible-rect-expected.txt: Added.
  • compositing/visible-rect/clipped-visible-rect.html: Added.
  • platform/chromium-android/TestExpectations:
  • platform/chromium/TestExpectations:
  • platform/chromium/virtual/softwarecompositing/TestExpectations: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
6:11 PM Changeset in webkit [131245] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Windows rebaseline afer r130411.

  • platform/win/editing/pasteboard/paste-text-008-expected.txt:
6:11 PM Changeset in webkit [131244] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Race condition during CopyingPhase can lead to deadlock
https://bugs.webkit.org/show_bug.cgi?id=99226

Reviewed by Filip Pizlo.

The main thread calls startCopying() for each of the GCThreads at the beginning of the copy phase.
It then proceeds to start copying. If copying completes before one of the GCThreads wakes up, the
main thread will set m_currentPhase back to NoPhase, the GCThread will wake up, see that there's
nothing to do, and then it will go back to sleep without ever calling CopyVisitor::doneCopying()
to return its borrowed block to the CopiedSpace. CopiedSpace::doneCopying() will then sleep forever
waiting on the block.

The fix for this is to make sure we call CopiedSpace::doneCopying() on the main thread before we
call GCThreadSharedData::didFinishCopying(), which sets the m_currentPhase flag to NoPhase. This
way we will wait until all threads have woken up and given back their borrowed blocks before
clearing the flag.

  • heap/Heap.cpp:

(JSC::Heap::copyBackingStores):

5:57 PM Changeset in webkit [131243] by roger_fong@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed. Test passes, unskip, update results.

  • platform/win/TestExpectations:
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt:
5:56 PM Changeset in webkit [131242] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Teach GeneratorGObject about [ImplementedAs] extended attribute in functions
https://bugs.webkit.org/show_bug.cgi?id=99214

Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-12
Reviewed by Kentaro Hara.

No new tests, updated the binding tests results.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_orange):

5:40 PM Changeset in webkit [131241] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Update chromium bot names in garden-o-matic.

Unreviewed, build fix.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
5:35 PM Changeset in webkit [131240] by jpfau@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Checking in fast/js/random-array-gc-stress.html as timing out.

  • platform/mac/TestExpectations:
5:11 PM Changeset in webkit [131239] by ojan@chromium.org
  • 2 edits in trunk/Tools

Fix bot name filters now that the Chromium bots have been renamed.

  • TestResultServer/static-dashboards/builders.js:

(isChromiumWebkitTipOfTreeTestRunner):
(isChromiumWebkitDepsTestRunner):
(isChromiumTipOfTreeGTestRunner):

4:51 PM Changeset in webkit [131238] by Beth Dakin
  • 5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=99211
When ScrollingStateNodes are destroyed, they should be removed
ScrollingCoordinator's HashMap

Reviewed by Sam Weinig.

This patch adds a new member variable to ScrollingStateTree. It's a
Vector of ScrollingNodeIDs. It will contain the IDs of nodes that
have been removed from the tree since the last time the tree was
committed.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::ScrollingStateTree):

When we do commit, copy the Vector over into the cloned tree, and
then clear our own Vector.
(WebCore::ScrollingStateTree::commit):

Call didRemoveNode().
(WebCore::ScrollingStateTree::removeNode):

Append the removed node's id to the vector.
(WebCore::ScrollingStateTree::didRemoveNode):
(WebCore):

  • page/scrolling/ScrollingStateTree.h:

(ScrollingStateTree):

Call didRemoveNode().

  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::removeChild):

Fix the FIXME!

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::detachFromStateTree):

4:49 PM Changeset in webkit [131237] by dpranke@chromium.org
  • 7 edits in trunk/Tools

[chromium] add ML bot and update bot names
https://bugs.webkit.org/show_bug.cgi?id=99209

Reviewed by Eric Seidel.

This change adds proper baseline support for Mac10.8 (Mountain
Lion or ML) to chromium and updates the bot names from "Webkit"
to "WebKit" and ensures that all the bots have the OS version in
the name on Mac and Win.

We don't yet include a ML bot in garden-o-matic since it isn't
green yet.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:

(.):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_get_from_builder_name):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_baseline_directory):
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_expectations):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(BuildCoverageExtrapolatorTest.test_extrapolate):

4:48 PM Changeset in webkit [131236] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Move macros from Parser.h to Parser.cpp
https://bugs.webkit.org/show_bug.cgi?id=99217

Reviewed by Andreas Kling.

There are a bunch of macros in Parser.h that are only used in Parser.cpp. Move them to Parser.cpp
so they won't pollute the global namespace.

  • parser/Parser.cpp:
  • parser/Parser.h:

(JSC):

4:37 PM Changeset in webkit [131235] by beidson@apple.com
  • 11 edits
    4 copies
    3 adds in trunk/Source

Setup basic NetworkProcess messaging and initialization.
https://bugs.webkit.org/show_bug.cgi?id=99198

Reviewed by Sam Weinig.

Source/WebCore:

  • English.lproj/Localizable.strings: Update for the Network Process UI name.

Source/WebKit2:

Project file/build system stuff:

  • DerivedSources.make:
  • WebKit2.xcodeproj/project.pbxproj:
  • Scripts/webkit2/messages.py:

(struct_or_class):

Add basic initialization parameters for the NetworkProcess:

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit):
(WebKit::NetworkProcessCreationParameters::NetworkProcessCreationParameters):
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:

(CoreIPC):
(WebKit):
(NetworkProcessCreationParameters):

Use them to message the NetworkProcess what it's application name should be:

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h:

(WebKit):
(NetworkProcessProxy):

  • UIProcess/Network/mac/NetworkProcessProxyMac.mm:

(WebKit):
(WebKit::NetworkProcessProxy::platformInitializeNetworkProcess):

Add basic message handling and initialization to the NetworkProcess itself:

  • NetworkProcess/NetworkProcess.messages.in: Added.
  • Platform/CoreIPC/MessageID.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit):

  • NetworkProcess/NetworkProcess.h:

(WebKit):
(NetworkProcess):

Set a reasonable application name to be revealed in UI:

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit):
(WebKit::NetworkProcess::platformInitialize):

3:41 PM Changeset in webkit [131234] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, chromium-mac-snowleopard rebaseline for a slider.
The thumb moved a small amount (maybe during shadow dom refactor?).
This matches the Apple Lion result.

  • platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium/TestExpectations:
3:37 PM Changeset in webkit [131233] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, remove duplicate TestExpectation entries.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
3:31 PM WebKitIDL edited by jsbell@chromium.org
Add StrictTypeChecking on DOMString parameter details (diff)
3:17 PM Changeset in webkit [131232] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping tests involving CSS_COMPOSITING on Windows. Feature isn't and should not be enabled.

  • platform/win/TestExpectations:
3:16 PM Changeset in webkit [131231] by leviw@chromium.org
  • 11 edits in trunk/Source/WebCore

Remove unnecessary mode identifiers added in r131111
https://bugs.webkit.org/show_bug.cgi?id=99208

Reviewed by Emil A Eklund.

Removing unnecessary mode identifiers from coordinate conversion methods. These
were added in http://trac.webkit.org/changeset/131111

No new tests. No change in behavior.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderView.h:

(RenderView):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

  • rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

3:04 PM Changeset in webkit [131230] by eae@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed cleanup, remove unneeded XP specific rebaselines for chromium.

  • platform/chromium-win-xp/fast/speech: Removed.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
3:02 PM Changeset in webkit [131229] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt][WK2] REGRESSION(r131057): It made plugins/plugin-document-back-forward.html timeout
https://bugs.webkit.org/show_bug.cgi?id=99152

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-12
Reviewed by Simon Fraser.

Even though Response was already checked in WTR WKBundlePagePolicyClient decidePolicyForResponse callback,
this check did not take plugins into consideration when deciding whether we can show the given MIME type or not
so added another check in WTR UI process which also includes plugins.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::decidePolicyForResponse):

  • WebKitTestRunner/TestController.h:

(TestController):

3:00 PM Changeset in webkit [131228] by leviw@chromium.org
  • 16 edits in trunk/LayoutTests

Unreviewed gardening. Updating expectations for fast/repaint/repaint-across-writing-mode-boundary.html
and switching the TestExpectations files for ports with SUBPIXEL_LAYOUT disabled to skip the entire
sub-pixel test folder.

  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium/TestExpectations:
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
2:53 PM Changeset in webkit [131227] by eae@chromium.org
  • 10 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium windows rebaseline for r131202.

  • platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-win/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.png:
2:45 PM Changeset in webkit [131226] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r131224.
http://trac.webkit.org/changeset/131224
https://bugs.webkit.org/show_bug.cgi?id=99210

It broke the build (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-12

Source/WebCore:

  • history/qt/HistoryItemQt.cpp:
  • platform/FractionalLayoutUnit.h:

(WebCore):
(WebCore::operator<<):
(WebCore::operator>>):

  • platform/graphics/IntPoint.h:

(WebCore):
(WebCore::operator<<):
(WebCore::operator>>):

Source/WTF:

  • wtf/Vector.h:

(WTF):
(WTF::operator<<):
(WTF::operator>>):

  • wtf/qt/StringQt.cpp:

(WTF::operator<<):
(WTF):
(WTF::operator>>):

  • wtf/text/WTFString.h:

(WTF):

2:41 PM Changeset in webkit [131225] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Another build fix after r131213

Added some symbol magic to placate the linker on some platforms.

2:25 PM Changeset in webkit [131224] by andersca@apple.com
  • 8 edits in trunk/Source

Move QDataStream functions into HistoryItemQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=99203

Reviewed by Andreas Kling.

It seems like the QDataStream stream operators are only used from HistoryItemQt.cpp
inside WebCore, so move them there. If in the future they are required elsewhere, they should
be moved into a separate header instead of polluting headers unnecessarily.

Source/WebCore:

  • history/qt/HistoryItemQt.cpp:

(operator<<):
(operator>>):

  • platform/FractionalLayoutUnit.h:
  • platform/graphics/IntPoint.h:

Source/WTF:

  • wtf/Vector.h:
  • wtf/qt/StringQt.cpp:
  • wtf/text/WTFString.h:
2:22 PM WebInspector edited by zandobersek@gmail.com
Removing spam links. (diff)
2:01 PM Changeset in webkit [131223] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove used frameForEnteredContext API
https://bugs.webkit.org/show_bug.cgi?id=99201

Reviewed by Eric Seidel.

No one in Chromium-land understands the difference between
frameForEnteredContext and frameForCurrentContext. Rather than give
folks a confusing choice, let's just expose the one we most often want
to use.

I've already removed all callers of frameForEnteredContext downstream.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit):

1:53 PM Changeset in webkit [131222] by eae@chromium.org
  • 9 edits
    4 adds
    6 deletes in trunk/LayoutTests

Unreviewed chromium rebaseline for r131216.

  • fast/box-sizing/box-sizing-expected.txt: Replaced.
  • fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt:
  • platform/chromium-mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win-xp/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
  • platform/efl/fast/box-sizing/box-sizing-expected.txt: Removed.
  • platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
  • platform/gtk/fast/box-sizing/box-sizing-expected.txt: Removed.
  • platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
  • platform/win-future/fast/box-sizing: Added.
  • platform/win-future/fast/box-sizing/box-sizing-expected.txt: Added.
1:50 PM Changeset in webkit [131221] by Beth Dakin
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=99204
ScrollingStateNodes should keep track of their IDs

Reviewed by Simon Fraser.

There is a HashMap in ScrollingCoordinatorMac that maps
ScrollingNodeIDs to ScrollingStateNodes. The nodes themselves should
keep track of this id. Then the id can be used to make sure
ScrollingStateNodes remove themselves from the HashMap when they are
destroyed, and it will also be useful for associating
ScrollingStateNodes with ScrollingTreeNodes over on the scrolling
thread.

This patch only has the ScrollingStateNodes cache the id. I will
actually make use of the id in follow-up patches.

  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::ScrollingStateNode):

  • page/scrolling/ScrollingStateNode.h:

(ScrollingStateNode):
(WebCore::ScrollingStateNode::scrollingNodeID):

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::create):
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):

  • page/scrolling/ScrollingStateScrollingNode.h:

(ScrollingStateScrollingNode):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::attachToStateTree):

1:47 PM Changeset in webkit [131220] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Add LSKD support to MediaPlayerPrivateAVFoundation.
https://bugs.webkit.org/show_bug.cgi?id=98090

Reviewed by Anders Carlsson.

Add support for LSKD key system to MediaPlayerPrivateAVFoundation.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(MediaPlayerPrivateAVFoundationObjC): Add m_loaderDelegate, m_keyURIToRequestMap, and m_sessionToRequestMap.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(globalLoaderDelegateQueue): Static accessor for the dispatch queue to use for the loader delegate.
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Add the loader delegate to the AVURLAsset.
(WebCore::keySystemIsSupported): Convenience function; checks that the key system matches "com.apple.lskd"
(WebCore::MediaPlayerPrivateAVFoundationObjC::extendedSupportsType): Check the key system matches.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Fire a needkey event with an initData containing

the key URI.

(WebCore::extractKeyURIKeyIdAndCertificateFromInitData): Extract the keyURI, keyID, and the app certificate from the initData.
(WebCore::MediaPlayerPrivateAVFoundationObjC::generateKeyRequest): Generate a streaming key request from AVFoundation and

fire a keymessage event.

(WebCore::MediaPlayerPrivateAVFoundationObjC::addKey): Pass to AVFoundation through the AVAssetResourceLoader.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelKeyRequest): Release the loader delegate.
(-[WebCoreAVFLoaderDelegate initWithCallback:]): Simple constructor.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]): Pass to the MediaPlayerPrivateAVFoundationObjC.

1:36 PM Changeset in webkit [131219] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: WebKit API plumbing to pass abort reason code/message to script
https://bugs.webkit.org/show_bug.cgi?id=99193

Reviewed by Adam Barth.

Add database error (code, message) to payload for back-end to front-end abort call,
so that scripts can determine why the abort occurred - e.g. ConstraintError during
indexing. This API change allows the Chromium plumbing to land; the real implementation
is in http://webkit.org/b/99097 and will land later.

  • public/WebIDBTransactionCallbacks.h:

(WebKit):
(WebIDBTransactionCallbacks):
(WebKit::WebIDBTransactionCallbacks::onAbort):

1:33 PM Changeset in webkit [131218] by eae@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed chromium windows rebaseline for vertical-rl-ltr test.

  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
1:30 PM Changeset in webkit [131217] by adachan@apple.com
  • 8 edits in trunk/Source/WebKit2

Add WKPage API to get whether the main frame is pinned to the top or bottom edge
https://bugs.webkit.org/show_bug.cgi?id=99110

Reviewed by NOBODY (OOPS!).

This is very similar to r79025 where we add support to do this for the left and right sides.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPinnedToTopSide):
(WKPageIsPinnedToBottomSide):

  • UIProcess/API/C/WKPage.h:

Add new API calls.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isPinnedToTopSide):
(WebKit::WebPageProxy::isPinnedToBottomSide):
Declare new data members for keeping track of the pinned states for
top and bottom sides. Initialize, reset, and update these states
at appropriate times. Implement getters for these states.

  • UIProcess/WebPageProxy.messages.in:

Change the DidChangeScrollOffsetPinningForMainFrame message to take
the pinned states for top and bottom sides.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::didChangeScrollOffsetForMainFrame):

  • WebProcess/WebPage/WebPage.h:

Cache the pinned states for top and bottom sides. Only notify the
UI process if the states have changed.

1:15 PM Changeset in webkit [131216] by eae@chromium.org
  • 316 edits
    66 adds
    112 deletes in trunk/LayoutTests

Unreviewed chromium rebaseline for r131202.

  • css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Added.
  • css2.1/t100801-c544-valgn-01-d-ag-expected.txt: Added.
  • css3/flexbox/flexbox-baseline-expected.txt: Added.
  • fast/html/details-add-child-1-expected.txt: Added.
  • fast/html/details-add-child-2-expected.txt: Added.
  • fast/html/details-add-details-child-1-expected.txt: Added.
  • fast/html/details-add-details-child-2-expected.txt: Added.
  • fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • fast/html/details-add-summary-1-expected.txt: Added.
  • fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • fast/html/details-add-summary-10-expected.txt: Added.
  • fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • fast/html/details-add-summary-2-expected.txt: Added.
  • fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • fast/html/details-add-summary-3-expected.txt: Added.
  • fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • fast/html/details-add-summary-4-expected.txt: Added.
  • fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • fast/html/details-add-summary-5-expected.txt: Added.
  • fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • fast/html/details-add-summary-6-expected.txt: Added.
  • fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • fast/html/details-add-summary-7-expected.txt: Added.
  • fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • fast/html/details-add-summary-8-expected.txt: Added.
  • fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • fast/html/details-add-summary-9-expected.txt: Added.
  • fast/html/details-add-summary-child-1-expected.txt: Added.
  • fast/html/details-add-summary-child-2-expected.txt: Added.
  • fast/html/details-nested-1-expected.txt: Added.
  • fast/html/details-no-summary1-expected.txt: Added.
  • fast/html/details-no-summary2-expected.txt: Added.
  • fast/html/details-no-summary3-expected.txt: Added.
  • fast/html/details-open1-expected.txt: Added.
  • fast/html/details-open3-expected.txt: Added.
  • fast/html/details-open5-expected.txt: Added.
  • fast/html/details-open6-expected.txt: Added.
  • fast/html/details-remove-child-1-expected.txt: Added.
  • fast/html/details-remove-child-2-expected.txt: Added.
  • fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • fast/html/details-remove-summary-1-expected.txt: Added.
  • fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • fast/html/details-remove-summary-2-expected.txt: Added.
  • fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • fast/html/details-remove-summary-3-expected.txt: Added.
  • fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • fast/html/details-remove-summary-4-expected.txt: Added.
  • fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • fast/html/details-remove-summary-5-expected.txt: Added.
  • fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • fast/html/details-remove-summary-6-expected.txt: Added.
  • fast/html/details-remove-summary-child-1-expected.txt: Added.
  • fast/html/details-remove-summary-child-2-expected.txt: Added.
  • fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-linux/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
  • platform/chromium-linux/css2.1/t100801-c544-valgn-01-d-ag-expected.txt: Added.
  • platform/chromium-linux/fast/forms/form-associated-element-crash3-expected.png: Added.
  • platform/chromium-linux/fast/forms/form-associated-element-crash3-expected.txt: Added.
  • platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
  • platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/007-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-mac/fast/forms/007-expected.png:
  • platform/chromium-mac/fast/forms/007-expected.txt:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac/fast/html/details-nested-1-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac/fast/html/details-nested-2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.txt:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.txt:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.txt:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.txt:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.txt:
  • platform/chromium-mac/fast/html/details-open6-expected.png:
  • platform/chromium-mac/fast/html/details-open6-expected.txt:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.txt:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium-win-xp/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-win/fast/forms/007-expected.png:
  • platform/chromium-win/fast/forms/basic-buttons-expected.png:
  • platform/chromium-win/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-win/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
  • platform/chromium-win/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/textarea-metrics-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-nested-1-expected.png:
  • platform/chromium-win/fast/html/details-nested-2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary1-expected.png:
  • platform/chromium-win/fast/html/details-no-summary2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary3-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open1-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open3-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open5-expected.png:
  • platform/chromium-win/fast/html/details-open6-expected.png:
  • platform/chromium-win/fast/html/details-position-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.png:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Removed.
  • platform/efl/css2.1/t100801-c544-valgn-01-d-ag-expected.txt: Removed.
  • platform/efl/css3/flexbox/flexbox-baseline-expected.txt: Removed.
  • platform/efl/fast/html/details-add-child-1-expected.txt: Removed.
  • platform/efl/fast/html/details-add-child-2-expected.txt: Removed.
  • platform/efl/fast/html/details-add-details-child-1-expected.txt: Removed.
  • platform/efl/fast/html/details-add-details-child-2-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-1-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-10-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-2-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-3-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-4-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-5-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-6-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-7-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-8-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-9-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-child-1-expected.txt: Removed.
  • platform/efl/fast/html/details-add-summary-child-2-expected.txt: Removed.
  • platform/efl/fast/html/details-nested-1-expected.txt: Removed.
  • platform/efl/fast/html/details-no-summary1-expected.txt: Removed.
  • platform/efl/fast/html/details-no-summary2-expected.txt: Removed.
  • platform/efl/fast/html/details-no-summary3-expected.txt: Removed.
  • platform/efl/fast/html/details-open1-expected.txt: Removed.
  • platform/efl/fast/html/details-open3-expected.txt: Removed.
  • platform/efl/fast/html/details-open5-expected.txt: Removed.
  • platform/efl/fast/html/details-open6-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-child-1-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-child-2-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-1-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-2-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-3-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-4-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-5-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-6-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-child-1-expected.txt: Removed.
  • platform/efl/fast/html/details-remove-summary-child-2-expected.txt: Removed.
  • platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/efl/tables/mozilla/bugs/bug30692-expected.txt: Removed.
  • platform/gtk/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Removed.
  • platform/gtk/css2.1/t100801-c544-valgn-01-d-ag-expected.txt: Removed.
  • platform/gtk/css3/flexbox: Removed.
  • platform/gtk/css3/flexbox/flexbox-baseline-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-child-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-child-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-10-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-3-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-4-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-5-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-6-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-7-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-8-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-9-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-child-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-summary-child-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-nested-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-no-summary1-expected.txt: Removed.
  • platform/gtk/fast/html/details-no-summary2-expected.txt: Removed.
  • platform/gtk/fast/html/details-no-summary3-expected.txt: Removed.
  • platform/gtk/fast/html/details-open1-expected.txt: Removed.
  • platform/gtk/fast/html/details-open3-expected.txt: Removed.
  • platform/gtk/fast/html/details-open5-expected.txt: Removed.
  • platform/gtk/fast/html/details-open6-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-child-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-child-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-3-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-4-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-5-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-6-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-child-1-expected.txt: Removed.
  • platform/gtk/fast/html/details-remove-summary-child-2-expected.txt: Removed.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug30692-expected.txt: Removed.
  • svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • tables/mozilla/bugs/bug30692-expected.txt: Added.
12:52 PM Changeset in webkit [131215] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Build fix after r131213

Removed an unused variable that was making compilers unhappy.

  • heap/GCThread.cpp:

(JSC::GCThread::GCThread):

  • heap/GCThread.h:

(GCThread):

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData):

12:48 PM Changeset in webkit [131214] by simonjam@chromium.org
  • 28 edits in trunk

[RequestAnimationFrame] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=99116

Reviewed by Adam Barth.

Source/WebCore:

Test: Existing rAF tests without prefix.

  • dom/Document.cpp:

(WebCore::Document::requestAnimationFrame):
(WebCore::Document::cancelAnimationFrame):

  • dom/Document.h:

(Document):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::requestAnimationFrame):
(WebCore::DOMWindow::cancelAnimationFrame):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/animation/request-animation-frame-callback-id.html:
  • fast/animation/request-animation-frame-cancel-expected.txt:
  • fast/animation/request-animation-frame-detach-element.html:
  • fast/animation/request-animation-frame-detach-element2.html:
  • fast/animation/request-animation-frame-during-modal.html:
  • fast/animation/request-animation-frame-iframe2.html:
  • fast/animation/request-animation-frame-missing-arguments-expected.txt:
  • fast/animation/request-animation-frame-missing-arguments.html:
  • fast/animation/script-tests/request-animation-frame-cancel.js:

(window):

  • fast/animation/script-tests/request-animation-frame-cancel2.js:
  • fast/animation/script-tests/request-animation-frame-disabled.js:
  • fast/animation/script-tests/request-animation-frame-subframe.html:
  • fast/animation/script-tests/request-animation-frame-timestamps-advance.js:

(window.requestAnimationFrame):

  • fast/animation/script-tests/request-animation-frame-timestamps.js:
  • fast/animation/script-tests/request-animation-frame-within-callback.js:

(window):

  • fast/animation/script-tests/request-animation-frame.js:
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js:

(BrowserPaint):

  • fast/canvas/webgl/webgl-texture-binding-preserved.html:
  • fast/dom/Window/post-message-crash.html:
  • inspector/timeline/timeline-animation-frame.html:
12:38 PM Changeset in webkit [131213] by mhahnenberg@apple.com
  • 28 edits
    5 adds in trunk/Source/JavaScriptCore

Copying collection shouldn't require O(live bytes) memory overhead
https://bugs.webkit.org/show_bug.cgi?id=98792

Reviewed by Filip Pizlo.

Currently our copying collection occurs simultaneously with the marking phase. We'd like
to be able to reuse CopiedBlocks as soon as they become fully evacuated, but this is not
currently possible because we don't know the liveness statistics of each old CopiedBlock
until marking/copying has already finished. Instead, we have to allocate additional memory
from the OS to use as our working set of CopiedBlocks while copying. We then return the
fully evacuated old CopiedBlocks back to the block allocator, thus giving our copying phase
an O(live bytes) overhead.

To fix this, we should instead split the copying phase apart from the marking phase. This
way we have full liveness data for each CopiedBlock during the copying phase so that we
can reuse them the instant they become fully evacuated. With the additional liveness data
that each CopiedBlock accumulates, we can add some additional heuristics to the collector.
For example, we can calculate our global Heap fragmentation and only choose to do a copying
phase if that fragmentation exceeds some limit. As another example, we can skip copying
blocks that are already above a particular fragmentation limit, which allows older objects
to coalesce into blocks that are rarely copied.

(CopiedBlock):
(JSC::CopiedBlock::CopiedBlock): Added support for tracking live bytes in a CopiedBlock in a
thread-safe fashion.
(JSC::CopiedBlock::reportLiveBytes): Adds a number of live bytes to the block in a thread-safe
fashion using compare and swap.
(JSC):
(JSC::CopiedBlock::didSurviveGC): Called when a block survives a single GC without being
evacuated. This could be called for a couple reasons: (a) the block was pinned or (b) we
decided not to do any copying. A block can become pinned for a few reasons: (1) a pointer into
the block was found during the conservative scan. (2) the block was deemed full enough to
not warrant any copying. (3) The block is oversize and was found to be live.
(JSC::CopiedBlock::didEvacuateBytes): Called when some number of bytes are copied from this
block. If the number of live bytes ever hits zero, the block will return itself to the
BlockAllocator to be recycled.
(JSC::CopiedBlock::canBeRecycled): Indicates that a block has no live bytes and can be
immediately recycled. This is used for blocks that are found to have zero live bytes at the
beginning of the copying phase.
(JSC::CopiedBlock::shouldEvacuate): This function returns true if the current fragmentation
of the block is above our fragmentation threshold, and false otherwise.
(JSC::CopiedBlock::isPinned): Added an accessor for the pinned flag
(JSC::CopiedBlock::liveBytes):

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::doneFillingBlock): Changed so that we can exchange our filled block for a
fresh block. This avoids the situation where a thread returns its borrowed block, it's the last
borrowed block, so CopiedSpace thinks that copying has completed, and it starts doing all of the
copying phase cleanup. In actuality, the thread wanted another block after returning the current
block. So we allow the thread to atomically exchange its block for another block.
(JSC::CopiedSpace::startedCopying): Added the calculation of global Heap fragmentation to
determine if the copying phase should commence. We include the MarkedSpace in our fragmentation
calculation by assuming that the MarkedSpace is 0% fragmented since we can reuse any currently
free memory in it (i.e. we ignore any internal fragmentation in the MarkedSpace). While we're
calculating the fragmentation of CopiedSpace, we also return any free blocks we find along the
way (meaning liveBytes() == 0).
(JSC):
(JSC::CopiedSpace::doneCopying): We still have to iterate over all the blocks, regardless of
whether the copying phase took place or not so that we can reset all of the live bytes counters
and un-pin any pinned blocks.

  • heap/CopiedSpace.h:

(CopiedSpace):
(JSC::CopiedSpace::shouldDoCopyPhase):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::recycleEvacuatedBlock): This function is distinct from recycling a borrowed block
because a borrowed block hasn't been added to the CopiedSpace yet, but an evacuated block is still
currently in CopiedSpace, so we have to make sure we properly remove all traces of the block from
CopiedSpace before returning it to BlockAllocator.
(JSC::CopiedSpace::recycleBorrowedBlock): Renamed to indicate the distinction mentioned above.

  • heap/CopyVisitor.cpp: Added.

(JSC):
(JSC::CopyVisitor::CopyVisitor):
(JSC::CopyVisitor::copyFromShared): Main function for any thread participating in the copying phase.
Grabs chunks of MarkedBlocks from the shared list and copies the backing store of anybody who needs
it until there are no more chunks to copy.

  • heap/CopyVisitor.h: Added.

(JSC):
(CopyVisitor):

  • heap/CopyVisitorInlineMethods.h: Added.

(JSC):
(GCCopyPhaseFunctor):
(JSC::GCCopyPhaseFunctor::GCCopyPhaseFunctor):
(JSC::GCCopyPhaseFunctor::operator()):
(JSC::CopyVisitor::checkIfShouldCopy): We don't have to check shouldEvacuate() because all of those
checks are done during the marking phase.
(JSC::CopyVisitor::allocateNewSpace):
(JSC::CopyVisitor::allocateNewSpaceSlow):
(JSC::CopyVisitor::startCopying): Initialization function for a thread that is about to start copying.
(JSC::CopyVisitor::doneCopying):
(JSC::CopyVisitor::didCopy): This callback is called by an object that has just successfully copied its
backing store. It indicates to the CopiedBlock that somebody has just finished evacuating some number of
bytes from it, and, if the CopiedBlock now has no more live bytes, can be recycled immediately.

  • heap/GCThread.cpp: Added.

(JSC):
(JSC::GCThread::GCThread): This is a new class that encapsulates a single thread responsible for participating
in a specific set of GC phases. Currently, that set of phases includes Mark, Copy, and Exit. Each thread
monitors a shared variable in its associated GCThreadSharedData. The main thread updates this m_currentPhase
variable as collection progresses through the various phases. Parallel marking still works exactly like it
has. In other words, the "run loop" for each of the GC threads sits above any individual phase, thus keeping
the separate phases of the collector orthogonal.
(JSC::GCThread::threadID):
(JSC::GCThread::initializeThreadID):
(JSC::GCThread::slotVisitor):
(JSC::GCThread::copyVisitor):
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):
(JSC::GCThread::gcThreadStartFunc):

  • heap/GCThread.h: Added.

(JSC):
(GCThread):

  • heap/GCThreadSharedData.cpp: The GCThreadSharedData now has a list of GCThread objects rather than raw

ThreadIdentifiers.
(JSC::GCThreadSharedData::resetChildren):
(JSC::GCThreadSharedData::childVisitCount):
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
(JSC::GCThreadSharedData::didStartMarking): Callback to let the GCThreadSharedData know that marking has
started and updates the m_currentPhase variable and notifies the GCThreads accordingly.
(JSC::GCThreadSharedData::didFinishMarking): Ditto for finishing marking.
(JSC::GCThreadSharedData::didStartCopying): Ditto for starting the copying phase.
(JSC::GCThreadSharedData::didFinishCopying): Ditto for finishing copying.

  • heap/GCThreadSharedData.h:

(JSC):
(GCThreadSharedData):
(JSC::GCThreadSharedData::getNextBlocksToCopy): Atomically gets the next chunk of work for a copying thread.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC):
(JSC::Heap::copyBackingStores): Responsible for setting up the copying phase, notifying the copying threads,
and doing any copying work if necessary.
(JSC::Heap::collect):

  • heap/Heap.h:

(Heap):
(JSC):
(JSC::CopyFunctor::CopyFunctor):
(CopyFunctor):
(JSC::CopyFunctor::operator()):

  • heap/IncrementalSweeper.cpp: Changed the incremental sweeper to have a reference to the list of MarkedBlocks

that need sweeping, since this now resides in the Heap so that it can be easily shared by the GCThreads.
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::startSweeping):

  • heap/IncrementalSweeper.h:

(JSC):
(IncrementalSweeper):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::setup):
(JSC::SlotVisitor::drainFromShared): We no longer do any copying-related work here.
(JSC):

  • heap/SlotVisitor.h:

(SlotVisitor):

  • heap/SlotVisitorInlineMethods.h:

(JSC):
(JSC::SlotVisitor::copyLater): Notifies the CopiedBlock that there are some live bytes that may need
to be copied.

  • runtime/Butterfly.h:

(JSC):
(Butterfly):

  • runtime/ButterflyInlineMethods.h:

(JSC::Butterfly::createUninitializedDuringCollection): Uses the new CopyVisitor.

  • runtime/ClassInfo.h:

(MethodTable): Added new "virtual" function copyBackingStore to method table.
(JSC):

  • runtime/JSCell.cpp:

(JSC::JSCell::copyBackingStore): Default implementation that does nothing.
(JSC):

  • runtime/JSCell.h:

(JSC):
(JSCell):

  • runtime/JSObject.cpp:

(JSC::JSObject::copyButterfly): Does the actual copying of the butterfly.
(JSC):
(JSC::JSObject::visitButterfly): Calls copyLater for the butterfly.
(JSC::JSObject::copyBackingStore):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSCell::methodTable):
(JSC::JSCell::inherits):

  • runtime/Options.h: Added two new constants, minHeapUtilization and minCopiedBlockUtilization,

to govern the amount of fragmentation we allow before doing copying.
(JSC):

12:35 PM Changeset in webkit [131212] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-12

  • DEPS:
12:34 PM Changeset in webkit [131211] by roger_fong@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed. Get rid of an accidental conflict marker in WebCore/ChangeLog.

12:22 PM Changeset in webkit [131210] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG array allocation calls should not return an encoded JSValue
https://bugs.webkit.org/show_bug.cgi?id=99196

Reviewed by Mark Hahnenberg.

The array allocation operations now return a pointer instead. This makes it
easier to share code between 32-bit and 64-bit.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:19 PM Changeset in webkit [131209] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION: Rapid memory growth calling DOM APIs with large strings.
<http://webkit.org/b/98498>
<rdar://problem/12443926>

Reviewed by Geöff Gären and Änders Cärlssön.

Prevent the selector query cache from growing indefinitely by setting a relaxed limit of 256 entries.
If the cache fills up, remove a random entry before inserting a new one.

While this is unlikely to be a problem on real websites, we definitely shouldn't be adding boundless
caches to WebKit.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

12:09 PM Changeset in webkit [131208] by eae@chromium.org
  • 1 edit
    8 deletes in trunk/LayoutTests

Unreviewed chromium lucid rebaseline for r131202.

  • platform/chromium-linux-x86/svg/as-border-image: Removed.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/as-border-image: Removed.
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-win-xp/svg/as-border-image: Removed.
  • platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Removed.
12:03 PM Changeset in webkit [131207] by eae@chromium.org
  • 231 edits
    3 adds
    3 deletes in trunk/LayoutTests

Unreviewed chromium mac rebaseline for r131202.

  • platform/chromium-linux-x86/fast/block/float: Removed.
  • platform/chromium-linux-x86/fast/block/float/float-avoidance-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.txt:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.txt:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.txt:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
  • platform/chromium-mac/fast/block/float/032-expected.txt:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.txt:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.txt:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.txt:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-win-xp/fast/block/float: Removed.
  • platform/chromium-win-xp/fast/block/float/float-avoidance-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs: Removed.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
12:00 PM Changeset in webkit [131206] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Update method signature for platformCALayerShowRepaintCounter in MediaPlayerPlayerPrivateAVFoundationCF's LayerClient class.
https://bugs.webkit.org/show_bug.cgi?id=99190

Reviewed by Simon Fraser.

LayerClient's base class (PlatformCALayerClient) method signature for abstract method platformCALayerShowRepaintCounter
was updated in http://trac.webkit.org/changeset/130676 so it needs to be changed in LayerClient as well.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerShowRepaintCounter):

11:46 AM Changeset in webkit [131205] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Local disable of stack corruption warning when compiling on VS2012
https://bugs.webkit.org/show_bug.cgi?id=99106

Patch by Scott Graham <scottmg@chromium.org> on 2012-10-12
Reviewed by Ryosuke Niwa.

Warning is:

...\FEConvolveMatrix.cpp(274) : warning C4789: buffer 'totals' of size 12 bytes will be overrun; 4 bytes will be written starting at offset 12.

And similar at lines 281, 355, and 365. This appears to be incorrect
as the writes at offset 12 occur only when preserveAlphaValues is
false, and when it's false, totals will be 16 bytes long.

No new tests.

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore):

11:38 AM Changeset in webkit [131204] by rwlbuis@webkit.org
  • 3 edits
    6 adds in trunk

[BlackBerry] Add tests of WebSocketEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=84982

Reviewed by Yong Li.

Tools:

Allow WebSocketsEnabled preference setting.

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::overridePreference):

LayoutTests:

  • platform/blackberry/http/tests/websocket/tests/enable-disable-setting-expected.txt: Added.
  • platform/blackberry/http/tests/websocket/tests/enable-disable-setting.html: Added.
11:30 AM Changeset in webkit [131203] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop using deprecatedSend inside ConnectionMac.cpp
https://bugs.webkit.org/show_bug.cgi?id=99192

Reviewed by Andreas Kling.

The messages that we send are so simple that we can just use sendMessage.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

11:10 AM Changeset in webkit [131202] by eae@chromium.org
  • 179 edits in trunk

[Sub pixel layout] Change RenderBox to not round logicalTop/Left for RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=99108

Reviewed by Levi Weintraub.

Source/WebCore:

Change RenderBox::computePositionedLogicalHeightReplaced and
computePositionedLogicalWidthReplaced to not round position.

Covered by existing tests.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Floor baselinePosition for replaced elements to match logic in
RootInlineBox::ascentAndDescentForBox where the ascent is
computed from the floored baselinePosition.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
Remove .round() call for m_position, preserving precision.

LayoutTests:

Update tests expectations to reflect more correct rounding behavior.
Specifically many images and other replaced content is no longer rendered at y -1.

  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/html/details-add-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-marker-style-expected.png:
  • platform/chromium-linux/fast/html/details-nested-1-expected.png:
  • platform/chromium-linux/fast/html/details-nested-2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open1-expected.png:
  • platform/chromium-linux/fast/html/details-open2-expected.png:
  • platform/chromium-linux/fast/html/details-open3-expected.png:
  • platform/chromium-linux/fast/html/details-open4-expected.png:
  • platform/chromium-linux/fast/html/details-open5-expected.png:
  • platform/chromium-linux/fast/html/details-open6-expected.png:
  • platform/chromium-linux/fast/html/details-position-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-linux/fast/html/details-replace-text-expected.png:
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-linux/fast/repaint/reflection-repaint-test-expected.png:
  • platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.png:
  • platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/chromium-linux/fast/repaint/transform-layout-repaint-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/box-sizing/box-sizing-expected.txt:
  • platform/chromium-win/fast/forms/007-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.txt:
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open1-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open3-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-open5-expected.txt:
  • platform/chromium-win/fast/html/details-open6-expected.txt:
  • platform/chromium-win/fast/html/details-position-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-win/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
11:08 AM Changeset in webkit [131201] by jer.noble@apple.com
  • 19 edits
    3 adds in trunk

Enable ENCRYPTED_MEDIA support on Mac.
https://bugs.webkit.org/show_bug.cgi?id=98044

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Enable the ENCRYPTED_MEDIA flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enable the ENCRYPTED_MEDIA conditional on the Mac port.

No new tests; Existing media/encrypted-media tests require org.w3.clearkey support, which is not implemented.

  • Configurations/FeatureDefines.xcconfig: Enable the ENCRYPTED_MEDIA flag.
  • DerivedSources.make: Add the MediaKeyError and MediaKeyEvent classes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add convertValue functions for Uint8Array and MediaKeyError.

  • bindings/js/JSDictionary.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded): Throw an error if no "needkey"

handler is registered.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl: Change keySystem to DefaultIsUndefined.
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyNeeded): Return a bool indicating whether the process was aborted

due to a lack of "needkey" listener.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerKeyAdded): Remove unused parameter names.
(WebCore::MediaPlayerClient::mediaPlayerKeyError): Ditto.
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage): Ditto.
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded): Ditto.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::addKey): Ditto.
(WebCore::MediaPlayerPrivateInterface::generateKeyRequest): Ditto.
(WebCore::MediaPlayerPrivateInterface::cancelKeyRequest): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine): Call extendedSupportsType.
(WebCore::MediaPlayerPrivateAVFoundationObjC::extendedSupportsType): Stub. Pass through to supportsType.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Call extendedSupportsType.
(WebCore::MediaPlayerPrivateQTKit::extendedSupportsType): Stub. Pass through to supportsType.

LayoutTests:

Add platform specific expected results.

  • platform/mac/fast/events/constructors/media-key-event-constructor-expected.txt: Added.
  • platform/chromium/fast/events/constructors/media-key-event-constructor-expected.txt: Copied from

fast/events/constructors/media-key-event-constructor-expected.txt due to chromium expected results
search order including platform/mac.

11:02 AM Changeset in webkit [131200] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move some WontFix tests to the right place in the file, and add
some ImageOnlyFailures that showed up after updating Cairo to
1.12.4.

  • platform/efl/TestExpectations:
10:48 AM Changeset in webkit [131199] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. It should be possible to build JSC on ARMv7.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::patchableBranchPtr):

10:33 AM Changeset in webkit [131198] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Check parameter's safety first
https://bugs.webkit.org/show_bug.cgi?id=99136

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-12
Reviewed by Chris Rogers.

Pointer parameter was used before NULL checking.
This patch moves safety checking statements to the head of the function.

No new tests. No behavior change.

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::copyFromRange):
(WebCore::AudioChannel::sumFrom):

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan):

10:13 AM Changeset in webkit [131197] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt: Updated.
  • platform/qt/TestExpectations: Skip a flakey test.
10:13 AM Changeset in webkit [131196] by beidson@apple.com
  • 9 edits
    11 adds in trunk/Source/WebKit2

Add a basic NetworkProcess.app to the WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=98543

Reviewed by Sam Weinig.

This change sets up the Mac build to include a NetworkProcess.app.
It also launches this app when the first WebProcess is created.
It then quits this app when the UIProcess terminates.

The app, it does nothing.

-McBain

Pure project file/build system stuff:

  • Configurations/NetworkProcess.xcconfig: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2Prefix.h:

Basic UIProcess side of things:

  • UIProcess/Network/NetworkProcessProxy.cpp: Added.

(WebKit):
(WebKit::NetworkProcessProxy::create):
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
(WebKit::NetworkProcessProxy::syncMessageSendTimedOut):
(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h: Added.

(WebKit):
(NetworkProcessProxy):

Basic NetworkProcess side of things:

  • NetworkProcess/Info.plist: Added.
  • NetworkProcess/NetworkProcess.cpp: Added.

(WebKit):
(WebKit::NetworkProcess::shared):
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::~NetworkProcess):
(WebKit::NetworkProcess::initialize):
(WebKit::NetworkProcess::shouldTerminate):
(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):
(WebKit::NetworkProcess::syncMessageSendTimedOut):

  • NetworkProcess/NetworkProcess.h: Added.

(WebCore):
(WebKit):
(NetworkProcess):

Add the main method for the NetworkProcess itself:

  • WebProcess/WebKitMain.cpp:

(WebKitMain):

  • NetworkProcess/NetworkProcessMain.h: Added.

(WebKit):

  • NetworkProcess/mac/NetworkProcessMainMac.mm: Added.

(WebKit):
(WebKit::NetworkProcessMain):

Teach ProcessLauncher about the new app type:

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::createProcess):

Launch the NetworkProcess when we launch the first WebProcess:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):

  • UIProcess/WebContext.h:

(WebContext):

9:58 AM Changeset in webkit [131195] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderBR should share its constant newline string between instances.
<http://webkit.org/b/99121>

Reviewed by Anders Carlsson.

  • rendering/RenderBR.cpp:

(WebCore::newlineString):
(WebCore::RenderBR::RenderBR):

9:57 AM Changeset in webkit [131194] by abarth@webkit.org
  • 17 edits
    37 deletes in trunk/LayoutTests

More baselines updates after http://trac.webkit.org/changeset/131134.
It seems http://trac.webkit.org/changeset/131158 wasn't quite complete.

  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/text/bidi-text-query-expected.txt: Removed.
  • platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/text/bidi-text-query-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-win-xp/svg/text/bidi-text-query-expected.txt: Removed.
9:57 AM Changeset in webkit [131193] by commit-queue@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r131189.
http://trac.webkit.org/changeset/131189
https://bugs.webkit.org/show_bug.cgi?id=99187

Made inspector http tests crash on WK2. (Requested by rakuco
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-12

.:

  • Source/PlatformEfl.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WebKit:

  • PlatformEfl.cmake:

Source/WebKit2:

  • PlatformEfl.cmake:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

9:49 AM Changeset in webkit [131192] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that this test is flaky.

  • platform/chromium/TestExpectations:
9:35 AM Changeset in webkit [131191] by rakuco@webkit.org
  • 50 edits
    5 adds in trunk/LayoutTests

[EFL] More pixel expectations and gardening.

Skip some pixel tests which are failing in WK1 and add correct PNG
baselines for quite a few tests which render correctly in WK2.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-in-composited-expected.png:
  • platform/efl/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/efl/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/efl/compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
  • platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.png:
  • platform/efl/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/efl/fast/dynamic/anchor-lock-expected.png:
  • platform/efl/fast/events/autoscroll-expected.png:
  • platform/efl/fast/events/reveal-link-when-focused-expected.png:
  • platform/efl/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/efl/fast/multicol/scrolling-overflow-expected.png:
  • platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
  • platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/efl/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/efl/fast/overflow/scrollRevealButton-expected.png:
  • platform/efl/fast/repaint/absolute-position-changed-expected.png:
  • platform/efl/fast/repaint/fixed-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
  • platform/efl/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-expected.png:
  • platform/efl/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-scale-expected.png:
  • platform/efl/fast/repaint/fixed-scroll-simple-expected.png:
  • platform/efl/fast/repaint/fixed-table-cell-expected.png:
  • platform/efl/fast/repaint/fixed-table-overflow-expected.png:
  • platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png:
  • platform/efl/fast/repaint/fixed-tranformed-expected.png:
  • platform/efl/fast/repaint/repaint-during-scroll-expected.png:
  • platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png:
  • platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png:
  • platform/efl/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/efl/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/efl/fast/text/justify-ideograph-complex-expected.png:
  • platform/efl/fast/text/large-text-composed-char-expected.png:
  • platform/efl/http/tests/loading/simple-subframe-expected.png: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1647-expected.png: Added.
9:27 AM Changeset in webkit [131190] by rakuco@webkit.org
  • 5 edits in trunk/LayoutTests

[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=99184

Unreviewed EFL gardening.

Skip failing tests on WK2 debug bot. Also, unskip tests that are
consistently passing.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-12

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/http/tests/loading/text-content-type-with-binary-extension-expected.txt:
  • platform/efl/TestExpectations:
9:19 AM Changeset in webkit [131189] by ryuan.choi@samsung.com
  • 8 edits in trunk

[EFL] Share resources installed for inspector
https://bugs.webkit.org/show_bug.cgi?id=98991

Reviewed by Gyuyoung Kim.

.:

Now, WebKit1/Efl and WebKit2/Efl install same resources to different directory
when INSPECTOR is enabled.

This patch changes to install resources one time and share it.

  • Source/PlatformEfl.cmake:

Extracted build scripts which install resources from WebKit/PlatformEfl.cmake.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit:

  • PlatformEfl.cmake:

Extracted build scripts which install resources to WebKit/PlatformEfl.cmake.

Source/WebKit2:

  • PlatformEfl.cmake: Removed build script which install resources to share.
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL): Modified not to use makeString.
(WebKit::WebInspectorProxy::inspectorBaseURL): Changed resource path.

8:25 AM Changeset in webkit [131188] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline inspector/styles/region-style-crash.html after r131176.

  • inspector/styles/region-style-crash-expected.txt:
8:18 AM Changeset in webkit [131187] by apavlov@chromium.org
  • 6 edits in trunk

Web Inspector: [Styles] !important priority not honored inside the same declaration
https://bugs.webkit.org/show_bug.cgi?id=99170

Reviewed by Yury Semikhatsky.

Source/WebCore:

Property priorities were not considered inside the same CSS rule. !important properties should stay active
even if followed by non-!important properties with the same name.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/resources/elements-panel-styles.css:

(.foo):

8:12 AM Changeset in webkit [131186] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=99176

Unreviewed EFL gardening.

Skip failing tests in order to make the bots green.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-12

  • platform/efl/TestExpectations:
7:20 AM Changeset in webkit [131185] by tommyw@google.com
  • 2 edits in trunk/Tools

Creating a MediaStream subscription in watchlist
https://bugs.webkit.org/show_bug.cgi?id=99172

Reviewed by Yuta Kitamura.

  • Scripts/webkitpy/common/config/watchlist:
6:51 AM Changeset in webkit [131184] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: use hard-coded zoom factors instead of 1.2 powers.
https://bugs.webkit.org/show_bug.cgi?id=99173

Reviewed by Vsevolod Vlasov.

Overwise we step too fast.

  • inspector/front-end/inspector.js:

(WebInspector._zoomIn):
(WebInspector._zoomOut):
(WebInspector):

6:16 AM WebInspector edited by doris.greys@gmail.com
(diff)
6:11 AM Changeset in webkit [131183] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: move delete watch expression farther from the expand triangle
https://bugs.webkit.org/show_bug.cgi?id=99166

Reviewed by Pavel Feldman.

Aligned 'delete watch expression' button on the right side (was on the left) so
that it is hard to click it when expanding watched value.

  • inspector/front-end/inspector.css:

(.properties-tree.watch-expressions):
(.section .properties .delete-button):

6:08 AM Changeset in webkit [131182] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: trim filename in the call stack sidebar
https://bugs.webkit.org/show_bug.cgi?id=99169

Reviewed by Yury Semikhatsky.

Otherwise long file names are rendered poorly.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.Placard.prototype._update):

  • inspector/front-end/inspector.css:

(.placard .subtitle):

6:01 AM Changeset in webkit [131181] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Resume button in element inspector -> scripts has tooltip 'pause script execution'
https://bugs.webkit.org/show_bug.cgi?id=99165

Reviewed by Pavel Feldman.

Pause/resume button title is now updated when debugger is paused/resumed.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._updateButtonTitle):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):

5:46 AM Changeset in webkit [131180] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed. Fix run-binding-tests failures introduced in r131167.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):
(WebCore::TestObjV8Internal::TestObjConstructorGetter):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::installPerContextPrototypeProperties):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

5:38 AM Changeset in webkit [131179] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=99161

Unskip editing/pasteboard and add test expectations for failing tests.

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-10-12

  • platform/efl/TestExpectations:
5:36 AM Changeset in webkit [131178] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: relies on current Function.prototype.bind in the frame
https://bugs.webkit.org/show_bug.cgi?id=99164

Reviewed by Yury Semikhatsky.

Source/WebCore:

InjectedScriptSource should not depend on the bind override.

Test: inspector/console/console-bind-fake.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/console-bind-fake-expected.txt: Added.
  • inspector/console/console-bind-fake.html: Added.
5:30 AM Changeset in webkit [131177] by Csaba Osztrogonác
  • 2 edits
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files, skip new failing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Added.
5:11 AM Changeset in webkit [131176] by apavlov@chromium.org
  • 11 edits in trunk

Web Inspector: [Styles] Colors should be "As authored" by default
https://bugs.webkit.org/show_bug.cgi?id=99017

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use "original" as the default value of WebInspector.settings.colorFormat.

  • inspector/front-end/Settings.js:

LayoutTests:

Test rebaselines.

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/inject-stylesheet-expected.txt:
  • inspector/styles/lazy-computed-style-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-overriden-properties-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/variables/css-variables-expected.txt:
  • platform/chromium/inspector/styles/inject-stylesheet-expected.txt:
5:05 AM Changeset in webkit [131175] by kbalazs@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r131160.
http://trac.webkit.org/changeset/131160
https://bugs.webkit.org/show_bug.cgi?id=99163

"It should not be landed without it's follow-up because it
break pixal and ref tests without it." (Requested by kbalazs
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-12

Source/WebKit2:

  • Shared/API/c/qt/WKImageQt.cpp:

(WKImageCreateQImage):

  • Shared/API/c/qt/WKImageQt.h:

Tools:

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::windowSnapshotImage):

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

4:59 AM Changeset in webkit [131174] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Serialization of Resource[Request,Response,Error] should be shared across ports
https://bugs.webkit.org/show_bug.cgi?id=90142

Unreviewed buildfix 2.

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

4:50 AM Changeset in webkit [131173] by jochen@chromium.org
  • 2 edits in trunk/Tools

Create a separate gyp target for dependencies of DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=99023

Reviewed by Tony Chang.

This allows for pulling in the fonts and helpers required to run layout
tests in the content_shell without depending on DumpRenderTree.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4:44 AM Changeset in webkit [131172] by commit-queue@webkit.org
  • 602 edits in trunk/Source/WebCore

[WebKit IDL] move extended attributes to left of interface, exception...
https://bugs.webkit.org/show_bug.cgi?id=99012

Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-12
Reviewed by Kentaro Hara.

According to WebIDL spec, moved all extended attributes to the left
of interface / attribute / readonly attribute / exception.

No new tests. I ran run-bindings-tests and all tests passed.

  • Modules/battery/BatteryManager.idl:
  • Modules/battery/NavigatorBattery.idl:
  • Modules/filesystem/DOMFileSystem.idl:
  • Modules/filesystem/DOMFileSystemSync.idl:
  • Modules/filesystem/DOMWindowFileSystem.idl:
  • Modules/filesystem/DataTransferItemFileSystem.idl:
  • Modules/filesystem/DirectoryEntry.idl:
  • Modules/filesystem/DirectoryEntrySync.idl:
  • Modules/filesystem/DirectoryReader.idl:
  • Modules/filesystem/DirectoryReaderSync.idl:
  • Modules/filesystem/EntriesCallback.idl:
  • Modules/filesystem/Entry.idl:
  • Modules/filesystem/EntryArray.idl:
  • Modules/filesystem/EntryArraySync.idl:
  • Modules/filesystem/EntryCallback.idl:
  • Modules/filesystem/EntrySync.idl:
  • Modules/filesystem/ErrorCallback.idl:
  • Modules/filesystem/FileCallback.idl:
  • Modules/filesystem/FileEntry.idl:
  • Modules/filesystem/FileEntrySync.idl:
  • Modules/filesystem/FileSystemCallback.idl:
  • Modules/filesystem/FileWriter.idl:
  • Modules/filesystem/FileWriterCallback.idl:
  • Modules/filesystem/FileWriterSync.idl:
  • Modules/filesystem/HTMLInputElementFileSystem.idl:
  • Modules/filesystem/Metadata.idl:
  • Modules/filesystem/MetadataCallback.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:
  • Modules/gamepad/Gamepad.idl:
  • Modules/gamepad/GamepadList.idl:
  • Modules/gamepad/NavigatorGamepad.idl:
  • Modules/geolocation/Geolocation.idl:
  • Modules/geolocation/Geoposition.idl:
  • Modules/geolocation/NavigatorGeolocation.idl:
  • Modules/geolocation/PositionCallback.idl:
  • Modules/geolocation/PositionError.idl:
  • Modules/geolocation/PositionErrorCallback.idl:
  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/IDBAny.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBCursorWithValue.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBDatabaseException.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKey.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBUpgradeNeededEvent.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/indexeddb/IDBVersionChangeRequest.idl:
  • Modules/indexeddb/WorkerContextIndexedDatabase.idl:
  • Modules/intents/DOMWindowIntents.idl:
  • Modules/intents/DeliveredIntent.idl:
  • Modules/intents/NavigatorIntents.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/IceCallback.idl:
  • Modules/mediastream/IceCandidate.idl:
  • Modules/mediastream/LocalMediaStream.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamEvent.idl:
  • Modules/mediastream/MediaStreamList.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/MediaStreamTrackEvent.idl:
  • Modules/mediastream/MediaStreamTrackList.idl:
  • Modules/mediastream/NavigatorMediaStream.idl:
  • Modules/mediastream/NavigatorUserMediaError.idl:
  • Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
  • Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
  • Modules/mediastream/PeerConnection00.idl:
  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCIceCandidate.idl:
  • Modules/mediastream/RTCIceCandidateEvent.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescription.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCStatsCallback.idl:
  • Modules/mediastream/RTCStatsElement.idl:
  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/RTCStatsResponse.idl:
  • Modules/mediastream/SessionDescription.idl:
  • Modules/navigatorcontentutils/NavigatorContentUtils.idl:
  • Modules/networkinfo/NavigatorNetworkInfoConnection.idl:
  • Modules/networkinfo/NetworkInfoConnection.idl:
  • Modules/notifications/DOMWindowNotifications.idl:
  • Modules/notifications/Notification.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/notifications/NotificationPermissionCallback.idl:
  • Modules/notifications/WorkerContextNotifications.idl:
  • Modules/proximity/DeviceProximityEvent.idl:
  • Modules/quota/DOMWindowQuota.idl:
  • Modules/quota/StorageInfo.idl:
  • Modules/quota/StorageInfoErrorCallback.idl:
  • Modules/quota/StorageInfoQuotaCallback.idl:
  • Modules/quota/StorageInfoUsageCallback.idl:
  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechGrammar.idl:
  • Modules/speech/SpeechGrammarList.idl:
  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionAlternative.idl:
  • Modules/speech/SpeechRecognitionError.idl:
  • Modules/speech/SpeechRecognitionEvent.idl:
  • Modules/speech/SpeechRecognitionResult.idl:
  • Modules/speech/SpeechRecognitionResultList.idl:
  • Modules/vibration/NavigatorVibration.idl:
  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/AudioBufferCallback.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioChannelMerger.idl:
  • Modules/webaudio/AudioChannelSplitter.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioDestinationNode.idl:
  • Modules/webaudio/AudioGain.idl:
  • Modules/webaudio/AudioGainNode.idl:
  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioPannerNode.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/AudioProcessingEvent.idl:
  • Modules/webaudio/AudioSourceNode.idl:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/ConvolverNode.idl:
  • Modules/webaudio/DOMWindowWebAudio.idl:
  • Modules/webaudio/DelayNode.idl:
  • Modules/webaudio/DynamicsCompressorNode.idl:
  • Modules/webaudio/JavaScriptAudioNode.idl:
  • Modules/webaudio/MediaElementAudioSourceNode.idl:
  • Modules/webaudio/MediaStreamAudioSourceNode.idl:
  • Modules/webaudio/OfflineAudioCompletionEvent.idl:
  • Modules/webaudio/Oscillator.idl:
  • Modules/webaudio/RealtimeAnalyserNode.idl:
  • Modules/webaudio/WaveShaperNode.idl:
  • Modules/webaudio/WaveTable.idl:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseCallback.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLError.idl:
  • Modules/webdatabase/SQLException.idl:
  • Modules/webdatabase/SQLResultSet.idl:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLStatementCallback.idl:
  • Modules/webdatabase/SQLStatementErrorCallback.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionCallback.idl:
  • Modules/webdatabase/SQLTransactionErrorCallback.idl:
  • Modules/webdatabase/SQLTransactionSync.idl:
  • Modules/webdatabase/SQLTransactionSyncCallback.idl:
  • Modules/webdatabase/WorkerContextWebDatabase.idl:
  • Modules/websockets/CloseEvent.idl:
  • Modules/websockets/DOMWindowWebSocket.idl:
  • Modules/websockets/WebSocket.idl:
  • Modules/websockets/WorkerContextWebSocket.idl:
  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/TestCustomNamedGetter.idl:
  • bindings/scripts/test/TestDomainSecurity.idl:
  • bindings/scripts/test/TestEventConstructor.idl:
  • bindings/scripts/test/TestEventTarget.idl:
  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestNamedConstructor.idl:
  • bindings/scripts/test/TestNode.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/TestSupplemental.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
  • css/WebKitCSSRegionRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/Attr.idl:
  • dom/BeforeLoadEvent.idl:
  • dom/CharacterData.idl:
  • dom/ClientRectList.idl:
  • dom/Clipboard.idl:
  • dom/CustomEvent.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMNamedFlowCollection.idl:
  • dom/DOMStringList.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/HashChangeEvent.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/MouseEvent.idl:
  • dom/MutationCallback.idl:
  • dom/MutationObserver.idl:
  • dom/MutationRecord.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeIterator.idl:
  • dom/NodeList.idl:
  • dom/Notation.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProcessingInstruction.idl:
  • dom/ProgressEvent.idl:
  • dom/PropertyNodeList.idl:
  • dom/RangeException.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • dom/ShadowRoot.idl:
  • dom/StringCallback.idl:
  • dom/Touch.idl:
  • dom/TouchEvent.idl:
  • dom/TouchList.idl:
  • dom/TreeWalker.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitNamedFlow.idl:
  • dom/WebKitTransitionEvent.idl:
  • editing/DOMTransaction.idl:
  • editing/UndoManager.idl:
  • fileapi/Blob.idl:
  • fileapi/File.idl:
  • fileapi/FileError.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDataListElement.idl:
  • html/HTMLDetailsElement.idl:
  • html/HTMLDialogElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIntentElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLMeterElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLProgressElement.idl:
  • html/HTMLPropertiesCollection.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLSourceElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLTrackElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • html/ImageData.idl:
  • html/MediaController.idl:
  • html/MediaError.idl:
  • html/MediaKeyError.idl:
  • html/MediaKeyEvent.idl:
  • html/MicroDataItemValue.idl:
  • html/RadioNodeList.idl:
  • html/TimeRanges.idl:
  • html/ValidityState.idl:
  • html/VoidCallback.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/CanvasRenderingContext.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/DataView.idl:
  • html/canvas/EXTTextureFilterAnisotropic.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLActiveInfo.idl:
  • html/canvas/WebGLBuffer.idl:
  • html/canvas/WebGLCompressedTextureS3TC.idl:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLDepthTexture.idl:
  • html/canvas/WebGLFramebuffer.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLProgram.idl:
  • html/canvas/WebGLRenderbuffer.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShader.idl:
  • html/canvas/WebGLShaderPrecisionFormat.idl:
  • html/canvas/WebGLTexture.idl:
  • html/canvas/WebGLUniformLocation.idl:
  • html/canvas/WebGLVertexArrayObjectOES.idl:
  • html/shadow/HTMLContentElement.idl:
  • html/shadow/HTMLShadowElement.idl:
  • html/track/TextTrack.idl:
  • html/track/TextTrackCue.idl:
  • html/track/TextTrackCueList.idl:
  • html/track/TextTrackList.idl:
  • html/track/TrackEvent.idl:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorFrontendHost.idl:
  • inspector/JavaScriptCallFrame.idl:
  • inspector/ScriptProfile.idl:
  • inspector/ScriptProfileNode.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/AbstractView.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/Coordinates.idl:
  • page/Crypto.idl:
  • page/DOMSecurityPolicy.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/DOMWindowPagePopup.idl:
  • page/EventSource.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/MemoryInfo.idl:
  • page/Navigator.idl:
  • page/PagePopupController.idl:
  • page/Performance.idl:
  • page/PerformanceEntry.idl:
  • page/PerformanceEntryList.idl:
  • page/PerformanceNavigation.idl:
  • page/PerformanceResourceTiming.idl:
  • page/PerformanceTiming.idl:
  • page/Screen.idl:
  • page/SpeechInputEvent.idl:
  • page/SpeechInputResult.idl:
  • page/SpeechInputResultList.idl:
  • page/WebKitAnimation.idl:
  • page/WebKitAnimationList.idl:
  • page/WebKitPoint.idl:
  • page/WorkerNavigator.idl:
  • plugins/DOMMimeType.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • svg/ElementTimeControl.idl:
  • svg/SVGAElement.idl:
  • svg/SVGAltGlyphDefElement.idl:
  • svg/SVGAltGlyphElement.idl:
  • svg/SVGAltGlyphItemElement.idl:
  • svg/SVGAngle.idl:
  • svg/SVGAnimateColorElement.idl:
  • svg/SVGAnimateElement.idl:
  • svg/SVGAnimateMotionElement.idl:
  • svg/SVGAnimateTransformElement.idl:
  • svg/SVGAnimatedAngle.idl:
  • svg/SVGAnimatedBoolean.idl:
  • svg/SVGAnimatedEnumeration.idl:
  • svg/SVGAnimatedInteger.idl:
  • svg/SVGAnimatedLength.idl:
  • svg/SVGAnimatedLengthList.idl:
  • svg/SVGAnimatedNumber.idl:
  • svg/SVGAnimatedNumberList.idl:
  • svg/SVGAnimatedPreserveAspectRatio.idl:
  • svg/SVGAnimatedRect.idl:
  • svg/SVGAnimatedString.idl:
  • svg/SVGAnimatedTransformList.idl:
  • svg/SVGAnimationElement.idl:
  • svg/SVGCircleElement.idl:
  • svg/SVGClipPathElement.idl:
  • svg/SVGColor.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGCursorElement.idl:
  • svg/SVGDefsElement.idl:
  • svg/SVGDescElement.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGEllipseElement.idl:
  • svg/SVGException.idl:
  • svg/SVGExternalResourcesRequired.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDistantLightElement.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEFuncAElement.idl:
  • svg/SVGFEFuncBElement.idl:
  • svg/SVGFEFuncGElement.idl:
  • svg/SVGFEFuncRElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFEPointLightElement.idl:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFESpotLightElement.idl:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.idl:
  • svg/SVGFitToViewBox.idl:
  • svg/SVGFontElement.idl:
  • svg/SVGFontFaceElement.idl:
  • svg/SVGFontFaceFormatElement.idl:
  • svg/SVGFontFaceNameElement.idl:
  • svg/SVGFontFaceSrcElement.idl:
  • svg/SVGFontFaceUriElement.idl:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGGElement.idl:
  • svg/SVGGlyphElement.idl:
  • svg/SVGGlyphRefElement.idl:
  • svg/SVGGradientElement.idl:
  • svg/SVGHKernElement.idl:
  • svg/SVGImageElement.idl:
  • svg/SVGLangSpace.idl:
  • svg/SVGLength.idl:
  • svg/SVGLengthList.idl:
  • svg/SVGLineElement.idl:
  • svg/SVGLinearGradientElement.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGMPathElement.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.idl:
  • svg/SVGMatrix.idl:
  • svg/SVGMetadataElement.idl:
  • svg/SVGMissingGlyphElement.idl:
  • svg/SVGNumber.idl:
  • svg/SVGNumberList.idl:
  • svg/SVGPaint.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGPathSeg.idl:
  • svg/SVGPathSegArcAbs.idl:
  • svg/SVGPathSegArcRel.idl:
  • svg/SVGPathSegClosePath.idl:
  • svg/SVGPathSegCurvetoCubicAbs.idl:
  • svg/SVGPathSegCurvetoCubicRel.idl:
  • svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
  • svg/SVGPathSegCurvetoCubicSmoothRel.idl:
  • svg/SVGPathSegCurvetoQuadraticAbs.idl:
  • svg/SVGPathSegCurvetoQuadraticRel.idl:
  • svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
  • svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
  • svg/SVGPathSegLinetoAbs.idl:
  • svg/SVGPathSegLinetoHorizontalAbs.idl:
  • svg/SVGPathSegLinetoHorizontalRel.idl:
  • svg/SVGPathSegLinetoRel.idl:
  • svg/SVGPathSegLinetoVerticalAbs.idl:
  • svg/SVGPathSegLinetoVerticalRel.idl:
  • svg/SVGPathSegList.idl:
  • svg/SVGPathSegMovetoAbs.idl:
  • svg/SVGPathSegMovetoRel.idl:
  • svg/SVGPatternElement.idl:
  • svg/SVGPoint.idl:
  • svg/SVGPointList.idl:
  • svg/SVGPolygonElement.idl:
  • svg/SVGPolylineElement.idl:
  • svg/SVGPreserveAspectRatio.idl:
  • svg/SVGRadialGradientElement.idl:
  • svg/SVGRect.idl:
  • svg/SVGRectElement.idl:
  • svg/SVGRenderingIntent.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGScriptElement.idl:
  • svg/SVGSetElement.idl:
  • svg/SVGStopElement.idl:
  • svg/SVGStringList.idl:
  • svg/SVGStylable.idl:
  • svg/SVGStyleElement.idl:
  • svg/SVGSwitchElement.idl:
  • svg/SVGSymbolElement.idl:
  • svg/SVGTRefElement.idl:
  • svg/SVGTSpanElement.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTextElement.idl:
  • svg/SVGTextPathElement.idl:
  • svg/SVGTextPositioningElement.idl:
  • svg/SVGTitleElement.idl:
  • svg/SVGTransform.idl:
  • svg/SVGTransformList.idl:
  • svg/SVGTransformable.idl:
  • svg/SVGURIReference.idl:
  • svg/SVGUnitTypes.idl:
  • svg/SVGUseElement.idl:
  • svg/SVGVKernElement.idl:
  • svg/SVGViewElement.idl:
  • svg/SVGViewSpec.idl:
  • svg/SVGZoomAndPan.idl:
  • svg/SVGZoomEvent.idl:
  • testing/InternalSettings.idl:
  • testing/Internals.idl:
  • testing/MallocStatistics.idl:
  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
  • workers/WorkerLocation.idl:
  • xml/DOMParser.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathException.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • xml/XSLTProcessor.idl:

Moved extended attributes.

4:23 AM Changeset in webkit [131171] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: never expand global scope automatically
https://bugs.webkit.org/show_bug.cgi?id=99159

Reviewed by Vsevolod Vlasov.

Otherwise, stepping is slow.

  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

4:22 AM Changeset in webkit [131170] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Serialization of Resource[Request,Response,Error] should be shared across ports
https://bugs.webkit.org/show_bug.cgi?id=90142

Unreviewed buildfix.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::decode):

4:19 AM Changeset in webkit [131169] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Refactor UISourceCode, make it possible to distinguish working copy changes/commits from formatting.
https://bugs.webkit.org/show_bug.cgi?id=98911

Reviewed by Pavel Feldman.

ContentChanged was dispatched both when working copy was committed and UISourceCode was formatted before.
WorkingCopyChanged event was dispatched when working copy was set.
Now there are three explicit events: WorkingCopyChanged, WorkingCopyCommitted, FormattedChanged.
No events are dispatched now during revisions restoring.
Reverting to revisions is now implemented based on the working copy editing.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onWorkingCopyChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onWorkingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._innerSetContent):
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.NavigatorView.prototype._uiSourceCodeFormattedChanged):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._addUISourceCodeListeners):
(WebInspector.TabbedEditorContainer.prototype._removeUISourceCodeListeners):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeFormattedChanged):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.addRevision):
(WebInspector.UISourceCode.prototype._restoreRevisionHistory):
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.Revision.prototype.revertToThis):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame):
(WebInspector.UISourceCodeFrame.prototype.onTextChanged):
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
(WebInspector.UISourceCodeFrame.prototype._onWorkingCopyChanged):
(WebInspector.UISourceCodeFrame.prototype._onWorkingCopyCommitted):
(WebInspector.UISourceCodeFrame.prototype._innerSetContent):

4:14 AM Changeset in webkit [131168] by kbalazs@webkit.org
  • 10 edits in trunk/Source

[WK2] Serialization of Resource[Request,Response,Error] should be shared across ports
https://bugs.webkit.org/show_bug.cgi?id=90142

Reviewed by Simon Hausmann.

Source/WebCore:

Added a setter for the certificate of ResourceError.

No change in behavior so no new tests.

  • platform/network/cf/ResourceError.h:

(ResourceError):

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore):
(WebCore::ResourceError::setCertificate):

Source/WebKit2:

Share common serialization code across Qt and soup ports.
All of these ports serialize the WebCore representation
of these types.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

3:29 AM Changeset in webkit [131167] by morrita@google.com
  • 34 edits in trunk/Source/WebCore

[V8] PerContextEnabled methods should be installed when the constructor is created
https://bugs.webkit.org/show_bug.cgi?id=99129

Reviewed by Kentaro Hara.

Before this change, generated installPerContextProperties() method
injected both per-context attributes and functions, and functions
were injected into the prototye object. This means that the
functions are injected into the prototype repeatedly for each
intance creation. This injection can be happened only once per
prototype object, which is clearer and is faster.

This change introduces installPerContextPrototypeProperties()
generated method, which is designed to be called for each time when the prototype
object is created.

To do that, WrapperTypeInfo is extended to hold an additional
function pointer to an installPerContextPrototypeProperties()
implementation so that we call it from V8PerContextData::constructorForTypeSlowCase(),
where the prototype instance is created.

Other changes:

  • Added some modification to pass around the parameter to constructorForTypeSlowCase().
  • installPerContextProperties() are now always generated for simplicity. Empty implementations are inlined thus no speed penalty.

No new tests. Covered by existing tests.

  • Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::document):

  • Modules/notifications/NotificationCenter.h:

(NotificationCenter):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateConstructorGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation): Extracted per-context function additions to new installPerContextPrototypeProperties() function.
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):
(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::installPerContextProperties):
(WebCore::V8Float64Array::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):
(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::installPerContextProperties):
(WebCore::V8TestActiveDOMObject::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):
(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::installPerContextProperties):
(WebCore::V8TestCustomNamedGetter::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):
(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::installPerContextProperties):
(WebCore::V8TestEventConstructor::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):
(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::installPerContextProperties):
(WebCore::V8TestEventTarget::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore):
(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::installPerContextProperties):
(WebCore::V8TestException::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::installPerContextProperties):
(WebCore::V8TestInterface::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):
(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::installPerContextProperties):
(WebCore::V8TestMediaQueryListListener::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):
(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::installPerContextProperties):
(WebCore::V8TestNamedConstructor::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):
(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::installPerContextProperties):
(WebCore::V8TestNode::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::installPerContextProperties):
(WebCore::V8TestSerializedScriptValueInterface::installPerContextPrototypeProperties):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase): Now invokes installPerContextPrototypeProperties()

  • bindings/v8/V8PerContextData.h:

(WebCore::V8PerContextData::createWrapperFromCache):
(WebCore::V8PerContextData::constructorForType):
(V8PerContextData):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::installPerContextPrototypeProperties): Added.
(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

2:54 AM Changeset in webkit [131166] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add "goto tab 1,2,3" hotkeys
https://bugs.webkit.org/show_bug.cgi?id=99157

Reviewed by Alexander Pavlov.

Ctrl/Cmd + digit shortcuts should select corresponding tabs

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._keyDownInternal):

2:38 AM Changeset in webkit [131165] by vsevik@chromium.org
  • 13 edits in trunk

Web Inspector: Extract domain specific editing handling logic from UISourceCode descendants (step 1).
https://bugs.webkit.org/show_bug.cgi?id=98912

Reviewed by Pavel Feldman.

Source/WebCore:

This is the first step that introduces StyleFile and ScriptFile and extracts domain specific editing handling logic.
StyleFile and ScriptFile should listen for the UISourceCode events and process them, this will be done in the next patch.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):

  • inspector/front-end/JavaScriptSource.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVMChanged):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ScriptFile):
(WebInspector.ScriptFile.prototype.hasDivergedFromVM):
(WebInspector.ScriptFile.prototype.isDivergingFromVM):
(WebInspector.ScriptFile.prototype.addEventListener):
(WebInspector.ScriptFile.prototype.removeEventListener):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype.workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype.workingCopyChanged):
(WebInspector.ResourceScriptFile.prototype.fireHasDivergedFromVMChanged):
(WebInspector.ResourceScriptFile.prototype.hasDivergedFromVM):
(WebInspector.ResourceScriptFile.prototype.isDivergingFromVM):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.SnippetScriptFile):
(WebInspector.SnippetScriptFile.prototype.hasDivergedFromVM):
(WebInspector.SnippetScriptFile.prototype.setHasDivergedFromVM):
(WebInspector.SnippetScriptFile.prototype.isDivergingFromVM):
(WebInspector.SnippetScriptFile.prototype.setIsDivergingFromVM):
(WebInspector.SnippetScriptFile.prototype.workingCopyCommitted):
(WebInspector.SnippetScriptFile.prototype.workingCopyChanged):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

  • inspector/front-end/StyleSource.js:
  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._addUISourceCode):
(WebInspector.StyleFile):
(WebInspector.StyleFile.prototype.workingCopyCommitted):
(WebInspector.StyleFile.prototype.workingCopyChanged):
(WebInspector.StyleFile.prototype._callOrSetTimeout):
(WebInspector.StyleFile.prototype._commitIncrementalEdit):
(WebInspector.StyleFile.prototype._clearIncrementalUpdateTimer):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.scriptFile):
(WebInspector.UISourceCode.prototype.setScriptFile):
(WebInspector.UISourceCode.prototype.styleFile):
(WebInspector.UISourceCode.prototype.setStyleFile):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):

LayoutTests:

  • inspector/debugger/live-edit.html:
  • inspector/extensions/extensions-resources.html:
2:36 AM Changeset in webkit [131164] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] GraphicsSurfaceGLX should keep track of previous GL context.
https://bugs.webkit.org/show_bug.cgi?id=99076

In GraphicsSurfaceGLX/GraphicsSurfacePrivate we create a new
QOpenGLContext for resolving GL methods.
This context is implicitly made current on creation.
Therefore we need to keep track of the previously bound context
and make that one current again after calling create.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

2:36 AM Changeset in webkit [131163] by apavlov@chromium.org
  • 2 edits in branches/chromium/1271/Source/WebCore/css

Merge 130511 - Web Inspector: [Styles] Unable to edit properties in broken stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98246

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Pop source data for invalid rules off the stack whenever we have consecutive CSSParser::markRuleHeaderStart() invocations.

Test: inspector/styles/parse-stylesheet-errors.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleBodyStart):

  • css/CSSParser.h:

(CSSParser):

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/11048052

2:24 AM Changeset in webkit [131162] by kbalazs@webkit.org
  • 9 edits in trunk

Revert ".: Don't allow to disable compositing in forced compositing mode"

This reverts commit e9055cb56b109cf4ab065200dc950f96ad149899.

2:20 AM Changeset in webkit [131161] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Show request body source in request headers view.
https://bugs.webkit.org/show_bug.cgi?id=99145

Reviewed by Pavel Feldman.

Added view source toggle to query parameters and form data elements.

  • inspector/front-end/NetworkPanel.js: fixed queryString getter usage.

(WebInspector.NetworkDataGridNode.prototype._fileName):
(WebInspector.NetworkDataGridNode.NameComparator):

  • inspector/front-end/NetworkRequest.js: Extracted queryString getter.

(WebInspector.NetworkRequest.prototype.queryString):
(WebInspector.NetworkRequest.prototype.get queryParameters):

  • inspector/front-end/RequestHeadersView.js:

(WebInspector.RequestHeadersView.prototype._refreshQueryString):
(WebInspector.RequestHeadersView.prototype._refreshFormData):
(WebInspector.RequestHeadersView.prototype._populateTreeElementWithSourceText):
extracted common method to populate elememnt with raw source text.
(WebInspector.RequestHeadersView.prototype._refreshParams.toggleViewSource):
(WebInspector.RequestHeadersView.prototype._refreshParams):
(WebInspector.RequestHeadersView.prototype._toggleURLDecoding):
(WebInspector.RequestHeadersView.prototype._refreshHeadersText):

  • inspector/front-end/networkPanel.css:A removed redundant raw-form-data style rule.
1:44 AM Changeset in webkit [131160] by kbalazs@webkit.org
  • 8 edits in trunk

[Qt][WTR] Do a forced repaint before generating pixel results
https://bugs.webkit.org/show_bug.cgi?id=98654

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

Added API to convert a QImage to a WKImage so we can
pass it to cross-platform code.

  • Shared/API/c/qt/WKImageQt.cpp:

(WKImageCreateFromQImage):

  • Shared/API/c/qt/WKImageQt.h:

Tools:

Do a forced repaint before grabbing the pixel snapshot. This extra
synchronisation is necessary with the CoordinatedGraphics rendering
backend because it has a fully asynchronous nature. This patch make
us using the window snapshot for pixel results which is necessary to
capture animations and other dynamic content. The actual grabbing of
the window has not been implemented in this patch. It will come in
a follow-up.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump): Store results in member variables.
Don't close output channels yet.
(WTR::TestInvocation::dumpResults): Added. This is where we dump
the results if no error happened.
(WTR):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::windowSnapshotImage):

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::forceRepaintDoneCallback):
(WTR):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

1:39 AM Changeset in webkit [131159] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-12

  • DEPS:
1:14 AM Changeset in webkit [131158] by bashi@chromium.org
  • 61 edits in trunk/LayoutTests

Unreviewed test expectations update after r131134

  • platform/chromium-linux/css3/font-feature-settings-rendering-expected.txt:
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/cg-vs-atsui-expected.png:
  • platform/chromium-linux/fast/text/complex-text-opacity-expected.png:
  • platform/chromium-linux/fast/text/drawBidiText-expected.png:
  • platform/chromium-linux/fast/text/international/arabic-justify-expected.png:
  • platform/chromium-linux/fast/text/international/arabic-vertical-offset-expected.png:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png:
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.txt:
  • platform/chromium-linux/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/text/bidi-text-query-expected.png:
  • platform/chromium-linux/svg/text/bidi-text-query-expected.txt:
  • platform/chromium-linux/svg/text/bidi-tspans-expected.png:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-with-geometric-precision-expected.png:
  • platform/chromium-linux/transforms/2d/hindi-rotated-expected.png:
  • platform/chromium/TestExpectations:
12:49 AM Changeset in webkit [131157] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining fast/dom/Window/window-properties-performance.html after r131106.
Adding a failure expectation for a transitions blend mode test added in r131146.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/Window/window-properties-performance-expected.txt:
12:47 AM Changeset in webkit [131156] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

Optimzie SelectorCheckingContext memory layout
https://bugs.webkit.org/show_bug.cgi?id=99139

Reviewed by Hajime Morita.

Since VisitedMatchType and PseudoId are both enum, we can make SelectorChecker more compact
if these two fields are continuously placed.

No new tests, no change in behavior.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):

12:33 AM Changeset in webkit [131155] by bashi@chromium.org
  • 3 edits
    3 adds in trunk

[WebSocket] Add "Cache-Control: no-cache" to handshake request
https://bugs.webkit.org/show_bug.cgi?id=98000

Reviewed by Yuta Kitamura.

Source/WebCore:

Add no-cache headers to opening handshake.
This is for compatibility improvement.
Some proxies rewrite "Connection: upgrade" to "Connection: close"
when a request doesn't contain no-cache headers.

Test: http/tests/websocket/tests/hybi/nocache.html

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

LayoutTests:

Add a test for no-cache headers check.

  • http/tests/websocket/tests/hybi/nocache-expected.txt: Added.
  • http/tests/websocket/tests/hybi/nocache-test_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/nocache.html: Added.
12:31 AM Changeset in webkit [131154] by loislo@chromium.org
  • 2 edits in trunk/Tools

Unreviewed compile error fix for chromium windows bot.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
12:26 AM Changeset in webkit [131153] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip test using disabled SHADOW_DOM.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-10-12

  • platform/qt/TestExpectations: Skip fast/dom/shadow/insertion-point-resetStyleInheritance.html.
12:24 AM Changeset in webkit [131152] by loislo@chromium.org
  • 2 edits in trunk/Tools

Another unreviewed fix for clang builders.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
12:22 AM Changeset in webkit [131151] by Csaba Osztrogonác
  • 5 edits in trunk/Source/WebKit2

Unreviewed, rolling out r131121.
http://trac.webkit.org/changeset/131121
https://bugs.webkit.org/show_bug.cgi?id=99144

It made all tests timeout on all WK2 platform (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-12

  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):

12:13 AM Changeset in webkit [131150] by loislo@chromium.org
  • 2 edits in trunk/Tools

Unreviewed compile error fix for clang builders.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
12:06 AM Changeset in webkit [131149] by loislo@chromium.org
  • 6 edits
    1 move in trunk

Web Inspector: NMI move instrumentation tests from chromium test set to the cross platform test set.
https://bugs.webkit.org/show_bug.cgi?id=99046

Reviewed by Yury Semikhatsky.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
Note: See TracTimeline for information about the timeline view.