Context Navigation

← Previous Period
Next Period →

Timeline

Oct 29, 2012:

11:56 PM Changeset in webkit [132873] by Csaba Osztrogonác

7 edits in trunk

Unreviewed, rolling out r132819.
http://trac.webkit.org/changeset/132819
https://bugs.webkit.org/show_bug.cgi?id=100388

It made layout testing 40% slower and storage tests assert

Tools:

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::dump):

DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::reset):

DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

LayoutTests:

platform/qt/TestExpectations:

11:43 PM Changeset in webkit [132872] by jochen@chromium.org

2 edits in trunk/Tools

[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
https://bugs.webkit.org/show_bug.cgi?id=100658

Reviewed by Tony Chang.

Before, this was compiled into DumpRenderTree. I also dropped the
include_dirs and dependencies block as TestRunner already has them.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

8:49 PM Changeset in webkit [132871] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Null-check WebViewImpl::m_client before calling invalidateRect() on it
https://bugs.webkit.org/show_bug.cgi?id=100716

Patch by James Robinson <jamesr@chromium.org> on 2012-10-29
Reviewed by Dirk Pranke.

This check was accidentally removed in r132862 and the value is null in at least some unit tests.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::invalidateRect):

8:42 PM Changeset in webkit [132870] by sergio@webkit.org

3 edits in trunk/Source/WebKit2

REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=98864

Reviewed by Martin Robinson.

Use a dedicated directory to store WebKit2 generated resources.

UIProcess/API/gtk/tests/GNUmakefile.am:
UIProcess/API/gtk/tests/TestMain.cpp:

(registerGResource): load the resource from the new directory.

8:34 PM Changeset in webkit [132869] by aestes@apple.com

2 edits in trunk/Source/WebCore

Fix a typo that caused SVG external resources to be blocked on
platforms other than Chromium.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

7:39 PM Changeset in webkit [132868] by keishi@webkit.org

2 edits in trunk/Source/WebCore

NSLocale leaks in LocaleMac
https://bugs.webkit.org/show_bug.cgi?id=97628

Reviewed by Kent Tamura.

We need to adopt the NSLocale object so it doesn't leak and
determineLocale() should return a NSLocale without additional retain.

No new tests.

platform/text/mac/LocaleMac.mm:

(WebCore::determineLocale): Returns a RetainPtr<NSLocale>.
(WebCore::Locale::create):
(WebCore::LocaleMac::LocaleMac): m_locale should adopt the NSLocale object.
(WebCore::LocaleMac::create): LocaleMac constructor takes NSLocale without additional retain.

7:37 PM Changeset in webkit [132867] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] Disable redirect to data scheme for potential fishing.
https://bugs.webkit.org/show_bug.cgi?id=100713

Reviewed by George Staikos.

We will disable redirect to data scheme to avoid potential security concern,
described in klevjers.com/papers/phishing.pdf.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleRedirect):

6:58 PM Changeset in webkit [132866] by tasak@google.com

1 edit in trunk/Tools/ChangeLog

Updated ChangeLog.

6:58 PM Changeset in webkit [132865] by tasak@google.com

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added myself as a committer.

5:05 PM Changeset in webkit [132864] by scheib@chromium.org

8 edits in trunk/Source

Unreviewed, rolling out r132845.
http://trac.webkit.org/changeset/132845
https://bugs.webkit.org/show_bug.cgi?id=99975

Broke chromium builds, linker errors from
IDBBindingUtilitiesTest

Source/WebCore:

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):

Modules/indexeddb/IDBRequest.h:

(IDBRequest):

bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::idbKeyToScriptValue):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::ensureAuxiliaryContext):
(WebCore):

bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

Source/WebKit/chromium:

tests/IDBBindingUtilitiesTest.cpp:

(WebCore::TEST):

5:04 PM WebKit Team edited by Jonathan Dong

add myself (Jonathan Dong) into committers list. (diff)

4:57 PM Changeset in webkit [132863] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix Windows build.

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

4:49 PM Changeset in webkit [132862] by jamesr@google.com

4 edits in trunk/Source/WebKit/chromium

[chromium] Defer commits between page unload and first invalidation in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100702

Reviewed by Adrienne Walker.

In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving
the first invalidation for the new page since the document is likely not loaded enough to paint usefully.
This defers commits from the time compositing is deactivated (which in force compositing mode only happens
at FrameView destruction) until we get the first invalidation from WebCore.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateContentsAndRootView):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::invalidateRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

src/WebViewImpl.h:

(WebViewImpl):

4:38 PM Changeset in webkit [132861] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Coordinated Graphics: Delete cached ShareableSurfaces when purging backingStores.
https://bugs.webkit.org/show_bug.cgi?id=100705

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-29
Reviewed by Noam Rosenthal.

LayerTreeCoordinatorProxy can be used after calling
LayerTreeCoordinatorProxy::purgeBackingStores(). So we should clear cached
ShareableSurfaces.

UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):

4:36 PM Changeset in webkit [132860] by mrowe@apple.com

32 edits in trunk

Simplify Xcode configuration settings that used to vary between OS versions.

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/JavaScriptCore.xcconfig:

Source/ThirdParty:

gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/WebCore.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/WebKit.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:
Configurations/WebKit2.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MiniBrowser/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/DebugRelease.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/DebugRelease.xcconfig:

4:35 PM Changeset in webkit [132859] by mrowe@apple.com

45 edits
11 deletes in trunk

Remove references to unsupported OS and Xcode versions.

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/CompilerVersion.xcconfig: Removed.
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:

Source/ThirdParty:

gtest/xcode/Config/CompilerVersion.xcconfig: Removed.
gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:
Configurations/CompilerVersion.xcconfig: Removed.
Configurations/DebugRelease.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
Configurations/CompilerVersion.xcconfig: Removed.
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:
Configurations/WebCore.xcconfig:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Configurations/Base.xcconfig:
Configurations/CompilerVersion.xcconfig: Removed.
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:
Configurations/CompilerVersion.xcconfig: Removed.
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:
DerivedSources.make:
WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

Configurations/Base.xcconfig:
Configurations/CompilerVersion.xcconfig: Removed.
Configurations/DebugRelease.xcconfig:
WTF.xcodeproj/project.pbxproj:

Tools:

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Removed.
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MiniBrowser/Configurations/CompilerVersion.xcconfig: Removed.
MiniBrowser/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Removed.
TestWebKitAPI/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
WebKitTestRunner/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Removed.
WebKitTestRunner/Configurations/DebugRelease.xcconfig:
WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

4:22 PM Changeset in webkit [132858] by andersca@apple.com

9 edits
1 add in trunk/Source

AtomicString(CFStringRef) shouldn't unconditionally create a StringImpl
https://bugs.webkit.org/show_bug.cgi?id=100701

Reviewed by Dan Bernstein.

Source/WebCore:

WebCore.exp.in:

Export AtomicString::add(CFStringRef).

Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Add AtomicStringCF.cpp

platform/text/cf/AtomicStringCF.cpp: Added.

(WTF::AtomicString::add):
When trying to add the atomic string to the table, first try to get a Latin-1 pointer
from the string. Second, try to get a Unicode pointer from the string.
If that also fails, copy the string to a temporary unicode buffer and add it from there.

platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForKey):
Update for AtomicString::createCFString being removed.

Source/WTF:

wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
Change the constructors that take a CFStringRef and an NSString * to call AtomicString::add(CFStringRef)
and remove AtomicString::createCFString.

(WTF::AtomicString::add):
Add new member function declaration. The definition is in a new file in WebCore, AtomicStringCF.cpp.
Also, fix the overload of add that takes a const char* to call the right other overload instead of itself.

4:18 PM Changeset in webkit [132857] by ap@apple.com

2 edits
2 adds in trunk/Source/WebKit2

[WK2] Add a NetworkingContext for NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=100708

Reviewed by Anders Carlsson.

Each request will have a context, because these are so lightweight on Mac, and
other platforms will need ResourceHandle refactored anyway to use NetworkProcess.

NetworkProcess/mac/RemoteNetworkingContext.h: Added.
NetworkProcess/mac/RemoteNetworkingContext.mm: Added. These go mac/ subdirectory, because NetworkingContext interface is different on each platform, as ResourceHandle needs dictate.

WebKit2.xcodeproj/project.pbxproj:

4:15 PM Changeset in webkit [132856] by schenney@chromium.org

5 edits
2 adds in trunk

feImage should not be allowed to self reference
https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

Add cycle detection for SVG filter application, and also fix a problem
with graphics context restore when filters are applied. This also
converts the flags in FilterData to a state tracking system, as the
number of flags was getting messy and only one flag is valid at any given time.

Test: svg/filters/feImage-self-and-other-referencing.html

rendering/svg/RenderSVGResourceFilter.cpp: Convert to new FilterData

state management and enable cycle detection.
(WebCore):
(WebCore::RenderSVGResourceFilter::removeClientFromCache): Change isBuilt and markedForRemoval flags to state enums.
(WebCore::RenderSVGResourceFilter::applyResource): Change flags to state enums and detect cycles.
(WebCore::RenderSVGResourceFilter::postApplyResource): Change flags to state and add handling
for the various states.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Change isBuilt flag to state enums.

rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData):
(FilterData): Convert to a state tracking system.

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced): Add a block around the
SVGRenderingContext so that it applies the filter and reverts the
context before the calling method restores the context.

LayoutTests:

Additional test case for situations when the filter is applied to multiple objects that it also references.

svg/filters/feImage-self-and-other-referencing-expected.html: Added.
svg/filters/feImage-self-and-other-referencing.html: Added.

4:10 PM Changeset in webkit [132855] by senorblanco@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

3:56 PM Changeset in webkit [132854] by abarth@webkit.org

2 edits in trunk/Source/WTF

Unreviewed. Correct my previous patch to disable external SVG
references only on PLATFORM(CHROMIUM).

wtf/Platform.h:

3:50 PM Changeset in webkit [132853] by msaboff@apple.com

3 edits
3 adds in trunk

Non-special escape character sequences cause JSC::Lexer::parseString to create 16 bit strings
https://bugs.webkit.org/show_bug.cgi?id=100576

Reviewed by Darin Adler.

Source/JavaScriptCore:

Changed singleEscape() processing to be based on a lookup of a static table. The table
covers ASCII characters SPACE through DEL. If a character can be a single character escape,
then the table provides the non-zero result of that escape. Updated the result of
singleEscape to be an LChar to make the table as small as possible.
Added a new test fast/js/normal-character-escapes-in-string-literals.html to validated
the behavior.

parser/Lexer.cpp:

(JSC::singleEscape):
(JSC::Lexer::parseString):
(JSC::Lexer::parseStringSlowCase):

LayoutTests:

Added a new test to validated the behavior of the corresponding changes to string processing
in the Lexer.

fast/js/normal-character-escapes-in-string-literals-expected.txt: Added.
fast/js/normal-character-escapes-in-string-literals.html: Added.
fast/js/script-tests/normal-character-escapes-in-string-literals.js: Added.

3:35 PM Changeset in webkit [132852] by mitz@apple.com

2 edits in trunk/Source/WebCore

<rdar://problem/12592716> REGRESSION (r132545): With full-page accelerated drawing, a
reproducible hang occurs at <http://www.cbsnews.com/stories/2010/01/24/ftn/main6136386.shtml>.

Reviewed by Anders Carlsson.

Work around <rdar://problem/12584492> by limiting the scope of the fix for <http://webkit.org/b/100413>.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipOut): Reverted to using CGContextGetClipBoundingBox() rather
than CGRectInfinite when the context is accelerated and has a transform that is not just
a translation or a scale.

2:53 PM Changeset in webkit [132851] by rwlbuis@webkit.org

5 edits in trunk/Source

[BlackBerry] Simplify AuthenticationChallengeManager::instance
https://bugs.webkit.org/show_bug.cgi?id=100614

Reviewed by Yong Li.
Internally reviewed by Lyon Chen.

Source/WebCore:

Use a standard Singleton pattern here, this makes sure we create lazily.

platform/blackberry/AuthenticationChallengeManager.cpp:

(WebCore):

platform/blackberry/AuthenticationChallengeManager.h:

(AuthenticationChallengeManager):

Source/WebKit/blackberry:

No need to call AuthenticationChallengeManager::init anymore.

Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

2:36 PM Changeset in webkit [132850] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Feature introduced in r132708 is chromium only. Skipping related tests.

platform/win/TestExpectations:

2:23 PM Changeset in webkit [132849] by abarth@webkit.org

7 edits in trunk

Block SVG external references pending a security review
https://bugs.webkit.org/show_bug.cgi?id=100635

Reviewed by Eric Seidel.

Source/WebCore:

We need to do a security review of loading external SVG references
before we're sure that it is safe.

css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

Source/WTF:

We need to do a security review of loading external SVG references
before we're sure that it is safe.

wtf/Platform.h:

LayoutTests:

Skip tests that depend on external SVG references.

platform/chromium/TestExpectations:

2:20 PM Changeset in webkit [132848] by jsbell@chromium.org

2 edits in trunk/Source/WebCore

IndexedDB: Crash on checking version of corrupt backing store
https://bugs.webkit.org/show_bug.cgi?id=100692

Reviewed by Tony Chang.

If the backing store fails to open (due to corruption, non-writeable disk, etc)
the subsequent schema version check dereferences a null pointer. Fix to only
do the schema check if the database opened.

Chromium tests will be included with crrev.com/11196029

Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

2:07 PM Changeset in webkit [132847] by pdr@google.com

7 edits in trunk/Source/WebCore

Let SVGElements have pending resources.
https://bugs.webkit.org/show_bug.cgi?id=99694

Reviewed by Eric Seidel.

Our SVG pending resource tracking is used for handling dynamic id changes. For example,
if an SVG element references an id that is not yet in the document (or has been removed),
the SVG element will be 'pending' an id. When styled elements are inserted into
the document, buildPendingResourcesIfNeeded() is called to force any pending elements
to resolve their dependencies. Only SVGStyledElement targets can be referenced using
this infrastructure, and that is not changed with this patch.

Previously, only SVGStyledElements could have pending resources. Some examples of where
this is violated are SVGAnimateElement and SVGMPathElement which are not a styled elements
but which can have pending references (they can reference styled elements and
paths, respectively). This patch changes the pending resource handling to allow
any SVGElement to have pending resources.

This patch is only a refactoring of code in preparation for WK99694 and does not
affect existing functionality or tests.

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):

svg/SVGDocumentExtensions.h:

(WebCore):
(SVGDocumentExtensions):

svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::hasPendingResources):
(WebCore):
(WebCore::SVGElement::setHasPendingResources):
(WebCore::SVGElement::clearHasPendingResourcesIfPossible):

svg/SVGElement.h:

(SVGElement):
(WebCore::SVGElement::buildPendingResource):

svg/SVGStyledElement.cpp:

(WebCore):
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::removedFrom):

svg/SVGStyledElement.h:

(SVGStyledElement):
(WebCore::SVGStyledElement::selfHasRelativeLengths):

2:06 PM Changeset in webkit [132846] by crogers@google.com

1 edit
2 adds in trunk/LayoutTests

Unreviewed rebaseline of webaudio/audiobuffersource-loop-points

platform/chromium-win-xp/webaudio/audiobuffersource-loop-points-expected.wav: Added.
platform/chromium-win/webaudio/audiobuffersource-loop-points-expected.wav: Added.

2:05 PM Changeset in webkit [132845] by commit-queue@webkit.org

8 edits in trunk/Source

Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975

Patch by Dan Carney <dcarney@google.com> on 2012-10-29
Reviewed by Adam Barth.

Source/WebCore:

Removed auxilliaryContext as use if it is problematic in IDB.

No new tests. No change in functionality.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):

Modules/indexeddb/IDBCursor.h:

(IDBCursor):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::put):
(WebCore):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):

bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):

bindings/v8/IDBBindingUtilities.h:

(WebCore):

bindings/v8/V8Binding.cpp:

(WebCore::toV8Context):
(WebCore):

bindings/v8/V8Binding.h:

(WebCore):

bindings/v8/V8PerIsolateData.cpp:

(WebCore):

bindings/v8/V8PerIsolateData.h:

Source/WebKit/chromium:

Updated tests to use correct v8 context.

tests/IDBBindingUtilitiesTest.cpp:

(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::checkKeyPathNullValue):
(WebKit::injectKey):
(WebKit::checkInjection):
(WebKit::checkInjectionFails):
(WebKit::checkKeyPathStringValue):
(WebKit::checkKeyPathNumberValue):
(WebKit::scriptExecutionContext):
(WebKit):
(WebKit::TEST):

1:57 PM Changeset in webkit [132844] by hclam@chromium.org

3 edits
3 adds in trunk

[skia] Handle mask box image.
https://bugs.webkit.org/show_bug.cgi?id=100570

Reviewed by James Robinson.

Source/WebCore:

When drawing an image with source rectangle it should intersect with image rectangle.
This should be the case for drawing single image and tiling an image.

Test: fast/images/mask-box-image-crash.html

platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

LayoutTests:

Added a test for -webkit-mask-box-image. Test should complete without crashes.
Output image should be blank.

fast/images/mask-box-image-crash-expected.png: Added.
fast/images/mask-box-image-crash-expected.txt: Added.
fast/images/mask-box-image-crash.html: Added.

1:16 PM Changeset in webkit [132843] by Dave Barton

5 edits
2 adds in trunk/LayoutTests

Unreviewed gardening. LayoutTests/mathml/msubsup-fuzz.html passes locally but not on
cr-linux-ews. I need to see a stack trace to debug it. See webkit.org/b/100463.

mathml/msubsup-fuzz-expected.txt: Added.
mathml/msubsup-fuzz.html: Added.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:

1:01 PM Changeset in webkit [132842] by eric.carlson@apple.com

4 edits in trunk/Source/WebCore

Support captions when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=100690

Reviewed by Simon Fraser.

When built with PLUGIN_PROXY_FOR_VIDEO, WebCore uses a plug-in for the media element's
platform media engine. Update this code path so the shadow DOM elements used to display
text tracks are created and configured correctly.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureMediaControls): Create media controls if necessary.

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout): Set the position and size of the shadow DOM when the

position of the embedded element changes.

rendering/RenderEmbeddedObject.h:

12:59 PM Changeset in webkit [132841] by msaboff@apple.com

2 edits in trunk/Source/WebKit2

buildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator
https://bugs.webkit.org/show_bug.cgi?id=100689

Reviewed by Darin Adler.

Changed from using a String temporary for the separator to using StringBuilder.appendLiteral(": ").

WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):

12:54 PM Changeset in webkit [132840] by dpranke@chromium.org

3 edits in trunk/Tools

webkitpy: change non-verbose log format for webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=100561

Reviewed by Ojan Vafai.

Logging the module name and the log level is annoying and nearly useless.
For starters, this change removes that unless you are doing verbose/
debug logging. In the future we should split out the concepts of
verbose and debug logging (like we did in test-webkitpy and
run-webkit-tests) so that you could get this in debug logging.

Scripts/webkitpy/common/system/logutils.py:

(_default_handlers):
(configure_logging):

Scripts/webkitpy/common/system/logutils_unittest.py:

(ConfigureLoggingTest.test_info_message):
(ConfigureLoggingTest):
(ConfigureLoggingTest.test_debug_message):
(ConfigureLoggingTest.test_two_messages):
(ConfigureLoggingVerboseTest):
(ConfigureLoggingVerboseTest._logging_level):
(ConfigureLoggingVerboseTest.test_info_message):
(ConfigureLoggingVerboseTest.test_debug_message):
(ConfigureLoggingCustomLevelTest.test_logged_message):

12:37 PM Changeset in webkit [132839] by junov@google.com

4 edits in trunk

[Chromium] flickering observed when copying 2D canvas to webGL texture
https://bugs.webkit.org/show_bug.cgi?id=100691

Reviewed by Stephen White.

Source/WebCore:

Added a flush to the webgl context after texture upload from an image
buffer to ensure proper graphics context synchronization with respect
to subsequent changes to the source image.

Tests: fast/canvas/webgl/canvas-2d-webgl-texture.html

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyToPlatformTexture):

LayoutTests:

Modified test by adding a canvas draw imediately after webgl texture
upload in order to exercise graphics context synchronization between
the webGL and 2D canvas graphics contexts.

fast/canvas/webgl/canvas-2d-webgl-texture.html:

12:29 PM Changeset in webkit [132838] by cevans@google.com

3 edits
2 copies in branches/chromium/1271

Merge 132724
BUG=157363
Review URL: https://codereview.chromium.org/11340016

12:22 PM Changeset in webkit [132837] by cevans@google.com

2 edits
2 copies in branches/chromium/1271

Merge 132420
BUG=157462
Review URL: https://codereview.chromium.org/11339018

12:06 PM Changeset in webkit [132836] by cevans@google.com

4 edits
3 copies in branches/chromium/1271

Merge 132528
BUG=151854
Review URL: https://codereview.chromium.org/11337009

12:01 PM Changeset in webkit [132835] by cevans@google.com

1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorStyleSheet.cpp

Merge 132462
BUG=157778
Review URL: https://codereview.chromium.org/11348012

12:00 PM Changeset in webkit [132834] by commit-queue@webkit.org

5 edits
4 adds in trunk

[CSSOM] Extraneous whitespace in CSSImportRule.cssText
https://bugs.webkit.org/show_bug.cgi?id=100657

Patch by Glenn Adams <glenn@skynav.com> on 2012-10-29
Reviewed by Simon Fraser.

Source/WebCore:

Remove extraneous whitespace when serializing CSSImportRule.cssText when
media list is empty.

Test: cssom/cssimportrule-media.html

css/CSSImportRule.cpp:

(WebCore::CSSImportRule::cssText):
Don't append extra whitespace if mediaText is empty.

LayoutTests:

Test (from CSS WG) that checks serializion of CSSImportRule.cssText.

http/tests/css/shared-stylesheet-mutation-expected.txt:
http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:

Fix expected output to match removal of extraneous space.

cssom/cssimportrule-media-expected.txt: Added.
cssom/cssimportrule-media.html: Added.
cssom/resources/import.css: Added.

11:58 AM Changeset in webkit [132833] by cevans@google.com

1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorStyleSheet.cpp

Merge 131578
BUG=156282
Review URL: https://codereview.chromium.org/11273087

11:56 AM Changeset in webkit [132832] by abarth@webkit.org

1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 132746 (partial) - [Chromium] Find-in-page reports matches in hidden iframes
https://bugs.webkit.org/show_bug.cgi?id=100604

Reviewed by Eric Seidel.

This is actually a regression caused by
http://trac.webkit.org/changeset/128784. This patch adds back some code
removed in WebFrameImpl::shouldScopeMatches in r128784.

This patch also introduces a test so that we don't make this mistake
again.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::shouldScopeMatches):

TBR=abarth@webkit.org
Review URL: https://codereview.chromium.org/11343020

11:50 AM Changeset in webkit [132831] by commit-queue@webkit.org

2 edits in trunk/Tools

[CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=100681

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Anders Carlsson.

Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMake since
it is needed by plugins/npruntime/npruntime-calls-with-null-npp.html
layout test.

DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

11:44 AM Changeset in webkit [132830] by cevans@google.com

1 edit
2 copies in branches/chromium/1271

Merge 131709
BUG=154617
Review URL: https://codereview.chromium.org/11273086

11:22 AM Changeset in webkit [132829] by cevans@google.com

2 edits in branches/chromium/1271/Source/WebKit/chromium

Merge 130847
BUG=154465
Review URL: https://codereview.chromium.org/11273084

11:18 AM Changeset in webkit [132828] by msaboff@apple.com

3 edits in trunk/Source/WTF

String::split(UChar, Vector<String>&) shouldn't create a temporary String
https://bugs.webkit.org/show_bug.cgi?id=100578

Reviewed by Anders Carlsson.

Changed split(UChar, Vector<String>&) to call split(UChar, bool, Vector<String>&) instead of creating a
string and calling the split(String,...) version and moved it to WTFString.h. Also moved
split(const String& separator, Vector<String>& result) to WTFString.h.

wtf/text/WTFString.cpp:

(WTF::String::split):

wtf/text/WTFString.h:

(WTF::String::split):

11:11 AM Changeset in webkit [132827] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding flaky crash expectations for tests that crash after r132699
if the accessibility object cache is populated.

platform/gtk/TestExpectations:

11:07 AM Changeset in webkit [132826] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
https://bugs.webkit.org/show_bug.cgi?id=100687

Unreviewed EFL gardening.

Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
since it is intrinsically flaky and cannot be fixed.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29

platform/efl/TestExpectations:

11:05 AM Changeset in webkit [132825] by msaboff@apple.com

2 edits in trunk/Source/WebKit2

WKStringCopyCFString() should directly use 8 bit Strings data instead of up converting
https://bugs.webkit.org/show_bug.cgi?id=100579

Reviewed by Oliver Hunt.

Changed to use CFStringCreateWithBytes() for 8 bit strings using characters8() for an 8 bit argument string.
Changed the current call to characters16().

Shared/API/c/cf/WKStringCF.cpp:

(WKStringCopyCFString):

11:02 AM Changeset in webkit [132824] by cevans@google.com

1 edit
2 copies in branches/chromium/1271

Merge 130999
BUG=154284
Review URL: https://codereview.chromium.org/11339015

11:01 AM Changeset in webkit [132823] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

webview not redrawn as needed when accelerated compositing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=99109

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-29
Reviewed by Martin Robinson.

GL shared display is not in the gtk loop and therefore, its events are
not captured by gtk. So, we use gdk default instead.

No new tests, covered by existing tests.

platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::resize):

10:54 AM Changeset in webkit [132822] by Lucas Forschler

4 edits in tags/Safari-537.16/Source

Versioning.

10:51 AM Changeset in webkit [132821] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
https://bugs.webkit.org/show_bug.cgi?id=100683

Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.

When in compact mode, style the Web Inspector toolbar using the same colors & gradients
as the Chromium toolbar (Chromium port only).

src/js/devTools.css:

(body.compact.platform-mac #toolbar):
(body.compact.platform-mac.inactive #toolbar):
(body.platform-mac.inactive #toolbar .toolbar-label):

10:48 AM Changeset in webkit [132820] by alecflett@chromium.org

8 edits in branches/chromium/1271/Source/WebCore

Revert 128379 - IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible
https://bugs.webkit.org/show_bug.cgi?id=94023

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-12
Reviewed by Kentaro Hara.

Transition the put/add/update methods to accept direct ScriptValue
objects rather than SerializedScriptValues, to eliminate lots of
redundant deserialization/serialization steps while storing
values.

Also see https://bugs.webkit.org/show_bug.cgi?id=95409 for
followup get/openCursor work, following this.

No new tests, this is a performance refactor of core IDB
functionality. Most existing tests cover correctness. Tests that
might fail include:

storage/indexeddb/objectstore-basics.html
storage/indexeddb/keypath-basics.html
storage/indexeddb/index-basics.html

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

Modules/indexeddb/IDBCursor.h:

(IDBCursor):

Modules/indexeddb/IDBCursor.idl:
Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore):

Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(IDBObjectStore):

Modules/indexeddb/IDBObjectStore.idl:
bindings/v8/IDBBindingUtilities.cpp:

(WebCore):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

bindings/v8/IDBBindingUtilities.h:

(WebCore):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11336016

10:47 AM Changeset in webkit [132819] by allan.jensen@digia.com

7 edits in trunk

[Qt] Flaky security tests
https://bugs.webkit.org/show_bug.cgi?id=100388

Reviewed by Jocelyn Turcotte.

Tools:

Disable text dumping and load a blank URL to ensure the documentLoader is cleared
before we start dumping text for the new page. Otherwise messages from the old page
may end up in the text output of the new test.

This matches what WebKitTestRunner does, and reuses the Qt code for waiting for flag.

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::runUntil):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::finishedResetting):
(WebCore::DumpRenderTree::dump):

DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::resetDumping):
(TestRunner::reset):

DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

LayoutTests:

Unskip no longer flaky tests.

platform/qt/TestExpectations:

10:46 AM Changeset in webkit [132818] by alecflett@chromium.org

14 edits in branches/chromium/1271/Source

Revert 128789 - IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor
https://bugs.webkit.org/show_bug.cgi?id=95409

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-17
Reviewed by Kentaro Hara.

Source/WebCore:

This reduces a bunch of serialization/deserialization when writing
to objectstores with indexes.

No new tests, as this covers core functionality of IndexedDB, and
almost every test would fail. Some likely tests that would fail
fundamentally include:

storage/indexeddb/objectstore-basics.html
storage/indexeddb/cursor-basics.html
storage/indexeddb/index-basics.html

Modules/indexeddb/IDBAny.cpp:

(WebCore::IDBAny::scriptValue):
(WebCore::IDBAny::integer):
(WebCore):
(WebCore::IDBAny::set):

Modules/indexeddb/IDBAny.h:

(WebCore):
(IDBAny):
(WebCore::IDBAny::create):

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::setValueReady):

Modules/indexeddb/IDBCursor.h:

(WebCore):
(IDBCursor):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore):
(WebCore::IDBRequest::onSuccessInternal):
(WebCore::IDBRequest::dispatchEvent):

Modules/indexeddb/IDBRequest.h:

(IDBRequest):

Modules/indexeddb/IDBTransactionCallbacks.h:
bindings/v8/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):

bindings/v8/IDBBindingUtilities.h:

(WebCore):

bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

Source/WebKit/chromium:

This removes a bunch of tests that have been migrated to
LayoutTests, in https://bugs.webkit.org/show_bug.cgi?id=96818.

tests/IDBBindingUtilitiesTest.cpp:

(WebCore::checkKeyFromValueAndKeyPathInternal):
(WebCore::checkKeyPathNullValue):
(WebCore::injectKey):
(WebCore::checkInjection):
(WebCore::checkInjectionFails):
(WebCore::checkKeyPathStringValue):
(WebCore::checkKeyPathNumberValue):
(WebCore::TEST):

tests/IDBKeyPathTest.cpp:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11348011

10:46 AM Changeset in webkit [132817] by cevans@google.com

4 edits in branches/chromium/1271/Source/WebCore

Merge 132398
BUG=154055
Review URL: https://codereview.chromium.org/11350003

10:35 AM Changeset in webkit [132816] by cevans@google.com

2 edits
2 copies in branches/chromium/1271

Merge 131670
BUG=152585
Review URL: https://codereview.chromium.org/11342010

10:30 AM Changeset in webkit [132815] by zoltan@webkit.org

2 edits
5 copies
3 adds
1 delete in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #7 (last)
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #7 (last) commit of the whole patch.

PageLoad: Removed.
PageLoad/svg: Removed.
PageLoad/svg/LICENSES: Removed.
PageLoad/svg/files: Removed.
PageLoad/svg/files/33041-Samurai.svg: Removed.
PageLoad/svg/files/42450-under the see.svg: Removed.
PageLoad/svg/files/world-iso.svg: Removed.
PageLoad/svg/svg.pltsuite: Removed.
SVG/Samurai.html: Added.
SVG/UnderTheSee.html: Added.
SVG/WorldIso.html: Added.
SVG/resources/LICENSES: Copied from PerformanceTests/PageLoad/svg/LICENSES.
SVG/resources/Samurai.svg: Copied from PerformanceTests/PageLoad/svg/files/33041-Samurai.svg.
SVG/resources/UnderTheSee.svg: Copied from PerformanceTests/PageLoad/svg/files/42450-under%20the%20see.svg.
SVG/resources/WorldIso.svg: Copied from PerformanceTests/PageLoad/svg/files/world-iso.svg.
SVG/resources/svg.pltsuite: Copied from PerformanceTests/PageLoad/svg/svg.pltsuite.
Skipped: Rename the files on the skipped list also.

10:28 AM Changeset in webkit [132814] by cevans@google.com

1 edit in branches/chromium/1271/Source/WebCore/loader/SubresourceLoader.cpp

Merge 132287 - Crash in WebCore::SubresourceLoader::willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=100147

Reviewed by Abhishek Arya.

No new tests. There is a test case that should cover this, but it doesn't
work correctly on many platforms due to its use of testRunner.addURLToRedirect().
See http/tests/loading/cross-origin-XHR-willLoadRequest.html.
Tested manually on http://www.nick.co.uk/shows/spongebob

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

TBR=Nate Chapin
Review URL: https://codereview.chromium.org/11312006

10:26 AM Changeset in webkit [132813] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: bind redo to Ctrl+Y on non-mac platforms
https://bugs.webkit.org/show_bug.cgi?id=100685

Reviewed by Vsevolod Vlasov.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._registerShortcuts):

10:10 AM Changeset in webkit [132812] by enrica@apple.com

9 edits in trunk/Source

Add ENABLE_USERSELECT_ALL feature flag.
https://bugs.webkit.org/show_bug.cgi?id=100559

Reviewed by Eric Seidel.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

10:03 AM Changeset in webkit [132811] by Lucas Forschler

2 edits in tags/Safari-537.16/Source/WebKit2

Merged r132714.

9:59 AM Changeset in webkit [132810] by Lucas Forschler

8 edits in tags/Safari-537.16/Source/WebCore

Rollout 132695.

9:56 AM Changeset in webkit [132809] by cevans@google.com

2 edits
2 copies in branches/chromium/1271

Merge 131488
BUG=143761
Review URL: https://codereview.chromium.org/11336015

9:50 AM Changeset in webkit [132808] by Alexandru Chiculita

10 edits
2 adds in trunk/Source/WebCore

[CSS Shaders] Extract the CustomFilterParameterList to its own file
https://bugs.webkit.org/show_bug.cgi?id=100548

Reviewed by Dean Jackson.

Moved all the CustomFilterParameterList related methods to their own file.
Also made CustomFilterParameterList inherit from Vector instead of typedefing it,
so that we can add a different operator== and a blend method to it.

No new tests, just refactoring existing code.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
css/StyleResolver.h:
platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::blend):

platform/graphics/filters/CustomFilterOperation.h:

(WebCore):
(WebCore::CustomFilterOperation::operator==):

platform/graphics/filters/CustomFilterParameterList.cpp: Added.

(WebCore):
(WebCore::CustomFilterParameterList::operator==):
(WebCore::CustomFilterParameterList::checkAlphabeticalOrder):
(WebCore::CustomFilterParameterList::blend):

platform/graphics/filters/CustomFilterParameterList.h: Added.

(WebCore):
(CustomFilterParameterList):

9:46 AM WebKit Team edited by allan.jensen@digia.com

(diff)

9:42 AM Changeset in webkit [132807] by beidson@apple.com

2 edits in trunk/Source/WebCore

Try to fix 32-bit builds after my incompletely tested m_identifier change.

Not reviewed.

loader/ResourceLoader.h:

(WebCore::ResourceLoader::identifier): Revert my "unsigned long" -> "uint64_t" change in two places.

9:40 AM Changeset in webkit [132806] by Lucas Forschler

8 edits in tags/Safari-537.16/Source/WebKit2

Merged r132738.

8:51 AM Changeset in webkit [132805] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Typo in WebPagePrivate::postponeDocumentRecalcStyle()
https://bugs.webkit.org/show_bug.cgi?id=100377

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-10-29
Reviewed by Adam Treat.

Should be void, not bool.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):

Api/WebPage_p.h:

(WebPagePrivate):

7:52 AM Changeset in webkit [132804] by commit-queue@webkit.org

11 edits in trunk

[WK2][WKTR] Enable Shadow DOM at runtime if compiled with SHADOW_DOM support
https://bugs.webkit.org/show_bug.cgi?id=100668

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle API to enable Shadow DOM functionality. This is
now needed by WebKitTestRunner.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetShadowDOMEnabled):

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setShadowDOMEnabled):
(WebKit):

WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Enable Shadow DOM functionality at run time in WebKitTestRunner
if compiled with SHADOW_DOM flag set. This is needed to run
the Shadow DOM layout tests.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

LayoutTests:

Remove Shadow DOM layout tests from the global wk2 TestExpectations
and add it to the mac-wk2 one. EFL and GTK ports have Shadow DOM
enabled so they don't need to be skipped for those ports. The Qt port
is already skipping those tests in its global TestExpectations file.

platform/efl-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/wk2/TestExpectations:

7:50 AM Changeset in webkit [132803] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[EFL][WK2] Fix cursor change detection in EwkViewImpl::setCursor()
https://bugs.webkit.org/show_bug.cgi?id=100662

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.

Cursor change detection in EwkViewImpl::setCursor() relies on
addresses returned by Cursor::platformCursor(). However, the
value returned is currently assigned to a WKEinaSharedString
instead of a raw pointer. Therefore, the address is always
different and we keep recreating Evas Objects for the same
cursor.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::setCursor): Call smartData() after same cursor
detection since it is not needed if the cursor has not changed
and it may affect performance.

UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

7:47 AM Changeset in webkit [132802] by Csaba Osztrogonác

4 edits in trunk

[Qt] Text with zero font size renders as X px sometimes, causing fast/text/zero-font-size-2.html to fail
https://bugs.webkit.org/show_bug.cgi?id=100115

Reviewed by Noam Rosenthal.

Source/WebCore:

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawGlyphs):

LayoutTests:

platform/qt/TestExpectations: Unskip fast/text/zero-font-size-2.html.

7:46 AM Changeset in webkit [132801] by jocelyn.turcotte@digia.com

3 edits in trunk/Source/WebKit2

Coordinated Graphics: Make sure that we release images immediately when purging resources
https://bugs.webkit.org/show_bug.cgi?id=100661

Reviewed by Noam Rosenthal.

When we purge, we do both on the UI and web process at the same time,
both are expected to release references of the other process.
This creates problem when delaying the release of directly composited
images.

Release them immediately in that case.

Fixes the tst_QQuickWebView::removeFromCanvas API test.

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::purgeReleasedImages):
(WebKit):
(WebKit::LayerTreeCoordinator::purgeBackingStores):

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

7:37 AM Changeset in webkit [132800] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[EFL][WK2] Avoid useless assignment in EwkViewImpl::setCustomTextEncodingName()
https://bugs.webkit.org/show_bug.cgi?id=100667

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.

Remove useless m_customEncoding assignment in EwkViewImpl::setCustomTextEncodingName()
since the member is anyway assigned in EwkViewImpl::customTextEncodingName().

Have EwkViewImpl::setCustomTextEncodingName() take a String in argument instead
of a const char* to make the API more C++ and since we don't need a const char*
to assign to m_customEncoding anymore.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::setCustomTextEncodingName):

UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

UIProcess/API/efl/ewk_view.cpp:

(ewk_view_setting_encoding_custom_set):

7:29 AM Changeset in webkit [132799] by commit-queue@webkit.org

5 edits in trunk/Tools

[EFL][AC] Fix bugs preventing us from running layout tests with AC turned on
https://bugs.webkit.org/show_bug.cgi?id=100598

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.

Make sure to use opengl_x11 engine when AC is turned on and X11 is in use.
We cannot create a gl context otherwise.

MiniBrowser/efl/main.c:

(elm_main):

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::initEcoreEvas):

DumpRenderTree/efl/DumpRenderTree.cpp:

(initEcoreEvas):

EWebLauncher/efl/main.c:

(windowCreate):

7:26 AM Changeset in webkit [132798] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[TexMap] Make GraphicsLayerAnimation choose a proper timing function.
https://bugs.webkit.org/show_bug.cgi?id=100623

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-29
Reviewed by Noam Rosenthal.

Currently, GraphicsLayerAnimation chooses a timing function in the wrong
way. Other GraphicsLayers choose a timing function in the similar way to
GraphicsLayerCA::timingFunctionForAnimationValue(). The way consists of
the following steps.

Try to query the timing function of the current keyframe animation value.
If the timing function of #1 is null, try to query the timing function of Animation.
If the timing function of #2 is null, return CubicBezierTimingFunction::defaultTimingFunction().

This patch makes GraphicsLayerAnimation choose a timing function in the same way
to other implementations.

Covered by existing animations tests.

platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerAnimation::apply):

7:23 AM Changeset in webkit [132797] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Toolbar overflow appears outside window
https://bugs.webkit.org/show_bug.cgi?id=100663

Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.

Since the search bar was removed from the toolbar, the overflow menu appears too far
to the right, and is unreadable. Fixed this by aligning it relative to the right side
of the window, rather than the left.

inspector/front-end/Toolbar.js:

(WebInspector.ToolbarDropdown.prototype.show):

inspector/front-end/inspector.css:

(#toolbar-dropdown .toolbar-label):

7:23 AM Changeset in webkit [132796] by rakuco@webkit.org

4 edits in trunk

[EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails
https://bugs.webkit.org/show_bug.cgi?id=100646

Reviewed by Kenneth Rohde Christiansen.

Tools:

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::focus): Improve the check we perform to
decide whether the focus should be taken out of the view before
focusing it again so that we do not unnecessarily unfocus it and
cause blur/focus events to be triggered. Instead of just verifying
if the Evas_Object representing the view has focus, use the WK C
API to check that the currently focused frame is not the main
frame.

LayoutTests:

platform/efl-wk2/TestExpectations: Unskip

fast/events/frame-tab-focus.html.

7:10 AM Changeset in webkit [132795] by Michelangelo De Simone

4 edits
2 adds in trunk

[CSS Shaders] Implement CustomFilterArrayParameter::blend
https://bugs.webkit.org/show_bug.cgi?id=96437

Reviewed by Dean Jackson.

Source/WebCore:

This patch adds the missing code to blend values within
an array() when using Custom Filters.

Test: css3/filters/custom/custom-filter-array-blending.html

platform/graphics/filters/CustomFilterArrayParameter.h:

(WebCore::CustomFilterArrayParameter::blend):

LayoutTests:

New tests to asses the correctness of CustomFilterArrayParameter::blend.

animations/resources/animation-test-helpers.js:

(customFilterParameterMatch): A check for functions' parameters length has been added.

css3/filters/custom/custom-filter-array-blending-expected.txt: Added.
css3/filters/custom/custom-filter-array-blending.html: Added.

6:52 AM Changeset in webkit [132794] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Drag and drop a URL in inspector is not working as expected
https://bugs.webkit.org/show_bug.cgi?id=100527

Reviewed by Yury Semikhatsky.

Inhibit custom dragstart handling when the active element is A.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondragstart):

6:29 AM Changeset in webkit [132793] by mkwst@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Error/warning count is one pixel off.
https://bugs.webkit.org/show_bug.cgi?id=100660

Reviewed by Pavel Feldman.

The error/warning count div had a top padding of 6. That was one pixel
too many.

inspector/front-end/inspector.css:

(#error-warning-count):

6:07 AM Changeset in webkit [132792] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix a build error
https://bugs.webkit.org/show_bug.cgi?id=100649

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-10-29
Reviewed by Kentaro Hara.

r127876 changed the signature of WebCore::EventHandler::hitTestResultAtPoint()
and this commit was later reverted. We need to update a call site in the
BlackBerry port to make it build.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

5:51 AM Changeset in webkit [132791] by shinyak@chromium.org

4 edits in trunk/Source/WebCore

[Refactoring] Use isActiveInsertionPoint() instead of isInsertionPoint()
https://bugs.webkit.org/show_bug.cgi?id=100459

Reviewed by Hajime Morita.

Checking InsertionPoint and its activeness with two if-statement is error-prone. We would like to
use a utility function which checks both at once.

We rewrite some lines with such function.

No new tests, simple refactoring.

dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseNode):

html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::populate):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::distributeNodeChildrenTo):

html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint): Since our convention is the argument of this kind of function should not be null,
we would like to make it similar to the other functions.
(WebCore::toInsertionPoint):
(WebCore::isLowerEncapsulationBoundary):

5:48 AM Changeset in webkit [132790] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: Fix vertical alignment in toolbar backgrounds and overflow button.
https://bugs.webkit.org/show_bug.cgi?id=100373

Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.

Fix the background image for the selected toolbar item to be vertically centered.
Make close button and toolbar overflow button vertically centered for any toolbar
height.

inspector/front-end/Toolbar.js: Remove unused variable.
inspector/front-end/inspector.css:

(.toolbar-item.toggleable):
(body.compact .toolbar-item.toggleable):
(.toolbar-item.toggleable.toggled-on):
(body.compact .toolbar-label):
(#toolbar-dropdown-arrow):
(#close-button-left, #close-button-right):
(.toolbar-item.close-left):

inspector/front-end/inspector.html:

5:43 AM Changeset in webkit [132789] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Timeline: Overview bars do not correspond to timeline bars
https://bugs.webkit.org/show_bug.cgi?id=100500

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-29
Reviewed by Yury Semikhatsky.

Fix: do not shorten bars by nested records of the same category.

inspector/front-end/TimelineOverviewPane.js: Check added.

5:40 AM Changeset in webkit [132788] by commit-queue@webkit.org

11 edits in trunk/Source

Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers
https://bugs.webkit.org/show_bug.cgi?id=100530

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-29
Reviewed by Yury Semikhatsky.

Motivation: cpu-monitoring feature looks like a glitch,
when it is not supported by browser.

Source/WebCore:

inspector/Inspector.json: Added capability getter to protocol.
inspector/InspectorClient.h: Added capability getter.
inspector/InspectorTimelineAgent.cpp: Proxy to request to client.
inspector/InspectorTimelineAgent.h: Added capability getter.
inspector/front-end/Settings.js: Added capability field.
inspector/front-end/TimelinePanel.js: Check capability.
inspector/front-end/inspector.js: Forward capability value.

Source/WebKit/chromium:

src/InspectorClientImpl.cpp: Implemented capability getter.
src/InspectorClientImpl.h:

5:37 AM Changeset in webkit [132787] by Antti Koivisto

6 edits in trunk/Source/WebCore

Move seamless stylesheet collecting to DocumentStyleSheetCollection
https://bugs.webkit.org/show_bug.cgi?id=100655

Reviewed by Andreas Kling.

Move the code from StyleResolver to DocumentStyleSheetCollection. StyleResolver should focus on resolving style.

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):

Use standard create() pattern.

(WebCore):

css/StyleResolver.h:

(StyleResolver):

dom/Document.cpp:

(WebCore::Document::Document):

dom/DocumentStyleSheetCollection.cpp:

(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):

Since parent activeAuthorStyleSheets() contains all seamlessly inherited sheets too, this does not need to
iterate to ancestors anymore.

(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::create):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList):
(WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets):

activeAuthorStyleSheets() now includes the stylesheets inherited from the seamless parent too.

(WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):

4:44 AM Changeset in webkit [132786] by kling@webkit.org

14 edits in trunk/Source/WebCore

Don't expose implementation details of StylePropertySet storage.
<http://webkit.org/b/100644>

Reviewed by Antti Koivisto.

Add a StylePropertySet::PropertyReference class, now returned by propertyAt(index).
This will allow us to refactor the internal storage of StylePropertySet without
breaking its API.

A PropertyReference is a simple inlinable wrapper around a StylePropertySet&/index pair.

css/CSSComputedStyleDeclaration.cpp:
css/CSSParser.cpp:
css/CSSParser.h:
css/SVGCSSParser.cpp:
css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::reportMemoryUsage):

css/StylePropertySet.h:

(StylePropertySet):
(PropertyReference):
(WebCore::StylePropertySet::PropertyReference::PropertyReference):
(WebCore::StylePropertySet::PropertyReference::id):
(WebCore::StylePropertySet::PropertyReference::isImportant):
(WebCore::StylePropertySet::PropertyReference::isInherited):
(WebCore::StylePropertySet::PropertyReference::cssName):
(WebCore::StylePropertySet::PropertyReference::cssText):
(WebCore::StylePropertySet::PropertyReference::value):
(WebCore::StylePropertySet::PropertyReference::propertyInternal):
(WebCore::StylePropertySet::propertyAt):
(WebCore::StylePropertySet::propertyAtInternal):
(WebCore):

css/StyleResolver.cpp:

(WebCore::attributeStylesEqual):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::resolveVariables):

editing/ApplyStyleCommand.cpp:
editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeStyle):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

editing/Editor.cpp:
editing/markup.cpp:
page/Frame.cpp:
svg/SVGFontFaceElement.cpp:

4:29 AM Changeset in webkit [132785] by Csaba Osztrogonác

4 edits in trunk

Unreviewed, rolling out r132782.
http://trac.webkit.org/changeset/132782
https://bugs.webkit.org/show_bug.cgi?id=100653

It made 400+ tests fail and 180 tests flakey on Qt (Requested
by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29

Tools:

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

LayoutTests:

platform/qt/TestExpectations:

4:21 AM Changeset in webkit [132784] by Csaba Osztrogonác

2 edits in trunk/Source/WTF

Unreviewed, rolling out r132736.
http://trac.webkit.org/changeset/132736
https://bugs.webkit.org/show_bug.cgi?id=100652

It broke all plugin related tests on GTK and on Qt (Requested
by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29

wtf/text/WTFString.cpp:

(WTF::String::fromUTF8):

3:53 AM Changeset in webkit [132783] by tkent@chromium.org

3 edits
1 delete in trunk/Source/WebKit/chromium

[Chromium] Merge LocalizedNumberICUTest into LocaleICUTest
https://bugs.webkit.org/show_bug.cgi?id=100648

Reviewed by Kentaro Hara.

LocalizedNumberICU was removed some months ago, and its features were
merged to LocaleICU. We merge the test too.

WebKit.gypi: Remove LocalizedNumberICUTest.cpp
tests/LocaleICUTest.cpp:

Move a #if because some headers are used unconditionally.
(testDecimalSeparator): Moved from LocalizedNumberICUTest.cpp.
(TEST_F): Ditto.
(testNumberIsReversible): Ditto.
(testNumbers): Ditto.

tests/LocalizedNumberICUTest.cpp: Removed.

3:52 AM Changeset in webkit [132782] by allan.jensen@digia.com

4 edits in trunk

[Qt] Flaky security tests
https://bugs.webkit.org/show_bug.cgi?id=100388

Reviewed by Jocelyn Turcotte.

Tools:

Disable text output and load a blank URL to ensure the documentLoader is cleared
before we start dumping text for the new page. Otherwise messages from the old page
may end up in the text output of the new test.

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

LayoutTests:

Unskip no longer flaky tests.

platform/qt/TestExpectations:

3:50 AM Changeset in webkit [132781] by jochen@chromium.org

12 edits
1 copy
1 add in trunk/Tools

[chromium] remove remaining usages of webkit_support from the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=100344

Reviewed by Adam Barth.

The most important part is to not rely on calling out to gdk/X11 to
translate keycodes to hardware keycodes, as this is not possible inside
the sandbox.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/DRTTestRunner.h:

(WebKit):
(webkit_support):

DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::doDragDrop):
(WebTestRunner::EventSender::updateClickCountForButton):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::handleMouseWheel):
(WebTestRunner::EventSender::gestureEvent):
(WebTestRunner::EventSender::gestureFlingCancel):
(WebTestRunner::EventSender::gestureFlingStart):

DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.

(WebTestRunner):
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.

(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::getCurrentTimeInMillisecond):
(WebViewHost::getAbsoluteWebStringFromUTF8Path):

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

3:28 AM Changeset in webkit [132780] by jocelyn.turcotte@digia.com

4 edits in trunk/Source/WebKit2

[WK2] Enable delegated scrolling as soon as the FrameView is created when using fixed layout
https://bugs.webkit.org/show_bug.cgi?id=100383

Reviewed by Kenneth Rohde Christiansen.

Scroll requests and PageTransitionViewportReady messages depend on
delegated scrolling being set properly on the FrameView to behave
properly. Since we were waiting for the viewport information to be
ready before setting the flag this could cause those messages to be avoided.

This patch takes most of the flag set by setResizesToContentsUsingLayoutSize
and apply them as soon as possible in WebPage::setUseFixedLayout and
WebFrameLoaderClient::transitionToCommittedForNewPage.

The behavior should be the same except for the following settings which are
now set outside of USE(TILED_BACKING_STORE) if we're using fixed layout:

setAcceleratedCompositingForFixedPositionEnabled
setFixedElementsLayoutRelativeToFrame
setFixedPositionCreatesStackingContext

This fixes the tst_QQuickWebView::scrollRequest auto test and improves the
reliability of the loadVisuallyCommitted signal with pages loaded from disk.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::setUseFixedLayout):
(WebKit::WebPage::setFixedLayoutSize):

WebProcess/WebPage/WebPage.h:

(WebPage):

3:07 AM Changeset in webkit [132779] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2012-10-29 Pavel Podivilov <podivilov@google.com>

[Chromium] Test expectation update.

Unreviewed, mark recently added audiobuffersource-loop-points.html test as failing on windows.

platform/chromium/TestExpectations:

2:44 AM Changeset in webkit [132778] by tkent@chromium.org

2 edits
1 move in trunk/Source/WebKit/chromium

[Chromium] Rename LocalizedDateICUTest.cpp to LocaleICUTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=100643

Reviewed by Kentaro Hara.

LocalizedDateICU was removed some months ago, and LocalizedDateICUTest
actually had tests for LocaleICU.

WebKit.gypi:
tests/LocaleICUTest.cpp:
Renamed from Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp.
Rename LocalizedDateICUTest class to LocaleICUTest.

2:18 AM Changeset in webkit [132777] by tkent@chromium.org

3 edits
2 moves in trunk/Source/WebCore

Move LocaleWin.{cpp,h} to platform/text/win/
https://bugs.webkit.org/show_bug.cgi?id=100641

Reviewed by Kentaro Hara.

We have platform/text/win/ directory. Windows-specific files should be
in it.
Note that these files are used only in Chromium-win for now.

No new tests. This doesn't change any behavior.

WebCore.gyp/WebCore.gyp: Fix path names.
WebCore.gypi: Ditto.
platform/text/win/LocaleWin.cpp: Renamed from Source/WebCore/platform/text/LocaleWin.cpp.
platform/text/win/LocaleWin.h: Renamed from Source/WebCore/platform/text/LocaleWin.h.

2:17 AM Changeset in webkit [132776] by rakuco@webkit.org

2 edits in trunk/Source/WebKit2

Unreviewed build fix after r132709.

Shared/WebMemorySampler.cpp: Include unistd.h for getpid(3).

2:11 AM Changeset in webkit [132775] by tkent@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium-linux] Fix build.

tests/LocalizedNumberICUTest.cpp:

(testNumberIsReversible): Rename an argument.
(testDecimalSeparator): Ditto.

1:51 AM Changeset in webkit [132774] by tkent@chromium.org

35 edits in trunk/Source

Rename Localizer to Locale
https://bugs.webkit.org/show_bug.cgi?id=100634

Reviewed by Kentaro Hara.

Source/WebCore:

Rename Localizer class to Locale
Rename localizer with locale in variable names
Rename localizer with locale in function names

No new tests. This doesn't make any behavior changes.

dom/Document.h:

(WebCore): Declare Locale instead of Localizer.
(Document):

Rename getCachedLocalizer to getCachedLocale.
Rename LocaleToLocalizerMap to LocaleIdentifierToLocaleMap.
Rename m_localizerCache to m_localeCache.
dom/Document.cpp:

(WebCore::Document::getCachedLocale): Follow renamings.

dom/Element.h:

(WebCore): Declare Locale instead of Localizer.
(Element): Rename localizer() to locale().

dom/Element.cpp:

(WebCore::Element::locale): Follow renamings.

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::localizeValue): Ditto.
(WebCore::BaseDateAndTimeInputType::convertFromVisibleValue): Ditto.

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Ditto.

html/DateInputType.cpp:

(WebCore::DateInputType::fixedPlaceholder): Ditto.
(WebCore::DateInputType::setupLayoutParameters): Ditto.

html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::setupLayoutParameters): Ditto.

html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.

html/MonthInputType.cpp:

(WebCore::MonthInputType::setupLayoutParameters): Ditto.

html/NumberInputType.cpp:

(WebCore::NumberInputType::localizeValue): Ditto.
(WebCore::NumberInputType::convertFromVisibleValue): Ditto.

html/TimeInputType.cpp:

(WebCore::TimeInputType::localizeValue): Ditto.
(WebCore::TimeInputType::setupLayoutParameters): Ditto.

html/shadow/DateTimeEditElement.h:

(WebCore): Declare Locale instead of Localizer.
(LayoutParameters): Rename localizer data member to locale.
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Follow renamings.

html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField): Ditto.

html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Rename localizerForOwner to localeForOwner.

html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::formatValue): Follow renamings.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Ditto.
(WebCore::DateTimeNumericFieldElement::localeForOwner): Ditto.

page/PagePopupClient.h:

(WebCore): Declare Locale instead of Localizer.
(PagePopupClient): Rename localizer member function to locale.

page/PagePopupController.cpp:

(WebCore::PagePopupController::localizeNumberString): Follow renamings.

platform/text/PlatformLocale.cpp: Rename the Localizer class to Locale.

(DateTimeStringBuilder):
(WebCore::DateTimeStringBuilder::DateTimeStringBuilder):
(WebCore::Locale::~Locale):
(WebCore::Locale::setLocaleData): Renamed from setLocalizerData.
(WebCore::Locale::convertToLocalizedNumber):
(WebCore::Locale::detectSignAndGetDigitRange):
(WebCore::Locale::matchedDecimalSymbolIndex):
(WebCore::Locale::convertFromLocalizedNumber):
(WebCore::Locale::localizedDecimalSeparator):
(WebCore::Locale::dateTimeFormatWithSeconds):
(WebCore::Locale::dateTimeFormatWithoutSeconds):
(WebCore::Locale::formatDateTime):

platform/text/PlatformLocale.h: Update the ifndef macro.

(Locale): Renamed from Localizer. Also, renamed the followings:

initializeLocalizerData -> initializeLocaleData
setLocalizerData -> setLocaleData
m_hasLocalizerData -> m_hasLocaleData

(WebCore::Locale::Locale):
(WebCore::Locale::createDefault):

platform/text/LocaleICU.cpp: Follow renamings.
platform/text/LocaleICU.h: Ditto.
platform/text/LocaleNone.cpp: Ditto.
platform/text/LocaleWin.cpp: Ditto.
platform/text/LocaleWin.h: Ditto.
platform/text/mac/LocaleMac.h: Ditto.
platform/text/mac/LocaleMac.mm: Ditto.

Source/WebKit/chromium:

src/ColorChooserUIController.h:

(ColorChooserUIController):
Rename m_localizer to m_locale, and follow other renamings.

src/ColorChooserUIController.cpp:

(WebKit::ColorChooserUIController::ColorChooserUIController): Follow renamings.
(WebKit::ColorChooserUIController::locale): Ditto.

src/DateTimeChooserImpl.h:

(DateTimeChooserImpl):
Rename m_localizer to m_locale, and follow other renamings.

src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::DateTimeChooserImpl): Follow renamings.
(WebKit::DateTimeChooserImpl::writeDocument): Ditto.
(WebKit::DateTimeChooserImpl::locale): Ditto.

tests/LocaleMacTest.cpp:

(LocaleMacTest::formatTime): Ditto.
(testNumberIsReversible): Ditto.

tests/LocalizedNumberICUTest.cpp:

(testNumberIsReversible): Ditto.
(testDecimalSeparator): Ditto.

1:49 AM Changeset in webkit [132773] by mkwst@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Error messages lines in console are 1px taller than regular messages
https://bugs.webkit.org/show_bug.cgi?id=100521

Reviewed by Pavel Feldman.

The inspector is adding a 1px bottom border to list elements inside
a disclosure list. This is unnecessary in the current layout; it's
causing console messages with stack traces to be one pixel taller than
other console messages, which this patch fixes.

As a drive-by, this patch also adjusts the disclosure triangle's
position to match.

inspector/front-end/inspector.css:

(.outline-disclosure li):
(.outline-disclosure li.parent::before):

1:48 AM Changeset in webkit [132772] by mkwst@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: The bubble for repeated errors is misplaced.
https://bugs.webkit.org/show_bug.cgi?id=100525

Reviewed by Pavel Feldman.

The repeated-message bubble is displayed as an inline-block element,
which works well as long as no stack trace is present. If present, the
message is wrapped in an 'ol' element displayed as a block, which pushes
itself down to the next line.

To avoid that issue, this patch switches the wrapper element to flexbox,
glorious flexbox.

inspector/front-end/inspector.css:

(.console-message .bubble):
(.repeated-message .outline-disclosure):
(.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message):

1:45 AM Changeset in webkit [132771] by tkent@chromium.org

3 edits
1 copy in trunk/LayoutTests

[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=99818

The failure of month-multiple-fields-keyboard-events.html on SnowLeopard
and XP is expected.

OS X SnowLeopard The month forma is "yyyy MMMM" on SnowLoepard though it's "MMMM yyyy" on other platforms.

Windows XP It doesn't support the lang-attribute-aware-form-control-UI testing

feature.

platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt.
platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
platform/chromium/TestExpectations:

1:36 AM Changeset in webkit [132770] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Skip 2 tests failing due to missing drag'n drop support
https://bugs.webkit.org/show_bug.cgi?id=100638

Unreviewed EFL gardening.

Skip 2 test cases failing due to missing drag'n drop support
in EFL port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29

platform/efl/TestExpectations:

1:34 AM Changeset in webkit [132769] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Skip 2 jquery tests crashing after r132757
https://bugs.webkit.org/show_bug.cgi?id=100637

Unreviewed EFL gardening.

Skip 2 jquery test cases that started crashing after
r132757.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29

platform/efl/TestExpectations:

1:30 AM Changeset in webkit [132768] by apavlov@chromium.org

5 edits
2 adds in trunk

Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones
https://bugs.webkit.org/show_bug.cgi?id=100119

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/styles/inactive-properties.html

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.createExclamationMark):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):

inspector/front-end/elementsPanel.css:

(.styles-section.computed-style .properties li.not-parsed-ok):
(.styles-section.computed-style .properties li.not-parsed-ok img.exclamation-mark):
(.styles-section .properties .not-parsed-ok):

LayoutTests:

http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpStyleTreeItem):

inspector/styles/inactive-properties-expected.txt: Added.
inspector/styles/inactive-properties.html: Added.

1:17 AM Changeset in webkit [132767] by eric@webkit.org

2 edits in trunk/Websites/webkit.org

Technical Articles should link to an old talk I gave
https://bugs.webkit.org/show_bug.cgi?id=100624

Reviewed by Adam Barth.

coding/technical-articles.html:

1:14 AM Changeset in webkit [132766] by Jonathan Dong

2 edits in trunk/Tools

Unreviewed. Add Jonathan Dong as a committer.
https://bugs.webkit.org/show_bug.cgi?id=100629

Scripts/webkitpy/common/config/committers.py:

12:58 AM WebInspector edited by zandobersek@gmail.com

Removing spam links, moving links to blog posts into a chronological order. (diff)

12:51 AM Changeset in webkit [132765] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip some tests because SHADOW_DOM is disabled on Qt.
Unskip another one that doesn't exist already.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-29

platform/qt/TestExpectations:

12:38 AM Changeset in webkit [132764] by eric@webkit.org

5 edits in trunk/Source/WebCore

Make rendering tables with <colgroups> twice as fast by avoiding walking the DOM for colgroups 4 times for each cell
https://bugs.webkit.org/show_bug.cgi?id=100630

Reviewed by Ojan Vafai.

This is not a complete fix. Our rendering of this large tables still takes 7.8 seconds
on my retina MBP (down from 14.3s before this change).
It's very expensive to walk the DOM each time we call RenderTable::colElement
so this caches the RenderTableCol* in a vector for easier walking.
We invalidate the cache any time a RenderTableCol is added or removed from the
rendering sub-tree to avoid holding a bad pointer.

rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::invalidateCachedColumns):
(WebCore):
(WebCore::RenderTable::addColumn):
(WebCore::RenderTable::removeColumn):
(WebCore::RenderTable::updateColumnCache):
(WebCore::RenderTable::slowColElement):

rendering/RenderTable.h:

(RenderTable):

rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::insertedIntoTree):
(WebCore):
(WebCore::RenderTableCol::willBeRemovedFromTree):

rendering/RenderTableCol.h:

12:29 AM Changeset in webkit [132763] by tkent@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

12:27 AM WebInspector edited by janeparker991@gmail.com

(diff)

12:02 AM Changeset in webkit [132762] by tkent@chromium.org

26 edits
2 moves in trunk/Source

Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=100627

Reviewed by Yuta Kitamura.

Source/WebCore:

We'd like to rename Localizer class to Locale class. However we use
PlatformLocale.cpp and PlatformLocale.h as their file names because
<locale.h> exists in the C standard. In this patch, we rename only file
names. We're going to rename the class name later.

No new tests. This doesn't make any behavior change.

platform/text/PlatformLocale.h: Renamed from Source/WebCore/platform/text/Localizer.h.
platform/text/PlatformLocale.cpp: Renamed from Source/WebCore/platform/text/Localizer.cpp.

Follow the Localizer.h -> PlatformLocale.cpp renaming.

CMakeLists.txt: Follow the file name renaming.
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/Document.cpp: Ditto.
html/BaseDateAndTimeInputType.cpp: Ditto.
html/BaseMultipleFieldsDateAndTimeInputType.cpp: Ditto.
html/DateInputType.cpp: Ditto.
html/DateTimeInputType.cpp: Ditto.
html/DateTimeLocalInputType.cpp: Ditto.
html/MonthInputType.cpp: Ditto.
html/NumberInputType.cpp: Ditto.
html/TimeInputType.cpp: Ditto.
html/shadow/DateTimeEditElement.cpp: Ditto.
html/shadow/DateTimeNumericFieldElement.cpp: Ditto.
page/PagePopupController.cpp: Ditto.
platform/text/LocaleICU.h: Ditto.
platform/text/LocaleNone.cpp: Ditto.
platform/text/LocaleWin.h: Ditto.
platform/text/mac/LocaleMac.h: Ditto.

Source/WebKit/chromium:

src/ColorChooserUIController.h: Follow the file name renaming.
src/DateTimeChooserImpl.cpp: Ditto.

Oct 28, 2012:

10:13 PM Changeset in webkit [132761] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WK2] Fix the incorrect use of preprocessor statement in API header.
https://bugs.webkit.org/show_bug.cgi?id=100610

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-28
Reviewed by Timothy Hatcher.

Remove the preprocessor statement to check 'ENABLE_INSPECTOR' feature
from the WKPage.h.

UIProcess/API/C/WKPage.cpp:

(WKPageGetInspector):

UIProcess/API/C/WKPage.h:

9:08 PM Changeset in webkit [132760] by shinyak@chromium.org

13 edits
12 adds
2 deletes in trunk

The shadow element is not reprojected to a nested ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=99228

Reviewed by Dimitri Glazkov.

Source/WebCore:

We support shadow reprojection; elements distributed to <shadow> element can be reprojected to <content> now.

First, we have a distribution vector for each InsertionPoint, even if InsertionPoint is a shadow insertion point.
And we update a node-distribution map. Basically We're creating a map from node to InsertionPoint in ElementShadow.
If a node can be distributed to several InsertionPoint (e.g. in case reprojection happens),
the InsertionPoint in older ShadowDOM is chosen.

We also fix ComposedShadowTreeWalker to consider shadow reprojection.

Tests: fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html

fast/dom/shadow/shadow-reprojection-click.html
fast/dom/shadow/shadow-reprojection-dynamic.html
fast/dom/shadow/shadow-reprojection-fallback.html
fast/dom/shadow/shadow-reprojection.html
fast/dom/shadow/shadow-reprojection2.html

css/StyleResolver.cpp:

(WebCore::shouldResetStyleInheritance): Now context.insertionPoint() returns the final insertion point where
a node is distributed. So we don't have to trace shadow insertion point anymore here.
(WebCore::StyleResolver::styleForElement): Since a direct child of ShadowRoot can be distributed now. In that case,
we don't have any parentElement. The parent node is a ShadowRoot in that case.

dom/ComposedShadowTreeWalker.cpp:

(WebCore::nodeCanBeDistributed): If a node can be distributed, returns true.
(WebCore):
(WebCore::resolveReprojection): Resolves content-reprojection and shadow-reprojection both.
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost): A case ShadowRoot is assigned
to some InsertionPoint should be handled with in traverseSiblingOrBackToInsertionPoint. So we remove it.
(WebCore::AncestorChainWalker::parent): Now we have a case that a direct child of ShadowRoot can be distributed.
In that case, we should not update m_distributedNode.

dom/ElementShadow.cpp:

(WebCore::ElementShadow::insertionPointFor): Since we have a distribution vector for each InsertionPoint,
we don't have a special case that a ShadowRoot is assigned to some InsertionPoint. Actually the existing code
is not correct now due to shadow reprojection.

html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::populate): Populate a POOL. If a node is InsertionPoint, we fill it with the
distributed nodes.
(WebCore):
(WebCore::ContentDistributor::distribute): Since we want to make a distribution vector for each InsertionPoint,
we have to resolve a shadow InsertionPoint
(WebCore::ContentDistributor::distributeNodeChildrenTo):

html/shadow/ContentDistributor.h:

(ContentDistributor):

html/shadow/HTMLShadowElement.h:

(WebCore::toHTMLShadowElement):
(WebCore):

html/shadow/InsertionPoint.h:

(WebCore::parentNodeForDistribution):
(WebCore::parentElementForDistribution):
(WebCore):

LayoutTests:

fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection-expected.txt: Added.
fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html: Added. A walker test case for elements distributed

to shadow element are reprojected.

fast/dom/shadow/composed-shadow-tree-walker.html:
fast/dom/shadow/content-reprojection-complex.html:
fast/dom/shadow/content-reprojection-fallback-expected.html:
fast/dom/shadow/content-reprojection-fallback-reprojection-expected.html:
fast/dom/shadow/shadow-reprojection-click-expected.txt: Added.
fast/dom/shadow/shadow-reprojection-click.html: Added. Does some interactive with a shadow-reprojected node.
fast/dom/shadow/shadow-reprojection-dynamic-expected.html: Added.
fast/dom/shadow/shadow-reprojection-dynamic.html: Added. Adds dynamically elements shadow-reprojected.
fast/dom/shadow/shadow-reprojection-expected.html: Added.
fast/dom/shadow/shadow-reprojection-fallback-expected.html: Added.
fast/dom/shadow/shadow-reprojection-fallback.html: Added. A test case for fallback elements of a shadow element

are reprojected.

fast/dom/shadow/shadow-reprojection-prohibited-expected.html: Removed.
fast/dom/shadow/shadow-reprojection-prohibited.html: Removed.
fast/dom/shadow/shadow-reprojection.html: Added. A basic test case.
fast/dom/shadow/shadow-reprojection2-expected.html: Added.
fast/dom/shadow/shadow-reprojection2.html: Added. Another basic test case.

9:02 PM Changeset in webkit [132759] by fpizlo@apple.com

20 edits in trunk/Source/JavaScriptCore

DFG should be able to emit effectful structure checks
https://bugs.webkit.org/show_bug.cgi?id=99260

Reviewed by Oliver Hunt.

This change allows us to find out if an array access that has gone polymorphic
is operating over known structures - i.e. the primordial array structures of the
global object that the code block containing the array access belongs to. We
term this state "OriginalArray" for short. The fact that the access has gone
polymorphic means that the array profile will not be able to report the set of
structures it had seen - but if it can tell us that all of the structures were
primordial then it just so happens that we can deduce what the structure set
would have been by just querying the code block's global object. This allows us
to emit an ArrayifyToStructure instead of an Arrayify if we find that we need to
do conversions. The fast path of an ArrayifyToStructure is exactly like the fast
path of a CheckStructure and is mostly subject to the same optimizations. It
also burns one fewer registers.

Essentially the notion of OriginalArray is a super cheap way of getting the
array profile to tell us a structure set instead of a singleton structure.
Currently, the array profile can only tell us the structure seen at an array
access if there was exactly one structure. If there were multiple structures, it
won't tell us anything other than the array modes and other auxiliary profiling
data (whether there were stores to holes, for example). With OriginalArray, we
cheaply get a structure set if all of the structures were primordial for the
code block's global object, since in that case the array mode set (ArrayModes)
can directly tell us the structure set. In the future, we might consider adding
complete structure sets to the array profiles, but I suspect that we would hit
diminishing returns if we did so - it would only help if we have array accesses
that are both polymorphic and are cross-global-object accesses (rare) or if the
arrays had named properties or other structure transitions that are unrelated to
indexing type (also rare).

This also does away with Arrayify (and the new ArrayifyToStructure) returning
the butterfly pointer. This turns out to be faster and easier to CSE.

And, this also changes constant folding to be able to eliminate CheckStructure,
ForwardCheckStructure, and ArrayifyToStructure in addition to being able to
transform them into structure transition watchpoints. This is great for
ArrayifyToStructure because then CSE and CFA know that there is no side effect.
Converting CheckStructure and ForwardCheckStructure to also behave this way is
just a matter of elegance.

This has no performance impact right now. It's intended to alleviate some of the
regressions seen in the early implementation of
https://bugs.webkit.org/show_bug.cgi?id=98606.

bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

bytecode/ArrayProfile.h:

(JSC):
(JSC::ArrayProfile::ArrayProfile):
(ArrayProfile):
(JSC::ArrayProfile::usesOriginalArrayStructures):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::alreadyChecked):
(JSC::DFG::arrayClassToString):

dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::withProfile):
(JSC::DFG::ArrayMode::isJSArray):
(ArrayMode):
(JSC::DFG::ArrayMode::isJSArrayWithOriginalStructure):
(JSC::DFG::ArrayMode::supportsLength):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleGetByOffset):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getScopeRegistersLoadElimination):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):

dfg/DFGNode.h:

(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::arrayMode):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(JSC::DFG::SpeculativeJIT::arrayify):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::isOriginalArrayStructure):

runtime/Structure.cpp:

(JSC::Structure::nonPropertyTransition):

7:50 PM Changeset in webkit [132758] by commit-queue@webkit.org

6 edits in trunk

Webkit adds a boundary to the Content-Type: text/plain POST header
https://bugs.webkit.org/show_bug.cgi?id=100445

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-28
Reviewed by Kent Tamura.

Source/WebCore:

Fixed a bug where an empty boundary parameter was added to Content-Type
header when POSTing forms with enctype=text/plain.

Test: http/tests/misc/form-post-textplain.html

loader/FormSubmission.cpp:

(WebCore::FormSubmission::populateFrameLoadRequest): Add boundary parameter to
Content-Type only when a boundary string is generated.

LayoutTests:

Fixed test failure and added a test case for Content-Type header.

http/tests/misc/form-post-textplain-expected.txt:
http/tests/misc/form-post-textplain.html:
http/tests/misc/resources/form-post-textplain.php:

Added a test case for testing Content-Type POST header.
Also fixed existing test case that attempted to test newline in the input value.
LF in the input value is replaced with CRLF durling the construction of the form data set.

7:16 PM Changeset in webkit [132757] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

There should not be blind spots in array length array profiling
https://bugs.webkit.org/show_bug.cgi?id=100620

Reviewed by Oliver Hunt.

I don't think this has any performance impact. But it's good to not have random
programs occasionally emit a GetById for array length accesses.

jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePatchGetArrayLength):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePatchGetArrayLength):

4:39 PM Changeset in webkit [132756] by tkent@chromium.org

6 edits in trunk/LayoutTests

[Chromium] Test expectation update

Rebaseline for http://trac.webkit.org/changeset/132753

platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:

4:32 PM Changeset in webkit [132755] by pdr@google.com

4 edits in trunk/Source/WebCore

Cache calcMode() value for SVG animations.
https://bugs.webkit.org/show_bug.cgi?id=99694

Reviewed by Eric Seidel.

This patch refactors SVGAnimationElement::calcMode() to return a cached value instead
of recalculating its value on every call. On a simple test of 100 rectangles with 100
animations each, calls to calcMode() account for 3% of the total animation. After this
patch, calcMode() no longer appears in animation profiles at all.

No new tests as this functionality is covered by existing tests.

svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):

The default calcMode for all animation types is linear except AnimateMotion,
which defaults to CalcModePaced.
See: http://www.w3.org/TR/SVG/single-page.html#animate-CalcModeAttribute

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::isSupportedAttribute):
(WebCore::SVGAnimationElement::parseAttribute):
(WebCore::SVGAnimationElement::setCalcMode):

svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::calcMode):
(WebCore::SVGAnimationElement::setCalcMode):
(SVGAnimationElement):

3:35 PM Changeset in webkit [132754] by Dimitri Glazkov

5 edits in trunk/Source/WebCore

Get rid of StyleResolver state related to unknown pseudo-elements.
https://bugs.webkit.org/show_bug.cgi?id=100582

Reviewed by Eric Seidel.

All of the state, related to unknown pseudo-elements is already understood at the time of collecting rules.
We can just get rid of most of this code in StyleResolver.

At the time of matching rules, we know for certain that only rules that contain unknown pseudo-elements,
or are UA rules, or are explicitly invited by a TreeScope will match. So we can just return early in many cases.

No change in behavior, covered by existing tests.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Removed now-unnecessary param.
(WebCore::SelectorChecker::checkOneSelector): Ditto.

css/SelectorChecker.h:

(SelectorChecker): Ditto.

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver): Ditto.
(MatchingUARulesScope): Moved class definition here, since we now use it in a different place.
(WebCore::StyleResolver::collectMatchingRules): Changed the logic to stop matching rules that definitely won't match in a different scope.
(WebCore::StyleResolver::collectMatchingRulesForList): Removed code that's now unnecesssary.
(WebCore::StyleResolver::checkSelector): Removed now-unnecessary param.
(WebCore::StyleResolver::checkRegionSelector): Removed weird dead code.

css/StyleResolver.h:

(StyleResolver): Removed now-unnecessary member.

2:42 PM Changeset in webkit [132753] by commit-queue@webkit.org

12 edits
21 adds
6 deletes in trunk

Unreviewed, rolling out r132696.
http://trac.webkit.org/changeset/132696
https://bugs.webkit.org/show_bug.cgi?id=100609

Needs a bit more clean-up on Chrome Web UI side. (Requested by
dglazkov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-28

Source/WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

rendering/RenderListBox.h:
rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
fast/forms/pseudo-elements-expected.html: Removed.
fast/forms/pseudo-elements.html: Removed.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.

2:36 PM Changeset in webkit [132752] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Unreviewed, make always-true enum-to-int comparisons use casts.

dfg/DFGFPRInfo.h:

(JSC::DFG::FPRInfo::debugName):

dfg/DFGGPRInfo.h:

(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):

5:31 AM Changeset in webkit [132751] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Viewport size does not change when the window size changes
https://bugs.webkit.org/show_bug.cgi?id=100573

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-28
Reviewed by Kenneth Rohde Christiansen.

The viewport size is set when we create the window the first time
and does not change automatically afterwards. When we change the window size,
we need to explicitly change the viewport size as well.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::createGLSurface):

5:17 AM Changeset in webkit [132750] by tkent@chromium.org

17 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=100128

Rebaseline for http://trac.webkit.org/changeset/132718 and crrev.com/164515.

platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
platform/chromium/TestExpectations:

1:20 AM Changeset in webkit [132749] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

OSR exit compilation should defend against argument recoveries from code blocks that are no longer on the inline stack
https://bugs.webkit.org/show_bug.cgi?id=100601

Reviewed by Oliver Hunt.

This happened to me while I was fixing bugs for https://bugs.webkit.org/show_bug.cgi?id=100599.
I'm not sure how to reproduce this.

dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(AssemblyHelpers):

dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

12:06 AM Changeset in webkit [132748] by Csaba Osztrogonác

2 edits
7 adds in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, skip a failing test, update expected files.

platform/qt-5.0-wk2/TestExpectations:
platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
platform/qt-5.0-wk2/http/tests/navigation/postredirect-basic-expected.txt: Added.
platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback1-expected.txt: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed