Context Navigation

← Previous Period
Next Period →

Timeline

Oct 31, 2012:

11:55 PM Changeset in webkit [133131] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Sparse array size threshold should be increased to 100000
https://bugs.webkit.org/show_bug.cgi?id=100827

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-10-31
Reviewed by Oliver Hunt.

This enables the use of contiguous arrays in programs that previously
couldn't use them. And I so far can't see any examples of this being
a downside. To the extent that there is a downside, it ought to be
addressed by GC: https://bugs.webkit.org/show_bug.cgi?id=100828

runtime/ArrayConventions.h:

(JSC):

11:20 PM Changeset in webkit [133130] by Nate Chapin

6 edits in trunk/Source/WebCore

Remove some CachedResource::Status's in favor of looking at CachedResource::m_error
https://bugs.webkit.org/show_bug.cgi?id=100901

Reviewed by Adam Barth.

No new tests, refactor only.

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrameTree):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::stopLoading):

loader/cache/CachedResource.h:

(WebCore::CachedResource::wasCanceled):
(WebCore::CachedResource::errorOccurred):
(WebCore::CachedResource::loadFailedOrCanceled):

11:09 PM Changeset in webkit [133129] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Sparse array size threshold should be increased to 100000
https://bugs.webkit.org/show_bug.cgi?id=100827

Reviewed by Oliver Hunt.

runtime/ArrayConventions.h:

(JSC):

10:26 PM Changeset in webkit [133128] by Lucas Forschler

4 edits in trunk/Source

Versioning.

10:21 PM Changeset in webkit [133127] by Lucas Forschler

1 copy in tags/Safari-537.17

New Tag.

10:19 PM Changeset in webkit [133126] by commit-queue@webkit.org

7 edits
7 adds in trunk/Source/WebKit2

[EFL][WK2] Add ewk_security_origin and ewk_storage_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=92827

Patch by Jihye Kang <jye.kang@samsung.com> on 2012-10-31
Reviewed by Gyuyoung Kim.

Add ewk_security_origin APIs to get security origin.
These APIs will be used to get host, protocol and port of security
origin.
Add ewk_storage_manager to manage web storage and
ewk_storage_manager_origins_get to get origins list of web storage.
Add Unit tests for ewk_storage_manager and ewk_security_origin APIs.

PlatformEfl.cmake:
UIProcess/API/efl/EWebKit2.h:
UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::storageManager):
(ewk_context_storage_manager_get):

UIProcess/API/efl/ewk_context.h:
UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):

UIProcess/API/efl/ewk_security_origin.cpp: Added.

(Ewk_Security_Origin::Ewk_Security_Origin):
(Ewk_Security_Origin::host):
(Ewk_Security_Origin::protocol):
(Ewk_Security_Origin::port):
(ewk_security_origin_ref):
(ewk_security_origin_unref):
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
(ewk_security_origin_port_get):

UIProcess/API/efl/ewk_security_origin.h: Added.
UIProcess/API/efl/ewk_security_origin_private.h: Added.

(Ewk_Security_Origin):
(Ewk_Security_Origin::create):

UIProcess/API/efl/ewk_storage_manager.cpp: Added.

(Ewk_Storage_Manager::Ewk_Storage_Manager):
(Ewk_Storage_Manager::getStorageOrigins):
(Ewk_Storage_Manager::createOriginList):
(_Ewk_Storage_Origins_Async_Get_Context):
(_Ewk_Storage_Origins_Async_Get_Context::_Ewk_Storage_Origins_Async_Get_Context):
(getStorageOriginsCallback):
(ewk_storage_manager_origins_get):

UIProcess/API/efl/ewk_storage_manager.h: Added.
UIProcess/API/efl/ewk_storage_manager_private.h: Added.

(Ewk_Storage_Manager):
(Ewk_Storage_Manager::create):

UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp: Added.

(getStorageOriginsCallback):
(TEST_F):

9:44 PM Changeset in webkit [133125] by senorblanco@chromium.org

12 edits in trunk/Source

Unreviewed, rolling out r133122.
http://trac.webkit.org/changeset/133122
https://bugs.webkit.org/show_bug.cgi?id=99083

Broke Chromium Win, Android, ChromeOS builds

Source/Platform:

chromium/public/WebContentLayerClient.h:

(WebContentLayerClient):

Source/WebCore:

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::paint):

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:

(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

src/LinkHighlight.cpp:

(WebKit::LinkHighlight::paintContents):

src/LinkHighlight.h:

(LinkHighlight):

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):

src/NonCompositedContentHost.h:

(NonCompositedContentHost):

tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:

(WebCore::TEST_F):

9:34 PM Changeset in webkit [133124] by tasak@google.com

3 edits
2 adds in trunk

[Refactoring] Move initial style setting for ProgressValueElement from attach method to createShadowSubtree method in HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=83664

Reviewed by Hajime Morita.

Source/WebCore:

The original code updates inline style during attach(). However,
the attach would be invoked from Element::recalcStyle()'s reattach().
If updating inline styles during the reattach(), style related flags,
i.e. childNeedsStyleRecalc, and needsStyleRecalc are cleared after the
reattach(). So the inline styles are not updated in next
setNeedsStyleRecalc, because ProgressValueElement has already had
InlineStyleChange (existingChanegType == InlineStyleChange) and
markAncestorsWithChildNeedsStyleRecalc is not invoked.

Test: fast/dom/HTMLProgressElement/progress-bar-set-value.html

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::attach):
Copied updateFromElement from didElementStateChange. If removing the
update, indeterminate-progress-001.html and progress-element.html
under fast/dom/HTMLProgressElement will fail. We still need attach()
and updateFromElement. To remove the attach(), need more refactoring,
i.e. investigating where attach() is invoked from and modifying all
related codes.
(WebCore::HTMLProgressElement::createShadowSubtree):
Initialize m_value by indeterminate-position. The value is default
value of progress element.

LayoutTests:

fast/dom/HTMLProgressElement/progress-bar-set-value-expected.html: Added.
fast/dom/HTMLProgressElement/progress-bar-set-value.html: Added.

9:25 PM Changeset in webkit [133123] by hayato@chromium.org

3 edits in trunk/Source/WebCore

Make resolveReprojection() defined in ComposedShadowTreeWalker.cpp callable from outside.
https://bugs.webkit.org/show_bug.cgi?id=100832

Reviewed by Dimitri Glazkov.

InsertionPoint.h now defines resolveReprojection() so that it can be called from outside.

No new tests as no new functionality.

dom/ComposedShadowTreeWalker.cpp:
html/shadow/InsertionPoint.h:

(WebCore::shadowOfParentForDistribution):
(WebCore):
(WebCore::resolveReprojection):

9:16 PM Changeset in webkit [133122] by alokp@chromium.org

12 edits in trunk/Source

[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083

Reviewed by James Robinson.

Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.

Source/Platform:

chromium/public/WebContentLayerClient.h:

(WebContentLayerClient):
(WebKit::WebContentLayerClient::paintContents):

Source/WebCore:

No new tests needed. This patch does not change anything functionally.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::paint):

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:

(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

src/LinkHighlight.cpp:

(WebKit::LinkHighlight::paintContents):

src/LinkHighlight.h:

(LinkHighlight):

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):

src/NonCompositedContentHost.h:

(NonCompositedContentHost):

tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:

(WebCore::TEST_F):

9:14 PM Changeset in webkit [133121] by dpranke@chromium.org

3 edits in trunk/Tools

NRWT: lint warnings don't show up by default
https://bugs.webkit.org/show_bug.cgi?id=100914

Reviewed by Ryosuke Niwa.

NRWT wasn't printing any warnings if you had errors in your
TestExpectations files; this means you would only notice this
with --lint-test-files, which is probably bad. I'm not sure
when this requested, but perhaps when we changed the
warnings to not be fatal if you weren't linting the files.

Now they're still not fatal, but at least we print them.

Also fix one warning message where we were printing the test name twice.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationsModel._already_seen_better_match):
(TestExpectations._report_warnings):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(MiscTests.test_parse_warnings_are_logged_if_not_in_lint_mode(self): Added.

8:33 PM Changeset in webkit [133120] by tdanderson@chromium.org

2 edits in trunk/Tools

Missing stderr output when using run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=100709

Reviewed by Dirk Pranke.

Appends #EOF to the end of the stderr output only at the end of a test,
not possibly part-way through. This will allow all of the stderr output
to appear on the results page after running run-webkit-tests.

DumpRenderTree/chromium/TestEventPrinter.cpp:

(TestEventPrinter::handleTextFooter):
(TestEventPrinter::handleTestFooter):

8:21 PM Changeset in webkit [133119] by cevans@google.com

3 edits in trunk/Source/WebCore

RenderArena has a memory leak and poor efficiency
https://bugs.webkit.org/show_bug.cgi?id=100893

Reviewed by Eric Seidel.

1) Avoid memory leak that persists for the Document lifetime by
increasing recycled size buckets up to 1024. It was previously 400,
and sizeof(RenderNamedFlowThread) / sizeof(RenderSVGText) both blew this
quota. An assert was added to prevent this happening again.

2) Fix the size of the recyled size bucket array on 64-bit. We only
need 8 byte granularity on 64-bit, but we had 4.

3) Try and pass power-of-two sizes to the underlying malloc() call, so
that we're space efficient. We now take Arena metadata into account.

4) Double the default RenderArena size allocation to 8192 bytes. Even
for a render of a trivial text file, 4096 bytes is not enough to prevent
extra calls into the underlying malloc() for more arena pool.

rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena): Adjust arena size so that we pass on the page-sized multiple to the underlying malloc() implementation.
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free): Assert that the allocation size is handled by our recycling buckets.

rendering/RenderArena.h:

(WebCore): Maintain free buckets up to 1024 bytes to avoid memory leak.
(RenderArena): Double the default allocation size and handle 64-bit systems more efficiently.

8:16 PM Changeset in webkit [133118] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-31

DEPS:

8:11 PM Changeset in webkit [133117] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, remove entries for tests no longer failing.

platform/chromium/TestExpectations:

8:05 PM Changeset in webkit [133116] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Mark a crashy test.

platform/chromium/TestExpectations:

7:57 PM Changeset in webkit [133115] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

platform/chromium/TestExpectations:

7:49 PM Changeset in webkit [133114] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Unreviewed chromium mac ml expectation updating.

platform/chromium-mac-mountainlion/TestExpectations:

7:37 PM Changeset in webkit [133113] by abarth@webkit.org

9 edits in trunk

[V8] Garbage collection should use opaque roots rather than implicit references
https://bugs.webkit.org/show_bug.cgi?id=100707

Reviewed by Kentaro Hara.

Source/WebCore:

This patch replaces visitDOMWrapper with opaqueRootForGC. The
former used to inform V8 of implicit relationships between wrapper
objects on a per-wrapper basis. That meant that we needed to know which
DOMDataStore a given wrapper was in during garbage collection.

After this patch, we now use object groups rather than implicit
references to inform V8 of these relationships. That has two benefits:

1) We no longer need to know which DOMDataStore a wrapper belongs

because we don't need to find the exact source wrapper for the
implicit connection.

2) We can now handle more complicated implicit relationships, for

example when some of the intervening objects haven't had their
JavaScript wrappers created yet.

This patch also unlocks to paths of future development:
A) Fixing the remaining failures in fast/dom/gc-9.html
B) Enumerating DOM wrappers entirely from V8 rather than from the

DOMWrapperMaps (so that we can move more object towards using
IntrusiveDOMWrapperMaps, which aren't enumerable from WebCore).

bindings/scripts/CodeGeneratorV8.pm:

(NeedsCustomOpaqueRootForGC):
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GenerateImplementation):

bindings/v8/V8GCController.cpp:

(ImplicitConnection):
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::root):
(WebCore::ImplicitConnection::wrapper):
(WebCore):
(WebCore::operator<):
(WrapperGrouper):
(WebCore::WrapperGrouper::WrapperGrouper):
(WebCore::WrapperGrouper::addToGroup):
(WebCore::WrapperGrouper::keepAlive):
(WebCore::WrapperGrouper::apply):
(WebCore::ObjectVisitor::ObjectVisitor):
(WebCore::ObjectVisitor::visitDOMWrapper):
(ObjectVisitor):
(WebCore::V8GCController::opaqueRootForGC):
(WebCore::NodeVisitor::NodeVisitor):
(WebCore::NodeVisitor::visitNodeWrapper):
(NodeVisitor):
(WebCore::V8GCController::majorGCPrologue):

bindings/v8/V8GCController.h:

(WebCore):
(V8GCController):

bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::opaqueRootForGC):
(WrapperTypeInfo):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp:

(WebCore::V8SpeechRecognitionResult::opaqueRootForGC):

LayoutTests:

Test progression.

platform/chromium/fast/dom/gc-9-expected.txt:

7:08 PM Changeset in webkit [133112] by senorblanco@chromium.org

43 edits in trunk/Source

Unreviewed, rolling out r133107.
http://trac.webkit.org/changeset/133107
https://bugs.webkit.org/show_bug.cgi?id=100425

Source/WebCore:

Broke compile on Chromium Win.

Modules/indexeddb/IDBCallbacks.h:

(IDBCallbacks):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
(WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap):
(WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap):

Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

Modules/indexeddb/IDBFactory.cpp:
Modules/indexeddb/IDBFactory.h:
Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::openKeyCursor):

Modules/indexeddb/IDBIndexBackendInterface.h:
Modules/indexeddb/IDBKeyPath.cpp:
Modules/indexeddb/IDBMetadata.h:

(WebCore):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBObjectStoreMetadata):
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(IDBIndexMetadata):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReadyInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap):
(WebCore::IDBObjectStoreBackendImpl::addIndexToMap):

Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

Modules/indexeddb/IDBObjectStoreBackendInterface.h:
Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onUpgradeNeeded):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):

Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore::IDBTransactionBackendImpl::scheduleTask):

Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

Modules/indexeddb/IDBTransactionBackendInterface.h:
Modules/indexeddb/IDBTransactionCoordinator.h:

Source/WebKit/chromium:

Broke compile on Chromium Win

public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::transaction):

public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::index):

public/WebIDBTransaction.h:

(WebKit::WebIDBTransaction::objectStore):

src/IDBDatabaseBackendProxy.cpp:
src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):

src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

src/IDBTransactionBackendProxy.cpp:
src/IDBTransactionBackendProxy.h:

(IDBTransactionBackendProxy):

src/WebIDBCallbacksImpl.cpp:
src/WebIDBDatabaseImpl.cpp:
src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

src/WebIDBObjectStoreImpl.cpp:
src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

src/WebIDBTransactionImpl.cpp:
src/WebIDBTransactionImpl.h:
tests/IDBDatabaseBackendTest.cpp:

7:00 PM Changeset in webkit [133111] by ryuan.choi@samsung.com

2 edits in trunk/LayoutTests

[EFL] Move jquery/traversing.html to flaky list
https://bugs.webkit.org/show_bug.cgi?id=100908

Unreviewed gardening.

jquery/traversing.html sometimes crashes and sometimes passes, so needs to be moved to the flaky list.

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-31

platform/efl/TestExpectations:

6:59 PM Changeset in webkit [133110] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

platform/chromium/TestExpectations:

6:59 PM Changeset in webkit [133109] by andersca@apple.com

4 edits in trunk/Source

Fix build.
<rdar://problem/12612207>.

Reviewed by Sam Weinig.

Source/WebKit/mac:

Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel loadNib]):

Source/WTF:

wtf/CheckedArithmetic.h:

6:55 PM Changeset in webkit [133108] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. fast\text\international\text-combine-image-test-expected.txt needs some 1 pixel off rebaselines on Windows.

platform/win/fast/text/international/text-combine-image-test-expected.txt:

6:21 PM Changeset in webkit [133107] by alecflett@chromium.org

43 edits in trunk/Source

IndexedDB: add methods to support id-based backend APIs
https://bugs.webkit.org/show_bug.cgi?id=100425

Reviewed by Tony Chang.

Source/WebCore:

First half of refactor involves adding a number of methods that
are int64_t-based rather than String-based. As a part of this, the
IDB*Metadata structs and the backend objectStore/index maps all
use int64_t as keys, rather than String.

In addition, there were a number of cleanups that came out of the
refactor:

The list of object stores active in a transaction is now maintained by the frontend IDBTransaction rather than the backend IDBTransactionBackendImpl. This also had a simplifying rippling effect through other call signatures.

I was able to remove an apparently old FIXME from IDBTransactionBackendImpl::objectStore and replace it with an ASSERT.

IDBObjectStoreBackendImpl's IndexWriter class got a little simpler since the id is now easily available in the IDBIndexMetadata.

A number of methods got simpler in their int64_t versions, specifically dropping a number of ExceptionCodes.

There is also some glue code
(getIndexId/getIndexIds/getObjectStoreId) that will go away with
the 2nd half of this: https://bugs.webkit.org/show_bug.cgi?id=100425

No new tests, no new functionality as this is just a refactor.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
(WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap):
(WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap):

Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):

Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::id):
(WebCore::IDBIndex::openKeyCursor):

Modules/indexeddb/IDBIndexBackendInterface.h:
Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(IDBIndexMetadata):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReadyInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap):
(WebCore::IDBObjectStoreBackendImpl::addIndexToMap):

Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

Modules/indexeddb/IDBObjectStoreBackendInterface.h:
Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onUpgradeNeeded):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):

Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

Modules/indexeddb/IDBTransactionBackendImpl.cpp:

Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

Chromium Proxy and WebIDB* support for new int64_t-based methods.

public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::deleteObjectStore):
(WebKit::WebIDBDatabase::transaction):

public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::put):
(WebKit::WebIDBObjectStore::setIndexKeys):
(WebKit::WebIDBObjectStore::setIndexesReady):
(WebKit::WebIDBObjectStore::index):
(WebKit::WebIDBObjectStore::deleteIndex):

public/WebIDBTransaction.h:

(WebKit::WebIDBTransaction::objectStore):

src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::deleteObjectStore):
(WebKit):
(WebKit::IDBDatabaseBackendProxy::transaction):

src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::put):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):

src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

src/IDBTransactionBackendProxy.cpp:

(WebKit::IDBTransactionBackendProxy::objectStore):

src/IDBTransactionBackendProxy.h:

(IDBTransactionBackendProxy):

src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

src/WebIDBTransactionImpl.cpp:

(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):

src/WebIDBTransactionImpl.h:
tests/IDBDatabaseBackendTest.cpp:

6:21 PM Changeset in webkit [133106] by commit-queue@webkit.org

2 edits
2 adds in trunk/LayoutTests

[CSS Exclusions] Test that dynamically setting shape-inside causes relayout in child elements
https://bugs.webkit.org/show_bug.cgi?id=97721

Patch by Bear Travis <betravis@adobe.com> on 2012-10-31
Reviewed by Dirk Schulze.

Adding a test that dynamically sets shape-inside on a block containing multiple block children.

fast/exclusions/resources/simple-rectangle.js:

(createRectangleTest): Modifying test to work with elements with existing content.
(createRectangleTestResult): Modifying test expectation to work with elements with existing content.

fast/exclusions/shape-inside/shape-inside-multiple-blocks-dynamic-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-multiple-blocks-dynamic.html: Added.

6:12 PM Changeset in webkit [133105] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Skip another failing drag and drop test.
Drag & Drop doesn't work correctly in DRT <rdar://5621244>

platform/win/TestExpectations:

6:02 PM Changeset in webkit [133104] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Skipping http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html.
Not supported in CFNetwork yet. https://bugs.webkit.org/show_bug.cgi?id=100349.

platform/win/TestExpectations:

5:59 PM Changeset in webkit [133103] by mark.lam@apple.com

7 edits
3 adds in trunk

A JSC printf (support for %J+s and %b).
https://bugs.webkit.org/show_bug.cgi?id=100566.

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Added VMInspector::printf(), fprintf(), sprintf(), and snprintf().

%b prints ints as boolean TRUE (non-zero) or FALSE (zero).
%Js prints a WTF::String* like a %s prints a char*. Also works for 16bit WTF::Strings (prints wchar_t* using %S).
'+' is a modifier meaning 'use verbose mode', and %J+s is an example of its use.

JavaScriptCore.xcodeproj/project.pbxproj:
interpreter/VMInspector.cpp:

(FormatPrinter):
(JSC::FormatPrinter::~FormatPrinter):
(JSC::FormatPrinter::print):
(JSC::FormatPrinter::printArg):
(JSC::FormatPrinter::printWTFString):
(JSC::FileFormatPrinter::FileFormatPrinter):
(JSC::FileFormatPrinter::printArg):
(JSC::StringFormatPrinter::StringFormatPrinter):
(JSC::StringFormatPrinter::printArg):
(JSC::StringNFormatPrinter::StringNFormatPrinter):
(JSC::StringNFormatPrinter::printArg):
(JSC::VMInspector::fprintf):
(JSC::VMInspector::printf):
(JSC::VMInspector::sprintf):
(JSC::VMInspector::snprintf):

interpreter/VMInspector.h:

(VMInspector):

Source/WebCore:

Added forwarding header for VMInspector.h.

No new tests needed for this.

ForwardingHeaders/interpreter/VMInspector.h: Added.

Tools:

Added regression tests for VMInspector::fprintf() sprintf() and snprintf().

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/JavaScriptCore: Added.
TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Added.

5:59 PM Changeset in webkit [133102] by staikos@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash on html popup form control when element is deleted
https://bugs.webkit.org/show_bug.cgi?id=100869

Reviewed by Yong Li.

Make the element pointers RefPtr so they don't go away before the popup
is closed.

WebCoreSupport/ColorPickerClient.h:

(ColorPickerClient):

WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

WebCoreSupport/SelectPopupClient.h:

(SelectPopupClient):

5:39 PM Changeset in webkit [133101] by crogers@google.com

6 edits
3 adds in trunk

Implement optional arguments in AudioBufferSourceNode start() method
https://bugs.webkit.org/show_bug.cgi?id=100894

Reviewed by Kenneth Russell.

Source/WebCore:

The start() method should be able to take 1, 2, or 3 arguments, optionally supporting
offset and duration. Currently, only 1 and 3 arguments are supported.

Test: webaudio/audiobuffersource-start.html

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::startGrain):
(WebCore):

Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):

Modules/webaudio/AudioBufferSourceNode.idl:

LayoutTests:

webaudio/audiobuffersource-loop-comprehensive.html:
webaudio/audiobuffersource-start-expected.txt: Added.
webaudio/audiobuffersource-start.html: Added.
webaudio/resources/audiobuffersource-testing.js: Added.

(createTestBuffer):
(checkSingleTest):
(checkAllTests):

5:31 PM Changeset in webkit [133100] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Add an optimized version of copyLCharsFromUCharSource for ARM
https://bugs.webkit.org/show_bug.cgi?id=94886

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-31
Reviewed by Gavin Barraclough.

Michael Saboff added a SIMD version of copyLCharsFromUCharSource() in r125846.

This patch a similar optimization for ARMv7 by using the interleaved load/store available
in the NEON extension.

The performance gains:
-10000 characters: ~3.5 times faster.
-20 characters (2 vectors): ~55% faster.
-15 characters (1 vector): ~21% faster.
-3 characters (no vector, pure overhead): ~10% slower.

wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

5:09 PM Changeset in webkit [133099] by Alexandru Chiculita

2 edits in trunk/Source/WebKit2

CustomFilterOperation parameters list is not decoded correctly in CoordinatedGraphicsArgumentCoders
https://bugs.webkit.org/show_bug.cgi?id=100889

Reviewed by Noam Rosenthal.

The custom filters parameters list was initialized with a specific size and then
the decoder was expected to fill it with all the decoded parameters. The decoder was
using the append command which added the paramters at the end, so it doubled the size
of the vector leaving empty spaces at the beginning of the list. Fixed it by writting
directly into the allocated space.

No new tests, the code path is not activated yet.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::decode):

5:06 PM Changeset in webkit [133098] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.
fast/js/post-message-numeric-property.html is flaky in Release as well.

platform/chromium/TestExpectations:

5:03 PM Changeset in webkit [133097] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BLACKBERRY] Custom WebWorks context menus don't always work.
https://bugs.webkit.org/show_bug.cgi?id=100891

Patch by Genevieve Mak <gmak@rim.com> on 2012-10-31
Reviewed by Rob Buis.

Walk up the dom tree until we find the webworks attribute or run out
of parent nodes.
PR# 227732

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

5:03 PM Changeset in webkit [133096] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. svg/custom/font-face-simple.svg
seems to be failing on Windows (wrong font).

platform/chromium/TestExpectations:

4:41 PM Changeset in webkit [133095] by mkwst@chromium.org

105 edits in trunk

Implement the canonical "Content-Security-Policy" header.
https://bugs.webkit.org/show_bug.cgi?id=96765

Reviewed by Adam Barth.

Source/WebCore:

The CSP 1.0 specification defines the "Content-Security-Policy" header
as the canonical mechanism of defining a resource's security policy. Up
through this patch, we've implemented the functionality behind a prefix
in order to ensure compatibility with the standard once it's released as
a recommendation. Both the specification and WebKit's implementation are
far enough along in that process that it makes sense to support the
unprefixed header for sites that wish to opt-in to CSP 1.0.

As discussed on public-webappsec[1], we'll keep the experimental 1.1
features behind the prefixed header ('X-WebKit-CSP') until that standard
is far enough along to justify moving them out to the canonical header.

This patch defines the 'Content-Security-Policy' header for all ports,
just as the 'X-WebKit-CSP' header is currently supported on all ports.
Ports that have not opted-in to the CSP_NEXT flag will see exactly the
same behavior with both headers. Ports that have opted-in will see much
of CSP 1.1's current definition on the prefixed header, and CSP 1.0 on
the canonical header.

The functionality in this change is covered by the changes made to
existing tests. No expectations changed, only the headers that are sent.

dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Add canonical header support to 'meta' element definitions.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

Add canonical header support to FrameLoader.

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::headerType):

The ContentSecurityPolicy::HeaderType enum now has four values:
prefixed/report-only, unprefixed/report-only, prefixed/enforce, and
unprefixed/enforce. Instead of creating logic to output the proper
type based on internal flags, CSPDirectiveList now saves the value
provided at creation time, and returns it via this method.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):

The constructor now accepts a type, which is stored on the object.
It also stores a new internal variable, 'm_experimental', which
defines whether or not experimental features ought to be available.
These features are still locked behind the CSP_NEXT flag, but that
might not be the case forever.

(WebCore::CSPDirectiveList::create):

The static constructor wrapper now passes the type into the real
constructor, which also now handles setting its internal variables.

(WebCore::CSPDirectiveList::parse):

'parse()' is given the header, so it makes sense to store it here as
well, rather than in the create wrapper.

(WebCore::CSPDirectiveList::addDirective):

1.1 directives remain locked behind CSP_NEXT, but now also require
that 'm_experimental' is set, signaling usage of the prefixed header
and an implicit opt-in to 1.1.

page/ContentSecurityPolicy.h:

Added two new types to the HeaderTypes enum: PrefixedReportOnly, and
PrefixedEnforcePolicy. These map to 'X-WebKitCSP-Report-Only' and
'X-WebKit-CSP', respectively.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html:
http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html:
http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html:
http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html:
http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html:
http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html:

Updating these 1.1 tests along with the multiple-iframe-*.js test
"framework" to ensure that the experimental prefixed header is sent.

http/tests/security/contentSecurityPolicy/blob-urls-match-self.html:
http/tests/security/contentSecurityPolicy/combine-multiple-policies.html:
http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html:
http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html:
http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html:
http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html:
http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html:
http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html:
http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html:
http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html:
http/tests/security/contentSecurityPolicy/duplicate-directive.html:
http/tests/security/contentSecurityPolicy/eval-allowed.html:
http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html:
http/tests/security/contentSecurityPolicy/eval-blocked.html:
http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html:
http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html:
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html:
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html:
http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html:
http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-default.html:
http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme.html:
http/tests/security/contentSecurityPolicy/frame-src-allowed.html:
http/tests/security/contentSecurityPolicy/frame-src-blocked.html:
http/tests/security/contentSecurityPolicy/function-constructor-allowed.html:
http/tests/security/contentSecurityPolicy/function-constructor-blocked.html:
http/tests/security/contentSecurityPolicy/iframe-inside-csp.html:
http/tests/security/contentSecurityPolicy/image-allowed.html:
http/tests/security/contentSecurityPolicy/image-blocked.html:
http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html:
http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html:
http/tests/security/contentSecurityPolicy/injected-inline-script-allowed.html:
http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html:
http/tests/security/contentSecurityPolicy/injected-inline-style-allowed.html:
http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html:
http/tests/security/contentSecurityPolicy/inline-script-allowed.html:
http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html:
http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html:
http/tests/security/contentSecurityPolicy/inline-script-blocked.html:
http/tests/security/contentSecurityPolicy/inline-style-allowed.html:
http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html:
http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html:
http/tests/security/contentSecurityPolicy/inline-style-attribute-on-html.html:
http/tests/security/contentSecurityPolicy/inline-style-blocked.html:
http/tests/security/contentSecurityPolicy/media-src-allowed.html:
http/tests/security/contentSecurityPolicy/media-src-blocked.html:
http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html:
http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html:
http/tests/security/contentSecurityPolicy/object-src-url-allowed.html:
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html:
http/tests/security/contentSecurityPolicy/policy-does-not-affect-child.html:
http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html:
http/tests/security/contentSecurityPolicy/report-and-enforce.html:
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html:
http/tests/security/contentSecurityPolicy/report-blocked-uri.html:
http/tests/security/contentSecurityPolicy/report-only-from-header.php:
http/tests/security/contentSecurityPolicy/report-only.html:
http/tests/security/contentSecurityPolicy/report-uri.html:
http/tests/security/contentSecurityPolicy/resources/echo-iframe.pl:
http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl:

s/X-WebKit-CSP/Content-Security-Policy/g

http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl:

Reworking these two scripts in order to support sending both
the experimental header and the canonical header, as required.

http/tests/security/contentSecurityPolicy/resources/event-handler.pl:
http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html:
http/tests/security/contentSecurityPolicy/resources/javascript-url.pl:
http/tests/security/contentSecurityPolicy/resources/mixed-content-with-csp.html:

s/X-WebKit-CSP/Content-Security-Policy/g

http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js:

(testExperimentalPolicy):
(test):
(testImpl.iframe.onload):
(testImpl):

http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:

(testPreescapedPolicy):
(testExperimentalPolicy):
(test):
(testImpl.iframe.onload):
(testImpl):

Reworking these two "frameworks" in order to support sending both
the experimental header and the canonical header, as required.

http/tests/security/contentSecurityPolicy/resources/sandbox.php:
http/tests/security/contentSecurityPolicy/resources/sandboxed-eval.php:
http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html:
http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html:
http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html:
http/tests/security/contentSecurityPolicy/sandbox-empty.html:
http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html:
http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html:
http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html:
http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html:
http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src.html:
http/tests/security/contentSecurityPolicy/style-allowed.html:
http/tests/security/contentSecurityPolicy/style-blocked.html:
http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html:
http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html:
http/tests/security/contentSecurityPolicy/worker-eval-blocked.html:
http/tests/security/contentSecurityPolicy/worker-function-function-blocked.html:
http/tests/security/contentSecurityPolicy/worker-script-src.html:
http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked.html:
http/tests/security/contentSecurityPolicy/xsl-allowed.php:
http/tests/security/contentSecurityPolicy/xsl-blocked.php:
http/tests/security/contentSecurityPolicy/xsl-img-blocked.php:
http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php:
http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php:

s/X-WebKit-CSP/Content-Security-Policy/g

4:27 PM Changeset in webkit [133094] by commit-queue@webkit.org

7 edits
6 adds in trunk

[BlackBerry] Adding window.external to our port
https://bugs.webkit.org/show_bug.cgi?id=100868

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-31
Reviewed by Rob Buis.

Source/WebKit:

Adding ExternalExtension classes to the BB cmake file.

PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Attaching the window.external interface to the frame when
it loads up.

When called, the external interface methods call stubs declared
in ChromeClientBlackBerry. The method passes in the url of the search
provider and the url of the frame. Cross-site check has to be done in the
implementation PR.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addSearchProvider):
(WebCore):
(WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):

WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

WebCoreSupport/ExternalExtension.cpp: Added.

(addSearchProviderMethod):
(IsSearchProviderInstalledMethod):
(externalExtensionInitialize):
(externalExtensionFinalize):

WebCoreSupport/ExternalExtension.h: Added.

(WebCore):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):

LayoutTests:

Adding BlackBerry platform specific DRT tests for window.external interface.

platform/blackberry/external/search-provider/search-provider-installed-expected.txt: Added.
platform/blackberry/external/search-provider/search-provider-installed.html: Added.

4:20 PM Changeset in webkit [133093] by senorblanco@chromium.org

9 edits
4 deletes in trunk/LayoutTests

[chromium] Win rebaselines for media tests. Unreviewed.

platform/chromium-win/media/video-aspect-ratio-expected.png:
platform/chromium-win/media/video-colorspace-yuv420-expected.png:
platform/chromium-win/media/video-colorspace-yuv422-expected.png:
platform/chromium-win/media/video-layer-crash-expected.png:
platform/chromium-win/media/video-transformed-expected.png:
platform/chromium-win/media/video-zoom-controls-expected.png:
platform/chromium-win/media/video-zoom-expected.png:
platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.png:
platform/efl/media/video-aspect-ratio-expected.png: Removed.
platform/efl/media/video-layer-crash-expected.png: Removed.
platform/efl/media/video-transformed-expected.png: Removed.
platform/efl/media/video-zoom-expected.png: Removed.

4:09 PM Changeset in webkit [133092] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Change PopupMenu positioning on Windows such that behaviour on multiple monitors matches Windows standards.
https://bugs.webkit.org/show_bug.cgi?id=100317

Reviewed by Sam Weinig.

The existing code determines which screen the popup menu "belongs" to by determining which screen the owning application's hwnd belongs to,
where ownership is determined by how much of the hwnd is on which screen.
To match what most Windows applications do, the owning screen should be whichever screen the drop down button belongs to.
To determine which screen an element belongs to in Windows we need to pass in an hwnd for that element.
However, since the drop down button is something that WebKit renders there is no hwnd.

To remedy this issue, we can temporarily move the popup menu's hwnd to match the position and size of the button,
determine the correct screen, and then eventually move it back to the correct final position after the rest of
the calculations have been completed. This is all done in the same function call so no rendering of the popup menu occurs
between the temporary and final positionings.

There's not really a good way of testing popup menus except manually, they're separate hwnds created outside of the WebView.

platform/win/PopupMenuWin.cpp:

(WebCore::monitorFromHwnd):
(WebCore):
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::calculatePositionAndSize):

3:50 PM Changeset in webkit [133091] by simonjam@chromium.org

4 edits
1 delete in branches/chromium/1312

Revert 129070 - [Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131

Reviewed by Nate Chapin.

Source/WebCore:

We'll use Chrome's network stack for scheduling instead.

No new tests.

loader/ResourceLoadScheduler.cpp:
loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::preload):

LayoutTests:

The preload scanner loads resources sooner and these tests are affected.

platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.

TBR=simonjam@chromium.org
Review URL: https://codereview.chromium.org/11367020

3:50 PM Changeset in webkit [133090] by Lucas Forschler

16 edits
2 adds in branches/safari-536.28-branch

Merge 121003. '<rdar://problem/12536517>'

3:40 PM Changeset in webkit [133089] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

64-bit llint PC offset can be negative: using an unsigned shift is a bug.
https://bugs.webkit.org/show_bug.cgi?id=100896.

Reviewed by Filip Pizlo.

Fixed the PC offset divisions in the 64-bit llint asm to use rshift instead of urshift.

llint/LowLevelInterpreter64.asm:

3:34 PM Changeset in webkit [133088] by Lucas Forschler

6 edits
2 copies in branches/safari-536.28-branch

Merged r121001. <rdar://problem/12504451>

3:32 PM Changeset in webkit [133087] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, chromium-mac-mountainlion expectation updating.

platform/chromium-mac-mountainlion/TestExpectations:

3:27 PM Changeset in webkit [133086] by thakis@chromium.org

2 edits in branches/chromium/1312/Source/WebCore

Merge 132961 (merge bug: http://crbug.com/158840) - Fix potential overflow in jpeg exif reader. Found by aedla@google.com.
https://bugs.webkit.org/show_bug.cgi?id=100320

Reviewed by Eric Seidel.

Adding more than 1 element past an array is undefined, so don't do it.

No test, since in practice ifd will just overflow and end - ifd will
become much larget than 2 and the if (end - ifd < 2) a few lines
down will catch that case.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readImageOrientation):

TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11361023

3:27 PM Changeset in webkit [133085] by commit-queue@webkit.org

4 edits
3 adds in trunk

Apply transformation for highlights on non-composited contents
https://bugs.webkit.org/show_bug.cgi?id=100438

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-10-31
Reviewed by Adam Barth.

Non-composited content host layer "steals" the contents on the
RenderView layer, including the highlight layer.
The transformation for regular contents are applied by the paint
function of the non-composited content host however the highlight
uses its own WebLayer. Need to apply the same transformation to
the highlight layer as well.

Source/WebKit/chromium:

src/LinkHighlight.cpp:

(WebKit::LinkHighlight::computeEnclosingCompositingLayer):

src/LinkHighlight.h:

(LinkHighlight):

LayoutTests:

platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaled-document.html: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaled-document-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaled-document-expected.txt: Added.

3:22 PM Changeset in webkit [133084] by commit-queue@webkit.org

26 edits
5 adds in trunk

Added viewport at-rule to the CSS parser and tokenizer
https://bugs.webkit.org/show_bug.cgi?id=95961

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

Enable CSS Device Adaptation by default on EFL.

Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add tokens and grammar rules to parse @-webkit-viewport blocks. Also add
the newly parsed rule to the rule list.

This parser now implements the following part of the CSS Device Adaptation
specification: http://www.w3.org/TR/css-device-adapt/#syntax

Test: css3/device-adapt/viewport-at-rule-parsing.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::detectAtToken):
(WebCore):
(WebCore::CSSParser::createViewportRule):

css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::markViewportRuleBodyStart):
(WebCore::CSSParser::markViewportRuleBodyEnd):
(WebCore::CSSParser::inViewport):

These methods are needed by the next patch validating the properties.
Some viewport properties are common to other rules but have different
semantics, and accepts different keywords. The validation needs to be
done in a different code path.

css/CSSPropertySourceData.h:
css/CSSRule.cpp:

(WebCore):
(WebCore::CSSRule::cssText):
(WebCore::CSSRule::destroy):
(WebCore::CSSRule::reattach):
(WebCore::CSSRule::reportMemoryUsage):

css/CSSRule.h:

(CSSRule):
(WebCore::CSSRule::isViewportRule):

css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore):
(WebCore::StyleRuleViewport::StyleRuleViewport):
(WebCore::StyleRuleViewport::~StyleRuleViewport):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleViewport::setProperties):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):

css/StyleRule.h:

(StyleRuleBase):
(WebCore::StyleRuleBase::isViewportRule):
(WebCore):
(StyleRuleViewport):
(WebCore::StyleRuleViewport::create):
(WebCore::StyleRuleViewport::properties):
(WebCore::StyleRuleViewport::copy):

css/WebKitCSSViewportRule.cpp: Added.

(WebCore):
(WebCore::WebKitCSSViewportRule::WebKitCSSViewportRule):
(WebCore::WebKitCSSViewportRule::~WebKitCSSViewportRule):
(WebCore::WebKitCSSViewportRule::style):
(WebCore::WebKitCSSViewportRule::cssText):
(WebCore::WebKitCSSViewportRule::reattach):
(WebCore::WebKitCSSViewportRule::reportDescendantMemoryUsage):

css/WebKitCSSViewportRule.h: Added.

(WebCore):

Tools:

Enable CSS Device Adaptation by default on EFL.

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Added a test that detects if the @-webkit-viewport rule is being
parsed and skip the tests on all ports since the feature is disabled
by default for instance.

Note that this test doesn't do property validation, which will be
added in the next patch of the series.

css3/device-adapt/viewport-at-rule-parsing-expected.txt: Added.
css3/device-adapt/viewport-at-rule-parsing.html: Added.
platform/chromium/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

3:13 PM Changeset in webkit [133083] by commit-queue@webkit.org

3 edits
8 adds in trunk

[CSS Shaders] Validate types of built-in uniforms
https://bugs.webkit.org/show_bug.cgi?id=98974

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-31
Reviewed by Dean Jackson.

Source/WebCore:

Reject shaders which define built-in uniforms with the wrong type. For example, we reject a
shader with the GLSL code "uniform float u_textureSize;" because u_textureSize should be a
vec2, not a float.

Relevant Spec Section:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

Test: css3/filters/custom/invalid-custom-filter-uniform-types.html

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore):
(WebCore::builtInUniformNameToTypeMap):
(WebCore::validateSymbols):

LayoutTests:

Add a test to verify that shaders which define built-in uniforms with the wrong type do not
execute. Add shaders for each built-in uniform in CSS Custom Filters.

Relevant Spec Section:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

css3/filters/custom/invalid-custom-filter-uniform-types-expected.html: Added.
css3/filters/custom/invalid-custom-filter-uniform-types.html: Added.
css3/filters/resources/invalid-type-u-mesh-box.fs: Added.
css3/filters/resources/invalid-type-u-mesh-size.fs: Added.
css3/filters/resources/invalid-type-u-projection-matrix.fs: Added.
css3/filters/resources/invalid-type-u-texture-size.fs: Added.
css3/filters/resources/invalid-type-u-tile-size.fs: Added.
css3/filters/resources/invalid-type-uniform-array.fs: Added.

3:10 PM Changeset in webkit [133082] by tdanderson@chromium.org

4 edits in trunk

[touchadjustment] touch-links-two-finger-tap test pass incorrectly
https://bugs.webkit.org/show_bug.cgi?id=100619

Reviewed by Antonio Gomes.

Tools:

Store the touch area when sending a GestureTwoFingerTap event.

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::gestureEvent):

LayoutTests:

Make use of the gesture's touch area when testing the correct targeting of elements.

touchadjustment/touch-links-two-finger-tap.html:

3:08 PM Changeset in webkit [133081] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. More flaky fallout from
http://trac.webkit.org/changeset/133069.

platform/chromium/TestExpectations:

2:56 PM Changeset in webkit [133080] by Lucas Forschler

3 edits
2 copies in branches/safari-536.28-branch

Merged r118249. <rdar://problem/12536403>

2:49 PM Changeset in webkit [133079] by Lucas Forschler

15 edits
4 copies
2 deletes in branches/safari-536.28-branch

Merged r117971. <rdar://problem/12536368>

2:36 PM Changeset in webkit [133078] by commit-queue@webkit.org

9 edits in trunk

Unreviewed, rolling out r133044.
http://trac.webkit.org/changeset/133044
https://bugs.webkit.org/show_bug.cgi?id=100888

Hits an ASSERT in the isolatedWorlds tests (Requested by
abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-31

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateImplementation):

bindings/v8/V8GCController.cpp:

(WebCore::ObjectVisitor::ObjectVisitor):
(WebCore::ObjectVisitor::visitDOMWrapper):
(ObjectVisitor):
(WebCore::rootForGC):
(ImplicitConnection):
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::root):
(WebCore::ImplicitConnection::wrapper):
(WebCore):
(WebCore::operator<):
(WebCore::NodeVisitor::NodeVisitor):
(WebCore::NodeVisitor::visitNodeWrapper):
(NodeVisitor):
(WebCore::NodeVisitor::applyGrouping):
(WebCore::V8GCController::majorGCPrologue):

bindings/v8/V8GCController.h:

(V8GCController):

bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::visitDOMWrapper):
(WrapperTypeInfo):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::visitDOMWrapper):

bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp:

(WebCore::V8SpeechRecognitionResult::visitDOMWrapper):

LayoutTests:

platform/chromium/fast/dom/gc-9-expected.txt:

2:30 PM Changeset in webkit [133077] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Updating TestExpectations for
recent failures.

platform/chromium/TestExpectations:

2:28 PM Changeset in webkit [133076] by dpranke@chromium.org

2 edits in trunk/Tools

nrwt is not killing stuck DRTs on chromium win
https://bugs.webkit.org/show_bug.cgi?id=100886

Unreviewed, build fix.

In the original implementation of NRWT for Chromium, we used
to assume that DRT would always manage to exit on its own and
so NRWT wouldn't attempt to kill DRT if it was stuck (this was the
"hung worker" problem, and meant that if DRT hung, NRWT would hang).

Eventually, we merged the chromium code with the other ports and
now will always try to shut down DRTs if a test times out, but as
part of that merge we left in a code path where we wouldn't
shut the driver down on windows. This was resulting in stray
DRTs being left around, and NRWT sometimes not exiting cleanly as
a result.

No unit tests added because this was a windows-only code path (hence
hard to test) and that is now gone.

Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.stop):

2:19 PM Changeset in webkit [133075] by weinig@apple.com

21 edits in trunk/Source/WebKit2

Convert the rest of the encoders to take the encoder as a reference
https://bugs.webkit.org/show_bug.cgi?id=100821

Reviewed by Anders Carlsson.

Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::SimpleArgumentCoder::encode):

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::encodeTimingFunction):

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode):

Shared/SessionState.cpp:
Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):

Shared/WebCoreArgumentCoders.h:
Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::Data::encode):

Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):

Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::encodeImage):
(CoreIPC::encodeDataObject):
(CoreIPC::::encode):
(CoreIPC::encodeGKeyFile):
(CoreIPC::encode):

Shared/gtk/ArgumentCodersGtk.h:
Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::encode):

Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::encode):

Shared/qt/ArgumentCodersQt.h:

(CoreIPC):

Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encodePlatformData):

Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encodePlatformData):

Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::::encodePlatformData):

WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeBytes):

WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeBytes):

1:54 PM Changeset in webkit [133074] by pdr@google.com

17 edits in trunk

Cache animationMode() in SVG animations.
https://bugs.webkit.org/show_bug.cgi?id=99694

Reviewed by Eric Seidel.

Source/WebCore:

This patch caches animationMode() which accounted for 25% of the CPU time of a simple
animation benchmark! This is the 3rd patch for WK99694.

Background: SVGAnimationElement contains most of the shared animation logic for <animate>,
<set>, <animateColor>, <animateTransform>, and <animateMotion>. <animateMotion> is the only
animation element that can depend on other elements in the page. For example:
<path id="mypath" d="M0 0 L 100 100Z"/> 
<rect x="0" y="0" width="100" height="100" fill="green">

<animateMotion dur="6s" repeatCount="indefinite">

<mpath xlink:href="#mypath"/>

</animateMotion>

</rect>
See: http://www.w3.org/TR/SVG/single-page.html#animate-AnimateMotionElement

animationMode depends on several properties of an animation element: the set tag, whether
the animation has a path, and the "values", "to", and "by" attributes. animationMode() was
a hot function for two reasons:
1) hasAttribute(SVGNames::valuesAttr) is expensive because we are unable to use

fastHasAttribute. This is cacheable by simply calculating the animationMode when the
"values" attribute changes.

2) In the <animateMotion> case, determining if a path is empty or changed is expensive.

AnimateMotion can have a path attribute, or it can have <mpath> children that reference
a (possibly non-existent) <path> element elsewhere in the page. Before this patch we did
this path lookup on every animation loop in case something changed. After this patch we
only update AnimateMotion's path when it changes.

A previous patch, http://trac.webkit.org/changeset/132847, laid the groundwork for tracking
<path> changes in <mpath>. This patch adds <mpath> to our resource tracking infrastructure
to track when target <path>s change, instead of looking this up every time.

This refactoring is covered by existing tests.
svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg fails after this patch
because our element dependency tracking has a bug with duplicate ids; see WK99893.

svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::parseAttribute):
(WebCore::SVGAnimateMotionElement::updateAnimationPath):

animationPath() has been changed to updateAnimationPath() and should only be called
when the animation path (path attribute, or mpath's referenced path) has changed.

(WebCore::SVGAnimateMotionElement::buildTransformForProgress):
(WebCore::SVGAnimateMotionElement::updateAnimationMode):

If an animationPath exists, we use PathAnimation, otherwise we fall back to the normal
updateAnimationMode() codepath.

(WebCore):

svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::isSupportedAttribute):
(WebCore::SVGAnimationElement::parseAttribute):

The from, by, and to attributes have been added so that we can track when they change
and update the animation mode. Similarly for when the values attribute changes.

(WebCore::SVGAnimationElement::updateAnimationMode):

svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::animationMode):
(SVGAnimationElement):
(WebCore::SVGAnimationElement::setAnimationMode):
(WebCore::SVGAnimationElement::calculateDistance):

svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):

It would be nice to move all the duplicated buildPendingResource() logic into a central
place (SVGURIReference?) but for now it is copied. This function is nearly identical to
SVGFEImageElement::buildPendingResource.

(WebCore):
(WebCore::SVGMPathElement::clearResourceReferences):
(WebCore::SVGMPathElement::insertedInto):
(WebCore::SVGMPathElement::removedFrom):
(WebCore::SVGMPathElement::svgAttributeChanged):
(WebCore::SVGMPathElement::targetPathChanged):
(WebCore::SVGMPathElement::notifyParentOfPathChange):

svg/SVGMPathElement.h:

(SVGMPathElement):

svg/SVGPathElement.cpp:

When a <path>'s path changes, we need to notify any dependent <mpath> elements. This is
typically handled with RenderSVGResource::markForLayoutAndParentResourceInvalidation
but for the special-case of <mpath> we only need to track when the path's "d" attribute
changes so invalidateMPathDependencies() has been added.

(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::invalidateMPathDependencies):
(WebCore):
(WebCore::SVGPathElement::insertedInto):
(WebCore::SVGPathElement::removedFrom):

svg/SVGPathElement.h:

(SVGPathElement):

svg/SVGSetElement.cpp:

(WebCore::SVGSetElement::SVGSetElement):
(WebCore::SVGSetElement::updateAnimationMode):
(WebCore):

svg/SVGSetElement.h:

(SVGSetElement):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::isSupportedAttribute):

LayoutTests:

platform/chromium/TestExpectations:
platform/mac/TestExpectations:

1:49 PM Changeset in webkit [133073] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Updating TestExpectations for
recent failures.

platform/chromium/TestExpectations:

1:45 PM Changeset in webkit [133072] by Lucas Forschler

12 edits
6 copies
3 deletes in branches/safari-536.28-branch

Merged r117865. <rdar://problem/12536400>

1:42 PM Changeset in webkit [133071] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

platform/chromium/TestExpectations:

1:38 PM Changeset in webkit [133070] by Lucas Forschler

8 edits
15 copies in branches/safari-536.28-branch

Merged r117482. <rdar://problem/12536395>

1:35 PM Changeset in webkit [133069] by fischman@chromium.org

4 edits in trunk

[chromium] DRT and WTR should clear the cache between tests
https://bugs.webkit.org/show_bug.cgi?id=93195

Reviewed by Tony Chang.

Tools:

This change makes chromium DRT match the GTK+, Qt, and EFL ports.

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.

LayoutTests:

media/video-poster-blocked-by-willsendrequest.html: updated list of still-busted ports.

1:11 PM Changeset in webkit [133068] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Mark a few tests as crashing.

platform/chromium/TestExpectations:

1:11 PM Changeset in webkit [133067] by Beth Dakin

6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=100879
ScrollingStateNode::cloneAndResetNode() should not be virtual

Reviewed by Simon Fraser.

cloneAndResetNode() is currently pure virtual and implemented only
in ScrollingStateScrollingNode. However, all of the work that it
does at this time is stuff that a generic ScrollingStateNode could
do. We should move this implementation to the base class so that it
does not need to be duplicated for future node types.

This patch also re-names cloneAndResetNode() to cloneAndReset()
and correspondingly re-names cloneAndResetChildNodes() to
cloneAndResetChildren().

Finally the patch also changes the copy constructors of both of these
classes to take a const reference instead of a pointer.

page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::ScrollingStateNode):
(WebCore::ScrollingStateNode::cloneAndReset):
(WebCore):
(WebCore::ScrollingStateNode::cloneAndResetChildren):

page/scrolling/ScrollingStateNode.h:

(ScrollingStateNode):

page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore):

page/scrolling/ScrollingStateScrollingNode.h:

(ScrollingStateScrollingNode):

page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit):

1:07 PM Changeset in webkit [133066] by tsepez@chromium.org

7 edits
5 copies
2 moves
3 adds in trunk

Source/WebCore: Malformed X-XSS-Protection headers not reported.
https://bugs.webkit.org/show_bug.cgi?id=100538

Reviewed by Adam Barth.

Re-writes X-XSS-Protection header parser to be more particular, and to
return better information on error.

Tests: http/tests/security/xssAuditor/malformed-xss-protection-header-1.html

http/tests/security/xssAuditor/malformed-xss-protection-header-2.html
http/tests/security/xssAuditor/malformed-xss-protection-header-4.html
http/tests/security/xssAuditor/xss-protection-parsing-02.html

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):
Detect error return code and log console message with details

platform/network/HTTPParsers.cpp:

(WebCore):
(WebCore::skipWhiteSpace):
Use safe less-than comparsion in case called with pos already out of range.
(WebCore::skipToken):
Fix comparison to properly reject substrings at end of input. Prevent advancing
returned position when match fails, so that this may someday be used to match
optional tokens.
(WebCore::parseXSSProtectionHeader):
Return detailled error status. Avoid needless string copy.

platform/network/HTTPParsers.h:

Add new error returns for x-xss-protection header parser.

LayoutTests: Malformed X-XSS-Protection headers not reported
https://bugs.webkit.org/show_bug.cgi?id=100538

Reviewed by Adam Barth.

http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Removed.
http/tests/security/xssAuditor/malformed-xss-protection-header.html: Removed.
http/tests/security/xssAuditor/malformed-xss-protection-header-1.html: Copied from LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header.html.
http/tests/security/xssAuditor/malformed-xss-protection-header-expected-1.txt: Copied from LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt.

renamed to -1 to match convention.

http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt: Added.
http/tests/security/xssAuditor/malformed-xss-protection-header-2.html: Added.
http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt: Added.
http/tests/security/xssAuditor/malformed-xss-protection-header-3.html: Added.
http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt: Added.
http/tests/security/xssAuditor/malformed-xss-protection-header-4.html: Added.

New test to cover new error message cases.

http/tests/security/xssAuditor/resources/echo-intertag.pl:

Added more x-xss-protection header values to its set of values.

http/tests/security/xssAuditor/xss-protection-parsing-01.html:

Converted for interface change to echo_intertag.pl

http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt: Added.
http/tests/security/xssAuditor/xss-protection-parsing-02.html: Added.

New test for testing x-xss-protect: 0; (allow trailing semicolon).

1:02 PM Changeset in webkit [133065] by kbr@google.com

1 edit in branches/chromium/1312/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

Merge 132980 - Set the initial scissor box for WebGL
https://bugs.webkit.org/show_bug.cgi?id=100804

Patch by Gregg Tavares <gman@google.com> on 2012-10-30
Reviewed by Kenneth Russell.

The initial scissor box needs to be set for WebGL

No new tests as no new functionality.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11366017

1:01 PM Changeset in webkit [133064] by dpranke@chromium.org

3 edits in trunk/Tools

Fix typos introduced in r133061.
Unreviewed, build fix.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
Scripts/webkitpy/tool/servers/reflectionhandler.py:

(ReflectionHandler._serve_file):

12:50 PM Changeset in webkit [133063] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[chromium] Fix incorrect test names landed in
http://trac.webkit.org/changeset/133056

Unreviewed.

platform/chromium/TestExpectations:

12:43 PM Changeset in webkit [133062] by senorblanco@chromium.org

2 edits
1 move in trunk/LayoutTests

[chromium] New linux baseline for basic-inputs-expected.png, due to
crrev.com/164985.

Unreviewed.

platform/chromium-linux/fast/forms/basic-inputs-expected.png:
platform/efl-wk1/fast/forms/basic-inputs-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/basic-inputs-expected.png.

12:36 PM Changeset in webkit [133061] by dpranke@chromium.org

9 edits in trunk/Tools

garden-o-matic should work for local results
https://bugs.webkit.org/show_bug.cgi?id=100805

Reviewed by Adam Barth.

This is the next step in making garden-o-matic replace
'webkit-patch rebaseline-server' and be able to deal with local
results. garden-o-matic now accepts a '--results-directory' option
that will point to a layout-test-results directory. At the moment
this will only work if you are also filtering to a single bot/
platform at a time (we can't handle multiple bots' worth of local
results, but that is a logical next step).

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
Scripts/webkitpy/tool/commands/gardenomatic.py:

(GardenOMatic.init):
(GardenOMatic.execute):

Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):
(RebaselineTest.init):
(RebaselineTest._rebaseline_test):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._rebaseline_commands):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineJson.init):

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(_BaseTestCase):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):
(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaselineJson.test_move_overwritten):
(TestRebaselineJson.test_no_optimize):
(TestRebaselineExpectations.test_rebaseline_expectations):

Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaselineall):
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler.localresult):

Scripts/webkitpy/tool/servers/reflectionhandler.py:

(ReflectionHandler.do_POST):
(ReflectionHandler):
(ReflectionHandler.do_HEAD):

12:34 PM Changeset in webkit [133060] by dpranke@chromium.org

14 edits in trunk/Tools

garden-o-matic should support gardening a single port and specifying how to deal with overwritten baselines
https://bugs.webkit.org/show_bug.cgi?id=100563

Reviewed by Ojan Vafai.

This patch starts the process of making garden-o-matic more useful for
bringing up a single new port in two ways. The goal is to fully
obsolete webkit-patch rebaseline-server.

First, it adds support for the --platform arguments to garden-o-matic
(so that the UI will default to the right cluster of bots), and if the platform arg
specifies a single bot, filters the results down to just that bot.

Second, it adds support for --move-overwritten-baselines and changes
the implementation of the move_overwritten_baselines setting in builders.py
so that it is only used if this flag is provided.

Future patches will make it possible to use local copies of the build
results (rather than going to the bots) and other optimizations to make
it faster to review lots of changes on a single bot.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

Scripts/webkitpy/layout_tests/port/builders.py:
Scripts/webkitpy/tool/commands/gardenomatic.py:

(GardenOMatic):
(GardenOMatic.execute):

Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.init):
(RebaselineTest):
(OptimizeBaselines):
(AnalyzeBaselines):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._rebaseline_commands):
(AbstractParallelRebaselineCommand._rebaseline):
(Rebaseline.init):

Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPServer.url):
(GardeningHTTPRequestHandler.rebaselineall):

12:29 PM Changeset in webkit [133059] by commit-queue@webkit.org

4 edits in trunk/Source

Enable webkit2 introspection
https://bugs.webkit.org/show_bug.cgi?id=94313

Patch by Jesse van den Kieboom <jessevdk@gnome.org> on 2012-10-31
Reviewed by Martin Robinson.

This patch enables generation of introspection information for webkit2
in the same was as it is done for webkit. The resulting gir and
typelib file are named WebKit2-3.0.{gir,typelib}.

GNUmakefile.am:
UIProcess/API/gtk/WebKitBackForwardList.cpp:

12:20 PM Changeset in webkit [133058] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Adjust expectations for float-wrap-zoom on mac.
Unreviewed.

platform/chromium/TestExpectations:

12:17 PM Changeset in webkit [133057] by commit-queue@webkit.org

7 edits
5 adds in trunk/Source/WebKit2

[EFL][WK2] Add Ewk_File_Chooser_Request API
https://bugs.webkit.org/show_bug.cgi?id=100818

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

Add Ewk_File_Chooser_Request API so that the client
can handle file chooser requests (e.g. Show a file
picker dialog) when the user clicks on an input
element of type "file".

PlatformEfl.cmake:
UIProcess/API/efl/EWebKit2.h:
UIProcess/API/efl/EwkViewCallbacks.h:

(EwkViewCallbacks):

UIProcess/API/efl/ewk_file_chooser_request.cpp: Added.

(Ewk_File_Chooser_Request::Ewk_File_Chooser_Request):
(Ewk_File_Chooser_Request::~Ewk_File_Chooser_Request):
(Ewk_File_Chooser_Request::allowMultipleFiles):
(Ewk_File_Chooser_Request::acceptedMIMETypes):
(Ewk_File_Chooser_Request::cancel):
(Ewk_File_Chooser_Request::chooseFiles):
(ewk_file_chooser_request_ref):
(ewk_file_chooser_request_unref):
(ewk_file_chooser_request_allow_multiple_files_get):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_cancel):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):

UIProcess/API/efl/ewk_file_chooser_request.h: Added.
UIProcess/API/efl/ewk_file_chooser_request_private.h: Added.

(WebKit):
(Ewk_File_Chooser_Request):
(Ewk_File_Chooser_Request::create):
(Ewk_File_Chooser_Request::wasHandled):

UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/tests/resources/file_chooser.html: Added.
UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp: Added corresponding

unit tests.
(onFileChooserRequest):
(compareStrings):
(freeStringList):
(TEST_F):

UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::runOpenPanel):
(WebKit):
(WebKit::PageUIClientEfl::PageUIClientEfl):

UIProcess/efl/PageUIClientEfl.h:

(PageUIClientEfl):

12:01 PM Changeset in webkit [133056] by Simon Fraser

8 edits
8 adds in trunk

REGRESSION (tile cache layers): bits of tiled layers are missing with certain 3D transforms
https://bugs.webkit.org/show_bug.cgi?id=100808
<rdar://problem/12562541>

Reviewed by Dean Jackson.

Source/WebCore:

When projecting rects down into transformed layers, the projection can fail with severe
3D rotations if the computed w component in TransformationMatrix::projectPoint() is negative.
In this case we already clamp, but the fact that we clamped doesn't make it out to
GraphicsLayerCA::computeVisibleRect() which resulted in incorrect visible rects being
computed.

Fix by propagating the fact that clamping occurred out of the TransformState functions
which can clamp. In computeVisibleRect(), simply consider the entire layer bounds
to be visible if clamping occurred.

Tests: compositing/tiling/rotated-tiled-clamped.html

compositing/tiling/rotated-tiled-preserve3d-clamped.html

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::computeVisibleRect): If either the applyTransform()
or the state.mappedQuad() clamped, use our bounds as the visible rect.

platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::applyTransform): Pass out clamping state.
(WebCore::TransformState::flatten): Ditto.
(WebCore::TransformState::mappedPoint): Ditto.
(WebCore::TransformState::mappedQuad): Ditto.
(WebCore::TransformState::flattenWithTransform): Ditto. No need to initialize
wasClamped, since this function is internal.

platform/graphics/transforms/TransformState.h:

(TransformState):

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectQuad): If any point projection clamped,
set the flag to say we clamped.

platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

LayoutTests:

Two tests for visible rect computation under clamping, one of which tests 'applyWasClamped',
and the other 'mapWasClamped'.

compositing/tiling/rotated-tiled-clamped-expected.png: Added.
compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
compositing/tiling/rotated-tiled-clamped.html: Added.
compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
compositing/tiling/rotated-tiled-preserve3d-clamped.html: Added.
platform/chromium/TestExpectations:
platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.

12:01 PM Changeset in webkit [133055] by dpranke@chromium.org

3 edits in trunk/Tools

test-webkitpy: fix running modules and classes on the command line
https://bugs.webkit.org/show_bug.cgi?id=100787

Reviewed by Eric Seidel.

Handling modules and classes are arguments on the command line
was broken due to the way we were parsing test names looking for
parallel and serial tests.

Scripts/webkitpy/test/main.py:

(Tester._test_names):
(_Loader):

Scripts/webkitpy/test/main_unittest.py:

(TestStubs.integration_test_empty):
(TestStubs):
(TestStubs.serial_test_empty):
(TestStubs.serial_integration_test_empty):
(TesterTest._find_test_names):
(TesterTest):
(TesterTest.test_individual_names_are_not_run_twice):
(TesterTest.test_integration_tests_are_not_found_by_default):
(TesterTest.test_integration_tests_are_found):

11:51 AM Changeset in webkit [133054] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Change bubble message style to BB10 UX spec.
https://bugs.webkit.org/show_bug.cgi?id=100862

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-10-31
Reviewed by Rob Buis.

RIM PR 198108
Internal Reviewed by Otto Cheung.
No new tests.

css/themeBlackBerry.css:

(::-webkit-validation-bubble-message): Added.
(::-webkit-validation-bubble-arrow): Added.
(::-webkit-validation-bubble-heading): Added.

11:47 AM Changeset in webkit [133053] by mkwst@chromium.org

10 edits in trunk/Source

Prefer document->addConsoleMessage to document->domWindow->console->addMessage.
https://bugs.webkit.org/show_bug.cgi?id=100850

Reviewed by Adam Barth.

For historical reasons, a few places in WebCore talk to Console directly
via 'document()->domWindow()->console()->addMessage(...)'. This is more
safely wrapped by calling 'addConsoleMessage' on the Document itself.

No visible functionality should change; we'll simply avoid potential
null dereferences in the future.

Source/WebCore:

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportLocalLoadFailed):

loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::printAccessDeniedMessage):

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::addMessageToConsole):

11:45 AM Changeset in webkit [133052] by pfeldman@chromium.org

14 edits in trunk/Source/WebCore

Web Inspector: frame chooser does not work on subsequent inspector open.
https://bugs.webkit.org/show_bug.cgi?id=100771

Reviewed by Yury Semikhatsky.

Make WorkerRuntimeAgent and PageRuntimeAgent register themselves in the instrumenting agents independently
Move pause / run worker handling from InspectorRuntimeAgent into WorkerRuntimeAgent
Remove remains of the front-end reused signal from InspectorAgent
Send execution contexts post clear window object instead of post commit load.

inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::clearFrontend):
(WebCore::InspectorAgent::didCommitLoad):

inspector/InspectorAgent.h:

(InspectorAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore):

inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::run):
(WebCore::InspectorRuntimeAgent::setScriptDebugServer):

inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::workerRuntimeAgent):
(WebCore::InstrumentingAgents::setWorkerRuntimeAgent):
(InstrumentingAgents):

inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::setFrontend):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):

inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::run):
(WebCore):
(WebCore::WorkerRuntimeAgent::pauseWorkerContext):

inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

11:32 AM Changeset in webkit [133051] by dpranke@chromium.org

6 edits in trunk/Tools

webkitpy: refactor common command line arguments for --platform, rebaseline commands
https://bugs.webkit.org/show_bug.cgi?id=100800

Reviewed by Ojan Vafai.

This change shuffles around how we share command-line options
between NRWT and the various webkit-patch rebaselining commands.

There are no functional changes in this patch but it should make
things clearer and will be useful in a couple of upcoming patches.

Scripts/webkitpy/layout_tests/port/init.py:
Scripts/webkitpy/layout_tests/port/factory.py:

(platform_options):
(configuration_options):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations.init):
(PrintBaselines.init):

Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.init):
(RebaselineTest.init):
(OptimizeBaselines.init):
(AnalyzeBaselines.init):
(AbstractParallelRebaselineCommand):
(RebaselineJson.init):
(RebaselineExpectations.init):
(Rebaseline.init):

11:28 AM Changeset in webkit [133050] by commit-queue@webkit.org

2 edits in trunk/Tools

[NRWT] Xvfb driver is leaking application cache files
https://bugs.webkit.org/show_bug.cgi?id=100864

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

Application Cache looks for XDG_CACHE_HOME which is now
prepended with DUMPRENDERTREE_TEMP and cleaned up when
the test worker finishes his job.

Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

11:24 AM Changeset in webkit [133049] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt][EFL][AC][WK2]TextureMapperLayer backing store contents are drawn upside down on screen.
https://bugs.webkit.org/show_bug.cgi?id=100845.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-10-31
Reviewed by Noam Rosenthal.

WebGL displays the Canvas with (0,0) being the bottom left corner.
In GraphicsSurface::platformPaintToTextureMapper we don't set ShouldFlipTexture
flag before painting to TextureMapper.
It results in backing store contents being drawn upside down on screen.
This patch enables ShouldFlipTexture flag when TextureMapperLayer renders
it's backing store contents into a TextureMapper.

platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurface::platformPaintToTextureMapper):

11:18 AM Changeset in webkit [133048] by abarth@webkit.org

2 edits in trunk/Websites/webkit.org

technical-articles.html should link to my talk on how WebKit works
https://bugs.webkit.org/show_bug.cgi?id=100867

Reviewed by Tony Chang.

coding/technical-articles.html:

11:06 AM Changeset in webkit [133047] by noam.rosenthal@nokia.com

7 edits in trunk/Source

[Texmap] Enable filter animations in GraphicsLayerAnimation
https://bugs.webkit.org/show_bug.cgi?id=100318

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use the same method of animating filters in WebCore to animate filters for TextureMapper.
Added the appropriate methods to GraphicsLayerAnimation and TextureMapperLayer.

Tested by LayoutTests/css3/filters/filter-animation-hw.html and other tests.

platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore):
(WebCore::blendFunc):
(WebCore::applyFilterAnimation):
(WebCore::GraphicsLayerAnimation::applyInternal):

platform/graphics/GraphicsLayerAnimation.h:

(Client):

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::syncAnimations):

platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):
(WebCore::TextureMapperLayer::setFilters):
(WebCore::TextureMapperLayer::setAnimatedFilters):

Source/WebKit2:

Encode/decode KeyframeValues of type FilterOperations.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

11:02 AM Changeset in webkit [133046] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Avoid storing dirty rects in a Vector inside EwkViewImpl
https://bugs.webkit.org/show_bug.cgi?id=100736

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

No longer store dirty rectangles in a temporary Vector and construct
a WebCore::Region directly from them instead. This avoid having to
iterate over the Vector in EwkViewImpl::displayTimerFired() to construct
a Region object, which should be more efficient.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::displayTimerFired):
(EwkViewImpl::redrawRegion):

UIProcess/API/efl/EwkViewImpl.h:

(WebCore):
(EwkViewImpl):

10:36 AM Changeset in webkit [133045] by andersca@apple.com

33 edits in trunk/Source/WebKit2

Connection::Client::didReceiveInvalidMessage should take the full message name
https://bugs.webkit.org/show_bug.cgi?id=100788

Reviewed by Sam Weinig.

Change Connection::Client::didReceiveInvalidMessage to take the message receiver name and message name as parameters
and make WebProcessProxy::didReceiveInvalidMessage print out the full message name.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):

NetworkProcess/NetworkConnectionToWebProcess.h:

(NetworkConnectionToWebProcess):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didReceiveInvalidMessage):

NetworkProcess/NetworkProcess.h:

(NetworkProcess):

Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchMessage):

Platform/CoreIPC/Connection.h:

(Client):

Platform/CoreIPC/StringReference.cpp:

(CoreIPC::StringReference::toString):
(CoreIPC):

Platform/CoreIPC/StringReference.h:

(StringReference):

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didReceiveInvalidMessage):

PluginProcess/PluginProcess.h:

(PluginProcess):

PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveInvalidMessage):

PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

SharedWorkerProcess/SharedWorkerProcess.cpp:

(WebKit::SharedWorkerProcess::didReceiveInvalidMessage):

SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):

UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didReceiveInvalidMessage):

UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:

(WebKit::SharedWorkerProcessProxy::didReceiveInvalidMessage):

UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:

(SharedWorkerProcessProxy):

UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):

UIProcess/WebConnectionToWebProcess.h:

(WebConnectionToWebProcess):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInvalidMessage):

UIProcess/WebProcessProxy.h:

(WebProcessProxy):

WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveInvalidMessage):

WebProcess/Network/NetworkProcessConnection.h:

(NetworkProcessConnection):

WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveInvalidMessage):

WebProcess/Plugins/PluginProcessConnection.h:

(PluginProcessConnection):

WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::didReceiveInvalidMessage):

WebProcess/WebConnectionToUIProcess.h:

(WebConnectionToUIProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveInvalidMessage):

WebProcess/WebProcess.h:

(WebProcess):

10:33 AM Changeset in webkit [133044] by abarth@webkit.org

9 edits in trunk

[V8] Garbage collection should use opaque roots rather than implicit references
https://bugs.webkit.org/show_bug.cgi?id=100707

Reviewed by Kentaro Hara.

Source/WebCore:

After this patch, we now use object groups rather than implicit
references to inform V8 of these relationships. That has two benefits:

1) We no longer need to know which DOMDataStore a wrapper belongs

because we don't need to find the exact source wrapper for the
implicit connection.

2) We can now handle more complicated implicit relationships, for

example when some of the intervening objects haven't had their
JavaScript wrappers created yet.

This patch also unlocks to paths of future development:
A) Fixing the remaining failures in fast/dom/gc-9.html
B) Enumerating DOM wrappers entirely from V8 rather than from the

DOMWrapperMaps (so that we can move more object towards using
IntrusiveDOMWrapperMaps, which aren't enumerable from WebCore).

bindings/scripts/CodeGeneratorV8.pm:

(NeedsCustomOpaqueRootForGC):
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GenerateImplementation):

bindings/v8/V8GCController.cpp:

bindings/v8/V8GCController.h:

(WebCore):
(V8GCController):

bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::opaqueRootForGC):
(WrapperTypeInfo):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp:

(WebCore::V8SpeechRecognitionResult::opaqueRootForGC):

LayoutTests:

Test progression.

platform/chromium/fast/dom/gc-9-expected.txt:

10:21 AM Changeset in webkit [133043] by jsbell@chromium.org

1 edit in branches/chromium/1312/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp

Merge 132848 - IndexedDB: Crash on checking version of corrupt backing store
https://bugs.webkit.org/show_bug.cgi?id=100692

Reviewed by Tony Chang.

If the backing store fails to open (due to corruption, non-writeable disk, etc)
the subsequent schema version check dereferences a null pointer. Fix to only
do the schema check if the database opened.

Chromium tests will be included with crrev.com/11196029

Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

TBR=jsbell@chromium.org
Review URL: https://codereview.chromium.org/11358013

10:07 AM Changeset in webkit [133042] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[chromium] Added skipped expectations for new test
svg-remote-element.html with no results.

Unreviewed.

platform/chromium/TestExpectations:

9:48 AM Changeset in webkit [133041] by commit-queue@webkit.org

8 edits
4 adds in trunk/Source

[EFL][WK2][AC] Use smart pointers for Evas_GL types
https://bugs.webkit.org/show_bug.cgi?id=100745

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Replace raw pointers to Evas_GL, Evas_GL_Context and
Evas_GL_Surface by smart pointers in EwkViewImpl.

C++ wrappers were added for Evas_GL_Context and
Evas_GL_Surface in order to use OwnPtr. This is needed
because their destroy functions need the Evas_GL.

PlatformEfl.cmake:
UIProcess/API/efl/EvasGLContext.cpp: Added.

(WebKit):
(WebKit::EvasGLContext::EvasGLContext):
(WebKit::EvasGLContext::~EvasGLContext):

UIProcess/API/efl/EvasGLContext.h: Added.

(WebKit):
(EvasGLContext):
(WebKit::EvasGLContext::create):
(WebKit::EvasGLContext::context):

UIProcess/API/efl/EvasGLSurface.cpp: Added.

(WebKit):
(WebKit::EvasGLSurface::EvasGLSurface):
(WebKit::EvasGLSurface::~EvasGLSurface):

UIProcess/API/efl/EvasGLSurface.h: Added.

(WebKit):
(EvasGLSurface):
(WebKit::EvasGLSurface::create):
(WebKit::EvasGLSurface::surface):

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):

UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl::evasGL):
(EwkViewImpl::evasGLContext):
(EwkViewImpl::evasGLSurface):
(EwkViewImpl::resetEvasGLSurface):
(EwkViewImpl):

UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

Source/WTF:

Make OwnPtr usable with Evas_GL type to avoid handling
raw pointers in EFL port.

wtf/OwnPtrCommon.h:

(WTF):

wtf/efl/OwnPtrEfl.cpp:

(WTF):
(WTF::deleteOwnedPtr):

9:46 AM Changeset in webkit [133040] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Add total node to native memory snapshot tree
https://bugs.webkit.org/show_bug.cgi?id=100843

Patch by Alexei Filippov <alph@chromium.org> on 2012-10-31
Reviewed by Yury Semikhatsky.

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotDataGrid):
(WebInspector.NativeSnapshotNode):
(WebInspector.MemoryBlockViewProperties._initialize):

9:45 AM Changeset in webkit [133039] by kbalazs@webkit.org

3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix "Unable to find a renderable master window QQuickView" warnings in tst_QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=100247

Reviewed by Jocelyn Turcotte.

Make sure we have a visible window for tests that want to render.

UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::removeFromCanvas):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::basicRenderingSanity):
(tst_QQuickWebView::transparentWebViews):
Removed some unnecessary resize now that the window have a default size.

UIProcess/API/qt/tests/testwindow.h:

(TestWindow): Resize the window to a default size at construction.

9:42 AM Changeset in webkit [133038] by senorblanco@chromium.org

1 edit
1 add
2 deletes in trunk/LayoutTests

[chromium] New baselines for
fast/images/exif-orientation-css-expected.png. Unreviewed.

platform/chromium-linux-x86/fast/images/exif-orientation-css-expected.png: Removed.
platform/chromium-win/fast/images/exif-orientation-css-expected.png: Added.
platform/chromium/fast/images/exif-orientation-css-expected.png: Removed.

9:32 AM Changeset in webkit [133037] by commit-queue@webkit.org

10 edits
2 adds in trunk

Table with percentage column widths doesn't scale to fill the entire width of a table containing it
https://bugs.webkit.org/show_bug.cgi?id=11645

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-31
Reviewed by Julien Chaffraix.

Source/WebCore:

When the inner (or nested) table has auto width and column(s) with
percent width, we should scale our column(s) to the width of the
containing table (unless it has auto width).

Test: fast/table/scale-nested-percent-width-cols.html

rendering/AutoTableLayout.cpp:

(WebCore::shouldScaleColumns):
If the containing table width was of percent type, we were disallowing
our inner or nested table's column from scaling to the size of the parent
table. We should prohibit the scaling of the nested table columns only
if the parent table has auto width.

LayoutTests:

fast/table/scale-nested-percent-width-cols-expected.html: Added.
fast/table/scale-nested-percent-width-cols.html: Added.

Added a ref test verifying that our nested (auto width) table's columns
are scaled and sized appropriately if the containing table has
percent width.

platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:

Added an entry for fast/table/025.html for these ports. It would need
rebaselining as a result of this fix.

platform/qt/fast/table/025-expected.png:
platform/qt/fast/table/025-expected.txt:

Modified expected results for the existing test on qt port.

In the given test, our innermost nested table has auto width and consits
of three table cells with percent width specified for the first and the
third cells. Its containing table on the other hand is a percent width
table.

Previously, we were not scaling our inner table's column(s) from expanding
to the width of the containing table if it had percent width type. Because
of this our first and last table cells in the innermost table were being
rendered only with the minimum width (4px).

Post this fix, since now our inner table columns shall scale, the first and
the last table cell would thus expand in width (41px each) and hence the
change in the column and the table dimensions.

8:53 AM Changeset in webkit [133036] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] DRT doesn't clean up after itself
https://bugs.webkit.org/show_bug.cgi?id=100346

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

The test driver exports an environment variable DUMPRENDERTREE_TEMP
which is used by both DRT and WTR as the folder for storing icons,
databases, application cache, etc, overriding the default XDG_* path.

We don't need to create these folders because in fact, they are never
used and also never cleaned. Things created inside DUMPRENDERTREE_TEMP
are automatically removed after the test run.

Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.setup_environ_for_server):

8:53 AM Changeset in webkit [133035] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[EFL] WebContext::platformDefaultIconDatabasePath() should return a path to a file
https://bugs.webkit.org/show_bug.cgi?id=100679

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

This patch aligns the EFL implementation with other ports. Before
that, we had an inconsistence: the return value of the getter could
not be used on the setter (the setter expects a full path, not a
directory).

UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::faviconDatabase):

UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

8:43 AM Changeset in webkit [133034] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] More unreviewed pixel expectations gardening.

Accept Missing as a valid result for some ietestcenter tests, and
skip another one of them.

platform/efl/TestExpectations:

8:36 AM Changeset in webkit [133033] by vollick@chromium.org

20 edits
2 adds
15 deletes in trunk

Add support for text-based repaint testing
https://bugs.webkit.org/show_bug.cgi?id=100584

Reviewed by Simon Fraser.

Allows tracked repaint rects to be dumped as text.

Source/autotools/symbols.filter: Exports for:

FrameView::setTracksRepaints(bool)
Frame::trackedRepaintRectsAsText() const

Source/WebCore:

The following layout tests have been converted:

fast/repaint/layer-full-repaint.html
fast/repaint/overflow-flipped-writing-mode-table.html

WebCore.exp.in: Exports for:

FrameView::setTracksRepaints(bool)
Frame::trackedRepaintRectsAsText() const

page/Frame.cpp:

(WebCore::Frame::trackedRepaintRectsAsText):

Returns a string containing information on all tracked repaint rects.

page/FrameView.cpp:

(WebCore::FrameView::setTracksRepaints):

Rather than calling m_trackedRepaintRects.clear() directly, I've
called resetTrackedRepaints(). This will allow us to do more
sophisticated resetting when we start tracking repaint rects for
composited layers.

(WebCore::FrameView::trackedRepaintRectsAsText):

Provides the string returned by Frame::trackedRepaintRectsAsText.

testing/Internals.cpp:

(WebCore::Internals::repaintRectsAsText):

Returns Frame::trackedRepaintRectsAsText.

(WebCore):
(WebCore::Internals::startTrackingRepaints):

Calls FrameView::setTracksRepaints(true)

(WebCore::Internals::stopTrackingRepaints):

Calls FrameView::setTracksRepaints(false)

testing/Internals.h:
testing/Internals.idl: Declarations for:

repaintRectsAsText
startTrackingRepaints
stopTrackingRepaints

Source/WebKit2:

mac/WebKit2.order:
win/WebKit2.def:
win/WebKit2CFLite.def: Exports for:

FrameView::setTracksRepaints(bool)
Frame::trackedRepaintRectsAsText() const

LayoutTests:

fast/repaint/layer-full-repaint-expected.txt: Added.
fast/repaint/layer-full-repaint.html:
fast/repaint/overflow-flipped-writing-mode-table-expected.png: Removed.
fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
fast/repaint/overflow-flipped-writing-mode-table.html:
fast/repaint/resources/repaint.js:
fast/repaint/resources/text-based-repaint.js: Added.

(runRepaintTest):

The function calls internals.startTrackingRepaints() rather than display()
before calling repaintTest(). It also generates a <pre> element and sets
its innerHTML to internals.repaintRectsAsText().

platform/chromium-mac/fast/repaint/layer-full-repaint-expected.png: Removed.
platform/chromium-mac/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Removed.
platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Removed.
platform/chromium/fast/repaint/layer-full-repaint-expected.png: Removed.
platform/chromium/fast/repaint/layer-full-repaint-expected.txt: Removed.
platform/efl/fast/repaint/layer-full-repaint-expected.png: Removed.
platform/efl/fast/repaint/layer-full-repaint-expected.txt: Removed.
platform/gtk/fast/repaint/layer-full-repaint-expected.png: Removed.
platform/gtk/fast/repaint/layer-full-repaint-expected.txt: Removed.
platform/gtk/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Removed.
platform/mac/fast/repaint/layer-full-repaint-expected.png: Removed.
platform/mac/fast/repaint/layer-full-repaint-expected.txt: Removed.
platform/qt/fast/repaint/layer-full-repaint-expected.png: Removed.
platform/qt/fast/repaint/layer-full-repaint-expected.txt: Removed.

8:27 AM Changeset in webkit [133032] by senorblanco@chromium.org

1 edit
2 adds in trunk/LayoutTests

New Chromium baselines for css3/filters/composited-reflected.html.

Unreviewed.

platform/chromium-mac/css3/filters/composited-reflected-expected.png: Added.
platform/chromium-win/css3/filters/composited-reflected-expected.png: Added.

8:22 AM Changeset in webkit [133031] by mkwst@chromium.org

4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining tests after r133019.

platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

8:12 AM Changeset in webkit [133030] by yurys@chromium.org

10 edits
4 adds in trunk

Web Inspector: page crash when pausing in dedicated worker
https://bugs.webkit.org/show_bug.cgi?id=100837

Reviewed by Pavel Feldman.

Source/WebCore:

Pass debugger agent to InjectedScriptHost::init in case of workers.

Test: inspector-protocol/debugger-pause-dedicated-worker.html

inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

LayoutTests:

Test that Debugger.pause works for dedicated workers. The test is skipped
on all platforms that use JSC as worker debugging is not supported there
yet.

http/tests/inspector-protocol/resources/InspectorTest.js:

(WebInspector.dispatchMessageFromBackend):

inspector-protocol/debugger-pause-dedicated-worker-expected.txt: Added.
inspector-protocol/debugger-pause-dedicated-worker.html: Added.
inspector-protocol/resources/dedicated-worker.js: Added.

(onmessage):
(doWork):

platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

8:01 AM Changeset in webkit [133029] by commit-queue@webkit.org

5 edits in trunk

perspective-origin should ignore values with more then two lengths and use the default values
https://bugs.webkit.org/show_bug.cgi?id=100835

Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Perspective-origin should ignore values with more then two lengths
(http://www.w3.org/TR/css3-transforms/#perspective-origin) and use
the default values instead of parsing it as an unlimited-length list,
of which all but the first two values are ignored. This makes perspective-origin
behave similar to transform-origin which uses default value in this case,
as well as firefox does the same.

Test: transforms/2d/computed-style-origin.html

css/CSSParser.cpp:

(WebCore::CSSParser::parsePerspectiveOrigin):

LayoutTests:

Add test for perspective-origin with more the than two lengths.

transforms/2d/computed-style-origin-expected.txt:
transforms/2d/computed-style-origin.html:

7:59 AM Changeset in webkit [133028] by podivilov@chromium.org

15 edits
3 deletes in trunk/Source

Unreviewed, rolling out r133016.
http://trac.webkit.org/changeset/133016
https://bugs.webkit.org/show_bug.cgi?id=100856

broke compile-webkit on several bots (Requested by podivilov
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-31

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/DeviceOrientationClient.h:

(DeviceOrientationClient):

dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore):
(WebCore::DeviceOrientationController::~DeviceOrientationController):
(WebCore::DeviceOrientationController::timerFired):
(WebCore::DeviceOrientationController::addListener):
(WebCore::DeviceOrientationController::removeListener):
(WebCore::DeviceOrientationController::removeAllListeners):
(WebCore::DeviceOrientationController::suspendEventsForAllListeners):
(WebCore::DeviceOrientationController::resumeEventsForAllListeners):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::DeviceOrientationController::supplementName):

dom/DeviceOrientationController.h:

(WebCore):
(DeviceOrientationController):
(WebCore::DeviceOrientationController::isActive):
(WebCore::DeviceOrientationController::client):
(WebCore::DeviceOrientationController::from):

dom/Document.cpp:

(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):

loader/EmptyClients.h:

(WebCore::EmptyDeviceOrientationClient::startUpdating):
(WebCore::EmptyDeviceOrientationClient::stopUpdating):

page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

page/DeviceClient.h: Removed.
page/DeviceController.cpp: Removed.
page/DeviceController.h: Removed.

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockDeviceOrientation):

7:22 AM Changeset in webkit [133027] by rakuco@webkit.org

2 edits
2 deletes in trunk/LayoutTests

[EFL] Unreviewed pixel expectations gardening.

Skip a few ietestcenter/css3/text texts which are rendering
incorrectly, and accept Missing as a valid result for some culling
tests.

platform/efl/TestExpectations:
platform/efl/ietestcenter/css3/text/textshadow-005-expected.png: Removed.
platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Removed.

7:13 AM Changeset in webkit [133026] by dominik.rottsches@intel.com

3 edits in trunk/LayoutTests

[EFL][GTK] Unreviewed gardening.

Removing duplicate in EFL file, changing bug number for exif orientation bug in GTK.

platform/efl/TestExpectations:
platform/gtk/TestExpectations:

7:01 AM Changeset in webkit [133025] by dominik.rottsches@intel.com

4 edits in trunk/LayoutTests

[EFL][GTK] Unreviewed gardening.

Exif orientation test marked as failing for GTK & EFL,
On EFL, the vibration IPC issue may cause crash, see bug 100334.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:

7:01 AM Changeset in webkit [133024] by commit-queue@webkit.org

2 edits in trunk/Tools

[WTR] WebKitTestRunner is not cleaning up the icon database
https://bugs.webkit.org/show_bug.cgi?id=100678

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

The icon database was not being set to the temporary folder created for
the test runner by the test driver, which is removed automatically
after the run.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

6:59 AM Changeset in webkit [133023] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] More unreviewed gardening.

Skip the EXIF-related tests since the feature is not implemented
for the port anyway, and skip the recently-added
fast/images/exif-orientation-image-document.html as well.

platform/efl/TestExpectations:

6:58 AM Changeset in webkit [133022] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Skip http/tests/appcache/load-from-appcache-defer-resume-crash.html on WK2.

Just marking it as Failure does not prevent a useless PNG expectation to be generated when running pixel tests.

platform/efl-wk2/TestExpectations:

6:55 AM Changeset in webkit [133021] by Antti Koivisto

3 edits in trunk/Source/WebCore

Remove stray calls to mutableAttributeData()
https://bugs.webkit.org/show_bug.cgi?id=100849

Reviewed by Andreas Kling.

Changing the cached class attribute value does not require mutable attribute data.

dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::clearClass):

Make const like setClass().

6:49 AM Changeset in webkit [133020] by rakuco@webkit.org

2 edits
6 adds in trunk/LayoutTests

[EFL] Unreviewed, add a few more pixel expectations.

platform/efl/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
platform/efl/css3/flexbox/repaint-rtl-column-expected.png:
platform/efl/fast/forms/indeterminate-expected.png: Added.
platform/efl/media/video-aspect-ratio-expected.png: Added.
platform/efl/media/video-layer-crash-expected.png: Added.
platform/efl/media/video-transformed-expected.png: Added.
platform/efl/media/video-zoom-expected.png: Added.

6:33 AM Changeset in webkit [133019] by mkwst@chromium.org

11 edits in trunk

X-Frame-Options console message should be associated with a request.
https://bugs.webkit.org/show_bug.cgi?id=100735

Reviewed by Pavel Feldman.

Source/WebCore:

In 99941, we added the possibility to tie console messages to requests,
which enables automatic generation of stack traces, line numbers, etc.
making the error simpler to diagnose for web developers. This patch
uses the piping laid in that patch to improve the console message
generated when a document is blocked by X-Frame-Options.

No new tests; the functionality is covered by changes to existing tests.

dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Grab the request identifier from the currently active DocumentLoader
and pass it into the console message.

loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

Grab the request identifier from the MainResourceLoader, and pass it
into the console message.

LayoutTests:

http/tests/inspector/network/x-frame-options-deny-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
http/tests/security/xssAuditor/meta-tag-http-refresh-x-frame-options-expected.txt:

Update tests with new console message.

6:25 AM Changeset in webkit [133018] by commit-queue@webkit.org

13 edits in trunk/Source/WebCore

Unreviewed, rolling out r133015.
http://trac.webkit.org/changeset/133015
https://bugs.webkit.org/show_bug.cgi?id=100847

broke Apple Win Debug compilation (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-31

inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::clearFrontend):
(WebCore::InspectorAgent::didCommitLoad):

inspector/InspectorAgent.h:

(WebCore::InspectorAgent::didCommitLoadFired):
(InspectorAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore):

inspector/InspectorRuntimeAgent.cpp:

inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorRuntimeAgent):
(WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
(InstrumentingAgents):

inspector/PageRuntimeAgent.cpp:

inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):

inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

6:00 AM Changeset in webkit [133017] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] Skip EWK2UnitTestBase.ewk_context_vibration_client_callbacks_set API test
https://bugs.webkit.org/show_bug.cgi?id=100839

Unreviewed, Skip EWK2UnitTestBase.ewk_context_vibration_client_callbacks_set
API test since it is failing on the bots.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-31

UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

5:55 AM Changeset in webkit [133016] by kihong.kwon@samsung.com

15 edits
3 adds in trunk/Source

Add DeviceController base-class to remove duplication of DeviceXXXControler
https://bugs.webkit.org/show_bug.cgi?id=96894

Reviewed by Hajime Morita.

Source/WebCore:

Add DeviceController which is extracted from DeviceOrientationController to remove duplication.
And soon-to-be-added DeviceMotionController and ProximityController.

Covered by existing tests.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/DeviceOrientationClient.h:
dom/DeviceOrientationController.cpp:

Remove member functions to move to DeviceController.

addListener(), removeListener(), removeAllListeners(), isActive()

(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::DeviceOrientationController::client):
(WebCore::DeviceOrientationController::hasLastData):
(WebCore::DeviceOrientationController::getLastEvent):
(WebCore::DeviceOrientationController::from):
(WebCore):

dom/DeviceOrientationController.h:

(WebCore):
(WebCore::DeviceOrientationController::~DeviceOrientationController):
(DeviceOrientationController):

dom/Document.cpp:

Remove suspendEventsForAllListeners() and resumeEventsForAllListeners() function calls.
These calls can be made by checking activeDOMObjectsAreSuspended() and activeDOMObjectsAreStopped() before dispatchEvent.
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):

loader/EmptyClients.h:

(EmptyDeviceClient):
(WebCore::EmptyDeviceClient::startUpdating):
(WebCore::EmptyDeviceClient::stopUpdating):
(WebCore):

page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

page/DeviceClient.h: Added.

(WebCore):
(DeviceClient):
(WebCore::DeviceClient::~DeviceClient):

page/DeviceController.cpp: Added.

DeviceController has extracted functions from DeviceOrientationController and DeviceMotionController.

addDeviceEventListener(), removeDeviceEventlistener(), removeAllDeviceEventListeners(), dispatchDeviceEvent()

All kind of device event controller which has DeviceClient can be inherited from DeviceController.
(WebCore):
(WebCore::DeviceController::DeviceController):
(WebCore::DeviceController::addDeviceEventListener):
(WebCore::DeviceController::removeDeviceEventListener):
(WebCore::DeviceController::removeAllDeviceEventListeners):
(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):

page/DeviceController.h: Added.

(WebCore):
(DeviceController):
(WebCore::DeviceController::~DeviceController):
(WebCore::DeviceController::isActive):
(WebCore::DeviceController::client):
(WebCore::DeviceController::hasLastData):
(WebCore::DeviceController::getLastEvent):

Source/WebKit/qt:

Change client() to deviceOrientationClient() to get DeviceOrientationClient*.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockDeviceOrientation):

5:41 AM Changeset in webkit [133015] by pfeldman@chromium.org

13 edits in trunk/Source/WebCore

Web Inspector: frame chooser does not work on subsequent inspector open.
https://bugs.webkit.org/show_bug.cgi?id=100771

Reviewed by Yury Semikhatsky.

Make WorkerRuntimeAgent and PageRuntimeAgent register themselves in the instrumenting agents independently
Move pause / run worker handling from InspectorRuntimeAgent into WorkerRuntimeAgent
Remove remains of the front-end reused signal from InspectorAgent
Send execution contexts post clear window object instead of post commit load.

inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::clearFrontend):
(WebCore::InspectorAgent::didCommitLoad):

inspector/InspectorAgent.h:

(InspectorAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore):

inspector/InspectorRuntimeAgent.cpp:

inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::workerRuntimeAgent):
(WebCore::InstrumentingAgents::setWorkerRuntimeAgent):
(InstrumentingAgents):

inspector/PageRuntimeAgent.cpp:

inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

inspector/WorkerRuntimeAgent.cpp:

inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

5:19 AM Changeset in webkit [133014] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2][EFL] Assert check need to be changed in InputMethodContextEfl::InputMethodContextEfl
https://bugs.webkit.org/show_bug.cgi?id=100840

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-31
Reviewed by Kenneth Rohde Christiansen.

Because 'context' is already set to 'm_context', assert check need to be done for m_context.

UIProcess/efl/InputMethodContextEfl.cpp:

(WebKit::InputMethodContextEfl::InputMethodContextEfl):

4:52 AM Changeset in webkit [133013] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unreviewed, unskip media/video-seek-past-end-playing.html on WK2.

It has been passing on the WK2 bot for quite a while, so unskip
and hope for the best.

platform/efl-wk2/TestExpectations:

4:41 AM Changeset in webkit [133012] by kenneth@webkit.org

10 edits in trunk/Source/WebKit2

[WK2/EFL] Make sure all our events are transformed correctly
https://bugs.webkit.org/show_bug.cgi?id=100836

Reviewed by Alexis Menard.

When moving to using the tiled backing store, we need to
transform our events before sending them to the web process.

We needed to do that before as well, as the webkit view
doesn't have to be positioned at (0,0), but it was done in
a hacking way in the WebEvent creating.

Now we generate two transforms, one for transforming points
to the web content, and one for transforming them into the
device screen coordinate system.

This fixes the global position which was wrong before.

Shared/NativeWebMouseEvent.h:

(NativeWebMouseEvent):

Shared/NativeWebTouchEvent.h:

(NativeWebTouchEvent):

Shared/NativeWebWheelEvent.h:

(NativeWebWheelEvent):

Shared/efl/NativeWebMouseEventEfl.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):

Shared/efl/NativeWebTouchEventEfl.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

Shared/efl/NativeWebWheelEventEfl.cpp:

(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):

Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

Shared/efl/WebEventFactory.h:

(WebEventFactory):

UIProcess/API/efl/ewk_view.cpp:

(toDeviceScreenTransform):
(toWebContentTransform):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(ewk_view_feed_touch_event):

4:38 AM Changeset in webkit [133011] by keishi@webkit.org

8 edits in trunk

Calendar picker can flicker when opened from the suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=100816

Reviewed by Kent Tamura.

Source/WebCore:

Calendar picker was opening before the hiding completed.

No new tests. Added test to date-suggestion-picker-key-operations.html.

Resources/pagepopups/pickerCommon.js: Added didHide event.
Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype.selectEntry): Use didHide event so we don't open the calendar picker prematurely.
(SuggestionPicker._handleWindowDidHide): When the window finished hiding, open the calendar picker.

LayoutTests:

fast/forms/resources/picker-common.js:

(openPicker): Fix mistake.

platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html: Test that didHide event fires after the entry was selected and before the calendar picker opened.

4:33 AM Changeset in webkit [133010] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unreviewed, unskip fast/forms/select-multiple-elements-with-mouse-drag.html.
https://bugs.webkit.org/show_bug.cgi?id=100248

The test is consistently passing again, and "fixing" the EFL side
is not trivial.

platform/efl-wk2/TestExpectations:

4:26 AM Changeset in webkit [133009] by tkent@chromium.org

2 edits in trunk/Source/WebKit/chromium

Remove code to hide/reshow text caret for PagePopups
https://bugs.webkit.org/show_bug.cgi?id=100834

Reviewed by Hajime Morita.

All of form controls supporting PagePopups don't have a text
caret. We don't need to hide a text caret on opening a PagePopup,
and don't need to reshow it on closing the PagePopup.

We had this code because an old UI of input[type=date] had a text
caret.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::openPagePopup):
(WebKit::WebViewImpl::closePagePopup):

4:03 AM Changeset in webkit [133008] by mkwst@chromium.org

1 edit in branches/chromium/1312/Source/WebKit/chromium/features.gypi

[Chromium] Unreviewed. Toggling ENABLE_CSP_NEXT flag off for M24.

BUG=158727

3:59 AM Changeset in webkit [133007] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

Reset binding test result after r132973
https://bugs.webkit.org/show_bug.cgi?id=99178

Unreviewed gardening.

bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::getJSFloat64ArrayConstructorTable):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):

2:59 AM Changeset in webkit [133006] by mkwst@chromium.org

19 edits
2 adds in trunk

Script run from an isolated world should bypass a page's CSP.
https://bugs.webkit.org/show_bug.cgi?id=97398

Reviewed by Adam Barth.

Source/WebCore:

A page's Content Security Policy currently applies to all resources
loaded, regardless of their source. That generally makes sense, but
proves problematic when considering script run from an isolated
world (Chrome extensions, for instance). These scripts should be allowed
to inject resources into a page's DOM without eiher being restricted by
the page's active CSP, or generating violation reports that spam the
page owner.

Ideally, the isolated world could define its own Content Security Policy
which should be applied to resources it loads. For the moment, this
patch accepts a String that we can parse later on, but only uses it in
a binary way. If a non-empty policy String is provided, we bypass the
main world's CSP checks. If an empty String is provided, the main
world's CSP checks remain active.

Test: http/tests/security/isolatedWorld/bypass-main-world-csp.html

(WebCore::isolatedWorldContentSecurityPolicies):
(WebCore::DOMWrapperWorld::isolatedWorldHasContentSecurityPolicy):
(WebCore::DOMWrapperWorld::setIsolatedWorldContentSecurityPolicy):
(WebCore::DOMWrapperWorld::clearIsolatedWorldContentSecurityPolicy):

bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):

Mechanisms for setting and clearing Content Security Policies from
isolated worlds; implemented in the same HashMappy way as
SecurityOrigin.

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore):

bindings/v8/ScriptController.h:

(ScriptController):

Adding a method to ScriptController to query the state of the
current world's Content Security Policy. We'll drop this once we can
apply a policy more directly, but for the moment it's necessary for
the next bit.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

Check the new ScriptController method, and only perform CSP checks
when loading resources if we're executing code from the main world,
or an isolated world with no Content Security Policy set.

Source/WebKit/chromium:

public/WebFrame.h:

(WebFrame):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
(WebKit):
(WebKit::WebFrameImpl::setIsolatedWorldContentSecurityPolicy):

src/WebFrameImpl.h:

(WebFrameImpl):

Piping a Content Security Policy through WebFrame, in the same way
we're currently doing for SecurityOrigin. As a drive-by, this also
uses the static method on DOMWrapperWindow to set the security
origin, rather than routing through the frame's ScriptController.

Tools:

DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setIsolatedWorldContentSecurityPolicy):

DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

Adding a mechanism to set the Content Security Policy for an
isolated world to Chromium's testRunner.

LayoutTests:

http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt: Added.
http/tests/security/isolatedWorld/bypass-main-world-csp.html: Added.
platform/efl/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:

Skip the new tests on ports that don't support the new functionality

2:48 AM Changeset in webkit [133005] by podivilov@chromium.org

3 edits
1 move
1 add in trunk/LayoutTests

[chromium] Rebaseline media/video-zoom.html.

platform/chromium-linux/media/video-zoom-expected.png:
platform/chromium-mac-lion/media/video-zoom-expected.png: Added.
platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
platform/efl-wk1/media/video-zoom-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-expected.png.

2:44 AM Changeset in webkit [133004] by podivilov@chromium.org

13 edits
6 moves
9 adds in trunk/LayoutTests

[chromium] Rebaseline 7 media/video-* tests on Linux and Mac.

platform/chromium-linux/media/video-aspect-ratio-expected.png:
platform/chromium-linux/media/video-colorspace-yuv420-expected.png:
platform/chromium-linux/media/video-colorspace-yuv422-expected.png:
platform/chromium-linux/media/video-layer-crash-expected.png:
platform/chromium-linux/media/video-transformed-expected.png:
platform/chromium-linux/media/video-zoom-controls-expected.png:
platform/chromium-linux/platform/chromium/media/video-frame-size-change-expected.png:
platform/chromium-mac-lion/media/video-aspect-ratio-expected.png: Added.
platform/chromium-mac-lion/media/video-colorspace-yuv420-expected.png: Added.
platform/chromium-mac-lion/media/video-colorspace-yuv422-expected.png: Added.
platform/chromium-mac-lion/media/video-layer-crash-expected.png: Added.
platform/chromium-mac-lion/media/video-transformed-expected.png: Added.
platform/chromium-mac-lion/media/video-zoom-controls-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/media/video-frame-size-change-expected.png: Added.
platform/chromium-mac-snowleopard/media/video-aspect-ratio-expected.png:
platform/chromium-mac-snowleopard/media/video-colorspace-yuv420-expected.png:
platform/chromium-mac-snowleopard/media/video-colorspace-yuv422-expected.png:
platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png:
platform/chromium-mac-snowleopard/media/video-transformed-expected.png:
platform/efl-wk1/media/video-aspect-ratio-expected.png: Renamed from LayoutTests/platform/efl/media/video-aspect-ratio-expected.png.
platform/efl-wk1/media/video-colorspace-yuv420-expected.png: Renamed from LayoutTests/platform/efl/media/video-colorspace-yuv420-expected.png.
platform/efl-wk1/media/video-colorspace-yuv422-expected.png: Renamed from LayoutTests/platform/efl/media/video-colorspace-yuv422-expected.png.
platform/efl-wk1/media/video-layer-crash-expected.png: Renamed from LayoutTests/platform/efl/media/video-layer-crash-expected.png.
platform/efl-wk1/media/video-transformed-expected.png: Renamed from LayoutTests/platform/efl/media/video-transformed-expected.png.
platform/efl-wk1/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-controls-expected.png.

2:33 AM Changeset in webkit [133003] by podivilov@chromium.org

2 edits
1 move
2 adds in trunk/LayoutTests

[chromium] Add new baselines for fast/forms/basic-inputs.html and fast/forms/indeterminate.html on linux.

platform/chromium-linux/fast/forms/indeterminate-expected.png:
platform/efl-wk1/fast/forms/indeterminate-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/indeterminate-expected.png.

2:28 AM Changeset in webkit [133002] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2012-10-31 Pavel Podivilov <podivilov@google.com>

[chromium] Unreviewed, mark two touchadjustment tests as failing on mac.

platform/chromium/TestExpectations:

2:10 AM Changeset in webkit [133001] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Change the scope of locking in CoreIPC::Connection class.
https://bugs.webkit.org/show_bug.cgi?id=98998

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-31
Reviewed by Laszlo Gombos.

Release the m_incomingMessagesLock and m_outgoingMessagesLock mutexes
immediately after the protected resource is no longer modified to
prevent a possible source of a deadlock.

The change allows the EFL port to prevent an actual dead-lock
situation with some upcoming changes.

Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::enqueueIncomingMessage):

1:58 AM Changeset in webkit [133000] by commit-queue@webkit.org

13 edits
4 adds in trunk

[EFL][DRT] EventSender requires contextClick implementation
https://bugs.webkit.org/show_bug.cgi?id=86091

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-10-31
Reviewed by Gyuyoung Kim.

Source/WebKit:

Add new unit test file, needed due to ewk API changes.

PlatformEfl.cmake:

Source/WebKit/efl:

Add a pointer to parent menu in Ewk_Context_Menu_Item and a getter
function to allow selecting a context menu item without having
parent menu pointer in DumpRenderTree EventSender.
Three unit tests added due ewk API changes.

ewk/ewk_contextmenu.cpp:

(_Ewk_Context_Menu_Item):
(ewk_context_menu_item_new):
(ewk_context_menu_item_parent_get):
(ewk_context_menu_item_append):

ewk/ewk_contextmenu.h:
ewk/ewk_view.cpp:

(ewk_view_context_menu_get):

ewk/ewk_view.h:
tests/test_ewk_contextmenu.cpp: Added.

(TEST_F):

tests/test_ewk_view.cpp:

(TEST_F):

Tools:

Add contextClick for DumpRenderTreeEventSender basing on WebKit GTK
implementation.

DumpRenderTree/efl/EventSender.cpp:

(getMenuItemTitleCallback):
(setMenuItemTitleCallback):
(menuItemClickCallback):
(contextClickCallback):

LayoutTests:

Move contextClick dependent tests to WebKit2 TestExpectations and
add new expected results.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:
platform/efl/editing/selection/5354455-2-expected.txt: Added.
platform/efl/fast/events/context-no-deselect-expected.txt: Added.
platform/efl/fast/events/context-onmousedown-event-expected.png: Added.

1:41 AM Changeset in webkit [132999] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, attempt to fix the release build by not exporting symbols that aren't defined there.

WebCore.exp.in:

1:36 AM Changeset in webkit [132998] by yurys@chromium.org

7 edits in trunk/Source/WebCore

Memory instrumentation: do not report memory occupied by objects referenced using client interfaces
https://bugs.webkit.org/show_bug.cgi?id=100824

Reviewed by Alexander Pavlov.

In many classes we have pointer to a client object. These references should be
reported as weak pointers and the client's memory usage should be reported when
the client is reached from its instrumented owner where we know exact type of
the client. Otherwise we would need to add reportMemoryUsage to all client
interfaces which places additional burden on the client implementers and blurs
the instrumentation boundaries.

inspector/InspectorController.cpp:

(WebCore::InspectorController::reportMemoryUsage):

inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::reportMemoryUsage):

inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::reportMemoryUsage):

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::reportMemoryUsage):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::reportMemoryUsage):

page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

1:18 AM Changeset in webkit [132997] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, attempt to fix the build by exporting NoExceptionAssertionChecker symbols.

WebCore.exp.in:

1:15 AM Changeset in webkit [132996] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Unreviewed, fix header sorting in r132992.

WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

1:14 AM Changeset in webkit [132995] by eric@webkit.org

11 edits in trunk/Source/WebCore

Add non-virtual firstChild/lastChild overrides to RenderBlock and RenderTableCol for a > 30% speedup on table from bug 100304
https://bugs.webkit.org/show_bug.cgi?id=100306

Reviewed by Abhishek Arya.

Presumably this is a speedup for other rendering tests as well. We use firstChild() all over
the rendering code w/o considering that it makes a virtual function call.
Originally I just fixed the one callsite which was showing up on the sample to
use children()->firstChild() directly. However after further thought, this
broader solution seemed the better way to go. The first patch was a 15% win for
this large table, this broader solution was a 30%!? win.

The elephant in the room for this table is that we're walking the whole table
for many nextColumn calls. But that I will solve in a later bug.

rendering/RenderBlock.h:

(WebCore::RenderBlock::firstChild):
(WebCore::RenderBlock::lastChild):
(RenderBlock):

rendering/RenderObject.h:

(RenderObject):

rendering/RenderTableCol.h:

(WebCore::RenderTableCol::firstChild):
(WebCore::RenderTableCol::lastChild):
(RenderTableCol):

1:07 AM Changeset in webkit [132994] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed, fix 32bit build breakage.

WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::updateGeometry):

12:54 AM Changeset in webkit [132993] by Philippe Normand

2 edits in trunk/Source/WebCore

Spatialized panning renders incorrectly with USE_CONCATENATED_IMPULSE_RESPONSES
https://bugs.webkit.org/show_bug.cgi?id=98294

Reviewed by Chris Rogers.

Regenerated the concatenated impulse responses file with
elevations in increasing order per azimuth. In the previous
version of this file the elevations for 315, 330 and 345 were
concatenated at the wrong indexes.

platform/audio/resources/Composite.wav:

12:53 AM Changeset in webkit [132992] by timothy_horton@apple.com

10 edits
7 adds in trunk/Source

Full-page PDFPlugin should support inline form editing
https://bugs.webkit.org/show_bug.cgi?id=100155

Reviewed by Dan Bernstein.

Add form controls corresponding to Text and Choice PDF annotations,
allowing for single- and multi-line text input, and <select>-like input.

Currently, forms are only implemented for full-page PDF documents.

Shared/mac/PDFKitImports.h:

(WebKit): Add pdfAnnotationTextWidgetClass and pdfAnnotationChoiceWidgetClass.

Shared/mac/PDFKitImports.mm:

(WebKit::pdfAnnotationTextWidgetClass): Add pdfAnnotationTextWidgetClass.
(WebKit::pdfAnnotationChoiceWidgetClass): Add pdfAnnotationChoiceWidgetClass.

WebKit2.xcodeproj/project.pbxproj: Add PDFLayerControllerDetails, PDFPluginTextAnnotation, PDFPluginChoiceAnnotation,

and PDFPluginAnnotation.

WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Added. Extract PDFLayerController details category into a header.
WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add m_activeAnnotation, to keep track of the active PDFPluginAnnotation, and m_annotationContainer,
the <div> that form controls are inserted into.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeActiveAnnotation:]): Forward active annotation changes to PDFPlugin.
(WebKit::PDFPlugin::PDFPlugin): Add a <div> to the PluginDocument <body>, which will contain <input>, <select>, and <textarea> elements
corresponding to the active annotation. This div is made to fit to the body, and is "overflow: hidden" so that form elements scrolled
out of the viewport do not cause the Document to expand to be larger than the Plugin.
(WebKit::PDFPlugin::pdfDocumentDidLoad): Update PDFPlugin's notion of the scroll position immediately after the document loads, in case
the scroll position is constrained by PDFKit.
(WebKit::PDFPlugin::destroy): Tear down any forms for the active annotation.
(WebKit::PDFPlugin::geometryDidChange): Notify the current annotation that it should update its geometry when the Plugin's geometry changes.
(WebKit::PDFPlugin::setScrollOffset): Notify the current annotation that it should update its geometry when we scroll.
(WebKit::PDFPlugin::setActiveAnnotation): Commit changes to the current annotation, if there is one, then make a new PDFPluginAnnotation
corresponding to the newly active annotation, and attach it to our document.

WebProcess/Plugins/PDF/PDFPluginAnnotation.h: Added.

(WebKit::PDFPluginAnnotation::element): Return the Element corresponding to this object.
(WebKit::PDFPluginAnnotation::annotation): Return the PDFAnnotation corresponding to this object.
(WebKit::PDFPluginAnnotation::plugin): Return the Plugin that created this object.
(WebKit::PDFPluginAnnotation::commit): Commit changes from the form to the PDFAnnotation. This is implemented in subclasses.
(WebKit::PDFPluginAnnotation::attach): Attach a PDFPluginAnnotation to its parent Element.
(WebKit::PDFPluginAnnotation::parent): Return the parent Element that we're attach()ed to.
(WebKit::PDFPluginAnnotation::pdfLayerController): Return the pdfLayerController that the PDFAnnotation comes from.
(PDFPluginAnnotationEventListener): Add an event listener to respond to "change" and "blur" events from m_element.

WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: Added.

(WebKit::PDFPluginAnnotation::create): Create the appropriate PDFPluginAnnotation subclass (PDFPluginTextAnnotation or
PDFPluginChoiceAnnotation based on the class of the PDFAnnotation).
(WebKit::PDFPluginAnnotation::attach): Lazily create the HTML form element corresponding to this annotation. Add it to its parent
element. Add event listeners for "change" and "blur".
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation): Tear down the annotation, by removing event listeners and removing
the form element from its parent element.
(WebKit::PDFPluginAnnotation::updateGeometry): Update the size and position of the form element, given the current PDF scale and scrolling position.
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent): If we get a blur or change event, we should remove the
form control to match the behavior of PDFKit.

WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h: Added.

(WebKit::PDFPluginChoiceAnnotation::choiceAnnotation): Return annotation() with the appropriate cast.

WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: Added.

(WebKit::PDFPluginChoiceAnnotation::updateGeometry): Update the font size of the choice widget given the current PDF scale.
(WebKit::PDFPluginChoiceAnnotation::commit): Save the value of the currently selected <option> into the PDFAnnotationChoiceWidget.
(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement): Create a <select> element, populated with <option> elements
for the PDFAnnotationChoiceWidget's available choices. Select the correct <option> initially.

WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h: Added.

(WebKit::PDFPluginTextAnnotation::textAnnotation): Return annotation() with the appropriate cast.

WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: Added.

(WebKit::cssAlignmentValueForNSTextAlignment): Return the CSS alignment value for a given NSTextAlignment.
(WebKit::PDFPluginTextAnnotation::createAnnotationElement): Create a <textarea> or <input> element, depending on whether the
PDFAnnotationTextWidget supports multiline editing or not.
(WebKit::PDFPluginTextAnnotation::updateGeometry): Update the font size of the text widget given the current PDF scale.
(WebKit::PDFPluginTextAnnotation::commit): Save the current string in the form element into the PDFAnnotationTextWidget.

WebProcess/WebPage/WebPage.cpp:

(WebKit::focusedPluginViewForFrame): Return the PluginView for a Frame only if the Plugin's element is focused.
(WebKit::WebPage::executeEditingCommand): Only forward editing commands to PluginView if the plugin itself is focused.
(WebKit::WebPage::isEditingCommandEnabled): Ditto.
(WebKit::WebPage::validateCommand): Ditto.

WebCore.exp.in: Expose a variety of additional WebCore functionality to WebKit2.
WebCore.xcodeproj/project.pbxproj: Expose some more WebCore headers as private headers for use in WebKit2.

Oct 30, 2012:

11:58 PM Changeset in webkit [132991] by yuqiang.xian@intel.com

2 edits in trunk/Source/JavaScriptCore

glsl-function-atan.html WebGL conformance test fails after https://bugs.webkit.org/show_bug.cgi?id=99154
https://bugs.webkit.org/show_bug.cgi?id=100789

Reviewed by Filip Pizlo.

We accidently missed a bitwise double to int64 conversion.

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFill):

11:48 PM Changeset in webkit [132990] by eric@webkit.org

2 edits in trunk/Source/WebCore

RoboHornetPro spends ~25% of total test time in WebCore::Region::Shape methods
https://bugs.webkit.org/show_bug.cgi?id=98800

Reviewed by Sam Weinig.

This patch brings our total RoboHornetPro time from 8.2 seconds to 5.3 seconds!

OverlapMap previously used Regions to track Layer bounds rects.
Unfortunately unioning a list of Regions is O(N^{2)

where N is the number of Shapes (in this case rects).

This is because Shapes are immutable, so to union two shapes, we copy

both Shapes' segment/span vectors into a single new Shape.

Thus if we union a set of M Regions, each with 1 Shape, we'll end up copying

the segments of the first Shape N times before we have the final Region/Shape

and the second shape N-1 times. The sum of 1 to N is (N*(N-1))/2 aka order N}2.
Fixing the N^{2 algorithm covered by https://bugs.webkit.org/show_bug.cgi?id=100814.}

For now we just avoid this O(N^{2) by moving away from Region, since OverlapMap

doesn't need it. We just collect a vector of the layer rects and hit-test that directly.

Hit-testing the rect list is O(N), just like hit-testing the same information in a Region would be.}

Even better for us is that the OverlapMap is never even used in RoboHornetPro.
We just collect these rects to end up doing nothing with them. :)

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::OverlapMap::add):
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::pushCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(RenderLayerCompositor::OverlapMap):

11:17 PM Changeset in webkit [132989] by thakis@chromium.org

2 edits
11 adds in trunk/LayoutTests

[chromium] Add baselines for fast/images/exif-orientation-css.html and exif-orientation-image-document.html
https://bugs.webkit.org/show_bug.cgi?id=100807

Unreviewed, expectations update.

platform/chromium-linux-x86/fast/images/exif-orientation-css-expected.png: Added.
platform/chromium-linux/fast/images/exif-orientation-css-expected.png: Added.
platform/chromium-linux/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-mac-lion/fast/images/exif-orientation-css-expected.png: Added.
platform/chromium-mac-lion/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-mac-snowleopard/fast/images/exif-orientation-css-expected.png: Added.
platform/chromium-mac-snowleopard/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-mac/fast/images/exif-orientation-css-expected.png: Added.
platform/chromium-mac/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-win/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium/TestExpectations:

11:08 PM Changeset in webkit [132988] by commit-queue@webkit.org

2 edits in trunk/Tools

[WTR] Memory leaks in TestWebKitAPI::didReceiveMessageFromInjectedBundle()
https://bugs.webkit.org/show_bug.cgi?id=100770

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-30
Reviewed by Sam Weinig.

Adopt strings returned by WKStringCreateWithUTF8CString() in
didReceiveMessageFromInjectedBundle() to avoid memory leaks.

TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

10:59 PM Changeset in webkit [132987] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Fix failure to highlight nodes on web inspector
https://bugs.webkit.org/show_bug.cgi?id=100303

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

It is not working to highlight nodes on web inspector
when using 'Single Backing Store'.
Add code for drawing it if there is the highlighted node.

ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

10:58 PM Changeset in webkit [132986] by Beth Dakin

3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=100813
ScrollingCoordinatorMac::stateNodeForID() should return a
ScrollingStateNode* instead of a ScrollingStateScrollingNode*

Reviewed by Sam Weinig.

ScrollingCoordinatorMac::stateNodeForID() should return a
ScrollingStateNode* instead of a ScrollingStateScrollingNode* so that
it can be used for other types of nodes once we add them.

page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::recomputeWheelEventHandlerCountForFrameView):
(WebCore::ScrollingCoordinatorMac::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinatorMac::stateNodeForID):

10:49 PM Changeset in webkit [132985] by keishi@webkit.org

3 edits
2 adds in trunk

F4 inside <input type=time> should not open calendar picker
https://bugs.webkit.org/show_bug.cgi?id=100730

Reviewed by Kent Tamura.

Source/WebCore:

We lacked the check to see if the picker indicator is visible.

Test: fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): Check if picker indicator is visible.

LayoutTests:

fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html: Added.

10:45 PM Changeset in webkit [132984] by commit-queue@webkit.org

2 edits in trunk/Tools

Fix broken python unit test
https://bugs.webkit.org/show_bug.cgi?id=100810

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-30
Reviewed by Dirk Pranke.

BUG 100755 has broken python unit test, e.g. assertion fail, since it modified baseline path.
Therefore, this patch fixes it.

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):

10:19 PM Changeset in webkit [132983] by tkent@chromium.org

5 edits
2 adds in trunk

Delaying 'change' and 'input' event dispatching during HTMLInputElement::setValue
https://bugs.webkit.org/show_bug.cgi?id=100772

Reviewed by Abhishek Arya.

Source/WebCore:

'change' and 'input' events are asynchronous and not
cancelable. We can use ScopedEvent.

Test: fast/forms/range/range-type-change-onchange.html

dom/Node.cpp:

(WebCore::Node::dispatchChangeEvent): Use dispatchScopedEvent.
(WebCore::Node::dispatchInputEvent): Ditto.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
Make a scope to delay event dispatching.

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent): Ditto.

LayoutTests:

fast/forms/range/range-type-change-onchange-expected.txt: Added.
fast/forms/range/range-type-change-onchange.html: Added.

10:03 PM Changeset in webkit [132982] by Simon Fraser

6 edits
3 adds in trunk

Fix issues with filters and reflections
https://bugs.webkit.org/show_bug.cgi?id=100308

Reviewed by Dirk Schulze.

Source/WebCore:

Composited filters were being applied to the wrong CALayer. The code used
primaryLayer(), which may be a CATransformLayer (which filters cannot apply
to; doing so causes console spew), or a CALayer that is used for reflection
flattening, which again is the wrong layer.

Test: css3/filters/composited-reflected.html

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsVisibility): Replace .get()-> with ->
(WebCore::GraphicsLayerCA::updateContentsOpaque): Ditto.
(WebCore::GraphicsLayerCA::updateFilters): Apply filters to m_layer, not primaryLayer(),
and use m_layerClones, not primaryLayerClones().
(WebCore::GraphicsLayerCA::cloneLayer): When cloning a layer for reflections, copy filters
from the source layer.

platform/graphics/ca/PlatformCALayer.h:

(PlatformCALayer): Add a member function to copy filters from a supplied layer.

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setFilters): Remove blank line.
(PlatformCALayer::copyFiltersFrom): Copy CAFIlters from the given layer.

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::copyFiltersFrom): Stub; no filters on Windows.

LayoutTests:

Test composited filters inside a nested reflection.

css3/filters/composited-reflected-expected.png: Added.
css3/filters/composited-reflected-expected.txt: Added.
css3/filters/composited-reflected.html: Added.
platform/mac/css3/filters/composited-reflected-expected.png: Added.

9:54 PM Changeset in webkit [132981] by Beth Dakin

5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=100809
ScrollingCoordinator::attachToStateTree() should take an enum
indicating what type of node to create

Reviewed by Simon Fraser.

New enum ScrollingNodeType will soon have other values, such as
FixedNode.

page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::attachToStateTree):

page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

This patch generalizes this function so that it can be used to create
different types of nodes and so that it is actually ready to create
child nodes.

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::attachToStateTree):

The rootStateNode is always a ScrollingNode.
(WebCore::ScrollingCoordinatorMac::ensureRootStateNodeForFrameView):

For the time being, always create a ScrollingNode.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::attachToScrollingCoordinator):

8:41 PM Changeset in webkit [132980] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Set the initial scissor box for WebGL
https://bugs.webkit.org/show_bug.cgi?id=100804

Patch by Gregg Tavares <gman@google.com> on 2012-10-30
Reviewed by Kenneth Russell.

The initial scissor box needs to be set for WebGL

No new tests as no new functionality.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):

8:04 PM Changeset in webkit [132979] by bashi@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test expectations update

platform/chromium/TestExpectations:

7:50 PM Changeset in webkit [132978] by commit-queue@webkit.org

6 edits
2 deletes in trunk/Source/WebKit

[BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry"
https://bugs.webkit.org/show_bug.cgi?id=100724

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-10-30
Reviewed by Rob Buis.

Remove the code of JavaScriptDebuggerBlackBerry.

Source/WebKit:

PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Api/WebPage.cpp:
Api/WebPage.h:
Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: Removed.
WebCoreSupport/JavaScriptDebuggerBlackBerry.h: Removed.

7:39 PM Changeset in webkit [132977] by bashi@chromium.org

4 edits in trunk/LayoutTests

Unreviewed test update after r132969

Add alternate font family name (Courier New).

fast/css/font-face-descending-unicode-range.html:
fast/css/font-face-download-error.html:
fast/css/font-face-unicode-range.html:

7:01 PM Changeset in webkit [132976] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] PurgeCredential should also purge the persisted credential store
https://bugs.webkit.org/show_bug.cgi?id=100744

Reviewed by George Staikos.

When challenged by the server, we will check the credential in-memory and from the persistent storage.
So the invalid credentials should also be purged from the persistent credential storage; Otherwise,
it will be sent to the server next time been challenged, instead of prompting the user.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::purgeCredentials):

7:01 PM Changeset in webkit [132975] by thakis@chromium.org

2 edits in trunk/LayoutTests

[chromium] Enable fast/images/exif-orientation-css.html
https://bugs.webkit.org/show_bug.cgi?id=100767

Unreviewed, expectations-only change.

platform/chromium/TestExpectations:

7:00 PM Changeset in webkit [132974] by commit-queue@webkit.org

12 edits in trunk/Source/WebKit2

[Mac] Make WebKit2 Build with NETWORK_PROCESS disabled
https://bugs.webkit.org/show_bug.cgi?id=100798

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-10-30
Reviewed by David Kilzer.

Wrap a few remaining NetworkProcess files and related code in
ENABLE(NETWORK_PROCESS) guards to avoid being compiled when disabled.

NetworkProcess/HostRecord.cpp:
NetworkProcess/HostRecord.h:
NetworkProcess/NetworkRequest.cpp:
NetworkProcess/NetworkRequest.h:
NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
UIProcess/Network/NetworkProcessManager.cpp:
UIProcess/Network/NetworkProcessManager.h:

Wrap files in guards.

UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):
Wrap NetworkProcess enum access in guards.

WebProcess/WebKitMain.cpp:

(WebKitMain):
Wrap NetworkProcess enum switch case in guards.

WebKit2Prefix.h:

Remove an extraneous close and reopen of the same guard.

6:43 PM Changeset in webkit [132973] by allan.jensen@digia.com

3 edits
3 adds in trunk

DOM URL is flaky when workers are used
https://bugs.webkit.org/show_bug.cgi?id=99178

Reviewed by Geoffrey Garen.

Source/WebCore:

Extend JSNoStaticTables to also avoid direct access of static tables in constructor objects.

Test: fast/workers/worker-domurl.html

bindings/scripts/CodeGeneratorJS.pm:

(constructorHashTableAccessor):
(GenerateConstructorDefinition):

LayoutTests:

Test that the methods of the URL constructor are accesible from both main and worker threads.

fast/workers/resources/worker-domurl.js: Added.

(log):
(onmessage):

fast/workers/worker-domurl-expected.txt: Added.
fast/workers/worker-domurl.html: Added.

6:39 PM Changeset in webkit [132972] by commit-queue@webkit.org

5 edits in trunk/Source

Coordinated Graphics: Remove unused methods
https://bugs.webkit.org/show_bug.cgi?id=100799

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-10-30
Reviewed by Noam Rosenthal.

Currently, there are several unused methods regarding Coordinated
Graphics. This patch removes those unused methods.

Source/WebCore:

No new tests (No change in behavior).

platform/graphics/texmap/TextureMapperGL.cpp:

Source/WebKit2:

UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

UIProcess/DrawingAreaProxy.h:

6:37 PM Changeset in webkit [132971] by commit-queue@webkit.org

7 edits
4 adds in trunk

[CSS Exclusions] Multiple segment polygon layout does not get all segments
https://bugs.webkit.org/show_bug.cgi?id=100039

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-30
Reviewed by Dirk Schulze.

Source/WebCore:

Corrected the algorithm for computing included polygon intervals for rectilinear polygons,
and polygons with horizontal edges in general.

Tests: fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-001.html

fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-002.html

rendering/ExclusionPolygon.cpp: Removed some internal dead code related to the no-longer-used sortedEdgesMinY Vector.

(WebCore::ExclusionPolygon::ExclusionPolygon): Initialize new ExclusionPolygonEdge edgeIndex field.
(WebCore::getVertexIntersectionVertices): Return the previous, next, and target vertex indices for a vertex intersection.
(WebCore::ExclusionPolygon::computeXIntersections): Refactored the core of this method to improve handling of horizontal edges.
(WebCore::ExclusionPolygon::computeEdgeIntersections): Ignore zero-width edges.

rendering/ExclusionPolygon.h: Removed the rightVertexY() method, since it's no longer used.

(WebCore::ExclusionPolygon::edgeAt): New method.
(WebCore::ExclusionPolygon::numberOfEdges): New method.
(ExclusionPolygon): Added support for retrieving edges.
(WebCore::ExclusionPolygonEdge::vertex1): Use vertex1Index.
(WebCore::ExclusionPolygonEdge::vertex2): Use vertex2Index.
(ExclusionPolygonEdge): Renamed index1, index2 fields to vertex1Index, vertex2Index.
(WebCore::ExclusionPolygonEdge::previousEdge): New method.
(WebCore::ExclusionPolygonEdge::nextEdge): New method.

LayoutTests:

Added tests for CSS Exclusion shape-inside polygons with horizontal edges.
Corrected the simple-polygon.js code for computing a polygon's included intervals.

fast/exclusions/resources/simple-polygon.js:
fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-001-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-001.html: Added.
fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-002-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-002.html: Added.
fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html:

6:10 PM Changeset in webkit [132970] by cevans@google.com

3 edits in trunk/Source/WebCore

Improve performance of MaskPtr.
https://bugs.webkit.org/show_bug.cgi?id=100790

Reviewed by Eric Seidel.

Calculate the mask once, and store it as a fast-access member variable.
Also avoid unneccessary integer width expansion in index calculation.
Parser/tiny-innerHTML.html has a high stddev.
Best result I've seen pre-patch is 5.70 runs/s.
Best result I've seen post-patch is 5.72 runs/s, but this is not statistically significant.
MaskPtr is still showing as ~2% in the profile, so we're not sure we trust the profile symbolization at this time.
MaskPtr is now reduced to a single inline instruction (was: 4) so this seems like a strict improvement worth landing.

rendering/RenderArena.cpp:

(MaskPtr): Use a passed-in mask for the mask operation.
(WebCore::RenderArena::RenderArena): Calculate the mask and store it.
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free): Use stored mask and avoid unneccessary casts.

rendering/RenderArena.h:

(RenderArena): Store the freelist mask as a member variable.

5:45 PM Changeset in webkit [132969] by bashi@chromium.org

6 edits in trunk

local(Helvetica) in src descriptor prevent fallback
https://bugs.webkit.org/show_bug.cgi?id=100446

Reviewed by Dan Bernstein.

Source/WebCore:

FontCache::getCachedFontData() has a mechanism that aliases a few pairs
of font family names, so that if the family name specified in the font-family
property is not available on the system, but the its alias is available,
it will be used instead. This is appropriate for the font-family property,
but not for font family names specified in the local() function of the src
descriptor in a @font-face rule.

This patch disables the mechanism while checking src descriptor of @font-face.

No new tests. It's difficult to test the change because 'Helvetica' can
be mapped any other font. For example, chromium DRT uses FontConfig to
map Helvetica to Times New Roman. Other ports may map Helvetica to other
fonts. We can't define the expected result.

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):
Call fontCache()->getCachedFontData() with checkingAlternateName = true.
This disables aliasing font family names in FontCache.

LayoutTests:

Add alternate font family names to src descriptor of @font-face rules
so that the change doesn't change the expectations of tests.

fast/css/font-face-implicit-local-font.html:
fast/css/font-face-multiple-faces.html:
svg/custom/font-face-simple.svg:

5:18 PM Changeset in webkit [132968] by Beth Dakin

3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=100796
Should add FixedPositionViewportConstraints to ScrollingConstraints.h

Reviewed by Simon Fraser.

ScrollingConstraints.h currently contains an abstract class called
ViewportConstraints that is intended to encapsulate data and logic
required to reposition elements whose layout depends on the viewport
rect (positions fixed and sticky), when scrolling and zooming.
However, at this time there is only a subclass for sticky. We should
add a sub-class for fixed. This is required to get pages with fixed
position elements scrolling on the scrolling thread.

page/scrolling/ScrollingConstraints.cpp:

(WebCore::FixedPositionViewportConstraints::layerPositionForViewportRect):
(WebCore):

page/scrolling/ScrollingConstraints.h:

(WebCore::ViewportConstraints::ViewportConstraints):
(ViewportConstraints):
(WebCore::ViewportConstraints::setAnchorEdges):
(FixedPositionViewportConstraints):
(WebCore::FixedPositionViewportConstraints::FixedPositionViewportConstraints):
(WebCore::FixedPositionViewportConstraints::viewportRectAtLastLayout):
(WebCore::FixedPositionViewportConstraints::setViewportRectAtLastLayout):
(WebCore::FixedPositionViewportConstraints::layerPositionAtLastLayout):
(WebCore::FixedPositionViewportConstraints::setLayerPositionAtLastLayout):
(WebCore):

5:12 PM Changeset in webkit [132967] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[BlackBerry] update form theme for BB10.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-10-30
Reviewed by Rob Buis.

RIM PR:222126
Introduce slide function to paint new theme for the form controls.

No new tests.

css/themeBlackBerry.css:

(select):

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::drawControl): Added.
(WebCore::drawThreeSlice): Added.
(WebCore::drawNineSlice): Added.
(WebCore::loadImage): Added.
(WebCore::RenderThemeBlackBerry::systemFont): Modified.
(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField): Modified.
(WebCore::RenderThemeBlackBerry::paintCheckbox): Modified.
(WebCore::RenderThemeBlackBerry::paintRadio): Modified.
(WebCore::RenderThemeBlackBerry::paintButton): Modified.
(WebCore::RenderThemeBlackBerry::paintMenuList): Modified.
(WebCore::RenderThemeBlackBerry::paintMenuListButton): Modified.
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect): Modified.
(WebCore::RenderThemeBlackBerry::paintSliderThumb): Modified.

platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

5:03 PM Changeset in webkit [132966] by commit-queue@webkit.org

5 edits
2 adds in trunk

cssText for cursor property doesn't include hotspot
https://bugs.webkit.org/show_bug.cgi?id=99530

Patch by Rick Byers <rbyers@chromium.org> on 2012-10-30
Reviewed by Darin Adler.

Source/WebCore:

Implement customCssText in CSSCursorImageValue to include the hotspot when present.
Also explicitly track whether or not a hotspot was supplied in the parser,
while still using the existing convention of (-1,-1) to denote no hotspot
in the rest of the system.

Test: fast/css/cursor-parsing.html

css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::customCssText):

css/CSSCursorImageValue.h:

(CSSCursorImageValue):

LayoutTests:

Add simple test for parsing of CSS cursor property.

fast/css/cursor-parsing-expected.txt: Added.
fast/css/cursor-parsing.html: Added.

5:00 PM Changeset in webkit [132965] by kbr@google.com

3 edits in trunk/Source/WebCore

Temporarily restrict use of ImageBufferSkia::copyToPlatformTexture until bugs resolved
https://bugs.webkit.org/show_bug.cgi?id=100714

Reviewed by Stephen White.

For the moment, only use ImageBuffer::copyToPlatformTexture when
copying to RGBA/UNSIGNED_BYTE textures, and document restriction
in header. Restriction will be lifted once the implementations
(currently only Chromium has one) have been fixed; see bug 100715.

No new tests; manually ran WebGL conformance test
tex-image-and-sub-image-2d-with-canvas-rgba5551.html on NVIDIA
hardware on Mac OS.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):

platform/graphics/ImageBuffer.h:

(ImageBuffer):

4:53 PM Changeset in webkit [132964] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Test should not be run on Apple Windows port: fast/images/exif-orientation-image-document.html

platform/win/TestExpectations:

4:50 PM Changeset in webkit [132963] by Joseph Pecoraro

8 edits in trunk/Source

[Mac] Sync up FeatureDefine Configuration Files
https://bugs.webkit.org/show_bug.cgi?id=100171

Reviewed by David Kilzer.

Follow up to better coordinate with iOS feature defines. Make:

ENABLE_FILTERS always on
ENABLE_INPUT_* iphonesimulator values point to the iphoneos values

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

4:48 PM Changeset in webkit [132962] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Skip another failing accessibility test on Windows: accessibility/svg-remote-element.html.

platform/win/TestExpectations:

4:43 PM Changeset in webkit [132961] by thakis@chromium.org

2 edits in trunk/Source/WebCore

Fix potential overflow in jpeg exif reader. Found by aedla@google.com.
https://bugs.webkit.org/show_bug.cgi?id=100320

Reviewed by Eric Seidel.

Adding more than 1 element past an array is undefined, so don't do it.

No test, since in practice ifd will just overflow and end - ifd will
become much larget than 2 and the if (end - ifd < 2) a few lines
down will catch that case.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readImageOrientation):

4:33 PM Changeset in webkit [132960] by Alexandru Chiculita

14 edits
2 adds in trunk/Source/WebCore

[CSS Shaders] Add the ValidatedCustomFilterOperation class
https://bugs.webkit.org/show_bug.cgi?id=100558

Reviewed by Dean Jackson.

Added the ValidatedCustomFilterOperation class. The file is now almost empty,
but more is going to come in the following patches.

Added the a filter operation type VALIDATED_CUSTOM and updated the compositors to ignore
such operations for now.

No new tests, there is no new functionality yet.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):

platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::filtersCanBeComposited):

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::filtersCanBeComposited):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::copyWebCoreFilterOperationsToWebFilterOperations):

platform/graphics/filters/FilterOperation.h:
platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::hasCustomFilter):
(WebCore::FilterOperations::getOutsets):

platform/graphics/filters/ValidatedCustomFilterOperation.cpp: Added.

(WebCore):
(WebCore::ValidatedCustomFilterOperation::ValidatedCustomFilterOperation):
(WebCore::ValidatedCustomFilterOperation::~ValidatedCustomFilterOperation):
(WebCore::ValidatedCustomFilterOperation::blend):

platform/graphics/filters/ValidatedCustomFilterOperation.h: Added.

(WebCore):
(ValidatedCustomFilterOperation):
(WebCore::ValidatedCustomFilterOperation::create):
(WebCore::ValidatedCustomFilterOperation::affectsOpacity):
(WebCore::ValidatedCustomFilterOperation::movesPixels):
(WebCore::ValidatedCustomFilterOperation::blendingNeedsRendererSize):
(WebCore::ValidatedCustomFilterOperation::operator==):

4:24 PM Changeset in webkit [132959] by dpranke@chromium.org

7 edits in trunk/Tools

webkit-patch rebaseline*: add more helpful logging
https://bugs.webkit.org/show_bug.cgi?id=100562

Reviewed by Ojan Vafai.

This change rewires the garden-o-matic and rebaseline* commands
in webkit-patch so that --verbose propagates through all the
subcommand invocations properly, and cleans up the logging so
that you can actually tell what is happening. For now, we
leave all of the logging at the logging.DEBUG level, which
means that it gets mixed in will all the other debug logging noise
and is harder to read, but we'll fix that in subsequent patches.

Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer._platform):
(BaselineOptimizer._move_baselines):
(BaselineOptimizer.optimize):

Scripts/webkitpy/tool/commands/gardenomatic.py:

(GardenOMatic.execute):

Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AbstractParallelRebaselineCommand._run_webkit_patch):
(AbstractParallelRebaselineCommand._rebaseline_commands):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._optimize_baselines):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineExpectations._add_tests_to_rebaseline_for_port):
(Rebaseline.execute):

Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPServer.init):
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler._run_webkit_patch):
(GardeningHTTPRequestHandler.rebaselineall):

4:24 PM Changeset in webkit [132958] by Joseph Pecoraro

8 edits in trunk/Source

[Mac] Sync up FeatureDefine Configuration Files
https://bugs.webkit.org/show_bug.cgi?id=100171

Reviewed by David Kilzer.

Ensure an identical FeatureDefine files across all projects. Changes:

ENABLE_CSS_BOX_DECORATION_BREAK should be in all
ENABLE_PDFKIT_PLUGIN should be in all
ENABLE_RESOLUTION_MEDIA_QUERY should be in all
ENABLE_ENCRYPTED_MEDIA should be in all
ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING with corrected value
Some alphabetical ordering cleanup

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

4:22 PM Changeset in webkit [132957] by dpranke@chromium.org

4 edits in trunk/Tools

clean up tests for webkit-patch rebaseline* commands
https://bugs.webkit.org/show_bug.cgi?id=100793

Reviewed by Ojan Vafai.

The tests in rebaseline_unittest.py had a lot of code cloning,
and many of the tests tested whether things passed or failed by
looking at what was logged instead of what was actually done;
as a result the tests were kinda hard to understand and harder to
maintain.

This patch adds hooks to MockWeb() and MockExecutive() so we can
directly see which URLs were fetched and calls invoked, and
then reworks all of the unit tests to be easier to follow and
maintain and not sensitive to the logging. Also there were a
couple of tests that were redundant.

There are no functional changes in this patch, and I verified that
the coverage remains the same.

Scripts/webkitpy/common/net/web_mock.py:

(MockWeb.init):
(MockWeb.get_binary):

Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.init):
(MockExecutive.run_command):
(MockExecutive.kill_all):
(MockExecutive):
(MockExecutive.kill_process):
(MockExecutive.popen):
(MockExecutive.run_in_parallel):
(MockExecutive2):
(MockExecutive2.init):
(MockExecutive2.run_command):

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(_BaseTestCase):
(_BaseTestCase.setUp):
(_BaseTestCase._expand):
(_BaseTestCase._read):
(_BaseTestCase._write):
(_BaseTestCase._zero_out_test_expectations):
(TestRebaselineTest):
(TestRebaselineTest.test_baseline_directory):
(TestRebaselineTest.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):
(TestRebaselineJson):
(TestRebaselineJson.setUp):
(TestRebaselineJson.tearDown):
(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaseline):
(TestRebaseline.test_tests_to_update):
(TestRebaseline.test_rebaseline):
(TestRebaseline.test_rebaseline.rebaseline_stub):
(TestRebaselineExpectations):
(TestRebaselineExpectations.setUp):
(TestRebaselineExpectations.test_rebaseline_expectations):
(TestRebaselineExpectations.test_rebaseline_expectations_noop):
(TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):

4:21 PM Changeset in webkit [132956] by Lucas Forschler

3 edits
2 copies in branches/safari-536.28-branch

Merged r117224. <rdar://problem/12504539>

4:17 PM Changeset in webkit [132955] by dpranke@chromium.org

3 edits in trunk/Tools

test-webkitpy: fix import of coverage so that it works in a clean install
https://bugs.webkit.org/show_bug.cgi?id=100780

Reviewed by Tony Chang.

The coverage module is written so that the parent directory needs
to be in PYTHONPATH; work around that ...

Scripts/webkitpy/test/main_unittest.py:

(TestStubs.test_empty):
(TesterTest.test_individual_names_are_not_run_twice):
(TesterTest):
(TesterTest.integration_test_coverage_works):

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_coverage):

4:17 PM Changeset in webkit [132954] by Lucas Forschler

3 edits
2 copies in branches/safari-536.28-branch

Merged r116255. <rdar://problem/12536487>

4:11 PM Changeset in webkit [132953] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Arrays can change IndexingType in the middle of sorting
https://bugs.webkit.org/show_bug.cgi?id=100773

Reviewed by Filip Pizlo.

Instead of giving up, we just fetch the appropriate vector based on the current
IndexingType of the array.

runtime/JSArray.cpp:

(JSC::JSArray::sortVector):

runtime/JSObject.h:

(JSObject):
(JSC::JSObject::currentIndexingData):
(JSC::JSObject::currentRelevantLength):

3:55 PM Changeset in webkit [132952] by kling@webkit.org

8 edits in trunk/Source/WebCore

StylePropertySet: Convert more logic to use PropertyReference.
<http://webkit.org/b/100779>

Reviewed by Antti Koivisto.

Rewrite more of the StylePropertySet logic to use PropertyReference instead of CSSProperty.
This is cleanup before changing the internal storage layout of immutable StylePropertySet.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):

css/CSSComputedStyleDeclaration.h:
css/CSSStyleDeclaration.h:
css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

css/PropertySetCSSStyleDeclaration.h:
css/StylePropertySet.cpp:

(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
(WebCore::StylePropertySet::findPropertyIndex):
(WebCore::StylePropertySet::findMutableCSSPropertyWithID):
(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):

css/StylePropertySet.h:

(WebCore::StylePropertySet::PropertyReference::shorthandID):
(WebCore::StylePropertySet::PropertyReference::isImplicit):

3:52 PM Changeset in webkit [132951] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Regression(r132887): Caused segfault in a EWK2UnitTestBase.ewk_view_text_find
https://bugs.webkit.org/show_bug.cgi?id=100781

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Make sure we pass a pointer to zero instead of a NULL pointer
as parameter to the "text,found" in case the text could not
be found. This prevents crashing in
EWK2UnitTestBase.ewk_view_text_find when trying to dereference
the parameter pointer.

UIProcess/efl/FindClientEfl.cpp:

(WebKit::FindClientEfl::didFailToFindString):

3:44 PM Changeset in webkit [132950] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Crash in WebProcess at com.apple.WebCore: WebCore::ResourceLoader::start
<rdar://problem/12596761> and https://webkit.org/b/100792

Reviewed by Tim Hatcher.

In release builds we can sometimes end up with a null ResourceLoader due to a race condition
with the WebProcess telling the NetworkProcess to remove a resource load at the very same time
the NetworkProcess is about to start that load.

Until we can resolve that race condition an early return will be necessary.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::startResourceLoad):

3:37 PM Changeset in webkit [132949] by eric@webkit.org

3 edits in trunk/Source/WebCore

Teach RenderTable how to use Vector::insert and Vector::append instead of its own custom memmove code
https://bugs.webkit.org/show_bug.cgi?id=100428

Reviewed by Julien Chaffraix.

RenderTable is now like all other clients of Vector instead of being
needlessly different. :)

insert, append and grow all use the same expandCapacity logic under the covers
and Vector::insert uses TypeOperations::moveOverlapping which should use memmove
by default for unknown types.

rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

rendering/RenderTable.h:

(WebCore::RenderTable::ColumnStruct::ColumnStruct):

3:28 PM Changeset in webkit [132948] by scheib@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed: Additional webgl test suppression to go along with earlier ones.
https://bugs.webkit.org/show_bug.cgi?id=100784

platform/chromium/TestExpectations:

2:53 PM Changeset in webkit [132947] by scheib@chromium.org

14 edits
2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r132927.
http://trac.webkit.org/changeset/132927
https://bugs.webkit.org/show_bug.cgi?id=100558

Compile error on Chromium builders

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):

platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::filtersCanBeComposited):

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::filtersCanBeComposited):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::copyWebCoreFilterOperationsToWebFilterOperations):

platform/graphics/filters/FilterOperation.h:
platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::hasCustomFilter):
(WebCore::FilterOperations::getOutsets):

platform/graphics/filters/ValidatedCustomFilterOperation.cpp: Removed.
platform/graphics/filters/ValidatedCustomFilterOperation.h: Removed.

2:38 PM Changeset in webkit [132946] by wjmaclean@chromium.org

4 edits in trunk/Source

[chromium] Transform mouse/gesture event coordinates to account for pinch-zoom in compositor.
https://bugs.webkit.org/show_bug.cgi?id=100542

Reviewed by James Robinson.

Pinch-zoom in the compositor applies a transformation that WebCore does not know about.
We need to adjust mouse and gesture event coordinates to account for this in order that
hit testing work properly for these types while zoomed.

Source/Platform:

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):
(WebKit::WebLayerTreeView::adjustPointForZoom): Adjusts point coordinated to account for zoom in compositor.

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent): Modified to adjoint event coordinates to account for zoom.

2:29 PM Changeset in webkit [132945] by wjmaclean@chromium.org

10 edits in trunk

[chromium] Restrict link highlights to targets that display a hand-cursor
https://bugs.webkit.org/show_bug.cgi?id=99862

Reviewed by James Robinson.

To avoid applying highlights to inappropriate targets, such as large divs with
click handlers installed, test candidate targets and only highlight them if they
would normally display a hand cursor on mouse over. This is a heuristic, but has
been tested and found effective in practice.

Source/WebCore:

This CL refactors EventHandler::selectCursor() to make the logic for determining
if CURSOR_AUTO should resolve to CURSOR_POINTER available outside EventHandler.

Relies on existing cursor tests.

page/EventHandler.cpp:

(WebCore::EventHandler::useHandCursor):
(WebCore):
(WebCore::EventHandler::selectCursor):

page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::invokesHandCursor):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::enableTouchHighlight):

src/WebViewImpl.h:

(WebViewImpl):

tests/LinkHighlightTest.cpp:

(WebCore::TEST):

tests/data/test_touch_link_highlight.html:

LayoutTests:

platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div.html:

1:58 PM Changeset in webkit [132944] by rwlbuis@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] Remove CookieDatabaseBackingStore::upgradeTableIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=100783

Reviewed by Yong Li.

PR 220513.

Remove CookieDatabaseBackingStore::upgradeTableIfNeeded, it was needed for backwards
compatibility, but not needed anymore.

platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::invokeOpen):

platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:

1:53 PM Changeset in webkit [132943] by scheib@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviwed suppression of 6 webgl tests.
https://bugs.webkit.org/show_bug.cgi?id=100784

platform/chromium/TestExpectations:

1:31 PM Changeset in webkit [132942] by commit-queue@webkit.org

15 edits in trunk

[CSS] Expand -webkit-line-break value space
https://bugs.webkit.org/show_bug.cgi?id=100739

Patch by Glenn Adams <glenn@skynav.com> on 2012-10-30
Reviewed by Eric Seidel.

Source/WebCore:

(1) expand -webkit-line-break to include new values defined by CSS3 Text [1], i.e., 'auto', 'strict', 'loose';
(2) change default (initial) value for -webkit-line-break to 'auto' to match CSS3 Text;
(3) rename enum EKHTMLLineBreak to LineBreak, renaming enum values appropriately;

New tests to be added when functionality of new values is added. No rendering behavior change at this time.
Only externally visible change is default (initial) value returning 'auto' rather than 'normal', for which 3 existing
tests that were sensitive to this value have been updated. Note that until the functionality for the new values is
added, any actual use of the new values will be treated as the same as the pre-existing 'normal' value, i.e., the
default semantics.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Update from kthmlLineBreak() to lineBreak().

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
Update values supported for CSSPropertyWebkitLineBreak.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineBreak):
Update LineBreak enumeration values (previously EKHTMLLineBreak).

css/CSSValueKeywords.in:

Update keywords used for -webkit-line-break.

css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):
Update names for line break style getter/setter.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):
Remove khtml prefix on line break related state.

rendering/style/RenderStyle.h:

Remove khtml prefix on line break related methods. Update to redefined LineBreak
enumeration type.

rendering/style/RenderStyleConstants.h:

Rename EKHTMLLineBreak enumeration to LineBreak.
Redefine LineBreak enumeration to include new CSS3 Text modes (auto, loose, strict) and
use better names.

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
Remove khtml prefix on line break related state references.

rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):
Remove khtml prefix on line break related state. Widen field to 3 bits to support 8 values,
of which 5 are now used.

LayoutTests:

Change default (initial) value for -webkit-line-break to 'auto' to match CSS3 Text.

fast/css/getComputedStyle/computed-style-expected.txt:

Fix for change of initial (default) value on -webkit-line-break from 'normal' to 'auto'.

fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

Fix for change of initial (default) value on -webkit-line-break from 'normal' to 'auto'.

svg/css/getComputedStyle-basic-expected.txt:

Fix for change of initial (default) value on -webkit-line-break from 'normal' to 'auto'.

1:25 PM Changeset in webkit [132941] by Antti Koivisto

10 edits in trunk/Source/WebCore

Avoid unnecessary style recalcs on class attribute mutation
https://bugs.webkit.org/show_bug.cgi?id=100776

Reviewed by Andreas Kling.

There is no need to invalidate element style on class attribute change if neither the added
or removed classes featured in any active stylesheet.

css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::reportMemoryUsage):

css/RuleFeature.h:

(RuleFeatureSet):

css/RuleSet.cpp:

(WebCore::collectFeaturesFromSelector):

Collect classes mentioned in CSS selectors the same way ids and attribute names are
already collected.

css/StyleResolver.cpp:

(WebCore::StyleResolver::hasSelectorForClass):

Add a method to test if a given class name is mentioned anywhere in stylehseets.

(WebCore):

css/StyleResolver.h:
css/StyleScopeResolver.h:

(WebCore):

dom/Element.cpp:

(WebCore::collectAddedAndRemovedClasses):
(WebCore):
(WebCore::Element::classAttributeChanged):

Figure out which classes were added and removed. Test if they are present in any style
rule and invalidate the style only if they are.

dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::add):
(WebCore::SpaceSplitStringData::remove):
(WebCore::SpaceSplitString::add):
(WebCore::SpaceSplitString::remove):

Added bool return value to indicate if anything was actually removed. Reorganized
the code a bit to avoid unnecessary uniquing when nothing changes.

dom/SpaceSplitString.h:

(SpaceSplitStringData):
(SpaceSplitString):

1:18 PM Changeset in webkit [132940] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fixed transfer annotation for default web context
https://bugs.webkit.org/show_bug.cgi?id=94314

Patch by Jesse van den Kieboom <jessevdk@gnome.org> on 2012-10-30
Reviewed by Martin Robinson.

Add a missing colon which prevented the transfer annotation of
webkit_web_context_get_default to be parsed correctly.

UIProcess/API/gtk/WebKitWebContext.cpp:

12:25 PM Changeset in webkit [132939] by andersca@apple.com

2 edits in trunk/Tools

Another build fix.

TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

12:24 PM Changeset in webkit [132938] by commit-queue@webkit.org

2 edits in trunk/Source/Platform

[chromium] Forward declare WebGraphicsContext3D in WebLayerTreeViewClient.h
https://bugs.webkit.org/show_bug.cgi?id=100717

Patch by James Robinson <jamesr@chromium.org> on 2012-10-30
Reviewed by Adrienne Walker.

Currently it isn't possible to include WebLayerTreeViewClient by itself.

chromium/public/WebLayerTreeViewClient.h:

(WebKit):

12:19 PM Changeset in webkit [132937] by andersca@apple.com

2 edits in trunk/Tools

Build fix.

WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseScrollBy):

12:14 PM Changeset in webkit [132936] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Use the message name when dispatching messages
https://bugs.webkit.org/show_bug.cgi?id=100774

Reviewed by Andreas Kling.

Change the message generator to decide which function to call based on the message name instead
of the MessageID. This is yet another step towards eliminating MessageID completely.

Scripts/webkit2/messages.py:

(async_message_statement):
(sync_message_statement):
(generate_message_handler):

Scripts/webkit2/messages_unittest.py:
UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::send):

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):

12:12 PM Changeset in webkit [132935] by robert@webkit.org

3 edits
2 adds in trunk

white-space: nowrap inline element beside a floated element wraps incorrectly without trailing textnode/newline
https://bugs.webkit.org/show_bug.cgi?id=29648

Reviewed by Levi Weintraub.

Source/WebCore:

A no-wrap child on a line inside an autowrap container should move to the next line if a float doesn't allow
it to fit. This will happen if there is trailing space after the no-wrap child but not if it's the last renderer
on the line. This is because nextLineBreak() is only interested in the white-space style of the current renderer
and the renderer's next sibling (if there is one) when deciding whether it needs to fit below any floats that
push it beyond the edge of the container. There isn't any situation in which a no-wrap child shouldn't move
below a float on an auto-wrap line though, so this check always needs to respect the container's white-space style too.

Test: fast/text/whitespace/no-wrap-child-in-auto-wrap-container.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

fast/text/whitespace/no-wrap-child-in-auto-wrap-container-expected.html: Added.
fast/text/whitespace/no-wrap-child-in-auto-wrap-container.html: Added.

12:06 PM Changeset in webkit [132934] by kareng@chromium.org

7 edits in branches/chromium/1312/Source

Merge 132922 - Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975

Patch by Dan Carney <dcarney@google.com> on 2012-10-30
Reviewed by Adam Barth.

Source/WebCore:

Removed auxilliaryContext as use if it is problematic in IDB.

No new tests. No change in functionality.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):

Modules/indexeddb/IDBCursor.h:

(IDBCursor):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::put):
(WebCore):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):

bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):

bindings/v8/IDBBindingUtilities.h:

(WebCore):

bindings/v8/V8Binding.cpp:

(WebCore::toV8Context):
(WebCore):

bindings/v8/V8Binding.h:

(WebCore):

bindings/v8/V8PerIsolateData.cpp:

(WebCore):

bindings/v8/V8PerIsolateData.h:

Source/WebKit/chromium:

Updated tests to use correct v8 context.

tests/IDBBindingUtilitiesTest.cpp:

(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::checkKeyPathNullValue):
(WebKit::injectKey):
(WebKit::checkInjection):
(WebKit::checkInjectionFails):
(WebKit::checkKeyPathStringValue):
(WebKit::checkKeyPathNumberValue):
(WebKit::scriptExecutionContext):
(WebKit):
(WebKit::TEST):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11337028

12:01 PM Changeset in webkit [132933] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/security tests to add to the skip list.
Bug tracking flaky security tests here: https://bugs.webkit.org/show_bug.cgi?id=95803.

platform/win/TestExpectations:

11:58 AM Changeset in webkit [132932] by kareng@chromium.org

1 add in branches/chromium/1312/codereview.settings

for easy drover

11:57 AM Changeset in webkit [132931] by kareng@chromium.org

1 copy in branches/chromium/1312

branching for m24

11:51 AM Changeset in webkit [132930] by Simon Fraser

2 edits in trunk/LayoutTests

Skip tiled drawing tests on Lion, since the TiledCoreAnimationDrawingArea is only
built for Mountain Lion and later.

platform/mac-lion/TestExpectations:

11:44 AM Changeset in webkit [132929] by commit-queue@webkit.org

7 edits in trunk

[touchadjustment] touch-links-longpress tests passes incorrectly
https://bugs.webkit.org/show_bug.cgi?id=96810

Patch by Rick Byers <rbyers@chromium.org> on 2012-10-30
Reviewed by Antonio Gomes.

Tools:

Add support for suppling width/height information for longpress
gesture (as for other gestures like tapDown) for the purposes
of touch adjustment.

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::gestureEvent):

LayoutTests:

Fix touch-links-longpress test to be consistent with touch-links-active.
Now it's actually touching where we intended - at the center of the
touch region identified instead of the top/left corner. Also pass
the width/height of the touch to EventSender in order to enable touch
adjustment.

Also adds checks to verify that our touches are actually landing on
or outside the element we're targetting as desired.

touchadjustment/resources/touchadjustment.js:

(findAbsoluteBounds): Update to support both inline and block nodes (clientHeight is 0 for inline nodes)

touchadjustment/touch-links-active.html: Use updated findAbsoluteBounds
touchadjustment/touch-links-longpress.html:

11:25 AM Changeset in webkit [132928] by alokp@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

11:15 AM Changeset in webkit [132927] by Alexandru Chiculita

14 edits
2 adds in trunk/Source/WebCore

[CSS Shaders] Add the ValidatedCustomFilterOperation class
https://bugs.webkit.org/show_bug.cgi?id=100558

Reviewed by Dean Jackson.

Added the ValidatedCustomFilterOperation class. The file is now almost empty,
but more is going to come in the following patches.

Added the a filter operation type VALIDATED_CUSTOM and updated the compositors to ignore
such operations for now.

No new tests, there is no new functionality yet.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):

platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::filtersCanBeComposited):

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::filtersCanBeComposited):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::copyWebCoreFilterOperationsToWebFilterOperations):

platform/graphics/filters/FilterOperation.h:
platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::hasCustomFilter):
(WebCore::FilterOperations::getOutsets):

platform/graphics/filters/ValidatedCustomFilterOperation.cpp: Added.

platform/graphics/filters/ValidatedCustomFilterOperation.h: Added.

11:09 AM Changeset in webkit [132926] by weinig@apple.com

62 edits in trunk/Source/WebKit2

Switch more class to use the new << form of encode
https://bugs.webkit.org/show_bug.cgi?id=100725

Reviewed by Anders Carlsson.

Switches many uses of encoder.encode(foo) to encoder << foo.
Switches a few places to take an ArgumentEncoder& rather than an ArgumentEncoder*.
Switches a few places away from using encoder.encodeVariableLengthByteArray(foo) to using encoder << CoreIPC::DataReference(foo).

Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
(CoreIPC::handleMessageVariadic):

Platform/CoreIPC/StringReference.cpp:

(CoreIPC::StringReference::encode):
(CoreIPC::StringReference::decode):

Platform/CoreIPC/mac/MachPort.h:

(CoreIPC::MachPort::encode):

Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::encode):

PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::encode):

Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):

Shared/EditorState.cpp:

(WebKit::EditorState::encode):

Shared/FontInfo.cpp:

(WebKit::FontInfo::encode):

Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):

Shared/OriginAndDatabases.cpp:

(WebKit::OriginAndDatabases::encode):

Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode):

Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::encode):

Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::encode):

Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):

Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode):

Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::encode):

Shared/SessionState.cpp:

(WebKit::SessionState::encode):

Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::encode):

Shared/SharedWorkerProcessCreationParameters.cpp:

(WebKit::SharedWorkerProcessCreationParameters::encode):

Shared/StatisticsData.cpp:

(WebKit::StatisticsData::encode):

Shared/StringPairVector.h:

(WebKit::StringPairVector::encode):

Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):

Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::encode):

Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::encode):

Shared/WebEvent.cpp:

(WebKit::WebEvent::encode):

Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::encode):

Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::encode):

Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::encode):

Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::encode):

Shared/WebNavigationDataStore.h:

(WebKit::WebNavigationDataStore::encode):

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):

Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode):

Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::encode):

Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::encode):

Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::encode):

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):

Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::encode):

Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::encode):

Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::encode):
(CoreIPC::decode):

Shared/cf/ArgumentCodersCF.h:

(CoreIPC):

Shared/mac/ArgumentCodersMac.h:

(CoreIPC):

Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

Shared/mac/AttributedString.mm:

(WebKit::AttributedString::encode):

Shared/mac/ColorSpaceData.mm:

(WebKit::ColorSpaceData::encode):

Shared/mac/KeychainAttribute.cpp:

(CoreIPC::encode):

Shared/mac/KeychainAttribute.h:

(CoreIPC):

Shared/mac/LayerTreeContextMac.mm:

(WebKit::LayerTreeContext::encode):

Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::encode):

Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::encode):
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):

Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::encode):

Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::encode):

Shared/mac/SecKeychainItemRequestData.cpp:

(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):

Shared/mac/SecKeychainItemResponseData.cpp:

(WebKit::SecKeychainItemResponseData::encode):

Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):

UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::encodeMessageBody):

UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):

WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):

WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode):

WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::encodeMessageBody):

11:07 AM Changeset in webkit [132925] by andersca@apple.com

42 edits in trunk

Build WebKit as C++11 on Mac
https://bugs.webkit.org/show_bug.cgi?id=100720

Reviewed by Daniel Bates.

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::beginSwitch):

llint/LLIntOffsetsExtractor.cpp:
runtime/Identifier.cpp:

(JSC::Identifier::add8):

runtime/Identifier.h:

(JSC::Identifier::add):

runtime/JSONObject.cpp:

(JSC::appendStringToStringBuilder):

runtime/StringPrototype.cpp:

(JSC::replaceUsingStringSearch):
Add static_casts to prevent implicit type conversions in non-constant initializer lists.

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.

Source/WebCore:

Configurations/Base.xcconfig:

Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.

platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::hash):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):

platform/graphics/filters/CustomFilterProgramInfo.cpp:

(WebCore::CustomFilterProgramInfo::hash):
(WebCore::ProtectionSpaceHash::hash):

platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::setHTTPBody):
Add static_casts to prevent implicit type conversions in non-constant initializer lists.

platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::createDragImage):

platform/mac/CursorMac.mm:

(WebCore::createNamedCursor):

platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetContentsSize):
Use NSMakePoint to prevent implicit type conversions in non-constant initializer lists.

platform/mac/CookieJar.mm:

(WebCore::cookiesEnabled):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
Add explicit casts to NSHTTPCookieAcceptPolicy.

platform/mac/WebCoreNSURLExtras.h:
platform/mac/WebCoreNSURLExtras.mm:

(WebCore::URLByTruncatingOneCharacterBeforeComponent):
(WebCore::dataForURLComponentType):

platform/network/ProtectionSpaceHash.h:

Use CFIndex instead of CFURLComponentType, the enum can be mangled differently in some cases, and these
functions are exported from WebCore.

Source/WebKit/mac:

Configurations/Base.xcconfig:

Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.

History/WebBackForwardList.mm:

(-[WebBackForwardList description]):

History/WebHistoryItem.mm:

(-[WebHistoryItem description]):
Add static_casts to prevent implicit type conversions in non-constant initializer lists.

Source/WebKit2:

Configurations/Base.xcconfig:

Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.

UIProcess/mac/WebCookieManagerProxyMac.mm:

(WebKit::WebCookieManagerProxy::persistHTTPCookieAcceptPolicy):

WebProcess/Cookies/mac/WebCookieManagerMac.mm:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Add explicit casts to NSHTTPCookieAcceptPolicy.

Source/WTF:

Configurations/Base.xcconfig:

Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.

wtf/text/AtomicString.cpp:

(WTF::AtomicString::add):
Change the type of length to be unsigned to prevent implicit type conversions in non-constant initializer lists.

wtf/unicode/UTF8.cpp:

(Unicode):
Add static_casts to prevent implicit type conversions in non-constant initializer lists.

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.

11:05 AM Changeset in webkit [132924] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/12395187> REGRESSION (r121299): OS X Text Replacement forces cursor out of text fields
https://bugs.webkit.org/show_bug.cgi?id=100768

Reviewed by Anders Carlsson.

Source/WebCore:

r121299 introduced code to restore the paragraph range by saving its length and start offset
relative to the document. The latter was obtained by iterating over the range starting at
the beginning of the document and ending at the beginning of the paragraph range. However,
such a range could not be constructed if the paragraph range was contained in a shadow DOM,
since a range must have both its endpoints within the same shadow tree (or not in a shadow
tree).

Test: platform/mac/editing/spelling/autocorrection-in-textarea.html

editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor): Changed paragraphStartIndex to be relative to the
root container of paragraphRange, using the same logic used by
checkForDifferentRootContainer() in Range.cpp.

LayoutTests:

platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt: Added.
platform/mac/editing/spelling/autocorrection-in-textarea.html: Added.

10:25 AM Changeset in webkit [132923] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new crashing tests to paint the bot green.

platform/qt/TestExpectations:

10:21 AM Changeset in webkit [132922] by commit-queue@webkit.org

9 edits in trunk/Source

Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975

Patch by Dan Carney <dcarney@google.com> on 2012-10-30
Reviewed by Adam Barth.

Source/WebCore:

Removed auxilliaryContext as use if it is problematic in IDB.

No new tests. No change in functionality.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):

Modules/indexeddb/IDBCursor.h:

(IDBCursor):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::put):
(WebCore):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):

bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):

bindings/v8/IDBBindingUtilities.h:

(WebCore):

bindings/v8/V8Binding.cpp:

(WebCore::toV8Context):
(WebCore):

bindings/v8/V8Binding.h:

(WebCore):

bindings/v8/V8PerIsolateData.cpp:

(WebCore):

bindings/v8/V8PerIsolateData.h:

Source/WebKit/chromium:

Updated tests to use correct v8 context.

tests/IDBBindingUtilitiesTest.cpp:

10:16 AM Changeset in webkit [132921] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed evening gardening, skip failing tests to paint the bot green.

platform/qt-5.0-wk2/TestExpectations:

10:08 AM Changeset in webkit [132920] by Alexandru Chiculita

10 edits
1 copy
1 add in trunk/Source/WebCore

[CSS Shaders] Add CustomFilterRenderer to reuse this class by Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=98989

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-30
Reviewed by Dean Jackson.

Extract CustomFilterRenderer class from the rendering part of FECustomFilter.
FECustomFilter now plays a role in extending FilterEffect and delegates
rendering CSS Shaders to CustomFilterRenderer.

CustomFilterRenderer does not know Filter and FilterEffect. We can
create a CustomFilterRenderer instance with only GraphicsContext3D and
CustomFilterValidatedProgram. It means that Accelerated Compositing can
create the CustomFilterRenderer instance if Accelerated Compositing has
GraphicsContext3D and CustomFilterOperation, and it is already possible.

This patch prepares to enable CSS Shaders on Accelerated Compositing.

No new tests. Covered by css3/filters/custom

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/CustomFilterRenderer.cpp: Added.

(WebCore):
(WebCore::orthogonalProjectionMatrix):
(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
(WebCore::CustomFilterRenderer::~CustomFilterRenderer):
(WebCore::CustomFilterRenderer::premultipliedAlpha):
(WebCore::CustomFilterRenderer::programNeedsInputTexture):
(WebCore::CustomFilterRenderer::draw):
(WebCore::CustomFilterRenderer::prepareForDrawing):
(WebCore::CustomFilterRenderer::initializeCompiledProgramIfNeeded):
(WebCore::CustomFilterRenderer::initializeMeshIfNeeded):
(WebCore::CustomFilterRenderer::bindVertexAttribute):
(WebCore::CustomFilterRenderer::unbindVertexAttribute):
(WebCore::CustomFilterRenderer::bindProgramArrayParameters):
(WebCore::CustomFilterRenderer::bindProgramNumberParameters):
(WebCore::CustomFilterRenderer::bindProgramTransformParameter):
(WebCore::CustomFilterRenderer::bindProgramParameters):
(WebCore::CustomFilterRenderer::bindProgramAndBuffers):
(WebCore::CustomFilterRenderer::unbindVertexAttributes):

platform/graphics/filters/CustomFilterRenderer.h: Copied from Source/WebCore/platform/graphics/filters/FECustomFilter.h.

(WebCore):
(CustomFilterRenderer):

CustomFilterRenderer renders custom filters in GPU using a
GraphicsContext3D.

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore::FECustomFilter::prepareForDrawing):
(WebCore::FECustomFilter::applyShader):
(WebCore::FECustomFilter::resolveMultisampleBuffer):
(WebCore::FECustomFilter::resizeMultisampleBuffers):
(WebCore::FECustomFilter::resizeContext):

platform/graphics/filters/FECustomFilter.h:

(WebCore):
(FECustomFilter):

rendering/FilterEffectRenderer.cpp:

(WebCore::createCustomFilterEffect):

10:08 AM Changeset in webkit [132919] by sergio@webkit.org

2 edits in trunk/Source/WebKit2

[WK2][Qt] Enable hover and mouse events in flickable WebView
https://bugs.webkit.org/show_bug.cgi?id=100296

Reviewed by Kenneth Rohde Christiansen.

Flickable WebView is now allowed to handle both hover and mouse
events. Flickable was initially meant to be the mobile interface and
was only handling touch events, but now the idea is that it will be
the WebView for both mobile and desktop environments.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize): refactored hover and mouse
event handling from children classes.
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):

9:49 AM Changeset in webkit [132918] by mkwst@chromium.org

17 edits in trunk/Source/WebCore

Web Inspector: Associate console messages with the requests that caused them.
https://bugs.webkit.org/show_bug.cgi?id=99941

Reviewed by Pavel Feldman.

The inspector currently supports the concept of a request's "initiator"
in order to add context to console messages that are generated in
response to a specific request. The initiator is used as the message's
anchor link iff a requestID is present, and no stack trace is present.

Currently, this functionality is only exposed to three specific
callsites: 'InspectorConsoleAgent::didFinishXHRLoading',
'InspectorConsoleAgent::didReceiveResponse', and
'InspectorConsoleAgent::didFailLoading'. This patch adds a generic
mechanism to associate requests with console messages by passing the
request's identifier through 'ScriptExecutionContext::addConsoleMessage'
or 'Console::addMessage' when relevant.

This patch should have no visible changes. It just installs some new
piping, and adjusts the three methods mentioned above to use it.
Existing tests shouldn't break.

dom/Document.cpp:

(WebCore::Document::addMessage):

dom/Document.h:

(Document):

Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
through to Console::addMessage.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::addConsoleMessage):

dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
through to the subclass' addMessage method.

inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

Accept an unsigned long instead of a string, and move the conversion
from WebCore request identifiers to Inspector request identifiers
into ConsoleMessage.

inspector/ConsoleMessage.h:

(ConsoleMessage):

Add 'requestIdentifier' (defaulting to 0) to the
ConsoleMessage constructor that accepts a ScriptCallStack (it was
already part of the constructor that accepted a line number).

inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::requestId):

If the provided request identifier is 0, return an empty string.
This simplifies the logic at the callsite.

inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
through to the 'ConsoleMessage' constructor after converting it to
an internal identifier via 'IdentifiersFactor::requestId'.

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

Use the new 'requestIdentifier' parameter on addMessageToConsole
rather than replicating the behavior in each of these three methods.

inspector/InspectorConsoleAgent.h:

(InspectorConsoleAgent):

Add a 'requestIdentifier' parameter (defaulting to 0).

inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
through to lower levels of the stack.

page/Console.cpp:

(WebCore::Console::addMessage):

page/Console.h:

(Console):

Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
through to 'InspectorInstrumentation::addMessageToConsole'.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):

workers/WorkerContext.h:

(WorkerContext):

Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
through to 'InspectorInstrumentation::addMessageToConsole'.

9:34 AM Changeset in webkit [132917] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][JHBUILD] Update EFL libraries to v1.7.1 stable release
https://bugs.webkit.org/show_bug.cgi?id=100759

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Update Bump EFL libraries to the new stable release (v1.7.1)
in JHBuild to pull the latest bug fixes.

efl/jhbuild.modules:

9:10 AM Changeset in webkit [132916] by andersca@apple.com

55 edits in trunk

String::createCFString should return a RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=100419

Reviewed by Andreas Kling.

Source/WebCore:

Update callers of String::createCFString.

bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):

platform/LocalizedStrings.cpp:

(WebCore::formatLocalizedString):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::keygenKeychainItemName):
(WebCore::imageTitle):

platform/RuntimeApplicationChecks.cpp:

(WebCore::mainBundleIsEqualTo):

platform/cf/FileSystemCF.cpp:

(WebCore::fileSystemRepresentation):
(WebCore::pathAsURL):

platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(PlatformCAAnimation::PlatformCAAnimation):

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(resubmitAllAnimations):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::removeAnimationForKey):
(PlatformCALayer::setName):

platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::updateTiles):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::utiFromMIMEType):

platform/graphics/cg/ImageSourceCGMac.mm:

(WebCore::MIMETypeForImageSourceType):
(WebCore::preferredExtensionForImageSourceType):

platform/mac/ClipboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):

platform/mac/SSLKeyGeneratorMac.cpp:

(WebCore::signedPublicKeyAndChallengeString):

platform/network/cf/AuthenticationCF.cpp:

(WebCore::createCF):

platform/network/cf/CookieJarCFNet.cpp:

(WebCore::setCookies):

platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformResolve):

platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::cfError):

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::setDefaultMIMEType):
(WebCore::willSendRequest):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):

platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::copyCFStreamDescription):

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForKey):

platform/text/cf/StringCF.cpp:

(WTF::String::createCFString):

platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString):

platform/text/mac/StringImplMac.mm:

(WTF::StringImpl::operator NSString *):

platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::encode):

platform/win/SearchPopupMenuWin.cpp:

(WebCore::autosaveKey):
(WebCore::SearchPopupMenuWin::saveRecentSearches):

Source/WebKit/cf:

Update callers of String::createCFString.

WebCoreSupport/WebInspectorClientCF.cpp:

(createKeyForPreferences):
(populateSetting):
(storeSetting):

Source/WebKit/win:

Update callers of String::createCFString.

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin):

WebDatabaseManager.cpp:

(WebDatabaseManager::dispatchDidModifyDatabase):

WebHistory.cpp:

(WebHistory::visitedURL):
(WebHistory::itemForURLString):

WebHistoryItem.cpp:

(WebHistoryItem::dictionaryRepresentation):

WebIconDatabase.cpp:

(WebIconDatabase::iconDatabaseNotificationUserInfoURLKey):
(postDidAddIconNotification):

WebLocalizableStrings.cpp:

(createWebKitBundle):
(copyLocalizedStringFromBundle):

WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

WebView.cpp:

(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):

Source/WebKit2:

Update callers of String::createCFString.

Platform/mac/ModuleMac.mm:

(WebKit::Module::load):

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeSandbox):

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::createPluginMIMETypesPreferences):

UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):

UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData):
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):

WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):

WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Make String::createCFString and StringImpl::createCFString return RetainPtrs.

wtf/text/AtomicString.h:
wtf/text/StringImpl.h:
wtf/text/WTFString.h:

Tools:

Update callers of String::createCFString.

WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:

(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):

9:02 AM Changeset in webkit [132915] by Chris Fleizach

20 edits
5 adds in trunk

AX: Support embedded SVG objects in AX tree
https://bugs.webkit.org/show_bug.cgi?id=97571

Reviewed by Tim Horton.

Source/WebCore:

This patch allows an SVG image from another resource to be hooked into the AX
hierarchy. This is done by creating an AX wrapper for the root SVG that holds onto
its native parent image. The SVGChromeClient is then used to connect to this SVG resource.

Test: accessibility/svg-remote-element.html

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

accessibility/AccessibilityAllInOne.cpp:
accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isAccessibilitySVGRoot):
(AccessibilityObject):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::offsetBoundingBoxForRemoteSVGElement):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::remoteSVGElementHitTest):
(WebCore::AccessibilityRenderObject::elementAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isSVGImage):
(WebCore::AccessibilityRenderObject::detachRemoteSVGRoot):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::addChildren):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

accessibility/AccessibilitySVGRoot.cpp: Added.

(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::~AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::create):
(WebCore::AccessibilitySVGRoot::parentObject):

accessibility/AccessibilitySVGRoot.h: Added.

(AccessibilitySVGRoot): Class provides ability to wrap the SVG root of a remote accessibility element.
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::isAccessibilitySVGRoot):
(WebCore::toAccessibilitySVGRoot):

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper position]): The position of AX elements within a remote SVG element needs to be handled
in a special manner.
(createAccessibilityRoleMap):

loader/EmptyClients.h:

(EmptyChromeClient): Expose isEmptyChromeClient() so Accessibility will know when to apply different policies for finding
the accessibility bounding rect of elements.
(WebCore::EmptyChromeClient::isEmptyChromeClient):

page/ChromeClient.h:

(WebCore::ChromeClient::isEmptyChromeClient):
(ChromeClient):

svg/graphics/SVGImage.cpp:
svg/graphics/SVGImageChromeClient.h: Added.

(SVGImageChromeClient): Expose the SVGImageChromeClient so that Accessibility can reference its image.
(WebCore::SVGImageChromeClient::SVGImageChromeClient):
(WebCore::SVGImageChromeClient::isSVGImageChromeClient):
(WebCore::SVGImageChromeClient::image):
(WebCore::SVGImageChromeClient::chromeDestroyed):
(WebCore::SVGImageChromeClient::invalidateContentsAndRootView):
(WebCore::toSVGImageChromeClient):

LayoutTests:

Added a new test that links in an svg file. Accessibility of that remote svg file is tested.
Test skipped on chromium until clickPoint() is implemented in DRT.

accessibility/svg-remote-element.html: Added.
accessibility/resources/svg-face.svg: Added.
platform/chromium/TestExpectations:
platform/mac/accessibility/svg-remote-element-expected.txt: Added.

8:50 AM Changeset in webkit [132914] by commit-queue@webkit.org

11 edits in trunk

[WK2][WTR] WebKitTestRunner needs testRunner.queueLoadHTMLString
https://bugs.webkit.org/show_bug.cgi?id=100747

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added testRunner.queueLoadHTMLString implementation.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::queueLoadHTMLString):
(WTR):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::queueLoadHTMLString):
(WTR):

WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

WebKitTestRunner/WorkQueueManager.cpp:

(WTR::WorkQueueManager::queueLoadHTMLString):
(WTR):

WebKitTestRunner/WorkQueueManager.h:

(WorkQueueManager):

LayoutTests:

Unskipped http/tests/navigation/go-back-to-error-page.html for WK2 ports.

platform/wk2/TestExpectations:

8:47 AM Changeset in webkit [132913] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

add 7 bit strings capabilities to the v8 binding layer
https://bugs.webkit.org/show_bug.cgi?id=91850

Patch by Dan Carney <dcarney@google.com> on 2012-10-30
Reviewed by Adam Barth.

This change enables the v8 binding layer to make use of webkit's
8 bit string capabilities. Using 8 bit strings leads to certain
benchmark performance improvemnts as can be seen in
https://bug-91850-attachments.webkit.org/attachment.cgi?id=163334.

No new tests. Test coverage already extensive.

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::visitExternalStrings):

bindings/v8/V8StringResource.cpp:

(StringTraits):
(WebCore::false):
(WebCore):
(WebCore::true):
(WebCore::v8StringToWebCoreString):

bindings/v8/V8ValueCache.cpp:

(WebCore::makeExternalString):
(WebCore::WebCoreStringResourceBase::visitStrings):

bindings/v8/V8ValueCache.h:

(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::memoryConsumption):

8:45 AM Changeset in webkit [132912] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Regression(r132647)-Enable WebGL in EwkView.
https://bugs.webkit.org/show_bug.cgi?id=100552.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

WebGL is enabled with following changeset: http://trac.webkit.org/changeset/132627.
Some changes are lost after the following changeset: http://trac.webkit.org/changeset/132647
i.e setWebGLEnabled(true); in EwkViewImpl.cpp.
This patch re-applies the lost changes.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

8:45 AM Changeset in webkit [132911] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[AC] Fix compilation warnings when enabling Accelerated Compositing
https://bugs.webkit.org/show_bug.cgi?id=100741

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Fix a few compilation warnings when building EFL port
with accelerated compositing enabled.

No new tests, no behavior change.

platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformLock):

platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

8:40 AM Changeset in webkit [132910] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Baseline search path should consider both WK1 and WK2 on layout test.
https://bugs.webkit.org/show_bug.cgi?id=100755

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Current implementation doesn't consider WK1 case in baseline search path.
Therefore, this patch fixes it.

Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.default_baseline_search_path):

8:32 AM Changeset in webkit [132909] by podivilov@chromium.org

1 edit
4 adds in trunk/LayoutTests

Unreviewed, rebaseline fast/sub-pixel/float-wrap-zoom.html.

platform/chromium-mac-lion/fast/sub-pixel/float-wrap-zoom-expected.png: Added.
platform/chromium-mac-snowleopard/fast/sub-pixel/float-wrap-zoom-expected.png: Added.
platform/chromium-mac/fast/sub-pixel/float-wrap-zoom-expected.png: Added.

7:14 AM Changeset in webkit [132908] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unreviewed, combine color profile failures to correct bug
https://bugs.webkit.org/show_bug.cgi?id=100746

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-30

platform/efl/TestExpectations:

7:11 AM Changeset in webkit [132907] by noam.rosenthal@nokia.com

5 edits in trunk/Source

[Qt] Animations jump when the page is suspended
https://bugs.webkit.org/show_bug.cgi?id=100673

Reviewed by Kenneth Rohde Christiansen.

GraphicsLayerAnimations::pause() should accept time from start and not an offset.

Source/WebCore:

We need to support the "freeze" API before this can be reliably tested.
See https://bugs.webkit.org/show_bug.cgi?id=100703.

platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::pause):

Source/WebKit2:

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

6:43 AM Changeset in webkit [132906] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt][EFL][AC] While Using WebGL, MiniBrowser segfaults on Refreshing the page.
https://bugs.webkit.org/show_bug.cgi?id=100639.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

TextureMapperSurfaceBackingStore can import textures from a GraphicSurface.
In such cases GraphicsSurfaceGLX creates an XPixmap to read texture content
from a given WindowId, but doesn't create any new window.
However, OffScreenRootWindow always tries to unmap window (in its destructor) resulting in segfault.
With this patch OffScreenRootWindow would check for a valid window before trying to unmap it.

platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::~OffScreenRootWindow):

6:37 AM Changeset in webkit [132905] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix EFL build after r132887
https://bugs.webkit.org/show_bug.cgi?id=100748

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Fixed EFL build failure with WTF_USE_TILED_BACKING_STORE enabled caused by http://trac.webkit.org/changeset/132887.

UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

6:36 AM Changeset in webkit [132904] by eae@chromium.org

3 edits
2 adds in trunk

[subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap
https://bugs.webkit.org/show_bug.cgi?id=100742

Reviewed by Levi Weintraub.

Source/WebCore:

As we no longer pixel snap values when computing the current width for a
line we should not do it in shrinkAvailableWidthForNewFloatIfNeeded
either.

Test: fast/sub-pixel/float-wrap-zoom.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth): Remove unnecessary ifdef.
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Use float values instead of pixel snapped/floored values as the line width calculations uses floats.

LayoutTests:

Add test for wrapping when combining float and inline elements.

fast/sub-pixel/float-wrap-zoom-expected.html: Added.
fast/sub-pixel/float-wrap-zoom.html: Added.

6:21 AM Changeset in webkit [132903] by commit-queue@webkit.org

31 edits
1 copy
1 add in trunk

[CSS Shaders] Reject vertex shaders with custom attributes
https://bugs.webkit.org/show_bug.cgi?id=98973

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-30
Reviewed by Dean Jackson.

Source/WebCore:

Improved CSS Custom Filters shader validation. With this patch:
(1) Shaders with custom attributes do not execute (e.g. attribute float my_attribute;).
(2) Shaders with a_triangleCoord defined do not execute with an attached mesh.

Most of the changes are from renaming CustomFilterOperation::MeshType to
CustomFilterMeshType, and moving the enumeration to CustomFilterConstants.h. This avoids
pulling in CustomFilterOperation for classes that only care about the mesh type.

Note that in CSS Custom Filters, the a_triangleCoord attribute is only available in detached
meshes. In detached meshes, no vertices are shared between triangles. Thus, each vertex
belongs to a specific triangle, which a_triangleCoord identifies. In attached meshes,
vertices can belong to many triangles, which a_triangleCoord cannot identify because it's
only a vec3.

Tests:
Add two new checks to the test file:

css3/filters/custom/invalid-custom-filter-attribute-types.html

Add two new shaders:

css3/filters/resources/invalid-custom-attribute.vs
css3/filters/resources/invalid-a-triangle-coord-with-attached-mesh.vs

WebCore.xcodeproj/project.pbxproj:

Update a broken reference to CustomFilterConstants.h in the Xcode project file.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

Replace CustomFilterOperation::MeshType with CustomFilterMeshType.

css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperation): Ditto.

platform/graphics/filters/CustomFilterConstants.h:

Add CustomFilterMeshType enum to share across the Custom Filters codebase, so that we
don't have to include CustomFilterOperation just to access the old
CustomFilterOperation::MeshType enum.

platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):

Replace CustomFilterOperation::MeshType with CustomFilterMeshType.

platform/graphics/filters/CustomFilterMesh.h:

(WebCore::CustomFilterMesh::create): Ditto.
(WebCore::CustomFilterMesh::meshType): Ditto.
(CustomFilterMesh): Ditto.

platform/graphics/filters/CustomFilterMeshGenerator.cpp: Ditto.

(WebCore::CustomFilterMeshGenerator::CustomFilterMeshGenerator): Ditto.
(WebCore::CustomFilterMeshGenerator::dumpBuffers): Ditto.

platform/graphics/filters/CustomFilterMeshGenerator.h:

(CustomFilterMeshGenerator): Ditto.
(WebCore::CustomFilterMeshGenerator::floatsPerVertex): Ditto.
(WebCore::CustomFilterMeshGenerator::verticesCount): Ditto.

platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::CustomFilterOperation::CustomFilterOperation): Ditto.

platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::create): Ditto.
(WebCore::CustomFilterOperation::meshType): Ditto.
(CustomFilterOperation): Ditto.

platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::CustomFilterProgram):

Add a meshType constructor parameter because the program now needs to know the meshType
to properly validate.

(WebCore::CustomFilterProgram::programInfo):

Pass meshType to CustomFilterProgram constructor.

(WebCore::CustomFilterProgram::operator==):

Check the meshType in the equals operator.

platform/graphics/filters/CustomFilterProgram.h:

Make vertexShaderString() and fragmentShaderString() public so that we don't have to ask
for a programInfo object just to get the shader strings in
CoordinatedGraphicsArgumentCoders.cpp.

platform/graphics/filters/CustomFilterProgramInfo.cpp:

(WebCore::CustomFilterProgramInfo::CustomFilterProgramInfo):

Add a meshType constructor parameter.

(WebCore::CustomFilterProgramInfo::hash):

Include the meshType in the validated program hash, since the same shader code can pass
or fail validation based on the meshType.

(WebCore::CustomFilterProgramInfo::operator==):

Check the meshType in the equals operator.

platform/graphics/filters/CustomFilterProgramInfo.h:

(CustomFilterProgramInfo):

Update method prototype.

(WebCore::CustomFilterProgramInfo::meshType):

Add meshType getter.

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::validateSymbols):

If the author defines attribute that is is not found in the built-in attribute map,
reject the shader.
If the author defines a_triangleCoord without a detached mesh type, reject the shader.
Also, make this previously file-static function into a method of
CustomFilterValidatedProgram because it now needs to access the m_meshType.

platform/graphics/filters/CustomFilterValidatedProgram.h:

(CustomFilterValidatedProgram):

Add a meshType constructor parameter because the program now needs to know the meshType
to properly validate.

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):

Replace CustomFilterOperation::MeshType with CustomFilterMeshType.

(WebCore::FECustomFilter::create): Ditto.
(WebCore::FECustomFilter::bindProgramAndBuffers): Ditto.
(WebCore::FECustomFilter::unbindVertexAttributes): Ditto.

platform/graphics/filters/FECustomFilter.h:

(FECustomFilter): Ditto.

rendering/style/StyleCustomFilterProgram.h:

(WebCore::StyleCustomFilterProgram::create):

Add a meshType constructor parameter.

(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram): Ditto.

Source/WebKit2:

Replace CustomFilterOperation::MeshType with CustomFilterMeshType from
CustomFilterConstants.h.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):

Read the shader strings directly from the CustomFilterProgram instead of asking for a
CustomFilterProgramInfo object. Also, encode the meshType earlier so that decoding can
can use it to create a WebCustomFilterProgram, which now requires a meshType.

(CoreIPC::::decode):

Decode the meshType earlier to pass it to the new WebCustomFilterProgram constructor.

Shared/CoordinatedGraphics/WebCustomFilterProgram.h:

(WebKit::WebCustomFilterProgram::create):

Add a meshType parameter to pass to the base class constructor.

(WebKit::WebCustomFilterProgram::WebCustomFilterProgram): Ditto.

LayoutTests:

Add checks to verify:
(1) Shaders with custom attributes do not execute (e.g. attribute float my_attribute;).
(2) Shaders with a_triangleCoord defined do not execute with an attached mesh.

CSS Filters Spec, Vertex Attributes:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#vertex-attribute-variables

css3/filters/custom/invalid-custom-filter-attribute-types-expected.html:
css3/filters/custom/invalid-custom-filter-attribute-types.html:

Add two checks for two new vertex shaders. Update the a_triangleCoord type check to use
a detached mesh, so the vertex shader fails to validate because a_triangleCoord is
defined with an incorrect type, not because it defines a_triangleCoord in an attached
mesh.

css3/filters/resources/invalid-a-triangle-coord-with-attached-mesh.vs:

Added. This vertex shader defines a_triangleCoord with the correct type. However, this
shader is run with an an attached mesh, so it should not execute.

css3/filters/resources/invalid-custom-attribute.vs:

Added. This vertex shader defines a custom attribute. The associated test verifies
that it does not execute.

css3/filters/resources/invalid-type-a-mesh-coord.vs:

Remove some empty lines to improve readability.

css3/filters/resources/invalid-type-a-position.vs: Ditto.
css3/filters/resources/invalid-type-a-tex-coord.vs: Ditto.
css3/filters/resources/invalid-type-a-triangle-coord.vs:

Add a comment that this shader should be run with a detached mesh.

css3/filters/resources/invalid-type-attribute-array.vs:

Remove some empty lines to improve readability.

css3/filters/resources/invalid-type-a-triangle-coord.vs: Ditto.

6:14 AM FeatureFlags edited by tkent@chromium.org

Remove INPUT_TYPE_DATE_LEGACY_UI (diff)

6:13 AM Changeset in webkit [132902] by commit-queue@webkit.org

5 edits
2 adds in trunk

Web Inspector: adds isOwnProperty to remote protocol
https://bugs.webkit.org/show_bug.cgi?id=100664

Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-10-30
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/runtime/runtime-getProperties-isOwnProperty.html

Adds requested 'isOwn' property to the 'PropertyDescriptor' class of the
remote debugging protocol.

inspector/InjectedScriptSource.js:

(.):

inspector/Inspector.json:

LayoutTests:

inspector/runtime/runtime-getProperties-isOwnProperty-expected.txt: Added.
inspector/runtime/runtime-getProperties-isOwnProperty.html: Added.

5:37 AM Changeset in webkit [132901] by podivilov@chromium.org

1 edit
5 adds in trunk/LayoutTests

Unreviewed, add baselines for exif-orientation-image-document.

platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.

5:35 AM Changeset in webkit [132900] by commit-queue@webkit.org

6 edits in trunk

[QT][DRT] Remove unneeded testRunner.setMediaType() implementation
https://bugs.webkit.org/show_bug.cgi?id=100740

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Removed unneeded testRunner.setMediaType() implementation, as tests use
cross-platform window.internals.settings.setMediaTypeOverride instead.

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

5:34 AM Changeset in webkit [132899] by podivilov@chromium.org

1 edit
1 move in trunk/LayoutTests

Unrewieved, rebaseline audiobuffersource-loop-points.

platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav: Renamed from LayoutTests/platform/chromium-win-xp/webaudio/audiobuffersource-loop-points-expected.wav.

5:32 AM Changeset in webkit [132898] by abecsi@webkit.org

5 edits in trunk/Source/WebKit2

[Qt][WK2] Remove ViewportUpdateDeferrer from PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=100665

Reviewed by Jocelyn Turcotte.

Since the original use case of delayed viewport updates and the issue
of infinite loop conditions between the programmatic adjustmet of the
viewport and the Qt notification signals are not present any more the
ViewportUpdateDeferrer became an unnecessary legacy and can be removed.

UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageDidRequestScroll):

UIProcess/PageViewportController.h:

(WebKit):
(PageViewportController):

UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):

UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

5:23 AM Changeset in webkit [132897] by zeno.albisser@digia.com

2 edits in trunk/Source/WebCore

[Qt][Win] BitmapTextureGL::updateContents() broken after r132019.
https://bugs.webkit.org/show_bug.cgi?id=100680

When creating a temporary for swizzling the image data,
the temporary will have the target size.
Therefore no offset within the available image data
shall be applied in this case.

Reviewed by Noam Rosenthal.

platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

5:10 AM Changeset in webkit [132896] by tkent@chromium.org

22 edits in trunk/Source

Remove unused code for old input[type=date] UI
https://bugs.webkit.org/show_bug.cgi?id=100734

Reviewed by Hajime Morita.

Source/WebCore:

The old input[type=date] UI used in Google Chrome 20-23 (text field with
a fixed placeholder) was replaced with ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests because of no behavior changes.

html/DateInputType.cpp: Remove ENABLE_INPUT_TYPE_DATE_LEGACY_UI code path.
html/DateInputType.h: Ditto.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::supportsPlaceholder):
Remove fixed-placeholder feature.

html/HTMLInputElement.h:

(HTMLInputElement): Ditto.

html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement): isPlaceholderEmpty() is not needed to be virtual

html/InputType.cpp: Remove fixed-placeholder feature.
html/InputType.h: Ditto.
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText): Ditto.

platform/text/PlatformLocale.h:

(Locale): Remove dateFormatText.

platform/text/LocaleICU.cpp: Ditto.
platform/text/LocaleICU.h: Ditto.
platform/text/LocaleNone.cpp: Ditto.
platform/text/mac/LocaleMac.h: Ditto.
platform/text/mac/LocaleMac.mm: Ditto.
platform/text/win/LocaleWin.cpp: Ditto.
platform/text/win/LocaleWin.h: Ditto.
platform/LocalizedStrings.h:

(WebCore): Remove unused functions; calendarTodayText,
calendarClearText, dateFormatYearText, dateFormatMonthText,
dateFormatDayInMonthText

Source/WebKit/chromium:

src/LocalizedStrings.cpp:

Follow the LocalizedStrings.h change.

tests/LocaleMacTest.cpp:

(LocaleMacTest): Remove tests for Locale::dateFormatText.

tests/LocaleWinTest.cpp:

(LocaleWinTest): Ditto.

5:07 AM Changeset in webkit [132895] by tkent@chromium.org

13 edits
2 adds in trunk

Fix crash by calendar picker or suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=100728

Reviewed by Hajime Morita.

Source/WebCore:

Change DateTimeChooser so that it is ref-coutned.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange.html

platform/DateTimeChooser.h: Made DateTimeChooser RefCounted.
page/ChromeClient.h:

(ChromeClient): openDateTimeChooser should return PassRefPtr<DateTimeChooser>.

loader/EmptyClients.h:

(EmptyChromeClient): Follow the above change.

loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::openDateTimeChooser): Ditto.

html/shadow/PickerIndicatorElement.h:

(PickerIndicatorElement): Hold DateTimeChooser in RefPtr<DateTimeChooser>.

html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::PickerIndicatorElement):
Remove unnecessary initialization.

Source/WebKit/chromium:

src/DateTimeChooserImpl.h:

(DateTimeChooserImpl): Add a factory function, and made the constructor private.

src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::create): Added.
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
Protect this because JavaScript code might run during didChooseValue.

src/ChromeClientImpl.h:

(ChromeClientImpl): Follow the ChromeClient change.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::openDateTimeChooser):
Use DateTimeChooserImpl::create.

LayoutTests:

platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange.html: Added.

5:01 AM Changeset in webkit [132894] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Web Inspector: Timeline: promote "cpu activity" out of experiment
https://bugs.webkit.org/show_bug.cgi?id=100726

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-30
Reviewed by Pavel Feldman.

CPU actibity bars redesigned
Experiment setting removed
Feature setting added

English.lproj/localizedStrings.js: Updated setting label.
inspector/front-end/Settings.js: Replaced experiment with setting.
inspector/front-end/SettingsScreen.js: Added new setting.
inspector/front-end/TimelinePanel.js: Update cpu bars appearance.
inspector/front-end/timelinePanel.css: Ditto.

4:36 AM Changeset in webkit [132893] by mrowe@apple.com

2 edits in trunk/Source/WTF

Fix WTF to not install a few header files in bogus locations.

WTF.xcodeproj/project.pbxproj:

4:23 AM Changeset in webkit [132892] by Michelangelo De Simone

12 edits
1 delete in trunk

[CSS Shaders] Change the default compositing mode and the default CSS value for <fragmentShader>
https://bugs.webkit.org/show_bug.cgi?id=94020

Reviewed by Dean Jackson.

Source/WebCore:

The default compositing mode has been changed from "normal source-over" to
"normal source-atop". This applies to the default fragment shader that will
kick in when there is no explicit fragment shader or mix function defined.

This has required to update all the existing tests; the dummy empty fragment
shader has also been removed because not needed.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter): An existence check
for the fragment shader has been added.

css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperation): The default program
has been updated: PROGRAM_TYPE_BLENDS_TEXTURE (compositing enabled) now is
the default.

platform/graphics/filters/CustomFilterProgramInfo.h:

(WebCore::CustomFilterProgramMixSettings::CustomFilterProgramMixSettings):
New CustomFilterProgramMixSettings defaults to "source-atop" composite
operator.

LayoutTests:

Existing tests have been modified to update them to the new default
compositing values (normal source-atop).

Also, the dummy empty shader has been removed: not needed.

css3/filters/custom/custom-filter-property-computed-style-expected.txt:
css3/filters/custom/custom-filter-shader-cache.html:
css3/filters/custom/effect-custom-transform-parameters.html:
css3/filters/custom/effect-custom.html:
css3/filters/custom/filter-fallback-to-software.html:
css3/filters/resources/empty-shader.fs: Removed.
css3/filters/script-tests/custom-filter-property-computed-style.js:

4:04 AM Changeset in webkit [132891] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

[Qt][Mac] Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=100727.

Speculative build fix after 132858. Include missing CoreFoundation/CoreFoundation.h header.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-10-30

platform/text/cf/AtomicStringCF.cpp:

3:50 AM Changeset in webkit [132890] by rgabor@webkit.org

2 edits in trunk/Source/WebCore

Optimize vclip for NEON in VectorMath
https://bugs.webkit.org/show_bug.cgi?id=100737

Reviewed by Zoltan Herczeg.

Speed up vclip in VectorMath with NEON intrinsics.

platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vclip):

3:33 AM Changeset in webkit [132889] by Alexandru Chiculita

4 edits in trunk/Source/WebCore

[CSS Shaders] Software and composited filters should have a common path
https://bugs.webkit.org/show_bug.cgi?id=100532

Reviewed by Dean Jackson.

Added computeFilterOperations as a common method between the software filters
and hardware composited ones. The method rejects custom filters that are not
loaded yet. In bug 100533 it will also convert the CustomFilterOperation to a
ValidatedCustomFilterOperation. That will help us keep the loading and verification
code for the custom filters common across all the ports.

No new tests, just refactoring existing code.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeFilterOperations):
(WebCore):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):

rendering/RenderLayer.h:

(WebCore):
(RenderLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateFilters):

3:31 AM Changeset in webkit [132888] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: Implement native memory snapshot grid view
https://bugs.webkit.org/show_bug.cgi?id=100656

Native memory snapshots are now shown as an expandable tree form
using the grid control.

Patch by Alexei Filippov <alph@chromium.org> on 2012-10-30
Reviewed by Yury Semikhatsky.

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeSnapshotDataGrid):
(WebInspector.NativeSnapshotNode):
(WebInspector.NativeSnapshotNode.prototype.createCell):
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):
(WebInspector.NativeSnapshotNode.prototype._populate):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.MemoryBlockViewProperties._forMemoryBlock):

inspector/front-end/dataGrid.css:

(.data-grid td):

inspector/front-end/nativeMemoryProfiler.css:

(.memory-bar-chart-bar):
(.native-snapshot-view):
(.native-snapshot-view.visible):
(.native-snapshot-view .data-grid):
(.native-snapshot-view .data-grid table):
(.native-snapshot-view .data-grid div.size-text):
(.native-snapshot-view .data-grid div.size-bar):
(.native-snapshot-view .data-grid div.percent-text):

2:58 AM Changeset in webkit [132887] by rakuco@webkit.org

10 edits
1 add in trunk/Source/WebKit2

[EFL][WK2] Simplify signal emitting API in EwkViewImpl
https://bugs.webkit.org/show_bug.cgi?id=100506

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Now signal emitting API in EwkViewImpl is simplified so that
there is one EwkViewImpl::smartCallback template method
returning EwkViewCallbacks::CallBack class instance
which encapsulates Ewk_view callback info and also provide
arguments type checking.

UIProcess/API/efl/EwkViewCallbacks.h: Added.

(EwkViewCallbacks):
(CallBackInfo):
(EwkViewCallbacks::CallBackInfo::name):
(EwkViewCallbacks::CallBackInfo::hasArguments):
(CallBack):
(EwkViewCallbacks::CallBack::CallBack):
(EwkViewCallbacks::CallBack::call):

UIProcess/API/efl/EwkViewImpl.cpp:
UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):
(EwkViewImpl::smartCallback):

UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):

UIProcess/efl/FindClientEfl.cpp:

(WebKit::FindClientEfl::didFindString):
(WebKit::FindClientEfl::didFailToFindString):

UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::willSubmitForm):

UIProcess/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::toolTipChanged):

UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didChangeProgress):
(WebKit::PageLoadClientEfl::didFinishLoadForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::didChangeBackForwardList):

UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):

UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):
(WebKit::ResourceLoadClientEfl::ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::~ResourceLoadClientEfl):

2:43 AM Changeset in webkit [132886] by commit-queue@webkit.org

5 edits in trunk

3d rotation with [0, 0, 0] direction vector should not be applied
https://bugs.webkit.org/show_bug.cgi?id=100733

Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-10-30
Reviewed by Levi Weintraub.

Source/WebCore:

As stated in the specification (http://dev.w3.org/csswg/css3-3d-transforms/#transform-functions),
a direction vector that cannot be normalized, such as [0, 0, 0], will cause the rotation to not be applied,
but webkit applies it with [1, 0, 0] direction vector.

Test: transforms/3d/general/3dtransform-values.html

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::rotate3d):

LayoutTests:

Add test for 3d rotation with [0, 0, 0] direction vector.

transforms/3d/general/3dtransform-values-expected.txt:
transforms/3d/general/3dtransform-values.html:

2:40 AM Changeset in webkit [132885] by commit-queue@webkit.org

4 edits in trunk

[EFL][DRT] Bitmap should show whole view area.
https://bugs.webkit.org/show_bug.cgi?id=100642

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Tools:

css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
This is because current create bitmap implementation refers to geometry position that considers scroll movement even though
paint does it. Therefore, this patch always reflects current view size and remove duplicated graphic operation to dump correct bitmap image.

DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

LayoutTests:

Unskip css sticky position as well as scroll and fixed position related test cases.

platform/efl-wk1/TestExpectations:

2:15 AM Changeset in webkit [132884] by yurys@chromium.org

3 edits in trunk/Source/WebCore

Memory instrumentation: report actual object address for CachedResourceClients
https://bugs.webkit.org/show_bug.cgi?id=100659

Reviewed by Alexander Pavlov.

Skipped pointers to objects that are not allocated on the heap directly.

To test this we need to compare addresses of objects traversed by the memory
insrumentation with those allocated by the memory allocator. The latter set
should include the former one.

css/StyleResolver.cpp:

(WTF): skip pointers to RuleData structures as they are stored by value in RuleSet
objects and should not be reported separately.

loader/cache/CachedResource.cpp:

(WTF): do not report memory occupied by CachedResourceClients as objects implementing
the interface may have address which differ from CachedResourceClient*. The clients
should be reachable from their instrumented owners where we know exact type of the
clients and hence can figure correct address.

2:15 AM Changeset in webkit [132883] by jocelyn.turcotte@digia.com

2 edits in trunk/Source/WebKit2

Coordinated Graphics: Unrelease adopted images
https://bugs.webkit.org/show_bug.cgi?id=100671

Reviewed by Kenneth Rohde Christiansen.

Reloading could cause a crash since r132640 where the directly composited
image would be re-adopted with the same key before it was properly released
in the UI process.
Cancel the release when this happens rather than creating a new image.

WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):

2:07 AM Changeset in webkit [132882] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Unskip sputnik flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=100732

Unreviewed, EFL gardening.

These tests are always passing now.

sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A5.html
sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A6.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.1_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.4_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.1_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.4_T2.html

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-30

platform/efl-wk2/TestExpectations:

2:00 AM Changeset in webkit [132881] by commit-queue@webkit.org

5 edits in trunk

[EFL] Refactor tooltip callback signal in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=100571

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Separate tooltip callback signal into 'tooltip,text,set'
and 'tooltip,text,unset' to be consistent with WebKit2.

Source/WebKit/efl:

ewk/ewk_view.cpp:

(ewk_view_tooltip_text_set):

ewk/ewk_view.h:

Tools:

EWebLauncher/main.c:

(on_tooltip_text_set):
(on_tooltip_text_unset):
(browserCreate):

1:54 AM Changeset in webkit [132880] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[EFL][WK2] Let Ecore_Evas own the cursor object
https://bugs.webkit.org/show_bug.cgi?id=100731

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Ecore_Evas takes care of calling evas_object_del() on
the cursor object when it is no longer used (e.g. when
it is replaced by another cursor object). Therefore,
we don't need to keep a RefPtr to the cursor Evas
Object as a data member of EwkViewImpl. We pass
ownership of the cursor object to Ecore_Evas.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::setCursor):

UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

1:43 AM Changeset in webkit [132879] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[EFL][WK2] Simplify getting impl from ewk_view evas object instance
https://bugs.webkit.org/show_bug.cgi?id=100505

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Macros are removed from EwkViewImpl.h. New macro added to EwkViewImpl.cpp
so that it's possible to get impl directly from ewk view.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::displayTimerFired):

UIProcess/API/efl/EwkViewImpl.h:
UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(mapToWebContent):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(ewk_view_context_get):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_icon_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

1:33 AM Changeset in webkit [132878] by commit-queue@webkit.org

2 edits in trunk

Add files generated by Windows to ignore list for git repository
https://bugs.webkit.org/show_bug.cgi?id=100729

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Adding the additional files generated by windows port to the ignore list

.gitignore:

1:02 AM Changeset in webkit [132877] by thakis@chromium.org

2 edits
2 adds in trunk/LayoutTests

Add a test for reading exif orientation off image documents
https://bugs.webkit.org/show_bug.cgi?id=100698

Reviewed by Eric Seidel.

fast/images/exif-orientation.html tests <img> elements, but image documents were untested previously.

fast/images/exif-orientation-image-document.html: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/images/exif-orientation-image-document-expected.txt: Added.

12:47 AM Changeset in webkit [132876] by Carlos Garcia Campos

2 edits in trunk

[GTK] Add a configure option to build with -g1
https://bugs.webkit.org/show_bug.cgi?id=100670

Reviewed by Martin Robinson.

Add min and full options to the --enable-debug-symbols configure
option. Using --enable-debug-symbols=min will use -g1 instead of
-g (which is actually -g2). The first level is enough for most of
the cases, like getting a backtrace, and it's the only way to
build WebKit with debug symbols in a 32 bit system. The option
full is actually the same than yes for backwards compatibility.

configure.ac:

12:36 AM Changeset in webkit [132875] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[WK2] Remove incorrect use of preprocessor macro in API headers.
https://bugs.webkit.org/show_bug.cgi?id=100722

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Remove the preprocessor macro ENABLE(INSPECTOR) from the WKAPICast.h
and WKInspector.h.

UIProcess/API/C/WKAPICast.h:

(WebKit):

UIProcess/API/C/WKInspector.cpp:

(WKInspectorGetTypeID):
(WKInspectorGetPage):
(WKInspectorIsVisible):
(WKInspectorIsFront):
(WKInspectorShow):
(WKInspectorClose):
(WKInspectorShowConsole):
(WKInspectorShowResources):
(WKInspectorShowMainResourceForFrame):
(WKInspectorIsAttached):
(WKInspectorAttach):
(WKInspectorDetach):
(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):
(WKInspectorIsProfilingPage):
(WKInspectorTogglePageProfiling):

UIProcess/API/C/WKInspector.h:

12:00 AM Changeset in webkit [132874] by shinyak@chromium.org

5 edits in trunk/Source/WebCore

[Refatoring] Remove ElementShadow::insertionPointFor
https://bugs.webkit.org/show_bug.cgi?id=100625

Reviewed by Hajime Morita.

Now that ElementShadow::insertionPointFor does not do any special things, and it's only used in
ComposedShadowTreeWalker. So we can remove it.

No new tests, simple refactoring.

dom/ComposedShadowTreeWalker.cpp:

(WebCore::resolveReprojection):
(WebCore::AncestorChainWalker::parent):

dom/ElementShadow.cpp:
dom/ElementShadow.h:

(ElementShadow):

dom/ShadowRoot.h: ShadowRoot has insertionPointFor declaration, but we don't have any implementation.

We should remove it.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed