Context Navigation

← Previous Period
Next Period →

Timeline

Nov 2, 2012:

11:40 PM Changeset in webkit [133392] by shinyak@chromium.org

9 edits
2 adds in trunk

[Shadow] ShadowRoot should be able to know the existence of <content>
https://bugs.webkit.org/show_bug.cgi?id=100921

Reviewed by Dimitri Glazkov.

Source/WebCore:

When <content> is inserted into or removed from a shadow subtree, ShadowRoot counts the number of <content>.
It provides O(1) method to check the existence of <content>.

This is necessary when we implement a fast checking path for distribution invalidation when an element attribute
is changed. Larger context is explained in Bug 100451.

Test: fast/dom/shadow/has-content-elements.html

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::hasInsertionPoint): Since we track both <content> and <shadow>, we don't need to traverse
all the descendants of ShadowRoot anymore.

dom/ShadowRoot.h:

(WebCore::ShadowRoot::registerContentElement):
(WebCore::ShadowRoot::unregisterContentElement):
(WebCore::ShadowRoot::hasContentElement):
(ShadowRoot):

html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::insertedInto): When <content> is inserted into ShadowDOM subtree,
we notify it to the ShadowRoot. Note that only active <content> element is counted.
(WebCore):
(WebCore::HTMLContentElement::removedFrom):

html/shadow/HTMLContentElement.h:

(HTMLContentElement):

testing/Internals.cpp:

(WebCore::Internals::hasContentElement):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

LayoutTests:

fast/dom/shadow/has-content-elements-expected.txt: Added.
fast/dom/shadow/has-content-elements.html: Added.

11:29 PM Changeset in webkit [133391] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

sCurrentPaintTimeStamp is not initialized when FrameView::paintContents returns in the middle
https://bugs.webkit.org/show_bug.cgi?id=99990

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Darin Adler.

Move initialization code for sCurrentPaintTimeStamp to the below of early returns,
because it was not reset after early return.

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

11:26 PM Changeset in webkit [133390] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix build warning in PluginView.cpp on release build
https://bugs.webkit.org/show_bug.cgi?id=101049

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Kentaro Hara.

The protocol, host, port parameters are not used when LOG_DISABLED
Use UNUSED_PARAM macro for removing -Wunused-parameter warning

plugins/PluginView.cpp:

(WebCore::PluginView::getAuthenticationInfo):

9:38 PM Changeset in webkit [133389] by Martin Robinson

12 edits in trunk/Source

[GTK] Move soup authentication from GtkAuthenticationDialog to WebCore
https://bugs.webkit.org/show_bug.cgi?id=99914

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Move the actual soup authentication code from the GtkAuthenticationDialog to ResourceHandleSoup.
This allows a more generic implementation of authentication, for example, one where a WebKit2
client can completely handle authentication.

No new tests. This does not change behavior.

platform/gtk/GtkAuthenticationDialog.cpp: Remove references to the SoupPasswordManager, which

is going away in the next release of Gnome. Instead we always assume that the authentication backend has
support for remembering passwords and pass that information along with the answer to the authentication
request.

The rest of the changes to this class can be summarized as:

Getting the information from the AuthenticationChallenge instead of directly from the libsoup objects.
Using the AuthenticationClient to accomplish the authentication instead of talking to libsoup directly.

platform/gtk/GtkAuthenticationDialog.h:

(GtkAuthenticationDialog): Remove members which are no longer used.

platform/network/ResourceHandle.h:

(ResourceHandle): ResourceHandleSoup now implements the entire AuthenticationClient interface.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveAuthenticationChallenge): Don't handle authentication
for synchronous handles.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Now set the current challenge on
the internal data structure.
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): Added.
(WebCore::ResourceHandle::receivedCredential): Added.
(WebCore::ResourceHandle::receivedCancellation): Added.
(WebCore::authenicateCallback): Pass the handle as the authentication client.

Source/WebKit/gtk:

The calls which actually authenticate a soup message are gone from the GtkAuthenticationDialog. Since the
GtkAuthenticationDialog exposed by the WebKitSoupAuthentication class in the GTK+ API work without a
ResourceHandle (they are more general), we add a WebKitSoupAuthDialogAuthenticationClient added to avoid
breaking API. This is unused by either Epiphany or internally in WebKitGTK+.

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): The authentication dialog
now just takes the AuthenticationChallenge instead of the libsoup objects.

webkit/webkitsoupauthdialog.cpp:

(WebKitSoupAuthDialogAuthenticationClient): Added this helper.
(sessionAuthenticate): Use the new WebKitSoupAuthDialogAuthenticationClient.

Source/WebKit2:

Instead of passing the libsoup objects to the GtkAuthenticationDialog, pass the
AuthenticationChallenge itself.

WebProcess/WebCoreSupport/gtk/WebFrameLoaderClientGtk.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):

9:24 PM Changeset in webkit [133388] by mitz@apple.com

5 copies
1 add in releases/Apple/Safari 6.0.2

Added a tag for the Safari 6.0.2 release.

Safari 6.0.2 includes JavaScriptCore-x536.26.15, WebCore-x536.26.15, WebKit-x536.26.17, and WebKit2-x536.26.17.

8:32 PM Changeset in webkit [133387] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Improve CSSParser::setupParser() since the prefix/suffix are literals
https://bugs.webkit.org/show_bug.cgi?id=101107

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-11-02
Reviewed by Andreas Kling.

css/CSSParser.cpp:

(WebCore::CSSParser::setupParser):

css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::setupParser):
CSSParser::setupParser() is only used with literals prefix and suffix. We do not have
to compute the length at runtime, we can direclty encode it in the binary.

6:48 PM Changeset in webkit [133386] by commit-queue@webkit.org

10 edits
66 deletes in trunk

Unreviewed, rolling out r133375.
http://trac.webkit.org/changeset/133375
https://bugs.webkit.org/show_bug.cgi?id=101138

Caused 3 tests to fail on Mac (Requested by aboxhall-laptop on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02

Source/WebCore:

platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):

platform/text/TextBreakIterator.h:

(WebCore):
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):

platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

rendering/RenderText.h:

(WebCore):

rendering/break_lines.cpp:

(WebCore):
(WebCore::isBreakableSpace):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

rendering/break_lines.h:

(WebCore):
(WebCore::isBreakable):

LayoutTests:

css3/line-break/line-break-auto-centered-expected.html: Removed.
css3/line-break/line-break-auto-centered.html: Removed.
css3/line-break/line-break-auto-half-kana-expected.html: Removed.
css3/line-break/line-break-auto-half-kana.html: Removed.
css3/line-break/line-break-auto-hyphens-expected.html: Removed.
css3/line-break/line-break-auto-hyphens.html: Removed.
css3/line-break/line-break-auto-inseparables-expected.html: Removed.
css3/line-break/line-break-auto-inseparables.html: Removed.
css3/line-break/line-break-auto-iteration-marks-expected.html: Removed.
css3/line-break/line-break-auto-iteration-marks.html: Removed.
css3/line-break/line-break-auto-postfixes-expected.html: Removed.
css3/line-break/line-break-auto-postfixes.html: Removed.
css3/line-break/line-break-auto-prefixes-expected.html: Removed.
css3/line-break/line-break-auto-prefixes.html: Removed.
css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
css3/line-break/line-break-auto-sound-marks.html: Removed.
css3/line-break/line-break-loose-centered-expected.html: Removed.
css3/line-break/line-break-loose-centered.html: Removed.
css3/line-break/line-break-loose-half-kana-expected.html: Removed.
css3/line-break/line-break-loose-half-kana.html: Removed.
css3/line-break/line-break-loose-hyphens-expected.html: Removed.
css3/line-break/line-break-loose-hyphens.html: Removed.
css3/line-break/line-break-loose-inseparables-expected.html: Removed.
css3/line-break/line-break-loose-inseparables.html: Removed.
css3/line-break/line-break-loose-iteration-marks-expected.html: Removed.
css3/line-break/line-break-loose-iteration-marks.html: Removed.
css3/line-break/line-break-loose-postfixes-expected.html: Removed.
css3/line-break/line-break-loose-postfixes.html: Removed.
css3/line-break/line-break-loose-prefixes-expected.html: Removed.
css3/line-break/line-break-loose-prefixes.html: Removed.
css3/line-break/line-break-loose-sound-marks-expected.html: Removed.
css3/line-break/line-break-loose-sound-marks.html: Removed.
css3/line-break/line-break-normal-centered-expected.html: Removed.
css3/line-break/line-break-normal-centered.html: Removed.
css3/line-break/line-break-normal-half-kana-expected.html: Removed.
css3/line-break/line-break-normal-half-kana.html: Removed.
css3/line-break/line-break-normal-hyphens-expected.html: Removed.
css3/line-break/line-break-normal-hyphens.html: Removed.
css3/line-break/line-break-normal-inseparables-expected.html: Removed.
css3/line-break/line-break-normal-inseparables.html: Removed.
css3/line-break/line-break-normal-iteration-marks-expected.html: Removed.
css3/line-break/line-break-normal-iteration-marks.html: Removed.
css3/line-break/line-break-normal-postfixes-expected.html: Removed.
css3/line-break/line-break-normal-postfixes.html: Removed.
css3/line-break/line-break-normal-prefixes-expected.html: Removed.
css3/line-break/line-break-normal-prefixes.html: Removed.
css3/line-break/line-break-normal-sound-marks-expected.html: Removed.
css3/line-break/line-break-normal-sound-marks.html: Removed.
css3/line-break/line-break-strict-centered-expected.html: Removed.
css3/line-break/line-break-strict-centered.html: Removed.
css3/line-break/line-break-strict-half-kana-expected.html: Removed.
css3/line-break/line-break-strict-half-kana.html: Removed.
css3/line-break/line-break-strict-hyphens-expected.html: Removed.
css3/line-break/line-break-strict-hyphens.html: Removed.
css3/line-break/line-break-strict-inseparables-expected.html: Removed.
css3/line-break/line-break-strict-inseparables.html: Removed.
css3/line-break/line-break-strict-iteration-marks-expected.html: Removed.
css3/line-break/line-break-strict-iteration-marks.html: Removed.
css3/line-break/line-break-strict-postfixes-expected.html: Removed.
css3/line-break/line-break-strict-postfixes.html: Removed.
css3/line-break/line-break-strict-prefixes-expected.html: Removed.
css3/line-break/line-break-strict-prefixes.html: Removed.
css3/line-break/line-break-strict-sound-marks-expected.html: Removed.
css3/line-break/line-break-strict-sound-marks.html: Removed.
platform/chromium-linux/css3/line-break/line-break-auto-half-kana-expected.html: Removed.
platform/chromium-linux/css3/line-break/line-break-auto-sound-marks-expected.html: Removed.

6:39 PM Changeset in webkit [133385] by kling@webkit.org

3 edits in trunk/Source/WebCore

Cut overgrown ElementAttributeData bitfield.
<http://webkit.org/b/101129>

Reviewed by Anders Carlsson.

Make sure the ElementAttributeData bitfield fits into 32 bits. Added a compile-time assertion
to guard against future bloatage.

dom/ElementAttributeData.cpp:

(SameSizeAsElementAttributeData):

dom/ElementAttributeData.h:

(ElementAttributeData):

6:21 PM Changeset in webkit [133384] by commit-queue@webkit.org

17 edits
1 add in trunk/LayoutTests

[CSS Exclusions] Clean up shape-inside tests' subpixel snapping code
https://bugs.webkit.org/show_bug.cgi?id=100704

Patch by Bear Travis <betravis@adobe.com> on 2012-11-02
Reviewed by Dirk Schulze.

Factor out the pixel snapping behavior from polygon tests to be shared with
the rounded rectangle tests. In sub-pixel layout, the rounding behavior may be
slightly different. This adds a new file, subpixel-utils.js, which tests for the
feature availability and provides functions for rounding at line left & line right.
I've also taken the opportunity to factor the window.internal.settings code into
rounded-rectangle.js and simple-polygon.js.

fast/exclusions/resources/rounded-rectangle.js:

(simulateShape): Use the new subpixel rounding code.

fast/exclusions/resources/simple-polygon.js:

(polygonXIntercepts): Ditto.

fast/exclusions/resources/subpixel-utils.js: Added.

(SubPixelLayout): Adding the SubPixelLayout object which has helper methods
for determining how line edges should round, and whether subpixel layout is enabled.

fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html:
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html:
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html:
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html:
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html:
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html:
fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html:

5:58 PM Changeset in webkit [133383] by crogers@google.com

2 edits
1 copy
2 adds in trunk/LayoutTests

Rebaseline some webaudio tests due to increased precision in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=101134

Unreviewed rebaseline.

platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav:
platform/chromium/webaudio/audiobuffersource-loop-points-expected.wav: Copied from LayoutTests/platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav.
platform/chromium/webaudio/audiobuffersource-playbackrate-expected.wav: Added.

5:51 PM Changeset in webkit [133382] by dpranke@chromium.org

3 edits in trunk/Tools

webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101081

Reviewed by Ojan Vafai.

I broke this in r133061 and the unit tests weren't covering this
code path. Fixed the issue and the tests. --results-directory
doesn't make sense for either 'webkit-patch rebaseline' or
'webkit-patch rebaseline-expectations', so we don't want to expose
that as a command line option, but they all call a common
_rebaseline() routine that references options.results_directory,
so we need to set a default value.

Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations.execute):
(Rebaseline.execute):

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline):
(TestRebaseline.test_rebaseline):

5:50 PM Changeset in webkit [133381] by dpranke@chromium.org

4 edits in trunk/Tools

lint-webkitpy doesn't autoinstall pylint properly
https://bugs.webkit.org/show_bug.cgi?id=101106

Reviewed by Ojan Vafai.

Turns out the autoinstalling code for pylint didn't install
pylint's dependencies, and the autoinstaller code didn't work
using nested directories (e.g., "logilab/astng"). Fix those issues,
clean up the autoinstaller code, and add tests to make sure everything
imports successfully.

Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install):

Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):

5:48 PM Changeset in webkit [133380] by dpranke@chromium.org

9 edits in trunk/Tools

nrwt prints an awkward result message for missing results
https://bugs.webkit.org/show_bug.cgi?id=100915

Reviewed by Ojan Vafai.

Completely rework how we print out the description of
each tests's result - we now will print either "passed" or "failed",
followed by " unexpectedly" if we weren't expecting the result,
followed by a short description of each type of failure that happened
(in parentheses). Also reworked the description of each type of
failure slightly to be clearer.

Also rework the tests to make sure we have coverage of all of the
messages. Examples of the new output are posted as an attachment to
the bug.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

Scripts/webkitpy/layout_tests/models/test_failures.py:

(FailureTimeout.message):
(FailureMissingResult.message):
(FailureTextMismatch.message):
(FailureMissingImageHash.message):
(FailureMissingImage.message):
(FailureImageHashMismatch.message):
(FailureImageHashIncorrect.message):
(FailureReftestMismatch.message):
(FailureReftestMismatchDidNotOccur.message):
(FailureReftestNoImagesGenerated.message):
(FailureMissingAudio.message):
(FailureAudioMismatch.message):
(FailureEarlyExit.message):

Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_missing_and_unexpected_results):

Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._print_result_summary_entry):
(Printer.print_finished_test):
(Printer._result_message):
(Printer._print_unexpected_results):

Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:

5:23 PM Changeset in webkit [133379] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Very speculative ArgumentDecoder crash fix
https://bugs.webkit.org/show_bug.cgi?id=101130
<rdar://problem/11917046>

Reviewed by Sam Weinig.

Switch from fastMalloc/fastFree to system malloc/free in the hopes that it'll give more information about
a crash inside TCMalloc when freeing the argument data. (It seems unlikely that this is a bug in TCMalloc, but
switching to the system malloc could potentially give better error reporting).

Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):

5:14 PM Changeset in webkit [133378] by Lucas Forschler

2 edits in branches/safari-536.28-branch/Source/WebCore

Merged r124776. <rdar://problem/12536423>

5:02 PM Changeset in webkit [133377] by msaboff@apple.com

2 edits in trunk/Source/WebCore

Crash calling is8Bit() in visitedLinkHash()
https://bugs.webkit.org/show_bug.cgi?id=101119

Reviewed by Filip Pizlo.

Added an isEmpty() check to AttributeURL and KURL.

platform/LinkHash.cpp:

(WebCore::visitedLinkHash):

5:01 PM Changeset in webkit [133376] by Lucas Forschler

4 edits
2 copies in branches/safari-536.28-branch

Merged r124733. <rdar://problem/12536503>

4:55 PM Changeset in webkit [133375] by commit-queue@webkit.org

10 edits
68 adds in trunk

Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-02
Reviewed by Eric Seidel.

See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

Source/WebCore:

Web exposed changes include:
(1) The default (initial) value for -webkit-line-break becomes 'auto', instead of 'normal';
(2) The values 'auto', 'loose', 'normal', and 'strict' are added to -webkit-line-break;
(3) See [2] above for details regarding interpretation.

Tests: css3/line-break/line-break-auto-centered.html

css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html

platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.

platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.

platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().

rendering/RenderText.cpp:

(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.

rendering/RenderText.h:

(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.

rendering/break_lines.cpp:

(WebCore):
Introduce two (local) enums NBSPBehavior and LooseBehavior for expanding template on nextBreakablePosition
to include loose mode parameter.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Introduce loose mode behavior template parameter to optimize loose mode behavior code path in order
to prevent regression to non loose mode path.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use new template parameter enums described above.
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::nextBreakablePositionLoose):
Introduce two additional 'loose' mode flavors of NBP template expansions.

rendering/break_lines.h:

(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.

LayoutTests:

css3/line-break/line-break-auto-centered-expected.html: Added.
css3/line-break/line-break-auto-centered.html: Added.
css3/line-break/line-break-auto-half-kana-expected.html: Added.
css3/line-break/line-break-auto-half-kana.html: Added.
css3/line-break/line-break-auto-hyphens-expected.html: Added.
css3/line-break/line-break-auto-hyphens.html: Added.
css3/line-break/line-break-auto-inseparables-expected.html: Added.
css3/line-break/line-break-auto-inseparables.html: Added.
css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
css3/line-break/line-break-auto-iteration-marks.html: Added.
css3/line-break/line-break-auto-postfixes-expected.html: Added.
css3/line-break/line-break-auto-postfixes.html: Added.
css3/line-break/line-break-auto-prefixes-expected.html: Added.
css3/line-break/line-break-auto-prefixes.html: Added.
css3/line-break/line-break-auto-sound-marks-expected.html: Added.
css3/line-break/line-break-auto-sound-marks.html: Added.
css3/line-break/line-break-loose-centered-expected.html: Added.
css3/line-break/line-break-loose-centered.html: Added.
css3/line-break/line-break-loose-half-kana-expected.html: Added.
css3/line-break/line-break-loose-half-kana.html: Added.
css3/line-break/line-break-loose-hyphens-expected.html: Added.
css3/line-break/line-break-loose-hyphens.html: Added.
css3/line-break/line-break-loose-inseparables-expected.html: Added.
css3/line-break/line-break-loose-inseparables.html: Added.
css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
css3/line-break/line-break-loose-iteration-marks.html: Added.
css3/line-break/line-break-loose-postfixes-expected.html: Added.
css3/line-break/line-break-loose-postfixes.html: Added.
css3/line-break/line-break-loose-prefixes-expected.html: Added.
css3/line-break/line-break-loose-prefixes.html: Added.
css3/line-break/line-break-loose-sound-marks-expected.html: Added.
css3/line-break/line-break-loose-sound-marks.html: Added.
css3/line-break/line-break-normal-centered-expected.html: Added.
css3/line-break/line-break-normal-centered.html: Added.
css3/line-break/line-break-normal-half-kana-expected.html: Added.
css3/line-break/line-break-normal-half-kana.html: Added.
css3/line-break/line-break-normal-hyphens-expected.html: Added.
css3/line-break/line-break-normal-hyphens.html: Added.
css3/line-break/line-break-normal-inseparables-expected.html: Added.
css3/line-break/line-break-normal-inseparables.html: Added.
css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
css3/line-break/line-break-normal-iteration-marks.html: Added.
css3/line-break/line-break-normal-postfixes-expected.html: Added.
css3/line-break/line-break-normal-postfixes.html: Added.
css3/line-break/line-break-normal-prefixes-expected.html: Added.
css3/line-break/line-break-normal-prefixes.html: Added.
css3/line-break/line-break-normal-sound-marks-expected.html: Added.
css3/line-break/line-break-normal-sound-marks.html: Added.
css3/line-break/line-break-strict-centered-expected.html: Added.
css3/line-break/line-break-strict-centered.html: Added.
css3/line-break/line-break-strict-half-kana-expected.html: Added.
css3/line-break/line-break-strict-half-kana.html: Added.
css3/line-break/line-break-strict-hyphens-expected.html: Added.
css3/line-break/line-break-strict-hyphens.html: Added.
css3/line-break/line-break-strict-inseparables-expected.html: Added.
css3/line-break/line-break-strict-inseparables.html: Added.
css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
css3/line-break/line-break-strict-iteration-marks.html: Added.
css3/line-break/line-break-strict-postfixes-expected.html: Added.
css3/line-break/line-break-strict-postfixes.html: Added.
css3/line-break/line-break-strict-prefixes-expected.html: Added.
css3/line-break/line-break-strict-prefixes.html: Added.
css3/line-break/line-break-strict-sound-marks-expected.html: Added.
css3/line-break/line-break-strict-sound-marks.html: Added.
platform/chromium-linux/css3/line-break/line-break-auto-half-kana-expected.html: Added.
platform/chromium-linux/css3/line-break/line-break-auto-sound-marks-expected.html: Added.

4:54 PM Changeset in webkit [133374] by Lucas Forschler

4 edits
4 copies in branches/safari-536.28-branch

Merged r124724. <rdar://problem/12536531>

4:42 PM Changeset in webkit [133373] by Lucas Forschler

5 edits
2 copies in branches/safari-536.28-branch

Merged r124681. <rdar://problem/12536448>

4:39 PM Changeset in webkit [133372] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Replace NodeRareData hash map with a union on m_renderer
https://bugs.webkit.org/show_bug.cgi?id=100057

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-02
Reviewed by Eric Seidel.

Use a union on Node::m_renderer between NodeRareData* and RenderObject*. This removes
the overhead of accessing rare data and the memory from the map.

This is an 8% improvement on Bindings/get-elements-by-tag-name.html which tested
document.getElementsByTagName and was previously optimized in Bug 90059 for a 5%
improvement. As this is better than even the special casing for document that was
done in that bug, general node list access should see an even greater win.

This reduces the memory usage on nytimes.com by 250k per Bug 101052 by
removing the rare data map overhead.

This is also a 15% improvement on Parser/textarea-parsing.html

By removing the performance overhead of rareData() this patch addresses the performance
issues raised in Bugs 73853, 87034 and 89635.

I ran Parser/html5-full-render.html and there was no performance regression after
tuning Text::recalcTextStyle and the refactor that was done in r132684.

No new tests, this is just a refactor.

dom/Document.cpp:

(WebCore::Document::Document):

dom/Document.h:

(WebCore::Node::Node):

dom/Element.cpp:

(WebCore::Element::elementRareData):

dom/Node.cpp:

(WebCore::Node::rareData):
(WebCore::Node::ensureRareData):
(WebCore::Node::clearRareData):
(WebCore::Node::renderBox):
(WebCore::Node::renderBoxModelObject):
(WebCore::Node::reportMemoryUsage):

dom/Node.h:

(NodeRareDataBase):

Base class for NodeRareData that knows about the renderer so we can
inline the accesses in Node.h

(WebCore::NodeRareDataBase::renderer):
(WebCore::NodeRareDataBase::setRenderer):
(WebCore::NodeRareDataBase::~NodeRareDataBase):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(WebCore):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):

dom/NodeRareData.h:
dom/NodeRenderStyle.h:

(WebCore::Node::renderStyle):

dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

This method appears very hot in html5-full-render.html and accessing the
renderer 4 times caused a 2% performance regression with this patch. I
reduced it to 1 access and there's no longer any performance regression.

dom/WebCoreMemoryInstrumentation.cpp: Removed tracking of the rare data map memory usage as there is no longer a map to track.
dom/WebCoreMemoryInstrumentation.h:
inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

4:39 PM Changeset in webkit [133371] by andersca@apple.com

18 edits in trunk

Don't instantiate the Java plug-in if it's inactive
https://bugs.webkit.org/show_bug.cgi?id=101102
<rdar://problem/12595679>

Reviewed by Andreas Kling.

Source/WebKit/mac:

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldUnavailablePluginMessageBeButton):
The RenderEmbeddedObject::PluginInactive reason should always result in a button being shown.

(WebChromeClient::unavailablePluginButtonClicked):
If the Java plug-in is inactive, call WKJLReportWebComponentsUsed() to reactivate the plug-in and
then reload the page.

WebCoreSupport/WebFrameLoaderClient.mm:

(isOracleJavaPlugIn):
(isPlugInInactive):
Helper functions.

(WebFrameLoaderClient::createPlugin):
If the plug-in is inactive, set the appropriate unavailability reason on the renderer.

Source/WebKit2:

Shared/Plugins/PluginModuleInfo.h:

Add a PluginModuleLoadPolicy enum.

UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::policyForPlugin):

UIProcess/Plugins/PluginInfoStore.h:

(PluginInfoStore):
Rename shouldBlockPlugin to policyForPlugin and make it return an enum so we can handle inactive plug-ins.

UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::shouldBlockPlugin):
Add helper function.

(WebKit::PluginInfoStore::policyForPlugin):
If the Java plug-in is inactive, return PluginModuleInactive.

(WebKit::PluginInfoStore::reactivateInactivePlugin):
If the given plug-in is the Java plug-in, call WKJLReportWebComponentsUsed() to reactivate it.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
If the plug-in is inactive, try to reactivate it and reload the page if reactivation succeeded.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginPath):

UIProcess/WebProcessProxy.h:

This now returns a plug-in load policy.

UIProcess/WebProcessProxy.messages.in:

GetPluginPack now returns a load policy enum.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
Change this to a switch statement and always return true for RenderEmbeddedObject::PluginInactive.

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Add RenderEmbeddedObject::PluginInactive to the assertion.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Update now that GetPluginPath returns a pluginLoadPolicy enum.

(WebKit::canPluginHandleResponse):
Ditto.

WebKitLibraries:

Update WebKitSystemInterface to a version that has WKJLReportWebComponentsUsed.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceMountainLion.a:

Roll WebKitSystemInterface DERPS.

4:29 PM Changeset in webkit [133370] by aboxhall@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Generalising flakiness for fast/forms/formaction-attribute.html.
https://bugs.webkit.org/show_bug.cgi?id=72039

platform/chromium/TestExpectations:

4:24 PM Changeset in webkit [133369] by Lucas Forschler

5 edits
2 copies in branches/safari-536.28-branch

Merged r124654. <rdar://problem/12516349>

4:19 PM Changeset in webkit [133368] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

LLInt 32-bit put_by_val ArrayStorage case should use the right register (t3, not t2) for the index in the publicLength updating path
https://bugs.webkit.org/show_bug.cgi?id=101118

Reviewed by Gavin Barraclough.

llint/LowLevelInterpreter32_64.asm:

4:14 PM Changeset in webkit [133367] by Lucas Forschler

5 edits
2 copies in branches/safari-536.28-branch

Merge 124645. '<rdar://problem/12536525>'

4:11 PM Changeset in webkit [133366] by ap@apple.com

7 edits in trunk/Source

[Mac] ResourceHandle changes for network process
https://bugs.webkit.org/show_bug.cgi?id=101111

Reviewed by Jessie Berlin.

With NSOperationQueue, we'll be getting NetworkProcess delegate method calls
on secondary threads, and so we won't block other requests while consulting with WebProcess.

platform/network/NetworkingContext.h: (WebCore::NetworkingContext::scheduledRunLoopPairs): (WebCore::NetworkingContext::scheduledOperationQueue): Add an ability to schedule on an NSOperationQueue. Now that scheduling on run loop is not a must, give scheduledRunLoopPairs() a default implementation.

platform/network/mac/ResourceHandleMac.mm: Removed isInitializingConnection static. It was only used to catch a long obsolete bug with debug logging, and cannot work with multiple threads. (WebCore::ResourceHandle::start): Scedule on a operation queue if applicable. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Removed a check that used isInitializingConnection.

4:10 PM Changeset in webkit [133365] by crogers@google.com

4 edits in trunk/Source/WebCore

Automating gain AudioParam with linearRampToValueAtTime introduces buzzing distortion
https://bugs.webkit.org/show_bug.cgi?id=100885

Reviewed by Kenneth Russell.

AudioParamTimeline needs to use double-precision for time-values to avoid drift and precision issues.

Covered by existing tests.

Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateTimelineValues):

Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

Modules/webaudio/AudioParamTimeline.h:

(AudioParamTimeline):

4:09 PM Changeset in webkit [133364] by aboxhall@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Fixing duplicate marking of video-media-source-state-changes.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=96725

platform/chromium/TestExpectations:

3:58 PM Changeset in webkit [133363] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG::Node::converToStructureTransitionWatchpoint should take kindly to ArrayifyToStructure
https://bugs.webkit.org/show_bug.cgi?id=101117

Reviewed by Gavin Barraclough.

We have logic to convert ArrayifyToStructure to StructureTransitionWatchpoint, which is awesome, except
that previously convertToStructureTransitionWatchpoint was (a) asserting that it never saw an
ArrayifyToStructure and (b) would incorrectly create a ForwardStructureTransitionWatchpoint if it did.

dfg/DFGNode.h:

(JSC::DFG::Node::convertToStructureTransitionWatchpoint):

3:30 PM Changeset in webkit [133362] by schenney@chromium.org

11 edits in trunk/Source/WebCore

Reduce redundant code in SimpleFontData[platform]
https://bugs.webkit.org/show_bug.cgi?id=97245

Reviewed by Eric Seidel.

Move duplicated code out of platform specific files and into the common file.
This represents all of the methods in SimpleFontData that do not have genuine
platform specific code.

No new tests because there is no change at all in the functionality.

platform/graphics/SimpleFontData.cpp:

(WebCore):
(WebCore::SimpleFontData::smallCapsFontData): Implementation from platform files.
(WebCore::SimpleFontData::emphasisMarkFontData): Implementation from platform files.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: