Timeline
Nov 5, 2012:
- 11:47 PM Changeset in webkit [133567] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG should not fall down to patchable GetById just because a prototype had things added to it
https://bugs.webkit.org/show_bug.cgi?id=101299
Reviewed by Geoffrey Garen.
This looks like a slight win on V8v7 and SunSpider.
- bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:44 PM Changeset in webkit [133566] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline*: fix typo for --results-directory
https://bugs.webkit.org/show_bug.cgi?id=101295
Reviewed by Ojan Vafai.
Had --results_directory instead of --results-directory in both the
code and the unit test.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._rebaseline_commands):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineJson.test_results_directory):
- 11:18 PM Changeset in webkit [133565] by
-
- 2 edits in trunk/Source/WebCore
Introduce Day class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101194
Reviewed by Kent Tamura.
Introducing Day class so day, week, and month can all be abstracted. To
solve some of the complexity around which months to show, I made
CalendarPicker in charge of it. This also made YearMonthController and
DaysTable independent of each other.
No new tests. Covered by existing calendar-picker-*.html tests.
- Resources/pagepopups/calendarPicker.js:
(createUTCDate): Allow negative month or date.
(parseDateString): Will return Day or Month depending on string format.
(Day): Represents a day.
(Day.parse): Parse yyyy-mm-dd.
(Day.createFromDate): Creates a Day that contains a datetime.
(Day.createFromToday): Creates Day for today. A method with the same name will be added to Week and Month in the future.
(Day.prototype.equals): Returns true if they are the same.
(Day.prototype.previous): Returns the previous day.
(Day.prototype.next): Returns the next day.
(Day.prototype.startDate): Returns the datetime that is the start of this day.
(Day.prototype.endDate): Returns the datetime that is the start of this day.
(Day.prototype.valueOf): Returns the milliseconds since epoch.
(Day.prototype.toString): Returns an ISO date string.
(Month): Fix bug in calculating month from value.
(Month.prototype.endDate): Use Day.Maximum.
(CalendarPicker): Added _currentMonth. yearMonthController and daysTable can be private members now.
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday): Use Day.createFromToday.
(CalendarPicker.prototype.shouldShowMonth): Returns true if the month should be shown.
(CalendarPicker.prototype.showMonth): Shows the given month. If the month is out of the range of months that should be shown, we clamp the month and show that.
(CalendarPicker.prototype.currentMonth): Returns the current month that is shown.
(YearMonthController): Removed _currentMonth.
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype.setMonth):
(YearMonthController.prototype._handleYearMonthChange): Use CalendarPicker.showMonth
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(CalendarPicker.prototype._stepMismatch): Made private.
(CalendarPicker.prototype._outOfRange): Made private.
(CalendarPicker.prototype.isValidDate): Take Day or Month instead of milliseconds since epoch.
(DaysTable.prototype._renderMonth):
(DaysTable.prototype.navigateToMonth): Shows a given month. Can use animation and leave the selection position as is.
(DaysTable.prototype.selectRange): Select a range.
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
- 11:16 PM Changeset in webkit [133564] by
-
- 22 edits4 deletes in trunk/Source/JavaScriptCore
Get rid of method_check
https://bugs.webkit.org/show_bug.cgi?id=101147
Reviewed by Geoffrey Garen.
op_method_check no longer buys us anything, since get_by_id proto caching
gives just as much profiling information and the DFG inlines monomorphic
proto accesses anyway.
This also has the potential for a speed-up since it makes parsing of
profiling data easier. No longer do we have to deal with the confusion of
the get_by_id portion of a method_check appearing monomorphic even though
we're really dealing with a bimorphic access (method_check specializes for
one case and get_by_id for another).
This looks like a 1% speed-up on both SunSpider and V8v7.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::unlinkCalls):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::callLinkInfo):
(CodeBlock):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
- bytecode/MethodCallLinkInfo.cpp: Removed.
- bytecode/MethodCallLinkInfo.h: Removed.
- bytecode/MethodCallLinkStatus.cpp: Removed.
- bytecode/MethodCallLinkStatus.h: Removed.
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallDotNode::emitBytecode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::slowCaseInfo):
(PropertyStubCompilationInfo):
(JSC):
(JIT):
- jit/JITPropertyAccess.cpp:
(JSC):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::compileGetByIdSlowCase):
- jit/JITPropertyAccess32_64.cpp:
(JSC):
(JSC::JIT::compileGetByIdSlowCase):
- jit/JITStubs.cpp:
(JSC):
- jit/JITStubs.h:
- llint/LowLevelInterpreter.asm:
- 10:43 PM Changeset in webkit [133563] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Adding #if PLATFORM(CHROMIUM) for the fix of
https://bugs.webkit.org/show_bug.cgi?id=101009
This fix requires the most recent version of harfbuzz-ng.
EFL port uses version 0.9.2, which doesn't have the fix.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
- 10:41 PM Changeset in webkit [133562] by
-
- 4 edits in trunk/Source/WebCore
Ensure acquireLineBreakIterator signature consistency on non-ICU ports.
https://bugs.webkit.org/show_bug.cgi?id=101281
Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Ryosuke Niwa.
Fix (newly) inconsistent signature for acquireLineBreakIterator for non-ICU ports
caused by http://trac.webkit.org/changeset/133529.
See new tests added from https://bugs.webkit.org/show_bug.cgi?id=89235.
- platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator):
- platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::setUpIterator):
(WebCore::acquireLineBreakIterator):
- platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::acquireLineBreakIterator):
- 10:25 PM Changeset in webkit [133561] by
-
- 2 edits in trunk/Source/WebCore
Use switch/case statements instead of if/elseif in CSSSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=100470
Reviewed by Ryosuke Niwa.
Minor clean up. We can get compiler warnings if we use switch/case statements here.
No changes to functionality, so no new tests.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- 10:24 PM Changeset in webkit [133560] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening, skip new failing tests.
- platform/qt/TestExpectations:
- 10:11 PM BuildingGtk edited by
- (diff)
- 10:06 PM Changeset in webkit [133559] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline*: fix handling of local file urls
https://bugs.webkit.org/show_bug.cgi?id=101296
Reviewed by Ojan Vafai.
When using --results-directory, we need to make sure we're converting
paths to file:/// urls for urllib to work correctly. Also, this
patch reworks the unit tests to get better coverage (of the execute()
command) and reduce copy/pasting of mock options.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.setUp):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test_with_results_directory):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):
- 9:52 PM Changeset in webkit [133558] by
-
- 10 edits in trunk/Source/WebKit2
Need a way to send and receive messages between the WKWebProcessPlugIn object and the client
https://bugs.webkit.org/show_bug.cgi?id=101282
Reviewed by Anders Carlsson.
API wise, this adds:
- A connection property on the WKWebProcessPlugInController
- A method to send messages across a WKConnection (sendMessageWithName:body).
It also implements message sending and receiving for WKConnection. Message bodies are currently
restricted to being object graphs with values that are property list types, but in the future, should
support all types conforming to the NSSecureCoding protocol.
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::handleMessage):
- Shared/WebConnection.h:
(WebConnection):
- Shared/WebConnection.messages.in:
Switch HandleMessage to be a variadic message to avoid an extra copy and support attachments correctly.
- Shared/mac/ArgumentCodersMac.h:
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::typeFromObject):
(CoreIPC::encode):
(CoreIPC::decode):
Add support for encoding/decoding NSArray, NSDate and NSData.
- UIProcess/API/mac/WKConnection.h:
- UIProcess/API/mac/WKConnection.mm:
(-[WKConnection sendMessageWithName:body:]):
(didReceiveMessage):
Implement message sending and receiving.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
(-[WKWebProcessPlugInController connection]):
Add a wrapper for the WKConnectionRef vended via WKBundleGetApplicationConnection() and expose it as
API on the WKWebProcessPlugInController.
- 9:04 PM Changeset in webkit [133557] by
-
- 19 edits170 adds12 deletes in trunk/LayoutTests
Unreviewed gardening. Updating MathML chromium baselines.
- platform/chromium-linux-x86/mathml/presentation: Added.
- platform/chromium-linux-x86/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/over-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/over-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/roots-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/row-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/row-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/style-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/style-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/sub-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/sup-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/tables-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/under-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/under-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/underover-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/underover-expected.txt: Added.
- platform/chromium-linux-x86/mathml/xHeight-expected.txt:
- platform/chromium-linux/mathml/presentation: Added.
- platform/chromium-linux/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-linux/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/mo-expected.png: Added.
- platform/chromium-linux/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/over-expected.png: Added.
- platform/chromium-linux/mathml/presentation/over-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/roots-expected.png: Added.
- platform/chromium-linux/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-linux/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/row-expected.png: Added.
- platform/chromium-linux/mathml/presentation/row-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/style-expected.png: Added.
- platform/chromium-linux/mathml/presentation/style-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/sub-expected.png: Added.
- platform/chromium-linux/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-linux/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/sup-expected.png: Added.
- platform/chromium-linux/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/tables-expected.png: Added.
- platform/chromium-linux/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-linux/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/under-expected.png: Added.
- platform/chromium-linux/mathml/presentation/under-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/underover-expected.png: Added.
- platform/chromium-linux/mathml/presentation/underover-expected.txt: Added.
- platform/chromium-linux/mathml/xHeight-expected.txt:
- platform/chromium-mac-lion/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.png:
- platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-mac-lion/mathml/presentation/subsup-expected.png:
- platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt:
- platform/chromium-mac-lion/mathml/presentation/tables-expected.png:
- platform/chromium-mac-lion/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.txt:
- platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.png:
- platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt:
- platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.png:
- platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt:
- platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.png:
- platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt:
- platform/chromium-mac/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-mac/mathml/presentation/row-alignment-expected.png:
- platform/chromium-mac/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-mac/mathml/presentation/subsup-expected.png:
- platform/chromium-mac/mathml/presentation/subsup-expected.txt:
- platform/chromium-mac/mathml/presentation/tables-expected.png:
- platform/chromium-mac/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation: Added.
- platform/chromium-win-xp/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/mo-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/over-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/over-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/roots-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/row-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/row-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/style-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/style-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/sub-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/sup-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/tables-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/under-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/under-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/underover-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/underover-expected.txt: Added.
- platform/chromium-win/mathml/presentation: Added.
- platform/chromium-win/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-win/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-win/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-win/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-win/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-win/mathml/presentation/mo-expected.png: Added.
- platform/chromium-win/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-win/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-win/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-win/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-win/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-win/mathml/presentation/over-expected.png: Added.
- platform/chromium-win/mathml/presentation/over-expected.txt: Added.
- platform/chromium-win/mathml/presentation/roots-expected.png: Added.
- platform/chromium-win/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-win/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-win/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-win/mathml/presentation/row-expected.png: Added.
- platform/chromium-win/mathml/presentation/row-expected.txt: Added.
- platform/chromium-win/mathml/presentation/style-expected.png: Added.
- platform/chromium-win/mathml/presentation/style-expected.txt: Added.
- platform/chromium-win/mathml/presentation/sub-expected.png: Added.
- platform/chromium-win/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-win/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-win/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-win/mathml/presentation/sup-expected.png: Added.
- platform/chromium-win/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-win/mathml/presentation/tables-expected.png: Added.
- platform/chromium-win/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-win/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-win/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-win/mathml/presentation/under-expected.png: Added.
- platform/chromium-win/mathml/presentation/under-expected.txt: Added.
- platform/chromium-win/mathml/presentation/underover-expected.png: Added.
- platform/chromium-win/mathml/presentation/underover-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/chromium/mathml/presentation/attributes-expected.png: Removed.
- platform/chromium/mathml/presentation/fractions-expected.png: Removed.
- platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
- platform/chromium/mathml/presentation/mo-expected.png: Removed.
- platform/chromium/mathml/presentation/mo-stretch-expected.png: Removed.
- platform/chromium/mathml/presentation/mroot-pref-width-expected.png: Removed.
- platform/chromium/mathml/presentation/over-expected.png: Removed.
- platform/chromium/mathml/presentation/roots-expected.png: Removed.
- platform/chromium/mathml/presentation/row-alignment-expected.png: Removed.
- platform/chromium/mathml/presentation/row-expected.png: Removed.
- platform/chromium/mathml/presentation/style-expected.png: Removed.
- platform/chromium/mathml/presentation/subsup-expected.png: Removed.
- 8:15 PM Changeset in webkit [133556] by
-
- 2 edits in trunk/Tools
Added secondary email address and IRC nick.
https://bugs.webkit.org/show_bug.cgi?id=101290
Unreviewed change to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 8:08 PM Changeset in webkit [133555] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not show error page for main loads denied by client application
https://bugs.webkit.org/show_bug.cgi?id=101287
Internal PR: 237574.
Internally reviewed by Arvid Nilsson, Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by George Staikos.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 7:46 PM Changeset in webkit [133554] by
-
- 7 edits in trunk/Source/WebKit2
[EFL][WK2] Fix wrong coding style in the boilerplates
https://bugs.webkit.org/show_bug.cgi?id=101283
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-05
Reviewed by Gyuyoung Kim.
Fix boilerplate which have wrong coding style.
- UIProcess/efl/InputMethodContextEfl.cpp:
- UIProcess/efl/InputMethodContextEfl.h:
- UIProcess/efl/PageClientDefaultImpl.cpp:
- UIProcess/efl/PageClientDefaultImpl.h:
- UIProcess/efl/PageClientLegacyImpl.cpp:
- UIProcess/efl/PageClientLegacyImpl.h:
- 7:46 PM Changeset in webkit [133553] by
-
- 1 edit16 adds in trunk/LayoutTests
[EFL][WK2][PixelTests] Add missing expectations
https://bugs.webkit.org/show_bug.cgi?id=101289
Unreviewed, EFL gardening.
Add 16 missing pixel test expectations.
Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-05
- platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
- platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
- platform/efl/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/efl/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
- platform/efl/fast/forms/basic-inputs-expected.png: Added.
- platform/efl/fast/media/view-mode-media-feature-expected.png: Added.
- platform/efl/media/video-aspect-ratio-expected.png: Added.
- platform/efl/media/video-layer-crash-expected.png: Added.
- platform/efl/media/video-transformed-expected.png: Added.
- platform/efl/media/video-zoom-controls-expected.png: Added.
- platform/efl/media/video-zoom-expected.png: Added.
- platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- 7:37 PM Changeset in webkit [133552] by
-
- 32 edits31 copies6 adds in trunk/LayoutTests
Unreviewed, update chromium-mac-mountainlion baselines for svg failures after r133538
- platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png.
- platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png.
- platform/chromium-mac-lion/svg/batik/filters/filterRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/filters/filterRegions-expected.png.
- platform/chromium-mac-lion/svg/batik/masking/maskRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/masking/maskRegions-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternRegionA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternRegions-positioned-objects-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png.
- platform/chromium-mac-lion/svg/batik/text/longTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png.
- platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/smallFonts-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textAnchor-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textAnchor-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textDecoration-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textEffect3-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect3-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textFeatures-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textLayout2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textLength-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLength-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPath-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textOnPathSpaces-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textPosition-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textPosition2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textProperties-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textProperties2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textStyles-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textStyles-expected.png.
- platform/chromium-mac-lion/svg/batik/text/verticalText-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalText-expected.png.
- platform/chromium-mac-lion/svg/batik/text/verticalTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png.
- platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
- platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
- platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
- platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
- platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
- platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
- platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
- platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png:
- platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
- platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac/svg/batik/text/textEffect-expected.png:
- platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
- platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
- platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac/svg/batik/text/textLayout-expected.png:
- platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
- platform/chromium-mac/svg/batik/text/textLength-expected.png:
- platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
- platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png:
- platform/chromium-mac/svg/batik/text/textPosition-expected.png:
- platform/chromium-mac/svg/batik/text/textPosition2-expected.png:
- platform/chromium-mac/svg/batik/text/textProperties-expected.png:
- platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
- platform/chromium-mac/svg/batik/text/textStyles-expected.png:
- platform/chromium-mac/svg/batik/text/verticalText-expected.png:
- platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
- 7:12 PM Changeset in webkit [133551] by
-
- 8 edits in trunk/Source/JavaScriptCore
Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations
https://bugs.webkit.org/show_bug.cgi?id=100321
Reviewed by Filip Pizlo.
We have refactored the MacroAssembler and JIT compilers to distinguish
the pointer operations from the 64-bit integer operations (see bug #99154).
Now we want to do the similar work for LLInt, and the goal is same as
the one mentioned in 99154.
This is the second part of the modification: in the low level interpreter,
changing the operations on 64-bit integers to use the "<foo>q" instructions.
This also removes some unused/meaningless "<foo>p" instructions.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter64.asm:
- offlineasm/armv7.rb:
- offlineasm/cloop.rb:
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
- 7:04 PM Changeset in webkit [133550] by
-
- 3 edits2 adds in trunk
[Chromium] Unicode combining diacritical aren't always combined on Linux
https://bugs.webkit.org/show_bug.cgi?id=101009
Reviewed by Kent Tamura.
Source/WebCore:
Add a space character to harfbuzzBuffer as pre-context. This will prevent
harfbuzz from inserting dotted-circle.
Test: fast/text/international/combining-marks-position.html
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
LayoutTests:
Add a test that checks whether combining marks are combined with base characters.
- fast/text/international/combining-marks-position-expected.txt: Added.
- fast/text/international/combining-marks-position.html: Added.
- 6:46 PM BuildingGtk edited by
- (diff)
- 6:18 PM Changeset in webkit [133549] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=100817
Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.
- mr.po: updated.
- 6:13 PM Changeset in webkit [133548] by
-
- 3 edits in trunk/Source/WebCore
LayoutTest fast/dom/shadow/shadowroot-type.html is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=101201
Reviewed by Hajime Morita.
When we use a bit field for enum, Windows compiler seems returning some wrong value.
We would like to avoid using a bit field for enum value.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::type):
(WebCore::ShadowRoot::setType):
(ShadowRoot):
- 6:05 PM Changeset in webkit [133547] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
[l10n] updated id.po for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100264
Patch by Andika Triwidada <andika@gmail.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.
- id.po: updated.
- 5:53 PM Changeset in webkit [133546] by
-
- 11 edits in trunk
Prototype chain caching should check that the path from the base object to the slot base involves prototype hops only
https://bugs.webkit.org/show_bug.cgi?id=101276
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Changed normalizePrototypeChain() to report an invalid prototype chain if any object is a proxy.
This catches cases where our prototype chain checks would have been insufficient to guard against
newly introduced properties, despecialized properties, or deleted properties in the chain of
objects involved in the access.
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Operations.h:
(JSC):
(JSC::normalizePrototypeChain):
LayoutTests:
This test already covered this case, but only for method_check. Modified it to
also cover the get_by_id case.
- fast/js/toString-and-valueOf-override-expected.txt:
- fast/js/toString-and-valueOf-override.html:
- 5:48 PM Changeset in webkit [133545] by
-
- 2 edits in trunk/Source/WebCore
TransformOperationInfo's constructor is really slow
https://bugs.webkit.org/show_bug.cgi?id=101143
Reviewed by Sam Weinig.
TransformOperationInfo() was slow for a few reasons:
-The function used a lot of branches. The basic assumption is that the input
is incorrect, thus every character is an opportunity to fail.
-Every branch had to be tested in order. If the name was matching the last if()
all the previous names had to be tested.
-Since equalIgnoringCase() was used in every branch, it was forcing the case folding
every time.
-When the string is 16bits, the case folding was using ICU, which was incredibly inefficient.
This can be fixed by either
1) Compute the lowercase name, then match it to a HashMap.
2) Write a tree to quickly reduce the number of branch needed.
The first solution is not viable because 16bits strings case folding
remains an important bottleneck.
Instead, the code now splits the names on simple characteristics to
match any name in a limited number of branches.
The assumption is the input is correct, so & is used instead of && to
avoid branches in favor of conditional instructions.
- css/CSSParser.cpp:
(WebCore::TransformOperationInfo::TransformOperationInfo):
- 5:45 PM Changeset in webkit [133544] by
-
- 4 edits in trunk/Source/WebCore
RenderGeometryMap asserts when loading http://en.softonic.com/mac
https://bugs.webkit.org/show_bug.cgi?id=101284
<rdar://problem/11540560>
Reviewed by Tim Horton.
When FrameView::layout() calls document->updateStyleIfNeeded(), we
can be in a state where FrameView::needsLayout() is false. However,
this is a bad time to update compositing layers, because we're about
to do layout, which will require us to update them again soon anyway,
and some RenderLayers may not have been sized or positioned yet.
Fix by adding a m_doingPreLayoutStyleUpdate member to FrameView,
and toggling it around this call to updateStyleIfNeeded().
Read this state in updateCompositingLayersAfterStyleChange(), which is
now called unconditionally by recalcStyle(), but returns early
if this flag is set, or layout is pending.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::layout):
- page/FrameView.h:
(FrameView):
- 4:54 PM Changeset in webkit [133543] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix build warning in PageClientLegacyImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=101266
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Laszlo Gombos.
The 'size' is not used when !USE(TILED_BACKING_STORE)
Use UNUSED_PARAM macro for removing -Wunused-parameter warning
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
- 4:48 PM Changeset in webkit [133542] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=101275
Clean up ScrollingConstraints.h
Reviewed by Simon Fraser.
This class cleans up ScrollingConstraints.h by removing the constructors since the
compiler will generate those constructors for us anyway. The patch also makes the
two override functions private.
- page/scrolling/ScrollingConstraints.h:
(ViewportConstraints):
(FixedPositionViewportConstraints):
(StickyPositionViewportConstraints):
- 4:35 PM Changeset in webkit [133541] by
-
- 2 edits in trunk/Source/WebCore
Make Document::updateStyleIfNeeded() non-virtual
https://bugs.webkit.org/show_bug.cgi?id=101273
Reviewed by Eric Seidel.
Document::updateStyleIfNeeded() has been virtual like forever, but
no-one ever overrides it, so make it non-virtual.
- dom/Document.h:
(Document):
- 4:23 PM Changeset in webkit [133540] by
-
- 3 edits in trunk/LayoutTests
Fixed flaky fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
https://bugs.webkit.org/show_bug.cgi?id=101268.
Reviewed by Geoffrey Garen.
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
- 4:14 PM Changeset in webkit [133539] by
-
- 1 edit5 adds in trunk/PerformanceTests
WebKit should have performance tests for book chapter reflow
https://bugs.webkit.org/show_bug.cgi?id=101271
Reviewed by Dan Bernstein.
I grabbed a book chapter from the Project Gutenberg front page:
- Layout/chapter-reflow-once.html: Added.
- Layout/chapter-reflow-thrice.html: Added.
- Layout/chapter-reflow-twice.html: Added.
- Layout/chapter-reflow.html: Added.
I also created a torture-test random text generator:
- Layout/chapter-reflow-once-random.html: Added.
- 4:13 PM Changeset in webkit [133538] by
-
- 6 edits in trunk
Unblock SVG external references
https://bugs.webkit.org/show_bug.cgi?id=100635
Reviewed by Adam Barth.
This patch reverts r132849 and r132869 because the potential XSS issue
turned out to not be an issue after all.
Covered by existing tests, many of which are re-whitelisted with this patch.
Source/WebCore:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- platform/chromium/TestExpectations:
- 3:41 PM Changeset in webkit [133537] by
-
- 2 edits in trunk/Tools
Add IRC alias for Glenn Adams
https://bugs.webkit.org/show_bug.cgi?id=101262
Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.
Add IRC alias for Glenn Adams.
- Scripts/webkitpy/common/config/committers.py:
- 3:31 PM Changeset in webkit [133536] by
-
- 28 edits19 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=101001
Pages with position:fixed elements should still be able to scroll on
the scrolling thread
-and corresponding-
<rdar://problem/10857315>
Reviewed by Simon Fraser.
Source/WebCore:
This patch adds two new classes. ScrollingStateFixedNode is a class
to represent fixed nodes in the state tree, and
ScrollingTreeFixedNode represents fixed node in the scrolling tree
over on the scrolling thread.
- WebCore.xcodeproj/project.pbxproj:
When we are (non-programatically) scrolling fixed objects on the
scrolling thread, we do not want to do any work here.
- page/FrameView.cpp:
(WebCore::FrameView::updateFixedElementsAfterScrolling):
Whenever we sync the position of the main frame's layer, we have to
do the same for scrolling tree children.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
New ScrollingNodeType -- FixedNode, yay! And two new functions
specific to dealing with FixedNodes.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::ScrollingCoordinator::syncChildPositions):
This is the new class that represents fixed nodes in the state tree.
All of the changed properties are stored within
FixedPositionViewportConstraints.
- page/scrolling/ScrollingStateFixedNode.cpp: Added.
(WebCore):
(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::~ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::updateConstraints):
(WebCore::ScrollingStateFixedNode::dumpProperties):
- page/scrolling/ScrollingStateFixedNode.h: Added.
(WebCore):
(ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::viewportConstraints):
(WebCore::toScrollingStateFixedNode):
Make sure to create the right type of clone for each node.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::cloneAndReset):
Now that m_children may be anything other than null, I found this
bug. We encounter it when the parameter to removeChild is this and we
want to remove all of our children. In that case, this is obviously
not found in its own child array.
(WebCore::ScrollingStateNode::removeChild):
ScrollingStateNode now caches the GraphicsLayer in addition to the
PlatformLayer. This will allow us to sync the GraphicsLayer position
at the appropriate times.
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::isScrollingStateFixedNode):
(WebCore::ScrollingStateNode::graphicsLayer):
(ScrollingStateNode):
Handle fixed nodes.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
New function parentScrollPositionDidChange() is called on children
when the parent has scrolled.
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
- page/scrolling/ScrollingTreeScrollingNode.h:
(ScrollingTreeScrollingNode):
Return true for supportsFixedPositionLayers().
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
Handle fixed nodes.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::attachToStateTree):
Now that m_children can be non-null I caught this pre-existing bug
where we would come times remove a node without updating the HashMap.
This patch fixes that by consolidating the removal into one function.
(WebCore::ScrollingCoordinatorMac::removeNode):
(WebCore::ScrollingCoordinatorMac::detachFromStateTree):
(WebCore::ScrollingCoordinatorMac::clearStateTree):
Update the GraphicsLayers to reflect the new position that the
Scrolling thread has moved the underlying CALayer to already.
(WebCore::ScrollingCoordinatorMac::syncChildPositions):
Pass new constraints over to the appropriate state node.
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
Cache the GraphicsLayer in addition to the PlatformLayer.
- page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):
Here is the new class that represents fixed nodes over on the
scrolling thread.
- page/scrolling/mac/ScrollingTreeFixedNode.h: Added.
(WebCore):
(ScrollingTreeFixedNode):
- page/scrolling/mac/ScrollingTreeFixedNode.mm: Added.
(WebCore):
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::~ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::update):
This is where the magic happens. re-position the fixed object when
its parent has scrolled so that it appears to have not moved at all.
(WebCore::ScrollingTreeFixedNode::parentScrollPositionDidChange):
Whenever we change the position of a scrolling layer, tell our
children.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Handle fixed nodes.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::attachToScrollingCoordinator):
detachFromScrollingCoordinator() needs to be public so that it can be
called from RenderLayerCompositor for fixed nodes.
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
RenderLayerCompositor takes control of attaching and detaching fixed
nodes to/from the ScrollingCoordinator.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didFlushChangesForLayer):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::didMoveOnscreen):
(WebCore::RenderLayerCompositor::willMoveOffscreen):
(WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
(WebCore::isRootmostFixedOrStickyLayer):
(WebCore):
(WebCore::RenderLayerCompositor::updateViewportConstraintStatus):
(WebCore::RenderLayerCompositor::addViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::computeViewportConstraints):
(WebCore::nearestScrollingCoordinatorAncestor):
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::unregisterViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers):
- rendering/RenderLayerCompositor.h:
(WebCore):
(RenderLayerCompositor):
LayoutTests:
New tests.
- platform/mac/tiled-drawing/fixed: Added.
- platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/absolute-inside-fixed.html: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view.html: Added.
- platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/four-bars.html: Added.
- platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/nested-fixed.html: Added.
- platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/percentage-inside-fixed.html: Added.
These two tests are supposed to be in "slow scrolling" mode. Now that
fixed elements can scroll "fast," we need something else to force
slow scrolling. We should probably just add something to
window.internals to do that, but in the meantime,
background-attachment:fixed will work.
- platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt:
- platform/mac/tiled-drawing/scrolling-tree-slow-scrolling.html:
- platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
- platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html:
- 3:22 PM Changeset in webkit [133535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark fonts/cursive.html as flaky on MountainLion as well as Lion.
https://bugs.webkit.org/show_bug.cgi?id=83219
- platform/chromium/TestExpectations:
- 3:18 PM Changeset in webkit [133534] by
-
- 3 edits in trunk/Source/WebCore
Cleaned up the Font class in preparation for optimizing kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=101258
Reviewed by Dan Bernstein.
- platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures):
(WebCore::Font::computeTypesettingFeatures): Compute and cache our
typesetting features instead of recomputing each time a client asks
for them. This makes the class interface easier to use because
"typesettingFeatures()" can appear in more than one expression without
undue performance cost. This may also be a small speedup to code that
calls typesettingFeatures() often for other reasons.
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update): Ditto.
(WebCore::Font::width): Unforked the width() function so all width-related
interfaces can benefit from optimization without duplicate code.
- 3:10 PM Changeset in webkit [133533] by
-
- 7 edits in trunk
Back out controversial changes from Bug 98665.
https://bugs.webkit.org/show_bug.cgi?id=101244
Patch by Dima Gorbik <dgorbik@apple.com> on 2012-11-05
Reviewed by David Kilzer.
Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
Source/JavaScriptCore:
- API/tests/minidom.c:
- API/tests/testapi.c:
Source/WTF:
- wtf/Assertions.h:
Tools:
- DumpRenderTree/mac/MockGeolocationProvider.mm:
- 3:07 PM Changeset in webkit [133532] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
- platform/chromium-mac-mountainlion/TestExpectations:
- 2:56 PM Changeset in webkit [133531] by
-
- 2 edits in trunk/Source/WebCore
Webkit does not handle some media keys correctly On Linux gtk platform.
https://bugs.webkit.org/show_bug.cgi?id=101221
Patch by Peng Huang <penghuang@google.com> on 2012-11-05
Reviewed by Alexey Proskuryakov.
Add media keyboard support on Linux gtk platform.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
- 2:52 PM Changeset in webkit [133530] by
-
- 4 edits4 copies in trunk/Source/WebKit2
Begin stubbing out the new remote layer tree drawing area
https://bugs.webkit.org/show_bug.cgi?id=101256
Reviewed by Andreas Kling.
- Shared/DrawingAreaInfo.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/DrawingArea.cpp:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
- 2:39 PM Changeset in webkit [133529] by
-
- 10 edits70 adds in trunk
Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235
Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.
See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
Source/WebCore:
Web exposed changes include:
(1) The default (initial) value for -webkit-line-break becomes 'auto', instead of 'normal';
(2) The values 'auto', 'loose', 'normal', and 'strict' are added to -webkit-line-break;
(3) See [2] above for details regarding interpretation.
Tests: css3/line-break/line-break-auto-centered.html
css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().
- rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.
- rendering/RenderText.h:
(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
- rendering/break_lines.cpp:
(WebCore):
Introduce two (local) enums NBSPBehavior and LooseBehavior for expanding template on nextBreakablePosition
to include loose mode parameter.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Introduce loose mode behavior template parameter to optimize loose mode behavior code path in order
to prevent regression to non loose mode path.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use new template parameter enums described above.
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::nextBreakablePositionLoose):
Introduce two additional 'loose' mode flavors of NBP template expansions.
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.
LayoutTests:
- css3/line-break/line-break-auto-centered-expected.html: Added.
- css3/line-break/line-break-auto-centered.html: Added.
- css3/line-break/line-break-auto-half-kana-expected.html: Added.
- css3/line-break/line-break-auto-half-kana.html: Added.
- css3/line-break/line-break-auto-hyphens-expected.html: Added.
- css3/line-break/line-break-auto-hyphens.html: Added.
- css3/line-break/line-break-auto-inseparables-expected.html: Added.
- css3/line-break/line-break-auto-inseparables.html: Added.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
- css3/line-break/line-break-auto-iteration-marks.html: Added.
- css3/line-break/line-break-auto-postfixes-expected.html: Added.
- css3/line-break/line-break-auto-postfixes.html: Added.
- css3/line-break/line-break-auto-prefixes-expected.html: Added.
- css3/line-break/line-break-auto-prefixes.html: Added.
- css3/line-break/line-break-auto-sound-marks-expected.html: Added.
- css3/line-break/line-break-auto-sound-marks.html: Added.
- css3/line-break/line-break-loose-centered-expected.html: Added.
- css3/line-break/line-break-loose-centered.html: Added.
- css3/line-break/line-break-loose-half-kana-expected.html: Added.
- css3/line-break/line-break-loose-half-kana.html: Added.
- css3/line-break/line-break-loose-hyphens-expected.html: Added.
- css3/line-break/line-break-loose-hyphens.html: Added.
- css3/line-break/line-break-loose-inseparables-expected.html: Added.
- css3/line-break/line-break-loose-inseparables.html: Added.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
- css3/line-break/line-break-loose-iteration-marks.html: Added.
- css3/line-break/line-break-loose-postfixes-expected.html: Added.
- css3/line-break/line-break-loose-postfixes.html: Added.
- css3/line-break/line-break-loose-prefixes-expected.html: Added.
- css3/line-break/line-break-loose-prefixes.html: Added.
- css3/line-break/line-break-loose-sound-marks-expected.html: Added.
- css3/line-break/line-break-loose-sound-marks.html: Added.
- css3/line-break/line-break-normal-centered-expected.html: Added.
- css3/line-break/line-break-normal-centered.html: Added.
- css3/line-break/line-break-normal-half-kana-expected.html: Added.
- css3/line-break/line-break-normal-half-kana.html: Added.
- css3/line-break/line-break-normal-hyphens-expected.html: Added.
- css3/line-break/line-break-normal-hyphens.html: Added.
- css3/line-break/line-break-normal-inseparables-expected.html: Added.
- css3/line-break/line-break-normal-inseparables.html: Added.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
- css3/line-break/line-break-normal-iteration-marks.html: Added.
- css3/line-break/line-break-normal-postfixes-expected.html: Added.
- css3/line-break/line-break-normal-postfixes.html: Added.
- css3/line-break/line-break-normal-prefixes-expected.html: Added.
- css3/line-break/line-break-normal-prefixes.html: Added.
- css3/line-break/line-break-normal-sound-marks-expected.html: Added.
- css3/line-break/line-break-normal-sound-marks.html: Added.
- css3/line-break/line-break-strict-centered-expected.html: Added.
- css3/line-break/line-break-strict-centered.html: Added.
- css3/line-break/line-break-strict-half-kana-expected.html: Added.
- css3/line-break/line-break-strict-half-kana.html: Added.
- css3/line-break/line-break-strict-hyphens-expected.html: Added.
- css3/line-break/line-break-strict-hyphens.html: Added.
- css3/line-break/line-break-strict-inseparables-expected.html: Added.
- css3/line-break/line-break-strict-inseparables.html: Added.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
- css3/line-break/line-break-strict-iteration-marks.html: Added.
- css3/line-break/line-break-strict-postfixes-expected.html: Added.
- css3/line-break/line-break-strict-postfixes.html: Added.
- css3/line-break/line-break-strict-prefixes-expected.html: Added.
- css3/line-break/line-break-strict-prefixes.html: Added.
- css3/line-break/line-break-strict-sound-marks-expected.html: Added.
- css3/line-break/line-break-strict-sound-marks.html: Added.
- platform/chromium/css3/line-break/line-break-auto-half-kana-expected.html: Added.
- platform/chromium/css3/line-break/line-break-auto-sound-marks-expected.html: Added.
Override reftest expectations on chromium due to different ICU auto behavior.
- platform/chromium-android/css3/line-break/line-break-auto-half-kana-expected.html: Added.
- platform/chromium-android/css3/line-break/line-break-auto-sound-marks-expected.html: Added.
Override override of reftest expectations on chromium due to different ICU auto behavior;
that is, chromium-android seems to follow the generic expectations.
- 2:34 PM Changeset in webkit [133528] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] screenX/Y gives wrong values
https://bugs.webkit.org/show_bug.cgi?id=101259
Reviewed by Yong Li.
PR 237071
Reviewed internally by Gen Mak.
Do not transform screenPos coordinates.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- 2:32 PM Changeset in webkit [133527] by
-
- 11 edits in trunk
webkitRegionLayoutUpdate is incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=100335
Reviewed by Ojan Vafai.
Source/WebCore:
DOM event names are supposed to be lower case.
- dom/EventNames.h:
(WebCore):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
LayoutTests:
Update tests to use the proper name.
- fast/regions/webkit-named-flow-event-add-to-flow.html:
- fast/regions/webkit-named-flow-event-no-regions.html:
- fast/regions/webkit-named-flow-event-remove-from-dom.html:
- fast/regions/webkit-named-flow-event-remove-from-flow.html:
- fast/regions/webkit-named-flow-event-target.html:
- fast/regions/webkit-named-flow-event-to-null.html:
- fast/regions/webkit-named-flow-event.html:
- 2:15 PM Changeset in webkit [133526] by
-
- 33 edits3 deletes in trunk/Source
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110
Reviewed by Kentaro Hara.
Source/WebCore:
This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.
To achieve this goal, this patch hides the details of how we map from
objects to wrappers inside DOMDataStore and then removes the
IntrusiveDOMWrapperMap class entirely. This approach lets us remove the
DOMWrapperMap base class and make all of these functions non-virtual.
- UseV8.cmake:
- WebCore.gypi:
- Remove deleted files.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
- Rather than grabbing at the DOMWrapperMap directly, we now ask the DOMDataStore to do this work for us.
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::wrap):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::wrap):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::wrap):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::wrap):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::wrap):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::wrap):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::wrap):
- bindings/v8/DOMDataStore.cpp:
- Updated run-bindings-test results.
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
- Simplify constructor and destructor now that there is only one hash map.
(WebCore::DOMDataStore::current):
- Now that V8DOMMap.cpp doesn't handle the null isolate case, we need to handle it here.
(WebCore::DOMDataStore::reportMemoryUsage):
- Simplfied now that there is only one wrapper map.
(WebCore::DOMDataStore::weakCallback):
- Moved from IntrusiveDOMWrapperMap.h
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
- These functions now handle the intrusive case with a branch rather than with a virtual function call. In many cases, the branch can be optimized away by the compiler when the overloaded inline functions are inlined.
(WebCore::DOMDataStore::wrapperIsStoredInObject):
- Overloaded functions to determine whether to store the wrapper inside the object or in the hashmap.
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::storeWrapperInObject):
- Overloaded functions to get/set the wrapper from inside the object itself.
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperHashMap::get):
(WebCore::DOMWrapperHashMap::set):
(WebCore::DOMWrapperHashMap::clear):
(WebCore::DOMWrapperHashMap::reportMemoryUsage):
(WebCore::DOMWrapperHashMap::remove):
- These functions are no longer virtual.
- bindings/v8/DOMWrapperWorld.h:
- bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
- bindings/v8/ScriptProfiler.cpp:
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::neuterBinding):
- We need to keep the type information slightly longer so that we look in the right wrapper map.
- bindings/v8/V8DOMMap.cpp: Removed.
- bindings/v8/V8DOMMap.h: Removed.
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- Defer this work to the store.
(WebCore::V8DOMWrapper::setWrapperClass):
- An overloaded function to set the right wrapper class.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- This function is now general enough to handle ever kind of object.
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerScriptController.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- Call the more general function (instead of the now-deleted specialized function).
Source/WebKit/chromium:
- src/WebScriptController.cpp:
- Remove unneeded include of deleted file.
- 2:11 PM Changeset in webkit [133525] by
-
- 2 edits in trunk/LayoutTests
Remove fast/forms/week-multiple-fields from
platform/mac/TestExpectations, since it no longer exists and makes the
style script complain. Unreviewed.
- platform/mac/TestExpectations:
- 2:07 PM Changeset in webkit [133524] by
-
- 20 edits1 delete in trunk
Get rid of setCookieStoragePrivateBrowsingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=101247
Reviewed by Brady Eidson.
We were only doing anything here on Mac, and only because we couldn't know if
sessions were in use. But sessions are always in use, and those obsolete changing
cookie storage explicitly.
- platform/network/win/CookieStorageWin.cpp: Removed.
- PlatformWinCE.cmake:
- WebCore.gypi: No more CookieStorageWin.cpp with an empty implementation.
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm: We no longer need this WKSI function.
- page/Settings.cpp: (WebCore::Settings::setPrivateBrowsingEnabled): Removed the only call to setCookieStoragePrivateBrowsingEnabled().
- platform/network/CookieStorage.h:
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/curl/CookieJarCurl.cpp:
- platform/network/soup/CookieStorageSoup.cpp:
- platform/qt/TemporaryLinkStubsQt.cpp: Removed empty setCookieStoragePrivateBrowsingEnabled implementations.
- platform/network/mac/CookieStorageMac.mm: This function used to have a FIXME that we should observe private storage while in private browsing mode. I don't think that it was correct - Safari doesn't display content of private storage, and thus doesn't need to know about changes. The removal of this function has an effect on WebKit1 clients that enable private browsing. We used to globally change cookie storage, even for loads not initiated by WebKit. Now we match API description: "If private browsing is enabled, WebKit will not store information about sites the user visits."
- 2:03 PM Changeset in webkit [133523] by
-
- 2 edits in trunk/LayoutTests
[chromium] Give actual bug IDs to some past gardening. Unreviewed.
- platform/chromium/TestExpectations:
- 1:59 PM Changeset in webkit [133522] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not display error page for failed downloads
https://bugs.webkit.org/show_bug.cgi?id=101246
Internal PR: 236318
Internal reviewed by Joe Mason, Leo Yang.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by Rob Buis.
Right now when a main load, including all downloads, failed, it will
display an error page. This is not very user friendly, especially for
WebWorks application, which want to use its own user interface to info
user about the failure.
So we just stop displaying error page for downloads.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 1:51 PM Changeset in webkit [133521] by
-
- 41 edits2 adds in trunk
Crash when mixing layers, foreignObjects and SVG hidden containers
https://bugs.webkit.org/show_bug.cgi?id=87297
Reviewed by Dirk Schulze.
Source/WebCore:
Foreign objects may introduce content which requires layers, but layer creation is
suppressed within RenderSVGHiddenContainer subtrees and this yields an inconsistent render
tree state. This patch prevents foreignObject renderer instantiation under
RenderSVGHiddenContainers.
Test: svg/foreignObject/foreign-object-defs-crash.svg
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
(WebCore):
- svg/SVGForeignObjectElement.h:
(SVGForeignObjectElement):
LayoutTests:
- platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/chromium/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/chromium/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
- svg/foreignObject/foreign-object-defs-crash-expected.txt: Added.
- svg/foreignObject/foreign-object-defs-crash.svg: Added.
- svg/foreignObject/text-tref-02-b-expected.txt:
- 1:43 PM Changeset in webkit [133520] by
-
- 2 edits in trunk/Source/WebCore
Remove the unused m_fixedPositionedElements from RenderView
https://bugs.webkit.org/show_bug.cgi?id=101251
Reviewed by Anders Carlsson.
m_fixedPositionedElements was completely unused. Remove it
and the related typedef.
- rendering/RenderView.h:
(RenderView):
- 1:38 PM Changeset in webkit [133519] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark several compositing tests as only failing Image
and not Text, after r133513. Unreviewed.
- platform/chromium/TestExpectations:
- 1:25 PM Changeset in webkit [133518] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166
Unskip now passing tests after r133513.
- platform/qt-5.0-wk2/TestExpectations:
- 1:07 PM Changeset in webkit [133517] by
-
- 46 edits in trunk/Source
Fix layer borders to cleaning appear and disappear on switching
https://bugs.webkit.org/show_bug.cgi?id=101136
Source/WebCore:
Reviewed by Sam Weinig.
GraphicsLayers decided whether to show layer borders based
on a callback through the GraphicsLayerClient. This made it
hard to manage state, resulting in a failure to cleanly
hide layers when toggled off via the preference.
Changed the layer border and repaint counter visibility to be bits
stored on GraphicsLayer just like other properties, with getters
and setters. RenderLayerBacking now updates these debug
indicators when we update other compositing layer properties.
In GraphicsLayerCA, avoid calling updateDebugIndicators() explicitly
in several places by setting the change flag DebugIndicatorsChanged
for properties whose values affect the appearance of the debug border.
Removed the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter() which are no longer required.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::updateDebugIndicators):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setShowDebugBorder):
(WebCore::GraphicsLayer::isShowingDebugBorder):
(WebCore::GraphicsLayer::setShowRepaintCounter):
(WebCore::GraphicsLayer::isShowingRepaintCounter):
(WebCore::GraphicsLayer::repaintCount):
(WebCore::GraphicsLayer::incrementRepaintCount):
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setMasksToBounds):
(WebCore::GraphicsLayerCA::setDrawsContent):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateDebugBorder):
(WebCore::GraphicsLayerCA::setShowDebugBorder):
(WebCore::GraphicsLayerCA::setShowRepaintCounter):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::setupContentsLayer):
(WebCore::GraphicsLayerCA::cloneLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
(WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
Source/WebKit/blackberry:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- Api/WebOverlay_p.h:
(WebOverlayPrivateWebKitThread):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
- Api/WebPage_p.h:
- WebKitSupport/DefaultTapHighlight.cpp:
- WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
- WebKitSupport/InspectorOverlayBlackBerry.cpp:
- WebKitSupport/InspectorOverlayBlackBerry.h:
(InspectorOverlay):
- WebKitSupport/SelectionOverlay.cpp:
- WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):
Source/WebKit/chromium:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- src/NonCompositedContentHost.cpp:
- src/NonCompositedContentHost.h:
(NonCompositedContentHost):
- src/PageOverlay.cpp:
- tests/GraphicsLayerChromiumTest.cpp:
- tests/ImageLayerChromiumTest.cpp:
Source/WebKit/gtk:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
- WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Source/WebKit/win:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- WebView.cpp:
- WebView.h:
Source/WebKit2:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
- WebProcess/WebPage/ca/LayerTreeHostCA.h:
(LayerTreeHostCA):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
- 12:49 PM Changeset in webkit [133516] by
-
- 3 edits in trunk/Source
[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=101016
Reviewed by Adrienne Walker.
Passing SkBitmap by value requires including SkBitmap.h, which is tricky for some clients to do since it
requires having the rest of skia's headers on the include path and setting up the correct config to set
preprocessor defines. Also shuffles the parameter order around to make rolling easier since you can't override
just by const ref-ness.
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::setFontAtlas):
- 12:40 PM Changeset in webkit [133515] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Input date should not popup dialog when readonly is set
https://bugs.webkit.org/show_bug.cgi?id=101234
Reviewed by Yong Li.
PR 236114
Reviewed internally by Mike Fenton.
Suppress popup dialog if the input element has readonly attribute set.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):
- 12:36 PM Changeset in webkit [133514] by
-
- 3 edits in branches/chromium/1312/Source/WebCore
Merge 133262 - Build fix. http://trac.webkit.org/changeset/133252 broke the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=101008
Reviewed by fischman@chromium.org.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
TBR=roger_fong@apple.com
Review URL: https://codereview.chromium.org/11368088
- 12:36 PM Changeset in webkit [133513] by
-
- 3 edits in trunk/LayoutTests
[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166
The platform-independent results should not contain visibleRect, since this is
only dumped on Mac.
- compositing/tiling/rotated-tiled-clamped-expected.txt:
- compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- 12:34 PM Changeset in webkit [133512] by
-
- 4 edits1 copy in branches/chromium/1312
Merge 133252 - HTMLMediaPlayer should free m_player when src is set/changed
https://bugs.webkit.org/show_bug.cgi?id=99647
Reviewed by Eric Carlson.
.:
- ManualTests/media-players-are-dropped-on-error.html: Added.
Various scenarios are tested to make sure players aren't
leaked in different ways for each of them.
Source/WebCore:
New ManualTest added; manual since leaking media players doesn't have layoutTestController-visible effects.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): clearMediaPlayer() when src is set/changed
(WebCore::HTMLMediaElement::userCancelledLoad): use new clearMediaPlayer() helper
(WebCore::HTMLMediaElement::clearMediaPlayer): clear m_player and associated timers/flags
(WebCore):
(WebCore::HTMLMediaElement::createMediaPlayer): whitespace-only change
- html/HTMLMediaElement.h: new method: createMediaPlayer().
(HTMLMediaElement):
TBR=fischman@chromium.org
Review URL: https://codereview.chromium.org/11275156
- 12:28 PM Changeset in webkit [133511] by
-
- 13 edits in trunk/LayoutTests
Rebaseline some Lion results that were affected by enabling subpixel layout.
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/mac-lion/fast/text/international/hindi-spacing-expected.txt:
- platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt:
- 11:47 AM Changeset in webkit [133510] by
-
- 3 edits in trunk/Tools
webkitpy: lint, clean up rebaseline.py
https://bugs.webkit.org/show_bug.cgi?id=101240
Reviewed by Ojan Vafai.
Miscellaneous cleanup of lint errors and warnings.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(RebaselineTest._test_root):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines.init):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._builders_to_fetch_from):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineExpectations.init):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase.setUp):
(TestAnalyzeBaselines.setUp):
- 11:28 AM Changeset in webkit [133509] by
-
- 5 edits in trunk/Tools
webkit-patch optimize-baselines should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97623
Reviewed by Ojan Vafai.
So that we can optionally limit/control which platforms' results
are affected.
This patch adds --platform to analyze-baselines as well.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(_baseline_search_hypergraph):
(BaselineOptimizer.init):
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(TestBaselineOptimizer.init):
(BaselineOptimizerTest.test_move_baselines):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(OptimizeBaselines.init):
(OptimizeBaselines.execute):
(AnalyzeBaselines.init):
(AnalyzeBaselines.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):
- 11:26 AM Changeset in webkit [133508] by
-
- 4 edits1 add in trunk/Tools
webkit-patch rebaseline-expectations should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97621
Reviewed by Ojan Vafai.
So that we can limit which platforms we attempt to rebaseline;
this can reduce the noise the command produces if some ports
have errors or warnings in their TestExpectations files and/or
help produce more predictable results.
In testing this patch, I realized that the rebaseline-in-parallel
commands (rebaseline-json, rebaseline-expectations, etc.) can
cause multiple rebaseline-test-internal commands to attempt to
modify the TestExpectations files concurrently, and that we needed
to lock the files to prevent corruption; it would be nice if
we can split the updating-the-expectations-files out separately
from updating the filesystem (much like we do with the scm updates)
to avoid this concurrency.
- Scripts/webkitpy/common/system/file_lock_mock.py: Added.
(MockFileLock):
(MockFileLock.init):
(MockFileLock.acquire_lock):
(MockFileLock.release_lock):
- Scripts/webkitpy/common/system/systemhost.py:
(SystemHost.copy_current_environment):
(SystemHost):
(SystemHost.make_file_lock):
- Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost.copy_current_environment):
(MockSystemHost):
(MockSystemHost.make_file_lock):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineExpectations.init):
(RebaselineExpectations._add_tests_to_rebaseline_for_port):
(RebaselineExpectations.execute):
- 11:24 AM Changeset in webkit [133507] by
-
- 5 edits in trunk/Tools
webkitpy: clean up options for specifying multiple platforms at once
https://bugs.webkit.org/show_bug.cgi?id=101140
Reviewed by Ojan Vafai.
This patch reworks how we display the help strings for --platform
options and how we filter out platforms matching a glob. This will
be useful as I add patches to ensure that all the webkit-patch
commands are using --platform consistently to filter ports.
There should be no functional changes resulting from this patch.
- Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory.all_port_names):
(PortFactory.get_from_builder_name):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.init):
(PrintBaselines.init):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(RebaselineJson.init):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.setUp):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 11:21 AM Changeset in webkit [133506] by
-
- 2 edits in trunk/Tools
The layout test runner shouldn't wait for data if stdout/stderr have been closed
https://bugs.webkit.org/show_bug.cgi?id=101233
Reviewed by Dirk Pranke.
Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
has crashed during a Chromium Android layout test-run, which uses FIFOs for
communication, causes the File.fileno() method to raise a ValueError. Return early
if either of the pipes has already been closed.
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):
- 11:17 AM Changeset in webkit [133505] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101235
Reviewed by Ojan Vafai.
It didn't get updated to handle the change in parsing --suffixes
properly, and the unit test didn't get updated either, masking the
problem.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._tests_to_update):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline):
- 11:12 AM Changeset in webkit [133504] by
-
- 5 edits in trunk/Tools
lint-webkitpy doesn't autoinstall pylint properly.
https://bugs.webkit.org/show_bug.cgi?id=101106
Reviewed by Ojan Vafai.
Re-land r133381 with fix; ironically, lint-webkitpy would've
complained about the problem. Also modify pylintrc and clean up
any other lint errors in the modified files.
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._set_up_target_dir):
(AutoInstaller):
(AutoInstaller._make_package):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
- Scripts/webkitpy/pylintrc:
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook):
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_webpagereplay):
(AutoinstallImportHook._install):
- Scripts/webkitpy/thirdparty/init_unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):
- 11:10 AM Changeset in webkit [133503] by
-
- 6 edits in trunk/Source/WebKit/chromium
Expose hit test related methods in public chromium port
https://bugs.webkit.org/show_bug.cgi?id=101204
Patch by Bo Liu <boliu@chromium.org> on 2012-11-05
Reviewed by Adam Barth.
The methods are needed in implementating hit test related methods in the
Android WebView API.
The specific methods are:
[Web]HitTestResult::urlElement
[Web]HitTestResult::absoluteImageURL
[Web]HitTestResult::absoluteLinkURL
[Web]HitTestResult::isContentEditable
WebViewImpl::hitTestResultAt
- public/WebHitTestResult.h:
(WebKit):
(WebHitTestResult):
- public/WebView.h:
(WebKit):
(WebView):
- src/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::urlElement):
(WebKit):
(WebKit::WebHitTestResult::absoluteImageURL):
(WebKit::WebHitTestResult::absoluteLinkURL):
(WebKit::WebHitTestResult::isContentEditable):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hitTestResultAt):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 11:09 AM Changeset in webkit [133502] by
-
- 4 edits in trunk/Source
[BLACKBERRY] Update touch code to reflect touch refactor
https://bugs.webkit.org/show_bug.cgi?id=101227
Patch by Genevieve Mak <gmak@rim.com> on 2012-11-05
Reviewed by Rob Buis.
PR #2706785
Reviewed Internally by: Mike Lattanzio
Source/WebCore:
- platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::touchEventType):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
- 11:08 AM Changeset in webkit [133501] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark css3/filters/custom/custom-filter-animation.html
as timing out intermittently. Unreviewed.
- platform/chromium/TestExpectations:
- 10:59 AM Changeset in webkit [133500] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r125353. <rdar://problem/12536410>
- 10:56 AM Changeset in webkit [133499] by
-
- 12 edits in trunk/Source
[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083
Reviewed by Stephen White.
Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.
Source/Platform:
- chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):
(WebKit::WebContentLayerClient::paintContents):
Source/WebCore:
No new tests needed. This patch does not change anything functionally.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::paint):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):
Source/WebKit/chromium:
- src/LinkHighlight.cpp:
(WebKit::LinkHighlight::paintContents):
- src/LinkHighlight.h:
(LinkHighlight):
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):
- src/NonCompositedContentHost.h:
(NonCompositedContentHost):
- tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):
- 10:55 AM WebKit Team edited by
- Add aboxhall and dmazzoni to the Committers list (already in committers.py) (diff)
- 10:51 AM Changeset in webkit [133498] by
-
- 10 edits2 copies in branches/safari-536.28-branch
Merged r125351. <rdar://problem/12536410>
- 10:51 AM Changeset in webkit [133497] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Build fix after http://trac.webkit.org/changeset/133488.
Removed a deleted file. Unreviewed.
- WebCore.gypi:
- 10:42 AM WebKit Team edited by
- (diff)
- 10:41 AM Changeset in webkit [133496] by
-
- 2 edits in trunk/Source/WebCore
[V8] toV8(impl) should return null if impl is 0
https://bugs.webkit.org/show_bug.cgi?id=101206
Reviewed by Adam Barth.
toV8(impl) should return null if impl is 0. However,
V8HTMLCollection::toV8() does not have the null check.
All other toV8()s return null.
No tests. I think there will be no call path that hits the change.
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- 10:18 AM Changeset in webkit [133495] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 10:17 AM Changeset in webkit [133494] by
-
- 4 edits in trunk
Implement SimpleFontData::platformBoundsForGlyph on skia
https://bugs.webkit.org/show_bug.cgi?id=101115
Reviewed by Eric Seidel.
Source/WebCore:
The implementation is similar to SimpleFontData::platformWidthForGlyph on skia.
Tested by: fast/block/lineboxcontain/*glyphs*, mathml/presentation/*
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.
LayoutTests:
Some lineboxcontain/etc. tests will need rebaselining.
- platform/chromium/TestExpectations:
- 10:15 AM Changeset in webkit [133493] by
-
- 16 edits in trunk/Source/JavaScriptCore
Reduce the verbosity of referring to QNaN in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=101174
Reviewed by Geoffrey Garen.
Introduces a #define QNaN in JSValue.h, and replaces all previous uses of
std::numeric_limits<double>::quiet_NaN() with QNaN.
- API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitFloatTypedArrayGetByVal):
- runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
- runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
- runtime/JSCell.h:
(JSC::JSValue::getPrimitiveNumber):
- runtime/JSDateMath.cpp:
(JSC::parseDateFromNullTerminatedCharacters):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
(JSC::parseFloat):
- runtime/JSValue.cpp:
(JSC::JSValue::toNumberSlowCase):
- runtime/JSValue.h:
(JSC):
- runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
- 10:06 AM Changeset in webkit [133492] by
-
- 7 edits in trunk/Source/WebCore
Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>
Reviewed by Antti Koivisto.
Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.
Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.
- dom/Element.h:
- dom/ElementAttributeData.h:
- dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):
Move everything Attr-related into Element.cpp while simplifying some loops and remove
conditions that are no longer needed as they used to depend on having an attributeData().
- dom/Node.h:
(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):
Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().
- dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
Remove awkward indirection and let the call site deal with removing the Attr node from
the Element's list of Attr nodes.
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::clearAttributes):
Remove now-unused Element* argument.
- 10:01 AM Changeset in webkit [133491] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip a now passing test.
- platform/qt-5.0-wk1/TestExpectations:
- 9:53 AM Changeset in webkit [133490] by
-
- 4 edits4 adds in trunk
[CSS Exclusions] Polygon edges should span colinear vertices
https://bugs.webkit.org/show_bug.cgi?id=99343
Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.
Source/WebCore:
ExclusionPolygonEdges now span coincident and collinear vertices. Currently
pairs of vertices are only considered coincident if their coordinates are exactly
equal. Similarly, a vertex is only considered collinear with an edge if the area
of the triangle defined by the three vertices is exactly zero. In the future it
may be useful to relax the comparison with zero.
Tests: fast/exclusions/shape-inside/shape-inside-coincident-vertices.html
fast/exclusions/shape-inside/shape-inside-collinear-vertices.html
- rendering/ExclusionPolygon.cpp:
(WebCore::determinant): Used to measure collinearity.
(WebCore):
(WebCore::areCollinearPoints): True if three FloatPoint arguments are collinear per the test outlined above.
(WebCore::areCoincidentPoints): True if the two FloatPoint arguments are equal.
(WebCore::nextVertexIndex): The next vertex index in clockwise or counterclockwise order.
(WebCore::ExclusionPolygon::findNextEdgeVertexIndex): Return the index of the next non-coincident, non-collinear vertex.
(WebCore::ExclusionPolygon::ExclusionPolygon): Skip coincident and collinear vertices when building the list of edges.
- rendering/ExclusionPolygon.h: Added private findNextEdgeVertexIndex() declaration.
LayoutTests:
Verify that exclusion polygonal shape-inside layout is unaffected by coincident
or collinear vertices.
- fast/exclusions/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-coincident-vertices.html: Added.
- fast/exclusions/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-collinear-vertices.html: Added.
- 9:37 AM Changeset in webkit [133489] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r125315. <rdar://problem/12536439>
- 9:33 AM Changeset in webkit [133488] by
-
- 2 edits1 delete in trunk/Source/WebCore
[EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile()
https://bugs.webkit.org/show_bug.cgi?id=101228
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Get rid of EFL-specific implementation of SharedBuffer::createWithContentsOfFile()
and reuse the POSIX one since it is pretty much the same.
No new tests, no behavior change.
- PlatformEfl.cmake:
- platform/efl/SharedBufferEfl.cpp: Removed.
- 9:25 AM Changeset in webkit [133487] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip now passing tests.
- platform/qt/TestExpectations:
- 9:22 AM Changeset in webkit [133486] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html
as also crashy, and give it a bug ID. Unreviewed.
- platform/chromium/TestExpectations:
- 8:57 AM Changeset in webkit [133485] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r125237. <rdar://problem/12536461>
- 8:48 AM Changeset in webkit [133484] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r125234. <rdar://problem/12536433>
- 8:32 AM Changeset in webkit [133483] by
-
- 3 edits in trunk/Source/WebCore
Add a comment about a return value of IDBKey::toV8()
https://bugs.webkit.org/show_bug.cgi?id=101212
Reviewed by Adam Barth.
Although all other toV8(impl) return null when impl is 0,
IDBKey::toV8(impl) is expected to return undefined when impl is 0.
This patch adds a comment about it.
No tests.
- bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- 8:23 AM Changeset in webkit [133482] by
-
- 6 edits6 adds in trunk
[Cairo] Make Cairo honor image orientation
https://bugs.webkit.org/show_bug.cgi?id=101207
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Implement transformed image drawing in BitmapImageCairo, similar
as it was done for Skia in bug 100179, r132384.
The image drawing code needs to transform the graphics context
depending on exif orientation in order for this to work.
No new tests, covered by fast/images/exif-* which are passing now.
- platform/graphics/BitmapImage.h: Enable draw function which respects image orientation for Cairo.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw): Apply ImageOrientation's transformFromDefault() transformation to context.
(WebCore):
LayoutTests:
Unskip and rebaseline exif orientation tests for EFL.
- platform/efl-wk1/TestExpectations: Tests not passing here yet, since DRT needs a setShouldRespectImageOrientation setting.
- platform/efl/TestExpectations: Unskipping three exif orientation tests.
- platform/efl/fast/images/exif-orientation-css-expected.png: Added.
- platform/efl/fast/images/exif-orientation-css-expected.txt: Added.
- platform/efl/fast/images/exif-orientation-expected.png: Added.
- platform/efl/fast/images/exif-orientation-expected.txt: Added.
- platform/efl/fast/images/exif-orientation-image-document-expected.png: Added.
- platform/efl/fast/images/exif-orientation-image-document-expected.txt: Added.
- 8:20 AM Changeset in webkit [133481] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r125176. <rdar://problem/12516381>
- 8:16 AM Changeset in webkit [133480] by
-
- 5 edits4 copies in branches/safari-536.28-branch
Merged r125162. <rdar://problem/12536458>
- 8:14 AM Changeset in webkit [133479] by
-
- 9 edits in trunk/Source/WebCore
[V8] Dispose() and Clear() should be always coupled for safety
https://bugs.webkit.org/show_bug.cgi?id=101191
Reviewed by Adam Barth.
Clear() is not mandatory. However, to avoid misusing already
disposed wrappers, Clear() should be always called just
after Dispose().
No tests. No change in behavior.
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperHashMap::defaultWeakCallback):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::weakCallback):
- bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::dispose):
(WebCore::weakNPObjectCallback):
(WebCore::forgetV8ObjectForNPObject):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
- bindings/v8/V8ValueCache.cpp:
(WebCore::cachedStringCallback):
(WebCore::IntegerCache::~IntegerCache):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):
- 7:56 AM Changeset in webkit [133478] by
-
- 11 edits2 copies in branches/safari-536.28-branch
Merged r125147. <rdar://problem/12536499>
- 7:42 AM Changeset in webkit [133477] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
https://bugs.webkit.org/show_bug.cgi?id=101213
RIM PR 178131
Reviewed by Rob Buis.
Internally Reviewed by Arvid Nilsson.
Added compositing events to the timeline for BlackBerry.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didComposite):
- Api/WebPage_p.h:
(WebPagePrivate):
- 7:29 AM Changeset in webkit [133476] by
-
- 12 edits in branches/safari-536.28-branch/Source
Merged r125091. <rdar://problem/12486152>
- 7:25 AM Changeset in webkit [133475] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Layout of the first shape-inside line can be incorrect
https://bugs.webkit.org/show_bug.cgi?id=100996
Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.
Source/WebCore:
Made the conversion from floating point top/bottom logical shape bounds coordinates
LayoutUnits explicit and corrected the case where the top value was truncated. A
float logicalTop value is converted to LayoutUnit with fromFloatCeil() to ensure
that the LayoutUnit value is within the shape.
Test: fast/exclusions/shape-inside/shape-inside-shape-logical-top.html
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop): Redefined this method in terms of shapeLogicalBoundsY,Max().
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsY): Explicit conversion from floating point shape coordinates to LayoutUnits.
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsMaxY): Ditto.
LayoutTests:
Verify that the first line of shape-inside content is laid out correctly
when the top of the shape's bounds has a non-integral value.
- fast/exclusions/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-shape-logical-top.html: Added.
- 7:20 AM Changeset in webkit [133474] by
-
- 4 edits2 copies in branches/safari-536.28-branch
Merged r125052. <rdar://problem/12536419>
- 7:17 AM Changeset in webkit [133473] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark a flaky test. Unreviewed.
- platform/chromium/TestExpectations:
- 7:14 AM Changeset in webkit [133472] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124924. <rdar://problem/12516358>
- 7:08 AM Changeset in webkit [133471] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add a now-failing test, remove a now-passing test. Unreviewed.
- platform/chromium/TestExpectations:
- 7:06 AM Changeset in webkit [133470] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124919. <rdar://problem/12516354>
- 7:02 AM Changeset in webkit [133469] by
-
- 2 edits in trunk/Source/WebCore
Protect against resource deletion during iteration in MemoryCache::pruneDeadResourcesToSize
https://bugs.webkit.org/show_bug.cgi?id=101211
Reviewed by Andreas Kling.
Some crashes have been seen under MemoryCache::pruneDeadResourcesToSize. A possible cause is that
destroyDecodedData() call ends up evicting the resource pointed by 'previous' pointer during iteration
and deleting the object. This looks in principle possible via stylesheets and SVG images.
Speculative fix, no repro, no obvious way to construct a test.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneDeadResourcesToSize):
Use CachedResourceHandle to protect the 'previous' pointer during iteration. Check if the
resource has been kicked out from the cache during destroyDecodedData() and stop iterating
if has (as it may die when CachedResourceHandle releases it).
The 'current' pointer is not protected as the resource it points to is allowed to die.
- 6:58 AM Changeset in webkit [133468] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124914. <rdar://problem/12536456>
- 6:49 AM Changeset in webkit [133467] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124888. <rdar://problem/12536408>
- 6:41 AM Changeset in webkit [133466] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124843. <rdar://problem/12536452>
- 6:27 AM Changeset in webkit [133465] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=101199
Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-05
Reviewed by Julien Chaffraix.
Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection
until we can implement it properly.
- features.gypi:
- 6:22 AM Changeset in webkit [133464] by
-
- 8 edits2 moves4 adds in trunk/Source/WebKit2
[EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=100674
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Make a distinction between calling ewk_view_base_add and ewk_view_smart_add.
Calling ewk_view_base_add creates a desktop style view, that does not support
fixed layout size, while calling ewk_view_smart_add does support fixed layout size.
As a result, WebKitTestRunner and the inspector window do not support
fixed layout size, while MiniBrowser does. This change allows many DumpAsText
layout tests to pass without modification, when AC is enabled.
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::pageClient):
(EwkViewImpl::setScaleFactor):
(EwkViewImpl::scaleFactor):
(EwkViewImpl::setScrollPosition):
(EwkViewImpl::scrollPosition):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
(createEwkView):
(ewk_view_base_add):
- UIProcess/efl/PageClientBase.cpp: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.cpp.
(WebKit::PageClientBase::PageClientBase):
(WebKit::PageClientBase::~PageClientBase):
(WebKit::PageClientBase::viewImpl):
(WebKit::PageClientBase::createDrawingAreaProxy):
(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::displayView):
(WebKit::PageClientBase::scrollView):
(WebKit::PageClientBase::viewSize):
(WebKit::PageClientBase::isViewWindowActive):
(WebKit::PageClientBase::isViewFocused):
(WebKit::PageClientBase::isViewVisible):
(WebKit::PageClientBase::isViewInWindow):
(WebKit::PageClientBase::processDidCrash):
(WebKit::PageClientBase::didRelaunchProcess):
(WebKit::PageClientBase::pageClosed):
(WebKit::PageClientBase::toolTipChanged):
(WebKit::PageClientBase::setCursor):
(WebKit::PageClientBase::setCursorHiddenUntilMouseMoves):
(WebKit::PageClientBase::registerEditCommand):
(WebKit::PageClientBase::clearAllEditCommands):
(WebKit::PageClientBase::canUndoRedo):
(WebKit::PageClientBase::executeUndoRedo):
(WebKit::PageClientBase::convertToDeviceSpace):
(WebKit::PageClientBase::convertToUserSpace):
(WebKit::PageClientBase::screenToWindow):
(WebKit::PageClientBase::windowToScreen):
(WebKit::PageClientBase::doneWithKeyEvent):
(WebKit::PageClientBase::doneWithTouchEvent):
(WebKit::PageClientBase::createPopupMenuProxy):
(WebKit::PageClientBase::createContextMenuProxy):
(WebKit::PageClientBase::createColorChooserProxy):
(WebKit::PageClientBase::setFindIndicator):
(WebKit::PageClientBase::enterAcceleratedCompositingMode):
(WebKit::PageClientBase::exitAcceleratedCompositingMode):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):
(WebKit::PageClientBase::didChangeScrollbarsForMainFrame):
(WebKit::PageClientBase::didCommitLoadForMainFrame):
(WebKit::PageClientBase::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientBase::customRepresentationZoomFactor):
(WebKit::PageClientBase::setCustomRepresentationZoomFactor):
(WebKit::PageClientBase::flashBackingStoreUpdates):
(WebKit::PageClientBase::findStringInCustomRepresentation):
(WebKit::PageClientBase::countStringMatchesInCustomRepresentation):
(WebKit::PageClientBase::updateTextInputState):
(WebKit::PageClientBase::handleDownloadRequest):
- UIProcess/efl/PageClientBase.h: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.h.
(PageClientBase):
- UIProcess/efl/PageClientDefaultImpl.cpp: Added.
(WebKit):
(WebKit::PageClientDefaultImpl::PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageDidRequestScroll):
(WebKit::PageClientDefaultImpl::didRenderFrame):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
- UIProcess/efl/PageClientDefaultImpl.h: Added.
(WebKit):
(PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::create):
(WebKit::PageClientDefaultImpl::~PageClientDefaultImpl):
- UIProcess/efl/PageClientImpl.cpp: Removed.
- UIProcess/efl/PageClientImpl.h: Removed.
- UIProcess/efl/PageClientLegacyImpl.cpp: Added.
(WebKit):
(WebKit::PageClientLegacyImpl::PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
- UIProcess/efl/PageClientLegacyImpl.h: Added.
(WebKit):
(PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::create):
(WebKit::PageClientLegacyImpl::~PageClientLegacyImpl):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
- UIProcess/efl/PageViewportControllerClientEfl.h:
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):
- 6:15 AM Changeset in webkit [133463] by
-
- 54 edits in trunk/Source/WebCore
Web Inspector: Fix jscompiler cast syntax
https://bugs.webkit.org/show_bug.cgi?id=101066
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-05
Reviewed by Pavel Feldman.
Casts should be in the form of "/ @type {TypeName} */ (expr)" instead of "/ @type {TypeName} */ expr".
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/InjectedScriptSource.js:
(.):
- inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
- inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._uiSourceCodeFormatted):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
(WebInspector.BreakpointManager.Storage):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
- inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._frameAdded):
(WebInspector.ConsoleView.prototype._frameRemoved):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointByURL):
(WebInspector.DebuggerModel.prototype.):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
- inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
- inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView.prototype._sort):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateBreadcrumbIfNeeded):
- inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/ElementsTreeOutline.js:
(.get node):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):
- inspector/front-end/FileContentView.js:
(WebInspector.FileContentView.prototype._metadataReceived):
(WebInspector.FileContentView.FileContentProvider.prototype.requestContent):
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._frameAdded):
(WebInspector.FileSystemModel.prototype._frameNavigated):
(WebInspector.FileSystemModel.prototype._frameDetached):
- inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):
- inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype._appendHrefItems):
- inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.write):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._snapshotReceived):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._frameNavigated):
(WebInspector.IndexedDBModel.prototype._frameDetached):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype.show):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.NavigatorView.prototype._uiSourceCodeFormattedChanged):
- inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog.prototype._onRequestStarted):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkPanel.prototype.reveal):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
- inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
- inspector/front-end/SASSSourceMapping.js:
(rawLocationToUILocation):
- inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
- inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.uiLocation):
- inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.get _worker):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
(WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
- inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeFormattedChanged):
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModelLoader.prototype.write):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
- inspector/front-end/Workspace.js:
(WebInspector.WorkspaceController.prototype._frameAdded):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
- 6:09 AM Changeset in webkit [133462] by
-
- 2 edits in trunk/LayoutTests
[Qt] Fix broken comment in WK2 TestExpectations
Unreviewed fix, just an obviously missing '#' character.
- platform/qt-5.0-wk2/TestExpectations:
- 6:08 AM Changeset in webkit [133461] by
-
- 2 edits in trunk/LayoutTests
fast/events/popup-allowed-from-gesture-initiated-event.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101208
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Close the new popup between each test to make sure the new window
does not mask the buttons and therefore prevent them from being
clicked. This addresses flakiness for this test.
- fast/events/popup-allowed-from-gesture-initiated-event.html:
- 5:43 AM Changeset in webkit [133460] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: render message bubbles in CodeMirror experiment.
https://bugs.webkit.org/show_bug.cgi?id=101164
Reviewed by Vsevolod Vlasov.
It sounds like addLineWidget just makes it happen.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.get if):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype._change):
- inspector/front-end/DefaultTextEditor.js:
(.preventDefaultOnMouseUp):
- inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror .webkit-html-message-bubble):
(.CodeMirror .webkit-html-message-bubble img):
(.CodeMirror .webkit-html-warning-message):
(.CodeMirror .webkit-html-error-message):
- 5:05 AM Changeset in webkit [133459] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
A followup to r133453, adding a baseline for http/tests/inspector/console-websocket-error.html.
- platform/gtk/http/tests/inspector: Added.
- platform/gtk/http/tests/inspector/console-websocket-error-expected.txt: Added.
- 4:47 AM Changeset in webkit [133458] by
-
- 8 edits2 adds in trunk
Validate CSS Device Adaptation properties and resolve shorthands
https://bugs.webkit.org/show_bug.cgi?id=95962
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-05
Reviewed by Alexis Menard.
Source/WebCore:
Add the missing keywords and properties for the viewport at-rule.
Note that we have to mark that we are inside a viewport scope because
some properties are not validated as they would be inside a style
rule. As an example, the semantics of CSSPropertyWidth are completely
different: on a viewport rule, it stands for a shorthand for the
minimum and maximum width.
Test: css3/device-adapt/viewport-properties-validation.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseViewportProperty):
(WebCore::CSSParser::parseViewportShorthand):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
LayoutTests:
Added a test for CSS Device Adaptation property parsing validation.
- css3/device-adapt/viewport-properties-validation-expected.txt: Added.
- css3/device-adapt/viewport-properties-validation.html: Added.
- 4:39 AM Changeset in webkit [133457] by
-
- 18 edits in trunk/Source/WebKit2
[EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101205
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Gyuyoung Kim.
Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data are using common Ewk_Object interface now.
- UIProcess/API/efl/EwkViewImpl.h:
- UIProcess/API/efl/ewk_download_job.cpp:
(Ewk_Download_Job::request):
(Ewk_Download_Job::response):
(Ewk_Download_Job::setResponse):
- UIProcess/API/efl/ewk_download_job_private.h:
(Ewk_Download_Job):
- UIProcess/API/efl/ewk_navigation_data.cpp:
(EwkNavigationData::EwkNavigationData):
(EwkNavigationData::originalRequest):
(EwkNavigationData::title):
(EwkNavigationData::url):
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):
- UIProcess/API/efl/ewk_navigation_data.h:
- UIProcess/API/efl/ewk_navigation_data_private.h:
(EwkNavigationData):
(EwkNavigationData::create):
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(Ewk_Navigation_Policy_Decision::Ewk_Navigation_Policy_Decision):
(Ewk_Navigation_Policy_Decision::request):
- UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
(Ewk_Navigation_Policy_Decision::create):
(Ewk_Navigation_Policy_Decision):
- UIProcess/API/efl/ewk_url_request.cpp:
(EwkUrlRequest::EwkUrlRequest):
(EwkUrlRequest::url):
(EwkUrlRequest::firstParty):
(EwkUrlRequest::httpMethod):
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):
- UIProcess/API/efl/ewk_url_request.h:
- UIProcess/API/efl/ewk_url_request_private.h:
(EwkUrlRequest):
(EwkUrlRequest::create):
- UIProcess/API/efl/ewk_url_response.cpp:
(EwkUrlResponse::EwkUrlResponse):
(EwkUrlResponse::httpStatusCode):
(EwkUrlResponse::url):
(EwkUrlResponse::mimeType):
(EwkUrlResponse::contentLength):
(ewk_url_response_url_get):
(ewk_url_response_status_code_get):
(ewk_url_response_mime_type_get):
(ewk_url_response_content_length_get):
- UIProcess/API/efl/ewk_url_response.h:
- UIProcess/API/efl/ewk_url_response_private.h:
(EwkUrlResponse):
(EwkUrlResponse::create):
- UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::didReceiveResponse):
- UIProcess/efl/ResourceLoadClientEfl.cpp:
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
- 4:23 AM Changeset in webkit [133456] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Remove a few tests which depend on setIsolatedWorldSecurityOrigin
since they are already skipped in efl/TestExpectations.
- platform/efl-wk2/TestExpectations:
- 4:14 AM Changeset in webkit [133455] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389
https://bugs.webkit.org/show_bug.cgi?id=101203
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Attempt for continue without credential when the client cancels
authentication (or does not handle the authentication request)
instead of cancelling the load. We now get a 402 error when
when cancelling the authentication, which is the behavior we
want (and the behavior we used to have before r133389).
- UIProcess/API/efl/ewk_auth_request.cpp:
(Ewk_Auth_Request::~Ewk_Auth_Request):
(Ewk_Auth_Request::continueWithoutCredential):
(ewk_auth_request_cancel):
- UIProcess/API/efl/ewk_auth_request_private.h:
(Ewk_Auth_Request):
- UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
(TEST_F):
- 3:50 AM Changeset in webkit [133454] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/forms/week-multiple-fields does not exist and should be removed from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=101202
Unreviewed EFL gardening.
Remove fast/forms/week-multiple-fields from TestExpections since it does
not exist and makes the style script complain.
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
- platform/efl/TestExpectations:
- 3:43 AM Changeset in webkit [133453] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Clean up the inspector-related test expectations. Instead of marking
many tests as skipped, proper failure expectations are put in place.
The tests are still being skipped as their current behavior on the
buildbots is unknown.
- platform/gtk/TestExpectations:
- 2:57 AM Changeset in webkit [133452] by
-
- 2 edits in trunk/Tools
[EFL] Fix build warning in EWebLauncher/main.c
https://bugs.webkit.org/show_bug.cgi?id=101197
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Kentaro Hara.
Because the strp of _Ecore_Getopt_Value is char (Ecore_Getopt.h),
The parameter of ECORE_GETOPT_VALUE_STR should be char*
- EWebLauncher/main.c:
(_User_Arguments):
- 2:47 AM Changeset in webkit [133451] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r133286, r133385, and r133394.
http://trac.webkit.org/changeset/133286
http://trac.webkit.org/changeset/133385
http://trac.webkit.org/changeset/133394
https://bugs.webkit.org/show_bug.cgi?id=101198
Broke image placement on some web sites. (Requested by kling
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-05
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):
- dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
- dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::cloneAttributesFromElement):
- dom/Element.h:
(Element):
(WebCore::Element::updateInvalidAttributes):
- dom/ElementAttributeData.cpp:
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore):
(WebCore::attrListMap):
(WebCore::attrListForElement):
(WebCore::ensureAttrListForElement):
(WebCore::removeAttrListForElement):
(WebCore::findAttrInList):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::getAttributeNode):
- dom/ElementAttributeData.h:
(WebCore):
(WebCore::ElementAttributeData::attributeStyle):
(WebCore::ElementAttributeData::setAttributeStyle):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
- dom/Node.h:
(WebCore):
(WebCore::Node::hasAttrList):
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):
(Node):
(WebCore::Node::setHasAttrList):
(WebCore::Node::clearHasAttrList):
(WebCore::Node::isStyleAttributeValid):
(WebCore::Node::setIsStyleAttributeValid):
(WebCore::Node::clearIsStyleAttributeValid):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::updateAttributeStyle):
- dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::attributeStyle):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- 2:36 AM EFLWebKitCodingStyle edited by
- Remove . at the end of @ field. (diff)
- 2:34 AM Changeset in webkit [133450] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add --window-size command line option to EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100942
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Added window-size (-s) command line option to EFL MiniBrowser.
- MiniBrowser/efl/main.c:
(window_create):
(parse_window_size):
(elm_main):
- 2:25 AM Changeset in webkit [133449] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip fast/dom/shadow/shadowroot-type.html because SHADOW_DOM is disabled.
- platform/qt/TestExpectations:
- 2:12 AM Changeset in webkit [133448] by
-
- 2 edits in trunk
[Qt] Trivial unreviewed: Add missing module dependencies for builds in Qt CI system.
These fields aren't used by anyone except some perl scripts in the Qt CI builds.
- Source/sync.profile:
- 2:12 AM Changeset in webkit [133447] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed trivial Qt build fix.
Surround imports from QtGui by QT_{BEGIN,END}_NAMESPACE to fix namespaced
builds.
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/ImageQt.cpp:
- 1:53 AM Changeset in webkit [133446] by
-
- 22 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining MathML tests after r132264 and r133221 and updating
pixel baselines with outdated hash.
- platform/gtk/TestExpectations:
- platform/gtk/mathml/presentation/attributes-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.png:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
- platform/gtk/mathml/presentation/over-expected.png:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.png:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/tables-expected.png:
- platform/gtk/mathml/presentation/tables-expected.txt:
- 1:33 AM Changeset in webkit [133445] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip compositing/repaint/invalidations-on-composited-layers.html
https://bugs.webkit.org/show_bug.cgi?id=101181
Unreviewed EFL gardening.
Mark compositing/repaint/invalidations-on-composited-layers.html as
expected to fail since accelerated compositing is disabled by default
on EFL port.
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
- platform/efl/TestExpectations:
- 1:23 AM Changeset in webkit [133444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Skipping ENABLE_SUBPIXEL- and ENABLE_INPUT_TYPE_*-related testing
directories. These features are not enabled yet and most of the
tests fail.
Removing failure expectation for fast/files/workers/worker-apply-blob-url-to-xhr.html,
the issue was fixed in r132973.
Moving the skip entry for css3/device-adapt to the proper section.
- platform/gtk/TestExpectations:
- 1:05 AM Changeset in webkit [133443] by
-
- 6 edits2 adds in trunk
[Shadow] ShadowRoot type is not set correctly.
https://bugs.webkit.org/show_bug.cgi?id=101188
Reviewed by Hajime Morita.
Source/WebCore:
ShadowRoot type is not set correctly in Release build. We have had to remove #ifndef block.
Test: fast/dom/shadow/shadowroot-type.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- testing/Internals.cpp:
(WebCore::Internals::shadowRootType):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- fast/dom/shadow/shadowroot-type-expected.txt: Added.
- fast/dom/shadow/shadowroot-type.html: Added.
- 12:55 AM Changeset in webkit [133442] by
-
- 9 edits in trunk
[EFL][WK2] The icon database path should be set by the client
https://bugs.webkit.org/show_bug.cgi?id=101182
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
No longer set the favicon database path in database instance getter.
Instead, a new ewk_context_favicon_database_directory_set() API
function was added to let the client set the icon database path.
This is needed because the icon database path can only be set once
and setting it unconditionally in the getter prevents the client
from setting it.
This will also avoid crashes in WebKitTestRunner since WKTR was
setting the path once and ewk_context was attempting to override it.
Note that the favicon database functionality is disabled until the
client sets its path.
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::ensureFaviconDatabase):
(Ewk_Context::setFaviconDatabaseDirectoryPath):
(Ewk_Context::faviconDatabase):
(ewk_context_favicon_database_directory_set):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
(Ewk_Context):
- UIProcess/API/efl/ewk_favicon_database.cpp:
(Ewk_Favicon_Database::Ewk_Favicon_Database):
(Ewk_Favicon_Database::~Ewk_Favicon_Database):
(Ewk_Favicon_Database::iconURLForPageURL):
(Ewk_Favicon_Database::iconForPageURL):
(Ewk_Favicon_Database::getIconSurfaceSynchronously):
- UIProcess/API/efl/ewk_favicon_database_private.h:
(WebKit):
(Ewk_Favicon_Database::create):
(Ewk_Favicon_Database):
- UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
(TEST_F):
Tools:
Enable favicon database functionality in MiniBrowser since
it is used and it is no longer enabled by default.
- MiniBrowser/efl/main.c:
(elm_main):
- 12:22 AM Changeset in webkit [133441] by
-
- 6 edits in trunk/Source/WebCore
BaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient
https://bugs.webkit.org/show_bug.cgi?id=101038
Reviewed by Hajime Morita.
Add DateTimeChooserClient behavior to BaseChooserOnlyDateAndTimeInputType.
It means that date/time input elements without
ENABLE_INPUT_MULTIPLE_FIELDS_UI can open date/time choosers by
DOMActivate event.
This patch doesn't change behavior yet because Chromimum-Android port
intercepts user events and doesn't deliver them to date/time input
elements. <http://crbug.com/159381>
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
Add DateTimeChooserClient behavior. The code is similar to
PickerIndicatorElement.
(WebCore::BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Open DateTimeChooser if
- The element is not disabled,
- The element is not read-only,
- The element has a renderer,
- This event is created by a user gesture, and
- The element has no DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::detach):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):
Set a string value coming from a chooser to the input element.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didEndChooser):
Clear m_dateTimeChooser when the chooser was closed.
(WebCore::BaseChooserOnlyDateAndTimeInputType::closeDateTimeChooser):
Requests to close the chooser.
- html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType):
- Implement DateTimeChooserClient
- Add closeDateTimeChooser helper function.
- Add detach override.
- Add m_dateTimeChooser.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
Added. The code is moved from PickerIndicatorElement.cpp in order to
share it with BaseChooserOnlyDateAndTimeInputType.
- html/HTMLInputElement.h:
(HTMLInputElement): Declare setupDateTimeChooserParameters.
- html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::openPopup):
Move some code to HTMLInputElement::setupDateTimeChooserParameters.
- 12:04 AM Changeset in webkit [133440] by
-
- 2 edits135 moves16 adds in trunk/LayoutTests
2012-11-04 Kent Tamura <tkent@chromium.org>
Move *-multiple-fields-appearance-*.html from fast/forms/*-multiple-fields/ to fast/forms/*/
https://bugs.webkit.org/show_bug.cgi?id=101186
Rubber-stamped by Kentaro Hara.
The fast/forms/{date,month,time,week}-multiple-fields/
{date,month,time,week}-multiple-fields-appearance-*.html tests don't
depend on the multiple-fields UI, and should work for non
multiple-fields configuration too. They should be moved to
fast/forms/{date,month,time,week}/.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html: Removed.
- fast/forms/date/date-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt.
- fast/forms/date/date-appearance-basic.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html.
- fast/forms/date/date-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt.
- fast/forms/date/date-appearance-l10n.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html.
- fast/forms/date/date-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/date/date-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/date/date-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/date/date-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/date/date-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt.
- fast/forms/date/date-appearance-style.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html: Removed.
- fast/forms/month/month-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt.
- fast/forms/month/month-appearance-basic.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html.
- fast/forms/month/month-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt.
- fast/forms/month/month-appearance-l10n.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html.
- fast/forms/month/month-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/month/month-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/month/month-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/month/month-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/month/month-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt.
- fast/forms/month/month-appearance-style.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Removed.
- fast/forms/time/time-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt.
- fast/forms/time/time-appearance-basic.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html.
- fast/forms/time/time-appearance-disabled-readonly-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt.
- fast/forms/time/time-appearance-disabled-readonly.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html.
- fast/forms/time/time-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/time/time-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/time/time-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/time/time-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/time/time-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt.
- fast/forms/time/time-appearance-style.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html: Removed.
- fast/forms/week/week-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt.
- fast/forms/week/week-appearance-basic.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html.
- fast/forms/week/week-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/week/week-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/week/week-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/week/week-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/week/week-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt.
- fast/forms/week/week-appearance-style.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-linux/fast/forms/month: Added.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-linux/fast/forms/time: Added.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-linux/fast/forms/week: Added.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/month: Added.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/time: Added.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/week: Added.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month: Added.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time: Added.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week: Added.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/month: Added.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/time: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/week: Added.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win-xp/fast/forms/month: Added.
- platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-win/fast/forms/month: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-win/fast/forms/time: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-win/fast/forms/week: Added.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium/TestExpectations:
Nov 4, 2012:
- 11:55 PM Changeset in webkit [133439] by
-
- 8 edits4 adds in trunk
Fix the collapsing border code to handle mixed directionality at the row level
https://bugs.webkit.org/show_bug.cgi?id=101060
Reviewed by Ojan Vafai.
Source/WebCore:
After bug 87900, we support mixed directionality at the row-group level. For coherency
- as the underlying code didn't support it - we were artificially ignoring 'direction'
below the row-group. This change relaxes the restriction and patches the collapsing
borders code to query the right style and border.
Tests: fast/table/border-collapsing/table-ltr-rows-mixed-direction.html
fast/table/border-collapsing/table-rtl-row-mixed-direction.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
Changed to query the row's direction.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::hasStartBorderAdjoiningTable):
(WebCore::RenderTableCell::hasEndBorderAdjoiningTable):
Added 2 helper functions. They determine if a specific cell's border
adjoins the table. This code is required as the last cell's end border
can be resolved against the start border.
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Updated these functions now that being the start / end column doesn't mean
that we have to resolve against the row / row-group / table's border.
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleForCellFlow):
Updated to return the row's style.
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
Updated these functions to work with mixed directionality.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setLogicalPositionForCell):
Changed this function to use the section's direction. This is wrong and should be changed
once we properly fix the collapsing border code.
(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
Added a FIXME.
- rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::width):
This is a bug in our implementation: we used to return a non-zero width for inexistant borders (per CSS 2.1,
'border-style: off | hidden' should have a 0 width). This is covered by our existing tests (among others by
fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html).
LayoutTests:
- fast/table/border-collapsing/table-ltr-rows-mixed-direction-expected.html: Added.
- fast/table/border-collapsing/table-ltr-rows-mixed-direction.html: Added.
- fast/table/border-collapsing/table-rtl-row-mixed-direction-expected.html: Added.
- fast/table/border-collapsing/table-rtl-row-mixed-direction.html: Added.
- 11:52 PM Changeset in webkit [133438] by
-
- 4 edits1 move5 adds in trunk
Web Inspector: [Canvas] do not blow up the capturing log
https://bugs.webkit.org/show_bug.cgi?id=100752
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-04
Reviewed by Pavel Feldman.
Source/WebCore:
Clear obsolete calls in the canvas 2D capturing log in runtime.
Now we store in the log only minimum number of calls that are necessary to replay a
canvas 2D context. To achieve that we find in runtime those calls in the log that no
longer contribute to the final context state and remove them.
These are the rules according which we find and remove such calls:
- all PATH methods between a clip() call and beginPath() call can be removed
- all MATRIX methods before a restore() or setTransform() call but after any PATH or corresponding save() method
- all consecutive save() + restore() calls
Tests: inspector/profiler/canvas2d/canvas2d-api-changes.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
LayoutTests:
Added test for track Canvas 2D API changes, as well as basics for the capturing.
- inspector/profiler/canvas-profiler-test.js: Renamed from LayoutTests/inspector/profiler/webgl/webgl-profiler-test.js.
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):
(createWebGLContext):
(createCanvas2DContext):
- inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt: Added.
- inspector/profiler/canvas2d/canvas2d-api-changes.html: Added.
- inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt: Added.
- inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html: Added.
- inspector/profiler/webgl/webgl-profiler-get-error.html:
- 11:49 PM Changeset in webkit [133437] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip a new failing test introduced in r133428, because SHADOW_DOM is disabled.
Unskip a test that does not exist already.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-04
- platform/qt/TestExpectations:
- 11:30 PM Changeset in webkit [133436] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for accessibility/svg-remote-element,
fast/images/exif-orientation-image-document.html and
svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg.
Rebaselining fast/images/repaint-subrect-grid.html, the new baseline
matches the one Mac port uses.
- platform/gtk/TestExpectations:
- platform/gtk/fast/images/repaint-subrect-grid-expected.txt: Added.
- 11:29 PM Changeset in webkit [133435] by
-
- 2 edits in trunk/Source/WebCore
[Shadow] ShadowRoot should have a method to return ShadowRootType.
https://bugs.webkit.org/show_bug.cgi?id=101178
Reviewed by Hajime Morita.
When we style PseudoCustomElement, we have to know ShadowRootType.
We would like to expose a method to get ShadowRootType also in Release mode.
This is a preparation patch for Bug 101170.
- dom/ShadowRoot.h:
(ShadowRoot):
- 11:13 PM Changeset in webkit [133434] by
-
- 8 edits in trunk
Introduce Month class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101024
Reviewed by Kent Tamura.
Source/WebCore:
Month class needs to be introduced to implement a month picker. This
patch just introduces the Month class into the calendar picker without
changing the current behavior.
No new tests. Covered by existing calendar-picker-*.html tests.
- Resources/pagepopups/calendarPicker.js:
(Month.prototype.toLocaleString): Returns a localized month string.
(Month): Takes a Month object, number representing the month, or year and month numbers.
(Month.parse): Returns a new Month from an ISO month string.
(Month.createFromDate): Returns a new Month containing the given datetime.
(Month.prototype.equals): Returns true if the given month is the same.
(Month.prototype.previous): Returns the previous month.
(Month.prototype.next): Returns the next month.
(Month.prototype.startDate): Returns a datetime that is the start of this month. The value is inclusive.
(Month.prototype.endDate): Returns a datetime that is the end of this month. The value is exclusive.
(Month.prototype.valueOf): Returns a number representing the month.
(Month.prototype.toString): Returns an ISO month string.
(YearMonthController): Use Month object.
(YearMonthController.prototype.attachTo): Year 275760 ends in September so use the year before to measure the label width.
(YearMonthController.prototype.setMonth): Take a month object.
(YearMonthController.prototype._redraw): Use ISO month string for element.dataset.value.
(YearMonthController.prototype._handleYearMonthChange):
(YearMonthController.prototype.moveRelatively):
(DaysTable): Use Month object.
(DaysTable.prototype._renderMonth): Take a month object. Testing for isNaN is moved up to fix a bug when showing September, 275760.
(DaysTable.prototype._navigateToMonth): Take a month object.
(DaysTable.prototype._navigateToMonthWithAnimation): Take a month object.
(DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Take a month object.
(DaysTable.prototype.selectDate):
(DaysTable.prototype._maybeSetPreviousMonth): Use Month object to calculate the previous month.
(DaysTable.prototype._maybeSetNextMonth): Use Month object to calculate the next month.
LayoutTests:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html: Adjust the expectation because we changed the month string format.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html: Ditto.
- 10:17 PM Changeset in webkit [133433] by
-
- 2 edits31 deletes in trunk/LayoutTests
Remove obsolete tests for date/time input types
https://bugs.webkit.org/show_bug.cgi?id=98783
Reviewed by Kentaro Hara.
*-input-visible-string.html and *-stepup-stepdown-from-renderer.html are
unnecessary and should be removed because they depend on textfield
behavior, and the date/time input types no longer have textfield
behavior on any platforms.
- fast/forms/datetime/datetime-input-visible-string-expected.txt: Removed.
- fast/forms/datetime/datetime-input-visible-string.html: Removed.
- fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Removed.
- fast/forms/datetimelocal/datetimelocal-input-visible-string.html: Removed.
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/month/month-input-visible-string-expected.txt: Removed.
- fast/forms/month/month-input-visible-string.html: Removed.
- fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/month/month-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/time/time-input-visible-string-expected.txt: Removed.
- fast/forms/time/time-input-visible-string.html: Removed.
- fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/time/time-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/week/week-input-visible-string-expected.txt: Removed.
- fast/forms/week/week-input-visible-string.html: Removed.
- fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/week/week-stepup-stepdown-from-renderer.html: Removed.
- platform/chromium-android/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/datetime/datetime-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/month/month-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/time/time-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/week/week-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Removed.
- 9:35 PM FeatureFlags edited by
- Remove UNDO_MANAGER (diff)
- 9:33 PM Changeset in webkit [133432] by
-
- 6 edits in trunk/Source
[EFL] Use _LIBRARIES instead of _LIBRARY
https://bugs.webkit.org/show_bug.cgi?id=101042
Patch by Halton Huo <halton.huo@intel.com> on 2012-11-04
Reviewed by Gyuyoung Kim.
In CMake Find files, _LIBRARY is intended for internal use, should
use _LIBRARIES instead.
Source/WebCore:
- PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}
Source/WebKit:
- PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}
Source/WebKit2:
- PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}
- 9:22 PM Changeset in webkit [133431] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] Skip a fast/images/repaint-subrect-grid.html test case after r133322
https://bugs.webkit.org/show_bug.cgi?id=101175
Unreviewed gardening.
fast/images/repaint-subrect-grid.html is failing on WK1 debug bot.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-04
- platform/efl-wk1/TestExpectations:
- 7:13 PM Changeset in webkit [133430] by
-
- 4 edits in trunk/Source/JavaScriptCore
Baseline JIT should use structure watchpoints whenever possible
https://bugs.webkit.org/show_bug.cgi?id=101146
Reviewed by Sam Weinig.
No speed-up yet except on toy programs. I think that it will start to show
speed-ups with https://bugs.webkit.org/show_bug.cgi?id=101147, which this is
a step towards.
- jit/JIT.h:
(JIT):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::addStructureTransitionCheck):
(JSC):
(JSC::JIT::testPrototype):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- 7:09 PM Changeset in webkit [133429] by
-
- 10 edits in trunk/Source
Shadow DOM should be able to be disabled per context.
https://bugs.webkit.org/show_bug.cgi?id=101173
Reviewed by Dimitri Glazkov.
Source/WebCore:
This change pulls back relevant bits from r131549. Note that if
the the port enables runtime Shadow DOM flag, this can cause slow
down on some Chromium page cycler test cases (which r131549
attempted to fix).
This change is temporal and the flags should be switched back from
ContextFeatures to RuntimeEnabledFeatures once it gains sufficent
stability.
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore):
- dom/ContextFeatures.h:
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection):
- html/HTMLTagNames.in:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::contentTagName):
- page/DOMWindow.idl:
Source/WebKit/chromium:
- src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
- 7:04 PM Changeset in webkit [133428] by
-
- 5 edits2 adds in trunk
[Shadow] Implement custom pseudo-elements styling
https://bugs.webkit.org/show_bug.cgi?id=100812
Reviewed by Hajime Morita.
Source/WebCore:
Instead of using ElementRareData::m_shadowPseudoId, we use 'pseudo' attribute.
Later we would like to remove Element::shadowPseudoId and Element::setShadowPseudoId
and use pseudo()/setPseudo() instead (Bug 101171).
Test: fast/dom/shadow/styling-pseudo-attribute.html
- dom/Element.cpp:
(WebCore::Element::shadowPseudoId):
(WebCore::Element::setShadowPseudoId):
- dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
- dom/ElementRareData.h:
(ElementRareData):
LayoutTests:
- fast/dom/shadow/styling-pseudo-attribute-expected.html: Added.
- fast/dom/shadow/styling-pseudo-attribute.html: Added.
- 3:16 PM Changeset in webkit [133427] by
-
- 6 edits in trunk/Source/WebCore
BaseChooserOnlyDateAndTimeInputType should have BaseClickableWithKeyInputType behavior
https://bugs.webkit.org/show_bug.cgi?id=101039
Reviewed by Hajime Morita.
Add BaseClickableWithKeyInputType behavior to
BaseChooserOnlyDateAndTimeInputType. It means date/time input types
without ENABLE_INPUT_MULTIPLE_FIELDS_UI receive DOMActivate events by
pressing space or enter key. They're going to open a date/time chooser
by DOMActive event.
Because BaseChooserOnlyDateAndTimeInputType inherits from
BaseDateAndTimeInputType, it can't inherit
BaseClickableWithKeyInputType. So, this patch adds static helper
functions to BaseClickableWithKeyInputType, and
BaseChooserOnlyDateAndTimeInputType uses them.
This patch doesn't change behavior yet because Chromimum-Android port
intercepts user events and doesn't deliver them to date/time input
elements.
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Add an empty implementation with a FIXME comment.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeydownEvent):
Add BaseClickableWithKeyInputType behavior by a helper function.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeypressEvent): Ditto.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeyupEvent): Ditto.
(WebCore::BaseChooserOnlyDateAndTimeInputType::accessKeyAction): Ditto.
- html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType): Add function declarations.
- html/BaseClickableWithKeyInputType.cpp:
Add static helper functions, and existing member functions use them.
- html/BaseClickableWithKeyInputType.h:
(BaseClickableWithKeyInputType): Add declarations of the helper functions.
- html/InputType.h:
(InputType): Make dispatchSimulatedClickIfActive public because it is
called from a helper function.
- 2:30 PM Changeset in webkit [133426] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r133416.
http://trac.webkit.org/changeset/133416
https://bugs.webkit.org/show_bug.cgi?id=101169
Broke world selection by right click (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-04
Source/WebCore:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::sendContextMenuEvent):
LayoutTests:
- fast/events/touch/gesture/disabled-input-text-selection-expected.txt: Removed.
- fast/events/touch/gesture/disabled-input-text-selection.html: Removed.
- platform/chromium/TestExpectations:
- 2:26 PM Changeset in webkit [133425] by
-
- 5 edits in trunk/Source/WebKit2
Expose security origin to BundleFrame
https://bugs.webkit.org/show_bug.cgi?id=101139
<rdar://problem/12629900>
Reviewed by Darin Adler.
Create a WebSecurityOrigin instance, sharing the security origin instance
that comes directly from the frame's document. We can do this because the
WK2 API only retrieves information about the origin, and because those
results are returned as copies. The security origin holds no references
that could lead to a retain cycle, avoiding the possibility that the
injected bundle accidentally keeps something alive.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedAPI): Create copied API for WebCore::SecurityOrigin
instances.
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::create): Add a new create() function that
takes a PassRefPtr to a WebCore SecurityOrigin instance.
(WebKit::WebSecurityOrigin::createFromString): Refactor to use new create()
function.
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier): Refactor to
use new create() function.
(WebKit::WebSecurityOrigin::create): Refactor to use new create()
function.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopySecurityOrigin): Add function to retrieve the security
origin as a WK2 API object.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- 9:27 AM Changeset in webkit [133424] by
-
- 2 edits in trunk/Source/WebCore
Missing ASCIILiteral in a place of accessibility
https://bugs.webkit.org/show_bug.cgi?id=101160
Reviewed by Darin Adler.
ASCIILiteral usage is being missed in a spot of accessibliity.
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeDisplay::accessibilityDescription):
- 8:02 AM Changeset in webkit [133423] by
-
- 4 edits in trunk/Source/WebKit2
[EFL] Unify transforms in WK2
https://bugs.webkit.org/show_bug.cgi?id=101051
Reviewed by Simon Hausmann.
Move our transforms into EwkViewImpl and use them
everywhere needed.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::smartData):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::transformToScene):
(EwkViewImpl::transformToScreen):
(EwkViewImpl::displayTimerFired):
- UIProcess/API/efl/EwkViewImpl.h:
(WebCore):
(EwkViewImpl):
(EwkViewImpl::pageViewportControllerClient):
(EwkViewImpl::pageViewportController):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(ewk_view_feed_touch_event):
- 6:57 AM Changeset in webkit [133422] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add a now-failing test. Unreviewed.
- platform/chromium/TestExpectations:
- 6:07 AM Changeset in webkit [133421] by
-
- 16 edits1 move1 add3 deletes in trunk
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838
Reviewed by Simon Hausmann.
Reland with build fixes.
Source/WebCore:
The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.
Basically covered by all tests.
- Target.pri:
- WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
- platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
- platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):
Tools:
Turned test runners to use the new QtTestSupport.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
- MiniBrowser/qt/MiniBrowser.pro:
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 5:26 AM Changeset in webkit [133420] by
-
- 3 edits2 adds in trunk
Color-profile property triggers assert
https://bugs.webkit.org/show_bug.cgi?id=101080
Reviewed by Dirk Schulze.
Source/WebCore:
CSSPropertyColorProfile is not handled in StyleResolver::applySVGProperty(), triggering the
unimplemented property assert. Adding a stub entry to avoid that.
Test: svg/css/color-profile-crash.html
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
LayoutTests:
- svg/css/color-profile-crash-expected.txt: Added.
- svg/css/color-profile-crash.html: Added.
- 4:30 AM Changeset in webkit [133419] by
-
- 5 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed weekend gardening, skip failing tests, update expected files.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Updated after r133019.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Updated after r133019.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Updated after r133019.
- 2:55 AM Changeset in webkit [133418] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip one more failing test.
- platform/qt/TestExpectations:
- 2:31 AM Changeset in webkit [133417] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt/TestExpectations:
- 1:20 AM Changeset in webkit [133416] by
-
- 4 edits2 adds in trunk
Unable to copy text on disabled input fields on long press gesture
https://bugs.webkit.org/show_bug.cgi?id=99698
Reviewed by Ryosuke Niwa.
Text from disabled input/text should be allowed to select. Replaced isContentEditable()
with canStartSelection()
Source/WebCore:
Test: fast/events/touch/gesture/disabled-input-text-selection.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongPress):
LayoutTests:
- fast/events/touch/gesture/disabled-input-text-selection-expected.txt: Added.
- fast/events/touch/gesture/disabled-input-text-selection.html: Added.
- platform/chromium/TestExpectations: Not Valid for chromium desktop.
Nov 4, 2012:
- 1:07 AM Changeset in webkit [133415] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Qt] udis86_itab.c is always regenerated
https://bugs.webkit.org/show_bug.cgi?id=100756
Reviewed by Simon Hausmann.
- DerivedSources.pri: Generate sources to the generated directory.
- disassembler/udis86/differences.txt:
- disassembler/udis86/itab.py: Add --outputDir option.
(UdItabGenerator.init):
(genItabH):
(genItabC):
(main):
- 1:03 AM Changeset in webkit [133414] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r133381.
http://trac.webkit.org/changeset/133381
https://bugs.webkit.org/show_bug.cgi?id=101161
It made webkit-patch useless (Requested by Ossy_weekend on
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-04
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.init):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install):
- Scripts/webkitpy/thirdparty/init_unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook):
- 12:43 AM Changeset in webkit [133413] by
-
- 2 edits in trunk/LayoutTests
[chromium] Remove some no-longer-flaky tests. Unreviewed.
- platform/chromium/TestExpectations:
