Timeline
Nov 7, 2012:
- 11:38 PM Changeset in webkit [133857] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: console error after inspecting IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=101481
Reviewed by Pavel Feldman.
Added objectId nullity check to RemoteOBject::release.
Drive-by added release for entry key and primaryKey.
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype.clear):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.release):
- 11:35 PM Changeset in webkit [133856] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Web Inspector: some tests failing with "Cannot call method 'hasTextContent' of undefined"
https://bugs.webkit.org/show_bug.cgi?id=94501
Unreviewed unskipped test.
- platform/chromium/TestExpectations:
- 11:32 PM Changeset in webkit [133855] by
-
- 7 edits in trunk
Web Inspector: Migrate inspector IndexedDB support to frontend API.
https://bugs.webkit.org/show_bug.cgi?id=101457
Reviewed by Pavel Feldman.
Source/WebCore:
Migrated IndexedDB support to web facing IndexedDB API.
- inspector/Inspector.json:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype.innerCallback):
(WebInspector.IndexedDBModel.prototype._requestData):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode):
(WebInspector.IDBDataGridNode.prototype.createCell):
LayoutTests:
- http/tests/inspector/indexeddb/database-data.html:
- 11:29 PM Changeset in webkit [133854] by
-
- 2 edits in trunk/Tools
Make wait-for-SVN-server.py accept empty string as revision
https://bugs.webkit.org/show_bug.cgi?id=98014
Reviewed by Dirk Pranke.
- BuildSlaveSupport/wait-for-SVN-server.py:
(waitForSVNRevision):
- 11:03 PM Changeset in webkit [133853] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: Infinite loop in DataGrid::autoSizeColumn
https://bugs.webkit.org/show_bug.cgi?id=101363
Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.
- inspector/datagrid-autosize-expected.txt: Added.
- inspector/datagrid-autosize.html: Added.
- 10:49 PM Changeset in webkit [133852] by
-
- 5 edits in trunk/Source
Web Inspector: Drop dimmed crumb handling
https://bugs.webkit.org/show_bug.cgi?id=94457
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-20
Reviewed by Vsevolod Vlasov.
Source/WebCore:
No new tests. Existing inspector test should work.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
- inspector/front-end/breadcrumbList.css:
Source/WebKit/chromium:
- src/js/devTools.css:
- 10:45 PM Changeset in webkit [133851] by
-
- 3 edits2 adds in trunk
Web Inspector: Infinite loop in DataGrid::autoSizeColumn
https://bugs.webkit.org/show_bug.cgi?id=101363
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/datagrid-autosize.html
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._autoSizeWidths):
(WebInspector.DataGrid.prototype.autoSizeColumns):
LayoutTests:
- inspector/datagrid-autosize-expected.txt: Added.
- inspector/datagrid-autosize.html: Added.
- 10:35 PM Changeset in webkit [133850] by
-
- 7 edits in trunk
Implement week picking to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101449
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Added test for week picker.
Source/WebCore:
This adds week picker mode to CalendarPicker.
No new tests. Tests will be added later when this feature is enabled in DRT.
- Resources/pagepopups/calendarPicker.css:
(.month-mode .day):
(.week-mode .available.day-selected.monday): Rounded corners around week selection.
(.week-mode .available.day-selected.sunday): Ditto.
(.week-mode .unavailable.day-selected):
(.week-mode .unavailable.day-selected.monday):
(.week-mode .unavailable.day-selected.sunday):
(.week-mode .week-column.unavailable.day-selected):
(.week-column): Hide week column unless in week mode.
(.week-mode .week-column):
- Resources/pagepopups/calendarPicker.js:
(parseDateString): Support week string.
(Week):
(Week.parse): Parses "yyyy-Www" string.
(Week.createFromDate): Creates Week containing datetime.
(Week.createFromToday): Creates Week containing today.
(Week.weekOneStartDateForYear): Returns the start date for the first week of year.
(Week.numberOfWeeksInYear): Returns the number of weeks in year.
(Week._numberOfWeeksSinceDate): Returns number of weeks since a date.
(Week.prototype.equals): Returns true if the Weeks are the same.
(Week.prototype.previous): Returns the previous Week.
(Week.prototype.next): Returns the next Week.
(Week.prototype.startDate): Returns start datetime of Week.
(Week.prototype.endDate): Returns end datetime of Week.
(Week.prototype.valueOf): Returns the milliseconds since epoch.
(Week.prototype.toString): Returns ISO week string.
(CalendarPicker): Add week picker mode.
(CalendarPicker.prototype.showMonth): Use NavigationBehaviour instead of bools.
(YearMonthController.prototype.attachTo): Fix bug.
(YearMonthController.prototype.moveRelatively): Use new showMonth.
(DaysTable.prototype.attachTo): Add week number column.
(DaysTable.prototype._renderMonth): Render week numbers.
(DaysTable.prototype.navigateToMonth): Render week numbers.
(DaysTable.prototype.selectRange):
(DaysTable.prototype._selectRangeAtPosition): Week number nodes have an positionX of -1.
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(MonthPickerDaysTable.prototype.selectRange):
(MonthPickerDaysTable.prototype.selectRangeAndShowEntireRange):
(MonthPickerDaysTable.prototype._handleKey):
(WeekPickerDaysTable): Added.
(WeekPickerDaysTable.prototype._markRangeAsSelected): Marks week as selected.
(WeekPickerDaysTable.prototype.selectRange): Selects week.
(WeekPickerDaysTable.prototype.selectRangeAndShowEntireRange): Selects week and navigate to show entire selection.
(WeekPickerDaysTable.prototype._rangeForNode): Returns Week for node.
(WeekPickerDaysTable.prototype._handleKey):
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html: Needs to be changed because we changed DaysTable DOM.
- 10:14 PM Changeset in webkit [133849] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, WebKit gardening.
Remove a duplication which caused a webkit-lint error.
- platform/chromium/TestExpectations:
- 10:08 PM Changeset in webkit [133848] by
-
- 25 edits2 adds in trunk
Unreviewed, rolling out r133841.
http://trac.webkit.org/changeset/133841
https://bugs.webkit.org/show_bug.cgi?id=101542
Reverted patches were innocent (Requested by shinyak on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::shadowPseudoId):
- dom/Element.h:
(Element):
- dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
- dom/ElementRareData.h:
(ElementRareData):
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize):
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement):
- html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):
- testing/Internals.cpp:
(WebCore::Internals::setShadowPseudoId):
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/dom/shadow/styling-pseudo-attribute-expected.html: Added.
- fast/dom/shadow/styling-pseudo-attribute.html: Added.
- platform/chromium/TestExpectations:
- 9:40 PM Changeset in webkit [133847] by
-
- 5 edits6 copies4 moves6 adds6 deletes in trunk/LayoutTests
Unreviewed, WebKit gardening.
Rebaseline after r133384.
- fast/repaint/moving-shadow-on-container-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt.
- platform/chromium-linux-x86/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
- platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/chromium-linux/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-linux/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
- platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.png.
- platform/chromium-mac-lion/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
- platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt:
- platform/chromium-mac/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-mac/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
- platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
- platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/chromium-win/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-win/svg/css/group-with-shadow-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/chromium/svg/css/group-with-shadow-expected.png: Removed.
- platform/efl-wk1/fast/repaint/moving-shadow-on-container-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-container-expected.png.
- platform/efl-wk1/svg/css/group-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.png.
- platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- 9:36 PM Changeset in webkit [133846] by
-
- 3 edits in trunk/Source/WebCore
Fix EFL build, which has accelerated compositing disabled, by making
repaintViewRectangle() const.
- rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
- rendering/RenderView.h:
(RenderView):
- 9:15 PM Changeset in webkit [133845] by
-
- 41 edits in trunk/Source/WebCore
constify ALL the repaint containers
https://bugs.webkit.org/show_bug.cgi?id=101541
Reviewed by Beth Dakin.
Make all the RenderLayerModelObject* repaintContainer arguments const, since
these member functions should have no need to mutate this object.
- WebCore.exp.in:
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions): Need to use a const_iterator.
- rendering/RenderFlowThread.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
- rendering/RenderInline.h:
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
- rendering/RenderListMarker.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):
- rendering/RenderObject.h:
(WebCore::RenderObject::selectionRectForRepaint):
(WebCore::RenderObject::outlineBoundsForRepaint):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderReplaced.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
- rendering/RenderTableRow.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
(WebCore::RenderText::selectionRectForRepaint):
- rendering/RenderText.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::computeRectForRepaint):
- rendering/RenderView.h:
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGHiddenContainer.h:
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
(WebCore::RenderSVGInline::mapLocalToContainer):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
(WebCore::RenderSVGModelObject::mapLocalToContainer):
(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
(WebCore::RenderSVGText::mapLocalToContainer):
- rendering/svg/RenderSVGText.h:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
(WebCore::SVGRenderSupport::mapLocalToContainer):
- rendering/svg/SVGRenderSupport.h:
(SVGRenderSupport):
- 8:38 PM Changeset in webkit [133844] by
-
- 11 edits in trunk/Source/WebKit2
[EFL][WK2] Make ewk_context use WebContext instead of WKContext
https://bugs.webkit.org/show_bug.cgi?id=101477
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.
Refactor ewk_context to use WebContext as ewk_context is encapsulated in a C++ classes.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::defaultContext):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
- UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
(EwkContext::webContext):
- UIProcess/API/efl/ewk_database_manager.cpp:
(Ewk_Database_Manager::Ewk_Database_Manager):
(Ewk_Database_Manager::getDatabaseOrigins):
- UIProcess/API/efl/ewk_database_manager_private.h:
(Ewk_Database_Manager::create):
(Ewk_Database_Manager):
- UIProcess/API/efl/ewk_storage_manager.cpp:
(Ewk_Storage_Manager::Ewk_Storage_Manager):
(Ewk_Storage_Manager::getStorageOrigins):
- UIProcess/API/efl/ewk_storage_manager_private.h:
(Ewk_Storage_Manager::create):
(Ewk_Storage_Manager):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::DownloadManagerEfl):
- UIProcess/efl/RequestManagerClientEfl.cpp:
(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
- 8:34 PM Changeset in webkit [133843] by
-
- 1114 edits1107 copies40 adds in trunk/LayoutTests
Unreviewed, new chromium-mac-mountainlion svg baselines.
- 8:12 PM Changeset in webkit [133842] by
-
- 3 edits in trunk/Source/WebCore
[Chromium-win] Refactor date/time format conversion code in LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=101329
Reviewed by Kentaro Hara.
convertWindowsDateFormatToLDML and convertWindowsTimeFormatToLDML did
similar jobs with different code. We can merge them into one function.
As for the date format conversion, we have tokenized a format string and
stored token objects into a vector. We skip token object generation and
generate a LDML-compliant pattern string during parsing.
No new tests. This should make no behavior changes and
WebKit/chromium/tests/LocaleWinTest.cpp has test cases.
- platform/text/win/LocaleWin.cpp:
(WebCore): Remove DateFormatToken, isFooSymbol, ensureShortDateTokens,
convertWindowsDateFormatToLDML, mapCharacterToDateTimeFieldType, and
convertWindowsTimeFormatToLDML.
(WebCore::commitLiteralToken): Store the result to the specified StringBuilder.
(WebCore::convertWindowsDateTimeFormat):
Renamed from parseDateFormat, and supports time format symbols.
(WebCore::LocaleWin::dateFormat): Use convertWindowsDateTimeFormat.
(WebCore::LocaleWin::monthFormat): Ditto.
(WebCore::LocaleWin::timeFormat): Ditto.
(WebCore::LocaleWin::shortTimeFormat): Ditto.
- platform/text/win/LocaleWin.h:
(LocaleWin): Remove ensureShortDateTokens and m_shortDateTokens.
- 8:00 PM Changeset in webkit [133841] by
-
- 25 edits2 deletes in trunk
Unreviewed, rolling out r133428 and r133749
https://bugs.webkit.org/show_bug.cgi?id=101533
These patches might cause memory regression.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::shadowPseudoId):
(WebCore):
(WebCore::Element::setShadowPseudoId):
- dom/Element.h:
(Element):
- dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
- dom/ElementRareData.h:
(ElementRareData):
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize):
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement):
- html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):
- testing/Internals.cpp:
(WebCore::Internals::setShadowPseudoId):
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/dom/shadow/styling-pseudo-attribute-expected.html: Removed.
- fast/dom/shadow/styling-pseudo-attribute.html: Removed.
- platform/chromium/TestExpectations:
- 7:50 PM Changeset in webkit [133840] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::RenderLayer::normalFlowList
https://bugs.webkit.org/show_bug.cgi?id=101528
Reviewed by Simon Fraser.
Make sure the layout is up to date before re-computing the caret rect.
Avoid doing the layout when the selection is cleared since we can always stop
the blink timer in that case.
Unfortunately, we haven't found any reproduction of this crash yet.
- editing/FrameSelection.cpp:
(WebCore::isNonOrphanedCaret):
(WebCore::FrameSelection::localCaretRect):
(WebCore::FrameSelection::updateAppearance):
- 7:42 PM Changeset in webkit [133839] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Marking new test editing/execCommand/switch-list-type-with-orphaned-li.html per webkit.org/b/101539.
- platform/chromium/TestExpectations:
- 7:23 PM Changeset in webkit [133838] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 133124 - [Refactoring] Move initial style setting for ProgressValueElement from attach method to createShadowSubtree method in HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=83664
Reviewed by Hajime Morita.
Source/WebCore:
The original code updates inline style during attach(). However,
the attach would be invoked from Element::recalcStyle()'s reattach().
If updating inline styles during the reattach(), style related flags,
i.e. childNeedsStyleRecalc, and needsStyleRecalc are cleared after the
reattach(). So the inline styles are not updated in next
setNeedsStyleRecalc, because ProgressValueElement has already had
InlineStyleChange (existingChanegType == InlineStyleChange) and
markAncestorsWithChildNeedsStyleRecalc is not invoked.
Test: fast/dom/HTMLProgressElement/progress-bar-set-value.html
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::attach):
Copied updateFromElement from didElementStateChange. If removing the
update, indeterminate-progress-001.html and progress-element.html
under fast/dom/HTMLProgressElement will fail. We still need attach()
and updateFromElement. To remove the attach(), need more refactoring,
i.e. investigating where attach() is invoked from and modifying all
related codes.
(WebCore::HTMLProgressElement::createShadowSubtree):
Initialize m_value by indeterminate-position. The value is default
value of progress element.
LayoutTests:
- fast/dom/HTMLProgressElement/progress-bar-set-value-expected.html: Added.
- fast/dom/HTMLProgressElement/progress-bar-set-value.html: Added.
TBR=tasak@google.com
Review URL: https://codereview.chromium.org/11275208
- 7:05 PM Changeset in webkit [133837] by
-
- 3 edits in trunk/Source/WebCore
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110
Reviewed by Kentaro Hara.
Hopefully the memory issues with this patch have been resolved by
fixing bug 101525. This patch re-lands this patch again, hopefully for
the last time.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):
- 7:03 PM Changeset in webkit [133836] by
-
- 2 edits in trunk/Source/WebCore
Seam occurred between pieces of ShadowBlur on floating point zoom
https://bugs.webkit.org/show_bug.cgi?id=101435
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07
Reviewed by Simon Fraser.
When paint Shadow that doesn't have blurred edge on floating point zoom,
pixel seam (pixel cracks) occurred between pieces of the ShadowBlur because of unaligned clip rect.
So, enlarge the clipping area 1 pixel so that the fill does not bleed (due to antialiasing)
even if the unaligned clip rect occurred.
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::calculateLayerBoundingRect):
- 7:01 PM Changeset in webkit [133835] by
-
- 148 edits135 copies27 adds in trunk/LayoutTests
Unreviewed, new chromium-mac-mountainlion baselines for remaining dirs outside of fast, svg, and tables.
- 6:58 PM Changeset in webkit [133834] by
-
- 26 edits7 adds in trunk
Repaint issues with -webkit-svg-shadow used on a container
https://bugs.webkit.org/show_bug.cgi?id=65643
<rdar://problem/7600532>
Reviewed by Simon Fraser.
SVG renderer repaint rects are currently expanded only by the shadow of
the renderer itself; however, the area they need to repaint can be larger
than that, if their parents also have shadows. We need to take into account
parent's shadows (respecting transforms, as well).
clippedOverflowRectForRepaint already recurses upwards through the render tree,
and ends up with a rect in layout coordinates, so we manually apply the shadow
at each step (repaintRectInLocalCoordinatesExcludingSVGShadow was added to allow
us to get the raw repaint rect without the shadow baked-in).
repaintRectInLocalCoordinates now includes shadows from all parents.
Also, RenderSVGRoot was clipping repaint rects to the viewport before applying
shadows, so offscreen elements with on-screen shadows (applied by the root) would not paint the shadows.
We can just swap the order of these things to correct this.
Tests: svg/css/parent-shadow-offscreen.svg, svg/css/root-shadow-offscreen.svg, svg/repaint/repaint-webkit-svg-shadow.svg
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Mark the child being added as having an SVG shadow if it is being added as a child of an element that does.
(WebCore::RenderObject::styleDidChange): Mark the child being added as having an SVG shadow if its new style has a shadow.
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout): Cache the repaint rect before intersecting it with the shadow.
- rendering/svg/RenderSVGImage.h:
(WebCore::RenderSVGImage::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::RenderSVGModelObject): Renderers do not have a shadow by default.
- rendering/svg/RenderSVGModelObject.h:
(WebCore::RenderSVGModelObject::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::RenderSVGModelObject::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGModelObject::setHasSVGShadow): Set whether or not the renderer has a shadow.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint): Apply the shadow before clipping to the viewport, so we draw shadows for elements outside the viewport.
(WebCore::RenderSVGRoot::updateCachedBoundaries): Cache the repaint rect before intersecting it with the shadow.
- rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::setHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateRepaintBoundingBox): Cache the repaint rect before intersecting it with the shadow.
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint): Apply shadows as we walk through our parents, instead of only applying the renderer's own shadow.
(WebCore::SVGRenderSupport::rendererHasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::setRendererHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::intersectRepaintRectWithShadows): Walk through the element's parents, adding shadows to the repaint rect as we go, eventually
transforming the repaint rect back into local coordinates.
(WebCore::SVGRenderSupport::intersectRepaintRectWithResources): Don't add shadows by default, just other resources, so that we can cache repaint rects with and without shadows.
- rendering/svg/SVGRenderSupport.h:
- platform/chromium/TestExpectations: Mark tests as needing rebaseline.
- platform/efl/TestExpectations: Mark tests as needing rebaseline.
- platform/gtk/TestExpectations: Mark tests as needing rebaseline.
- platform/qt/TestExpectations: Mark tests as needing rebaseline.
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
- platform/mac/svg/css/arrow-with-shadow-expected.txt:
- platform/mac/svg/css/clippath-with-shadow-expected.txt:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/mac/svg/css/group-with-shadow-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.txt:
- platform/mac/svg/custom/simple-text-double-shadow-expected.txt:
Rebaseline Mac results due to this change.
- svg/css/parent-shadow-offscreen-expected.svg: Added.
- svg/css/parent-shadow-offscreen.svg: Added.
Add a new test that ensures that <g> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.
- svg/css/root-shadow-offscreen-expected.svg: Added.
- svg/css/root-shadow-offscreen.svg: Added.
Add a new test that ensures that <svg> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.
- platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.
- svg/repaint/repaint-webkit-svg-shadow.svg: Added.
Add a new test that ensures that SVG elements with -webkit-svg-shadow are correctly invalidated.
- 6:52 PM Changeset in webkit [133833] by
-
- 9 edits2 copies in trunk/Source
Add RemoteGraphicsLayer class
https://bugs.webkit.org/show_bug.cgi?id=101535
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.exp.in:
Export GraphicsLayer symbols required by WebKit2.
- WebCore.xcodeproj/project.pbxproj:
Make GraphicsLayerFactory.h a private header.
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
Add RemoteGraphicsLayer, a subclass of WebCore::GraphicsLayer.
- WebProcess/WebPage/mac/RemoteLayerTreeController.h:
Make RemoteLayerTreeController a GraphicsLayerFactory.
- WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::createGraphicsLayer):
Create a new RemoteGraphicsLayer.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
Return the layer tree controller.
- 6:52 PM Changeset in webkit [133832] by
-
- 30 edits in trunk
Enable Subpixel Layout on Windows. Rebaseline any failing tests that were rebaselined in r133351.
https://bugs.webkit.org/show_bug.cgi?id=101538
Rubberstamped by Tim Horton.
- win/tools/vsprops/FeatureDefines.vsprops:
- platform/win/css1/font_properties/font-expected.txt:
- platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/win/editing/selection/caret-ltr-right-expected.txt:
- platform/win/editing/selection/caret-rtl-2-left-expected.txt:
- platform/win/editing/selection/caret-rtl-right-expected.txt:
- platform/win/editing/selection/mixed-editability-10-expected.txt:
- platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/win/fast/borders/bidi-012-expected.txt:
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- platform/win/fast/forms/file/file-input-disabled-expected.txt:
- platform/win/fast/inline/inline-box-background-expected.txt:
- platform/win/fast/inline/inline-box-background-long-image-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/win/fast/lists/003-vertical-expected.txt:
- platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/win/transforms/2d/hindi-rotated-expected.txt:
- 5:41 PM Changeset in webkit [133831] by
-
- 2 edits in trunk/LayoutTests
[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101408
Reviewed by Kent Tamura.
Mistake with timezone was making this test flaky.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- 5:39 PM Changeset in webkit [133830] by
-
- 744 edits742 copies17 adds in trunk/LayoutTests
Unreviewed, new chromium-mac-mountainlion baselines for css3/selectors3.
- 5:29 PM Changeset in webkit [133829] by
-
- 5 edits in trunk/Source/WebCore
[V8] Don't leak <img> elements in content scripts
https://bugs.webkit.org/show_bug.cgi?id=101525
Reviewed by Ojan Vafai.
I found the leak that was causing a problem for bug 101110. We weren't
filling in the derefObjectFunction for HTMLImageElements (and
potentially some other types of elements). That manifests today as a
memory leak in content scripts (which use the derefObjectFunction for
nodes) and caused a memory leak after bug 101110 because we started
using the derefObjectFunction in the main world as well.
This patch adds ASSERTs so that we won't make this mistake in the future.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::defaultWeakCallback):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- 5:29 PM Changeset in webkit [133828] by
-
- 21 edits1 move1 add1 delete in trunk/Source/WebKit2
[WK2] Make WebVibrationProxy to be a member of WebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=100334
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-07
Reviewed by Anders Carlsson.
WebVibrationProxy should be a member of WebPageProxy, because the IPC
messages of WebVibrationProxy have page destination ID.
The r132386 proposed a way to add/delete message receivers that can
handle IPC messages with destination ID.
Previous implementation that creating WebVibrationProxy as a WebContext
member and using the global message receiver for the proxy can make
assertions after r132386.
To handle the vibration IPC messages properly, this patch will do the
followings.
1) Instead of WebContext, WebPageProxy will have the WebVibrationProxy.
2) WebVibrationProxy will add itself to the message receiver map of
the WebContext with page destination ID.
3) When WebProcessProxy received vibration ipc messages, it will
forward the messages to the WebContext first. Then the message
receiver map of the WebContext will handle the messages with the
registered WebVibrationProxy.
4) APIs will be modified to apply these changes.
a) WK API to get WKVibrationRef will use WKPageRef not WKContextRef.
b) EFL APIs and API test for the vibration will also be changed.
- EwkViewImpl will have vibration client. (EwkContext will not have it)
- Previous API to register the vibration callback will be removed.
- New signals for vibration will be added to the EwkViewImpl.
- VibrationProxy will be renamed to VibrationClient for the consistency with other clients in EwkViewImpl.
- VibrationClient will use EwkViewImpl instead of EwkContext.
- Previous API test for vibration will be moved from context test to view test, and it will use the changed API.
- PlatformEfl.cmake:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageGetVibration):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/efl/EwkViewCallbacks.h:
(EwkViewCallbacks):
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
(WebKit):
(EwkContext):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(VibrationCbData):
(onVibrate):
(onCancelVibration):
(loadVibrationHTMLString):
(TEST_F):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
- UIProcess/WebContext.h:
(WebKit):
(WebContext):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
(WebKit):
(WebPageProxy):
(WebKit::WebPageProxy::vibration):
- UIProcess/WebVibrationProxy.cpp:
(WebKit::WebVibrationProxy::create):
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
(WebKit::WebVibrationProxy::invalidate):
- UIProcess/WebVibrationProxy.h:
(WebKit):
(WebVibrationProxy):
- UIProcess/efl/VibrationClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.cpp.
(toVibrationClient):
(VibrationClientEfl::vibrateCallback):
(VibrationClientEfl::cancelVibrationCallback):
(VibrationClientEfl::create):
(VibrationClientEfl::VibrationClientEfl):
(VibrationClientEfl::~VibrationClientEfl):
- UIProcess/efl/VibrationClientEfl.h: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.h.
(WebKit):
(VibrationClientEfl):
- 5:26 PM Changeset in webkit [133827] by
-
- 4 edits2 copies in trunk/Source/WebKit2
Add empty RemoteLayerTree class
https://bugs.webkit.org/show_bug.cgi?id=101524
Reviewed by Simon Fraser.
Add a new RemoteLayerTree class which will contain the remote graphics layers.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/RemoteLayerTree.h: Added.
- WebProcess/WebPage/mac/RemoteLayerTree.mm: Added.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
- 5:18 PM Changeset in webkit [133826] by
-
- 4 edits in trunk/Source
Versioning.
- 5:16 PM Changeset in webkit [133825] by
-
- 5 edits1 move in trunk/Source/WebCore
IndexedDB: Prepare for IDBBackingStore merge by renaming IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=101486
Reviewed by Ojan Vafai.
Rename IDBLevelDBBackingStore.cpp to IDBBackingStore.cpp in
preparation for merging these classes. This will make the merge
diffs sane. See https://bugs.webkit.org/show_bug.cgi?id=101415
for the final goal.
No new tests, this is is just a rename and minor style fix.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBBackingStore.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- 5:13 PM Changeset in webkit [133824] by
-
- 1 copy in tags/Safari-537.18
New Tag.
- 4:56 PM Changeset in webkit [133823] by
-
- 2 edits in trunk/Source/WebCore
[V8] Prepare DOMDataStore to be able to store ScriptWrappable wrappers inline
https://bugs.webkit.org/show_bug.cgi?id=101523
Unreviewed. Technically this patch hasn't been reviewed, but it is part
of a patch that was reviewed by Kentaro Hara.
Sadly, my patch for bug 101110 triggered the regression again. This
patch is a smaller incremental step towards the patch in bug 101110. It
doesn't make that much sense on its own, but it will help me isolate
the source of the regression.
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):
- 4:52 PM Changeset in webkit [133822] by
-
- 2 edits2 deletes in trunk/LayoutTests
Unreviewed, fix mistakenly added pngs for failing compositing ref tests :(.
- platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Removed.
- platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Removed.
- platform/chromium/TestExpectations:
- 4:36 PM Changeset in webkit [133821] by
-
- 9 edits7 copies2 adds in trunk/LayoutTests
Unreviewed, clean up chromium-mac-mountainlion for remaining compositing, css3 (non selectors3) tests.
- platform/chromium-mac-lion/css3/css3-modsel-33-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-33-expected.png.
- platform/chromium-mac-lion/css3/css3-modsel-35-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-35-expected.png.
- platform/chromium-mac-lion/css3/css3-modsel-36-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-36-expected.png.
- platform/chromium-mac-lion/css3/css3-modsel-37-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-37-expected.png.
- platform/chromium-mac-lion/css3/flexbox/repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/flexbox/repaint-expected.png.
- platform/chromium-mac-lion/css3/font-feature-settings-rendering-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/font-feature-settings-rendering-expected.png.
- platform/chromium-mac-lion/css3/unicode-bidi-isolate-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png.
- platform/chromium-mac-mountainlion/TestExpectations:
- platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Added.
- platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Added.
- platform/chromium-mac/css3/css3-modsel-33-expected.png:
- platform/chromium-mac/css3/css3-modsel-35-expected.png:
- platform/chromium-mac/css3/css3-modsel-36-expected.png:
- platform/chromium-mac/css3/css3-modsel-37-expected.png:
- platform/chromium-mac/css3/flexbox/repaint-expected.png:
- platform/chromium-mac/css3/font-feature-settings-rendering-expected.png:
- platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
- 4:35 PM Changeset in webkit [133820] by
-
- 17 edits in trunk/Source/WebCore
SimplifyMarkupCommand takes a disproportionally long time to run when there are many nodes to remove
https://bugs.webkit.org/show_bug.cgi?id=101144
Reviewed by Enrica Casucci.
The bug was caused by attach() happening between each node removal. Since the command was trying
to remove millions of node in some cases, attach()ing render objects for each node being reinserted
imposed a huge runtime cost.
Fixed the bug by using lazy attach when removing nodes and avoiding calls to isContentEditable.
Also remove all ancestors at once when they are direct child/parent of each other so that we don't
remove an ancestor and then insert its child back only to remove it again in the next iteration.
No new tests since it doesn't change the asymptotic performance, and adding a new performance test for
this specific case is not the worth the increase in the bot cycle time. I'll note that the email
attached in the original radar bug (<rdar://problem/12179712>) took 100 seconds to open now only takes
7 seconds to open on my MacPro.
- editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply): Takes a flag indicating whether we should assume nodes are editable
without calling isContentEditable or not.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Update the style as later code requires render
object.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeBefore): Passes a flag to the command.
(WebCore::CompositeEditCommand::removeNode): Ditto.
(WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
- editing/CompositeEditCommand.h:
(CompositeEditCommand):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode): Takes a flag indicating whether we should assume nodes are
editable without calling isContentEditable or not.
- editing/DeleteSelectionCommand.h:
(DeleteSelectionCommand):
- editing/EditCommand.h:
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply): Update the layout when password echo is enabled since
we need to have render objects for echoing.
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
(WebCore::InsertNodeBeforeCommand::doApply): Ditto; also always use lazy attach.
(WebCore::InsertNodeBeforeCommand::doUnapply):
- editing/InsertNodeBeforeCommand.h:
(WebCore::InsertNodeBeforeCommand::create):
(InsertNodeBeforeCommand):
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto about the flag.
(WebCore::RemoveNodeCommand::doApply):
- editing/RemoveNodeCommand.h:
(WebCore::RemoveNodeCommand::create):
(RemoveNodeCommand):
- editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
(WebCore::RemoveNodePreservingChildrenCommand::doApply):
- editing/RemoveNodePreservingChildrenCommand.h:
(WebCore::RemoveNodePreservingChildrenCommand::create):
(RemoveNodePreservingChildrenCommand):
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove): Added to optimize removals of multiple
ancestors.
- editing/SimplifyMarkupCommand.h:
(SimplifyMarkupCommand):
- 4:22 PM Changeset in webkit [133819] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed, chromium expectations cleanup
Remove entries for a couple of passing tests and one stale pixel
result for a reftest.
- platform/chromium-mac-mountainlion/TestExpectations:
- platform/chromium-mac/fast/sub-pixel/float-wrap-zoom-expected.png: Removed.
- platform/chromium/TestExpectations:
- 4:20 PM Changeset in webkit [133818] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r133810.
http://trac.webkit.org/changeset/133810
https://bugs.webkit.org/show_bug.cgi?id=101520
This patch made ws_single_peak_r regress by 15% (Requested by
abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):
- 4:14 PM Changeset in webkit [133817] by
-
- 3 edits8 deletes in trunk/LayoutTests
Unreviewed, update chromium-mac-ml expectations after r133811 and r133814.
- platform/chromium-mac-mountainlion/TestExpectations:
- platform/chromium-mac/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/overflow-applies-to-007-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/overflow-applies-to-010-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/overflow-applies-to-012-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/overflow-applies-to-013-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/overflow-applies-to-014-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/overflow-applies-to-015-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/text-indent-014-expected.png: Removed.
- platform/chromium/TestExpectations:
- 4:11 PM Changeset in webkit [133816] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove exif-orientation-image-document.html from failure list
https://bugs.webkit.org/show_bug.cgi?id=101518
Unreviewed gardening.
fast/images/exif-orientation-image-document.html passes after r133728
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07
- platform/efl-wk1/TestExpectations:
- 4:09 PM Changeset in webkit [133815] by
-
- 10 edits2 adds in trunk/LayoutTests
Rebaselinene after external SVG unblocked in WK100485
https://bugs.webkit.org/show_bug.cgi?id=101248
Unreviewed update of test expectations.
- platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
- platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
- platform/chromium/TestExpectations:
- 3:48 PM Changeset in webkit [133814] by
-
- 476 edits475 copies4 adds in trunk/LayoutTests
Unreviewed, update chromium-mac-mountainlion baselines for css2.1
- 3:37 PM Changeset in webkit [133813] by
-
- 8 edits in trunk/Source/WebCore
Clean up confused use of Document::renderer and renderView
https://bugs.webkit.org/show_bug.cgi?id=101484
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-07
Reviewed by Ojan Vafai.
Document::renderer and Document::renderView are the same thing, but it seems
people don't always realize it and check if document()->renderer() is a RenderView.
This patch cleans up usage of document()->renderer() and document()->renderView() and
simplifies the code that was written without realizing they were the same thing.
No new tests, this is just a refactor.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint): Lots of simplification.
- dom/Element.cpp:
(WebCore::Element::screenRect):
(WebCore::Element::unregisterNamedFlowContentNode): Remove unneeded conditional.
- editing/FrameSelection.cpp: Remove verbose casts.
(WebCore::clearRenderViewSelection):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
- page/Frame.cpp:
(WebCore::Frame::contentRenderer): Vastly simplified.
- page/PrintContext.cpp: Remove verbose casts.
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
- page/wince/FrameWinCE.cpp:
(WebCore::computePageRectsForFrame): Remove unreachable code.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::maximalOutlineSize): Remove verbose cast.
- 3:34 PM Changeset in webkit [133812] by
-
- 7 edits in trunk/Source/JavaScriptCore
WeakBlocks should be HeapBlocks
https://bugs.webkit.org/show_bug.cgi?id=101411
Reviewed by Oliver Hunt.
Currently WeakBlocks use fastMalloc memory. They are very similar to the other HeapBlocks, however,
so we should change them to being allocated with the BlockAllocator.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::BlockAllocator):
- heap/BlockAllocator.h: Added a new RegionSet for WeakBlocks.
(JSC):
(BlockAllocator):
(JSC::WeakBlock):
- heap/Heap.h: Friended WeakSet to allow access to the BlockAllocator.
(Heap):
- heap/WeakBlock.cpp:
(JSC::WeakBlock::create): Refactored to use HeapBlocks rather than fastMalloc.
(JSC::WeakBlock::WeakBlock):
- heap/WeakBlock.h: Changed the WeakBlock size to 4 KB so that it divides evenly into the Region size.
(JSC):
(WeakBlock):
- heap/WeakSet.cpp:
(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::addAllocator):
- 3:25 PM Changeset in webkit [133811] by
-
- 256 edits255 copies9 adds in trunk/LayoutTests
Unreviewed, update chromium-mac-mountainlion baselines for css2.1/2011/0323
- 3:11 PM Changeset in webkit [133810] by
-
- 3 edits in trunk/Source/WebCore
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110
Reviewed by Kentaro Hara.
This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
- 3:01 PM Changeset in webkit [133809] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 2:48 PM Changeset in webkit [133808] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-07
Reviewed by Rob Buis.
RIM PR 236997
Internally Reviewed by Jakob Petsovits.
Set font family to fix DRT test fast/forms/input-type-text-min-width.html
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::defaultGUIFont):
(WebCore):
(WebCore::RenderThemeBlackBerry::systemFont):
- 2:27 PM Changeset in webkit [133807] by
-
- 9 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=101303
Fixed position elements that are out of view still end up forcing
non-threaded scrolling
-and corresponding-
<rdar://problem/12642222>
Reviewed by Simon Fraser.
Source/WebCore:
Re-name hasNonLayerFixedObjects() to
hasVisibleSlowRepaintFixedObjects() and make it virtual.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintFixedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Override hasVisibleSlowRepaintFixedObjects() to always return false.
We don't want to bother with the extra computation in the
ScrollingCoordinator implementation, though other ports might still
want it.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintFixedObjects):
(ScrollingCoordinatorMac):
Make this function const so that we can call it from
requiresCompositingForPosition().
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
Actually be thorough here and check if the fixed object has any
descendants that are visible in the view. If it does, then we do
want to composite the fixed object.
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
LayoutTests:
New tests for an invisible fixed object that has visible children.
- compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
- compositing/absolute-inside-out-of-view-fixed.html: Added.
- platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html: Added.
Updated results because these tests can now scroll on the scrolling
thread, yay!
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt:
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
- 1:58 PM Changeset in webkit [133806] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Style fix following r133262.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- 1:45 PM Changeset in webkit [133805] by
-
- 4 edits in trunk/Source/WebCore
[V8] DOMWrapperMap doesn't need to use virtual functions
https://bugs.webkit.org/show_bug.cgi?id=101494
Reviewed by Kentaro Hara.
DOMWrapperMap has only one subclass. There's no reason to use virtual functions.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::clear):
(WebCore::DOMWrapperMap::reportMemoryUsage):
(WebCore::DOMWrapperMap::remove):
(WebCore::DOMWrapperMap::defaultWeakCallback):
- bindings/v8/V8NPObject.cpp:
(WebCore::staticNPObjectMap):
- 1:42 PM Changeset in webkit [133804] by
-
- 2 edits in trunk/Tools
garden-o-matic should handle concurrent requests
https://bugs.webkit.org/show_bug.cgi?id=101407
Reviewed by Ojan Vafai.
Garden-o-Matic is implemented on top of the BaseHttpServer
python library, which implements a single-threaded (one request at
a time) server. This means that we can only rebaseline one test at
a time, and when using a local results file, even fetching the results
for diffs is single-threaded.
Mixing in the ThreadingMixin enables concurrent requests (subject
to the global python interpreter lock). Given that we're doing all
of the work in webkit-patch subprocesses, I think this is safe.
Of course, it may not be safe to do some of the subprocesses in
parallel (e.g., rollout), but I think as long as we don't issue
commands that touch overlapping sets of files things should be fine.
The file locking over modifying testexpectations should keep that
from being corrupted.
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPServer):
(GardeningHTTPRequestHandler):
- 1:30 PM Changeset in webkit [133803] by
-
- 7 edits in trunk/Source/WebCore
[CSS Shaders] Remove the dependency on CustomFilterValidatedProgram from CustomFilterRenderer
https://bugs.webkit.org/show_bug.cgi?id=101071
Reviewed by Dean Jackson.
I've removed the need to get a CustomFilterValidatedProgram from FilterEffectRenderer. It was only
used to delay the compilation of the shader until it was really needed. Instead, the FilterEffectRenderer
will directly get the compiled shader in the constructor. The callers that still want to avoid
compiling the shader until it is really needed can use the setCompiledProgram to inject the shader
at a later time, before painting.
No new tests, the change is covered by the css3/filters/custom/ tests.
- platform/graphics/filters/CustomFilterConstants.h:
- platform/graphics/filters/CustomFilterProgramInfo.h:
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
(WebCore::CustomFilterRenderer::premultipliedAlpha):
(WebCore::CustomFilterRenderer::setCompiledProgram):
(WebCore):
(WebCore::CustomFilterRenderer::prepareForDrawing):
(WebCore::CustomFilterRenderer::bindProgramAndBuffers):
- platform/graphics/filters/CustomFilterRenderer.h:
(WebCore):
(CustomFilterRenderer):
(WebCore::CustomFilterRenderer::compiledProgram):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::prepareForDrawing):
- platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
- 1:30 PM Changeset in webkit [133802] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove setUserStyleSheetString/userStyleSheetString
https://bugs.webkit.org/show_bug.cgi?id=101490
Reviewed by Yong Li.
We no longer need this API.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebSettings.cpp:
(WebKit):
- Api/WebSettings.h:
- 1:24 PM Changeset in webkit [133801] by
-
- 2 edits1 delete in trunk/LayoutTests
Update expectations for svg/text/text-rescale.svg
Unreviewed update of test expectations.
This test needed a rebaseline after r133786.
- platform/chromium-win/svg/text/text-rescale-expected.png:
- platform/efl/svg/text/text-rescale-expected.png: Removed.
- 1:15 PM Changeset in webkit [133800] by
-
- 2 edits in trunk/Source/JavaScriptCore
Indentation of ArgList.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101441
Reviewed by Andreas Kling.
Just unindented by 4 spaces.
- runtime/ArgList.h:
- 1:10 PM Changeset in webkit [133799] by
-
- 5 edits in trunk
Remove build-webkit dependency on Java SDK for Apple Mac WebKit.
<http://webkit.org/b/101492>
Patch by Andreas Kling <akling@apple.com> on 2012-11-07
Reviewed by Anders Carlsson.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Remove WebJavaPlugIn.h
Source/WebKit/mac:
- Plugins/WebJavaPlugIn.h: Removed.
Tools:
Don't check for a Java SDK before building the Apple Mac port. It's no longer needed for
the build after the Java bridge was removed.
- Scripts/build-webkit:
(cMakeArgsFromFeatures):
- 1:08 PM Changeset in webkit [133798] by
-
- 7 edits in trunk
[EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
https://bugs.webkit.org/show_bug.cgi?id=101496
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add window_geometry_set() / window_geometry_get() smart functions to
ewk_view allowing the client to provide its own implementation for
those.
This is particularly useful if the application uses elm_win because
the default implementation will not behave correctly in this case.
This is due to the fact that the default implementation interacts
with the Ecore_Evas that contains the view and is not aware of the
parent window widget.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::windowGeometry):
(EwkViewImpl::setWindowGeometry):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
Tools:
Provide implementation for on_window_geometry_get() / on_window_geometry_set()
smart functions that interact with the elm_win widget.
- MiniBrowser/efl/main.c:
(on_window_geometry_get):
(on_window_geometry_set):
(window_create):
- 12:54 PM Changeset in webkit [133797] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Adding myself to commiters.py.
- 12:47 PM Changeset in webkit [133796] by
-
- 2 edits in trunk/Source/WTF
Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
https://bugs.webkit.org/show_bug.cgi?id=101238
Reviewed by Benjamin Poulain.
'result' was a bool, but the asm was expecting a 32-bit register. A
recent version of Clang warned about this:
WebKit/Source/WTF/wtf/Atomics.h:163:34: error: the size being stored
is truncated, use a modifier to specify the size [-Werror,-Wasm-operand-widths]
This patch fixes it by making 'result' an unsigned. It does not change
the functionality in practice ('result' would be in a 32-bit register
anyway), but it makes the code more correct and makes the warning go
away.
Also make 'result' for the X86 version an 'unsigned char' to make it
more clear that it is a byte.
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
- 12:41 PM Changeset in webkit [133795] by
-
- 2 edits in trunk/Tools
[EFL][WK2][AC] API tests crash
https://bugs.webkit.org/show_bug.cgi?id=101480
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests.
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas):
- 12:39 PM Changeset in webkit [133794] by
-
- 5 edits1 delete in trunk/Source/WebCore
[V8] IntrusiveDOMWrapperMap is no longer needed and can be deleted
https://bugs.webkit.org/show_bug.cgi?id=101493
Reviewed by Kentaro Hara.
This patch is another incremental step towards landing the patch in bug
- In this patch, we delete IntrusiveDOMWrapperMap, which is no
longer needed.
- WebCore.gypi:
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):
(WebCore::DOMDataStore::weakCallback):
(WebCore):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):
- bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
- bindings/v8/V8GCController.cpp:
- 12:35 PM Changeset in webkit [133793] by
-
- 2 edits in trunk/Source/WTF
Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer.
https://bugs.webkit.org/show_bug.cgi?id=101420
Patch by Remy Demarest <rdemarest@apple.com> on 2012-11-07
Reviewed by Benjamin Poulain.
Add attributes to the adoptNS and adoptCF function arguments to remove Clang Static Analyzer diagnotics.
Define CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, use them in function declarations.
- wtf/RetainPtr.h:
(WTF::adoptCF): Adds CF_RELEASES_ARGUMENT attribute to the argument.
(WTF::adoptNS): Adds NS_RELEASES_ARGUMENT attribute to the argument.
- 12:34 PM Changeset in webkit [133792] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Adding myself to commiters.py.
- 12:32 PM Changeset in webkit [133791] by
-
- 2 edits in trunk/Source/WebCore
[AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are leaking in GraphicsSurface
https://bugs.webkit.org/show_bug.cgi?id=101475
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
Free the memory returned by glXChooseFBConfig and glXGetVisualFromFBConfig
using XFree to avoid memory leaks.
No tests. No change in behavior.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
- 12:10 PM Changeset in webkit [133790] by
-
- 4 edits in trunk/Source/WebCore
Autoresize should work even if turned on while the page is loading.
https://bugs.webkit.org/show_bug.cgi?id=101380
Reviewed by David Levin.
Autoresize does not work in cases where it is turned on while loading.
This patch addresses this by allowing autoSize to complete if it's turned on
while loading and doing a final pass after loading.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
Adjust to call renamed function.
- page/FrameView.cpp:
(WebCore::FrameView::handleLoadCompleted):
Rename function to encompass its expanded responsibilities (which include doing the final auto size after the load is completed).
(WebCore::FrameView::autoSizeIfEnabled):
Allow the size to shrink if autosize is adjusted while the page is loading.
- page/FrameView.h:
(FrameView):
Renamed 'checkFlushDeferredRepaintsAfterLoadComplete' to 'handleLoadComplete'
- 11:49 AM Changeset in webkit [133789] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226
Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-11-07
Reviewed by Csaba Osztrogonác.
- Api/qwebpage.cpp: Fix after r133763, move the initialization of OpenLinkInThisWindow to the proper place.
- 11:35 AM Changeset in webkit [133788] by
-
- 2 edits in trunk/Source/WebKit/efl
Unreviewed EFL build fix.
- ewk/ewk_view.cpp:
- 11:31 AM Changeset in webkit [133787] by
-
- 2 edits in trunk/Source/Platform
Add API for touchEventHandlerRegion to WebLayer
https://bugs.webkit.org/show_bug.cgi?id=101406
Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-11-07
Reviewed by James Robinson.
These will be used to keep track of JavaScript touch event handlers from the compositor thread.
- chromium/public/WebLayer.h:
(WebKit::WebLayer::setTouchEventHandlerRegion):
(WebKit::WebLayer::touchEventHandlerRegion):
(WebLayer):
- 11:26 AM Changeset in webkit [133786] by
-
- 11 edits in trunk
Skip SVG repaint tracking when parent container transforms
https://bugs.webkit.org/show_bug.cgi?id=101177
Reviewed by Eric Seidel.
Source/WebCore:
This patch skips child repaint rect checks when a parent container is transformed, leading
to a 75% increase on the RoboHornet SVG benchmark:
http://www.robohornet.org/#et=svg (average of 2 runs)
Before patch: 161.6ms
After patch: 38.5ms
SVG transforms are relative to the local container which makes calculating an absolute
repaint rect expensive because it requires multiplying the local repaint rect by each
parent container's local transform. See SVGRenderSupport::computeFloatRectForRepaint
as an example of this calculation.
This patch takes advantage of SVG's container rules: when a parent container's transform
changes, all children must be repainted (there is no absolute positioning in SVG).
SVGRenderSupport::checkForSVGRepaintDuringLayout has been added which checks for whether
the parent transform changed before doing child repaint checks. A similar optimization is
used in HTML (see RenderObject::checkForRepaintDuringLayout) where no repaint checking
is done when the view is fully repainted.
This code is tested in existing tests.
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::layout):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore):
- rendering/svg/SVGRenderSupport.h:
(SVGRenderSupport):
LayoutTests:
The repaint area in svg/repaint/inner-svg-change-viewBox.svg has
been tightened as a result of this patch.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- 11:24 AM Changeset in webkit [133785] by
-
- 2 edits in trunk/Source/WebCore
AX: Textfields don't get focus when navigated to from 'show all tabs' button
https://bugs.webkit.org/show_bug.cgi?id=101369
Reviewed by Darin Adler.
When focus leaves a webpage, the webpage does not normally clear its focused node. When focus
returns (through tab, or mouse click), then focus will be cleared and restored.
However, when focus is returned through accessibility means, focus is not cleared first, which
means subsequent focus actions do nothing.
This fix will check if the focused node is the same as the node being focused, and if so, clear the focus first.
Making a layout test for this is not possible because it requires setting focus to something in the chrome, and then
moving focus back to the webpage.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):
- 11:02 AM Changeset in webkit [133784] by
-
- 2 edits in trunk/LayoutTests
[Qt] Text on scaled layer is blurry
https://bugs.webkit.org/show_bug.cgi?id=101491
Unreviewed gardening.
Mark tests as ImageOnlyFailure.
- platform/qt-5.0-wk2/TestExpectations:
- 10:59 AM Changeset in webkit [133783] by
-
- 14 edits2 deletes in trunk/Source
[V8] We should hide the DOMWrapperMaps inside DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101430
Reviewed by Kentaro Hara.
Source/WebCore:
This is yet another incremental step towards landing the patch in bug
- In this patch, we hide the existence of DOMWrapperMaps inside
DOMDataStore. In the process, we can remove V8DOMMap.cpp.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::set):
- bindings/v8/DOMWrapperWorld.h:
- bindings/v8/ScriptProfiler.cpp:
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::neuterBinding):
- bindings/v8/V8DOMMap.cpp: Removed.
- bindings/v8/V8DOMMap.h: Removed.
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
(WebCore::V8DOMWrapper::setWrapperClass):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- bindings/v8/V8NPObject.cpp:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerScriptController.cpp:
Source/WebKit/chromium:
Remove unneeded header includes.
- src/WebScriptController.cpp:
- 10:53 AM Changeset in webkit [133782] by
-
- 2 edits in trunk/LayoutTests
Enable text dump in fast/forms/file/get-file-upload.html earlier.
https://bugs.webkit.org/show_bug.cgi?id=101468
Reviewed by Kentaro Hara.
Do not call testRunner.dumpAsText() only when processing the form
submission, since that will not be triggered if a port does not
support, say, beginDragWithFiles(), and a useless pixel result
will be generated in that case.
Instead, call dumpAsText() as early as possible.
- fast/forms/file/get-file-upload.html:
- 10:49 AM Changeset in webkit [133781] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt][ARM] REGRESSION(r133688): It made all JSC and layout tests crash on ARM traditional platform
https://bugs.webkit.org/show_bug.cgi?id=101465
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-07
Reviewed by Oliver Hunt.
Fix failing javascriptcore tests on ARM after r133688
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- 10:37 AM Changeset in webkit [133780] by
-
- 9 edits in trunk
Add new gesture type, LongTap, which is basically the completion of a GestureLongPress
https://bugs.webkit.org/show_bug.cgi?id=101385
Patch by Varun Jain <varunjain@chromium.org> on 2012-11-07
Reviewed by Adam Barth.
Test: Only creating the new enum. No functionality change, hence no tests required.
Source/WebCore:
- platform/PlatformEvent.h:
Source/WebKit/chromium:
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
- 10:33 AM Changeset in webkit [133779] by
-
- 116 edits9 moves1 add3 deletes in trunk/Source
Remove LayoutTypes abstraction
https://bugs.webkit.org/show_bug.cgi?id=93050
Reviewed by Levi Weintraub.
Remove LayoutTypes abstraction and rename FractionalLayout* to
Layout* now that all platforms use the FractionalLayout version
(albeit with different fractions).
No new tests, no change in functionality.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityNodeObject.cpp:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.h:
- css/LengthFunctions.cpp:
- css/LengthFunctions.h:
- dom/Document.h:
- dom/DocumentMarkerController.h:
- dom/ElementRareData.h:
- dom/MouseRelatedEvent.h:
- dom/Node.h:
- dom/Touch.h:
- editing/FrameSelection.cpp:
- editing/FrameSelection.h:
- editing/RenderedPosition.h:
- html/HTMLAreaElement.h:
- inspector/InspectorOverlay.h:
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
- inspector/TimelineRecordFactory.h:
- loader/cache/CachedImage.h:
- page/FocusController.h:
- page/FrameView.h:
- page/Page.h:
- page/SpatialNavigation.cpp:
- page/SpatialNavigation.h:
- platform/FractionalLayoutUnit.h: Removed.
- platform/LayoutUnit.h: Copied from Source/WebCore/platform/FractionalLayoutUnit.h.
- platform/Length.h:
- platform/PopupMenuClient.h:
- platform/animation/AnimationUtilities.h:
- platform/graphics/FloatPoint.cpp:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.cpp:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.cpp:
- platform/graphics/FloatSize.h:
- platform/graphics/FractionalLayoutBoxExtent.cpp: Removed.
- platform/graphics/FractionalLayoutBoxExtent.h: Removed.
- platform/graphics/FractionalLayoutPoint.h: Removed.
- platform/graphics/FractionalLayoutRect.cpp: Removed.
- platform/graphics/FractionalLayoutRect.h: Removed.
- platform/graphics/FractionalLayoutSize.h: Removed.
- platform/graphics/GraphicsLayer.cpp:
- platform/graphics/GraphicsLayerAnimation.cpp:
- platform/graphics/IntRect.cpp:
- platform/graphics/IntRect.h:
- platform/graphics/LayoutBoxExtent.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.cpp.
- platform/graphics/LayoutBoxExtent.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.h.
- platform/graphics/LayoutPoint.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutPoint.h.
- platform/graphics/LayoutRect.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.cpp.
- platform/graphics/LayoutRect.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.h.
- platform/graphics/LayoutSize.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutSize.h.
- platform/graphics/MediaPlayer.h:
- platform/graphics/filters/CustomFilterOperation.h:
- platform/graphics/filters/CustomFilterParameterList.h:
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/filters/FilterOperations.h:
- platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
- platform/graphics/filters/ValidatedCustomFilterOperation.h:
- platform/graphics/qt/FractionalLayoutPointQt.cpp: Removed.
- platform/graphics/qt/FractionalLayoutRectQt.cpp: Removed.
- platform/graphics/qt/FractionalLayoutSizeQt.cpp: Removed.
- platform/graphics/qt/LayoutPointQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp.
- platform/graphics/qt/LayoutRectQt.cpp: Added.
- platform/graphics/qt/LayoutSizeQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp.
- platform/graphics/transforms/TransformOperations.h:
- platform/graphics/transforms/TransformState.h:
- platform/graphics/transforms/TransformationMatrix.cpp:
- platform/graphics/transforms/TransformationMatrix.h:
- rendering/AutoTableLayout.h:
- rendering/ColumnInfo.h:
- rendering/ExclusionShapeInsideInfo.h:
- rendering/FilterEffectRenderer.h:
- rendering/FixedTableLayout.h:
- rendering/GapRects.h:
- rendering/HitTestResult.h:
- rendering/HitTestingTransformState.cpp:
- rendering/HitTestingTransformState.h:
- rendering/InlineFlowBox.cpp:
- rendering/LayoutRepainter.cpp:
- rendering/LayoutRepainter.h:
- rendering/LayoutState.h:
- rendering/LayoutTypes.h:
- rendering/LayoutTypesInlineMethods.h:
- rendering/PaintInfo.h:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
- rendering/RenderBoxModelObject.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
- rendering/RenderFieldset.cpp:
- rendering/RenderFlexibleBox.cpp:
- rendering/RenderFlowThread.cpp:
- rendering/RenderGeometryMap.h:
- rendering/RenderImageResource.h:
- rendering/RenderInline.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerFilterInfo.h:
- rendering/RenderLineBoxList.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderMarquee.cpp:
- rendering/RenderMenuList.h:
- rendering/RenderMultiColumnBlock.cpp:
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderNamedFlowThread.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderOverflow.h:
- rendering/RenderRegion.cpp:
- rendering/RenderReplaced.cpp:
- rendering/RenderTable.cpp:
- rendering/RenderTable.h:
- rendering/RenderText.cpp:
- rendering/RenderThemeChromiumCommon.cpp:
- rendering/RenderThemeChromiumCommon.h:
- rendering/RenderTreeAsText.cpp:
- rendering/RenderTreeAsText.h:
- rendering/RenderView.h:
- rendering/style/NinePieceImage.h:
- rendering/style/RenderStyle.h:
- rendering/style/ShadowData.cpp:
- rendering/style/ShadowData.h:
- rendering/style/StyleCachedImageSet.h:
- rendering/style/StyleImage.h:
- rendering/svg/SVGRenderSupport.h:
Source/WebKit/chromium:
- src/LinkHighlight.cpp:
- 10:33 AM Changeset in webkit [133778] by
-
- 2 edits in trunk/Tools
Don't show the Android tester in garden-o-matic yet
https://bugs.webkit.org/show_bug.cgi?id=101476
Reviewed by Adam Barth.
The Android tester just started running layout tests, and doesn't upload its
results yet. Don't show it for now. This exception will be removed once it
has a baseline of greenness.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
- 10:29 AM Changeset in webkit [133777] by
-
- 5 edits in trunk/Source
CoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation instead
https://bugs.webkit.org/show_bug.cgi?id=100905
Reviewed by Noam Rosenthal.
Source/WebCore:
Added getters for the validated shaders, so that platform code could extract them.
No new tests, just added two getters.
- platform/graphics/filters/CustomFilterValidatedProgram.h:
(WebCore::CustomFilterValidatedProgram::validatedVertexShader):
(WebCore::CustomFilterValidatedProgram::validatedFragmentShader):
(CustomFilterValidatedProgram):
Source/WebKit2:
The code now knows how to read a ValidatedCustomFitlerOperation and serialize it to the UI process.
No new tests, the code path is not used yet.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/CoordinatedGraphics/WebCustomFilterProgram.h:
- 10:26 AM Changeset in webkit [133776] by
-
- 5 edits3 adds in trunk
IndexedDB: Assertion failure with open() within upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=96947
Reviewed by Dimitri Glazkov.
Source/WebCore:
Postpone creation of the "pending second half open" until the version change
transaction has started.
Test: storage/indexeddb/unblocked-version-changes.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseCallbacks.h:
LayoutTests:
Exercise the code path leading to the assert by having a second version change transaction
unblocked by the first's connection closing. Includes a known failure due to metadata
snapshot timing.
- storage/indexeddb/resources/unblocked-version-changes.js: Added.
(test):
(openConnection):
(onUpgradeNeeded):
(onError):
(onUpgradeNeeded2):
(onSuccess):
- storage/indexeddb/unblocked-version-changes-expected.txt: Added.
- storage/indexeddb/unblocked-version-changes.html: Added.
- 10:20 AM Changeset in webkit [133775] by
-
- 8 edits in branches/safari-536.28-branch/Source/WebCore
Merged r129652. <rdar://problem/12516382>
- 9:57 AM Changeset in webkit [133774] by
-
- 3 edits3 copies in branches/safari-536.28-branch
Merged r129535. <rdar://problem/12536360>
- 9:55 AM Changeset in webkit [133773] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r129469. <rdar://problem/12536545>
- 9:48 AM Changeset in webkit [133772] by
-
- 1 edit17 adds in trunk/LayoutTests
Fix failing platform/mac/tiled-drawing on Lion.
It's not possible to use TestExpectations to skip tests on all but current mac-wk2,
so just land results for Lion.
- platform/mac-lion/platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-after-scroll-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Added.
- platform/mac-lion/platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
- 9:46 AM Changeset in webkit [133771] by
-
- 5 edits in trunk/Source/WebCore
[CSS Shaders] Add CustomFilterMeshBoxType to ValidatedCustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=100890
Reviewed by Dean Jackson.
Added the CustomFilterMeshBoxType parameter to the ValidatedCustomFilterOperation.
No new tests, this parameter is not used in the implementation yet.
- platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
(WebCore::ValidatedCustomFilterOperation::ValidatedCustomFilterOperation):
- platform/graphics/filters/ValidatedCustomFilterOperation.h:
(WebCore::ValidatedCustomFilterOperation::create):
(WebCore::ValidatedCustomFilterOperation::meshBoxType):
(WebCore::ValidatedCustomFilterOperation::operator==):
(ValidatedCustomFilterOperation):
- rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeFilterOperations):
- 9:39 AM Changeset in webkit [133770] by
-
- 3 edits in trunk/Source/WebCore
[Qt] Implement deleteCookie() for persistent storage
https://bugs.webkit.org/show_bug.cgi?id=101272
Reviewed by Jocelyn Turcotte.
Individual cookies were never persistently cleared as the
deleteCookie() virtual method was not implemented for persistent
storage. That's why cookies were only deleted for the current
session.
- platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::deleteCookie):
(WebCore): added deleteCookie() implementation for persistent
storage.
- platform/qt/CookieJarQt.h:
(SharedCookieJarQt):
- 9:35 AM Changeset in webkit [133769] by
-
- 3 edits2 adds in trunk
[Shadow] Style should update when 'pseudo' attribute is dynamically updated
https://bugs.webkit.org/show_bug.cgi?id=100918
Reviewed by Dimitri Glazkov.
Source/WebCore:
When 'pseudo' attribute is changed and its element is in ShadowTree, we enable the styleShouldRecalc flag.
It would be fast if we have a set of pseudo attribute style value in RuleFeatureSet,
but it might consume a lot of memory.
Test: fast/dom/shadow/pseudo-attribute-dynamic.html
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
LayoutTests:
- fast/dom/shadow/pseudo-attribute-dynamic-expected.html: Added.
- fast/dom/shadow/pseudo-attribute-dynamic.html: Added.
- 9:33 AM Changeset in webkit [133768] by
-
- 5 edits in trunk/Tools
WebKitTestRunner flakily hangs when running pixel tests on Qt
https://bugs.webkit.org/show_bug.cgi?id=100686
Reviewed by Csaba Osztrogonác.
Make WebKitTestRunner harden against the situation when the coordinated
graphics rendering synchronisation fails. If we time out when waiting
for the forced repaint to finish it usually a symptom of the synchronisation
has been broken. In this case all other tests will fail with the same error.
The underlying problem is not yet known. Ths patch make us report this situation
as web process unresponsiveness, so the test harness will kill us and launch
a new instance. This will make our pixel test bot usable while it should not limit
us debugging the underlying bug.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/TestInvocation.h:
(TestInvocation): Introduce new members to hold our state
that was local to invoke() so far.
- WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- 9:30 AM Changeset in webkit [133767] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations update.
- platform/chromium/TestExpectations:
- 9:14 AM Changeset in webkit [133766] by
-
- 1 edit3 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening. Rebaseline the tests added
in http://trac.webkit.org/changeset/133686 - part deux.
- platform/chromium-win/fast/backgrounds/transformed-body-background-expected.png: Added.
- platform/chromium-win/fast/backgrounds/transformed-body-html-background-expected.png: Added.
- platform/chromium-win/fast/backgrounds/transformed-html-body-background-expected.png: Added.
- 9:12 AM Changeset in webkit [133765] by
-
- 2 edits in trunk/Source/WebCore
[V8] WebKit sends unnecessary low memory notification when running memory benchmarks
https://bugs.webkit.org/show_bug.cgi?id=101474
Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-11-07
Reviewed by Kentaro Hara.
Do not send low memory notification to V8 when most of memory usage
comes from V8 heap and not DOM objects. In this case V8 can schedule GC
itself more optimally.
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
- 8:28 AM Changeset in webkit [133764] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07
- DEPS:
- 8:12 AM Changeset in webkit [133763] by
-
- 10 edits in trunk
[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226
Reviewed by Simon Hausmann.
Source/WebCore:
Adds the action to the WebCore context-menu controller.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.h:
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::contextMenuItemTagOpenLinkInThisWindow):
Source/WebKit/qt:
Adds the action to QtWebKit.
- Api/qwebpage.cpp:
(webActionForContextMenuAction):
(QWebPage::triggerAction):
(QWebPage::action):
- Api/qwebpage.h:
Tools:
Populates the context-menu with the new action when the default action is to open in a new window.
- QtTestBrowser/webview.cpp:
(createContextMenu):
- 8:05 AM Changeset in webkit [133762] by
-
- 2 edits in branches/chromium/1312/Source/WebCore/inspector/front-end
Merge 133750 - Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355
Reviewed by Pavel Feldman.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
TBR=vsevik@chromium.org
BUG=159820
Review URL: https://codereview.chromium.org/11377027
- 8:04 AM Changeset in webkit [133761] by
-
- 6 edits in trunk
[EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
https://bugs.webkit.org/show_bug.cgi?id=101467
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
Tools:
Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.
Set default minimum contents width to '0' for MiniBrowser as it should behave like desktop browser.
- MiniBrowser/efl/main.c:
(window_create):
- 7:16 AM Changeset in webkit [133760] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2][AC] Avoid creating an empty surface
https://bugs.webkit.org/show_bug.cgi?id=101464
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
Make sure we have a valid view size before creating a GL surface.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
- 7:13 AM Changeset in webkit [133759] by
-
- 3 edits in trunk/LayoutTests
Layout Test inspector/debugger/script-formatter-breakpoints.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101361
Unreviewed test fix.
- inspector/debugger/script-formatter-breakpoints.html:
- platform/chromium/TestExpectations:
- 7:07 AM Changeset in webkit [133758] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening
Some image expectetions was accidentally added for reference tests and it consused nrwt.
Deleted them.
- platform/qt-5.0-wk2/compositing/text-on-scaled-layer-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/text-on-scaled-surface-expected.png: Removed.
- platform/qt/css2.1/20110323/margin-collapse-clear-016-expected.png: Removed.
- platform/qt/svg/animations/animateMotion-additive-2c-expected.png: Removed.
- 7:05 AM Changeset in webkit [133757] by
-
- 2 edits in trunk/Tools
[EFL] Add EFL to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=101444
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
Added the EFL bots running layout tests to the garden-o-matic report
page. We are skipping here the bot that just builds WebKit EFL to make
the data fetching faster.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
- 6:58 AM Changeset in webkit [133756] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a timeout expectation for the test introduced in r133660.
Adding timeout expectations for two media tests that started timing
out probably after r133633.
- platform/gtk/TestExpectations:
- 6:55 AM Changeset in webkit [133755] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][UNIX] Crash in WebKit::PluginProcessProxy::scanPlugin()
https://bugs.webkit.org/show_bug.cgi?id=101446
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
Make sure that the disposition of the SIGCHLD signal is reset to the default
before calling g_spawn_sync(). If the disposition is set to SIG_IGN, then
g_spawn_sync() will not be able to return the exit status of the child
process, our exit failure check will be useless and the following warning
will be printed:
GLib-WARNING : In call to g_spawn_sync(), exit status of a child process
was requested but SIGCHLD action was set to SIG_IGN and ECHILD was received
by waitpid(), so exit status can't be returned. This is a bug in the
program calling g_spawn_sync(); either don't request the exit status, or
don't set the SIGCHLD action.
This patch also adds a NULL-check for stdOut to avoid crashing in such
case and makes use of String::split() to parse stdOut instead of doing it
manually.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 6:52 AM Changeset in webkit [133754] by
-
- 7 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Rebaselining a few ruby tests.
- platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
- platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- 6:42 AM Changeset in webkit [133753] by
-
- 1 edit3 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening after r133688, remove unnecessary platform specific expected files.
- platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
- platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
- platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
- 6:37 AM Changeset in webkit [133752] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Canvas] closure compiler fixes
https://bugs.webkit.org/show_bug.cgi?id=101459
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- 6:18 AM Changeset in webkit [133751] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r133712.
http://trac.webkit.org/changeset/133712
https://bugs.webkit.org/show_bug.cgi?id=101461
Broke fast/forms/time* tests on chromium-win. (Requested by
mkwst on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07
- platform/text/win/LocaleWin.cpp:
(WebCore::DateFormatToken::DateFormatToken):
(DateFormatToken):
(WebCore):
(WebCore::isEraSymbol):
(WebCore::isYearSymbol):
(WebCore::isMonthSymbol):
(WebCore::isDaySymbol):
(WebCore::commitLiteralToken):
(WebCore::parseDateFormat):
(WebCore::LocaleWin::ensureShortDateTokens):
(WebCore::convertWindowsDateFormatToLDML):
(WebCore::mapCharacterToDateTimeFieldType):
(WebCore::convertWindowsTimeFormatToLDML):
(WebCore::LocaleWin::dateFormat):
(WebCore::LocaleWin::monthFormat):
(WebCore::LocaleWin::timeFormat):
(WebCore::LocaleWin::shortTimeFormat):
- platform/text/win/LocaleWin.h:
(LocaleWin):
- 6:14 AM Changeset in webkit [133750] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355
Reviewed by Pavel Feldman.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
- 6:13 AM Changeset in webkit [133749] by
-
- 21 edits in trunk
[Shadow] Use setPseudo() instead of setShadowPseudoId().
https://bugs.webkit.org/show_bug.cgi?id=101306
Reviewed by Kent Tamura.
.:
Exposes necessary symbols.
- Source/autotools/symbols.filter:
Source/WebCore:
We would like to remove setShadowPseudoId() and use setPseudo() instead, since ShadowDOM spec now has
'pseudo' attribute.
We change all setShadowPseudoId() invocation to setPseudo() invocation. Also, when AtomicString is not
constructed with AtomicStringFromLiteral, we use it.
No new tests, refactoring.
- WebCore.exp.in:
- dom/Element.cpp:
- dom/Element.h:
(Element):
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize):
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement):
- html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):
- testing/Internals.cpp:
(WebCore::Internals::setShadowPseudoId):
Source/WebKit2:
Exposes necessary symbols.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
- 5:57 AM Changeset in webkit [133748] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
navigator-vibration.html is still crashing occasionally.
- platform/efl-wk2/TestExpectations:
- 5:53 AM Changeset in webkit [133747] by
-
- 5 edits2 adds in trunk
Web Inspector: [Canvas] Save CanvasGradient objects state for a replay
https://bugs.webkit.org/show_bug.cgi?id=101432
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.
Source/WebCore:
Save CanvasGradient resource state for a subsequent replay. The gradient's state is modified by the gradient.addColorStop() call.
Test: inspector/profiler/canvas2d/canvas2d-gradient-capturing.html
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
LayoutTests:
Alerts about API changes to CanvasGradient and CanvasPattern classes.
Checks capturing for CanvasGradient objects' state.
- inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt:
- inspector/profiler/canvas2d/canvas2d-api-changes.html:
- inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt: Added.
- inspector/profiler/canvas2d/canvas2d-gradient-capturing.html: Added.
- 5:51 AM Changeset in webkit [133746] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Regression] Snippets evaluations should not appear in Sources tab of navigator.
https://bugs.webkit.org/show_bug.cgi?id=101354
Reviewed by Pavel Feldman.
- inspector/front-end/DebuggerScriptMapping.js:
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.isSnippet):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._snippetIdForSourceURL):
- 5:50 AM Changeset in webkit [133745] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
fast/repaint/block-selection-gap-in-table-cell.html is not
rendering correctly, so skip it when running pixel tests. Need a
- platform/efl/TestExpectations:
- 5:45 AM Changeset in webkit [133744] by
-
- 39 edits in trunk
[EFL][WK2] Make EWK classes Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101057
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.
Now all the existing EWK classes share common Ewk_Object ref/unref API.
Source/WebKit2:
- UIProcess/API/efl/EwkViewCallbacks.h:
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/API/efl/ewk_database_manager.cpp:
(Ewk_Database_Manager::createOriginList):
- UIProcess/API/efl/ewk_database_manager_private.h:
- UIProcess/API/efl/ewk_file_chooser_request.cpp:
(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_allow_multiple_files_get):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_cancel):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):
- UIProcess/API/efl/ewk_file_chooser_request.h:
- UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest):
(EwkFileChooserRequest::create):
- UIProcess/API/efl/ewk_form_submission_request.cpp:
(EwkFormSubmissionRequest::EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::~EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::fieldValue):
(EwkFormSubmissionRequest::fieldNames):
(EwkFormSubmissionRequest::submit):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):
- UIProcess/API/efl/ewk_form_submission_request.h:
- UIProcess/API/efl/ewk_form_submission_request_private.h:
(EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::create):
- UIProcess/API/efl/ewk_intent.cpp:
(EwkIntent::EwkIntent):
(EwkIntent::webIntentData):
(EwkIntent::action):
(EwkIntent::type):
(EwkIntent::service):
(EwkIntent::suggestions):
(EwkIntent::extra):
(EwkIntent::extraKeys):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
- UIProcess/API/efl/ewk_intent.h:
- UIProcess/API/efl/ewk_intent_private.h:
(EwkIntent):
(EwkIntent::create):
- UIProcess/API/efl/ewk_intent_service.cpp:
(EwkIntentService::EwkIntentService):
(EwkIntentService::action):
(EwkIntentService::type):
(EwkIntentService::href):
(EwkIntentService::title):
(EwkIntentService::disposition):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):
- UIProcess/API/efl/ewk_intent_service.h:
- UIProcess/API/efl/ewk_intent_service_private.h:
(EwkIntentService):
(EwkIntentService::create):
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(EwkNavigationPolicyDecision::EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::~EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::navigationType):
(EwkNavigationPolicyDecision::mouseButton):
(EwkNavigationPolicyDecision::modifiers):
(EwkNavigationPolicyDecision::frameName):
(EwkNavigationPolicyDecision::request):
(EwkNavigationPolicyDecision::accept):
(EwkNavigationPolicyDecision::reject):
(EwkNavigationPolicyDecision::download):
(ewk_navigation_policy_navigation_type_get):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
(ewk_navigation_policy_decision_accept):
(ewk_navigation_policy_decision_reject):
(ewk_navigation_policy_decision_download):
- UIProcess/API/efl/ewk_navigation_policy_decision.h:
- UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
(EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::create):
- UIProcess/API/efl/ewk_resource.cpp:
(EwkResource::EwkResource):
(EwkResource::url):
(EwkResource::isMainResource):
(ewk_resource_url_get):
(ewk_resource_main_resource_get):
- UIProcess/API/efl/ewk_resource.h:
- UIProcess/API/efl/ewk_resource_private.h:
(EwkResource):
(EwkResource::create):
- UIProcess/API/efl/ewk_security_origin.cpp:
(EwkSecurityOrigin::EwkSecurityOrigin):
(EwkSecurityOrigin::host):
(EwkSecurityOrigin::protocol):
(EwkSecurityOrigin::port):
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
(ewk_security_origin_port_get):
- UIProcess/API/efl/ewk_security_origin.h:
- UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin):
(EwkSecurityOrigin::create):
- UIProcess/API/efl/ewk_storage_manager.cpp:
(Ewk_Storage_Manager::createOriginList):
- UIProcess/API/efl/ewk_url_scheme_request_private.h:
(EwkUrlSchemeRequest):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_deliver):
- UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
(onFileChooserRequest):
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
(TEST_F):
- UIProcess/efl/FormClientEfl.cpp:
(WebKit::FormClientEfl::willSubmitForm):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
- UIProcess/efl/PagePolicyClientEfl.cpp:
(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::runOpenPanel):
- UIProcess/efl/ResourceLoadClientEfl.cpp:
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
- UIProcess/efl/ResourceLoadClientEfl.h:
Tools:
- MiniBrowser/efl/main.c:
(close_file_picker):
(on_file_chooser_request):
- 5:42 AM Changeset in webkit [133743] by
-
- 2 edits in branches/chromium/1312/Source/WebKit/chromium
Merge 133132 - [Chromium] Page popup shows up at wrong locations when root view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=100830
Reviewed by Kent Tamura.
We need to account for the scroll position when calculating the root view rectangle in the screen.
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11275190
- 5:35 AM Changeset in webkit [133742] by
-
- 4 edits in trunk/LayoutTests
Unreviewed inspector test polish.
Made http/tests/indexeddb/database-data.html test faster, added more verbose errors for test debugging.
- http/tests/inspector/indexeddb/database-data-expected.txt:
- http/tests/inspector/indexeddb/database-data.html:
- http/tests/inspector/indexeddb/indexeddb-test.js:
(onIndexedDBError):
(onIndexedDBBlocked):
(doWithDatabase):
- 5:35 AM Changeset in webkit [133741] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Return earlier if a plugin snapshot cannot be created.
https://bugs.webkit.org/show_bug.cgi?id=101445
Reviewed by Kenneth Rohde Christiansen.
Currently only the Mac port has support for creating snapshots of
Netscape plugins. Return earlier in PluginProxy::snapshot() so
that we do not pass a null handler to ShareableBitmap::create()
and avoid crashing when running pixel tests with plugins.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::snapshot):
- 5:33 AM Changeset in webkit [133740] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Change encoding detector API names
https://bugs.webkit.org/show_bug.cgi?id=101450
Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.
To make settings API name consistent, we need to change two APIs with respect to encoding detector.
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- 5:15 AM Changeset in webkit [133739] by
-
- 8 edits4 adds in trunk/LayoutTests
[EFL] Gardening. Add or fix a few pixel expectations.
- platform/efl/compositing/plugins/composited-plugin-expected.png:
- platform/efl/compositing/repaint/composited-document-element-expected.png: Added.
- platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
- platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/efl/plugins/iframe-plugin-bgcolor-expected.png: Added.
- platform/efl/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
- platform/efl/plugins/netscape-dom-access-expected.png: Added.
- 5:14 AM Changeset in webkit [133738] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed. Add Qt EWS bots to the watchers list.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(QtEWS):
(QtWK2EWS):
- 4:55 AM Changeset in webkit [133737] by
-
- 1 edit7 deletes in trunk/LayoutTests
Now that it no longer produces image results, remove unnecessary
PNGs for crash-hw-sw-switch.html. Unreviewed.
- platform/chromium-android/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- 4:39 AM Changeset in webkit [133736] by
-
- 9 edits3 adds in trunk
Source/WebKit2: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611
Reviewed by Gyuyoung Kim.
When WebKitTestRunner turns on the spelling feature with the resetStateToConsistentValues() method,
it happens that the WebProcess is still not launched (although it is already created).
In this case, isValid() method returns false.
This fix sends a message to the WebProcess messages queue, and the message
will be handled once the WebProcess is ready.
- Target.pri:
Adds missing files to compile spellcheking feature for WebKit2-Qt
to use WebKit C API from WKTextChecker.h.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::updateTextCheckerState):
Uses canSendMessage() method instead of isValid() to check whether the message to
the WebProcess can be sent.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Calls TextChecker::setContinuousSpellCheckingEnabled which additionaly invokes the client's method.
WK2-EFL settings for text checker (ewk_settings.cpp) set the default language (if it wasn't set earlier) to
perform the spelling. It allows to pass the tests from editing/spelling directory.
Tools: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611
Reviewed by Gyuyoung Kim.
WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Enables spelling by WebKit2 C API.
LayoutTests: [EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611
Reviewed by Gyuyoung Kim.
Unskip the spelling tests from efl-wk2/TestExpectations to run them for WebKit2-EFL.
Add new missing baselines for two spelling tests for EFL platform.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Added.
- platform/efl/editing/spelling/spelling-expected.txt: Added.
- 4:28 AM Changeset in webkit [133735] by
-
- 2 edits in trunk/Tools
[EFL] Switch the efl-linux-slave-2 to Wk2 Release
https://bugs.webkit.org/show_bug.cgi?id=101345
Reviewed by Gyuyoung Kim.
Switching efl-linux-slave-2 to Wk2 Release.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:14 AM Changeset in webkit [133734] by
-
- 2 edits in trunk/Source/WebCore
[V8] Cleanup V8DOMWrapper::getCachedWrapper
https://bugs.webkit.org/show_bug.cgi?id=100853
Patch by Dan Carney <dcarney@google.com> on 2012-11-07
Reviewed by Adam Barth.
Slight cleanup. Removed redundant branch.
No new tests. No change in functionality.
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- 2:22 AM Changeset in webkit [133733] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed trivial build fix adapting to QtMultimedia API changes
The QtMultimedia namespace is now called QMultimedia and
QtMultimedia::MetaData is now QMediaMetaData.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::supportsType):
(WebCore::MediaPlayerPrivateQt::totalBytes):
- 1:45 AM Changeset in webkit [133732] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Marking new test media/progress-events-generated-correctly.html as failing on EFL.
- platform/efl/TestExpectations:
- 1:43 AM Changeset in webkit [133731] by
-
- 22 edits in trunk
Add replaceWithLiteral() method to WTF::String
https://bugs.webkit.org/show_bug.cgi?id=101257
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Benjamin Poulain.
Source/WebCore:
Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.
No new tests, no behavior change.
- dom/Node.cpp:
(WebCore::Node::showNode):
- editing/EditingStyle.cpp:
(WebCore::StyleChange::extractTextStyles):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setSearch):
- loader/FormSubmission.cpp:
(WebCore::appendMailtoPostFormDataToURL):
- platform/network/soup/ProxyResolverSoup.cpp:
(soupProxyResolverWkSetProperty):
- plugins/PluginView.cpp:
(WebCore::makeURL):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::showBox):
- xml/XSLTProcessor.cpp:
(WebCore::transformTextStringToXHTMLDocumentString):
Source/WebKit/blackberry:
Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
Source/WebKit2:
Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::makeURLString):
Source/WTF:
Add replaceWithLiteral() method to WTF::String that takes
replacement string as a literal to avoid uselessly constructing
a String object.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::replace):
(WTF):
- wtf/text/StringImpl.h:
(WTF::StringImpl::replace):
(StringImpl):
- wtf/text/WTFString.h:
(String):
(WTF::String::replaceWithLiteral):
Tools:
Add API tests for String::replaceWithLiteral() and corresponding
StringImpl methods.
- TestWebKitAPI/CMakeLists.txt: Add WTFString API tests to CMake.
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI):
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
- 1:32 AM Changeset in webkit [133730] by
-
- 4 edits in trunk
[Qt] Fix build of modules depending on QtWebKit when using prefix
https://bugs.webkit.org/show_bug.cgi?id=101437
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-11-07
Reviewed by Simon Hausmann.
.:
.qmake.conf loads qt_build_config.prf, which nowadays is responsible for
adding the path to .qmake.super (before it was done by default_pre.prf,
so having setting the path in our default_pre wrapper was sufficient).
- .qmake.conf:
Tools:
Remove setting of MODULE_QMAKE_OUTDIR from here, it's been moved to .qmake.conf.
- qmake/mkspecs/features/default_pre.prf:
- 12:54 AM Changeset in webkit [133729] by
-
- 7 edits in trunk/Source
Remove support for "desktop-width" in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=101217
Reviewed by Gyuyoung Kim.
Source/WebCore:
This has been removed from the CSS Device Adaptation spec, and
should be safe to remove as it is not documented anywhere (neither
in blog posts).
The viewport meta should only support the legacy features.
- dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
- dom/ViewportArguments.h:
Source/WebKit/blackberry:
Sync WebViewportArguments enum with the one in
WebCore::ViewportArguments
- Api/WebViewportArguments.h:
Source/WebKit/chromium:
Remove some code trying to use the set desktop width (say 980) for
sites not using a viewport meta element.
Removing this code should have no effect as it ends up being set
to desktop width in that case anyway, by the ViewportArguments
algorithm.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- 12:40 AM Changeset in webkit [133728] by
-
- 4 edits in trunk
[EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
https://bugs.webkit.org/show_bug.cgi?id=101343
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Add Cairo to the list of backends that support shouldRespectImageOrientation.
No new tests, fixes exif-orientation-image-document.html.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
LayoutTests:
Unskipping exif-orientation-image-document.html now that respecting
orientation is default enabled for image documents.
- platform/efl-wk2/TestExpectations:
- 12:32 AM Changeset in webkit [133727] by
-
- 4 edits2 adds in trunk
Console not displaying all properties of an Object once native Constructor overwritten
https://bugs.webkit.org/show_bug.cgi?id=101320
Reviewed by Pavel Feldman.
Source/WebCore:
Use Object instance from {}.constructor when formatting inspector messages in the
injected script. Otherwise inspected page may overwrite Object value and break inspector.
Test: inspector/console/console-Object-overwritten.html
- inspector/InjectedScriptSource.js:
LayoutTests:
Check that Web Inspector's console works fine if Object is overwritten in the inspected
page.
- inspector/console/console-Object-overwritten-expected.txt: Added.
- inspector/console/console-Object-overwritten.html: Added.
Nov 6, 2012:
- 11:13 PM Changeset in webkit [133726] by
-
- 3 edits in trunk/Source/WTF
StringBuilder::append(UChar) with an 8 bit quantity shouldn't change the contents to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=101421
Reviewed by Anders Carlsson.
If the string builder contains only 8 bit data, check if the character being appended contains
8 bit data. If so, append it to the 8 bit buffer instead of converting the buffer to 16 bits.
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::append):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
- 10:46 PM Changeset in webkit [133725] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] media/media-continues-playing-after-replace-source.html fails
https://bugs.webkit.org/show_bug.cgi?id=101429
Unreviewed, EFL gardening.
media-continues-playing-after-replace-source.html test case crashes in WK2 only.
Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-06
- platform/efl-wk2/TestExpectations:
- 10:46 PM Changeset in webkit [133724] by
-
- 3 edits in trunk/Source/WebKit2
Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=101427
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-11-06
Reviewed by Anders Carlsson.
Moving these methods under the ACCELERATED_COMPOSITING flag.
This fixes broken wincairo due to use of override specifier.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- 10:31 PM Changeset in webkit [133723] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] API test crash with accelerated compositing on.
https://bugs.webkit.org/show_bug.cgi?id=101384
Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.
If accelerated compositing is enabled API tests should create GL evas engine
instead of default one.
Also, in API tests first window resize and display often comes earlier
than enterAcceleratedCompositingMode call, so let's create GL surface in
_ewk_view_smart_calculate on first window resize.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
- 10:29 PM Changeset in webkit [133722] by
-
- 5 edits in trunk
Implement month picking to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101333
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Added test for month picker.
Source/WebCore:
This adds month picker mode to CalendarPicker.
No new tests. Tests will be added later when this feature is enabled in DRT.
- Resources/pagepopups/calendarPicker.css:
(.month-mode .day): Remove rounded corners when in month mode.
- Resources/pagepopups/calendarPicker.js:
(Month.createFromToday): Creates month containing today.
(CalendarPicker): Set this.selectionConstructor to Day or Month depending on the mode. Create DayTables or MonthPickerDaysTable depending on the mode.
(CalendarPicker.prototype.handleToday):
(CalendarPicker.prototype._layoutButtons):
(DaysTable.prototype._renderMonth): Set element.dataset.monthValue for all date nodes.
(DaysTable.prototype._markRangeAsSelected): Marks all day nodes in range as selected.
(DaysTable.prototype.selectRange): Selects a day.
(DaysTable.prototype.selectRangeAndShowEntireRange): Same as selectRange.
(DaysTable.prototype._selectRangeContainingNode):
(DaysTable.prototype._rangeForNode): Returns Day for node.
(DaysTable.prototype.startDate): Start datetime of visible date range. This value is inclusive.
(DaysTable.prototype.endDate): End datetime of visible date range. This value is exclusive.
(DaysTable.prototype._handleKey):
(MonthPickerDaysTable):
(MonthPickerDaysTable.prototype._markRangeAsSelected): Marks all day nodes in range as selected.
(MonthPickerDaysTable.prototype.selectRange): Selects month. If month is not visible, navigates to that month.
(MonthPickerDaysTable.prototype.selectRangeAndShowEntireRange): Selects month. Navigates to the month.
(MonthPickerDaysTable.prototype._rangeForNode): Returns Month for node.
(MonthPickerDaysTable.prototype._handleKey): Arrow keys simply move the selection forwards or backwards.
- 9:28 PM Changeset in webkit [133721] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed attempt to fix the chromium-mac build.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 9:18 PM FeatureFlags edited by
- (diff)
- 9:06 PM AddingFeatures edited by
- (diff)
- 9:05 PM Changeset in webkit [133720] by
-
- 13 edits1 add in trunk
Enable REQUEST_AUTOCOMPLETE for chromium port
https://bugs.webkit.org/show_bug.cgi?id=101376
Patch by Dan Beam <dbeam@chromium.org> on 2012-11-06
Reviewed by Adam Barth.
Source/WebCore:
Added a runtime enabled feature to control whether HTMLFormElement#requestAutocomplete is visible from JavaScript.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
Added a binding from RuntimeEnabledFeatures that triggers [V8EnabledAtRuntime=requestAutocomplete].
(WebCore::RuntimeEnabledFeatures::requestAutocompleteEnabled):
Added a getter to WebCore to ask whether the runtime flag requestAutocomplete is on.
(WebCore::RuntimeEnabledFeatures::setRequestAutocompleteEnabled):
Added a setter to WebCore to affect the runtime flag requestAutocomplete.
- html/HTMLFormElement.idl:
Wrapped commonly grouped features in an #if defined(ENABLED_REQUEST_AUTOCOMPLETE) block and added [V8EnableAtRuntime]
so these features can be changed with a command line switch in the chromium port.
Source/WebKit/chromium:
This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.
- features.gypi:
Turned on the *compile* time flag for REQUEST_AUTOCOMPLETE in chromium's webkit port but also added a *run* time flag
that functionally enables the behavior. This means the chromium port will compile in support but will require a run
time flag to enable.
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
Added a method to the public chromium run time features interface to allow chrome to enable/disable this feature.
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableRequestAutocomplete):
(WebKit):
A setter than can be called from chrome code to change the enable/disable requestAutocomplete and associated events at
runtime.
(WebKit::WebRuntimeFeatures::isRequestAutocompleteEnabled):
A getter that returns whether the requestAutocomplete run time feature is enabled.
Tools:
This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
Enables the requestAutocomplete runtime feature flag during tests.
LayoutTests:
This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.
- fast/forms/form-request-autocomplete-expected.txt:
Updated to match form-request-autocomplete.html changes.
- fast/forms/form-request-autocomplete.html:
Remove bug number as per Adam Barth <abarth@webkit.org>'s advice.
- platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Added.
Adding expected successful layout test for form-request-autocomplete.html tests to chromium specific directory
(as chromium is currently the only place the feature is enabled).
- 8:59 PM Changeset in webkit [133719] by
-
- 20 edits in trunk/Source/WebCore
[V8] Unify setJSWrapperForDOMObject and setJSWrapperForDOMNode
https://bugs.webkit.org/show_bug.cgi?id=101422
Reviewed by Kentaro Hara.
This patch is another incremental step towards the patch in Bug 10110.
In this step, we unify setJSWrapperForDOMObject and
setJSWrapperForDOMNode.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::wrap):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::wrap):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::wrap):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::wrap):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::wrap):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::wrap):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::wrap):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(DOMDataStore):
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperPrivate):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- 8:56 PM Changeset in webkit [133718] by
-
- 2 edits in trunk/Tools
[WK2][EFL] Add shortcut for setting a pagination mode on Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=100301
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.
Setting pagination modes is for a paginated view - left to right / right to left / top to bottom / bottom to top.
Assign a shortcut "F7" to set pagination modes for tests.
- MiniBrowser/efl/main.c:
(on_key_down):
- 8:55 PM Changeset in webkit [133717] by
-
- 4 edits2 adds in trunk
Crash due to column span under button element
https://bugs.webkit.org/show_bug.cgi?id=101402
Reviewed by Abhishek Arya.
Source/WebCore:
When there is a column-spanning child of a RenderButton
splitBlocks() must split the RenderButton as well as its
only permitted direct child, the anonymous block referenced
by m_inner. A crash was occurring because splitBlocks()
calls addChildIgnoringAnonymousColumnBlocks() to add the
cloned m_inner to the cloned RenderButton, which meant the
m_inner for the cloned RenderButton was not being set even
though a child was being added. This violates state
assumptions in the RenderButton code.
This patch prevents any descendants of RenderButton from
spanning columns. Also, it adds a precautionary check in
RenderButton::removeChild() to mitigate problems if similar
state problems are found in future.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::removeChild):
LayoutTests:
Test creates crashing condition for bug 101402.
- fast/block/colspan-under-button-crash.html: Added.
- fast/block/colspan-under-button-crash-expected.txt: Added.
- 8:50 PM Changeset in webkit [133716] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] fast/dom/shadow/shadowdom-for-object-only-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=101417
Unreviewed, EFL gardening.
shadowdom-for-object-only-shadow.html test is flaky in WK2 only.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-06
- platform/efl-wk2/TestExpectations:
- 8:40 PM Changeset in webkit [133715] by
-
- 3 edits2 adds in trunk
[Shadow] Pseudo custom-elements should start with 'x-'.
https://bugs.webkit.org/show_bug.cgi?id=100919
Reviewed by Dimitri Glazkov.
Source/WebCore:
Pseuco custom-elements should start with 'x-'. 'Pseudo' starting with '-webkit-' should work
only in UserAgent ShadowDOM. If it's used in Author ShadowDOM, it should not work.
Test: fast/dom/shadow/pseudo-attribute-rendering.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Added ShadowRoot type check.
LayoutTests:
- fast/dom/shadow/pseudo-attribute-rendering-expected.html: Added.
- fast/dom/shadow/pseudo-attribute-rendering.html: Added.
- 8:39 PM Changeset in webkit [133714] by
-
- 2 edits in trunk/Tools
[EFL][EWebLauncher] Use Ctrl +/- to zoom in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=100207
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.
Use "Ctrl -" instead of "F7" to zoom out, and use "Ctrl +" instead of "F8" to zoom in,
and use "Ctrl 0" to set to default zoom level.
They are more common shortcuts on usual browsers.
- EWebLauncher/main.c:
(on_key_down):
- 8:14 PM Changeset in webkit [133713] by
-
- 5 edits in trunk/Source/WebCore
Re-order variables in BidiRun and LayoutState
https://bugs.webkit.org/show_bug.cgi?id=100173
Reviewed by Eric Seidel.
The variable re-ordering and use of bitfields for bools has two benefits:
1) Size reduction. sizeof(BidiRun) goes down from 48 to 40 bytes on 64-bit. This is achieved by removing a bool member variable from BidiRun and packing it together with other bools in the BidiCharacterRun base class.
2) Security improvement. We have a lot of use-after-free in the RenderObject hierarchy, and the RenderArena class protects us from a lot of trouble by ensuring that objects of arbitrary type cannot be overlayed on top of freed RenderObjects. This change additionally makes sure that non-virtual RenderArena allocated objects do not have member variables which fully overlap the freed vtable pointer. This leaves re-used vtable pointers always pointing to either a valid vtable or an invalid address due to the freelist high-bit poisoning.
This change is exclusively about size savings; it is performance neutral as you would expect, including on Parser/html5-full-render.html
- platform/text/BidiResolver.h:
(WebCore::BidiCharacterRun::BidiCharacterRun): impact from re-ordering members.
(BidiCharacterRun): provide an efficiently packed bit of storage for BidiRun subclass to use, and re-order members to place bools adjacent.
- rendering/BidiRun.h:
(WebCore::BidiRun::BidiRun): use base class' efficiently packed bit storage for m_hasHyphen.
(BidiRun): m_hasHyphen is now stored in the base class.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState): impact from re-ordering members.
(LayoutState): re-order members to place bools adjacently.
- 7:33 PM Changeset in webkit [133712] by
-
- 3 edits in trunk/Source/WebCore
[Chromium-win] Refactor date/time format conversion code in LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=101329
Reviewed by Kentaro Hara.
convertWindowsDateFormatToLDML and convertWindowsTimeFormatToLDML did
similar jobs with different code. We can merge them into one function.
As for the date format conversion, we have tokenized a format string and
stored token objects into a vector. We skip token object generation and
generate a LDML-compliant pattern string during parsing.
No new tests. This should make no behavior changes and
WebKit/chromium/tests/LocaleWinTest.cpp has test cases.
- platform/text/win/LocaleWin.cpp:
(WebCore): Remove DateFormatToken, isFooSymbol, ensureShortDateTokens,
convertWindowsDateFormatToLDML, mapCharacterToDateTimeFieldType, and
convertWindowsTimeFormatToLDML.
(WebCore::commitLiteralToken): Store the result to the specified StringBuilder.
(WebCore::convertWindowsDateTimeFormat):
Renamed from parseDateFormat, and supports time format symbols.
(WebCore::LocaleWin::dateFormat): Use convertWindowsDateTimeFormat.
(WebCore::LocaleWin::monthFormat): Ditto.
(WebCore::LocaleWin::timeFormat): Ditto.
(WebCore::LocaleWin::shortTimeFormat): Ditto.
- platform/text/win/LocaleWin.h:
(LocaleWin): Remove ensureShortDateTokens and m_shortDateTokens.
- 7:31 PM Changeset in webkit [133711] by
-
- 4 edits in trunk/Source/WebCore
Make Document::renderer faster by using the cached ptr for RenderView
https://bugs.webkit.org/show_bug.cgi?id=101409
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-06
Reviewed by Eric Seidel.
In Bug 101277 I made Document::renderView() just return m_renderView instead
of casting the result of renderer(). While this made renderView() cheaper it
makes more sense to just make renderer() faster for Document pointers and
go back to the out of line method in RenderView.h because lots of places in
the code do document()->renderer().
No new tests, this is just a refactor.
- dom/Document.h:
(WebCore::Document::renderer):
- rendering/RenderView.h:
(WebCore::Document::renderView):
- 6:47 PM Changeset in webkit [133710] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r129270. <rdar://problem/12536542>
- 6:36 PM Changeset in webkit [133709] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r128964. <rdar://problem/12516360>
- 6:31 PM Changeset in webkit [133708] by
-
- 2 edits in trunk/Source/WebCore
[V8] neuterBinding should remember the type of its argument
https://bugs.webkit.org/show_bug.cgi?id=101413
Reviewed by Kentaro Hara.
This is a small part of the patch in
https://bugs.webkit.org/show_bug.cgi?id=101110 that we can land
separately to try to tease out what is causing the memory regression.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore):
(WebCore::neuterBinding):
- 6:30 PM Changeset in webkit [133707] by
-
- 2 edits in trunk/WebKitLibraries
Build fix.
- WebKitSystemInterface.h:
- 6:26 PM Changeset in webkit [133706] by
-
- 3 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r128935. <rdar://problem/12486170>
- 6:06 PM Changeset in webkit [133705] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r128792. <rdar://problem/12516344>
- 6:04 PM Changeset in webkit [133704] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r128774. <rdar://problem/12514580>
- 6:02 PM Changeset in webkit [133703] by
-
- 5 edits2 copies in branches/safari-536.28-branch
Merged r128654. <rdar://problem/12536534>
- 5:58 PM Changeset in webkit [133702] by
-
- 8 edits in trunk
Update Java related WKSI function names
https://bugs.webkit.org/show_bug.cgi?id=101414
Reviewed by Sam Weinig.
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::unavailablePluginButtonClicked):
- WebCoreSupport/WebFrameLoaderClient.mm:
(isPlugInInactive):
Source/WebKit2:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::policyForPlugin):
(WebKit::PluginInfoStore::reactivateInactivePlugin):
WebKitLibraries:
Roll WebKitSystemInterface DEPS.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 5:56 PM Changeset in webkit [133701] by
-
- 4 edits1 move12 adds in trunk/LayoutTests
Unreviewed gardening. Rebaseline the tests added in http://trac.webkit.org/changeset/133686 for different platforms.
- platform/chromium-linux/fast/backgrounds/transformed-body-background-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/transformed-body-html-background-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/transformed-html-body-background-expected.png: Added.
- platform/chromium-mac-lion/compositing/repaint/composited-document-element-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/repaint/composited-document-element-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/repaint/composited-document-element-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/repaint/composited-document-element-expected.png: Added.
- platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:
- platform/chromium-mac/fast/backgrounds/transformed-body-background-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/transformed-body-html-background-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/transformed-html-body-background-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/composited-document-element-expected.png: Added.
- platform/efl-wk1/compositing/repaint/composited-document-element-expected.png: Renamed from LayoutTests/platform/efl/compositing/repaint/composited-document-element-expected.png.
- 5:35 PM Changeset in webkit [133700] by
-
- 3 edits4 copies in branches/safari-536.28-branch
Merged r127082. <rdar://problem/12536425>
- 5:17 PM Changeset in webkit [133699] by
-
- 27 edits5 copies1 add in trunk/Source/WebKit2
Add application occlusion criterion to enable/disable process suppression on Mac
https://bugs.webkit.org/show_bug.cgi?id=100997
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-11-06
Reviewed by Alexey Proskuryakov.
Provide support for enabling and disabling process suppression when application is completely occluded on Mac.
- NetworkProcess/NetworkProcess.messages.in: Added message to update application occlusion status.
- NetworkProcess/mac/NetworkProcessMainMac.mm:
(WebKit::NetworkProcessMain): Removed call to take process suppression assertion since ChildProcess
takes one on constrution.
- PluginProcess/PluginProcess.messages.in: Added message to update application occlusion status.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain): Removed call to take process suppression assertion since ChildProcess
takes one on construction.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess): Take process suppression assertion on construction.
- Shared/ChildProcess.h:
(WebKit::ChildProcess::applicationIsOccluded):
- Shared/mac/ChildProcessMac.mm: Added.
(WebKit::ChildProcess::setApplicationIsOccluded): Release process suppression assertion if application
becomes occluded or take a new assertion if application becomes visible.
(WebKit::ChildProcess::disableProcessSuppression):
(WebKit::ChildProcess::enableProcessSuppression):
Helper methods to take and release process suppression assertion.
- SharedWorkerProcess/SharedWorkerProcess.messages.in: Added message to update application occlusion status.
- SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
(WebKit::SharedWorkerProcessMain): Removed call to take process suppression assertion since ChildProcess
takes one on construction.
- UIProcess/Network/NetworkProcessManager.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching): Update application occlusion status post launch.
- UIProcess/Network/NetworkProcessProxy.h:
(WebKit::NetworkProcessProxy::isValid):
- UIProcess/Network/mac/NetworkProcessManagerMac.mm: Added.
(WebKit::NetworkProcessManager::setApplicationIsOccluded):
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::NetworkProcessProxy::setApplicationIsOccluded):
- UIProcess/Plugins/PluginProcessManager.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching): Update application occlusion status post launch.
- UIProcess/Plugins/PluginProcessProxy.h:
(WebKit::PluginProcessProxy::isValid):
- UIProcess/Plugins/mac/PluginProcessManagerMac.mm: Added.
(WebKit::PluginProcessManager::setApplicationIsOccluded):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setApplicationIsOccluded):
- UIProcess/SharedWorkers/SharedWorkerProcessManager.h:
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didFinishLaunching): Update application occlusion status post launch.
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:
(WebKit::SharedWorkerProcessProxy::isValid):
- UIProcess/SharedWorkers/mac/SharedWorkerProcessManagerMac.mm: Added.
(WebKit::SharedWorkerProcessManager::setApplicationIsOccluded):
- UIProcess/SharedWorkers/mac/SharedWorkerProcessProxyMac.mm: Added.
(WebKit::SharedWorkerProcessProxy::setApplicationIsOccluded):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::create): Added call to initialize process suppression support.
- UIProcess/WebContext.h:
(WebKit::WebContext::applicationIsOccluded):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching): Update application occlusion status post launch.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::applicationBecameVisible):
(WebKit::WebContext::applicationBecameOccluded):
Notification handlers for informing non UI WebKit2 processes of changes to application occlusion state.
(WebKit::WebContext::registerOcclusionNotificationHandlers):
(WebKit::WebContext::initializeProcessSuppressionSupport):
Helper method to register occlusion notification handlers if process suppression support is enabled.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.messages.in: Added message to update application occlusion status.
- WebProcess/mac/WebProcessInitialization.mm:
(WebKit::InitializeWebProcess): Removed call to take process supression assertion since ChildProcess
takes one on construction.
- 5:14 PM Changeset in webkit [133698] by
-
- 2 edits in trunk/LayoutTests
fast/forms/select-set-length-with-mutation-remove is slow on chromium debug builds
https://bugs.webkit.org/show_bug.cgi?id=60092
[Chromium] Unreviewed gardening - so slow it's timing out at 60s rather often.
- platform/chromium/TestExpectations:
- 5:02 PM Changeset in webkit [133697] by
-
- 5 edits in trunk/LayoutTests
[CSS Exclusions] Changeset r133384 defeated the rectilinear polygon tests
https://bugs.webkit.org/show_bug.cgi?id=101405
Patch by Hans Muller <hmuller@adobe.com> on 2012-11-06
Reviewed by Dirk Schulze.
When the exclusions/shape-inside subpixel layout JS code was refactored,
(see https://bugs.webkit.org/show_bug.cgi?id=100704) these two tests were not
properly updated. They now include subpixel-utils.js, which simple-polygon.js depends on.
- fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-001-expected.html:
- fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-001.html:
- fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-002-expected.html:
- fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-002.html:
- 4:48 PM Changeset in webkit [133696] by
-
- 2 edits in trunk/LayoutTests
Don't write pixels for crash-hw-sw-switch test; if it doesn't crash, it
passes. Unreviewed.
- css3/filters/crash-hw-sw-switch.html:
- 4:46 PM Changeset in webkit [133695] by
-
- 4 edits3 deletes in trunk/LayoutTests
(r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion
https://bugs.webkit.org/show_bug.cgi?id=93636
Reviewed by Simon Fraser.
Remove this test: fast/images/jpeg-partial-load.html is now used to test
partial jpeg image loads.
- http/tests/images/jpg-img-partial-load-expected.png: Removed.
- http/tests/images/jpg-img-partial-load-expected.txt: Removed.
- http/tests/images/jpg-img-partial-load.html: Removed.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 4:41 PM Changeset in webkit [133694] by
-
- 17 edits in trunk
Clean up which storage cookie jar functions use
https://bugs.webkit.org/show_bug.cgi?id=101395
Reviewed by Brady Eidson.
Source/WebCore:
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Updated for two new WKSI functions.
- platform/CookieJar.h: Added explanatory comments.
- platform/mac/CookieJar.mm:
(WebCore::cookies): Removed fallback on NSHTTPCookieStorage, the WKSI function
already implements it.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::setCookies): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): This function used to look at NSHTTPCookieStorage
exclusively. While it makes sense to bypass private storage session, default storage
session (currently only used for testing on Mac) is never OK to bypass. Changed to
use a WKSI function that supports both.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated to match Foundation, so now these functions bypass private session.
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::currentCFHTTPCookieStorage): Updated a comment.
(WebCore::defaultCFHTTPCookieStorage): Added a function that returns cookie storage
for non-private session (or null if that would be an NSHTTPCookieStorage).
(WebCore::startObservingCookieChanges): We do not want to observe private cookies
here, and we certainly don't want a mismatch between start/stop due to private
browsing mode changes.
(WebCore::stopObservingCookieChanges): Ditto.
- platform/network/cf/CookieStorageCFNet.h: Added defaultCFHTTPCookieStorage().
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated for
two new functions.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
Updated for two new functions.
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
Added WKHTTPCookies() and WKDeleteAllHTTPCookies(). Updated ifdefs for currently
supported OS versions.
- 4:37 PM Changeset in webkit [133693] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r126657. <rdar://problem/12536471>
- 4:32 PM Changeset in webkit [133692] by
-
- 7 edits4 adds in trunk/Source/WebKit2
[EFL][WK2] Add ewk_database_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=101193
Patch by Jihye Kang <jye.kang@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.
Add ewk_database_manager to manage web database and
ewk_database_manaager_origins_get to get origins list of web storage.
Add unit tests for ewk_database_manager APIs.
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):
(Ewk_Context::databaseManager):
(ewk_context_database_manager_get):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
(Ewk_Context):
- UIProcess/API/efl/ewk_database_manager.cpp: Added.
(Ewk_Database_Manager::Ewk_Database_Manager):
(Ewk_Database_Manager::getDatabaseOrigins):
(Ewk_Database_Manager::createOriginList):
(Ewk_Database_Origins_Async_Get_Context):
(Ewk_Database_Origins_Async_Get_Context::Ewk_Database_Origins_Async_Get_Context):
(getDatabaseOriginsCallback):
(ewk_database_manager_origins_get):
- UIProcess/API/efl/ewk_database_manager.h: Added.
- UIProcess/API/efl/ewk_database_manager_private.h: Added.
(Ewk_Database_Manager):
(Ewk_Database_Manager::create):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_database_manager.cpp: Added.
(OriginData):
(OriginData::OriginData):
(getDatabaseOriginsCallback):
(timerCallback):
(TEST_F):
- 4:29 PM Changeset in webkit [133691] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. A couple of expectation updates c/o Dave Barton
and marking calendar-picker-key-operations.html flaky per webkit.org/b/101408
- platform/chromium/TestExpectations:
- 4:16 PM Changeset in webkit [133690] by
-
- 1 edit6 deletes in trunk/LayoutTests
Removed useless image baselines for filter-empty-element-crash.
Unreviewed.
- platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Removed.
- platform/chromium-mac/css3/filters/filter-empty-element-crash-expected.png: Removed.
- platform/chromium-win/css3/filters/filter-empty-element-crash-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Removed.
- platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Removed.
- 4:14 PM Changeset in webkit [133689] by
-
- 2 edits in trunk/Source/WebCore
Build fix. r133601 broke the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=101404
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.
Only static const integral data members can be initialized within a class in the
Windows, so we initialize static const double date members out of the class.
- platform/graphics/texmap/TextureMapper.cpp:
(BitmapTexturePool):
(WebCore):
- 4:13 PM Changeset in webkit [133688] by
-
- 45 edits5 adds in trunk/Source/JavaScriptCore
Reduce parser overhead in JSC
https://bugs.webkit.org/show_bug.cgi?id=101127
Reviewed by Filip Pizlo.
An exciting journey into the world of architecture in which our hero
adds yet another layer to JSC codegeneration.
This patch adds a marginally more compact form of bytecode that is
free from any data specific to a given execution context, and that
does store any data structures necessary for execution. To actually
execute this UnlinkedBytecode we still need to instantiate a real
CodeBlock, but this is a much faster linear time operation than any
of the earlier parsing or code generation passes.
As the unlinked code is context free we can then simply use a cache
from source to unlinked code mapping to completely avoid all of the
old parser overhead. The cache is currently very simple and memory
heavy, using the complete source text as a key (rather than SourceCode
or equivalent), and a random eviction policy.
This seems to produce a substantial win when loading identical content
in different contexts.
- API/tests/testapi.c:
(main):
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
Moved a number of fields, and a bunch of logic to UnlinkedCodeBlock.h/cpp
- bytecode/Opcode.h:
Added a global const init no op instruction needed to get correct
behaviour without any associated semantics.
- bytecode/UnlinkedCodeBlock.cpp: Added.
- bytecode/UnlinkedCodeBlock.h: Added.
A fairly shallow, GC allocated version of the old CodeBlock
classes with a 32bit instruction size, and just metadata
size tracking.
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
Replace direct access to m_symbolTable with access through
symbolTable(). ProgramCode no longer has a symbol table at
all so some previously unconditional (and pointless) uses
of symbolTable get null checks.
A few other changes to deal with type changes due to us generating
unlinked code (eg. pointer free, so profile indices rather than
pointers).
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCapabilities.h:
Support global_init_nop
- interpreter/Interpreter.cpp:
Now get the ProgramExecutable to initialise new global properties
before starting execution.
- jit/JIT.cpp:
- jit/JITDriver.h:
- jit/JITStubs.cpp:
- llint/LLIntData.cpp:
- llint/LLIntSlowPaths.cpp:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
Adding init_global_const_nop everywhere else
- parser/Parser.h:
- parser/ParserModes.h: Added.
- parser/ParserTokens.h:
Parser no longer needs a global object or callframe to function
- runtime/CodeCache.cpp: Added.
- runtime/CodeCache.h: Added.
A simple, random eviction, Source->UnlinkedCode cache
- runtime/Executable.cpp:
- runtime/Executable.h:
Executables now reference their unlinked counterparts, and
request code specifically for the target global object.
- runtime/JSGlobalData.cpp:
- runtime/JSGlobalData.h:
GlobalData now owns a CodeCache and a set of new structures
for the unlinked code types.
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
Utility functions used by executables to perform compilation
- runtime/JSType.h: Add new JSTypes for unlinked code
- 4:11 PM Changeset in webkit [133687] by
-
- 6 edits in trunk/LayoutTests
[Chromium] New baselines for some CSS3 filter tests. Unreviewed.
- platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-expected.txt:
- platform/chromium-win/css3/filters/effect-reference-expected.png:
- platform/chromium-win/css3/filters/effect-reference-expected.txt:
- 4:03 PM Changeset in webkit [133686] by
-
- 4 edits12 adds in trunk
-webkit-background-clip:text produces artifacts when applied to the body and the browser is resized
https://bugs.webkit.org/show_bug.cgi?id=89287
Reviewed by Beth Dakin.
Source/WebCore:
If the body had -webkit-background-clip: text, we'd fail to paint
anything behind it, so would see garbage pixels.
Fix by having RenderView::paintBoxDecorations() check for a background-clip of "text"
on the renderer that paints the root background.
Added some new pixel tests for combinations of html and body transform
and backgrounds; earlier versions of the patch broke some of these tests.
Tests: fast/backgrounds/background-clip-text-on-body.html
fast/backgrounds/transformed-body-background.html
fast/backgrounds/transformed-body-html-background.html
fast/backgrounds/transformed-html-body-background.html
- rendering/RenderView.cpp:
(WebCore::rendererObscuresBackground): Broke up the single condition
into early 'false' returns when possible. We need to also check whether
the renderer that actually paints the background (which might be the body)
will fill it; background-clip: text does not.
(WebCore::RenderView::paintBoxDecorations): Rather than checking firstChild(),
actually check the root renderer, so that we can reliably get to the renderer
that mains the root background.
LayoutTests:
Test with -webkit-background-clip: text on the body, which scrolls.
Some additional tests that exercise different combinations of html and
body transform and background.
- compositing/repaint/composited-document-element.html:
- fast/backgrounds/background-clip-text-on-body-expected.png: Added.
- fast/backgrounds/background-clip-text-on-body-expected.txt: Added.
- fast/backgrounds/background-clip-text-on-body.html: Added.
- fast/backgrounds/transformed-body-background-expected.png: Added.
- fast/backgrounds/transformed-body-background-expected.txt: Added.
- fast/backgrounds/transformed-body-background.html: Added.
- fast/backgrounds/transformed-body-html-background-expected.png: Added.
- fast/backgrounds/transformed-body-html-background-expected.txt: Added.
- fast/backgrounds/transformed-body-html-background.html: Added.
- fast/backgrounds/transformed-html-body-background-expected.png: Added.
- fast/backgrounds/transformed-html-body-background-expected.txt: Added.
- fast/backgrounds/transformed-html-body-background.html: Added.
- 3:52 PM Changeset in webkit [133685] by
-
- 3 edits in trunk/Tools
Don't warn about RefPtr* parameters
https://bugs.webkit.org/show_bug.cgi?id=101403
Reviewed by Gavin Barraclough.
RefPtr<>* is a valid parameter type.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition_and_pass_ptr):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(PassPtrTest.test_ref_ptr_parameter_value):
- 3:51 PM Changeset in webkit [133684] by
-
- 3 edits in trunk/Source/WebCore
Implement save and restore for a bunch of InternalSettings state
https://bugs.webkit.org/show_bug.cgi?id=101394
Reviewed by Dirk Pranke.
In http://trac.webkit.org/changeset/133399, I resolved a bunch of
flaky tests by saving and restoring the InternalSettings state
EnableCompositingForFixedPosition. On a hunch, I git grepped for all
internal settings state which is being set by layout tests but not
saved and restored. It turns out there about 15 calls.
This patch takes care of five of them, mostly compositing-related.
The others I was either not sure about, or were already at least
being reset to known values by the testing harness.
Hopefully this will alleviate some further test flakiness.
- testing/InternalSettings.cpp:
- testing/InternalSettings.h:
- 3:50 PM Changeset in webkit [133683] by
-
- 2 edits in trunk/Source/WebCore
Fix build warning in RenderLayer.cpp caused by r133628
https://bugs.webkit.org/show_bug.cgi?id=101401
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-06
Reviewed by Simon Fraser.
The static function WebCore::frameViewFromLayer is only used when USE(ACCELERATED_COMPOSITING),
so define it only that case for removing -Wunused-function warning
- rendering/RenderLayer.cpp:
(WebCore):
- 3:47 PM Changeset in webkit [133682] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Store ExclusionPolygonEdge vertices in clockwise order
https://bugs.webkit.org/show_bug.cgi?id=100763
Patch by Hans Muller <hmuller@adobe.com> on 2012-11-06
Reviewed by Darin Adler.
Source/WebCore:
The ExclusionPolygon's internal logic, notably getVertexIntersectionVertices(),
assumes that ExclusionPolygonEdge vertices are stored in clockwise order.
If this is not true, then we construct the polygon's edges in reverse.
To determine if the vertices are in clockwise order, we compare the slope
of the line between the top,left vertex and its previous vertex, with the
the slope of the line of vertices before and after the top,left vertex.
If the slope of the latter is greater, then top,left vertex is located
to its left, and the vertices are clockwise.
Test: fast/exclusions/shape-inside/shape-inside-counterclockwise-polygon.html
- rendering/ExclusionPolygon.cpp:
(WebCore::determinant): Used to decide if the min vertex is on the left side of the line that passes through its adjacent vertices.
(WebCore::ExclusionPolygon::ExclusionPolygon): If the polygon's vertices are specified in counterclockwise order, construct the edges in reverse.
(WebCore::appendIntervalX): Made this an inline since it was only defined as a function for the sake of clarity.
LayoutTests:
Verify that a shape-inside polygon whose vertices are specified in counterclockwise
order is handled correctly.
- fast/exclusions/shape-inside/shape-inside-counterclockwise-polygon-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-counterclockwise-polygon.html: Added.
- 3:44 PM Changeset in webkit [133681] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, remove a couple of passing tests from chromium expectations.
- platform/chromium-mac-mountainlion/TestExpectations:
- platform/chromium/TestExpectations:
- 3:38 PM Changeset in webkit [133680] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening after r133676.
- platform/efl-wk2/TestExpectations: Unskip a few passing tests.
- 3:30 PM Changeset in webkit [133679] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash in InRegionScrollerPrivate.
https://bugs.webkit.org/show_bug.cgi?id=101399
Patch by Genevieve Mak <gmak@rim.com> on 2012-11-06
Reviewed by Rob Buis.
Add a pointer to the enclosing document as the pointer to layer
or node along the way may become invalid.
Use document pointer in clearDocumentData.
PR #238469
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
(BlackBerry::WebKit::InRegionScrollableArea::document):
(WebKit):
- WebKitSupport/InRegionScrollableArea.h:
(WebCore):
(InRegionScrollableArea):
- 3:25 PM Changeset in webkit [133678] by
-
- 4 edits in trunk
[EFL] Simplify the build system
https://bugs.webkit.org/show_bug.cgi?id=101392
Patch by Laszlo Gombos <Laszlo Gombos> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.
.:
Remove unused cmake variables. In addition there is no longer a need to define
WTF_USE_TEXTURE_MAPPER_GL in the build system as that is now handled in Platform.h
(see r133623).
- Source/cmake/OptionsEfl.cmake:
Source/WebKit:
Use WTF_USE_3D_GRAPHICS to guard the inclusion of surfaces and textmap
directories under WebCore/graphics to be consistent with
WebCore/PlatformEfl.cmake.
- PlatformEfl.cmake:
- 3:06 PM Changeset in webkit [133677] by
-
- 2 edits in trunk/LayoutTests
http/tests/inspector-enabled/dynamic-scripts.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=100926
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 3:04 PM Changeset in webkit [133676] by
-
- 6 edits in trunk/Tools
[WTR] Reset EventSender before running each test.
https://bugs.webkit.org/show_bug.cgi?id=101353
Reviewed by Simon Fraser.
Contrary to what was done to at least some ports in DumpRenderTree,
EventSender did not currently reset its values in WTR. This caused
flakiness if a test such as editing/selection/fake-doubleclick.html was
run twice in a row, since the click count was not reset across each
run.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController): Do not create m_eventSenderProxy
in the constructor anymore, it is created in
resetStateToConsistentValues now.
(WTR::TestController::resetStateToConsistentValues): Recreate
m_eventSenderProxy every time this method is run.
- WebKitTestRunner/TestController.h: Make m_eventSenderProxy an OwnPtr
and guard it with a platform #ifdef.
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::~EventSenderProxy): Add an empty
implementation.
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::~EventSenderProxy): Ditto.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::~EventSenderProxy): Ditto.
- 2:58 PM Changeset in webkit [133675] by
-
- 2 edits in trunk/LayoutTests
[Chromium] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html flaky on linux debug
https://bugs.webkit.org/show_bug.cgi?id=101377
Unreviewed gardening. Add ImageOnlyFailure expectation, for extra fun.
- platform/chromium/TestExpectations:
- 2:50 PM Changeset in webkit [133674] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-06
Reviewed by Rob Buis.
RIM PR 238123
Internal Reviewed by Chris Hutten-Czapski
BB10 selection theme use slice image function to draw selection button,
any border-radius setting other than 0 will make the button corner
clipped. Always set button border-radius: 0 for BB10 theme.
- css/themeBlackBerry.css:
(select[size][multiple]):
(select[size="1"]):
- 2:42 PM EFLWebKit edited by
- add an example to pass arguments to make (diff)
- 2:21 PM Changeset in webkit [133673] by
-
- 21 edits in trunk
[EFL][WK2] Refactor Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job to be Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101383
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.
Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job are Ewk_Objects now.
Source/WebKit2:
- UIProcess/API/efl/EwkViewCallbacks.h:
- UIProcess/API/efl/EwkViewImpl.h:
- UIProcess/API/efl/ewk_auth_request.cpp:
(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::~EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_suggested_username_get):
(ewk_auth_request_cancel):
(ewk_auth_request_authenticate):
(ewk_auth_request_retrying_get):
(ewk_auth_request_realm_get):
(ewk_auth_request_host_get):
- UIProcess/API/efl/ewk_auth_request.h:
- UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest):
(EwkAuthRequest::create):
- UIProcess/API/efl/ewk_back_forward_list.h:
- UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
- UIProcess/API/efl/ewk_download_job.cpp:
(EwkDownloadJob::EwkDownloadJob):
(EwkDownloadJob::id):
(EwkDownloadJob::viewImpl):
(ewk_download_job_state_get):
(EwkDownloadJob::state):
(ewk_download_job_request_get):
(EwkDownloadJob::request):
(ewk_download_job_response_get):
(EwkDownloadJob::response):
(ewk_download_job_destination_get):
(EwkDownloadJob::destination):
(ewk_download_job_destination_set):
(EwkDownloadJob::setDestination):
(ewk_download_job_suggested_filename_get):
(EwkDownloadJob::suggestedFileName):
(ewk_download_job_cancel):
(EwkDownloadJob::cancel):
(ewk_download_job_estimated_progress_get):
(EwkDownloadJob::estimatedProgress):
(ewk_download_job_elapsed_time_get):
(EwkDownloadJob::elapsedTime):
(EwkDownloadJob::setResponse):
(EwkDownloadJob::setSuggestedFileName):
(EwkDownloadJob::incrementReceivedData):
(EwkDownloadJob::setState):
- UIProcess/API/efl/ewk_download_job.h:
- UIProcess/API/efl/ewk_download_job_private.h:
(EwkDownloadJob):
(EwkDownloadJob::create):
- UIProcess/API/efl/ewk_url_scheme_request.cpp:
(EwkUrlSchemeRequest::EwkUrlSchemeRequest):
(EwkUrlSchemeRequest::id):
(EwkUrlSchemeRequest::url):
(EwkUrlSchemeRequest::scheme):
(EwkUrlSchemeRequest::path):
(EwkUrlSchemeRequest::finish):
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
(ewk_url_scheme_request_finish):
- UIProcess/API/efl/ewk_url_scheme_request.h:
- UIProcess/API/efl/ewk_url_scheme_request_private.h:
(EwkUrlSchemeRequest):
(EwkUrlSchemeRequest::create):
- UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
(onAuthenticationRequest):
(TEST_F):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didReceiveResponse):
(WebKit::DownloadManagerEfl::didCreateDestination):
(WebKit::DownloadManagerEfl::didReceiveData):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::registerDownload):
(WebKit::DownloadManagerEfl::downloadJob):
- UIProcess/efl/DownloadManagerEfl.h:
(DownloadManagerEfl):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):
- UIProcess/efl/RequestManagerClientEfl.cpp:
(WebKit::RequestManagerClientEfl::didReceiveURIRequest):
Tools:
- MiniBrowser/efl/main.c:
(auth_popup_close):
(on_authentication_request):
- 2:16 PM Changeset in webkit [133672] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSStringCreateWithCFString() Should create an 8 bit String if possible
https://bugs.webkit.org/show_bug.cgi?id=101104
Reviewed by Darin Adler.
Try converting the CFString to an 8 bit string using CFStringGetBytes(...,
kCFStringEncodingISOLatin1, ...) and return the 8 bit string if successful.
If not proceed with 16 bit conversion.
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
- 2:12 PM Changeset in webkit [133671] by
-
- 6 edits in trunk/Source/WebCore
Remove branch from inside RenderObject::view now that renderer() is more expensive
https://bugs.webkit.org/show_bug.cgi?id=101277
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-06
Reviewed by Eric Seidel.
It was observed in Bug 100057 that calling renderer() repeatedly now that it has a branch
can be a performance regression. Now that we no longer keep a separate pointer for rare data
in Document, we can use that space for a pointer to the RenderView making RenderObject::view()
faster and removing the branch.
This is a 1% improvement on Parser/html5-full-render.html
This also cleans up the code because it turns out we don't need to have RenderObject::view() in
RenderView.h because we can just call Document::renderView() and not do toRenderView. This makes
it easier to find this method as it exists in the right header file now.
No new tests, this is just a refactor.
- WebCore.exp.in: Remove export of Document::renderView since it's inline now.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setRenderer):
(WebCore):
- dom/Document.h:
(WebCore::Document::renderView):
(Document):
- rendering/RenderObject.h:
(WebCore::RenderObject::view):
- rendering/RenderView.h:
(WebCore):
- 2:06 PM Changeset in webkit [133670] by
-
- 1 edit2 deletes in trunk/WebKitLibraries
Delete Leopard and Snow Leopard versions of WKSI. These have not been updated in ages.
Rubber-stampted by Mark Rowe.
- libWebKitSystemInterfaceLeopard.a: Removed.
- libWebKitSystemInterfaceSnowLeopard.a: Removed.
- 2:05 PM Changeset in webkit [133669] by
-
- 3 edits in trunk/Source/JavaScriptCore
Reduce direct m_symbolTable usage in CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=101391
Reviewed by Sam Weinig.
Simple refactoring.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::nameForRegister):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::isCaptured):
- 2:01 PM Changeset in webkit [133668] by
-
- 3 edits in trunk/Source/JavaScriptCore
Lexer::scanRegExp, create 8 bit pattern and flag Identifiers from 16 bit source when possible
https://bugs.webkit.org/show_bug.cgi?id=101013
Reviewed by Darin Adler.
Changed scanRegExp so that it will create 8 bit identifiers from 8 bit sources and from 16 bit sources
whan all the characters are 8 bit. Using two templated helpers, the "is all 8 bit" check is only performed
on 16 bit sources. The first helper is orCharacter() that will accumulate the or value of all characters
only for 16 bit sources. Replaced the helper Lexer::makeIdentifierSameType() with Lexer::makeRightSizedIdentifier().
- parser/Lexer.cpp:
(JSC::orCharacter<LChar>): Explicit template that serves as a placeholder.
(JSC::orCharacter<UChar>): Explicit template that actually or accumulates characters.
(JSC::Lexer::scanRegExp):
- parser/Lexer.h:
(Lexer):
(JSC::Lexer::makeRightSizedIdentifier<LChar>): New template that always creates an 8 bit Identifier.
(JSC::Lexer::makeRightSizedIdentifier<UChar>): New template that creates an 8 bit Identifier for 8 bit
data in a 16 bit source.
- 2:00 PM Changeset in webkit [133667] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Pushing window.external.* events to webplatform
https://bugs.webkit.org/show_bug.cgi?id=101386
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-06
Reviewed by Rob Buis.
Adding calls to trigger window.external events so we can handle them on the
browser side.
PR 170059
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::addSearchProvider):
(WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
- 1:38 PM Changeset in webkit [133666] by
-
- 4 edits2 copies in branches/safari-536.28-branch
Merged r126205. <rdar://problem/12536482>
- 1:37 PM Changeset in webkit [133665] by
-
- 33 edits3 copies in trunk/Source
Unreviewed, rolling out r133526.
http://trac.webkit.org/changeset/133526
https://bugs.webkit.org/show_bug.cgi?id=101388
May have caused 15% memory regression in Chromium (Requested
by jsbell|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-06
Source/WebCore:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):
(GetDomMapName):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::wrap):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::wrap):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::wrap):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::wrap):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::wrap):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::wrap):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::wrap):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::current):
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::domNodeMap):
(WebCore::DOMDataStore::domObjectMap):
(DOMDataStore):
- bindings/v8/DOMWrapperMap.h:
(WebCore):
(DOMWrapperMap):
(WebCore::DOMWrapperMap::~DOMWrapperMap):
(WebCore::DOMWrapperHashMap::remove):
- bindings/v8/DOMWrapperWorld.h:
- bindings/v8/IntrusiveDOMWrapperMap.h: Copied from Source/WebKit/chromium/src/WebScriptController.cpp.
(WebCore):
(IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::weakCallback):
- bindings/v8/ScriptProfiler.cpp:
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::neuterBinding):
- bindings/v8/V8DOMMap.cpp: Copied from Source/WebKit/chromium/src/WebScriptController.cpp.
(WebCore):
(WebCore::getDOMNodeMap):
(WebCore::getDOMObjectMap):
- bindings/v8/V8DOMMap.h: Copied from Source/WebKit/chromium/src/WebScriptController.cpp.
(WebCore):
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::getCachedWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerScriptController.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
Source/WebKit/chromium:
- src/WebScriptController.cpp:
- 1:24 PM Changeset in webkit [133664] by
-
- 5 edits in trunk/Source/WebCore
Some cookie code cleanup
https://bugs.webkit.org/show_bug.cgi?id=101375
Reviewed by Dan Bernstein.
- platform/CookieJar.h: Fixed style. Grouped functions by which storage they operate
on in Mac port, but didn't add explanatory comments yet, because this is different
in some ports.
- platform/mac/CookieJar.mm:
(WebCore): Removed special code for isHTTPOnly, it's present in Foundation in all
supported OS X versions.
(WebCore::filterCookies): Use -isHTTPOnly directly.
(WebCore::cookies): Get rid of a variable for URL, implicit conversion works just as well.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::setCookies): Assert that no more than one cookie was created from one
Set-Cookie header, document.cookie can only be used to set one cookie at a time.
(WebCore::getRawCookies): Removed useless local variables.
- platform/network/CookieStorage.h: Removed an unneeded include, clarified a comment.
- platform/network/HTTPHeaderMap.h: Added a FIXME.
- 1:19 PM Changeset in webkit [133663] by
-
- 4 edits2 deletes in trunk/LayoutTests
Unreviewed chromium, chromium-mac-mountainlion gardening
Remove a bunch of passing tests, and clean up a couple of ML issues.
- platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Removed.
- platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
- platform/chromium/TestExpectations:
- 1:19 PM Changeset in webkit [133662] by
-
- 6 edits2 adds in branches/safari-536.28-branch
Merged r126131. <rdar://problem/12536500>
- 1:13 PM Changeset in webkit [133661] by
-
- 2 edits in trunk/Source/JavaScriptCore
Indentation of JSCell.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101379
Rubber stamped by Alexey Proskuryakov.
Just removed four spaces on a bunch of lines.
- runtime/JSCell.h:
- 1:08 PM Changeset in webkit [133660] by
-
- 6 edits2 adds in trunk
Implement MediaPlayerPrivate::didLoadingProgress for BlackBerry platform
https://bugs.webkit.org/show_bug.cgi?id=100378
Patch by John Griggs <jgriggs@rim.com> on 2012-11-06
Reviewed by Eric Carlson.
Implement this method for BlackBerry platform.
New test: LayoutTests/media/progress-events-generated-correctly.html
Source/WebCore:
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::didLoadingProgress):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
LayoutTests:
- media/progress-events-generated-correctly-expected.txt: Added.
- media/progress-events-generated-correctly.html: Added.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- 12:44 PM Changeset in webkit [133659] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Wrong scroll position when going back in history
https://bugs.webkit.org/show_bug.cgi?id=101358
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.
Reset the contentsSize after a new load was committed. We should not continue
to use the contentsSize of the previous page in any calculation.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didCommitLoad):
- 12:43 PM Changeset in webkit [133658] by
-
- 7 edits2 copies in branches/safari-536.28-branch
Merged r125988. <rdar://problem/12536463>
- 12:25 PM Changeset in webkit [133657] by
-
- 3 edits1 add in trunk
DOMImplementation should use ScriptWrappable
https://bugs.webkit.org/show_bug.cgi?id=101279
Reviewed by Eric Seidel.
PerformanceTests:
This simple PerformanceTest measure how quickly we can access
document.implementation. The goal of this performance test is just to
validate that using ScriptWrappable actually makes the bindings faster.
- Bindings/document-implementation.html: Added.
Source/WebCore:
This patch makes DOMImplementation ScriptWrappable. Both the V8 and JSC
bindings automatically detect the presence of this base class and use
it to optimize getting and setting JavaScript wrappers.
This patch is a 23% progression on Bindings/document-implementation for
the V8 bindings and a 69% progression for the JSC bindings.
- dom/DOMImplementation.h:
- 12:23 PM Changeset in webkit [133656] by
-
- 1 edit2 copies in branches/safari-536.28-branch/LayoutTests
Merged r126144. <rdar://problem/12516374>
- 12:22 PM Changeset in webkit [133655] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r125631. <rdar://problem/12516374>
- 12:10 PM Changeset in webkit [133654] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-06
- DEPS:
- 12:10 PM Changeset in webkit [133653] by
-
- 5 edits in trunk/Source
Speed up TransformationMatrix::multiply() on modern ARM
https://bugs.webkit.org/show_bug.cgi?id=101084
Reviewed by Gavin Barraclough.
Source/WebCore:
The main improvements are:
-Store the full source matrix in the registers d16 to d31. This way we avoid going
back and forth to memory to use the operands.
Since the full matrix is in register, we can also directly modify the memory of m_matrix,
we no longer need the temporary matrix memcopied at the end.
-Use of LoadMultiple and StoreMultiple to load-store the matrix parameters.
-Use Multiply-Accumulate instead of VMUL followed by VADD. This half the number of instruction.
-On regular ARMv7, using a loop to reuse the same code for each row also improve the performance.
Depending on the hardware, the new code takes 20% to 42% less time than the basic implementation.
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::multiply):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
Source/WTF:
- wtf/Platform.h:
Add CPU(ARM_VFP) for detecting VFP availability.
Add CPU(APPLE_ARMV7S) for the Apple ARMv7S architecture.
- 12:08 PM Changeset in webkit [133652] by
-
- 8 edits in branches/chromium/1180/Source/WebCore
Revert 123677 - Merge 123495 - Files from drag and file <input> should use getMIMETypeForExtension to determine content type.
https://bugs.webkit.org/show_bug.cgi?id=91702
Reviewed by Jian Li.
Awhile back, we changed File to only use getWellKnownMIMETypeForExtension to prevent web
pages from being able to detect what applications a user has installed indirectly through
the MIME types. However, some sites like YouTube's drag and drop uploader use MIME types
that aren't in WebKit's internal list, so we relax the restriction for Files that originate
from an user action.
- fileapi/File.cpp:
(WebCore::getContentTypeFromFileName):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
(WebCore::createBlobDataForFileWithMetadata):
(WebCore::File::createWithRelativePath):
(WebCore::File::File):
- fileapi/File.h:
(File):
(WebCore::File::create):
(WebCore::File::createWithName):
- html/FileInputType.cpp:
(WebCore::FileInputType::createFileList):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::addFilename):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::files):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::files):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::files):
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::files):
TBR=dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10821032
TBR=kareng@chromium.org
Review URL: https://codereview.chromium.org/11370004
- 12:03 PM Changeset in webkit [133651] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r125503. <rdar://problem/12536466>
- 11:24 AM Changeset in webkit [133650] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:19 AM Changeset in webkit [133649] by
-
- 2 edits in trunk/Source/JavaScriptCore
Indentation of JSObject.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101313
Rubber stamped by Alexey Proskuryakov.
Just unindented code, since namespace bodies shouldn't be indented.
- runtime/JSObject.h:
- 11:18 AM Changeset in webkit [133648] by
-
- 5 edits in trunk/LayoutTests
[CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled
https://bugs.webkit.org/show_bug.cgi?id=101364
Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-06
Reviewed by Simon Fraser.
There are no changes in the code. Only the tests had to be fixed.
- fast/regions/float-pushed-width-change-expected.html: Remove the unnecessary 0.5px margin.
- fast/regions/floats-basic-in-variable-width-regions-expected.html: Because of how regions are implemented, the left offset for lines is 50px (the float width) - X.5px (margin: auto gives a different value in the two regions). This translated into 37.5px which triggered a sub-pixel layout issue. The new width values changes the X.5px into a rounded value.
- fast/regions/floats-basic-in-variable-width-regions.html: See above
- fast/regions/render-region-renderer-expected.html: Remove unnecessary 0.5px height.
- 11:15 AM Changeset in webkit [133647] by
-
- 2 edits in trunk/LayoutTests
[Chromium] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html flaky on linux debug
https://bugs.webkit.org/show_bug.cgi?id=101377
Unreviewed gardening. Add new expectation, remove expectation for reverted change.
- platform/chromium/TestExpectations:
- 11:13 AM Changeset in webkit [133646] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fix ChangeLog comment: r133645 was rubber stamped by, not reviwed by, Alexey.
- 11:10 AM Changeset in webkit [133645] by
-
- 2 edits in trunk/Source/JavaScriptCore
Indentation of JSArray.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101314
Reviewed by Alexey Proskuryakov.
Just removing the indentation inside the namespace body.
- runtime/JSArray.h:
- 11:10 AM Changeset in webkit [133644] by
-
- 13 edits68 deletes in trunk
Unreviewed, rolling out r133529 and r133562.
http://trac.webkit.org/changeset/133529
http://trac.webkit.org/changeset/133562
https://bugs.webkit.org/show_bug.cgi?id=101371
Caused 15% memory regression on Chromium page cyclers
(Requested by jsbell|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-06
Source/WebCore:
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
- platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator):
- platform/text/TextBreakIterator.h:
(WebCore):
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::setUpIterator):
(WebCore::acquireLineBreakIterator):
- platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::acquireLineBreakIterator):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/RenderText.h:
(WebCore):
- rendering/break_lines.cpp:
(WebCore):
(WebCore::isBreakableSpace):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
LayoutTests:
- css3/line-break/line-break-auto-centered-expected.html: Removed.
- css3/line-break/line-break-auto-centered.html: Removed.
- css3/line-break/line-break-auto-half-kana-expected.html: Removed.
- css3/line-break/line-break-auto-half-kana.html: Removed.
- css3/line-break/line-break-auto-hyphens-expected.html: Removed.
- css3/line-break/line-break-auto-hyphens.html: Removed.
- css3/line-break/line-break-auto-inseparables-expected.html: Removed.
- css3/line-break/line-break-auto-inseparables.html: Removed.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-auto-iteration-marks.html: Removed.
- css3/line-break/line-break-auto-postfixes-expected.html: Removed.
- css3/line-break/line-break-auto-postfixes.html: Removed.
- css3/line-break/line-break-auto-prefixes-expected.html: Removed.
- css3/line-break/line-break-auto-prefixes.html: Removed.
- css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
- css3/line-break/line-break-auto-sound-marks.html: Removed.
- css3/line-break/line-break-loose-centered-expected.html: Removed.
- css3/line-break/line-break-loose-centered.html: Removed.
- css3/line-break/line-break-loose-half-kana-expected.html: Removed.
- css3/line-break/line-break-loose-half-kana.html: Removed.
- css3/line-break/line-break-loose-hyphens-expected.html: Removed.
- css3/line-break/line-break-loose-hyphens.html: Removed.
- css3/line-break/line-break-loose-inseparables-expected.html: Removed.
- css3/line-break/line-break-loose-inseparables.html: Removed.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-loose-iteration-marks.html: Removed.
- css3/line-break/line-break-loose-postfixes-expected.html: Removed.
- css3/line-break/line-break-loose-postfixes.html: Removed.
- css3/line-break/line-break-loose-prefixes-expected.html: Removed.
- css3/line-break/line-break-loose-prefixes.html: Removed.
- css3/line-break/line-break-loose-sound-marks-expected.html: Removed.
- css3/line-break/line-break-loose-sound-marks.html: Removed.
- css3/line-break/line-break-normal-centered-expected.html: Removed.
- css3/line-break/line-break-normal-centered.html: Removed.
- css3/line-break/line-break-normal-half-kana-expected.html: Removed.
- css3/line-break/line-break-normal-half-kana.html: Removed.
- css3/line-break/line-break-normal-hyphens-expected.html: Removed.
- css3/line-break/line-break-normal-hyphens.html: Removed.
- css3/line-break/line-break-normal-inseparables-expected.html: Removed.
- css3/line-break/line-break-normal-inseparables.html: Removed.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-normal-iteration-marks.html: Removed.
- css3/line-break/line-break-normal-postfixes-expected.html: Removed.
- css3/line-break/line-break-normal-postfixes.html: Removed.
- css3/line-break/line-break-normal-prefixes-expected.html: Removed.
- css3/line-break/line-break-normal-prefixes.html: Removed.
- css3/line-break/line-break-normal-sound-marks-expected.html: Removed.
- css3/line-break/line-break-normal-sound-marks.html: Removed.
- css3/line-break/line-break-strict-centered-expected.html: Removed.
- css3/line-break/line-break-strict-centered.html: Removed.
- css3/line-break/line-break-strict-half-kana-expected.html: Removed.
- css3/line-break/line-break-strict-half-kana.html: Removed.
- css3/line-break/line-break-strict-hyphens-expected.html: Removed.
- css3/line-break/line-break-strict-hyphens.html: Removed.
- css3/line-break/line-break-strict-inseparables-expected.html: Removed.
- css3/line-break/line-break-strict-inseparables.html: Removed.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-strict-iteration-marks.html: Removed.
- css3/line-break/line-break-strict-postfixes-expected.html: Removed.
- css3/line-break/line-break-strict-postfixes.html: Removed.
- css3/line-break/line-break-strict-prefixes-expected.html: Removed.
- css3/line-break/line-break-strict-prefixes.html: Removed.
- css3/line-break/line-break-strict-sound-marks-expected.html: Removed.
- css3/line-break/line-break-strict-sound-marks.html: Removed.
- platform/chromium-android/css3/line-break/line-break-auto-half-kana-expected.html: Removed.
- platform/chromium-android/css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
- platform/chromium/css3/line-break/line-break-auto-half-kana-expected.html: Removed.
- platform/chromium/css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
- 11:08 AM Changeset in webkit [133643] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Declare all smart callbacks in EwkViewCallbacks.h
https://bugs.webkit.org/show_bug.cgi?id=101360
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.
Declare all EwkView smart callbacks in EwkViewCallbacks.h
and remove remaining calls to evas_object_smart_callback_call().
It is a good idea to have all the callbacks declared in one
place for convenience and consistency. We also have better
argument type checking if we use the new callback mechanism.
- UIProcess/API/efl/EwkViewCallbacks.h:
(EwkViewCallbacks::CallBack::call):
(CallBack):
(EwkViewCallbacks):
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::informIconChange):
(EwkViewImpl::informURLChange):
(EwkViewImpl::createNewPage):
(EwkViewImpl::closePage):
- 11:04 AM Changeset in webkit [133642] by
-
- 4 edits in trunk/Source
[Chromium] Enable the JavaScript i18n API for Android
https://bugs.webkit.org/show_bug.cgi?id=101357
Reviewed by Adam Barth.
Source/WebCore:
Remove the conditional dependency on the v8-i18n API. The library is now
always available in a Chromium for Android checkout.
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
Enable the JavaScript i18n API for Chromium on Android. This adds a
grand total of 18.7 KiB of data to the content shell apk.
- features.gypi:
- 11:03 AM Changeset in webkit [133641] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium-mac-mountainlion expectations to remove passing tests.
- platform/chromium-mac-mountainlion/TestExpectations:
- 10:58 AM Changeset in webkit [133640] by
-
- 2 edits in trunk/LayoutTests
Don't dump pixels for filter-empty-element-crash.
https://bugs.webkit.org/show_bug.cgi?id=101359
Reviewed by Adrienne Walker.
- css3/filters/filter-empty-element-crash.html:
- 10:51 AM Changeset in webkit [133639] by
-
- 3 edits in trunk/LayoutTests
(r133351): Number of test failures from enabling SUBPIXEL_LAYOUT on Mac
https://bugs.webkit.org/show_bug.cgi?id=101220
New baselines for two more tests whose output was affected by enabling subpixel layout.
- platform/mac/fast/dynamic/subtree-parent-static-y-expected.txt:
- platform/mac/fast/images/repaint-subrect-grid-expected.txt:
- 10:48 AM WebKit Team edited by
- (diff)
- 10:43 AM Changeset in webkit [133638] by
-
- 3 edits in trunk/LayoutTests
Add new test cases to layout test effect-reference and effect-reference-hw.
https://bugs.webkit.org/show_bug.cgi?id=101366
Reviewed by Dean Jackson.
- css3/filters/effect-reference-hw.html:
- css3/filters/effect-reference.html:
Add some test cases for feBlend and feSpecularLighting.
- 10:42 AM Changeset in webkit [133637] by
-
- 3 edits in trunk/Source/WebKit2
Hook up the remote layer tree drawing area to an environment variable
https://bugs.webkit.org/show_bug.cgi?id=101267
Reviewed by Andreas Kling.
- UIProcess/API/mac/WKView.mm:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::sizeDidChange):
(WebKit::RemoteLayerTreeDrawingAreaProxy::deviceScaleFactorDidChange):
- 10:40 AM Changeset in webkit [133636] by
-
- 4 edits in trunk/LayoutTests
[chromium] Two touchadjustment tests are failing on mac
https://bugs.webkit.org/show_bug.cgi?id=100833
Patch by Rick Byers <rbyers@chromium.org> on 2012-11-06
Reviewed by Antonio Gomes.
Re-enable these two tests with appropriate tweaks. Also avoid the platform dependant
behavior by switching to the Ahem font.
- platform/chromium/TestExpectations: Remove the failure expectations.
- touchadjustment/html-label.html: Tweak one very borderline case to be closer to pass
reliably. Previously this passed only due to a bug in the test infrastructure fixed in r132929.
- touchadjustment/nested-touch.html: Tweak borderline case to compensate for inclusion of
the border in the measurement of the size of the div.
- 10:27 AM Changeset in webkit [133635] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 10:25 AM Changeset in webkit [133634] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Adding window.external to our port
https://bugs.webkit.org/show_bug.cgi?id=100868
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-06
Reviewed by Rob Buis.
Patching the method names to match the ones in the spec.
- WebCoreSupport/ExternalExtension.cpp:
- 10:19 AM Changeset in webkit [133633] by
-
- 3 edits in trunk/Source/WebCore
ScriptWrappable should work for more than just Node
https://bugs.webkit.org/show_bug.cgi?id=101319
Reviewed by Eric Seidel.
This patch generalizes the inline cached wrapper code path to work with
all subclasses of ScriptWrappable, not just Node.
- bindings/js/JSDOMBinding.h:
(WebCore::setInlineCachedWrapper):
(WebCore::getInlineCachedWrapper):
(WebCore):
(WebCore::clearInlineCachedWrapper):
(WebCore::cacheWrapper):
- bindings/js/JSNodeCustom.h:
- 10:17 AM Changeset in webkit [133632] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-06
Reviewed by Rob Buis.
Revert webkit/ce306dcc698199a6f7ce679daf0a30c25d3a3d43 slider theme
change which break media control and vertical slider.
RIM PR 236993
Internal Reviewed by Jeff Rogers.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):
- 10:15 AM Changeset in webkit [133631] by
-
- 4 edits in trunk/Source/WebCore
canonicalizedTitle() shouldn't convert 8 bit title strings to 16 bit
https://bugs.webkit.org/show_bug.cgi?id=101105
Reviewed by Darin Adler.
Turned canonicalizedTitle() into a templated function based on character type.
Changed call in updateTitle() to check the bitness of the title string to call
the right template flavor of canonicalizedTitle().
Made supporting changes by adding displayBufferModifiedByEncoding(LChar*, ...)
and made TextEncoding::displayBuffer() a templated function as well.
No new tests needed, as functionality is unchanged.
- dom/Document.cpp:
(WebCore::canonicalizedTitle):
(WebCore::Document::updateTitle):
(WebCore::Document::displayBufferModifiedByEncodingInternal):
- dom/Document.h:
(WebCore::Document::displayBufferModifiedByEncoding):
- platform/text/TextEncoding.h:
(TextEncoding):
(WebCore::TextEncoding::displayBuffer):
- 10:15 AM Changeset in webkit [133630] by
-
- 2 edits in trunk/LayoutTests
[Chromium] css3/line-break/line-break-strict-sound-marks.html image flaky on Mac 10.7
https://bugs.webkit.org/show_bug.cgi?id=101368
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 10:01 AM Changeset in webkit [133629] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Page can't back to whole screen after zoom out and orientation change
https://bugs.webkit.org/show_bug.cgi?id=101350
Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.
Internally reviewed by Arvid Nilsson.
PR: 229321
When rotating device during touch interaction, bitmap zooming was
unexpected ended by resetBitmapZoomScale() so that it couldn't bounce
back. The call resetBitmapZoomScale() is ancient, which just resets the
scale of the bitmap before. Right now it only ends the bitmap zooming
which caused the issue. As UI viewport will be updated by zoomChanged()
right after that, we can remove this trouble maker.
Update the interaction views if the rotation is being changed so that
ZoomHandler can get the updated views.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
- Api/WebPageClient.h:
- 9:57 AM Changeset in webkit [133628] by
-
- 3 edits2 adds in trunk
Fix RenderGeometryMap assertion when layers are scrolled during layout
https://bugs.webkit.org/show_bug.cgi?id=101292
Reviewed by Beth Dakin.
Source/WebCore:
When we set RenderLayer scroll positions as part of layout, we don't want
to update compositing layers right away. Updating compositing layers
requires that the entire layer tree has been updated from renderers,
so that the geometry of all RenderLayers can be trusted. When this state
was violated, RenderGeometryMap asserts.
Fix by bailing from updateCompositingLayersAfterScroll() if FrameView
tells us that we're doing layout. A full update of the compositing layers
will happen later anyway.
Test: compositing/geometry/geometry-map-scroll-during-layout-assertion.html
- rendering/RenderLayer.cpp:
(WebCore::frameViewFromLayer):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
LayoutTests:
Test that hit the assertion before the fix.
- compositing/geometry/geometry-map-scroll-during-layout-assertion-expected.txt: Added.
- compositing/geometry/geometry-map-scroll-during-layout-assertion.html: Added.
- 9:54 AM Changeset in webkit [133627] by
-
- 1 edit5 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening - more rebaselines following bug 101115.
- platform/chromium-mac-lion/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
- platform/chromium-mac-lion/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
- platform/chromium-mac-lion/fast/block/lineboxcontain/glyphs-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/stacked-diacritics-expected.png: Added.
- 9:50 AM Changeset in webkit [133626] by
-
- 2 edits in trunk/Tools
[chromium] MediaStream API: Remove the valgrind issue with MockWebRTCPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=101336
Reviewed by Andreas Kling.
This patch changes the delete to delete [] to match the new[].
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
- 9:42 AM Changeset in webkit [133625] by
-
- 2 edits in trunk/Source/WebCore
quoteCSSString() always creates a 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=101004
Reviewed by Darin Adler.
Added a new templated helper based on character type from the logic of quoteCSSString() to process
the argument string based on its native bitness.
Functionality covered by existing tests.
- css/CSSParser.cpp:
(WebCore::quoteCSSStringInternal):
(WebCore::quoteCSSString):
- 9:34 AM Changeset in webkit [133624] by
-
- 7 edits1 add in trunk/Source
[Qt][WK2] Fit-to-width broken on pages with viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=99715
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Add a bool that indicates if the content had an explicit
initial-scale in the viewport meta tag.
- dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
- dom/ViewportArguments.h:
(ViewportAttributes):
Source/WebKit2:
The initial scale from the viewport attributes should only
be applied if the scale was explicitly specified in the
viewport meta tag.
If the initial scale is auto it should be calculated using
the final contents size, which might be larger than the
layout size, so that the content fits horizontally into
the view.
Also add QML unit tests that cover this functionality.
- UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml:
- UIProcess/API/qt/tests/qmltests/common/test5.html: Added.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageTransitionViewportReady):
- 9:31 AM Changeset in webkit [133623] by
-
- 2 edits in trunk/Source/WTF
Refactor setting TEXTURE_MAPPER_GL
https://bugs.webkit.org/show_bug.cgi?id=99758
Patch by Laszlo Gombos <Laszlo Gombos> on 2012-11-06
Reviewed by Noam Rosenthal.
Make the rule that sets the default for USE(3D_GRAPHICS) port independent.
If not set, set USE(TEXTURE_MAPPER_GL) when USE(TEXTURE_MAPPER) and
USE(3D_GRAPHICS) is enabled.
- wtf/Platform.h:
- 9:28 AM Changeset in webkit [133622] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Gardening, add pixel expectation for test.
- platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
- 9:26 AM Changeset in webkit [133621] by
-
- 2 edits in trunk/LayoutTests
[Chromium] fast/dom/Window/customized-property-survives-gc.html slow on debug
https://bugs.webkit.org/show_bug.cgi?id=101362
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 9:15 AM Changeset in webkit [133620] by
-
- 20 edits4 adds in trunk
CSP 1.1: Tweak the script interface to match the spec.
https://bugs.webkit.org/show_bug.cgi?id=101321
Reviewed by Adam Barth.
Source/WebCore:
This patch brings WebKit in line with the changes made to the spec in
https://dvcs.w3.org/hg/content-security-policy/rev/5a29424a37d4.
Specifically, the following:
- Renamed 'document.SecurityPolicy' to 'document.securityPolicy'
- Converted the following to read-only boolean attributes:
- 'allowsEval'
- 'allowsInlineScript'
- 'allowsInlineStyle'
- 'isActive'
These changes only have effect for ports with CSP_NEXT enabled.
Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinescript.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinestyle.html
- dom/Document.idl:
- page/DOMSecurityPolicy.idl:
Tweaking the IDL files to match the new definition of the
functionlity in the spec.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi.html:
- http/tests/security/contentSecurityPolicy/resources/securitypolicy-tests-base.js:
s/document.SecurityPolicy/document.securityPolicy/g
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinescript-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinescript.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinestyle-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinestyle.html: Added.
For whatever reason, we never wrote tests for these methods. Now we
have, which is good.
- 9:02 AM EFLWebKit edited by
- add an example to turn on verbose build logs for cmake (diff)
- 8:44 AM Changeset in webkit [133619] by
-
- 8 edits20 adds in trunk/LayoutTests
Unreviewed gardening after bug 101115 fixed.
- platform/chromium-linux-x86/fast/block/lineboxcontain: Added.
- platform/chromium-linux-x86/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
- platform/chromium-linux-x86/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
- platform/chromium-linux-x86/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
- platform/chromium-linux-x86/fast/block/lineboxcontain/glyphs-expected.png: Added.
- platform/chromium-linux-x86/fast/block/lineboxcontain/glyphs-expected.txt: Added.
- platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.png:
- platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
- platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
- platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
- platform/chromium-linux/fast/block/lineboxcontain/glyphs-expected.png: Added.
- platform/chromium-linux/fast/block/lineboxcontain/glyphs-expected.txt: Added.
- platform/chromium-linux/fast/repaint/stacked-diacritics-expected.png:
- platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.png:
- platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.png:
- platform/chromium-mac/fast/block/lineboxcontain/glyphs-expected.png:
- platform/chromium-mac/fast/repaint/stacked-diacritics-expected.png:
- platform/chromium-win-xp/fast/block/lineboxcontain: Added.
- platform/chromium-win-xp/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
- platform/chromium-win-xp/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
- platform/chromium-win-xp/fast/block/lineboxcontain/glyphs-expected.png: Added.
- platform/chromium-win-xp/fast/block/lineboxcontain/glyphs-expected.txt: Added.
- platform/chromium-win/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
- platform/chromium-win/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
- platform/chromium-win/fast/block/lineboxcontain/glyphs-expected.png: Added.
- platform/chromium-win/fast/block/lineboxcontain/glyphs-expected.txt: Added.
- platform/chromium/TestExpectations:
- 8:37 AM EFLWebKit edited by
- sort the list of dependent packages to avoid adding the same package … (diff)
- 8:37 AM Changeset in webkit [133618] by
-
- 2 edits in trunk/Tools
Add Adobe's bug tracker to committers.py
https://bugs.webkit.org/show_bug.cgi?id=101338
Patch by Mihai Balan <mibalan@adobe.com> on 2012-11-06
Reviewed by Kentaro Hara.
Adding Adobe's bug tracker mailing list to committers.py
to enable its inclusion in the autocomplete list.
- Scripts/webkitpy/common/config/committers.py:
- 8:22 AM Changeset in webkit [133617] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Make webkit_lint happy. Unreviewed.
- platform/chromium/TestExpectations:
- 8:18 AM Changeset in webkit [133616] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Mark fast/dom/shadow/shadowdom-for-output-only-shadow.html as flaky.
- platform/efl/TestExpectations:
- 8:15 AM Changeset in webkit [133615] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening. Unskip test that's been passing for a while.
- platform/efl-wk2/TestExpectations:
- 8:14 AM Changeset in webkit [133614] by
-
- 15 edits2 adds in trunk
Added console.clear() method
Web Inspector: add console.clear()
https://bugs.webkit.org/show_bug.cgi?id=101021
Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-11-06
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Adds native implementation of console.clear
Test: inspector/console/console-clear-function.html
- English.lproj/localizedStrings.js: Adds 'Console was cleared' string
- inspector/ConsoleMessage.cpp:
(WebCore::messageTypeValue): Adds ClearMessageType
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage): Display strategy for "clear" message
- inspector/front-end/ConsoleModel.js:
- inspector/front-end/inspector.css:
(.console-info): Adds style for the 'console was cleared' message
- page/Console.cpp: backend binging for console.clear()
(WebCore::Console::clear):
(WebCore):
- page/Console.h:
(Console):
- page/Console.idl: Adds 'clear' message to protocol
- page/ConsoleTypes.h:
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(stringForMessageType): Added ClearMessageType case to switch
LayoutTests:
- inspector/console/console-clear-function-expected.txt: Added.
- inspector/console/console-clear-function.html: Added.
- 8:11 AM Changeset in webkit [133613] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/images/exif-orientation-image-document.html failing on WK2 bots
https://bugs.webkit.org/show_bug.cgi?id=101344
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-06
- platform/efl-wk2/TestExpectations:
- 8:06 AM Changeset in webkit [133612] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 8:00 AM Changeset in webkit [133611] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 7:54 AM Changeset in webkit [133610] by
-
- 5 edits in trunk
Heap-buffer-overflow in WebCore::TextTrackCueList::add
https://bugs.webkit.org/show_bug.cgi?id=101018
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-11-06
Reviewed by Eric Carlson.
Source/WebCore:
Added an extra check to avoid using a negative array index when a cue
is added to the beginning of the list.
Test case added to LayoutTests/media/track/track-add-remove-cue.html.
- html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add):
LayoutTests:
Added a test case to verify that adding a cue to the beginning of a non-empty list doesn't crash.
- media/track/track-add-remove-cue-expected.txt:
- media/track/track-add-remove-cue.html:
- 7:42 AM Changeset in webkit [133609] by
-
- 3 edits2 adds in trunk
Regression(r132681): Heap-use-after-free in WebCore::RenderTextTrackCue::layout
https://bugs.webkit.org/show_bug.cgi?id=100981
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-11-06
Reviewed by Eric Carlson.
Source/WebCore:
Fixing a TextTrackCue use after free bug. textTrackRemoveCues() needs to be called when
an HTMLTrackElement is removed from an HTMLMediaElement so that references to
TextTrackCues are removed from m_cueTree.
Test: media/track/track-remove-by-setting-innerHTML.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::willRemoveTrack):
LayoutTests:
Added a test that removes track elements by setting innerHTML on the track's parent.
- media/track/track-remove-by-setting-innerHTML-expected.txt: Added.
- media/track/track-remove-by-setting-innerHTML.html: Added.
- 7:34 AM Changeset in webkit [133608] by
-
- 27 edits1 copy2 adds in trunk
[skia] Implement reference (url) filters on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=100142
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayer.h:
Expose Layer::setFilter() to the WebKit API.
Source/WebCore:
Covered by css3/filters/effect-reference-hw.html
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
Add new files.
- WebCore.xcodeproj/project.pbxproj:
Mark FilterEffect.h as "private".
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setFilters):
Use the new SkImageFilter builder and setLayer() infrastructure, but
only if there's a reference filter in the chain.
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::createImageFilter):
Add createImageFilter() factory function for building SkImageFilters.
- platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::ReferenceFilterOperation::filterEffect):
(WebCore::FilterOperation::ReferenceFilterOperation::setFilterEffect):
Add a FilterEffect member to ReferenceFilterOperation, and accessors
for it.
- platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::createImageFilter):
Implement SkImageFilter building for FEBlend filter.
- platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::createColorFilter):
(WebCore::FEColorMatrix::platformApplySkia):
Refactor creation of SkColorFilter from an FEColorMatrix filter.
(WebCore::FEColorMatrix::createImageFilter):
Implement SkImageFilter building for FEColorMatrix filter.
- platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:
(WebCore::FEGaussianBlur::createImageFilter):
Implement SkImageFilter building for FEGaussianBlur filter.
- platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::createImageFilter):
Implement SkImageFilter building for FELighting filters.
- platform/graphics/filters/skia/FEMorphologySkia.cpp:
(WebCore::FEMorphology::createImageFilter):
Implement SkImageFilter building for FEMorphology filter.
- platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp: Added.
(WebCore::SkiaImageFilterBuilder::SkiaImageFilterBuilder):
(WebCore::SkiaImageFilterBuilder::build):
- platform/graphics/filters/skia/SkiaImageFilterBuilder.h:
Implement new helper class for building an SkImageFilter DAG from
a FilterEffect DAG. Can also build from FilterOperations list.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
When building FilterEffects from a reference filter, also store the
generated DAG on the ReferenceFilterOperation itself.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
Even when in composited mode, if there's a reference filter in the
chain, build the FilterEffect DAG from it.
- 7:32 AM Changeset in webkit [133607] by
-
- 7 edits in trunk/Tools
[chromium] Enable fixed position compositing on Android DRT
https://bugs.webkit.org/show_bug.cgi?id=100263
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-06
Reviewed by James Robinson.
Chrome on Android forces composited mode for every page and creates
stacking contexts and graphics layers for fixed positioned elements.
Change the DumpRenderTree settings to match this.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedCompositingForFixedPositionEnabled):
(TestShell):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.additional_drt_flag):
- 7:27 AM Changeset in webkit [133606] by
-
- 7 edits2 adds in trunk
[BlackBerry] Automatically go fullscreen on video play
https://bugs.webkit.org/show_bug.cgi?id=101100
Patch by Max Feil <mfeil@rim.com> on 2012-11-06
Reviewed by Eric Carlson.
Source/WebCore:
There is a requirement to have HTML5 video automatically enter
fullscreen when a video starts playing (PR131774). This change
implements this feature, with restrictions. The main restriction
is adherence to WebKit's philosophy of only entering fullscreen
due to a user gesture. This is important in order to avoid
pop-up advertisements and other unwanted fullscreen content.
One consequence of this is that video elements with the autoplay
attribute will not automatically enter fullscreen.
Other caveats:
- This feature applies only to "small screen" devices where
automatically going fullscreen makes more sense.
- Fullscreen will only be entered automatically when the
video is played from the beginning (current time is zero).
It is assumed that if the user is resuming play from a paused
state and is not in fullscreen mode, then they exited fullscreen
mode intentionally.
Test: platform/blackberry/media/video-automatic-fullscreen.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerEnterFullscreen):
(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreen):
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreenPermitted):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerEnterFullscreen):
(WebCore::MediaPlayerClient::mediaPlayerIsFullscreen):
(WebCore::MediaPlayerClient::mediaPlayerIsFullscreenPermitted):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::conditionallyGoFullscreenAfterPlay):
(WebCore):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
LayoutTests:
Test that fullscreen is entered automatically when play is
pressed (PR131774). This test applies to handheld (small screen)
devices only, not tablets. The html code for this test was based
on video-controls-fullscreen-volume.html and modified.
- platform/blackberry/media/video-automatic-fullscreen-expected.txt: Added.
- platform/blackberry/media/video-automatic-fullscreen.html: Added.
- 7:20 AM Changeset in webkit [133605] by
-
- 3 edits in trunk/Source/WebKit2
Coordinated Graphics: Remove a parent member in WebLayerInfo.
https://bugs.webkit.org/show_bug.cgi?id=101142
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.
The parent member is not used in UI Process, and GraphicsLayer::setParent is
internally used only, so we don't need to send the parent layer id to UI Process.
- Shared/WebLayerTreeInfo.h:
(WebKit::WebLayerInfo::WebLayerInfo):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
- 7:16 AM Changeset in webkit [133604] by
-
- 13 edits in branches/chromium/1312/Source/WebCore/inspector
Merge 133052 - Web Inspector: frame chooser does not work on subsequent inspector open.
https://bugs.webkit.org/show_bug.cgi?id=100771
Reviewed by Yury Semikhatsky.
- Make WorkerRuntimeAgent and PageRuntimeAgent register themselves in the instrumenting agents independently
- Move pause / run worker handling from InspectorRuntimeAgent into WorkerRuntimeAgent
- Remove remains of the front-end reused signal from InspectorAgent
- Send execution contexts post clear window object instead of post commit load.
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::clearFrontend):
(WebCore::InspectorAgent::didCommitLoad):
- inspector/InspectorAgent.h:
(InspectorAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::restore):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::run):
(WebCore::InspectorRuntimeAgent::setScriptDebugServer):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/InstrumentingAgents.h:
(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::workerRuntimeAgent):
(WebCore::InstrumentingAgents::setWorkerRuntimeAgent):
(InstrumentingAgents):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::setFrontend):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::run):
(WebCore):
(WebCore::WorkerRuntimeAgent::pauseWorkerContext):
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11366107
- 7:16 AM Changeset in webkit [133603] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics: Remove two methods' virtual modifiers in CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=101141
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.
The methods exist for only CoordinatedGraphicsLayer and we have no plan to
extend CoordinatedGraphicsLayer.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
- 7:14 AM Changeset in webkit [133602] by
-
- 2 edits in trunk/Source/WebCore
[WK2][EFL][GTK] early return of checkSpellingOfString treats correct words as misspelled
https://bugs.webkit.org/show_bug.cgi?id=101215
Reviewed by Gustavo Noronha Silva.
Save the misspelled location and length of the string to the default values (-1, 0)
at the beginning of the checkSpellingOfString method.
It assumes that the words are spelled correctly and early return of method doesn't
cause assertions in findFirstMisspelling (WebCore/editing/TextCheckingHelper.cpp).
- platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::checkSpellingOfString):
- 7:12 AM Changeset in webkit [133601] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] Remove unused textures in the texture pool.
https://bugs.webkit.org/show_bug.cgi?id=100706
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.
Currently, we do not remove textures in the texture pool of
TextureMapper. The texture pool is destroyed when TextureMapper is
destroyed. It means the texture pool consumes texture memory until its
destruction. This patch removes textures if the textures have been not
used in 3 seconds as LayerTreeCoordinator manages UpdateAtlases.
Changing cache policy is not testable in layout tests.
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::BitmapTexturePoolEntry::BitmapTexturePoolEntry):
(WebCore::BitmapTexturePoolEntry::markUsed):
(WebCore::BitmapTexturePoolEntry::compareTimeLastUsed):
(BitmapTexturePoolEntry):
(WebCore):
(BitmapTexturePool):
(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::scheduleReleaseUnusedTextures):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
(WebCore::BitmapTexturePool::acquireTexture):
(WebCore::TextureMapper::acquireTextureFromPool):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::~TextureMapper):
- platform/graphics/texmap/TextureMapper.h:
(WebCore):
(TextureMapper):
- 6:45 AM Changeset in webkit [133600] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: NMI instrument CachedMetadata. It uses ~300k on plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=101067
Reviewed by Yury Semikhatsky.
Plain vanilla instrumentation for CachedMetadata class.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/CachedMetadata.cpp: Added.
(WebCore):
(WebCore::CachedMetadata::reportMemoryUsage):
- loader/CachedMetadata.h:
(CachedMetadata):
- 6:40 AM Changeset in webkit [133599] by
-
- 3 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Access to LayerTreeRenderer::m_renderQueue should be thread safe
https://bugs.webkit.org/show_bug.cgi?id=101341
Reviewed by Noam Rosenthal.
The queue can be accessed from public API so we should make
sure it is not updated concurrently with a threaded render loop.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::syncRemoteContent):
(WebKit::LayerTreeRenderer::appendUpdate):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- 6:18 AM Changeset in webkit [133598] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed unskip passing tests.
Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2012-11-06
- platform/qt-arm/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 6:15 AM Changeset in webkit [133597] by
-
- 3 edits in trunk/Tools
[EFL][WTR] EventSender: Get rid of the WTRMouseButton enum.
https://bugs.webkit.org/show_bug.cgi?id=101340
Reviewed by Kenneth Rohde Christiansen.
Get rid of an enum which was basically a duplicate of the
WKEventMouseButton one in the shared API.
The only difference is that it also had a case for a 4th mouse
button that we treat in a special way in evasMouseButton() now.
- WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::evasMouseButton):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):
- 6:13 AM Changeset in webkit [133596] by
-
- 4 edits in trunk/LayoutTests
Unreviewed unskip passing tests.
- platform/qt-arm/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 6:08 AM Changeset in webkit [133595] by
-
- 3 edits1 add in trunk/LayoutTests
Web Inspector: Flakyness in http/tests/inspector/network/network-initiator-from-console.html
https://bugs.webkit.org/show_bug.cgi?id=101195
Unreviewed test flakiness fix.
- http/tests/inspector/network/network-initiator-from-console-expected.txt:
- http/tests/inspector/network/network-initiator-from-console.html:
- http/tests/inspector/network/resources/silent_script.js: Added.
(foo):
- 6:07 AM Changeset in webkit [133594] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 6:05 AM Changeset in webkit [133593] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: report physical memory really committed for JS heap in NMI
https://bugs.webkit.org/show_bug.cgi?id=101335
Some OSes (e.g. Linux) perform lazy commits of requested memory.
Because of that the committed memory may not retain any physical
memory until the very first access to the committed chunk.
That led to JS heap reported more physical memory than was currently
in use.
Patch by Alexei Filippov <alph@chromium.org> on 2012-11-06
Reviewed by Vsevolod Vlasov.
- bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
- 5:57 AM Changeset in webkit [133592] by
-
- 5 edits in trunk
Web Inspector: Breakpoint is not removed when it was set in non-formatted mode and then removed while in formatted mode.
https://bugs.webkit.org/show_bug.cgi?id=100595
Reviewed by Yury Semikhatsky.
Source/WebCore:
Breakpoints in storage are now updated/removed by file name saved from primary location when they were created,
not by the name returned by UISourceCode (as this one could change when UISourceCode is formatted).
SourceFileId is now used across BreakpointManager to specify file name.
And breakpointStorageId is now used to specify (fileName, lineNumber) pair.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.sourceFileId):
(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved): Removed redundant check.
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.Breakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._breakpointStorageId):
(WebInspector.BreakpointManager.Storage.prototype._restoreBreakpoints):
(set WebInspector.BreakpointManager.Storage.Item):
LayoutTests:
- inspector/debugger/script-formatter-breakpoints-expected.txt:
- inspector/debugger/script-formatter-breakpoints.html:
- 5:55 AM Changeset in webkit [133591] by
-
- 1 edit2 adds in trunk/LayoutTests
Add an extra test for background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=101245
Reviewed by Eric Seidel.
This test may overlap some existing tests but they are usually
old tests where the parsing is tested but mixed with the rendering
verification, therefore it is not ideal to add new parsing tests.
This will be useful for the upcoming support of background-position with 4
values as this test will be extended to verify the parsing and later another
test/patch will be added to check/support the rendering.
- fast/backgrounds/background-position-parsing-2-expected.txt: Added.
- fast/backgrounds/background-position-parsing-2.html: Added.
- 5:24 AM Changeset in webkit [133590] by
-
- 5 edits in trunk
The "Rect" class in WebCore/Resources/pagepopups/pickerCommon.js should be renamed
https://bugs.webkit.org/show_bug.cgi?id=101304
Reviewed by Kent Tamura.
Source/WebCore:
The name Rect conflicts with CSS Rect.
No new tests. Just renaming.
- Resources/pagepopups/pickerCommon.js:
(Rectangle): Renamed from Rect.
(Rectangle.prototype.toString):
(Rectangle.intersection):
(adjustWindowRect):
(hideWindow):
LayoutTests:
- platform/chromium/fast/forms/page-popup/page-popup-adjust-rect-expected.txt: Replace Rect with Rectangle.
- platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Ditto.
- 5:20 AM Changeset in webkit [133589] by
-
- 3 edits in trunk/Source/WebCore
Replace setDOMWrapper(wrapper, 0) with resetDOMWrapper(wrapper)
https://bugs.webkit.org/show_bug.cgi?id=101190
Reviewed by Adam Barth.
To guarantee that we never stores NULL pointers to V8 internal
fields, we want to insert ASSERT()s to setDOMWrapper().
This patch replaces setDOMWrapper() that intentionally
passes NULL pointers with clearDOMWrapper().
No tests. No change in behavior.
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):
- bindings/v8/V8NPObject.cpp:
(WebCore::forgetV8ObjectForNPObject):
- 4:56 AM Changeset in webkit [133588] by
-
- 2 edits in trunk/LayoutTests
[EFL] Exclude fast/css/style-scoped cases from layout test running
https://bugs.webkit.org/show_bug.cgi?id=101326
Unreviewed, EFL gardening.
According to BUG 49142, html5 style scoped attribute implementation is on progress.
Therefore, we can skip its test cases from regular layout test running.
Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-06
- platform/efl/TestExpectations:
- 4:35 AM Changeset in webkit [133587] by
-
- 13 edits in trunk/Source/WebKit2
[EFL][WK2] Make Ewk_Context Ewk_Object
https://bugs.webkit.org/show_bug.cgi?id=101322
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.
Ewk_Context is Ewk_Object now and using common ref/unref API.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl::ewkContext):
(EwkViewImpl):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::defaultContext):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::faviconDatabase):
(EwkContext::storageManager):
(EwkContext::requestManager):
(EwkContext::vibrationProvider):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_directory_set):
(ewk_context_favicon_database_get):
(ewk_context_storage_manager_get):
(EwkContext::wkContext):
(EwkContext::downloadManager):
(EwkContext::historyClient):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
- UIProcess/API/efl/ewk_view.cpp:
(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::DownloadManagerEfl):
- UIProcess/efl/DownloadManagerEfl.h:
(WebKit::DownloadManagerEfl::create):
(DownloadManagerEfl):
- UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::handleDownloadRequest):
- UIProcess/efl/RequestManagerClientEfl.cpp:
(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
- UIProcess/efl/RequestManagerClientEfl.h:
(WebKit::RequestManagerClientEfl::create):
(RequestManagerClientEfl):
- 4:33 AM Changeset in webkit [133586] by
-
- 3 edits in trunk/LayoutTests
[Chromium] There shouldn't be linting errors about our TestExpectation files
Unreviewed test expectation update.
A number of linting errors were being displayed, partially because of my
recent additions. Fix them.
- platform/chromium-android/TestExpectations:
- platform/chromium/TestExpectations:
- 4:14 AM Changeset in webkit [133585] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Minibrowser forgets http variables when url includes ampersand
https://bugs.webkit.org/show_bug.cgi?id=101061
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.
Elementary entry only returns 'markup' text, meaning ampersands
in a url will become "&". Use elm_entry_markup_to_utf8() and
elm_entry_utf8_to_markup() when interacting with the entry.
- MiniBrowser/efl/main.c:
(on_url_changed):
(on_url_bar_activated):
- 4:09 AM Changeset in webkit [133584] by
-
- 2 edits in trunk/LayoutTests
[Qt] Disable all tests fast/dom/shadow
https://bugs.webkit.org/show_bug.cgi?id=101324
Patch by Shinya Kawanaka <shinyak@chromium.org> on 2012-11-06
Reviewed by Csaba Osztrogonác.
Since Qt does not have SHADOW_DOM flag enabled, a lot of tests are failing.
Let's skip all tests.
- platform/qt/TestExpectations:
- 4:07 AM Changeset in webkit [133583] by
-
- 5 edits2 adds in trunk
Web Inspector: Displayed name/path of urls in network tab of dev tools is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=101064
Reviewed by Yury Semikhatsky.
Source/WebCore:
Extracted some generic methods from ParsedURL displayName getters (about:blank and data url handlers).
Implemented consistent name() and path() method on NetworkRequest based on ParsedURL.
NetworkPanel now uses name() and path() methods on NetworkRequest to show requests and search for them.
Test: http/tests/inspector/network/request-name-path.html
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._matchRequest):
(WebInspector.NetworkLogView.prototype._highlightMatchedRequests):
(WebInspector.NetworkLogView.prototype.performFilter):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.NameComparator):
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.name):
(WebInspector.NetworkRequest.prototype.path):
(WebInspector.NetworkRequest.prototype._parseNameAndPathFromURL):
- inspector/front-end/ParsedURL.js:
(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(WebInspector.ParsedURL.prototype.dataURLDisplayName):
(WebInspector.ParsedURL.prototype.isAboutBlank):
(WebInspector.ParsedURL.prototype.isDataURL):
LayoutTests:
- http/tests/inspector/network/request-name-path-expected.txt: Added.
- http/tests/inspector/network/request-name-path.html: Added.
- 4:00 AM Changeset in webkit [133582] by
-
- 12 edits1 add in trunk/Source/WebCore
Web Inspector: make Spectrum and Popover WebInspector.Views in order to enable reuse
https://bugs.webkit.org/show_bug.cgi?id=101200
Reviewed by Yury Semikhatsky.
- Split Spectrum and SpectrumPopoverHelper (first is a component, second is controller)
- Made Popover a root view in order to enable lazy style loading for potential subviews (such as Spectrum)
- Extracted spectrum's css into a separate file
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/DOMExtension.js:
(Element.prototype.positionAt):
(Size):
(Element.prototype.measurePreferredSize):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.willHide):
(WebInspector.HeapSnapshotView.prototype._helpClicked):
- inspector/front-end/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.showView):
(WebInspector.Popover.prototype._innerShow):
(WebInspector.Popover.prototype.hide):
(WebInspector.Popover.prototype.dispose):
(WebInspector.Popover.prototype._positionElement):
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.alphaDrag):
(WebInspector.Spectrum):
(WebInspector.Spectrum.prototype.wasShown):
(WebInspector.SpectrumPopupHelper):
(WebInspector.SpectrumPopupHelper.prototype.spectrum):
(WebInspector.SpectrumPopupHelper.prototype.toggle):
(WebInspector.SpectrumPopupHelper.prototype.show):
(WebInspector.SpectrumPopupHelper.prototype.reposition):
(WebInspector.SpectrumPopupHelper.prototype.hide):
(WebInspector.ColorSwatch):
(WebInspector.ColorSwatch.prototype.setColorString):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype.willHide):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/View.js:
(WebInspector.View.prototype.measurePreferredSize):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/elementsPanel.css:
(.image-preview-container img):
- inspector/front-end/inspector.css:
(.swatch):
(.swatch-inner):
(.swatch-inner:hover):
- inspector/front-end/spectrum.css: Added.
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-display-value):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
(.spectrum-container .swatch):
- 3:33 AM Changeset in webkit [133581] by
-
- 7 edits2 adds in trunk
removeAttribute('style') not working in certain circumstances
https://bugs.webkit.org/show_bug.cgi?id=99295
Reviewed by Ryosuke Niwa.
Source/WebCore:
After web developers did style.XXXX=YYYY for some element, the inline
style should be always removable by using "removeAttribute('style')".
Currently it depends on whether web developers invokes
getAttribute('style'), setAttribute('style), and so on. E.g. once they
invoke getAttribute('style'), removeAttribute('style') works. This is
very confusing behavior.
Looking at Firefox browser, removeAttribute('style') always removes
all inline styles.
Test: fast/css/remove-attribute-style.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::clear):
Added a new method to remove all style properties.
(WebCore):
- css/StylePropertySet.h:
(StylePropertySet):
- dom/Element.cpp:
(WebCore::Element::removeAttribute):
If 'style' is given but the element has no style attribute, the old
code did nothing. However, if the element is styled element and has any
inline styles, the inline styles should be removed. So invoke
StyledElement::removeAllInlineStyleProperties and if any inline styles
are removed, invoke style recalc, too.
- dom/StyledElement.cpp:
(WebCore::StyledElement::removeAllInlineStyleProperties):
Added a new method to remove all inline style propeties. If any inline
style is removed, invoke inlineStyleChanged() to force style recalc.
(WebCore):
- dom/StyledElement.h:
(StyledElement):
LayoutTests:
- fast/css/remove-attribute-style-expected.txt: Added.
- fast/css/remove-attribute-style.html: Added.
- 3:17 AM Changeset in webkit [133580] by
-
- 2 edits in trunk/LayoutTests
[Chromium-Android] Skip a number of crashing tests.
Unreviewed rebaselining.
- platform/chromium/TestExpectations:
- 2:49 AM Changeset in webkit [133579] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: dim size bar for expanded item in native memory snapshot grid
https://bugs.webkit.org/show_bug.cgi?id=101062
Patch by Alexei Filippov <alph@chromium.org> on 2012-11-06
Reviewed by Yury Semikhatsky.
- inspector/front-end/nativeMemoryProfiler.css:
(.native-snapshot-view .data-grid .expanded div.size-bar):
- 2:46 AM Changeset in webkit [133578] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics] compositing/iframes/connect-compositing-iframe.html crashes
https://bugs.webkit.org/show_bug.cgi?id=101232
Reviewed by Jocelyn Turcotte.
The crash is happening in CoordinatedGraphicsLayer::flushCompositingState
because we dereferencing a null m_coordinatedGraphicsLayerClient.
This happens when the root layer became composited because it has content overlapping
with an inner iframe that is composited. In this case the RenderLayerCompositor attaches
the layer with RootLayerAttachedViaEnclosingFrame attachment flag and do not call
ChromeClient::attachRootGraphcisLayer so we don't have a chance to set m_coordinatedGraphicsLayerClient.
The solution is to set the client early in the factory method.
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createGraphicsLayer):
- 2:43 AM Changeset in webkit [133577] by
-
- 14 edits2 adds in trunk
[Shadow] Using isUnknownPseudoElement() for shadow pseudo id seems confusing
https://bugs.webkit.org/show_bug.cgi?id=100826
Reviewed by Hajime Morita.
Source/WebCore:
We used isUnknownPseudoElement() for these 3 meanings: 1) the element is a custom pseudo-element (starting with 'x-'),
2) the element is a webkit custom pseudo-element (starting with '-webkit-'), and 3) the element has an unknown type.
We would like to distinguish them when parsing CSSSelector types. Also, we disable using (3) type for using
shadowPseudoId.
In this patch, we allow using WebKitCustomPseudoElement in AuthorShadowRoot, and CustomPseudoElement in
UAShadowRoot. However, we will disable them later.
Test: fast/dom/shadow/shadow-pseudo-id.html
- css/CSSGrammar.y.in: Now we can discard UNKNOWN type. It should not match anything.
- css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::updateSpecifiers):
- css/CSSParserValues.h:
(WebCore::CSSParserSelector::isCustomPseudoElement):
(CSSParserSelector):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoType):
(WebCore::CSSSelector::isCustomPseudoType): Returns true if the type is PseudoUserAgentCustomElement or PseudoWebKitCustomElement.
(WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h:
(CSSSelector):
(WebCore::CSSSelector::isCustomPseudoElement):
(WebCore):
- css/CSSSelectorList.cpp:
(WebCore::SelectorHasInvalidSelectorFunctor::operator()): We will reject all selectors which were judged as
UNKNOWN before. i.e. It contians all three types for now.
(WebCore::CSSSelectorList::hasInvalidSelector): Renamed.
- css/CSSSelectorList.h:
(CSSSelectorList):
- css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
- dom/Element.cpp:
(WebCore::Element::setShadowPseudoId):
- dom/SelectorQuery.cpp:
(WebCore::SelectorQueryCache::add):
LayoutTests:
- fast/dom/shadow/shadow-nested-pseudo-id.html: Fixed a testcase so that shadowPseudoId starts with 'x-'.
- fast/dom/shadow/shadow-pseudo-id-expected.html: Added.
- fast/dom/shadow/shadow-pseudo-id.html: Added.
- 2:26 AM Changeset in webkit [133576] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
committers-autocomplete.js works only with WebKit based browsers
https://bugs.webkit.org/show_bug.cgi?id=66752
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2012-11-06
Reviewed by Csaba Osztrogonác.
Based on the patch posted by Peter Gal. Attach event listeners
to all input elements we want to enable auto-completions on.
- committers-autocomplete.js:
- 2:15 AM Changeset in webkit [133575] by
-
- 7 edits2 adds in trunk
[Shadow] ShadowRoot should know the existence of elements having ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=100922
Reviewed by Hajime Morita.
Source/WebCore:
We count the elements having ElementShadow in ShadowRoot. This is a prepation patch for to solve Bug 100451.
We have a count-up and count-down login in ShadowRoot::insertedInto and ShadowRoot::removedFrom.
For performance reason, we have a flag that an element should be unregistered in ShadowRoot.
Test: fast/dom/shadow/has-elementshadow.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::insertedInto): Count up the number of elements having ElementShadow. ElementShadow
is created only when the oldest ShadowRoot is created, we only count up only when this ShadowRoot is oldest.
(WebCore):
(WebCore::ShadowRoot::removedFrom): Count down if we used this ShadowRoot for count up.
- dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::ShadowRoot::registerElementShadow):
(WebCore::ShadowRoot::unregisterElementShadow):
(WebCore::ShadowRoot::hasElementShadow):
(WebCore::ShadowRoot::countElementShadow):
- testing/Internals.cpp:
(WebCore::Internals::countElementShadow):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- fast/dom/shadow/has-elementshadow-expected.txt: Added.
- fast/dom/shadow/has-elementshadow.html: Added.
- 2:12 AM Changeset in webkit [133574] by
-
- 11 edits in trunk/Tools
DumpRenderTree should have --pixel-tests option again
https://bugs.webkit.org/show_bug.cgi?id=98648
Reviewed by Dirk Pranke.
Add back the --pixel-tests command line option to DumpRenderTree.
It was removed r124581 because tools don't use it after that patch.
However, it turned out that it is useful for debugging and working
with pixel tests.
- DumpRenderTree/efl/DumpRenderTree.cpp:
(parseCommandLineOptions):
(runTest):
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGlobalsFromCommandLineOptions):
(runTest):
- DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions):
(runTest):
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(isOption):
(printUsage):
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::processLine):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(WebCore::DumpRenderTree::setShouldDumpPixelsForAllTests):
(DumpRenderTree):
- DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):
(dllLauncherEntryPoint):
- DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(runTest):
(MyApp::OnInit):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
(TestController):
- 2:06 AM Changeset in webkit [133573] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: show "debugging session terminated" message when remote debuggign connection is closed unexpectedly.
https://bugs.webkit.org/show_bug.cgi?id=101030
Reviewed by Vsevolod Vlasov.
- inspector/front-end/inspector.js:
(WebInspector.loaded.WebInspector.socket.onclose):
(WebInspector.loaded):
(WebInspector.detached):
- 2:04 AM Changeset in webkit [133572] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Overrides] Add Chrome for Android and Firefox for Android user agent strings
https://bugs.webkit.org/show_bug.cgi?id=100666
Reviewed by Pavel Feldman.
- inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):
- 1:49 AM Changeset in webkit [133571] by
-
- 3 edits in trunk/LayoutTests
[QT] [GTK] Remove fast/forms/week-multiple-fields from TestExpectations of gtk and qt.
https://bugs.webkit.org/show_bug.cgi?id=101317
Unreviewed gardening.
fast/forms/week-multiple-fields is removed by http://trac.webkit.org/changeset/133440.
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-06
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 1:34 AM Changeset in webkit [133570] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] [WK2] Random crash in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=101241
Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.
Do not clear GL context and GL surface in exitAcceleratedCompositing.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):
- 12:49 AM Changeset in webkit [133569] by
-
- 9 edits2 adds in trunk
Web Inspector: JavaScript web workers debugging crashes
https://bugs.webkit.org/show_bug.cgi?id=101065
Reviewed by Alexander Pavlov.
Source/WebCore:
Clear m_pageInspector when page inspector instance is deleted.
Disable worker inspection when front-end disconnects.
Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify
WorkerMessagingProxy so that it can clear pointer to the channel.
LayoutTests:
Test that inspected page won't crash if inspected worker is terminated when it is paused
on a breakpoint.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 12:02 AM Changeset in webkit [133568] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Console: wrap long URLs
https://bugs.webkit.org/show_bug.cgi?id=100970
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-06
Reviewed by Yury Semikhatsky.
- inspector/front-end/inspector.css:
(.console-message-url):
