Timeline



Nov 10, 2012:

10:39 PM Changeset in webkit [134170] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Coalesce main thread scroll position updates
https://bugs.webkit.org/show_bug.cgi?id=101855

Reviewed by Anders Carlsson.

When using threaded scrolling, the dispatched updateMainFrameScrollPosition() calls
from ScrollingTree would pile up on the main thread, and we'd handle several per
runloop cycle when scrolling fast. This causes extra work especially on pages
with position:fixed elements which must update RenderLayers on scrolling.

Fix by using a zero-delay timer in ScrollingCoordinator to coalesce these
scrolling updates to one per runloop.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator): Initialized data members
for the scheduled scroll position update.
(WebCore::ScrollingCoordinator::scheduleUpdateMainFrameScrollPosition): If
the timer is active and the parameters match, just update the target scroll
position and return. If the params don't match, dispatch the scheduled update,
and then the new one. Otherwise, prime the timer.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionTimerFired): Call
the existing updateMainFrameScrollPosition() with the saved values.

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPosition): Call scheduleUpdateMainFrameScrollPosition()
rather than updateMainFrameScrollPosition().

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::syncChildPositions): Fixed a bug that caused fixed
position elements to jiggle with the patch; we should be calling syncPosition() (which just
sets the position data, without touching CA layers).

9:21 PM Changeset in webkit [134169] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition()
https://bugs.webkit.org/show_bug.cgi?id=101514

Reviewed by Tim Horton.

ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition() is very similar to
ScrollingCoordinator::updateMainFrameScrollPosition(). In order to eliminate updateMainFrameScrollPositionAndScrollLayerPosition(),
we just need to plumb through a flag that says that updateMainFrameScrollPosition() should
set the layer position (rather than just doing a 'sync').

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPosition):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollPositionWithoutContentEdgeConstraints):

6:56 PM Changeset in webkit [134168] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

DFG should optimize out the NaN check on loads from double arrays if the array prototype chain is having a great time
https://bugs.webkit.org/show_bug.cgi?id=101718

Reviewed by Geoffrey Garen.

If we're reading from a JSArray in double mode, where the array's structure is
primordial (all aspects of the structure are unchanged except for indexing type),
and the result of the load is used in arithmetic that is known to not distinguish
between NaN and undefined, then we should not emit a NaN check. Looks like a 5%
win on navier-stokes.

Also fixed an OpInfo initialization goof for String ops that was revealed by this
change.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::arraySpeculationToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::isSaneChain):
(ArrayMode):
(JSC::DFG::ArrayMode::isInBounds):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::arrayPrototypeChainIsSane):
(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

4:55 PM Changeset in webkit [134167] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r134069.
http://trac.webkit.org/changeset/134069
https://bugs.webkit.org/show_bug.cgi?id=101852

"It is a wrong way to fix the problem. See discussions in bug
96614" (Requested by 1JTAAPQFJ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-10

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

4:20 PM Changeset in webkit [134166] by mkwst@chromium.org
  • 7 edits in trunk

Web Inspector: Multiple '%c' formatting options should all have effect.
https://bugs.webkit.org/show_bug.cgi?id=101495

Reviewed by Pavel Feldman.

Source/WebCore:

This patch supports multiple '%c' formatting blocks in console messages.
'console.log("%cblue! %cgreen!", "color: blue;", "color: green;")' will
do exactly what you expect: "blue!" will be blue, and "green!" will be
green.

The implementation moves the styles off the message's parent 'span', and
onto new 'span' elements that wrap the various textual bits of the
message.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.):
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):

LayoutTests:

  • http/tests/inspector/console-test.js:

(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithStyles):

We're no longer putting the style directly on the message's
parent, but instead on each section of the message in order to
support multiple styles.

  • inspector/console/console-format-style-expected.txt:
  • inspector/console/console-format-style-whitelist-expected.txt:
  • inspector/console/console-format-style.html:
3:36 PM Changeset in webkit [134165] by mkwst@chromium.org
  • 3 edits in trunk/Source/WebCore

Including <CoreText/CoreText.h> breaks the chromium/mac build.
https://bugs.webkit.org/show_bug.cgi?id=101851

Reviewed by Dan Bernstein.

r134146 introduced inclusion of 'CoreText/CoreText.h' in
SimpleFontDataCoreText.cpp, which broke the chromium/mac build. Grepping
around, it looks like this needs to be modified to include
'ApplicationServices/ApplicationServices.h'.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

Drop 'CoreText.h' in favor of 'ApplicationServices.h'.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

Drop the platform-specific '#if' logic; just include 'ApplicationServices.h'.

3:33 PM Changeset in webkit [134164] by fpizlo@apple.com
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

DFG constant folding and CFG simplification should be smart enough to know that if a logical op's operand is proven to have a non-masquerading structure then it always evaluates to true
https://bugs.webkit.org/show_bug.cgi?id=101511

Reviewed by Geoffrey Garen.

This is the second attempt at this patch, which fixes the !"" case.

To make life easier, this moves BranchDirection into BasicBlock so that after
running the CFA, we always know, for each block, what direction the CFA
proved. CFG simplification now both uses and preserves cfaBranchDirection in
its transformations.

Also made both LogicalNot and Branch check whether the operand is a known cell
with a known structure, and if so, made them do the appropriate folding.

5% speed-up on V8/raytrace because it makes raytrace's own null checks
evaporate (i.e. idioms like 'if (!x) throw "unhappiness"') thanks to the fact
that we were already doing structure check hoisting.

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGBranchDirection.h: Added.

(DFG):
(JSC::DFG::branchDirectionToString):
(JSC::DFG::isKnownDirection):
(JSC::DFG::branchCondition):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

2:35 PM Changeset in webkit [134163] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't detach from shared ElementAttributeData when overwriting attribute with identical value.
<http://webkit.org/b/101849>

Reviewed by Anders Carlsson.

Defer the mutableAttributeData() call in Element::setAttributeInternal() until the last
possible moment, to avoid unnecessarily detaching and cloning from attribute data.

120 kB progression on Membuster3.

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
(WebCore::Element::addAttributeInternal):

1:56 PM Changeset in webkit [134162] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Some minor optimizations in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=101847

Reviewed by Anders Carlsson.

Some minor performance improvements in RenderLayer code.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition): isRenderInline() is a virtual call,
so prefix it with an isInline() check which tests a bit on RenderObject.
(WebCore::RenderLayer::localBoundingBox): Ditto.
(WebCore::RenderLayer::calculateLayerBounds): Pull layer->renderer()
into a local variable.

1:19 PM Changeset in webkit [134161] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Use QLibraryInfo to search for executables.
https://bugs.webkit.org/show_bug.cgi?id=101774

Reviewed by Simon Hausmann.

This allows finding the WebProcess or the PluginProcess
in it's installed location. This is necessary when
deploying QtWebKit with an installer.

  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

11:48 AM Changeset in webkit [134160] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Document::m_fullScreenElementStack should be a Vector
https://bugs.webkit.org/show_bug.cgi?id=101844

Reviewed by Andreas Kling.

m_fullScreenElementStack is currently a Deque where elements are being prepended
and removed from the beginning in LIFO order, so it can be replaced with a Vector.

  • dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):
(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::popFullscreenElementStack):
(WebCore::Document::pushFullscreenElementStack):

  • dom/Document.h:

(WebCore::Document::webkitFullscreenElement):
(Document):

10:25 AM Changeset in webkit [134159] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up header includes and ifdefs in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=101691

Reviewed by Kentaro Hara.

This file doesn't need to include all these headers anymore.

  • bindings/v8/V8GCController.cpp:

(WebCore::workingSetEstimateMBMutex):
(WebCore::V8GCController::majorGCEpilogue):
(WebCore::V8GCController::checkMemoryUsage):

8:11 AM Changeset in webkit [134158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Mac] Guard WebCore PageVisibility Symbol Export
https://bugs.webkit.org/show_bug.cgi?id=101817

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-11-10
Reviewed by Andreas Kling.

Guard the export with the same ENABLE guards around its definition
and implementation.

  • WebCore.exp.in:
7:13 AM Changeset in webkit [134157] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r133971.
http://trac.webkit.org/changeset/133971
https://bugs.webkit.org/show_bug.cgi?id=101839

Causes WebProcess to hang at 100% on www.apple.com (Requested
by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-10

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::branchDirectionToString):
(AbstractState):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGBranchDirection.h: Removed.
  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

6:41 AM Changeset in webkit [134156] by Bruno de Oliveira Abinader
  • 8 edits in trunk

[css] text-decoration:none no longer valid
https://bugs.webkit.org/show_bug.cgi?id=101529

Reviewed by Ojan Vafai.

Source/WebCore:

This patch fixes an issue where the 'none' value was parsed as explicitly
'initial' value. However true in a sense that the initial value for the
'text-decoration' property is 'none', the value itself could not be parsed as
'initial'.

The getComputedStyle layout tests for 'text-decoration' and
'-webkit-text-decoration-line' CSS properties are updated with the correct
results.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTextDecoration): When parsed, 'none' value
gets its own identifier value instead of explicit initial.

LayoutTests:

The getComputedStyle layout tests for 'text-decoration' and
'-webkit-text-decoration-line' CSS properties are updated with the correct
results for the 'none' value.

  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
  • fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt:
  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js:
  • inspector/console/console-format-style-whitelist-expected.txt:
6:29 AM Changeset in webkit [134155] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed. Rebaseline fast/images/color-jpeg-with-color-profile.html on Win.

  • platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.png: Rebaseline.
  • platform/chromium/TestExpectations:

Nov 9, 2012:

11:00 PM Changeset in webkit [134154] by dino@apple.com
  • 13 edits in trunk/Source/WebCore

Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669

Reviewed by Eric Carlson.

Attempt three of commit. The first two times caused build failures on Chromium.

Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670

No new tests - this doesn't expose any testable surface.

  • css/mediaControls.css: Added default rules that hide the new elements.
  • css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create): New track container and list elements created.
(WebCore::MediaControlRootElement::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
(WebCore::MediaControlRootElement::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls): Pass in the controls as a parameter.

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.

  • platform/Language.h:

(WebCore):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart): New enum values into switch.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): New enum values into switch.

10:47 PM Changeset in webkit [134153] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Unreviewed, rolling out r134152.
http://trac.webkit.org/changeset/134152
https://bugs.webkit.org/show_bug.cgi?id=101831

broke chromium again (Requested by dino_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • css/mediaControls.css:
  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls):

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore):

  • platform/Language.h:

(WebCore):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

10:23 PM Changeset in webkit [134152] by dino@apple.com
  • 13 edits in trunk/Source/WebCore

Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669

Reviewed by Eric Carlson.

Attempt two of commit. The first time caused a build failure on Chromium.

Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670

No new tests - this doesn't expose any testable surface.

  • css/mediaControls.css: Added default rules that hide the new elements.
  • css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create): New track container and list elements created.
(WebCore::MediaControlRootElement::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
(WebCore::MediaControlRootElement::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls): Pass in the controls as a parameter.

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.

  • platform/Language.h:

(WebCore):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart): New enum values into switch.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): New enum values into switch.

9:54 PM Changeset in webkit [134151] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

If the DFG ArrayMode says that an access is on an OriginalArray, then the checks should always enforce this
https://bugs.webkit.org/show_bug.cgi?id=101720

Reviewed by Mark Hahnenberg.

Previously, "original" arrays was just a hint that we could find the structure
of the array if we needed to even if the array profile didn't have it due to
polymorphism. Now, "original" arrays are a property that is actually checked:
if an array access has ArrayMode::arrayClass() == Array::OriginalArray, then we
can be sure that the code performing the access is dealing with not just a
JSArray, but a JSArray that has no named properties, no indexed accessors, and
the ArrayPrototype as its prototype. This will be useful for optimizations that
are being done as part of https://bugs.webkit.org/show_bug.cgi?id=101720.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::originalArrayStructure):
(DFG):
(JSC::DFG::ArrayMode::alreadyChecked):

  • dfg/DFGArrayMode.h:

(JSC):
(DFG):
(JSC::DFG::ArrayMode::withProfile):
(ArrayMode):
(JSC::DFG::ArrayMode::benefitsFromOriginalArray):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::checkArray):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):

9:16 PM Changeset in webkit [134150] by ojan@chromium.org
  • 6 edits
    2 adds in trunk

Should only fire a single set of mouse events and update hover state once when scrolling is done
https://bugs.webkit.org/show_bug.cgi?id=99940

Reviewed by Levi Weintraub.

Source/WebCore:

-Use a DeferrableOneShotTimer instead of a Timer. By resetting when the
timer is fired, we ensure the actual goal of not firing fake mouse events
until the scroll is completed. This is the core part of this change.
-Change our mouse event throttling to keep a running average of how long
mouse events take and adjust throttling appropriately.
Test: fast/scrolling/fake-mouse-event-throttling.html
-Maintain a minimum throttle of 100ms.

  • page/EventHandler.cpp:

(WebCore):
(WebCore::RunningAverageDurationTracker::RunningAverageDurationTracker):
(WebCore::RunningAverageDurationTracker::~RunningAverageDurationTracker):
Keep track of a running average instead of max. This lets us adjust throttling
dynamically without punishing a page for having a single mouse event handler
that takes disproportionately long.
(RunningAverageDurationTracker):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/EventHandler.h:

(EventHandler):

  • platform/Timer.h:

(WebCore::DeferrableOneShotTimer::setDelay):
(WebCore::DeferrableOneShotTimer::delay):
Add a way of adjusting the timer delay.

LayoutTests:

Tests basic throttling. I couldn't think of a good way to test changing
the delay that wouldn't make for a test that takes minutes to run.

  • fast/scrolling/fake-mouse-event-throttling-expected.txt: Added.
  • fast/scrolling/fake-mouse-event-throttling.html: Added.
9:12 PM Changeset in webkit [134149] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

Source/WebCore: Move chromium to USE(LAZY_NATIVE_CURSOR)
https://bugs.webkit.org/show_bug.cgi?id=101501

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

This simplifies cursor handling in chromium and unifies it with other
ports for easier code sharing and testing by moving to the
USE_LAZY_CURSOR model and eliminating PlatformCursor entirely.

PlatformCursor adds no value in chromium since the sandboxing model
requires the cursor information be marshalled to the browser process
before being turned into a real OS cursor.

Test: fast/events/mouse-cursor.html

  • WebCore.gypi:
  • platform/Cursor.h:

(WebCore):

  • platform/chromium/CursorChromium.cpp:

(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::ensurePlatformCursor):

  • platform/chromium/PlatformCursor.h: Removed.

Source/WebKit/chromium: Move chromium to USE(LAZY_NATIVE_CURSOR)
https://bugs.webkit.org/show_bug.cgi?id=101501

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

Update conversion from Cursor to WebCursorInfo to remove the
intermediate (and useless) step of PlatformCursor.

  • src/AssertMatchingEnums.cpp:
  • src/WebCursorInfo.cpp:

(WebKit::WebCursorInfo::WebCursorInfo):

LayoutTests: [chromium] Move to USE(LAZY_NATIVE_CURSOR)
https://bugs.webkit.org/show_bug.cgi?id=101501

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

Remove failure expectation for fast/events/mouse-cursor.html now that
chromium uses the same cursor architecture as other ports.

  • platform/chromium/TestExpectations:
9:05 PM Changeset in webkit [134148] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit2

Coordinated Graphics: Rename tileRect from targetRect.
https://bugs.webkit.org/show_bug.cgi?id=101705

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Messages::LayerTreeCoordinatorProxy::CreateTileForLayer contains the targetRect
variable. The targetRect stands for the rect of the tile created. This patch
renames tileRect to enhance the clearity.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::swapBuffers):
(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStoreTile):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::updateTile):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(TileUpdate):
(WebKit::LayerTreeRenderer::TileUpdate::TileUpdate):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:

(CoordinatedTileClient):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

8:49 PM Changeset in webkit [134147] by noam.rosenthal@nokia.com
  • 6 edits in trunk/Source

Allow ports to decide whether an image should be directly composited
https://bugs.webkit.org/show_bug.cgi?id=101827

Reviewed by Simon Fraser.

Source/WebCore:

Tested by compositing/tiling/huge-layer-img.html.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::shouldDirectlyCompositeImage):

Allow the GraphicsLayer implementation to decide if the image can be composited.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

Take onto account the new shouldDirectlyCompositeImage check.

Source/WebKit2:

Implement shouldDirectlyCompositeImage for coordinated graphics, effectively disabling direct
compositing of images with width or height larger than 2000 pixels.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::shouldDirectlyCompositeImage):
(WebCore):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

7:34 PM Changeset in webkit [134146] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

SimpleFontData::getCFStringAttributes sets some attributes to their default values, but shouldn’t
https://bugs.webkit.org/show_bug.cgi?id=101799

Reviewed by Alexey Proskuryakov.

In some configurations, setting kCTLigatureAttributeName to its default value of 1 yields
different behavior from not setting it at all. We can get the correct behavior and greatly
simplify the code by not setting attributes to their default values.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

Removed redundant #import directives and changed the remaining ones to #include.
(WebCore::SimpleFontData::getCFStringAttributes): Changed to use a mutable dictionary and
only add attributes that have non-default values.

6:54 PM Changeset in webkit [134145] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Antialias the edge-tiles of CoordinatedBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=101818

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Since we now have the entire surfaceRect, we can antialias the edge-tiles.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::paintTilesToTextureMapper):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

6:45 PM Changeset in webkit [134144] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

No tests for changing mouse cursors
https://bugs.webkit.org/show_bug.cgi?id=100550

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

.:

Add necessary exports for Internals::getCurrentCursorInfo

  • Source/autotools/symbols.filter:

Source/WebCore:

Add infrastructure to keep track of the last set mouse cursor,
and then to query it from DumpRenderTree.

Test: fast/events/mouse-cursor.html

  • WebCore.exp.in: Add Cursor copy ctor export
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseMoveEvent): Keep track of last set mouse cursor

  • page/EventHandler.h:

(WebCore::EventHandler::currentMouseCursor): New getter for last set mouse cursor

  • testing/Internals.cpp:

(WebCore::cursorTypeToString): Helper to convert cursor type to enum
(WebCore):
(WebCore::Internals::getCurrentCursorInfo): New function to return a string describing the last set mouse cursor

  • testing/Internals.h: Declare getCurrentCursorInfo
  • testing/Internals.idl: Declare getCurrentCursorInfo

Source/WebKit2:

Add necessary exports for Internals::getCurrentCursorInfo

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Add a simple test covering the basic scenarios of changing a mouse
cursor with CSS. This includes most of the cases currently covered
by ManualTests/*cursor*.

  • fast/events/mouse-cursor-expected.txt: Added.
  • fast/events/mouse-cursor.html: Added.
  • platform/chromium/TestExpectations: Add failure expectation.
6:42 PM Changeset in webkit [134143] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Add missing exports setMediaTypeOverride, setResolutionOverride and layerTreeAsText to WebKit2CFLite.def
https://bugs.webkit.org/show_bug.cgi?id=101816

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-11-09
Reviewed by Anders Carlsson.

Add missing exports setMediaTypeOverride, setResolutionOverride and layerTreeAsText to WebKit2CFLite.def to fix win-cairo build.

  • win/WebKit2CFLite.def:
6:32 PM Changeset in webkit [134142] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Coordinated Graphics: Amend CoordinatedBackingStore::paintToTextureMapper to fit its own semantic.
https://bugs.webkit.org/show_bug.cgi?id=101701

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Source/WebCore:

Add TiledBackingStore::rect() because CoordinatedTile needs to know
m_rect of TiledBackingStore.

  • platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::rect):

Source/WebKit2:

Currently, all subclasses of TextureMapperPlatformLayer implement
paintToTextureMapper to draw its own texture on the given targetRect. Subclasses
can scale the texture to fit the size of the targetRect. However, only
CoordinatedBackingStore::paintToTextureMapper draws its texture using its own
texture size. There is no bug yet, because TextureMapperLayer uses
CoordinatedBackingStore only as a backing store, not a content layer. So,
TextureMapperLayer always request CoordinatedBackingStore to draw using its own
texture size. However, we can use CoordinatedBackingStore as a content layer in
the future. So this patch fixes this potential bug.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::setSize):
(WebKit):
(WebKit::mapToContents):
(WebKit::paintTilesToTextureMapper):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createTile):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createTile):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:

(WebKit::CoordinatedTile::updateBackBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:

(CoordinatedTileClient):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createTile):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

6:07 PM Changeset in webkit [134141] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r134139.
http://trac.webkit.org/changeset/134139
https://bugs.webkit.org/show_bug.cgi?id=101823

breaks chromium (android) build (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • css/mediaControls.css:
  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls):

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore):

  • platform/Language.h:

(WebCore):

5:46 PM Changeset in webkit [134140] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap] Initialize m_compositedNativeImagePtr in GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=101675

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Fix a potential bug in GraphicsLayerTextureMapper. If the member's uninitialized
value equals image->nativeImageForCurrentFrame() by change, we can encounter
undefined behavior.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):

5:44 PM Changeset in webkit [134139] by dino@apple.com
  • 11 edits in trunk/Source/WebCore

Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669

Reviewed by Eric Carlson.

Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670

No new tests - this doesn't expose any testable surface.

  • css/mediaControls.css: Added default rules that hide the new elements.
  • css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create): New track container and list elements created.
(WebCore::MediaControlRootElement::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
(WebCore::MediaControlRootElement::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls): Pass in the controls as a parameter.

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.

  • platform/Language.h:

(WebCore):

5:26 PM Changeset in webkit [134138] by noel.gordon@gmail.com
  • 4 edits
    2 adds in trunk

[chromium] Should pass fast/images/paletted-png-with-color-profile.html
https://bugs.webkit.org/show_bug.cgi?id=101551

Reviewed by Adam Barth.

Source/WebCore:

Support decoding color PALETTE images that have an ICC color profile.

Covered by fast/images/png-suite/test.html and many other fast/image tests.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::headerAvailable): Move the color profile code after the
transparency (tRNS) reader. Allow color PNG images: RGB, RGBA, PALLETE to be color
corrected. Use the transparency count from the tRNS reader to detect the expansion
of RGB and PALLETE image pixels to RGBA.

LayoutTests:

Update fast/images/paletted-png-with-color-profile.html image results for
Mac and Win (Chromium Android and Linux don't support color profiles).

  • platform/chromium-mac/fast/images/paletted-png-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/paletted-png-with-color-profile-expected.png: Added.
  • platform/chromium/TestExpectations:
4:53 PM Changeset in webkit [134137] by beidson@apple.com
  • 11 edits in trunk/Source/WebKit2

Implement NetworkProcess willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=101812

Reviewed by Alexey Proskuryakov.

Message to the WebProcess to get the new request, if any.

Because network callbacks are coming in on a background thread we have to jump through hoops to synchronously
ask the WebProcess, but these hoops follow an established pattern of using async messaging with BlockingResourceMap.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::willSendRequestHandled): Pass the new request back to NetworkRequest for handling.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkRequest.cpp:

(WebKit::NetworkRequest::didFail):
(WebKit::responseMap):
(WebKit::generateWillSendRequestID):
(WebKit::didReceiveWillSendRequestHandled):
(WebKit::NetworkRequest::willSendRequest): Asynchronously message the WebProcess but synchronous wait for a reply back.

  • NetworkProcess/NetworkRequest.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::willSendRequest): Ask the WebResourceLoadScheduler for the new request then

message back to the NetworkProcess with the reply.

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::willSendRequest):

  • WebProcess/Network/WebResourceLoadScheduler.h:
4:46 PM Changeset in webkit [134136] by jsbell@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. One more baseline following 134112.

  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
4:16 PM Changeset in webkit [134135] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Correct hit-test point scaling for document.elementFromPoint
https://bugs.webkit.org/show_bug.cgi?id=101798

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

The hit-test point come from user JavaScript is in the document coordinate.
Convert to the frame coordinate with correct scale factor for hit test.

Source/WebCore:

Test: fast/dom/elementFromPoint-scaled-scrolled.html

  • dom/Document.cpp:

(WebCore::nodeFromPoint):

LayoutTests:

  • fast/dom/elementFromPoint-scaled-scrolled-expected.txt: Added.
  • fast/dom/elementFromPoint-scaled-scrolled.html: Added.
4:15 PM Changeset in webkit [134134] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BooleanPrototype.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BooleanPrototype.h:
4:14 PM Changeset in webkit [134133] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BooleanObject.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BooleanObject.h:
4:12 PM Changeset in webkit [134132] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] More gardening.

media/video-seek-past-end-playing.html is still flaky on WK2, skip
it on both WK1 and WK2.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
4:09 PM Changeset in webkit [134131] by timothy_horton@apple.com
  • 13 edits in trunk/Source/WebKit2

PDFPlugin should support clicking on external links
https://bugs.webkit.org/show_bug.cgi?id=101647
<rdar://problem/12555222>

Reviewed by Alexey Proskuryakov.

  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add details about clickedLinkWithURL: callback.
  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add clickedLink() and storage for the last mouse event that was dispatched.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate pdfLayerController:clickedLinkWithURL:]): Forward the URL to PDFPlugin.
(WebKit::PDFPlugin::handleMouseEvent): Store the last mouse event that was dispatched.
We use this to get the correct mouse button and modifier keys, so that command-clicking, etc. links works.
(WebKit::PDFPlugin::clickedLink): Request a load given the new URL.

  • PluginProcess/PluginControllerProxy.h:

(PluginControllerProxy):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::shouldAllowScripting):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::shouldAllowScripting):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::shouldAllowScripting):

  • WebProcess/Plugins/PluginView.h:

Add shouldAllowScripting() function to Plugin (and plumb through PluginProxy and PluginView, etc.)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::allowScript): Override allowScript(); if the frame is hosting a PluginDocument,
ask its plugin whether it should allow execution of JavaScript and JavaScript URLs or not.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/Plugins/PDF/SimplePDFPlugin.h: Disable scripting for SimplePDFPlugin (and, by inheritance, PDFPlugin).
4:07 PM Changeset in webkit [134130] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Skip fast/canvas/canvas-resize-reset-pixelRatio.html since
HIGH_DPI_CANVAS is disabled by default.

  • platform/efl/TestExpectations:
4:01 PM Changeset in webkit [134129] by alecflett@chromium.org
  • 11 edits
    1 delete in trunk/Source

IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101415

Reviewed by Tony Chang.

Source/WebCore:

Combine abstract interface IDBBackingStore with its only
implementation, IDBLevelDBBackingStore, to reduce code
complexity. The legacy structure existed to support a SQLLite
IDBBackingStore, but it is no longer worth the complexity to
support this abstraction.

Changes include:
1) Merging IDBLevelDBBackingStore into IDBBackingStore.

2) Merge together IDBBackingStore's inner classes: Cursor,
Transaction, and ObjectStoreRecordIdentfier with their respective
subclasses in IDBLevelDBBackingStore.

3) Simplifying the inner Transaction class to not be refcounted or
virtualized, to allow it to be a simple concrete member of its
owner, IDBTransactionBackendImpl.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::recordInternalError):
(WebCore::setUpMetadata):
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::getDatabaseNames):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange):
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::setMaxIndexId):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::firstSeek):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Cursor::haveEnteredRange):
(WebCore::IDBBackingStore::Cursor::isPastBounds):
(WebCore::ObjectStoreKeyCursorImpl::create):
(ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::value):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::create):
(ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::value):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::create):
(IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::value):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::create):
(IndexCursorImpl):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(IDBBackingStore):
(RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::create):
(WebCore::IDBBackingStore::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::isValid):
(WebCore::IDBBackingStore::RecordIdentifier::primaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::setPrimaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::version):
(WebCore::IDBBackingStore::RecordIdentifier::setVersion):
(WebCore::IDBBackingStore::RecordIdentifier::RecordIdentifier):
(Transaction):
(WebCore::IDBBackingStore::Transaction::levelDBTransactionFrom):
(CursorOptions):
(Cursor):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::key):
(WebCore::IDBBackingStore::Cursor::primaryKey):
(WebCore::IDBBackingStore::Cursor::~Cursor):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::countInternal):

  • Modules/indexeddb/IDBLevelDBBackingStore.h: Removed.
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove method that is no longer in the base class.

  • tests/IDBFakeBackingStore.h:
3:55 PM Changeset in webkit [134128] by Lucas Forschler
  • 5 edits in branches/safari-536.28-branch

Merged r132427. <rdar://problem/12589196>

3:54 PM Changeset in webkit [134127] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Correct scroll adjustment for touchEvent.clientX/clientY
https://bugs.webkit.org/show_bug.cgi?id=101800

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

FrameView::scrollX/scrollY returns scroll offset in (scaled) frame coordinate.
Convert to document coordinate before passing to JavaScript.

Source/WebCore:

Test: fast/events/touch/touch-scaled-scrolled.html

  • dom/Touch.cpp:

(WebCore::contentsX):
(WebCore::contentsY):

LayoutTests:

  • fast/events/touch/touch-scaled-scrolled-expected.txt: Added.
  • fast/events/touch/touch-scaled-scrolled.html: Added.
3:52 PM Changeset in webkit [134126] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch/Source/WebCore

Merged r131939. <rdar://problem/12589196>

3:49 PM Changeset in webkit [134125] by Alexandru Chiculita
  • 7 edits
    3 adds in trunk

[Texmap][CSS Shaders] Enable CSS Shaders in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=98990

Reviewed by Noam Rosenthal.

Source/WebCore:

Added code that draws the Custom Filter in the TextureMapperGL. Also added
required code to make a depth buffer for a BitmapTextureGL.

Note that the code is not optimized yet, so it will always recompile the shader.

Test: css3/filters/custom/composited/custom-filter-blend-modes.html

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::getPassesRequiredForFilter):
(WebCore):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::BitmapTextureGL::applyFilters):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::~BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

LayoutTests:

Copied the custom-filter-blend-modes.html test file and forced the filtered elements to have
composited layers using 3d transforms.

  • css3/filters/custom/composited/custom-filter-blend-modes-expected.html: Added.
  • css3/filters/custom/composited/custom-filter-blend-modes.html: Added.
  • platform/qt-4.8/TestExpectations: Only Qt-Wk2 can currently run the shaders.
  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/TestExpectations: Added a couple of tests that are not passing currently.

I've added 101531 to track those.

3:46 PM Changeset in webkit [134124] by jsbell@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. A few more baselines following 134112.

  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/reflection-opacity-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/clip-content-under-overflow-controls-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/reflection-opacity-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/newly-composited-on-scroll-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
3:40 PM Changeset in webkit [134123] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Widen cross-fade-invalidation expectation to include all platforms.

  • platform/chromium/TestExpectations:
3:37 PM Changeset in webkit [134122] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip fast/dom/navigator-vibration.html after r133828.

  • platform/efl-wk2/TestExpectations:
3:36 PM Changeset in webkit [134121] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch/Source/WebCore

Merge r130236. <rdar://problem/12589196>

3:27 PM Changeset in webkit [134120] by commit-queue@webkit.org
  • 7 edits
    1 copy in trunk/Source/WebCore

CustomEvent: Allow taking in a serialized value during initialization.
https://bugs.webkit.org/show_bug.cgi?id=101348

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

If a CustomEvent is initialized using a serialized value, then for each access
to |detail|, the value is deserialized first. This way, each world gets a different
deserialization.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8CustomEventCustom.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(WebCore):
(WebCore::V8CustomEvent::detailAccessorGetter):

  • dom/CustomEvent.cpp:

(WebCore::CustomEvent::initCustomEvent):
(WebCore):

  • dom/CustomEvent.h:

(CustomEvent):
(WebCore::CustomEvent::serializedScriptValue):

  • dom/CustomEvent.idl:
3:25 PM Changeset in webkit [134119] by beidson@apple.com
  • 5 edits in trunk/Source

Implement WebResourceBuffer::isEmpty()
https://bugs.webkit.org/show_bug.cgi?id=101805

Reviewed by Alexey Proskuryakov.

This is required to make the existing subresource loading in NetworkProcess work correctly,
as there's an isEmpty() check in the WebProcess that decides whether or not to actually deliver
the data to the ResourceLoader.

Source/WebCore:

No new tests (No change in behavior in any configuration we test.)

  • loader/ResourceBuffer.h: Make isEmpty() virtual.

Source/WebKit2:

  • Shared/WebResourceBuffer.cpp:

(WebKit::WebResourceBuffer::isEmpty):

  • Shared/WebResourceBuffer.h:
2:36 PM Changeset in webkit [134118] by Lucas Forschler
  • 3 edits in branches/safari-536.28-branch/Source/JavaScriptCore

Merged r126624. <rdar://problem/12486145>

2:33 PM Changeset in webkit [134117] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adding a sound to touch events on anchor elements
https://bugs.webkit.org/show_bug.cgi?id=101655

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-09
Reviewed by Antonio Gomes.

Adding audio feedback to touchevents on html anchor elements.

The feedback is called directly from client instead of using the
mouseup event to avoid the delay between touch start and end caused
by the tap sequence recognizer.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::playSoundIfAnchorIsTarget):
(WebKit):

  • Api/WebPage.h:
  • WebKitSupport/TouchEventHandler.cpp:

(WebKit):
(BlackBerry::WebKit::TouchEventHandler::playSoundIfAnchorIsTarget):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

2:32 PM Changeset in webkit [134116] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

HTML Attributes names and values should be created as 8 bit string where possible
https://bugs.webkit.org/show_bug.cgi?id=101781

Reviewed by Filip Pizlo.

Given that almost all attribute names and values are lower case ASCII, we should try to
create 8 bit strings to process them. Creating an AtomicString already tries to make
an 8 bit string, so that didn't need to change.

No new tests, functionality covered by existing tests.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::processTagToken):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::processMeta):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::PreloadTask::processAttributes):

2:31 PM Changeset in webkit [134115] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Updated expectations following 134112.

  • platform/chromium/TestExpectations:
2:28 PM Changeset in webkit [134114] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BooleanConstructor.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BooleanConstructor.h:
2:27 PM Changeset in webkit [134113] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BatchedTransitionOptimizer.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BatchedTransitionOptimizer.h:
2:22 PM Changeset in webkit [134112] by enne@google.com
  • 2 edits
    1 move
    160 adds in trunk/LayoutTests

[chromium] Rebaselining software compositor tests.

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-09
Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-09
Reviewed by Adrienne Walker.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/chromium-android/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/scrollbar-painting-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium/TestExpectations:
2:07 PM Changeset in webkit [134111] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Define WEBKIT_IMPLEMENTATION everywhere inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=101795

Reviewed by James Robinson.

  • WebCore.gyp/WebCore.gyp:
2:00 PM Changeset in webkit [134110] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening, failing new hidpi tests in r134099/r134100

  • platform/chromium/TestExpectations:
1:53 PM Changeset in webkit [134109] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r126490. <rdar://problem/12516330>

1:53 PM Changeset in webkit [134108] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, last few chromium-mac-mountainlion expectations cleaned up.

  • platform/chromium/TestExpectations:
1:50 PM Changeset in webkit [134107] by Lucas Forschler
  • 4 edits
    2 adds in branches/safari-536.28-branch

Merged r1164161. WebKit r126251. <rdar://problem/12536470>

1:43 PM Changeset in webkit [134106] by Lucas Forschler
  • 11 edits in branches/safari-536.28-branch/Source/WebCore

Merged r1164159. WebKit r126048. <rdar://problem/12536470>

1:42 PM Changeset in webkit [134105] by jsbell@chromium.org
  • 11 edits
    1 copy in trunk/Source

Unreviewed, rolling out r134101.
http://trac.webkit.org/changeset/134101
https://bugs.webkit.org/show_bug.cgi?id=101790

IDBDatabaseBackendTest.BackingStoreRetention failing
(Requested by jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier):
(WebCore::IDBLevelDBBackingStore::deleteRecord):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::createTransaction):
(WebCore::IDBLevelDBBackingStore::Transaction::create):
(WebCore::IDBLevelDBBackingStore::Transaction::Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::begin):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):
(WebCore::IDBLevelDBBackingStore::backingStoreExists):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(IDBBackingStore):
(RecordIdentifier):
(WebCore::IDBBackingStore::Cursor::~Cursor):
(WebCore::IDBBackingStore::Transaction::~Transaction):
(Transaction):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBLevelDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBBackingStore.h.

(WebCore):
(IDBLevelDBBackingStore):
(Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransactionFrom):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

  • tests/IDBFakeBackingStore.h:
1:29 PM Changeset in webkit [134104] by dpranke@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed, baselines change - remove stray baselines for reftests.

  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-layer-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-surface-expected.png: Removed.
1:25 PM Changeset in webkit [134103] by Lucas Forschler
  • 10 edits in branches/safari-536.28-branch/Source/WebCore

Merged r1164158. WebKit r125737. <rdar://problem/12536470>

12:54 PM Changeset in webkit [134102] by arv@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION (r125239): classList contains() doesn't work after element was moved from strict mode document to quirks mode document
https://bugs.webkit.org/show_bug.cgi?id=101627

Reviewed by Alexey Proskuryakov.

We used to only create m_classNamesForQuirksMode in the constructor or when the class attribute
was changed. If an element is moved from a standards document to a quirks mode document the
m_classNamesForQuirksMode would not be up to date which lead to wrong results.

Now we alway check if m_classNamesForQuirksMode is up to date (in quirks mode only).

Source/WebCore:

Test: fast/dom/Element/class-list-move-between-document-with-different-quirks-mode.html

  • html/ClassList.cpp:

(WebCore::ClassList::classNames): Create the m_classNamesForQuirksMode lazily as needed so that

it is up to date.

  • html/ClassList.h:

LayoutTests:

  • fast/dom/Element/class-list-move-between-document-with-different-quirks-mode-expected.txt: Added.
  • fast/dom/Element/class-list-move-between-document-with-different-quirks-mode.html: Added.
12:47 PM Changeset in webkit [134101] by alecflett@chromium.org
  • 11 edits
    1 delete in trunk/Source

IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101415

Reviewed by Tony Chang.

Source/WebCore:

Combine abstract interface IDBBackingStore with its only
implementation, IDBLevelDBBackingStore, to reduce code
complexity. The legacy structure existed to support a SQLLite
IDBBackingStore, but it is no longer worth the complexity to
support this abstraction.

Changes include:
1) Merging IDBLevelDBBackingStore into IDBBackingStore.

2) Merge together IDBBackingStore's inner classes: Cursor,
Transaction, and ObjectStoreRecordIdentfier with their respective
subclasses in IDBLevelDBBackingStore.

3) Simplifying the inner Transaction class to not be refcounted or
virtualized, to allow it to be a simple concrete member of its
owner, IDBTransactionBackendImpl.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::recordInternalError):
(WebCore::setUpMetadata):
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::getDatabaseNames):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange):
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::setMaxIndexId):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::firstSeek):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Cursor::haveEnteredRange):
(WebCore::IDBBackingStore::Cursor::isPastBounds):
(WebCore::ObjectStoreKeyCursorImpl::create):
(ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::value):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::create):
(ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::value):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::create):
(IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::value):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::create):
(IndexCursorImpl):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(IDBBackingStore):
(RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::create):
(WebCore::IDBBackingStore::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::isValid):
(WebCore::IDBBackingStore::RecordIdentifier::primaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::setPrimaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::version):
(WebCore::IDBBackingStore::RecordIdentifier::setVersion):
(WebCore::IDBBackingStore::RecordIdentifier::RecordIdentifier):
(Transaction):
(WebCore::IDBBackingStore::Transaction::levelDBTransactionFrom):
(CursorOptions):
(Cursor):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::key):
(WebCore::IDBBackingStore::Cursor::primaryKey):
(WebCore::IDBBackingStore::Cursor::~Cursor):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::countInternal):

  • Modules/indexeddb/IDBLevelDBBackingStore.h: Removed.
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove method that is no longer in the base class.

  • tests/IDBFakeBackingStore.h:
12:39 PM Changeset in webkit [134100] by timothy@apple.com
  • 10 edits
    3 adds in trunk

Source/WebCore: Make -webkit-canvas in CSS use the full backing store instead
of always 1x when rendering.

https://bugs.webkit.org/show_bug.cgi?id=100611

Reviewed by Dean Jackson.

Test: fast/canvas/canvas-as-image-hidpi.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::makePresentationCopy): Pass Unscaled to copyImage.
(WebCore::HTMLCanvasElement::copiedImage): Ditto.

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::copyImage): Added Scale parameter and use copyNativeImage for Unscaled.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::copyImage): Added unnamed ScaleBehavior parameter.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

LayoutTests: Test if -webkit-canvas in CSS uses the full backing store instead
of always 1x when rendering.

https://bugs.webkit.org/show_bug.cgi?id=100611

Reviewed by Dean Jackson.

  • fast/canvas/canvas-as-image-hidpi-expected.png: Added.
  • fast/canvas/canvas-as-image-hidpi-expected.txt: Added.
  • fast/canvas/canvas-as-image-hidpi.html: Added.
12:39 PM Changeset in webkit [134099] by timothy@apple.com
  • 4 edits
    2 adds in trunk

Source/WebCore: Reset the canvas backing store pixel ratio when the buffer resizes.

The backing store was not being recreated using the current page pixel ratio
when a resize occurred.

https://bugs.webkit.org/show_bug.cgi?id=100608

Reviewed by Darin Adler.

Test: fast/canvas/canvas-resize-reset-pixelRatio.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Use targetDeviceScaleFactor.
(WebCore::HTMLCanvasElement::reset): Do a clear only if the pixel ratios also
match. Store the new pixel ratio in m_deviceScaleFactor.
(WebCore::HTMLCanvasElement::targetDeviceScaleFactor): Added.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::setSize): Return early only if the sizes and
pixel ratios match.

LayoutTests: Test the canvas backing store pixel ratio when the buffer resizes.

https://bugs.webkit.org/show_bug.cgi?id=100608

Reviewed by Darin Adler.

  • fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Added.
  • fast/canvas/canvas-resize-reset-pixelRatio.html: Added.
12:30 PM Changeset in webkit [134098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Fixed layers are shaking when scrolling
https://bugs.webkit.org/show_bug.cgi?id=101549

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

At the time of adjusting positions for fixed layers, the locations of
fixed layers are calculated incorrectly because the contentsSize is empty.

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize): Call the
setContentsSize function in LayerTreeCoordinatorProxy in order to calculate
the locations of fixed layers correctly.

12:16 PM Changeset in webkit [134097] by rniwa@webkit.org
  • 2 edits in trunk/Tools

People with dichromacy can't tell crashes and passes on flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=101711

Reviewed by Ojan Vafai.

Lower the brightness of orange, and raise the brightness of green so that
people with color blindnes can still distinguish passes and crashes easily.

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.css:

(.P):
(.C):

12:10 PM Changeset in webkit [134096] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

RemoveFormat command doesn't remove background color
https://bugs.webkit.org/show_bug.cgi?id=101682

Reviewed by Tony Chang.

Source/WebCore:

Fixed the bug by removing all non-transparent background-color properties.

Test: editing/execCommand/remove-format-background-color.html

  • editing/RemoveFormatCommand.cpp:

(WebCore::RemoveFormatCommand::doApply):

LayoutTests:

Added a regression test.

  • editing/execCommand/remove-format-background-color-expected.txt: Added.
  • editing/execCommand/remove-format-background-color.html: Added.
11:55 AM Changeset in webkit [134095] by alecflett@chromium.org
  • 32 edits in trunk/Source

IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

  • src/IDBObjectStoreBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

11:47 AM Changeset in webkit [134094] by mario@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Isolate the GTK/Gail/Pango specific code in accessibility/gtk
https://bugs.webkit.org/show_bug.cgi?id=101727

Reviewed by Chris Fleizach.

Added conditional compilation checks for GTK+ specific
accessibility code, to pave the way for sharing this
implementation with other ports (e.g WebKitEFL).

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetTextAfterOffset): Added conditional
compilation checks, only implementing it in GTK so far.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkParentOfRootObject): Added conditional compilation checks,
only implementing in GTK the part of getting the accessible object
for the root object.
(webkitAccessibleGetParent): Updated comments.
(webkitAccessibleGetNChildren): Ditto.
(webkitAccessibleRefChild): Ditto.
(webkitAccessibleGetIndexInParent): Ditto.
(webkitAccessibleGetAttributes): Only set the 'toolkit' attribute
for GTK. Other ports might be interested in this too.
(setAtkStateSetFromCoreObject): Updated comments.

11:39 AM Changeset in webkit [134093] by tommyw@google.com
  • 2 edits in trunk/Source/WebCore

MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
https://bugs.webkit.org/show_bug.cgi?id=101586

Reviewed by Adam Barth.

Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when
ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new
API some WebCore objects might be cleaned away which is not allowed at this stage.

This behaviour is not possible to test unfortunately in webkit.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::stop):

11:32 AM Changeset in webkit [134092] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-11-09 Oliver Hunt <oliver@apple.com>

So Thingy probably isn't the best name for a class, so
renamed to CacheMap.

RS=Geoff

  • runtime/CodeCache.h: (JSC::CacheMap::CacheMap):
11:27 AM Changeset in webkit [134091] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed gardening. Fix chromium-win builds following r134082

  • WebCore.gypi:
11:15 AM Changeset in webkit [134090] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

NetworkRequest refactoring
https://bugs.webkit.org/show_bug.cgi?id=101777

Reviewed by Alexey Proskuryakov.

Move all of the ResourceHandleClient stubs from the .h to the .cpp in one patch
to make future patches cleaner.

Also completely remove the declaration for shouldCacheResponse() for now.

  • NetworkProcess/NetworkRequest.cpp:

(WebKit::NetworkRequest::willSendRequest):
(WebKit::NetworkRequest::didSendData):
(WebKit::NetworkRequest::didReceiveCachedMetadata):
(WebKit::NetworkRequest::wasBlocked):
(WebKit::NetworkRequest::cannotShowURL):
(WebKit::NetworkRequest::willCacheResponse):
(WebKit::NetworkRequest::shouldUseCredentialStorage):
(WebKit::NetworkRequest::didReceiveAuthenticationChallenge):
(WebKit::NetworkRequest::didCancelAuthenticationChallenge):
(WebKit::NetworkRequest::receivedCancellation):
(WebKit::NetworkRequest::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkRequest::supportsDataArray):
(WebKit::NetworkRequest::didReceiveDataArray):
(WebKit::NetworkRequest::willStopBufferingData):
(WebKit::NetworkRequest::createAsyncFileStream):

  • NetworkProcess/NetworkRequest.h:
11:10 AM Changeset in webkit [134089] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

[V8] Remove ScriptController::windowShell()
https://bugs.webkit.org/show_bug.cgi?id=100235

Patch by Dan Carney <dcarney@google.com> on 2012-11-09
Reviewed by Adam Barth.

Refactored windowShell(DOMWrapperWorld*) and
existingWindowShell(DOMWrapperWorld*) to be like JSC.

No new tests. No change in functionality.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldMap):
(WebCore::DOMWrapperWorld::getAllWorlds):
(WebCore):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearForOutOfMemory):
(WebCore):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::updateSecurityOrigin):
(WebCore::ScriptController::initializeMainWorld): Returns true if the main world was initialized.
(WebCore::existingWindowShellWorkaroundWorld):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::mainWorldContext):
(WebCore::ScriptController::haveInterpreter):
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::namedItemAdded):
(WebCore::ScriptController::namedItemRemoved):

  • bindings/v8/ScriptController.h:

(ScriptController):
(WebCore::ScriptController::getAllWorlds):

  • bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):
(WebCore::handleOutOfMemory):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::updateDocument):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):

  • bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::isContextInitialized):
(WebCore::V8DOMWindowShell::isGlobalInitialized):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

11:07 AM Changeset in webkit [134088] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-536.28-branch

Merged r125635. <rdar://problem/12536426>

10:56 AM Changeset in webkit [134087] by zandobersek@gmail.com
  • 30 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining and removing stale expectations after the Cairo
version used in Jhbuild modules was bumped to 1.12.8 in r134073.

  • platform/gtk/TestExpectations:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/gtk/svg/batik/text/smallFonts-expected.png:
  • platform/gtk/svg/batik/text/smallFonts-expected.txt:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.png:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath2-expected.png:
  • platform/gtk/svg/batik/text/textOnPath2-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath3-expected.png:
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/custom/js-update-path-changes-expected.png:
  • platform/gtk/svg/custom/js-update-path-changes-expected.txt:
  • platform/gtk/svg/custom/js-update-path-removal-expected.png:
  • platform/gtk/svg/custom/js-update-path-removal-expected.txt:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.png:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
10:55 AM Changeset in webkit [134086] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove a level of indirection in DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101690

Reviewed by Kentaro Hara.

There is no longer any reason for the DOMDataStore to hold the wrapper
map via a pointer. It can just hold the wrapper map directly, saving a
level of indirection. I doubt this has any measurable performance gain.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):

10:24 AM Changeset in webkit [134085] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Region styling properties are not filtered correctly
https://bugs.webkit.org/show_bug.cgi?id=101768

Reviewed by Andreas Kling.

Source/WebCore:

Region styling allows only a handful of css properties. There is a mechanism in place,
in StyleResolver::isValidRegionStyleProperty that filters the supported region style properties.
In order to be effective, this mechanism relies on RuleData::m_isInRegionRule being set correctly.
This patch makes sure that the flag RuleData::m_isInRegionRule is set properly in RuleData constructor.

Test: fast/regions/region-style-not-supported-properties.html

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):

LayoutTests:

Visibility is not a supported region style property, therefore using it inside @-webkit-region
should not be possible.

  • fast/regions/region-style-not-supported-properties-expected.html: Added.
  • fast/regions/region-style-not-supported-properties.html: Added.
10:22 AM Changeset in webkit [134084] by tommyw@google.com
  • 31 edits
    65 deletes in trunk

MediaStream API: Deleting all files relating to the deprecated PeerConnection00
https://bugs.webkit.org/show_bug.cgi?id=101730

Reviewed by Adam Barth.

Since RTCPeerConenction has superseeded PeerConnection00 this patch removes all
files relating to the old API.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):

  • chromium/public/WebICECandidateDescriptor.h: Removed.
  • chromium/public/WebICEOptions.h: Removed.
  • chromium/public/WebMediaHints.h: Removed.
  • chromium/public/WebMediaStreamCenter.h:

(WebKit):
(WebMediaStreamCenter):

  • chromium/public/WebPeerConnection00Handler.h: Removed.
  • chromium/public/WebPeerConnection00HandlerClient.h: Removed.
  • chromium/public/WebPeerConnectionHandler.h: Removed.
  • chromium/public/WebPeerConnectionHandlerClient.h: Removed.
  • chromium/public/WebSessionDescriptionDescriptor.h: Removed.

Source/WebCore:

No testing needed, the remaining tests makes sure that nothing else breaks.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/IceCallback.h: Removed.
  • Modules/mediastream/IceCallback.idl: Removed.
  • Modules/mediastream/IceCandidate.cpp: Removed.
  • Modules/mediastream/IceCandidate.h: Removed.
  • Modules/mediastream/IceCandidate.idl: Removed.
  • Modules/mediastream/PeerConnection00.cpp: Removed.
  • Modules/mediastream/PeerConnection00.h: Removed.
  • Modules/mediastream/PeerConnection00.idl: Removed.
  • Modules/mediastream/SessionDescription.cpp: Removed.
  • Modules/mediastream/SessionDescription.h: Removed.
  • Modules/mediastream/SessionDescription.idl: Removed.
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebICECandidateDescriptor.cpp: Removed.
  • platform/chromium/support/WebICEOptions.cpp: Removed.
  • platform/chromium/support/WebMediaHints.cpp: Removed.
  • platform/mediastream/IceCandidateDescriptor.cpp: Removed.
  • platform/mediastream/IceCandidateDescriptor.h: Removed.
  • platform/mediastream/IceOptions.cpp: Removed.
  • platform/mediastream/IceOptions.h: Removed.
  • platform/mediastream/MediaHints.cpp: Removed.
  • platform/mediastream/MediaHints.h: Removed.
  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

  • platform/mediastream/PeerConnection00Handler.cpp: Removed.
  • platform/mediastream/PeerConnection00Handler.h: Removed.
  • platform/mediastream/PeerConnection00HandlerClient.h: Removed.
  • platform/mediastream/SessionDescriptionDescriptor.cpp: Removed.
  • platform/mediastream/SessionDescriptionDescriptor.h: Removed.
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:

(WebCore):
(MediaStreamCenterBlackBerry):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
  • platform/mediastream/chromium/MediaStreamCenterChromium.h:

(WebCore):
(MediaStreamCenterChromium):

  • platform/mediastream/chromium/PeerConnection00Handler.cpp: Removed.
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp: Removed.
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.h: Removed.
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

(WebCore):
(MediaStreamCenterGStreamer):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • public/platform/WebICECandidateDescriptor.h: Removed.
  • public/platform/WebICEOptions.h: Removed.
  • public/platform/WebMediaHints.h: Removed.
  • public/platform/WebPeerConnection00Handler.h: Removed.
  • public/platform/WebPeerConnection00HandlerClient.h: Removed.
  • public/platform/WebPeerConnectionHandler.h: Removed.
  • public/platform/WebPeerConnectionHandlerClient.h: Removed.
  • public/platform/WebSessionDescriptionDescriptor.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::isPeerConnectionEnabled):

  • src/WebSessionDescriptionDescriptor.cpp: Removed.

Tools:

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h:

(MockWebMediaStreamCenter):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • fast/mediastream/SessionDescription-expected.txt: Removed.
  • fast/mediastream/SessionDescription.html: Removed.
  • fast/mediastream/constructors-expected.txt:
  • fast/mediastream/constructors.html:
  • fast/mediastream/peerconnection-Attributes-expected.txt: Removed.
  • fast/mediastream/peerconnection-Attributes.html: Removed.
  • fast/mediastream/peerconnection-addstream-expected.txt: Removed.
  • fast/mediastream/peerconnection-addstream.html: Removed.
  • fast/mediastream/peerconnection-argument-types-expected.txt: Removed.
  • fast/mediastream/peerconnection-argument-types.html: Removed.
  • fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Removed.
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html: Removed.
  • fast/mediastream/peerconnection-iceoptions-expected.txt: Removed.
  • fast/mediastream/peerconnection-iceoptions.html: Removed.
  • fast/mediastream/peerconnection-mediastreamlist-expected.txt: Removed.
  • fast/mediastream/peerconnection-mediastreamlist.html: Removed.
  • fast/mediastream/peerconnection-removestream-expected.txt: Removed.
  • fast/mediastream/peerconnection-removestream.html: Removed.
  • fast/mediastream/script-tests/peerconnection-Attributes.js: Removed.
  • fast/mediastream/script-tests/peerconnection-addstream.js: Removed.
  • fast/mediastream/script-tests/peerconnection-argument-types.js: Removed.
  • fast/mediastream/script-tests/peerconnection-removestream.js: Removed.
10:16 AM Changeset in webkit [134083] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Plugin diagnostic logging should send plugin file basename instead of MIME type.
https://bugs.webkit.org/show_bug.cgi?id=101679

Reviewed by Eric Carlson.

Log the basename of the plugin file rather than the mime type so as to more
accurately log which plugin was used to handle the request.

  • loader/SubframeLoader.cpp:

(WebCore::logPluginRequest): Log the plugin 'file' field, if present.

  • plugins/PluginData.cpp:

(WebCore::PluginData::pluginInfoForMimeType): Factored out from pluginNameForMimeType.
(WebCore::PluginData::pluginNameForMimeType): Use pluginInfoForMimeType to retrieve name field.
(WebCore::PluginData::pluginFileForMimeType): Use pluginInfoForMimeType to retrieve file field.

  • plugins/PluginData.h:
10:08 AM Changeset in webkit [134082] by ap@apple.com
  • 16 edits
    1 copy
    6 moves
    1 add in trunk/Source

CookieJar uses Document class, which is a layering violation
https://bugs.webkit.org/show_bug.cgi?id=101621

Reviewed by Brady Eidson.

Source/WebCore:

Split CookieJar in two parts, one that takes a Document, and another that is a pure
platform one, using NetworkingContext to access the correct platform storage.

  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Updated.

  • loader/CookieJar.cpp: Added.

(WebCore::networkingContext):
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

  • loader/CookieJar.h: Copied from Source/WebCore/platform/CookieJar.h.

This is an adaptor for pure platform implementations. Clients continue to use the
old interface unchanged.

  • platform/blackberry/CookieJarBlackBerry.cpp: Removed.
  • loader/blackberry/CookieJarBlackBerry.cpp: Copied from Source/WebCore/platform/blackberry/CookieJarBlackBerry.cpp.
  • platform/network/chromium/CookieJarChromium.cpp: Removed.
  • loader/chromium/CookieJarChromium.cpp: Copied from Source/WebCore/platform/network/chromium/CookieJarChromium.cpp.

These platforms do not have a pure platform implementation yet, so they just keep
to use original implementations. Since the code is not in platform/ any more, the
violation is resolved for Chromium and Blackberry, too.

  • platform/CookieJar.h: Removed.
  • platform/network/PlatformCookieJar.h: Copied from Source/WebCore/platform/CookieJar.h.

The platform interface is now more uniform - all functions take a NetworkingContext
instead of hardcoding which cookie storage to use in some cases.
Renamed functions that are only useful for document.cookie implementation to look
less generic.

  • platform/mac/CookieJar.mm: Removed.
  • platform/network/mac/CookieJarMac.mm: Copied from Source/WebCore/platform/mac/CookieJar.mm.

(WebCore::cookiesForDOM): This now takes a context instead of Document, and also
takes a firstParty URL (unused on Mac, but used on some other platforms).
(WebCore::cookieRequestHeaderFieldValue): Get cookie storage from context (and
use shared one if context is null).
(WebCore::setCookiesFromDOM): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): Ditto. This used to only support default storage,
but its cleaner to have a uniform interface.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

  • platform/network/cf/CookieJarCFNet.cpp:

Same changes as on Mac.

  • platform/network/curl/CookieJarCurl.cpp:

Updated for new interface. Implementation is largely a dummy one.

  • platform/qt/CookieJarQt.h: Removed.
  • platform/network/qt/CookieJarQt.h: Copied from Source/WebCore/platform/qt/CookieJarQt.h.

Moved to a common location, most cookie files were in network/ already.

  • platform/qt/CookieJarQt.cpp: Removed.
  • platform/network/qt/CookieJarQt.cpp: Copied from Source/WebCore/platform/qt/CookieJarQt.cpp.

(WebCore::setCookiesFromDOM): Use context's or shared cooke jar as appropriate.
(WebCore::cookiesForDOM): Ditto.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): Back-end implementation can only handle shared
jar here, assert that argument does not request another one.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForContext):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForContext):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated for new function signatures, and use the same cross-platform logic for
choosing a cookie jar.

  • platform/network/soup/CookieJarSoup.h: Don't include unnecessary CooieJar.h.
  • platform/network/win/CookieJarWin.cpp:

(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated for new function signatures.

Source/WebKit2:

  • UIProcess/API/C/WKAPICast.h: Don't include CookieJar.h, its completely unnecessary.
10:04 AM Changeset in webkit [134081] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

ArrayPrototype should start out with a blank indexing type
https://bugs.webkit.org/show_bug.cgi?id=101719

Reviewed by Mark Hahnenberg.

This allows us to track if the array prototype ever ends up with indexed
properties.

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::ArrayPrototype):

  • runtime/ArrayPrototype.h:

(ArrayPrototype):
(JSC::ArrayPrototype::createStructure):

9:58 AM Changeset in webkit [134080] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

MarkStackArray should use the BlockAllocator instead of the MarkStackSegmentAllocator
https://bugs.webkit.org/show_bug.cgi?id=101642

Reviewed by Filip Pizlo.

MarkStackSegmentAllocator is like a miniature version of the BlockAllocator. Now that the BlockAllocator has support
for a variety of block sizes, we should get rid of the MarkStackSegmentAllocator in favor of the BlockAllocator.

  • heap/BlockAllocator.h: Add new specializations of regionSetFor for the new MarkStackSegments.

(JSC):
(JSC::MarkStackSegment):

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):

  • heap/GCThreadSharedData.h:

(GCThreadSharedData):

  • heap/MarkStack.cpp:

(JSC::MarkStackArray::MarkStackArray): We now have a doubly linked list of MarkStackSegments, so we need to refactor
all the places that used the old custom tail/previous logic.
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo): Refactor to use the new linked list.
(JSC::MarkStackArray::stealSomeCellsFrom): Ditto.

  • heap/MarkStack.h:

(JSC):
(MarkStackSegment):
(JSC::MarkStackSegment::MarkStackSegment):
(JSC::MarkStackSegment::sizeFromCapacity):
(MarkStackArray):

  • heap/MarkStackInlines.h:

(JSC::MarkStackSegment::create):
(JSC):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::size):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):

9:51 AM Changeset in webkit [134079] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Give the view a size in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=101770

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-09
Reviewed by Laszlo Gombos.

2 tests are currently failing, because they expect us to paint, but we don't paint if the view size is empty.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI):
(TestWebKitAPI::PlatformWebView::resizeTo):

9:22 AM Changeset in webkit [134078] by Bruno de Oliveira Abinader
  • 5 edits in trunk

[css] Text decoration's "blink" not valid when CSS3_TEXT is enabled
https://bugs.webkit.org/show_bug.cgi?id=101750

Reviewed by Ojan Vafai.

Source/WebCore:

This patch fixes an issue regarding "blink" value, which is valid for CSS 2.1
"text-decoration" property, but recently have its parser function modified by
the addition of CSS3 "-webkit-text-decoration-line" property.

The 'fast/css/getComputedStyle/getComputedStyle-text-decoration.html'
layout test is updated with all possible value combinations.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTextDecoration): Added 'blink' value to list
if accepted.

LayoutTests:

This patch updates the "text-decoration" computed style layout tests to
handle a larger variety of value combinations.

  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
  • fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js:
9:18 AM Changeset in webkit [134077] by eae@chromium.org
  • 36 edits
    2 copies in branches/chromium/1312

Merge 133172 - [subpixel] Change intrinsicSize to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=99104

Reviewed by Levi Weintraub.

Source/WebCore:

Change RenderReplaced and intrinsicSize to LayoutUnit to avoid
rounding problems when zooming/scaling. Also change imageSize to
LayoutUnit as it can return a scaled size.

Test: fast/sub-pixel/tiled-canvas-elements.html

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::finish):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):

  • platform/graphics/FractionalLayoutSize.h:

(FractionalLayoutSize):
(WebCore::FractionalLayoutSize::scale):
(WebCore::FractionalLayoutSize::clampToMinimumSize):

  • rendering/RenderBox.h:

(WebCore::RenderBox::intrinsicSize):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasSizeChanged):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::minimumReplacedHeight):

  • rendering/RenderImage.h:

(RenderImage):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::imageSize):

  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::RenderReplaced):
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderReplaced.h:

(RenderReplaced):
(WebCore::RenderReplaced::minimumReplacedHeight):
(WebCore::RenderReplaced::setIntrinsicSize):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updateIntrinsicSize):
(WebCore::RenderVideo::calculateIntrinsicSize):
(WebCore::RenderVideo::videoBox):
(WebCore::RenderVideo::minimumReplacedHeight):

  • rendering/RenderVideo.h:

(RenderVideo):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::imageSize):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::imageSize):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):

  • rendering/style/StyleGeneratedImage.h:

(StyleGeneratedImage):

  • rendering/style/StyleImage.h:

(StyleImage):

  • rendering/style/StylePendingImage.h:

LayoutTests:

Add test for tiled replaced elements and update existing expectations as needed.

  • fast/sub-pixel/tiled-canvas-elements-expected.txt: Added.
  • fast/sub-pixel/tiled-canvas-elements.html: Added.
  • platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium/fast/reflections/reflection-with-zoom-expected.txt:
  • platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-svg-as-image-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-svg-as-relative-image-expected.txt:

TBR=eae@chromium.org

9:16 AM Changeset in webkit [134076] by jsbell@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening - rebaseline a handful of image tests for chromium-mac-lion.

  • platform/chromium-mac-lion/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/backgrounds-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
9:09 AM Changeset in webkit [134075] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-11-09 Xan Lopez <xlopez@igalia.com>

[GTK] Do not use 'ls' to list IDL files in EXTRA_DIST
https://bugs.webkit.org/show_bug.cgi?id=101581

Reviewed by Martin Robinson.

Use normal GNU Make wildcards instead of 'ls' to list files in
EXTRA_DIST, it's safer and more straightforward.

  • GNUmakefile.am: ditto.
8:55 AM Changeset in webkit [134074] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r134068.
http://trac.webkit.org/changeset/134068
https://bugs.webkit.org/show_bug.cgi?id=101766

Caused crashes on the bots. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

8:20 AM Changeset in webkit [134073] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Bump the jhbuild Cairo version to 1.12.8
https://bugs.webkit.org/show_bug.cgi?id=101721

Bump the Cairo version in Jhbuild moduleset to 1.12.8. This version
should fix multiple failures in canvas tests and also contains
fixes for X-related crashes that occurred from the 1.12.4 version onwards.

  • gtk/jhbuild.modules:
8:03 AM Changeset in webkit [134072] by Lucas Forschler
  • 4 edits in tags/Safari-537.18.1/Source

Versioning.

8:02 AM Changeset in webkit [134071] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] r133953 broke the ARM_TRADITIONAL build
https://bugs.webkit.org/show_bug.cgi?id=101706

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-09
Reviewed by Csaba Osztrogonác.

Fix for both hardfp and softfp.

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

7:59 AM Changeset in webkit [134070] by Lucas Forschler
  • 1 copy in tags/Safari-537.18.1

New Tag.

7:56 AM Changeset in webkit [134069] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Need to clear exception in JSDictionary that might have been caused by previous operation.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by George Staikos.

IndexedDB IDBDatabase::createObjectStore supports both String type of KeyPath and
String Array type of KeyPath. It will first try to get the keyPath as a String Array,
if fails, it will try to get KeyPath as a String, from the Dictionary. The first get
will leave the internal ExecState of Dictionary in exception state. We need to clear
the exception state before the 2nd query, otherwise the second query will also fail.

No new tests. The existing test case LayoutTests/storage/indexeddb/tutorial.html should
now work with this patch.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

7:49 AM Changeset in webkit [134068] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
https://bugs.webkit.org/show_bug.cgi?id=101759

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
the check for an empty repaintRect -- we need to check if the
WKArrayRef has any items. `if (repaintRect)' will return true
regardless of whether the array is empty or not.

7:32 AM Changeset in webkit [134067] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove obsolete tokenizer settings
https://bugs.webkit.org/show_bug.cgi?id=101689

Reviewed by Yong Li.

These tokenizer settings are obsolete and should not be here. Remove them.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

7:23 AM Changeset in webkit [134066] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources

Having DerivedSources.pri in the watchlist regexp was creating too much
noise.

Reviewed by Ossy.

  • Scripts/webkitpy/common/config/watchlist:
7:18 AM Changeset in webkit [134065] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

[EFL] Rebaseline svg tests after 99870
https://bugs.webkit.org/show_bug.cgi?id=101756

Unreviewed svg baseline after https://bugs.webkit.org/show_bug.cgi?id=99870.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

  • platform/efl/TestExpectations:
  • platform/efl/svg/custom/pattern-scaling-expected.png: Added.
  • platform/efl/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
6:58 AM Changeset in webkit [134064] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Rebaseline fast/table/025-expected
https://bugs.webkit.org/show_bug.cgi?id=101752

Unreviewed rebaseline after https://bugs.webkit.org/show_bug.cgi?id=11645.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

  • platform/efl/TestExpectations:
  • platform/efl/fast/table/025-expected.png:
  • platform/efl/fast/table/025-expected.txt:
6:51 AM Changeset in webkit [134063] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r134051.
http://trac.webkit.org/changeset/134051
https://bugs.webkit.org/show_bug.cgi?id=101757

It didn't fix the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

6:42 AM Changeset in webkit [134062] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Unmark now passing tests
https://bugs.webkit.org/show_bug.cgi?id=65531

Reviewed by Csaba Osztrogonác.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::viewModes):

6:36 AM Changeset in webkit [134061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build fails to link
https://bugs.webkit.org/show_bug.cgi?id=101739

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-11-09
Reviewed by Kentaro Hara.

  • win/WebKit2CFLite.def:
6:28 AM Changeset in webkit [134060] by dominik.rottsches@intel.com
  • 2 edits in trunk/Tools

webkitpy/layouttests integration test fails if high shards/processes environment variables are used
https://bugs.webkit.org/show_bug.cgi?id=101455

Reviewed by Dirk Pranke.

Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_max_locked_shards):

6:25 AM Changeset in webkit [134059] by rakuco@webkit.org
  • 5 edits in trunk

[EFL][DRT] Force a repaint before tracking repaint rects.
https://bugs.webkit.org/show_bug.cgi?id=101743

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::forceLayout): Added.

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Do like other ports and force a repaint before we start tracking
repaints so that the pixel results generated look more in line
with what's expected.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(displayWebView): Call DRTSupport::forceLayout() before start
tracking repaints.

6:22 AM Changeset in webkit [134058] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Month/week picker should submit month/week string
https://bugs.webkit.org/show_bug.cgi?id=101744

Reviewed by Kent Tamura.

Month/week picker should submit month/week string and not yyyy-mm-dd.

No new tests. Test will be added in Bug 101555 and Bug 101556.

  • Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype._handleDayClick):

6:03 AM Changeset in webkit [134057] by commit-queue@webkit.org
  • 3 edits in trunk

[EFL] Enable -Werror for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=98715

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-11-09
Reviewed by Gyuyoung Kim.

Treat all warnings as errors, except the existing warnings in the
current code base ("unused-parameter", "sign-compare" and "switch").

Thanks for Raphael Kubo da Costa for the extra help.

  • Source/CMakeLists.txt: Enable warnings as error for all libraries

(except WebKit and WebKit2) for the EFL port.
Other cmake-based ports are welcome to join.

  • Source/cmake/WebKitHelpers.cmake: Treat warnings as errors by

default for cmake-based ports when ENABLE_WERROR is set.

5:52 AM Changeset in webkit [134056] by rakuco@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] REGRESSION (r134043): API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=101742

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Do not assert on PassRefPtr<WebContext> after it becomes 0.

  • UIProcess/efl/BatteryProvider.cpp:

(BatteryProvider::BatteryProvider):

  • UIProcess/efl/NetworkInfoProvider.cpp:

(NetworkInfoProvider::NetworkInfoProvider):

5:42 AM Changeset in webkit [134055] by rakuco@webkit.org
  • 31 edits in trunk/LayoutTests/fast/repaint

Remove the `svn:executable' property from a few test files.

5:15 AM Changeset in webkit [134054] by kbalazs@webkit.org
  • 1 edit
    103 adds in trunk/LayoutTests

Pixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebaseline.

Rebaseline some tests, add missing expectations.

  • platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/transformed-body-background-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/transformed-body-html-background-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/transformed-html-body-background-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/before-with-first-letter-expected.png: Added.
  • platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/text-rescale-expected.png: Added.
  • platform/qt/css3/filters/effect-reference-ordering-hw-actual.png: Added.
  • platform/qt/fast/images/png-suite/test-actual.png: Added.
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-change-actual.png: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-actual.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-height-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-width-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-height-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-width-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-height-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-width-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTRefElement-dom-href-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-dx-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-dy-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-transform-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-dom-href1-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-dom-href2-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/filters/subRegion-one-effect-actual.png: Added.
  • platform/qt/svg/filters/subRegion-two-effects-actual.png: Added.
5:05 AM Changeset in webkit [134053] by pfeldman@chromium.org
  • 10 edits
    1 copy in trunk

Web Inspector: wrong output for empty object {}
https://bugs.webkit.org/show_bug.cgi?id=101356

Reviewed by Vsevolod Vlasov.

Changed preview formatting to iterate over enumerable properties only + visit the prototypes.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/command-line-api-inspect-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
4:54 AM Changeset in webkit [134052] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key
https://bugs.webkit.org/show_bug.cgi?id=100937

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-11-09
Reviewed by Rob Buis.

  1. Translate these keys to their corresponding BlackBerry key code.
  2. Break down a KeyChar event to a KeyDown/KeyUp pair. This is required

because we only handle scrolling on a KeyDown event in WebPage::keyEvent()
, and internally a KeyChar event is interpreted as a KeyDown event + a
KeyUp event in InputHandler::handleKeyboardInput().

Tests fixed:

  1. editing/input/scroll-viewport-page-up-down.html
  2. editing/selection/move-begin-end.html
  3. fast/forms/select-popup-pagekeys.html
  • DumpRenderTree/blackberry/EventSender.cpp:

(keyDownCallback):

4:41 AM Changeset in webkit [134051] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] r133953 broke the ARM_TRADITIONAL build
https://bugs.webkit.org/show_bug.cgi?id=101706

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-09
Reviewed by Csaba Osztrogonác.

Fix the ARM_TRADITIONAL build after r133953

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

4:28 AM Changeset in webkit [134050] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix annotations in page popup files
https://bugs.webkit.org/show_bug.cgi?id=101736

Reviewed by Kent Tamura.

Add @constructor where needed. Replacing /* with / for annotations.

No new tests. No behavior change.

  • Resources/pagepopups/calendarPicker.js:
  • Resources/pagepopups/pickerCommon.js:
  • Resources/pagepopups/suggestionPicker.js:
4:23 AM Changeset in webkit [134049] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Random crashes in layout tests on the bot
https://bugs.webkit.org/show_bug.cgi?id=101687

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Speculative fix for a crash on the bot.
If didCommitLoad() is called before the view size was set, we will
try to paint an empty area, and that will crash.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::update):

4:13 AM Changeset in webkit [134048] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Coordinated Graphics: Remove a backing store of GraphicsLayer when the layer is far from the viewport.
https://bugs.webkit.org/show_bug.cgi?id=101656

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore computes cover and keep rects to create, keep or remove tiles
smartly, but currently TiledBackingStore expects a contents rect is big enough
to cover the visibleRect. However, when CoordinatedGraphicsLayer uses TBS, it
is usually wrong expectation.

We must compute cover and keep rects using the visibleRect, instead of
the rect intersecting the visibleRect with m_rect, because TBS can be
used as a backing store of GraphicsLayer and the visible rect usually
does not intersect with m_rect.
In the below case, the intersecting rect is an empty.

+---------------+
| |
| m_rect |

| +-------+

| | HERE | cover or keep |
+---------------+ rect |

| +---------+ |
| | visible | |
| | rect | |
| +---------+ |
| |
| |
+-------------------------------+

We must create or keep the tiles in the HERE region. Currently in the
case, we do not create or keep tiles on the HERE region. Moreover, in
the case, we early return, which means we don't remove any tiles. It
causes to waste heap and video memory.

This patch changes TiledBackingStore to manage tiles smartly for
Coordinated Graphics.

Changing cache policy is not testable in layout tests.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

4:08 AM Changeset in webkit [134047] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Refactor TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=101738

Unreviewed, EFL gardening.

Remove duplicated definitions.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-09

  • platform/efl/TestExpectations:
3:39 AM Changeset in webkit [134046] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix undefined variable in Week constructor for calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101734

Reviewed by Kent Tamura.

Closer compiler found an undefined variable in the Week constructor.

No new tests. This code isn't used.

  • Resources/pagepopups/calendarPicker.js:

(Week): Used wrong variable name.

3:33 AM Changeset in webkit [134045] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: render canvas log as a grid.
https://bugs.webkit.org/show_bug.cgi?id=101732

Reviewed by Vsevolod Vlasov.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._onSelectTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasLogGrid):
(WebInspector.CanvasLogGrid.prototype._didReceiveTraceLog):
(WebInspector.CanvasLogGrid.prototype._createCallNode):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.createCell):

  • inspector/front-end/canvasProfiler.css:

(#canvas-replay-image-container):

3:28 AM Changeset in webkit [134044] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Regression(r107593) Crash in ContextMenuController::addInspectElementItem()
https://bugs.webkit.org/show_bug.cgi?id=101595

Reviewed by Simon Hausmann.

If the contextMenu is a null pointer treat it as empty, appendItem will later
create it if necessary.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::addInspectElementItem):

3:25 AM Changeset in webkit [134043] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Make classes for client use WebContext instead of WKContext
https://bugs.webkit.org/show_bug.cgi?id=101564

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

EwkContext class has been refactored to use WebContext instead of WKContext in r133844,
so this patch makes client classes use WebContext

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):

  • UIProcess/efl/BatteryProvider.cpp:

(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::didChangeBatteryStatus):

  • UIProcess/efl/BatteryProvider.h:

(BatteryProvider):

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):

  • UIProcess/efl/ContextHistoryClientEfl.h:

(WebKit::ContextHistoryClientEfl::create):
(ContextHistoryClientEfl):

  • UIProcess/efl/NetworkInfoProvider.cpp:

(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):

  • UIProcess/efl/NetworkInfoProvider.h:

(NetworkInfoProvider):

3:12 AM Changeset in webkit [134042] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build warning in test_ewk2_context.cpp: [-Wwrite-strings]
https://bugs.webkit.org/show_bug.cgi?id=101666

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Use constant character pointer to fix [-Wwrite-strings] warning.

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

3:06 AM Changeset in webkit [134041] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[EFL][WK2] Add support for custom cursors
https://bugs.webkit.org/show_bug.cgi?id=101723

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add getEvasObject() virtual method to Image class and
provide implementation for BitmapImage.

No new tests, no behavior change.

  • platform/efl/CursorEfl.cpp:

(WebCore::cursorString):

  • platform/graphics/BitmapImage.h:

(BitmapImage):

  • platform/graphics/Image.h:

(Image):
(WebCore::Image::getEvasObject):

  • platform/graphics/efl/ImageEfl.cpp:

(WebCore::BitmapImage::getEvasObject):
(WebCore):

Source/WebKit2:

EwkViewImpl::setCursor() now properly handles custom
cursors.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::setCursor):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

2:33 AM Changeset in webkit [134040] by abarth@webkit.org
  • 11 edits in trunk/Source/WebCore

IndexedDB should use mostly ScriptWrappable DOM objects
https://bugs.webkit.org/show_bug.cgi?id=101694

Reviewed by Kentaro Hara.

These object always have JavaScript wrappers, so we should store the
wrappers inline to use less memory and be faster.

  • Modules/indexeddb/IDBAny.h:
  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBIndex.h:
  • Modules/indexeddb/IDBKey.h:
  • Modules/indexeddb/IDBKeyRange.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.h:
2:10 AM Changeset in webkit [134039] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Skip failing test perf/accessibility-title-ui-element.html
https://bugs.webkit.org/show_bug.cgi?id=101728

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09

  • platform/efl/TestExpectations:
2:09 AM Changeset in webkit [134038] by dominik.rottsches@intel.com
  • 11 edits in trunk/LayoutTests

[EFL] Update baselines for failing svg tests
https://bugs.webkit.org/show_bug.cgi?id=101726

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09

  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/efl/svg/text/bidi-tspans-expected.png:
  • platform/efl/svg/text/bidi-tspans-expected.txt:
2:06 AM Changeset in webkit [134037] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Add meaningful error message when request content was evicted from inspector cache.
https://bugs.webkit.org/show_bug.cgi?id=101578

Reviewed by Yury Semikhatsky.

Added specific error message when request content was evicted from inspector cache.
Replaced purge with evict in fields/methods names.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::getResponseBody):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::evictContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::isContentEvicted):
(ResourceData):

2:03 AM Changeset in webkit [134036] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

Don't use RenderTextControlSingleLine for date/time input types without the multiple-fields UI
https://bugs.webkit.org/show_bug.cgi?id=101722

Reviewed by Hajime Morita.

Because the date/time input types are not textfields, we should not use
RenderTextControlSingleLine, and don't need to create shadow trees for
RenderTextControlSingleLine.

No new tests. Covered by fast/forms/*/*-appearance-*.html.

  • css/html.css:

(input[type="date"]):
It has menulist appeanrace by default, and should be a flexible box to
center the inner text. 10em width is almost same as the default width of
text fields.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-date-and-time-value):
Added. A style for the inner text block.

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::createRenderer):
Don't create RenderTextControlSingleLine.
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
Skip TextFieldInputType::updateInnerTextValue.
(WebCore::BaseChooserOnlyDateAndTimeInputType::forwardEvent):
Skip TextFieldInputType::forwardEvent.
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
Just add one element to the shadow root.
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):
Sets a localized value to the inner text block.
(WebCore::BaseChooserOnlyDateAndTimeInputType::setValue):
Calls updateAppearance if the value is updated.

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(BaseChooserOnlyDateAndTimeInputType): Declare updateAppearance,
createRenderer, updateInnerTextValue, forwardEvent, createShadowSubtree,
and setValue.

  • html/BaseDateAndTimeInputType.h:

(WebCore): Add a FIXME comment.
(BaseDateAndTimeInputType):
Make visibleValue protected. It is used by BaseChooserOnlyDateAndTimeInputType.

  • html/TextFieldInputType.h:

(TextFieldInputType):
Make setValue protected. It is used by BaseChooserOnlyDateAndTimeInputType.

1:59 AM Changeset in webkit [134035] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Clarify meaning of different urls in protocol.
https://bugs.webkit.org/show_bug.cgi?id=101582

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
1:58 AM Changeset in webkit [134034] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Month picker should select the current month when navigating while keeping selection position.
https://bugs.webkit.org/show_bug.cgi?id=101724

Reviewed by Kent Tamura.

Month picker needs to behave differently because selection won't be in the same position when changing current month.

No new tests. Test will be added in Bug 101556.

  • Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype.navigateToMonth): Date/Week picker should keep selection position for first selected date node.
(DaysTable.prototype._startMoveInAnimation): Moving shared code to separate function.
(MonthPickerDaysTable.prototype.navigateToMonth): Month picker should just select the month.

1:50 AM Changeset in webkit [134033] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Web Inspector: Fix heap snapshots counted several times by NMI
https://bugs.webkit.org/show_bug.cgi?id=101085

The fix moves snapshots size counting to V8PerIsolateData class. As long
as it has one instance per isolate its reportMemoryUsage should be
called once per isolate.

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-09
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryClassInfo::addPrivateBuffer):

1:47 AM Changeset in webkit [134032] by Simon Hausmann
  • 2 edits in trunk/Tools

Unreviewed prospective Qt/Windows build bot fix:

Make determination of qmake mkspec work with older versions of Qt that
still create a "mkspecs/default" directory.

  • Scripts/webkitdirs.pm:

(qtMakeCommand):

1:22 AM Changeset in webkit [134031] by pfeldman@chromium.org
  • 22 edits
    1 add in trunk/Source/WebCore

Web Inspector: split SplitView into SplitView and SidebarView
https://bugs.webkit.org/show_bug.cgi?id=101612

Reviewed by Vsevolod Vlasov.

Currently, SplitView is rather a sidebar view. I'm extracting the reusable split component from it.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/CSSNamedFlowCollectionsView.js:

(WebInspector.CSSNamedFlowCollectionsView):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/FileSystemView.js:

(WebInspector.FileSystemView):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.CounterUI):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype.setSidebarWidth):
(WebInspector.MemoryStatistics.prototype.visible):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.hide):

  • inspector/front-end/NavigatorOverlayController.js:

(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._innerHideNavigatorOverlay):

  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.createSidebarView):
(WebInspector.Panel.prototype.createSidebarViewWithTree):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

  • inspector/front-end/SidebarView.js: Added.

(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._hasLeftSidebar):
(WebInspector.SidebarView.prototype.get mainElement):
(WebInspector.SidebarView.prototype.get sidebarElement):
(WebInspector.SidebarView.prototype._innerSetSidebarPosition):
(WebInspector.SidebarView.prototype.setMinimalSidebarWidth):
(WebInspector.SidebarView.prototype.setMinimalMainWidthPercent):
(WebInspector.SidebarView.prototype.setSidebarWidth):
(WebInspector.SidebarView.prototype.sidebarWidth):
(WebInspector.SidebarView.prototype.onResize):
(WebInspector.SidebarView.prototype.applyConstraints):
(WebInspector.SidebarView.prototype.hideMainElement):
(WebInspector.SidebarView.prototype.showMainElement):
(WebInspector.SidebarView.prototype.hideSidebarElement):
(WebInspector.SidebarView.prototype.showSidebarElement):
(WebInspector.SidebarView.prototype.elementsToRestoreScrollPositionsFor):

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype.firstElement):
(WebInspector.SplitView.prototype.secondElement):
(WebInspector.SplitView.prototype.setChangeFirstOnResize):
(WebInspector.SplitView.prototype.resizerElement):
(WebInspector.SplitView.prototype.showOnlyFirst):
(WebInspector.SplitView.prototype.showOnlySecond):
(WebInspector.SplitView.prototype._showOnly):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):
(WebInspector.SplitView.prototype.showBoth):
(WebInspector.SplitView.prototype.setResizable):
(WebInspector.SplitView.prototype.setSplitOffset):
(WebInspector.SplitView.prototype.splitOffset):
(WebInspector.SplitView.prototype._innerSetSplitOffset):
(WebInspector.SplitView.prototype._startResizerDragging):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/splitView.css:
1:20 AM Changeset in webkit [134030] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Ctrl+A in the network panel should select resource content, not the entire panel
https://bugs.webkit.org/show_bug.cgi?id=101591

Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-11-09
Reviewed by Vsevolod Vlasov.

Intercept Ctrl+A event in DefaultTextEditor to select resource content

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._registerShortcuts): Added Ctrl+A
(WebInspector.DefaultTextEditor.prototype._handleKeyDown): Intercept Ctrl+A even for readonly fields
(WebInspector.TextEditorMainPanel.prototype.handleSelectAll):

  • inspector/front-end/KeyboardShortcut.js: Added SelectAll constant for Ctrl+A combination
1:11 AM Changeset in webkit [134029] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Main world should have one DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101470

Patch by Dan Carney <dcarney@google.com> on 2012-11-09
Reviewed by Kentaro Hara.

The main world DOMWrapperWorld held onto a DOMDataStore that should
never be used, as there is a static one optimized for speed in
DOMDataStore.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::isolatedWorldDomDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

1:01 AM Changeset in webkit [134028] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Navigating around NMI snapshot grid with keys breaks the grid
https://bugs.webkit.org/show_bug.cgi?id=101611

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-09
Reviewed by Yury Semikhatsky.

Keys navigation cause populate message sent to the node. The node should
not react on populate messages but the first one.

  • inspector/front-end/NativeMemorySnapshotView.js:
1:00 AM Changeset in webkit [134027] by jochen@chromium.org
  • 5 edits
    2 adds in trunk/Tools

[chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout tests
https://bugs.webkit.org/show_bug.cgi?id=101452

Reviewed by Adam Barth.

The WebTestProxy is template, so it can derive from an implementation
of the WebViewClient interface. That way, WebTestProxy can hook into
individual methods of the WebViewClient and forward all the rest to the
actual implementation.

To demonstrate how I want to use this, I moved the
postAccessibilityNotification method from WebViewHost to WebTestProxy.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Added.

(WebKit):
(WebTestRunner):
(WebTestProxyBase):
(WebTestProxy):
(WebTestRunner::WebTestProxy::WebTestProxy):
(WebTestRunner::WebTestProxy::~WebTestProxy):
(WebTestRunner::WebTestProxy::postAccessibilityNotification):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Added.

(WebTestRunner):
(WebTestRunner::WebTestProxyBase::WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::doPostAccessibilityNotification):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createNewWindow):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

12:54 AM Changeset in webkit [134026] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] css3/flexbox/multiline-justify-content.html doesn't crash
https://bugs.webkit.org/show_bug.cgi?id=101717

Unreviewed, EFL gardening.

css3/flexbox/multiline-justify-content.html doesn't crash and can be passed.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-09

  • platform/efl/TestExpectations:
12:40 AM Changeset in webkit [134025] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Fix the LLINT build from ARMv7 platform
https://bugs.webkit.org/show_bug.cgi?id=101712

Reviewed by Simon Hausmann.

Enable generating of LLIntAssembly.h on ARM platforms.

12:36 AM Changeset in webkit [134024] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Build with MSVC fails to use nmake instead of make
https://bugs.webkit.org/show_bug.cgi?id=98645

Reviewed by Tor Arne Vestbø.

Don't rely on the "default" mkspec but instead query the target
mkspec variable from qmake to find the right qmake.conf.

  • Scripts/webkitdirs.pm:

(qtMakeCommand):

Note: See TracTimeline for information about the timeline view.