Timeline
Nov 12, 2012:
- 11:49 PM Changeset in webkit [134375] by
-
- 16 edits in trunk/Source
[Qt] REGRESSION(134142): overscaled tiles in pixel test results and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101918
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-12
Reviewed by Noam Rosenthal.
Source/WebCore:
Remove TiledBackingStore::rect(), because it is not used anymore.
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
Source/WebKit2:
Currently, CoordinatedBackingStore can keep out-dated contents size, because the
size of CoordinatedBackingStore is set by only LayerTreeRenderer::createTile().
Although the size of GraphicsLayer is changed, LayerTreeRenderer::createTile()
is not called. However, LayerTreeRenderer::createTile() is always called, when
the contents scale of GraphicsLayer is changed.
This patch makes sure that we reset the backing store's size to the
layer size when UpdateTile or RemoveTile are called.
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::setSize):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(CoordinatedBackingStore):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::getBackingStore):
(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):
(WebKit::LayerTreeRenderer::resetBackingStoreSizeToLayerSize):
(WebKit):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::createTile):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:
(WebKit::CoordinatedTile::updateBackBuffer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
(CoordinatedTileClient):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createTile):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 11:37 PM Changeset in webkit [134374] by
-
- 15 edits in trunk/Tools
webkitpy: clean up lint errors, part 1
https://bugs.webkit.org/show_bug.cgi?id=102024
Reviewed by Adam Barth.
This patch cleans up a lot of miscellaneous minor lint errors that
apparently aren't caught by unit tests, and suppresses a few
false positives.
Also, this patch removes the garden-o-matic "rollout" entry point
since it's no longer being used by the frontend (rather than
fix it to not generate lint errors).
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive2.run_command):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.copyfile):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._http_tests):
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.reference_files):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._teardown_performance):
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.TestAndroidPort.init):
(ChromiumPortTestCase.test_default_configuration):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase):
(PortTestCase.test_driver_cmd_line):
(PortTestCase.test_expectations_ordering):
- Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase._check_that_all_ports_are_available):
- Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
- Scripts/webkitpy/tool/commands/gardenomatic.py:
(GardenOMatic.init):
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler.localresult):
- 11:35 PM Changeset in webkit [134373] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/12445176>
WebProcess needs permission to open AppleUpstreamUserClient
Rubber-stamped by Dan Bernstein.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:32 PM Changeset in webkit [134372] by
-
- 5 edits in trunk/Source/WebCore
[V8] We should be able to recover the V8DOMWindowShell more quickly
https://bugs.webkit.org/show_bug.cgi?id=102020
Reviewed by Kentaro Hara.
For isolated worlds, we used to store the V8DOMWindowShell as an
internal field of the inner DOM window. This patch moves the pointer to
an internal field of the v8::Context, which saves us the work of
looking up the inner DOM window.
Unfortunately, we cannot store the V8DOMWindowShell in V8PerContextData
because the V8DOMWindowShell outlives the V8PerContextData. (We destroy
the V8PerContextData when we detach the V8DOMWindowShell from the
frame.)
- bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8DOMWindowShell.h:
(WebCore::V8DOMWindowShell::getEntered):
- bindings/v8/V8PerContextData.h:
- 11:29 PM Changeset in webkit [134371] by
-
- 14 edits in trunk/Tools
webkitpy: clean up lint errors, part 2
https://bugs.webkit.org/show_bug.cgi?id=102029
Reviewed by Adam Barth.
This cleans up the remaining lint errors in webkitpy with four exceptions:
1) we don't lint thirdparty/ autoinstalled code, obviously
2) there's an intentional error in the unit tests for pylint itself
3) the implementation of webkit-patch optimize-expectations has
an error but I think we can and should just remove that command as well.
4) I have not yet linted the test code
- Scripts/webkitpy/common/newstringio.py:
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.find_checkout_root):
(SCM.will.remote_merge_base):
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
(SVN.init):
- Scripts/webkitpy/common/config/contributionareas.py:
(ContributionAreas.names):
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort):
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.force_build):
- Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_posix_threading):
(check_spacing):
- Scripts/webkitpy/style/optparser.py:
(ArgumentParser._create_option_parser):
- Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand.execute):
- Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand):
(AbstractPatchProcessingCommand._process_patch):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
- 11:13 PM Changeset in webkit [134370] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 133569 - Web Inspector: JavaScript web workers debugging crashes
https://bugs.webkit.org/show_bug.cgi?id=101065
Reviewed by Alexander Pavlov.
Source/WebCore:
Clear m_pageInspector when page inspector instance is deleted.
Disable worker inspection when front-end disconnects.
Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify
WorkerMessagingProxy so that it can clear pointer to the channel.
LayoutTests:
Test that inspected page won't crash if inspected worker is terminated when it is paused
on a breakpoint.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11361236
- 10:59 PM Changeset in webkit [134369] by
-
- 2 edits in trunk/Source/WebCore
[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
https://bugs.webkit.org/show_bug.cgi?id=101054
Reviewed by Adam Barth.
I'm investigating a Chromium crash bug:
http://code.google.com/p/chromium/issues/detail?id=155942
I've not yet identified the root cause (because I can't reproduce
the crash), but it looks like we are storing NULL pointers to
V8 internal fields. Just in case, we can add an ASSERT() to
guarantee that NULL pointers are never stored. (Also I'm hoping
that this ASSERT() will give me more debug information.)
No tests. No change in behavior.
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):
- 10:55 PM Changeset in webkit [134368] by
-
- 2 edits in trunk
[EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries
https://bugs.webkit.org/show_bug.cgi?id=101762
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
In case of EFL, add ENABLE_WERROR to EXTRA_COMPILER_FLAGS for WEBKIT and WEBKIT2
- Source/CMakeLists.txt:
- 10:50 PM Changeset in webkit [134367] by
-
- 4 edits14 adds in trunk
Changing id, className, or attribute should invalidate distribution
https://bugs.webkit.org/show_bug.cgi?id=100738
Reviewed by Dimitri Glazkov.
PerformanceTests:
Added test code to modify id/class/attribute.
- DOM/ModifyAttribute.html: Added.
- DOM/resources/dom-perf/modify-attribute.js: Added.
(ModifyAttribute.CreateElementToSetUp):
(ModifyAttribute.ModifyId):
(ModifyAttribute.ModifyClass):
(ModifyAttribute.ModifyTitle):
Source/WebCore:
When id, className, or attribute is changed, we might have to invalidate distribution.
However, we don't want to do useless invalidation. So we consult with the RuleFeatureSet of ElementShadow,
and invalidate distribution only if necessary.
When className is changed, we can share a lot of code between invalidating distribution and invalidating style.
So we made checkNeedsStyleInvalidationForClassChange a template method, and share it.
Also we've measured how this patch makes changing attribute slow. By converting checkNeedsStyleInvalidationForClassChange
to template, actually this improves the performance of changing attribute code. I've measured each code 3 times.
DOM/ModifyAttribute.html
Before this patch:
median stdev min max [ms]
1st 115.62 0.67 114.75 117.00
2nd 115.08 1.13 113.25 117.58
3rd 114.75 1.16 113.42 117.83
After this patch:
median stdev min max [ms]
1st 102.55 0.95 101.25 104.50
2nd 103.10 0.86 102.20 100.95
3rd 103.30 1.05 102.10 106.65
Tests: fast/dom/shadow/distribution-attribute-modified.html
fast/dom/shadow/distribution-className-modified.html
fast/dom/shadow/distribution-id-modified.html
fast/dom/shadow/reprojection-attribute-modified.html
fast/dom/shadow/reprojection-className-modified.html
fast/dom/shadow/reprojection-id-modified.html
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::HasSelectorForClassStyleFunctor::HasSelectorForClassStyleFunctor):
(HasSelectorForClassStyleFunctor):
(WebCore::HasSelectorForClassStyleFunctor::operator()): Returns true if StyleResolver::hasSelectorForClass returns true.
(WebCore):
(WebCore::HasSelectorForClassDistributionFunctor::HasSelectorForClassDistributionFunctor):
(HasSelectorForClassDistributionFunctor):
(WebCore::HasSelectorForClassDistributionFunctor::operator()): Returns true if ElementShadow::hasSelectorForClass returns true.
(WebCore::checkFunctorForClassChange):
(WebCore::checkNeedsStyleInvalidationForClassChange): Extacted the implementation to checkFunctorForClassChange.
(WebCore::checkNeedsDistributionInvalidationForClassChange):
(WebCore::Element::classAttributeChanged):
LayoutTests:
We have test cases that id/class/attribute is changed, and thier reprojection cases.
- fast/dom/shadow/distribution-attribute-modified-expected.html: Added.
- fast/dom/shadow/distribution-attribute-modified.html: Added.
- fast/dom/shadow/distribution-className-modified-expected.html: Added.
- fast/dom/shadow/distribution-className-modified.html: Added.
- fast/dom/shadow/distribution-id-modified-expected.html: Added.
- fast/dom/shadow/distribution-id-modified.html: Added.
- fast/dom/shadow/reprojection-attribute-modified-expected.html: Added.
- fast/dom/shadow/reprojection-attribute-modified.html: Added.
- fast/dom/shadow/reprojection-className-modified-expected.html: Added.
- fast/dom/shadow/reprojection-className-modified.html: Added.
- fast/dom/shadow/reprojection-id-modified-expected.html: Added.
- fast/dom/shadow/reprojection-id-modified.html: Added.
- 10:36 PM Changeset in webkit [134366] by
-
- 8 edits in branches/chromium/1312/Source
Merge 133429 - Shadow DOM should be able to be disabled per context.
https://bugs.webkit.org/show_bug.cgi?id=101173
Reviewed by Dimitri Glazkov.
Source/WebCore:
This change pulls back relevant bits from r131549. Note that if
the the port enables runtime Shadow DOM flag, this can cause slow
down on some Chromium page cycler test cases (which r131549
attempted to fix).
This change is temporal and the flags should be switched back from
ContextFeatures to RuntimeEnabledFeatures once it gains sufficent
stability.
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore):
- dom/ContextFeatures.h:
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection):
- html/HTMLTagNames.in:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::contentTagName):
- page/DOMWindow.idl:
Source/WebKit/chromium:
- src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
TBR=morrita@google.com
Review URL: https://codereview.chromium.org/11410062
- 10:36 PM Changeset in webkit [134365] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be uninitialized
https://bugs.webkit.org/show_bug.cgi?id=102038
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
To fix build warning -Wuninitialized,
initialize the 'slicer' in ewk_tiled_backing_store_pre_render_region.
- ewk/ewk_tiled_backing_store.cpp:
(ewk_tiled_backing_store_pre_render_region):
- 10:28 PM Changeset in webkit [134364] by
-
- 4 edits1 add in trunk
[BlackBerry] NetworkJob should not check if data is received with HEAD
https://bugs.webkit.org/show_bug.cgi?id=102034
Patch by Joe Mason <jmason@rim.com> on 2012-11-12
Reviewed by George Staikos.
Internal PR: 241391
.:
Add test that HEAD XMLHttpRequests return status 404 instead of calling onerror.
- ManualTests/blackberry/head-xhr-nonexistant-file.html: Added.
Source/WebCore:
Make HEAD requests call didFinish instead of didFail on a 404 response, even though they
have no data.
Tests: ManualTests/blackberry/head-xhr-nonexistant-file.html
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::shouldNotifyClientFailed):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- 10:12 PM Changeset in webkit [134363] by
-
- 2 edits1 delete in trunk/Tools
remove 'webkit-patch optimize-expectations'
https://bugs.webkit.org/show_bug.cgi?id=102032
Reviewed by Adam Barth.
Removing this command because it is totally broken (probably
broke when I added support for multiple files in a cascade)
and doesn't seem to do anything much useful. It certainly
didn't actually optimize things.
- Scripts/webkitpy/tool/commands/expectations.py: Removed.
- 10:08 PM Changeset in webkit [134362] by
-
- 2 edits2 copies in branches/chromium/1312
Merge 133030 - Web Inspector: page crash when pausing in dedicated worker
https://bugs.webkit.org/show_bug.cgi?id=100837
Reviewed by Pavel Feldman.
Source/WebCore:
Pass debugger agent to InjectedScriptHost::init in case of workers.
Test: inspector-protocol/debugger-pause-dedicated-worker.html
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
LayoutTests:
Test that Debugger.pause works for dedicated workers. The test is skipped
on all platforms that use JSC as worker debugging is not supported there
yet.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(WebInspector.dispatchMessageFromBackend):
- inspector-protocol/debugger-pause-dedicated-worker-expected.txt: Added.
- inspector-protocol/debugger-pause-dedicated-worker.html: Added.
- inspector-protocol/resources/dedicated-worker.js: Added.
(onmessage):
(doWork):
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11275274
- 10:04 PM Changeset in webkit [134361] by
-
- 13 edits in trunk/Source/JavaScriptCore
The act of getting the callee during 'this' construction should be explicit in bytecode
https://bugs.webkit.org/show_bug.cgi?id=102016
Reviewed by Michael Saboff.
This is mostly a rollout of http://trac.webkit.org/changeset/116673, but also includes
changes to have create_this use the result of get_callee.
No performance or behavioral impact. This is just meant to allow us to profile
get_callee in the future.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
(JIT):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC):
(JSC::JIT::emit_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC):
(JSC::JIT::emit_op_create_this):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 10:04 PM Changeset in webkit [134360] by
-
- 19 edits in trunk/Source/WebCore
[V8] V8DOMWrapper::instantiateV8Object shouldn't use deprecatedDocument
https://bugs.webkit.org/show_bug.cgi?id=102015
Reviewed by Kentaro Hara.
Previously, Nodes had a special path through
V8DOMWrapper::instantiateV8Object using deprecatedDocument so that we
could find the V8PerContextData quickly. Now that we can get the
V8PerContextData from the v8::Context quickly, we can move Nodes to the
general case. The net consequence is that creation of all DOM objects
should be as fast as Nodes are.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- 9:53 PM Changeset in webkit [134359] by
-
- 2 edits in trunk/Tools
[BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
https://bugs.webkit.org/show_bug.cgi?id=101894
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 241686
Also remove an un-needed pixel lock, and fix a klocwork error in SKIA
code path.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(readPixelsUserInterfaceThread):
(createBitmapContextFromWebView):
- 9:51 PM Changeset in webkit [134358] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix ARMv7 build.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToPatchableBranchPtrWithPatch):
- 9:32 PM Changeset in webkit [134357] by
-
- 2 edits in trunk/Source/WebCore
Some CSS properties are not handled on StyleResolver::applyProperty
https://bugs.webkit.org/show_bug.cgi?id=102027
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
The CSSPropertyMaxZoom, CSSPropertyMinZoom, CSSPropertyOrientation and CSSPropertyUserZoom
need to be handled on StyleResolver::applyProperty.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 9:24 PM Changeset in webkit [134356] by
-
- 4 edits in trunk/Source/WebCore
Avoid calling calculateLayerBounds() and convertToLayerCoords() more than once per layer paint
https://bugs.webkit.org/show_bug.cgi?id=102031
Reviewed by Beth Dakin.
RenderLayer::paintLayerContents() and callees could end up calling convertToLayerCoords()
and calculateLayerBounds() multiple times for painting a single layer.
Keep track of whether we've computed the root-relative bounds and do it on demand.
Compute the offset relative to rootLayer once, and pass it around as an optional parameter
to functions that need it.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::boundingBox):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
- 9:24 PM Changeset in webkit [134355] by
-
- 4 edits in trunk/Source/WebCore
Change calculateLayerBounds() from a static function to a member function
https://bugs.webkit.org/show_bug.cgi?id=102022
Reviewed by Beth Dakin.
calculateLayerBounds() has grown into a substantial function after
starting live as a little utility function, so make it a member function
of RenderLayer, and adjust callers accordingly.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
- 8:58 PM Changeset in webkit [134354] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Add an option to switch display of "Other" memory on/off in NMI
https://bugs.webkit.org/show_bug.cgi?id=101601
Patch by Alexei Filippov <alph@chromium.org> on 2012-11-12
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- 8:55 PM Changeset in webkit [134353] by
-
- 4 edits in trunk/Source
Build fix after r134346 and 134347.
Use frameView.isFlipped, not frameView.flipped in the assertion.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]):
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow):
- 8:51 PM Changeset in webkit [134352] by
-
- 6 edits2 adds in trunk
BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with themselves
https://bugs.webkit.org/show_bug.cgi?id=101854
Reviewed by Andreas Kling.
Source/WebCore:
The basic shapes BasicShapeCircle, BasicShapeEllipse and BasicShapeRectangle should
blend with themselves. This patch introduces simple interpolation of BasicShapes for
the -webkit-clip-path property.
Test: css3/masking/clip-path-animation.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Added a new function that blends between two BasicShape objects.
It skips blending on <clipPath> references, polygons and if the shapes are not of
the same type.
(WebCore):
(PropertyWrapperClipPath): Added new wrapper for ClipPathShapes.
(WebCore::PropertyWrapperClipPath::PropertyWrapperClipPath): Ditto.
(WebCore::CSSPropertyAnimation::ensurePropertyMap): Add -webkit-clip-path to animatable
properties.
- rendering/style/BasicShapes.cpp:
The blending is done by each shape itself. This is similar to FilterOperations or
TransformOperations.
(WebCore::BasicShapeRectangle::blend):
(WebCore):
(WebCore::BasicShapeCircle::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
- rendering/style/BasicShapes.h:
Added new blending functions to header.
(BasicShape):
(BasicShapeRectangle):
(BasicShapeCircle):
(BasicShapeEllipse):
(BasicShapePolygon):
LayoutTests:
Added an animtation test for -webkit-clip-path and tested the basic shapes.
- animations/resources/animation-test-helpers.js:
(parseBasicShape):
(basicShapeParametersMatch):
(getPropertyValue):
(comparePropertyValue):
- css3/masking/clip-path-animation-expected.txt: Added.
- css3/masking/clip-path-animation.html: Added.
- 8:46 PM Changeset in webkit [134351] by
-
- 4 edits in trunk/Source/WebCore
[V8] We should be able to get V8PerContextData from a v8::Context more quickly
https://bugs.webkit.org/show_bug.cgi?id=102008
Reviewed by Ojan Vafai.
This patch uses the new v8::Context::GetAlignedPointerFromEmbedderData
API to get the V8PerContextData associated with a v8::Context much more
quickly. We no longer need to use a hidden property on the inner global
object. This patch will enable future optimizations.
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):
- bindings/v8/V8PerContextData.h:
(WebCore::V8PerContextData::from):
- 8:44 PM Changeset in webkit [134350] by
-
- 4 edits in trunk/Source/WebCore
Make Frames and HTMLFrameOwnerElement less friendly
https://bugs.webkit.org/show_bug.cgi?id=102003
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-12
Reviewed by Ojan Vafai.
Frame used to assign HTMLFrameOwnerElement's m_contentFrame directly
this patch makes it go through a method to allow future hooks when frames
are associated with owners.
No new tests, this is just a refactor.
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::setContentFrame):
- html/HTMLFrameOwnerElement.h:
(HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::clearContentFrame):
- page/Frame.cpp:
(WebCore::Frame::Frame): Use new methods.
- 8:40 PM Changeset in webkit [134349] by
-
- 3 edits in trunk/WebKitLibraries
Build fix. Forgot these bits last time.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 8:26 PM Changeset in webkit [134348] by
-
- 9 edits in trunk
Zoomed-in scrolling is very slow when deviceScaleFactor > 1
https://bugs.webkit.org/show_bug.cgi?id=101787
Reviewed by Simon Fraser.
Source/WebCore:
This patch adds a new member to the GraphicsContextState that tracks
whether or not fonts should be subpixel-quantized. We want to default
to sibpixel-quantizing, but we'll turn it off if we're scrolling
content that cannot be scrolled on the scrolling thread.
State has a new bool shouldSubpixelQuantizeFonts. It defaults to true
since normally we do want to quantize.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setShouldSubpixelQuantizeFonts):
(WebCore::GraphicsContext::shouldSubpixelQuantizeFonts):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):
wkSetCGFontRenderingMode now takes a BOOL parameter which indicates
whether or not it should try to subpixel-quantize the fonts.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Disable subpixel-quantization for overflow areas, subframes, and
content that is scrolling on the main thread.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
WebKitLibraries:
wkSetCGFontRenderingMode now takes a BOOL parameter.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 8:05 PM Changeset in webkit [134347] by
-
- 5 edits1 add in trunk/Source/WebKit
Add a dock button to the top right corner of the Web Inspector window (similar to the full screen button).
https://bugs.webkit.org/show_bug.cgi?id=102025
Reviewed by Joseph Pecoraro.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Added Dock.pdf.
Source/WebKit/mac:
- Resources/Dock.pdf: Added.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindow _cursorForResizeDirection:]): Added.
(WebInspectorClient::didResizeMainFrame): Call attachAvailabilityChanged instead.
(WebInspectorFrontendClient::attachAvailabilityChanged): Added.
(-[WebInspectorWindowController window]): Create the dock button and add it.
(-[WebInspectorWindowController attachWindow:]): Added.
(-[WebInspectorWindowController attach]): Call setAttachedWindow.
(-[WebInspectorWindowController detach]): Ditto.
(-[WebInspectorWindowController setDockingUnavailable:]): Added. Update hidden state of the dock button.
- 8:05 PM Changeset in webkit [134346] by
-
- 15 edits2 adds in trunk/Source
Add a dock button to the top right corner of the Web Inspector window (similar to the full screen button).
Source/WebCore: Expose InspectorFrontendClientLocal::setAttachedWindow as public.
This allows external actions to update the docked state in the frontend.
https://bugs.webkit.org/show_bug.cgi?id=102023
Reviewed by Anders Carlsson.
- inspector/InspectorFrontendClientLocal.h:
Moved InspectorFrontendClientLocal::setAttachedWindow to public section.
Source/WebKit2: Add a dock button to the top right corner of the Web Inspector window (similar to the full screen button).
https://bugs.webkit.org/show_bug.cgi?id=102023
Reviewed by Anders Carlsson.
- Resources/Dock.pdf: Added.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Set the SetAttachedWindow message.
(WebKit::WebInspectorProxy::detach): Ditto.
(WebKit::WebInspectorProxy::attachAvailabilityChanged): Added. Call platformAttachAvailabilityChanged.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Added AttachAvailabilityChanged message.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter attach:]): Added. Call WebInspectorProxy::attach.
(-[WKWebInspectorWindow _cursorForResizeDirection:]): Added.
(WebKit::WebInspectorProxy::createInspectorWindow): Create the dock button and add it.
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Added. Update hidden state of the dock button.
- WebKit2.xcodeproj/project.pbxproj: Added Dock.pdf.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::setAttachedWindow): Added. Call through to the frontend client.
(WebKit::WebInspector::updateDockingAvailability): Send AttachAvailabilityChanged message.
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in: Added SetAttachedWindow message.
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Added stub.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Ditto.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Ditto.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Ditto.
- 8:03 PM Changeset in webkit [134345] by
-
- 53 edits in trunk
Replace DOMException TYPE_MISMATCH_ERR with TypeError
https://bugs.webkit.org/show_bug.cgi?id=101604
Reviewed by Adam Barth.
Source/WebCore:
DOMException.TYPE_MISMATCH_ERR is deprecated in favor of using TypeError.
We have historically used TYPE_MISMATCH_ERR as a blanket DOMException code when
the spec mandates TypeError being thrown.
Updated existing tests.
- Modules/mediastream/MediaConstraintsImpl.cpp:
- Modules/mediastream/MediaStreamTrackList.cpp:
- Modules/mediastream/PeerConnection00.cpp:
- Modules/mediastream/RTCDataChannel.cpp:
- Modules/mediastream/RTCIceCandidate.cpp:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/mediastream/RTCSessionDescription.cpp:
- Modules/mediastream/SessionDescription.cpp:
- bindings/js/CallbackFunction.cpp:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- bindings/js/JSHTMLSelectElementCustom.cpp:
- bindings/js/JSMutationObserverCustom.cpp:
- bindings/js/JSSQLResultSetRowListCustom.cpp:
- bindings/js/JSSQLTransactionCustom.cpp:
- bindings/js/JSSQLTransactionSyncCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Callback.h:
- bindings/v8/V8Collection.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8MutationObserverCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
- dom/DOMCoreException.idl:
- html/HTMLElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLOptionsCollection.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- page/Crypto.cpp:
- page/DOMSelection.cpp:
- svg/properties/SVGTransformListPropertyTearOff.h:
LayoutTests:
Update the tests to test for TypeError instead of DOMException with the TYPE_MISMATCH_ERR code.
- canvas/philip/tests/2d.drawImage.null.html:
- canvas/philip/tests/2d.imageData.put.null.html:
- canvas/philip/tests/2d.pattern.image.null.html:
- editing/selection/extend-expected.txt:
- fast/dom/Geolocation/argument-types-expected.txt:
- fast/dom/Geolocation/not-enough-arguments-expected.txt:
- fast/dom/Geolocation/script-tests/argument-types.js:
- fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
- fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
- fast/js/select-options-add-expected.txt:
- fast/mediastream/RTCIceCandidate-expected.txt:
- fast/mediastream/RTCPeerConnection-expected.txt:
- fast/mediastream/RTCSessionDescription-expected.txt:
- fast/mediastream/SessionDescription-expected.txt:
- fast/mediastream/peerconnection-addstream-expected.txt:
- fast/mediastream/peerconnection-iceoptions-expected.txt:
- fast/mediastream/peerconnection-iceoptions.html:
- fast/mediastream/peerconnection-removestream-expected.txt:
- media/encrypted-media/encrypted-media-syntax.html:
- media/video-test.js:
- platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
- security/crypto-random-values-types-expected.txt:
- svg/dom/SVGTransformList-expected.txt:
- 8:01 PM Changeset in webkit [134344] by
-
- 2 edits in trunk/Tools
Perl errors from Tools/Scripts/copy-webkitlibraries-to-product-directory
https://bugs.webkit.org/show_bug.cgi?id=101980
Reviewed by Mark Rowe.
Remove library libWebKitSystemInterfaceLeopard.a and libWebKitSystemInterfaceSnowLeopard.a
from the list of libraries to copy to the specified built products directory
as these libraries were removed from the repository in <http://trac.webkit.org/changeset/133670>.
- Scripts/copy-webkitlibraries-to-product-directory:
- 7:38 PM Changeset in webkit [134343] by
-
- 3 edits in trunk/LayoutTests
IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101990
Reviewed by Tony Chang.
Race condition in test leads to flaky behavior. Refactor test to remove flake
and clean up output.
- storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
- storage/indexeddb/resources/cursor-prev-no-duplicate.js:
(testFarRangeCursor_closed):
(.trans.oncomplete):
(.storeReq.onsuccess):
(runTest):
- 7:09 PM Changeset in webkit [134342] by
-
- 7 edits in trunk/Source/WebCore
IndexedDB: Use sequence<> instead of DOMString[] in IDL
https://bugs.webkit.org/show_bug.cgi?id=100539
Reviewed by Adam Barth.
In the binding layer, DOMString[] is implemented as an alias for DOMStringList.
WebIDL usage is tending towards sequence<DOMString> anyway for inputs, so switch
to that. Note webkit.org/b/100537 which requires sequence<String> instead.
Covered by storage/indexeddb/transaction-basics.html and objectstore-basics.html
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction): DOMStringList -> Vector<String>
- Modules/indexeddb/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
(IDBDatabase):
- Modules/indexeddb/IDBDatabase.idl: DOMString[] -> sequence<String>
- Modules/indexeddb/IDBObjectStore.cpp: Move trivial impls to header.
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::createIndex):
- Modules/indexeddb/IDBObjectStore.idl: DOMString[] -> sequence<String>
- 6:48 PM Changeset in webkit [134341] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
Rebase after r134287.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
- 6:48 PM Changeset in webkit [134340] by
-
- 3 edits in trunk/Source/WebCore
Remove Leopard only gradient code
https://bugs.webkit.org/show_bug.cgi?id=102033
Reviewed by Dan Bernstein.
USE_CG_SHADING was only ever true on Leopard, so we can remove it now.
- platform/graphics/Gradient.h:
- platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::platformGradient):
(WebCore::Gradient::paint):
- 6:47 PM Changeset in webkit [134339] by
-
- 4 edits in trunk/Source/WebKit/gtk
Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378
Patch by Josh Rickmar <jrick@devio.us> on 2012-11-12
Reviewed by Martin Robinson.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 6:28 PM Changeset in webkit [134338] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 237003
Internally Reviewed by Eli Fidler.
Since we nolonger use small font for form controls, adjust paddingDivisor
ratio to decrease the padding value.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
- 6:22 PM Changeset in webkit [134337] by
-
- 2 edits in branches/chromium/1312/Source/WebKit/chromium
Merge 134009 - WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
https://bugs.webkit.org/show_bug.cgi?id=93800
Reviewed by Kent Tamura.
We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close): Set m_closing to true.
TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11312201
- 6:10 PM Changeset in webkit [134336] by
-
- 6 edits in trunk/Source/WebKit2
Include child layers in the remote layer tree transaction
https://bugs.webkit.org/show_bug.cgi?id=102026
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode child layer IDs.
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
Grab all child layer IDs and stick them in a vector.
(WebKit::dumpChangedLayers):
Dump child layer IDs as well.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::setChildren):
(WebKit::RemoteGraphicsLayer::addChild):
(WebKit::RemoteGraphicsLayer::addChildAtIndex):
(WebKit::RemoteGraphicsLayer::addChildAbove):
(WebKit::RemoteGraphicsLayer::addChildBelow):
(WebKit::RemoteGraphicsLayer::replaceChild):
Call noteSublayersChanged.
(WebKit::RemoteGraphicsLayer::noteSublayersChanged):
Note that the Children property changed.
- 6:09 PM Changeset in webkit [134335] by
-
- 9 edits in trunk/LayoutTests
IndexedDB: Convert some non-simple tests from setVersion to upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=101959
Reviewed by Tony Chang.
Ongoing work to remove calls to setVersion from our tests before
removing it from the IndexedDB API.
- storage/indexeddb/create-and-remove-object-store-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/resources/create-and-remove-object-store.js: Create and delete were running between open and setVersion, which no longer makes sense.
- storage/indexeddb/resources/database-deletepending-flag.js: Use optional object parameter instead of optional version parameter.
- storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js: This used to call delete just after issuing setVersion but before receiving the corresponding success event. Now it calls delete while in the upgradeneeded transaction, still causing the delete to be delayed by an in flight versionchange transaction.
- storage/indexeddb/resources/duplicates.js: Call indexedDBTest twice to rerun the tests with a different database.
- storage/indexeddb/resources/shared.js: Added a suffix option to support duplicates.js, switched to an optional object parameter.
- 6:09 PM Changeset in webkit [134334] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix windowRect calculation for webplugin due to page scale factors
https://bugs.webkit.org/show_bug.cgi?id=100182
Patch by Min Qin <qinmin@chromium.org> on 2012-11-12
Reviewed by Adam Barth.
The current calculaton of windowRect in WebPluginContainerImpl is wrong. Even after some of our latest changes.
The problem is caused by page scale factor.
For example, windowToContents(IntPoint) will return an unscaled offset for an iframe, but will return a scaled offset for the main frame. So in order to obtain the correct window coordinate, we need to use contentsToWindow().
Since webview_plugin.cc is expecting window coordinates, we need to use contentsToWindow(IntRect) to calculate the windowRect so that the rect size can get correctly scaled.
It is difficult to write a test for this because it's pixel-based, and plugin placeholder is managed on the Chromium side (webview_plugin.cc).
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
- 6:01 PM Changeset in webkit [134333] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Ensure we only receive one KeyUp per key event
https://bugs.webkit.org/show_bug.cgi?id=101967
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-12
Reviewed by Rob Buis.
We are creating synthetic KeyUps too often, and get into trouble since IMF will send up a KeyUp on all key events.
Furthermore, these KeyUps can arrive both when we are composing and not. To bypass this check, we are storing the KeyDown
character and comparing against it on KeyUp.
Internally reviewed by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::insertText):
(BlackBerry::WebKit::InputHandler::setText):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 5:55 PM Changeset in webkit [134332] by
-
- 8 edits in trunk/Source/JavaScriptCore
Patching of jumps to stubs should use jump replacement rather than branch destination overwrite
https://bugs.webkit.org/show_bug.cgi?id=101909
Reviewed by Geoffrey Garen.
This saves a few instructions in inline cases, on those architectures where it is
easy to figure out where to put the jump replacement. Sub-1% speed-up across the
board.
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::canJumpReplacePatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerX86::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerX86_64::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatch):
(RepatchBuffer):
(JSC::RepatchBuffer::replaceWithJump):
(JSC::RepatchBuffer::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::revertJumpTo_movq_i64r):
(JSC::X86Assembler::revertJumpTo_cmpl_im_force32):
(X86InstructionFormatter):
- bytecode/StructureStubInfo.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::replaceWithJump):
(DFG):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- 5:26 PM Changeset in webkit [134331] by
-
- 7 edits in trunk/Source/WebKit2
Send along the current remote layer tree transaction with the commit message
https://bugs.webkit.org/show_bug.cgi?id=102014
Reviewed by Tim Horton.
Add encode and decode member functions to RemoteLayerTreeTransaction and RemoteLayerTreeTransaction::LayerProperties.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::flushLayers):
- 5:13 PM Changeset in webkit [134330] by
-
- 2 edits in trunk/Source/WebCore
Fix filter dirty rect regression from r134311
https://bugs.webkit.org/show_bug.cgi?id=102002
Reviewed by Beth Dakin.
When rendering with filters, the code can inflate the root-relative
paintDirtyRect in RenderLayer::paintLayerContents(), and my cleanup
broke this behavior.
Fix by making a local copy of LayerPaintingInfo, updating its paintDirtyRect,
and using it for the rest of the function.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
- 5:04 PM Changeset in webkit [134329] by
-
- 2 edits in trunk/Source/WebCore
[V8] V8Event::valueAccessorGetter() in custom binding is not used
https://bugs.webkit.org/show_bug.cgi?id=101893
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/custom/V8EventCustom.cpp:
- 5:03 PM Changeset in webkit [134328] by
-
- 7 edits in trunk/Source/WebKit2
Get rid of the CrossOriginRedirectReceived message to the NetworkProcess.
https://bugs.webkit.org/show_bug.cgi?id=102010
Reviewed by Alexey Proskuryakov.
This message was a stop-gap measure for when the NetworkProcess did scheduling but not loading.
Now that the NetworkProcess does loading it doesn't need to be told when redirect is received.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in: Get rid of the message to the NetworkProcess.
- NetworkProcess/NetworkRequest.cpp:
(WebKit::NetworkRequest::willSendRequest): After willSendRequest is dispatched to the WebProcess, directly call
"receivedRedirect" on the NetworkResourceLoadScheduler.
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::receivedRedirect): Renamed from crossOriginRedirectReceived, as the
function already checks to see if the redirect was actually cross-origin.
- NetworkProcess/NetworkResourceLoadScheduler.h:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::crossOriginRedirectReceived): A no-op so the WebProcess doesn't
do any host record accounting of its own.
- 4:36 PM Changeset in webkit [134327] by
-
- 4 edits in trunk/Source
Web Inspector: Fix docking behavior on Windows.
https://bugs.webkit.org/show_bug.cgi?id=101978
Reviewed by Brian Weinstein.
There are a number of problems with docking behaviour on Windows.
For starters, it does not ever constrain the inspector's size properly while docked.
It also does not properly set the whether or not the inspector can be docked/undocked.
This patch fixes both issues.
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
Switch order of calling bringToFront and setDockingUnavailable.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::attachWindow):
Call restoreAttachedWindowHeight so that when first loading or reattaching the inspector,
we resize the inspector window properly.
- 4:25 PM Changeset in webkit [134326] by
-
- 7 edits in trunk/Source/WebKit2
PDFPlugin should use PDFKit's context menu instead of the default WebKit one
https://bugs.webkit.org/show_bug.cgi?id=101896
<rdar://problem/12555173>
Reviewed by Anders Carlsson.
Show the context menu that PDFKit vends us instead of the default WebKit one
when PDFPlugin is told to show a context menu.
Also, react to the didChangeContentScaleFactor callback, so that when the context
menu (or HUD) is used to change the scale factor, we can inform PluginView.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Add pdfLayerController:didChangeContentScaleFactor: delegate callback.
Rename tileScaleFactor to contentScaleFactor.
Add rightMouseDown: and menuForEvent: on PDFLayerController.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin):
Add notifyContentScaleFactorChanged, handleContextMenuEvent, and nsEventForWebMouseEvent.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeContentScaleFactor:]): Forward content scale factor changes to PDFPlugin.
(WebKit::PDFPlugin::pdfDocumentDidLoad): Rename tileScaleFactor to contentScaleFactor.
(WebKit::PDFPlugin::geometryDidChange): Rename tileScaleFactor to contentScaleFactor.
(WebKit::eventTypeFromWebEvent): It turns out we can infer whether the mouse is being dragged during a MouseMove event
by whether it has a mouse button associated with it or not, so we don't need to track this state manually.
(WebKit::PDFPlugin::nsEventForWebMouseEvent): Factor the part of handleMouseEvent that creates NSEvents* out into its own function.
(WebKit::PDFPlugin::handleMouseEvent):
Don't track mouseButtonIsDown manually, make use of the new nsEventForWebMouseEvent.
Hand rightMouseDown: to PDFLayerController instead of mouseDown: if necessary.
(WebKit::PDFPlugin::handleContextMenuEvent): Grab the relevant NSMenu from PDFKit and display it.
(WebKit::PDFPlugin::handleKeyboardEvent): Don't pass a bogus mouseButtonIsDown to eventTypeFromWebEvent.
(WebKit::PDFPlugin::notifyContentScaleFactorChanged): Update PluginView and co.'s notion of page scale when
PDFKit changes it (generally from the context menu/HUD). Also update page size and scrollbar size/position.
(WebKit::PDFPlugin::setScrollOffset): Don't call SimplePDFPlugin's implementation, as PDFKit handles invalidation itself.
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::updateGeometry): Rename tileScaleFactor to contentScaleFactor.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::updateGeometry): Rename tileScaleFactor to contentScaleFactor.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Make m_scrollOffset protected.
- 4:23 PM Changeset in webkit [134325] by
-
- 2 edits in trunk/LayoutTests
[EFL] WebKit1 gardening.
Mark fast/repaint/block-selection-gap-stale-cache.html and
fast/repaint/block-selection-gap-stale-cache-2.html as image failures.
- platform/efl-wk1/TestExpectations:
- 4:21 PM Changeset in webkit [134324] by
-
- 9 edits2 copies1 add in trunk/Source/WebKit2
Add a RemoteLayerTreeHost object in the UI process
https://bugs.webkit.org/show_bug.cgi?id=101999
Reviewed by Tim Horton.
Add a (mostly empty) RemoteLayerTreeHost class that will live in the UI process and host the layer tree.
- DerivedSources.make:
Add RemoteLayerTreeHost.messages.in.
- Platform/CoreIPC/MessageID.h:
Add a RemoteLayerTreeHost message class.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addMessageReceiver):
(WebKit::WebProcessProxy::removeMessageReceiver):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
Add a message receiver map to the web process proxy.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
Add a RemoteLayerTreeHost member variable.
- UIProcess/mac/RemoteLayerTreeHost.h:
Add new class.
- UIProcess/mac/RemoteLayerTreeHost.messages.in:
Add new messages file with a single Commit message.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
Add the layer tree host as a message receiver.
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
Remote the layer tree host as a message receiver.
(WebKit::RemoteLayerTreeHost::didReceiveMessage):
Call the generated member function.
(WebKit::RemoteLayerTreeHost::commit):
Add an empty stub for now.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::flushLayers):
Send a commit message to the remote layer tree host.
- 3:55 PM Changeset in webkit [134323] by
-
- 21 edits in trunk/Source/WebCore
[V8] Update callers to use the aligned pointer API rather than the deprecated unaligned pointer API
https://bugs.webkit.org/show_bug.cgi?id=101519
Reviewed by Ojan Vafai.
There should be no change in behavior. The new API is slightly faster
than the old API (and apparently works correctly internally in V8).
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::toNative):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::toNative):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::toNative):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::toNative):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::toNative):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::toNative):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::toNative):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::toNative):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::toNative):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::V8TestNode::toNative):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::toNative):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::toNative):
- bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):
- bindings/v8/V8Collection.h:
(WebCore::toNativeCollection):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::isWrapperOfType):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):
- bindings/v8/WrapperTypeInfo.h:
(WebCore::toNative):
(WebCore::toWrapperTypeInfo):
- 3:52 PM Changeset in webkit [134322] by
-
- 71 edits in trunk/Source/WebCore
Rename AttributeStyle => PresentationAttributeStyle across WebCore.
<http://webkit.org/b/101975>
Rubber-stamped by Antti Koivisto.
The completely separate concepts of "attribute style" and "style attribute" were a bit too
easy to confuse in variable and method names. Reconfigure our terminology to call it
"presentation attribute style" instead of "attribute style".
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/ElementAttributeData.cpp:
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::presentationAttributeStyle):
(WebCore::ElementAttributeData::setPresentationAttributeStyle):
(ElementAttributeData):
- dom/Node.h:
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setPresentationAttributeStyleDirty):
(WebCore::Node::clearPresentationAttributeStyleDirty):
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
- dom/StyledElement.h:
(WebCore::StyledElement::additionalPresentationAttributeStyle):
(StyledElement):
(WebCore::StyledElement::collectStyleForPresentationAttribute):
(WebCore::StyledElement::presentationAttributeStyle):
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForPresentationAttribute):
- html/HTMLBRElement.h:
(HTMLBRElement):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectStyleForPresentationAttribute):
- html/HTMLBodyElement.h:
(HTMLBodyElement):
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForPresentationAttribute):
- html/HTMLDivElement.h:
(HTMLDivElement):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForPresentationAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::addHTMLLengthToStyle):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForPresentationAttribute):
- html/HTMLEmbedElement.h:
(HTMLEmbedElement):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
- html/HTMLFontElement.h:
(HTMLFontElement):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::collectStyleForPresentationAttribute):
- html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForPresentationAttribute):
- html/HTMLHRElement.h:
(HTMLHRElement):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForPresentationAttribute):
- html/HTMLIFrameElement.h:
(HTMLIFrameElement):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::collectStyleForPresentationAttribute):
- html/HTMLImageElement.h:
(HTMLImageElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::collectStyleForPresentationAttribute):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectStyleForPresentationAttribute):
- html/HTMLLIElement.h:
(HTMLLIElement):
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::collectStyleForPresentationAttribute):
- html/HTMLMarqueeElement.h:
(HTMLMarqueeElement):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::collectStyleForPresentationAttribute):
- html/HTMLOListElement.h:
(HTMLOListElement):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::collectStyleForPresentationAttribute):
- html/HTMLObjectElement.h:
(HTMLObjectElement):
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForPresentationAttribute):
- html/HTMLParagraphElement.h:
(HTMLParagraphElement):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::collectStyleForPresentationAttribute):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::collectStyleForPresentationAttribute):
- html/HTMLPreElement.h:
(HTMLPreElement):
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::collectStyleForPresentationAttribute):
- html/HTMLTableCaptionElement.h:
(HTMLTableCaptionElement):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::collectStyleForPresentationAttribute):
(WebCore::HTMLTableCellElement::additionalPresentationAttributeStyle):
- html/HTMLTableCellElement.h:
(HTMLTableCellElement):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::collectStyleForPresentationAttribute):
(WebCore::HTMLTableColElement::additionalPresentationAttributeStyle):
- html/HTMLTableColElement.h:
(HTMLTableColElement):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForPresentationAttribute):
(WebCore::HTMLTableElement::additionalPresentationAttributeStyle):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForPresentationAttribute):
- html/HTMLTablePartElement.h:
(HTMLTablePartElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalPresentationAttributeStyle):
- html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectStyleForPresentationAttribute):
- html/HTMLTextAreaElement.h:
(HTMLTextAreaElement):
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::collectStyleForPresentationAttribute):
- html/HTMLUListElement.h:
(HTMLUListElement):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::collectStyleForPresentationAttribute):
- html/HTMLVideoElement.h:
(HTMLVideoElement):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::collectStyleForPresentationAttribute):
- mathml/MathMLElement.h:
(MathMLElement):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
- svg/SVGImageElement.h:
(SVGImageElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::collectStyleForPresentationAttribute):
- svg/SVGStyledElement.h:
(SVGStyledElement):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute):
- svg/SVGTextContentElement.h:
(SVGTextContentElement):
- 3:50 PM Changeset in webkit [134321] by
-
- 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merge fix for <rdar://problem/12486173>.
- 3:47 PM Changeset in webkit [134320] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Roll Chromium DEPS.
- 3:32 PM Changeset in webkit [134319] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Added more Hi-DPI wont-fixes.
- platform/chromium/TestExpectations: Added wont-fixes.
- 3:30 PM Changeset in webkit [134318] by
-
- 2 edits in trunk/Source/WebCore
[V8] Many things crash when switching to V8's new aligned pointer API
https://bugs.webkit.org/show_bug.cgi?id=101994
Reviewed by Eric Seidel.
When using the aligned pointer API, we need to make sure to initialize
every internal field that we later read because the new API has better
error checks than the old API. This patch explicitly initializes the
enteredIsolatedWorldIndex internal field to zero for main worlds,
fixing the LayoutTest crashes from our previous attempt to move the
aligned pointer API.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- 3:19 PM Changeset in webkit [134317] by
-
- 1 edit in branches/safari-536.28-branch/Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h
ML Build fix.
- 3:11 PM Writing Layout Tests for DumpRenderTree edited by
- Fixed the 'font' property for the cross-platform trick (diff)
- 3:09 PM Changeset in webkit [134316] by
-
- 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merge part 2 of <rdar://problem/12486142>.
- 2:57 PM Changeset in webkit [134315] by
-
- 4 edits in trunk/Source/WebKit2
PDFPlugin should support non-1 device scale factor
https://bugs.webkit.org/show_bug.cgi?id=101923
Reviewed by Alexey Proskuryakov.
Do the appropriate plumbing to ensure that PDFPlugin handles device scale factor > 1
(it's called contentsScaleFactor in plugins), both for normal drawing and for snapshotting.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add deviceScaleFactor setter/getter to PDFLayerController.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Override contentsScaleFactorChanged.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfDocumentDidLoad): Plumb device scale factor through to PDFLayerController.
(WebKit::PDFPlugin::contentsScaleFactorChanged): Plumb device scale factor through to PDFLayerController
when we're notified that it has changed.
(WebKit::PDFPlugin::snapshot): Create snapshots with the device scale factor applied.
- 2:54 PM Changeset in webkit [134314] by
-
- 5 edits12 adds in trunk
DFG ArithMul overflow check elimination is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=101871
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
The code was ignoring the fact that ((a * b) | 0) == (((a | 0) * (b | 0)) | 0)
only holds if a * b < 253. So, I changed it to only enable the optimization
when a < 222 and b is an int32 (and vice versa), using a super trivial peephole
analysis to prove the inequality. I considered writing an epic forward flow
formulation that tracks the ranges of integer values but then I thought better
of it.
This also rewires the ArithMul integer speculation logic. Previously, we would
assume that an ArithMul was only UsedAsNumber if it escaped, and separately we
would decide whether to speculate integer based on a proof of the <222
inequality. Now, we treat the double rounding behavior of ArithMul as if the
result was UsedAsNumber even if it did not escape. Then we try to prove that
double rounding cannot happen by attemping to prove that a < 222. This then
feeds back into the decision of whether or not to speculate integer (if we fail
to prove a < 222 then we're UsedAsNumber, and if we're also MayOverflow then
that forces double speculation).
No performance impact. It just fixes a bug.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::mulShouldSpeculateInteger):
- dfg/DFGPredictionPropagationPhase.cpp:
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
LayoutTests:
- fast/js/dfg-mul-big-integer-with-small-integer-and-bitor-expected.txt: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-and-bitor.html: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-and-detect-overflow-expected.txt: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-and-detect-overflow.html: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-expected.txt: Added.
- fast/js/dfg-mul-big-integer-with-small-integer.html: Added.
- fast/js/dfg-mul-big-integers-expected.txt: Added.
- fast/js/dfg-mul-big-integers.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-mul-big-integer-with-small-integer-and-bitor.js: Added.
(foo):
- fast/js/script-tests/dfg-mul-big-integer-with-small-integer-and-detect-overflow.js: Added.
(foo):
- fast/js/script-tests/dfg-mul-big-integer-with-small-integer.js: Added.
(foo):
- fast/js/script-tests/dfg-mul-big-integers.js: Added.
(foo):
- 2:52 PM Changeset in webkit [134313] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG should not emit function checks if we've already proved that the operand is that exact function
https://bugs.webkit.org/show_bug.cgi?id=101885
Reviewed by Oliver Hunt.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::filterByValue):
(AbstractValue):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 2:45 PM Changeset in webkit [134312] by
-
- 6 edits2 moves in trunk/Source/WebKit2
Rename RemoteLayerTreeController to RemoteLayerTreeContext
https://bugs.webkit.org/show_bug.cgi?id=101993
Reviewed by Andreas Kling.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::create):
(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):
(WebKit::RemoteGraphicsLayer::flushCompositingStateForThisLayerOnly):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeController.h.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeController.mm.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
- 2:42 PM Changeset in webkit [134311] by
-
- 5 edits in trunk/Source/WebCore
Reduce the crazy number of parameters to RenderLayer painting member functions
https://bugs.webkit.org/show_bug.cgi?id=101895
Reviewed by Beth Dakin.
The various RenderLayer::paintLayer* functions took a lot of arguments, most
of which were passed down directly to descendants.
Gather these arguments into a LayerPaintingInfo struct.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint): Create a LayerPaintingInfo struct to pass
to descendant paint calls.
(WebCore::RenderLayer::paintOverlayScrollbars): Ditto.
(WebCore::RenderLayer::paintLayer): When painting transformed layers, we
make a new LayerPaintingInfo because the root layer is shifted.
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::paintPaginatedChildLayer):
(WebCore::RenderLayer::paintChildLayerIntoColumns): Create a new LayerPaintingInfo
struct for column painting.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
(LayerPaintingInfo):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer): Build a LayerPaintingInfo
to enter layer painting.
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::paint): Ditto.
- 2:36 PM Changeset in webkit [134310] by
-
- 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merge part 1 of <rdar://problem/12486142>.
- 2:36 PM Changeset in webkit [134309] by
-
- 6 edits in trunk/Tools
webkitpy: integrate pylint into check-webkit-style, part I
https://bugs.webkit.org/show_bug.cgi?id=101285
Reviewed by Ojan Vafai.
This patch re-works lint-webkitpy so that the logic is pushed
into check-webkit-style (mostly); we don't yet control which
messages are displayed using the rules in webkitpy/style/checker.py
(we're still using the pylintrc to suppress messages instead),
but otherwise things work. For now we will only report pylint
"errors", not warnings.
- Scripts/lint-webkitpy:
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checkers/python.py:
(PythonChecker):
(PythonChecker.check):
(PythonChecker._check_pep8):
(PythonChecker._check_pylint):
(Pylinter):
(Pylinter.init):
(Pylinter.run):
(_FilteredStringIO):
(_FilteredStringIO.init):
(_FilteredStringIO.write):
(_FilteredStringIO._filter):
- Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
- Scripts/webkitpy/style/checkers/python_unittest_input.py:
- 2:33 PM Changeset in webkit [134308] by
-
- 3 edits in trunk/Tools
nrwt: remove a bunch of broken chromium-specific flags
https://bugs.webkit.org/show_bug.cgi?id=101979
Reviewed by Tony Chang.
There were a bunch of chromium-specific flags that used to be
supported by NRWT (and handled and passed on to DRT) but have
probably been broken for a long time and are currently ignored.
This patch removes all of those flags; the rule of thumb going forward
is that we should only add flags that affect how the python code functions.
If a flag is just passed verbatim to DRT, the user can use --additional-drt-flag
for that.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp):
- 2:30 PM Changeset in webkit [134307] by
-
- 3 edits in trunk/Source/WebKit2
Add debug only code to dump the contents of a transaction
https://bugs.webkit.org/show_bug.cgi?id=101991
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::writeIndent):
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::dump):
- 2:26 PM Changeset in webkit [134306] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Updated expectations for calendar-picker.
- platform/chromium/TestExpectations: Updated expectations.
- 2:25 PM Changeset in webkit [134305] by
-
- 4 edits3 copies in branches/safari-536.28-branch
Merged r129440. <rdar://problem/12632312>
- 2:22 PM Changeset in webkit [134304] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] When opening an image it does not scale to fit our window
https://bugs.webkit.org/show_bug.cgi?id=101778
Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.
PR: 230935
For image document, the actual image size can be different with the
contents size. Zoom the document based on the image width so that
images can fit the screen horizontally. Set 2.0 as the maximum zoom to
fit scale for image document so that very small images won't get
ridiculous large scales during the initial load.
- Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):
- 2:21 PM Changeset in webkit [134303] by
-
- 6 edits3 copies in branches/safari-536.28-branch
Merged r126718. <rdar://problem/12625038>
- 2:21 PM Changeset in webkit [134302] by
-
- 2 edits in trunk/LayoutTests
Marked transforms/3d/point-mapping tests as flakey.
https://bugs.webkit.org/show_bug.cgi?id=101988
- platform/chromium/TestExpectations: Added Expectations.
- 2:13 PM Changeset in webkit [134301] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Added expectations for platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html
https://bugs.webkit.org/show_bug.cgi?id=101986
- platform/chromium/TestExpectations: Added expectations.
- 1:59 PM Changeset in webkit [134300] by
-
- 5 edits in trunk/Source/WebKit2
Store name changes in the layer transaction
https://bugs.webkit.org/show_bug.cgi?id=101981
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
Add new LayerProperties class.
(RemoteLayerTreeTransaction):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
Find the changed layer properties for the given layer and apply the changed properties.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(WebKit::RemoteGraphicsLayer::layerID):
Add new getter.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::generateLayerID):
(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):
Give each remote graphics layer a unique ID.
- 1:56 PM Changeset in webkit [134299] by
-
- 12 edits in trunk/Source
NetworkProcess: Use an accurate shouldContentSniff value when creating ResourceHandles
https://bugs.webkit.org/show_bug.cgi?id=101872
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Expose shouldSniffContent to pass it along to the NetworkProcess.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::shouldSniffContent):
Source/WebKit2:
The WebProcess now passes "shouldContentSniff" over to the NetworkProcess with the requests so it can be respected.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleNetworkRequest): Update to pass through "shouldContentSniff"
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkRequest.cpp:
(WebKit::NetworkRequest::NetworkRequest):
(WebKit::NetworkRequest::start):
- NetworkProcess/NetworkRequest.h:
(WebKit::NetworkRequest::create):
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleNetworkRequest): Update to pass through "shouldContentSniff"
- NetworkProcess/NetworkResourceLoadScheduler.h:
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Update to pass through "shouldContentSniff"
- 1:54 PM Changeset in webkit [134298] by
-
- 2 edits in trunk/LayoutTests
[Chromium] WonFixed hi-DPI related tests.
https://bugs.webkit.org/show_bug.cgi?id=90022
- platform/chromium/TestExpectations: Added expectations.
- 1:45 PM Changeset in webkit [134297] by
-
- 2 edits2 deletes in trunk/LayoutTests
Unreviewed, update chromium-mac baselines.
- platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Removed.
- platform/chromium-mac-snowleopard/compositing/repaint/invalidations-on-composited-layers-expected.txt: Removed.
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- 1:45 PM Changeset in webkit [134296] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Supressing a Skia change to prevent layout test breakage.
Unreviewed expectations management.
- skia_webkit.gyp: Added supression 'SK_IGNORE_FAST_BLURRECT=1'
- 1:36 PM Changeset in webkit [134295] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101930
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
Added --device-pixel-ratio command line option to EFL MiniBrowser which sets
the ratio between the CSS units and device pixels when the content is unscaled.
Option is applied for all the views created by mini browser.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 1:26 PM Changeset in webkit [134294] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use keyevents instead of editor commands for backspace
https://bugs.webkit.org/show_bug.cgi?id=101663
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-12
Reviewed by Rob Buis.
PR229395
Sending keyEvents for backspace and switching from KeyChar
to KeyDown since we are still receiving an unadultered KeyUp
from the input service. This was causing us to get two keyUps
for regular keys and no key downs for backspace since it was
triggering an editor command and bypassing JS listeners.
Reviewed internally by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::relativeRightOffset):
(WebKit):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::setText):
- 1:16 PM Changeset in webkit [134293] by
-
- 6 edits in trunk/Source/WebKit2
More work towards packaging layer changes up into a transaction object
https://bugs.webkit.org/show_bug.cgi?id=101969
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::RemoteLayerTreeTransaction):
(WebKit::RemoteLayerTreeTransaction::~RemoteLayerTreeTransaction):
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
Add empty stubs.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::flushCompositingStateForThisLayerOnly):
Call layerPropertiesChanged on the current transaction.
- WebProcess/WebPage/mac/RemoteLayerTreeController.h:
- WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::RemoteLayerTreeController):
Initialize m_currentTransaction till 0.
(WebKit::RemoteLayerTreeController::currentTransaction):
Add getter. This may only be called from beneath flushLayers.
(WebKit::RemoteLayerTreeController::flushLayers):
Create a transaction before flusing the compositing state.
- 1:14 PM Changeset in webkit [134292] by
-
- 1 edit7 adds in trunk/LayoutTests
Unreviewed, update chromium-mac-lion baselines after r134279.
- platform/chromium-mac-lion/fast/repaint/delete-into-nested-block-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/inline-outline-repaint-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/selection-after-delete-expected.png: Added.
- platform/chromium-mac-lion/svg/custom/foreignObject-crash-on-hover-expected.png: Added.
- platform/chromium-mac-lion/svg/custom/hit-test-unclosed-subpaths-expected.png: Added.
- platform/chromium-mac-lion/svg/custom/hit-test-with-br-expected.png: Added.
- 1:10 PM Changeset in webkit [134291] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update expectations for calendar-picker tests..
https://bugs.webkit.org/show_bug.cgi?id=101561
- platform/chromium/TestExpectations: Updated expectations.
- 1:04 PM Changeset in webkit [134290] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r133469. <rdar://problem/12636795>
- 1:02 PM Changeset in webkit [134289] by
-
- 4 edits1 delete in trunk/Source
[chromium] Delete WebCompositor.h
https://bugs.webkit.org/show_bug.cgi?id=101137
Reviewed by James Robinson.
The implementation of this class is getting deleted and all
WebKit-side users are already going via WebCompositorSupport instead.
Source/Platform:
- Platform.gypi:
- chromium/public/WebCompositor.h: Removed.
Source/WebKit/chromium:
- tests/WebCompositorInputHandlerImplTest.cpp:
- 12:58 PM Changeset in webkit [134288] by
-
- 2 edits in trunk/LayoutTests
Unreviewd, update chromium-mac-mountainlion expectations for a few tests.
- platform/chromium/TestExpectations:
- 12:51 PM Changeset in webkit [134287] by
-
- 5 edits in trunk/LayoutTests
Layout Test compositing/repaint/invalidations-on-composited-layers.html is failing/flaky
https://bugs.webkit.org/show_bug.cgi?id=101219
Reviewed by James Robinson.
Force a style recalc before starting repaint tracking.
- compositing/repaint/invalidations-on-composited-layers-expected.txt:
- compositing/repaint/invalidations-on-composited-layers.html:
- platform/chromium/TestExpectations:
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- 12:44 PM Changeset in webkit [134286] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r133379. <rdar://problem/12632315>
- 12:41 PM Changeset in webkit [134285] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r131077. <rdar://problem/12589197>
- 12:38 PM Changeset in webkit [134284] by
-
- 6 edits in branches/safari-536.28-branch/Source
Merged r131018. <rdar://problem/12516363>
- 12:37 PM Changeset in webkit [134283] by
-
- 2 edits in trunk/Source/WebCore
Fix memory leak in createSurfaceForBackingStore()
https://bugs.webkit.org/show_bug.cgi?id=101941
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
Fix memory leak in createSurfaceForBackingStore(),
the RefPtr<cairo_surface_t> should be released
when returned since we pass ownership to the
caller.
No new tests, no behavior change for layout tests.
- platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::createSurfaceForBackingStore):
- 12:34 PM Changeset in webkit [134282] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r130855. <rdar://problem/12655076>
- 12:32 PM Changeset in webkit [134281] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix Chromium DEPS version after accidentally checking in HEAD a couple days ago.
Unreviewed, build fix.
- DEPS:
- 12:32 PM Changeset in webkit [134280] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update to new proxyInfo API
https://bugs.webkit.org/show_bug.cgi?id=101945
Patch by Joe Mason <jmason@rim.com> on 2012-11-12
Reviewed by George Staikos.
Internal PR: 234680
Reviewed internally by: Leo Yang
The proxyAddress, proxyUsername and proxyPassword methods in BlackBerry::Platform::Settings
have been replaced with a single, more efficient proxyInfo method.
No new tests because this is an API update with no behaviour change.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::storeCredentials):
- 12:15 PM Changeset in webkit [134279] by
-
- 8 edits in trunk/LayoutTests
Unreviewed, update chromium-mac-mountainlion baselines.
- platform/chromium-mac/fast/repaint/delete-into-nested-block-expected.png:
- platform/chromium-mac/fast/repaint/inline-outline-repaint-expected.png:
- platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
- platform/chromium-mac/fast/repaint/selection-after-delete-expected.png:
- platform/chromium-mac/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/chromium-mac/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/chromium-mac/svg/custom/hit-test-with-br-expected.png:
- 12:14 PM Changeset in webkit [134278] by
-
- 6 edits in trunk/Source/WebKit2
More work on remote layer flushing
https://bugs.webkit.org/show_bug.cgi?id=101960
Reviewed by Andreas Kling.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::flushCompositingState):
Call recursiveCommitChanges.
(WebKit::RemoteGraphicsLayer::flushCompositingStateForThisLayerOnly):
Add stub function for now.
(WebKit::RemoteGraphicsLayer::recursiveCommitChanges):
Call flushCompositingStateForThisLayerOnly and then call recursiveCommitChanges recursively on all the child layers.
- WebProcess/WebPage/mac/RemoteLayerTreeController.h:
- WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::create):
(WebKit::RemoteLayerTreeController::RemoteLayerTreeController):
This now takes a web page.
(WebKit::RemoteLayerTreeController::setRootLayer):
Add empty function.
(WebKit::RemoteLayerTreeController::layerFlushTimerFired):
Call flushLayers explicitly.
(WebKit::RemoteLayerTreeController::flushLayers):
Force a layout and then sync all the compositing layers.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
RemoteLayerTreeController::create now takes a web page.
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
Call the remote layer tree controller.
- 12:08 PM Changeset in webkit [134277] by
-
- 5 edits1 delete in trunk
remove the chromium-mac-mountainlion TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=101789
Reviewed by Ojan Vafai.
Nearly all of the tests have been updated for 10.8 and the remaining
failures have been merged into the main TestExpectations file. We
don't need this hook any more.
Tools:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.operating_system):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_path_to_image_diff):
LayoutTests:
- platform/chromium-mac-mountainlion/TestExpectations: Removed.
- 11:54 AM Changeset in webkit [134276] by
-
- 1 edit in branches/chromium/1312/Source/WebKit/chromium/src/WebElement.cpp
Merge 133982
BUG=159829
Review URL: https://codereview.chromium.org/11410042
- 11:53 AM Changeset in webkit [134275] by
-
- 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebElement.cpp
Merge 133982
BUG=159829
Review URL: https://codereview.chromium.org/11363202
- 11:50 AM Changeset in webkit [134274] by
-
- 3 edits in branches/chromium/1312
Merge 133610
BUG=159098
Review URL: https://codereview.chromium.org/11377110
- 11:48 AM Changeset in webkit [134273] by
-
- 3 edits in branches/chromium/1271
Merge 133610
BUG=159098
Review URL: https://codereview.chromium.org/11369197
- 11:44 AM Changeset in webkit [134272] by
-
- 2 edits2 copies in branches/chromium/1312
Merge 133717
BUG=158898
Review URL: https://codereview.chromium.org/11360203
- 11:42 AM Changeset in webkit [134271] by
-
- 2 edits2 copies in branches/chromium/1271
Merge 133717
BUG=158898
Review URL: https://codereview.chromium.org/11377109
- 11:36 AM Changeset in webkit [134270] by
-
- 7 edits2 copies in branches/safari-536.28-branch
Merged r129796. <rdar://problem/12589203>
- 11:31 AM Changeset in webkit [134269] by
-
- 3 edits2 copies in branches/chromium/1312
Merge 132983
BUG=158547
Review URL: https://codereview.chromium.org/11364206
- 11:28 AM Changeset in webkit [134268] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r126157.
http://trac.webkit.org/changeset/126157
https://bugs.webkit.org/show_bug.cgi?id=101954
This patch caused (untestable) regression of the volume
property on Mac, Win, and Blackberry ports. (Requested by
jernoble on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::setVolume):
(WebCore::MediaPlayer::setMuted):
(WebCore::MediaPlayer::setPreservesPitch):
(WebCore::MediaPlayer::setSize):
(WebCore::MediaPlayer::setVisible):
(WebCore::MediaPlayer::setPreload):
- 11:24 AM Changeset in webkit [134267] by
-
- 3 edits2 copies in branches/chromium/1312
Merge 132856
BUG=156567
Review URL: https://codereview.chromium.org/11358200
- 11:24 AM Changeset in webkit [134266] by
-
- 3 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merged r129577.
- 11:20 AM Changeset in webkit [134265] by
-
- 6 edits2 adds in trunk
Source/WebCore: Specified width CSS tables should not include border and padding as part of that width.
https://bugs.webkit.org/show_bug.cgi?id=77028
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-12
Reviewed by Julien Chaffraix.
CSS table width should not include border and padding even though HTML
tables size as though their width includes border/padding.
This is applicable for all CSS tables with specified widths.
The change would also make our rendering of CSS tables with specified
width similar to that of Opera, IE and FF.
Test: fast/table/css-table-width-with-border-padding.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
Added check for all (positive) specified widths for CSS tables to
consider border and padding outside of the specified width.
LayoutTests: Specified width CSS tables should not include border and padding as part of that width.
https://bugs.webkit.org/show_bug.cgi?id=77028
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-12
Reviewed by Julien Chaffraix.
- fast/table/css-table-width-with-border-padding-expected.html: Added.
- fast/table/css-table-width-with-border-padding.html: Added.
Test added for verifying that for specified width css tables, border
and padding are not considered as part of the specified table width.
The test also verifies the width values for the different box-sizing
properties viz, content-box, border-box and padding-box.
Out of these padding-box is currently not supported even though
the test verifies against this property as well.
The expected width values added for padding-box are thus incorrect
and should be lesser by 100px (padding value).
- fast/table/min-width-css-block-table-expected.txt:
- fast/table/min-width-css-inline-table-expected.txt:
- fast/table/script-tests/min-width-helpers.js:
Existing test values changed for CSS tables that have percent width
specified since for both these tests, border and padding has been
specified for all the tables.
As a result of this fix, the specified table width shall no longer
include the border and padding values thereby increasing our table
width size by exactly 30px (the value of border and padding in these
tests).
The new values for percent width css tables now match those for FF
and Opera.
- 11:19 AM Changeset in webkit [134264] by
-
- 1 edit3 copies in branches/chromium/1312
Merge 133155
BUG=153228
Review URL: https://codereview.chromium.org/11369193
- 11:18 AM Changeset in webkit [134263] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r126903. <rdar://problem/12516356>
- 11:13 AM Changeset in webkit [134262] by
-
- 6 edits in trunk/Source/WebCore
Move resolving blob references to FormData.
https://bugs.webkit.org/show_bug.cgi?id=101754
Reviewed by Simon Hausmann.
Resolving Blob-references to a set of just File and Data is done similar by several platforms.
This patch adds a generic implementation in FormData and uses that from CFNetwork, Qt and
BlackBerry network implementation.
- platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
(WebCore::FormData::resolveBlobReferences):
- platform/network/FormData.h:
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::setHTTPBody):
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::prepareFormElements):
- 11:12 AM Changeset in webkit [134261] by
-
- 2 edits in trunk/Tools
[Chromium-Android] Restart the device's shell in root before pushing data
https://bugs.webkit.org/show_bug.cgi?id=101944
Reviewed by Adam Barth.
Setting up md5sum and pushing the executable, fonts and test resources was
unintentionally being done prior to executing the "adb root" command,
which restarts the device's shell to be root. Since test data is still
being pushed to /data/local/tmp, writing to which requires root access,
devices not running as root would throw a ScriptError.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._setup_test):
- 11:10 AM Changeset in webkit [134260] by
-
- 3 edits2 copies in branches/chromium/1271
Merge 132983
BUG=158547
Review URL: https://codereview.chromium.org/11360201
- 11:04 AM Changeset in webkit [134259] by
-
- 7 edits2 copies in trunk/Source/WebKit2
Layer property changes should schedule a remote layer flush
https://bugs.webkit.org/show_bug.cgi?id=101951
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
New class. For now this just contains the changed layer properties flags but this will be extended
to cover changed layers as well.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):
Initialize m_uncommittedLayerChanges.
(WebKit::RemoteGraphicsLayer::setName):
Set the name and call noteLayerPropertiesChanged.
(WebKit::RemoteGraphicsLayer::noteLayerPropertiesChanged):
Notify that a flush is required (if required).
- WebProcess/WebPage/mac/RemoteLayerTreeController.h:
Add a layer flush timer.
- WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::RemoteLayerTreeController):
Initialize the layer flush timer.
(WebKit::RemoteLayerTreeController::scheduleLayerFlush):
Schedule the layer flush timer if needed.
(WebKit::RemoteLayerTreeController::layerFlushTimerFired):
Empty stub for now.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
Call the remote layer tree controller.
- 11:03 AM Changeset in webkit [134258] by
-
- 3 edits2 copies in branches/chromium/1271
Merge 132856
BUG=156567
Review URL: https://codereview.chromium.org/11293229
- 10:58 AM Changeset in webkit [134257] by
-
- 1 edit3 copies in branches/chromium/1271
Merge 133155
BUG=153228
Review URL: https://codereview.chromium.org/11275265
- 10:43 AM Changeset in webkit [134256] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash in InRegionScrollerPrivate.
https://bugs.webkit.org/show_bug.cgi?id=101399
Reviewed by Yong Li.
Fix warning caused by the previous patch for this bug (r133679).
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 10:36 AM Changeset in webkit [134255] by
-
- 2 edits in trunk/Source/WebCore
GraphicsSurfaceGLX does not handle transparency correctly.
https://bugs.webkit.org/show_bug.cgi?id=101943
GraphicsSurfacGLX must consistently use RGBA texture format.
glXCreateWindow must be called after creating the XWindow
that serves as a temporary offscreen texture storage, in order
to allow for transparency.
When creating the offscreen XWindow we must make sure,
that we use a framebuffer configuration that supports
an alpha mask.
Reviewed by Noam Rosenthal.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- 10:19 AM Changeset in webkit [134254] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r134225.
http://trac.webkit.org/changeset/134225
https://bugs.webkit.org/show_bug.cgi?id=101948
Appears to have broken the EFL and GTK builds (Requested by
abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore):
(WebCore::JSHTMLElement::itemValue):
(WebCore::JSHTMLElement::setItemValue):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
(WebCore::V8HTMLElement::itemValueAccessorSetter):
- html/HTMLElement.idl:
- 10:13 AM Changeset in webkit [134253] by
-
- 2 edits in trunk/Source/WebCore
hitTestResultAtPoint does two hit-tests if called on non main frame
https://bugs.webkit.org/show_bug.cgi?id=101915
Reviewed by Antonio Gomes.
Always redirect hitTestResultAtPoint to the main-frame. This used to being
done on every result that hit anything, which caused running the expensive
hit-tests multiple times in almost all cases.
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- 10:06 AM Changeset in webkit [134252] by
-
- 198 edits in trunk/LayoutTests
IndexedDB: convert tests from setVersion to upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=101676
Reviewed by Tony Chang.
A la bug 92037, add a function to shared.js that sets up the database
for tests where opening and versioning isn't the focus.
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/createObjectStore-null-name-expected.txt: ...many tests and expected files...
- storage/indexeddb/resources/shared.js: The new utility function indexedDBTest lives here.
- storage/indexeddb/values-odd-types-expected.txt:
- 9:59 AM Changeset in webkit [134251] by
-
- 7 edits in trunk/Source/WebKit2
[EFL] Add implementations of device - user conversion methods
https://bugs.webkit.org/show_bug.cgi?id=101938
Reviewed by Laszlo Gombos.
Consider the deviceScaleFactor when convertion to/from user
and device units.
This affects DOM API's such as window.moveTo, resizeTo etc.
- UIProcess/efl/PageClientBase.cpp:
- UIProcess/efl/PageClientBase.h:
(PageClientBase):
- UIProcess/efl/PageClientDefaultImpl.cpp:
(WebKit::PageClientDefaultImpl::convertToDeviceSpace):
(WebKit):
(WebKit::PageClientDefaultImpl::convertToUserSpace):
- UIProcess/efl/PageClientDefaultImpl.h:
(PageClientDefaultImpl):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::convertToDeviceSpace):
(WebKit):
(WebKit::PageClientLegacyImpl::convertToUserSpace):
- UIProcess/efl/PageClientLegacyImpl.h:
(PageClientLegacyImpl):
- 9:57 AM Changeset in webkit [134250] by
-
- 12 edits1 delete in trunk/Source
[V8][JSC] ScriptProfileNode::callUID needs not to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=101892
Reviewed by Adam Barth.
Source/JavaScriptCore:
Added callUID(), which enables us to kill custom bindings for ScriptProfileNode::callUID.
- profiler/ProfileNode.h:
(JSC::ProfileNode::callUID):
Source/WebCore:
We can remove [Custom] from callUID in ScriptProfileNode.idl.
No tests. No change in behavior.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSScriptProfileNodeCustom.cpp: Removed.
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
- inspector/ScriptProfileNode.idl:
- 9:50 AM Changeset in webkit [134249] by
-
- 4 edits1 delete in trunk/Source/WebCore
[V8] Performance::memory getter needs not to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=101890
Reviewed by Adam Barth.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/custom/V8PerformanceCustom.cpp: Removed.
- page/Performance.idl:
- 9:42 AM Changeset in webkit [134248] by
-
- 4 edits in trunk/Source/WebCore
[V8][JSC] HTMLOptionsCollection::length needs not to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=101888
Reviewed by Adam Barth.
We can remove [Custom] from getter. It is possible to remove [Custom]
from setter, but it changes the current behavior.
(I think the current implementation of the setter is wrong.
I'll fix it in another patch.)
No tests. No change in behavior.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- html/HTMLOptionsCollection.idl:
- 9:34 AM Changeset in webkit [134247] by
-
- 9 edits in trunk/Source
[EFL][WK2][AC] Black screen when applications use software backend.
https://bugs.webkit.org/show_bug.cgi?id=101659
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Add a utility method to create a cairo_surface_t from a given Evas_Object_Image.
No new tests. Will be covered when running existing tests without enabling openGL.
- platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::createSurfaceForImage):
(WebCore):
- platform/graphics/efl/CairoUtilitiesEfl.h:
(WebCore):
Source/WebKit2:
If creating openGL context fails, automatically fallback to software rendering.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl::hardwareAccelerationEnabled):
(EwkViewImpl):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::ensureRootLayer):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit::LayerTreeRenderer::setAccelerationMode):
(LayerTreeRenderer):
- UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::createDrawingAreaProxy):
- 8:43 AM Changeset in webkit [134246] by
-
- 5 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing header.
Source/WebCore:
- GNUmakefile.am: Remove editing from IDL_PATH since it doesn't
contain idl files anymore.
- GNUmakefile.list.am: Add missing header files.
- 8:34 AM Changeset in webkit [134245] by
-
- 5 edits in trunk
MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level
https://bugs.webkit.org/show_bug.cgi?id=101733
Reviewed by Jochen Eisinger.
Source/WebCore:
This patch adds better verification to MediaConstraintsImpl.
Existing tests expanded to cover this change.
- Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::initialize):
LayoutTests:
This patch adds more tests for MediaConstraints.
- fast/mediastream/RTCPeerConnection-expected.txt:
- fast/mediastream/RTCPeerConnection.html:
- 8:20 AM Changeset in webkit [134244] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r134223.
http://trac.webkit.org/changeset/134223
https://bugs.webkit.org/show_bug.cgi?id=101939
Breaks inspector tests (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
- inspector/front-end/externs.js:
- inspector/front-end/textEditor.css:
- 8:13 AM Changeset in webkit [134243] by
-
- 8 edits in trunk
[Qt] Support ResourceRequest's setTimeoutInterval
https://bugs.webkit.org/show_bug.cgi?id=101731
Reviewed by Simon Hausmann.
Source/WebCore:
Establish a timeout and return the correct error when it is triggered.
Tested by existing http/tests/xmlhttprequest/timeout tests.
- platform/network/ResourceRequestBase.cpp:
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::timeout):
(WebCore::QNetworkReplyHandler::timerEvent):
(WebCore::QNetworkReplyHandler::start):
- platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyHandler):
Tools:
Enable XHR_TIMEOUT now that we support the necessary feature.
- qmake/mkspecs/features/features.pri:
LayoutTests:
Unskip now passing XHR timeout tests.
- platform/qt/TestExpectations:
- 8:06 AM Changeset in webkit [134242] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r134224.
http://trac.webkit.org/changeset/134224
https://bugs.webkit.org/show_bug.cgi?id=101937
asserting on bawts (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
- rendering/style/RenderStyle.h:
- rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::StyleBackgroundData):
- rendering/style/StyleBackgroundData.h:
(WebCore::StyleBackgroundData::color):
(StyleBackgroundData):
- rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
- rendering/style/StyleInheritedData.h:
(StyleInheritedData):
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
- rendering/style/StyleMultiColData.h:
(StyleMultiColData):
- rendering/style/StyleRareInheritedData.cpp:
(SameSizeAsStyleRareInheritedData):
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(WebCore):
(StyleRareInheritedData):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
- 7:51 AM Changeset in webkit [134241] by
-
- 4 edits in trunk/LayoutTests
Layout Test inspector/debugger/dynamic-scripts.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=99338
Unreviewed inspector tests flakiness fix.
- http/tests/inspector-enabled/dynamic-scripts.html:
- inspector/debugger/dynamic-scripts.html:
- platform/chromium/TestExpectations:
- 7:43 AM Changeset in webkit [134240] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 236993
Internally Reviewed by Jeff Rogers.
Use slide and paint method on slider range and media controls.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::drawThreeSliceHorizontal):
(WebCore::drawThreeSliceVertical):
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
- 7:38 AM Changeset in webkit [134239] by
-
- 12 edits in trunk/Source/WebCore
Refactoring: set read-only values on layout in DateTimeEditElement
https://bugs.webkit.org/show_bug.cgi?id=101916
Reviewed by Kentaro Hara.
We have always updated read-only values when we set an empty value or
DateTimeFieldsState. It has wasted CPU time because such read-only
values are never updated after layout() essentially. So, we set
read-only values in DateTimeEditBuilder used by layout(), and remove
dateForReadOnlyField arguments of setEmptyValue and
setValueAsDateTimeFieldsState.
No new tests. This should not make behavior changes.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):
We removed dateForReadOnlyField argument because read-only values are
already set in DateTimeFieldElement::layout().
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField):
Set a value to a read-only minute/second/millisecond field while
building UI elements.
Also, changed variable types for millisecond and second fields to
RefPtr<DateTimeNumericFieldElement> because we'd like to call
setValueAsDate, which is private in DateTimeMillisecondFieldElement and
DateTimeSecondFieldElement
(WebCore::DateTimeEditElement::setValueAsDateTimeFieldsState):
We removed dateForReadOnlyField argument because read-only values are
already set in DateTimeFieldElement::layout().
(WebCore::DateTimeEditElement::setEmptyValue): Ditto.
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement):
Removed dateForReadOnlyField argument for setValueAsDateTimeFieldsState.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
We removed dateForReadOnlyField argument because read-only values are
already set in DateTimeFieldElement::layout().
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Ditto.
- html/shadow/DateTimeFieldElements.cpp: Ditto.
- html/shadow/DateTimeFieldElements.h: Ditto.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
It should do nothing if it is read-only because a read-only value was
already set just after construction.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
Removed dateForReadOnlyField argument of setEmptyValue.
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue): Ditto.
- html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement): Ditto.
- 7:27 AM Changeset in webkit [134238] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::findText
Reviewed by Simon Hausmann.
Details of the failure:
FAIL! : tst_QWebPage::findText() Compared values are not the same
Actual (m_page->selectedHtml().trimmed().replace(regExp, "")): <span>foo</span>
Expected (subString): foo
Loc: home/joce/dev/webkit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2964)
The format returned by selectedHtml changed.
Make the test a bit more robust by just checking that the HTML
contains our search value.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::findText):
- 7:27 AM Changeset in webkit [134237] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::testLocalStorageVisibility
Reviewed by Simon Hausmann.
window.localStorage is expected to work for file URLs.
I'm not sure why it did work when this test was written,
but I believe that it had the wrong expected value.
- tests/qwebpage/tst_qwebpage.cpp:
- 7:26 AM Changeset in webkit [134236] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QObjectBridge::callQtInvokable
Reviewed by Simon Hausmann.
Q_DECLARE_METATYPE now calls qRegisterMetaType so just prevent
the value from being wrapped by QVariant since this code shouldn't
be reached anyway.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(MyQObject::myInvokableWithBrushStyleArg):
- 7:26 AM Changeset in webkit [134235] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::inputMethods
Reviewed by Simon Hausmann.
Details of the failure:
FAIL! : tst_QWebPage::inputMethods(QWebView) Compared values are not the same
Actual (page->settings()->fontFamily(QWebSettings::SerifFont)): FooSerifFont
Expected (font.family()): Helvetica
Loc: [Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1691)]
The issue was that WebCore wouldn't find FooSerifFont and would have
RenderStyle::font() return the fallback font it used instead.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
- 7:26 AM Changeset in webkit [134234] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244
Reviewed by Simon Hausmann.
- tests/qwebpage/tst_qwebpage.cpp:
- 7:26 AM Changeset in webkit [134233] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle now works as expected
https://bugs.webkit.org/show_bug.cgi?id=60372
Reviewed by Simon Hausmann.
Update the expected value to follow this comment in StylePropertySet::addParsedProperty:
"Only add properties that have no !important counterpart present"
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::style):
- 7:25 AM Changeset in webkit [134232] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] tst_QWebElement::style() fails because QWebElement::CascadedStyle doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=65244
Reviewed by Kenneth Rohde Christiansen.
StyleResolver::styleRulesForElement now takes flags as parameter instead of a bool to specify
that we want to exclude UI and user style sheets.
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::style):
- 7:25 AM Changeset in webkit [134231] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Appending "!important" to the property value of QWebElement::setStyleProperty isn't working
https://bugs.webkit.org/show_bug.cgi?id=101763
Reviewed by Kenneth Rohde Christiansen.
In the pastWebCore have been considering the important token of a CSS
property value if it was followed by !important as well as the
important parameter of setInlineStyleProperty, but not anymore.
Since we need to keep the behavior compatible, do the parsing of the
value and extract the token if present. Ideally this would be passed
as a parameter to the function but I think it's not worth deprecating
the old mechanism.
The parsing is pretty dumb, so this will break applications that
passed a value with spaces between the "!" and "important".
This fixes part of tst_QWebElement::style
- Api/qwebelement.cpp:
(QWebElement::setStyleProperty):
- 7:25 AM Changeset in webkit [134230] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix URL issues in tst_qwebframe
https://bugs.webkit.org/show_bug.cgi?id=101741
Reviewed by Simon Hausmann.
- tests/qwebframe/tst_qwebframe.cpp:
(FakeReply::FakeReply):
Properly forward the request URL to our custom reply.
This would cause redirections not to occur. The requestedUrl and setUrlSameUrl tests
would fail because of this.
(tst_QWebFrame::setUrlToInvalid):
- http:/example.com is a valid URL, but not a valid HTTP URL, so remove this check.
- QCOMPARE uses testlib's toString on the QUrls to compare them and it now
also output the error description. Since we want to compare the resulting
URL instead, compare their toEncoded() value.
- 7:24 AM Changeset in webkit [134229] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix a crash in tst_QWebInspector::attachAndDestroy
https://bugs.webkit.org/show_bug.cgi?id=101575
Reviewed by Simon Hausmann.
It can now happen that destroyInspectorView is called when the Page
is destroyed. This would call getOrCreateInspector and re-create a
QWebInspector.
Since the new instance is created after our setInspector(0) cleanup
in ~QWebPagePrivate, this runs into the same crash that this line was
protecting us against.
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorFrontendClientQt::destroyInspectorView):
- 7:24 AM Changeset in webkit [134228] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::inputMethods on Qt5
https://bugs.webkit.org/show_bug.cgi?id=101571
Reviewed by Simon Hausmann.
QEvent::RequestSoftwareInputPanel isn't passed through event filters anymore.
Use QInputMethodPrivate::testContext instead to capture input method events,
the same way as qtbase tests like tst_QTextEdit are doing.
- tests/qwebpage/tst_qwebpage.cpp:
(TestInputContext::TestInputContext):
(TestInputContext::~TestInputContext):
(TestInputContext):
(TestInputContext::showInputPanel):
(TestInputContext::hideInputPanel):
(TestInputContext::isInputPanelVisible):
(tst_QWebPage::inputMethods):
- 7:20 AM Changeset in webkit [134227] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 236993
Internally Reviewed by Jeff Rogers.
Enable GL slider.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::drawThreeSlice):
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):
- 7:02 AM Changeset in webkit [134226] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r134205): gardening. Skipped 2 failing reftests.
https://bugs.webkit.org/show_bug.cgi?id=101933
Patch by János Badics <János Badics> on 2012-11-12
Reviewed by Csaba Osztrogonác.
- platform/qt/TestExpectations:
- 6:57 AM Changeset in webkit [134225] by
-
- 4 edits in trunk/Source/WebCore
[V8][JSC] HTMLElement::itemValue() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101882
Reviewed by Adam Barth.
We can remove a [Custom] IDL attribute.
No tests. No change in behavior.
- bindings/js/JSHTMLElementCustom.cpp:
- bindings/v8/custom/V8HTMLElementCustom.cpp:
- html/HTMLElement.idl:
- 6:42 AM Changeset in webkit [134224] by
-
- 13 edits in trunk/Source/WebCore
RenderStyle: Pack Color members tighter in substructures.
<http://webkit.org/b/101860>
Patch by Andreas Kling <kling@webkit.org> on 2012-11-12
Reviewed by Antti Koivisto.
For RenderStyle substructures (StyleInheritedData, et al.), unfold all WebCore::Color
members into RGBA32/bool variables OR just an RGBA32 if the color can never be invalid.
Memory saved per instance:
- StyleMultiColData: 4 bytes
- StyleBackgroundData: 8 bytes
- StyleInheritedData: 8 bytes
- StyleRareInheritedData: 24 bytes
- StyleRareNonInheritedData: 24 bytes
323kB progression on Membuster3.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
(WebCore::RenderStyle::setVisitedLinkColumnRuleColor):
(WebCore::RenderStyle::setBackgroundColor):
- rendering/style/RenderStyle.h:
- rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::StyleBackgroundData):
- rendering/style/StyleBackgroundData.h:
(WebCore::StyleBackgroundData::color):
(StyleBackgroundData):
- rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
- rendering/style/StyleInheritedData.h:
(StyleInheritedData):
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::setVisitedLinkColumnRuleColor):
- rendering/style/StyleMultiColData.h:
(StyleMultiColData):
(WebCore::StyleMultiColData::visitedLinkColumnRuleColor):
- rendering/style/StyleRareInheritedData.cpp:
(SameSizeAsStyleRareInheritedData):
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
(WebCore::StyleRareInheritedData::setTextStrokeColor):
(WebCore::StyleRareInheritedData::setTextFillColor):
(WebCore::StyleRareInheritedData::setTextEmphasisColor):
(WebCore::StyleRareInheritedData::setVisitedLinkTextStrokeColor):
(WebCore::StyleRareInheritedData::setVisitedLinkTextFillColor):
(WebCore::StyleRareInheritedData::setVisitedLinkTextEmphasisColor):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
(WebCore::StyleRareInheritedData::textStrokeColor):
(WebCore::StyleRareInheritedData::textFillColor):
(WebCore::StyleRareInheritedData::textEmphasisColor):
(WebCore::StyleRareInheritedData::visitedLinkTextStrokeColor):
(WebCore::StyleRareInheritedData::visitedLinkTextFillColor):
(WebCore::StyleRareInheritedData::visitedLinkTextEmphasisColor):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderLeftColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderRightColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderTopColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderBottomColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkOutlineColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBackgroundColor):
- rendering/style/StyleRareNonInheritedData.h:
(WebCore::StyleRareNonInheritedData::visitedLinkBackgroundColor):
(WebCore::StyleRareNonInheritedData::visitedLinkOutlineColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderLeftColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderRightColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderTopColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderBottomColor):
(StyleRareNonInheritedData):
- 6:34 AM Changeset in webkit [134223] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: migrate text editor to mutation observers
https://bugs.webkit.org/show_bug.cgi?id=101841
Reviewed by Vsevolod Vlasov.
Otherwise, we miss notifications on the removed lines.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._handleMutation):
- inspector/front-end/externs.js:
(WebKitMutation):
(WebKitMutationObserver.prototype.observe):
(WebKitMutationObserver.prototype.disconnect):
- 6:33 AM Changeset in webkit [134222] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Flash-plugin starts with wrong width
https://bugs.webkit.org/show_bug.cgi?id=101836
Patch by Allan Sandfeld Jensen <sandfeld@kde.org> on 2012-11-12
Reviewed by Simon Hausmann.
Defer the setWindow call, so that the one time it is called it will have its final size.
- plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
- 6:18 AM Changeset in webkit [134221] by
-
- 16 edits1 copy12 adds in trunk
Remove the V8 custom code for WebSockets constructor
https://bugs.webkit.org/show_bug.cgi?id=100801
Reviewed by Kentaro Hara.
Source/WebCore:
This patch does the following:
1) Modifies the V8 code generator to support overloaded constructors,
the JS generator is fixed to work as before. Proper support for JS will come later.
2) Modifies WebSocket.h/.cpp for the new constructors.
Tested by running WebSockets layout tests.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
(WebCore):
- Modules/websockets/WebSocket.h:
(WebSocket):
- Modules/websockets/WebSocket.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLParser.pm:
(copyAttributes):
(parseExtendedAttributeList):
(parseExtendedAttributes):
(applyExtendedAttributeList):
- bindings/scripts/IDLStructure.pm:
- bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp: Added.
(WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructorsPrivate::WebDOMTestOverloadedConstructorsPrivate):
(WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructorsPrivate):
(WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructors):
(WebDOMTestOverloadedConstructors::operator=):
(WebDOMTestOverloadedConstructors::impl):
(WebDOMTestOverloadedConstructors::~WebDOMTestOverloadedConstructors):
(toWebCore):
(toWebKit):
- bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.h: Added.
(WebCore):
(WebDOMTestOverloadedConstructors):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp: Added.
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestOverloadedConstructors):
(webkit_dom_test_overloaded_constructors_finalize):
(webkit_dom_test_overloaded_constructors_set_property):
(webkit_dom_test_overloaded_constructors_get_property):
(webkit_dom_test_overloaded_constructors_constructed):
(webkit_dom_test_overloaded_constructors_class_init):
(webkit_dom_test_overloaded_constructors_init):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h: Added.
(_WebKitDOMTestOverloadedConstructors):
(_WebKitDOMTestOverloadedConstructorsClass):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h: Added.
(WebKit):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Added.
(WebCore):
(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
(WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertySlot):
(WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
(WebCore::JSTestOverloadedConstructorsPrototype::self):
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::finishCreation):
(WebCore::JSTestOverloadedConstructors::createPrototype):
(WebCore::JSTestOverloadedConstructors::destroy):
(WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::getOwnPropertySlot):
(WebCore::JSTestOverloadedConstructors::getOwnPropertyDescriptor):
(WebCore::jsTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructors::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestOverloadedConstructorsOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestOverloadedConstructorsOwner::finalize):
(WebCore::toJS):
(WebCore::toTestOverloadedConstructors):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h: Added.
(WebCore):
(JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::create):
(WebCore::JSTestOverloadedConstructors::createStructure):
(WebCore::JSTestOverloadedConstructors::impl):
(WebCore::JSTestOverloadedConstructors::releaseImpl):
(WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull):
(JSTestOverloadedConstructorsOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestOverloadedConstructorsPrototype):
(WebCore::JSTestOverloadedConstructorsPrototype::create):
(WebCore::JSTestOverloadedConstructorsPrototype::createStructure):
(WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):
(JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h: Added.
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.mm: Added.
(-[DOMTestOverloadedConstructors dealloc]):
(-[DOMTestOverloadedConstructors finalize]):
(core):
(kit):
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h: Added.
(WebCore):
- bindings/scripts/test/TestOverloadedConstructors.idl: Copied from Source/WebCore/bindings/scripts/test/TestSerializedScriptValueInterface.idl.
- bindings/scripts/test/TestSerializedScriptValueInterface.idl:
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp: Added.
(WebCore):
(TestOverloadedConstructorsV8Internal):
(WebCore::TestOverloadedConstructorsV8Internal::V8_USE):
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetRawTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
(WebCore::V8TestOverloadedConstructors::wrapSlow):
(WebCore::V8TestOverloadedConstructors::derefObject):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h: Added.
(WebCore):
(V8TestOverloadedConstructors):
(WebCore::V8TestOverloadedConstructors::toNative):
(WebCore::V8TestOverloadedConstructors::installPerContextProperties):
(WebCore::V8TestOverloadedConstructors::installPerContextPrototypeProperties):
(WebCore::V8TestOverloadedConstructors::wrap):
(WebCore::toV8):
- bindings/v8/custom/V8WebSocketCustom.cpp:
LayoutTests:
Added test for null argument to WebSocket(url).
- http/tests/websocket/tests/hybi/url-parsing-expected.txt:
- http/tests/websocket/tests/hybi/url-parsing.html:
- platform/chromium-win/websocket/tests/url-parsing-expected.txt:
- platform/chromium/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
- platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
- 6:04 AM Changeset in webkit [134220] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Indentation nit on WebPage
https://bugs.webkit.org/show_bug.cgi?id=101928
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewportSize):
- 5:54 AM Changeset in webkit [134219] by
-
- 9 edits2 adds in trunk/Source/WebCore
[Refactoring] Create SelectRuleFeatureSet for collecting RuleFeatureSet for select attribute
https://bugs.webkit.org/show_bug.cgi?id=101891
Reviewed by Hajime Morita.
We would like to have another class for RuleFeatureSet to collect 'select' attribute features,
since it will have more features than the original RuleFeatureSet has.
Also, some methods of ElementShadow are removed and we provide a method to get SelectRuleFeatureSet itself.
No new tests, no change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ElementShadow.h:
(ElementShadow):
(WebCore::ElementShadow::selectRuleFeatureSet):
(WebCore):
- html/shadow/SelectRuleFeatureSet.cpp: Added.
(WebCore):
(WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet):
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
- html/shadow/SelectRuleFeatureSet.h: Added.
(WebCore):
(SelectRuleFeatureSet):
(WebCore::SelectRuleFeatureSet::hasSelectorForId):
(WebCore::SelectRuleFeatureSet::hasSelectorForClass):
(WebCore::SelectRuleFeatureSet::hasSelectorForAttribute):
- testing/Internals.cpp:
(WebCore::Internals::hasSelectorForIdInShadow):
(WebCore::Internals::hasSelectorForClassInShadow):
(WebCore::Internals::hasSelectorForAttributeInShadow):
- 5:52 AM Changeset in webkit [134218] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Chromium Android (caused by r134216)
Unreviewed.
No new tests.
- platform/text/PlatformLocale.cpp:
(WebCore::Locale::formatDateTime):
- 5:51 AM Changeset in webkit [134217] by
-
- 2 edits in trunk/Tools
Unreviewed. Removing myself from the list of address to CC on EWS
build failure; the CC turned out to just be too noisy so I'm
tracking those in a different way.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(GtkEWS):
- 5:23 AM Changeset in webkit [134216] by
-
- 4 edits in trunk/Source
Add support for week/month to Locale::formatDateTime()
https://bugs.webkit.org/show_bug.cgi?id=101878
Reviewed by Kent Tamura.
Source/WebCore:
Adding support for week/month to Locale::formatDateTime() in preparation for datalist support for <input type=week/month>.
Added Chromium tests LocaleMacTest.formatWeek and LocaleMacTest.formatMonth.
- platform/text/PlatformLocale.cpp:
(WebCore::DateTimeStringBuilder::visitField):
(WebCore::Locale::formatDateTime): Support week and month types.
Source/WebKit/chromium:
- tests/LocaleMacTest.cpp:
(LocaleMacTest::formatWeek): Takes ISO string and returns localized string.
(LocaleMacTest):
(LocaleMacTest::formatMonth): Ditto.
(TEST_F):
- 5:21 AM Changeset in webkit [134215] by
-
- 1 edit94 moves in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed gardening.
Fix my previous gardening commit: s/-actual.png/-expected.png
- platform/qt/css3/filters/effect-reference-ordering-hw-expected.png: Renamed from LayoutTests/platform/qt/css3/filters/effect-reference-ordering-hw-actual.png.
- platform/qt/fast/images/png-suite/test-expected.png: Renamed from LayoutTests/platform/qt/fast/images/png-suite/test-actual.png.
- platform/qt/svg/as-image/image-respects-pageScaleFactor-change-expected.png: Renamed from LayoutTests/platform/qt/svg/as-image/image-respects-pageScaleFactor-change-actual.png.
- platform/qt/svg/as-object/embedded-svg-size-changes-expected.png: Renamed from LayoutTests/platform/qt/svg/as-object/embedded-svg-size-changes-actual.png.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-expected.png: Renamed from LayoutTests/platform/qt/svg/as-object/nested-embedded-svg-size-changes-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-height-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-width-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-height-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-width-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-height-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-width-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTRefElement-dom-href-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-dx-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-dy-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-transform-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-dom-href1-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-dom-href2-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/filters/subRegion-one-effect-expected.png: Renamed from LayoutTests/platform/qt/svg/filters/subRegion-one-effect-actual.png.
- platform/qt/svg/filters/subRegion-two-effects-expected.png: Renamed from LayoutTests/platform/qt/svg/filters/subRegion-two-effects-actual.png.
- 5:11 AM Changeset in webkit [134214] by
-
- 4 edits in trunk
[Qt] Can not load MHTML documents
https://bugs.webkit.org/show_bug.cgi?id=101765
Reviewed by Simon Hausmann.
Source/WebCore:
Recognize common MHTML extensions so that we can recognize MHTML tests on the file-system.
Tested by existing mhtml/ tests.
- platform/qt/MIMETypeRegistryQt.cpp:
(WebCore):
Tools:
Enable MHTML feature.
- qmake/mkspecs/features/features.pri:
- 4:45 AM Changeset in webkit [134213] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a new crashing test.
- platform/qt/TestExpectations:
- 4:39 AM Changeset in webkit [134212] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: Timeline: fix test expectations
https://bugs.webkit.org/show_bug.cgi?id=101737
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-12
Reviewed by Yury Semikhatsky.
The expected order of timeline records of specific types
have been changed: https://bugs.webkit.org/show_bug.cgi?id=101544
This change fixes test expectations.
Also removed expectation that test can fail.
- inspector/timeline/timeline-receive-response-event-expected.txt:
- platform/chromium/TestExpectations: Removed "fail" expectation.
- 4:34 AM Changeset in webkit [134211] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening after 134099 and 134100. Skipped two tests because layoutTestController
needs implementation of setBackingScaleFactor().
Patch by János Badics <János Badics> on 2012-11-12
Reviewed by Csaba Osztrogonác.
- platform/qt/TestExpectations:
- 4:34 AM Changeset in webkit [134210] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add ewk_settings_offline_web_application_cache_enabled set/get APIs
https://bugs.webkit.org/show_bug.cgi?id=101688
Patch by Jiyeon Kim <jiyeon0402.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
Add ewk_settings_offline_web_application_cache_get API to be used for enabling disabling the web application cache.
Add ewk_settings_offline_web_application_cache_set API to be used for getting the web application cache status.
In addition, offline web application cache is enabled by default.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_offline_web_application_cache_enabled_set):
(ewk_settings_offline_web_application_cache_enabled_get):
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- 4:31 AM Changeset in webkit [134209] by
-
- 3 edits13 adds in trunk/LayoutTests
Add tests for month picker
https://bugs.webkit.org/show_bug.cgi?id=101556
Reviewed by Kent Tamura.
Adding tests for month picker.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: Added.
- platform/chromium/TestExpectations: Marking appearance tests as needs rebaseline.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html: Added.
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(selectedMonth): Returns ISO string for selected month.
- 4:31 AM Changeset in webkit [134208] by
-
- 2 edits in trunk/Source/WebCore
Tighten vector in ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray().
<http://webkit.org/b/101850>
Patch by Andreas Kling <akling@apple.com> on 2012-11-12
Reviewed by Antti Koivisto.
Reserve the exact amount of space needed for m_responseContentDispositionEncodingFallbackArray.
222kB progression on Membuster3.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
- 4:24 AM Changeset in webkit [134207] by
-
- 11 edits in trunk
MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
https://bugs.webkit.org/show_bug.cgi?id=101751
Reviewed by Adam Barth.
Source/Platform:
Making some WebRTCDataChannel methods const.
- chromium/public/WebRTCDataChannel.h:
(WebRTCDataChannel):
Source/WebCore:
This patch queues the events until the JS interpreter is in an idle state.
Existing tests cover this patch.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::readyStateChanged):
(WebCore::RTCDataChannel::dataArrived):
(WebCore::RTCDataChannel::error):
(WebCore::RTCDataChannel::scheduleDispatchEvent):
(WebCore):
(WebCore::RTCDataChannel::scheduledEventTimerFired):
- Modules/mediastream/RTCDataChannel.h:
(RTCDataChannel):
- platform/chromium/support/WebRTCDataChannel.cpp:
(WebKit::WebRTCDataChannel::setBufferedAmount):
(WebKit::WebRTCDataChannel::readyStateChanged):
(WebKit::WebRTCDataChannel::dataArrived):
(WebKit::WebRTCDataChannel::error):
Tools:
Makes the data channel mocks to be synchronous instead of asynchronous to be able to
properly test RTCDataChannel event handling.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::sendStringData):
(MockWebRTCPeerConnectionHandler::sendRawData):
LayoutTests:
Adding shouldNotTrow to the send() calls.
- fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- 4:21 AM Changeset in webkit [134206] by
-
- 5 edits in trunk/Source/WebCore
Remove HTMLInputElement dependency from PickerIndicatorElement
https://bugs.webkit.org/show_bug.cgi?id=101913
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-12
Reviewed by Kent Tamura.
Introduced PickerIndicatorOwner interface that replaces the role of hostInput() in
PickerIndicatorElement. It makes easier to add interactions between picker indicator
and its owner without having to add functions to HTMLInputElement.
No new tests. This is just a refactor.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isPickerIndicatorOwnerDisabledOrReadOnly): Added.
(WebCore):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue): Added.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setupDateTimeChooserParameters): Added.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(WebCore):
(BaseMultipleFieldsDateAndTimeInputType): Implements PickerIndicatorOwner.
- html/shadow/PickerIndicatorElement.cpp: Replaced all the use of hostInput() by using PickerIndicatorOwner.
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
(WebCore::PickerIndicatorElement::create):
(WebCore::PickerIndicatorElement::defaultEventHandler):
(WebCore::PickerIndicatorElement::willRespondToMouseClickEvents):
(WebCore::PickerIndicatorElement::didChooseValue):
(WebCore::PickerIndicatorElement::openPopup):
- html/shadow/PickerIndicatorElement.h:
(PickerIndicatorElement): Added a PickerIndicatorOwner member.
(PickerIndicatorOwner): An interface class for communicating picker indicator and its owner.
(WebCore::PickerIndicatorElement::PickerIndicatorOwner::~PickerIndicatorOwner):
(WebCore::PickerIndicatorElement::removePickerIndicatorOwner):
- 4:08 AM Changeset in webkit [134205] by
-
- 8 edits2 adds in trunk
[CSSRegions]Add support for text-shadow in region styling
https://bugs.webkit.org/show_bug.cgi?id=94472
Reviewed by David Hyatt.
Source/WebCore:
Original patch by Andrei Onea.
Add support for text-shadow in region styling (@-webkit-region rule).
In addition to the previously supported region styling properties (background-color and color),
text-shadow requires the computation of an element style in region at layout time.
This patch adds a new method on RenderRegion - ensureRegionStyleForObject - that
can be used to retrieve the object style in region (if already cached) or to compute it
on the spot. When computing the object style in region, we need to compute the style in region
also for the object ancestor, up to the content nodes.
This patch also refactors the way styles in region are computed and stored, because
we can compute the style in region not only at paint time, but also at layout time.
Test: fast/regions/region-style-text-shadow.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::isValidRegionStyleProperty):
Allow text-shadow to be used in region styling.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::styleInRegion):
Retrieve the region style for an InlineBox's renderer, given its RenderRegion.
Compute the style in region if not computed yet.
(WebCore::InlineBox::regionDuringLayout):
Retrieve the region in which an InlineBox is being flowed.
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: Take region styling into account.
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::canCacheObjectStyleInRegion):
Test if we can cache the computed style in region.
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::setChildrenStyleInRegion):
(WebCore::setObjectHasBoxDecorationsFlag):
(WebCore::RenderRegion::setObjectStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
(WebCore::RenderRegion::ensureRegionStyleForObject):
- rendering/RenderRegion.h:
LayoutTests:
Original patch by Andrei Onea.
Added tests for region styling using the text-shadow property.
- fast/regions/region-style-text-shadow-expected.html: Added.
- fast/regions/region-style-text-shadow.html: Added.
- 3:51 AM Changeset in webkit [134204] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r134154.
http://trac.webkit.org/changeset/134154
https://bugs.webkit.org/show_bug.cgi?id=101919
Causes plenty of crashes on GTK and Apple Win builders
(Requested by zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- css/mediaControls.css:
- css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
- html/shadow/MediaControlElements.h:
(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
- html/shadow/MediaControlRootElement.h:
(WebCore):
(MediaControlRootElement):
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::initializeControls):
- html/shadow/MediaControls.h:
(MediaControls):
- platform/Language.cpp:
(WebCore):
- platform/Language.h:
(WebCore):
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- 3:42 AM Changeset in webkit [134203] by
-
- 19 edits in trunk/Tools
[chromium] move TestRunner implementation into WebTestRunner namespace
https://bugs.webkit.org/show_bug.cgi?id=101837
Reviewed by Adam Barth.
That way, we don't get collisions when linking e.g. against chromium's
net test support library.
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(WebTestRunner):
(TestDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.h:
(WebTestRunner):
- 3:23 AM Changeset in webkit [134202] by
-
- 2 edits in trunk/Source/WebCore
'for (x in y)' requires 'var' declaration in ConsoleMessage.js
https://bugs.webkit.org/show_bug.cgi?id=101908
Reviewed by Pavel Feldman.
r134166 should have included a 'var' declaration in its 'for (x in y)'
loop. This patch adds the missing 'var' in order to prevent leakage into
the global context.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
- 3:20 AM Changeset in webkit [134201] by
-
- 2 edits in trunk
[EFL] Turn on error on warnings for "switch"
https://bugs.webkit.org/show_bug.cgi?id=101760
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
Turn on error on warning for "switch" by removing "-Wno-error=switch"
- Source/cmake/WebKitHelpers.cmake:
- 3:07 AM Changeset in webkit [134200] by
-
- 6 edits in trunk
[Qt] MiniBrowser should not strongly depend on QtTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=101775
Introducing HAVE(QTTESTSUPPORT) to allow building
MiniBrowser without QtTestSupport.
This is necessary when using a production build.
Reviewed by Tor Arne Vestbø.
Source/WebCore:
- Target.pri:
- platform/qt/QtTestSupport.h:
Tools:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
- qmake/mkspecs/features/configure.prf:
- qmake/mkspecs/features/features.prf:
- 2:13 AM Changeset in webkit [134199] by
-
- 5 edits in trunk
Web Inspector: wasShown is called twice when show() is called from within wasShown
https://bugs.webkit.org/show_bug.cgi?id=101858
Reviewed by Vsevolod Vlasov.
Source/WebCore:
When we attach views lazily from within wasShown, the views were getting wasShown notification twice.
We now mute one of them.
- inspector/front-end/View.js:
(WebInspector.View):
(WebInspector.View.prototype._inNotification):
(WebInspector.View.prototype._parentIsShowing):
(WebInspector.View.prototype._callOnVisibleChildren):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processWillHide):
(WebInspector.View.prototype._processOnResize):
(WebInspector.View.prototype._notify):
(WebInspector.View.prototype.show):
LayoutTests:
- inspector/view-events-expected.txt:
- inspector/view-events.html:
- 1:34 AM Changeset in webkit [134198] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, disable the test on Mac/Chromium until we figure out the cause of failure.
- 1:30 AM Changeset in webkit [134197] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r134191. Turns out that FrameView::performPostLayoutTasks calls FrameSelection::updateAppearance
in the middle of a layout. So we can't have assertions in recomputeCaretRect and updateAppearance.
Furthermore, we can't update layout in updateAppearance. So do that in its call sites.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::setCaretVisibility):
- 1:15 AM Changeset in webkit [134196] by
-
- 4 edits2 adds in trunk
Don't update style when attaching in HTMLMeterElement
https://bugs.webkit.org/show_bug.cgi?id=101714
Reviewed by Hajime Morita.
Source/WebCore:
HTMLMeterElement was updating style when it's being attached. However, updating style when attaching
can cause style-update prevention. The similar thing has already happened in Bug 100507.
Since we have already set the default value in creating ShadowDOM subtree, we don't need to update style actually.
Test: fast/dom/HTMLMeterElement/meter-bar-set-value.html
- html/HTMLMeterElement.cpp:
- html/HTMLMeterElement.h:
(HTMLMeterElement): Removed attach(). We don't need it.
LayoutTests:
- fast/dom/HTMLMeterElement/meter-bar-set-value-expected.html: Added.
- fast/dom/HTMLMeterElement/meter-bar-set-value.html: Added.
- 12:37 AM Changeset in webkit [134195] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorWorkerAgent.cpp
Merge 133569 - Web Inspector: JavaScript web workers debugging crashes
https://bugs.webkit.org/show_bug.cgi?id=101065
Reviewed by Alexander Pavlov.
Source/WebCore:
Clear m_pageInspector when page inspector instance is deleted.
Disable worker inspection when front-end disconnects.
Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify
WorkerMessagingProxy so that it can clear pointer to the channel.
LayoutTests:
Test that inspected page won't crash if inspected worker is terminated when it is paused
on a breakpoint.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11361213
- 12:13 AM Changeset in webkit [134194] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/inspector/WorkerInspectorController.cpp
Merge 133030 - Web Inspector: page crash when pausing in dedicated worker
https://bugs.webkit.org/show_bug.cgi?id=100837
Reviewed by Pavel Feldman.
Source/WebCore:
Pass debugger agent to InjectedScriptHost::init in case of workers.
Test: inspector-protocol/debugger-pause-dedicated-worker.html
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
LayoutTests:
Test that Debugger.pause works for dedicated workers. The test is skipped
on all platforms that use JSC as worker debugging is not supported there
yet.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(WebInspector.dispatchMessageFromBackend):
- inspector-protocol/debugger-pause-dedicated-worker-expected.txt: Added.
- inspector-protocol/debugger-pause-dedicated-worker.html: Added.
- inspector-protocol/resources/dedicated-worker.js: Added.
(onmessage):
(doWork):
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11410030
Nov 11, 2012:
- 11:49 PM Changeset in webkit [134193] by
-
- 3 edits2 adds in trunk
Fix assertion failure in JSObject::tryGetIndexQuickly()
https://bugs.webkit.org/show_bug.cgi?id=101869
Patch by Michael Pruett <michael@68k.org> on 2012-11-11
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Currently JSObject::tryGetIndexQuickly() triggers an assertion
failure when the object has an undecided indexing type. This
case should be treated the same as a blank indexing type.
- runtime/JSObject.h:
(JSC::JSObject::tryGetIndexQuickly):
LayoutTests:
Add test case for an assertion failure triggered when constructing
a Blob with a sparse array.
- fast/constructors/blob-sparse-array-assertion-failure.html: Added.
- 11:24 PM Changeset in webkit [134192] by
-
- 3 edits in trunk/Tools
Change build congratulation message in EFL
https://bugs.webkit.org/show_bug.cgi?id=101833
Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-11
Reviewed by Gyuyoung Kim.
EFL port is currently supporting both WK1 and WK2.
But, build congratulation message still shows WK1(EWebLauncher) only.
Therefore, this patch adopts WK2 reference execution(MiniBrowser) in its message.
From 'To run EWebLauncher with this newly-built code, use the'
to 'To run EWebLauncher/MiniBrowser with this newly-built code, use the'.
- Scripts/build-webkit:
(writeCongrats):
- Scripts/webkitdirs.pm:
(launcherName):
- 11:09 PM Changeset in webkit [134191] by
-
- 6 edits in trunk
Multiple Layout Tests (e.g. fast/repaint/japanese-rl-selection-clear.html) is failing after r133840.
https://bugs.webkit.org/show_bug.cgi?id=101547
Reviewed by Simon Fraser.
Source/WebCore:
I overlooked the fact when the selection is null, we still have to invalidate the caret rect that
previously existed. Revert the optimization added in r133840 to skip caret invalidation when new
selection is null, and add a special method to be called by FrameLoader prior to destruction instead.
This will let us avoid doing an extra layout upon destruction and not regress repaint tests.
Covered by existing tests.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection): Added DoNotUpdateAppearance option.
(WebCore::FrameSelection::prepareForDestruction): Added.
(WebCore::FrameSelection::updateAppearance): Reverted the flawed optimization added in r133840.
Also, don't update style before updating selection unless text caret is disabled since we always
update the layout (including style) when text caret is enabled.
- editing/FrameSelection.h:
(FrameSelection):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear): Call prepareForDestruction instead of clear to avoid a layout.
LayoutTests:
Remove Chromium test expectations as these tests now pass.
- platform/chromium/TestExpectations:
- 10:37 PM Changeset in webkit [134190] by
-
- 19 edits9 adds in trunk
[CSS3] Parsing the property, text-align-last.
https://bugs.webkit.org/show_bug.cgi?id=99439
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-11
Reviewed by Julien Chaffraix.
This patch implements the parsing side of the "text-align-last" property specified
in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
Specification link : http://www.w3.org/TR/css3-text/#text-align-last
Source/WebCore:
Tests: fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html
fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Get the value of the text-align-last property.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Parse the value, and check whether it is a proper value which text-align-last can have.
- css/CSSPrimitiveValueMappings.h:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ETextAlignLast):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in: Add '-webkit-text-align-last' property.
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StylePropertySet.cpp:
(WebCore):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData): Add m_textAlignLast.
LayoutTests:
- fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html: Added.
- fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html: Added.
- fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last-inherited.js: Added.
(testComputedStyle):
- fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js: Added.
(testElementStyle):
(testComputedStyle):
- platform/chromium/TestExpectations:
- fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt: Added.
- fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- 10:35 PM Changeset in webkit [134189] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Remove shadowPseudoId() and use setPseudo() in HTMLKeygenElement
https://bugs.webkit.org/show_bug.cgi?id=101881
Reviewed by Kent Tamura.
We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
setPseudo()/pseudo() instead.
No new tests, simple refacotring.
- html/HTMLKeygenElement.cpp:
(WebCore::KeygenSelectElement::KeygenSelectElement):
(KeygenSelectElement):
- 9:30 PM Changeset in webkit [134188] by
-
- 8 edits in trunk/Source/WebCore
Many DOMWindowProperties would benefit from being ScriptWrappable
https://bugs.webkit.org/show_bug.cgi?id=101887
Reviewed by Kentaro Hara.
These object are only ever created at the behest of script, which means
making them ScriptWrappable is a win.
- page/BarInfo.h:
- page/Console.h:
- page/Crypto.h:
- page/History.h:
- page/Location.h:
- page/Navigator.h:
- page/Performance.h:
- 9:04 PM Changeset in webkit [134187] by
-
- 48 edits in trunk/LayoutTests
Rebaseline month/week appearance tests
https://bugs.webkit.org/show_bug.cgi?id=101561
Unreviewed.
Rebaselining month/week appearance tests.
- platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-classes-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-style-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-classes-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-style-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-style-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-style-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-classes-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-style-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-classes-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-style-expected.png:
- platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-classes-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-style-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-classes-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-style-expected.png:
- platform/chromium/TestExpectations:
- 8:42 PM Changeset in webkit [134186] by
-
- 3 edits in trunk/Source/WebCore
[V8] HTMLDocument::all() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101875
Reviewed by Adam Barth.
We can easily remove the custom getter from V8 because the
custom setter sets .all by ForceSet(). On the other hand,
it is non-trivial to remove the custom getter from JSC
because the custom setter sets .all by putDirect()
and the custom getter wants to get it by getDirect().
No tests. No change in behavior.
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- html/HTMLDocument.idl:
- 8:29 PM Changeset in webkit [134185] by
-
- 3 edits in trunk/Source/WebCore
[V8] V8Console::memoryAttrGetter() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101873
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore):
- page/Console.idl:
- 7:40 PM Changeset in webkit [134184] by
-
- 15 edits2 adds in trunk
[Shadow] ElementShadow should have RuleFeatureSet for select attribute selectors.
https://bugs.webkit.org/show_bug.cgi?id=101180
Reviewed by Dimitri Glazkov.
.:
Exposes necessary symbols.
- Source/autotools/symbols.filter:
Source/WebCore:
This is a preparation patch for Bug 100451.
We preserve RuleFeatureSet collected from select attributes in ShadowDOM.
When an element attribute is changed, we might have to invalidate content distribution,
however it's high cost operation. So we would like to check RuleFeatureSet used in
select attributes to determine we really need to invalidate distribution.
Like StyleResolver, ElementShadow has several rule features. When nested ShadowDOM is used,
first we collect features in nested ShadowDOM, and merge it to the parent ShadowDOM.
For the performance reason, we have a flag to check whether we need to collect features again.
Test: fast/dom/shadow/shadow-select-attribute-featureset.html
- WebCore.exp.in:
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::setShouldCollectSelectFeatureSet): Enable a flag to collect feature set of descendant
nodes (and their ShadowDOM).
(WebCore):
(WebCore::ElementShadow::ensureSelectFeatureSetCollected):
(WebCore::ElementShadow::collectSelectFeatureSetFrom): Collect RuleFeatureSet from all descendant Nodes and their
ShadowDOM. We need to collect id, class, and attribute names.
- dom/ElementShadow.h:
(WebCore::ElementShadow::shouldCollectSelectFeatureSet):
(ElementShadow):
(WebCore::ElementShadow::hasSelectorForId):
(WebCore):
(WebCore::ElementShadow::hasSelectorForClass):
(WebCore::ElementShadow::hasSelectorForAttribute):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute): When select attribute is changed, enable a flag to recollect features.
(WebCore::HTMLContentElement::insertedInto): We have to recollect features when HTMLContentElement is moved.
(WebCore::HTMLContentElement::removedFrom): ditto.
- html/shadow/HTMLContentElement.h:
(WebCore::toHTMLContentElement):
(WebCore):
- testing/Internals.cpp:
(WebCore::Internals::hasSelectorForIdInShadow):
(WebCore):
(WebCore::Internals::hasSelectorForClassInShadow):
(WebCore::Internals::hasSelectorForAttributeInShadow):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/dom/shadow/shadow-select-attribute-featureset-expected.txt: Added.
- fast/dom/shadow/shadow-select-attribute-featureset.html: Added.
- 6:57 PM WikiStart edited by
- (diff)
- 6:27 PM Changeset in webkit [134183] by
-
- 13 edits2 deletes in trunk
Unreviewed, rolling out r134144.
http://trac.webkit.org/changeset/134144
https://bugs.webkit.org/show_bug.cgi?id=101876
seems to break win 7 chromium browser test (Requested by
hayato on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-11
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- page/EventHandler.cpp:
(WebCore):
(WebCore::EventHandler::handleMouseMoveEvent):
- page/EventHandler.h:
(EventHandler):
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/events/mouse-cursor-expected.txt: Removed.
- fast/events/mouse-cursor.html: Removed.
- 6:08 PM Changeset in webkit [134182] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG register allocation should be greedy rather than round-robin
https://bugs.webkit.org/show_bug.cgi?id=101870
Reviewed by Geoffrey Garen.
This simplifies the code, reduces some code duplication, and shows some slight
performance improvements in a few places, likely due to the fact that lower-numered
registers also typically have smaller encodings.
- dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::RegisterBank):
(JSC::DFG::RegisterBank::tryAllocate):
(JSC::DFG::RegisterBank::allocate):
(JSC::DFG::RegisterBank::allocateInternal):
(RegisterBank):
- 5:41 PM Changeset in webkit [134181] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 133860 - User can change a disabled select (drop down box)
https://bugs.webkit.org/show_bug.cgi?id=100932
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-08
Reviewed by Kent Tamura.
Source/WebCore:
<select> should not handle events if it's disabled.
Test: fast/forms/select/select-disabled.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler):
LayoutTests:
Verify that keyboard events do not change value of disabled select.
- fast/forms/select/select-disabled-expected.txt: Added.
- fast/forms/select/select-disabled.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11363189
- 5:40 PM Changeset in webkit [134180] by
-
- 17 edits in trunk
Internals: MockPagePopup should not update DOM structure during detach()
https://bugs.webkit.org/show_bug.cgi?id=101710
Reviewed by Hajime Morita.
Source/WebCore:
PickerIndicatorElement::detach calls
MockPagePopupDriver::closePagePopup, MockPagePopup::~MockPagePopup,
which remove the mock iframe from the tree. But updating the tree during
detach() is dangerous.
MockPagePopupDriver::closePagePopup calls MockpagePopup::closeLater, it
requests to call 'close' asynchronously, and 'close' removes the mock
iframe. We need to change MockPagePopup so that it is ref-couted and has
a timer.
No new tests. This is a change for the test harness.
- testing/MockPagePopupDriver.cpp:
(MockPagePopup): Make this ref-counted, add closeLater, add close, and
add m_closeTimer.
(WebCore::MockPagePopup::MockPagePopup): Initialize the timer.
(WebCore::MockPagePopup::create): PassOwnPtr -> PassRefPtr
(WebCore::MockPagePopup::closeLater):
- Add one reference to avoid destruction by m_mockPagePopup.clear() in closePagePopup.
- Notify didClosePopup here because the client expects didClosePopup is called synchronously.
- Invoke the timer to call 'close'
(WebCore::MockPagePopup::close):
Just remove one reference. This means calling the desructor.
(WebCore::MockPagePopup::~MockPagePopup):
Move didClosePopup call to caloseLater.
(WebCore::MockPagePopupDriver::closePagePopup):
Request to close PagePopup.
Clear PagePopupClient in m_pagePopupController because this object is
necessary until MockPagePopup is closed, but it should not have a
reference to the PagePopupClient.
- testing/MockPagePopupDriver.h:
(MockPagePopupDriver): Make MockPagePopup ref-counted.
LayoutTests:
Update tests because page popup closing becomes asynchronous.
- fast/forms/resources/picker-common.js:
(waitUntilClosing): Added. Helper to wait until a page popup closing.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html:
- platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html:
- platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html:
- platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html:
- 5:35 PM Changeset in webkit [134179] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] The QNX extension method should not be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=101863
Reviewed by Rob Buis.
Simply change the default to false.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- 4:29 PM Changeset in webkit [134178] by
-
- 3 edits in trunk/Source/WebCore
axObjectCache code is more complicated than necessary
https://bugs.webkit.org/show_bug.cgi?id=101820
Reviewed by Darin Adler.
This code should use OwnPtr rather than manually calling new/delete.
Also, instead of using a "double check" pattern, we can just access the
private fields on the top document directly.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::axObjectCacheExists):
(WebCore):
(WebCore::Document::axObjectCache):
- dom/Document.h:
(Document):
- 4:12 PM Changeset in webkit [134177] by
-
- 2 edits2 adds in trunk/Source/WebKit/chromium
[chromium] Expose CustomEvent through WebDOMCustomEvent.
https://bugs.webkit.org/show_bug.cgi?id=101293
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-11
Reviewed by Adam Barth.
- WebKit.gyp:
- public/WebDOMCustomEvent.h: Added.
(WebKit):
(WebDOMCustomEvent):
(WebKit::WebDOMCustomEvent::WebDOMCustomEvent):
- src/WebDOMCustomEvent.cpp: Added.
(WebKit):
(WebKit::WebDOMCustomEvent::initCustomEvent):
- 3:54 PM Changeset in webkit [134176] by
-
- 2 edits in trunk/LayoutTests
[WK2] Mark fast/repaint/body-background-image.html as flaky.
- platform/wk2/TestExpectations:
- 3:51 PM Changeset in webkit [134175] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Replace the pixel expectation for
fast/repaint/body-background-image.html with the one generated by the
WK1 port, since WK2 fails to render it properly at times (see bug
101773).
- platform/efl/fast/repaint/body-background-image-expected.png:
- 8:58 AM Changeset in webkit [134174] by
-
- 3 edits in trunk/Source/WebCore
Save one call to containerForRepaint() when updating layer positions
https://bugs.webkit.org/show_bug.cgi?id=101856
Reviewed by Dan Bernstein.
RenderLayer::updateLayerPositions() has already computed the repaint container,
but calls computeRepaintRects() which computes it again. Computing the repaint
container involves a walk back up the layer tree, so calling it during a tree
traversal is costly.
Fix by passing the repaint container down into computeRepaintRects().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::computeRepaintRectsIncludingDescendants):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::setHasVisibleContent):
- rendering/RenderLayer.h:
(RenderLayer):
- 6:17 AM Changeset in webkit [134173] by
-
- 15 edits in trunk/Source
WTFString::utf8() should have a mode of conversion to use replacement character
https://bugs.webkit.org/show_bug.cgi?id=101678
Source/JavaScriptCore:
Reviewed by Alexey Proskuryakov.
Follow the change on String::utf8()
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode): Pass String::StrictConversion instead of true to String::utf8().
Source/WebCore:
Reviewed by Alexey Proskuryakov.
Follow the change on String::utf8()
No new tests. No changes in behavior.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::close): Pass String::StrictConversion instead of true to String::utf8().
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send): Ditto.
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments): Ditto.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::notifyChallengeResult): Ditto.
- platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::RSSFilterStream::convertContentToHtml): Ditto.
- platform/network/blackberry/rss/RSSGenerator.cpp:
(WebCore::RSSGenerator::generateHtml): Ditto.
Source/WebKit2:
Reviewed by Alexey Proskuryakov.
Update the symbol for String::utf8().
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Source/WTF:
Reviewed by Alexander Pavlov.
Introduce conversion mode to String::utf8().
There are three conversion modes; lenient mode, strict mode, and
"replacing unpaired surrogates with the replacement character" (replacement) mode.
Lenient mode converts unpaired surrogates. Strict mode fails when there is an unpaired
surrogates and returns CString(). Replacement mode replaces unpaired surrogates with
the replacement character(U+FFFD). Replacement mode implements the algorithm defined at
http://dev.w3.org/2006/webapi/WebIDL/#dfn-obtain-unicode. WebSocket::send() requires
this algorithm to encode a string to utf-8.
- wtf/text/WTFString.cpp:
(WTF::String::utf8): Changed to take ConversionMode as the argument.
- wtf/text/WTFString.h:
(String):
- 5:12 AM Changeset in webkit [134172] by
-
- 2 edits2 copies in branches/chromium/1312
Merge 133983 - [Chromium] Arabic digits should appear left-to-right
https://bugs.webkit.org/show_bug.cgi?id=101440
Reviewed by Tony Chang.
Source/WebCore:
Call hb_buffer_set_direction() to set direction when drawing glyphs or
direction should be overridden. Leave direction setting to HarfBuzz when
WebKit is calculating widths because the direction is LTR by default while
calculating widths. Set script before shaping so that HarfBuzz can estimate
appropriate direction.
Test: fast/text/international/arabic-digits.html
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
Add m_script. This holds the script of the run.
(WebCore::HarfBuzzShaper::shape):
Tell shapeHarfBuzzRuns() to set direction when drawing glyphs or
direction should be overridden.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
Set script of HarfBuzzRuns.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
Add an argument that indicates it should set direction.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
(WebCore::HarfBuzzShaper::HarfBuzzRun::script):
(HarfBuzzRun):
(HarfBuzzShaper):
LayoutTests:
Add a test that checks Arabic digits appear in increasing order from left to right.
- fast/text/international/arabic-digits-expected.html: Added.
- fast/text/international/arabic-digits.html: Added.
TBR=bashi@chromium.org
Review URL: https://codereview.chromium.org/11293219
- 4:59 AM Changeset in webkit [134171] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 133550 - [Chromium] Unicode combining diacritical aren't always combined on Linux
https://bugs.webkit.org/show_bug.cgi?id=101009
Reviewed by Kent Tamura.
Source/WebCore:
Add a space character to harfbuzzBuffer as pre-context. This will prevent
harfbuzz from inserting dotted-circle.
Test: fast/text/international/combining-marks-position.html
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
LayoutTests:
Add a test that checks whether combining marks are combined with base characters.
- fast/text/international/combining-marks-position-expected.txt: Added.
- fast/text/international/combining-marks-position.html: Added.
TBR=bashi@chromium.org
Review URL: https://codereview.chromium.org/11365191
