Timeline
Nov 13, 2012:
- 11:56 PM Changeset in webkit [134558] by
-
- 4 edits in trunk/Source/WebCore
Use menulist-button instead of menulist for date/time input types
https://bugs.webkit.org/show_bug.cgi?id=101886
Reviewed by Hajime Morita.
Both of Chromium-Android and iOS use -webkit-appearance:menulist-button,
not menulist. We had better apply common one by default.
No new tests. Covered by fast/forms/*/*-appearance-*.html.
- css/html.css:
(input[type="date"]): Switch menulist-button from menulist.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-date-and-time-value):
Add top, right, bottom margins. The right margin is important when
dir=rtl is specified.
whitespace:pre is needed to align baseline in a case of empty values.
- css/themeChromiumAndroid.css:
Remove redundant style declaration.
- css/themeWin.css:
Remove padding adjustment for date/time input types. It is for
textfields.
- 11:49 PM Changeset in webkit [134557] by
-
- 9 edits in trunk/Source
Remove RuntimeEnabledFeatures::isPointerLockEnabled.
https://bugs.webkit.org/show_bug.cgi?id=102107
Reviewed by Adam Barth.
The runtime flag is always true now that the feature is enabled by default in Chromium.
Source/WebCore:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- dom/Document.idl:
- dom/Element.idl:
- dom/MouseEvent.idl:
Source/WebKit/chromium:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit):
(WebKit::WebRuntimeFeatures::enablePointerLock):
- 11:24 PM Changeset in webkit [134556] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Expanding failure expectations for the inspector/debugger/live-edit.html test.
Adding failure and timeout expectations for two tests that regressed after r134495.
Adding failure expectation for a test added in r134099.
- platform/gtk/TestExpectations:
- 11:22 PM Changeset in webkit [134555] by
-
- 17 edits in trunk/Source/JavaScriptCore
DFG CreateThis should be able to statically account for the structure of the object it creates, if profiling indicates that this structure is always the same
https://bugs.webkit.org/show_bug.cgi?id=102017
Reviewed by Geoffrey Garen.
This adds a watchpoint in JSFunction on the cached inheritor ID. It also changes
NewObject to take a structure as an operand (previously it implicitly used the owning
global object's empty object structure). Any GetCallee where the callee is predictable
is turned into a CheckFunction + WeakJSConstant, and any CreateThis on a WeakJSConstant
where the inheritor ID watchpoint is still valid is turned into an InheritorIDWatchpoint
followed by a NewObject. NewObject already accounts for the structure it uses for object
creation in the CFA.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkFunctionElimination):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasFunction):
(JSC::DFG::Node::function):
(JSC::DFG::Node::hasStructure):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Executable.h:
(JSC::JSFunction::JSFunction):
- runtime/JSBoundFunction.cpp:
(JSC):
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSFunction.h:
(JSC::JSFunction::tryGetKnownInheritorID):
(JSFunction):
(JSC::JSFunction::addInheritorIDWatchpoint):
- 11:19 PM Changeset in webkit [134554] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, skip new failing tests.
- platform/qt/TestExpectations:
- 11:17 PM Changeset in webkit [134553] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
- DEPS:
- 11:12 PM Changeset in webkit [134552] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: JsDoc-annotate KeyboardShortcuts
https://bugs.webkit.org/show_bug.cgi?id=101301
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.
JsDoc-annotate KeyboardShortcuts to improve readability.
- inspector/front-end/AdvancedSearchController.js: Fix parameter type.
- inspector/front-end/KeyboardShortcut.js: Add annotations.
- inspector/front-end/Panel.js: Make event parameter typed.
- inspector/front-end/inspector.js: Ditto.
- 11:06 PM Changeset in webkit [134551] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marked platform/chromium/virtual/gpu/fast/hidpi/image-set-without-specified-width.html
as Slow.
- platform/chromium/TestExpectations:
- 10:57 PM Changeset in webkit [134550] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Extract common interface for StatusBarButton and StatusBarCombo
https://bugs.webkit.org/show_bug.cgi?id=101907
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.
Status bar control element should have common interface for
easier management.
In this patch getter/setter for StatusBarButton "disabled" are replaced
with regular functions "enabled"/"setEnabled"; added "setEnabled"
to StatusBarCombo; added new base class StatusBarItem with
method "setEnabled" and member "element".
- inspector/front-end/CPUProfileView.js: Adopted refactoring.
- inspector/front-end/DockController.js: Ditto.
- inspector/front-end/ScriptsPanel.js: Ditto.
- inspector/front-end/TimelinePanel.js: Ditto.
- inspector/front-end/inspector.js: Ditto.
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarItem): Added.
(WebInspector.StatusBarButton): Replaced getter/setter with
regular functions.
(WebInspector.StatusBarComboBox.prototype.setEnabled): Added.
- 10:56 PM Changeset in webkit [134549] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening, update expected files after r134435.
- dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
- fast/dom/DOMException/prototype-object-expected.txt:
- fast/dom/DOMException/stack-trace-expected.txt:
- 10:55 PM Changeset in webkit [134548] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Console: update tab/shift-tab shortcut description.
https://bugs.webkit.org/show_bug.cgi?id=102175
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.
For "Tab / Shift-Tab" it said "Next/previous suggestion".
Actually, shift-tab to do nothing, and tab auto-completes common prefix.
- English.lproj/localizedStrings.js: Replaced string.
- inspector/front-end/ConsoleView.js: Updated shortcut registration.
- 10:37 PM Changeset in webkit [134547] by
-
- 7 edits in trunk/Source
[chromium] Pass showDebugBorders directly to WebLayerTreeSettings, don't use the GraphicsLayer border width setting.
https://bugs.webkit.org/show_bug.cgi?id=102130
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebCore:
The current method of setting debug borders on GraphicsLayers requires
every GraphicsLayerClient to set the value on the layer(s) it
represents. This skips the NonCompositedContentHost as well as any
other clients other than RenderLayerBacking - including layers from the
inspector.
Instead, pass the debug border setting directly to the
WebLayerTreeSettings where the compositor can use the flag to enable
borders on all layers globally.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- 10:30 PM Changeset in webkit [134546] by
-
- 9 edits4 adds in trunk
Enable calendar picker for input types datetime/datetime-local
https://bugs.webkit.org/show_bug.cgi?id=101889
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-13
Reviewed by Kent Tamura.
Source/WebCore:
This adds calendar picker to <input type=datetime> and <input type=datetime-local>.
When a user choose a date from calendar picker, year/month/day fields of the input
element are updated and hour/minute/second fields are unchanged.
Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-local.html
platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html
- Resources/pagepopups/calendarPicker.js: Day.parse accepts datetime string (just drops time part).
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue):
If the given value is not valid for the element, try to parse it as a date string.
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::formatDateTimeFieldsState): DateTimeFieldsState::month() returns 1-12, not 0-11.
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState): Ditto.
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::setOnlyYearMonthDay): Added.
(WebCore):
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement):
- rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker): Return true for datetime and datetimelocal too.
LayoutTests:
Added tests for calendar picker for inpt type=datetime/datetime-local.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal.html: Added.
- 10:18 PM Changeset in webkit [134545] by
-
- 7 edits4 deletes in trunk/Source/WebCore
Unreviewed, rolling out r134524.
http://trac.webkit.org/changeset/134524
https://bugs.webkit.org/show_bug.cgi?id=102177
"Chromiium build broken" (Requested by haraken on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- rendering/RenderThemeChromiumFontProvider.cpp: Removed.
- rendering/RenderThemeChromiumFontProvider.h: Removed.
- rendering/RenderThemeChromiumFontProviderLinux.cpp: Removed.
- rendering/RenderThemeChromiumFontProviderWin.cpp: Removed.
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::defaultGUIFont):
(WebCore::RenderThemeChromiumSkia::systemFont):
(WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
- rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::getNonClientMetrics):
(WebCore::systemFontSize):
(WebCore::pointsToPixels):
(WebCore::RenderThemeChromiumWin::systemFont):
(WebCore::RenderThemeChromiumWin::setDefaultFontSize):
- rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):
- 10:15 PM Changeset in webkit [134544] by
-
- 2 edits in trunk/Source/WebCore
Fix compile warning [-Wsign-compare]
https://bugs.webkit.org/show_bug.cgi?id=101458
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-13
Reviewed by Alexey Proskuryakov.
Currently, lossy check has been done by comparing file size(posix signed integral value) with conversioned(standard c++ unsigned integral value).
However, it leads -Wsign-compare compile warning.
Therefore, this patch assigns the file size to the biggest possible unsigned variable, then does the lossy check.
- platform/posix/SharedBufferPOSIX.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
- 10:13 PM Changeset in webkit [134543] by
-
- 6 edits in trunk
Enable datalist UI for input types week and month
https://bugs.webkit.org/show_bug.cgi?id=102041
Reviewed by Kent Tamura.
Source/WebCore:
Enabling datalist UI for input types week and month.
No new tests. Tests will be added later in Bug 102039 and Bug 102040.
- rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add month and week to the list.
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): If the type supports calendar picker show the "Other..." option.
LayoutTests:
- platform/chromium/fast/forms/datalist/input-list-expected.txt:
- 9:52 PM Changeset in webkit [134542] by
-
- 17 edits in trunk/Source
checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660
Patch by Eberhard Graether <egraether@google.com> on 2012-11-13
Reviewed by Pavel Feldman.
Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowFPSCounter):
Source/WebCore:
No new tests.
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowFPSCounter):
(WebCore::InspectorClient::setShowFPSCounter):
(InspectorClient):
- inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowFPSCounter):
(WebCore):
(WebCore::InspectorPageAgent::setShowFPSCounter):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showFPSCounterChanged):
- inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
Source/WebKit/chromium:
- public/WebView.h:
(WebView):
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit):
(WebKit::InspectorClientImpl::setShowFPSCounter):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::loadFontAtlasIfNecessary):
- src/WebViewImpl.h:
(WebViewImpl):
- 9:51 PM Changeset in webkit [134541] by
-
- 9 edits in trunk
Collect necessary features for SelectRuleFeatureSet
https://bugs.webkit.org/show_bug.cgi?id=102160
Reviewed by Dimitri Glazkov.
Source/WebCore:
When pseudo class is changed, we might have to invalidate distribution. To determine whether we should invalidate
distribution, we would like to collect RuleFeature from select attributes.
According to ShadowDOM spec, we have to collect the following pseudo classes: checked, enabled, disabled,
indeterminate, link, target, and visited. We collect them in this patch.
Test: fast/dom/shadow/shadow-select-attribute-featureset.html
- html/shadow/SelectRuleFeatureSet.cpp:
(WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet): Uses int as bitset so that we can use bit operator.
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector): Collects necessary features from CSSSelector.
- html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorForChecked):
(WebCore::SelectRuleFeatureSet::hasSelectorForEnabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForDisabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForIndeterminate):
(WebCore::SelectRuleFeatureSet::hasSelectorForLink):
(WebCore::SelectRuleFeatureSet::hasSelectorForTarget):
(WebCore::SelectRuleFeatureSet::hasSelectorForVisited):
(SelectRuleFeatureSet):
(WebCore::SelectRuleFeatureSet::setSelectRuleFeature):
(WebCore::SelectRuleFeatureSet::hasSelectorFor):
- testing/Internals.cpp:
(WebCore::Internals::hasSelectorForPseudoClassInShadow):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- fast/dom/shadow/shadow-select-attribute-featureset-expected.txt:
- fast/dom/shadow/shadow-select-attribute-featureset.html:
- 9:45 PM Changeset in webkit [134540] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
https://bugs.webkit.org/show_bug.cgi?id=102065
Reviewed by Laszlo Gombos.
mouseClick(), mouseDown() and mouseUp() test functions are only able to test a left button of mouse now.
However, EFL API test framwork needs to test various mouse buttons. For example, context menu test needs
to simulate a right mouse button. So, button type parameter needs to be added for it.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseClick):
(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- 9:39 PM Changeset in webkit [134539] by
-
- 12 edits in trunk/Source
Move inline style logic from ElementAttributeData to StyledElement.
<http://webkit.org/b/102120>
Reviewed by Antti Koivisto.
Source/WebCore:
Move all the logic dealing with element inline style from ElementAttributeData to StyledElement.
No difference in behavior, just making ElementAttributeData dumber.
- css/StylePropertySet.cpp:
- css/StylePropertySet.h:
(WebCore::StylePropertySet::hasCSSOMWrapper):
(WebCore::StylePropertySet::cssStyleDeclaration):
Added as complements to ensureCSSStyleDeclaration() for the case where we don't want
to instantiate a CSSOM wrapper unnecessarily.
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyle):
- dom/ElementAttributeData.cpp:
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::inlineStyle):
(ElementAttributeData):
Renamed m_inlineStyleDecl to m_inlineStyle. Finally.
- dom/StyledElement.cpp:
(WebCore::StyledElement::~StyledElement):
Detach the CSSOM wrapper from the inline style if there is one.
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::style):
Renamed ensureInlineStyle() to ensureMutableInlineStyle() since that's what it
actually does. Update call sites accordingly.
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
Added helper to get the CSSOM wrapper for the element's inline style if there is one.
(WebCore::StyledElement::styleAttributeChanged):
Do the work to parse/update/replace the inline style attribute here instead of
in an ElementAttributeData method.
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::removeAllInlineStyleProperties):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
- html/canvas/CanvasStyle.cpp:
(WebCore::currentColor):
s/ensureInlineStyle/ensureMutableInlineStyle/
Source/WebKit/qt:
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- 9:35 PM Changeset in webkit [134538] by
-
- 2 edits in trunk/Source/WebCore
fast/forms/file/input-file-write-files.html should cover correct setting value
https://bugs.webkit.org/show_bug.cgi?id=100085
Patch by Li Yin <li.yin@intel.com> on 2012-11-13
Reviewed by Kentaro Hara.
Fix the GObject and Objective C bindings comparibility issue. Preserving existing
behavior for those may be important in idl.
No new tests, because fast/forms/file/input-file-value.html has covered it.
- html/HTMLInputElement.idl:
- 9:23 PM Changeset in webkit [134537] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix build warning in NetworkStateNotifierEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=102061
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-13
Reviewed by Gyuyoung Kim.
The second argument for NLMSG_OK needs to be unsigned to avoid the -Wsign-compare warning.
- platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::readSocketCallback):
- 9:19 PM Changeset in webkit [134536] by
-
- 2 edits in trunk/Source/WebCore
Don't mark scrolling contents as dirty if RenderLayerBacking is going away
https://bugs.webkit.org/show_bug.cgi?id=101947
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-13
Reviewed by Simon Fraser.
When a scrolling contents graphics layer is created or destroyed, the
associated graphics layer is marked as needing display because some of
the painted content may have migrated between the primary graphics layer
and the scrolling layer.
This causes a problem when the RenderLayerBacking is being destroyed,
because setNeedsDisplay() needs to check from the compositor whether to
track repaints or not. If the RenderLayerBacking is being destroyed, the
value returned by compositor() is garbage and this causes a crash.
This patch fixes the problem by making RenderLayer::compositor() return a null
pointer when the renderer no longer has a view.
Covered by existing layout tests in compositing/overflow/.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::compositor):
- 9:12 PM Changeset in webkit [134535] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed. Rebaselined test results.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/checkerboard-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/checkerboard-expected.png: Added.
- 9:05 PM Changeset in webkit [134534] by
-
- 7 edits in trunk
[EFL][WK2] New window size should consult the window attributes
https://bugs.webkit.org/show_bug.cgi?id=102122
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Pass the size that was specified in window.open to the embedder.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::createNewPage):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::createNewPage):
Tools:
Take into account the size that was specified in window.open
when creating a new window. This avoids ugly flashing on the screen.
- MiniBrowser/efl/main.c:
(on_key_down):
(on_new_window):
(window_create):
(elm_main):
- 9:03 PM Changeset in webkit [134533] by
-
- 9 edits in trunk/LayoutTests
IndexedDB: non-trivial test conversion batch 2
https://bugs.webkit.org/show_bug.cgi?id=101998
Reviewed by Tony Chang.
- storage/indexeddb/cursor-overloads-expected.txt:
- storage/indexeddb/cursor-overloads.html: Trivial conversion that I missed last time around.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-close-expected.txt:
- storage/indexeddb/database-closepending-flag-expected.txt:
- storage/indexeddb/delete-closed-database-object-expected.txt:
- storage/indexeddb/resources/database-basics.js: Removed test that shows calling setVersion inside a version change transaction is an error. Replaced with test showing same error for a generic transaction.
- storage/indexeddb/resources/database-close.js: Formerly used both unblocked setVersion and deleteDatabase to signal that a connection was closed, now just used deleteDatabase.
- storage/indexeddb/resources/database-closepending-flag.js: Straightforward, it just has multiple opens.
- 9:01 PM Changeset in webkit [134532] by
-
- 13 edits in trunk
[chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well, in preparation for removing the settings from WebCompositorSupport
https://bugs.webkit.org/show_bug.cgi?id=102146
Reviewed by James Robinson.
Source/Platform:
Add accelerated animation and per-tile painting to the
WebLayerTreeView structure.
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebKit/chromium:
Add accelerated animation and per-tile painting to the WebSettings structure.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
(WebKit::WebSettingsImpl::perTilePaintingEnabled):
(WebKit::WebSettingsImpl::acceleratedAnimationEnabled):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
Tools:
Pass settings that go through WebCompositorSupport also through
WebLayerTreeSettings. When the compositor starts using those instead,
we can remove the callers to the WebCompositorSupport setters.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
- 8:47 PM Changeset in webkit [134531] by
-
- 4 edits in trunk/Source/WebKit2
Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
https://bugs.webkit.org/show_bug.cgi?id=102133
Renamed m_CoordinatedGraphicsLayerClient to m_coordinator.
Also, there is no need for calling setCoordinator every time the tree changes,
since we can call it once when the layer is created, now that LayerTreeCoordinator
is the GraphicsLayerFactory.
Reviewed by Kenneth Rohde Christiansen.
No change in functionality.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::ensureImageBackingStore):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
(WebCore::CoordinatedGraphicsLayer::setCoordinator):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::paintContents):
- 8:42 PM Changeset in webkit [134530] by
-
- 11 edits in trunk
Update DOMException name: InvalidCharacterError
https://bugs.webkit.org/show_bug.cgi?id=102128
Reviewed by Darin Adler.
Source/WebCore:
Patch 5 of 25 to update DOMException name to match the spec and Firefox.
Updated existing tests.
- dom/DOMCoreException.cpp:
LayoutTests:
Updated tests and expectations.
- fast/dom/Document/createElement-invalid-names-expected.txt:
- fast/dom/Document/createElement-invalid-names.html:
- fast/dom/Element/prefix-setter-exception-expected.txt:
- fast/dom/Window/atob-btoa-expected.txt:
- fast/dom/dataset-expected.txt:
- fast/dom/dataset-xhtml-expected.txt:
- fast/dom/script-tests/dataset-xhtml.js:
- fast/dom/script-tests/dataset.js:
- 8:33 PM Changeset in webkit [134529] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Run multiple tasks per transaction tick
https://bugs.webkit.org/show_bug.cgi?id=97738
Reviewed by Tony Chang.
Process multiple tasks from the pending queue(s) when the timer fires. The
task may initiate new tasks that change which queue is active (e.g. indexing
operations) so the loop must re-check each tick which queue to use.
In DumpRenderTree, time to make 20k puts/20k gets dropped from 3.2s to 2.0s (-37%);
in Chromium's content_shell, the time dropped from 8.1s to 4.6s (-42%).
No new tests - just perf improvements, covered by (nearly) all existing IDB tests.
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort): Use takeFirst() to clean up code.
(WebCore::IDBTransactionBackendImpl::taskTimerFired): Process as many tasks as are available.
- 8:25 PM Changeset in webkit [134528] by
-
- 8 edits2 adds1 delete in trunk
Disable frame loading instead of throwing exceptions on subtree modifications in ChildFrameDisconnector
https://bugs.webkit.org/show_bug.cgi?id=102012
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-13
Reviewed by Ojan Vafai.
Source/WebCore:
Previously if you modified the subtree that was being removed from a
removeChild from inside an unload handler on an <iframe> inside the
subtree you'd get an exception which is wrong. Instead we just need to
disable all frame loading there.
This works because either the subtree will be removed and the frame never
loading doesn't matter, or some section of the subtree that contains the
frame will be moved to another part of the document which will cause the
frame to load when it's inserted there.
I also added a check for <object> elements. It doesn't seem this is actually
reachable in the existing code, but I'm not entirely sure since the frame
loading and object/plugin handling is very confusing.
A better fix could be to repeatedly walk the subtree until all frames
were disconnected or some iteration limit was hit and then force all leftover
subframes to disconnect without firing unload handlers but this is such an
edge case I don't think the complexity is necessary.
Test: fast/frames/modifications-in-subtree-unload.html
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::disconnect):
- dom/Node.cpp:
(WebCore::checkAcceptChild): Removed exception.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check canLoadFrame().
- html/HTMLFrameOwnerElement.h:
(SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::~SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::canLoadFrame):
Returns true if frames can be loaded in the subtree.
(WebCore::SubframeLoadingDisabler::disabledSubtreeRoots):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
Check canLoadFrame(). I think this case is impossible, but it's better
to be safe than sorry later.
LayoutTests:
Remove console log output from the exception we no longer throw. Since we no
longer throw an exception we don't need a platform specific output file either.
Also add a test that we don't throw an exception during modifications to subtrees
during unload.
- fast/frames/modifications-in-subtree-unload-expected.html: Added.
- fast/frames/modifications-in-subtree-unload.html: Added.
- fast/frames/out-of-document-iframe-has-child-frame-expected.txt:
- platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Removed.
- 8:22 PM Changeset in webkit [134527] by
-
- 2 edits in trunk/Source/WebCore
[V8] Add missing ENABLE(SVG) test in header
https://bugs.webkit.org/show_bug.cgi?id=102143
Reviewed by Kentaro Hara.
Need to wrap the #include of a header that's only conditionally generated.
Fixes build error if compiling e.g. w/ GYP_DEFINES="enable_svg=0"
- bindings/v8/custom/V8ElementCustom.cpp:
- 8:21 PM Changeset in webkit [134526] by
-
- 4 edits in trunk/Source/WebCore
Automatically run small plugins
https://bugs.webkit.org/show_bug.cgi?id=102148
<rdar://problem/12695560>
Reviewed by Darin Adler.
- rendering/RenderEmbeddedObject.h: Promote layout() to protected.
- rendering/RenderSnapshottedPlugIn.cpp: Add constants for threshold size for plugins that will auto-start.
(WebCore::RenderSnapshottedPlugIn::layout): After layout, obtain the width and height of the element.
If either dimension is 0, or the overall size of the plugin is smaller that the threshold size, move the
display state to Playing. Assuming we will always layout before first paint, changing the state here
should be safe.
- rendering/RenderSnapshottedPlugIn.h:
- 8:13 PM Changeset in webkit [134525] by
-
- 8 edits in trunk/Source
Notify embedder of lost contexts and allow overriding of WebGL support
https://bugs.webkit.org/show_bug.cgi?id=101826
Reviewed by Adam Barth.
Source/WebCore:
Add hooks notifying the embedder when OpenGL contexts are lost and
allowing overriding of WebGL support on a per-frame basis.
No tests yet; don't know how to test this solely within WebKit.
Currently developing tests in the Chromium port exercising the
notifications end-to-end. Once those are in place, I'm prepared to
investigate adding tests for all ports.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
Check whether embedder vetoes creation of new WebGL contexts.
(WebCore::WebGLRenderingContext::loseContextImpl):
Notify embedder that context was lost.
(WebCore::WebGLRenderingContext::maybeRestoreContext):
Check whether embedder vetoes restoration of existing WebGL contexts.
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::allowWebGL):
(WebCore::FrameLoaderClient::didLoseWebGLContext):
Hooks notifying embedder of lost contexts and asking permission to run WebGL.
Source/WebKit/chromium:
Expose new FrameLoaderClient hooks through Chromium's
WebPermissionClient and WebFrameClient. Downstream browser tests
will exercise this new functionality.
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didLoseWebGLContext):
- public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowWebGL):
- src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::allowWebGL):
(WebKit::FrameLoaderClientImpl::didLoseWebGLContext):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- 8:06 PM Changeset in webkit [134524] by
-
- 7 edits4 adds in trunk/Source/WebCore
[Chromium] Refactor theme font lookup into a factory
https://bugs.webkit.org/show_bug.cgi?id=101949
Patch by Scott Violet <sky@chromium.org> on 2012-11-13
Reviewed by Tony Chang.
This will ultimately allow us to use what is currently in RenderThemeChromiumLinux on windows.
No new tests. Refactoring only.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- rendering/RenderThemeChromiumFontProvider.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::defaultGUIFont): Moved into RenderThemeFontProvider.
- rendering/RenderThemeChromiumFontProvider.h: Added.
(WTF):
(WebCore):
(RenderThemeChromiumFontProvider): This is the font related methods.
- rendering/RenderThemeChromiumFontProviderLinux.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): What was in RenderThemeChromiumSkia::setDefaultFontSize.
(WebCore::RenderThemeChromiumFontProvider::systemFont): What was in RenderThemeChromiumSkia::systemFont.
- rendering/RenderThemeChromiumFontProviderWin.cpp: Added.
(WebCore):
(WebCore::pointsToPixels): Moved from RenderThemeChromiumWin.
(WebCore::getNonClientMetrics): Moved from RenderThemeChromiumWin.
(WebCore::systemFontSize): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::systemFont): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): Moved from RenderThemeChromiumWin.
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): Moved into RenderThemeFontProvider.
(WebCore::RenderThemeChromiumSkia::systemFont): Calls to RenderThemeChromiumFontProvider.
(WebCore::RenderThemeChromiumSkia::setDefaultFontSize): Calls to RenderThemeChromiumFontProvider.
- rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Moves defaultFontSize into RenderThemeChromiumFontProvider.
- rendering/RenderThemeChromiumWin.cpp: Moves font code into RenderThemeFontProviderWin.
(WebCore):
- rendering/RenderThemeChromiumWin.h: Removed overriden methods now handled by RenderThemeChromiumSkia.
(RenderThemeChromiumWin):
- 7:41 PM Changeset in webkit [134523] by
-
- 9 edits1 copy in trunk/Source
Add DOMRequestState to maintain world/ScriptExecutionContext state
https://bugs.webkit.org/show_bug.cgi?id=102102
Reviewed by Adam Barth.
Introduce DOMRequestState, and convert IndexedDB over.
No new tests, this is an abstraction layer for existing code.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- WebCore.gypi:
- bindings/v8/DOMRequestState.h: Added.
(WebCore):
(DOMRequestState):
(WebCore::DOMRequestState::DOMRequestState):
(Scope):
(WebCore::DOMRequestState::Scope::Scope):
(WebCore::DOMRequestState::scope):
- 7:38 PM Changeset in webkit [134522] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r134328) - ASSERT(isMainThread()) when subresources redirect in the NetworkProcessPass through
https://bugs.webkit.org/show_bug.cgi?id=102167
Reviewed by Simon Fraser.
willSendRequest comes in on a background thread but we need to do HostRecord accounting on the main thread.
So we'll just dispatch the receivedRedirect call to the main thread RunLoop.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::willSendRequest):
- 7:19 PM Changeset in webkit [134521] by
-
- 2 edits1 delete in trunk/LayoutTests
Revert r134474; turns out these tests were failing.
I need to figure out what's going on here ...
- platform/chromium-linux/fast/text/zero-font-size-2-expected.png: Removed.
- platform/chromium/TestExpectations:
- 7:15 PM Changeset in webkit [134520] by
-
- 8 edits2 copies in trunk/Source/WebCore
Sever Chromium's dependence on WebKitSystemInterface media control drawing functions in RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=101634
Patch by Robert Sesek <rsesek@chromium.org> on 2012-11-13
Reviewed by Adam Barth.
This splits out the common methods between RenderThemeMac and RenderThemeChromiumMac
into RenderThemeMacShared.
No new tests, just refactoring.
- WebCore.gyp/WebCore.gyp: Remove RenderThemeMac.mm from platform/ sources list, since it's part of rendering/
- WebCore.gypi: Add RenderThemeMacShared.{h,mm}
- WebCore.xcodeproj/project.pbxproj: Add RenderThemeMacShared.{h,mm}
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft):
(WebCore::RenderThemeChromiumMac::popupInternalPaddingRight):
(WebCore::RenderThemeChromiumMac::extraDefaultStyleSheet):
- rendering/RenderThemeMac.h:
(RenderThemeMac):
- rendering/RenderThemeMac.mm:
(WebCore):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeMac::create):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
(WebCore::RenderThemeMac::documentViewFor):
(WebCore::mediaControllerTheme):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):
(WebCore::RenderThemeMac::extraMediaControlsStyleSheet):
(WebCore::RenderThemeMac::extraFullScreenStyleSheet):
- rendering/RenderThemeMacShared.h: Copied from Source/WebCore/rendering/RenderThemeMac.h.
(WebCore):
(RenderThemeMacShared):
(WebCore::RenderThemeMacShared::supportsControlTints):
(WebCore::RenderThemeMacShared::scrollbarControlSizeForPart):
(WebCore::RenderThemeMacShared::supportsSelectionForegroundColors):
(WebCore::RenderThemeMacShared::supportsClosedCaptioning):
(WebCore::RenderThemeMacShared::updateActiveState):
- rendering/RenderThemeMacShared.mm: Copied from Source/WebCore/rendering/RenderThemeMac.mm.
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(WebCore):
(WebCore::RenderThemeMacShared::RenderThemeMacShared):
(WebCore::RenderThemeMacShared::~RenderThemeMacShared):
(WebCore::RenderThemeMacShared::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeMacShared::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeMacShared::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeMacShared::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMacShared::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMacShared::platformFocusRingColor):
(WebCore::RenderThemeMacShared::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::toFontWeight):
(WebCore::RenderThemeMacShared::systemFont):
(WebCore::convertNSColorToColor):
(WebCore::menuBackgroundColor):
(WebCore::RenderThemeMacShared::platformColorsDidChange):
(WebCore::RenderThemeMacShared::systemColor):
(WebCore::RenderThemeMacShared::usesTestModeFocusRingColor):
(WebCore::RenderThemeMacShared::isControlStyled):
(WebCore::RenderThemeMacShared::adjustRepaintRect):
(WebCore::RenderThemeMacShared::inflateRect):
(WebCore::RenderThemeMacShared::convertToPaintingRect):
(WebCore::RenderThemeMacShared::updateCheckedState):
(WebCore::RenderThemeMacShared::updateEnabledState):
(WebCore::RenderThemeMacShared::updateFocusedState):
(WebCore::RenderThemeMacShared::updatePressedState):
(WebCore::RenderThemeMacShared::controlSupportsTints):
(WebCore::RenderThemeMacShared::controlSizeForFont):
(WebCore::RenderThemeMacShared::setControlSize):
(WebCore::RenderThemeMacShared::sizeForFont):
(WebCore::RenderThemeMacShared::sizeForSystemFont):
(WebCore::RenderThemeMacShared::setSizeFromFont):
(WebCore::RenderThemeMacShared::setFontFromControlSize):
(WebCore::RenderThemeMacShared::controlSizeForSystemFont):
(WebCore::RenderThemeMacShared::paintTextField):
(WebCore::RenderThemeMacShared::adjustTextFieldStyle):
(WebCore::RenderThemeMacShared::paintCapsLockIndicator):
(WebCore::RenderThemeMacShared::paintTextArea):
(WebCore::RenderThemeMacShared::adjustTextAreaStyle):
(WebCore::RenderThemeMacShared::popupButtonMargins):
(WebCore::RenderThemeMacShared::popupButtonSizes):
(WebCore::RenderThemeMacShared::popupButtonPadding):
(WebCore::RenderThemeMacShared::paintMenuList):
(WebCore::RenderThemeMacShared::meterSizeForBounds):
(WebCore::RenderThemeMacShared::paintMeter):
(WebCore::RenderThemeMacShared::supportsMeter):
(WebCore::RenderThemeMacShared::levelIndicatorStyleFor):
(WebCore::RenderThemeMacShared::levelIndicatorFor):
(WebCore::RenderThemeMacShared::progressBarSizes):
(WebCore::RenderThemeMacShared::progressBarMargins):
(WebCore::RenderThemeMacShared::minimumProgressBarHeight):
(WebCore::RenderThemeMacShared::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMacShared::animationDurationForProgressBar):
(WebCore::RenderThemeMacShared::adjustProgressBarStyle):
(WebCore::RenderThemeMacShared::paintProgressBar):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMacShared::paintMenuListButtonGradients):
(WebCore::RenderThemeMacShared::paintMenuListButton):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMacShared::adjustMenuListStyle):
(WebCore::RenderThemeMacShared::popupInternalPaddingLeft):
(WebCore::RenderThemeMacShared::popupInternalPaddingRight):
(WebCore::RenderThemeMacShared::popupInternalPaddingTop):
(WebCore::RenderThemeMacShared::popupInternalPaddingBottom):
(WebCore::RenderThemeMacShared::adjustMenuListButtonStyle):
(WebCore::RenderThemeMacShared::setPopupButtonCellState):
(WebCore::RenderThemeMacShared::menuListSizes):
(WebCore::RenderThemeMacShared::minimumMenuListSize):
(WebCore::RenderThemeMacShared::adjustSliderTrackStyle):
(WebCore::RenderThemeMacShared::paintSliderTrack):
(WebCore::RenderThemeMacShared::adjustSliderThumbStyle):
(WebCore::RenderThemeMacShared::paintSliderThumb):
(WebCore::RenderThemeMacShared::paintSearchField):
(WebCore::RenderThemeMacShared::setSearchCellState):
(WebCore::RenderThemeMacShared::searchFieldSizes):
(WebCore::RenderThemeMacShared::setSearchFieldSize):
(WebCore::RenderThemeMacShared::adjustSearchFieldStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
(WebCore::RenderThemeMacShared::cancelButtonSizes):
(WebCore::RenderThemeMacShared::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMacShared::resultsButtonSizes):
(WebCore::RenderThemeMacShared::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldDecoration):
(WebCore::RenderThemeMacShared::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMacShared::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldResultsButton):
(WebCore::RenderThemeMacShared::sliderTickSize):
(WebCore::RenderThemeMacShared::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeMacShared::adjustSliderThumbSize):
(WebCore::RenderThemeMacShared::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeMacShared::popupButton):
(WebCore::RenderThemeMacShared::search):
(WebCore::RenderThemeMacShared::searchMenuTemplate):
(WebCore::RenderThemeMacShared::sliderThumbHorizontal):
(WebCore::RenderThemeMacShared::sliderThumbVertical):
(WebCore::RenderThemeMacShared::textField):
(WebCore::RenderThemeMacShared::fileListNameForWidth):
(WebCore::RenderThemeMacShared::paintPlugInSnapshotOverlay):
- 7:15 PM Changeset in webkit [134519] by
-
- 2 edits2 adds in trunk/LayoutTests
Update chromium-mac-lion baselines after r134516. Unreviewed.
- platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
- platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png: Added.
- 6:55 PM Changeset in webkit [134518] by
-
- 3 edits19 adds3 deletes in trunk
CSS @charset parsing is too loose, doesn't match other browsers
https://bugs.webkit.org/show_bug.cgi?id=101527
Patch by Tab Atkins <jackalmage@gmail.com> on 2012-11-13
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Per <https://www.w3.org/Bugs/Public/show_bug.cgi?id=19882#attach_1244>,
IE and FF have changed to be strict about @charset parsing,
as the CSS 2.1 spec requires.
Since @charset use is very uncommon anyway,
we should match the new behavior and the spec for platform consistency.
Test: fast/encoding/css-charset-evil/css-charset-evil.html
- loader/TextResourceDecoder.cpp:
(WebCore::bytesEqual):
(WebCore::TextResourceDecoder::checkForCSSCharset):
LayoutTests:
Removed the old css-charset-evil.html test,
which tested for our loose parsing of @charset.
Now that we're tightening our parsing to match the spec and IE's and FF's new behavior,
I added a more comprehensive test of incorrect @charset rules,
to ensure that we correctly reject them.
- fast/encoding/css-charset-evil-expected.txt: Removed.
- fast/encoding/css-charset-evil.css: Removed.
- fast/encoding/css-charset-evil.html: Removed.
- fast/encoding/css-charset-evil/css-charset-evil-a1.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-a2.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-a3.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-a4.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b1.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b2.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b3.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b4.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b5.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b6.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b7.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-b8.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-c1.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-c2.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-c3.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-d1.css: Added.
- fast/encoding/css-charset-evil/css-charset-evil-expected.txt: Added.
- fast/encoding/css-charset-evil/css-charset-evil.html: Added.
- 6:53 PM Changeset in webkit [134517] by
-
- 1 edit18 adds in trunk/LayoutTests
[EFL] Add new baselines after r134435
https://bugs.webkit.org/show_bug.cgi?id=102125
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-13
- platform/efl-wk1/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
- platform/efl-wk1/fast/dom/DOMException/prototype-object-expected.txt: Added.
- platform/efl-wk1/fast/dom/DOMException/stack-trace-expected.txt: Added.
- platform/efl-wk2/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
- platform/efl-wk2/fast/dom/DOMException/prototype-object-expected.txt: Added.
- platform/efl-wk2/fast/dom/DOMException/stack-trace-expected.txt: Added.
- 6:45 PM Changeset in webkit [134516] by
-
- 30 edits25 copies9 adds in trunk/LayoutTests
More chromium-mac-mountainlion rebaselining and bug triaging.
https://bugs.webkit.org/show_bug.cgi?id=99749
Unreviewed.
- platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/chromium-mac-lion/compositing/direct-image-compositing-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/direct-image-compositing-expected.png.
- platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/clipping-foreground-expected.png.
- platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/dynamic/text-combine-expected.png.
- platform/chromium-mac-lion/fast/dynamic/text-combine-expected.txt: Added.
- platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png.
- platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt.
- platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/emphasis-combined-text-expected.png.
- platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.txt: Added.
- platform/chromium-mac-lion/fast/text/emphasis-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/emphasis-expected.png.
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png.
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt.
- platform/chromium-mac-lion/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png.
- platform/chromium-mac-lion/fast/writing-mode/border-vertical-lr-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/border-vertical-lr-expected.png.
- platform/chromium-mac-lion/fast/writing-mode/border-vertical-lr-expected.txt: Added.
- platform/chromium-mac-lion/fast/writing-mode/box-shadow-horizontal-bt-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/box-shadow-horizontal-bt-expected.png.
- platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-lr-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png.
- platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-rl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png.
- platform/chromium-mac-lion/fast/writing-mode/broken-ideographic-font-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png.
- platform/chromium-mac-lion/fast/writing-mode/broken-ideographic-font-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.txt.
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png.
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png.
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png.
- platform/chromium-mac-lion/platform/chromium/fast/text/text-stroke-with-border-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png.
- platform/chromium-mac-lion/svg/custom/foreign-object-skew-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/foreign-object-skew-expected.png.
- platform/chromium-mac-lion/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png.
- platform/chromium-mac-lion/svg/hixie/perf/007-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/perf/007-expected.png.
- platform/chromium-mac-lion/tables/mozilla/bugs/bug11026-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png.
- platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-mac/compositing/direct-image-compositing-expected.png:
- platform/chromium-mac/compositing/geometry/clipping-foreground-expected.png:
- platform/chromium-mac/fast/dynamic/text-combine-expected.png:
- platform/chromium-mac/fast/dynamic/text-combine-expected.txt: Added.
- platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
- platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt:
- platform/chromium-mac/fast/text/emphasis-combined-text-expected.png:
- platform/chromium-mac/fast/text/emphasis-combined-text-expected.txt: Added.
- platform/chromium-mac/fast/text/emphasis-expected.png:
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/chromium-mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
- platform/chromium-mac/fast/writing-mode/border-vertical-lr-expected.png:
- platform/chromium-mac/fast/writing-mode/border-vertical-lr-expected.txt: Added.
- platform/chromium-mac/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
- platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
- platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
- platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png:
- platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png:
- platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
- platform/chromium-mac/svg/hixie/perf/007-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium/TestExpectations:
- 5:52 PM Changeset in webkit [134515] by
-
- 8 edits2 copies in trunk
[WebSocket] send() and close() should not throw an exception for an unpaired surrogate but use the replacement character
https://bugs.webkit.org/show_bug.cgi?id=101569
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Replace unpaired surrogates with replacing character (U+FFFD) when
encoding text messages and close reasons. This change is aimed at
following the changes on the WebSocket API specification.
Test: http/tests/websocket/tests/hybi/close-reason-too-long.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::close):
Use String::StrictConversionReplacingUnpairedSurrogatesWithFFFD mode to encode
text message. Remove invalid utf-8 check.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
Use String::StrictConversionReplacingUnpairedSurrogatesWithFFFD mode to encode
close reason. Remove invalid utf-8 check.
LayoutTests:
- Updated tests which try to send unpaired surrogates. These tests should not throw SYNTAX_ERR.
- Add a test that checks whether WebKit throws SYNTAX_ERR when a close reason is too long.
- http/tests/websocket/tests/hybi/close-reason-too-long-expected.txt: Added.
- http/tests/websocket/tests/hybi/close-reason-too-long.html: Ditto.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Updated.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Ditto.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Ditto.
- http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Ditto.
- 5:27 PM Changeset in webkit [134514] by
-
- 9 edits in trunk/Source/WTF
Use prefix form of increment / decrement operators in WTF String classes when possible
https://bugs.webkit.org/show_bug.cgi?id=101859
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-13
Reviewed by Benjamin Poulain.
Use prefix form of increment / decrement operators whenever possible in
WTF String classes as this seems to be the convention in WebKit.
- wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::add):
- wtf/text/Base64.cpp:
(WTF::base64Encode):
(WTF::base64DecodeInternal):
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::allocateBufferUpConvert):
- wtf/text/StringConcatenate.h:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upconvertCharacters):
(WTF::StringImpl::containsOnlyWhitespace):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::stripMatchedCharacters):
(WTF::StringImpl::removeCharacters):
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::reverseFindInner):
(WTF::reverseFindIgnoringCaseInner):
(WTF::StringImpl::replace):
(WTF::StringImpl::createWithTerminatingNullCharacter):
- wtf/text/StringImpl.h:
(WTF::codePointCompare):
- wtf/text/WTFString.cpp:
(WTF::String::String):
(WTF::toIntegralType):
- 5:18 PM Changeset in webkit [134513] by
-
- 3 edits in trunk/Source/WebKit2
Make InspectorFrontendHost.moveWindowBy work in WebKit2 for Mac.
https://bugs.webkit.org/show_bug.cgi?id=102154
Reviewed by Joseph Pecoraro.
- UIProcess/WebInspectorProxy.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::getWindowFrame): Added. Call setInspectorWindowFrame.
(WebKit::setWindowFrame): Added. Call inspectorWindowFrame.
(WebKit::WebInspectorProxy::setInspectorWindowFrame): Added.
(WebKit::WebInspectorProxy::inspectorWindowFrame): Added.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create and set the WKPageUIClient
with getWindowFrame and setWindowFrame.
- 5:11 PM Changeset in webkit [134512] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r127508. <rdar://problem/12536493>
- 5:10 PM Changeset in webkit [134511] by
-
- 2 edits in trunk/Source/WebKit2
Reduce snapshot waiting time
https://bugs.webkit.org/show_bug.cgi?id=102147
<rdar://problem/12695539>
Reviewed by Brian Weinstein.
- WebProcess/Plugins/PluginView.cpp: Reduce to 1 second. Improves impressions of responsiveness.
- 5:08 PM Changeset in webkit [134510] by
-
- 4 edits3 adds in trunk
Make HTMLLegendElement.form behave according to specification
https://bugs.webkit.org/show_bug.cgi?id=101044
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-13
Reviewed by Kent Tamura.
Source/WebCore:
According to the HTML5 specification (http://dev.w3.org/html5/spec/single-page.html#dom-legend-form),
The form IDL attribute's behavior depends on whether the legend element is in a fieldset element or
not. If the legend has a fieldset element as its parent, then the form IDL attribute must return the
same value as the form IDL attribute on that fieldset element. Otherwise, it must return null.
This patch makes WebKit behaves according to specification (and Firefox). Previously, legend.form was
not returning null if the element was not inside a fieldset. Also, legend.form did not necessarily
return the same value as the parent fieldset's form attribute.
Test: fast/forms/legend/legend-form.html
- html/HTMLLegendElement.cpp:
(WebCore):
(WebCore::HTMLLegendElement::virtualForm):
- html/HTMLLegendElement.h:
(HTMLLegendElement):
LayoutTests:
A new fast/forms/legend/legend-form.html test to check that
the legend element's form attribute behaves according to
specification.
- fast/forms/legend/legend-form-expected.txt: Added.
- fast/forms/legend/legend-form.html: Added.
- 5:06 PM Changeset in webkit [134509] by
-
- 3 edits in trunk/Source/WebKit2
Factor the code to enter accelerated compositing given a layer out into a separate method
https://bugs.webkit.org/show_bug.cgi?id=102155
Reviewed by Andreas Kling.
- UIProcess/API/mac/WKView.mm:
(-[WKView _enterAcceleratedCompositingMode:]):
(-[WKView _enterAcceleratedCompositingModeWithRootLayer:]):
- UIProcess/API/mac/WKViewInternal.h:
- 4:59 PM Changeset in webkit [134508] by
-
- 2 edits in trunk/Source/WebCore
Make an assertion in JSEventListener::jsFunction() more useful.
https://bugs.webkit.org/show_bug.cgi?id=101985.
Reviewed by Geoffrey Garen.
The assertion was weakened in r134495. This strengthens it again.
No new tests.
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- 4:36 PM Changeset in webkit [134507] by
-
- 13 edits in trunk/Source/WebCore
Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669
Reviewed by Eric Carlson.
Attempt four of commit. The first two times caused build failures on Chromium. The third time
crashed the Windows test bot. It's also been rebased since r134488.
Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670
No new tests - this doesn't expose any testable surface.
- css/mediaControls.css: Added default rules that hide the new elements.
- css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.
- html/shadow/MediaControlElements.h:
(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::MediaControlsApple):
(WebCore::MediaControlsApple::create): New track container and list elements created.
(WebCore::MediaControlsApple::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlsApple::hide):
(WebCore::MediaControlsApple::makeTransparent):
(WebCore::MediaControlsApple::reset):
(WebCore::MediaControlsApple::reportedError):
(WebCore::MediaControlsApple::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):
- html/shadow/MediaControlsApple.h:
(MediaControlsApple):
- html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::initializeControls): Pass in the controls as a parameter.
- html/shadow/MediaControls.h:
(MediaControls):
- platform/Language.cpp:
(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.
- platform/Language.h:
(WebCore):
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart): New enum values into switch.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): New enum values into switch.
- 4:33 PM Changeset in webkit [134506] by
-
- 4 edits4 deletes in trunk
Unreviewed, rolling out r134377.
http://trac.webkit.org/changeset/134377
https://bugs.webkit.org/show_bug.cgi?id=101133
Caused a mysterious Android Clang build failure, needs
investigation before landing again.
Source/WebCore:
- css/html.css:
(input::-webkit-textfield-decoration-container):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attach):
LayoutTests:
- fast/forms/number/number-content-url-crash-expected.txt: Removed.
- fast/forms/number/number-content-url-crash.html: Removed.
- fast/forms/search/search-content-url-crash-expected.txt: Removed.
- fast/forms/search/search-content-url-crash.html: Removed.
- 4:16 PM Changeset in webkit [134505] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r134482.
http://trac.webkit.org/changeset/134482
https://bugs.webkit.org/show_bug.cgi?id=102140
The patch causes fast/regions/moved-content-node-crash.html to
crash in Debug mode due to ASSERTION. (Requested by abucur on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
- rendering/InlineFlowBox.cpp:
(SameSizeAsInlineFlowBox):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(InlineFlowBox):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
- rendering/RootInlineBox.h:
(WebCore):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
(WebCore::RootInlineBox::isFirstAfterPageBreak):
(WebCore::RootInlineBox::setIsFirstAfterPageBreak):
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
(RootInlineBox):
- 4:02 PM Changeset in webkit [134504] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r134503.
http://trac.webkit.org/changeset/134503
Roll out a patch that was landed just to investigate svn
trouble
- Scripts/webkitpy/common/config/committers.py:
- 4:01 PM Changeset in webkit [134503] by
-
- 2 edits in trunk/Tools
Unreviewed. Investigating svn trouble. Test commit.
- Scripts/webkitpy/common/config/committers.py:
- 3:56 PM Changeset in webkit [134502] by
-
- 2 edits4 adds in trunk/LayoutTests
Rebaselines for filtering changes due to chromium r167479
- platform/chromium-linux/compositing/checkerboard-expected.png: Added.
- platform/chromium-mac/compositing/checkerboard-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
- platform/chromium-win/compositing/checkerboard-expected.png: Added.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:
- 3:55 PM Changeset in webkit [134501] by
-
- 4 edits in branches/safari-536.27-branch/Source
Versioning.
- 3:53 PM Changeset in webkit [134500] by
-
- 2 edits in trunk/Source/WebCore
Missing NodeRenderStyle.h include in WebCore/html/TextFieldInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=102108
Reviewed by Adam Barth.
No new tests. Fix clang build break.
- html/TextFieldInputType.cpp: Added #include "NodeRenderStyle.h"
- 3:51 PM Changeset in webkit [134499] by
-
- 1 copy in tags/Safari-536.27.2
New Tag.
- 3:49 PM Changeset in webkit [134498] by
-
- 4 edits in branches/safari-536.27-branch/Source
Merged r134327 -> <rdar://problem/12695013>
- 3:31 PM Changeset in webkit [134497] by
-
- 4 edits in branches/safari-536.27-branch/Source
Versioning.
- 3:29 PM Changeset in webkit [134496] by
-
- 20 edits2 adds in trunk
AX: MathML types need to be semantically identified in AX tree
https://bugs.webkit.org/show_bug.cgi?id=101263
Reviewed by Beth Dakin.
Source/WebCore:
Semantically identify various MathML elements within the AX tree. This will allow
screen readers to identify math types so that equations can be output more accurately.
Test: platform/mac/accessibility/mathml-elements.html
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::isMathElement):
(WebCore::AccessibilityObject::isMathFraction):
(WebCore::AccessibilityObject::isMathFenced):
(WebCore::AccessibilityObject::isMathSubscriptSuperscript):
(WebCore::AccessibilityObject::isMathRow):
(WebCore::AccessibilityObject::isMathUnderOver):
(WebCore::AccessibilityObject::isMathRoot):
(WebCore::AccessibilityObject::isMathSquareRoot):
(WebCore::AccessibilityObject::isMathText):
(WebCore::AccessibilityObject::isMathNumber):
(WebCore::AccessibilityObject::isMathOperator):
(WebCore::AccessibilityObject::isMathFenceOperator):
(WebCore::AccessibilityObject::isMathSeparatorOperator):
(WebCore::AccessibilityObject::isMathIdentifier):
(WebCore::AccessibilityObject::isMathTable):
(WebCore::AccessibilityObject::isMathTableRow):
(WebCore::AccessibilityObject::isMathTableCell):
(WebCore::AccessibilityObject::mathRadicandObject):
(WebCore::AccessibilityObject::mathRootIndexObject):
(WebCore::AccessibilityObject::mathUnderObject):
(WebCore::AccessibilityObject::mathOverObject):
(WebCore::AccessibilityObject::mathNumeratorObject):
(WebCore::AccessibilityObject::mathDenominatorObject):
(WebCore::AccessibilityObject::mathBaseObject):
(WebCore::AccessibilityObject::mathSubscriptObject):
(WebCore::AccessibilityObject::mathSuperscriptObject):
(WebCore::AccessibilityObject::mathFencedOpenString):
(WebCore::AccessibilityObject::mathFencedCloseString):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
Handle a case where a MathML render element is created with the node of their parent (which could lead to an assert).
(WebCore::AccessibilityRenderObject::textUnderElement):
Handle the cases for RenderMathMLOperators which use the node of their parent, which confuses the normal textUnderElement() routine.
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
Handle ignored cases for math elements
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isMathElement):
(WebCore::AccessibilityRenderObject::isMathFraction):
(WebCore::AccessibilityRenderObject::isMathFenced):
(WebCore::AccessibilityRenderObject::isMathSubscriptSuperscript):
(WebCore::AccessibilityRenderObject::isMathRow):
(WebCore::AccessibilityRenderObject::isMathUnderOver):
(WebCore::AccessibilityRenderObject::isMathSquareRoot):
(WebCore::AccessibilityRenderObject::isMathRoot):
(WebCore::AccessibilityRenderObject::isMathOperator):
(WebCore::AccessibilityRenderObject::isMathFenceOperator):
(WebCore::AccessibilityRenderObject::isMathSeparatorOperator):
(WebCore::AccessibilityRenderObject::isMathText):
(WebCore::AccessibilityRenderObject::isMathNumber):
(WebCore::AccessibilityRenderObject::isMathIdentifier):
(WebCore::AccessibilityRenderObject::isMathTable):
(WebCore::AccessibilityRenderObject::isMathTableRow):
(WebCore::AccessibilityRenderObject::isMathTableCell):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
Make sure anonymouse blocks are ignored within math tree; make sure non-element type objects are ignored (like <mstyle>).
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
(WebCore::AccessibilityRenderObject::mathFencedOpenString):
(WebCore::AccessibilityRenderObject::mathFencedCloseString):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::isRenderMathMLFenced):
(WebCore::RenderMathMLBlock::isRenderMathMLFraction):
(WebCore::RenderMathMLBlock::isRenderMathMLRoot):
(WebCore::RenderMathMLBlock::isRenderMathMLSquareRoot):
(WebCore::RenderMathMLBlock::isRenderMathMLSubSup):
(WebCore::RenderMathMLBlock::isRenderMathMLUnderOver):
(WebCore::RenderMathMLBlock::setIgnoreInAccessibilityTree):
(WebCore::RenderMathMLBlock::ignoreInAccessibilityTree):
Add ability to identify anonymous render blocks as items that AX should ignore.
(RenderMathMLBlock):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
Identify which kind of math operator is being created on the fly (Fence or Separator)
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
- rendering/mathml/RenderMathMLFenced.h:
(WebCore::RenderMathMLFenced::isRenderMathMLFenced):
(RenderMathMLFenced):
- rendering/mathml/RenderMathMLFraction.h:
(WebCore::RenderMathMLFraction::isRenderMathMLFraction):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
Mark anonymous render blocks as AX ignored.
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::setOperatorType):
(WebCore::RenderMathMLOperator::operatorType):
(RenderMathMLOperator):
- rendering/mathml/RenderMathMLRoot.h:
(WebCore::RenderMathMLRoot::isRenderMathMLRoot):
- rendering/mathml/RenderMathMLSquareRoot.h:
(WebCore::RenderMathMLSquareRoot::isRenderMathMLSquareRoot):
- rendering/mathml/RenderMathMLSubSup.h:
(WebCore::RenderMathMLSubSup::isRenderMathMLSubSup):
- rendering/mathml/RenderMathMLUnderOver.h:
(WebCore::RenderMathMLUnderOver::isRenderMathMLUnderOver):
Source/WebKit/chromium:
- public/WebAccessibilityRole.h:
- src/AssertMatchingEnums.cpp:
Add new accessibility role.
LayoutTests:
- platform/mac/accessibility/mathml-elements-expected.txt: Added.
- platform/mac/accessibility/mathml-elements.html: Added.
- 3:21 PM Changeset in webkit [134495] by
-
- 3 edits in trunk/Source/WebCore
JSEventListener should not access m_jsFunction when its wrapper is gone.
https://bugs.webkit.org/show_bug.cgi?id=101985.
Reviewed by Geoffrey Garen.
Added a few null checks for m_wrapper before we do anything with m_jsFunction.
No new tests.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::initializeJSFunction):
- Removed a now invalid assertion. m_wrapper is expected to have a valid non-zero value when jsFunction is valid. However, in the case of JSLazyEventListener (which extends JSEventListener), m_wrapper is initially 0 when m_jsFunction has not been realized yet. When JSLazyEventListener::initializeJSFunction() realizes m_jsFunction, it will set m_wrapper to an appropriate wrapper object.
For this reason, JSEventListener::jsFunction() cannot do the null
check on m_wrapper until after the call to initializeJSFunction.
This, in turns, means that in the case of the non-lazy
JSEventListener, initializeJSFunction() will also be called, and
if the GC has collected the m_wrapper but the JSEventListener has
not been removed yet, it is possible to see a null m_wrapper while
m_jsFunction contains a non-zero stale value.
Hence, this assertion of (m_wrapper !m_jsFunction) in JSEventListener::initializeJSFunction() is not always true and
should be removed.
(WebCore::JSEventListener::visitJSFunction):
(WebCore::JSEventListener::operator==):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- 3:21 PM Changeset in webkit [134494] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Fix media/video-empty-source.html lint error.
- platform/chromium/TestExpectations: Fixed.
- 3:11 PM Changeset in webkit [134493] by
-
- 2 edits in trunk/Source/WTF
Build fix after r134490.
- wtf/FastMalloc.cpp:
- 3:06 PM Changeset in webkit [134492] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r123433. <rdar://problem/12516346>
- 2:55 PM Changeset in webkit [134491] by
-
- 7 edits in branches/safari-536.28-branch/Source/WebCore
Merged r122912. <rdar://problem/12516346>
- 2:39 PM Changeset in webkit [134490] by
-
- 2 edits in trunk/Source/WTF
Fix FastMalloc.cpp compile error for MSVC in 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=88344
Patch by Brent Fulgham <bfulgham@webkit.org> and Alex Christensen <alex.christensen@flexsim.com> on 2012-11-13
Reviewed by Ryosuke Niwa.
MSVC will not compile array declarations of zero size. The existing
padding math for TCMalloc_Central_FreeListPadded would evaluate
to zero on 64-bit machines, preventing the compile from finishing.
- wtf/FastMalloc.cpp:
(TCMalloc_Central_FreeListPadded_Template): Add new template (and
zero-size specialization) to provide proper behavior under 64-bit
Windows build.
- 2:38 PM Changeset in webkit [134489] by
-
- 17 edits in trunk/Source/WebCore
[V8] instantiateV8Object should encapulate the tricky creationContext logic
https://bugs.webkit.org/show_bug.cgi?id=102117
Reviewed by Eric Seidel.
The logic around creationContext is tricky. Rather than putting the
logic in the code generator, we can centralize the logic in
instantiateV8Object.
This patch shouldn't have any behavior change.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/v8/V8DOMWrapper.cpp:
(V8WrapperInstantiationScope):
(WebCore::V8WrapperInstantiationScope::V8WrapperInstantiationScope):
(WebCore::V8WrapperInstantiationScope::~V8WrapperInstantiationScope):
(WebCore::V8WrapperInstantiationScope::context):
(WebCore):
(WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- 2:36 PM Changeset in webkit [134488] by
-
- 17 edits1 copy3 moves3 adds3 deletes in trunk
Clean up the inheritance tree under the MediaControls Class.
https://bugs.webkit.org/show_bug.cgi?id=88871
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-11-13
Reviewed by Eric Carlson.
Source/WebCore:
This patch removes code duplication between the Chromium and Safari
media controls shadow DOMs.
This is achieved by pulling common functions that are identical (or
almost identical) between the different platforms into the base class.
The derived classes are renamed based on their platform:
- MediaControlRootElement to MediaControlsApple.
- MediaControlRootElementChromium to MediaControlsChromium.
- MediaControlRootElementChromiumAndroid to MediaControlsChromiumAndroid.
MediaControls is now no longer an abstract base class, but its "create"
function is only implemented in the port-specific header file, so it's
on purpose incomplete in the MediaControls.cpp file.
No new tests because this is refactoring work only.
- CMakeLists.txt: Rename MediaControlRootElement.cpp to MediaControlsApple.cpp .
- GNUmakefile.list.am: Rename MediaControlRootElement.[cpp,h] to MediaControlsApple.[cpp,h] .
- Target.pri: Rename MediaControlRootElement.cpp to MediaControlsApple.cpp .
- WebCore.gypi: Rename MediaControlRootElement[Chromium[Android]].[cpp,h] to MediaControls[Apple,Chromium[Android]].[cpp,h] .
- WebCore.order: Rename MediaControlRootElement symbols to MediaControlsApple symbols.
- WebCore.vcproj/WebCore.vcproj: Rename MediaControlRootElement.[cpp,h] to MediaControlsApple.[cpp,h] .
- WebCore.xcodeproj/project.pbxproj: Rename MediaControlRootElement.[cpp,h] to MediaControlsApple.[cpp,h] .
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::defaultEventHandler):
Remove dependency on MediaControlRootElement.h (base class MediaControls.h is still there).
Rename updateTimeDisplay() to updateCurrentTimeDisplay().
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::MediaControls):
Added initialization for media elements that all platform controls share.
(WebCore):
Removed include files that are already included in header file.
(WebCore::MediaControls::setMediaController):
Added controller assignment for media elements that all platform controls share.
(WebCore::MediaControls::reset):
Added resets for media elements that all platform controls share.
(WebCore::MediaControls::reportedError):
Added error handling for media elements that all platform controls share.
(WebCore::MediaControls::loadedMetadata):
Added default action for loadedMetadata event.
(WebCore::MediaControls::show):
(WebCore::MediaControls::hide):
(WebCore::MediaControls::makeOpaque):
(WebCore::MediaControls::makeTransparent):
(WebCore::MediaControls::shouldHideControls):
(WebCore::MediaControls::bufferingProgressed):
(WebCore::MediaControls::playbackStarted):
(WebCore::MediaControls::playbackProgressed):
(WebCore::MediaControls::playbackStopped):
(WebCore::MediaControls::updateCurrentTimeDisplay):
(WebCore::MediaControls::showVolumeSlider):
(WebCore::MediaControls::changedMute):
(WebCore::MediaControls::changedVolume):
(WebCore::MediaControls::changedClosedCaptionsVisibility):
(WebCore::MediaControls::enteredFullscreen):
(WebCore::MediaControls::exitedFullscreen):
(WebCore::MediaControls::defaultEventHandler):
(WebCore::MediaControls::hideFullscreenControlsTimerFired):
(WebCore::MediaControls::startHideFullscreenControlsTimer):
(WebCore::MediaControls::stopHideFullscreenControlsTimer):
(WebCore::MediaControls::shadowPseudoId):
(WebCore::MediaControls::containsRelatedTarget):
(WebCore::MediaControls::createTextTrackDisplay):
(WebCore::MediaControls::showTextTrackDisplay):
(WebCore::MediaControls::hideTextTrackDisplay):
(WebCore::MediaControls::updateTextTrackDisplay):
Added default actions for all these media controls member functions.
- html/shadow/MediaControls.h:
(WebCore):
Added include files and forward class declarations that all media controls share.
(MediaControls):
Make all pure virtual functions that have default implementations just virtual.
(WebCore::MediaControls::updateStatusDisplay):
Add an empty virtual updateStatusDisplay function which is used by media elements.
- html/shadow/MediaControlsApple.cpp: Renamed from Source/WebCore/html/shadow/MediaControlRootElement.cpp. Reduced Apple-specific media control functions by relying on default implementations in the base class.
- html/shadow/MediaControlsApple.h: Renamed from Source/WebCore/html/shadow/MediaControlRootElement.h. Reduced Apple-specific media control elements by relying on some elements in the base class.
- html/shadow/MediaControlsChromium.cpp: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp. Reduced Chromium-specific media control functions by relying on default implementations in the base class.
- html/shadow/MediaControlsChromium.h: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromium.h. Reduced Chromium-specific media control functions by relying on default implementations in the base class.
- html/shadow/MediaControlsChromiumAndroid.cpp: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromiumAndroid.cpp. Renamed class name and base class name.
- html/shadow/MediaControlsChromiumAndroid.h: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromiumAndroid.h. Renamed class name and base class name.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::timeWithoutMouseMovementBeforeHidingControls):
Moved timeWithoutMouseMovementBeforeHidingControls variable from all classes to a theme-specific function.
Source/WebKit/chromium:
This patch removes code duplication between the Chromium and Safari
media controls shadow DOMs.
The derived classes are renamed based on their platform:
- MediaControlRootElement to MediaControlsApple.
- MediaControlRootElementChromium to MediaControlsChromium.
- MediaControlRootElementChromiumAndroid to MediaControlsChromiumAndroid.
- public/WebContextMenuData.h: Move MediaControlRootElement to MediaControls.
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
Move MediaControlRootElement to MediaControls.
LayoutTests:
- platform/chromium-mac-mountainlion/TestExpectations: Added.
- platform/chromium/TestExpectations:
- 2:34 PM Changeset in webkit [134487] by
-
- 3 edits in trunk/Source/WebKit2
RemoteGraphicsLayer destructor should call GraphicsLayer::willBeDestroyed
https://bugs.webkit.org/show_bug.cgi?id=102135
Reviewed by Andreas Kling.
Call GraphicsLayer::willBeDestroyed from the RemoteGraphicsLayer destructor and move
the call to RemoteLayerTreeContext::layerWillBeDestroyed to the overridden
willBeDestroyed member function.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::~RemoteGraphicsLayer):
(WebKit::RemoteGraphicsLayer::willBeDestroyed):
(WebKit):
- 2:32 PM Changeset in webkit [134486] by
-
- 15 edits in trunk
Unreviewed, rolling out r134446.
http://trac.webkit.org/changeset/134446
https://bugs.webkit.org/show_bug.cgi?id=101968
Need to try a different strategy for landing a two-sided patch
(3/3).
Source/Platform:
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
LayoutTests:
- platform/chromium/TestExpectations:
- 2:31 PM Changeset in webkit [134485] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r134458.
http://trac.webkit.org/changeset/134458
Need to try a different strategy for landing a two-sided patch
(2/3).
- platform/chromium/TestExpectations:
- 2:30 PM Changeset in webkit [134484] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r134461.
http://trac.webkit.org/changeset/134461
Need to try a different strategy for landing a two-sided patch
(1/3).
- platform/chromium/TestExpectations:
- 2:19 PM Changeset in webkit [134483] by
-
- 3 edits in trunk/Source/WebCore
CSSParser::setStyleSheet() should be inline
https://bugs.webkit.org/show_bug.cgi?id=101829
Reviewed by Andreas Kling.
- css/CSSParser.cpp:
- css/CSSParser.h:
(WebCore::CSSParser::setStyleSheet):
CSSParser::setStyleSheet() just assign a pointer, it does not even
change a ref-count. The function should probably be in the header.
- 2:14 PM Changeset in webkit [134482] by
-
- 7 edits in trunk/Source/WebCore
[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data
https://bugs.webkit.org/show_bug.cgi?id=101332
Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-13
Reviewed by David Hyatt.
Currently the pagination information for lines is spread between the RootInlineBox and InlineFlowBox classes, consuming memory even though
the boxes were not the result of an pagination layout. To overcome this, a new struct (LineFragmentationData) is created that wraps all the data,
including a new member, the containing Region for the line.
The containing Region is used to detect if a line changed the Region where it resides. This will be helpful especially when implementing region
styling for layout properties (e.g. the font-size property https://bugs.webkit.org/show_bug.cgi?id=95559 ).
A line can change the region when it is shifted inside the containing block or if the entire block moves. This means it's better to delegate
the task of updating the containing Region to the block.
Tests: No new tests because there is no functional change.
- rendering/InlineFlowBox.cpp:
(SameSizeAsInlineFlowBox):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(InlineFlowBox):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::setContainingRegion):
(WebCore):
- rendering/RootInlineBox.h:
(WebCore):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
(WebCore::RootInlineBox::isFirstAfterPageBreak):
(WebCore::RootInlineBox::setIsFirstAfterPageBreak):
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
(RootInlineBox):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::ensureLineFragmentationData):
(LineFragmentationData):
(WebCore::RootInlineBox::LineFragmentationData::LineFragmentationData):
- 2:05 PM Changeset in webkit [134481] by
-
- 10 edits2 copies2 adds in trunk/Source/WebKit2
Split NetworkRequest up into a request class and a loading class.
https://bugs.webkit.org/show_bug.cgi?id=102049
Reviewed by Alexey Proskuryakov.
NetworkRequest unintentionally grew into a class that managed actual loading.
This patch splits it into "NetworkResourceLoadParameters" for all request-related data
and "NetworkResourceLoader" for handling the actual load itself.
Change HostRecord to manage NetworkResourceLoaders instead of NetworkRequests:
- NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::~HostRecord):
(WebKit::HostRecord::schedule):
(WebKit::HostRecord::addLoadInProgress):
(WebKit::HostRecord::remove):
(WebKit::HostRecord::hasRequests):
(WebKit::HostRecord::limitRequests):
- NetworkProcess/HostRecord.h:
(WebKit::HostRecord::loadersPending):
A new class to be a container for all the data required to start a network load:
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(WebKit::NetworkResourceLoadParameters::request):
(WebKit::NetworkResourceLoadParameters::priority):
(WebKit::NetworkResourceLoadParameters::contentSniffingPolicy):
Pass a single NetworkResourceLoadParameters around instead of multiple bits of data:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleResourceLoad):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost):
- NetworkProcess/NetworkResourceLoadScheduler.h:
The actual ResourceHandleClient that does the actual loading:
- NetworkProcess/NetworkResourceLoader.cpp: Renamed from Source/WebKit2/NetworkProcess/NetworkRequest.cpp.
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::priority):
(WebKit::NetworkResourceLoader::start):
(WebKit::requestsToStopMutex):
(WebKit::requestsToStop):
(WebKit::NetworkResourceLoader::scheduleStopOnMainThread):
(WebKit::NetworkResourceLoader::performStops):
(WebKit::NetworkResourceLoader::stop):
(WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::responseMap):
(WebKit::generateWillSendRequestID):
(WebKit::didReceiveWillSendRequestHandled):
(WebKit::NetworkResourceLoader::willSendRequest):
(WebKit::NetworkResourceLoader::didSendData):
(WebKit::NetworkResourceLoader::didReceiveCachedMetadata):
(WebKit::NetworkResourceLoader::wasBlocked):
(WebKit::NetworkResourceLoader::cannotShowURL):
(WebKit::NetworkResourceLoader::willCacheResponse):
(WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):
(WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge):
(WebKit::NetworkResourceLoader::receivedCancellation):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkResourceLoader::supportsDataArray):
(WebKit::NetworkResourceLoader::didReceiveDataArray):
(WebKit::NetworkResourceLoader::willStopBufferingData):
(WebKit::NetworkResourceLoader::createAsyncFileStream):
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::create):
(WebKit::NetworkResourceLoader::identifier):
(WebKit::NetworkResourceLoader::connectionToWebProcess):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- 1:53 PM Changeset in webkit [134480] by
-
- 5 edits2 copies in branches/safari-536.28-branch
Merged r125280. <rdar://problem/12516346>
- 1:50 PM Changeset in webkit [134479] by
-
- 2 edits in trunk/Source/WTF
FastMalloc.cpp needs to be reordered before padding bug can be fixed
https://bugs.webkit.org/show_bug.cgi?id=89366
Note: This file violates Style rules. This change only moves
the TCMalloc_Central_FreeList class declaration and the various
FastMallocZone methods earlier in the file.
Patch by Brent Fulgham <bfulgham@webkit.org> and Alex Christensen <alex.christensen@flexsim.com> on 2012-11-13
Reviewed by Ryosuke Niwa.
- wtf/FastMalloc.cpp:
Reordered definitions to prepare for adding specialized template
(WTF):
(TCMalloc_Central_FreeList):
(WTF::TCMalloc_Central_FreeList::length):
(WTF::TCMalloc_Central_FreeList::tc_length):
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects):
(TCMalloc_Central_FreeListPadded):
(FastMallocZone):
(WTF::FastMallocZone::goodSize):
(WTF::FastMallocZone::check):
(WTF::FastMallocZone::print):
(WTF::FastMallocZone::log):
(WTF::FastMallocZone::forceLock):
(WTF::FastMallocZone::forceUnlock):
(WTF::FastMallocZone::statistics):
(WTF::FastMallocZone::zoneValloc):
(WTF::FastMallocZone::zoneDestroy):
(WTF::KernelSupportsTLS):
(WTF::CheckIfKernelSupportsTLS):
(TCMalloc_ThreadCache):
- 1:46 PM Changeset in webkit [134478] by
-
- 7 edits in trunk/Source/WebKit2
Store destroyed layers in the remote layer tree transaction
https://bugs.webkit.org/show_bug.cgi?id=102127
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
(RemoteLayerTreeTransaction):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::setDestroyedLayerIDs):
(WebKit):
(WebKit::RemoteLayerTreeTransaction::dump):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::~RemoteGraphicsLayer):
(WebKit::RemoteGraphicsLayer::removeFromParent):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
(RemoteLayerTreeContext):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
(WebKit::RemoteLayerTreeContext::flushLayers):
- 1:44 PM Changeset in webkit [134477] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marked fast/workers/worker-exception-during-navigation.html as a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=102131
- platform/chromium/TestExpectations: Added a flaky crash expectation.
- 1:37 PM Changeset in webkit [134476] by
-
- 2 edits in trunk/Source/WebCore
[Qt] QNX build fails due to signature change in gl2.h header (glShaderSource)
https://bugs.webkit.org/show_bug.cgi?id=98038
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-11-13
Reviewed by Simon Hausmann.
Cast the function to the expected type, just like it is done on non-Qt/OpenGL2 ES platforms.
- platform/graphics/OpenGLShims.cpp:
(WebCore):
- 1:25 PM Changeset in webkit [134475] by
-
- 3 edits2 adds in trunk
WebKit exposes ARIA rowheader role as AXUnknown when not contained in table/grid
https://bugs.webkit.org/show_bug.cgi?id=101616
Reviewed by Beth Dakin.
Source/WebCore:
If the rowheader role is exposed because the element is not within a table, the mac platform
should map that to a generic group.
Test: platform/mac/accessibility/rowheader-outside-table-role.html
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
LayoutTests:
- platform/mac/accessibility/rowheader-outside-table-role-expected.txt: Added.
- platform/mac/accessibility/rowheader-outside-table-role.html: Added.
- 1:23 PM Changeset in webkit [134474] by
-
- 2 edits1 add in trunk/LayoutTests
Remove a few old no-longer-failing tests and update one baseline.
Unreviewed, gardening.
- platform/chromium-linux/fast/text/zero-font-size-2-expected.png: Added.
- platform/chromium/TestExpectations:
- 1:18 PM Changeset in webkit [134473] by
-
- 3 edits4 copies in branches/safari-536.28-branch
Merged r127000. <rdar://problem/12536475>
- 1:11 PM Changeset in webkit [134472] by
-
- 2 edits in trunk/Source/WebKit/win
REGRESSION(r130643): Assertion failure when running DRT in debug mode
https://bugs.webkit.org/show_bug.cgi?id=101791
Reviewed by Darin Adler.
When running DRT in debug mode, we hit an assertion failure in initializing the WebKit instance.
This failure started occuring in r130643 and this work around follows the work around in r132302.
- WebKitCOMAPI.cpp:
(CLSIDHashTraits):
- 1:10 PM Changeset in webkit [134471] by
-
- 4 edits in trunk/Source
Adjust the Web Inspector window title frame if needed to prevent it from intersecting the dock button.
https://bugs.webkit.org/show_bug.cgi?id=102073
Reviewed by Joseph Pecoraro.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindow _customTitleFrame]): Added. Adjust the title frame.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorWindow _customTitleFrame]): Added. Adjust the title frame.
- 1:04 PM Changeset in webkit [134470] by
-
- 16 edits2 deletes in branches/safari-536.28-branch
Rollout 133090. <rdar://problem/12536517>
- 12:54 PM Changeset in webkit [134469] by
-
- 5 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r129959. <rdar://problem/12516361>
- 12:39 PM Changeset in webkit [134468] by
-
- 42 edits8 adds in trunk/LayoutTests
[EFL] Unreviewed gardening.
Skip a few tests, update expectations when some colors varied
slightly from the existing expectation and add a few new ones.
- platform/efl-wk1/TestExpectations:
- platform/efl/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/efl/fast/forms/menulist-no-overflow-expected.png:
- platform/efl/fast/forms/menulist-separator-painting-expected.png:
- platform/efl/fast/forms/select-background-none-expected.png:
- platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.png:
- platform/efl/fast/forms/select-selected-expected.png:
- platform/efl/fast/forms/select-visual-hebrew-expected.png:
- platform/efl/fast/forms/selectlist-minsize-expected.png:
- platform/efl/fast/forms/stuff-on-my-optgroup-expected.png:
- platform/efl/fast/html/keygen-expected.png:
- platform/efl/fast/images/png-suite/test-expected.png:
- platform/efl/fast/replaced/image-sizing-expected.png:
- platform/efl/fast/replaced/three-selects-break-expected.png:
- platform/efl/fast/replaced/width100percent-menulist-expected.png:
- platform/efl/fast/ruby/overhang-horizontal-expected.png: Added.
- platform/efl/fast/runin/runin-generated-before-content-expected.png: Added.
- platform/efl/fast/text/updateNewFont-expected.png:
- platform/efl/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
- platform/efl/fast/writing-mode/box-shadow-vertical-lr-expected.png:
- platform/efl/fast/writing-mode/english-lr-text-expected.png:
- platform/efl/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
- platform/efl/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
- platform/efl/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
- platform/efl/svg/filters/feColorMatrix-offset-expected.png: Added.
- platform/efl/svg/filters/feDropShadow-subregion-expected.png: Added.
- platform/efl/svg/filters/feGaussianBlur-subregion-expected.png: Added.
- platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
- platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
- platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
- platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
- platform/efl/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/efl/svg/filters/feImage-subregions-expected.png:
- platform/efl/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/efl/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/efl/svg/filters/feLighting-crash-expected.png:
- platform/efl/svg/filters/feOffset-expected.png:
- platform/efl/svg/filters/feTile-expected.png:
- platform/efl/svg/filters/filter-on-tspan-expected.png:
- platform/efl/svg/filters/filter-placement-issue-expected.png:
- platform/efl/svg/filters/filter-rounding-issues-expected.png:
- platform/efl/svg/filters/filter-source-position-expected.png: Added.
- platform/efl/svg/filters/filteredImage-expected.png: Added.
- platform/efl/svg/filters/parent-children-with-same-filter-expected.png:
- platform/efl/svg/filters/shadow-on-filter-expected.png:
- platform/efl/svg/filters/subRegion-one-effect-expected.png:
- platform/efl/svg/filters/subRegion-two-effects-expected.png:
- platform/efl/svg/foreignObject/filter-expected.png: Added.
- platform/efl/svg/text/selection-doubleclick-expected.png:
- 12:39 PM Changeset in webkit [134467] by
-
- 4 edits2 adds in trunk/Source/WebCore
[Chromium] Fix SkImageFilter DAG path to pass all css3/filters tests
https://bugs.webkit.org/show_bug.cgi?id=101952
Reviewed by James Robinson.
With these changes, all of the css3/filters tests pass when the
if-test in GraphicsLayerChromium::setFilters() is forced true (for
now, it remains true only if there's a reference filter in the chain).
Covered by the css3/filters tests (when the switch is thrown in
GraphicsLayerChromium::setFilters()).
- WebCore.gypi:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
Drop to software rendering if there's a custom filter in the chain.
This is the same as the WebFilterOperations path is doing.
- platform/graphics/filters/skia/DropShadowImageFilter.cpp: Added.
- platform/graphics/filters/skia/DropShadowImageFilter.h: Added.
New implementation of drop-shadow filter; equivalent to
the path in cc/render_surface_filters.cc.
- platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
Fix the sepia and grayscale filters (value was inverted).
- 12:36 PM Changeset in webkit [134466] by
-
- 32 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r134442.
http://trac.webkit.org/changeset/134442
https://bugs.webkit.org/show_bug.cgi?id=102111
Does not compile on apple-mac (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
- css/CSSImageValue.h:
(WebCore):
(CSSImageValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::load):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::cachedShader):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::preload):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore):
(WebCore::CachedResourceLoader::preload):
- loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
- loader/cache/CachedResourceRequest.h:
(CachedResourceRequest):
(WebCore::CachedResourceRequest::defer):
(WebCore::CachedResourceRequest::setDefer):
- loader/cache/CachedResourceRequestInitiators.cpp: Removed.
- loader/cache/CachedResourceRequestInitiators.h: Removed.
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
- platform/ThreadGlobalData.h:
(ThreadGlobalData):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
- 12:30 PM Changeset in webkit [134465] by
-
- 6 edits2 adds in trunk
AX: file upload input text value is not exposed through accessibility
https://bugs.webkit.org/show_bug.cgi?id=100583
Reviewed by Beth Dakin.
Source/WebCore:
This is a hard problem to solve on the Mac because there are three pieces of information
1) The type of button 2) The text on the button 3) The text for the value.
I think the best compromise is to label this as a file upload button type in the role description,
and then expose the file path text as the AXTitle.
This will give the more relevant information and should be clear what is happening.
Test: platform/mac/accessibility/file-upload-button-subrole.html
- English.lproj/Localizable.strings:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
- platform/LocalizedStrings.cpp:
(WebCore::AXFileUploadButtonText):
- platform/LocalizedStrings.h:
LayoutTests:
- platform/mac/accessibility/file-upload-button-subrole-expected.txt: Added.
- platform/mac/accessibility/file-upload-button-subrole.html: Added.
- 12:17 PM Changeset in webkit [134464] by
-
- 7 edits in trunk
Unreviewed, rolling out r133944.
http://trac.webkit.org/changeset/133944
https://bugs.webkit.org/show_bug.cgi?id=102118
Only JS bindings support NATIVE_TYPE_ERR (Requested by arv on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
Source/WebCore:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNamedConstructorCallback):
(TypeCanFailConversion):
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
- dom/Element.idl:
LayoutTests:
- fast/dom/Element/attr-param-typechecking-expected.txt:
- fast/dom/Element/script-tests/attr-param-typechecking.js:
- 12:11 PM Changeset in webkit [134463] by
-
- 27 edits in trunk/Source/WebCore
Unreviewed.
Update run-bindings-tests results.
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::dispatchWrapCustom):
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::toNative):
(V8Float64Array):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::toNative):
(V8TestActiveDOMObject):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::toNative):
(V8TestCustomNamedGetter):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::toNative):
(V8TestEventConstructor):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::toNative):
(V8TestEventTarget):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::toNative):
(V8TestException):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::toNative):
(V8TestInterface):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::toNative):
(V8TestMediaQueryListListener):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::toNative):
(V8TestNamedConstructor):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::V8TestNode::toNative):
(V8TestNode):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
(WebCore::toV8Fast):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::toNative):
(V8TestObj):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::wrapSlow):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::V8TestOverloadedConstructors::toNative):
(V8TestOverloadedConstructors):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::toNative):
(V8TestSerializedScriptValueInterface):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
- 12:11 PM Changeset in webkit [134462] by
-
- 5 edits in trunk/Source/WebKit2
Store layer positions and sizes in the transaction
https://bugs.webkit.org/show_bug.cgi?id=102115
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
(WebKit::dumpChangedLayers):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::setPosition):
(WebKit::RemoteGraphicsLayer::setSize):
- 12:08 PM Changeset in webkit [134461] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations for animation tests.
- platform/chromium/TestExpectations:
- 11:58 AM Changeset in webkit [134460] by
-
- 5 edits in trunk/Source/JavaScriptCore
JSFunction and its descendants should be destructible
https://bugs.webkit.org/show_bug.cgi?id=102062
Reviewed by Mark Hahnenberg.
This will make it easy to place an InlineWatchpointSet inside JSFunction. In the
future, we could make JSFunction non-destructible again by making a version of
WatchpointSet that is entirely GC'd, but this seems like overkill for now.
This is performance-neutral.
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::destroy):
(JSC):
- runtime/JSBoundFunction.h:
(JSBoundFunction):
- runtime/JSFunction.cpp:
(JSC):
(JSC::JSFunction::destroy):
- runtime/JSFunction.h:
(JSFunction):
- 11:55 AM Changeset in webkit [134459] by
-
- 2 edits4 copies in branches/chromium/1312
Merge 134377 - Crash when replacing parts of text inputs with content: url(...)
https://bugs.webkit.org/show_bug.cgi?id=101133
Reviewed by Kent Tamura.
Source/WebCore:
Disable directly setting content of elements in an input element's
shadow dom tree, because the setting breaks input element's behavior.
Tests: fast/forms/number/number-content-url-crash.html
fast/forms/search/search-content-url-crash.html
- css/html.css:
(input::-webkit-textfield-decoration-container):
Use important to disable overriding an input element's content
property.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attach):
Added ASSERTION. No content should be applied to
input::-webkit-textfield-decoration-container.
LayoutTests:
- fast/forms/number/number-content-url-crash-expected.txt: Added.
- fast/forms/number/number-content-url-crash.html: Added.
- fast/forms/search/search-content-url-crash-expected.txt: Added.
- fast/forms/search/search-content-url-crash.html: Added.
TBR=tasak@google.com
Review URL: https://codereview.chromium.org/11293258
- 11:53 AM Changeset in webkit [134458] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Pacify linter and tweak expectations to avoid conflicts.
- platform/chromium/TestExpectations: Tweaked.
- 11:42 AM Changeset in webkit [134457] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed.
Speculative build fix for Qt.
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- 11:40 AM Changeset in webkit [134456] by
-
- 9 edits2 adds in trunk
Allow painting outside overflow clip in accelerated scrolling layers
https://bugs.webkit.org/show_bug.cgi?id=100524
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-13
Reviewed by Simon Fraser.
Source/WebCore:
In preparation for avoiding repaints when scrolling child layers, make it
possible to paint outside the overflow clip.
Test: compositing/overflow/updating-scrolling-content.html
- rendering/LayoutState.h:
(LayoutState):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::repaintBlockSelectionGaps):
LayoutTests:
Added a test to check painting outside the overflow clip. Note that this will
not pass unless ENABLE_ACCELERATED_OVERFLOW_SCROLLING is enabled.
- compositing/overflow/updating-scrolling-content-expected.txt: Added.
- compositing/overflow/updating-scrolling-content.html: Added.
- platform/chromium/TestExpectations: Mark test as expected to fail by default.
- platform/mac/TestExpectations: Skip the test.
- 11:33 AM Changeset in webkit [134455] by
-
- 5 edits in trunk/Source/WebKit2
The layer tree transaction should include the root layer
https://bugs.webkit.org/show_bug.cgi?id=102109
Reviewed by Andreas Kling.
Keep the root layer ID in the layer tree transaction and encode/decode and dump it.
- Shared/mac/RemoteLayerTreeTransaction.h:
(RemoteLayerTreeTransaction):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::setRootLayerID):
(WebKit):
(WebKit::RemoteLayerTreeTransaction::dump):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
(RemoteLayerTreeContext):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::setRootLayer):
(WebKit::RemoteLayerTreeContext::flushLayers):
- 11:31 AM Changeset in webkit [134454] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Remove the test that is now passing.
- platform/chromium/TestExpectations: Removed expectation of failure.
- 11:31 AM Changeset in webkit [134453] by
-
- 2 edits in trunk/Source/WebCore
Port SimpleFontDataWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=97889
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around some parts of the code, so it can be used by the WinCE port too in a next step.
Also cleaned up the include headers.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore):
(WebCore::SimpleFontData::widthForGDIGlyph):
- 11:29 AM Changeset in webkit [134452] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Chromium] move spectrum.css into the standalone css files group.
Not reviewed: moved css file in gypi.
- WebCore.gypi:
- 11:24 AM Changeset in webkit [134451] by
-
- 5 edits3 deletes in trunk
Unreviewed, rolling out r134434.
http://trac.webkit.org/changeset/134434
https://bugs.webkit.org/show_bug.cgi?id=102072
The test that was added asserts in loader.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::createWindow):
- page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect):
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
(WebCore::DOMWindow::open):
(WebCore::DOMWindow::showModalDialog):
- page/DOMWindow.h:
(DOMWindow):
LayoutTests:
- fast/dom/Window/open-window-min-size-expected.txt: Removed.
- fast/dom/Window/open-window-min-size.html: Removed.
- fast/dom/Window/resources/print-close.html: Removed.
- 11:21 AM Changeset in webkit [134450] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r134449.
http://trac.webkit.org/changeset/134449
https://bugs.webkit.org/show_bug.cgi?id=102076
Re-rolling in the patch, it was innocent.
- TestWebKitAPI/PlatformEfl.cmake:
- 11:10 AM Changeset in webkit [134449] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r134424.
http://trac.webkit.org/changeset/134424
https://bugs.webkit.org/show_bug.cgi?id=102076
Made fast/dom/Window/open-window-min-size.html crash.
- TestWebKitAPI/PlatformEfl.cmake:
- 11:10 AM Changeset in webkit [134448] by
-
- 2 edits3 adds in trunk/LayoutTests
[Chromium] Rebaselined platform/chromium/virtual/softwarecompositing/layer-creation/spanOverlapsCanvas.html
https://bugs.webkit.org/show_bug.cgi?id=101997
Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-13
Reviewed by James Robinson.
Since we disabled hardware accelerated canvas when in software compositing mode,
this layout test doesn't create any layers which is the correct behaviour.
- platform/chromium/TestExpectations:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
- 11:06 AM Changeset in webkit [134447] by
-
- 36 edits1 add in trunk/Source
[V8] More efficient wrapper dispatch
https://bugs.webkit.org/show_bug.cgi?id=102082
Patch by Dan Carney <dcarney@google.com> on 2012-11-13
Reviewed by Adam Barth.
Source/WebCore:
Dispatching a call to V8Whatever::wrap involved a chain
of calls, each of which checked its wrapper cache.
This refactor gives calls only 2 choices of functions to call:
toV8 and toV8Object instead of wrap. wrap has been renamed to
dispatchWrap and no longer contains cache checks.
Additionally, classes which require a custom toV8 function
have had all wrapping and caching calls removed, as they could
not have been accessed.
No new tests. Sufficiently covered.
- Modules/indexeddb/IDBAny.idl:
- Modules/indexeddb/IDBKey.idl:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GenerateToV8Converters):
- bindings/scripts/IDLAttributes.txt:
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::dispatchWrapCustom):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::V8CSSRule::dispatchWrapCustom):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::V8CSSValue::dispatchWrapCustom):
- bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:
(WebCore::V8CanvasRenderingContext::dispatchWrapCustom):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore):
(WebCore::V8DataView::dispatchWrapCustom):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::dispatchWrapCustom):
- bindings/v8/custom/V8ElementCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8PerformanceEntryCustom.cpp.
(WebCore):
(WebCore::V8Element::dispatchWrapCustom):
- bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::V8Entry::dispatchWrapCustom):
- bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::V8EntrySync::dispatchWrapCustom):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore):
(WebCore::V8Event::dispatchWrapCustom):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::dispatchWrapCustom):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::dispatchWrapCustom):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::dispatchWrapCustom):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::V8ImageData::dispatchWrapCustom):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::dispatchWrapCustom):
- bindings/v8/custom/V8PerformanceEntryCustom.cpp:
(WebCore::V8PerformanceEntry::dispatchWrapCustom):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::V8SVGDocument::dispatchWrapCustom):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::V8SVGElement::dispatchWrapCustom):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::V8SVGPathSeg::dispatchWrapCustom):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::V8StyleSheet::dispatchWrapCustom):
- dom/Element.idl:
- dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
- html/MicroDataItemValue.idl:
- inspector/ScriptProfile.idl:
- inspector/ScriptProfileNode.idl:
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
Source/WebKit/chromium:
- src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
- src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
- 11:05 AM Changeset in webkit [134446] by
-
- 14 edits in trunk
[chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
https://bugs.webkit.org/show_bug.cgi?id=101968
Reviewed by James Robinson.
Source/Platform:
Move the outlier settings from WebCompositorSupport to WebLayerTreeView.
PerTilePainting and AcceleratedAnimations are simply moved over. The
PartialSwap and PageScalePinchZoomInCompositor settings, however, are
not used by DRT, so we remove them.
This change will temporarily break the --per-tile-painting and
--accelerated-animations command line flags for chromium DRT until
a chromium side patch hooks up the WebLayerTreeSettings again, but
we have no bots running with these flags.
PinchZoom will be unaffected by this, as DRT never turned it on, and by
passing the WebLayerTreeSetting, chromium will not use it from here yet,
either.
PartialSwap will be also unaffected, as there was no place in WebKit
that would enable it currently.
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebKit/chromium:
This adds perTilePainting and acceleratedAniamtions to the WebSettings
classes, so that DRT can turn these on via WebLayerTreeSettings.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
(WebKit::WebSettingsImpl::perTilePaintingEnabled):
(WebKit::WebSettingsImpl::acceleratedAnimationEnabled):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):
(TestShell):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
- 10:59 AM Changeset in webkit [134445] by
-
- 2 edits in trunk/Tools
Fix webkitpy issues arising from a partially-installed pylint.
Unreviewed, build fix.
This patch ensures that we will re-install the pylint and logilab
packages if any of them are missing, not just the pylint package.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._install_pylint):
- 10:58 AM Changeset in webkit [134444] by
-
- 5 edits in trunk/LayoutTests
Revert the changes from r134388 and r134426 as r134345 was rolled out.
- platform/efl/fast/dynamic/insertAdjacentElement-expected.txt:
- platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt:
- platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
- platform/qt/fast/dynamic/insertAdjacentElement-expected.txt:
- 10:53 AM Changeset in webkit [134443] by
-
- 4 edits14 deletes in trunk
Unreviewed, rolling out r134367.
http://trac.webkit.org/changeset/134367
https://bugs.webkit.org/show_bug.cgi?id=100738
Speculative rollout, could have cause Dromaeo setAttribute
perf regression.
PerformanceTests:
- DOM/ModifyAttribute.html: Removed.
- DOM/resources/dom-perf/modify-attribute.js: Removed.
Source/WebCore:
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::checkNeedsStyleInvalidationForClassChange):
(WebCore::Element::classAttributeChanged):
LayoutTests:
- fast/dom/shadow/distribution-attribute-modified-expected.html: Removed.
- fast/dom/shadow/distribution-attribute-modified.html: Removed.
- fast/dom/shadow/distribution-className-modified-expected.html: Removed.
- fast/dom/shadow/distribution-className-modified.html: Removed.
- fast/dom/shadow/distribution-id-modified-expected.html: Removed.
- fast/dom/shadow/distribution-id-modified.html: Removed.
- fast/dom/shadow/reprojection-attribute-modified-expected.html: Removed.
- fast/dom/shadow/reprojection-attribute-modified.html: Removed.
- fast/dom/shadow/reprojection-className-modified-expected.html: Removed.
- fast/dom/shadow/reprojection-className-modified.html: Removed.
- fast/dom/shadow/reprojection-id-modified-expected.html: Removed.
- fast/dom/shadow/reprojection-id-modified.html: Removed.
- 10:52 AM Changeset in webkit [134442] by
-
- 32 edits2 copies in trunk/Source/WebCore
Add initiator to CachedResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=101935
Patch by Marja Hölttä <marja@chromium.org> on 2012-11-13
Reviewed by Adam Barth.
Motivation: Chromium needs to know which elements request a
resource (such as an image or a script) (bug 92761). In addition,
for exposing resource timing information (bug 84883) we need to
store the initiator, and this is the first step towards it.
No new tests: No visible change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSCrossfadeValue.cpp:
(WebCore::cachedImageForCSSValue):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
- css/CSSImageValue.h:
(WebCore):
(CSSImageValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::load):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::cachedShader):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::preload):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore):
(WebCore::CachedResourceLoader::preload):
- loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
(WebCore):
(WebCore::CachedResourceRequest::~CachedResourceRequest):
(WebCore::CachedResourceRequest::setInitiator):
(WebCore::CachedResourceRequest::initiatorName):
(WebCore::CachedResourceRequest::initiatorDocument):
(WebCore::CachedResourceRequest::initiatorElement):
- loader/cache/CachedResourceRequest.h:
(WebCore):
(WebCore::CachedResourceRequest::setOptions):
(WebCore::CachedResourceRequest::defer):
(WebCore::CachedResourceRequest::setDefer):
(CachedResourceRequest):
- loader/cache/CachedResourceRequestInitiators.cpp: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
(WebCore):
(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):
- loader/cache/CachedResourceRequestInitiators.h: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
(WebCore):
(CachedResourceRequestInitiators):
(WebCore::cachedResourceRequestInitiators):
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
- platform/ThreadGlobalData.h:
(WebCore):
(WebCore::ThreadGlobalData::cachedResourceRequestInitiators):
(ThreadGlobalData):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
- 10:51 AM Changeset in webkit [134441] by
-
- 4 edits1 add in trunk/LayoutTests
[EFL] More unreviewed gardening.
Update some pixel expectations and skip one test.
- platform/efl/TestExpectations:
- platform/efl/fast/media/view-mode-media-feature-expected.png: Added property svn:mime-type.
- platform/efl/fast/overflow/overflow_hidden-expected.png: Modified property svn:mime-type.
- platform/efl/svg/text/text-rescale-expected.png: Added.
- 10:47 AM Changeset in webkit [134440] by
-
- 53 edits in trunk
Unreviewed, rolling out r134345.
http://trac.webkit.org/changeset/134345
https://bugs.webkit.org/show_bug.cgi?id=102106
Incomplete support for NATIVE_TYPE_ERR in objc and other
bindings (Requested by jsbell on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
Source/WebCore:
- Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::create):
- Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::setBinaryType):
- Modules/mediastream/RTCIceCandidate.cpp:
(WebCore::RTCIceCandidate::create):
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
- Modules/mediastream/RTCSessionDescription.cpp:
(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::setType):
- bindings/js/CallbackFunction.cpp:
(WebCore::checkFunctionOnlyCallback):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
- bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::selectIndexSetter):
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
- bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallString):
- bindings/v8/V8Callback.h:
(WebCore::createFunctionOnlyCallback):
- bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
- bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- dom/DOMCoreException.idl:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD):
- page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::extend):
- svg/properties/SVGTransformListPropertyTearOff.h:
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
LayoutTests:
- canvas/philip/tests/2d.drawImage.null.html:
- canvas/philip/tests/2d.imageData.put.null.html:
- canvas/philip/tests/2d.pattern.image.null.html:
- editing/selection/extend-expected.txt:
- fast/dom/Geolocation/argument-types-expected.txt:
- fast/dom/Geolocation/not-enough-arguments-expected.txt:
- fast/dom/Geolocation/script-tests/argument-types.js:
(test):
- fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
- fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
- fast/js/select-options-add-expected.txt:
- fast/mediastream/RTCIceCandidate-expected.txt:
- fast/mediastream/RTCPeerConnection-expected.txt:
- fast/mediastream/RTCSessionDescription-expected.txt:
- media/encrypted-media/encrypted-media-syntax-expected.txt:
- media/encrypted-media/encrypted-media-syntax.html:
- media/video-test.js:
- platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
- security/crypto-random-values-types-expected.txt:
- svg/dom/SVGTransformList-expected.txt:
- 10:45 AM Changeset in webkit [134439] by
-
- 2 edits in trunk/LayoutTests
IndexedDB: storage/indexeddb/mozilla/add-twice-failure.html is flaky following r134252
https://bugs.webkit.org/show_bug.cgi?id=101996
Reviewed by Dimitri Glazkov.
Error being tested may cause transaction to abort, which could happen before or after
test output is captured. Prevent default behavior of the error so this doesn't happen.
- storage/indexeddb/mozilla/resources/add-twice-failure.js:
(addSecondExpectedError):
- 10:26 AM Changeset in webkit [134438] by
-
- 3 edits in trunk/Tools
Unreviewed, adding my new email address to committers.py and watchlist.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 10:23 AM Changeset in webkit [134437] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fully restore both zoom and scroll when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=102094
Reviewed by Rob Buis.
PR 234187.
Cache both the zoom and scroll position prior to adjusting
for input focus so that state can be reset fully.
Reviewed Internally by Gen Mak.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 10:19 AM Changeset in webkit [134436] by
-
- 8 edits in trunk/Source/WebKit/chromium
IndexedDB: remove legacy string-based backend methods
https://bugs.webkit.org/show_bug.cgi?id=102004
Reviewed by Adam Barth.
This is the final stage in a refactor, preceded by
https://bugs.webkit.org/show_bug.cgi?id=100426
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):
(WebKit::WebIDBObjectStore::index):
- public/WebIDBTransaction.h:
- src/IDBDatabaseBackendProxy.cpp:
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/IDBTransactionBackendProxy.cpp:
- src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
- 10:02 AM Changeset in webkit [134435] by
-
- 36 edits in trunk
Update DOMException name: HierarchyRequestError
https://bugs.webkit.org/show_bug.cgi?id=102092
Reviewed by Ojan Vafai.
Source/WebCore:
Patch 3 of 25 to update DOMException name to match the spec and Firefox.
Updated existing tests.
- dom/DOMCoreException.cpp:
LayoutTests:
Updated tests and expectations.
- fast/dom/DOMException/prototype-object-expected.txt:
- fast/dom/DOMException/prototype-object.html:
- fast/dom/DOMException/stack-trace-expected.txt:
- fast/dom/DOMException/stack-trace.html:
- fast/dom/Document/replace-child-expected.txt:
- fast/dom/Range/31684-expected.txt:
- fast/dom/Range/range-exceptions-expected.txt:
- fast/dom/Range/script-tests/31684.js:
- fast/dom/Range/script-tests/range-exceptions.js:
- fast/dom/Range/surroundContents-1.html:
- fast/dom/css-mediarule-functions-expected.txt:
- fast/dom/css-mediarule-functions.html:
- fast/dom/document-set-body-expected.txt:
- fast/dom/document-set-body.html:
- fast/dom/move-nodes-across-documents.html:
- fast/dom/processing-instruction-appendChild-exceptions-expected.txt:
- fast/dom/processing-instruction-appendChild-exceptions.xhtml:
- fast/dom/setter-type-enforcement-expected.txt:
- fast/dom/shadow/adopt-node-with-shadow-root-expected.txt:
- fast/dom/shadow/shadow-disable-expected.txt:
- fast/dom/shadow/shadow-root-js-api-expected.txt:
- fast/events/mutation-during-replace-child-2-expected.txt:
- fast/events/mutation-during-replace-child-2.html:
- fast/events/mutation-during-replace-child-expected.txt:
- fast/events/mutation-during-replace-child.html:
- fast/frames/adopt-iframe-into-itself-expected.txt:
- fast/frames/adopt-object-into-itself-expected.txt:
- fast/html/adopt-parent-frame.html:
- fast/inspector-support/uncaught-dom3-exception-expected.txt:
- platform/chromium/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
- platform/chromium/fast/dom/DOMException/prototype-object-expected.txt:
- platform/chromium/fast/dom/DOMException/stack-trace-expected.txt:
- platform/chromium/fast/inspector-support/uncaught-dom3-exception-expected.txt:
- 9:59 AM Changeset in webkit [134434] by
-
- 5 edits3 adds in trunk
Clean up use of adjustWindowRect
https://bugs.webkit.org/show_bug.cgi?id=102072
Reviewed by Alexis Menard.
Source/WebCore:
Tested by fast/dom/Window/open-window-min-size.html
- loader/FrameLoader.cpp:
(WebCore::createWindow):
Validate the window size here so that it is not just done for
.open, but also for .showModalDialog. This is compatible with
other browsers such as IE and Firefox (though IE > 6, enforces
a minimum width of 250 instead of 100 as Firefox and us.)
- page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect):
Make it a static method which only takes page. It was never
called from anywhere without a valid page, so the page check
has been turned into an assert, and two of the arguments have
been removed as they can be accessed via the page.
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
Update use of adjustWindowRect.
(WebCore::DOMWindow::open):
Avoid modifying the WindowFeatures as the WebCore::createWindow
validates and adjusts the arguments.
- page/DOMWindow.h:
(DOMWindow):
LayoutTests:
Test that minimum sizes are honored.
- fast/dom/Window/open-window-min-size.html: Added.
- fast/dom/Window/open-window-min-size-expected.txt: Added.
- fast/dom/Window/resources/print-close.html: Added.
- 9:53 AM Changeset in webkit [134433] by
-
- 17 edits2 moves4 adds4 deletes in trunk
[CSS Exclusions] Update wrap-margin/padding to shape-margin/padding
https://bugs.webkit.org/show_bug.cgi?id=97736
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2012-11-13
Reviewed by Andreas Kling.
Rename properties to match updated spec.
Source/WebCore:
Tests: fast/exclusions/shape-margin-parsing.html
fast/exclusions/shape-padding-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
- css/StylePropertyShorthand.cpp:
(WebCore::webkitWrapShorthand):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
- fast/exclusions/css-exclusions-disabled-expected.txt:
- fast/exclusions/css-exclusions-disabled.html:
- fast/exclusions/script-tests/shape-margin-parsing.js: Added.
(test):
(testComputedStyle):
(testNotInherited):
- fast/exclusions/script-tests/shape-padding-parsing.js: Added.
(test):
(testComputedStyle):
(testNotInherited):
- fast/exclusions/script-tests/wrap-margin-parsing.js: Removed.
- fast/exclusions/script-tests/wrap-padding-parsing.js: Removed.
- fast/exclusions/script-tests/wrap-parsing.js:
(testComputedStyle):
- fast/exclusions/shape-margin-parsing-expected.txt: Added.
- fast/exclusions/shape-margin-parsing.html: Renamed from LayoutTests/fast/exclusions/wrap-padding-parsing.html.
- fast/exclusions/shape-padding-parsing-expected.txt: Added.
- fast/exclusions/shape-padding-parsing.html: Renamed from LayoutTests/fast/exclusions/wrap-margin-parsing.html.
- fast/exclusions/wrap-margin-parsing-expected.txt: Removed.
- fast/exclusions/wrap-padding-parsing-expected.txt: Removed.
- 9:47 AM Changeset in webkit [134432] by
-
- 8 edits4 deletes in trunk
Unreviewed, rolling out r134418.
http://trac.webkit.org/changeset/134418
https://bugs.webkit.org/show_bug.cgi?id=101903
The newly added test is crashing on cr-win.
Source/WebCore:
- dom/ElementShadow.cpp:
- dom/ElementShadow.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::setIndeterminate):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
- html/shadow/SelectRuleFeatureSet.cpp:
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
- html/shadow/SelectRuleFeatureSet.h:
(SelectRuleFeatureSet):
LayoutTests:
- fast/dom/shadow/pseudoclass-update-indeterminate-input-expected.html: Removed.
- fast/dom/shadow/pseudoclass-update-indeterminate-input.html: Removed.
- fast/dom/shadow/pseudoclass-update-indeterminate-progress-expected.html: Removed.
- fast/dom/shadow/pseudoclass-update-indeterminate-progress.html: Removed.
- 9:27 AM Changeset in webkit [134431] by
-
- 2 edits2 deletes in trunk/LayoutTests
[EFL] Properly skip all HiDPI tests which are currently failing.
Skip an additional test and add a bug to each entry.
- platform/efl/TestExpectations:
- platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Removed.
- platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Removed.
- 9:17 AM Changeset in webkit [134430] by
-
- 2 edits in trunk/Source/JavaScriptCore
Uninitialized fields in class JSLock
https://bugs.webkit.org/show_bug.cgi?id=101695
Patch by Cosmin Truta <ctruta@rim.com> on 2012-11-13
Reviewed by Mark Hahnenberg.
Initialize JSLock::m_ownerThread and JSLock::m_lockDropDepth.
- runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
- 9:12 AM Changeset in webkit [134429] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update pixel expectation for fast/repaint/table-hover-on-link.html
- platform/efl/fast/repaint/table-hover-on-link-expected.png:
- 9:09 AM Changeset in webkit [134428] by
-
- 3 edits4 deletes in trunk/LayoutTests
[EFL] More video-colorspace-yuv* gardening.
These tests are also failing on WK2, so skip them in both ports.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk1/media/video-colorspace-yuv420-expected.png: Removed.
- platform/efl-wk1/media/video-colorspace-yuv422-expected.png: Removed.
- platform/efl/TestExpectations:
- platform/efl/media/video-colorspace-yuv420-expected.txt: Removed.
- platform/efl/media/video-colorspace-yuv422-expected.txt: Removed.
- 9:08 AM Changeset in webkit [134427] by
-
- 17 edits in trunk/Source
Unreviewed, rolling out r134391.
http://trac.webkit.org/changeset/134391
https://bugs.webkit.org/show_bug.cgi?id=99660
Speculative rollout, trying to fix browser_tests failure.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/InspectorClient.h:
- inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
Source/WebKit/chromium:
- public/WebView.h:
(WebView):
- src/InspectorClientImpl.cpp:
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 8:53 AM Changeset in webkit [134426] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, update expectations after r134345.
- platform/efl/fast/dynamic/insertAdjacentElement-expected.txt:
- platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt:
- platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
- 8:44 AM Changeset in webkit [134425] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r134205.
http://trac.webkit.org/changeset/134205
https://bugs.webkit.org/show_bug.cgi?id=102093
Broke webkit-flow-inlines-dynamic.html on several ports
(Requested by mihnea on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
Source/WebCore:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::isValidRegionStyleProperty):
- rendering/InlineBox.cpp:
- rendering/InlineBox.h:
(WebCore):
(InlineBox):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
(WebCore::RenderRegion::setObjectStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
- rendering/RenderRegion.h:
(RenderRegion):
(ObjectRegionStyleInfo):
LayoutTests:
- fast/regions/region-style-text-shadow-expected.html: Removed.
- fast/regions/region-style-text-shadow.html: Removed.
- 8:42 AM Changeset in webkit [134424] by
-
- 2 edits in trunk/Tools
[CMake] Incorrect dependency calculation when generating forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=102076
Reviewed by Kenneth Rohde Christiansen.
Explicitly call generate-forwarding-headers.pl on ${WEBKIT2_DIR} as
well, since some dependencies pulled in via the WebKit2/WebKit2_C.h
include in config.h are only generated from there.
This is a bit redundant since this is also done in WebKit2's
PlatformEfl.cmake, however the WTF and WebCore API tests do not depend
on WebKit2 so the script may not have been called when these tests are
being built.
- TestWebKitAPI/PlatformEfl.cmake:
- 8:27 AM WebKit Team edited by
- (diff)
- 8:15 AM Changeset in webkit [134423] by
-
- 2 edits in trunk/LayoutTests
[EFL] WK1 gardening.
Mark media/video-colorspace-yuv420.html and
media/video-colorspace-yuv422.html as producing bad image results.
- platform/efl-wk1/TestExpectations:
- 8:08 AM Changeset in webkit [134422] by
-
- 2 edits in trunk/Source/WebCore
Remove the non-const overload of ElementAttributeData::inlineStyle().
Rubber-stamped by Anders Koivisto.
No call sites actually needed a mutable StylePropertySet* from inlineStyle() anyway.
- dom/ElementAttributeData.h:
- 8:06 AM Changeset in webkit [134421] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Enable input type month/week
https://bugs.webkit.org/show_bug.cgi?id=102042
Reviewed by Kent Tamura.
Enable input type month/week for Chromium.
No new tests. Tests will be added later in Bug 102045 and Bug 102046.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- 7:59 AM Changeset in webkit [134420] by
-
- 6 edits in trunk
[Refactoring] Remove shadowPseudoId() and use setPseudo() in <meter> ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=101906
Reviewed by Dimitri Glazkov.
Source/WebCore:
We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
setPseudo()/pseudo() instead.
No new tests, covered by existing tests.
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didElementStateChange): Since shadowPseudoId() was returning pseudo id without setting
it anywhere, we have to set it into pseudo attribute here.
(WebCore::HTMLMeterElement::createShadowSubtree): ditto.
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterInnerElement::MeterInnerElement):
(WebCore::MeterValueElement::valuePseudoId):
- html/shadow/MeterShadowElement.h:
(MeterInnerElement):
(WebCore::MeterBarElement::MeterBarElement):
(MeterBarElement):
(WebCore::MeterValueElement::MeterValueElement):
(WebCore::MeterValueElement::updatePseudo):
(MeterValueElement):
LayoutTests:
- fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
- 7:56 AM Changeset in webkit [134419] by
-
- 2 edits in trunk/LayoutTests
Expectations update for fast/regions/webkit-flow-inlines-dynamic.html
https://bugs.webkit.org/show_bug.cgi?id=102086
Unreviewed expectations update.
- platform/chromium/TestExpectations:
- 7:55 AM Changeset in webkit [134418] by
-
- 8 edits4 adds in trunk
Changing pseudoClass (:indeterminate) should cause distribution
https://bugs.webkit.org/show_bug.cgi?id=101903
Reviewed by Dimitri Glazkov.
Source/WebCore:
<progress> and <input type="checkbox"> have 'indeterminate' state. When their state is changed, we have to
invalidate distribution if necessary. To check it, we collect a feature that :invalidate is used in select attributes.
For <input>, we also have to see 'type' is changed. According to the spec, :indeterminate should match only
progress element or <input type="checkbox">. So changing 'type' might also change :indeterminate state.
Tests: fast/dom/shadow/pseudoclass-update-indeterminate-input.html
fast/dom/shadow/pseudoclass-update-indeterminate-progress.html
- dom/ElementShadow.cpp:
(WebCore::invalidateParentDistributionIfNecessary): Since we will add a lot of pseudoClass check later, we would like to
have this kind of helper method. We will add various pseudoClass check (see Bug 101697), we reuse CSSSelector::PseudoType
here.
(WebCore):
- dom/ElementShadow.h:
(WebCore):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Invalidate parent distribution anyway, since it changes various internal states.
(WebCore::HTMLInputElement::setIndeterminate): Invalidate parent distribution if necessary.
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
- html/shadow/SelectRuleFeatureSet.cpp:
(WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet): Adds m_usesIndeterminate feature.
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
- html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorForIndeterminate):
(SelectRuleFeatureSet):
LayoutTests:
- fast/dom/shadow/pseudoclass-update-indeterminate-input-expected.html: Added.
- fast/dom/shadow/pseudoclass-update-indeterminate-input.html: Added.
- fast/dom/shadow/pseudoclass-update-indeterminate-progress-expected.html: Added.
- fast/dom/shadow/pseudoclass-update-indeterminate-progress.html: Added.
- 7:39 AM Changeset in webkit [134417] by
-
- 2 edits in trunk/LayoutTests
Reverting expectations update because it breaks lint
https://bugs.webkit.org/show_bug.cgi?id=101982
Unreviewed expectations fix.
With the new-ish wekbit_skia.gyp file we do not need to change expections like this.
- platform/chromium/TestExpectations:
- 7:30 AM Changeset in webkit [134416] by
-
- 33 edits in trunk/LayoutTests
[EFL] Rebaseline after bug 98666 (input[type=range] thumb rendering)
https://bugs.webkit.org/show_bug.cgi?id=102059
Unreviewed rebaseline. There were a few actual bugs (see bug 102068 and
bug 102067).These changes seem correct and the image changes are tiny.
The non-platform results were still wrong because they are not used
by most platforms, even if the results actually match the platform results.
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-13
- fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
- fast/forms/range/slider-thumb-stylability-expected.txt:
- fast/forms/range/range-thumb-height-percentage-expected.txt:
- fast/repaint/slider-thumb-float-expected.txt:
- platform/efl/TestExpectations:
- platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.png:
- platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/efl/fast/forms/box-shadow-override-expected.txt:
- platform/efl/fast/forms/input-appearance-height-expected.txt:
- platform/efl/fast/forms/range/input-appearance-range-expected.png:
- platform/efl/fast/forms/range/input-appearance-range-expected.txt:
- platform/efl/fast/forms/range/slider-padding-expected.txt:
- platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
- platform/efl/fast/layers/video-layer-expected.txt:
- platform/efl/fast/multicol/client-rects-expected.txt:
- platform/efl/fast/repaint/slider-thumb-drag-release-expected.png:
- platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/efl/media/audio-controls-rendering-expected.txt:
- platform/efl/media/audio-repaint-expected.txt:
- platform/efl/media/controls-after-reload-expected.txt:
- platform/efl/media/controls-strict-expected.txt:
- platform/efl/media/controls-styling-expected.txt:
- platform/efl/media/controls-styling-strict-expected.txt:
- platform/efl/media/controls-without-preload-expected.txt:
- platform/efl/media/media-controls-clone-expected.txt:
- platform/efl/media/media-document-audio-repaint-expected.txt:
- platform/efl/media/track/track-cue-rendering-horizontal-expected.txt:
- platform/efl/media/track/track-cue-rendering-vertical-expected.txt:
- platform/efl/media/video-display-toggle-expected.txt:
- platform/efl/media/video-empty-source-expected.txt:
- platform/efl/media/video-no-audio-expected.txt:
- platform/efl/media/video-zoom-controls-expected.txt:
- 7:23 AM Changeset in webkit [134415] by
-
- 8 edits in branches/chromium/1312/Source/WebCore
Merge 133885 - Web Inspector: Add option to disable rulers (Elements panel)
https://bugs.webkit.org/show_bug.cgi?id=101554
Reviewed by Pavel Feldman.
A new setting, showMetricsRulers, has been introduced (off by default, so users need to opt in to see the rulers).
The setting value is passed into InspectorDOMAgent, down to the InspectorOverlayPage, which affects the drawGrid() and
drawRulers() calls. As a side effect, the issue when the rulers were painted for elements having no renderers has been fixed.
No new tests, a UI change.
- English.lproj/localizedStrings.js: Add "Show rulers" string.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject): Copy over the showRulers value.
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForHighlight): Copy over the showRulers value.
- inspector/InspectorOverlay.h:
(HighlightConfig): Add |bool showRulers|.
(WebCore::Highlight::Highlight): Initialize fields.
(Highlight): Add |bool showRulers|.
(WebCore::Highlight::setDataFromConfig):
- inspector/InspectorOverlayPage.html:
- inspector/front-end/DOMAgent.js: Make use of WebInspector.settings.showMetricsRulers when building the highlight DTO.
- inspector/front-end/Settings.js: Add showMetricsRulers.
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab): Add "Show rulers" checkbox in the Elements panel section.
TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/11366221
- 7:15 AM Changeset in webkit [134414] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] TiledBackingStore: WebChromeClient::pageRect() should consider viewport size
https://bugs.webkit.org/show_bug.cgi?id=101946
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-13
Reviewed by Noam Rosenthal.
WebChromeClient::pageRect() should consider viewport size when TILED_BACKING_STORE enabled.
Based on patch by Kenneth Rohde Christiansen.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::pageRect):
- 7:15 AM Changeset in webkit [134413] by
-
- 1 edit in branches/chromium/1312/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
Merge 134093 - MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
https://bugs.webkit.org/show_bug.cgi?id=101586
Reviewed by Adam Barth.
Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when
ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new
API some WebCore objects might be cleaned away which is not allowed at this stage.
This behaviour is not possible to test unfortunately in webkit.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::stop):
TBR=tommyw@google.com
Review URL: https://codereview.chromium.org/11363215
- 7:11 AM Changeset in webkit [134412] by
-
- 2 edits in trunk/Tools
Unreviewed: Adding watchlist definition for CoordinatedGraphics.
- Scripts/webkitpy/common/config/watchlist:
- 7:04 AM Changeset in webkit [134411] by
-
- 2 edits in trunk
FindGLIB.cmake fails do find glib gmodule module.
https://bugs.webkit.org/show_bug.cgi?id=101784
Reviewed by Caio Marcelo de Oliveira Filho.
- Source/cmake/FindGLIB.cmake:
- 6:54 AM Changeset in webkit [134410] by
-
- 2 edits in trunk/Tools
[cmake] Do not use GLOB to add WTR IDL files to buildsystem.
https://bugs.webkit.org/show_bug.cgi?id=101785
Reviewed by Caio Marcelo de Oliveira Filho.
Using *.idl makes impossible to add IDL files depending on compiler flags,
like a possible GamepadController.idl file found on Chromium.
- WebKitTestRunner/CMakeLists.txt:
- 6:49 AM Changeset in webkit [134409] by
-
- 2 edits in trunk/Tools
[chromium] TestRunner should depend on webkit_wtf_support instead of compiling the files itself
https://bugs.webkit.org/show_bug.cgi?id=102075
Reviewed by Pavel Feldman.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 6:21 AM Changeset in webkit [134408] by
-
- 4 edits in trunk/Source/WebCore
Exploit ElementAttributeData sharing in Node.cloneNode.
<http://webkit.org/b/101374>
Reviewed by Anders Carlsson.
Instead of blindly creating a new ElementAttributeData for Node.cloneNode, let's be clever!
If the source data is immutable, simply ref it from the new node at virtually no cost.
If the source data is mutable, convert it to immutable data so it can be shared between both nodes.
Since the typical use-case for Node.cloneNode is to create-once/clone-many, this saves both time
and memory in the long run.
~8% speed-up on PerformanceTests/DOM/CloneNodes on my MBP.
- dom/Element.cpp:
(WebCore::Element::cloneAttributesFromElement):
Move attribute data cloning logic from ElementAttributeData to Element.
- dom/ElementAttributeData.cpp:
(WebCore::ImmutableElementAttributeData::~ImmutableElementAttributeData):
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::makeMutableCopy):
(WebCore::ElementAttributeData::makeImmutableCopy):
- dom/ElementAttributeData.h:
(ElementAttributeData):
(ImmutableElementAttributeData):
(MutableElementAttributeData):
Add facilities for converting a mutable ElementAttributeData to an immutable one.
Share some code in the common base class constructor.
- 6:09 AM Changeset in webkit [134407] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Build fix of V8 bindings.
Patch by Kentaro Hara <haraken@chromium.org> on 2012-11-13
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):
- 6:06 AM Changeset in webkit [134406] by
-
- 2 edits in trunk/Tools
[EFL][DRT] Remove extra layoutFrame() call when preparing to send an event via EventSender.
https://bugs.webkit.org/show_bug.cgi?id=102074
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/efl/EventSender.cpp:
(feedMouseEvent): Do not call DumpRenderTreeSupportEfl::layoutFrame()
when sending an event, as it causes additional repaints that create
wrong pixel results for tests such as
fast/repaint/overflow-auto-in-overflow-auto-scrolled.html.
- 6:05 AM Changeset in webkit [134405] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Canvas] UI: make the Grid save scrolling position, show wait spinner icon
https://bugs.webkit.org/show_bug.cgi?id=102071
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-13
Reviewed by Pavel Feldman.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._createCallNode):
- inspector/front-end/canvasProfiler.css:
(#canvas-replay-image.wait):
- 5:50 AM Changeset in webkit [134404] by
-
- 21 edits1 copy in trunk/Source/WebCore
Web Inspector: Settings screen: some panel shortcuts are missing
https://bugs.webkit.org/show_bug.cgi?id=101026
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.
Panels, that have not been loaded by the time shortcuts view was
initialized, had no chance to register shortcuts.
Solution: move shortcut registration (for shortcuts screen) to panel
descriptors.
More changes: add JsDoc annotations to ShortcutScreen and change "key"
parameter type for raw string to key descriptor object.
- WebCore.gypi: Added TimelinePanelDescriptor.js file.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- inspector/compile-front-end.py: Ditto.
- inspector/front-end/WebKit.qrc: Ditto.
- inspector/front-end/inspector.html: Ditto.
- inspector/front-end/AdvancedSearchController.js: Add JsDoc annotation.
- inspector/front-end/GoToLineDialog.js: Ditto.
- inspector/front-end/CallStackSidebarPane.js: Removed shortcut-screen
shortcuts registration.
- inspector/front-end/ElementsPanel.js: Ditto.
- inspector/front-end/ScriptsPanel.js: Ditto.
- inspector/front-end/StylesSidebarPane.js: Ditto.
- inspector/front-end/TimelinePanel.js: Ditto.
- inspector/front-end/ConsoleView.js: Changes order of lines to increase
readability.
- inspector/front-end/ElementsPanelDescriptor.js: Add shortcut-screen
shortcuts registration and key descriptor constants.
- inspector/front-end/ScriptsPanelDescriptor.js: Ditto.
- inspector/front-end/TimelinePanelDescriptor.js: Ditto.
- inspector/front-end/Panel.js: Removed unused "uregisterShortcut"; made
"registerShortcuts" method accept array of key descriptors.
(WebInspector.PanelDescriptor.prototype.registerShortcuts): Added.
- inspector/front-end/ShortcutsScreen.js: Added JsDoc; changed parameter
type from string to key descriptor.
- inspector/front-end/inspector.js: Register shortcuts using
panel descriptors.
(WebInspector._panelDescriptors): Removed duplicate line.
- 5:44 AM Changeset in webkit [134403] by
-
- 3 edits in trunk/Source/WebCore
Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics
https://bugs.webkit.org/show_bug.cgi?id=102060
Reviewed by Zoltan Herczeg.
Adding more NEONized packing functions to GraphicsContext3DNEON.h.
These functions are three times faster with this intrinsics optimizations.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- platform/graphics/cpu/arm/GraphicsContext3DNEON.h:
(WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON):
(ARM):
(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort5551NEON):
(WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON):
(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort565NEON):
- 5:26 AM Changeset in webkit [134402] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed: temporary disable failing test.
- tests/MemoryInstrumentationTest.cpp:
- 5:20 AM Changeset in webkit [134401] by
-
- 8 edits in trunk
[Qt] Enable Mutation observer
https://bugs.webkit.org/show_bug.cgi?id=102066
Reviewed by Pavel Feldman.
Source/WebCore:
- DerivedSources.pri: Add missing IDL files.
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- platform/qt/TestExpectations: Unskip now passing tests.
- 5:15 AM Changeset in webkit [134400] by
-
- 2 edits in trunk/LayoutTests
update expectations in advance of skia change for blurred rects
https://bugs.webkit.org/show_bug.cgi?id=101982
Reviewed by NOBODY.
Unreviewed. Expectations change only
- platform/chromium/TestExpectations:
- 5:03 AM Changeset in webkit [134399] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip failing tests.
- platform/qt/TestExpectations:
- 4:49 AM Changeset in webkit [134398] by
-
- 2 edits in trunk/Tools
[BlackBerry] DRT - platform/blackberry/editing/text-iterator/findString-markers.html failed
https://bugs.webkit.org/show_bug.cgi?id=102056
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-11-13
Reviewed by Rob Buis.
RIM PR 235836
TestRunner::findString() was changed to call Page::findString() instead
of WebPage::findNextString(). Page::findString() doesn't update
TextMatch markers.
Work-around by calling both Page::findString() and WebPage::findNextString().
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::findString):
- 4:48 AM Changeset in webkit [134397] by
-
- 2 edits6 adds2 deletes in trunk/LayoutTests
Unreviewed Qt gardening.
Skip and rebase some tests, remove png's for reftests.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/css2.1/20110323/margin-collapse-clear-016-expected.png: Added.
- platform/qt-5.0-wk2/css3/filters/custom/custom-filter-composite-source-atop-expected.png: Added.
- platform/qt-5.0-wk2/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
- platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Removed.
- platform/qt-5.0-wk2/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
- platform/qt/svg/animations/animateMotion-additive-2d-expected.png: Removed.
- 3:44 AM Changeset in webkit [134396] by
-
- 3 edits in trunk/Source/WebCore
[V8] Make isValidDOMObject() static
https://bugs.webkit.org/show_bug.cgi?id=101914
Reviewed by Adam Barth.
isValidDOMObject() is used by DOMWrapper.cpp only.
No tests. No change in behavior.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::isValidDOMObject):
(WebCore):
(WebCore::V8DOMWrapper::maybeDOMWrapper):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- 3:39 AM Changeset in webkit [134395] by
-
- 4 edits2 adds in trunk
[CSSRegions] Incorrect computed height for content with region-break-before
https://bugs.webkit.org/show_bug.cgi?id=101862
Reviewed by Julien Chaffraix.
Source/WebCore:
When processing the region breaks for auto-height regions, we skipped the case
when the region-break-before occurred in the first region in the chain which was
an auto-height region. Because of that, the region computed height was not 0
as it was supposed to be, but rather LayoutUnit::max() / 2.
Test: fast/regions/autoheight-breakbefore-wrongheight.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addForcedRegionBreak):
Make sure we process also the case when the region-break occurs at offset 0 in the flow thread
and the first region in chain is an auto-height region.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::updateLogicalHeight):
Add an assert to make sure that the computed height for auto-height regions is always less than LayoutUnit::max() / 2.
LayoutTests:
Add a test showing that when content having -webkit-region-break-before:always is flowed
into a region chain with the first region being an auto-height region, the auto-height region
has a computed height of 0 and the content is flowed into the second region in the chain.
- fast/regions/autoheight-breakbefore-wrongheight-expected.txt: Added.
- fast/regions/autoheight-breakbefore-wrongheight.html: Added.
- 3:31 AM Changeset in webkit [134394] by
-
- 2 edits in trunk/Tools
Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
https://bugs.webkit.org/show_bug.cgi?id=101957
Reviewed by Adam Barth.
Chromium now also depends on the TestRunner public API, and as such, similar rules as for the Chromium WebKit API should apply.
- Scripts/webkitpy/common/config/watchlist:
- 3:21 AM Changeset in webkit [134393] by
-
- 4 edits in trunk/Source/WebCore
Memory instrumentation: remove reportMemoryUsage method from ImageObserver
https://bugs.webkit.org/show_bug.cgi?id=102058
Reviewed by Pavel Feldman.
- bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage): drive-by fix, no need to report
each element of the vector as generic vector instrumentation will take care of it.
- platform/graphics/Image.cpp: the client is reported as weak pointer to make sure
we don't count its by the pointer to the base class which may differ from the actual
object address.
(WebCore::Image::reportMemoryUsage):
- platform/graphics/ImageObserver.h: removed reportMemoryUsage method from the interface.
(ImageObserver):
- 2:53 AM Changeset in webkit [134392] by
-
- 7 edits in trunk/Tools
[chromium] move tracking of damaged regions from WebViewHost to WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=101927
Reviewed by Adam Barth.
This will allow for sharing the code with content_shell
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::display):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::didInvalidateRect):
(WebTestRunner::WebTestProxy::didScrollRect):
(WebTestRunner::WebTestProxy::scheduleComposite):
(WebTestRunner::WebTestProxy::scheduleAnimation):
(WebTestRunner::WebTestProxy::setWindowRect):
(WebTestRunner::WebTestProxy::show):
(WebTestRunner::WebTestProxy::didAutoResize):
(WebTestRunner::WebTestProxy::postAccessibilityNotification):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::setPaintRect):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::paintRect):
(WebTestRunner::WebTestProxyBase::didInvalidateRect):
(WebTestRunner::WebTestProxyBase::didScrollRect):
(WebTestRunner::WebTestProxyBase::scheduleComposite):
(WebTestRunner::WebTestProxyBase::scheduleAnimation):
(WebTestRunner::WebTestProxyBase::show):
(WebTestRunner::WebTestProxyBase::setWindowRect):
(WebTestRunner::WebTestProxyBase::didAutoResize):
(WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::createNewWindow):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::scheduleAnimation):
(WebViewHost::show):
(WebViewHost::setWindowRect):
(WebViewHost::WebViewHost):
(WebViewHost::proxy):
(WebViewHost::setProxy):
(WebViewHost::reset):
(WebViewHost::paintInvalidatedRegion):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 2:25 AM Changeset in webkit [134391] by
-
- 17 edits in trunk/Source
checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660
Patch by Eberhard Graether <egraether@google.com> on 2012-11-13
Reviewed by Pavel Feldman.
Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowFPSCounter):
Source/WebCore:
No new tests.
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowFPSCounter):
(WebCore::InspectorClient::setShowFPSCounter):
(InspectorClient):
- inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowFPSCounter):
(WebCore):
(WebCore::InspectorPageAgent::setShowFPSCounter):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showFPSCounterChanged):
- inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
Source/WebKit/chromium:
- public/WebView.h:
(WebView):
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit):
(WebKit::InspectorClientImpl::setShowFPSCounter):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::loadFontAtlasIfNecessary):
- src/WebViewImpl.h:
(WebViewImpl):
- 2:18 AM Changeset in webkit [134390] by
-
- 7 edits2 adds in trunk
Unable to set valid time value to input[type=time] with user interaction in some cases
https://bugs.webkit.org/show_bug.cgi?id=102048
Reviewed by Kentaro Hara.
Source/WebCore:
The implementations of shouldMillisecondFieldReadOnly,
shouldMinuteFieldReadOnly, and shouldSecondFieldReadOnly were
incorrect. We need to check if a part of the minimum value matches to
the corresponding part of the current value.
Also, we had better check hour field editability.
Test: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldHaveSecondField):
Fix a problem that hh:mm:00.sss didn't create a seconds field.
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add shouldHourFieldReadOnly declaration.
(WebCore::DateTimeEditBuilder::visitField):
Add shouldHourFieldReadOnly check to Hour11/Hour12/Hour23/Hour24/Period fields.
(WebCore::DateTimeEditBuilder::shouldHourFieldReadOnly):
Added. An hour field should be read-only if the step value is a multiple
of a day and the hour part of the minimum value matches to the hour part
of the value.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldReadOnly):
A millisecond field should be read-only if the step value is a multiple
of one second and the millisecond part of the minimum value matches to
the millisecond part of the value.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldReadOnly):
A minute field should be read-only if the step value is a multiple of
one hour and the minute part of the minimum value matches to the minute
part of the value.
(WebCore::DateTimeEditBuilder::shouldSecondFieldReadOnly):
A second field should be read-only if the step value is a multiple of
one minute and the second part of the minimum value matches to the second
part of the value.
- platform/Decimal.cpp:
(WebCore::Decimal::remainder):
Fix a bug in case that the fractional part of quotient is >= 0.5. Also
make this matches to C99, C++11, ECMAScript behavior.
Source/WebKit/chromium:
- tests/DecimalTest.cpp:
(TEST_F): Update and add tests.
2.1 % 3 should be 2.1
10 % -3 should be 1
-10 % -3 should be -1
3.6 % 1.3 should be 1
500 % 1000 should be 500
-500 % 1000 should be -500
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html: Added.
- 2:13 AM Changeset in webkit [134389] by
-
- 7 edits in trunk
Memory instrumentation: MemoryBlock name should not include full path to the block
https://bugs.webkit.org/show_bug.cgi?id=102055
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/InspectorMemoryAgent.cpp: pass only last path component as MemoryBlock name
intead of fully qualified name.
LayoutTests:
Use Image instead of Page.Image as block identifier.
- inspector/profiler/memory-instrumentation-cached-images-expected.txt:
- inspector/profiler/memory-instrumentation-cached-images.html:
- inspector/profiler/memory-instrumentation-canvas-expected.txt:
- inspector/profiler/memory-instrumentation-canvas.html:
- 2:11 AM Changeset in webkit [134388] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed Qt gardening.
Update TestExpectations after r134345.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-11-13
- platform/qt/fast/dynamic/insertAdjacentElement-expected.txt:
- 1:29 AM Changeset in webkit [134387] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: get rid of enter/exitTextChangeMode in the editor
https://bugs.webkit.org/show_bug.cgi?id=101845
Reviewed by Vsevolod Vlasov.
They seem to do nothing.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._textChanged):
(WebInspector.DefaultTextEditor.prototype.editRange):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- 1:15 AM Changeset in webkit [134386] by
-
- 5 edits1 delete in trunk/Source/WebCore
Remove the custom WebSocket::send for both V8 and JSC
https://bugs.webkit.org/show_bug.cgi?id=101936
Reviewed by Kentaro Hara.
This patch removes the custom WebSocket::send since it isn't needed anymore.
Patch covered by existing tests.
- Modules/websockets/WebSocket.idl:
- UseV8.cmake:
- WebCore.gypi:
- bindings/js/JSWebSocketCustom.cpp:
- bindings/v8/custom/V8WebSocketCustom.cpp: Removed.
- 1:08 AM Changeset in webkit [134385] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Qt gardening.
Amend my last commit, Ossy suggested we should not forget about
past failures because of needed rebaseline.
- platform/qt/TestExpectations:
- 12:55 AM Changeset in webkit [134384] by
-
- 3 edits in trunk/LayoutTests
Unreviewed Qt gardening.
Cleanup TestExpectations to pass --lint-test-files.
Removed some duplicated entries.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 12:53 AM Changeset in webkit [134383] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the ARM traditional build after r134332
https://bugs.webkit.org/show_bug.cgi?id=102044
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-11-13
Reviewed by Zoltan Herczeg.
Added missing methods for the MacroAssemblerARM, based on the MacroAssemblerARMv7.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranchPtrWithPatch):
- 12:48 AM Changeset in webkit [134382] by
-
- 5 edits in trunk
Web Inspector: move indentation logic into TextEditorModel
https://bugs.webkit.org/show_bug.cgi?id=101842
Reviewed by Vsevolod Vlasov.
Source/WebCore:
I'd like to move as much headless logic into the TextEditorModel as possible.
Drive by: removed some dead code, converted getter into function and moved undo
mark state into the model as well.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.editRange):
(WebInspector.DefaultTextEditor.prototype._syncDecorationsForLine):
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.isDecorated):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
- inspector/editor/indentation.html:
- 12:42 AM Changeset in webkit [134381] by
-
- 8 edits in trunk/Source/JavaScriptCore
op_get_callee should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=102047
Reviewed by Sam Weinig.
This will allow us to detect if the callee is always the same, which is probably
the common case for a lot of constructors.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 12:39 AM Changeset in webkit [134380] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed attempt to fix the chromium mac-build after r134348.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 12:34 AM Changeset in webkit [134379] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: migrate text editor to mutation observers
https://bugs.webkit.org/show_bug.cgi?id=101841
Reviewed by Vsevolod Vlasov.
Otherwise, we miss notifications on the removed lines.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._wasShown):
(WebInspector.TextEditorMainPanel.prototype._willHide):
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._handleMutations.else.get if):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
- inspector/front-end/externs.js:
(WebKitMutation):
(WebKitMutationObserver.prototype.observe):
(WebKitMutationObserver.prototype.disconnect):
- inspector/front-end/textEditor.css:
(.debug-fadeout):
(@-webkit-keyframes debug-fadeout):
(to):
- 12:33 AM Changeset in webkit [134378] by
-
- 10 edits3 adds in trunk/Source/WebCore
Optimize RGBA4444ToRGBA8 packing/unpacking functions with NEON intrinsics in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=101473
Reviewed by Zoltan Herczeg.
With NEON intrinsics the packing/unpacking functions can be optimized well.
This particular function is about 3 times faster with ARM NEON. On top level tests
the speed up was 1.18x.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- platform/graphics/cpu/arm/GraphicsContext3DNEON.h: Added.
(WebCore):
(ARM):
(WebCore::ARM::unpackOneRowOfRGBA4444ToRGBA8NEON):
(WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort4444NEON):
- 12:23 AM Changeset in webkit [134377] by
-
- 4 edits4 adds in trunk
Crash when replacing parts of text inputs with content: url(...)
https://bugs.webkit.org/show_bug.cgi?id=101133
Reviewed by Kent Tamura.
Source/WebCore:
Disable directly setting content of elements in an input element's
shadow dom tree, because the setting breaks input element's behavior.
Tests: fast/forms/number/number-content-url-crash.html
fast/forms/search/search-content-url-crash.html
- css/html.css:
(input::-webkit-textfield-decoration-container):
Use important to disable overriding an input element's content
property.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attach):
Added ASSERTION. No content should be applied to
input::-webkit-textfield-decoration-container.
LayoutTests:
- fast/forms/number/number-content-url-crash-expected.txt: Added.
- fast/forms/number/number-content-url-crash.html: Added.
- fast/forms/search/search-content-url-crash-expected.txt: Added.
- fast/forms/search/search-content-url-crash.html: Added.
- 12:11 AM Changeset in webkit [134376] by
-
- 4 edits1 add in trunk
Coordinated Graphics: Directly composited animated GIFs only render the first image.
https://bugs.webkit.org/show_bug.cgi?id=102043
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-13
Reviewed by Noam Rosenthal.
.:
Add a test to check that a gif animation can run on a compositing layer.
- ManualTests/animated-gif-on-compositing-layer.html: Added.
Source/WebKit2:
CoordinatedGraphicsLayer::setContentsToImage() checks the pointer to the image,
not nativeImagePtr, so Coordinated Graphics currently draws only the first frame
of gif animations. This patch makes Coordinated Graphics draw gif animations.
In addition, this patch modifies the style of direct image compositing
code to match other parts of CoordinatedGraphicsLayer.
Test: ManualTests/animated-gif-on-compositing-layer.html
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::didChangeImageBacking):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
(WebCore::CoordinatedGraphicsLayer::hasPendingVisibleChanges):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
Nov 12, 2012:
- 11:49 PM Changeset in webkit [134375] by
-
- 16 edits in trunk/Source
[Qt] REGRESSION(134142): overscaled tiles in pixel test results and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101918
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-12
Reviewed by Noam Rosenthal.
Source/WebCore:
Remove TiledBackingStore::rect(), because it is not used anymore.
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
Source/WebKit2:
Currently, CoordinatedBackingStore can keep out-dated contents size, because the
size of CoordinatedBackingStore is set by only LayerTreeRenderer::createTile().
Although the size of GraphicsLayer is changed, LayerTreeRenderer::createTile()
is not called. However, LayerTreeRenderer::createTile() is always called, when
the contents scale of GraphicsLayer is changed.
This patch makes sure that we reset the backing store's size to the
layer size when UpdateTile or RemoveTile are called.
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::setSize):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(CoordinatedBackingStore):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::getBackingStore):
(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):
(WebKit::LayerTreeRenderer::resetBackingStoreSizeToLayerSize):
(WebKit):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::createTile):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:
(WebKit::CoordinatedTile::updateBackBuffer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
(CoordinatedTileClient):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createTile):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 11:37 PM Changeset in webkit [134374] by
-
- 15 edits in trunk/Tools
webkitpy: clean up lint errors, part 1
https://bugs.webkit.org/show_bug.cgi?id=102024
Reviewed by Adam Barth.
This patch cleans up a lot of miscellaneous minor lint errors that
apparently aren't caught by unit tests, and suppresses a few
false positives.
Also, this patch removes the garden-o-matic "rollout" entry point
since it's no longer being used by the frontend (rather than
fix it to not generate lint errors).
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive2.run_command):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.copyfile):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._http_tests):
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.reference_files):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._teardown_performance):
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.TestAndroidPort.init):
(ChromiumPortTestCase.test_default_configuration):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase):
(PortTestCase.test_driver_cmd_line):
(PortTestCase.test_expectations_ordering):
- Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase._check_that_all_ports_are_available):
- Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
- Scripts/webkitpy/tool/commands/gardenomatic.py:
(GardenOMatic.init):
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler.localresult):
- 11:35 PM Changeset in webkit [134373] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/12445176>
WebProcess needs permission to open AppleUpstreamUserClient
Rubber-stamped by Dan Bernstein.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:32 PM Changeset in webkit [134372] by
-
- 5 edits in trunk/Source/WebCore
[V8] We should be able to recover the V8DOMWindowShell more quickly
https://bugs.webkit.org/show_bug.cgi?id=102020
Reviewed by Kentaro Hara.
For isolated worlds, we used to store the V8DOMWindowShell as an
internal field of the inner DOM window. This patch moves the pointer to
an internal field of the v8::Context, which saves us the work of
looking up the inner DOM window.
Unfortunately, we cannot store the V8DOMWindowShell in V8PerContextData
because the V8DOMWindowShell outlives the V8PerContextData. (We destroy
the V8PerContextData when we detach the V8DOMWindowShell from the
frame.)
- bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8DOMWindowShell.h:
(WebCore::V8DOMWindowShell::getEntered):
- bindings/v8/V8PerContextData.h:
- 11:29 PM Changeset in webkit [134371] by
-
- 14 edits in trunk/Tools
webkitpy: clean up lint errors, part 2
https://bugs.webkit.org/show_bug.cgi?id=102029
Reviewed by Adam Barth.
This cleans up the remaining lint errors in webkitpy with four exceptions:
1) we don't lint thirdparty/ autoinstalled code, obviously
2) there's an intentional error in the unit tests for pylint itself
3) the implementation of webkit-patch optimize-expectations has
an error but I think we can and should just remove that command as well.
4) I have not yet linted the test code
- Scripts/webkitpy/common/newstringio.py:
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.find_checkout_root):
(SCM.will.remote_merge_base):
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
(SVN.init):
- Scripts/webkitpy/common/config/contributionareas.py:
(ContributionAreas.names):
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort):
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.force_build):
- Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_posix_threading):
(check_spacing):
- Scripts/webkitpy/style/optparser.py:
(ArgumentParser._create_option_parser):
- Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand.execute):
- Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand):
(AbstractPatchProcessingCommand._process_patch):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
- 11:13 PM Changeset in webkit [134370] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 133569 - Web Inspector: JavaScript web workers debugging crashes
https://bugs.webkit.org/show_bug.cgi?id=101065
Reviewed by Alexander Pavlov.
Source/WebCore:
Clear m_pageInspector when page inspector instance is deleted.
Disable worker inspection when front-end disconnects.
Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify
WorkerMessagingProxy so that it can clear pointer to the channel.
LayoutTests:
Test that inspected page won't crash if inspected worker is terminated when it is paused
on a breakpoint.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11361236
- 10:59 PM Changeset in webkit [134369] by
-
- 2 edits in trunk/Source/WebCore
[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
https://bugs.webkit.org/show_bug.cgi?id=101054
Reviewed by Adam Barth.
I'm investigating a Chromium crash bug:
http://code.google.com/p/chromium/issues/detail?id=155942
I've not yet identified the root cause (because I can't reproduce
the crash), but it looks like we are storing NULL pointers to
V8 internal fields. Just in case, we can add an ASSERT() to
guarantee that NULL pointers are never stored. (Also I'm hoping
that this ASSERT() will give me more debug information.)
No tests. No change in behavior.
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):
- 10:55 PM Changeset in webkit [134368] by
-
- 2 edits in trunk
[EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries
https://bugs.webkit.org/show_bug.cgi?id=101762
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
In case of EFL, add ENABLE_WERROR to EXTRA_COMPILER_FLAGS for WEBKIT and WEBKIT2
- Source/CMakeLists.txt:
- 10:50 PM Changeset in webkit [134367] by
-
- 4 edits14 adds in trunk
Changing id, className, or attribute should invalidate distribution
https://bugs.webkit.org/show_bug.cgi?id=100738
Reviewed by Dimitri Glazkov.
PerformanceTests:
Added test code to modify id/class/attribute.
- DOM/ModifyAttribute.html: Added.
- DOM/resources/dom-perf/modify-attribute.js: Added.
(ModifyAttribute.CreateElementToSetUp):
(ModifyAttribute.ModifyId):
(ModifyAttribute.ModifyClass):
(ModifyAttribute.ModifyTitle):
Source/WebCore:
When id, className, or attribute is changed, we might have to invalidate distribution.
However, we don't want to do useless invalidation. So we consult with the RuleFeatureSet of ElementShadow,
and invalidate distribution only if necessary.
When className is changed, we can share a lot of code between invalidating distribution and invalidating style.
So we made checkNeedsStyleInvalidationForClassChange a template method, and share it.
Also we've measured how this patch makes changing attribute slow. By converting checkNeedsStyleInvalidationForClassChange
to template, actually this improves the performance of changing attribute code. I've measured each code 3 times.
DOM/ModifyAttribute.html
Before this patch:
median stdev min max [ms]
1st 115.62 0.67 114.75 117.00
2nd 115.08 1.13 113.25 117.58
3rd 114.75 1.16 113.42 117.83
After this patch:
median stdev min max [ms]
1st 102.55 0.95 101.25 104.50
2nd 103.10 0.86 102.20 100.95
3rd 103.30 1.05 102.10 106.65
Tests: fast/dom/shadow/distribution-attribute-modified.html
fast/dom/shadow/distribution-className-modified.html
fast/dom/shadow/distribution-id-modified.html
fast/dom/shadow/reprojection-attribute-modified.html
fast/dom/shadow/reprojection-className-modified.html
fast/dom/shadow/reprojection-id-modified.html
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::HasSelectorForClassStyleFunctor::HasSelectorForClassStyleFunctor):
(HasSelectorForClassStyleFunctor):
(WebCore::HasSelectorForClassStyleFunctor::operator()): Returns true if StyleResolver::hasSelectorForClass returns true.
(WebCore):
(WebCore::HasSelectorForClassDistributionFunctor::HasSelectorForClassDistributionFunctor):
(HasSelectorForClassDistributionFunctor):
(WebCore::HasSelectorForClassDistributionFunctor::operator()): Returns true if ElementShadow::hasSelectorForClass returns true.
(WebCore::checkFunctorForClassChange):
(WebCore::checkNeedsStyleInvalidationForClassChange): Extacted the implementation to checkFunctorForClassChange.
(WebCore::checkNeedsDistributionInvalidationForClassChange):
(WebCore::Element::classAttributeChanged):
LayoutTests:
We have test cases that id/class/attribute is changed, and thier reprojection cases.
- fast/dom/shadow/distribution-attribute-modified-expected.html: Added.
- fast/dom/shadow/distribution-attribute-modified.html: Added.
- fast/dom/shadow/distribution-className-modified-expected.html: Added.
- fast/dom/shadow/distribution-className-modified.html: Added.
- fast/dom/shadow/distribution-id-modified-expected.html: Added.
- fast/dom/shadow/distribution-id-modified.html: Added.
- fast/dom/shadow/reprojection-attribute-modified-expected.html: Added.
- fast/dom/shadow/reprojection-attribute-modified.html: Added.
- fast/dom/shadow/reprojection-className-modified-expected.html: Added.
- fast/dom/shadow/reprojection-className-modified.html: Added.
- fast/dom/shadow/reprojection-id-modified-expected.html: Added.
- fast/dom/shadow/reprojection-id-modified.html: Added.
- 10:36 PM Changeset in webkit [134366] by
-
- 8 edits in branches/chromium/1312/Source
Merge 133429 - Shadow DOM should be able to be disabled per context.
https://bugs.webkit.org/show_bug.cgi?id=101173
Reviewed by Dimitri Glazkov.
Source/WebCore:
This change pulls back relevant bits from r131549. Note that if
the the port enables runtime Shadow DOM flag, this can cause slow
down on some Chromium page cycler test cases (which r131549
attempted to fix).
This change is temporal and the flags should be switched back from
ContextFeatures to RuntimeEnabledFeatures once it gains sufficent
stability.
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore):
- dom/ContextFeatures.h:
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection):
- html/HTMLTagNames.in:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::contentTagName):
- page/DOMWindow.idl:
Source/WebKit/chromium:
- src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
TBR=morrita@google.com
Review URL: https://codereview.chromium.org/11410062
- 10:36 PM Changeset in webkit [134365] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be uninitialized
https://bugs.webkit.org/show_bug.cgi?id=102038
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
To fix build warning -Wuninitialized,
initialize the 'slicer' in ewk_tiled_backing_store_pre_render_region.
- ewk/ewk_tiled_backing_store.cpp:
(ewk_tiled_backing_store_pre_render_region):
- 10:28 PM Changeset in webkit [134364] by
-
- 4 edits1 add in trunk
[BlackBerry] NetworkJob should not check if data is received with HEAD
https://bugs.webkit.org/show_bug.cgi?id=102034
Patch by Joe Mason <jmason@rim.com> on 2012-11-12
Reviewed by George Staikos.
Internal PR: 241391
.:
Add test that HEAD XMLHttpRequests return status 404 instead of calling onerror.
- ManualTests/blackberry/head-xhr-nonexistant-file.html: Added.
Source/WebCore:
Make HEAD requests call didFinish instead of didFail on a 404 response, even though they
have no data.
Tests: ManualTests/blackberry/head-xhr-nonexistant-file.html
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::shouldNotifyClientFailed):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- 10:12 PM Changeset in webkit [134363] by
-
- 2 edits1 delete in trunk/Tools
remove 'webkit-patch optimize-expectations'
https://bugs.webkit.org/show_bug.cgi?id=102032
Reviewed by Adam Barth.
Removing this command because it is totally broken (probably
broke when I added support for multiple files in a cascade)
and doesn't seem to do anything much useful. It certainly
didn't actually optimize things.
- Scripts/webkitpy/tool/commands/expectations.py: Removed.
- 10:08 PM Changeset in webkit [134362] by
-
- 2 edits2 copies in branches/chromium/1312
Merge 133030 - Web Inspector: page crash when pausing in dedicated worker
https://bugs.webkit.org/show_bug.cgi?id=100837
Reviewed by Pavel Feldman.
Source/WebCore:
Pass debugger agent to InjectedScriptHost::init in case of workers.
Test: inspector-protocol/debugger-pause-dedicated-worker.html
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
LayoutTests:
Test that Debugger.pause works for dedicated workers. The test is skipped
on all platforms that use JSC as worker debugging is not supported there
yet.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(WebInspector.dispatchMessageFromBackend):
- inspector-protocol/debugger-pause-dedicated-worker-expected.txt: Added.
- inspector-protocol/debugger-pause-dedicated-worker.html: Added.
- inspector-protocol/resources/dedicated-worker.js: Added.
(onmessage):
(doWork):
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11275274
- 10:04 PM Changeset in webkit [134361] by
-
- 13 edits in trunk/Source/JavaScriptCore
The act of getting the callee during 'this' construction should be explicit in bytecode
https://bugs.webkit.org/show_bug.cgi?id=102016
Reviewed by Michael Saboff.
This is mostly a rollout of http://trac.webkit.org/changeset/116673, but also includes
changes to have create_this use the result of get_callee.
No performance or behavioral impact. This is just meant to allow us to profile
get_callee in the future.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
(JIT):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC):
(JSC::JIT::emit_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC):
(JSC::JIT::emit_op_create_this):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 10:04 PM Changeset in webkit [134360] by
-
- 19 edits in trunk/Source/WebCore
[V8] V8DOMWrapper::instantiateV8Object shouldn't use deprecatedDocument
https://bugs.webkit.org/show_bug.cgi?id=102015
Reviewed by Kentaro Hara.
Previously, Nodes had a special path through
V8DOMWrapper::instantiateV8Object using deprecatedDocument so that we
could find the V8PerContextData quickly. Now that we can get the
V8PerContextData from the v8::Context quickly, we can move Nodes to the
general case. The net consequence is that creation of all DOM objects
should be as fast as Nodes are.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- 9:53 PM Changeset in webkit [134359] by
-
- 2 edits in trunk/Tools
[BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
https://bugs.webkit.org/show_bug.cgi?id=101894
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 241686
Also remove an un-needed pixel lock, and fix a klocwork error in SKIA
code path.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(readPixelsUserInterfaceThread):
(createBitmapContextFromWebView):
- 9:51 PM Changeset in webkit [134358] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix ARMv7 build.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToPatchableBranchPtrWithPatch):
- 9:32 PM Changeset in webkit [134357] by
-
- 2 edits in trunk/Source/WebCore
Some CSS properties are not handled on StyleResolver::applyProperty
https://bugs.webkit.org/show_bug.cgi?id=102027
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
The CSSPropertyMaxZoom, CSSPropertyMinZoom, CSSPropertyOrientation and CSSPropertyUserZoom
need to be handled on StyleResolver::applyProperty.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 9:24 PM Changeset in webkit [134356] by
-
- 4 edits in trunk/Source/WebCore
Avoid calling calculateLayerBounds() and convertToLayerCoords() more than once per layer paint
https://bugs.webkit.org/show_bug.cgi?id=102031
Reviewed by Beth Dakin.
RenderLayer::paintLayerContents() and callees could end up calling convertToLayerCoords()
and calculateLayerBounds() multiple times for painting a single layer.
Keep track of whether we've computed the root-relative bounds and do it on demand.
Compute the offset relative to rootLayer once, and pass it around as an optional parameter
to functions that need it.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::boundingBox):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
- 9:24 PM Changeset in webkit [134355] by
-
- 4 edits in trunk/Source/WebCore
Change calculateLayerBounds() from a static function to a member function
https://bugs.webkit.org/show_bug.cgi?id=102022
Reviewed by Beth Dakin.
calculateLayerBounds() has grown into a substantial function after
starting live as a little utility function, so make it a member function
of RenderLayer, and adjust callers accordingly.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
- 8:58 PM Changeset in webkit [134354] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Add an option to switch display of "Other" memory on/off in NMI
https://bugs.webkit.org/show_bug.cgi?id=101601
Patch by Alexei Filippov <alph@chromium.org> on 2012-11-12
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- 8:55 PM Changeset in webkit [134353] by
-
- 4 edits in trunk/Source
Build fix after r134346 and 134347.
Use frameView.isFlipped, not frameView.flipped in the assertion.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]):
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow):
- 8:51 PM Changeset in webkit [134352] by
-
- 6 edits2 adds in trunk
BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with themselves
https://bugs.webkit.org/show_bug.cgi?id=101854
Reviewed by Andreas Kling.
Source/WebCore:
The basic shapes BasicShapeCircle, BasicShapeEllipse and BasicShapeRectangle should
blend with themselves. This patch introduces simple interpolation of BasicShapes for
the -webkit-clip-path property.
Test: css3/masking/clip-path-animation.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Added a new function that blends between two BasicShape objects.
It skips blending on <clipPath> references, polygons and if the shapes are not of
the same type.
(WebCore):
(PropertyWrapperClipPath): Added new wrapper for ClipPathShapes.
(WebCore::PropertyWrapperClipPath::PropertyWrapperClipPath): Ditto.
(WebCore::CSSPropertyAnimation::ensurePropertyMap): Add -webkit-clip-path to animatable
properties.
- rendering/style/BasicShapes.cpp:
The blending is done by each shape itself. This is similar to FilterOperations or
TransformOperations.
(WebCore::BasicShapeRectangle::blend):
(WebCore):
(WebCore::BasicShapeCircle::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
- rendering/style/BasicShapes.h:
Added new blending functions to header.
(BasicShape):
(BasicShapeRectangle):
(BasicShapeCircle):
(BasicShapeEllipse):
(BasicShapePolygon):
LayoutTests:
Added an animtation test for -webkit-clip-path and tested the basic shapes.
- animations/resources/animation-test-helpers.js:
(parseBasicShape):
(basicShapeParametersMatch):
(getPropertyValue):
(comparePropertyValue):
- css3/masking/clip-path-animation-expected.txt: Added.
- css3/masking/clip-path-animation.html: Added.
- 8:46 PM Changeset in webkit [134351] by
-
- 4 edits in trunk/Source/WebCore
[V8] We should be able to get V8PerContextData from a v8::Context more quickly
https://bugs.webkit.org/show_bug.cgi?id=102008
Reviewed by Ojan Vafai.
This patch uses the new v8::Context::GetAlignedPointerFromEmbedderData
API to get the V8PerContextData associated with a v8::Context much more
quickly. We no longer need to use a hidden property on the inner global
object. This patch will enable future optimizations.
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):
- bindings/v8/V8PerContextData.h:
(WebCore::V8PerContextData::from):
- 8:44 PM Changeset in webkit [134350] by
-
- 4 edits in trunk/Source/WebCore
Make Frames and HTMLFrameOwnerElement less friendly
https://bugs.webkit.org/show_bug.cgi?id=102003
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-12
Reviewed by Ojan Vafai.
Frame used to assign HTMLFrameOwnerElement's m_contentFrame directly
this patch makes it go through a method to allow future hooks when frames
are associated with owners.
No new tests, this is just a refactor.
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::setContentFrame):
- html/HTMLFrameOwnerElement.h:
(HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::clearContentFrame):
- page/Frame.cpp:
(WebCore::Frame::Frame): Use new methods.
- 8:40 PM Changeset in webkit [134349] by
-
- 3 edits in trunk/WebKitLibraries
Build fix. Forgot these bits last time.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 8:26 PM Changeset in webkit [134348] by
-
- 9 edits in trunk
Zoomed-in scrolling is very slow when deviceScaleFactor > 1
https://bugs.webkit.org/show_bug.cgi?id=101787
Reviewed by Simon Fraser.
Source/WebCore:
This patch adds a new member to the GraphicsContextState that tracks
whether or not fonts should be subpixel-quantized. We want to default
to sibpixel-quantizing, but we'll turn it off if we're scrolling
content that cannot be scrolled on the scrolling thread.
State has a new bool shouldSubpixelQuantizeFonts. It defaults to true
since normally we do want to quantize.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setShouldSubpixelQuantizeFonts):
(WebCore::GraphicsContext::shouldSubpixelQuantizeFonts):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):
wkSetCGFontRenderingMode now takes a BOOL parameter which indicates
whether or not it should try to subpixel-quantize the fonts.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Disable subpixel-quantization for overflow areas, subframes, and
content that is scrolling on the main thread.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
WebKitLibraries:
wkSetCGFontRenderingMode now takes a BOOL parameter.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 8:05 PM Changeset in webkit [134347] by
-
- 5 edits1 add in trunk/Source/WebKit
Add a dock button to the top right corner of the Web Inspector window (similar to the full screen button).
https://bugs.webkit.org/show_bug.cgi?id=102025
Reviewed by Joseph Pecoraro.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Added Dock.pdf.
Source/WebKit/mac:
- Resources/Dock.pdf: Added.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindow _cursorForResizeDirection:]): Added.
(WebInspectorClient::didResizeMainFrame): Call attachAvailabilityChanged instead.
(WebInspectorFrontendClient::attachAvailabilityChanged): Added.
(-[WebInspectorWindowController window]): Create the dock button and add it.
(-[WebInspectorWindowController attachWindow:]): Added.
(-[WebInspectorWindowController attach]): Call setAttachedWindow.
(-[WebInspectorWindowController detach]): Ditto.
(-[WebInspectorWindowController setDockingUnavailable:]): Added. Update hidden state of the dock button.
- 8:05 PM Changeset in webkit [134346] by
-
- 15 edits2 adds in trunk/Source
Add a dock button to the top right corner of the Web Inspector window (similar to the full screen button).
Source/WebCore: Expose InspectorFrontendClientLocal::setAttachedWindow as public.
This allows external actions to update the docked state in the frontend.
https://bugs.webkit.org/show_bug.cgi?id=102023
Reviewed by Anders Carlsson.
- inspector/InspectorFrontendClientLocal.h:
Moved InspectorFrontendClientLocal::setAttachedWindow to public section.
Source/WebKit2: Add a dock button to the top right corner of the Web Inspector window (similar to the full screen button).
https://bugs.webkit.org/show_bug.cgi?id=102023
Reviewed by Anders Carlsson.
- Resources/Dock.pdf: Added.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Set the SetAttachedWindow message.
(WebKit::WebInspectorProxy::detach): Ditto.
(WebKit::WebInspectorProxy::attachAvailabilityChanged): Added. Call platformAttachAvailabilityChanged.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Added AttachAvailabilityChanged message.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter attach:]): Added. Call WebInspectorProxy::attach.
(-[WKWebInspectorWindow _cursorForResizeDirection:]): Added.
(WebKit::WebInspectorProxy::createInspectorWindow): Create the dock button and add it.
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Added. Update hidden state of the dock button.
- WebKit2.xcodeproj/project.pbxproj: Added Dock.pdf.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::setAttachedWindow): Added. Call through to the frontend client.
(WebKit::WebInspector::updateDockingAvailability): Send AttachAvailabilityChanged message.
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in: Added SetAttachedWindow message.
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Added stub.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Ditto.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Ditto.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Ditto.
- 8:03 PM Changeset in webkit [134345] by
-
- 53 edits in trunk
Replace DOMException TYPE_MISMATCH_ERR with TypeError
https://bugs.webkit.org/show_bug.cgi?id=101604
Reviewed by Adam Barth.
Source/WebCore:
DOMException.TYPE_MISMATCH_ERR is deprecated in favor of using TypeError.
We have historically used TYPE_MISMATCH_ERR as a blanket DOMException code when
the spec mandates TypeError being thrown.
Updated existing tests.
- Modules/mediastream/MediaConstraintsImpl.cpp:
- Modules/mediastream/MediaStreamTrackList.cpp:
- Modules/mediastream/PeerConnection00.cpp:
- Modules/mediastream/RTCDataChannel.cpp:
- Modules/mediastream/RTCIceCandidate.cpp:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/mediastream/RTCSessionDescription.cpp:
- Modules/mediastream/SessionDescription.cpp:
- bindings/js/CallbackFunction.cpp:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- bindings/js/JSHTMLSelectElementCustom.cpp:
- bindings/js/JSMutationObserverCustom.cpp:
- bindings/js/JSSQLResultSetRowListCustom.cpp:
- bindings/js/JSSQLTransactionCustom.cpp:
- bindings/js/JSSQLTransactionSyncCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Callback.h:
- bindings/v8/V8Collection.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8MutationObserverCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
- dom/DOMCoreException.idl:
- html/HTMLElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLOptionsCollection.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- page/Crypto.cpp:
- page/DOMSelection.cpp:
- svg/properties/SVGTransformListPropertyTearOff.h:
LayoutTests:
Update the tests to test for TypeError instead of DOMException with the TYPE_MISMATCH_ERR code.
- canvas/philip/tests/2d.drawImage.null.html:
- canvas/philip/tests/2d.imageData.put.null.html:
- canvas/philip/tests/2d.pattern.image.null.html:
- editing/selection/extend-expected.txt:
- fast/dom/Geolocation/argument-types-expected.txt:
- fast/dom/Geolocation/not-enough-arguments-expected.txt:
- fast/dom/Geolocation/script-tests/argument-types.js:
- fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
- fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
- fast/js/select-options-add-expected.txt:
- fast/mediastream/RTCIceCandidate-expected.txt:
- fast/mediastream/RTCPeerConnection-expected.txt:
- fast/mediastream/RTCSessionDescription-expected.txt:
- fast/mediastream/SessionDescription-expected.txt:
- fast/mediastream/peerconnection-addstream-expected.txt:
- fast/mediastream/peerconnection-iceoptions-expected.txt:
- fast/mediastream/peerconnection-iceoptions.html:
- fast/mediastream/peerconnection-removestream-expected.txt:
- media/encrypted-media/encrypted-media-syntax.html:
- media/video-test.js:
- platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
- security/crypto-random-values-types-expected.txt:
- svg/dom/SVGTransformList-expected.txt:
- 8:01 PM Changeset in webkit [134344] by
-
- 2 edits in trunk/Tools
Perl errors from Tools/Scripts/copy-webkitlibraries-to-product-directory
https://bugs.webkit.org/show_bug.cgi?id=101980
Reviewed by Mark Rowe.
Remove library libWebKitSystemInterfaceLeopard.a and libWebKitSystemInterfaceSnowLeopard.a
from the list of libraries to copy to the specified built products directory
as these libraries were removed from the repository in <http://trac.webkit.org/changeset/133670>.
- Scripts/copy-webkitlibraries-to-product-directory:
- 7:38 PM Changeset in webkit [134343] by
-
- 3 edits in trunk/LayoutTests
IndexedDB: storage/indexeddb/cursor-prev-no-duplicate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101990
Reviewed by Tony Chang.
Race condition in test leads to flaky behavior. Refactor test to remove flake
and clean up output.
- storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
- storage/indexeddb/resources/cursor-prev-no-duplicate.js:
(testFarRangeCursor_closed):
(.trans.oncomplete):
(.storeReq.onsuccess):
(runTest):
- 7:09 PM Changeset in webkit [134342] by
-
- 7 edits in trunk/Source/WebCore
IndexedDB: Use sequence<> instead of DOMString[] in IDL
https://bugs.webkit.org/show_bug.cgi?id=100539
Reviewed by Adam Barth.
In the binding layer, DOMString[] is implemented as an alias for DOMStringList.
WebIDL usage is tending towards sequence<DOMString> anyway for inputs, so switch
to that. Note webkit.org/b/100537 which requires sequence<String> instead.
Covered by storage/indexeddb/transaction-basics.html and objectstore-basics.html
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction): DOMStringList -> Vector<String>
- Modules/indexeddb/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
(IDBDatabase):
- Modules/indexeddb/IDBDatabase.idl: DOMString[] -> sequence<String>
- Modules/indexeddb/IDBObjectStore.cpp: Move trivial impls to header.
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::createIndex):
- Modules/indexeddb/IDBObjectStore.idl: DOMString[] -> sequence<String>
- 6:48 PM Changeset in webkit [134341] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
Rebase after r134287.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
- 6:48 PM Changeset in webkit [134340] by
-
- 3 edits in trunk/Source/WebCore
Remove Leopard only gradient code
https://bugs.webkit.org/show_bug.cgi?id=102033
Reviewed by Dan Bernstein.
USE_CG_SHADING was only ever true on Leopard, so we can remove it now.
- platform/graphics/Gradient.h:
- platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::platformGradient):
(WebCore::Gradient::paint):
- 6:47 PM Changeset in webkit [134339] by
-
- 4 edits in trunk/Source/WebKit/gtk
Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378
Patch by Josh Rickmar <jrick@devio.us> on 2012-11-12
Reviewed by Martin Robinson.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 6:28 PM Changeset in webkit [134338] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 237003
Internally Reviewed by Eli Fidler.
Since we nolonger use small font for form controls, adjust paddingDivisor
ratio to decrease the padding value.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
- 6:22 PM Changeset in webkit [134337] by
-
- 2 edits in branches/chromium/1312/Source/WebKit/chromium
Merge 134009 - WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
https://bugs.webkit.org/show_bug.cgi?id=93800
Reviewed by Kent Tamura.
We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close): Set m_closing to true.
TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11312201
- 6:10 PM Changeset in webkit [134336] by
-
- 6 edits in trunk/Source/WebKit2
Include child layers in the remote layer tree transaction
https://bugs.webkit.org/show_bug.cgi?id=102026
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode child layer IDs.
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
Grab all child layer IDs and stick them in a vector.
(WebKit::dumpChangedLayers):
Dump child layer IDs as well.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::setChildren):
(WebKit::RemoteGraphicsLayer::addChild):
(WebKit::RemoteGraphicsLayer::addChildAtIndex):
(WebKit::RemoteGraphicsLayer::addChildAbove):
(WebKit::RemoteGraphicsLayer::addChildBelow):
(WebKit::RemoteGraphicsLayer::replaceChild):
Call noteSublayersChanged.
(WebKit::RemoteGraphicsLayer::noteSublayersChanged):
Note that the Children property changed.
- 6:09 PM Changeset in webkit [134335] by
-
- 9 edits in trunk/LayoutTests
IndexedDB: Convert some non-simple tests from setVersion to upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=101959
Reviewed by Tony Chang.
Ongoing work to remove calls to setVersion from our tests before
removing it from the IndexedDB API.
- storage/indexeddb/create-and-remove-object-store-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/resources/create-and-remove-object-store.js: Create and delete were running between open and setVersion, which no longer makes sense.
- storage/indexeddb/resources/database-deletepending-flag.js: Use optional object parameter instead of optional version parameter.
- storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js: This used to call delete just after issuing setVersion but before receiving the corresponding success event. Now it calls delete while in the upgradeneeded transaction, still causing the delete to be delayed by an in flight versionchange transaction.
- storage/indexeddb/resources/duplicates.js: Call indexedDBTest twice to rerun the tests with a different database.
- storage/indexeddb/resources/shared.js: Added a suffix option to support duplicates.js, switched to an optional object parameter.
- 6:09 PM Changeset in webkit [134334] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix windowRect calculation for webplugin due to page scale factors
https://bugs.webkit.org/show_bug.cgi?id=100182
Patch by Min Qin <qinmin@chromium.org> on 2012-11-12
Reviewed by Adam Barth.
The current calculaton of windowRect in WebPluginContainerImpl is wrong. Even after some of our latest changes.
The problem is caused by page scale factor.
For example, windowToContents(IntPoint) will return an unscaled offset for an iframe, but will return a scaled offset for the main frame. So in order to obtain the correct window coordinate, we need to use contentsToWindow().
Since webview_plugin.cc is expecting window coordinates, we need to use contentsToWindow(IntRect) to calculate the windowRect so that the rect size can get correctly scaled.
It is difficult to write a test for this because it's pixel-based, and plugin placeholder is managed on the Chromium side (webview_plugin.cc).
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
- 6:01 PM Changeset in webkit [134333] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Ensure we only receive one KeyUp per key event
https://bugs.webkit.org/show_bug.cgi?id=101967
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-12
Reviewed by Rob Buis.
We are creating synthetic KeyUps too often, and get into trouble since IMF will send up a KeyUp on all key events.
Furthermore, these KeyUps can arrive both when we are composing and not. To bypass this check, we are storing the KeyDown
character and comparing against it on KeyUp.
Internally reviewed by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::insertText):
(BlackBerry::WebKit::InputHandler::setText):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 5:55 PM Changeset in webkit [134332] by
-
- 8 edits in trunk/Source/JavaScriptCore
Patching of jumps to stubs should use jump replacement rather than branch destination overwrite
https://bugs.webkit.org/show_bug.cgi?id=101909
Reviewed by Geoffrey Garen.
This saves a few instructions in inline cases, on those architectures where it is
easy to figure out where to put the jump replacement. Sub-1% speed-up across the
board.
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::canJumpReplacePatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerX86::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::startOfPatchableBranchPtrWithPatch):
(JSC::MacroAssemblerX86_64::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatch):
(RepatchBuffer):
(JSC::RepatchBuffer::replaceWithJump):
(JSC::RepatchBuffer::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::revertJumpTo_movq_i64r):
(JSC::X86Assembler::revertJumpTo_cmpl_im_force32):
(X86InstructionFormatter):
- bytecode/StructureStubInfo.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::replaceWithJump):
(DFG):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- 5:26 PM Changeset in webkit [134331] by
-
- 7 edits in trunk/Source/WebKit2
Send along the current remote layer tree transaction with the commit message
https://bugs.webkit.org/show_bug.cgi?id=102014
Reviewed by Tim Horton.
Add encode and decode member functions to RemoteLayerTreeTransaction and RemoteLayerTreeTransaction::LayerProperties.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::flushLayers):
- 5:13 PM Changeset in webkit [134330] by
-
- 2 edits in trunk/Source/WebCore
Fix filter dirty rect regression from r134311
https://bugs.webkit.org/show_bug.cgi?id=102002
Reviewed by Beth Dakin.
When rendering with filters, the code can inflate the root-relative
paintDirtyRect in RenderLayer::paintLayerContents(), and my cleanup
broke this behavior.
Fix by making a local copy of LayerPaintingInfo, updating its paintDirtyRect,
and using it for the rest of the function.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
- 5:04 PM Changeset in webkit [134329] by
-
- 2 edits in trunk/Source/WebCore
[V8] V8Event::valueAccessorGetter() in custom binding is not used
https://bugs.webkit.org/show_bug.cgi?id=101893
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/custom/V8EventCustom.cpp:
- 5:03 PM Changeset in webkit [134328] by
-
- 7 edits in trunk/Source/WebKit2
Get rid of the CrossOriginRedirectReceived message to the NetworkProcess.
https://bugs.webkit.org/show_bug.cgi?id=102010
Reviewed by Alexey Proskuryakov.
This message was a stop-gap measure for when the NetworkProcess did scheduling but not loading.
Now that the NetworkProcess does loading it doesn't need to be told when redirect is received.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in: Get rid of the message to the NetworkProcess.
- NetworkProcess/NetworkRequest.cpp:
(WebKit::NetworkRequest::willSendRequest): After willSendRequest is dispatched to the WebProcess, directly call
"receivedRedirect" on the NetworkResourceLoadScheduler.
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::receivedRedirect): Renamed from crossOriginRedirectReceived, as the
function already checks to see if the redirect was actually cross-origin.
- NetworkProcess/NetworkResourceLoadScheduler.h:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::crossOriginRedirectReceived): A no-op so the WebProcess doesn't
do any host record accounting of its own.
- 4:36 PM Changeset in webkit [134327] by
-
- 4 edits in trunk/Source
Web Inspector: Fix docking behavior on Windows.
https://bugs.webkit.org/show_bug.cgi?id=101978
Reviewed by Brian Weinstein.
There are a number of problems with docking behaviour on Windows.
For starters, it does not ever constrain the inspector's size properly while docked.
It also does not properly set the whether or not the inspector can be docked/undocked.
This patch fixes both issues.
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
Switch order of calling bringToFront and setDockingUnavailable.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::attachWindow):
Call restoreAttachedWindowHeight so that when first loading or reattaching the inspector,
we resize the inspector window properly.
- 4:25 PM Changeset in webkit [134326] by
-
- 7 edits in trunk/Source/WebKit2
PDFPlugin should use PDFKit's context menu instead of the default WebKit one
https://bugs.webkit.org/show_bug.cgi?id=101896
<rdar://problem/12555173>
Reviewed by Anders Carlsson.
Show the context menu that PDFKit vends us instead of the default WebKit one
when PDFPlugin is told to show a context menu.
Also, react to the didChangeContentScaleFactor callback, so that when the context
menu (or HUD) is used to change the scale factor, we can inform PluginView.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Add pdfLayerController:didChangeContentScaleFactor: delegate callback.
Rename tileScaleFactor to contentScaleFactor.
Add rightMouseDown: and menuForEvent: on PDFLayerController.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin):
Add notifyContentScaleFactorChanged, handleContextMenuEvent, and nsEventForWebMouseEvent.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeContentScaleFactor:]): Forward content scale factor changes to PDFPlugin.
(WebKit::PDFPlugin::pdfDocumentDidLoad): Rename tileScaleFactor to contentScaleFactor.
(WebKit::PDFPlugin::geometryDidChange): Rename tileScaleFactor to contentScaleFactor.
(WebKit::eventTypeFromWebEvent): It turns out we can infer whether the mouse is being dragged during a MouseMove event
by whether it has a mouse button associated with it or not, so we don't need to track this state manually.
(WebKit::PDFPlugin::nsEventForWebMouseEvent): Factor the part of handleMouseEvent that creates NSEvents* out into its own function.
(WebKit::PDFPlugin::handleMouseEvent):
Don't track mouseButtonIsDown manually, make use of the new nsEventForWebMouseEvent.
Hand rightMouseDown: to PDFLayerController instead of mouseDown: if necessary.
(WebKit::PDFPlugin::handleContextMenuEvent): Grab the relevant NSMenu from PDFKit and display it.
(WebKit::PDFPlugin::handleKeyboardEvent): Don't pass a bogus mouseButtonIsDown to eventTypeFromWebEvent.
(WebKit::PDFPlugin::notifyContentScaleFactorChanged): Update PluginView and co.'s notion of page scale when
PDFKit changes it (generally from the context menu/HUD). Also update page size and scrollbar size/position.
(WebKit::PDFPlugin::setScrollOffset): Don't call SimplePDFPlugin's implementation, as PDFKit handles invalidation itself.
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::updateGeometry): Rename tileScaleFactor to contentScaleFactor.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::updateGeometry): Rename tileScaleFactor to contentScaleFactor.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Make m_scrollOffset protected.
- 4:23 PM Changeset in webkit [134325] by
-
- 2 edits in trunk/LayoutTests
[EFL] WebKit1 gardening.
Mark fast/repaint/block-selection-gap-stale-cache.html and
fast/repaint/block-selection-gap-stale-cache-2.html as image failures.
- platform/efl-wk1/TestExpectations:
- 4:21 PM Changeset in webkit [134324] by
-
- 9 edits2 copies1 add in trunk/Source/WebKit2
Add a RemoteLayerTreeHost object in the UI process
https://bugs.webkit.org/show_bug.cgi?id=101999
Reviewed by Tim Horton.
Add a (mostly empty) RemoteLayerTreeHost class that will live in the UI process and host the layer tree.
- DerivedSources.make:
Add RemoteLayerTreeHost.messages.in.
- Platform/CoreIPC/MessageID.h:
Add a RemoteLayerTreeHost message class.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addMessageReceiver):
(WebKit::WebProcessProxy::removeMessageReceiver):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
Add a message receiver map to the web process proxy.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
Add a RemoteLayerTreeHost member variable.
- UIProcess/mac/RemoteLayerTreeHost.h:
Add new class.
- UIProcess/mac/RemoteLayerTreeHost.messages.in:
Add new messages file with a single Commit message.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
Add the layer tree host as a message receiver.
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
Remote the layer tree host as a message receiver.
(WebKit::RemoteLayerTreeHost::didReceiveMessage):
Call the generated member function.
(WebKit::RemoteLayerTreeHost::commit):
Add an empty stub for now.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::flushLayers):
Send a commit message to the remote layer tree host.
- 3:55 PM Changeset in webkit [134323] by
-
- 21 edits in trunk/Source/WebCore
[V8] Update callers to use the aligned pointer API rather than the deprecated unaligned pointer API
https://bugs.webkit.org/show_bug.cgi?id=101519
Reviewed by Ojan Vafai.
There should be no change in behavior. The new API is slightly faster
than the old API (and apparently works correctly internally in V8).
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::toNative):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::toNative):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::toNative):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::toNative):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::toNative):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::toNative):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::toNative):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::toNative):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::toNative):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::V8TestNode::toNative):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::toNative):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::toNative):
- bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):
- bindings/v8/V8Collection.h:
(WebCore::toNativeCollection):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::isWrapperOfType):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):
- bindings/v8/WrapperTypeInfo.h:
(WebCore::toNative):
(WebCore::toWrapperTypeInfo):
- 3:52 PM Changeset in webkit [134322] by
-
- 71 edits in trunk/Source/WebCore
Rename AttributeStyle => PresentationAttributeStyle across WebCore.
<http://webkit.org/b/101975>
Rubber-stamped by Antti Koivisto.
The completely separate concepts of "attribute style" and "style attribute" were a bit too
easy to confuse in variable and method names. Reconfigure our terminology to call it
"presentation attribute style" instead of "attribute style".
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/ElementAttributeData.cpp:
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::presentationAttributeStyle):
(WebCore::ElementAttributeData::setPresentationAttributeStyle):
(ElementAttributeData):
- dom/Node.h:
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setPresentationAttributeStyleDirty):
(WebCore::Node::clearPresentationAttributeStyleDirty):
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
- dom/StyledElement.h:
(WebCore::StyledElement::additionalPresentationAttributeStyle):
(StyledElement):
(WebCore::StyledElement::collectStyleForPresentationAttribute):
(WebCore::StyledElement::presentationAttributeStyle):
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForPresentationAttribute):
- html/HTMLBRElement.h:
(HTMLBRElement):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectStyleForPresentationAttribute):
- html/HTMLBodyElement.h:
(HTMLBodyElement):
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForPresentationAttribute):
- html/HTMLDivElement.h:
(HTMLDivElement):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForPresentationAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::addHTMLLengthToStyle):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForPresentationAttribute):
- html/HTMLEmbedElement.h:
(HTMLEmbedElement):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
- html/HTMLFontElement.h:
(HTMLFontElement):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::collectStyleForPresentationAttribute):
- html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForPresentationAttribute):
- html/HTMLHRElement.h:
(HTMLHRElement):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForPresentationAttribute):
- html/HTMLIFrameElement.h:
(HTMLIFrameElement):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::collectStyleForPresentationAttribute):
- html/HTMLImageElement.h:
(HTMLImageElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::collectStyleForPresentationAttribute):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectStyleForPresentationAttribute):
- html/HTMLLIElement.h:
(HTMLLIElement):
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::collectStyleForPresentationAttribute):
- html/HTMLMarqueeElement.h:
(HTMLMarqueeElement):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::collectStyleForPresentationAttribute):
- html/HTMLOListElement.h:
(HTMLOListElement):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::collectStyleForPresentationAttribute):
- html/HTMLObjectElement.h:
(HTMLObjectElement):
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForPresentationAttribute):
- html/HTMLParagraphElement.h:
(HTMLParagraphElement):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::collectStyleForPresentationAttribute):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::collectStyleForPresentationAttribute):
- html/HTMLPreElement.h:
(HTMLPreElement):
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::collectStyleForPresentationAttribute):
- html/HTMLTableCaptionElement.h:
(HTMLTableCaptionElement):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::collectStyleForPresentationAttribute):
(WebCore::HTMLTableCellElement::additionalPresentationAttributeStyle):
- html/HTMLTableCellElement.h:
(HTMLTableCellElement):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::collectStyleForPresentationAttribute):
(WebCore::HTMLTableColElement::additionalPresentationAttributeStyle):
- html/HTMLTableColElement.h:
(HTMLTableColElement):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForPresentationAttribute):
(WebCore::HTMLTableElement::additionalPresentationAttributeStyle):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForPresentationAttribute):
- html/HTMLTablePartElement.h:
(HTMLTablePartElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalPresentationAttributeStyle):
- html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectStyleForPresentationAttribute):
- html/HTMLTextAreaElement.h:
(HTMLTextAreaElement):
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::collectStyleForPresentationAttribute):
- html/HTMLUListElement.h:
(HTMLUListElement):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::collectStyleForPresentationAttribute):
- html/HTMLVideoElement.h:
(HTMLVideoElement):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::collectStyleForPresentationAttribute):
- mathml/MathMLElement.h:
(MathMLElement):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
- svg/SVGImageElement.h:
(SVGImageElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::collectStyleForPresentationAttribute):
- svg/SVGStyledElement.h:
(SVGStyledElement):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute):
- svg/SVGTextContentElement.h:
(SVGTextContentElement):
- 3:50 PM Changeset in webkit [134321] by
-
- 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merge fix for <rdar://problem/12486173>.
- 3:47 PM Changeset in webkit [134320] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Roll Chromium DEPS.
- 3:32 PM Changeset in webkit [134319] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Added more Hi-DPI wont-fixes.
- platform/chromium/TestExpectations: Added wont-fixes.
- 3:30 PM Changeset in webkit [134318] by
-
- 2 edits in trunk/Source/WebCore
[V8] Many things crash when switching to V8's new aligned pointer API
https://bugs.webkit.org/show_bug.cgi?id=101994
Reviewed by Eric Seidel.
When using the aligned pointer API, we need to make sure to initialize
every internal field that we later read because the new API has better
error checks than the old API. This patch explicitly initializes the
enteredIsolatedWorldIndex internal field to zero for main worlds,
fixing the LayoutTest crashes from our previous attempt to move the
aligned pointer API.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- 3:19 PM Changeset in webkit [134317] by
-
- 1 edit in branches/safari-536.28-branch/Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h
ML Build fix.
- 3:11 PM Writing Layout Tests for DumpRenderTree edited by
- Fixed the 'font' property for the cross-platform trick (diff)
- 3:09 PM Changeset in webkit [134316] by
-
- 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merge part 2 of <rdar://problem/12486142>.
- 2:57 PM Changeset in webkit [134315] by
-
- 4 edits in trunk/Source/WebKit2
PDFPlugin should support non-1 device scale factor
https://bugs.webkit.org/show_bug.cgi?id=101923
Reviewed by Alexey Proskuryakov.
Do the appropriate plumbing to ensure that PDFPlugin handles device scale factor > 1
(it's called contentsScaleFactor in plugins), both for normal drawing and for snapshotting.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add deviceScaleFactor setter/getter to PDFLayerController.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Override contentsScaleFactorChanged.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfDocumentDidLoad): Plumb device scale factor through to PDFLayerController.
(WebKit::PDFPlugin::contentsScaleFactorChanged): Plumb device scale factor through to PDFLayerController
when we're notified that it has changed.
(WebKit::PDFPlugin::snapshot): Create snapshots with the device scale factor applied.
- 2:54 PM Changeset in webkit [134314] by
-
- 5 edits12 adds in trunk
DFG ArithMul overflow check elimination is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=101871
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
The code was ignoring the fact that ((a * b) | 0) == (((a | 0) * (b | 0)) | 0)
only holds if a * b < 253. So, I changed it to only enable the optimization
when a < 222 and b is an int32 (and vice versa), using a super trivial peephole
analysis to prove the inequality. I considered writing an epic forward flow
formulation that tracks the ranges of integer values but then I thought better
of it.
This also rewires the ArithMul integer speculation logic. Previously, we would
assume that an ArithMul was only UsedAsNumber if it escaped, and separately we
would decide whether to speculate integer based on a proof of the <222
inequality. Now, we treat the double rounding behavior of ArithMul as if the
result was UsedAsNumber even if it did not escape. Then we try to prove that
double rounding cannot happen by attemping to prove that a < 222. This then
feeds back into the decision of whether or not to speculate integer (if we fail
to prove a < 222 then we're UsedAsNumber, and if we're also MayOverflow then
that forces double speculation).
No performance impact. It just fixes a bug.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::mulShouldSpeculateInteger):
- dfg/DFGPredictionPropagationPhase.cpp:
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
LayoutTests:
- fast/js/dfg-mul-big-integer-with-small-integer-and-bitor-expected.txt: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-and-bitor.html: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-and-detect-overflow-expected.txt: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-and-detect-overflow.html: Added.
- fast/js/dfg-mul-big-integer-with-small-integer-expected.txt: Added.
- fast/js/dfg-mul-big-integer-with-small-integer.html: Added.
- fast/js/dfg-mul-big-integers-expected.txt: Added.
- fast/js/dfg-mul-big-integers.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-mul-big-integer-with-small-integer-and-bitor.js: Added.
(foo):
- fast/js/script-tests/dfg-mul-big-integer-with-small-integer-and-detect-overflow.js: Added.
(foo):
- fast/js/script-tests/dfg-mul-big-integer-with-small-integer.js: Added.
(foo):
- fast/js/script-tests/dfg-mul-big-integers.js: Added.
(foo):
- 2:52 PM Changeset in webkit [134313] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG should not emit function checks if we've already proved that the operand is that exact function
https://bugs.webkit.org/show_bug.cgi?id=101885
Reviewed by Oliver Hunt.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::filterByValue):
(AbstractValue):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 2:45 PM Changeset in webkit [134312] by
-
- 6 edits2 moves in trunk/Source/WebKit2
Rename RemoteLayerTreeController to RemoteLayerTreeContext
https://bugs.webkit.org/show_bug.cgi?id=101993
Reviewed by Andreas Kling.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::create):
(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):
(WebKit::RemoteGraphicsLayer::flushCompositingStateForThisLayerOnly):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeController.h.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeController.mm.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
- 2:42 PM Changeset in webkit [134311] by
-
- 5 edits in trunk/Source/WebCore
Reduce the crazy number of parameters to RenderLayer painting member functions
https://bugs.webkit.org/show_bug.cgi?id=101895
Reviewed by Beth Dakin.
The various RenderLayer::paintLayer* functions took a lot of arguments, most
of which were passed down directly to descendants.
Gather these arguments into a LayerPaintingInfo struct.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint): Create a LayerPaintingInfo struct to pass
to descendant paint calls.
(WebCore::RenderLayer::paintOverlayScrollbars): Ditto.
(WebCore::RenderLayer::paintLayer): When painting transformed layers, we
make a new LayerPaintingInfo because the root layer is shifted.
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::paintPaginatedChildLayer):
(WebCore::RenderLayer::paintChildLayerIntoColumns): Create a new LayerPaintingInfo
struct for column painting.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
(LayerPaintingInfo):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer): Build a LayerPaintingInfo
to enter layer painting.
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::paint): Ditto.
- 2:36 PM Changeset in webkit [134310] by
-
- 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merge part 1 of <rdar://problem/12486142>.
- 2:36 PM Changeset in webkit [134309] by
-
- 6 edits in trunk/Tools
webkitpy: integrate pylint into check-webkit-style, part I
https://bugs.webkit.org/show_bug.cgi?id=101285
Reviewed by Ojan Vafai.
This patch re-works lint-webkitpy so that the logic is pushed
into check-webkit-style (mostly); we don't yet control which
messages are displayed using the rules in webkitpy/style/checker.py
(we're still using the pylintrc to suppress messages instead),
but otherwise things work. For now we will only report pylint
"errors", not warnings.
- Scripts/lint-webkitpy:
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checkers/python.py:
(PythonChecker):
(PythonChecker.check):
(PythonChecker._check_pep8):
(PythonChecker._check_pylint):
(Pylinter):
(Pylinter.init):
(Pylinter.run):
(_FilteredStringIO):
(_FilteredStringIO.init):
(_FilteredStringIO.write):
(_FilteredStringIO._filter):
- Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
- Scripts/webkitpy/style/checkers/python_unittest_input.py:
- 2:33 PM Changeset in webkit [134308] by
-
- 3 edits in trunk/Tools
nrwt: remove a bunch of broken chromium-specific flags
https://bugs.webkit.org/show_bug.cgi?id=101979
Reviewed by Tony Chang.
There were a bunch of chromium-specific flags that used to be
supported by NRWT (and handled and passed on to DRT) but have
probably been broken for a long time and are currently ignored.
This patch removes all of those flags; the rule of thumb going forward
is that we should only add flags that affect how the python code functions.
If a flag is just passed verbatim to DRT, the user can use --additional-drt-flag
for that.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp):
- 2:30 PM Changeset in webkit [134307] by
-
- 3 edits in trunk/Source/WebKit2
Add debug only code to dump the contents of a transaction
https://bugs.webkit.org/show_bug.cgi?id=101991
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::writeIndent):
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::dump):
- 2:26 PM Changeset in webkit [134306] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Updated expectations for calendar-picker.
- platform/chromium/TestExpectations: Updated expectations.
- 2:25 PM Changeset in webkit [134305] by
-
- 4 edits3 copies in branches/safari-536.28-branch
Merged r129440. <rdar://problem/12632312>
- 2:22 PM Changeset in webkit [134304] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] When opening an image it does not scale to fit our window
https://bugs.webkit.org/show_bug.cgi?id=101778
Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.
PR: 230935
For image document, the actual image size can be different with the
contents size. Zoom the document based on the image width so that
images can fit the screen horizontally. Set 2.0 as the maximum zoom to
fit scale for image document so that very small images won't get
ridiculous large scales during the initial load.
- Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):
- 2:21 PM Changeset in webkit [134303] by
-
- 6 edits3 copies in branches/safari-536.28-branch
Merged r126718. <rdar://problem/12625038>
- 2:21 PM Changeset in webkit [134302] by
-
- 2 edits in trunk/LayoutTests
Marked transforms/3d/point-mapping tests as flakey.
https://bugs.webkit.org/show_bug.cgi?id=101988
- platform/chromium/TestExpectations: Added Expectations.
- 2:13 PM Changeset in webkit [134301] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Added expectations for platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html
https://bugs.webkit.org/show_bug.cgi?id=101986
- platform/chromium/TestExpectations: Added expectations.
- 1:59 PM Changeset in webkit [134300] by
-
- 5 edits in trunk/Source/WebKit2
Store name changes in the layer transaction
https://bugs.webkit.org/show_bug.cgi?id=101981
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
Add new LayerProperties class.
(RemoteLayerTreeTransaction):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
Find the changed layer properties for the given layer and apply the changed properties.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(WebKit::RemoteGraphicsLayer::layerID):
Add new getter.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::generateLayerID):
(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):
Give each remote graphics layer a unique ID.
- 1:56 PM Changeset in webkit [134299] by
-
- 12 edits in trunk/Source
NetworkProcess: Use an accurate shouldContentSniff value when creating ResourceHandles
https://bugs.webkit.org/show_bug.cgi?id=101872
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Expose shouldSniffContent to pass it along to the NetworkProcess.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::shouldSniffContent):
Source/WebKit2:
The WebProcess now passes "shouldContentSniff" over to the NetworkProcess with the requests so it can be respected.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleNetworkRequest): Update to pass through "shouldContentSniff"
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkRequest.cpp:
(WebKit::NetworkRequest::NetworkRequest):
(WebKit::NetworkRequest::start):
- NetworkProcess/NetworkRequest.h:
(WebKit::NetworkRequest::create):
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleNetworkRequest): Update to pass through "shouldContentSniff"
- NetworkProcess/NetworkResourceLoadScheduler.h:
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Update to pass through "shouldContentSniff"
- 1:54 PM Changeset in webkit [134298] by
-
- 2 edits in trunk/LayoutTests
[Chromium] WonFixed hi-DPI related tests.
https://bugs.webkit.org/show_bug.cgi?id=90022
- platform/chromium/TestExpectations: Added expectations.
- 1:45 PM Changeset in webkit [134297] by
-
- 2 edits2 deletes in trunk/LayoutTests
Unreviewed, update chromium-mac baselines.
- platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Removed.
- platform/chromium-mac-snowleopard/compositing/repaint/invalidations-on-composited-layers-expected.txt: Removed.
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- 1:45 PM Changeset in webkit [134296] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Supressing a Skia change to prevent layout test breakage.
Unreviewed expectations management.
- skia_webkit.gyp: Added supression 'SK_IGNORE_FAST_BLURRECT=1'
- 1:36 PM Changeset in webkit [134295] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101930
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
Added --device-pixel-ratio command line option to EFL MiniBrowser which sets
the ratio between the CSS units and device pixels when the content is unscaled.
Option is applied for all the views created by mini browser.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 1:26 PM Changeset in webkit [134294] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use keyevents instead of editor commands for backspace
https://bugs.webkit.org/show_bug.cgi?id=101663
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-12
Reviewed by Rob Buis.
PR229395
Sending keyEvents for backspace and switching from KeyChar
to KeyDown since we are still receiving an unadultered KeyUp
from the input service. This was causing us to get two keyUps
for regular keys and no key downs for backspace since it was
triggering an editor command and bypassing JS listeners.
Reviewed internally by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::relativeRightOffset):
(WebKit):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::setText):
- 1:16 PM Changeset in webkit [134293] by
-
- 6 edits in trunk/Source/WebKit2
More work towards packaging layer changes up into a transaction object
https://bugs.webkit.org/show_bug.cgi?id=101969
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::RemoteLayerTreeTransaction):
(WebKit::RemoteLayerTreeTransaction::~RemoteLayerTreeTransaction):
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
Add empty stubs.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::flushCompositingStateForThisLayerOnly):
Call layerPropertiesChanged on the current transaction.
- WebProcess/WebPage/mac/RemoteLayerTreeController.h:
- WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::RemoteLayerTreeController):
Initialize m_currentTransaction till 0.
(WebKit::RemoteLayerTreeController::currentTransaction):
Add getter. This may only be called from beneath flushLayers.
(WebKit::RemoteLayerTreeController::flushLayers):
Create a transaction before flusing the compositing state.
- 1:14 PM Changeset in webkit [134292] by
-
- 1 edit7 adds in trunk/LayoutTests
Unreviewed, update chromium-mac-lion baselines after r134279.
- platform/chromium-mac-lion/fast/repaint/delete-into-nested-block-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/inline-outline-repaint-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/selection-after-delete-expected.png: Added.
- platform/chromium-mac-lion/svg/custom/foreignObject-crash-on-hover-expected.png: Added.
- platform/chromium-mac-lion/svg/custom/hit-test-unclosed-subpaths-expected.png: Added.
- platform/chromium-mac-lion/svg/custom/hit-test-with-br-expected.png: Added.
- 1:10 PM Changeset in webkit [134291] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update expectations for calendar-picker tests..
https://bugs.webkit.org/show_bug.cgi?id=101561
- platform/chromium/TestExpectations: Updated expectations.
- 1:04 PM Changeset in webkit [134290] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r133469. <rdar://problem/12636795>
- 1:02 PM Changeset in webkit [134289] by
-
- 4 edits1 delete in trunk/Source
[chromium] Delete WebCompositor.h
https://bugs.webkit.org/show_bug.cgi?id=101137
Reviewed by James Robinson.
The implementation of this class is getting deleted and all
WebKit-side users are already going via WebCompositorSupport instead.
Source/Platform:
- Platform.gypi:
- chromium/public/WebCompositor.h: Removed.
Source/WebKit/chromium:
- tests/WebCompositorInputHandlerImplTest.cpp:
- 12:58 PM Changeset in webkit [134288] by
-
- 2 edits in trunk/LayoutTests
Unreviewd, update chromium-mac-mountainlion expectations for a few tests.
- platform/chromium/TestExpectations:
- 12:51 PM Changeset in webkit [134287] by
-
- 5 edits in trunk/LayoutTests
Layout Test compositing/repaint/invalidations-on-composited-layers.html is failing/flaky
https://bugs.webkit.org/show_bug.cgi?id=101219
Reviewed by James Robinson.
Force a style recalc before starting repaint tracking.
- compositing/repaint/invalidations-on-composited-layers-expected.txt:
- compositing/repaint/invalidations-on-composited-layers.html:
- platform/chromium/TestExpectations:
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- 12:44 PM Changeset in webkit [134286] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r133379. <rdar://problem/12632315>
- 12:41 PM Changeset in webkit [134285] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r131077. <rdar://problem/12589197>
- 12:38 PM Changeset in webkit [134284] by
-
- 6 edits in branches/safari-536.28-branch/Source
Merged r131018. <rdar://problem/12516363>
- 12:37 PM Changeset in webkit [134283] by
-
- 2 edits in trunk/Source/WebCore
Fix memory leak in createSurfaceForBackingStore()
https://bugs.webkit.org/show_bug.cgi?id=101941
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
Fix memory leak in createSurfaceForBackingStore(),
the RefPtr<cairo_surface_t> should be released
when returned since we pass ownership to the
caller.
No new tests, no behavior change for layout tests.
- platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::createSurfaceForBackingStore):
- 12:34 PM Changeset in webkit [134282] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r130855. <rdar://problem/12655076>
- 12:32 PM Changeset in webkit [134281] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix Chromium DEPS version after accidentally checking in HEAD a couple days ago.
Unreviewed, build fix.
- DEPS:
- 12:32 PM Changeset in webkit [134280] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update to new proxyInfo API
https://bugs.webkit.org/show_bug.cgi?id=101945
Patch by Joe Mason <jmason@rim.com> on 2012-11-12
Reviewed by George Staikos.
Internal PR: 234680
Reviewed internally by: Leo Yang
The proxyAddress, proxyUsername and proxyPassword methods in BlackBerry::Platform::Settings
have been replaced with a single, more efficient proxyInfo method.
No new tests because this is an API update with no behaviour change.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::storeCredentials):
- 12:15 PM Changeset in webkit [134279] by
-
- 8 edits in trunk/LayoutTests
Unreviewed, update chromium-mac-mountainlion baselines.
- platform/chromium-mac/fast/repaint/delete-into-nested-block-expected.png:
- platform/chromium-mac/fast/repaint/inline-outline-repaint-expected.png:
- platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
- platform/chromium-mac/fast/repaint/selection-after-delete-expected.png:
- platform/chromium-mac/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/chromium-mac/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/chromium-mac/svg/custom/hit-test-with-br-expected.png:
- 12:14 PM Changeset in webkit [134278] by
-
- 6 edits in trunk/Source/WebKit2
More work on remote layer flushing
https://bugs.webkit.org/show_bug.cgi?id=101960
Reviewed by Andreas Kling.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::flushCompositingState):
Call recursiveCommitChanges.
(WebKit::RemoteGraphicsLayer::flushCompositingStateForThisLayerOnly):
Add stub function for now.
(WebKit::RemoteGraphicsLayer::recursiveCommitChanges):
Call flushCompositingStateForThisLayerOnly and then call recursiveCommitChanges recursively on all the child layers.
- WebProcess/WebPage/mac/RemoteLayerTreeController.h:
- WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::create):
(WebKit::RemoteLayerTreeController::RemoteLayerTreeController):
This now takes a web page.
(WebKit::RemoteLayerTreeController::setRootLayer):
Add empty function.
(WebKit::RemoteLayerTreeController::layerFlushTimerFired):
Call flushLayers explicitly.
(WebKit::RemoteLayerTreeController::flushLayers):
Force a layout and then sync all the compositing layers.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
RemoteLayerTreeController::create now takes a web page.
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
Call the remote layer tree controller.
- 12:08 PM Changeset in webkit [134277] by
-
- 5 edits1 delete in trunk
remove the chromium-mac-mountainlion TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=101789
Reviewed by Ojan Vafai.
Nearly all of the tests have been updated for 10.8 and the remaining
failures have been merged into the main TestExpectations file. We
don't need this hook any more.
Tools:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.operating_system):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_path_to_image_diff):
LayoutTests:
- platform/chromium-mac-mountainlion/TestExpectations: Removed.
- 11:54 AM Changeset in webkit [134276] by
-
- 1 edit in branches/chromium/1312/Source/WebKit/chromium/src/WebElement.cpp
Merge 133982
BUG=159829
Review URL: https://codereview.chromium.org/11410042
- 11:53 AM Changeset in webkit [134275] by
-
- 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebElement.cpp
Merge 133982
BUG=159829
Review URL: https://codereview.chromium.org/11363202
- 11:50 AM Changeset in webkit [134274] by
-
- 3 edits in branches/chromium/1312
Merge 133610
BUG=159098
Review URL: https://codereview.chromium.org/11377110
- 11:48 AM Changeset in webkit [134273] by
-
- 3 edits in branches/chromium/1271
Merge 133610
BUG=159098
Review URL: https://codereview.chromium.org/11369197
- 11:44 AM Changeset in webkit [134272] by
-
- 2 edits2 copies in branches/chromium/1312
Merge 133717
BUG=158898
Review URL: https://codereview.chromium.org/11360203
- 11:42 AM Changeset in webkit [134271] by
-
- 2 edits2 copies in branches/chromium/1271
Merge 133717
BUG=158898
Review URL: https://codereview.chromium.org/11377109
- 11:36 AM Changeset in webkit [134270] by
-
- 7 edits2 copies in branches/safari-536.28-branch
Merged r129796. <rdar://problem/12589203>
- 11:31 AM Changeset in webkit [134269] by
-
- 3 edits2 copies in branches/chromium/1312
Merge 132983
BUG=158547
Review URL: https://codereview.chromium.org/11364206
- 11:28 AM Changeset in webkit [134268] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r126157.
http://trac.webkit.org/changeset/126157
https://bugs.webkit.org/show_bug.cgi?id=101954
This patch caused (untestable) regression of the volume
property on Mac, Win, and Blackberry ports. (Requested by
jernoble on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::setVolume):
(WebCore::MediaPlayer::setMuted):
(WebCore::MediaPlayer::setPreservesPitch):
(WebCore::MediaPlayer::setSize):
(WebCore::MediaPlayer::setVisible):
(WebCore::MediaPlayer::setPreload):
- 11:24 AM Changeset in webkit [134267] by
-
- 3 edits2 copies in branches/chromium/1312
Merge 132856
BUG=156567
Review URL: https://codereview.chromium.org/11358200
- 11:24 AM Changeset in webkit [134266] by
-
- 3 edits in branches/safari-536.28-branch/Source/JavaScriptCore
Merged r129577.
- 11:20 AM Changeset in webkit [134265] by
-
- 6 edits2 adds in trunk
Source/WebCore: Specified width CSS tables should not include border and padding as part of that width.
https://bugs.webkit.org/show_bug.cgi?id=77028
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-12
Reviewed by Julien Chaffraix.
CSS table width should not include border and padding even though HTML
tables size as though their width includes border/padding.
This is applicable for all CSS tables with specified widths.
The change would also make our rendering of CSS tables with specified
width similar to that of Opera, IE and FF.
Test: fast/table/css-table-width-with-border-padding.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
Added check for all (positive) specified widths for CSS tables to
consider border and padding outside of the specified width.
LayoutTests: Specified width CSS tables should not include border and padding as part of that width.
https://bugs.webkit.org/show_bug.cgi?id=77028
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-12
Reviewed by Julien Chaffraix.
- fast/table/css-table-width-with-border-padding-expected.html: Added.
- fast/table/css-table-width-with-border-padding.html: Added.
Test added for verifying that for specified width css tables, border
and padding are not considered as part of the specified table width.
The test also verifies the width values for the different box-sizing
properties viz, content-box, border-box and padding-box.
Out of these padding-box is currently not supported even though
the test verifies against this property as well.
The expected width values added for padding-box are thus incorrect
and should be lesser by 100px (padding value).
- fast/table/min-width-css-block-table-expected.txt:
- fast/table/min-width-css-inline-table-expected.txt:
- fast/table/script-tests/min-width-helpers.js:
Existing test values changed for CSS tables that have percent width
specified since for both these tests, border and padding has been
specified for all the tables.
As a result of this fix, the specified table width shall no longer
include the border and padding values thereby increasing our table
width size by exactly 30px (the value of border and padding in these
tests).
The new values for percent width css tables now match those for FF
and Opera.
- 11:19 AM Changeset in webkit [134264] by
-
- 1 edit3 copies in branches/chromium/1312
Merge 133155
BUG=153228
Review URL: https://codereview.chromium.org/11369193
- 11:18 AM Changeset in webkit [134263] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r126903. <rdar://problem/12516356>
- 11:13 AM Changeset in webkit [134262] by
-
- 6 edits in trunk/Source/WebCore
Move resolving blob references to FormData.
https://bugs.webkit.org/show_bug.cgi?id=101754
Reviewed by Simon Hausmann.
Resolving Blob-references to a set of just File and Data is done similar by several platforms.
This patch adds a generic implementation in FormData and uses that from CFNetwork, Qt and
BlackBerry network implementation.
- platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
(WebCore::FormData::resolveBlobReferences):
- platform/network/FormData.h:
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::setHTTPBody):
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::prepareFormElements):
- 11:12 AM Changeset in webkit [134261] by
-
- 2 edits in trunk/Tools
[Chromium-Android] Restart the device's shell in root before pushing data
https://bugs.webkit.org/show_bug.cgi?id=101944
Reviewed by Adam Barth.
Setting up md5sum and pushing the executable, fonts and test resources was
unintentionally being done prior to executing the "adb root" command,
which restarts the device's shell to be root. Since test data is still
being pushed to /data/local/tmp, writing to which requires root access,
devices not running as root would throw a ScriptError.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._setup_test):
- 11:10 AM Changeset in webkit [134260] by
-
- 3 edits2 copies in branches/chromium/1271
Merge 132983
BUG=158547
Review URL: https://codereview.chromium.org/11360201
- 11:04 AM Changeset in webkit [134259] by
-
- 7 edits2 copies in trunk/Source/WebKit2
Layer property changes should schedule a remote layer flush
https://bugs.webkit.org/show_bug.cgi?id=101951
Reviewed by Andreas Kling.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
New class. For now this just contains the changed layer properties flags but this will be extended
to cover changed layers as well.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):
Initialize m_uncommittedLayerChanges.
(WebKit::RemoteGraphicsLayer::setName):
Set the name and call noteLayerPropertiesChanged.
(WebKit::RemoteGraphicsLayer::noteLayerPropertiesChanged):
Notify that a flush is required (if required).
- WebProcess/WebPage/mac/RemoteLayerTreeController.h:
Add a layer flush timer.
- WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::RemoteLayerTreeController):
Initialize the layer flush timer.
(WebKit::RemoteLayerTreeController::scheduleLayerFlush):
Schedule the layer flush timer if needed.
(WebKit::RemoteLayerTreeController::layerFlushTimerFired):
Empty stub for now.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
Call the remote layer tree controller.
- 11:03 AM Changeset in webkit [134258] by
-
- 3 edits2 copies in branches/chromium/1271
Merge 132856
BUG=156567
Review URL: https://codereview.chromium.org/11293229
- 10:58 AM Changeset in webkit [134257] by
-
- 1 edit3 copies in branches/chromium/1271
Merge 133155
BUG=153228
Review URL: https://codereview.chromium.org/11275265
- 10:43 AM Changeset in webkit [134256] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash in InRegionScrollerPrivate.
https://bugs.webkit.org/show_bug.cgi?id=101399
Reviewed by Yong Li.
Fix warning caused by the previous patch for this bug (r133679).
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 10:36 AM Changeset in webkit [134255] by
-
- 2 edits in trunk/Source/WebCore
GraphicsSurfaceGLX does not handle transparency correctly.
https://bugs.webkit.org/show_bug.cgi?id=101943
GraphicsSurfacGLX must consistently use RGBA texture format.
glXCreateWindow must be called after creating the XWindow
that serves as a temporary offscreen texture storage, in order
to allow for transparency.
When creating the offscreen XWindow we must make sure,
that we use a framebuffer configuration that supports
an alpha mask.
Reviewed by Noam Rosenthal.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- 10:19 AM Changeset in webkit [134254] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r134225.
http://trac.webkit.org/changeset/134225
https://bugs.webkit.org/show_bug.cgi?id=101948
Appears to have broken the EFL and GTK builds (Requested by
abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore):
(WebCore::JSHTMLElement::itemValue):
(WebCore::JSHTMLElement::setItemValue):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
(WebCore::V8HTMLElement::itemValueAccessorSetter):
- html/HTMLElement.idl:
- 10:13 AM Changeset in webkit [134253] by
-
- 2 edits in trunk/Source/WebCore
hitTestResultAtPoint does two hit-tests if called on non main frame
https://bugs.webkit.org/show_bug.cgi?id=101915
Reviewed by Antonio Gomes.
Always redirect hitTestResultAtPoint to the main-frame. This used to being
done on every result that hit anything, which caused running the expensive
hit-tests multiple times in almost all cases.
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- 10:06 AM Changeset in webkit [134252] by
-
- 198 edits in trunk/LayoutTests
IndexedDB: convert tests from setVersion to upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=101676
Reviewed by Tony Chang.
A la bug 92037, add a function to shared.js that sets up the database
for tests where opening and versioning isn't the focus.
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/createObjectStore-null-name-expected.txt: ...many tests and expected files...
- storage/indexeddb/resources/shared.js: The new utility function indexedDBTest lives here.
- storage/indexeddb/values-odd-types-expected.txt:
- 9:59 AM Changeset in webkit [134251] by
-
- 7 edits in trunk/Source/WebKit2
[EFL] Add implementations of device - user conversion methods
https://bugs.webkit.org/show_bug.cgi?id=101938
Reviewed by Laszlo Gombos.
Consider the deviceScaleFactor when convertion to/from user
and device units.
This affects DOM API's such as window.moveTo, resizeTo etc.
- UIProcess/efl/PageClientBase.cpp:
- UIProcess/efl/PageClientBase.h:
(PageClientBase):
- UIProcess/efl/PageClientDefaultImpl.cpp:
(WebKit::PageClientDefaultImpl::convertToDeviceSpace):
(WebKit):
(WebKit::PageClientDefaultImpl::convertToUserSpace):
- UIProcess/efl/PageClientDefaultImpl.h:
(PageClientDefaultImpl):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::convertToDeviceSpace):
(WebKit):
(WebKit::PageClientLegacyImpl::convertToUserSpace):
- UIProcess/efl/PageClientLegacyImpl.h:
(PageClientLegacyImpl):
- 9:57 AM Changeset in webkit [134250] by
-
- 12 edits1 delete in trunk/Source
[V8][JSC] ScriptProfileNode::callUID needs not to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=101892
Reviewed by Adam Barth.
Source/JavaScriptCore:
Added callUID(), which enables us to kill custom bindings for ScriptProfileNode::callUID.
- profiler/ProfileNode.h:
(JSC::ProfileNode::callUID):
Source/WebCore:
We can remove [Custom] from callUID in ScriptProfileNode.idl.
No tests. No change in behavior.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSScriptProfileNodeCustom.cpp: Removed.
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
- inspector/ScriptProfileNode.idl:
- 9:50 AM Changeset in webkit [134249] by
-
- 4 edits1 delete in trunk/Source/WebCore
[V8] Performance::memory getter needs not to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=101890
Reviewed by Adam Barth.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/custom/V8PerformanceCustom.cpp: Removed.
- page/Performance.idl:
- 9:42 AM Changeset in webkit [134248] by
-
- 4 edits in trunk/Source/WebCore
[V8][JSC] HTMLOptionsCollection::length needs not to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=101888
Reviewed by Adam Barth.
We can remove [Custom] from getter. It is possible to remove [Custom]
from setter, but it changes the current behavior.
(I think the current implementation of the setter is wrong.
I'll fix it in another patch.)
No tests. No change in behavior.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- html/HTMLOptionsCollection.idl:
- 9:34 AM Changeset in webkit [134247] by
-
- 9 edits in trunk/Source
[EFL][WK2][AC] Black screen when applications use software backend.
https://bugs.webkit.org/show_bug.cgi?id=101659
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Add a utility method to create a cairo_surface_t from a given Evas_Object_Image.
No new tests. Will be covered when running existing tests without enabling openGL.
- platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::createSurfaceForImage):
(WebCore):
- platform/graphics/efl/CairoUtilitiesEfl.h:
(WebCore):
Source/WebKit2:
If creating openGL context fails, automatically fallback to software rendering.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl::hardwareAccelerationEnabled):
(EwkViewImpl):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::ensureRootLayer):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit::LayerTreeRenderer::setAccelerationMode):
(LayerTreeRenderer):
- UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::createDrawingAreaProxy):
- 8:43 AM Changeset in webkit [134246] by
-
- 5 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing header.
Source/WebCore:
- GNUmakefile.am: Remove editing from IDL_PATH since it doesn't
contain idl files anymore.
- GNUmakefile.list.am: Add missing header files.
- 8:34 AM Changeset in webkit [134245] by
-
- 5 edits in trunk
MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level
https://bugs.webkit.org/show_bug.cgi?id=101733
Reviewed by Jochen Eisinger.
Source/WebCore:
This patch adds better verification to MediaConstraintsImpl.
Existing tests expanded to cover this change.
- Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::initialize):
LayoutTests:
This patch adds more tests for MediaConstraints.
- fast/mediastream/RTCPeerConnection-expected.txt:
- fast/mediastream/RTCPeerConnection.html:
- 8:20 AM Changeset in webkit [134244] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r134223.
http://trac.webkit.org/changeset/134223
https://bugs.webkit.org/show_bug.cgi?id=101939
Breaks inspector tests (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
- inspector/front-end/externs.js:
- inspector/front-end/textEditor.css:
- 8:13 AM Changeset in webkit [134243] by
-
- 8 edits in trunk
[Qt] Support ResourceRequest's setTimeoutInterval
https://bugs.webkit.org/show_bug.cgi?id=101731
Reviewed by Simon Hausmann.
Source/WebCore:
Establish a timeout and return the correct error when it is triggered.
Tested by existing http/tests/xmlhttprequest/timeout tests.
- platform/network/ResourceRequestBase.cpp:
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::timeout):
(WebCore::QNetworkReplyHandler::timerEvent):
(WebCore::QNetworkReplyHandler::start):
- platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyHandler):
Tools:
Enable XHR_TIMEOUT now that we support the necessary feature.
- qmake/mkspecs/features/features.pri:
LayoutTests:
Unskip now passing XHR timeout tests.
- platform/qt/TestExpectations:
- 8:06 AM Changeset in webkit [134242] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r134224.
http://trac.webkit.org/changeset/134224
https://bugs.webkit.org/show_bug.cgi?id=101937
asserting on bawts (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
- rendering/style/RenderStyle.h:
- rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::StyleBackgroundData):
- rendering/style/StyleBackgroundData.h:
(WebCore::StyleBackgroundData::color):
(StyleBackgroundData):
- rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
- rendering/style/StyleInheritedData.h:
(StyleInheritedData):
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
- rendering/style/StyleMultiColData.h:
(StyleMultiColData):
- rendering/style/StyleRareInheritedData.cpp:
(SameSizeAsStyleRareInheritedData):
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(WebCore):
(StyleRareInheritedData):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
- 7:51 AM Changeset in webkit [134241] by
-
- 4 edits in trunk/LayoutTests
Layout Test inspector/debugger/dynamic-scripts.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=99338
Unreviewed inspector tests flakiness fix.
- http/tests/inspector-enabled/dynamic-scripts.html:
- inspector/debugger/dynamic-scripts.html:
- platform/chromium/TestExpectations:
- 7:43 AM Changeset in webkit [134240] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 236993
Internally Reviewed by Jeff Rogers.
Use slide and paint method on slider range and media controls.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::drawThreeSliceHorizontal):
(WebCore::drawThreeSliceVertical):
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
- 7:38 AM Changeset in webkit [134239] by
-
- 12 edits in trunk/Source/WebCore
Refactoring: set read-only values on layout in DateTimeEditElement
https://bugs.webkit.org/show_bug.cgi?id=101916
Reviewed by Kentaro Hara.
We have always updated read-only values when we set an empty value or
DateTimeFieldsState. It has wasted CPU time because such read-only
values are never updated after layout() essentially. So, we set
read-only values in DateTimeEditBuilder used by layout(), and remove
dateForReadOnlyField arguments of setEmptyValue and
setValueAsDateTimeFieldsState.
No new tests. This should not make behavior changes.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):
We removed dateForReadOnlyField argument because read-only values are
already set in DateTimeFieldElement::layout().
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField):
Set a value to a read-only minute/second/millisecond field while
building UI elements.
Also, changed variable types for millisecond and second fields to
RefPtr<DateTimeNumericFieldElement> because we'd like to call
setValueAsDate, which is private in DateTimeMillisecondFieldElement and
DateTimeSecondFieldElement
(WebCore::DateTimeEditElement::setValueAsDateTimeFieldsState):
We removed dateForReadOnlyField argument because read-only values are
already set in DateTimeFieldElement::layout().
(WebCore::DateTimeEditElement::setEmptyValue): Ditto.
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement):
Removed dateForReadOnlyField argument for setValueAsDateTimeFieldsState.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
We removed dateForReadOnlyField argument because read-only values are
already set in DateTimeFieldElement::layout().
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Ditto.
- html/shadow/DateTimeFieldElements.cpp: Ditto.
- html/shadow/DateTimeFieldElements.h: Ditto.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
It should do nothing if it is read-only because a read-only value was
already set just after construction.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
Removed dateForReadOnlyField argument of setEmptyValue.
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue): Ditto.
- html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement): Ditto.
- 7:27 AM Changeset in webkit [134238] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::findText
Reviewed by Simon Hausmann.
Details of the failure:
FAIL! : tst_QWebPage::findText() Compared values are not the same
Actual (m_page->selectedHtml().trimmed().replace(regExp, "")): <span>foo</span>
Expected (subString): foo
Loc: home/joce/dev/webkit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2964)
The format returned by selectedHtml changed.
Make the test a bit more robust by just checking that the HTML
contains our search value.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::findText):
- 7:27 AM Changeset in webkit [134237] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::testLocalStorageVisibility
Reviewed by Simon Hausmann.
window.localStorage is expected to work for file URLs.
I'm not sure why it did work when this test was written,
but I believe that it had the wrong expected value.
- tests/qwebpage/tst_qwebpage.cpp:
- 7:26 AM Changeset in webkit [134236] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QObjectBridge::callQtInvokable
Reviewed by Simon Hausmann.
Q_DECLARE_METATYPE now calls qRegisterMetaType so just prevent
the value from being wrapped by QVariant since this code shouldn't
be reached anyway.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(MyQObject::myInvokableWithBrushStyleArg):
- 7:26 AM Changeset in webkit [134235] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::inputMethods
Reviewed by Simon Hausmann.
Details of the failure:
FAIL! : tst_QWebPage::inputMethods(QWebView) Compared values are not the same
Actual (page->settings()->fontFamily(QWebSettings::SerifFont)): FooSerifFont
Expected (font.family()): Helvetica
Loc: [Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1691)]
The issue was that WebCore wouldn't find FooSerifFont and would have
RenderStyle::font() return the fallback font it used instead.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
- 7:26 AM Changeset in webkit [134234] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244
Reviewed by Simon Hausmann.
- tests/qwebpage/tst_qwebpage.cpp:
- 7:26 AM Changeset in webkit [134233] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle now works as expected
https://bugs.webkit.org/show_bug.cgi?id=60372
Reviewed by Simon Hausmann.
Update the expected value to follow this comment in StylePropertySet::addParsedProperty:
"Only add properties that have no !important counterpart present"
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::style):
- 7:25 AM Changeset in webkit [134232] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] tst_QWebElement::style() fails because QWebElement::CascadedStyle doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=65244
Reviewed by Kenneth Rohde Christiansen.
StyleResolver::styleRulesForElement now takes flags as parameter instead of a bool to specify
that we want to exclude UI and user style sheets.
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::style):
- 7:25 AM Changeset in webkit [134231] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Appending "!important" to the property value of QWebElement::setStyleProperty isn't working
https://bugs.webkit.org/show_bug.cgi?id=101763
Reviewed by Kenneth Rohde Christiansen.
In the pastWebCore have been considering the important token of a CSS
property value if it was followed by !important as well as the
important parameter of setInlineStyleProperty, but not anymore.
Since we need to keep the behavior compatible, do the parsing of the
value and extract the token if present. Ideally this would be passed
as a parameter to the function but I think it's not worth deprecating
the old mechanism.
The parsing is pretty dumb, so this will break applications that
passed a value with spaces between the "!" and "important".
This fixes part of tst_QWebElement::style
- Api/qwebelement.cpp:
(QWebElement::setStyleProperty):
- 7:25 AM Changeset in webkit [134230] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix URL issues in tst_qwebframe
https://bugs.webkit.org/show_bug.cgi?id=101741
Reviewed by Simon Hausmann.
- tests/qwebframe/tst_qwebframe.cpp:
(FakeReply::FakeReply):
Properly forward the request URL to our custom reply.
This would cause redirections not to occur. The requestedUrl and setUrlSameUrl tests
would fail because of this.
(tst_QWebFrame::setUrlToInvalid):
- http:/example.com is a valid URL, but not a valid HTTP URL, so remove this check.
- QCOMPARE uses testlib's toString on the QUrls to compare them and it now
also output the error description. Since we want to compare the resulting
URL instead, compare their toEncoded() value.
- 7:24 AM Changeset in webkit [134229] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix a crash in tst_QWebInspector::attachAndDestroy
https://bugs.webkit.org/show_bug.cgi?id=101575
Reviewed by Simon Hausmann.
It can now happen that destroyInspectorView is called when the Page
is destroyed. This would call getOrCreateInspector and re-create a
QWebInspector.
Since the new instance is created after our setInspector(0) cleanup
in ~QWebPagePrivate, this runs into the same crash that this line was
protecting us against.
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorFrontendClientQt::destroyInspectorView):
- 7:24 AM Changeset in webkit [134228] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::inputMethods on Qt5
https://bugs.webkit.org/show_bug.cgi?id=101571
Reviewed by Simon Hausmann.
QEvent::RequestSoftwareInputPanel isn't passed through event filters anymore.
Use QInputMethodPrivate::testContext instead to capture input method events,
the same way as qtbase tests like tst_QTextEdit are doing.
- tests/qwebpage/tst_qwebpage.cpp:
(TestInputContext::TestInputContext):
(TestInputContext::~TestInputContext):
(TestInputContext):
(TestInputContext::showInputPanel):
(TestInputContext::hideInputPanel):
(TestInputContext::isInputPanelVisible):
(tst_QWebPage::inputMethods):
- 7:20 AM Changeset in webkit [134227] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-12
Reviewed by Rob Buis.
RIM PR 236993
Internally Reviewed by Jeff Rogers.
Enable GL slider.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::drawThreeSlice):
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):
- 7:02 AM Changeset in webkit [134226] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r134205): gardening. Skipped 2 failing reftests.
https://bugs.webkit.org/show_bug.cgi?id=101933
Patch by János Badics <János Badics> on 2012-11-12
Reviewed by Csaba Osztrogonác.
- platform/qt/TestExpectations:
- 6:57 AM Changeset in webkit [134225] by
-
- 4 edits in trunk/Source/WebCore
[V8][JSC] HTMLElement::itemValue() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101882
Reviewed by Adam Barth.
We can remove a [Custom] IDL attribute.
No tests. No change in behavior.
- bindings/js/JSHTMLElementCustom.cpp:
- bindings/v8/custom/V8HTMLElementCustom.cpp:
- html/HTMLElement.idl:
- 6:42 AM Changeset in webkit [134224] by
-
- 13 edits in trunk/Source/WebCore
RenderStyle: Pack Color members tighter in substructures.
<http://webkit.org/b/101860>
Patch by Andreas Kling <kling@webkit.org> on 2012-11-12
Reviewed by Antti Koivisto.
For RenderStyle substructures (StyleInheritedData, et al.), unfold all WebCore::Color
members into RGBA32/bool variables OR just an RGBA32 if the color can never be invalid.
Memory saved per instance:
- StyleMultiColData: 4 bytes
- StyleBackgroundData: 8 bytes
- StyleInheritedData: 8 bytes
- StyleRareInheritedData: 24 bytes
- StyleRareNonInheritedData: 24 bytes
323kB progression on Membuster3.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
(WebCore::RenderStyle::setVisitedLinkColumnRuleColor):
(WebCore::RenderStyle::setBackgroundColor):
- rendering/style/RenderStyle.h:
- rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::StyleBackgroundData):
- rendering/style/StyleBackgroundData.h:
(WebCore::StyleBackgroundData::color):
(StyleBackgroundData):
- rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
- rendering/style/StyleInheritedData.h:
(StyleInheritedData):
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::setVisitedLinkColumnRuleColor):
- rendering/style/StyleMultiColData.h:
(StyleMultiColData):
(WebCore::StyleMultiColData::visitedLinkColumnRuleColor):
- rendering/style/StyleRareInheritedData.cpp:
(SameSizeAsStyleRareInheritedData):
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
(WebCore::StyleRareInheritedData::setTextStrokeColor):
(WebCore::StyleRareInheritedData::setTextFillColor):
(WebCore::StyleRareInheritedData::setTextEmphasisColor):
(WebCore::StyleRareInheritedData::setVisitedLinkTextStrokeColor):
(WebCore::StyleRareInheritedData::setVisitedLinkTextFillColor):
(WebCore::StyleRareInheritedData::setVisitedLinkTextEmphasisColor):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
(WebCore::StyleRareInheritedData::textStrokeColor):
(WebCore::StyleRareInheritedData::textFillColor):
(WebCore::StyleRareInheritedData::textEmphasisColor):
(WebCore::StyleRareInheritedData::visitedLinkTextStrokeColor):
(WebCore::StyleRareInheritedData::visitedLinkTextFillColor):
(WebCore::StyleRareInheritedData::visitedLinkTextEmphasisColor):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderLeftColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderRightColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderTopColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBorderBottomColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkOutlineColor):
(WebCore::StyleRareNonInheritedData::setVisitedLinkBackgroundColor):
- rendering/style/StyleRareNonInheritedData.h:
(WebCore::StyleRareNonInheritedData::visitedLinkBackgroundColor):
(WebCore::StyleRareNonInheritedData::visitedLinkOutlineColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderLeftColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderRightColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderTopColor):
(WebCore::StyleRareNonInheritedData::visitedLinkBorderBottomColor):
(StyleRareNonInheritedData):
- 6:34 AM Changeset in webkit [134223] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: migrate text editor to mutation observers
https://bugs.webkit.org/show_bug.cgi?id=101841
Reviewed by Vsevolod Vlasov.
Otherwise, we miss notifications on the removed lines.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._handleMutation):
- inspector/front-end/externs.js:
(WebKitMutation):
(WebKitMutationObserver.prototype.observe):
(WebKitMutationObserver.prototype.disconnect):
- 6:33 AM Changeset in webkit [134222] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Flash-plugin starts with wrong width
https://bugs.webkit.org/show_bug.cgi?id=101836
Patch by Allan Sandfeld Jensen <sandfeld@kde.org> on 2012-11-12
Reviewed by Simon Hausmann.
Defer the setWindow call, so that the one time it is called it will have its final size.
- plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
- 6:18 AM Changeset in webkit [134221] by
-
- 16 edits1 copy12 adds in trunk
Remove the V8 custom code for WebSockets constructor
https://bugs.webkit.org/show_bug.cgi?id=100801
Reviewed by Kentaro Hara.
Source/WebCore:
This patch does the following:
1) Modifies the V8 code generator to support overloaded constructors,
the JS generator is fixed to work as before. Proper support for JS will come later.
2) Modifies WebSocket.h/.cpp for the new constructors.
Tested by running WebSockets layout tests.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
(WebCore):
- Modules/websockets/WebSocket.h:
(WebSocket):
- Modules/websockets/WebSocket.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLParser.pm:
(copyAttributes):
(parseExtendedAttributeList):
(parseExtendedAttributes):
(applyExtendedAttributeList):
- bindings/scripts/IDLStructure.pm:
- bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp: Added.
(WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructorsPrivate::WebDOMTestOverloadedConstructorsPrivate):
(WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructorsPrivate):
(WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructors):
(WebDOMTestOverloadedConstructors::operator=):
(WebDOMTestOverloadedConstructors::impl):
(WebDOMTestOverloadedConstructors::~WebDOMTestOverloadedConstructors):
(toWebCore):
(toWebKit):
- bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.h: Added.
(WebCore):
(WebDOMTestOverloadedConstructors):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp: Added.
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestOverloadedConstructors):
(webkit_dom_test_overloaded_constructors_finalize):
(webkit_dom_test_overloaded_constructors_set_property):
(webkit_dom_test_overloaded_constructors_get_property):
(webkit_dom_test_overloaded_constructors_constructed):
(webkit_dom_test_overloaded_constructors_class_init):
(webkit_dom_test_overloaded_constructors_init):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h: Added.
(_WebKitDOMTestOverloadedConstructors):
(_WebKitDOMTestOverloadedConstructorsClass):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h: Added.
(WebKit):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Added.
(WebCore):
(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
(WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertySlot):
(WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
(WebCore::JSTestOverloadedConstructorsPrototype::self):
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::finishCreation):
(WebCore::JSTestOverloadedConstructors::createPrototype):
(WebCore::JSTestOverloadedConstructors::destroy):
(WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::getOwnPropertySlot):
(WebCore::JSTestOverloadedConstructors::getOwnPropertyDescriptor):
(WebCore::jsTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructors::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestOverloadedConstructorsOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestOverloadedConstructorsOwner::finalize):
(WebCore::toJS):
(WebCore::toTestOverloadedConstructors):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h: Added.
(WebCore):
(JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::create):
(WebCore::JSTestOverloadedConstructors::createStructure):
(WebCore::JSTestOverloadedConstructors::impl):
(WebCore::JSTestOverloadedConstructors::releaseImpl):
(WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull):
(JSTestOverloadedConstructorsOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestOverloadedConstructorsPrototype):
(WebCore::JSTestOverloadedConstructorsPrototype::create):
(WebCore::JSTestOverloadedConstructorsPrototype::createStructure):
(WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):
(JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h: Added.
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.mm: Added.
(-[DOMTestOverloadedConstructors dealloc]):
(-[DOMTestOverloadedConstructors finalize]):
(core):
(kit):
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h: Added.
(WebCore):
- bindings/scripts/test/TestOverloadedConstructors.idl: Copied from Source/WebCore/bindings/scripts/test/TestSerializedScriptValueInterface.idl.
- bindings/scripts/test/TestSerializedScriptValueInterface.idl:
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp: Added.
(WebCore):
(TestOverloadedConstructorsV8Internal):
(WebCore::TestOverloadedConstructorsV8Internal::V8_USE):
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetRawTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
(WebCore::V8TestOverloadedConstructors::wrapSlow):
(WebCore::V8TestOverloadedConstructors::derefObject):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h: Added.
(WebCore):
(V8TestOverloadedConstructors):
(WebCore::V8TestOverloadedConstructors::toNative):
(WebCore::V8TestOverloadedConstructors::installPerContextProperties):
(WebCore::V8TestOverloadedConstructors::installPerContextPrototypeProperties):
(WebCore::V8TestOverloadedConstructors::wrap):
(WebCore::toV8):
- bindings/v8/custom/V8WebSocketCustom.cpp:
LayoutTests:
Added test for null argument to WebSocket(url).
- http/tests/websocket/tests/hybi/url-parsing-expected.txt:
- http/tests/websocket/tests/hybi/url-parsing.html:
- platform/chromium-win/websocket/tests/url-parsing-expected.txt:
- platform/chromium/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
- platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
- 6:04 AM Changeset in webkit [134220] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Indentation nit on WebPage
https://bugs.webkit.org/show_bug.cgi?id=101928
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewportSize):
- 5:54 AM Changeset in webkit [134219] by
-
- 9 edits2 adds in trunk/Source/WebCore
[Refactoring] Create SelectRuleFeatureSet for collecting RuleFeatureSet for select attribute
https://bugs.webkit.org/show_bug.cgi?id=101891
Reviewed by Hajime Morita.
We would like to have another class for RuleFeatureSet to collect 'select' attribute features,
since it will have more features than the original RuleFeatureSet has.
Also, some methods of ElementShadow are removed and we provide a method to get SelectRuleFeatureSet itself.
No new tests, no change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ElementShadow.h:
(ElementShadow):
(WebCore::ElementShadow::selectRuleFeatureSet):
(WebCore):
- html/shadow/SelectRuleFeatureSet.cpp: Added.
(WebCore):
(WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet):
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
- html/shadow/SelectRuleFeatureSet.h: Added.
(WebCore):
(SelectRuleFeatureSet):
(WebCore::SelectRuleFeatureSet::hasSelectorForId):
(WebCore::SelectRuleFeatureSet::hasSelectorForClass):
(WebCore::SelectRuleFeatureSet::hasSelectorForAttribute):
- testing/Internals.cpp:
(WebCore::Internals::hasSelectorForIdInShadow):
(WebCore::Internals::hasSelectorForClassInShadow):
(WebCore::Internals::hasSelectorForAttributeInShadow):
- 5:52 AM Changeset in webkit [134218] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Chromium Android (caused by r134216)
Unreviewed.
No new tests.
- platform/text/PlatformLocale.cpp:
(WebCore::Locale::formatDateTime):
- 5:51 AM Changeset in webkit [134217] by
-
- 2 edits in trunk/Tools
Unreviewed. Removing myself from the list of address to CC on EWS
build failure; the CC turned out to just be too noisy so I'm
tracking those in a different way.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(GtkEWS):
- 5:23 AM Changeset in webkit [134216] by
-
- 4 edits in trunk/Source
Add support for week/month to Locale::formatDateTime()
https://bugs.webkit.org/show_bug.cgi?id=101878
Reviewed by Kent Tamura.
Source/WebCore:
Adding support for week/month to Locale::formatDateTime() in preparation for datalist support for <input type=week/month>.
Added Chromium tests LocaleMacTest.formatWeek and LocaleMacTest.formatMonth.
- platform/text/PlatformLocale.cpp:
(WebCore::DateTimeStringBuilder::visitField):
(WebCore::Locale::formatDateTime): Support week and month types.
Source/WebKit/chromium:
- tests/LocaleMacTest.cpp:
(LocaleMacTest::formatWeek): Takes ISO string and returns localized string.
(LocaleMacTest):
(LocaleMacTest::formatMonth): Ditto.
(TEST_F):
- 5:21 AM Changeset in webkit [134215] by
-
- 1 edit94 moves in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed gardening.
Fix my previous gardening commit: s/-actual.png/-expected.png
- platform/qt/css3/filters/effect-reference-ordering-hw-expected.png: Renamed from LayoutTests/platform/qt/css3/filters/effect-reference-ordering-hw-actual.png.
- platform/qt/fast/images/png-suite/test-expected.png: Renamed from LayoutTests/platform/qt/fast/images/png-suite/test-actual.png.
- platform/qt/svg/as-image/image-respects-pageScaleFactor-change-expected.png: Renamed from LayoutTests/platform/qt/svg/as-image/image-respects-pageScaleFactor-change-actual.png.
- platform/qt/svg/as-object/embedded-svg-size-changes-expected.png: Renamed from LayoutTests/platform/qt/svg/as-object/embedded-svg-size-changes-actual.png.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-expected.png: Renamed from LayoutTests/platform/qt/svg/as-object/nested-embedded-svg-size-changes-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-actual.png.
- platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-height-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-width-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-height-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-width-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-height-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-width-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTRefElement-dom-href-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-dx-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-dy-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-transform-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-x-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-dom-y-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-dom-href1-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-dom-href2-attr-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-actual.png.
- platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-actual.png.
- platform/qt/svg/filters/subRegion-one-effect-expected.png: Renamed from LayoutTests/platform/qt/svg/filters/subRegion-one-effect-actual.png.
- platform/qt/svg/filters/subRegion-two-effects-expected.png: Renamed from LayoutTests/platform/qt/svg/filters/subRegion-two-effects-actual.png.
- 5:11 AM Changeset in webkit [134214] by
-
- 4 edits in trunk
[Qt] Can not load MHTML documents
https://bugs.webkit.org/show_bug.cgi?id=101765
Reviewed by Simon Hausmann.
Source/WebCore:
Recognize common MHTML extensions so that we can recognize MHTML tests on the file-system.
Tested by existing mhtml/ tests.
- platform/qt/MIMETypeRegistryQt.cpp:
(WebCore):
Tools:
Enable MHTML feature.
- qmake/mkspecs/features/features.pri:
- 4:45 AM Changeset in webkit [134213] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a new crashing test.
- platform/qt/TestExpectations:
- 4:39 AM Changeset in webkit [134212] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: Timeline: fix test expectations
https://bugs.webkit.org/show_bug.cgi?id=101737
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-12
Reviewed by Yury Semikhatsky.
The expected order of timeline records of specific types
have been changed: https://bugs.webkit.org/show_bug.cgi?id=101544
This change fixes test expectations.
Also removed expectation that test can fail.
- inspector/timeline/timeline-receive-response-event-expected.txt:
- platform/chromium/TestExpectations: Removed "fail" expectation.
- 4:34 AM Changeset in webkit [134211] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening after 134099 and 134100. Skipped two tests because layoutTestController
needs implementation of setBackingScaleFactor().
Patch by János Badics <János Badics> on 2012-11-12
Reviewed by Csaba Osztrogonác.
- platform/qt/TestExpectations:
- 4:34 AM Changeset in webkit [134210] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add ewk_settings_offline_web_application_cache_enabled set/get APIs
https://bugs.webkit.org/show_bug.cgi?id=101688
Patch by Jiyeon Kim <jiyeon0402.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
Add ewk_settings_offline_web_application_cache_get API to be used for enabling disabling the web application cache.
Add ewk_settings_offline_web_application_cache_set API to be used for getting the web application cache status.
In addition, offline web application cache is enabled by default.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_offline_web_application_cache_enabled_set):
(ewk_settings_offline_web_application_cache_enabled_get):
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- 4:31 AM Changeset in webkit [134209] by
-
- 3 edits13 adds in trunk/LayoutTests
Add tests for month picker
https://bugs.webkit.org/show_bug.cgi?id=101556
Reviewed by Kent Tamura.
Adding tests for month picker.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: Added.
- platform/chromium/TestExpectations: Marking appearance tests as needs rebaseline.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-appearance.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html: Added.
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(selectedMonth): Returns ISO string for selected month.
- 4:31 AM Changeset in webkit [134208] by
-
- 2 edits in trunk/Source/WebCore
Tighten vector in ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray().
<http://webkit.org/b/101850>
Patch by Andreas Kling <akling@apple.com> on 2012-11-12
Reviewed by Antti Koivisto.
Reserve the exact amount of space needed for m_responseContentDispositionEncodingFallbackArray.
222kB progression on Membuster3.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
- 4:24 AM Changeset in webkit [134207] by
-
- 11 edits in trunk
MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
https://bugs.webkit.org/show_bug.cgi?id=101751
Reviewed by Adam Barth.
Source/Platform:
Making some WebRTCDataChannel methods const.
- chromium/public/WebRTCDataChannel.h:
(WebRTCDataChannel):
Source/WebCore:
This patch queues the events until the JS interpreter is in an idle state.
Existing tests cover this patch.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::readyStateChanged):
(WebCore::RTCDataChannel::dataArrived):
(WebCore::RTCDataChannel::error):
(WebCore::RTCDataChannel::scheduleDispatchEvent):
(WebCore):
(WebCore::RTCDataChannel::scheduledEventTimerFired):
- Modules/mediastream/RTCDataChannel.h:
(RTCDataChannel):
- platform/chromium/support/WebRTCDataChannel.cpp:
(WebKit::WebRTCDataChannel::setBufferedAmount):
(WebKit::WebRTCDataChannel::readyStateChanged):
(WebKit::WebRTCDataChannel::dataArrived):
(WebKit::WebRTCDataChannel::error):
Tools:
Makes the data channel mocks to be synchronous instead of asynchronous to be able to
properly test RTCDataChannel event handling.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::sendStringData):
(MockWebRTCPeerConnectionHandler::sendRawData):
LayoutTests:
Adding shouldNotTrow to the send() calls.
- fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- 4:21 AM Changeset in webkit [134206] by
-
- 5 edits in trunk/Source/WebCore
Remove HTMLInputElement dependency from PickerIndicatorElement
https://bugs.webkit.org/show_bug.cgi?id=101913
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-12
Reviewed by Kent Tamura.
Introduced PickerIndicatorOwner interface that replaces the role of hostInput() in
PickerIndicatorElement. It makes easier to add interactions between picker indicator
and its owner without having to add functions to HTMLInputElement.
No new tests. This is just a refactor.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isPickerIndicatorOwnerDisabledOrReadOnly): Added.
(WebCore):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue): Added.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setupDateTimeChooserParameters): Added.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(WebCore):
(BaseMultipleFieldsDateAndTimeInputType): Implements PickerIndicatorOwner.
- html/shadow/PickerIndicatorElement.cpp: Replaced all the use of hostInput() by using PickerIndicatorOwner.
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
(WebCore::PickerIndicatorElement::create):
(WebCore::PickerIndicatorElement::defaultEventHandler):
(WebCore::PickerIndicatorElement::willRespondToMouseClickEvents):
(WebCore::PickerIndicatorElement::didChooseValue):
(WebCore::PickerIndicatorElement::openPopup):
- html/shadow/PickerIndicatorElement.h:
(PickerIndicatorElement): Added a PickerIndicatorOwner member.
(PickerIndicatorOwner): An interface class for communicating picker indicator and its owner.
(WebCore::PickerIndicatorElement::PickerIndicatorOwner::~PickerIndicatorOwner):
(WebCore::PickerIndicatorElement::removePickerIndicatorOwner):
- 4:08 AM Changeset in webkit [134205] by
-
- 8 edits2 adds in trunk
[CSSRegions]Add support for text-shadow in region styling
https://bugs.webkit.org/show_bug.cgi?id=94472
Reviewed by David Hyatt.
Source/WebCore:
Original patch by Andrei Onea.
Add support for text-shadow in region styling (@-webkit-region rule).
In addition to the previously supported region styling properties (background-color and color),
text-shadow requires the computation of an element style in region at layout time.
This patch adds a new method on RenderRegion - ensureRegionStyleForObject - that
can be used to retrieve the object style in region (if already cached) or to compute it
on the spot. When computing the object style in region, we need to compute the style in region
also for the object ancestor, up to the content nodes.
This patch also refactors the way styles in region are computed and stored, because
we can compute the style in region not only at paint time, but also at layout time.
Test: fast/regions/region-style-text-shadow.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::isValidRegionStyleProperty):
Allow text-shadow to be used in region styling.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::styleInRegion):
Retrieve the region style for an InlineBox's renderer, given its RenderRegion.
Compute the style in region if not computed yet.
(WebCore::InlineBox::regionDuringLayout):
Retrieve the region in which an InlineBox is being flowed.
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: Take region styling into account.
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::canCacheObjectStyleInRegion):
Test if we can cache the computed style in region.
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::setChildrenStyleInRegion):
(WebCore::setObjectHasBoxDecorationsFlag):
(WebCore::RenderRegion::setObjectStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
(WebCore::RenderRegion::ensureRegionStyleForObject):
- rendering/RenderRegion.h:
LayoutTests:
Original patch by Andrei Onea.
Added tests for region styling using the text-shadow property.
- fast/regions/region-style-text-shadow-expected.html: Added.
- fast/regions/region-style-text-shadow.html: Added.
- 3:51 AM Changeset in webkit [134204] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r134154.
http://trac.webkit.org/changeset/134154
https://bugs.webkit.org/show_bug.cgi?id=101919
Causes plenty of crashes on GTK and Apple Win builders
(Requested by zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-12
- css/mediaControls.css:
- css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
- html/shadow/MediaControlElements.h:
(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
- html/shadow/MediaControlRootElement.h:
(WebCore):
(MediaControlRootElement):
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::initializeControls):
- html/shadow/MediaControls.h:
(MediaControls):
- platform/Language.cpp:
(WebCore):
- platform/Language.h:
(WebCore):
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- 3:42 AM Changeset in webkit [134203] by
-
- 19 edits in trunk/Tools
[chromium] move TestRunner implementation into WebTestRunner namespace
https://bugs.webkit.org/show_bug.cgi?id=101837
Reviewed by Adam Barth.
That way, we don't get collisions when linking e.g. against chromium's
net test support library.
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(WebTestRunner):
(TestDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.h:
(WebTestRunner):
- 3:23 AM Changeset in webkit [134202] by
-
- 2 edits in trunk/Source/WebCore
'for (x in y)' requires 'var' declaration in ConsoleMessage.js
https://bugs.webkit.org/show_bug.cgi?id=101908
Reviewed by Pavel Feldman.
r134166 should have included a 'var' declaration in its 'for (x in y)'
loop. This patch adds the missing 'var' in order to prevent leakage into
the global context.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
- 3:20 AM Changeset in webkit [134201] by
-
- 2 edits in trunk
[EFL] Turn on error on warnings for "switch"
https://bugs.webkit.org/show_bug.cgi?id=101760
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-12
Reviewed by Gyuyoung Kim.
Turn on error on warning for "switch" by removing "-Wno-error=switch"
- Source/cmake/WebKitHelpers.cmake:
- 3:07 AM Changeset in webkit [134200] by
-
- 6 edits in trunk
[Qt] MiniBrowser should not strongly depend on QtTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=101775
Introducing HAVE(QTTESTSUPPORT) to allow building
MiniBrowser without QtTestSupport.
This is necessary when using a production build.
Reviewed by Tor Arne Vestbø.
Source/WebCore:
- Target.pri:
- platform/qt/QtTestSupport.h:
Tools:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
- qmake/mkspecs/features/configure.prf:
- qmake/mkspecs/features/features.prf:
- 2:13 AM Changeset in webkit [134199] by
-
- 5 edits in trunk
Web Inspector: wasShown is called twice when show() is called from within wasShown
https://bugs.webkit.org/show_bug.cgi?id=101858
Reviewed by Vsevolod Vlasov.
Source/WebCore:
When we attach views lazily from within wasShown, the views were getting wasShown notification twice.
We now mute one of them.
- inspector/front-end/View.js:
(WebInspector.View):
(WebInspector.View.prototype._inNotification):
(WebInspector.View.prototype._parentIsShowing):
(WebInspector.View.prototype._callOnVisibleChildren):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processWillHide):
(WebInspector.View.prototype._processOnResize):
(WebInspector.View.prototype._notify):
(WebInspector.View.prototype.show):
LayoutTests:
- inspector/view-events-expected.txt:
- inspector/view-events.html:
- 1:34 AM Changeset in webkit [134198] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, disable the test on Mac/Chromium until we figure out the cause of failure.
- 1:30 AM Changeset in webkit [134197] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r134191. Turns out that FrameView::performPostLayoutTasks calls FrameSelection::updateAppearance
in the middle of a layout. So we can't have assertions in recomputeCaretRect and updateAppearance.
Furthermore, we can't update layout in updateAppearance. So do that in its call sites.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::setCaretVisibility):
- 1:15 AM Changeset in webkit [134196] by
-
- 4 edits2 adds in trunk
Don't update style when attaching in HTMLMeterElement
https://bugs.webkit.org/show_bug.cgi?id=101714
Reviewed by Hajime Morita.
Source/WebCore:
HTMLMeterElement was updating style when it's being attached. However, updating style when attaching
can cause style-update prevention. The similar thing has already happened in Bug 100507.
Since we have already set the default value in creating ShadowDOM subtree, we don't need to update style actually.
Test: fast/dom/HTMLMeterElement/meter-bar-set-value.html
- html/HTMLMeterElement.cpp:
- html/HTMLMeterElement.h:
(HTMLMeterElement): Removed attach(). We don't need it.
LayoutTests:
- fast/dom/HTMLMeterElement/meter-bar-set-value-expected.html: Added.
- fast/dom/HTMLMeterElement/meter-bar-set-value.html: Added.
- 12:37 AM Changeset in webkit [134195] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorWorkerAgent.cpp
Merge 133569 - Web Inspector: JavaScript web workers debugging crashes
https://bugs.webkit.org/show_bug.cgi?id=101065
Reviewed by Alexander Pavlov.
Source/WebCore:
Clear m_pageInspector when page inspector instance is deleted.
Disable worker inspection when front-end disconnects.
Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify
WorkerMessagingProxy so that it can clear pointer to the channel.
LayoutTests:
Test that inspected page won't crash if inspected worker is terminated when it is paused
on a breakpoint.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added.
- inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11361213
- 12:13 AM Changeset in webkit [134194] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/inspector/WorkerInspectorController.cpp
Merge 133030 - Web Inspector: page crash when pausing in dedicated worker
https://bugs.webkit.org/show_bug.cgi?id=100837
Reviewed by Pavel Feldman.
Source/WebCore:
Pass debugger agent to InjectedScriptHost::init in case of workers.
Test: inspector-protocol/debugger-pause-dedicated-worker.html
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
LayoutTests:
Test that Debugger.pause works for dedicated workers. The test is skipped
on all platforms that use JSC as worker debugging is not supported there
yet.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(WebInspector.dispatchMessageFromBackend):
- inspector-protocol/debugger-pause-dedicated-worker-expected.txt: Added.
- inspector-protocol/debugger-pause-dedicated-worker.html: Added.
- inspector-protocol/resources/dedicated-worker.js: Added.
(onmessage):
(doWork):
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/11410030
