Timeline
Nov 25, 2012:
- 11:54 PM Changeset in webkit [135686] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Unskip the fixed regressions from r135662
- platform/efl-wk1/TestExpectations:
- 11:50 PM Changeset in webkit [135685] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r135656.
http://trac.webkit.org/changeset/135656
https://bugs.webkit.org/show_bug.cgi?id=103218
Made a few SVG tests crash on all platforms (Requested by
apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-25
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
- 11:45 PM Changeset in webkit [135684] by
-
- 3 edits2 adds in trunk
WebCore::RenderBlock::determineStartPosition crash
https://bugs.webkit.org/show_bug.cgi?id=98993
Reviewed by Brent Fulgham.
Source/WebCore:
If we move some node and the node has some text,
InlineFlowBox::removeChild() is invoked. The method invokes
RootInlineBox::childRemoved(). childRemoved() checks whether the
removed inlinebox has the renderer of its parent's line break object.
If so, use setLineBreakInfo to make the parent's line break info to
be 0. However in RenderBlock::determineStartPosition(), the code
assume that all line break info is solved, i.e.
prevRootBox->lineBreakObj()->isText(). Since lineBreakObj() returns 0
because of removeChild(), determineStartPosition crash occurs.
Test: fast/inline/inline-box-append-child-crash.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
Checks whether lineBreakObj() is 0 or not before using lineBreakObj().
LayoutTests:
- fast/inline/inline-box-append-child-crash-expected.txt: Added.
- fast/inline/inline-box-append-child-crash.html: Added.
- 10:35 PM Changeset in webkit [135683] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: use native Element.prototype.normalize instead of custom defined Element.prototype.pruneEmptyTextNodes
https://bugs.webkit.org/show_bug.cgi?id=103205
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.
- inspector/front-end/DOMExtension.js:
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
- 10:33 PM Changeset in webkit [135682] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: remove unused DOM methods
https://bugs.webkit.org/show_bug.cgi?id=103204
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.
- inspector/front-end/DOMExtension.js:
- 10:15 PM Changeset in webkit [135681] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove unused Array.convert method
https://bugs.webkit.org/show_bug.cgi?id=103202
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Daniel Bates.
- inspector/front-end/utilities.js:
- 10:07 PM Changeset in webkit [135680] by
-
- 3 edits2 adds in trunk
AX: file upload input cannot be activated with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=100343
Reviewed by Sam Weinig.
Source/WebCore:
Simulated events were not allowed to be processed in the file input type in the DOMActivate handler.
This was a problem for accessibility clients which rely on simulated events.
The solution is to mark the UserGestureIndicator as definitely processing an event.
Test: accessibility/file-upload-button-with-axpress.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
LayoutTests:
- accessibility/file-upload-button-with-axpress-expected.txt: Added.
- accessibility/file-upload-button-with-axpress.html: Added.
- 9:58 PM Changeset in webkit [135679] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: dispatch an event upon heap snapshot filter change
https://bugs.webkit.org/show_bug.cgi?id=103201
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.
Dispatch heapSnapshotFilterChanged event so it can be received by third parties.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeFilter):
- inspector/front-end/UserMetrics.js:
- 9:12 PM Changeset in webkit [135678] by
-
- 3 edits in trunk/Source/WebKit/gtk
Remove deprecated load-done signal
https://bugs.webkit.org/show_bug.cgi?id=72712
Reviewed by Brent Fulgham.
Remove deprecated load-done signal and migrate to load-status.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit):
(WebKit::FrameLoaderClient::dispatchDidFinishLoad):
- webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
- 5:54 PM Changeset in webkit [135677] by
-
- 19 edits in trunk/LayoutTests
2012-11-25 Kent Tamura <tkent@chromium.org>
[Chromium] Fix svn:mime-type for images
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png: Added property svn:mime-type.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png: Added property svn:mime-type.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png: Added property svn:mime-type.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png: Added property svn:mime-type.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png: Added property svn:mime-type.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png: Added property svn:mime-type.
- platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/fast/text/drawBidiText-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/fast/text/international/001-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/fast/text/international/002-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/fast/text/international/wrap-CJK-001-expected.png: Modified property svn:mime-type.
- platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Modified property svn:mime-type.
- 5:00 PM Changeset in webkit [135676] by
-
- 2 edits40 adds in trunk/LayoutTests
[Chromium] Add tests for datetime/datetime-local suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=102888
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-25
Reviewed by Kent Tamura.
Adding tests for <input type=datetime> and <input type=datetime-local> with datalist.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations-expected.txt: Added.
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute-expected.txt: Added.
- platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute.html: Added.
- 4:38 PM Changeset in webkit [135675] by
-
- 9 edits in trunk/Source/WebCore
Refactoring: Move the content of HTMLInputElement::subtreeHasChanged to TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=103195
Reviewed by Kentaro Hara.
HTMLInputElement::subtreeHasChanged is called only if the input is
a text field. The code should be moved to TextFieldInputType.
No new tests. This should not change any behavior.
- html/HTMLInputElement.cpp:
- Remove unnecessary NumberInputType.h inclusion.
- Remove convertFromVisibleValue. It was used only by subtreeHasChanged.
(WebCore::HTMLInputElement::subtreeHasChanged):
Move the code to TextFieldInputType::subtreeHasChanged except
calculateAndAdjustDirectionality, which is a protected member of
HTMLElement.
- html/HTMLInputElement.h:
(HTMLInputElement): Remove convertFromVisibleValue.
- html/InputType.cpp:
Move convertFromVisibleValue to TextFieldInputType.
(WebCore::InputType::subtreeHasChanged):
Add ASSERT_NOT_REACHED.
- html/InputType.h:
(InputType): Remove convertFromVisibleValue.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::convertFromVisibleValue):
Moved from InputType.
(WebCore::TextFieldInputType::subtreeHasChanged):
Moved from HTMLInputElement. A latter part is moved to
didSetValueByUserEdit to be hooked by SearchInputType.
(WebCore::TextFieldInputType::didSetValueByUserEdit):
Moved from HTMLInputElement::subtreeHasChanged, and clean up the code.
- html/TextFieldInputType.h:
(TextFieldInputType):
- Move convertFromVisibleValue from InputType.
- Add didSetValueByUserEdit and subtreeHasChanged.
- html/SearchInputType.cpp:
(WebCore::SearchInputType::didSetValueByUserEdit):
Renamed from subtreeHasChanged, and calls TextFieldInputType::didSetValueByUserEdit.
- html/SearchInputType.h:
(SearchInputType): Rename subtreeHasChanged to didSetValueByUserEdit.
- 4:21 PM Changeset in webkit [135674] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=103061
Reviewed by Adam Barth.
This is an incremental step to remove WorkerExecutionContextProxy.
This patch moves WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer.
This patch also renames methods so that the names become consistent
between the main thread and workers.
No tests. No change in behavior.
- bindings/v8/V8Initializer.cpp:
(WebCore::reportFatalErrorInMainThread):
(WebCore::messageHandlerInMainThread):
(WebCore::failedAccessCheckCallbackInMainThread):
(WebCore::V8Initializer::initializeMainThreadIfNeeded):
(WebCore::reportFatalErrorInWorker):
(WebCore):
(WebCore::messageHandlerInWorker):
(WebCore::V8Initializer::initializeWorkerIfNeeded):
- bindings/v8/V8Initializer.h:
(V8Initializer):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
- bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):
- 11:19 AM Changeset in webkit [135673] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
https://bugs.webkit.org/show_bug.cgi?id=103189
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-25
Reviewed by Kenneth Rohde Christiansen.
Check if the entry size and type changed in
RenderThemeEfl::ThemePartCacheEntry::reuse() to avoid
useless processing if one of them did not change.
Remove useless call to cairo_surface_finish() since
we are using a smart pointer for the surface.
Resize the edge object *after* loading its content
from the theme file as it seems more logical this
way.
No new tests, no behavior change for layout tests.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
- platform/efl/RenderThemeEfl.h:
(ThemePartCacheEntry):
- 11:06 AM Changeset in webkit [135672] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Get rid of resetBitmapZoomScale()
https://bugs.webkit.org/show_bug.cgi?id=103200
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Gen Mak.
PR: 235707
Right now, resetBitmapZoomScale() takes an unused paramter and
dispatches a message to end the bitmap zooming. However, the
interaction has its own state machine to start bitmap zooming when it
is active and end bitmap zooming when it is inactive. This is
expecially for pinch zoom and scroll. From WebKit side, block zoom
which will call zoomBlock when the bitmap zoom finished doesn't even
need to dispatch the useless ending message to ZoomHandler.
resetBitmapZoomScale() is basically a noop for block zoom. And likewise
that is useless for zoomToInitialScaleOnLoad(). It can also potentially
cause problem if it is used somewhere else in the future and
incidentally breaks the interaction's own state machine. So just remove
this completely.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- Api/WebPageClient.h:
- 10:51 AM Changeset in webkit [135671] by
-
- 34 edits2 moves in trunk/Source/WebCore
Rename DynamicNodeList to LiveNodeList
https://bugs.webkit.org/show_bug.cgi?id=103197
Reviewed by Ojan Vafai.
Rename DynamicNodeList to LiveNodeList to match the terminology used in DOM4 working draft:
http://www.w3.org/TR/2012/WD-dom-20120405/#concept-collection-live
"A collection (either NodeList or HTMLCollection) can be either live or static".
Also rename DynamicNodeListCacheBase to LiveNodeListBase, and merge DynamicSubtreeNodeList
into LiveNodeList (old DynamicNodeList) now that the only difference between those two classes
is the former calling registerNodeListCache and unregisterNodeListCache on Document.
This patch completes the series of simplification of NodeList/HTMLCollection classes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):
- dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::nodeMatches):
- dom/ChildNodeList.h:
- dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::ClassNodeList):
- dom/ClassNodeList.h:
- dom/DOMAllInOne.cpp:
- dom/Document.cpp:
(WebCore::Document::registerNodeListCache):
(WebCore::Document::unregisterNodeListCache):
(WebCore):
- dom/Document.h:
(WebCore):
(Document):
- dom/DynamicNodeList.cpp: Removed.
- dom/DynamicNodeList.h: Removed.
- dom/LiveNodeList.cpp: Copied from Source/WebCore/dom/DynamicNodeList.cpp.
(WebCore::LiveNodeListBase::rootNode):
(WebCore::LiveNodeListBase::invalidateCache):
(WebCore::LiveNodeListBase::invalidateIdNameCacheMaps):
(WebCore::LiveNodeListBase::reportMemoryUsage):
(WebCore::LiveNodeList::namedItem):
- dom/LiveNodeList.h: Copied from Source/WebCore/dom/DynamicNodeList.h.
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::shouldInvalidateTypeOnAttributeChange):
(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
(LiveNodeList):
- dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::MicroDataItemList):
- dom/MicroDataItemList.h:
- dom/NameNodeList.cpp:
(WebCore::NameNodeList::NameNodeList):
- dom/NameNodeList.h:
- dom/Node.cpp:
(WebCore::shouldInvalidateNodeListCachesForAttr):
(WebCore::Document::invalidateNodeListCaches):
- dom/Node.h:
(WebCore):
- dom/NodeList.h:
(WebCore::NodeList::isLiveNodeList):
- dom/NodeRareData.h:
(NodeListsNodeData):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::removeCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):
- dom/PropertyNodeList.cpp:
(WebCore::PropertyNodeList::PropertyNodeList):
- dom/PropertyNodeList.h:
- dom/TagNodeList.cpp:
(WebCore::TagNodeList::TagNodeList):
- dom/TagNodeList.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::LiveNodeListBase::iterateForNextNode):
(WebCore::LiveNodeListBase::itemBeforeOrAfter):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::itemAfter):
(WebCore::LiveNodeListBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeListBase::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeListBase::setItemCache):
(WebCore::LiveNodeListBase::length):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):
- html/HTMLCollection.h:
- html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::LabelsNodeList):
- html/LabelsNodeList.h:
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
- html/RadioNodeList.h:
- 10:35 AM Changeset in webkit [135670] by
-
- 4 edits2 adds in trunk
Changing position:relative to position:static results in mis-positioned div
https://bugs.webkit.org/show_bug.cgi?id=26397
Reviewed by Ojan Vafai.
Source/WebCore:
When a block changes position from relative to static it is no longer the containing block for any
positioned objects it may have. If any of those positioned objects actually have a position specified
they are going to need a layout as their new containing block will likely have a different location they
need to offset from. Positioned objects without a specified position always get a layout anyway
in layoutPositionedObjects() so no need to worry about them in this situation.
Test: fast/block/abspos-child-container-changes-from-relative-to-static-expected.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::removePositionedObjects):
- rendering/RenderBlock.h:
(RenderBlock):
LayoutTests:
- fast/block/abspos-child-container-changes-from-relative-to-static-expected.html: Added
- fast/block/abspos-child-container-changes-from-relative-to-static.html: Added
- 10:30 AM Changeset in webkit [135669] by
-
- 4 edits4 adds in trunk
[WK2] TiledBackingStore: page contents is scaled wrongly
https://bugs.webkit.org/show_bug.cgi?id=103090
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-25
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Before this change the page contents scaling in PageViewportController was
defined all the times by m_rawAttributes.initialScale. If initial scale had not
been specified in the viewport meta tag it was set to m_minimumScaleToFit inside
PageViewportController::didChangeViewportAttributes().
The problem was that m_minimumScaleToFit could have wrong value as contents size
might have not be updated by the time PageViewportController::didChangeViewportAttributes()
was invoked.
The solution is to use m_minimumScaleToFit for contents scaling if initial scale
is not specified in the viewport meta tag, as it is updated all the time.
Also a flag m_initiallyFitToViewport is added to PageViewportController to detect
whether m_minimumScaleToFit should be used for scaling.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeViewportAttributes):
- UIProcess/PageViewportController.h:
(PageViewportController):
LayoutTests:
Added new layout test to verify that viewport 'width' descriptor does not
affect contents width of next loaded page.
- css3/device-adapt/resources/check-contents-width.html: Added.
- css3/device-adapt/viewport-width-not-affecting-next-page-expected.txt: Added.
- css3/device-adapt/viewport-width-not-affecting-next-page.html: Added.
- 8:53 AM Changeset in webkit [135668] by
-
- 13 edits in trunk/Source/WebCore
Make renderer construction less generic
https://bugs.webkit.org/show_bug.cgi?id=103175
Reviewed by Ojan Vafai.
The renderer construction code currently operates on Nodes and is very generic. In reality
only Element and Text nodes can have renderers and the Text case is much simpler.
This patch separates the Text and Element renderer construction paths and makes it statically
known that other Node types can't have renderers. Less generic code is less branchy and enables
further optimizations.
- dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore):
(WebCore::CharacterData::rendererIsNeeded):
(WebCore::CharacterData::createRenderer):
Only Text subclass of CharacterData can have renderers.
- dom/CharacterData.h:
(CharacterData):
- dom/ContainerNode.h:
(WebCore::ContainerNode::childShouldCreateRenderer):
Move childShouldCreateRenderer from Node to ContainerNode.
(ContainerNode):
- dom/Element.cpp:
(WebCore::Element::rendererIsNeeded):
(WebCore):
(WebCore::Element::attach):
(WebCore::Element::childShouldCreateRenderer):
- dom/Element.h:
Move rendererIsNeeded and createRenderer from Node to Element.
(Element):
- dom/Node.cpp:
(WebCore::Node::attach):
(WebCore):
- dom/Node.h:
(Node):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):
Separate the Element and Text renderer creation paths. Both are less branchy.
The Text path is much simpler and avoids a bunch of virtual calls.
(WebCore):
- dom/NodeRenderingContext.h:
(NodeRenderingContext):
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::createTextRendererIfNeeded):
(WebCore):
(WebCore::Text::createTextRenderer):
(WebCore::Text::attach):
(WebCore::Text::updateTextRenderer):
- dom/Text.h:
Add non-virtual Text specific functions.
(WebCore):
(Text):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
- 12:01 AM Changeset in webkit [135667] by
-
- 15 edits in trunk/Source/WebCore
REGRESSION(r135493): HTMLCollection and DynamicNodeList have two vtable pointers
https://bugs.webkit.org/show_bug.cgi?id=103096
Reviewed by Sam Weinig.
Co-authored by Ilya Tikhonovsky.
Made DynamicNodeListCacheBase inherit from NodeList. While HTMLCollection doesn't inherit
from NodeList in IDL, it makes a lot of sense for the C++ implementation to do so via
DynamicNodeListCacheBase since HTMLCollection and live NodeList share a lot of code in
DynamicNodeListCacheBase.
This lets remove proxies for item() and length() in DynamicNodeList and HTMLCollection
and directly implement them in DynamicNodeListCacheBase which used to provide itemCommon()
and lengthCommon().
Also renamed NodeList::itemWithName() to NodeList::namedItem() to match HTMLCollection's
naming convention.
Finally, removed reportMemoryUsage in DynamicNodeList::reportMemoryUsage since DynamicNodeList
now uses single inheritance.
- bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::canGetItemsForName): Calls namedItem, which has been renamed from
itemWithName.
(WebCore::JSNodeList::nameGetter): Ditto.
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter): Ditto.
- bindings/v8/custom/V8NamedNodesCollection.cpp:
(WebCore::V8NamedNodesCollection::namedItem): Renamed from itemWithName.
- bindings/v8/custom/V8NamedNodesCollection.h:
- dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::nodeMatches): Updated comment.
- dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::namedItem): Renamed from itemWithName.
- dom/DynamicNodeList.h:
(DynamicNodeListCacheBase): Inhertis from NodeList and renamed lengthCommon and itemCommon
to virtual length and item respectively.
(DynamicNodeList): Now inherits from just DynamicNodeListCacheBase instead of NodeList
and DynamicNodeListCacheBase since the former now inhertis from NodeList. Also removed
length() and item() since they're implemented in DynamicNodeListCacheBase now and renamed
itemWithName() to namedItem() to match HTMLCollection's naming convention.
- dom/NodeList.h:
(NodeList::namedItem): Renamed from itemWithName. Note that this member function is not
exposed via IDL. It's merely used in the binding code.
- dom/StaticHashSetNodeList.cpp:
(WebCore::StaticHashSetNodeList::namedItem): Ditto.
- dom/StaticHashSetNodeList.h:
(StaticHashSetNodeList::namedItem): Ditto.
- dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::namedItem): Ditto.
- dom/StaticNodeList.h:
(StaticNodeList::namedItem): Ditto.
- html/HTMLCollection.cpp:
(WebCore::DynamicNodeListCacheBase::length): Renamed from lengthCommon.
(WebCore::DynamicNodeListCacheBase::item): Renamed from itemCommon.
- html/HTMLCollection.h:
(HTMLCollection): Inherits from DynamicNodeListCacheBase since DynamicNodeListCacheBase
is already RefCount'ed and NodeList, from which DynamicNodeListCacheBase inherits,
inherits from ScriptWrappable.
Nov 24, 2012:
- 11:25 PM Changeset in webkit [135666] by
-
- 3 edits in trunk/Source/WTF
Chromium should use TCMalloc on Mac to go fast
https://bugs.webkit.org/show_bug.cgi?id=102866
Reviewed by Eric Seidel.
This patch enables TCMalloc for some WebKit objects. It improves
dom-modify on Mac by 5-10%.
On non-Mac platforms, Chromium already uses TCMalloc throughout the
project. Unfortunately, we haven't yet figured out how to turn TCMalloc
on globally on Mac because the approach we use for other platforms makes
some OS X APIs sad.
The next best thing would be to enable TCMalloc for WebKit by
overriding the global new and delete operator, as is done on apple-mac
and other platforms. Unfortunately, we cannot use that approach either
because the Chromium WebKit API is not memory tight.
Fortunately, WebKit has a mechanism for selectively enabling TCMalloc
for a selection of objects by overriding the new and delete operators
on those objects. This patch opts chromium-mac into that scheme by
setting the appropriate preprocessor macros.
- WTF.gyp/WTF.gyp:
- wtf/Platform.h:
- 8:49 PM Changeset in webkit [135665] by
-
- 2 edits in trunk/Websites/webkit.org
Substitute "use" for "user" in sentence about naming convention for
enum members so that it reads well.
- coding/coding-style.html:
- 8:13 PM Changeset in webkit [135664] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Find-on-page keeps stale pointer
https://bugs.webkit.org/show_bug.cgi?id=103190
Patch by Andy Chen <andchen@rim.com> on 2012-11-24
Reviewed by Rob Buis.
Find on page: pendingScopingEffort stores stale pointer when frames unload,
we need to cancel those scoping efforts.
PR 250807.
Internally reviewed by Yongxin Dai and Mike Fenton.
- WebKitSupport/InPageSearchManager.cpp:
(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
- 6:52 PM Changeset in webkit [135663] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Refactor RenderThemeEfl::paintThemePart()
https://bugs.webkit.org/show_bug.cgi?id=103192
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Refactor RenderThemeEfl::paintThemePart() so that:
- Some C'ism is removed
- RTL related code is moved to applyEdjeRTLState()
- evas_render() is called instead of evas_render_updates() to avoid creating uselessly update rects.
No new tests, no behavior change for layout tests.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeRTLState):
(WebCore):
(WebCore::RenderThemeEfl::paintThemePart):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
- 6:38 PM Changeset in webkit [135662] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Layout test comes to crash on WK1
https://bugs.webkit.org/show_bug.cgi?id=103170
Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Switch off accelerated compositing for WK1 because GraphicsContext3D is
missing direct rendering implementation that is required for EFL WK1.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 6:22 PM Changeset in webkit [135661] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove traces of MediaControlRootElement
https://bugs.webkit.org/show_bug.cgi?id=103174
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-11-24
Reviewed by Adam Barth.
Now that nothing is using MediaControlRootElement any more,
we can remove the FIXME and MediaControlRootElement enum left
over from bug 88871.
- public/WebContextMenuData.h:
- 6:18 PM Changeset in webkit [135660] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
https://bugs.webkit.org/show_bug.cgi?id=103187
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Now the client should pass to DECLARE_EWK_VIEW_CALLBACK macro exacly the
same arg type s/he wants to have in the Ewk_View callback.
- UIProcess/API/efl/EwkViewCallbacks.h:
(EvasObjectHolder):
(EwkViewCallbacks::EvasObjectHolder::EvasObjectHolder):
(EwkViewCallbacks):
- 3:05 PM Changeset in webkit [135659] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Avoid access violation when frame is NULL.
https://bugs.webkit.org/show_bug.cgi?id=68753
BitmapImage::drawFrameMatchingSourceSize causes an access violation
if BitmapImage::frameAtIndex returns NULL. (Found by David Delaune).
Reviewed by Simon Fraser.
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Check for null
cairo_surface_t pointer and avoid dereferencing.
- 2:25 PM Changeset in webkit [135658] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Refactor RenderThemeEfl::getThemePartFromCache()
https://bugs.webkit.org/show_bug.cgi?id=103186
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Refactor getThemePartFromCache() so that a list is used
for the cache instead of a vector. The function moves
items to the head of the container which is much more
efficient with a list than a vector.
The list ordering is also slightly altered so that the
cached parts that were used last come first. Previously,
they were sorted by creation time which may cause an
item to be removed from the cache because it is older
even if is was used recently.
This patch also gets rid of some code duplication at the
end of the function.
No new tests, no behavior change.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create): Return
a smart pointer instead of a raw pointer.
(WebCore::RenderThemeEfl::getThemePartFromCache):
(WebCore::RenderThemeEfl::clearThemePartCache): Rename
flushThemePartCache to clearThemePartCache for clarity.
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::~RenderThemeEfl):
- platform/efl/RenderThemeEfl.h:
(ThemePartCacheEntry):
(RenderThemeEfl):
- 12:34 PM Changeset in webkit [135657] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] RTSP should use the same MediaDocument as HTTP videos.
https://bugs.webkit.org/show_bug.cgi?id=103185
RIM PR 250114
Patch by Liam Quinn <lquinn@rim.com> on 2012-11-24
Reviewed by George Staikos.
Make our MediaPlayer implementation indicate that it supports RTSP. That way, DOMImplementation::createDocument will create the same MediaDocument as is used for HTTP videos.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
- 12:31 PM Changeset in webkit [135656] by
-
- 3 edits in trunk/Source/WebCore
Put computed style 'font-family' values in the CSSValuePool.
<http://webkit.org/b/103184>
Reviewed by Ojan Vafai.
Use CSSValuePool::createFontFamilyValue() when handing out 'font-family' values from CSSComputedStyleDeclaration.
This avoids creating extra CSSPrimitiveValue objects since we already have these in the pool from parsing.
Also added a max capacity to the font-family cache (using random eviction.)
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
- 11:35 AM Changeset in webkit [135655] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Text not selected when input field focused.
https://bugs.webkit.org/show_bug.cgi?id=103182
Patch by Genevieve Mak <gmak@rim.com> on 2012-11-24
Reviewed by George Staikos.
Reviewed Internally by: Mike Fenton, Eli Fidler
PR #250163
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectObject):
- 11:24 AM Changeset in webkit [135654] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: updated expectations for failures in:
- http/tests/local/drag-over-remote-content.html
https://bugs.webkit.org/show_bug.cgi?id=103181
- media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=103183
- platform/chromium/TestExpectations:
- 9:15 AM Changeset in webkit [135653] by
-
- 11 edits in trunk/Tools
Add the --order option to NRWT
https://bugs.webkit.org/show_bug.cgi?id=102229
Reviewed by Dirk Pranke.
The --order option controls in what order the gathered tests will be run.
There are 3 options:
- natural, the tests are sorted in natural order,
- random, the tests are sorted in random order,
- none, the tests are kept in the order in which they were specified through
arguments or the test list.
The natural option is the default one and maintains the current behavior.
The none option is primarily intended to be used with the --test-list option,
with the test list file expected to list specific test names.
When a directory is specified as one of the paths from under which tests should
be gathered and the none option is used, that path will expand to all the tests
under it, with these tests sorted in the natural order.
Using --order=random duplicated the behavior of the --randomize-order option, so
the latter is removed.
This patch also incorporates the change with which makes it is possible to specify
a test via arguments or the test list multiple tests and then have the test run
that many times.
- Scripts/webkitpy/common/find_files.py:
(find): Accept an optional sorting key that is used to sort files found in the directories
that the given paths specify.
(_normalized_find): Both paths that are then searched for the tests and the tests that
were found are now kept in lists. This makes it possible to run a test multiple times
by specifying it multiple times through arguments or the test list file.
(_normalized_find.sort_by_directory_key):
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
(LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.init): The Sharder class no longer needs a test path separator.
(Sharder.init): Ditto.
(Sharder._resize_shards):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(SharderTests.get_shards): Modify the Shader initializing as required.
(SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
are now moved to the base Port unit tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
the new --order option.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.tests): This method should now return a list of all the tests found in the specified
paths.
(Port._real_tests): A list is required, so no conversion to a set is made.
(Port):
(Port.test_key): Place this method here for now, but it should really move into a separate
module.
(Port._natural_sort_key): Ditto.
(Port._natural_sort_key.tryint):
(Port._virtual_tests): A list is required, so the function now operates on that rather than
on a set.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
list rather than an empty set.
(PortTest.test_dont_require_http_server):
(NaturalCompareTest): The natural sorting unit tests are placed here for now.
(NaturalCompareTest.assert_cmp):
(NaturalCompareTest.test_natural_compare):
(KeyCompareTest): The test name key unit tests are placed here for now.
(KeyCompareTest.assert_cmp):
(KeyCompareTest.test_test_key):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
by using --order=random.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
various aspects of this change.
(MainTest.test_natural_order):
(MainTest):
(MainTest.test_natural_order_test_specified_multiple_times):
(MainTest.test_random_order):
(MainTest.test_random_order_test_specified_multiple_times):
(MainTest.test_no_order):
(MainTest.test_no_order_test_specified_multiple_times):
(MainTest.test_no_order_with_directory_entries_in_natural_order):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.execute): Operate on a set of tests when printing out expectations.
- 8:46 AM Changeset in webkit [135652] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Check errors in EwkView callbacks usage at compile time
https://bugs.webkit.org/show_bug.cgi?id=103177
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Errors in EwkView callbacks usage are now checked at compile time.
- UIProcess/API/efl/EwkViewCallbacks.h:
(CallBack):
(EwkViewCallbacks::CallBack::CallBack):
(EwkViewCallbacks::CallBack::call):
- 7:32 AM Changeset in webkit [135651] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed, rolling out r135648 and r135649.
http://trac.webkit.org/changeset/135648
http://trac.webkit.org/changeset/135649
https://bugs.webkit.org/show_bug.cgi?id=103176
This change cannot be built with a qt-minimal configuration.
(Requested by zalbisser on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-24
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- 7:11 AM Changeset in webkit [135650] by
-
- 3 edits in trunk/Source/WebCore
It's confusing that return values of 'bool Node::dispatchEvent(...)' and 'bool Node::dispatchMouseEvent(..)' have the opposite meanings.
https://bugs.webkit.org/show_bug.cgi?id=103058
Reviewed by Ojan Vafai.
Refactor MouseEventDispatchMediator::dispatchEvent() and
EventHandler::dispatchMouseEvent() so that they return bool
which has the same meaning of the return value of
Node::dispatchEvent().
No tests. No change in behavior.
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
- 7:11 AM Changeset in webkit [135649] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed Qt build fix:
Make sure QGLWidget definition is available.
- WebCoreSupport/PageClientQt.cpp:
- 6:41 AM Changeset in webkit [135648] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103142
When creating the TextureMapperGL for WK1 we have to make sure
that the GL context provided by the QGLWidget is current.
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
the wrong pointer by calling QOpenGLContext::currentContext().
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- 3:28 AM Changeset in webkit [135647] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 2:50 AM Changeset in webkit [135646] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r135600.
http://trac.webkit.org/changeset/135600
https://bugs.webkit.org/show_bug.cgi?id=103173
It made EFL API test is failed (Requested by gyuyoung_mbp on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-24
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/efl/PlatformUtilities.cpp:
(TestWebKitAPI::Util::sleep):
- TestWebKitAPI/efl/PlatformWebView.cpp:
- 2:05 AM Changeset in webkit [135645] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Too many tests come to crashe after build 7830 on
EFL Linux 64-bit Release bot.
- platform/efl-wk1/TestExpectations:
- 12:51 AM Changeset in webkit [135644] by
-
- 11 edits in releases/WebKitGTK/webkit-1.10
[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435
Reviewed by Martin Robinson.
More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.
.:
- GNUmakefile.am: add variable that will hold the list of source files
for libWebCorePlatform .
Source/WebCore:
- GNUmakefile.am: add new libWebCorePlatform convenience library.
- GNUmakefile.list.am: move list of platform/* files to its own variable.
Source/WebKit/gtk:
- GNUmakefile.am: link libWebCorePlatform into libwebkitgtk
Source/WebKit2:
- GNUmakefile.am: link libWebCorePlatform into libwebkit2gtk
Tools:
- GNUmakefile.am: link libWebCorePlatform into DRT
Conflicts:
Source/WebCore/GNUmakefile.am
Source/WebCore/GNUmakefile.list.am
