Timeline
Dec 1, 2012:
- 11:55 PM Changeset in webkit [136317] by
-
- 2 edits in trunk/Source/WebKit2
PDFPlugin: Support PDF form editing in <iframe>s
https://bugs.webkit.org/show_bug.cgi?id=103287
<rdar://problem/10326917>
Reviewed by Dan Bernstein.
PDFPlugin form editing depends on having a Document that has the same
size and position as the plugin; this is true not only in the full-main-frame
case, but also in the <iframe> case. Therefore, we can enable form editing
for <iframe> PDFPlugins.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::supportsForms): Support form editing whenever
our Document's widget is our PluginView (which will only be true in the
full-main-frame or <iframe> case).
- 11:51 PM Changeset in webkit [136316] by
-
- 3 edits in trunk/Source/WebKit2
PDFPlugin: <embed> and <object> PDFs affect their parent frame's page scale
https://bugs.webkit.org/show_bug.cgi?id=103286
<rdar://problem/12752315>
Reviewed by Dan Bernstein.
Detecting whether or not a PDFPlugin is a full-page plugin or not is not
as simple as checking isMainFrame(), because <embed> and <object> will
cause PDFPlugin to live in the main frame, while still not being full-page.
We also have to check that the main frame's document is a PluginDocument,
and whether that PluginDocument's PluginWidget is our PDFPlugin's PluginView.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Add isFullFramePlugin.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::isFullFramePlugin): Check whether the main frame is
backed by a PluginDocument, and that that PluginDocument corresponds
to this PDFPlugin.
(WebKit::PDFPlugin::handlesPageScaleFactor): Use isFullFramePlugin.
(WebKit::PDFPlugin::supportsForms): Use isFullFramePlugin.
- 11:44 PM Changeset in webkit [136315] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Use spoolRect instead of snapshots for print preview
https://bugs.webkit.org/show_bug.cgi?id=103798
<rdar://problem/12686749>
Reviewed by Sam Weinig.
Revert to using spoolRect instead of snapshotting for printing; this was a bogus
change I made in http://trac.webkit.org/changeset/133935 which was irrelevant to
the core of that change, and incorrectly disregards the Frame parameter passed to
beginPrinting, instead using the WebPage's current Frame.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToImage):
- 11:06 PM Changeset in webkit [136314] by
-
- 4 edits in trunk/Tools
[XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
https://bugs.webkit.org/show_bug.cgi?id=103806
Reviewed by Dirk Pranke.
There are occasional mishaps on builders where XvfbDriver doesn't properly
clean up the Xvfb instance it was managing so the related guard lock files
are still existing when the webkitpy unit tests are run. This can cause failures
in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
with a specific number but is unable to due to the stale locks.
The solution to this is to use MockFileLock when inside unit test. This is achievable
by creating a file lock through the SystemHost instance connected to the Port object,
the latter available to the Driver.
- Scripts/webkitpy/common/system/file_lock_mock.py:
(MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
(MockFileLock.release_lock): Return True to signal lock releasing succeeded.
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._next_free_display): Create the file lock through a mockable way.
- Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.test_next_free_display): Enable back the unit test.
- 10:35 PM WebInspector edited by
- (diff)
- 4:31 PM Changeset in webkit [136313] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r136015.
http://trac.webkit.org/changeset/136015
https://bugs.webkit.org/show_bug.cgi?id=103821
Did not heal performance bot and caused other performance
regressions (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-01
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- 2:34 PM EFLWebKit edited by
- fix the spelling for cmakeargs - see … (diff)
- 1:33 PM Changeset in webkit [136312] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Skipping crashing tests.
The DEPS roll containing r170422 is causing three crashes cross-platform
in the Chromium port. Skipping them here, filed crbug.com/163785 to fix.
- platform/chromium/TestExpectations:
Marked media/encrypted-media/encrypted-media-events.html,
media/encrypted-media/encrypted-media-not-loaded.html, and
media/encrypted-media/encrypted-media-syntax.html as crashing.
- 12:00 PM Changeset in webkit [136311] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Skipping calendar-picker-datetime-with-step.html.
It looks like platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html
started failing at midnight PST, December 1st. I don't think it handled
the month change correctly. Filed https://bugs.webkit.org/show_bug.cgi?id=103817
to cover the fix.
- platform/chromium/TestExpectations:
- 10:43 AM Changeset in webkit [136310] by
-
- 4 edits in releases/WebKitGTK/webkit-1.10/Source
Merge 133059 - Enable webkit2 introspection
https://bugs.webkit.org/show_bug.cgi?id=94313
Patch by Jesse van den Kieboom <jessevdk@gnome.org> on 2012-10-31
Reviewed by Martin Robinson.
This patch enables generation of introspection information for webkit2
in the same was as it is done for webkit. The resulting gir and
typelib file are named WebKit2-3.0.{gir,typelib}.
- GNUmakefile.am:
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
- 4:39 AM Changeset in webkit [136309] by
-
- 2 edits in trunk/Source/WebCore
DRT - crashed in WebCore::SearchFieldCancelButtonElement::defaultEventHandler
https://bugs.webkit.org/show_bug.cgi?id=103592
Patch by Xiaobo Wang <xiaobo.wang@torchmobile.com.cn> on 2012-12-01
Reviewed by Kent Tamura.
The crash happened when the search field cancel button handles mouseout
event after the search input was detached. When it happens the input
element returned from shadowHost() is null, need to check the pointer
before dereferencing.
InputFieldSpeechButton and SearchFieldResultsButtonElement have the
similar issue.
No new tests. The patch fixes the following test on BlackBerry platform.
Test: fast/forms/search-delete-while-cancel-button-clicked.html
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
- 3:09 AM Changeset in webkit [136308] by
-
- 2 edits in trunk/Tools
[GTK] A11y tests in WK2 report badly-formatted AX roles
https://bugs.webkit.org/show_bug.cgi?id=102947
Reviewed by Xan Lopez.
As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
These are expected in both tests and their baselines.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::roleToString):
(WTR):
(WTR::AccessibilityUIElement::role):
- 12:33 AM Changeset in webkit [136307] by
-
- 2 edits in trunk/LayoutTests
[gtk] Unreviewed gardening. Skipping CSP 1.1 tests.
The CSP 1.1 tests are failing under GTK after r136305 made the CSP_NEXT
flag runtime enabled. Will fix in webkit.org/b/103810, skipping for now.
- platform/gtk/TestExpectations:
Skipping CSP 1.1 tests.
Nov 30, 2012:
- 11:09 PM Changeset in webkit [136306] by
-
- 2 edits1 move in trunk/LayoutTests
Shorten a file name as the test renamed in r136122 is still hosing Chromium Win perf. bot.
- http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php: Renamed.
- http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php: Removed.
- http/tests/inspector/network/script-as-text-loading-long-url.html:
- 10:53 PM Changeset in webkit [136305] by
-
- 11 edits in trunk
CSP 1.1: Make the CSP_NEXT flag runtime enabled.
https://bugs.webkit.org/show_bug.cgi?id=103652
Reviewed by Adam Barth.
Source/WebCore:
Content Security Policy 1.1 continues to live behind the CSP_NEXT flag,
this patch adds another layer on top of that in order to enable runtime
decisions about whether it should be active.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled):
Adds methods in order to correctly handle enabling and disabling
CSP 1.1 features.
- dom/Document.idl:
Gate the 'document.securityPolicy' object on the runtime flag.
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::addDirective):
Check that experimental features are runtime enabled before
processing 1.1 directives.
(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled):
(WebCore):
- page/ContentSecurityPolicy.h:
Adds a new method which checks against the runtime flag to determine
whether CSP 1.1 features are enabled.
Source/WebKit/chromium:
The CSP_NEXT flag continues to be enabled on the Chromium port, but this
patch now locks the features away behind the securityPolicy runtime
flag.
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableExperimentalContentSecurityPolicyFeatures):
(WebKit):
(WebKit::WebRuntimeFeatures::isExperimentalContentSecurityPolicyFeaturesEnabled):
Adds the feature to WebRuntimeFeatures so it can be toggled from
inside Chromium.
Tools:
Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- 10:18 PM Changeset in webkit [136304] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK1] Gardening test cases which are not crashed after r135662
https://bugs.webkit.org/show_bug.cgi?id=103803
Unreviewed, EFL gardening.
Patch by Sujin Park <sujjin.park@gmail.com> on 2012-11-30
- platform/efl-wk1/TestExpectations:
- 10:12 PM Changeset in webkit [136303] by
-
- 2 edits in trunk/Source/WebCore
Avoid calling into NSUserDefaults every time we start a scroll
https://bugs.webkit.org/show_bug.cgi?id=103804
Reviewed by Dan Bernstein.
Cache the NSScrollAnimationEnabled preference to avoid
hitting NSUserDefaults every time we start scrolling.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::scrollAnimationEnabledForSystem):
- 6:24 PM Changeset in webkit [136302] by
-
- 2 edits in trunk/Source/WebKit2
Always listen for the DidFirstLayout layout milestone
https://bugs.webkit.org/show_bug.cgi?id=103795
<rdar://problem/12790268>
Reviewed by Dan Bernstein.
The DidFirstLayout layout milestone is used to determine when to unfreeze the layer tree, so we always want to listen for it.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 5:40 PM Changeset in webkit [136301] by
-
- 2 edits in trunk/Tools
Unreviewed. Removed temporary debugging change from DRT (r136300).
- DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
- 5:23 PM Changeset in webkit [136300] by
-
- 2 edits in trunk/Tools
Unreviewed. Temporary change to DRT for debugging purposes.
- DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
- 5:19 PM Changeset in webkit [136299] by
-
- 4 edits in trunk/Source
[Qt] Unreviewed speculative Mac build fix after r136232
Source/JavaScriptCore:
Update the include path so that LLIntAssembly.h is picked up.
The bot didn't break until later when a clean build was triggered.
- JavaScriptCore.pri:
Source/WebKit2:
cleanup an oversight from r136235
- PluginProcess.pro: s/webkit/webkitwidgets/
- 4:53 PM Changeset in webkit [136298] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=103790
The LayerPool m_pruneTimer should have a longer delay
Reviewed by Simon Fraser.
A 1 second delay is more appropriate here.
- platform/graphics/ca/mac/LayerPool.mm:
(WebCore::LayerPool::schedulePrune):
- 4:50 PM Changeset in webkit [136297] by
-
- 2 edits in trunk/Source/JavaScriptCore
Optimise more cases of op_typeof
https://bugs.webkit.org/show_bug.cgi?id=103783
Reviewed by Mark Hahnenberg.
Increase our coverage of typeof based typechecks by
making sure that the codegenerators always uses
consistent operand ordering when feeding typeof operations
into equality operations.
- bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):
(JSC::EqualNode::emitBytecode):
(JSC::StrictEqualNode::emitBytecode):
- 4:43 PM Changeset in webkit [136296] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix.
Add a default: entry to an case statement to fix a build error when compiled in VS2005.
- html/MediaController.cpp:
(MediaController::playbackState):
- 4:13 PM Changeset in webkit [136295] by
-
- 7 edits1 copy1 add in trunk
Add support for the 'unpause()' method on MediaController.
https://bugs.webkit.org/show_bug.cgi?id=103751
Reviewed by Eric Carlson.
Source/WebCore:
The MediaController spec has been updated to add an unpause() method
which is functionally identical to the old play() method, and changes
the semantics of play() to call play() on the underlying slaved media
elements. The spec also added a playbackState() method, returning a
string representing the last calculated playback state.
Test: media/media-controller-unpause.html
- html/MediaController.cpp:
(MediaController::unpause): Renamed from play().
(MediaController::play): Added. Same as unpause(), but also call
play() on slaved media elements.
(playbackStateWaiting): Static string accessor.
(playbackStatePlaying): Ditto.
(playbackStateEnded): Ditto.
(MediaController::playbackState): Added. Returns string value of
m_playbackState.
- html/MediaController.h:
- html/MediaController.idl:
LayoutTests:
Add new test for unpause() and playbackState() methods.
- media/media-controller-unpause.html:
- media/media-controller-unpause-expected.txt:
- media/media-controller-playback.html:
- media/media-controller-playback-expected.txt:
- 3:59 PM Changeset in webkit [136294] by
-
- 5 edits in trunk/Source/WebCore
[CSS Grid Layout] Align the grid track code with the specification's production rules
https://bugs.webkit.org/show_bug.cgi?id=103703
Reviewed by Alexis Menard.
In order to support more of the syntax and make the code more readable, this change
splits following the grammar's production rules (see
http://dev.w3.org/csswg/css3-grid-layout/#grid-definition-columns-and-grid-definit).
Refactoring covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackMinMax):
(WebCore::valueForGridTrackGroup):
(WebCore::valueForGridTrackList):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackGroup):
(WebCore::CSSParser::parseGridTrackMinMax):
- css/CSSParser.h:
- css/StyleResolver.cpp:
(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
Mechanical split of the parsing, resolving and computed style code into
<track-list>, <track-group>, <track-minmax> and <track-breadth> parts.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridBreadth):
Changed this function to just parse a single value (without any extra logic).
- css/StyleResolver.cpp:
(WebCore::createGridTrackBreadth):
Changed this function to take a Length as it is used to parse a <track-breadth>.
The goal is for it to be the low-level function createGridTrackMinmax will call on
each function parameter.
- 3:56 PM Changeset in webkit [136293] by
-
- 2 edits in trunk/Source/WebCore
Fix potential crash when canceling animations on renderers with no node
https://bugs.webkit.org/show_bug.cgi?id=103784
Reviewed by Dan Bernstein.
We could crash when tearing down RenderScrollbars because we hit
AnimationController::cancelAnimations() for a renderer with no node.
The assertion already check for a null node, but the line after
does not, so fix that.
I tried to make a test with animations/transitions on a custom scrollbar, but was not able
to get it to crash.
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::cancelAnimations):
- 3:36 PM Changeset in webkit [136292] by
-
- 6 edits1 move10 adds1 delete in trunk/Source
Source/WebKit/win: [Windows, WinCairo] Generate library export definition file.
https://bugs.webkit.org/show_bug.cgi?id=103687
Reviewed by Tim Horton.
Update project solutions to use the new generated *.def files.
- WebKit.vcproj/WebKit.sln: Update for new project and file
locations.
Source/WebKit2: [Windows, WinCairo] Generate library export symbol file.
https://bugs.webkit.org/show_bug.cgi?id=103687
Reviewed by Tim Horton.
Generate the export definition file based on the compile options
and port settings. Get rid of the old hand-written file, and use
a revised master input file that allows using conditional
settings to generate the output, much like the Mac and other
ports do.
- win/WebKit2.def: Removed.
- win/WebKit2.def.in: Added.
- win/WebKit2Apple.vsprops:
- win/WebKit2CFLite.def: Removed.
- win/WebKit2CFLite.vsprops:
- win/WebKit2Common.vsprops:
- win/WebKit2ExportGenerator.vcproj: Added.
- win/WebKit2ExportGeneratorCommon.vsprops: Added.
- win/WebKit2ExportGeneratorDebug.vsprops: Added.
- win/WebKit2ExportGeneratorDebugAll.vsprops: Added.
- win/WebKit2ExportGeneratorDebugCairoCFLite.vsprops: Added.
- win/WebKit2ExportGeneratorPostBuild.cmd: Added.
- win/WebKit2ExportGeneratorPreBuild.cmd: Added.
- win/WebKit2ExportGeneratorProduction.vsprops: Added.
- win/WebKit2ExportGeneratorRelease.vsprops: Added.
- win/WebKit2ExportGeneratorReleaseCairoCFLite.vsprops: Added.
- 3:33 PM Changeset in webkit [136291] by
-
- 1 edit in branches/chromium/1312/Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.h
Merge 134902
BUG=157875
Review URL: https://codereview.chromium.org/11419266
- 3:33 PM Changeset in webkit [136290] by
-
- 9 edits in branches/chromium/1312/Source/WebCore/platform/graphics
Merge 134871
BUG=157875
Review URL: https://codereview.chromium.org/11348334
- 3:30 PM Changeset in webkit [136289] by
-
- 2 edits in trunk/Source/WebCore
PluginDocument fires didFinishDocumentLoadForFrame upon receiving initial bytes instead of when load completes
https://bugs.webkit.org/show_bug.cgi?id=103702
<rdar://problem/12762534>
Reviewed by Alexey Proskuryakov.
Remove the call to finish() from PluginDocumentParser::appendBytes().
This was introduced in http://trac.webkit.org/changeset/14838, when finish() wouldn't get
called for PluginDocuments any other way. In the time since, DocumentWriter::end() was made
to call finish() anyway, at the correct time (the call from appendBytes makes a PluginDocument
appear to be finished loading after the first bytes are received).
No new tests, because there doesn't seem to be any state in a PluginDocument that can be accessed
from JavaScript to determine whether or not it has finished loading.
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes):
- 3:21 PM Changeset in webkit [136288] by
-
- 3 edits in trunk/Source/WebCore
RenderBlock minor clean-up: replace raw pointers with OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=103690
Reviewed by Eric Seidel.
raw pointers were replaced with OwnPtrs.
Probably we also gain a small performance improvements because
I replaced get && remove pair with take.
- rendering/RenderBlock.cpp:
(WebCore):
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::addContinuationWithOutline):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
- rendering/RenderBlock.h:
(WebCore):
- 3:21 PM Changeset in webkit [136287] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, webkit gardening, fix webkit lint.
- platform/chromium/TestExpectations:
- 3:17 PM Changeset in webkit [136286] by
-
- 3 edits2 copies in branches/chromium/1312
Merge 136060
BUG=158693
Review URL: https://codereview.chromium.org/11416300
- 3:12 PM Changeset in webkit [136285] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 135914
BUG=158695
Review URL: https://codereview.chromium.org/11415245
- 3:12 PM Changeset in webkit [136284] by
-
- 2 edits in trunk/LayoutTests
Use the correct path to a test in TestExpectations.
- platform/chromium/TestExpectations:
- 3:07 PM Changeset in webkit [136283] by
-
- 1 edit in branches/chromium/1312/Source/WebCore/page/EventHandler.cpp
Merge 136062
BUG=159219
Review URL: https://codereview.chromium.org/11415242
- 3:04 PM Changeset in webkit [136282] by
-
- 11 edits in trunk/Source/WebCore
WebGL: Add a class to abstract the status of the Image in texImage2D() and texSubImage2D()
https://bugs.webkit.org/show_bug.cgi?id=103606
Patch by Jun Jiang <jun.a.jiang@intel.com> on 2012-11-30
Reviewed by Kenneth Russell.
In texImage2D() and texSubImage2D() for WebGL, the status of the Image is extracted and kept in the function GraphicsContext3D::getImageData() but provides no interface or guaranteed way to use the status of the Image outside GraphicsContext3D::getImageData() safely. For example, you can not get the address of the raw Image data and operate it outside the scope of the GraphicsContext3D::getImageData() and there is at least one memory copy existed from the Image to the intermediate vector.
This patch refactors the code by adding a ImageExtractor class to abstract and keep the status of the Image. The lifetime and validity of Image status are determined by the lifetime of the object instead of the scope of getImageData(). It provides flexibility on future optimizations.
No new tests. It is a code refactoring patch.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::packImageData):
- platform/graphics/GraphicsContext3D.h:
(WebCore):
(GraphicsContext3D):
(ImageExtractor):
(WebCore::GraphicsContext3D::ImageExtractor::extractSucceeded):
(WebCore::GraphicsContext3D::ImageExtractor::imagePixelData):
(WebCore::GraphicsContext3D::ImageExtractor::imageWidth):
(WebCore::GraphicsContext3D::ImageExtractor::imageHeight):
(WebCore::GraphicsContext3D::ImageExtractor::imageSourceFormat):
(WebCore::GraphicsContext3D::ImageExtractor::imageAlphaOp):
(WebCore::GraphicsContext3D::ImageExtractor::imageSourceUnpackAlignment):
- platform/graphics/NativeImagePtr.h:
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/clutter/GraphicsContext3DClutter.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- 3:01 PM Changeset in webkit [136281] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 136034
BUG=146882
Review URL: https://codereview.chromium.org/11299286
- 3:00 PM Changeset in webkit [136280] by
-
- 6 edits in trunk
Make RenderLayer::updateLayerPosition() private
https://bugs.webkit.org/show_bug.cgi?id=102624
Reviewed by Ryosuke Niwa.
Source/WebCore:
Made updateLayerPosition() private. The only external caller was
MouseRelatedEvent::computeRelativePosition(), which has no business updating
layer positions. In fact it had positively dangerous behavior; doing just
a style update without layout, and then calling absoluteToLocal() and walking
layers. Fixed by having it call updateLayoutIgnorePendingStylesheets().
This revealed a bug where event.offsetX/offsetY could be wrong in some cases.
fast/events/stopPropagation-submit.html does a simulated click (which has
client coordinates at 0,0), so the image submit coordinates were incorrectly
0,0. Now that we do layout before computing them, they are correctly reported
as being relative to the element.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::computeRelativePosition):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
- rendering/RenderLayer.h:
(RenderLayer):
LayoutTests:
New results with correctly computed event offsets.
- fast/events/stopPropagation-submit-expected.txt:
- 2:45 PM Changeset in webkit [136279] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 135719
BUG=161690
Review URL: https://codereview.chromium.org/11316291
- 2:43 PM Changeset in webkit [136278] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 135719
BUG=161690
Review URL: https://codereview.chromium.org/11434065
- 2:30 PM Changeset in webkit [136277] by
-
- 7 edits in trunk/Source/WebCore
Late-loading stylesheets can cause composited layers to be blank
https://bugs.webkit.org/show_bug.cgi?id=103773
Reviewed by Tim Horton.
Early painting can be short-circuited in RenderBlock::paintContents() if we know a stylesheet
is pending, which is done to avoid a flash of unstyled content (FOUC). When the stylesheet
finally loaded, Document::styleResolverChanged() would try to repaint everything by calling
repaint() on the RenderView(). In a composited world, however, this repaint() doesn't repaint
composited layers.
This was particularly prevalent on this specific URL because it failed to load
a CSS file from typekit.com, so Document::styleResolverChanged()
just did the repaint and returned (rather than doing a recalc style as would
happen for correctly loaded stylesheets).
Fix by making a way to repaint all compositing layers, and calling it
from Document::styleResolverChanged().
No tests because this is timing-dependant.
- dom/Document.cpp:
(WebCore::Document::styleResolverChanged): Call repaintViewAndCompositedLayers().
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContents): Fix the comment.
- rendering/RenderLayerCompositor.cpp: Convert repaintCompositedLayersAbsoluteRect()
and associated recursiveRepaintLayerRect() to allow the rect to be null, which indicates
that we should just repaint the entire layer, and improve their names.
(WebCore::RenderLayerCompositor::repaintCompositedLayers):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
- rendering/RenderLayerCompositor.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): repaintCompositedLayersAbsoluteRect()
was renamed to repaintCompositedLayers().
(WebCore::RenderView::repaintViewAndCompositedLayers):
- rendering/RenderView.h:
(RenderView): repaintViewRectangle() and repaintRectangleInViewAndCompositedLayers() should not
be virtual. Add repaintViewAndCompositedLayers().
- 1:56 PM Changeset in webkit [136276] by
-
- 15 edits in trunk/Source/JavaScriptCore
Rationalize and clean up DFG handling of scoped accesses
https://bugs.webkit.org/show_bug.cgi?id=103715
Reviewed by Oliver Hunt.
Previously, we had a GetScope node that specified the depth to which you wanted
to travel to get a JSScope, and the backend implementation of the node would
perform all of the necessary footwork, including potentially skipping the top
scope if necessary, and doing however many loads were needed. But there were
strange things. First, if you had accesses at different scope depths, then the
loads to get to the common depth could not be CSE'd - CSE would match only
GetScope's that had identical depth. Second, GetScope would be emitted even if
we already had the scope, for example in put_to_base. And finally, even though
the ResolveOperations could tell us whether or not we had to skip the top scope,
the backend would recompute this information itself, often pessimistically.
This eliminates GetScope and replaces it with the following:
GetMyScope: just get the JSScope from the call frame header. This will forever
mean getting the JSScope associated with the machine call frame; it will not
mean getting the scope of an inlined function. Or at least that's the intent.
SkipTopScope: check if there is an activation, and if so, skip a scope. This
takes a scope as a child and returns a scope.
SkipScope: skip one scope level.
The bytecode parser now emits the right combination of the above, and
potentially emits multiple SkipScope's, based on the ResolveOperations.
This change also includes some fixups to debug logging. We now always print
the ExecutableBase* in addition to the CodeBlock* in the CodeBlock's dump,
and we are now more verbose when dumping CodeOrigins and InlineCallFrames.
This is performance-neutral. It's just meant to be a clean-up.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
- bytecode/CodeOrigin.cpp:
(JSC::CodeOrigin::inlineStack):
(JSC::CodeOrigin::dump):
(JSC):
(JSC::InlineCallFrame::dump):
- bytecode/CodeOrigin.h:
(CodeOrigin):
(InlineCallFrame):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getScope):
(DFG):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dump):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dumpBlockHeader):
- dfg/DFGNode.h:
(Node):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dump):
- 1:54 PM Changeset in webkit [136275] by
-
- 17 edits3 deletes in trunk
Unreviewed, rolling out r136142.
http://trac.webkit.org/changeset/136142
https://bugs.webkit.org/show_bug.cgi?id=103768
break a bunch of interactive_ui_tests in chromium win
(Requested by zhenyao_home on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-30
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layout):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- fast/ruby/position-after.html: Removed.
- platform/mac/fast/ruby/position-after-expected.png: Removed.
- platform/mac/fast/ruby/position-after-expected.txt: Removed.
- 1:53 PM Changeset in webkit [136274] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 135740
BUG=158204
Review URL: https://codereview.chromium.org/11348330
- 1:52 PM Changeset in webkit [136273] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 135740
BUG=158204
Review URL: https://codereview.chromium.org/11418272
- 1:48 PM Changeset in webkit [136272] by
-
- 9 edits in trunk/Source/WebCore
IndexedDB: Replace use of ScriptExecutionContext::Task (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=101483
Reviewed by Tony Chang.
The IDB back end (which runs on a single thread) makes use of ScriptExecutionContext's
Task and facilities for cross-task posting with callbacks, and requires decorating various
IDB classes with "ThreadSafe" when they are not. Move towards encapsulating the tasks
in "Operation" classes which are IDB-operation specific.
Part 1 (this patch) retains the use of ScriptExecutionContext::Task but wraps the creation
and the callback function in an Operation class which will be fleshed out in later patches.
As an aside, a little bit of RefPtr churn is eliminated, and IDB_TRACE sprinkled in.
No new tests - just a refactor.
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(IDBCursorBackendImpl::CursorIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::create):
(WebCore):
(IDBCursorBackendImpl::CursorAdvanceOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::create):
(IDBCursorBackendImpl::CursorPrefetchIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::create):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::advance):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::perform):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::perform):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(IDBDatabaseBackendImpl::CreateObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::create):
(WebCore):
(IDBDatabaseBackendImpl::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::create):
(IDBDatabaseBackendImpl::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::VersionChangeAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::create):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(IDBIndexBackendImpl::OpenIndexCursorOperation):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::create):
(WebCore):
(IDBIndexBackendImpl::IndexCountOperation):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::create):
(IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::create):
(IDBIndexBackendImpl::IndexValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::create):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::perform):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::perform):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::metadata):
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::create):
(WebCore):
(IDBObjectStoreBackendImpl::ObjectStoreStorageOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreClearOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::create):
(IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreCountOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::create):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::perform):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- 1:31 PM Changeset in webkit [136271] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Suppress the new separable mask blurs in skia until the tests can be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=103766
Unreviewed.
- skia_webkit.gyp:
- 1:29 PM Changeset in webkit [136270] by
-
- 4 edits in branches/safari-536.28-branch/Source
Versioning.
- 1:27 PM Changeset in webkit [136269] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 135193
BUG=156619
Review URL: https://codereview.chromium.org/11411295
- 1:26 PM Changeset in webkit [136268] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 135193
BUG=156619
Review URL: https://codereview.chromium.org/11418269
- 1:25 PM Changeset in webkit [136267] by
-
- 1 copy in tags/Safari-536.28.5
New Tag.
- 1:25 PM Changeset in webkit [136266] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 1:24 PM Changeset in webkit [136265] by
-
- 9 edits in trunk/Source
(Simple)PDFPlugin: Support conversion of PostScript documents
https://bugs.webkit.org/show_bug.cgi?id=103289
<rdar://problem/10235708>
Reviewed by Dan Bernstein.
SimplePDFPlugin (and PDFPlugin) should support converting PostScript files
to PDF before handing them off to their respective backends.
As PDFPlugin inherits from SimplePDFPlugin, it gets the new functionality automatically.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Add convertPostScriptDataIfNeeded(), and m_isPostScript.
- WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::pluginInfo): SimplePDFPlugin should claim to support PDF and PostScript.
(WebKit::convertPostScriptDataSourceToPDF): PS->PDF conversion code, copied from PDFViewController (which I intend to remove).
(WebKit::SimplePDFPlugin::convertPostScriptDataIfNeeded): Check if the loaded data represents a PS file; if so, convert it.
(WebKit::SimplePDFPlugin::streamDidReceiveResponse): Check if the loaded data is of MIME type application/postscript, and store that in m_isPostScript.
(WebKit::SimplePDFPlugin::streamDidFinishLoading): Call convertPostScriptDataIfNeeded when we finish loading.
(WebKit::SimplePDFPlugin::manualStreamDidReceiveResponse): Ditto from streamDidReceiveResponse.
(WebKit::SimplePDFPlugin::manualStreamDidFinishLoading): Ditto from streamDidFinishLoading.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Use (Simple)PDFPlugin for PostScript files too.
- English.lproj/Localizable.strings:
- WebCore.exp.in:
- platform/LocalizedStrings.cpp:
(WebCore::postScriptDocumentTypeDescription):
- platform/LocalizedStrings.h:
Add and export postScriptDocumentTypeDescription, for PostScript files.
- 1:21 PM Changeset in webkit [136264] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 135303
BUG=154488
Review URL: https://codereview.chromium.org/11421183
- 1:20 PM Changeset in webkit [136263] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 135303
BUG=154488
Review URL: https://codereview.chromium.org/11418268
- 1:11 PM Changeset in webkit [136262] by
-
- 5 edits1 add in trunk
[Chromium] Animation updates fail when using a canvas as a CSS backround-image style with -webkit-canvas
https://bugs.webkit.org/show_bug.cgi?id=103643
Reviewed by Stephen White.
.:
New test to verify that elements using a canvas as a style image
source are redrawn when the canvas is animated. Added as a manual test
because the bug was not reproducible in DumpRenderTree.
- ManualTests/animated-canvas-as-background.html: Added.
Source/WebCore:
CanvasRenderingContext2D::didDraw was not propagating the change
notification to observers in the accelerated compositing case.
Problem fixed by adding observer notifications.
New manual test: animated-canvas-as-background.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::didDraw):
The observer notification was factored out into a separate method
so that it can be invoked directly for accelerated compositing.
(WebCore):
(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
- html/HTMLCanvasElement.h:
(HTMLCanvasElement):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
Added observer notification call to trigger repainting of elements that
use this canvas for their style.
- 1:09 PM Changeset in webkit [136261] by
-
- 11 edits in trunk/Source/JavaScriptCore
Add direct string->function code cache
https://bugs.webkit.org/show_bug.cgi?id=103764
Reviewed by Michael Saboff.
A fairly logically simple patch. We now track the start of the
unique portion of a functions body, and use that as our key for
unlinked function code. This allows us to cache identical code
in different contexts, leading to a small but consistent improvement
on the benchmarks we track.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::functionStartOffset):
(UnlinkedFunctionExecutable):
- parser/ASTBuilder.h:
(ASTBuilder):
(JSC::ASTBuilder::setFunctionStart):
- parser/Nodes.cpp:
- parser/Nodes.h:
(JSC::FunctionBodyNode::setFunctionStart):
(JSC::FunctionBodyNode::functionStart):
(FunctionBodyNode):
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- parser/Parser.h:
(JSC::Parser::findCachedFunctionInfo):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::setFunctionStart):
- runtime/CodeCache.cpp:
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionCodeBlock):
(JSC::CodeCache::usedFunctionCode):
- runtime/CodeCache.h:
- 12:49 PM Changeset in webkit [136260] by
-
- 3 edits in trunk/Source/WebKit2
PDFPlugin: "Show Definition" context menu item should be implemented
https://bugs.webkit.org/show_bug.cgi?id=103389
<rdar://problem/12710751>
Reviewed by Dan Bernstein.
Call existing dictionary popup code when the context menu "Show Definition" item is selected.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Add showDefinitionForAttributedString and convertFromPDFViewToRootView.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate showDefinitionForAttributedString:atPoint:]): Forward this call to PDFPlugin.
(WebKit::PDFPlugin::showDefinitionForAttributedString): Create a DictionaryPopupInfo with the necessary information.
Ask WebPageProxy to show the dictionary popup.
(WebKit::PDFPlugin::convertFromPDFViewToRootView): Convert a point from PDFLayerController space to the root view space.
- 12:39 PM Changeset in webkit [136259] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set the minimal DOM timer interval to 4 milliseconds
https://bugs.webkit.org/show_bug.cgi?id=103534
Patch by Cosmin Truta (ctruta@rim.com)
Reviewed by Yong Li.
We align this behavior with other platforms.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
- 12:20 PM Changeset in webkit [136258] by
-
- 135 edits1 move3 adds8 deletes in trunk/LayoutTests
[Chromium] Rebaselining tests affected by recent Skia changes
Unreviewed test expectations updates.
Due to the Win7 builders being so far behind, some Win7 expectations may be wrong.
Also fixes https://bugs.webkit.org/show_bug.cgi?id=103722
- platform/chromium-linux-x86/svg/transforms: Added.
- platform/chromium-linux-x86/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-linux/fast/text/line-initial-and-final-swashes-expected.png: Removed.
- platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
- platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
- platform/chromium-mac-lion/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
- platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
- platform/chromium-mac-lion/svg/custom/linking-a-03-b-transform-expected.png:
- platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-mac-lion/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac-lion/svg/custom/stroke-width-large-expected.png:
- platform/chromium-mac-lion/svg/custom/use-transform-expected.png:
- platform/chromium-mac-lion/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/stroke-width-large-expected.png:
- platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
- platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-expected.png:
- platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
- platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
- platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
- platform/chromium-mac/fast/transforms/shadows-expected.png:
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
- platform/chromium-mac/svg/css/group-with-shadow-expected.png:
- platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
- platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac/svg/custom/stroke-width-large-expected.png:
- platform/chromium-mac/svg/custom/use-transform-expected.png:
- platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/color: Removed.
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
- platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-win/fast/box-shadow/inset-expected.png:
- platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/line-initial-and-final-swashes-expected.png.
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
- platform/chromium-win/svg/css/group-with-shadow-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-win/svg/custom/pattern-rotate-expected.png:
- platform/chromium-win/svg/custom/stroke-width-large-expected.png:
- platform/chromium-win/svg/custom/use-transform-expected.png:
- platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium/TestExpectations:
- 11:28 AM Changeset in webkit [136257] by
-
- 1 edit in branches/safari-536.28-branch/Source/WebCore/English.lproj/Localizable.strings
Update localized strings.
- 11:19 AM Changeset in webkit [136256] by
-
- 8 edits in trunk
Report CSS as initiator instead of elements, except body
https://bugs.webkit.org/show_bug.cgi?id=103546
Reviewed by Tony Gentilcore.
Source/WebCore:
The Resource Timing spec says the initiator should be "css" when the the load comes from a
url() rule in a stylesheet. Separately, WebKit reports <body background> as a CSS load, we
need to override that to match the spec.
Tests: http/tests/w3c/webperf/submission/resource-timing
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage): By default, the initiator is "css".
- css/CSSImageValue.h:
(CSSImageValue):
(WebCore::CSSImageValue::setInitiator): Allow users to manually override it (see body).
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectStyleForPresentationAttribute): Record "body" as the initiator.
LayoutTests:
- platform/chromium/fast/loader/resource-request-callbacks-expected.txt: Rebaseline to match new behavior.
- 11:17 AM Changeset in webkit [136255] by
-
- 3 edits in trunk/Source/WebCore
Remember the CachedResourceRequest for preloads
https://bugs.webkit.org/show_bug.cgi?id=102995
Reviewed by Tony Gentilcore.
Without this, the initiator is lost.
Tests: http/tests/w3c/webperf/submission/resource-timing
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::checkForPendingPreloads):
(WebCore::CachedResourceLoader::requestPreload):
(WebCore::CachedResourceLoader::isPreloaded):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
(PendingPreload):
- 10:47 AM Changeset in webkit [136254] by
-
- 3 edits6 adds in trunk
[CSS Shaders] Clamp input colors before blending
https://bugs.webkit.org/show_bug.cgi?id=98962
Reviewed by Dean Jackson.
Source/WebCore:
The result of css_ColorMatrix multiplication is now clamped in [0.0, 1.0]
before the blending step.
Relevant spec section is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-processing-model
Tests: css3/filters/custom/custom-filter-color-clamping-negative.html
css3/filters/custom/custom-filter-color-clamping.html
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader): Added clamping
code.
LayoutTests:
Test to check the correct clamping of color values.
- css3/filters/custom/custom-filter-color-clamping-expected.html: Added.
- css3/filters/custom/custom-filter-color-clamping-negative-expected.html: Added.
- css3/filters/custom/custom-filter-color-clamping-negative.html: Added.
- css3/filters/custom/custom-filter-color-clamping.html: Added.
- css3/filters/resources/custom-filter-color-clamping-negative.fs: Added.
- css3/filters/resources/custom-filter-color-clamping.fs: Added.
- 10:19 AM FeatureFlags edited by
- (diff)
- 10:18 AM FeatureFlags edited by
- (diff)
- 10:14 AM Changeset in webkit [136253] by
-
- 3 edits2 adds in trunk
Crash due to intruding float not removed after writing mode changed.
https://bugs.webkit.org/show_bug.cgi?id=100149
Reviewed by Levi Weintraub.
Source/WebCore:
When RenderView writing mode changes, make sure to mark all descendants
with floats for layout.
Test: fast/block/float/intruding-float-not-removed-writing-mode.xhtml
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
- fast/block/float/intruding-float-not-removed-writing-mode-expected.txt: Added.
- fast/block/float/intruding-float-not-removed-writing-mode.xhtml: Added.
- 9:57 AM Changeset in webkit [136252] by
-
- 4 edits in trunk/Source/WebKit/qt
[Qt] Introduce setTextSizeMultiplier in the page adapter as well.
Rubber-stamped by Simon Hausmann.
As it turns out it the bots didn't like the previous attempt.
- WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::setTextSizeMultiplier):
- WebCoreSupport/QWebFrameAdapter.h:
- WidgetApi/qwebframe.cpp:
(QWebFrame::setTextSizeMultiplier):
- 9:57 AM Changeset in webkit [136251] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Unreviewed build fix.
In the same vein as r136245. Include PlatformExportMacros proper.
- WebCoreSupport/QtPrintContext.h:
- 9:49 AM Changeset in webkit [136250] by
-
- 4 edits2 adds in trunk
SVG pattern data deleted while in use
https://bugs.webkit.org/show_bug.cgi?id=103415
Reviewed by Dirk Schulze.
Source/WebCore:
Various calls in RenderSVGResourcePattern::applyResource() can trigger invalidations,
which may end up deleting our current pattern data (via removeAllClientsFromCache).
To avoid this, we should add the pattern data to the cache only after it is fully built.
For clarity, the patch also refactors the pattern setup code into a separate method.
Test: svg/custom/large-image-pattern-crash.html
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):
- rendering/svg/RenderSVGResourcePattern.h:
(RenderSVGResourcePattern):
LayoutTests:
- svg/custom/large-image-pattern-crash-expected.txt: Added.
- svg/custom/large-image-pattern-crash.html: Added.
- 9:20 AM Changeset in webkit [136249] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: It's Sass, not SASS
https://bugs.webkit.org/show_bug.cgi?id=103626
Reviewed by Yury Semikhatsky.
Change "SASS" to "Sass" in UI strings.
- English.lproj/localizedStrings.js:
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SettingsScreen.js:
- 9:17 AM Changeset in webkit [136248] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Fixing TestExpectations
Unreviewed fix to pass lint
- platform/chromium/TestExpectations:
- 9:06 AM Changeset in webkit [136247] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed trivial Qt build fix:
Always link against WebProcess against QT += webkit and use webkitwidgets only if available.
- WebProcess.pro:
- 8:59 AM Changeset in webkit [136246] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash in conversion of empty OpaqueJSString to Identifier
https://bugs.webkit.org/show_bug.cgi?id=101867
Reviewed by Michael Saboff.
The constructor call used for both null and empty OpaqueJSStrings results
in an assertion voilation and crash. This patch instead uses the Identifier
constructors which are specifically for null and empty Identifier.
- API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):
- 8:24 AM Changeset in webkit [136245] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed prospective MIPS build fix:
Explicitly include PlatformExportMacros for the correct export macro to be find.
Not really MIPS specific but rather to a minimal build configuration with less implicit
includes.
- WebCoreSupport/UndoStepQt.h:
- 8:20 AM Changeset in webkit [136244] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Unreviewed build un-break
Revert r136243 and hope it served its purpose.
- WidgetApi/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- 8:10 AM Changeset in webkit [136243] by
-
- 4 edits in trunk
[Qt] Unreviewed build break
Rubber-stamped by Simon Hausmann.
Poor man's way to trigger a clean build on a bot.
.:
- WebKit.pro:
Source/WebKit/qt:
- WidgetApi/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- 7:48 AM Changeset in webkit [136242] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Fix QML import installation with newer Qt
Reviewed by Tor Arne Vestbø.
The import path has been separated between QML1 and QML2. Use
QT_INSTALL_QML if it's available.
- declarative/experimental/experimental.pri:
- declarative/public.pri:
- 7:32 AM Changeset in webkit [136241] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 135578 - REGRESSION (r128633): td changes size during re-layout of table although it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=102802
Patch by Julian Pastarmov <pastarmovj@chromium.org> on 2012-11-23
Reviewed by Ojan Vafai.
Source/WebCore:
The bug was caused by incorrectly rewriting a nested condition which caused the else
clause to trigger in wrong cases.
Test: fast/table/nested-tables-with-div-offset.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
Reverted wrong combination of nested if statements.
LayoutTests:
This test checks that table layout of some nested tables in quirks mode is computed correctly.
- fast/table/nested-tables-with-div-offset-expected.txt: Added.
- fast/table/nested-tables-with-div-offset.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11414259
- 7:25 AM Changeset in webkit [136240] by
-
- 2 edits in trunk/Source/WebKit/qt
Prospective build fix for --minimal build.
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::triggerAction):
(QWebPageAdapter::contextMenuItemTagForAction):
- 7:22 AM Changeset in webkit [136239] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip failing test editing/selection/caret-alignment-for-vertical-text.html
https://bugs.webkit.org/show_bug.cgi?id=103741
Unreviewed, EFL gardening.
Skip failing test editing/selection/caret-alignment-for-vertical-text.html
until bug 103740 is fixed.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30
- platform/efl/TestExpectations:
- 7:22 AM Changeset in webkit [136238] by
-
- 2 edits in trunk
[Qt] Unreviewed doc fix
Add additional search paths for API folders.
- Source/qtwebkit.qdocconf:
- 7:17 AM Changeset in webkit [136237] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Fix zoomIn/zoomOut related regression.
Reviewed by Simon Hausmann.
Following r136235, fix a case of refactoring gone wrong.
Implementing setTextSizeMultiplier in terms of
setZoomFactor, and not the other way around.
- WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::setZoomFactor):
- WidgetApi/qwebframe.cpp:
(QWebFrame::setTextSizeMultiplier):
- 7:09 AM Changeset in webkit [136236] by
-
- 21 edits1 move in trunk
Source/WebCore: Speech Recognition API: Update SpeechRecognitionEvent/Result to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407
Reviewed by Adam Barth.
This patch does the following:
o Adds results, and removing result on SpeechRecognitionEvent
o Renaming SpeechRecognitionResult::final to isFinal
o Moving emma to SpeechRecognitionEvent from SpeechRecognitionResult
Existing tests updated to test the new API.
- Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::didReceiveResults):
(WebCore):
- Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
- Modules/speech/SpeechRecognitionEvent.cpp:
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::~SpeechRecognitionEvent):
(WebCore::emmaQualifiedName):
(WebCore::SpeechRecognitionEvent::emma):
- Modules/speech/SpeechRecognitionEvent.h:
(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::results):
- Modules/speech/SpeechRecognitionEvent.idl:
- Modules/speech/SpeechRecognitionResult.cpp:
- Modules/speech/SpeechRecognitionResult.h:
(WebCore::SpeechRecognitionResult::isFinal):
(SpeechRecognitionResult):
- Modules/speech/SpeechRecognitionResult.idl:
- WebCore.gypi:
- bindings/v8/custom/V8SpeechRecognitionEventCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp.
(WebCore):
(WebCore::V8SpeechRecognitionEvent::opaqueRootForGC):
Source/WebKit/chromium: Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407
Reviewed by Adam Barth.
Adding the new didReceiveResults method.
- public/WebSpeechRecognizerClient.h:
- src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::didReceiveResults):
(WebKit):
- src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):
Tools: Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407
Reviewed by Adam Barth.
Changing the mock to use the new results delivery API.
- DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
LayoutTests: Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407
Reviewed by Adam Barth.
Updating tests.
- fast/speech/scripted/emma-expected.txt:
- fast/speech/scripted/emma.html:
- fast/speech/scripted/speechrecognition-basics-expected.txt:
- fast/speech/scripted/speechrecognition-basics.html:
- 7:00 AM Changeset in webkit [136235] by
-
- 51 edits1 copy38 moves7 adds5 deletes in trunk
2012-11-30 Simon Hausmann <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
[Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
https://bugs.webkit.org/show_bug.cgi?id=99314
Reviewed by Tor Arne Vestbø.
This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
shared libraries.
It's a big refactoring that mostly involves moving WebCore dependent
code into QtWebKit and accessing it through exported QWebFrameAdapter
and QWebPageAdapter classes.
- 6:20 AM Changeset in webkit [136234] by
-
- 4 edits in trunk/Source/WebKit2
[EFL]Drawing artifacts while resizing the view
https://bugs.webkit.org/show_bug.cgi?id=101288
Reviewed by Kenneth Rohde Christiansen.
An Evas GL surface is recreated when the window is resized, but the update of the surface is
asynchronously done, which gives Evas a chance of painting the empty surface on the screen.
As a result, the flickering problem happens while resizing the view.
So this patch allows to create an Evas GL surface synchronously with the update of the surface.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl): Set m_pendingSurfaceResize to false.
(EwkViewImpl::displayTimerFired): Create an Evas GL surface.
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl::setNeedsSurfaceResize): Added.
(EwkViewImpl):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate): Set m_pendingSurfaceResize to true.
- 6:16 AM Changeset in webkit [136233] by
-
- 2 edits in trunk
[Qt] Build as a regular Qt module when production_build is enabled
Instead of always setting CONFIG+=force_independent. This means the
libs, headers, and documentation will end up in qtbase for developer
builds of Qt, instead of always in the QtWebKit build directory.
Reviewed by Simon Hausmann.
- Source/api.pri:
- 6:16 AM Changeset in webkit [136232] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Place the LLIntOffsetsExtractor binaries in debug/release subdirs on Mac
Otherwise we'll end up using the same LLIntAssembly.h for both build
configs of JavaScriptCore -- one of them which will be for the wrong
config.
Reviewed by Simon Hausmann.
- 5:58 AM WebKitEFLLayoutTest edited by
- (diff)
- 5:56 AM Changeset in webkit [136231] by
-
- 5 edits in trunk
[WK2] TiledBackingStore: Frame view re-layouts with wrong Fixed Visible Content Rect.
https://bugs.webkit.org/show_bug.cgi?id=103428
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-30
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Set now appropriate fixed visible content rect before layout when viewport
attributes change.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::didChangeViewportAttributes):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
LayoutTests:
Unskipped corresponding test cases for EFL WK2.
- platform/efl-wk2/TestExpectations:
- 5:44 AM Changeset in webkit [136230] by
-
- 4 edits2 adds in trunk
[EFL] Gardening after r136031 and r136142
https://bugs.webkit.org/show_bug.cgi?id=103734
Source/WebKit2:
Unreviewed, API test EWK2UnitTestBase.ewk_view_setting_encoding_custom
is asserting after r136031. So, disabling the test until bug 103732 is
fixed.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
LayoutTests:
Unreviewed, EFL gardening.
Add baselines for new test fast/ruby/position-after.html. Also
unskip passing tests.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30
- platform/efl/TestExpectations:
- platform/efl/fast/ruby/position-after-expected.png: Added.
- platform/efl/fast/ruby/position-after-expected.txt: Added.
- 5:03 AM Changeset in webkit [136229] by
-
- 4 edits in trunk/Source
[Qt] Enable WebGL by default.
https://bugs.webkit.org/show_bug.cgi?id=103731
Reviewed by Simon Hausmann.
Source/WebKit/qt:
- Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):
Source/WebKit2:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- 4:59 AM Changeset in webkit [136228] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r136227.
http://trac.webkit.org/changeset/136227
Broke the Qt bots due to version mismatch
- platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(PlatformVideoWindow::PlatformVideoWindow):
- 4:50 AM Changeset in webkit [136227] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fixed use of to-be-removed compatibility functions in QWindow.
Patch by Samuel Rødal <samuel.rodal@digia.com> on 2012-11-30
Reviewed by Simon Hausmann.
- platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(PlatformVideoWindow::PlatformVideoWindow):
- 4:47 AM Changeset in webkit [136226] by
-
- 1 edit1 add in trunk/Tools
[Qt] Unreviewed trivial fix.
Add empty.cpp back, it was removed accidentally by r129092.
- qmake/config.tests/gccdepends/empty.cpp: Added.
- 4:32 AM Changeset in webkit [136225] by
-
- 4 edits2 adds in trunk
Caret is painted horizontally in vertical writing mode when there are no visible text
https://bugs.webkit.org/show_bug.cgi?id=102359
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-30
Reviewed by Ryosuke Niwa.
Source/WebCore:
In the vertical writing mode the caret rect on an empty editable box or
an empty line is rendered as per the horizontal writing mode.
This changes though when any text is added; the caret is then displayed
in accordance with the vertical writing mode.
Test: editing/selection/caret-alignment-for-vertical-text.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
The caret rect should be transposed for the vertical writing mode. Its
width and height values need to be interchanged for it to be oriented
as per the vertical text.
LayoutTests:
- editing/selection/caret-alignment-for-vertical-text-expected.txt: Added.
- editing/selection/caret-alignment-for-vertical-text.html: Added.
Test to verify that the orientation of the caret on an empty vertical text
line or container is same as that for a non-empty container.
- 4:01 AM Changeset in webkit [136224] by
-
- 2 edits in trunk/Tools
[Qt] Add support for prepare_docs and generate_docs
Follow-up to changes in Qt in how documentation is built.
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/default_post.prf:
- 3:26 AM Changeset in webkit [136223] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
Add expected results for a new test.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-30
- platform/qt/fast/ruby/position-after-expected.png: Added.
- platform/qt/fast/ruby/position-after-expected.txt: Added.
- 3:21 AM Changeset in webkit [136222] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Page popup doesn't change mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=97454
Reviewed by Kent Tamura.
The mouse cursor should change based on the page popup content and not the main window content.
On Mac the mousemove event propagates to both the page popup and main window causing the cursor to flicker.
The change to ChromeClientImpl stops that.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::setCursor): On Mac, don't update the mouse cursor if a popup is open.
- src/WebPagePopupImpl.cpp: Implement setCursor so the mouse cursor gets set based on the page popup content.
- 2:56 AM Changeset in webkit [136221] by
-
- 4 edits2 adds2 deletes in trunk/Tools
Finally remove webkitpy.common.system.deprecated_logging
https://bugs.webkit.org/show_bug.cgi?id=103624
Reviewed by Adam Barth.
Remove the deprecated logging module and its unit tests now that such logging is not
used anymore in webkitpy.
The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
The tee class is renamed to Tee to conform with the usual guidelines.
Only unit test for the Tee class is currently provided as the OutputTee is not currently
using the webkitpy Filesystem abstraction that would make its functionality testable.
- Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
(Executive.run_and_throw_if_fail):
- Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
(Tee):
(Tee.init):
(Tee.write):
(OutputTee):
(OutputTee.init):
(OutputTee.add_log):
(OutputTee.remove_log):
(OutputTee._open_log_file):
(OutputTee._tee_outputs_to_files):
- Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
(SimpleTeeTest):
(SimpleTeeTest.test_simple_tee):
- Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
- Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
- 2:52 AM Changeset in webkit [136220] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Timeline] JS error when clicking in Memory Statistics view
https://bugs.webkit.org/show_bug.cgi?id=103486
Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2012-11-30
Reviewed by Alexander Pavlov.
The counter value can be null/undefined. Hence a check is needed
before we access the "time" property on this counter object.
No new tests required as UI related change.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onClick):
- 2:32 AM Changeset in webkit [136219] by
-
- 6 edits in trunk/LayoutTests
[Chromium] Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is failing
https://bugs.webkit.org/show_bug.cgi?id=96720
Reviewed by Kentaro Hara.
We should start tests after js-test-post.js loading to avoid missing
testRunner.waitUntilDone calls.
- fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html:
Make the outer switch a function to be called window.onload, and stop to
remove the iframe because the script in the iframe calls notifyDone.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html:
Ditto.
- fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html:
Ditto.
- fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html:
Ditto.
- platform/chromium/TestExpectations:
Move the line for
week-multiple-fields-preserve-value-after-history-back.html near to
others. We don't remove these expectations yet just in case.
- 2:19 AM Changeset in webkit [136218] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Fix compilation warnings in JavaScriptCore JIT for sh4 arch
https://bugs.webkit.org/show_bug.cgi?id=103378
Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-11-30
Reviewed by Filip Pizlo.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchTest32):
(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchMul32):
(JSC::MacroAssemblerSH4::branchSub32):
(JSC::MacroAssemblerSH4::branchOr32):
- 1:45 AM Changeset in webkit [136217] by
-
- 3 edits in trunk/Tools
[EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=103634
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30
Reviewed by Gyuyoung Kim.
Add support for PlatformWebView::simulateRightClick() and enable
WebKit2 API test HitTestResultNodeHandle.
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI):
- 1:13 AM Changeset in webkit [136216] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, fast/text/line-initial-and-final-swashes.html missing expectations on XP after r136153.
- platform/chromium/TestExpectations:
- 1:02 AM Changeset in webkit [136215] by
-
- 3 edits in trunk/Source/WebCore
Fix typos in DateTimeNumericFieldElement.cpp and DateTimeSymbolicFieldElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=103717
Reviewed by Hajime Morita.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
maximum, not maxium.
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Ditto.
- 1:01 AM Changeset in webkit [136214] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, WebKit gardening.
- platform/chromium/TestExpectations:
- 12:58 AM Changeset in webkit [136213] by
-
- 4 edits in trunk/Source
Versioning.
- 12:54 AM Changeset in webkit [136212] by
-
- 2 edits in trunk/Source/WebCore
[EFL] libwebcore_efl.a fail to link when enable webgl
https://bugs.webkit.org/show_bug.cgi?id=103610
Patch by Halton Huo <halton.huo@intel.com> on 2012-11-30
Reviewed by Gyuyoung Kim.
libwebcore_efl.a should link to X11, Xcomposite and Xrender libraries when ENABLE_WEBGL is ON
No new tests, no behavior change for layout tests.
- PlatformEfl.cmake: Append ${X11_X11_LIB}, ${X11_Xcomposite_LIB} and ${X11_Xrender_LIB} to WebCore_LIBRARIES
- 12:52 AM Changeset in webkit [136211] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the PDFPlugin build after http://trac.webkit.org/changeset/136205.
- WebCore.xcodeproj/project.pbxproj:
- 12:48 AM Changeset in webkit [136210] by
-
- 32 edits in trunk
[CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=101192
Patch by Mihai Maerean <Mihai Maerean> on 2012-11-30
Reviewed by Hajime Morita.
Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
Tests: No new tests because there is no functional change.
Source/WebCore:
- WebCore.exp.in:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled):
- dom/Document.cpp:
(WebCore::Document::cssRegionsEnabled):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(Settings):
Source/WebKit/chromium:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- public/WebSettings.h: moved setExperimentalCSSRegionsEnabled to the bottom of the interface and made it a
no-op. After this patch lands and Chromium's webkit_rev is increased, we'll remove any callers in Chromium. Once
the Chromium callers are gone and WebKit's chromium_rev is increased, we'll remove the deprecated API.
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCSSRegions):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSRegionsEnabled):
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/qt:
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
Source/WebKit/win:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setCSSRegionsEnabled):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
- 12:08 AM Changeset in webkit [136209] by
-
- 1 edit2 adds in trunk/LayoutTests
Layout Test fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html is failing
https://bugs.webkit.org/show_bug.cgi?id=103713
Unreviewed.
Rebaselining month-multiple-fields-preserve-value-after-history-back.html for Windows.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Added.