⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 9, 2012:

11:43 PM Changeset in webkit [137112] by tasak@google.com
  • 7 edits in trunk

[Shadow DOM]: reset-style-inheritance doesn't work for insertion point
​https://bugs.webkit.org/show_bug.cgi?id=103711

Reviewed by Hajime Morita.

Source/WebCore:

reset-style-inheritance can be specified by using insertion points'
attribute, e.g. <content reset-style-inheritance>.
c.f. shadow dom spec:
​https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#styles

No new tests. Updated an existing test,
fast/dom/shadow/insertion-point-resetStyleInheritance.html to cover
this feature.

  • html/HTMLAttributeNames.in:

Added HTMLNames::reset_style_inheritanceAttr.

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::parseAttribute):
Since both shadow and content elements have to support
reset-style-inheritance, added InsertionPoint::parseAttribute.
(WebCore::InsertionPoint::resetStyleInheritance):
(WebCore::InsertionPoint::setResetStyleInheritance):
Modified to update reset-style-inheritance attribute value.

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
Removed m_shouldResetStyleInheritance. Instead, use
reset-style-inheritance attribute value.

LayoutTests:

  • fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt:
  • fast/dom/shadow/insertion-point-resetStyleInheritance.html:

Added two more basic tests to cover <content reset-style-inheritance>
and <shadow reset-style-inheritance>.

11:28 PM Changeset in webkit [137111] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
​https://bugs.webkit.org/show_bug.cgi?id=104481

Patch by Alejandro Piñeiro <​apinheiro@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectable): Implement this by checking
the current state of the AtkObject.
(AccessibilityUIElement::isMultiSelectable): Implement this by
checking the current state of the AtkObject.

10:54 PM Changeset in webkit [137110] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG ArrayPush/Pop should not pass their second child as the index for blessArrayOperation()
​https://bugs.webkit.org/show_bug.cgi?id=104500

Reviewed by Oliver Hunt.

Slight across-the-board speed-up.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

10:45 PM Changeset in webkit [137109] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
​https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-09
Reviewed by Noam Rosenthal.

Send SetRootCompositingLayer message to the UI process before
flushing compositing states of layer tree.

This is in preparation for refactoring TextureMapper to work in an actor
model (​http://webkit.org/b/103854).

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

10:16 PM Changeset in webkit [137108] by loislo@chromium.org
  • 32 edits in trunk/Source/WebCore

Native Memory Instrumentation: instrument a part of RenderObject class tree.
​https://bugs.webkit.org/show_bug.cgi?id=103564

Reviewed by Eric Seidel.

Many RenderObject descendants have OwnPtrs and RefPtrs members.
Looks like we have to instrument all the RenderObject classes and visit
all the render objects instead of counting entire render arena memory.

  • WebCore.exp.in:
  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::reportRenderTreeInfo):
(WebCore):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

  • platform/PlatformMemoryInstrumentation.h:

(PlatformMemoryTypes):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::reportMemoryUsage):
(WebCore):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::reportMemoryUsage):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::reportMemoryUsage):
(WebCore):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reportMemoryUsage):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::reportMemoryUsage):
(WebCore):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::reportMemoryUsage):
(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderText.cpp:

(WebCore::RenderText::reportMemoryUsage):
(WebCore):

  • rendering/RenderText.h:

(RenderText):

  • rendering/RenderView.cpp:

(WebCore::RenderView::reportMemoryUsage):
(WebCore):

  • rendering/RenderView.h:

(RenderView):

9:39 PM Changeset in webkit [137107] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

REGRESSION (r137003): failures in MicroData tests on EFL, GTK
​https://bugs.webkit.org/show_bug.cgi?id=104469

Reviewed by Darin Adler.

Fix the regression by calling propertyNodeList on HTMLPropertiesCollection
in the named getter for HTMLCollection. It's a miracle that the old code prior to r137003
worked at all since the return type of namedItem was different.

Existing tests cover this.

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

9:09 PM Changeset in webkit [137106] by commit-queue@webkit.org
  • 38 edits in trunk/LayoutTests

[Qt] Gardening after r137006.
​https://bugs.webkit.org/show_bug.cgi?id=104432

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-09
Reviewed by Kentaro Hara.

Update existing tests that are affected by r137006.

  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
7:58 PM Changeset in webkit [137105] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r137103.
​http://trac.webkit.org/changeset/137103
​https://bugs.webkit.org/show_bug.cgi?id=104503

Didn't resolve the chrome win build bot failure, problem moved
elsewhere. (Requested by noel_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-09

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

7:39 PM Changeset in webkit [137104] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Gardening for Accelerated Compositing
​https://bugs.webkit.org/show_bug.cgi?id=104466

Unreviewed, EFL gardening.

As EFL WK1 does not support Accelerated Compositing, related cases should be skipped from layout tests.

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-12-09

  • platform/efl-wk1/TestExpectations:
7:05 PM EFLWebKit edited by Seokju Kwon
Add Web Inspector in EFL (diff)
7:02 PM Changeset in webkit [137103] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] webkit_unit_tests tests are failing on win
​https://bugs.webkit.org/show_bug.cgi?id=104502

Unreviewed test fix: disable applyScrollToScrollableArea test.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

5:59 PM Changeset in webkit [137102] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening: broken or flakey hardness perftests

fast/harness/perftests/runs-per-second-iterations.html
fast/harness/perftests/perf-runner-compute-statistics.html
fast/harness/perftests/runs-per-second-log.html

  • platform/chromium/TestExpectations:
5:17 PM Changeset in webkit [137101] by tkent@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebCore/Resources/pagepopups/pickerCommon.js

Merge 136671

Fix flickering when hiding page popup
​https://bugs.webkit.org/show_bug.cgi?id=104100

Reviewed by Kent Tamura.

Moving the page popup while hiding was causing flickering in some environments.

No new tests. Can't reproduce in layout test.

  • Resources/pagepopups/pickerCommon.js:

(hideWindow): Don't move and just resize.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/11488003

5:11 PM Changeset in webkit [137100] by tkent@chromium.org
  • 3 edits in branches/chromium/1312

Merge 136803

Source/WebCore: INPUT_MULTIPLE_FIELDS_UI: The hour, am/pm, millisecond fields should support read-only state correctly
​https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  1. The hour, am/pm, and millisecond fields should have CSS rules for [readonly]. They should be gray when they are read-only.
  2. The am/pm field should reject to set an empty value like other numeric fields do.

Tests: Add test cases to fast/forms/time/time-appearance-basic.html.

  • css/html.css: merge existing readonly rules, and add ampm, hour, and

millisecond pseudo classes.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
Reject to set empty value if it is read-only.

LayoutTests: INPUT_MULTIPLE_FIELDS_UI: The hour field and the am/pm field should support read-only state correctly
​https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  • fast/forms/time/time-appearance-basic.html:

Add test cases for step=86400 (24 hours)

  • platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/11503003

5:09 PM Changeset in webkit [137099] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] accessibility/placeholder.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98373

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The test was failing because the placeholder text was not supported and
AccessibilityUIElement::stringAttributeValue() was not implemented.

Source/WebCore:

No new tests; instead the failing test was unskipped.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Add the placeholder text as an AtkAttribute
of the AtkObject, as is done in Gtk+ 3.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
names into AtkObject attribute names
(AccessibilityUIElement::stringAttributeValue): implemented

LayoutTests:

  • platform/gtk/TestExpectations: Unskip the failing test
2:56 PM Changeset in webkit [137098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] [WebGL] Path is not resized correctly.
​https://bugs.webkit.org/show_bug.cgi?id=104458.

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2012-12-09
Reviewed by Kenneth Rohde Christiansen.

In GraphicsContext3D::paintToCanvas, we flip the contents and draw on the surface.
The operations done to flip the image (translation and scale) are done before rectangle with correct size
is added to current path. This resulted in updating pixels at wrong positions.

Covered by existing tests.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

2:53 PM Changeset in webkit [137097] by joone.hur@intel.com
  • 4 edits in trunk/Source/WebCore

[GTK][AC] build fix after r130525 and r133332
​https://bugs.webkit.org/show_bug.cgi?id=104491

Reviewed by Martin Robinson.

Build fix for Accelerated Compositing Clutter backend after r130525 and r133332.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:
  • platform/gtk/RedirectedXCompositeWindow.cpp:
  • platform/gtk/RedirectedXCompositeWindow.h:
1:45 PM Changeset in webkit [137096] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for 15 layout tests that started failing after libxml2
version used in Jhbuild was bumped in r137090.

  • platform/gtk/TestExpectations:
12:43 PM Changeset in webkit [137095] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkitgtk-1.10.2

Tagging WebKitGTK+ 1.10.2.

12:41 PM Changeset in webkit [137094] by fpizlo@apple.com
  • 18 edits
    2 adds in trunk/Source/JavaScriptCore

JSC should scale the optimization threshold for a code block according to the cost of compiling it
​https://bugs.webkit.org/show_bug.cgi?id=104406

Reviewed by Oliver Hunt.

We've long known that we want to scale the execution count threshold needed for the DFG
to kick in to scale according to some estimate of the cost of compiling that code block.
This institutes a relationship like this:

threshold = thresholdSetting * (a * sqrt(instructionCount + b) + abs(c * instructionCount) + d

Where a, b, c, d are coefficients derived from fitting the above expression to various
data points, which I chose based on looking at one benchmark (3d-cube) and from my
own intuitions.

Making this work well also required changing the thresholdForOptimizeAfterLongWarmUp
from 5000 to 1000.

This is a >1% speed-up on SunSpider, a >3% speed-up on V8Spider, ~1% speed-up on V8v7,
neutral on Octane, and neutral on Kraken.

I also out-of-lined a bunch of methods related to these heuristics, because I couldn't
stand having them defined in the header anymore. I also made improvements to debugging
code because I needed it for tuning this change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::sourceCodeOnOneLine):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::optimizationThresholdScalingFactor):
(JSC::clipThreshold):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::counterValueForOptimizeSoon):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/CodeBlock.h:
  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::hasCrossedThreshold):

  • bytecode/ReduceWhitespace.cpp: Added.

(JSC::reduceWhitespace):

  • bytecode/ReduceWhitespace.h: Added.
  • dfg/DFGCapabilities.cpp:

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):

  • dfg/DFGCapabilities.h:
  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpHeader):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):

  • runtime/Options.h:
12:32 PM WebInspector edited by zandobersek@gmail.com
Begone spam! (diff)
12:32 PM BadContent edited by zandobersek@gmail.com
Add a spamming mail address. (diff)
12:15 PM Changeset in webkit [137093] by Carlos Garcia Campos
  • 16 edits in trunk/Source/WebCore

[GTK] Use GObject casts instead of C++ cast for GObjects in DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=104492

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateCFile):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(WebKit::kit):

11:33 AM Changeset in webkit [137092] by senorblanco@chromium.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] Unreviewed. Temporarily disable a webkit_unit_tests test
that's failing on Windows.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

LayoutTests: [Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:28 AM Changeset in webkit [137091] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: do not treat object as equal to itself when logging to console
​https://bugs.webkit.org/show_bug.cgi?id=104487

Reviewed by Alexander Pavlov.

Source/WebCore:

Otherwise, mutating object in a loop results in the repeat count update instead of generation of the new preview.

Test: inspector/console/console-object-preview.html

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::isEqual):

LayoutTests:

  • inspector/console/console-object-preview-expected.txt: Added.
  • inspector/console/console-object-preview.html: Added.
11:28 AM Changeset in webkit [137090] by danw@gnome.org
  • 2 edits in trunk/Tools

[GTK] Bump libxml2 requirement in jhbuild.modules
​https://bugs.webkit.org/show_bug.cgi?id=104477

Reviewed by Martin Robinson.

Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
tests won't run if we only have libxml2 2.8.0 installed in the
jhbuild root.

  • gtk/jhbuild.modules:
11:00 AM Changeset in webkit [137089] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Remove unused code in GObject DOM bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=104490

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperties): Remove code to install event listeners and
signals.

10:55 AM Changeset in webkit [137088] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[GTK] accessibility/canvas-fallback-content.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98362

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The failure was due to platform-specific expectations of the accessible
role reported for comboboxes. The solution was conditionalizing the test.

  • accessibility/canvas-fallback-content.html: Base expected role on platform.
  • platform/gtk/TestExpectations: Unskipped the test.
  • platform/gtk/accessibility/canvas-fallback-content-expected.txt: Added.
10:40 AM Changeset in webkit [137087] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.10

Patch by Gustavo Noronha on 2012-12-09
Reviewed by Martin Robinson.

Update configure.ac and the NEWS in preparation for the 1.10.2 release.

10:39 AM Changeset in webkit [137086] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 132363 - [GTK] Typos in user-visible strings: "coordintate"
​https://bugs.webkit.org/show_bug.cgi?id=100252

Patch by Priit Laes <​plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

s/coordintate/coordinate

  • webkit/webkithittestresult.cpp:

(webkit_hit_test_result_class_init):

10:39 AM Changeset in webkit [137085] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131478 - [GStreamer] GstBuffer ref race in WebKitWebAudioSrcLoop
​https://bugs.webkit.org/show_bug.cgi?id=95833

Reviewed by Philippe Normand.

The render bus used in GStreamer's implementation of AudioDestination no longer
allocates memory for each of its channels. Rather than that, when looping, the
data is rendered into a channel-specific GstBuffer. Each buffer is then chained
to the appropriate GstPad, as has been the case before.

No new tests - there are tests covering this change but they are not yet working
on the GTK port or any other GStreamer implementation of Web Audio.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(_WebKitWebAudioSourcePrivate): Remove an unused member variable.
(webkit_web_audio_src_init): Remove an unnecessary line.
(webKitWebAudioSrcConstructed): Ditto.
(webKitWebAudioSrcLoop):

10:38 AM Changeset in webkit [137084] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131755 - [GTK] AudioBusGtk sometimes fails to load the HRTF database
​https://bugs.webkit.org/show_bug.cgi?id=99601

Reviewed by Martin Robinson.

AudioBusGtk now first lookup for the uninstalled resource files,
if the AUDIO_RESOURCES_PATH environment variable is
set. Additionally the audio file reader is now better dealing with
errors, returning an empty AudioBus in such cases and issuing
warnings on the console output. The cleanup of some member
variables was also moved to the destructor.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader): Clear and free
member variables. This was done in createBus before.
(WebCore::AudioFileReader::handleMessage): Issue warnings in case
of error and exit from the main loop so the pipeline is not
forever stuck.
(WebCore::AudioFileReader::createBus): Return an empty bus in case
of error.

  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Load uninstalled
resources first if AUDIO_RESOURCES_PATH is set.

10:25 AM WebKitGTK/1.10.x edited by kov@webkit.org
(diff)
10:22 AM WebKitGTK edited by kov@webkit.org
(diff)
10:20 AM Changeset in webkit [137083] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:19 AM Changeset in webkit [137082] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Unreviewed update for the GObject bindings after r137074 and r137078.

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(webkit_dom_test_event_target_dispatch_event):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_supplemental_method2):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):

10:16 AM Changeset in webkit [137081] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
10:14 AM Changeset in webkit [137080] by zandobersek@gmail.com
  • 11 edits in trunk/Tools

Remove testRunner.disableImageLoading()
​https://bugs.webkit.org/show_bug.cgi?id=98083

Reviewed by Gustavo Noronha Silva.

Remove the disableImageLoading methods and callback.
No tests use the method anymore and all ports except Wx
now support this behavior through overriding the
WebKitDisplayImagesKey preference.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::overridePreference): Add support for overriding the
WebKitDisplayImagesKey preference which is now the preferred way
of disabling image loading.

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
9:55 AM WebKitGTK/1.10.x edited by kov@webkit.org
Striking the commits that have been merged (diff)
9:48 AM Changeset in webkit [137079] by senorblanco@chromium.org
  • 4 edits in trunk/LayoutTests

Try to fix a finnicky reftest.
​https://bugs.webkit.org/show_bug.cgi?id=104486

Reviewed by Simon Fraser.

This reftest fails on Chromium Mac since the leftmost pixel of the 'T'
of 'Text' is clipped in composited mode, and non-clipped in software
painting. Not sure exactly why, but a lowercase 't' doesn't seem to
have this problem.

  • compositing/background-color/background-color-change-to-text-expected.html:
  • compositing/background-color/background-color-change-to-text.html:
  • platform/chromium-mac/compositing/background-color/background-color-change-to-text-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/background-color/background-color-change-to-text-expected.png: Removed.
  • platform/chromium/TestExpectations:
9:34 AM Changeset in webkit [137078] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Fix the GError check in GObject DOM bindings.

Reviewed by Xan Lopez.

Previous commit introduced a check to make sure the passed GError
is valid in all DOM methods receiving an error.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGReturnMacro): Check that the passed GError either is NULL or
the pointer has been initialized to NULL.

9:10 AM Changeset in webkit [137077] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.10

Merge 133610 - Heap-buffer-overflow in WebCore::TextTrackCueList::add
​https://bugs.webkit.org/show_bug.cgi?id=101018

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-11-06
Reviewed by Eric Carlson.

Source/WebCore:

Added an extra check to avoid using a negative array index when a cue
is added to the beginning of the list.

Test case added to LayoutTests/media/track/track-add-remove-cue.html.

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add):

LayoutTests:

Added a test case to verify that adding a cue to the beginning of a non-empty list doesn't crash.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
8:36 AM Changeset in webkit [137076] by senorblanco@chromium.org
  • 2 edits
    40 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
8:30 AM Changeset in webkit [137075] by leoyang@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adapt to name change of createNetworkBufferByCopyingData()
​https://bugs.webkit.org/show_bug.cgi?id=104449

Reviewed by Rob Buis.

Name change no new tests.

  • platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::handleRSSContent):

8:17 AM Changeset in webkit [137074] by Carlos Garcia Campos
  • 16 edits in trunk/Source/WebCore

[GTK] Clean up g_return macros usage in GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=101079

Reviewed by Xan Lopez.

Several improvements:

  • Move g_return macros at the beginning of the methods.
  • Use them only to check parameters of public API.
  • Use GObject macros to check GObjects.
  • Check also GError parameters.
  • Use early returns in kit and core methods, since they should work even if g_return macros are disabled handling NULL gracefully.
  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGReturnMacro):
(GenerateFunction):
(GenerateCFile):
(Generate):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_foo):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_exciting_function):
(webkit_dom_test_active_dom_object_post_message):
(webkit_dom_test_active_dom_object_get_exciting_attr):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_callback_with_no_param):
(webkit_dom_test_callback_callback_with_class1param):
(webkit_dom_test_callback_callback_with_class2param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_with_string_list):
(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_another_function):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_item):
(webkit_dom_test_event_target_dispatch_event):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_get_name):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_supplemental_method4):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNamedConstructor):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNode):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_void_method):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_long_method):
(webkit_dom_test_obj_long_method_with_args):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_serialized_value):
(webkit_dom_test_obj_idb_key):
(webkit_dom_test_obj_options_object):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void):
(webkit_dom_test_obj_with_script_state_obj):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context):
(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_method_with_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_class_method):
(webkit_dom_test_obj_class_method_with_optional):
(webkit_dom_test_obj_overloaded_method1):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_mutable_point_function):
(webkit_dom_test_obj_immutable_point_function):
(webkit_dom_test_obj_orange):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_variadic_string_method):
(webkit_dom_test_obj_variadic_double_method):
(webkit_dom_test_obj_variadic_node_method):
(webkit_dom_test_obj_get_read_only_long_attr):
(webkit_dom_test_obj_get_read_only_string_attr):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_short_attr):
(webkit_dom_test_obj_set_short_attr):
(webkit_dom_test_obj_get_unsigned_short_attr):
(webkit_dom_test_obj_set_unsigned_short_attr):
(webkit_dom_test_obj_get_long_attr):
(webkit_dom_test_obj_set_long_attr):
(webkit_dom_test_obj_get_long_long_attr):
(webkit_dom_test_obj_set_long_long_attr):
(webkit_dom_test_obj_get_unsigned_long_long_attr):
(webkit_dom_test_obj_set_unsigned_long_long_attr):
(webkit_dom_test_obj_get_string_attr):
(webkit_dom_test_obj_set_string_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_set_test_obj_attr):
(webkit_dom_test_obj_get_xml_obj_attr):
(webkit_dom_test_obj_set_xml_obj_attr):
(webkit_dom_test_obj_get_create):
(webkit_dom_test_obj_set_create):
(webkit_dom_test_obj_get_reflected_string_attr):
(webkit_dom_test_obj_set_reflected_string_attr):
(webkit_dom_test_obj_get_reflected_integral_attr):
(webkit_dom_test_obj_set_reflected_integral_attr):
(webkit_dom_test_obj_get_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_set_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_get_reflected_boolean_attr):
(webkit_dom_test_obj_set_reflected_boolean_attr):
(webkit_dom_test_obj_get_reflected_url_attr):
(webkit_dom_test_obj_set_reflected_url_attr):
(webkit_dom_test_obj_get_reflected_custom_integral_attr):
(webkit_dom_test_obj_set_reflected_custom_integral_attr):
(webkit_dom_test_obj_get_reflected_custom_boolean_attr):
(webkit_dom_test_obj_set_reflected_custom_boolean_attr):
(webkit_dom_test_obj_get_reflected_custom_url_attr):
(webkit_dom_test_obj_set_reflected_custom_url_attr):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_get_string_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_get_any_attribute):
(webkit_dom_test_obj_set_any_attribute):
(webkit_dom_test_obj_get_content_document):
(webkit_dom_test_obj_get_mutable_point):
(webkit_dom_test_obj_set_mutable_point):
(webkit_dom_test_obj_get_immutable_point):
(webkit_dom_test_obj_set_immutable_point):
(webkit_dom_test_obj_get_strawberry):
(webkit_dom_test_obj_set_strawberry):
(webkit_dom_test_obj_get_strict_float):
(webkit_dom_test_obj_set_strict_float):
(webkit_dom_test_obj_get_description):
(webkit_dom_test_obj_get_id):
(webkit_dom_test_obj_set_id):
(webkit_dom_test_obj_get_hash):
(webkit_dom_test_obj_get_replaceable_attribute):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):
(webkit_dom_test_serialized_script_value_interface_get_value):
(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_ports):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):

7:56 AM Changeset in webkit [137073] by mihnea@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskip a skipped test for which i have added expectation in ​http://trac.webkit.org/changeset/135851.

  • platform/gtk-wk2/TestExpectations:
7:48 AM Changeset in webkit [137072] by Carlos Garcia Campos
  • 17 edits in trunk/Source/WebCore

[GTK] Use a private struct and placement new syntax in GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=101074

Reviewed by Xan Lopez.

It allows to use RefPtr for the wrapped object and it simplifies
the code. Only the classes deriving from WebKitDOMObject keep a
reference of the wrapped object in a private struct. The wrapped
object is added to the cache in GObjectClass::constructor() and
removed in GObjectClass::finalize().

  • bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::createWrapper):
(WebKit::kit):
(WebKit::wrapEventTarget):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetParentImplClassName):
(GenerateProperties):
(GenerateCFile):
(Generate):
(WriteData):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(_WebKitDOMTestActiveDOMObjectPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_finalize):
(webkit_dom_test_active_dom_object_constructor):
(webkit_dom_test_active_dom_object_class_init):
(webkit_dom_test_active_dom_object_init):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(_WebKitDOMTestCallbackPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_constructor):
(webkit_dom_test_callback_class_init):
(webkit_dom_test_callback_init):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(_WebKitDOMTestCustomNamedGetterPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_constructor):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(_WebKitDOMTestEventConstructorPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_constructor):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(_WebKitDOMTestEventTargetPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_finalize):
(webkit_dom_test_event_target_constructor):
(webkit_dom_test_event_target_class_init):
(webkit_dom_test_event_target_init):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(_WebKitDOMTestExceptionPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_constructor):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(_WebKitDOMTestInterfacePrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_finalize):
(webkit_dom_test_interface_constructor):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_init):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(_WebKitDOMTestMediaQueryListListenerPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):
(webkit_dom_test_media_query_list_listener_finalize):
(webkit_dom_test_media_query_list_listener_constructor):
(webkit_dom_test_media_query_list_listener_class_init):
(webkit_dom_test_media_query_list_listener_init):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(_WebKitDOMTestNamedConstructorPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNamedConstructor):
(webkit_dom_test_named_constructor_finalize):
(webkit_dom_test_named_constructor_constructor):
(webkit_dom_test_named_constructor_class_init):
(webkit_dom_test_named_constructor_init):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNode):
(webkit_dom_test_node_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(_WebKitDOMTestObjPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_constructor):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:

(_WebKitDOMTestOverloadedConstructorsPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestOverloadedConstructors):
(webkit_dom_test_overloaded_constructors_finalize):
(webkit_dom_test_overloaded_constructors_constructor):
(webkit_dom_test_overloaded_constructors_class_init):
(webkit_dom_test_overloaded_constructors_init):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(_WebKitDOMTestSerializedScriptValueInterfacePrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_constructor):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_init):

5:26 AM Changeset in webkit [137071] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] accessibility/label-for-control-hittest.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98368

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

Tools:

The test was failing because AccessibilityUIElement::elementAtPoint was
not implemented.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::elementAtPoint): implemented

LayoutTests:

Unskip the test having implemented AccessibilityUIElement::elementAtPoint.

  • platform/gtk/TestExpectations: unskip accessibility/label-for-control-hittest.html
3:41 AM Changeset in webkit [137070] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 compositing/background-color ref tests introduced
in r137006 as failing for WK2 EFL.

  • platform/efl-wk2/TestExpectations:
3:22 AM Changeset in webkit [137069] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline 2 media/track test cases after r136991.

  • platform/efl/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/efl/media/track/track-cue-rendering-vertical-expected.txt:
3:06 AM Changeset in webkit [137068] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark inspector/styles/import-pseudoclass-crash.html as crashing
since it is hitting m_childRuleCSSOMWrappers.size() == ruleCount
assertion after r136948.

  • platform/efl-wk2/TestExpectations:
2:43 AM Changeset in webkit [137067] by jonlee@apple.com
  • 15 edits
    2 deletes in trunk

[WK2] Move button image to injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=104107
<rdar://problem/12813842>

Reviewed by Simon Fraser.

Source/WebCore:

Update RenderSnapshottedPlugIn to retrieve the start button image from the ChromeClient. Expand the
kinds of images available for use as the button. Try to find the best sized button to use for the plug-in,
otherwise use no image at all.

  • rendering/RenderSnapshottedPlugIn.h: Add an enum representing the size to use. Remove the label rect

variable since it is unneeded.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::startLabelImage): Maintain a cache of the images for reuse. Index into the
array using the enum. If the image has been loaded, or an attempt was made, then return the result. Otherwise
ask the chrome client for the image.
(WebCore::RenderSnapshottedPlugIn::paintLabel): Determine the proper label to use, and paint if the image is
available.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Compare the label size with the provided content
box. Return a LayoutRect representing the label's placement. If it doesn't fit, return an empty rect.
(WebCore::RenderSnapshottedPlugIn::layout): The rect is not needed because it is all determined at paint time.

  • page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelImage): Added.

  • WebCore.exp.in: Expose GraphicsContext::drawNativeImage() for WKImageCG.cpp.
  • WebCore.xcodeproj/project.pbxproj: Remove start button assets.
  • Resources/startButton.png: Removed.
  • Resources/​startButton@2x.png: Removed.

Source/WebKit2:

Rely on the injected bundle to create the image used for the button in snapshotted plug-ins.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelImage): Forward the call to the injected bundle UI client.

  • WebProcess/WebCoreSupport/WebChromeClient.h: Implement plugInStartLabelImage().
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelImage): Convert the WebCore enums to WK API enums.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Expose a new callback to generate the button image.
  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage): Refactor to use GraphicsContext methods so that the image is flipped appropriately.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.

2:39 AM Changeset in webkit [137066] by Christophe Dumez
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Skip fast/text/hyphenate-locale.html since the EFL port does
not support hyphenation. Also remove wrong expected results
for WK1 EFL.

  • platform/efl-wk1/fast/text/hyphenate-locale-expected.png: Removed.
  • platform/efl-wk1/fast/text/hyphenate-locale-expected.txt: Removed.
  • platform/efl/TestExpectations:
2:28 AM Changeset in webkit [137065] by Christophe Dumez
  • 10 edits in trunk/LayoutTests

Unreviewing gardening.

Rebaseline several compositing test cases after r137051.

  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
1:59 AM Changeset in webkit [137064] by commit-queue@webkit.org
  • 15 edits in trunk

Unreviewed, rolling out r137053.
​http://trac.webkit.org/changeset/137053
​https://bugs.webkit.org/show_bug.cgi?id=104471

Broke PerformanceTests/Parser/html-parser.html (Requested by
mkwst_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-09

Source/WebCore:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:
1:54 AM Changeset in webkit [137063] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after WebGL
was enabled for EFL port in r137050.

  • platform/efl/fast/js/global-constructors-expected.txt:
1:42 AM Changeset in webkit [137062] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Adding failure expectation for several MicroData test cases
that started failing after r137003.

  • platform/efl/TestExpectations:
1:24 AM Changeset in webkit [137061] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 133717 - Crash due to column span under button element
​https://bugs.webkit.org/show_bug.cgi?id=101402

Reviewed by Abhishek Arya.

Source/WebCore:

When there is a column-spanning child of a RenderButton
splitBlocks() must split the RenderButton as well as its
only permitted direct child, the anonymous block referenced
by m_inner. A crash was occurring because splitBlocks()
calls addChildIgnoringAnonymousColumnBlocks() to add the
cloned m_inner to the cloned RenderButton, which meant the
m_inner for the cloned RenderButton was not being set even
though a child was being added. This violates state
assumptions in the RenderButton code.

This patch prevents any descendants of RenderButton from
spanning columns. Also, it adds a precautionary check in
RenderButton::removeChild() to mitigate problems if similar
state problems are found in future.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::removeChild):

LayoutTests:

Test creates crashing condition for bug 101402.

  • fast/block/colspan-under-button-crash.html: Added.
  • fast/block/colspan-under-button-crash-expected.txt: Added.
1:18 AM Changeset in webkit [137060] by kov@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 132983 - Delaying 'change' and 'input' event dispatching during HTMLInputElement::setValue
​https://bugs.webkit.org/show_bug.cgi?id=100772

Reviewed by Abhishek Arya.

Source/WebCore:

'change' and 'input' events are asynchronous and not
cancelable. We can use ScopedEvent.

Test: fast/forms/range/range-type-change-onchange.html

  • dom/Node.cpp:

(WebCore::Node::dispatchChangeEvent): Use dispatchScopedEvent.
(WebCore::Node::dispatchInputEvent): Ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
Make a scope to delay event dispatching.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent): Ditto.

LayoutTests:

  • fast/forms/range/range-type-change-onchange-expected.txt: Added.
  • fast/forms/range/range-type-change-onchange.html: Added.
1:04 AM Changeset in webkit [137059] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a failure expectation for an accelerated compositing layout test introduced in r136959.
Adding failure expectations for MicroData layout tests that regressed in r137003.

  • platform/gtk/TestExpectations:
12:13 AM Changeset in webkit [137058] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Fix unused parameter compile warnings
​https://bugs.webkit.org/show_bug.cgi?id=104463

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-12-09
Reviewed by Kentaro Hara.

Remove compile warning messages by omitting parameter name.

Source/WebCore:

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::GraphicsSurface):

Source/WebKit2:

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createCanvas):

Dec 8, 2012:

11:46 PM Changeset in webkit [137057] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[CMake] Add CMake style checker
​https://bugs.webkit.org/show_bug.cgi?id=104240

Patch by Halton Huo <​halton.huo@intel.com> on 2012-12-08
Reviewed by Eric Seidel.

The CMake style checker is followed by existing style checkers like cpp, python.
Unit test is added as well.

  • Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)

(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checkers/cmake.py: Added.

(CMakeChecker):
(CMakeChecker.init):
(CMakeChecker.check):
(CMakeChecker._process_line):
(CMakeChecker._check_trailing_whitespace):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):
(CMakeChecker._check_indent):

  • Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.

(CMakeCheckerTest):
(CMakeCheckerTest.test_init):
(CMakeCheckerTest.test_init._mock_handle_style_error):
(CMakeCheckerTest.test_check):
(CMakeCheckerTest.test_check._mock_handle_style_error):

9:48 PM Changeset in webkit [137056] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Gardening for WebGL
​https://bugs.webkit.org/show_bug.cgi?id=104464

Unreviewed, EFL gardening.

As EFL WK1 does not support WebGL, it should be skipped from layout tests.

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-12-08

  • platform/efl-wk1/TestExpectations:
7:02 PM Changeset in webkit [137055] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Build break if SVG is disabled
​https://bugs.webkit.org/show_bug.cgi?id=104452

Patch by Rakesh KN <​rakeshchaitan@gmail.com> on 2012-12-08
Reviewed by Darin Adler.

Build breaking after r136975 if SVG is disabled.
No new tests required.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
As document is not an argument anymore, removing UNUSED_PARAM against it.

  • rendering/FilterEffectRenderer.h:

Added forward declaration for RenderObject.

6:30 PM Changeset in webkit [137054] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Compiling WTF outside of WebKit failed on Windows
​https://bugs.webkit.org/show_bug.cgi?id=100201

Reviewed by Darin Adler.

Explicitly use the Unicode variants of the Windows API to
allow building the WTF library without the UNICODE define.

  • wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

5:54 PM Changeset in webkit [137053] by mkwst@chromium.org
  • 15 edits in trunk

Log to console when script is blocked by sandbox attributes.
​https://bugs.webkit.org/show_bug.cgi?id=104365

Reviewed by Ojan Vafai.

Source/WebCore:

Adds a console message to cover script execution blocked within the
context of a sandboxed frame which lacks the 'allow-scripts' permission.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

Log a warning when sandboxing flags block script execution.

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:

Rebaselining tests with new expectations.

4:03 PM Changeset in webkit [137052] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

Add appearance tests for input[type=datetime-local]
​https://bugs.webkit.org/show_bug.cgi?id=104439

Reviewed by Kentaro Hara.

  • fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-basic.html: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-l10n.html: Added.
  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png: Added.
  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:

Added.
The placeholder strings "yyyy" "mm" "dd" are expected to be
non-localized because they don't support
setLangAttributeAwareFormControlUIEnabled(true).
Note that sub-fields order of filled-outs input and empty inputs
in ar-eg and he-il locales are mismatched. It will be addressed in
webkit.org/b/104438.

  • platform/chromium/TestExpectations:
3:46 PM Changeset in webkit [137051] by commit-queue@webkit.org
  • 90 edits
    38 copies
    20 adds in trunk

Use background color for GraphicsLayers when applicable
​https://bugs.webkit.org/show_bug.cgi?id=103786

Source/WebCore:

Updated RenderLayerBacking to call GraphicsLayer::setContentsToBackgroundColor when the following conditions take place:

  1. The layer doesn't paint its own content, other than background/decoration.
  2. There are no borders or other box decorations (border radius, borders, outline, shadow etc.)
  3. The image has only a background color, and no background image.
  4. background-composite is set to source-over, and background-clip is anything apart from text.
  5. The port supports setContentsToBackgroundColor.

This allows any implementation of GraphicsLayer that supports setContentsToBackgroundColor to avoid allocating a backing store
for that layer, but instead draw that solid color directly.
In addition to setting the background color, the layer's contentsRect needs to be adjusted, since the default contents rect of
a layer is not always equivalent to the rect where the background is supposed to be painted, which is derived from the box's
background-clip property.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-08
Reviewed by Simon Fraser.

Tests: compositing/background-color/background-color-alpha.html

compositing/background-color/background-color-change-to-text.html
compositing/background-color/background-color-composite.html
compositing/background-color/background-color-container.html
compositing/background-color/background-color-content-clip.html
compositing/background-color/background-color-padding-change.html
compositing/background-color/background-color-padding-clip.html
compositing/background-color/background-color-simple.html
compositing/background-color/background-color-text-change.html
compositing/background-color/background-color-text-clip.html

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

Allows different implementation of GraphicsLayer to identify whether they implement setContentsToBackgroundColor.
Currently only the MAC implementation and TextureMapper falls under that category.

  • rendering/RenderBox.h:

(WebCore::RenderBox::paddingBoxRect):

Added paddingBoxRect to compliment borderBoxRect and contentsBoxRect. paddingBoxRect corresponds to
background-clip: padding.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

Update the background color if needed, for every configuration change.
This should accomodate the old behavior for full-screen, while enabling background color changes for other layers.

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Move the contentsRect logic to updateContentsRect.

(WebCore::RenderLayerBacking::updateContentsRect):

Use the background box when directly compositing backgrounds.

(WebCore::RenderLayerBacking::updateBackgroundColor):

Set the background color if applicable, otherwise set to trasnparent and clear.
This was not needed in the past because background colors were only used for the special case of full-screen.

(WebCore::supportsDirectBoxDecorationsComposition):

Helper function to determine whether a particular background can be directly composited. Right now only
background color can be composited, and only if the GraphicsLayer implementation supports background colors.
Also we don't yet support background-clip: text and any background-composite other than source-over.

(WebCore::RenderLayerBacking::paintsBoxDecorations):

Apply the new supportsDirectBoxDecorationsComposition logic.

(WebCore::RenderLayerBacking::contentsBox):

Remove unnecessary local variable.

(WebCore::backgroundRectForBox):
(WebCore::RenderLayerBacking::backgroundBox):

Figure out the correct rect for the GraphicsLayer's contentsRect, based on the renderer's backgroundClip.
The rectangle has to be adjusted based on the composited layer offset, and snapped to an IntRect as
GraphicsLayer::contentsRect expects snapped pixels.

LayoutTests:

Created new tests for composited background colors, update existing tests that are affected by the change,
and created platform-specific overrides for Chromium, since it does not yet support composited background
colors.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-08
Reviewed by Simon Fraser.

  • compositing/background-color/background-color-alpha-expected.html: Added.
  • compositing/background-color/background-color-alpha.html: Added.
  • compositing/background-color/background-color-change-to-text-expected.html: Added.
  • compositing/background-color/background-color-change-to-text.html: Added.
  • compositing/background-color/background-color-composite-expected.html: Added.
  • compositing/background-color/background-color-composite.html: Added.
  • compositing/background-color/background-color-container-expected.html: Added.
  • compositing/background-color/background-color-container.html: Added.
  • compositing/background-color/background-color-content-clip-expected.html: Added.
  • compositing/background-color/background-color-content-clip.html: Added.
  • compositing/background-color/background-color-padding-change-expected.html: Added.
  • compositing/background-color/background-color-padding-change.html: Added.
  • compositing/background-color/background-color-padding-clip-expected.html: Added.
  • compositing/background-color/background-color-padding-clip.html: Added.
  • compositing/background-color/background-color-simple-expected.html: Added.
  • compositing/background-color/background-color-simple.html: Added.
  • compositing/background-color/background-color-text-change-expected.html: Added.
  • compositing/background-color/background-color-text-change.html: Added.
  • compositing/background-color/background-color-text-clip-expected.html: Added.
  • compositing/background-color/background-color-text-clip.html: Added.

Added new tests for the specific functionality added, with the edge cases regarding composited
backgrounds.

  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:

Updated existing tests that now print different layer-tree results.

  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-overlap-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-perspective-expected.txt.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Copied from LayoutTests/compositing/columns/composited-in-paginated-expected.txt.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Copied from LayoutTests/compositing/geometry/ancestor-overflow-change-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt.
  • platform/chromium/compositing/geometry/clip-expected.txt: Copied from LayoutTests/compositing/geometry/clip-expected.txt.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Copied from LayoutTests/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Copied from LayoutTests/compositing/geometry/flipped-writing-mode-expected.txt.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Copied from LayoutTests/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-transformed-expected.txt.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Copied from LayoutTests/compositing/iframes/invisible-nested-iframe-hide-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-and-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Copied from LayoutTests/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-animation-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-clipping-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transforms-expected.txt.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Copied from LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-nested-expected.txt.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/translatez-overlap-expected.txt.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Copied from LayoutTests/compositing/overflow-trumps-transform-style-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-relative-expected.txt.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Copied from LayoutTests/css3/filters/filtered-compositing-descendant-expected.txt.

Create chromium-specific results since chromium does not yet support setContentsToBackgroundColor.

3:13 PM Changeset in webkit [137050] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Enable WebGL by default.
​https://bugs.webkit.org/show_bug.cgi?id=102991.

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2012-12-08
Reviewed by Kenneth Rohde Christiansen.

Tools:

Enable WebGL by default.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Update TestExpectations file to enable WebGL tests.

  • platform/efl/TestExpectations:
3:07 PM Changeset in webkit [137049] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Google results page rendering issue with RTL languages like arabic/hebrew
​https://bugs.webkit.org/show_bug.cgi?id=104451

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by Rob Buis.

PR: 206372
On Google results page, we layout the contents at the width of 833.
However, "appbar" and "top_nav" elements which have width 980 cause
overflow during the last layout and make the contents width larger.
The other renderers still stay at the old width unfortunately which
results in blank areas on the left side of the Google results RTL page.
Give it a chance to request another layout if overflow exceeds the
contents size and the page doesn't have virtual viewport, as this
layout will pick up the absolute visible overflow width within
DEFAULT_MAX_LAYOUT_WIDTH and update the other renderers.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:47 PM Changeset in webkit [137048] by Patrick Gansterer
  • 7 edits in trunk/Source/WebCore

Build fix for WinCE after r137011.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::drawBitmap):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::BufferedImage::draw):
(WebCore::ImageBuffer::draw):

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
(WebCore::BitmapImage::draw):

  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::draw):

  • platform/graphics/wince/SharedBitmap.h:
1:19 PM Changeset in webkit [137047] by gavinp@chromium.org
  • 1 edit in trunk/Source/WebCore/loader/LinkLoader.cpp

Unreviewed. Fix build after r137045 for !ENABLE(LINK_PRERENDER) platforms.

A new guard was needed.

I am sorry.

12:34 PM Changeset in webkit [137046] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enforce selection of last work when triggering caret based selection
​https://bugs.webkit.org/show_bug.cgi?id=104447

Reviewed by Rob Buis.

PR 249225.

When the selection has reached the end of an input field,
ensure the last word is selected by adjusting the caret.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
(WebKit):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectObject):

12:03 PM Changeset in webkit [137045] by gavinp@chromium.org
  • 26 edits
    1 copy
    4 adds in trunk/Source

Add status events on <link rel=prerender> elements.
​https://bugs.webkit.org/show_bug.cgi?id=96474

Reviewed by Adam Barth.

The new PrerenderStatusEvent is sent to link elements when
prerenders are started by the embedder, and also sent when they
are stopped. Pages using this feature can now serialize launching
prerenders, and track timing performance.

Source/Platform:

  • chromium/public/WebPrerender.h:

(WebKit::WebPrerender::WebPrerender):
(WebKit::WebPrerender::operator=):
(WebPrerender):

Source/WebCore:

Tested in a new WebKitUnitTest for the chromium port.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:

(WebCore):

  • html/HTMLLinkElement.cpp:

(WebCore):
(WebCore::HTMLLinkElement::didStartLinkPrerender):
(WebCore::HTMLLinkElement::didStopLinkPrerender):
(WebCore::HTMLLinkElement::didSendLoadForLinkPrerender):
(WebCore::HTMLLinkElement::didSendDOMContentLoadedForLinkPrerender):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::didStartPrerender):
(WebCore):
(WebCore::LinkLoader::didStopPrerender):
(WebCore::LinkLoader::didSendLoadForPrerender):
(WebCore::LinkLoader::didSendDOMContentLoadedForPrerender):
(WebCore::LinkLoader::loadLink):

  • loader/LinkLoader.h:

(LinkLoader):

  • loader/LinkLoaderClient.h:

(LinkLoaderClient):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::render):

  • loader/Prerenderer.h:

(WebCore):
(Prerenderer):

  • platform/PrerenderClient.h: Copied from Source/WebCore/loader/LinkLoaderClient.h.

(WebCore):
(PrerenderClient):
(WebCore::PrerenderClient::~PrerenderClient):

  • platform/PrerenderHandle.h:

(WebCore):
(PrerenderHandle):

  • platform/chromium/Prerender.cpp:

(WebCore::Prerender::Prerender):
(WebCore::Prerender::removeClient):
(WebCore):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
(WebCore::Prerender::didStartPrerender):
(WebCore::Prerender::didStopPrerender):
(WebCore::Prerender::didSendLoadForPrerender):
(WebCore::Prerender::didSendDOMContentLoadedForPrerender):

  • platform/chromium/Prerender.h:

(WebKit):
(WebCore):
(Prerender):

  • platform/chromium/PrerenderHandle.cpp:

(WebCore::PrerenderHandle::create):
(WebCore::PrerenderHandle::PrerenderHandle):
(WebCore::PrerenderHandle::~PrerenderHandle):
(WebCore::PrerenderHandle::removeClient):
(WebCore):

  • platform/chromium/support/WebPrerender.cpp:

(WebKit::WebPrerender::toPrerender):
(WebKit):
(WebKit::WebPrerender::assign):
(WebKit::WebPrerender::isNull):
(WebKit::WebPrerender::didStartPrerender):
(WebKit::WebPrerender::didStopPrerender):
(WebKit::WebPrerender::didSendLoadForPrerender):
(WebKit::WebPrerender::didSendDOMContentLoadedForPrerender):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebView):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/PrerenderingTest.cpp: Added.
  • tests/data/prerender/multiple_prerenders.html: Added.
  • tests/data/prerender/single_prerender.html: Added.
11:42 AM Changeset in webkit [137044] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Martin Robinson.

Update the Chromium/Chrome version we advertise in our User-Agent
string to version 25, to better match our current reality.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

11:18 AM Changeset in webkit [137043] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk/webkit/webkitwebsettings.cpp

Update the Chromium version we expose in our User-Agent to match the stable one used when we branched

11:18 AM Changeset in webkit [137042] by kov@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.10

Merge 133155 - SVG as an image may recreate the renderer on zoom
​https://bugs.webkit.org/show_bug.cgi?id=99508

Reviewed by Abhishek Arya.

Source/WebCore:

The SVGImage code, when SVG is used in <img> tags, caches the renderer
at the start of the painting method and re-uses the pointer at the end
of the method. However, when the page is zoomed the renderer may be
detached mid-method, thus leaving a stray pointer. The fix is to
re-fetch the pointer after the zooms.

Test: svg/as-image/img-zoom-svg-stylesheet.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer): Re-fetch the renderer after
the zoom operations.

LayoutTests:

Test and ref-test-result for zooming of SVG content when loaded as-image, and the svg is actually a css file.

  • svg/as-image/img-zoom-svg-stylesheet-expected.html: Added.
  • svg/as-image/img-zoom-svg-stylesheet.html: Added.
  • svg/as-image/resources/svg-stylesheet-for-zoom.svg: Added.
10:27 AM Changeset in webkit [137041] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove about:credits
​https://bugs.webkit.org/show_bug.cgi?id=104399

Patch by Chris Hutten-Czapski <​chutten@rim.com> on 2012-12-08
Reviewed by Rob Buis.

Just a simple removal.

  • WebKitSupport/AboutData.cpp:
10:10 AM Changeset in webkit [137040] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

[as_IN] New translation for WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=103419

Patch by Nilamdyuti Goswami <​nilamdyuti@gmail.com> on 2012-12-08
Rubber-stamped by Gustavo Noronha.

  • as.po: Added.
9:59 AM Changeset in webkit [137039] by commit-queue@webkit.org
  • 90 edits
    58 deletes in trunk

Unreviewed, rolling out r137006.
​http://trac.webkit.org/changeset/137006
​https://bugs.webkit.org/show_bug.cgi?id=104446

Broke plugin painting on Mac (youtube, etc.) (Requested by
thorton_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-08

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • rendering/RenderBox.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::updateBackgroundColor):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::contentsBox):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

LayoutTests:

  • compositing/background-color/background-color-alpha-expected.html: Removed.
  • compositing/background-color/background-color-alpha.html: Removed.
  • compositing/background-color/background-color-change-to-text-expected.html: Removed.
  • compositing/background-color/background-color-change-to-text.html: Removed.
  • compositing/background-color/background-color-composite-expected.html: Removed.
  • compositing/background-color/background-color-composite.html: Removed.
  • compositing/background-color/background-color-container-expected.html: Removed.
  • compositing/background-color/background-color-container.html: Removed.
  • compositing/background-color/background-color-content-clip-expected.html: Removed.
  • compositing/background-color/background-color-content-clip.html: Removed.
  • compositing/background-color/background-color-padding-change-expected.html: Removed.
  • compositing/background-color/background-color-padding-change.html: Removed.
  • compositing/background-color/background-color-padding-clip-expected.html: Removed.
  • compositing/background-color/background-color-padding-clip.html: Removed.
  • compositing/background-color/background-color-simple-expected.html: Removed.
  • compositing/background-color/background-color-simple.html: Removed.
  • compositing/background-color/background-color-text-change-expected.html: Removed.
  • compositing/background-color/background-color-text-change.html: Removed.
  • compositing/background-color/background-color-text-clip-expected.html: Removed.
  • compositing/background-color/background-color-text-clip.html: Removed.
  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/content-gains-scrollbars-expected.txt:
  • compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • compositing/overflow/resize-painting-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Removed.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Removed.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Removed.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Removed.
  • platform/chromium/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Removed.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Removed.
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/compositing/overflow/resize-painting-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Removed.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/mac/compositing/iframes/resizer-expected.txt:
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
9:42 AM Changeset in webkit [137038] by kov@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 132856 - feImage should not be allowed to self reference
​https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

Add cycle detection for SVG filter application, and also fix a problem
with graphics context restore when filters are applied. This also
converts the flags in FilterData to a state tracking system, as the
number of flags was getting messy and only one flag is valid at any given time.

Test: svg/filters/feImage-self-and-other-referencing.html

  • rendering/svg/RenderSVGResourceFilter.cpp: Convert to new FilterData

state management and enable cycle detection.
(WebCore):
(WebCore::RenderSVGResourceFilter::removeClientFromCache): Change isBuilt and markedForRemoval flags to state enums.
(WebCore::RenderSVGResourceFilter::applyResource): Change flags to state enums and detect cycles.
(WebCore::RenderSVGResourceFilter::postApplyResource): Change flags to state and add handling
for the various states.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Change isBuilt flag to state enums.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData):
(FilterData): Convert to a state tracking system.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced): Add a block around the
SVGRenderingContext so that it applies the filter and reverts the
context before the calling method restores the context.

LayoutTests:

Additional test case for situations when the filter is applied to multiple objects that it also references.

  • svg/filters/feImage-self-and-other-referencing-expected.html: Added.
  • svg/filters/feImage-self-and-other-referencing.html: Added.

Conflicts:

Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
Source/WebCore/rendering/svg/RenderSVGResourceFilter.h

9:41 AM Changeset in webkit [137037] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 131488 - An feImage that tries to render itself should be stopped
​https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

An SVG feImage filter element will accept, as the src to render, an
SVG document that makes use of the feImage itself. This causes the
feImage to try to draw itself while already in the process of drawing
itself. Various problems arise from this. The invariant we wish to
maintain is that no element in the src tree of an feImage element
refers to that feImage.

This patch adds a flag to all FilterData objects that tracks whether or
not the filter is currently applying itself, and avoids applying the
filter recursively.

While it may seem better to catch this problem when the src is set, or
when the filter is built, that turns out to be challenging and
inefficient. Say we choose to test when the src atttribute is set. To
do so would require looking through all of the DOM nodes that will be
rendered for the src, finding all resources used, and checking if any
of them make use fo the feImage element that we are setting the source
for. The infrastructure is not in place to do that, and it would
involve walking a potentially very large portion of the DOM in order
to detect a very rare situation. Note that it is not enough just to
walk the DOM directly under the src; we also need to recursively follow any
resource links to see if they use the feImage (e.g. patterns or
masks or use or ...).

If we instead try to use the renderer node to find self referencing,
we need to recursively walk a potentially very large render tree,
tracing all resources in search of the feImage. This would need to be
done every time the filter is built, which is again a significant
overhead for a situation that is very unlikely to occur. And we do not
have methods that make it easy to find feImage filter effect nodes; they are
hidden behind filter resource nodes.

Hence the runtime check to catch the problem. The check must be in
FilterData and RenderSVGResourceFilter code because we must prevent
the destruction of the feImage when we encounter it recursively.

This patch also renames FilterData::builded to FilterData::isBuilt.

Test: svg/filters/feImage-self-referencing.html

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::ApplyingFilterEffectGuard): Guard to ensure that, in the future, we always
clear the isApplying flag even if the postApplyResource method returns early.
(WebCore::RenderSVGResourceFilter::applyResource): Do not apply a resource that is already applying and
rename builded to isBuilt.
(WebCore::RenderSVGResourceFilter::postApplyResource): Mark a resource as applying and clear after
it is done. Abort if a resource is already applying when the method begins. Rename builded to isBuilt.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Rename builded to isBuilt.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData):
(FilterData): Add isApplying and rename builded to isBuilt.

LayoutTests:

Ref-test to verify that an feImage that tries to draw itself will not
crash. This test must be render in order to verify the result. Do not
convert to dumpAstext.

  • svg/filters/feImage-self-referencing-expected.html: Added.
  • svg/filters/feImage-self-referencing.html: Added.

Conflicts:

Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp

9:30 AM Changeset in webkit [137036] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit2

Merge 137033 - Unreviewed. Make building the WebKit2 GIR file conditional on building the WebKit2 library.

  • GNUmakefile.am:
9:16 AM Changeset in webkit [137035] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[EFL][WK2] Add Remote Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=98705

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-08
Reviewed by Gyuyoung Kim.

.:

Prepare inspectorPageIndex.html for remote web inspector.

  • Source/PlatformEfl.cmake:

Source/WebKit2:

Add Remote Web Inspector to EFL port.
The WebInspectorSever will be started during WebKit context initialization.
The IP address and port number for the server can be set in WEBKIT_INSPECTOR_SERVER.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • UIProcess/InspectorServer/WebInspectorServer.h:

(WebInspectorServer):

  • UIProcess/InspectorServer/WebSocketServer.h:

(WebSocketServer):

  • UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp: Added.

(WebKit):
(WebKit::inspectorResourcePath):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:

(WebKit::connectionCallback):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::initializeInspectorServer):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • config.h:
9:13 AM Changeset in webkit [137034] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Merge Hindi translation of webkit
​https://bugs.webkit.org/show_bug.cgi?id=97410

Patch by Rajesh Ranjan <​rajeshkajha@yahoo.com> on 2012-12-08
Rubber-stamped by Gustavo Noronha.

  • hi.po: Added.
8:41 AM Changeset in webkit [137033] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Make building the WebKit2 GIR file conditional on building the WebKit2 library.

  • GNUmakefile.am:
8:08 AM Changeset in webkit [137032] by kov@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed trivial space fix to silence an automake warning.

  • GNUmakefile.list.am:
8:01 AM Changeset in webkit [137031] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove no-op line in WebPage.cpp
​https://bugs.webkit.org/show_bug.cgi?id=104385

Reviewed by Antonio Gomes.

Remove self-assignment no-op line. Must have been left when I removed the
mapFromTransformed part.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):

7:52 AM Changeset in webkit [137030] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
6:41 AM Changeset in webkit [137029] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:48 AM Changeset in webkit [137028] by james.wei@intel.com
  • 2 edits in trunk/Source/WebCore

Remove incorrect ASSERT for m_error in CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=104333

Reviewed by Nate Chapin.

This assertion was brought in ​https://bugs.webkit.org/show_bug.cgi?id=100901
When the request is canceled, m_error.isNull() should be true.

run webkit_unit_tests Debug build.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::stopLoading):

3:05 AM Changeset in webkit [137027] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt Linux Minimal build fix after r136975.

  • dom/ElementRareData.h:

(ElementRareData):

2:52 AM Changeset in webkit [137026] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt Linux Minimal build fix attempt after r136959.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):

2:44 AM Changeset in webkit [137025] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137003. Wrap Microdata only sections with ENABLE(MICRODATA).

  • dom/NodeRareData.h:

(NodeRareData):

2:37 AM Changeset in webkit [137024] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137003. Wrap NodeMutationObserverData with ENABLE(MUTATION_OBSERVERS).

  • dom/NodeRareData.h:

(NodeRareData):

2:22 AM Changeset in webkit [137023] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Remove unused headers
​https://bugs.webkit.org/show_bug.cgi?id=104428

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-08
Reviewed by Kentaro Hara.

Header inclusion cleanup.
Remove <WebCore/NotImplement.h>.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebMutableURLRequest.cpp:

Source/WebKit2:

  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/qt/ShareableBitmapQt.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
2:01 AM Changeset in webkit [137022] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for ENABLE(SVG) && !ENABLE(FILTERS) after r136975.

  • rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::buildCachedResources):

1:33 AM WebKitGTK edited by Simon Pena
Updated reference to IRC channel (diff)
1:22 AM Changeset in webkit [137021] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

HTMLTemplateElement.innerHTML should be parsed into the template contents owner document
​https://bugs.webkit.org/show_bug.cgi?id=104407

Reviewed by Eric Seidel.

Source/WebCore:

When parsing via innerHTML, ensure that all operations (including the
initial fragment creation) occur in the proper document to avoid,
e.g., images loading while being parsed into the template contents.
This matches the parsing behavior during page load.

Test: fast/dom/HTMLTemplateElement/innerHTML-inert.html

  • editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML):

LayoutTests:

  • fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/innerHTML-inert.html: Added.
12:36 AM Changeset in webkit [137020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Assertion failed at WebCore::RedirectedXCompositeWindow::context()
​https://bugs.webkit.org/show_bug.cgi?id=104349

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-12-08
Reviewed by Martin Robinson.

We should return GLContext if m_needsContext is CreateGLContext. By the way
CreateGLContext is a enum value and its default value is 0. So checking
ASSERT(m_needsContext) causes a crash on debug build.
ASSERT(m_needsContext == CreateGLContext) is better here.

No new tests since we can verify this with already existing AC tests.

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::context):

Note: See TracTimeline for information about the timeline view.