⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 10, 2012:

11:49 PM Changeset in webkit [137259] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening
​https://bugs.webkit.org/show_bug.cgi?id=84432

fast/filesystem/op-restricted-names.html
fast/filesystem/op-restricted-unicode.html
fast/filesystem/read-directory.html
fast/filesystem/simple-readonly-file-object.html

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2012-12-10

  • platform/chromium/TestExpectations: These have been passing on WIN for over a month.
11:46 PM Changeset in webkit [137258] by danakj@chromium.org
  • 1 edit
    2 deletes in trunk/Source/Platform

[chromium] Remove WebCompositorFrame(Ack) as these classes are not needed now that they are passed through cc::OutputSurface.
​https://bugs.webkit.org/show_bug.cgi?id=104635

Reviewed by James Robinson.

These have been supplanted by cc::CompositorFrame(Ack) which do not
need to inherit from them.

  • chromium/public/WebCompositorFrame.h: Removed.
  • chromium/public/WebCompositorFrameAck.h: Removed.
11:46 PM Changeset in webkit [137257] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening
​https://bugs.webkit.org/show_bug.cgi?id=84432

fast/filesystem/op-restricted-names.html
fast/filesystem/op-restricted-unicode.html
fast/filesystem/read-directory.html
fast/filesystem/simple-readonly-file-object.html

  • platform/chromium/TestExpectations: These have been passing on WIN for over a month.
11:45 PM Changeset in webkit [137256] by danakj@chromium.org
  • 12 edits
    7 deletes in trunk

[chromium] Remove WebCompositorOutputSurface implementations from DRT
​https://bugs.webkit.org/show_bug.cgi?id=104046

Reviewed by Darin Fisher.

Source/Platform:

Remove now-unused definitions for these classes. The cc::OutputSurface
and its related classes have replaced these, with the
WebCompositorOutputSurface class as an empty base class.

  • Platform.gypi:
  • chromium/public/WebCompositorOutputSurface.h:

(WebKit):

  • chromium/public/WebCompositorOutputSurfaceClient.h: Removed.
  • chromium/public/WebCompositorSoftwareOutputDevice.h: Removed.

Source/WebKit/chromium:

Use WebCompositorSupport to create an OutputSurface.

  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit):

  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/FakeWebCompositorOutputSurface.h: Removed.
  • tests/WebLayerTreeViewTestCommon.h:

Tools:

The classes are now provided through WebCompositorSupport.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Removed.
  • DumpRenderTree/chromium/WebViewHostOutputSurface.h: Removed.
  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Removed.
  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Removed.
11:33 PM Changeset in webkit [137255] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] Add a user default to limit the number of web processes
​https://bugs.webkit.org/show_bug.cgi?id=104606

Reviewed by Sam Weinig.

When the limit is reached, we'll reuse an existing process with fewest pages.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize m_webProcessCountLimit.
(WebKit::WebContext::platformInitialize): Added a hook for reading the preference,
empty implementation on most platforms.
(WebKit::WebContext::createNewWebProcess): Changed to return a raw pointer. The new
process is put into a vector anyway, so there is no ownership transfer.
(WebKit::WebContext::warmInitialProcess): Don't create a new process if that would
exceed the limit.
(WebKit::WebContext::createNewWebProcessRespectingProcessCountLimit): Added a new
function that wither creates a new process, or picks an existing one.
(WebKit::WebContext::createWebPage): Call the above new function instead of
unconditionally creating a process.

  • UIProcess/WebContext.h: createNewWebProcess is no private. All clients should

respect the process count limit.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess):

Respect the process count limit.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::registerUserDefaultsIfNeeded): Register the new default.
(WebKit::WebContext::platformInitialize): Read the default into a WebContext
member variable.
(WebKit::WebContext::platformInitializeWebProcess): Moved registerUserDefaultsIfNeeded()
from here to platformInitialize(), as that's a better place for it. Also added a
FIXME for an unrelated issue.

11:31 PM Changeset in webkit [137254] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after r137243.

  • platform/efl/fast/js/global-constructors-expected.txt:
11:20 PM Changeset in webkit [137253] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening

Mark platform/chromium/virtual/deferred/fast/images/pdf-as-image-landscape.html WontFix.

  • platform/chromium/TestExpectations:
11:02 PM Changeset in webkit [137252] by noel.gordon@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Unreviewed gardening: rebase fast/repaint/body-background-image.html on linux

  • platform/chromium/TestExpectations:
10:57 PM Changeset in webkit [137251] by noel.gordon@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Unreviewed gardening: rebase fast/text/font-initial.html on linux

  • platform/chromium-linux/fast/text/font-initial-expected.png: Added.
  • platform/chromium/TestExpectations:
10:44 PM Changeset in webkit [137250] by commit-queue@webkit.org
  • 4 edits
    2 copies
    1 add in trunk

REGRESSION (r137006): CSS clip on solid color composited div broken
​https://bugs.webkit.org/show_bug.cgi?id=104604

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-10
Reviewed by Simon Fraser.

Source/WebCore:

Disable direct compositing of background color for clipping layers.

Test: compositing/geometry/clip-inside.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::supportsDirectBoxDecorationsComposition):

Never allow direct background composition if there is a clip.

LayoutTests:

Added a new test (by Simon Fraser) to make sure background color doesn't break clipping.

  • compositing/geometry/clip-inside-expected.txt: Added.
  • compositing/geometry/clip-inside.html: Added.
  • compositing/geometry/clip-expected:

New result.

  • platform/chromium/compositing/geometry/clip-inside-expected.txt

Adjust Chromium expected result for new test.

10:07 PM Changeset in webkit [137249] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening after ​http://trac.webkit.org/changeset/137243

  • platform/chromium/TestExpectations: Remove animations test.
9:54 PM Changeset in webkit [137248] by Simon Fraser
  • 4 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r137215): WebKit stretches and shrinks a part of screen on scroll
​https://bugs.webkit.org/show_bug.cgi?id=104626

Reviewed by Beth Dakin.

r137215 removed a compositing layer repaint on size changes. However, there
are cases where the compositing code constrains layer size by clipping
with the viewport and a clipping ancestor. When that happens, we must
invalidate the layer on a size change to avoid showing stretched or
shrunken content.

Test: compositing/repaint/clipped-layer-size-change.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

LayoutTests: REGRESSION(r137215): WebKit stretches and shrinks a part of screen on scroll
​https://bugs.webkit.org/show_bug.cgi?id=104626

Reviewed by Beth Dakin.

Testcase that scrolls an overflow area containing a compositing layer.

  • compositing/repaint/clipped-layer-size-change-expected.html: Added.
  • compositing/repaint/clipped-layer-size-change.html: Added.
9:22 PM Changeset in webkit [137247] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Don't OSR exit just because a string is a rope
​https://bugs.webkit.org/show_bug.cgi?id=104621

Reviewed by Michael Saboff.

Slight SunSpider speed-up at around the 0.7% level. This patch does the obvious
thing of calling a slow path to resolve ropes rather than OSR exiting if the
string is a rope.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::getIndexedPropertyStorageMayTriggerGC):
(ArrayMode):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

9:17 PM Changeset in webkit [137246] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

ASSERTION failed in Windows: css3/css3-modsel-33.html
​https://bugs.webkit.org/show_bug.cgi?id=104472

Patch by Xueqing Huang <​huangxueqing@baidu.com> on 2012-12-10
Reviewed by Tim Horton.

In WebFrameLoaderClient::dispatchDidLayout, milestones maybe
DidFirstLayout & DidFirstVisualNonEmptyLayout, we should
use seperate COMPtrs for the two cases rather than reuse one.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidLayout):

8:44 PM Changeset in webkit [137245] by dino@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Change Tab's affiliation in ChangeLog on recent patch.

8:31 PM Changeset in webkit [137244] by noel.gordon@gmail.com
  • 4 edits
    1 move
    1 add in trunk/LayoutTests

[chromium] fast/dom/HTMLMeterElement/meter-boundary-values.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=104625

Unreviewed HTMLMeterElement/meter-boundary-values.html rebaselines.

  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/efl-wk1/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png.
8:23 PM Changeset in webkit [137243] by dino@apple.com
  • 24 edits
    10 deletes in trunk

Remove old WebKit Animation API code
​https://bugs.webkit.org/show_bug.cgi?id=104611

Reviewed by Simon Fraser.

Remove the existing, unused animation API code. We'll look into
implementing the W3C Animation API if/when it is stable.

Source/WebCore:

  • CMakeLists.txt: Remove WebKitAnimation and WebKitAnimationList classes.
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Remove includes.
  • bindings/js/JSWebKitAnimationCustom.cpp: Removed.
  • bindings/js/JSWebKitAnimationListCustom.cpp: Removed.
  • dom/Element.cpp: Remove API.
  • dom/Element.h: Ditto.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
  • page/WebKitAnimation.cpp: Removed.
  • page/WebKitAnimation.h: Removed.
  • page/WebKitAnimation.idl: Removed.
  • page/WebKitAnimationList.cpp: Removed.
  • page/WebKitAnimationList.h: Removed.
  • page/WebKitAnimationList.idl: Removed.
  • page/animation/AnimationController.cpp: Remove API.
  • page/animation/AnimationController.h: Ditto.
  • page/animation/AnimationControllerPrivate.h: Ditto.
  • page/animation/CompositeAnimation.cpp: Ditto.
  • page/animation/CompositeAnimation.h: Ditto.

LayoutTests:

  • animations/animation-api-1-expected.txt: Removed.
  • animations/animation-api-1.html: Removed.
  • fast/js/global-constructors-expected.txt:
7:53 PM Changeset in webkit [137242] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Re-enable a failing test. Disabling it just seemed to
move the problem to another test. Unreviewed.

  • tests/GraphicsLayerChromiumTest.cpp:
7:34 PM Changeset in webkit [137241] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::WebPlugInClient): Remove unneeded m_page variable.

  • WebProcess/WebCoreSupport/WebPlugInClient.h:

(WebPlugInClient):

7:10 PM Changeset in webkit [137240] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Mac build after r137233

  • html/shadow/HTMLShadowElement.h:

Remove a declaration of a member variable that was moved to the InsertionPoint superclass.

6:37 PM Changeset in webkit [137239] by commit-queue@webkit.org
  • 5 edits
    3 copies
    3 adds
    1 delete in trunk/LayoutTests

[EFL] Rebaseline expected results for "visibility:hidden; position: absolute;" cases
​https://bugs.webkit.org/show_bug.cgi?id=104620

Unreviewed, EFL gardening.

This is a following rebaseline of BUG 104195.
This patch sets AC ON as a default expected result of EFL.

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-12-10

  • platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt.
  • platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
  • platform/efl-wk1/fast/block/basic/020-expected.txt: Copied from LayoutTests/platform/efl/fast/block/basic/020-expected.txt.
  • platform/efl-wk2/fast/block/basic/020-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/efl/fast/block/basic/020-expected.txt:
6:06 PM Changeset in webkit [137238] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations lint errors in r137231
Unreviewed gardening.

  • platform/chromium/TestExpectations:
6:00 PM Changeset in webkit [137237] by dpranke@chromium.org
  • 5 edits in trunk/Tools

change --no-launch-safari to --no-show-results in scripts
​https://bugs.webkit.org/show_bug.cgi?id=104298

Reviewed by Eric Seidel.

Since Safari only exists on the Apple ports, NRWT calls the
command line flag --[no-]show-results instead. This updates
the scripts to use the new flag (but not the buildbot config yet).

  • Scripts/generate-coverage-data:
  • Scripts/webkit-tools-completion.sh:
  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
5:59 PM Changeset in webkit [137236] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137221
​https://bugs.webkit.org/show_bug.cgi?id=104617

Unreviewed build fix

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2012-12-10

  • html/HTMLPropertiesCollection.cpp:

(WebCore::nextNodeWithProperty):

5:54 PM Changeset in webkit [137235] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Rewrite last occurrences of "Image" in TestExpectations to "ImageOnlyFailure".
Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
5:48 PM Changeset in webkit [137234] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: fix mapping of AUDIO onto FAIL when printing unexpected results
​https://bugs.webkit.org/show_bug.cgi?id=104597

Reviewed by Ojan Vafai.

This was broken in the recent printer refactoring.

  • Scripts/webkitpy/layout_tests/views/buildbot_results.py:

(BuildBotPrinter.print_unexpected_results.add_result.is_expected):

  • Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:

(BuildBotPrinterTests.get_result):
(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
(BuildBotPrinterTests):

5:42 PM Changeset in webkit [137233] by morrita@google.com
  • 11 edits in trunk/Source/WebCore

[Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredWithShadowRoot should be moved to InsertionPoint
​https://bugs.webkit.org/show_bug.cgi?id=104516

Reviewed by Dimitri Glazkov.

This change pulls duplicated code in removedFrom() and
insertedInto() of both both HTMLShadowElement and
HTMLContentElement to their super class InsertionPoint.

This is a part of effor that encapsulate node distribution algorithm to
ContentDistributor and its family.

No new tests, no behavior change.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::registerInsertionPoint): Added.
(WebCore::ShadowRoot::unregisterInsertionPoint): Added.

  • dom/ShadowRoot.h:

(ShadowRoot):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ShadowRootContentDistributionData::regiterInsertionPoint): Generalized two methods for <content> and <shadow>.
(WebCore):
(WebCore::ShadowRootContentDistributionData::unregisterInsertionPoint): Ditto.

  • html/shadow/ContentDistributor.h:

(ShadowRootContentDistributionData):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):

  • html/shadow/HTMLContentElement.h:
  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::HTMLShadowElement):

  • html/shadow/HTMLShadowElement.h:
  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::insertedInto): Pulled up from subclasses
(WebCore::InsertionPoint::removedFrom): Pulled up from subclasses

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

5:40 PM Changeset in webkit [137232] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Expand flakiness of move-by-line-001.html.
Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:35 PM Changeset in webkit [137231] by acolwell@chromium.org
  • 2 edits in trunk/LayoutTests

Temporarily disable video-media-source-seek.html & video-media-source-state-changes.html
​https://bugs.webkit.org/show_bug.cgi?id=104584

Reviewed by Dirk Pranke.

Changes in Chromium needed for Bug 104581 and Bug 104583 will break these tests so they are
being temporarily disabled until the Chromium & WebKit changes are both landed.

  • platform/chromium/TestExpectations:
5:33 PM Changeset in webkit [137230] by jonlee@apple.com
  • 25 edits
    5 adds in trunk/Source

Keep track of plug-in snapshots clicked by user
​https://bugs.webkit.org/show_bug.cgi?id=103206
<rdar://problem/12746483>

Reviewed by Anders Carlsson.

Source/WebCore:

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initially the hash is
unknown. Set to 0. Move the check for whether to snapshot the plugin into the
new function subframeLoaderWillLoadPlugIn.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Rename
setPendingClickEvent to userDidClickSnapshot. In addition to holding onto the
click event used to activate the plug-in, the function now also tells the plug-in
client to add the origin hash as an auto-start origin.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillLoadPlugIn): Calculate the
hash based on the provided URL, which is the URL the plug-in will load. Extend
the check that used to be in the constructor to see if the plug-in should not
automatically load, including checking the plug-in size and whether the hash
is an auto-start origin.

  • html/HTMLPlugInImageElement.h: Rename setPendingClickEvent to userDidClickSnapshot

and add a variable for the origin hash.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin): When the loader is about to load the
plug-in, pass the URL to the element, so that it can calculate the hash.

  • page/Page.cpp:

(WebCore::Page::Page): Take the plugInClient from the page clients.
(WebCore::Page::~Page): If the client exists, tell it that the page is being
destroyed.
(WebCore::Page::PageClients::PageClients): Initialize this optional client to
null.

  • page/Page.h: Add PlugInClient to page clients.

(PageClients): Add PlugInClient variable.
(WebCore::Page::plugInClient):

  • page/PlugInClient.h: Added.
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent): Call the renamed function
userDidClickSnapshot().
(WebCore::RenderSnapshottedPlugIn::layout): Move the check of the plug-in size
to subframeLoaderWillLoadPlugIn.

Add PlugInClient.h.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Create a new provider class for the web context that maintains a mapping of the plug-in origins
allowed to auto-start for a specific page origin.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Create and set WebPlugInClient.

Implement WebCore::PlugInClient.

  • WebProcess/WebCoreSupport/WebPlugInClient.cpp: Added.

(WebKit::WebPlugInClient::WebPlugInClient):
(WebKit::WebPlugInClient::~WebPlugInClient):
(WebKit::WebPlugInClient::pageDestroyed):
(WebKit::WebPlugInClient::isAutoStartOrigin): Forward to WebProcess.
(WebKit::WebPlugInClient::addAutoStartOrigin): Forward to WebProcess.

  • WebProcess/WebCoreSupport/WebPlugInClient.h: Added.
  • WebProcess/WebProcess.cpp: Maintains a copy of the hash set.

(WebKit::WebProcess::isPlugInAutoStartOrigin): Look for the hash in the set.
(WebKit::WebProcess::addPlugInAutoStartOrigin): Tell the UI process to add the hash for the page.
(WebKit::WebProcess::didAddPlugInAutoStartOrigin): Add the hash to the cached set.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add DidAddPlugInAutoStartOrigin.

Add the auto-start provider.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize the provider.
(WebKit::WebContext::addPlugInAutoStartOriginHash): Forward to the provider.

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Add AddPlugInAutoStartOriginHash.

The provider class maintains a map of page domains to hashes, and a set of all the hashes.
The latter will be used to initialize new web processes without having to crawl through the
whole map.

  • UIProcess/Plugins/PlugInAutoStartProvider.cpp: Added.

(WebKit::PlugInAutoStartProvider::PlugInAutoStartProvider):
(WebKit::PlugInAutoStartProvider::addAutoStartOrigin): Add the origin to the map and set. Tell
all processes to add the origin to their local copies.

  • UIProcess/Plugins/PlugInAutoStartProvider.h: Added.

Add PlugInAutoStartProvider and WebPlugInClient.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
5:18 PM Changeset in webkit [137229] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WKPageSetInvalidMessageFunction stub
​https://bugs.webkit.org/show_bug.cgi?id=104614
<rdar://problem/12841671>

Reviewed by Mark Rowe.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetInvalidMessageFunction):

  • UIProcess/API/C/WKPagePrivate.h:
5:13 PM Changeset in webkit [137228] by dpranke@chromium.org
  • 2 edits in trunk/Tools

old-run-webkit-tests: add --show-results properly
​https://bugs.webkit.org/show_bug.cgi?id=104608

Reviewed by Eric Seidel.

Rework r137219 / bug 104601 to use the correct perl idiom.

  • Scripts/old-run-webkit-tests:
5:03 PM Changeset in webkit [137227] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Not reviewed.

Build fix.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::nextNodeWithProperty):

  • page/TouchDisambiguation.cpp:

(WebCore::boundingBoxForEventNodes):

5:02 PM Changeset in webkit [137226] by acolwell@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Adding Aaron Colwell to the contributor list.

  • Scripts/webkitpy/common/config/committers.py:
4:43 PM Changeset in webkit [137225] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark an encrypted media test as failing after ​http://crrev.com/172175
Unreviewed gardening.

  • platform/chromium/TestExpectations:
4:40 PM WebKitGTK/1.10.x edited by kalevlember@gmail.com
Added r135761 as proposed merge (diff)
4:32 PM Changeset in webkit [137224] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=104602
DidHitRelevantRepaintedObjectsAreaThreshold LayoutMilestone fires too
early on some pages with iframes

Reviewed by Simon Fraser.

This change makes it so that any RenderObjects inside iframes are not
considered relevant.

  • page/Page.cpp:

(WebCore::Page::addRelevantRepaintedObject):

4:21 PM Changeset in webkit [137223] by dgrogan@chromium.org
  • 6 edits in trunk/Source

IndexedDB: Propagate more leveldb errors to script
​https://bugs.webkit.org/show_bug.cgi?id=104422

Reviewed by Tony Chang.

Source/WebCore:

These are the last places that ignore leveldb errors that can get the
usual ok/found treatment.

Nothing called getBool, so it is deleted.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore):
(WebCore::getInt):
(WebCore::isSchemaKnown):
(WebCore::setUpMetadata):
(WebCore::getMaxObjectStoreId):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::setMaxObjectStoreId):
(WebCore::getNewVersionNumber):
(WebCore::IDBBackingStore::putRecord):
(WebCore::setMaxIndexId):

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):

Source/WebKit/chromium:

  • tests/IDBFakeBackingStore.h: Delete method override that doesn't match new signature.
4:17 PM Changeset in webkit [137222] by andersca@apple.com
  • 2 edits
    9 deletes in trunk/Tools

Remove WebKit2 tests on Windows
​https://bugs.webkit.org/show_bug.cgi?id=104607

Reviewed by Tim Horton.

Stop building WebKit2 tests and remove associated files.

  • TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Removed.
  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Removed.
  • TestWebKitAPI/win/PlatformWebViewWin.cpp: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.sln: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Removed.
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Removed.
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Removed.
  • TestWebKitAPI/win/WindowMessageObserver.h: Removed.
  • TestWebKitAPI/win/copy-resources.cmd: Removed.
4:13 PM Changeset in webkit [137221] by Antti Koivisto
  • 79 edits
    2 adds in trunk/Source

Factor node traversal into standalone functions
​https://bugs.webkit.org/show_bug.cgi?id=104507

Source/WebCore:

Reviewed by Eric Seidel.

Node traversal functions are currently Node and ContainerNode members. Their implementations
are confusingly scattered over multiple header and source files. These functions have no particular
reason to be members as they don't require non-public access. They should be made freestanding
function instead and gathered together.

This patch adds NodeTraversal namespace, defined in NodeTraversal.h. It contains freestanding
functions for traversing Nodes. Most popular functions are inlined (as before) and
there are ContainerNode specific specializations (as before).

In client code

node = node->traverseNextNode();
node = node->traverseNextSibling();


becomes

node = NodeTraversal::next(node);
node = NodeTraversal::nextSkippingChildren(node);


etc.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addImageMapChildren):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::allVisitedStateChanged):
(WebCore::SelectorChecker::visitedStateChanged):

  • css/StyleInvalidationAnalysis.cpp:

(WebCore::StyleInvalidationAnalysis::invalidateStyle):

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

  • dom/ContainerNode.h:

(ContainerNode):
(WebCore):

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::collectDescendant):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::removeAllEventListeners):
(WebCore::Document::updateBaseURL):
(WebCore::Document::processBaseElement):
(WebCore::Document::nodeAbsIndex):
(WebCore::Document::nodeWithAbsIndex):
(WebCore::Document::getFocusableNodes):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markersInRange):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::hasMarkers):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::get):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::collectSelectFeatureSetFrom):

  • dom/Node.cpp:

(WebCore::Node::normalize):
(WebCore::Node::lazyAttach):
(WebCore):
(WebCore::Node::detach):
(WebCore::traverseTreeAndMark):

  • dom/Node.h:

(Node):

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodePointer::moveToNext):
(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::updateForNodeRemoval):

  • dom/NodeTraversal.h: Added.

(WebCore):
(NodeTraversal):
(WebCore::NodeTraversal::traverseNextNodeTemplate):
(WebCore::NodeTraversal::next):
(WebCore::NodeTraversal::traverseNextSiblingTemplate):
(WebCore::NodeTraversal::nextSibling):

  • dom/Range.cpp:

(WebCore::Range::toString):
(WebCore::Range::checkDeleteExtract):
(WebCore::Range::firstNode):
(WebCore::Range::pastLastNode):
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
(WebCore::Range::getBorderAndTextQuads):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::labelElementForId):
(WebCore::TreeScope::findAnchor):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):

  • dom/TreeWalker.cpp:

(WebCore::TreeWalker::nextNode):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
(WebCore::containsNonEditableRegion):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
(WebCore::ApplyStyleCommand::removeInlineStyle):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::firstEditablePositionInNode):
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):

  • editing/EditCommand.cpp:

(WebCore::SimpleEditCommand::addNodeAndDescendants):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::textDirectionForSelection):

  • editing/Editor.cpp:

(WebCore::Editor::simplifyMarkup):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):
(WebCore::FrameSelection::setSelectionFromNone):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes):
(WebCore::ReplacementFragment::removeInterchangeNodes):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::removeHeadContents):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance):
(WebCore::shouldEmitNewlineAfterNode):

  • editing/htmlediting.cpp:

(WebCore::hasARenderedDescendant):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):

  • editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):
(WebCore::findNodesSurroundingContext):
(WebCore::trimFragment):

  • editing/visible_units.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/HTMLCollection.cpp:

(WebCore::nextNode):

  • html/HTMLElement.cpp:

(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionality):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
(WebCore::HTMLElement::getItemRefElements):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::formElementIndex):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::associatedControl):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::mapMouseEvent):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::virtualItemAfter):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::collectOptionInnerText):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::nextNodeWithProperty):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ShadowRootContentDistributionData::ensureInsertionPointList):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

  • inspector/InspectorMemoryAgent.cpp:
  • page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsAboveCell):
(WebCore::Frame::searchForLabelsBeforeElement):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
(WebCore::SVGSVGElement::getElementById):

  • svg/SVGUseElement.cpp:

(WebCore::removeDisallowedElementsFromSubtree):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

  • xml/XPathUtil.cpp:

(WebCore::XPath::stringValue):

Source/WebKit/chromium:

Reviewed by Eric Seidel.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):

Source/WebKit/mac:

Reviewed by Eric Seidel.

  • WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit2:

Reviewed by Eric Seidel.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

4:08 PM Changeset in webkit [137220] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

Sending multi-touch events to the same Iframe
​https://bugs.webkit.org/show_bug.cgi?id=97973

Patch by Min Qin <​qinmin@chromium.org> on 2012-12-10
Reviewed by Dimitri Glazkov.

Source/WebCore:

Multi-Touch in different iframe can give both documents access to each other.
This could cause cross-origin access. To solve this, all the touch events should
be sent to the iframe where the first touchstart happens.

Test: fast/events/touch/multi-touch-inside-iframes.html

fast/events/touch/multi-touch-inside-nested-iframes.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:

LayoutTests:

Check that all multi-touch events are sent to the same iframe.

  • fast/events/touch/multi-touch-inside-iframes-expected.txt: Added.
  • fast/events/touch/multi-touch-inside-iframes.html: Added.
  • fast/events/touch/resources/multi-touch-inside-iframes2.html: Added.
  • fast/events/touch/multi-touch-inside-nested-iframes-expected.txt: Added.
  • fast/events/touch/multi-touch-inside-nested-iframes.html: Added.
  • fast/events/touch/resources/multi-touch-inside-nested-iframes2.html: Added.
  • fast/events/touch/resources/multi-touch-inside-nested-iframes3.html: Added.
3:56 PM Changeset in webkit [137219] by dpranke@chromium.org
  • 2 edits in trunk/Tools

old-run-webkit-tests: support --no-show-results for compatibility w/ NRWT
​https://bugs.webkit.org/show_bug.cgi?id=104601

Reviewed by Eric Siedel.

This flag is being added so we can move all of the calling scripts
over to using --no-show-results instead of --no-launch-safari.

  • Scripts/old-run-webkit-tests:
3:55 PM Changeset in webkit [137218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[soup] Fix build warning in ResourceHandleSoup.cpp
​https://bugs.webkit.org/show_bug.cgi?id=104605

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2012-12-10
Reviewed by Martin Robinson.

The nextMultipartResponsePartCallback has unused parameter 'source',
comment out it to fix 'unused parameter' build warning.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::nextMultipartResponsePartCallback):

3:43 PM Changeset in webkit [137217] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix frame border painting in tiled drawing mode
​https://bugs.webkit.org/show_bug.cgi?id=104453
<rdar://problem/11678611>

Reviewed by Dan Bernstein.

Frame borders were not correctly invalidated when in tiled drawing mode, because
RenderFrameSet::layout() invalidated directly on the view, which skips the tile
cache.

Fix by invalidating like all other renderers, via the repaint container.

Also, the layer transform should be updated before the invalidation, and
we make use of RenderObject::updateLayerTransform() which has the same behavior
as the old code.

Attempts to make a layout test failed. Resizing composited framesets repainted
via layer resizing, and an attempt to make a ref test in tiled drawing mode
failed (the test passed without the patch).

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):

3:43 PM Changeset in webkit [137216] by Simon Fraser
  • 3 edits
    3 adds in trunk

When converting a layer into a tiled layer, ensure that we update the visible rect
​https://bugs.webkit.org/show_bug.cgi?id=104467

Reviewed by Darin Adler.

Source/WebCore:

When a GraphicsLayerCA toggles to use a TileCache, we have to ensure that the
layer's visible rect (which is used to ensure tile coverage) is updated in
the same commit. Otherwise we can get blank layers until something else causes
the visible rect to be updated.

Test: compositing/tiling/tiled-layer-resize.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::dumpAdditionalProperties): With the debug flag, dump the TiledBacking
address for ease of debugging.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Set the VisibleRectChanged bit in
m_uncommittedChanges if we've just switched to a tiled layer.

LayoutTests:

Test that resizes a layer over the tiled layer threshold, then dumps layer data.

Mac-specific results added because only Mac dumps tile cache info.

  • compositing/tiling/tiled-layer-resize-expected.txt: Added.
  • compositing/tiling/tiled-layer-resize.html: Added.
  • platform/mac/compositing/tiling/tiled-layer-resize-expected.txt: Added.
3:43 PM Changeset in webkit [137215] by Simon Fraser
  • 3 edits
    2 adds in trunk

Don't unconditionally repaint compositing layers when their size changes
​https://bugs.webkit.org/show_bug.cgi?id=104461

Reviewed by Sam Weinig.

Source/WebCore:

RenderLayerBacking always repainted the entire compositing layer when its size
changed. This was done to fix repaint issues when outline widths changes, but
that issue is now solved by repainting in GraphicsLayer::setOffsetFromRenderer(),
add in r134628. I believe this is no longer necessary.

Always repainting when the size changes is terrible for the tile cache when
loading large documents, as all tiles repaint every time the document gets
longer.

Test: compositing/repaint/resize-repaint.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

Test that dumps repaint rects after adding content to a compositing layer.

  • compositing/repaint/resize-repaint-expected.txt: Added.
  • compositing/repaint/resize-repaint.html: Added.
3:34 PM Changeset in webkit [137214] by ojan@chromium.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r134150.
​http://trac.webkit.org/changeset/134150
​https://bugs.webkit.org/show_bug.cgi?id=99940

Caused JS-based tooltips to remain during scroll on Facebook
and Gmail. Rollout until I have time to experiment with less
aggresive approaches.

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore):
(WebCore::MaximumDurationTracker::MaximumDurationTracker):
(WebCore::MaximumDurationTracker::~MaximumDurationTracker):
(MaximumDurationTracker):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/EventHandler.h:

(EventHandler):

  • platform/Timer.h:

LayoutTests:

  • fast/scrolling/fake-mouse-event-throttling-expected.txt: Removed.
  • fast/scrolling/fake-mouse-event-throttling.html: Removed.
  • platform/mac/TestExpectations:
3:30 PM Changeset in webkit [137213] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Keyboard caret movement in textarea with RTL Override Character can make tab unresponsive
​https://bugs.webkit.org/show_bug.cgi?id=103067

Patch by Yi Shen <​max.hong.shen@gmail.com> on 2012-12-10
Reviewed by Ryosuke Niwa.

Source/WebCore:

For textarea with RTL override character, the line break could be the previous leaf InlineTextBox of
the InlineTextBox for the RTL override text. When overshots the left/right, make sure the
leftVisuallyDistinctCandidate and rightVisuallyDistinctCandidate return the visually distinct
left/right position by ignoring the line break.

Test: editing/selection/move-by-character-crash-test-textarea.html

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

LayoutTests:

New test for moving caret in textarea with RTL override character causes crash.

  • editing/selection/move-by-character-crash-test-textarea-expected.txt: Added.
  • editing/selection/move-by-character-crash-test-textarea.html: Added.
3:06 PM Changeset in webkit [137212] by adamk@chromium.org
  • 6 edits in branches/chromium/1312/Source

Merge 136785

Add runtime enable for web intents.
​https://bugs.webkit.org/show_bug.cgi?id=103669

Patch by Greg Billock <​gbillock@google.com> on 2012-12-05
Reviewed by Adam Barth.

Source/WebCore:

Make web intents Javascript API enabled by a runtime setting.

  • Modules/intents/DOMWindowIntents.idl:
  • Modules/intents/NavigatorIntents.idl:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitStartActivityEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::webKitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::setWebIntentsEnabled):

Source/WebKit/chromium:

Propagate runtime setting to enable/disable web intents Javascript API.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableWebIntents):
(WebKit):
(WebKit::WebRuntimeFeatures::isWebIntentsEnabled):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11519009

3:01 PM Changeset in webkit [137211] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

[EFL][WebGL] Minor Refactoring in GraphicsContext3DEfl.
​https://bugs.webkit.org/show_bug.cgi?id=104553.

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

We use different FBO for canvas and offscreen surface of our platform layer.
Thus we need to manage any bound buffers while copying contents to the surface. Currently, Surface
always uses double buffering but in future we should be able to configure it to use either
double or single buffer. For these use cases, it would be handy to bind buffers directly to
FBO used by the surface. This patch does the needed changes in GraphicsContext3DEfl and
PlatformSurface. Also, removes some unused code.

Covered by existing tests.

Relevant changes in GraphicsContext3DEfl to obtain FBO id from PlatformSurface.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

Renamed createGraphicsSurface to didResizeCanvas.
(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(GraphicsContext3DPrivate::didResizeCanvas):
(GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

Header cleanup.

  • platform/graphics/opengl/GLDefs.h:
  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLPlatformContext::createContext):

  • platform/graphics/opengl/GLPlatformContext.h:

Added initialize method to expose FBO id of the surface.
Removed unused code.

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::initialize):
(WebCore):
(WebCore::GLPlatformSurface::updateContents):

  • platform/graphics/opengl/GLPlatformSurface.h:

(GLPlatformSurface):

  • platform/graphics/surfaces/glx/GLXSurface.h:
2:57 PM Changeset in webkit [137210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Flash content is being rendered as garbled characters when Flashplayer is disabled
​https://bugs.webkit.org/show_bug.cgi?id=104505

Patch by Max Feil <​mfeil@rim.com> on 2012-12-10
Reviewed by Antonio Gomes.

The check to allow video and audio as the source of embed and
object elements is causing a problem when the Flashplayer plugin
is disabled. We have to take Flash content into account in this
check otherwise the swf contents will be rendered as garbled
text characters where there should just be blank space.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createPlugin):

2:53 PM Changeset in webkit [137209] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Tidy up the tiled scrolling indicator, fix with zooming
​https://bugs.webkit.org/show_bug.cgi?id=104386

Reviewed by Tim Horton.

Fix the tiled scrolling indicator to not get tiny when zooming,
to not poke out of the bottom of the window, and to not look
so crappy.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::updateTileCoverageMap):
(WebCore::TileCache::drawTileMapContents):

2:42 PM Changeset in webkit [137208] by dpranke@chromium.org
  • 5 edits in trunk

nrwt: use the default logic for skipping platform-specific tests for chromium
​https://bugs.webkit.org/show_bug.cgi?id=104403

Reviewed by Stephen White.

Tools:

I thought I had fixed this a while ago, but the chromium port was
using custom logic to figure out which platform/* tests to run (or
skip) and as a result we were getting some odd behavior (like running
tests in chromium-linux on chromium-mac, but only when there was
an expectation listed for the test).

Ports are supposed to only run the tests found under their
baseline_search_path() by default.

Not writing a test for this; theoretically there shouldn't been a
test checking that the behavior for Chromium was *different* than
the other ports before.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._missing_symbol_to_skipped_tests):

LayoutTests:

Remove a bunch of WONTFIX lines that will now be handled programmatically.

  • platform/chromium-android/TestExpectations:
  • platform/chromium/TestExpectations:
2:31 PM Changeset in webkit [137207] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r136817.
​http://trac.webkit.org/changeset/136817
​https://bugs.webkit.org/show_bug.cgi?id=104596

This patch was an unnecessarily complex solution to handling
conversion of union types. (Requested by mpruett on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-10

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

2:15 PM Changeset in webkit [137206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Deprecate prefixed linear-gradient and radial-gradient functions
​https://bugs.webkit.org/show_bug.cgi?id=104591

Patch by Tab Atkins <​jackalmage@gmail.com> on 2012-12-10
Reviewed by Dean Jackson.

Rename the old gradient parsing functions in anticipation of functions that parse the new syntax.

No new tests added - this is a rename and has no functionality change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseGeneratedImage):

  • css/CSSParser.h:
2:14 PM Changeset in webkit [137205] by dpranke@chromium.org
  • 2 edits in trunk/Tools

fix regression in test-webkitpy after r137189
​https://bugs.webkit.org/show_bug.cgi?id=104589

Reviewed by Eric Seidel.

Need to specify full port names.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_build_check):

2:13 PM Changeset in webkit [137204] by dino@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed update to test results after ​http://trac.webkit.org/changeset/137200.
The 'widows' and 'orphans' properties have an initial value of 'auto'.

  • editing/pasteboard/onpaste-text-html-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
2:06 PM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
1:53 PM Changeset in webkit [137203] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Change the minimum required EFL version to 1.6
​https://bugs.webkit.org/show_bug.cgi?id=104431

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

.:

Change the minimum required EFL version to 1.6 from 1.7 to enable
building on Tizen.

The elementary EFL package is only required to build MiniBrowser,
so I moved the required only to the Minibrowser CMake file.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Change the minimum required EFL version to 1.6 from 1.7.
The elementary EFL package is only required to build MiniBrowser,
so I moved the required only to the Minibrowser CMake file.

  • MiniBrowser/efl/CMakeLists.txt: In addition removed

ENABLE_GLIB_SUPPORT as it is obsolete and it was always set to be on.

1:40 PM Changeset in webkit [137202] by dino@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Updating date in Tools/ChangeLog

1:33 PM Changeset in webkit [137201] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium][Win] Remove theme-related functions from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=102699

Reviewed by Adam Barth.

Call theme engine directly instead of going through
PlatformSupport. Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::pluginScriptableObject):

1:22 PM Changeset in webkit [137200] by dino@apple.com
  • 18 edits
    2 adds in trunk

Support for CSS widows and orphans
​https://bugs.webkit.org/show_bug.cgi?id=9410

Reviewed by Darin Adler.

Source/WebCore:

The CSS 'widow' and 'orphan' properties were supported by the parser and
style system, but were not actually doing anything in layout. Now they do!

In order to not break existing content, I unfortunately had to go against
the specification and change our default value from 2 to auto. A value of
auto means that widows and orphans will not cause any page/column breaks.

Supporting orphans was a small change. During line layout, if we realise
we need to move to a new page in a situation that would create an orphan,
move the entire block to the new page. There was already code to do this.

Support for widows was trickier. When we finish laying out a block, count
the number of hanging lines. If we've created a widow, and there are enough
available lines on the previous page, then steal some and remember the line
to break at. Trigger a relayout. Then notice the line that was marked for
breaking and avoid the widow. This means some blocks go through layout
twice, but as long as the widow value is small it shouldn't be a huge penalty.

Tests: fast/multicol/widows-and-orphans.html (new test)

printing/page-break-orphans.html
printing/page-break-orphans-and-widows.html
printing/page-break-widows.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return CSSValueAuto for widows and orphans if necessary.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Support "auto" in widow and orphan property parsing.

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Change property handler to something that supports auto.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimation::ensurePropertyMap): Add widows and orphans to the animation map.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild): Detect if we've caused a widow-fixing break, and request relayout evaluation.
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded): Test for a widow-fixing line.
(WebCore::RenderBlock::setBreakAtLineToAvoidWidow): New function to remember where we should break on next layout.
(WebCore::RenderBlock::adjustLinePositionForPagination): Move the entire block to a new page if this would create an orphan.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::shouldBreakAtLineToAvoidWidow): New function to indicate if we are remembering a widow.
(WebCore::RenderBlock::clearShouldBreakAtLineToAvoidWidow): Reset the line breaks.
(WebCore::RenderBlock::lineBreakToAvoidWidow):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData): Add a flag for indicating if we are remembering a line, and the actual line itself.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): The code to detect and fix widows. Explained above.

  • rendering/style/RenderStyle.h: New methods for indicating if widows and orphans are non-default values.
  • rendering/style/StyleRareInheritedData.cpp: Ditto.
  • rendering/style/StyleRareInheritedData.h: Ditto.

LayoutTests:

A new, slightly more comprehensive, test for widows and orphans. We also
now pass the existing widows and orphans tests from printing. And
since the default value of the properties changed, update the
computed style test as well.

  • fast/css/getComputedStyle/computed-style-expected.txt: New auto value.
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: New auto value.
  • fast/multicol/widows-and-orphans-expected.txt: Added.
  • fast/multicol/widows-and-orphans.html: Added.
  • printing/page-break-orphans-and-widows-expected.txt:
  • printing/page-break-orphans-expected.txt:
  • printing/page-break-widows-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt: New auto value.
1:21 PM Changeset in webkit [137199] by dino@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Adding Antoine to the contributor list so his name autocompletes in bugzilla.

  • Scripts/webkitpy/common/config/committers.py:
1:07 PM Changeset in webkit [137198] by zandobersek@gmail.com
  • 4 edits in trunk

REGRESSION (r118735): svg/dom/complex-svgView-specification.html, svg/dom/SVGViewSpec.html, svg/dom/viewspec-parser.html failing on GTK Linux 64-bit Release
​https://bugs.webkit.org/show_bug.cgi?id=87734

Reviewed by Martin Robinson.

Source/WebCore:

Don't modify ResourceRequest's URL to have the value of the (encoded)
URI of the SoupMessage. The only exception is in the case of cancelled
SoupMessage - the URL of the ResourceRequest should then be null.

No new tests - existing tests should show no regressions.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessage):

Tools:

When willSendRequest should return null in testing, cancel the SoupMessage
instead of setting the request's URI to about:blank.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(willSendRequestCallback):

12:21 PM Changeset in webkit [137197] by Lucas Forschler
  • 4 edits in tags/Safari-537.20.4/Source/WebCore

Merged r137178. <rdar://problem/12724571>

12:01 PM Changeset in webkit [137196] by Lucas Forschler
  • 4 edits in tags/Safari-537.20.4/Source

Versioning.

11:59 AM Changeset in webkit [137195] by Lucas Forschler
  • 1 copy in tags/Safari-537.20.4

New Tag.

11:56 AM Changeset in webkit [137194] by kov@webkit.org
  • 4 edits in trunk/Source

Unreviewed distcheck fix.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebCore:

  • GNUmakefile.list.am:
11:52 AM Changeset in webkit [137193] by jochen@chromium.org
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Tools

[chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=104537

Reviewed by Tony Chang.

In order to hide implementation details from the public TestRunner API,
I moved the plugin to WebTestPluginImpl and added a static create
method to WebTestPlugin. Also, I renamed the plugin from TestWebPlugin
to WebTestPlugin to be more in line with other classes in the
TestRunner API.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Added.

(WebTestRunner):
(WebTestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestWebPlugin.cpp.

(WebTestRunner::WebTestPlugin::create):
(WebTestRunner):
(WebTestRunner::WebTestPlugin::WebTestPlugin):
(WebTestRunner::WebTestPlugin::~WebTestPlugin):
(WebTestRunner::WebTestPlugin::mimeType):

  • DumpRenderTree/chromium/TestWebPlugin.h: Removed.
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

11:42 AM Changeset in webkit [137192] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[GTK] Expose HitTestResult::scrollbar() condition in API
​https://bugs.webkit.org/show_bug.cgi?id=104369

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2012-12-10
Reviewed by Carlos Garcia Campos.

This patch populates WebCore::HitTestResult::scrollbar() condition
in WebKitHitTestResult public API, and includes a corresponding unit
test.

  • Shared/WebHitTestResult.cpp: Adds new isScrollbar member to

encoding and decoding methods to carry the scrollbar condition
from Web process to UI process.
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):

  • Shared/WebHitTestResult.h:

(Data): Adds new bool member isScrollbar.
(WebKit::WebHitTestResult::Data::Data): Initializes isScrollbar from
WebCore::HitTestResult::scrollbar().
(WebKit::WebHitTestResult::isScrollbar): Method that returns value
of isScrollbar member.
(WebHitTestResult):

  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkitHitTestResultCreate): Adds scrollbar condition to context upon
initialization.
(webkitHitTestResultCompare): Adds comparison of scrollbar condition.
(webkit_hit_test_result_context_is_scrollbar): Public accessor for
scrollbar presence in context.

  • UIProcess/API/gtk/WebKitHitTestResult.h: Adds new flag

WEBKIT_HIT_TEST_RESULT_CONTEXT_SCROLLBAR to
WebKitHitTestResultContext enum.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Adds new API symbol

to the corresponding documentation sections.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Updates mouse-target
test to include assertions for hitting scrollbar condition, and
an new HTML to privide a positive case.

11:36 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
11:33 AM Changeset in webkit [137191] by Christophe Dumez
  • 102 edits in trunk/LayoutTests

[EFL] Massive rebaseline after r137146
​https://bugs.webkit.org/show_bug.cgi?id=104576

Unreviewed EFL gardening.

Rebaseline several test cases after r137146.

  • platform/efl/fast/text/atsui-spacing-features-expected.png:
  • platform/efl/fast/text/atsui-spacing-features-expected.txt:
  • platform/efl/fast/text/complex-text-opacity-expected.png:
  • platform/efl/fast/text/complex-text-opacity-expected.txt:
  • platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/efl/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/efl/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/efl/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/efl/svg/text/bidi-text-query-expected.png:
  • platform/efl/svg/text/bidi-text-query-expected.txt:
  • platform/efl/svg/text/bidi-tspans-expected.png:
  • platform/efl/svg/text/bidi-tspans-expected.txt:
  • platform/efl/svg/text/text-intro-05-t-expected.png:
  • platform/efl/svg/text/text-intro-05-t-expected.txt:
11:31 AM Changeset in webkit [137190] by eric@webkit.org
  • 5 edits in trunk/Source/WebCore

Caused crashes in v8. Rolling out until abarth can fix. See cr-issue 165136 for more info
​https://bugs.webkit.org/show_bug.cgi?id=104575

Unreviewed, just rolling out r136559.

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8NodeFilterCondition.h:

(WebCore::V8NodeFilterCondition::create):
(V8NodeFilterCondition):

  • dom/NodeFilter.h:
11:29 AM Changeset in webkit [137189] by dpranke@chromium.org
  • 3 edits in trunk/Tools

run_webkit_tests throws exception when DRT is not present
​https://bugs.webkit.org/show_bug.cgi?id=104565

Reviewed by Jochen Eisinger.

Don't actually try to print the bot results if there aren't
any because we exited before running any tests.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_build_check):

11:26 AM Changeset in webkit [137188] by benjamin@webkit.org
  • 7 edits
    1 add in trunk

Add convenience methods to use ListHashSet for a LRU cache
​https://bugs.webkit.org/show_bug.cgi?id=104499

Reviewed by Sam Weinig.

Source/WTF:

ListHashSet is a great abstract data type to implement caches.
Unfortunately, the class was missing methods to do that easily and
efficiently. This patch fixes that.

The names appendOrMoveToLast() and prependOrMoveToFirst() were chosen
in favor of append()/prepend() to ensure they are not used in place of
add() by accident.

  • wtf/ListHashSet.h:

(ListHashSet):
(WTF::::removeFirst):
(WTF::::appendOrMoveToLast):
(WTF::::prependOrMoveToFirst):
(WTF::::unlink):
(WTF::::unlinkAndDelete):
(WTF::::prependNode):

Tools:

Test the new methods added to ListHashSet.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/ListHashSet.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

11:14 AM Changeset in webkit [137187] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r137167.

  • WebCore.xcodeproj/project.pbxproj: Add InbandTextTrackPrivate.h to framework private

headers.

11:09 AM Changeset in webkit [137186] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Fix the GTK+ build after a collision of two patches.

Unreviewed build fix.

  • bindings/gobject/GNUmakefile.am: The GObject DOM bindings library needs to

include the harfbuzz cflags when compiling.

11:05 AM Changeset in webkit [137185] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Source/WebCore: Make hiddenPageDomTimerInterval a setting
​https://bugs.webkit.org/show_bug.cgi?id=104555

Patch by Parth Patel <​parpatel@rim.com> on 2012-12-10
Reviewed by Yong Li.

Make hiddenPageDomTimerInterval a setting so client can customize it.

No new tests are needed.

  • page/Page.cpp:

(WebCore):
(WebCore::Page::setVisibilityState):

  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::setHiddenPageDOMTimerAlignmentInterval):
(WebCore::Settings::hiddenPageDOMTimerAlignmentInterval):

  • page/Settings.h:

(Settings):

Source/WebKit/blackberry: [BlackBerry] Make hiddenPageDomTimerInterval a setting
​https://bugs.webkit.org/show_bug.cgi?id=104555

Patch by Parth Patel <​parpatel@rim.com> on 2012-12-10
Reviewed by Yong Li.

HiddenPageDomTimerInterval in setting in webcore can be utilized by browser application
when needed.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

11:04 AM Changeset in webkit [137184] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkit-patch print-expectations doesn't work right for platforms w/ shared expectations
​https://bugs.webkit.org/show_bug.cgi?id=104405

Reviewed by Eric Seidel.

If multiple ports shared a TestExpectations file, webkit-patch
print-expectations would use the expectation for the first port
using that file and print the result for all ports, rather than
re-parse and print each port separately (e.g., we might print
the chromium-linux expectation for a file for both chromium-linux
and chromium-mac). Discovered while testing/debugging the fix
for bug 104403.

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort._skipped_tests_for_unsupported_features):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations._model):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(PrintExpectationsTest.test_platform):

10:58 AM Changeset in webkit [137183] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: fix total number of tests computed in the result summary
​https://bugs.webkit.org/show_bug.cgi?id=104061

Reviewed by Jochen Eisinger.

Good thing I left this open, because I actually broke it again
the same way in a merge. Fix the computation of the one_line_summary
again, and add tests for it (also clean up some redundant tests).

Also, add constants into the test port code so that the knowledge
of how many tests should fail and how is next to the list of tests,
rather than a totally different place.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestList.getitem):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_test_results):
(MainTest.setUp):
(MainTest.test_basic):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_test_list_with_prefix):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code.CustomExitCodePort):
(MainTest.test_tolerance.ImageDiffTestPort):
(EndToEndTest.parse_full_results):

10:47 AM Changeset in webkit [137182] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile fix in ImageCairoWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=104554

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2012-12-10
Reviewed by Brent Fulgham.

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize): Added parameter.
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Added parameter.

10:47 AM Changeset in webkit [137181] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

Adding failure expectations for failing http tests that started
failing on EFL and GTK after the Jhbuild libsoup was bumped to 2.40.0.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
10:42 AM Changeset in webkit [137180] by mkwst@chromium.org
  • 17 edits in trunk

Log to console when script is blocked by sandbox attributes.
​https://bugs.webkit.org/show_bug.cgi?id=104365

Reviewed by Ojan Vafai.

Source/WebCore:

Adds a console message to cover script execution blocked within the
context of a sandboxed frame which lacks the 'allow-scripts' permission.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

Log a warning when sandboxing flags block script execution.

Tools:

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

Ignoring the new console message in perftests, as it broke parsing
for the Parser/html-parser.html microbenchmark.

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:

Rebaselining tests with new expectations.

10:38 AM Changeset in webkit [137179] by fpizlo@apple.com
  • 10 edits in trunk

JSC profiling and debug dump code should use inferred names when possible
​https://bugs.webkit.org/show_bug.cgi?id=104519

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This does as advertised: the profiler now knows the inferred name of all code blocks,
and all uses of CodeBlock::dump() dump it along with the hash.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::inferredName):
(JSC::CodeBlock::dumpAssumingJITType):

  • bytecode/CodeBlock.h:
  • profiler/ProfilerBytecodes.cpp:

(JSC::Profiler::Bytecodes::Bytecodes):
(JSC::Profiler::Bytecodes::toJS):

  • profiler/ProfilerBytecodes.h:

(JSC::Profiler::Bytecodes::inferredName):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::addBytecodes):
(JSC::Profiler::Database::ensureBytecodesFor):

  • profiler/ProfilerDatabase.h:
  • runtime/CommonIdentifiers.h:

Tools:

The format I'm using for referring to a code block is now name#hash. For example,
v8-crypto has something called bnpSquareTo#B5QFbU. The profiler allows you to use
either the hash, the inferred name, or the combined hash and full name when referring
to blocks.

  • Scripts/display-profiler-output:
10:36 AM Changeset in webkit [137178] by Chris Fleizach
  • 4 edits in trunk/Source/WebCore

AX: Crash in NSAccessibilityUnignoredDescendant
​https://bugs.webkit.org/show_bug.cgi?id=104468

Reviewed by Anders Carlsson.

This crash occurred because AccessibilityScrollView stopped retaining it's ScrollView pointer.

Unfortunately, there was still a case that didn't correctly clear that variable.

That case was when a Frame had a new FrameView associated with it. The old FrameView didn't inform the
accessibility object cache that it should be removed. As a result, when the FrameView deallocated and
did try to remove, it used the wrong AXObjectCache because it was no longer correctly hooked into the
document tree.

No new tests. Existing tests will stop crashing.

  • page/Frame.cpp:

(WebCore::Frame::setView): change the name of the method that tells the FrameView to detach

  • page/FrameView.cpp:

(WebCore::FrameView::~FrameView):
(WebCore::FrameView::removeFromAXObjectCache): add a method that can be called in multiple places
(WebCore::FrameView::isFrameView):
(WebCore::FrameView::prepareForDetach): detaches scrollbars and accessibility

  • page/FrameView.h:

(FrameView):

10:22 AM Changeset in webkit [137177] by pilgrim@chromium.org
  • 12 edits
    1 copy
    2 moves in trunk/Source

[Chromium] Move getPluginsList out of PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=96507

Reviewed by Darin Fisher.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::getPluginList):

  • chromium/public/WebPluginListBuilder.h: Added.

(WebKit):
(WebPluginListBuilder):

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • plugins/chromium/PluginDataChromium.cpp:

(WebCore::PluginCache::plugins):

  • plugins/chromium/PluginListBuilder.cpp: Added.

(WebKit):
(WebKit::PluginListBuilder::addPlugin):
(WebKit::PluginListBuilder::addMediaTypeToLastPlugin):
(WebKit::PluginListBuilder::addFileExtensionToLastMediaType):

  • plugins/chromium/PluginListBuilder.h: Added.

(WebKit):
(PluginListBuilder):
(WebKit::PluginListBuilder::PluginListBuilder):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebPluginListBuilder.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::idbFactory):

  • src/WebPluginListBuilderImpl.cpp: Removed.
  • src/WebPluginListBuilderImpl.h: Removed.
10:21 AM Changeset in webkit [137176] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Fixing most of the expectations added in r137153, the baselines are missing so the expectations
are changed according to that. The a11y gurus will have a look at them and determine what the
baselines should look like and whether the tests can be fixed.

  • platform/gtk/TestExpectations:
10:17 AM Changeset in webkit [137175] by fpizlo@apple.com
  • 23 edits
    6 adds in trunk

Profiler should say things about OSR exits
​https://bugs.webkit.org/show_bug.cgi?id=104497

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This adds support for profiling OSR exits. For each exit that is taken, the profiler
records the machine code address that the exit occurred on, the exit kind, the origin
stack, and the number of times that it happened.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(Jump):
(JSC::AbstractMacroAssembler::Jump::label):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::saveCompilation):
(CodeBlock):
(JSC::CodeBlock::compilation):
(DFGData):

  • bytecode/DFGExitProfile.h:

(DFG):

  • bytecode/ExitKind.cpp: Added.

(JSC):
(JSC::exitKindToString):
(JSC::exitKindIsCountable):
(WTF):
(WTF::printInternal):

  • bytecode/ExitKind.h: Added.

(JSC):
(WTF):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGOSRExitCompiler.cpp:
  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JIT):

  • jit/JumpReplacementWatchpoint.h:

(JSC::JumpReplacementWatchpoint::sourceLabel):
(JumpReplacementWatchpoint):

  • profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::addOSRExitSite):
(Profiler):
(JSC::Profiler::Compilation::addOSRExit):
(JSC::Profiler::Compilation::toJS):

  • profiler/ProfilerCompilation.h:

(Compilation):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::newCompilation):

  • profiler/ProfilerDatabase.h:

(Database):

  • profiler/ProfilerOSRExit.cpp: Added.

(Profiler):
(JSC::Profiler::OSRExit::OSRExit):
(JSC::Profiler::OSRExit::~OSRExit):
(JSC::Profiler::OSRExit::toJS):

  • profiler/ProfilerOSRExit.h: Added.

(Profiler):
(OSRExit):
(JSC::Profiler::OSRExit::id):
(JSC::Profiler::OSRExit::origin):
(JSC::Profiler::OSRExit::exitKind):
(JSC::Profiler::OSRExit::isWatchpoint):
(JSC::Profiler::OSRExit::counterAddress):
(JSC::Profiler::OSRExit::count):

  • profiler/ProfilerOSRExitSite.cpp: Added.

(Profiler):
(JSC::Profiler::OSRExitSite::toJS):

  • profiler/ProfilerOSRExitSite.h: Added.

(Profiler):
(OSRExitSite):
(JSC::Profiler::OSRExitSite::OSRExitSite):
(JSC::Profiler::OSRExitSite::codeAddress):

  • runtime/CommonIdentifiers.h:

Tools:

Adds support for displaying OSR exit information for full summary (just displays the
counts and the number of recompilations), bytecode display (says which bytecodes
exited), and DFG display (annotates disassembly with taken OSR exits and their
counts).

  • Scripts/display-profiler-output:
9:58 AM Changeset in webkit [137174] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

inspector/styles/styles-computed-trace still times out after r137156.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:55 AM Changeset in webkit [137173] by Carlos Garcia Campos
  • 38 edits in trunk/Source

[GTK] Build GObject DOM bindings as a separate library
​https://bugs.webkit.org/show_bug.cgi?id=104527

Reviewed by Xan Lopez.

Source/WebCore:

  • bindings/gobject/GNUmakefile.am: Add libWebCoreDOM library.
  • bindings/gobject/WebKitDOMBinding.h: Define private macros.
  • bindings/gobject/WebKitDOMCustom.h: Don't include webkit/webkitdefines.h.
  • bindings/gobject/WebKitDOMEventTarget.h: Ditto.
  • bindings/gobject/WebKitDOMObject.h: Ditto.
  • bindings/scripts/CodeGeneratorGObject.pm:

(Generate): Don't include webkitglobalsprivate.h.
(WriteData): Don't include webkit/webkitdefines.h.

  • bindings/scripts/gobject-generate-headers.pl: Define WEBKIT_API

macro in webkitdomdefines.h.

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestException.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:

Source/WebKit/gtk:

  • GNUmakefile.am: Link to libWebCoreDOM.la.
9:53 AM Changeset in webkit [137172] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Removed failing test expectations for GTK+ port after r137107.

  • platform/gtk/TestExpectations:
9:48 AM Changeset in webkit [137171] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

In InbandTextTrackPrivate, return emptyAtoms instead of emptyString() by default.

Unreviewed build fix.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::label):
(WebCore::InbandTextTrackPrivate::language):

9:35 AM Changeset in webkit [137170] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test expectations update after r137152.
Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:31 AM Changeset in webkit [137169] by loislo@chromium.org
  • 13 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: instrument RenderBox descendants.
​https://bugs.webkit.org/show_bug.cgi?id=104026

Reviewed by Eric Seidel.

Plain vanilla instrumentation for RenderBox descendants.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):

  • rendering/RenderFrameSet.h:

(RenderFrameSet):
(GridAxis):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::reportMemoryUsage):
(WebCore):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::reportMemoryUsage):
(WebCore):

  • rendering/RenderReplaced.h:

(RenderReplaced):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::reportMemoryUsage):
(WebCore):

  • rendering/RenderTableCol.h:

(RenderTableCol):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::reportMemoryUsage):
(WebCore):

  • rendering/RenderTableRow.h:

(RenderTableRow):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):

  • rendering/RenderTableSection.h:

(CellStruct):
(RowStruct):

9:30 AM Changeset in webkit [137168] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AX: wrong Enabled states on a ListBox
​https://bugs.webkit.org/show_bug.cgi?id=104483

Patch by Alejandro Piñeiro <​apinheiro@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/listbox-enabled-states.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled): taking into
account the DISABLED attribute and the aria-disabled attribute to
decide if the item is enabled or not.

LayoutTests:

  • accessibility/listbox-enabled-states-expected.txt: Added.
  • accessibility/listbox-enabled-states.html: Added.
9:28 AM Changeset in webkit [137167] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

cr-win build fix after r137161.

Unreviewed.

  • platform/graphics/MediaPlayer.h: Replace forward-decl of

InbandTextTrackPrivate with #include as the definition is required.

9:25 AM Changeset in webkit [137166] by alexis@webkit.org
  • 31 edits in trunk

[CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
​https://bugs.webkit.org/show_bug.cgi?id=104539

Reviewed by Antonio Gomes.

.:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

No new tests : the feature is covered by various tests and it is already enabled in many ports.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty):

  • css/CSSParser.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):

  • rendering/style/FillLayer.cpp:

(SameSizeAsFillLayer):
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::backgroundXOrigin):
(WebCore::FillLayer::backgroundYOrigin):
(WebCore::FillLayer::isBackgroundOriginSet):
(WebCore::FillLayer::clearXPosition):
(WebCore::FillLayer::clearYPosition):
(FillLayer):

Source/WebKit/chromium:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • features.gypi:

Source/WebKit/mac:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Configurations/FeatureDefines.xcconfig:

Tools:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the related CSS3 <position> type tests for background-position
as now the feature is enabled by default.

  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
9:19 AM Changeset in webkit [137165] by adamk@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove expectation of previously failing test.
It passes after r137152.

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
9:14 AM Changeset in webkit [137164] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKitWebViewBase produces a warning if compiled with gcc
​https://bugs.webkit.org/show_bug.cgi?id=104561

Patch by Alberto Garcia <​agarcia@igalia.com> on 2012-12-10
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitWebViewBase.h:

since this file can be included from C code, use void to
explicitly specify that webkit_web_view_base_get_type() doesn't
have parameters. Otherwise we get "warning: function declaration
isn't a prototype" with -Wstrict-prototypes.

9:01 AM Changeset in webkit [137163] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix warning for comparison between signed and unsigned
​https://bugs.webkit.org/show_bug.cgi?id=104563

Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):

8:56 AM Changeset in webkit [137162] by jocelyn.turcotte@digia.com
  • 2 edits in trunk

[Qt] Remove the support for building a debug WebKit with a release Qt
​https://bugs.webkit.org/show_bug.cgi?id=104560

Reviewed by Tor Arne Vestbø.

This creates issues with non-framework builds of Qt (necessary for debug-only
builds) since a Qt5 prefix is now added to the base target name.

  • Source/api.pri:
8:50 AM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
8:19 AM Changeset in webkit [137161] by eric.carlson@apple.com
  • 25 edits
    1 move
    8 adds in trunk

Add support for in-band text tracks to Mac port
​https://bugs.webkit.org/show_bug.cgi?id=103663

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-in-band.html

  • GNUmakefile.list.am: Move InbandTextTrackPrivate.h to platform/graphics. Add InbandTextTrackPrivateClient.h.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState): No need to call processInbandTextTracks, in-band tracks

are now registered by the media engine as they are discovered.

(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): New, called by the media player when a new

in-band track is found.

(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTrack): New, called by the media player when an

in-band track goes away.

  • html/HTMLMediaElement.h:
  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack): Use m_private instead of tracksPrivate because

it is zeroed during assignment.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::addTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses

to add a new in-band track.

(WebCore::MediaPlayer::removeTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses

to remove a new in-band track.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Added.

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF):
(WebCore::InbandTextTrackPrivateAVF::~InbandTextTrackPrivateAVF):
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Convert an attribute string into WebVTT

cue setting and content strings.

(WebCore::InbandTextTrackPrivateAVF::processCue): Process a new cue.
(WebCore::InbandTextTrackPrivateAVF::disconnect): Clear member variables.
(WebCore::InbandTextTrackPrivateAVF::resetCueValues): Reset cue values to defaults.
(WebCore::InbandTextTrackPrivateAVF::setMode): Set track mode and call player's trackModeChanged.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Initialize

m_inbandTrackConfigurationPending.

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Flush the currently accumulating

cue so it doesn't get the wrong duration.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Handle InbandTracksNeedConfiguration.
(WebCore::MediaPlayerPrivateAVFoundation::flushCurrentCue): New, pass the current cue up to the client.
(WebCore::MediaPlayerPrivateAVFoundation::configureInbandTracks): Configure in-band tracks.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Schedule a call to configureInbandTracks.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm: Added.

(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC):
(WebCore::InbandTextTrackPrivateAVFObjC::disconnect):
(WebCore::InbandTextTrackPrivateAVFObjC::kind): Return track kind.
(WebCore::InbandTextTrackPrivateAVFObjC::label): Return track label.
(WebCore::InbandTextTrackPrivateAVFObjC::language): Return track language.
(WebCore::InbandTextTrackPrivateAVFObjC::isDefault):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItem):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize m_currentTrack.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Clear m_legibleOutput.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create and initialize m_legibleOutput.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Called when the player item's

"tracks" changes, add and remove in-band text tracks as necessary.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): Pass an attributed string to the current

track to be processed.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Tell AVFoundation to select an in-band track.
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTrack): Return the current track.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]): Legible

output delegate.

Source/WTF:

  • wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT.

LayoutTests:

Test for initial support for in-band text tracks. New test skipped on all ports that don't
have support in the media engine.

  • media/content/counting-subtitled.m4v: Added.
  • media/track/track-in-band-expected.txt: Added.
  • media/track/track-in-band.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
8:18 AM Changeset in webkit [137160] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: fix front-end compilation warnings
​https://bugs.webkit.org/show_bug.cgi?id=104557

Reviewed by Alexander Pavlov.

Corresponding annotations added.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration.prototype.):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.highlightDOMNode):

  • inspector/front-end/DOMPresentationUtils.js:

(WebInspector.DOMPresentationUtils.linkifyNodeReference):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/Toolbar.js:
8:10 AM Changeset in webkit [137159] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] MediaPlayerQTKit broken after switching QPainter to raster engine.
​https://bugs.webkit.org/show_bug.cgi?id=104550

With Qt5 QPainter changed to using the raster engine.
Therefore we no longer have an NSGraphicsContext that we can
use for drawing video frames.
With this patch we are rendering the video frame into an image buffer
and then paint it manually using QPainter.

Reviewed by Simon Hausmann.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore):
(WebCore::swapBgrToRgb):

Swap the color format from BGR to RGB,
since BGR is not supported by QImage.

(WebCore::MediaPlayerPrivateQTKit::paint):

8:00 AM Changeset in webkit [137158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Link fix in InspectorController.cpp
​https://bugs.webkit.org/show_bug.cgi?id=104556

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2012-12-10
Reviewed by Pavel Feldman.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController): Added missing #if check.

7:55 AM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
7:28 AM Changeset in webkit [137157] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add 'WebKit/chromium/win8' to .gitignore
​https://bugs.webkit.org/show_bug.cgi?id=104534

Reviewed by Jochen Eisinger.

I've now added it via 'git add' once, and via 'git commit -a' twice.
Let's make that more difficult, shall we?

  • .gitignore:
7:23 AM Changeset in webkit [137156] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed: Web Inspector: update test expectation for inspector/styles/styles-computed-trace.html.
it is slow in debug version. ~20 sec on linux.

  • platform/chromium/TestExpectations:
7:20 AM Changeset in webkit [137155] by Martin Robinson
  • 1 edit
    1 add in trunk/Tools

Build fix.

Add a patchfile missing from my previous commit.

  • gtk/patches/harfbuzz-icu-detection-fix.patch: Added.
7:20 AM Changeset in webkit [137154] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: remove the Overrides / Settings context menu from gear icon
​https://bugs.webkit.org/show_bug.cgi?id=104546

Reviewed by Alexander Pavlov.

It sounds like too many people don't like the way it works. Bringing things back: overrides will be a tab in settings for now.
Moving present behavior to under experiment.

  • inspector/front-end/OverridesView.js:

(WebInspector.OverridesView):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.OverridesSettingsTab):
(WebInspector.SettingsController):
(WebInspector.SettingsController.prototype.get statusBarItem):
(WebInspector.SettingsController.prototype._mouseDown.showSettings):
(WebInspector.SettingsController.prototype._mouseDown):
(WebInspector.SettingsController.prototype._mouseUp):

  • inspector/front-end/helpScreen.css:

(#settings-screen .tabbed-pane-header):
(#settings-screen .tabbed-pane-header-tabs):
(#settings-screen .tabbed-pane-header-tab):

7:16 AM Changeset in webkit [137153] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Unskipping 8 failing accessibility tests, adding expected failures for them.

  • platform/gtk/TestExpectations:
7:13 AM Changeset in webkit [137152] by tkent@chromium.org
  • 12 edits in trunk

Visual order of empty value placeholder in INPUT_MULTIPLE_FIELDS_UI is wrong in RTL
​https://bugs.webkit.org/show_bug.cgi?id=104438

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. This updates datetimelocal-appearance-l10n.html for he-il
and ar-eg locales.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
We should not append Right-to-left-mark to each of placeholder
strings. It makes numeric field separators such as ':' and '/' RTL, and
makes a wrong visual order. We use unicode-bidi:bidi-override and
direction:ltr instead. It means we force LTR only to this element

  • html/shadow/DateTimeNumericFieldElement.h:

Makes m_placeholder const again.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
Explicitly set right-to-left-mark before S, WS, ON types according to
Unicod Bidirectional Algorithm Table 4 [1]. This is needed because we
don't have context like "This literal follows European/Arabic numbers"
in a case of showing placeholders.
[1] ​http://www.unicode.org/reports/tr9/#Bidirectional_Character_Types

LayoutTests:

  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
  • platform/chromium/TestExpectations:

Update bug numbers and add time-multiple-fields-localization.html.

  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:

Adjust test scenario for the new behavior.

  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
7:11 AM Changeset in webkit [137151] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(137127): Causes assertion failures on the debug bots
​https://bugs.webkit.org/show_bug.cgi?id=104549

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-12-10
Reviewed by Alejandro G. Castro.

After handling the new TextOutput message we should return the method
handling messages received.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a missing early return.

7:02 AM Changeset in webkit [137150] by kov@webkit.org
  • 16 edits
    1 copy in trunk

[Soup] utilize multipart/x-mixed-replace support recently added to libsoup
​https://bugs.webkit.org/show_bug.cgi?id=94515

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-12-09
Reviewed by Martin Robinson.

.:

  • configure.ac: require soup 2.40.0, which adds the new support.

Source/WebCore:

The multipart/x-mixed-replace content type is often used for providing
"push" server support, with each part in the multipart response
replacing the previous one in the rendering. Soup recently acquired
support for multipart/x-mixed replace, which this change utilizes.

Covered by existing multipart/x-mixed-replace tests.

  • platform/network/ResourceHandleInternal.h:

(ResourceHandleInternal): add new member to this class, the multipart input stream

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::cleanupSoupRequestOperation): also clear the multipart input stream on
cleanup
(WebCore::nextPartCallback): callback that handles reporting the new response delivered
with the new part, if any; uses the factored out updateFromSoupMessageHeaders method
(WebCore::sendRequestCallback): handle multipart/x-mixed-replace responses by
requesting the next part
(WebCore::readCallback): when reading has finished, request the next part when
handling a multipart/x-mixed-replace response

  • platform/network/soup/ResourceResponse.h:

(ResourceResponse): add declaration for new method

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage): call new updateFromSoupMessageHeaders
method, instead of dealing with the message headers directly
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): new method, factored out from
updateFromSoupMessage, so this same code can be reused for updating responses for
multipart/x-mixed-replace responses parts

Tools:

This change requires a very recent libsoup, so update our jhbuild
requirements.

  • gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace

support

  • efl/jhbuild.modules: ditto

LayoutTests:

  • platform/efl/TestExpectations: adjust expectations for tests that now pass.
  • platform/gtk/TestExpectations: ditto.
  • platform/gtk-wk2/TestExpectations: add missing multipart tests expectations.
  • platform/gtk/http/tests/multipart/invalid-image-data-expected.png: new baseline
  • platform/gtk/http/tests/multipart/invalid-image-data-expected.txt: ditto.
6:58 AM Changeset in webkit [137149] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale
​https://bugs.webkit.org/show_bug.cgi?id=104544

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

Removed 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale()
as it was not used by anyone.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didRenderFrame):

  • UIProcess/PageViewportControllerClient.h:

(PageViewportControllerClient):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setContentsScale):

  • UIProcess/efl/PageViewportControllerClientEfl.h:

(PageViewportControllerClientEfl):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::setContentsScale):

  • UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

6:57 AM Changeset in webkit [137148] by commit-queue@webkit.org
  • 13 edits in trunk

Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=103886

Patch by Zoltan Nyul <​zoltan.nyul@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Export symbol for WebCore::Page::setViewMode on Mac.

No new tests, no behavior change for layout tests.

  • WebCore.exp.in:

Source/WebKit2:

Add support for TestRunner::setViewModeMediaFeature().
This functionality is needed by the following LayoutTests:
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html
fast/media/view-mode-media-feature.html

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetViewMode):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewMode):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

Tools:

Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
This API is required by layout tests.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setViewModeMediaFeature):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskipping the following tests for EFL WebKit2:
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html
fast/media/view-mode-media-feature.html

  • platform/efl-wk2/TestExpectations:
6:54 AM Changeset in webkit [137147] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix QtWebProcess discovery on Windows
​https://bugs.webkit.org/show_bug.cgi?id=104552

Reviewed by Jocelyn Turcotte.

Make sure to look for QtWebProcess.exe on Windows instead of QtWebProcess.

  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

6:50 AM Changeset in webkit [137146] by Martin Robinson
  • 135 edits
    8 adds in trunk

[GTK] Bring Harfbuzz-ng support to Gtk
​https://bugs.webkit.org/show_bug.cgi?id=92098

Reviewed by Gustavo Noronha Silva.

.:

Add support for detecting HarfBuzz during configuration phase. Add these
flags to the FreeType ones since HarfBuzz support is part of the FreeType
backend.

  • configure.ac: Detect HarfBuzz.

Source/WebCore:

Enable HarfBuzz support by default. With the Freetype backend we no longer
fall back to Pango for rendering complex text.

No new tests. This is covered by existing tests.

  • GNUmakefile.am: Add HarfBuzz include directories and define.
  • GNUmakefile.list.am: Add HarfBuzz files to source list and remove

Pango ones.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::operator==): To properly render fallback
fonts via HarfBuzz , it's important that we actually ask Fontconfig
whether or not two patterns are the same. This ensures that when patterns
are just copies of one another they only take up one slot in the font cache
and appear to be the same font to HarfBuzzShaper.

Source/WebKit/gtk:

Add HarfBuzz dependency.

  • GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the library.

Source/WebKit2:

Add a HarfBuzz dependency.

  • GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS/LIBS to the libraries.

Tools:

Add HarfBuzz dependency.

  • GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
  • gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it

should no longer affect layout test results.

LayoutTests:

Update tests results that have changed due to the switch to HarfBuzz.
In general, these are progressions or harmless metrics differences.

  • platform/gtk: Update test results that have changed.
6:40 AM Changeset in webkit [137145] by Simon Hausmann
  • 6 edits
    2 deletes in trunk

[Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
​https://bugs.webkit.org/show_bug.cgi?id=104541

Reviewed by Jocelyn Turcotte.

We now depend on a Qt 5 version that is guaranteed to have this API, so we
can remove the configure checks for it.

Source/WebKit2:

  • PluginProcess.pro:
  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

  • WebProcess.pro:

Tools:

  • qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
  • qmake/config.tests/libexecdir/libexecdir.pro: Removed.
  • qmake/mkspecs/features/features.prf:
6:38 AM Changeset in webkit [137144] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
​https://bugs.webkit.org/show_bug.cgi?id=104548

  • platform/chromium/TestExpectations:

Hyphenation tests failure on WebKit-only checkout Linux

6:31 AM Changeset in webkit [137143] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed: update expectation for inspector/styles/svg-style.xhtml

  • inspector/styles/svg-style-expected.txt:
  • platform/chromium/TestExpectations:
6:15 AM Changeset in webkit [137142] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Overrides] Unable to change values in Device Metrics override setting
​https://bugs.webkit.org/show_bug.cgi?id=104542

Reviewed by Vsevolod Vlasov.

Remove inadvertent object property assignment.

  • inspector/front-end/OverridesView.js:
5:51 AM Changeset in webkit [137141] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r135863): GtkLauncher --help no longer displays all help options
​https://bugs.webkit.org/show_bug.cgi?id=104382

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2012-12-10
Reviewed by Philippe Normand.

Remove gst_init() because it steals the GOptionContext.
gst_init_get_option_group() already does the initialization job.

  • GtkLauncher/main.c:

(main):

5:34 AM Changeset in webkit [137140] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview
​https://bugs.webkit.org/show_bug.cgi?id=104504

Reviewed by George Staikos.

When deleting a webview, the webkit thread will send a sync message to userInterfaceThread
to delete handlers, including the viewport accessor. But the UserInterfaceThread could be
doing a blit after it has deleted the viewport accessor and before the webkit thread gets
the time slot to resume it's operation to clean up the webview, which leaves a very short
time that viewport accessor of a webpage has been deleted while the webpage is still in
the process of deleting, and the viewport accessor is referenced in the UserInterfaceThread.

So we need to check if the viewport accessor is NULL before using it in the backingstore code.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):

5:14 AM Changeset in webkit [137139] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Builds for Mac are tied to the OS system instead of the SDK version.
​https://bugs.webkit.org/show_bug.cgi?id=104529

Reviewed by Simon Hausmann.

Using work by Eike Ziller <​eike.ziller@digia.com>.

The build system now first tries to assign the correct system libraries
for the SDK being used for Mac builds. If this does not yield any
result, it falls back to using the Mac OS version to determine the
correct library.

No new tests (not applicable).

  • WebCore.pri:
4:58 AM Changeset in webkit [137138] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix build without QtQuick 2

Unreviewed trivial build fix.

This function is defined in QtWebContext, which is only used when QtQuick2 is available.

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInvalidateContext):

4:20 AM Changeset in webkit [137137] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: touch RenderingAllInOne.cpp to fix Apple Windows builder.

  • rendering/RenderingAllInOne.cpp:
4:18 AM Changeset in webkit [137136] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Network: newly added items are not filtered.
​https://bugs.webkit.org/show_bug.cgi?id=104021

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2012-12-10
Reviewed by Vsevolod Vlasov.

Extracted method to higlight/hide record according to filter.
Used this method to process newly created records.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._applyFilter): Extracted.
(WebInspector.NetworkLogView.prototype.performFilter): Refactored.

4:11 AM Changeset in webkit [137135] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Unreviewed: move reportMemoryUsage to public section.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.h:

(RenderBox):

4:03 AM Changeset in webkit [137134] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Managing current failures on the 64-bit debug builder to get it green.

  • platform/gtk/TestExpectations:
3:53 AM QtWebKitReleases edited by Simon Hausmann
(diff)
3:50 AM WebKitEFLLayoutTest edited by thiago.santos@intel.com
(diff)
3:47 AM Changeset in webkit [137133] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: adds an option to remove toolbar icons.
​https://bugs.webkit.org/show_bug.cgi?id=95654

Reviewed by Vsevolod Vlasov.

  • removes compact mode in favor or dock-to-bottom
  • introduces setting for hiding toolbar icons
  • inspector/front-end/DockController.js:

(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype.setDockedToBottom):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDrag):

  • inspector/front-end/helpScreen.css:

(body.dock-to-bottom .help-content):

  • inspector/front-end/inspector.css:

(body.dock-to-bottom #toolbar):
(body.no-toolbar-icons #toolbar):
(body.dock-to-bottom.port-qt #toolbar):
(body.dock-to-bottom.inactive #toolbar):
(body.no-toolbar-icons .toolbar-item.toggleable):
(body.dock-to-bottom .toolbar-item.toggleable):
(body.dock-to-bottom .toolbar-icon):
(body.no-toolbar-icons .toolbar-icon):
(body.no-toolbar-icons #main):
(body.dock-to-bottom .toolbar-icon.custom-toolbar-icon):
(body.dock-to-bottom .toolbar-item:active .toolbar-icon):
(body.dock-to-bottom .toolbar-label):
(body.dock-to-bottom #search-toolbar-label):
(body.no-toolbar-icons .toolbar-label):
(body.no-toolbar-icons #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item.toggleable:hover):
(body.no-toolbar-icons #toolbar-dropdown .toolbar-label):
(body.no-toolbar-icons #toolbar-dropdown .toolbar-item):
(body.dock-to-bottom .toolbar-item.resources .toolbar-icon):
(body.dock-to-bottom .toolbar-item.network .toolbar-icon):
(body.dock-to-bottom .toolbar-item.scripts .toolbar-icon):
(body.dock-to-bottom .toolbar-item.timeline .toolbar-icon):
(body.dock-to-bottom .toolbar-item.profiles .toolbar-icon):
(body.dock-to-bottom .toolbar-item.audits .toolbar-icon):
(body.dock-to-bottom .toolbar-item.console .toolbar-icon):
(body.dock-to-bottom.port-qt .toolbar-item.close-left, body.dock-to-bottom.port-qt .toolbar-item.close-right):
(body.dock-to-bottom #main):

3:43 AM QtWebKitReleases edited by Simon Hausmann
(diff)
3:41 AM QtWebKitReleases edited by Simon Hausmann
(diff)
3:39 AM Changeset in webkit [137132] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Remove duplicate expectations
​https://bugs.webkit.org/show_bug.cgi?id=104526

Unreviewed gardening: collect all WebAudio-related skips
to one place.

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2012-12-10

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:34 AM Changeset in webkit [137131] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Refactoring: Remove HTMLFormControlElement::autofocus
​https://bugs.webkit.org/show_bug.cgi?id=104524

Reviewed by Kentaro Hara.

autofocus function is used only by HTMLFormControlElement itself, no
sub-classes override it, and it is not exposed via an IDL attribute,

No new tests. This doesn't make any behavior changes.

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus): Use fastHasAttribute instead of autofocus().

  • html/HTMLFormControlElement.h: Remove autofocus().
3:30 AM Changeset in webkit [137130] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[GTK][WTR] Implement AccessibilityUIElement::titleUIElement
​https://bugs.webkit.org/show_bug.cgi?id=102953

Reviewed by Martin Robinson.

Implement AccessibilityUIElement::titleUIElement in the ATK backend
in the same manner it is implemented in DumpRenderTree. Both implementations
are updated to unref the relation set before the final function return
rather than at the end of each loop through the relations held in the said
relation set.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::titleUIElement):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::titleUIElement):

3:29 AM Changeset in webkit [137129] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix GC3Dintptr and GC3Dsizeiptr typedefs for Win64
​https://bugs.webkit.org/show_bug.cgi?id=104426

Patch by Jonathan Liu <​net147@gmail.com> on 2012-12-10
Reviewed by Simon Hausmann.

The GC3Dintptr and GC3Dsizeiptr typedefs are incorrect for Win64 as
LLP64 is used there. This would result in compile error due to
narrowing conversion of 64-bit pointer to signed long int which is
32-bit.

  • platform/graphics/GraphicsTypes3D.h:
3:00 AM Changeset in webkit [137128] by Martin Robinson
  • 2 edits in trunk/Tools

Fix the WebKit2 debug build

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().

2:44 AM Changeset in webkit [137127] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

[WTR] Move text output accumulation to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=104214

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-12-10
Reviewed by Darin Adler.

Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess
once a test is finished, immediately send any text output to the UIProcess. This will allow
WebKitTestRunner to output text from the UIProcess as well.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output

StringBuilder. Add a method to send output to the UIProcess.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder

to use the new outputText method.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
(WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
(WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
method of printing the text is slightly different.
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
message by appending the results to the StringBuilder.

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation): Switch the type of m_textOutput.

2:37 AM Changeset in webkit [137126] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove the dependency of ShareableSurface from Coordinated Graphics.
​https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

It is a follow-up patch of r137117.

There are two changes

  1. Add a const qualifier to supportsAlpha().
  2. Use << instead of encode() when using ArgumentEncoder.
  • Shared/CoordinatedGraphics/CoordinatedSurface.h:

(WebKit::CoordinatedSurface::supportsAlpha):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::copyToTexture):

2:35 AM Changeset in webkit [137125] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove the dependency of ShareableSurface from Coordinated Graphics.
​https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

WebCoordinatedSurface::copyToTexture should return early if the backend
is GraphicsSurface.

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::copyToTexture):

2:26 AM Changeset in webkit [137124] by tkent@chromium.org
  • 16 edits in trunk/Source

Refactoring: Introduce HTMLFormControlElement::isDisabledOrReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=104508

Reviewed by Kentaro Hara.

Source/WebCore:

We have a lot of code like element->disabled
element->readOnly().

isDisabledOrReadOnly makes them simpler.

No new tests. This make no behaivor change.

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
Added. Note that the implmentation of disabled() is not just "return m_disabled;".

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Use isDisabledOrReadOnly.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToMouseEvents): Ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isPickerIndicatorOwnerDisabledOrReadOnly): Ditto.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::handleDOMActivateEvent): Ditto.
(WebCore::ColorInputType::didChooseColor): Ditto.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::recalcWillValidate): Ditto.

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::valueMissing): Ditto.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent): Ditto.
(WebCore::RangeInputType::handleTouchEvent): Ditto.
(WebCore::RangeInputType::handleKeydownEvent): Ditto.

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent): Ditto.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): Ditto.
(WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents): Ditto.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Ditto.
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Ditto.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Ditto.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::defaultEventHandler): Ditto.
(WebCore::TextFieldDecorationElement::willRespondToMouseMoveEvents): Ditto.
(WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents): Ditto.

Source/WebKit/blackberry:

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup): Use isDisabledOrReadOnly.
(BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):
Use isDisabledOrReadOnly. Also, remove unnecessary local variable.

2:14 AM Changeset in webkit [137123] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing failure expectations for the MicroData tests that were fixed in r137107.

  • platform/gtk/TestExpectations:
2:12 AM Changeset in webkit [137122] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Check that plugin functionality is enabled before querying the database for installed plugins.
​https://bugs.webkit.org/show_bug.cgi?id=73671

Patch by Andy Shaw <​andy.shaw@digia.com> on 2012-12-10
Reviewed by Jocelyn Turcotte.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::objectContentType):

1:38 AM Changeset in webkit [137121] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: console broken? - console.dirxml behaves like console.log
​https://bugs.webkit.org/show_bug.cgi?id=104245

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Do not generate preview for dirxml.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):

LayoutTests:

  • inspector/console/console-dirxml-expected.txt:
  • inspector/console/console-dirxml.html:
  • platform/chromium/TestExpectations:
1:29 AM Changeset in webkit [137120] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring: Remove HTMLFormControlElement::setDisabled
​https://bugs.webkit.org/show_bug.cgi?id=104510

Reviewed by Kentaro Hara.

Remove it because the number of call sites is only one, and the
setDisabled implementation is equivalent to setBooleanAttribute.

No new tests. This should not make behavior changes.

  • html/HTMLFormControlElement.cpp: Remove setDisabled.
  • html/HTMLFormControlElement.h: Ditto.
  • html/FileInputType.cpp:

(WebCore::FileInputType::disabledAttributeChanged):
Replace setDisabled with setBooleanAttribute.

1:03 AM Changeset in webkit [137119] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

[Shadow DOM][Refacdtoring] nextTo() and previousTo() can be part of ContentDistribution
​https://bugs.webkit.org/show_bug.cgi?id=104514

Reviewed by Kentaro Hara.

InsertionPoint::nextTo() and InsertionPoint::previousTo() are an
query to distributed nodes, which is what ContentDistribution
represents. We can move them to better home.

No new tests. No behavior change.

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistribution::nextTo): Moved from InsertionPoint
(WebCore):
(WebCore::ContentDistribution::previousTo): Moved from InsertionPoint

  • html/shadow/ContentDistributor.h:

(ContentDistribution):

  • html/shadow/InsertionPoint.cpp:
  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::nextTo): Delegated to ContentDistribution
(WebCore::InsertionPoint::previousTo): Delegated to ContentDistribution

12:42 AM Changeset in webkit [137118] by mihnea@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.

12:28 AM Changeset in webkit [137117] by commit-queue@webkit.org
  • 18 edits
    2 moves
    1 add in trunk/Source/WebKit2

Coordinated Graphics: Add CoordinatedSurface to remove the dependency of ShareableSurface from Coordinated Graphics.
​https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-10
Reviewed by Noam Rosenthal.

Internal Review by Gwang Yoon Hwang and Jae Hyun Park.

It is a preparation patch for Threaded Coordinated Graphics on WK1.

Create a CoordinatedSurface class that can be the base class both for
the current IPC-based ShareableSurface, renamed here to
WebCoordinatedSurface, and to a future thread-based surface
implementation.

  • CMakeLists.txt:
  • Shared/CoordinatedGraphics/CoordinatedSurface.h: Added.

(WebCore):
(WebKit):
(CoordinatedSurface):
(WebKit::CoordinatedSurface::~CoordinatedSurface):
(WebKit::CoordinatedSurface::supportsAlpha):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Renamed from Source/WebKit2/Shared/ShareableSurface.cpp. Extends CoordinatedSurface.

(WebKit):
(WebKit::WebCoordinatedSurface::Handle::Handle):
(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::Handle::decode):
(WebKit::CoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::createWithSurface):
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
(WebKit::WebCoordinatedSurface::~WebCoordinatedSurface):
(WebKit::WebCoordinatedSurface::createHandle):
(WebKit::WebCoordinatedSurface::copyToTexture):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Renamed from Source/WebKit2/Shared/ShareableSurface.h.

(WebCore):
(WebKit):
(WebCoordinatedSurface):
(Handle):
(WebKit::WebCoordinatedSurface::Handle::graphicsSurfaceToken):
(WebKit::WebCoordinatedSurface::isBackedByGraphicsSurface):

  • Target.pri:
  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::swapBuffers):
(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(WebKit):
(CoordinatedBackingStoreTile):
(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createUpdateAtlas):
(WebKit::LayerTreeCoordinatorProxy::updateImageBacking):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::updateImageBacking):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(TileUpdate):
(WebKit::LayerTreeRenderer::TileUpdate::TileUpdate):
(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:

(WebKit::CoordinatedImageBacking::update):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:

(Coordinator):
(CoordinatedImageBacking):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::updateImageBacking):
(WebKit::LayerTreeCoordinator::createUpdateAtlas):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
(WebKit::LayerTreeCoordinator::releaseInactiveAtlasesTimerFired):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

(UpdateAtlasClient):
(UpdateAtlas):
(WebKit::UpdateAtlas::supportsAlpha):

12:22 AM Changeset in webkit [137116] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip 5 MicroData test cases that were fixed in r137107.

  • platform/efl/TestExpectations:
12:19 AM Changeset in webkit [137115] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Add fast/canvas/webgl tests to TestExpectations since they
sometimes crash on the bots.

  • platform/efl/TestExpectations:
12:17 AM Changeset in webkit [137114] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] accessibility/language-attribute.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98369

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

The test is failing for two reasons: Not exposing the language
for accessible objects and AccessibilityUIElement::language() not
being implemented.

Source/WebCore:

No new tests; instead, unskipped the previously-failing test.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject): Expose the language via AtkText attribute

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::language): Implemented.

LayoutTests:

  • accessibility/language-attribute.html: Modified the test to work with

both Mac and Atk platforms. (The former exposes static text objects as
accessibles; the latter folds the text into the parent element.)

  • platform/gtk/TestExpectations: Unskipped the previously-failing test.
12:04 AM Changeset in webkit [137113] by commit-queue@webkit.org
  • 9 edits
    2 moves in trunk

[GTK] accessibility/editable-webarea-context-menu-point.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98364

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Tools:

The test is failing because the clickPoint values remain unchanged. The
values remain unchanged because ATK lacks a means to keep track of this
information.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
(AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details

LayoutTests:

This test seems to be Mac-specific. Therefore, move the test to that
platform and remove the skips from the other platforms.

  • platform/chromium/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/efl-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/gtk-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/gtk/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt.
  • platform/mac/accessibility/editable-webarea-context-menu-point.html: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point.html.
  • platform/win/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/wincairo/TestExpectations: Remove editable-webarea-context-menu-point.html

Dec 9, 2012:

11:43 PM Changeset in webkit [137112] by tasak@google.com
  • 7 edits in trunk

[Shadow DOM]: reset-style-inheritance doesn't work for insertion point
​https://bugs.webkit.org/show_bug.cgi?id=103711

Reviewed by Hajime Morita.

Source/WebCore:

reset-style-inheritance can be specified by using insertion points'
attribute, e.g. <content reset-style-inheritance>.
c.f. shadow dom spec:
​https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#styles

No new tests. Updated an existing test,
fast/dom/shadow/insertion-point-resetStyleInheritance.html to cover
this feature.

  • html/HTMLAttributeNames.in:

Added HTMLNames::reset_style_inheritanceAttr.

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::parseAttribute):
Since both shadow and content elements have to support
reset-style-inheritance, added InsertionPoint::parseAttribute.
(WebCore::InsertionPoint::resetStyleInheritance):
(WebCore::InsertionPoint::setResetStyleInheritance):
Modified to update reset-style-inheritance attribute value.

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
Removed m_shouldResetStyleInheritance. Instead, use
reset-style-inheritance attribute value.

LayoutTests:

  • fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt:
  • fast/dom/shadow/insertion-point-resetStyleInheritance.html:

Added two more basic tests to cover <content reset-style-inheritance>
and <shadow reset-style-inheritance>.

11:28 PM Changeset in webkit [137111] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
​https://bugs.webkit.org/show_bug.cgi?id=104481

Patch by Alejandro Piñeiro <​apinheiro@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectable): Implement this by checking
the current state of the AtkObject.
(AccessibilityUIElement::isMultiSelectable): Implement this by
checking the current state of the AtkObject.

10:54 PM Changeset in webkit [137110] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG ArrayPush/Pop should not pass their second child as the index for blessArrayOperation()
​https://bugs.webkit.org/show_bug.cgi?id=104500

Reviewed by Oliver Hunt.

Slight across-the-board speed-up.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

10:45 PM Changeset in webkit [137109] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
​https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-09
Reviewed by Noam Rosenthal.

Send SetRootCompositingLayer message to the UI process before
flushing compositing states of layer tree.

This is in preparation for refactoring TextureMapper to work in an actor
model (​http://webkit.org/b/103854).

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

10:16 PM Changeset in webkit [137108] by loislo@chromium.org
  • 32 edits in trunk/Source/WebCore

Native Memory Instrumentation: instrument a part of RenderObject class tree.
​https://bugs.webkit.org/show_bug.cgi?id=103564

Reviewed by Eric Seidel.

Many RenderObject descendants have OwnPtrs and RefPtrs members.
Looks like we have to instrument all the RenderObject classes and visit
all the render objects instead of counting entire render arena memory.

  • WebCore.exp.in:
  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::reportRenderTreeInfo):
(WebCore):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

  • platform/PlatformMemoryInstrumentation.h:

(PlatformMemoryTypes):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::reportMemoryUsage):
(WebCore):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::reportMemoryUsage):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::reportMemoryUsage):
(WebCore):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reportMemoryUsage):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::reportMemoryUsage):
(WebCore):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::reportMemoryUsage):
(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderText.cpp:

(WebCore::RenderText::reportMemoryUsage):
(WebCore):

  • rendering/RenderText.h:

(RenderText):

  • rendering/RenderView.cpp:

(WebCore::RenderView::reportMemoryUsage):
(WebCore):

  • rendering/RenderView.h:

(RenderView):

9:39 PM Changeset in webkit [137107] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

REGRESSION (r137003): failures in MicroData tests on EFL, GTK
​https://bugs.webkit.org/show_bug.cgi?id=104469

Reviewed by Darin Adler.

Fix the regression by calling propertyNodeList on HTMLPropertiesCollection
in the named getter for HTMLCollection. It's a miracle that the old code prior to r137003
worked at all since the return type of namedItem was different.

Existing tests cover this.

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

9:09 PM Changeset in webkit [137106] by commit-queue@webkit.org
  • 38 edits in trunk/LayoutTests

[Qt] Gardening after r137006.
​https://bugs.webkit.org/show_bug.cgi?id=104432

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-12-09
Reviewed by Kentaro Hara.

Update existing tests that are affected by r137006.

  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
7:58 PM Changeset in webkit [137105] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r137103.
​http://trac.webkit.org/changeset/137103
​https://bugs.webkit.org/show_bug.cgi?id=104503

Didn't resolve the chrome win build bot failure, problem moved
elsewhere. (Requested by noel_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-09

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

7:39 PM Changeset in webkit [137104] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Gardening for Accelerated Compositing
​https://bugs.webkit.org/show_bug.cgi?id=104466

Unreviewed, EFL gardening.

As EFL WK1 does not support Accelerated Compositing, related cases should be skipped from layout tests.

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-12-09

  • platform/efl-wk1/TestExpectations:
7:05 PM EFLWebKit edited by Seokju Kwon
Add Web Inspector in EFL (diff)
7:02 PM Changeset in webkit [137103] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] webkit_unit_tests tests are failing on win
​https://bugs.webkit.org/show_bug.cgi?id=104502

Unreviewed test fix: disable applyScrollToScrollableArea test.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

5:59 PM Changeset in webkit [137102] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening: broken or flakey hardness perftests

fast/harness/perftests/runs-per-second-iterations.html
fast/harness/perftests/perf-runner-compute-statistics.html
fast/harness/perftests/runs-per-second-log.html

  • platform/chromium/TestExpectations:
5:17 PM Changeset in webkit [137101] by tkent@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebCore/Resources/pagepopups/pickerCommon.js

Merge 136671

Fix flickering when hiding page popup
​https://bugs.webkit.org/show_bug.cgi?id=104100

Reviewed by Kent Tamura.

Moving the page popup while hiding was causing flickering in some environments.

No new tests. Can't reproduce in layout test.

  • Resources/pagepopups/pickerCommon.js:

(hideWindow): Don't move and just resize.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/11488003

5:11 PM Changeset in webkit [137100] by tkent@chromium.org
  • 3 edits in branches/chromium/1312

Merge 136803

Source/WebCore: INPUT_MULTIPLE_FIELDS_UI: The hour, am/pm, millisecond fields should support read-only state correctly
​https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  1. The hour, am/pm, and millisecond fields should have CSS rules for [readonly]. They should be gray when they are read-only.
  2. The am/pm field should reject to set an empty value like other numeric fields do.

Tests: Add test cases to fast/forms/time/time-appearance-basic.html.

  • css/html.css: merge existing readonly rules, and add ampm, hour, and

millisecond pseudo classes.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
Reject to set empty value if it is read-only.

LayoutTests: INPUT_MULTIPLE_FIELDS_UI: The hour field and the am/pm field should support read-only state correctly
​https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  • fast/forms/time/time-appearance-basic.html:

Add test cases for step=86400 (24 hours)

  • platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/11503003

5:09 PM Changeset in webkit [137099] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] accessibility/placeholder.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98373

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The test was failing because the placeholder text was not supported and
AccessibilityUIElement::stringAttributeValue() was not implemented.

Source/WebCore:

No new tests; instead the failing test was unskipped.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Add the placeholder text as an AtkAttribute
of the AtkObject, as is done in Gtk+ 3.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
names into AtkObject attribute names
(AccessibilityUIElement::stringAttributeValue): implemented

LayoutTests:

  • platform/gtk/TestExpectations: Unskip the failing test
2:56 PM Changeset in webkit [137098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] [WebGL] Path is not resized correctly.
​https://bugs.webkit.org/show_bug.cgi?id=104458.

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2012-12-09
Reviewed by Kenneth Rohde Christiansen.

In GraphicsContext3D::paintToCanvas, we flip the contents and draw on the surface.
The operations done to flip the image (translation and scale) are done before rectangle with correct size
is added to current path. This resulted in updating pixels at wrong positions.

Covered by existing tests.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

2:53 PM Changeset in webkit [137097] by joone.hur@intel.com
  • 4 edits in trunk/Source/WebCore

[GTK][AC] build fix after r130525 and r133332
​https://bugs.webkit.org/show_bug.cgi?id=104491

Reviewed by Martin Robinson.

Build fix for Accelerated Compositing Clutter backend after r130525 and r133332.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:
  • platform/gtk/RedirectedXCompositeWindow.cpp:
  • platform/gtk/RedirectedXCompositeWindow.h:
1:45 PM Changeset in webkit [137096] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for 15 layout tests that started failing after libxml2
version used in Jhbuild was bumped in r137090.

  • platform/gtk/TestExpectations:
12:43 PM Changeset in webkit [137095] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkitgtk-1.10.2

Tagging WebKitGTK+ 1.10.2.

12:41 PM Changeset in webkit [137094] by fpizlo@apple.com
  • 18 edits
    2 adds in trunk/Source/JavaScriptCore

JSC should scale the optimization threshold for a code block according to the cost of compiling it
​https://bugs.webkit.org/show_bug.cgi?id=104406

Reviewed by Oliver Hunt.

We've long known that we want to scale the execution count threshold needed for the DFG
to kick in to scale according to some estimate of the cost of compiling that code block.
This institutes a relationship like this:

threshold = thresholdSetting * (a * sqrt(instructionCount + b) + abs(c * instructionCount) + d

Where a, b, c, d are coefficients derived from fitting the above expression to various
data points, which I chose based on looking at one benchmark (3d-cube) and from my
own intuitions.

Making this work well also required changing the thresholdForOptimizeAfterLongWarmUp
from 5000 to 1000.

This is a >1% speed-up on SunSpider, a >3% speed-up on V8Spider, ~1% speed-up on V8v7,
neutral on Octane, and neutral on Kraken.

I also out-of-lined a bunch of methods related to these heuristics, because I couldn't
stand having them defined in the header anymore. I also made improvements to debugging
code because I needed it for tuning this change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::sourceCodeOnOneLine):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::optimizationThresholdScalingFactor):
(JSC::clipThreshold):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::counterValueForOptimizeSoon):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/CodeBlock.h:
  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::hasCrossedThreshold):

  • bytecode/ReduceWhitespace.cpp: Added.

(JSC::reduceWhitespace):

  • bytecode/ReduceWhitespace.h: Added.
  • dfg/DFGCapabilities.cpp:

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):

  • dfg/DFGCapabilities.h:
  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpHeader):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):

  • runtime/Options.h:
12:32 PM WebInspector edited by zandobersek@gmail.com
Begone spam! (diff)
12:32 PM BadContent edited by zandobersek@gmail.com
Add a spamming mail address. (diff)
12:15 PM Changeset in webkit [137093] by Carlos Garcia Campos
  • 16 edits in trunk/Source/WebCore

[GTK] Use GObject casts instead of C++ cast for GObjects in DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=104492

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateCFile):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(WebKit::kit):

11:33 AM Changeset in webkit [137092] by senorblanco@chromium.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] Unreviewed. Temporarily disable a webkit_unit_tests test
that's failing on Windows.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

LayoutTests: [Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:28 AM Changeset in webkit [137091] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: do not treat object as equal to itself when logging to console
​https://bugs.webkit.org/show_bug.cgi?id=104487

Reviewed by Alexander Pavlov.

Source/WebCore:

Otherwise, mutating object in a loop results in the repeat count update instead of generation of the new preview.

Test: inspector/console/console-object-preview.html

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::isEqual):

LayoutTests:

  • inspector/console/console-object-preview-expected.txt: Added.
  • inspector/console/console-object-preview.html: Added.
11:28 AM Changeset in webkit [137090] by danw@gnome.org
  • 2 edits in trunk/Tools

[GTK] Bump libxml2 requirement in jhbuild.modules
​https://bugs.webkit.org/show_bug.cgi?id=104477

Reviewed by Martin Robinson.

Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
tests won't run if we only have libxml2 2.8.0 installed in the
jhbuild root.

  • gtk/jhbuild.modules:
11:00 AM Changeset in webkit [137089] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Remove unused code in GObject DOM bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=104490

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperties): Remove code to install event listeners and
signals.

10:55 AM Changeset in webkit [137088] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[GTK] accessibility/canvas-fallback-content.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98362

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The failure was due to platform-specific expectations of the accessible
role reported for comboboxes. The solution was conditionalizing the test.

  • accessibility/canvas-fallback-content.html: Base expected role on platform.
  • platform/gtk/TestExpectations: Unskipped the test.
  • platform/gtk/accessibility/canvas-fallback-content-expected.txt: Added.
10:40 AM Changeset in webkit [137087] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.10

Patch by Gustavo Noronha on 2012-12-09
Reviewed by Martin Robinson.

Update configure.ac and the NEWS in preparation for the 1.10.2 release.

10:39 AM Changeset in webkit [137086] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 132363 - [GTK] Typos in user-visible strings: "coordintate"
​https://bugs.webkit.org/show_bug.cgi?id=100252

Patch by Priit Laes <​plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

s/coordintate/coordinate

  • webkit/webkithittestresult.cpp:

(webkit_hit_test_result_class_init):

10:39 AM Changeset in webkit [137085] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131478 - [GStreamer] GstBuffer ref race in WebKitWebAudioSrcLoop
​https://bugs.webkit.org/show_bug.cgi?id=95833

Reviewed by Philippe Normand.

The render bus used in GStreamer's implementation of AudioDestination no longer
allocates memory for each of its channels. Rather than that, when looping, the
data is rendered into a channel-specific GstBuffer. Each buffer is then chained
to the appropriate GstPad, as has been the case before.

No new tests - there are tests covering this change but they are not yet working
on the GTK port or any other GStreamer implementation of Web Audio.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(_WebKitWebAudioSourcePrivate): Remove an unused member variable.
(webkit_web_audio_src_init): Remove an unnecessary line.
(webKitWebAudioSrcConstructed): Ditto.
(webKitWebAudioSrcLoop):

10:38 AM Changeset in webkit [137084] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131755 - [GTK] AudioBusGtk sometimes fails to load the HRTF database
​https://bugs.webkit.org/show_bug.cgi?id=99601

Reviewed by Martin Robinson.

AudioBusGtk now first lookup for the uninstalled resource files,
if the AUDIO_RESOURCES_PATH environment variable is
set. Additionally the audio file reader is now better dealing with
errors, returning an empty AudioBus in such cases and issuing
warnings on the console output. The cleanup of some member
variables was also moved to the destructor.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader): Clear and free
member variables. This was done in createBus before.
(WebCore::AudioFileReader::handleMessage): Issue warnings in case
of error and exit from the main loop so the pipeline is not
forever stuck.
(WebCore::AudioFileReader::createBus): Return an empty bus in case
of error.

  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Load uninstalled
resources first if AUDIO_RESOURCES_PATH is set.

10:25 AM WebKitGTK/1.10.x edited by kov@webkit.org
(diff)
10:22 AM WebKitGTK edited by kov@webkit.org
(diff)
10:20 AM Changeset in webkit [137083] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:19 AM Changeset in webkit [137082] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Unreviewed update for the GObject bindings after r137074 and r137078.

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(webkit_dom_test_event_target_dispatch_event):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_supplemental_method2):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):

10:16 AM Changeset in webkit [137081] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
10:14 AM Changeset in webkit [137080] by zandobersek@gmail.com
  • 11 edits in trunk/Tools

Remove testRunner.disableImageLoading()
​https://bugs.webkit.org/show_bug.cgi?id=98083

Reviewed by Gustavo Noronha Silva.

Remove the disableImageLoading methods and callback.
No tests use the method anymore and all ports except Wx
now support this behavior through overriding the
WebKitDisplayImagesKey preference.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::overridePreference): Add support for overriding the
WebKitDisplayImagesKey preference which is now the preferred way
of disabling image loading.

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
9:55 AM WebKitGTK/1.10.x edited by kov@webkit.org
Striking the commits that have been merged (diff)
9:48 AM Changeset in webkit [137079] by senorblanco@chromium.org
  • 4 edits in trunk/LayoutTests

Try to fix a finnicky reftest.
​https://bugs.webkit.org/show_bug.cgi?id=104486

Reviewed by Simon Fraser.

This reftest fails on Chromium Mac since the leftmost pixel of the 'T'
of 'Text' is clipped in composited mode, and non-clipped in software
painting. Not sure exactly why, but a lowercase 't' doesn't seem to
have this problem.

  • compositing/background-color/background-color-change-to-text-expected.html:
  • compositing/background-color/background-color-change-to-text.html:
  • platform/chromium-mac/compositing/background-color/background-color-change-to-text-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/background-color/background-color-change-to-text-expected.png: Removed.
  • platform/chromium/TestExpectations:
9:34 AM Changeset in webkit [137078] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Fix the GError check in GObject DOM bindings.

Reviewed by Xan Lopez.

Previous commit introduced a check to make sure the passed GError
is valid in all DOM methods receiving an error.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGReturnMacro): Check that the passed GError either is NULL or
the pointer has been initialized to NULL.

9:10 AM Changeset in webkit [137077] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.10

Merge 133610 - Heap-buffer-overflow in WebCore::TextTrackCueList::add
​https://bugs.webkit.org/show_bug.cgi?id=101018

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-11-06
Reviewed by Eric Carlson.

Source/WebCore:

Added an extra check to avoid using a negative array index when a cue
is added to the beginning of the list.

Test case added to LayoutTests/media/track/track-add-remove-cue.html.

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add):

LayoutTests:

Added a test case to verify that adding a cue to the beginning of a non-empty list doesn't crash.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
8:36 AM Changeset in webkit [137076] by senorblanco@chromium.org
  • 2 edits
    40 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
8:30 AM Changeset in webkit [137075] by leoyang@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adapt to name change of createNetworkBufferByCopyingData()
​https://bugs.webkit.org/show_bug.cgi?id=104449

Reviewed by Rob Buis.

Name change no new tests.

  • platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::handleRSSContent):

8:17 AM Changeset in webkit [137074] by Carlos Garcia Campos
  • 16 edits in trunk/Source/WebCore

[GTK] Clean up g_return macros usage in GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=101079

Reviewed by Xan Lopez.

Several improvements:

  • Move g_return macros at the beginning of the methods.
  • Use them only to check parameters of public API.
  • Use GObject macros to check GObjects.
  • Check also GError parameters.
  • Use early returns in kit and core methods, since they should work even if g_return macros are disabled handling NULL gracefully.
  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGReturnMacro):
(GenerateFunction):
(GenerateCFile):
(Generate):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_foo):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_exciting_function):
(webkit_dom_test_active_dom_object_post_message):
(webkit_dom_test_active_dom_object_get_exciting_attr):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_callback_with_no_param):
(webkit_dom_test_callback_callback_with_class1param):
(webkit_dom_test_callback_callback_with_class2param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_with_string_list):
(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_another_function):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_item):
(webkit_dom_test_event_target_dispatch_event):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_get_name):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_supplemental_method4):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNamedConstructor):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNode):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_void_method):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_long_method):
(webkit_dom_test_obj_long_method_with_args):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_serialized_value):
(webkit_dom_test_obj_idb_key):
(webkit_dom_test_obj_options_object):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void):
(webkit_dom_test_obj_with_script_state_obj):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context):
(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_method_with_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_class_method):
(webkit_dom_test_obj_class_method_with_optional):
(webkit_dom_test_obj_overloaded_method1):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_mutable_point_function):
(webkit_dom_test_obj_immutable_point_function):
(webkit_dom_test_obj_orange):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_variadic_string_method):
(webkit_dom_test_obj_variadic_double_method):
(webkit_dom_test_obj_variadic_node_method):
(webkit_dom_test_obj_get_read_only_long_attr):
(webkit_dom_test_obj_get_read_only_string_attr):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_short_attr):
(webkit_dom_test_obj_set_short_attr):
(webkit_dom_test_obj_get_unsigned_short_attr):
(webkit_dom_test_obj_set_unsigned_short_attr):
(webkit_dom_test_obj_get_long_attr):
(webkit_dom_test_obj_set_long_attr):
(webkit_dom_test_obj_get_long_long_attr):
(webkit_dom_test_obj_set_long_long_attr):
(webkit_dom_test_obj_get_unsigned_long_long_attr):
(webkit_dom_test_obj_set_unsigned_long_long_attr):
(webkit_dom_test_obj_get_string_attr):
(webkit_dom_test_obj_set_string_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_set_test_obj_attr):
(webkit_dom_test_obj_get_xml_obj_attr):
(webkit_dom_test_obj_set_xml_obj_attr):
(webkit_dom_test_obj_get_create):
(webkit_dom_test_obj_set_create):
(webkit_dom_test_obj_get_reflected_string_attr):
(webkit_dom_test_obj_set_reflected_string_attr):
(webkit_dom_test_obj_get_reflected_integral_attr):
(webkit_dom_test_obj_set_reflected_integral_attr):
(webkit_dom_test_obj_get_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_set_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_get_reflected_boolean_attr):
(webkit_dom_test_obj_set_reflected_boolean_attr):
(webkit_dom_test_obj_get_reflected_url_attr):
(webkit_dom_test_obj_set_reflected_url_attr):
(webkit_dom_test_obj_get_reflected_custom_integral_attr):
(webkit_dom_test_obj_set_reflected_custom_integral_attr):
(webkit_dom_test_obj_get_reflected_custom_boolean_attr):
(webkit_dom_test_obj_set_reflected_custom_boolean_attr):
(webkit_dom_test_obj_get_reflected_custom_url_attr):
(webkit_dom_test_obj_set_reflected_custom_url_attr):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_get_string_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_get_any_attribute):
(webkit_dom_test_obj_set_any_attribute):
(webkit_dom_test_obj_get_content_document):
(webkit_dom_test_obj_get_mutable_point):
(webkit_dom_test_obj_set_mutable_point):
(webkit_dom_test_obj_get_immutable_point):
(webkit_dom_test_obj_set_immutable_point):
(webkit_dom_test_obj_get_strawberry):
(webkit_dom_test_obj_set_strawberry):
(webkit_dom_test_obj_get_strict_float):
(webkit_dom_test_obj_set_strict_float):
(webkit_dom_test_obj_get_description):
(webkit_dom_test_obj_get_id):
(webkit_dom_test_obj_set_id):
(webkit_dom_test_obj_get_hash):
(webkit_dom_test_obj_get_replaceable_attribute):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):
(webkit_dom_test_serialized_script_value_interface_get_value):
(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_ports):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):

7:56 AM Changeset in webkit [137073] by mihnea@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskip a skipped test for which i have added expectation in ​http://trac.webkit.org/changeset/135851.

  • platform/gtk-wk2/TestExpectations:
7:48 AM Changeset in webkit [137072] by Carlos Garcia Campos
  • 17 edits in trunk/Source/WebCore

[GTK] Use a private struct and placement new syntax in GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=101074

Reviewed by Xan Lopez.

It allows to use RefPtr for the wrapped object and it simplifies
the code. Only the classes deriving from WebKitDOMObject keep a
reference of the wrapped object in a private struct. The wrapped
object is added to the cache in GObjectClass::constructor() and
removed in GObjectClass::finalize().

  • bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::createWrapper):
(WebKit::kit):
(WebKit::wrapEventTarget):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetParentImplClassName):
(GenerateProperties):
(GenerateCFile):
(Generate):
(WriteData):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(_WebKitDOMTestActiveDOMObjectPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_finalize):
(webkit_dom_test_active_dom_object_constructor):
(webkit_dom_test_active_dom_object_class_init):
(webkit_dom_test_active_dom_object_init):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(_WebKitDOMTestCallbackPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_constructor):
(webkit_dom_test_callback_class_init):
(webkit_dom_test_callback_init):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(_WebKitDOMTestCustomNamedGetterPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_constructor):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(_WebKitDOMTestEventConstructorPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_constructor):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(_WebKitDOMTestEventTargetPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_finalize):
(webkit_dom_test_event_target_constructor):
(webkit_dom_test_event_target_class_init):
(webkit_dom_test_event_target_init):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(_WebKitDOMTestExceptionPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_constructor):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(_WebKitDOMTestInterfacePrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_finalize):
(webkit_dom_test_interface_constructor):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_init):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(_WebKitDOMTestMediaQueryListListenerPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):
(webkit_dom_test_media_query_list_listener_finalize):
(webkit_dom_test_media_query_list_listener_constructor):
(webkit_dom_test_media_query_list_listener_class_init):
(webkit_dom_test_media_query_list_listener_init):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(_WebKitDOMTestNamedConstructorPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNamedConstructor):
(webkit_dom_test_named_constructor_finalize):
(webkit_dom_test_named_constructor_constructor):
(webkit_dom_test_named_constructor_class_init):
(webkit_dom_test_named_constructor_init):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNode):
(webkit_dom_test_node_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(_WebKitDOMTestObjPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_constructor):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:

(_WebKitDOMTestOverloadedConstructorsPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestOverloadedConstructors):
(webkit_dom_test_overloaded_constructors_finalize):
(webkit_dom_test_overloaded_constructors_constructor):
(webkit_dom_test_overloaded_constructors_class_init):
(webkit_dom_test_overloaded_constructors_init):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(_WebKitDOMTestSerializedScriptValueInterfacePrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_constructor):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_init):

5:26 AM Changeset in webkit [137071] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] accessibility/label-for-control-hittest.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98368

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

Tools:

The test was failing because AccessibilityUIElement::elementAtPoint was
not implemented.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::elementAtPoint): implemented

LayoutTests:

Unskip the test having implemented AccessibilityUIElement::elementAtPoint.

  • platform/gtk/TestExpectations: unskip accessibility/label-for-control-hittest.html
3:41 AM Changeset in webkit [137070] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 compositing/background-color ref tests introduced
in r137006 as failing for WK2 EFL.

  • platform/efl-wk2/TestExpectations:
3:22 AM Changeset in webkit [137069] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline 2 media/track test cases after r136991.

  • platform/efl/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/efl/media/track/track-cue-rendering-vertical-expected.txt:
3:06 AM Changeset in webkit [137068] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark inspector/styles/import-pseudoclass-crash.html as crashing
since it is hitting m_childRuleCSSOMWrappers.size() == ruleCount
assertion after r136948.

  • platform/efl-wk2/TestExpectations:
2:43 AM Changeset in webkit [137067] by jonlee@apple.com
  • 15 edits
    2 deletes in trunk

[WK2] Move button image to injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=104107
<rdar://problem/12813842>

Reviewed by Simon Fraser.

Source/WebCore:

Update RenderSnapshottedPlugIn to retrieve the start button image from the ChromeClient. Expand the
kinds of images available for use as the button. Try to find the best sized button to use for the plug-in,
otherwise use no image at all.

  • rendering/RenderSnapshottedPlugIn.h: Add an enum representing the size to use. Remove the label rect

variable since it is unneeded.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::startLabelImage): Maintain a cache of the images for reuse. Index into the
array using the enum. If the image has been loaded, or an attempt was made, then return the result. Otherwise
ask the chrome client for the image.
(WebCore::RenderSnapshottedPlugIn::paintLabel): Determine the proper label to use, and paint if the image is
available.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Compare the label size with the provided content
box. Return a LayoutRect representing the label's placement. If it doesn't fit, return an empty rect.
(WebCore::RenderSnapshottedPlugIn::layout): The rect is not needed because it is all determined at paint time.

  • page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelImage): Added.

  • WebCore.exp.in: Expose GraphicsContext::drawNativeImage() for WKImageCG.cpp.
  • WebCore.xcodeproj/project.pbxproj: Remove start button assets.
  • Resources/startButton.png: Removed.
  • Resources/​startButton@2x.png: Removed.

Source/WebKit2:

Rely on the injected bundle to create the image used for the button in snapshotted plug-ins.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelImage): Forward the call to the injected bundle UI client.

  • WebProcess/WebCoreSupport/WebChromeClient.h: Implement plugInStartLabelImage().
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelImage): Convert the WebCore enums to WK API enums.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Expose a new callback to generate the button image.
  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage): Refactor to use GraphicsContext methods so that the image is flipped appropriately.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.

2:39 AM Changeset in webkit [137066] by Christophe Dumez
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Skip fast/text/hyphenate-locale.html since the EFL port does
not support hyphenation. Also remove wrong expected results
for WK1 EFL.

  • platform/efl-wk1/fast/text/hyphenate-locale-expected.png: Removed.
  • platform/efl-wk1/fast/text/hyphenate-locale-expected.txt: Removed.
  • platform/efl/TestExpectations:
2:28 AM Changeset in webkit [137065] by Christophe Dumez
  • 10 edits in trunk/LayoutTests

Unreviewing gardening.

Rebaseline several compositing test cases after r137051.

  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
1:59 AM Changeset in webkit [137064] by commit-queue@webkit.org
  • 15 edits in trunk

Unreviewed, rolling out r137053.
​http://trac.webkit.org/changeset/137053
​https://bugs.webkit.org/show_bug.cgi?id=104471

Broke PerformanceTests/Parser/html-parser.html (Requested by
mkwst_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-09

Source/WebCore:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:
1:54 AM Changeset in webkit [137063] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after WebGL
was enabled for EFL port in r137050.

  • platform/efl/fast/js/global-constructors-expected.txt:
1:42 AM Changeset in webkit [137062] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Adding failure expectation for several MicroData test cases
that started failing after r137003.

  • platform/efl/TestExpectations:
1:24 AM Changeset in webkit [137061] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 133717 - Crash due to column span under button element
​https://bugs.webkit.org/show_bug.cgi?id=101402

Reviewed by Abhishek Arya.

Source/WebCore:

When there is a column-spanning child of a RenderButton
splitBlocks() must split the RenderButton as well as its
only permitted direct child, the anonymous block referenced
by m_inner. A crash was occurring because splitBlocks()
calls addChildIgnoringAnonymousColumnBlocks() to add the
cloned m_inner to the cloned RenderButton, which meant the
m_inner for the cloned RenderButton was not being set even
though a child was being added. This violates state
assumptions in the RenderButton code.

This patch prevents any descendants of RenderButton from
spanning columns. Also, it adds a precautionary check in
RenderButton::removeChild() to mitigate problems if similar
state problems are found in future.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::removeChild):

LayoutTests:

Test creates crashing condition for bug 101402.

  • fast/block/colspan-under-button-crash.html: Added.
  • fast/block/colspan-under-button-crash-expected.txt: Added.
1:18 AM Changeset in webkit [137060] by kov@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 132983 - Delaying 'change' and 'input' event dispatching during HTMLInputElement::setValue
​https://bugs.webkit.org/show_bug.cgi?id=100772

Reviewed by Abhishek Arya.

Source/WebCore:

'change' and 'input' events are asynchronous and not
cancelable. We can use ScopedEvent.

Test: fast/forms/range/range-type-change-onchange.html

  • dom/Node.cpp:

(WebCore::Node::dispatchChangeEvent): Use dispatchScopedEvent.
(WebCore::Node::dispatchInputEvent): Ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
Make a scope to delay event dispatching.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent): Ditto.

LayoutTests:

  • fast/forms/range/range-type-change-onchange-expected.txt: Added.
  • fast/forms/range/range-type-change-onchange.html: Added.
1:04 AM Changeset in webkit [137059] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a failure expectation for an accelerated compositing layout test introduced in r136959.
Adding failure expectations for MicroData layout tests that regressed in r137003.

  • platform/gtk/TestExpectations:
12:13 AM Changeset in webkit [137058] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Fix unused parameter compile warnings
​https://bugs.webkit.org/show_bug.cgi?id=104463

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-12-09
Reviewed by Kentaro Hara.

Remove compile warning messages by omitting parameter name.

Source/WebCore:

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::GraphicsSurface):

Source/WebKit2:

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createCanvas):

Note: See TracTimeline for information about the timeline view.