Timeline
Dec 14, 2012:
- 10:15 PM Changeset in webkit [137794] by
-
- 4 edits in trunk/Source/WebKit
The WebView should initialize the platform strategies before initializing other sub-systems.
https://bugs.webkit.org/show_bug.cgi?id=105083.
Reviewed by Alexey Proskuryakov.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/win:
- WebView.cpp:
(WebView::initWithFrame):
- 6:28 PM Changeset in webkit [137793] by
-
- 7 edits in trunk/Source
Send a message from WebViewImpl to the compositor to inform about end of flings
https://bugs.webkit.org/show_bug.cgi?id=104947
Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-12-14
Reviewed by James Robinson.
Whenever we have a fling animation finished on cancelled on main thread this sends
a message that will be relayed to the compositor input handler. Then the input handler
keeps track of main thread fling with a boolean and doesn't send flingCancels
unnecessarily
- chromium/public/WebInputHandler.h:
(WebInputHandler):
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::mainThreadHasStoppedFlinging):
- 5:21 PM Changeset in webkit [137792] by
-
- 6 edits in trunk/Source
WebViewImpl::resetScrollAndScaleState() causes the page to render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=104767
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-12-14
Reviewed by Darin Fisher.
Change WebViewImpl::resetScrollAndScaleState() so that it directly
alters values in the HistoryItem instead of indirectly changing the
values.
Adds a method in HistoryController to clear the scroll and scale state of
its current HistoryItem.
- public/WebView.h:
(WebView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resetScrollAndScaleState):
- tests/WebViewTest.cpp:
- 4:52 PM Changeset in webkit [137791] by
-
- 3 edits2 deletes in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=105064
fast/css/nested-layers-with-hover.html fails on the Mac WK2 bots, and seems to be
a bad test
Reviewed by Tim Horton.
There were a number of problems with this test, and this patch attempts to fix
them all. The problems were:
-This test was failing on the WK2 bots.
-But it was comparing against expected results that expected to fail, so that's
bad!
-In the cross-platform directory there were expected results checked in that look
for a render tree dump, but those results haven't made sense for a while since
that test was converted to dumpAsText() months ago.
This patch updates the test so that it will actually work. To do that, we need to
make sure layout is up to date and also use window.setTimeout() to run the
function to assess our hover state rather than relying on onmousemove.
- fast/css/nested-layers-with-hover-expected.txt:
- fast/css/nested-layers-with-hover.html:
- platform/mac/fast/css/nested-layers-with-hover-expected.png: Removed.
- platform/mac/fast/css/nested-layers-with-hover-expected.txt: Removed.
- 4:48 PM Changeset in webkit [137790] by
-
- 4 edits in trunk/Source/WebKit2
DownloadProxy objects should be message receivers
https://bugs.webkit.org/show_bug.cgi?id=105068
Reviewed by Andreas Kling.
This simplifies the WebContext message dispatch code somewhat.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveMessage):
(WebKit::DownloadProxy::didReceiveSyncMessage):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createDownloadProxy):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- 4:28 PM Changeset in webkit [137789] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r137765.
http://trac.webkit.org/changeset/137765
https://bugs.webkit.org/show_bug.cgi?id=105067
Breaks webkit_unit_tests and transferred flings (Requested by
jamesr_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-14
Source/Platform:
- chromium/public/WebInputHandler.h:
(WebInputHandler):
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::handleKeyEvent):
(WebKit::WebViewImpl::updateAnimations):
(WebKit::WebViewImpl::didCommitLoad):
- 3:57 PM Changeset in webkit [137788] by
-
- 4 edits in branches/safari-536.28-branch/Source
Versioning.
- 3:55 PM Changeset in webkit [137787] by
-
- 1 copy in tags/Safari-536.28.8
New Tag.
- 3:52 PM Changeset in webkit [137786] by
-
- 5 edits4 adds in trunk
Emphasis mark is printed after inline-block with justify
https://bugs.webkit.org/show_bug.cgi?id=104631
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2012-12-14
Reviewed by Dean Jackson.
Source/WebCore:
Do not print an emphasis mark after an inline-block when justified.
If an inline-block is expanded, it has a space appended to it.
This space should not have any emphasis marks drawn.
Test: fast/inline/justify-emphasis-inline-box.html
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::zeroWidthSpaceGlyph): Add getter method to get zero width space glyph.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal): We use zero width space for the extra space not to draw emphasis marks.
LayoutTests:
Test that emphasis marks are not drawn incorrectly in justified text with inline boxes.
- fast/inline/justify-emphasis-inline-box.html: Added.
- platform/chromium-mac/fast/inline/justify-emphasis-inline-box-expected.png: Added.
- platform/chromium-mac/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
- platform/mac/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
- 3:47 PM Changeset in webkit [137785] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed bug fix after r137782.
Add new source file TextTrackRepresentation.cpp to CMakeLists.txt.
- CMakeLists.txt:
- 3:40 PM Changeset in webkit [137784] by
-
- 33 edits4 deletes in trunk/Source
Unreviewed, rolling out r137767.
http://trac.webkit.org/changeset/137767
https://bugs.webkit.org/show_bug.cgi?id=105062
Broke Mac builds. (Requested by mlam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-14
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabaseServer.h: Removed.
- Modules/webdatabase/DBBackendServer.h: Removed.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
- Modules/webdatabase/DatabaseManager.h:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/DatabaseStrategy.cpp: Removed.
- platform/DatabaseStrategy.h: Removed.
- platform/PlatformStrategies.h:
(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):
Source/WebKit/efl:
- WebCoreSupport/PlatformStrategiesEfl.cpp:
- WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):
Source/WebKit/gtk:
- WebCoreSupport/PlatformStrategiesGtk.cpp:
- WebCoreSupport/PlatformStrategiesGtk.h:
(PlatformStrategiesGtk):
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- WebCoreSupport/WebPlatformStrategies.mm:
Source/WebKit/qt:
- WebCoreSupport/PlatformStrategiesQt.cpp:
- WebCoreSupport/PlatformStrategiesQt.h:
(PlatformStrategiesQt):
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
Source/WebKit/wince:
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
- WebCoreSupport/PlatformStrategiesWinCE.h:
(PlatformStrategiesWinCE):
Source/WebKit2:
- CMakeLists.txt:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- 3:33 PM Changeset in webkit [137783] by
-
- 5 edits in trunk/Source/WebKit2
<rdar://problem/12874760> NetworkProcess loads may get stuck when WebProcess quits
https://bugs.webkit.org/show_bug.cgi?id=105056
Reviewed by Anders Carlsson.
Make response maps per-connection.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose): Cancel waiting for responses from WebProcess, they will never arrive.
- NetworkProcess/NetworkConnectionToWebProcess.h: (WebKit::NetworkConnectionToWebProcess::willSendRequestResponseMap): (WebKit::NetworkConnectionToWebProcess::canAuthenticateAgainstProtectionSpaceResponseMap): Maps now live here.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::connectionToWebProcessDidClose): Added a FIXME.
(WebKit::NetworkResourceLoader::willSendRequest):
(WebKit::NetworkResourceLoader::willSendRequestHandled):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceHandled):
Handle the cases where we can't send a request, or can't expect a response any more.
- Shared/BlockingResponseMap.h: (BlockingResponseMap): (BlockingResponseMap::BlockingResponseMap): (BlockingResponseMap::~BlockingResponseMap): (BlockingResponseMap::waitForResponse): (BlockingResponseMap::didReceiveResponse): (BlockingResponseMap::cancel): (BlockingBoolResponseMap): (BlockingBoolResponseMap::BlockingBoolResponseMap): (BlockingBoolResponseMap::~BlockingBoolResponseMap): (BlockingBoolResponseMap::waitForResponse): (BlockingBoolResponseMap::didReceiveResponse): (BlockingBoolResponseMap::cancel): Added an ability to cancel, and slightly beefed up overall.
- 3:23 PM Changeset in webkit [137782] by
-
- 13 edits2 adds in trunk/Source/WebCore
Allow the text track contents to be displayed externally to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=105052
Reviewed by Eric Carlson.
Support scenarios where the text track contents must be rendered outside of WebCore, such as to an external
display or window. Add an abstract base class which encapsulates the external representation to which the
text tracks will be rendered.
Add a new abstract base class and client to wrap the external rendering of a TextTrack.
- platform/graphics/TextTrackRepresentation.h: Added.
(WebCore::TextTrackRepresentationClient::~TextTrackRepresentationClient):
(WebCore::TextTrackRepresentation::~TextTrackRepresentation):
Add an empty concrete implementation for those ports who do not yet support external display of subtitles.
- platform/graphics/TextTrackRepresentation.cpp: Added.
(NullTextTrackRepresentation):
(WebCore::NullTextTrackRepresentation::~NullTextTrackRepresentation):
(WebCore::NullTextTrackRepresentation::update):
(WebCore::NullTextTrackRepresentation::platformLayer):
(WebCore::NullTextTrackRepresentation::setContentScale):
(WebCore::NullTextTrackRepresentation::bounds):
(WebCore::TextTrackRepresentation::create):
Add methods to MediaPlayerPrivateIOS to handle the TextTrackRepresentation.
- platform/graphics/ios/MediaPlayerPrivateIOS.h:
- platform/graphics/ios/MediaPlayerPrivateIOS.mm:
(WebCore::MediaPlayerPrivateIOS::deliverNotification): Remove the representation when exiting full screen.
(WebCore::MediaPlayerPrivateIOS::requiresTextTrackRepresentation): Return YES if in full screen mode.
(WebCore::MediaPlayerPrivateIOS::setTextTrackRepresentation): Pass the representation's layer to the player plug-in.
Expose those methods via HTMLMediaElement:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::requiresTextTrackRepresentation):
(WebCore::HTMLMediaElement::setTextTrackRepresentation):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::requiresTextTrackRepresentation):
(WebCore::MediaPlayer::setTextTrackRepresentation):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::textTrackRepresentationBoundsChanged):
(WebCore::MediaPlayerClient::paintTextTrackRepresentation):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::requiresTextTrackRepresentation):
(WebCore::MediaPlayerPrivateInterface::setTextTrackRepresentation):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Create the representation, if necessary.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Use the representation to determine the font size.
(WebCore::MediaControlTextTrackContainerElement::paintTextTrackRepresentation): Added. Paint the TextTrack into the provided graphics context.
(WebCore::MediaControlTextTrackContainerElement::textTrackRepresentationBoundsChanged): Added. Call updateSizes().
- html/shadow/MediaControlElements.h:
Add the new files to the project.
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- 3:18 PM Changeset in webkit [137781] by
-
- 6 edits in trunk/Tools
webkitpy: make port_name a required parameter to the non-test ports
https://bugs.webkit.org/show_bug.cgi?id=105057
Reviewed by Eric Seidel.
This is just minor code cleanup along the path to making Port
constructors simpler and pushing more logic into the port factory.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.make_port):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(TestWebKitPort.init):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort):
(TestPort.determine_full_port_name):
(TestPort.init):
- Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_stop):
- 3:17 PM Changeset in webkit [137780] by
-
- 4 edits in trunk/Tools
garden-o-matic doesn't know about reftests
https://bugs.webkit.org/show_bug.cgi?id=101976
Reviewed by Eric Seidel.
Attempt to make garden-o-matic properly aware of reftests again.
This is re-landing r137407 with a change to
rebaselineWithStatusUpdates() to actually pass the filtered
failureInofLost to checkout.rebaseline().
Unfortunately, the testing coverage for this whole module is almost
non-existent, and it's not obvious that there's a good way to
stub out checkout.rebaseline() to test that the right thing
happens. I verified the change manually.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
- 3:04 PM Changeset in webkit [137779] by
-
- 3 edits in branches/safari-534.58-branch/Source/WebCore
Merge r118820.
2012-05-29 John Sullivan <sullivan@apple.com>
Update label for blacklisted plug-in
https://bugs.webkit.org/show_bug.cgi?id=87767
rdar://problem/11550048
Reviewed by Kevin Decker.
- English.lproj/Localizable.strings:
Regenerated.
- platform/LocalizedStrings.cpp:
(WebCore::insecurePluginVersionText):
Changed this string.
- 3:04 PM Changeset in webkit [137778] by
-
- 2 edits in trunk/LayoutTests
Updating these results again since this failing test has started failing in a new
way. https://bugs.webkit.org/show_bug.cgi?id=58332 represents fixing the bug.
- platform/mac-wk2/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt:
- 2:57 PM Changeset in webkit [137777] by
-
- 2 edits in tags/Safari-537.21.1/Source/WebCore
Merged r137763. <rdar://problem/12879657>
- 2:55 PM Changeset in webkit [137776] by
-
- 7 edits in trunk/Source
Allow embedder to observe changes to frame names
https://bugs.webkit.org/show_bug.cgi?id=104404
Reviewed by Darin Fisher.
Source/WebCore:
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didChangeName):
(FrameLoaderClient):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::setName):
Source/WebKit/chromium:
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didChangeName):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didChangeName):
(WebKit):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- 2:51 PM Changeset in webkit [137775] by
-
- 4 edits in tags/Safari-537.21.1/Source
Versioning.
- 2:48 PM Changeset in webkit [137774] by
-
- 1 copy in tags/Safari-537.21.1
New Tag.
- 2:31 PM Changeset in webkit [137773] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] IndexedDB: Memory leak in IDBCallbacksProxy::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>)
https://bugs.webkit.org/show_bug.cgi?id=104615
Reviewed by Tony Chang.
Don't create (and leak) a new wrapper object for onSuccess if one was created for onUpgradeNeeded.
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::IDBCallbacksProxy):
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- 2:30 PM Changeset in webkit [137772] by
-
- 4 edits2 adds in trunk
[Resource Timing] Properly report reused connections
https://bugs.webkit.org/show_bug.cgi?id=104986
Reviewed by Tony Gentilcore.
Source/WebCore:
Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse.html
- page/PerformanceResourceTiming.cpp:
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
- page/PerformanceResourceTiming.h:
(PerformanceResourceTiming):
LayoutTests:
- http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse-expected.txt: Added.
- http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse.html: Added.
- 2:18 PM Changeset in webkit [137771] by
-
- 4 edits in trunk/Source/WebCore
Enable video caption controls on Windows.
https://bugs.webkit.org/show_bug.cgi?id=105045.
Reviewed by Eric Carlson.
Now that video tracks have been enabled on Windows, enable controls as well.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
- html/shadow/MediaControlElements.h:
- rendering/RenderThemeWin.h:
- 2:13 PM Changeset in webkit [137770] by
-
- 3 edits in trunk/Tools
"Running 1 DumpRenderTree over X shards" is not a helpful output
https://bugs.webkit.org/show_bug.cgi?id=104858
Reviewed by Dirk Pranke.
The word "shard" is not typically used in test frameworks. This word is confusing for many WebKit
contributors who typically don't have much experience on distributed computations and databases.
So only print this message out in the debug mode.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_workers_and_shards):
- 2:11 PM Changeset in webkit [137769] by
-
- 4 edits in trunk/LayoutTests
fast/dom/HTMLTemplateElement/inertContents.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=104023
Reviewed by Eric Seidel.
Made the test only check inertness using <script>, since
<img>s are currently flaky due to the preload scanner.
- fast/dom/HTMLTemplateElement/inertContents-expected.txt:
- fast/dom/HTMLTemplateElement/inertContents.html:
- platform/chromium/TestExpectations:
- 2:07 PM Changeset in webkit [137768] by
-
- 5 edits in trunk/Source/WebKit2
DownloadProxyMap should keep track of outstanding DownloadProxy objects
https://bugs.webkit.org/show_bug.cgi?id=105053
Reviewed by Andreas Kling.
This is more work towards removing the m_downloads map from every WebContext object.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didFinish):
(WebKit::DownloadProxy::didFail):
(WebKit::DownloadProxy::didCancel):
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit):
(WebKit::DownloadProxyMap::downloadFinished):
- UIProcess/Downloads/DownloadProxyMap.h:
(DownloadProxyMap):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createDownloadProxy):
- 1:57 PM Changeset in webkit [137767] by
-
- 33 edits4 adds in trunk/Source
Introducing the DatabaseStrategy and database servers.
https://bugs.webkit.org/show_bug.cgi?id=104934.
Reviewed by Sam Weinig.
The database server is currently a placeholder that does nothing.
Source/WebCore:
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabaseServer.h: Added.
(WebCore):
(AbstractDatabaseServer):
(WebCore::AbstractDatabaseServer::AbstractDatabaseServer):
(WebCore::AbstractDatabaseServer::~AbstractDatabaseServer):
- Modules/webdatabase/DBBackendServer.h: Added.
(DBBackend):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
- Modules/webdatabase/DatabaseManager.h:
(WebCore):
(DatabaseManager):
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/DatabaseStrategy.cpp: Added.
(WebCore):
(WebCore::DatabaseStrategy::getDatabaseServer):
- platform/DatabaseStrategy.h: Added.
(WebCore):
(DatabaseStrategy):
(WebCore::DatabaseStrategy::~DatabaseStrategy):
- platform/PlatformStrategies.h:
(WebCore):
(WebCore::PlatformStrategies::databaseStrategy):
(PlatformStrategies):
(WebCore::PlatformStrategies::PlatformStrategies):
Source/WebKit/efl:
- WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::createDatabaseStrategy):
- WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):
Source/WebKit/gtk:
- WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::createDatabaseStrategy):
- WebCoreSupport/PlatformStrategiesGtk.h:
(PlatformStrategiesGtk):
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createDatabaseStrategy):
Source/WebKit/qt:
- WebCoreSupport/PlatformStrategiesQt.cpp:
(PlatformStrategiesQt::createDatabaseStrategy):
- WebCoreSupport/PlatformStrategiesQt.h:
(PlatformStrategiesQt):
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createDatabaseStrategy):
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
Source/WebKit/wince:
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::createDatabaseStrategy):
- WebCoreSupport/PlatformStrategiesWinCE.h:
(PlatformStrategiesWinCE):
Source/WebKit2:
- CMakeLists.txt:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createDatabaseStrategy):
(WebKit):
(WebKit::WebPlatformStrategies::getDatabaseServer):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- 1:25 PM Changeset in webkit [137766] by
-
- 2 edits in trunk/Source/WebKit2
Resource loads sometimes stall
https://bugs.webkit.org/show_bug.cgi?id=104976
Apply the same quick an dirty fix to BlockingBoolResponseMap.
- Shared/BlockingResponseMap.h: (BlockingBoolResponseMap::didReceiveResponse):
- 1:17 PM Changeset in webkit [137765] by
-
- 7 edits in trunk/Source
Send a message from WebViewImpl to the compositor to inform about end of flings
https://bugs.webkit.org/show_bug.cgi?id=104947
Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-12-14
Reviewed by James Robinson.
Whenever we have a fling animation finished on cancelled on main thread this sends
a message that will be relayed to the compositor input handler. Then the input handler
keeps track of main thread fling with a boolean and doesn't send flingCancels
unnecessarily
Source/Platform:
- chromium/public/WebInputHandler.h:
(WebInputHandler):
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::mainThreadHasStoppedFlinging):
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::mainThreadHasStoppedFlinging):
(WebKit):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::handleKeyEvent):
(WebKit::WebViewImpl::updateAnimations):
(WebKit::WebViewImpl::didCommitLoad):
- 1:07 PM Changeset in webkit [137764] by
-
- 3 edits4 adds in trunk
Source/WebCore: Text Autosizing: Consider inline-block and inline-table elements to be autosizing clusters.
https://bugs.webkit.org/show_bug.cgi?id=104702
Patch by Anton Vayvod <avayvod@chromium.org> on 2012-12-14
Reviewed by Julien Chaffraix.
A common pattern for creating adjacent columns in CSS is to set each of the columns to
display:inline-block, display:inline-table or alike WebKit-specific styles. Whenever columns
are used, Text Autosizing needs to assign each of the columns to different clusters (since
the user can zoom in such that a column fills the width of the screen, so text within a column
should have a smaller multiplier than it's wider enclosing cluster would have needed).
This patch causes display:inline-block, display:inline-table and alike styles to trigger new clusters.
Test: fast/text-autosizing/cluster-inline-block-or-table.html
Test: fast/text-autosizing/cluster-inline-grid-flex-box.html
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::isAutosizingContainer):
(WebCore::TextAutosizer::isAutosizingCluster):
Consider display:inline-block, inline-table and alike elements to be autosizing containers and clusters.
LayoutTests: Consider inline-block and inline-table elements to be autosizing clusters.
https://bugs.webkit.org/show_bug.cgi?id=104702
Patch by Anton Vayvod <avayvod@chromium.org> on 2012-12-14
Reviewed by Julien Chaffraix.
Added tests to verify that display:inline-block, display:inline-table and alike elements become clusters.
- fast/text-autosizing/cluster-inline-block-or-table-expected.html: Added.
- fast/text-autosizing/cluster-inline-block-or-table.html: Added.
- fast/text-autosizing/cluster-inline-grid-flex-box-expected.html: Added.
- fast/text-autosizing/cluster-inline-grid-flex-box.html: Added.
- 12:49 PM Changeset in webkit [137763] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r137607): Cannot download files, stuck in "Preparing to download"
https://bugs.webkit.org/show_bug.cgi?id=105044
<rdar://problem/12879657>
Reviewed by Alexey Proskuryakov.
Make ResourceHandle::cancel return early if the handle has been converted to a download.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::cancel):
- 12:27 PM Changeset in webkit [137762] by
-
- 2 edits in trunk/LayoutTests
Marking these tests as failure for now.
https://bugs.webkit.org/show_bug.cgi?id=105049 tracks fixing the issue.
- platform/mac/TestExpectations:
- 12:16 PM Changeset in webkit [137761] by
-
- 20 edits2 deletes in trunk
Unreviewed, rolling out r137570.
http://trac.webkit.org/changeset/137570
https://bugs.webkit.org/show_bug.cgi?id=105048
Stale nodes in the touchEventTarget HashCountedSet are
triggering crashes. Rolling out while I find the root cause.
(Requested by leviw on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-14
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler):
(WebCore::Document::didRemoveTouchEventHandler):
- dom/Document.h:
(WebCore::Document::touchEventHandlerCount):
(Document):
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::updateType):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
- page/Frame.cpp:
(WebCore::Frame::setDocument):
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/ScrollingCoordinator.h:
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):
- page/scrolling/chromium/ScrollingCoordinatorChromium.h:
(ScrollingCoordinatorChromium):
- testing/Internals.cpp:
(WebCore::Internals::touchEventHandlerCount):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/chromium:
- features.gypi:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::requestTouchEventType):
(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
LayoutTests:
- platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Removed.
- platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Removed.
- 11:34 AM Changeset in webkit [137760] by
-
- 1 edit in branches/chromium/1312/Source/WebKit/chromium/features.gypi
Revert 136739
BUG=164454
Review URL: https://codereview.chromium.org/11572049
- 11:32 AM Changeset in webkit [137759] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 137632
BUG=163593
Review URL: https://codereview.chromium.org/11583006
- 11:26 AM Changeset in webkit [137758] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding crash expectations for two regressions after r137487 and r137607.
- platform/gtk/TestExpectations:
- 11:24 AM Changeset in webkit [137757] by
-
- 2 edits5 adds in trunk/LayoutTests
Unreviewed rebaselines on Win7 port after r137336.
- media/video-controls-captions-trackmenu.html:
- platform/win/fast/css-generated-content: Added.
- platform/win/fast/css-generated-content/table-row-group-to-inline-expected.txt: Added.
- platform/win/fast/css/empty-generated-content-expected.txt: Added.
- platform/win/http/tests/misc: Added.
- platform/win/http/tests/misc/acid3-expected.txt: Added.
- 10:47 AM Changeset in webkit [137756] by
-
- 7 edits2 adds in trunk/Source/WebKit2
Add a DownloadsProxyMap class in preparation for moving the downloads map away from WebContext
https://bugs.webkit.org/show_bug.cgi?id=104980
Reviewed by Andreas Kling.
Currently the DownloadProxyMap doesn't really do anything; this initial change is to make sure that
adding the new files won't break any builds.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- UIProcess/Downloads/DownloadProxyMap.cpp: Added.
(WebKit):
(WebKit::DownloadProxyMap::shared):
(WebKit::DownloadProxyMap::DownloadProxyMap):
(WebKit::DownloadProxyMap::~DownloadProxyMap):
(WebKit::DownloadProxyMap::createDownloadProxy):
- UIProcess/Downloads/DownloadProxyMap.h: Added.
(WebKit):
(DownloadProxyMap):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createDownloadProxy):
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 10:42 AM Changeset in webkit [137755] by
-
- 2 edits in trunk/Source/WebKit2
Fix assertion failure when the network process is enabled
https://bugs.webkit.org/show_bug.cgi?id=105040
<rdar://problem/12883632>
Reviewed by Alexey Proskuryakov.
Make sure that we don't call into the download manager when running with a network process.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldTerminate):
- 10:35 AM Changeset in webkit [137754] by
-
- 33 edits in trunk
[CSS Shaders] Remove code for the other mesh box types (border-box | padding-box | content-box)
https://bugs.webkit.org/show_bug.cgi?id=103776
Reviewed by Dean Jackson.
Source/WebCore:
The MeshBoxType has been removed and the code has been refactored. The specs will be updated shortly
and therefore this feature - even though it was not fully implemented yet - shall not be used anymore.
In this patch we remove everything but the parsing code, which shall be addressed in a different patch
(see: https://bugs.webkit.org/show_bug.cgi?id=103778).
Specification to be updated: http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#ltboxgt
Existing tests have been updated and new parsing legacy cases have been added.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilter):
- css/CSSPrimitiveValueMappings.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperation):
- platform/graphics/filters/CustomFilterConstants.h:
- platform/graphics/filters/CustomFilterOperation.cpp:
(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::blend):
- platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::create):
(CustomFilterOperation):
(WebCore::CustomFilterOperation::operator==):
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
- platform/graphics/filters/CustomFilterRenderer.h:
(CustomFilterRenderer):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
- platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
- platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
(WebCore::ValidatedCustomFilterOperation::ValidatedCustomFilterOperation):
- platform/graphics/filters/ValidatedCustomFilterOperation.h:
(WebCore::ValidatedCustomFilterOperation::create):
(WebCore::ValidatedCustomFilterOperation::operator==):
(ValidatedCustomFilterOperation):
- rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeFilterOperations):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawUsingCustomFilter):
Source/WebKit2:
The MeshBoxType has been removed and the code has been refactored. The specs will be updated shortly
and therefore this feature - even though it was not fully implemented yet - shall not be used anymore.
In this patch we remove everything but the parsing code, which shall be addressed in a different patch
(see: https://bugs.webkit.org/show_bug.cgi?id=103778).
Specification to be updated: http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#ltboxgt
Existing tests have been updated and new parsing legacy cases have been added.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/CoordinatedGraphics/WebCustomFilterOperation.h:
(WebCore::WebCustomFilterOperation::create):
(WebCore::WebCustomFilterOperation::WebCustomFilterOperation):
LayoutTests:
MeshBoxBoxType has been removed from the spec and from the code.
Parsing code has been retained for legacy reason and will be updated in a different patch
(see: https://bugs.webkit.org/show_bug.cgi?id=103778).
Current tests have been updated and new legacy test cases have been added to custom-filter-property-parsing.
- css3/filters/custom/custom-filter-animation-expected.txt:
- css3/filters/custom/custom-filter-animation.html:
- css3/filters/custom/custom-filter-array-blending-expected.txt:
- css3/filters/custom/custom-filter-array-blending.html:
- css3/filters/custom/custom-filter-property-computed-style-expected.txt:
- css3/filters/custom/custom-filter-property-parsing-expected.txt:
- css3/filters/custom/custom-filter-transforms-animation-expected.txt:
- css3/filters/custom/custom-filter-transforms-animation.html:
- css3/filters/script-tests/custom-filter-property-computed-style.js:
- css3/filters/script-tests/custom-filter-property-parsing.js:
- 9:53 AM Changeset in webkit [137753] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Allow plugins to be disabled by shared library filename
https://bugs.webkit.org/show_bug.cgi?id=101274
Patch by Parth Patel <parpatel@rim.com> on 2012-12-14
Reviewed by Yong Li.
Fixing build error.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
- 9:53 AM Changeset in webkit [137752] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/12880750> RGRESSION: Crash when emptying cookie jar
https://bugs.webkit.org/show_bug.cgi?id=105038
Reviewed by Jessie Berlin.
Handle null context, which is used for cookie management functions.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::cookiesForDOM): (WebKit::WebPlatformStrategies::setCookiesFromDOM): (WebKit::WebPlatformStrategies::cookiesEnabled): (WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue): (WebKit::WebPlatformStrategies::getRawCookies): (WebKit::WebPlatformStrategies::deleteCookie): (WebKit::WebPlatformStrategies::getHostnamesWithCookies): (WebKit::WebPlatformStrategies::deleteCookiesForHostname): (WebKit::WebPlatformStrategies::deleteAllCookies):
- 9:21 AM Changeset in webkit [137751] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: optional parameters of protocol commands should go after required ones
https://bugs.webkit.org/show_bug.cgi?id=105019
Reviewed by Pavel Feldman.
- inspector/Inspector.json: Moved required x and y parameters declaration before
optional ones.
- inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::dispatchMouseEvent):
- inspector/InspectorInputAgent.h:
(InspectorInputAgent):
- 9:19 AM Changeset in webkit [137750] by
-
- 3 edits in trunk/Source/WebCore
Mac build fix after r137724.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerKeyAdded):
Comment out the names of the unused parameters so they don't trigger unused parameter
warnings.
(WebCore::MediaPlayerClient::mediaPlayerKeyError):
Ditto.
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage):
Ditto.
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::generateKeyRequest):
Pass an empty URL for the new defaultURL parameter in the keyMessage call.
- 9:00 AM Changeset in webkit [137749] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 8:57 AM Changeset in webkit [137748] by
-
- 10 edits in trunk/Source
[GTK] When in private mode WebKitGTK+ should not save HTTP authentication credentials to the persistent storage
https://bugs.webkit.org/show_bug.cgi?id=104910
Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-14
Reviewed by Martin Robinson.
Source/WebCore:
Add new parameter to GtkAuthenticationDialog to select whether we
allow persistent storage of credential information or not. In the
latter case, the "Remember password" check button is not shown and
the credentials are always stored in the session.
- platform/gtk/GtkAuthenticationDialog.cpp:
(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
(WebCore::GtkAuthenticationDialog::createContentsInContainer):
(WebCore::GtkAuthenticationDialog::buttonClickedCallback):
- platform/gtk/GtkAuthenticationDialog.h:
(GtkAuthenticationDialog):
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
When creating the GtkAuthenticationDialog, set the credential
storage mode using the private browsing setting from the current
page.
- webkit/webkitsoupauthdialog.cpp:
(sessionAuthenticate):
Create the GtkAuthenticationDialog with no persistent storage
allowed, as we are not handling the credential persistence here.
Source/WebKit2:
- UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp:
(WebKit::WebKit2GtkAuthenticationDialog::WebKit2GtkAuthenticationDialog):
- UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h:
(WebKit2GtkAuthenticationDialog):
GtkAuthenticationDialog has a new credential storage mode
parameter, so add it here too.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewHandleAuthenticationChallenge):
When creating the GtkAuthenticationDialog, set the credential
storage mode using the private browsing setting from the current
page.
- 8:18 AM Changeset in webkit [137747] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 8:12 AM Changeset in webkit [137746] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Fix EFL build after r137718
https://bugs.webkit.org/show_bug.cgi?id=105018
Unreviewed build fix.
The problem was that UNUSED_PARAM(size) was left in the code
for non-existent variable 'size'.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-12-14
- UIProcess/efl/PageClientDefaultImpl.cpp:
(WebKit::PageClientDefaultImpl::updateViewportSize):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
- 7:45 AM Changeset in webkit [137745] by
-
- 2 edits in trunk/LayoutTests
[Chromium gardening] Set expectations for platform/chromium/virtual/gpu/compositedscrolling/scrollbars/scrollbar-drag-thumb-with-large-content-expected.html
Unreviewed gardening change.
Need to mirror the expectations for the virtual tests against those for the
original.
- platform/chromium/TestExpectations:
- 7:35 AM Changeset in webkit [137744] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r129633 and r129757.
http://trac.webkit.org/changeset/129633
http://trac.webkit.org/changeset/129757
https://bugs.webkit.org/show_bug.cgi?id=97659
Causes performance regression whn inspector overlay is
displayed
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
- 7:33 AM Changeset in webkit [137743] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry][Fullscreen] Exiting fullscreen does not set the correct scroll position
https://bugs.webkit.org/show_bug.cgi?id=104958
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Antonio Gomes.
Internally reviewed by Arvid Nilsson and Max Feil.
PR: 231174
When leaving fullscreen, WebPage scale and scroll position can't return
to the original scale and scroll position.
We can't restore them in WebPagePrivate::exitFullScreenForElement()
as they can still be changed thereafter during the async
setViewportSize(). And also the async setViewportSize() from the app
side isn't guaranteed as some apps don't need to resize the viewport if
their windows are already fullscreen.
The restoration is basically only needed if viewport size is changed.
At the point of entering fullscreen, we can safely assume that there
would be a viewport size change thereafter if the current visible size
and screen size are not equal. Based on this assumption, we can save
the scale and position before entering fullscreen and restore them in
setViewportSize() thereafter.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- Api/WebPage_p.h:
(WebPagePrivate):
- 6:34 AM BuildingQtOnWindows edited by
- Remove the unsupported MSVC project file generation instructions. (diff)
- 6:10 AM Changeset in webkit [137742] by
-
- 6 edits in trunk/Source
Web Inspector: add data grid for exploring native heap graph
https://bugs.webkit.org/show_bug.cgi?id=105012
Reviewed by Pavel Feldman.
Source/WebCore:
Added a view for displaying native heap graph nodes.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::reportEdge):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemorySnapshotView.prototype._onSelectedViewChanged):
(WebInspector.NativeMemorySnapshotView.prototype.get statusBarItems):
(WebInspector.NativeHeapGraphNode):
(WebInspector.NativeHeapGraphNode.prototype.id):
(WebInspector.NativeHeapGraphNode.prototype.type):
(WebInspector.NativeHeapGraphNode.prototype.size):
(WebInspector.NativeHeapGraphNode.prototype.className):
(WebInspector.NativeHeapGraphNode.prototype.name):
(WebInspector.NativeHeapGraphNode.prototype.hasReferencedNodes):
(WebInspector.NativeHeapGraphNode.prototype.referencedNodes):
(WebInspector.NativeHeapGraphNode.prototype._firstEdgePoistion):
(WebInspector.NativeHeapGraphNode.prototype._afterLastEdgePosition):
(WebInspector.NativeHeapGraphNode.prototype._getStringField):
(WebInspector.NativeHeapGraph):
(WebInspector.NativeHeapGraph.prototype.rootNodes):
(WebInspector.NativeHeapGraph.prototype._calculateNodeEdgeIndexes):
(WebInspector.NativeHeapGraphDataGrid):
(WebInspector.NativeHeapGraphDataGridRoot):
(WebInspector.NativeHeapGraphDataGridRoot.prototype._populate):
(WebInspector.NativeHeapGraphDataGridNode):
(WebInspector.NativeHeapGraphDataGridNode.prototype._populate):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
Source/WTF:
Do not report edges with null target.
- wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addObjectImpl):
- 5:54 AM Changeset in webkit [137741] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: do not validate InlineFlowBox objects against tcmalloc data.
https://bugs.webkit.org/show_bug.cgi?id=105001
Reviewed by Yury Semikhatsky.
This is a follow-up change for r137589.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::reportMemoryUsage):
(WebCore):
- rendering/InlineFlowBox.h:
(InlineFlowBox):
- 5:49 AM Changeset in webkit [137740] by
-
- 7 edits in trunk/LayoutTests
[Chromium] Unreviewed rebaseline after Skia roll @6773.
- platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDotted04-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png:
- 4:04 AM Changeset in webkit [137739] by
-
- 3 edits in trunk/Source/WebCore
ChildNodesLazySnapshot::nextNode() can crash in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=104982
Reviewed by Ryosuke Niwa.
The original fix in r137702 was not enough. r137702 fixed a crash
in Release builds but didn't fix a crash in Debug builds.
We have to also change a return type of ChildNodesLazySnapshot::nextNode()
from a raw pointer to a RefPtr.
Test: fast/dom/insertedIntoDocument-no-crash.html
(Confirm that this test does not crash in Debug builds.)
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
- 3:58 AM Changeset in webkit [137738] by
-
- 4 edits4 adds in trunk
Text Autosizing: Don't autosize unwrappable blocks
https://bugs.webkit.org/show_bug.cgi?id=104925
Patch by John Mellor <johnme@chromium.org> on 2012-12-14
Reviewed by Julien Chaffraix.
Source/WebCore:
If we autosize an unwrappable block (white-space:nowrap/pre), it'll
expand sideways. This doesn't actually improve its legibility, and it
can often severely break web page layouts. This patch prevents us from
autosizing unwrappable blocks. A follow-up patch will address the more
complex issue of unwrappable inline elements.
Tests: fast/text-autosizing/unwrappable-blocks.html
fast/text-autosizing/unwrappable-inlines.html
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processContainer):
Use containerShouldbeAutosized instead of contentHeightIsConstrained.
(WebCore::contentHeightIsConstrained):
Unchanged, just moved lower down the file.
(WebCore::TextAutosizer::containerShouldbeAutosized):
Checks that the block is wrappable, and also that contentHeightIsConstrained is false.
(WebCore::TextAutosizer::measureDescendantTextWidth):
Use containerShouldbeAutosized instead of contentHeightIsConstrained.
- rendering/TextAutosizer.h:
Declared containerShouldbeAutosized.
LayoutTests:
Added tests verifying that this prevents unwrappable blocks from being
autosized, and that this has no effect on unwrappable inlines.
- fast/text-autosizing/unwrappable-blocks-expected.html: Added.
- fast/text-autosizing/unwrappable-blocks.html: Added.
- fast/text-autosizing/unwrappable-inlines-expected.html: Added.
- fast/text-autosizing/unwrappable-inlines.html: Added.
- 3:16 AM Changeset in webkit [137737] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Duplicate scripts appear in workspace when script was referenced by url with a fragment part.
https://bugs.webkit.org/show_bug.cgi?id=105004
Reviewed by Alexander Pavlov.
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
- 2:56 AM Changeset in webkit [137736] by
-
- 3 edits in trunk/LayoutTests
Remove an exception message from insertedIntoDocument-no-crash-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=104982
Reviewed by Ryosuke Niwa.
To make the test result identical in all platforms, this patch
removes an exception message from insertedIntoDocument-no-crash-expected.txt.
- fast/dom/insertedIntoDocument-no-crash-expected.txt:
- fast/dom/insertedIntoDocument-no-crash.html:
- 2:54 AM Changeset in webkit [137735] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed. Rebaselined images.
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- 2:51 AM Changeset in webkit [137734] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marked fast/css/variables/case-insensitive.html as [ Pass Crash ]
- platform/chromium/TestExpectations:
- 1:32 AM Changeset in webkit [137733] by
-
- 8 edits in trunk
Hours field of date/time input UI should respect step attribute
https://bugs.webkit.org/show_bug.cgi?id=104993
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-14
Reviewed by Kent Tamura.
Source/WebCore:
This patch makes step-up/-down UI of the hours field respect step attribute when possible.
Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField): Pass step parameters to the hour field constructor.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement): Add Parameters argument.
(WebCore::DateTimeHourFieldElement::create): Ditto.
- html/shadow/DateTimeFieldElements.h:
(DateTimeHourFieldElement): Ditto.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
Added test cases for hour field.
- 1:30 AM Changeset in webkit [137732] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Windows compilation fix after r137728.
- inspector/InspectorAllInOne.cpp:
- 1:23 AM Changeset in webkit [137731] by
-
- 6 edits2 adds in trunk
[Shadow DOM] ShadowRoot.getElementById() should work outside document.
https://bugs.webkit.org/show_bug.cgi?id=87815
Reviewed by Hajime Morita.
Source/WebCore:
ShadowRoot.getElementById() didn't work if ShadowRoot is outside document. We need to update id when an element
is in ShadowTree event if it is not in document.
For performance reason, we introduce IsInShadowTree flag, which enables us to check isInTreeScope() fast.
This is maintained in Element::insertedInto and removedFrom. Here, we're anxious about performance regression,
however our benchmark result shows this doesn't regress the performance.
I've measured Dromaeo/dom-modify.html and Parser/html5-full-render.html 2 times.
Dromaeo/dom-modify.html
35.21, 35.27 [runs/s] ---> 35.76, 35.56 [runs/s]
Parser/html5-full-render.html
4328.51, 4254.94 [ms] ---> 4277.14, 4222.43 [ms]
Test: fast/dom/shadow/getelementbyid-in-orphan.html
- dom/Element.cpp:
(WebCore::Element::insertedInto):
- dom/Element.h:
(WebCore::Element::updateId):
- dom/Node.cpp:
(WebCore::Node::insertedInto): If the parent node is in shadow tree, this node should be also in the same shadow tree.
Since this node is inserted, parentOrHostNode() will not be null.
(WebCore::Node::removedFrom): When node is removed from ShadowTree, its treeScope() should not be ShadowRoot.
- dom/Node.h:
(Node):
(WebCore::Node::isInShadowTree):
(WebCore::Node::isInTreeScope):
LayoutTests:
- fast/dom/shadow/getelementbyid-in-orphan-expected.txt: Added.
- fast/dom/shadow/getelementbyid-in-orphan.html: Added.
- 1:08 AM Changeset in webkit [137730] by
-
- 2 edits in trunk/Source/WebCore
LayerTreeAgent should only be enabled upon restore if it was previously in the enabled state
https://bugs.webkit.org/show_bug.cgi?id=104887
Patch by Antoine Quint <Antoine Quint> on 2012-12-14
Reviewed by Pavel Feldman.
Check that we were previously in the enabled state before re-enabling the agent upon restore,
as suggested by Pavel Feldman in follow-up discussion to https://bugs.webkit.org/show_bug.cgi?id=103513.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::restore):
- 12:54 AM Changeset in webkit [137729] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CPU Profile: Search in "heavy" mode is very slow.
https://bugs.webkit.org/show_bug.cgi?id=103682
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-14
Reviewed by Pavel Feldman.
In "heavy" mode the searchable tree is much larger than original tree.
That is why search can cause watchdog timer fired.
Simple optimization makes search much faster.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.searchCanceled):
Fix cleanup.
(WebInspector.CPUProfileView.prototype.matchesQuery):
Precompute regexp.
(WebInspector.CPUProfileView.prototype.performSearch):
Use precomputed regexp instead of generating one on each iteration.
- 12:44 AM Changeset in webkit [137728] by
-
- 12 edits1 copy1 add in trunk/Source/WebCore
Web Inspector: collect native heap graph and report it to the front-end
https://bugs.webkit.org/show_bug.cgi?id=104888
Reviewed by Pavel Feldman.
Added an option to serialize native heap graph in a format similar to that
of JS heap profiler and send it in reply to getProcessMemoryDistribution
command. This is a first attempt and we likely change the report mechanism to
use a stream instread of sending whole graph at once.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/HeapGraphSerializer.cpp: Added.
(WebCore):
(HeapGraphNode):
(WebCore::HeapGraphNode::HeapGraphNode):
(HeapGraphEdge):
(WebCore::HeapGraphEdge::HeapGraphEdge):
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::~HeapGraphSerializer):
(WebCore::HeapGraphSerializer::serialize):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportEdge):
(WebCore::HeapGraphSerializer::reportLeaf):
(WebCore::HeapGraphSerializer::reportBaseAddress):
(WebCore::HeapGraphSerializer::adjutEdgeTargets):
(WebCore::HeapGraphSerializer::addString):
- inspector/HeapGraphSerializer.h: Copied from Source/WebCore/inspector/InspectorMemoryAgent.h.
(WebCore):
(HeapGraphSerializer):
- inspector/Inspector.json:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportNode):
(WebCore):
(WebCore::MemoryInstrumentationClientImpl::reportEdge):
(WebCore::MemoryInstrumentationClientImpl::reportLeaf):
(WebCore::MemoryInstrumentationClientImpl::reportBaseAddress):
- inspector/MemoryInstrumentationImpl.h:
(WebCore):
(WebCore::MemoryInstrumentationClientImpl::MemoryInstrumentationClientImpl):
(MemoryInstrumentationClientImpl):
- 12:33 AM Changeset in webkit [137727] by
-
- 2 edits in trunk/LayoutTests
http/tests/inspector/resource-main-cookies.php is broken on Mac after r137585
https://bugs.webkit.org/show_bug.cgi?id=104977
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-14
Reviewed by Vsevolod Vlasov.
Adopted Webkit Bug 104893 changes.
- http/tests/inspector/resource-main-cookies.php: Adopted changes.
- 12:32 AM Changeset in webkit [137726] by
-
- 11 edits2 adds in trunk/Source/WebCore
Handling autoscroll in EventHandler should be re-factor
https://bugs.webkit.org/show_bug.cgi?id=104764
Reviewed by Hajime Morita.
This patch introduces new class AutoscrollController for moving autoscroll
and panscroll from EventHandler class for ease of maintenance of
EventHandler and ease of adding autoscroll related features, e.g. autoscroll
during drag-and-drop, autoscoll by gesture.
No new tests. This patch doesn't change behavior.
- CMakeLists.txt: Changed to add page/AutoscrollController.cpp
- GNUmakefile.list.am: Changed to add page/AutoscrollController.{cpp,h}
- Target.pri: Changed to add page/AutoscrollController.cpp
- WebCore.gypi: Changed to add page/AutoscrollController.{cpp,h}
- WebCore.vcproj/WebCore.vcproj: Changed to add page/AutoscrollController.{cpp,h}
- WebCore.xcodeproj/project.pbxproj: Changed to add page/AutoscrollController.{cpp,h}
- page/AutoscrollController.cpp: Added.
(WebCore::getMainFrame): Helper function.
(WebCore::AutoscrollController::AutoscrollController): Moved from EventHandler.
(WebCore::AutoscrollController::autoscrollRenderer): Moved from EventHandler.
(WebCore::AutoscrollController::autoscrollInProgress): Moved from EventHandler.
(WebCore::AutoscrollController::startAutoscrollForSelection): Replacement of EventHandler::handleAutoscroll().
(WebCore::AutoscrollController::stopAutoscrollTimer): Moveed from EventHandler.
(WebCore::AutoscrollController::updateAutoscrollRenderer): ditto
(WebCore::AutoscrollController::didPanScrollStart): Added for updating pan scrolling status of main frame.
(WebCore::AutoscrollController::didPanScrollStop): ditto
(WebCore::AutoscrollController::handleMouseReleaseEvent): Extracted from EventHandler.
(WebCore::AutoscrollController::panScrollInProgress): Replacement of EventHandler::m_panScrollInProgress.
(WebCore::AutoscrollController::startPanScrolling): Moved from EventHandler::startPanScrolling()
(WebCore::AutoscrollController::autoscrollTimerFired): Moved from EventHandler::autoscrollTimerFired().
(WebCore::AutoscrollController::startAutoscrollTimer): Moved from EventHandler::startAutoscrollTimer().
(WebCore::AutoscrollController::updatePanScrollState): Moved from EventHandler::updatePanScrollState().
- page/AutoscrollController.h: Added.
(AutoscrollController):
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Changed autoscroll and panscroll related member variable initializations to m_autoscrollController initialization.
(WebCore::EventHandler::handleMouseDraggedEvent): Changed to call AutoscrollController::startAutoscrollForSelection().
(WebCore::EventHandler::handleMouseReleaseEvent): Changed to remove m_autoscrollInProgress reference.
(WebCore::EventHandler::didPanScrollStart): Added for updating pan scrolling status of main frame.
(WebCore::EventHandler::didPanScrollStop): ditto
(WebCore::EventHandler::startPanScrolling): Changed to call AutoscrollController::startPanScrolling().
(WebCore::EventHandler::autoscrollRenderer): Changed to use AutoscrollController.
(WebCore::EventHandler::updateAutoscrollRenderer): ditto
(WebCore::EventHandler::autoscrollInProgress): ditto
(WebCore::EventHandler::panScrollInProgress): Added to replace m_panScrollInProgress.
(WebCore::EventHandler::stopAutoscrollTimer): Changed to use AutoscrollController.
(WebCore::EventHandler::selectCursor): Changed to use panScrollInProgress().
(WebCore::EventHandler::handleMousePressEvent): Chagned to call AutoscrollController::handleMousePressEvent().
(WebCore::EventHandler::keyEvent): Changed to use panScrollInProgress().
- page/EventHandler.h:
(WebCore::EventHandler::autoscrollController): Added for using main frame's panScrollInProgress().
(WebCore::EventHandler::mouseDownWasInSubframe): Added for AutoscrollController.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::canAutoscroll): Moved from EventHandler.cpp.
(WebCore::RenderBox::findAutoscrollable): Moved from EventHandler.cpp.
- rendering/RenderBox.h:
(RenderBox): Added new functions canAutoscroll() and findAutoscrollable().
- 12:27 AM Changeset in webkit [137725] by
-
- 2 edits6 copies in trunk/LayoutTests
Copy platform/win/fast/events/panScroll-* to platform/chromium-win/fast/events
https://bugs.webkit.org/show_bug.cgi?id=104991
This patch copies pan scrolling related test from Win port to Chromium-Win port
for catching pan scrolling breakage on Chromium-Win port.
- platform/chromium/TestExpectations: Disables panScroll tests other than Windows.
- platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Copied from platform/mac/fast/events.
- platform/chromium-win/fast/events/panScroll-click-hyperlink.html: ditto
- platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: ditto
- platform/chromium-win/fast/events/panScroll-event-fired.html: ditto
- platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: ditto.
- platform/chromium-win/fast/events/panScroll-nested-divs.html: ditto
- 12:25 AM Changeset in webkit [137724] by
-
- 9 edits in trunk/Source
EME v0.1: Report defaultURL in KeyMessage.
https://bugs.webkit.org/show_bug.cgi?id=104284
Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-14
Reviewed by Darin Fisher.
Passes defaultURL down from the media engine to HTMLMediaElement.
Only Valid URLs will be passed.
No test because Clear Key does not provide a defaultURL (in v0.1).
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerKeyMessage):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::keyMessage):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerKeyAdded):
(WebCore::MediaPlayerClient::mediaPlayerKeyError):
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage):
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
(MediaPlayer):
Source/WebKit/chromium:
- public/WebMediaPlayerClient.h:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::keyMessage):
(WebKit):
(WebKit::WebMediaPlayerClient::keyMessage):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 12:19 AM Changeset in webkit [137723] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r137720.
http://trac.webkit.org/changeset/137720
https://bugs.webkit.org/show_bug.cgi?id=104991
Wrong Commit
- platform/chromium/TestExpectations:
- 12:14 AM Changeset in webkit [137722] by
-
- 1 edit6 deletes in trunk/LayoutTests
Unreviewed, rolling out r137719.
http://trac.webkit.org/changeset/137719
https://bugs.webkit.org/show_bug.cgi?id=104991
Wrong commit
- platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
- platform/chromium-win/fast/events/panScroll-click-hyperlink.html: Removed.
- platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Removed.
- platform/chromium-win/fast/events/panScroll-event-fired.html: Removed.
- platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Removed.
- platform/chromium-win/fast/events/panScroll-nested-divs.html: Removed.
- 12:13 AM Changeset in webkit [137721] by
-
- 3 edits in trunk/LayoutTests
[GTK] accessibility/ellipsis-text.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98365
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-14
Reviewed by Martin Robinson.
The test was failing due to differences in the accessible hierarchies
with respect to which object contains the accessible text. The solution
is to conditionalize the test.
- accessibility/ellipsis-text.html: Modified to handle differences in
the accessible hierarchy
- platform/gtk/TestExpectations: Unskipped the failing test
- 12:12 AM Changeset in webkit [137720] by
-
- 2 edits in trunk/LayoutTests
Suspend
- 12:12 AM Changeset in webkit [137719] by
-
- 1 edit6 copies in trunk/LayoutTests
Suspend 2012-12-14T14:48
- 12:01 AM Changeset in webkit [137718] by
-
- 10 edits in trunk/Source/WebKit2
[EFL][WK2] Do not pass size to updateViewportSize
https://bugs.webkit.org/show_bug.cgi?id=104994
Reviewed by Gyuyoung Kim.
There is no need to pass size to updateViewportSize as we
have direct access to it. This makes the code differ less
from Qt.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::pageDidRequestScroll):
- UIProcess/efl/PageClientBase.h:
(PageClientBase):
- UIProcess/efl/PageClientDefaultImpl.cpp:
(WebKit::PageClientDefaultImpl::updateViewportSize):
- UIProcess/efl/PageClientDefaultImpl.h:
(PageClientDefaultImpl):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
- UIProcess/efl/PageClientLegacyImpl.h:
(PageClientLegacyImpl):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
- UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):
Dec 13, 2012:
- 11:45 PM Changeset in webkit [137717] by
-
- 5 edits in trunk/Source/WebCore
ContentDistributor and ShadowRootContentDistributionData should use RefPtr to hold elements.
https://bugs.webkit.org/show_bug.cgi?id=104918
Reviewed by Kentaro Hara.
This change turns some raw pointers to RefPtrs.
No new tests. Hard to write reliable fast tests since the error
reproduction needs GC to run in certain timing. Although original
report has a repdocution, it takes a few seconds before crash and
isn't suited for a layout test.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::insertionPointList):
- dom/ShadowRoot.h:
(ShadowRoot):
- html/shadow/ContentDistributor.cpp:
(WebCore::ShadowRootContentDistributionData::ensureInsertionPointList):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
- html/shadow/ContentDistributor.h:
(ShadowRootContentDistributionData):
(ContentDistributor):
- 11:30 PM Changeset in webkit [137716] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning
https://bugs.webkit.org/show_bug.cgi?id=104978
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2012-12-13
Reviewed by Kentaro Hara.
Initialize parameter 'downloadID' to fix 'unused parameter' build warning.
- WebProcess/Downloads/Download.cpp:
(WebKit::Download::Download):
- 10:50 PM Changeset in webkit [137715] by
-
- 24 edits2 adds in trunk/Source/WebCore
NodeRenderingContext is slow due to ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=104332
Reviewed by Dimitri Glazkov.
NodeRenderingContext has some slowness due to the complexity of
ComposedShadowTreeWalker that NRC relies on. This change
creates some fast paths to address such slowness.
NodeRenderingTraversal module:
This change introduces NodeRenderingTraversal namespace, a sister
of NodeTraversal. NRT consists of a set of tree traversal
functions that is responsible for traversal in NRC. Before this
change, NRC directly used CSTW. This NRT module hides and narrows
the usage of CSTW.
- Traversals provided by NRT have fast paths. In many case, such traversals don't need to use CSTW and just goes to neighboring nodes in a plain DOM way.
- It also handles NRC specific traversal concerns like pseudo elements. CSTW::pseudoAwareNextSibling() and CSTW::pseudoAwarePreviousSibling() are merged into this module.
- CSTW::ParentTraversalDetails is moved and renamed to NRT::ParentDetails with small modification. This is a pure refactoring: As the name implies, This class is used only by NRC and used during a traversal there.
NodeRenderingTraversal is an isolation layer between generic DOM and CSTW. This hides CSTW
behind the wall and will help further reduction of its usage.
Node::NeedsShadowTreeWalkerFlag flag:
NRT fast path is enabled by newly introduced NeedsShadowTreeWalker
node flag. Each DOM node is now markd as NeedsShadowTreeWalker if
it requires non-trivial traversal in NRT which uses CSTW. This
means that each node can go fast path unless it is marked with this flag.
A node is marked as it NeedsShadowTreeWalker if:
- The node is a shadow boundary like InsertionPoint or ShadowRoot,
- The node has pseudo elements like generated content or
- The node is a pseudo element.
This criteria is defined in Node::needsShadowTreeWalkerSlow(). The node actually needs
the walker if the node or its parent is marked with this flag.
The original idea of this change was demonstrated by Antti Koivisto on bug 103208 and bug 104507.
This chagne has 2-3% speedup on Dromaeo/dom-modify/innerHTML on Apple Mac.
No new tests. Covered by existing tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/ComposedShadowTreeWalker.cpp:
- dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker): Move some part to NodeRenderingTraversal
- dom/ContainerNode.h:
(WebCore::Node::needsShadowTreeWalker): Added. This is located here since it refers ContainerNode definition.
(WebCore):
- dom/DOMAllInOne.cpp:
- dom/Element.cpp:
(WebCore::Element::updatePseudoElement): Refactored.
(WebCore::Element::hasPseudoElements): Ditto.
(WebCore::Element::pseudoElement): Ditto.
(WebCore::Element::setPseudoElement): Refactored and added a flag update logic.
(WebCore):
- dom/Element.h:
(Element):
(WebCore::Element::beforePseudoElement): Refactored.
(WebCore::Element::afterPseudoElement): Refactored.
- dom/ElementRareData.h:
(WebCore::ElementRareData::hasPseudoElements): Factored out.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Added a flag update logic.
- dom/Node.cpp:
(WebCore::Node::needsShadowTreeWalkerSlow): Added.
- dom/Node.h:
(WebCore::Node::isInsertionPointNode): Added.
(Node):
(WebCore::Node::isInsertionPoint): Changed to use NeedsShadowTreeWalkerFlag.
(WebCore::Node::setNeedsShadowTreeWalker):
(WebCore::Node::resetNeedsShadowTreeWalker):
- dom/NodeRenderingContext.cpp: Adopted NodeRenderingTraversal.
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
- dom/NodeRenderingContext.h: Ditto.
(NodeRenderingContext):
(WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
- dom/NodeRenderingTraversal.cpp: Added.
(WebCore):
(NodeRenderingTraversal):
(WebCore::NodeRenderingTraversal::ParentDetails::didTraverseInsertionPoint): Moved from ComposedShadowTreeWalker
(WebCore::NodeRenderingTraversal::ParentDetails::didTraverseShadowRoot): Ditto.
(WebCore::NodeRenderingTraversal::parentSlow): Ditto.
(WebCore::NodeRenderingTraversal::nextSiblingSlow): Ditto. The original was pseudoAwareNextSibling.
(WebCore::NodeRenderingTraversal::previousSiblingSlow): Ditto. The original was pseudoAwarePreviousSibling.
- dom/NodeRenderingTraversal.h: Added.
(WebCore):
(NodeRenderingTraversal):
(ParentDetails): Moved from ComposedShadowTreeWalker.
(WebCore::NodeRenderingTraversal::ParentDetails::ParentDetails):
(WebCore::NodeRenderingTraversal::ParentDetails::insertionPoint):
(WebCore::NodeRenderingTraversal::ParentDetails::resetStyleInheritance):
(WebCore::NodeRenderingTraversal::ParentDetails::outOfComposition):
(WebCore::NodeRenderingTraversal::ParentDetails::childWasOutOfComposition):
(WebCore::NodeRenderingTraversal::ParentDetails::operator==):
(WebCore::NodeRenderingTraversal::parent):
(WebCore::NodeRenderingTraversal::nextSibling):
(WebCore::NodeRenderingTraversal::previousSibling):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::PseudoElement): Added an assertion.
- dom/Text.cpp:
- html/HTMLOptGroupElement.cpp: Added a #include which revealed by a chagne on NodeRenderingContext.h
- html/HTMLOptionElement.cpp: Ditto.
- html/HTMLProgressElement.cpp: Dito.
- html/shadow/InsertionPoint.h: Added an override of isInsertionPointNode().
- 10:41 PM Changeset in webkit [137714] by
-
- 5 edits in trunk/Tools
Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
https://bugs.webkit.org/show_bug.cgi?id=104891
Reviewed by Ryosuke Niwa.
I also implemented a very simple "Sample" Profiler using
Mac OS X's /usr/bin/sample command line tool.
The real reason for this abstraction is to make it easy
to support both perf and pprof on linux which seem to
be about equally popular among those I ask in the Chrome team.
- Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(ProfilerFactory):
(ProfilerFactory.available_profilers_by_name):
(ProfilerFactory.default_profiler_name):
(Sample):
(Sample.init):
(Sample.attach_to_pid):
(Sample.profile_after_exit):
(IProfiler.attach_to_pid):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.init):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
- 9:43 PM Changeset in webkit [137713] by
-
- 2 edits in trunk/Source/WebCore
Refactoring: Fix indentation of ChromeClient.h
https://bugs.webkit.org/show_bug.cgi?id=104989
Reviewed by Kentaro Hara.
The contents of an outermost namespace block should not be indented.
http://www.webkit.org/coding/coding-style.html#indentation-namespace
No behavior change.
- page/ChromeClient.h:
- 8:56 PM Changeset in webkit [137712] by
-
- 9 edits in trunk
Seconds/Minutes field of date/time input UI should respect step attribute
https://bugs.webkit.org/show_bug.cgi?id=104985
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-13
Reviewed by Kent Tamura.
Source/WebCore:
This patch makes step-up/-down UI of the seconds and minutes fields respect
step attribute when possible.
Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField): Compute step parameters for seconds and minutes fields, and pass it to the field element constructors.
(WebCore::DateTimeEditBuilder::createNumericFieldParameters): Added.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement): Use Parameters instead of step and stepBase.
(WebCore::DateTimeMillisecondFieldElement::create): Ditto.
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement): Add Parameters argument.
(WebCore::DateTimeMinuteFieldElement::create): Ditto.
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement): Ditto.
(WebCore::DateTimeSecondFieldElement::create): Ditto.
- html/shadow/DateTimeFieldElements.h:
(DateTimeMillisecondFieldElement): Use Parameters instead of step and stepBase.
(DateTimeMinuteFieldElement): Add Parameters argument.
(DateTimeSecondFieldElement): Ditto.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement): Use Parameters instead of step and stepBase.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::Parameters::Parameters):
(Parameters): Added.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
Added test cases for seconds and minutes fields.
Update an expectation for milliseconds: value=07:13:00.500, step=0 should round to 07:13:00.000
(setInputAttributes): Set value attribute first to avoid the focused field becomes read-only and unfocused.
- 8:52 PM Changeset in webkit [137711] by
-
- 2 edits in trunk/Tools
Unreviewed, fixing typo in python unittest.
I changed the default profiler on linux from pprof to perf in
bug 104971. I failed to update the unittest results at that time.
- Scripts/webkitpy/common/system/profiler_unittest.py:
(ProfilerFactoryTest.test_basic):
- 8:48 PM Changeset in webkit [137710] by
-
- 9 edits in trunk
[chromium] Add a virtual test suite for enabling opt-in to composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=104911
Reviewed by Dirk Pranke.
Tools:
Adds two virtual tests suites to run the tests in
compositing/overflow/ and scrollbars/ with the flag
--enable-accelerated-overflow-scroll, which I've also plumbed through
in the usual way.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
(WebPreferences):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedCompositingForOverflowScrollEnabled):
(TestShell):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
LayoutTests:
Updated the test expectations for the virtual test suite to match the
usual chromium test expectations.
- platform/chromium/TestExpectations:
- 8:41 PM Changeset in webkit [137709] by
-
- 13 edits in trunk/Source
Attempt to rationalize and simplify WTF::binarySearch
https://bugs.webkit.org/show_bug.cgi?id=104890
Reviewed by Maciej Stachowiak.
Source/JavaScriptCore:
Switch to using the new binarySearch() API. No change in behavior.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getByValInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::specialFastCaseProfileForBytecodeOffset):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
- dfg/DFGMinifiedGraph.h:
(JSC::DFG::MinifiedGraph::at):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::indexForBytecodeIndex):
Source/WebCore:
Switch to using the new binarySearch() API. No change in behavior, so no new tests.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::findInstanceTime):
Source/WTF:
Binary search now has three modes:
The default: assert that the key was found, but return an adjacent element if it
wasn't found, if asserts are turned off.
tryBinarySearch: return 0 if the key wasn't found.
approximateBinarySearch: if the key is not found, return an adjacent element (either
the left or right; no guarantee which).
This also reduces the number of variants of binarySearch. The functor variant is now
gone because binarySearch now always uses a functor for the key extractor. The
generic variant is now gone because binarySearch always expects an array type that
can do operator[].
- wtf/StdLibExtras.h:
(WTF::binarySearchImpl):
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
- 8:40 PM Changeset in webkit [137708] by
-
- 9 edits4 adds in trunk
[Shadow DOM]: scoped styles are not applied in the cascade order.
https://bugs.webkit.org/show_bug.cgi?id=103239
Reviewed by Dimitri Glazkov.
Source/WebCore:
If the scoping elements of two declarations have an ancestor/
descendant relationship, the declaration whose scoping element is
the descendant should win.
c.f. http://dev.w3.org/csswg/css3-cascade/#cascade
Test: fast/css/style-scoped/style-scoped-nested.html
fast/css/style-scoped/style-scoped-with-important-rule.html
- css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
Removed specificity for @host @-rules. Now @host @-rules use the
cascading order instead.
- css/RuleSet.h:
Removed increaseSpecificity. The method is used by only @host @-rules.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
Modified to invoke sortAndTransferMatchedRules per scoping element.
The order of "matchXXXRules" must be the same as the cascading order.
So matchHostRules was invoked after collecting all scoped author rules.
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::addHostRule):
Removed RuleIsHostRule. We don't need the flag.
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
Needs to pass the last test case of style-scoped-nested.html.
When appending some style element to a shadow root, we should recalc
styles of all elements in the shadow dom tree. And if the style
element has @host @-rules, we have to update the host's style.
LayoutTests:
- fast/css/style-scoped/style-scoped-nested-expected.txt: Added.
- fast/css/style-scoped/style-scoped-nested.html: Added.
- fast/css/style-scoped/style-scoped-with-important-rule-expected.txt: Added.
- fast/css/style-scoped/style-scoped-with-important-rule.html: Added.
- fast/regions/style-scoped-in-flow-override-region-styling-expected.html:
- fast/regions/style-scoped-in-flow-override-region-styling.html:
Changed the test's expectation.
Since @region's scoping element is :root but scoped styles' scoping
element is a descendant element of :root, scoped styles should win.
- 8:38 PM Changeset in webkit [137707] by
-
- 3 edits in trunk/Source/WebCore
MediaPlayerPrivateAVFoundation::m_inbandTrackConfigurationPending is unused except when HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=104987
Rubber stamped by Michael Saboff.
No change in behavior so no new tests.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
- 8:30 PM Changeset in webkit [137706] by
-
- 3 edits in trunk/Tools
Use 'perf' to profile on linux instead of google-pprof by default
https://bugs.webkit.org/show_bug.cgi?id=104971
Reviewed by Dirk Pranke.
This makes Chromium Linux match Chromium Android and use the perf
tool by default. Once https://bugs.webkit.org/show_bug.cgi?id=104891
lands it will be possible to use pprof again on Linux.
This is slightly more advanced than the AndroidPerf profiler as
instead of using a timeout on "perf record" I instead watch
for the termination of the target process and then control-C
the 'perf record' process. This required me to add two new
methods to Executive, one to have a limited-time wait() and
the second to be able to send a control-C. I chose to add
these to Executive to make them easier to mock/fix-for-win32
at a later time if needed.
- Scripts/webkitpy/common/system/executive.py:
(Executive.wait_limited):
(Executive.interrupt):
- Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(Perf):
(Perf.init):
(Perf._perf_path):
(Perf.attach_to_pid):
(Perf._first_ten_lines_of_profile):
(Perf.profile_after_exit):
- 8:19 PM Changeset in webkit [137705] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't assert that flags <= 0x3ff in JSTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=104988
Reviewed by Sam Weinig.
This assertion doesn't accomplish anything other than crashes.
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
- 8:04 PM Changeset in webkit [137704] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(JSTestCustomNamedGetter):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(JSTestEventTarget):
- 7:47 PM Changeset in webkit [137703] by
-
- 11 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r137691.
http://trac.webkit.org/changeset/137691
https://bugs.webkit.org/show_bug.cgi?id=104764
panscroll test on AppleWin failed
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/AutoscrollController.cpp: Removed.
- page/AutoscrollController.h: Removed.
- page/EventHandler.cpp:
(WebCore):
(WebCore::EventHandler::EventHandler):
(WebCore::canAutoscroll):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleAutoscroll):
(WebCore::EventHandler::autoscrollTimerFired):
(WebCore::EventHandler::startPanScrolling):
(WebCore::EventHandler::updatePanScrollState):
(WebCore::EventHandler::autoscrollRenderer):
(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::setAutoscrollRenderer):
(WebCore::EventHandler::startAutoscrollTimer):
(WebCore::EventHandler::stopAutoscrollTimer):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent):
- page/EventHandler.h:
(EventHandler):
(WebCore::EventHandler::autoscrollInProgress):
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
(RenderBox):
- 7:42 PM Changeset in webkit [137702] by
-
- 3 edits2 adds in trunk
ChildNodesLazySnapshot::nextNode() can crash
https://bugs.webkit.org/show_bug.cgi?id=104982
Reviewed by Hajime Morita.
ChildNodesLazySnapshot::nextNode() can crash for
fast/dom/insertedIntoDocument-no-crash.html.
The root cause is that ChildNodesLazySnapshot::m_currentNode
was not a RefPtr. This patch changes it to a RefPtr.
Test: fast/dom/insertedIntoDocument-no-crash.html
Source/WebCore:
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(ChildNodesLazySnapshot):
LayoutTests:
- fast/dom/insertedIntoDocument-no-crash-expected.txt: Added.
- fast/dom/insertedIntoDocument-no-crash.html: Added.
- 7:28 PM Changeset in webkit [137701] by
-
- 3 edits2 adds in trunk
Clear m_timeContainer on SVGSMILElement removal.
https://bugs.webkit.org/show_bug.cgi?id=104972
Reviewed by Abhishek Arya.
Source/WebCore:
This patch fixes a regression introduced by r137509 where we did not clear
m_timeContainer in SVGSMILElement::removedFrom.
Test: svg/custom/removed-from-animation-crash.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::removedFrom):
LayoutTests:
- svg/custom/removed-from-animation-crash-expected.txt: Added.
- svg/custom/removed-from-animation-crash.html: Added.
- 7:24 PM Changeset in webkit [137700] by
-
- 8 edits6 adds in trunk
Named lookups on HTML documents produce inconsistent results in JavaScriptCore bindings
https://bugs.webkit.org/show_bug.cgi?id=104623
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Add the notion of objects that HasImpureGetOwnPropertySlot, and use that to inhibit prototype chain caching
in some cases. This appears to be perf-neutral on benchmarks that we track.
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSTypeInfo.h:
(JSC):
(JSC::TypeInfo::hasImpureGetOwnPropertySlot):
- runtime/Operations.h:
(JSC::normalizePrototypeChainForChainAccess):
Source/WebCore:
All DOM objects that have named getters or directly override getOwnPropertySlot are now marked as
HasImpureGetOwnPropertySlot.
Tests: fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps
fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
LayoutTests:
- fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added.
- fast/js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added.
- fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added.
- fast/js/prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added.
- fast/js/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added.
(f):
- fast/js/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added.
(f):
- 7:16 PM Changeset in webkit [137699] by
-
- 13 edits in trunk/Source/JavaScriptCore
Unreviewed, roll out http://trac.webkit.org/changeset/137683.
It broke gmail.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC):
- runtime/Operations.h:
(JSC):
- 7:13 PM Changeset in webkit [137698] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=50282
Skip imagemap tests to avoid incorrect rebaselines such as r136489. The imagemap tests
won't work on chromium until Skia is taught to draw focus rings along arbitrary paths.
- platform/chromium/TestExpectations:
- 6:58 PM Changeset in webkit [137697] by
-
- 3 edits7 adds in trunk
Out-of-view check of fixed position element in frame is incorrect when page is scaled
https://bugs.webkit.org/show_bug.cgi?id=104943
Reviewed by Simon Fraser.
Source/WebCore:
Use frameScaleFactor instead of pageScaleFactor to scale the layer bounds.
Tests: compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html
compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
Test cases.
- compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Added.
- compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt: Added.
- compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html: Added.
- compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html: Added.
- compositing/layer-creation/resources/fixed-position-out-of-view-frame-scroll.html: Added.
- compositing/layer-creation/resources/fixed-position-out-of-view-frame.html: Added.
- 6:24 PM Changeset in webkit [137696] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 136554
BUG=158533
Review URL: https://codereview.chromium.org/11569024
- 6:17 PM WebKit Team edited by
- remove "Torch Mobile" as I leave the company (diff)
- 6:13 PM Changeset in webkit [137695] by
-
- 3 edits2 adds in trunk
Source/WebCore: Positioned replaced elements should resolve vertical margins against their containing
block's logical width
https://bugs.webkit.org/show_bug.cgi?id=103579
Patch by Bear Travis <betravis@adobe.com> on 2012-12-13
Reviewed by Emil A Eklund.
According to the CSS box model & writing modes specifications, percentage margin
& padding values, including top & bottom, should be resolved based on the
containing block's logical width (logical with respect to the containing block's
writing mode).
http://www.w3.org/TR/CSS2/box.html#margin-properties
http://dev.w3.org/csswg/css3-writing-modes/#dimension-mapping
Previously, a positioned replaced element resolved margin before/after relative to
its inline direction (containerLogicalHeight), and margin start/end relative to
its block direction (containerLogicalWidth). This patch measures the container's
logical width in its own inline direction (containerRelativeLogicalWidth) to
resolve all margin percentage values.
Test: fast/writing-mode/percentage-margins-absolute-replaced.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Calculate the logical
width of the container, and use it to calculate margins.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Ditto.
LayoutTests: Positioned replaced elements should resolve vertical margins against their
containing block's logical width
https://bugs.webkit.org/show_bug.cgi?id=103579
Patch by Bear Travis <betravis@adobe.com> on 2012-12-13
Reviewed by Emil A Eklund.
Test that different writing mode combinations between a parent and child correctly
compute percentage margins for an absolutely positioned replaced child.
- fast/writing-mode/percentage-margins-absolute-replaced-expected.txt: Added.
- fast/writing-mode/percentage-margins-absolute-replaced.html: Added.
- 6:12 PM Changeset in webkit [137694] by
-
- 2 edits2 copies in branches/chromium/1312
Merge 136541
BUG=163994
Review URL: https://codereview.chromium.org/11564028
- 6:02 PM Changeset in webkit [137693] by
-
- 10 edits in trunk/Tools
Dashboard cleanup: remove usage of global g_builders.
https://bugs.webkit.org/show_bug.cgi?id=104941
Reviewed by Dirk Pranke.
The dashboards use a lot of global state, which makes hacking on them
complicated. This change removes the use of one such global: g_builders.
In most cases, we can just use currentBuilderGroup().builders instead,
which is now currentBuilders().
Surprisingly, the most changes were required to the unit tests, since
they were even bigger offenders of bad hygiene, relying on global state
set by other tests, randomly clobbering global variables in ways the
real code doesn't, etc.
- TestResultServer/static-dashboards/builders.js:
(BuilderGroup.prototype.setup):
- TestResultServer/static-dashboards/dashboard_base.js:
(.switch.return):
(htmlForTestTypeSwitcher):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(getAllTestsTrie):
(processTestRunsForAllBuilders):
(showPopupForBuild):
(generatePageForExpectationsUpdate):
(loadExpectationsLayoutTests):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
(stubResultsByBuilder):
(test):
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/loader_unittests.js:
- 5:58 PM Changeset in webkit [137692] by
-
- 4 edits in trunk/Tools
Callers should not have to stringify args before calling Executive run_command/popen
https://bugs.webkit.org/show_bug.cgi?id=104975
Reviewed by Dirk Pranke.
One could argue that we should match the python call syntax here,
but I think it's a more friendly API if we automagically handle
stringification of args in run_command, etc.
This removes map(unicode, args) from several callsites.
When I first tried to land this change, I didn't realize that
Executive._command_for_printing depended on this behavior
having been applied to args in run_command. The fix is to
call _stringify_args in both run_command and popen.
This is slightly redundant, but given how short args have to be
(due to shell limits), I don't think the double-encode check
matters in practice.
This is slightly complicated by the fact that apache_http_server.py
is the one caller in our codebase which uses shell=True.
shell=True is a well-documented trail-of-tears:
http://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocess
but to support this legacy (windows-only) code (which I can't easily test)
I've added an if-hack to avoid stringifying the the popen(shell=True) case.
- Scripts/webkitpy/common/system/executive.py:
(Executive.run_command):
(Executive._stringify_args):
(Executive.popen):
- Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_auto_stringify_args):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(attach_to_pid):
- 5:45 PM Changeset in webkit [137691] by
-
- 11 edits2 adds in trunk/Source/WebCore
Handling autoscroll in EventHandler should be re-factor
https://bugs.webkit.org/show_bug.cgi?id=104764
Reviewed by Hajime Morita.
This patch introduces new class AutoscrollController for moving autoscroll
and panscroll from EventHandler class for ease of maintenance of
EventHandler and ease of adding autoscroll related features, e.g. autoscroll
during drag-and-drop, autoscoll by gesture.
No new tests. This patch doesn't change behavior.
- CMakeLists.txt: Changed to add page/AutoscrollController.cpp
- GNUmakefile.list.am: Changed to add page/AutoscrollController.{cpp,h}
- Target.pri: Changed to add page/AutoscrollController.cpp
- WebCore.gypi: Changed to add page/AutoscrollController.{cpp,h}
- WebCore.vcproj/WebCore.vcproj: Changed to add page/AutoscrollController.{cpp,h}
- WebCore.xcodeproj/project.pbxproj: Changed to add page/AutoscrollController.{cpp,h}
- page/AutoscrollController.cpp: Added.
(WebCore::getMainFrame): Helper function.
(WebCore::AutoscrollController::AutoscrollController): Moved from EventHandler.
(WebCore::AutoscrollController::autoscrollRenderer): Moved from EventHandler.
(WebCore::AutoscrollController::autoscrollInProgress): Moved from EventHandler.
(WebCore::AutoscrollController::startAutoscrollForSelection): Replacement of EventHandler::handleAutoscroll().
(WebCore::AutoscrollController::stopAutoscrollTimer): Moveed from EventHandler.
(WebCore::AutoscrollController::updateAutoscrollRenderer): ditto
(WebCore::AutoscrollController::didPanScrollStart): Added for updating pan scrolling status of main frame.
(WebCore::AutoscrollController::didPanScrollStop): ditto
(WebCore::AutoscrollController::handleMouseReleaseEvent): Extracted from EventHandler.
(WebCore::AutoscrollController::panScrollInProgress): Replacement of EventHandler::m_panScrollInProgress.
(WebCore::AutoscrollController::startPanScrolling): Moved from EventHandler::startPanScrolling()
(WebCore::AutoscrollController::autoscrollTimerFired): Moved from EventHandler::autoscrollTimerFired().
(WebCore::AutoscrollController::startAutoscrollTimer): Moved from EventHandler::startAutoscrollTimer().
(WebCore::AutoscrollController::updatePanScrollState): Moved from EventHandler::updatePanScrollState().
- page/AutoscrollController.h: Added.
(AutoscrollController):
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Changed autoscroll and panscroll related member variable initializations to m_autoscrollController initialization.
(WebCore::EventHandler::handleMouseDraggedEvent): Changed to call AutoscrollController::startAutoscrollForSelection().
(WebCore::EventHandler::handleMouseReleaseEvent): Changed to remove m_autoscrollInProgress reference.
(WebCore::EventHandler::didPanScrollStart): Added for updating pan scrolling status of main frame.
(WebCore::EventHandler::didPanScrollStop): ditto
(WebCore::EventHandler::startPanScrolling): Changed to call AutoscrollController::startPanScrolling().
(WebCore::EventHandler::autoscrollRenderer): Changed to use AutoscrollController.
(WebCore::EventHandler::updateAutoscrollRenderer): ditto
(WebCore::EventHandler::autoscrollInProgress): ditto
(WebCore::EventHandler::panScrollInProgress): Added to replace m_panScrollInProgress.
(WebCore::EventHandler::stopAutoscrollTimer): Changed to use AutoscrollController.
(WebCore::EventHandler::selectCursor): Changed to use panScrollInProgress().
(WebCore::EventHandler::handleMousePressEvent): Chagned to call AutoscrollController::handleMousePressEvent().
(WebCore::EventHandler::keyEvent): Changed to use panScrollInProgress().
- page/EventHandler.h:
(WebCore::EventHandler::autoscrollController): Added for using main frame's panScrollInProgress().
(WebCore::EventHandler::mouseDownWasInSubframe): Added for AutoscrollController.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::canAutoscroll): Moved from EventHandler.cpp.
(WebCore::RenderBox::findAutoscrollable): Moved from EventHandler.cpp.
- rendering/RenderBox.h:
(RenderBox): Added new functions canAutoscroll() and findAutoscrollable().
- 5:44 PM Changeset in webkit [137690] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=102599
ASSERT loading Acid3 test in run-safari --debug (r135050)
Reviewed by Simon Fraser.
New flag IncludeCompositedDescendants will always calculate the layer bounds for
descendants, even when the are composited.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
calculateCompositedBounds() should not include this new flag, so instead of
calling that, call calculateLayerBounds() directly with the
IncludeCompositedDescendants flag. This will get us the information we need
upfront and avoid the toggling later on.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- 5:29 PM Changeset in webkit [137689] by
-
- 2 edits in trunk/Source/WebKit2
Resource loads sometimes stall
https://bugs.webkit.org/show_bug.cgi?id=104976
Reviewed by Anders Carlsson.
Quick and dirty partial fix.
- Shared/BlockingResponseMap.h: (BlockingResponseMap::didReceiveResponse): Wake up all threads, so that non-sequential responses don't break us. This is still horribly inefficient,but should improve behavior quite a bit.
- 5:15 PM Changeset in webkit [137688] by
-
- 5 edits in trunk/Source
Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=104907
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-13
Reviewed by Kentaro Hara.
Use UNUSED_PARAM macro to fix build warning -Wunused-parameter
when ENABLE_INSPECTOR is disabled.
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
Source/WebKit2:
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorGetPage):
(WKInspectorIsVisible):
(WKInspectorIsFront):
(WKInspectorShow):
(WKInspectorClose):
(WKInspectorShowConsole):
(WKInspectorShowResources):
(WKInspectorShowMainResourceForFrame):
(WKInspectorIsAttached):
(WKInspectorAttach):
(WKInspectorDetach):
(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):
(WKInspectorIsProfilingPage):
(WKInspectorTogglePageProfiling):
- UIProcess/API/C/WKPage.cpp:
(WKPageGetInspector):
- 5:10 PM Changeset in webkit [137687] by
-
- 4 edits in trunk/Source/WebKit2
[QT][GTK][EFL] Add guard for WebInspectorServer
https://bugs.webkit.org/show_bug.cgi?id=104889
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-13
Reviewed by Kenneth Rohde Christiansen.
Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer.
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
- UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:
- 5:09 PM Changeset in webkit [137686] by
-
- 4 edits1 add in trunk/Source
Don't consider container nodes of other disambiguated nodes
https://bugs.webkit.org/show_bug.cgi?id=104619
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-12-13
Reviewed by Eric Seidel.
Source/WebCore:
It is not uncommon to have a clickable <div> that contains other clickable objects.
This heuristic avoids excessive disambiguation in that case.
New unit test: WebFrameTest.DisambiguationPopupNoContainer
- page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
Source/WebKit/chromium:
Added a test to track the new disambiguation popup heuristics.
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_no_container.html: Added.
- 4:42 PM Changeset in webkit [137685] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics: Reorder messages to CoordinatedLayerTreeHostProxy
https://bugs.webkit.org/show_bug.cgi?id=103843
Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-13
Reviewed by Noam Rosenthal.
Clarify LayerTreeRenderer::setRootLayerID() can be called only once during its
lifecycle. LayerTreeRenderer, CoordinatedLayerTreeHost and CoordinatedLayerTreeHostProxy
have the same lifecycle to WebPage and the root layer is reused even if loading
new page, so it is impossible to call LayerTreeRenderer::setRootLayerID() more
than twice.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setRootLayerID):
- 4:42 PM Changeset in webkit [137684] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/events/mouse-cursor-image-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=104945
Patch by Rick Byers <rbyers@chromium.org> on 2012-12-13
Reviewed by Beth Dakin.
Fix typo that prevented one of the images from being reliably pre-loaded.
A deeper fix to avoid these class of issues is tracked by
https://bugs.webkit.org/show_bug.cgi?id=104952
- fast/events/mouse-cursor-image-set.html:
- 4:32 PM Changeset in webkit [137683] by
-
- 13 edits in trunk/Source/JavaScriptCore
Support op_typeof in the DFG
https://bugs.webkit.org/show_bug.cgi?id=98898
Reviewed by Filip Pizlo.
Adds a TypeOf node to the DFG to support op_typeof.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
We try to determine the result early here, and substitute in a constant.
Otherwise we leave the node intact, and set the result type to SpecString.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
Parse op_typeof
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
TypeOf nodes can be subjected to pure CSE
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
We can handle typeof.
- dfg/DFGNodeType.h:
(DFG):
Define the node.
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h: Add operationTypeOf to support the non-trivial cases.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Actual codegen
- runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC):
- runtime/Operations.h:
(JSC):
Some refactoring to allow us to get the type string for an
object without needing a callframe.
- 4:30 PM Changeset in webkit [137682] by
-
- 14 edits5 deletes in trunk
Unreviewed, rolling out r137645, r137646, and r137667.
http://trac.webkit.org/changeset/137645
http://trac.webkit.org/changeset/137646
http://trac.webkit.org/changeset/137667
https://bugs.webkit.org/show_bug.cgi?id=104911
Breaks some overflow layout tests
Source/WebCore:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateDescendantDependentFlags):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::usesCompositedScrolling):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateLayerListsIfNeeded):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- testing/InternalSettings.cpp:
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
Tools:
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
LayoutTests:
- compositing/overflow/automatically-opt-into-composited-scrolling-expected.txt: Removed.
- compositing/overflow/automatically-opt-into-composited-scrolling.html: Removed.
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Removed.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Removed.
- platform/chromium/TestExpectations:
- 4:22 PM Changeset in webkit [137681] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Expose a WebLayerTreeView getter on WebWidget to make it easier for the embedder to interface with the compositor
https://bugs.webkit.org/show_bug.cgi?id=104968
Patch by James Robinson <jamesr@chromium.org> on 2012-12-13
Reviewed by Adrienne Walker.
This is an intermediate step on the way to https://code.google.com/p/chromium/issues/detail?id=156175.
- public/WebWidget.h:
(WebKit):
(WebWidget):
(WebKit::WebWidget::layerTreeView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::webLayerTreeView):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 4:20 PM Changeset in webkit [137680] by
-
- 3 edits in trunk/Source/WebCore
Event dispatch: Avoid heap allocations in ensureEventAncestors() typical case.
<http://webkit.org/b/104938>
Reviewed by Anders Carlsson.
Give the EventTarget and EventContext vectors an inline capacity of 32 (no science here, just a
non-zero number.) As these vectors are created on the stack already, this is merely using a bit
more stack space to avoid malloc()ing all the gosh-darn time.
Looks like ~6% improvement on Dromaeo/jslib-event-prototype.
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):
(WebCore::EventDispatcher::ensureEventAncestors):
- dom/EventDispatcher.h:
(EventRelatedTargetAdjuster):
(EventDispatcher):
- 4:20 PM Changeset in webkit [137679] by
-
- 4 edits in branches/safari-536.28-branch/Source
Versioning.
- 4:17 PM Changeset in webkit [137678] by
-
- 1 copy in tags/Safari-536.28.7
New Tag.
- 4:13 PM Changeset in webkit [137677] by
-
- 3 edits2 adds in trunk
[Resource Timing] Don't report resources with data: urls
https://bugs.webkit.org/show_bug.cgi?id=104868
Reviewed by Tony Gentilcore.
Source/WebCore:
Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadDone):
LayoutTests:
- http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt: Added.
- http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html: Added.
- 4:06 PM Changeset in webkit [137676] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tim Horton.
This test needs updates results after http://trac.webkit.org/changeset/137393
- platform/mac/svg/css/shadow-changes-expected.txt:
- 4:00 PM Changeset in webkit [137675] by
-
- 2 edits3 copies in branches/chromium/1312
Merge 136845
BUG=162494
- 3:52 PM Changeset in webkit [137674] by
-
- 2 edits in trunk/Source/WebCore
Add a missing nullity check in RenderObject::containingBlock
https://bugs.webkit.org/show_bug.cgi?id=104961
Reviewed by Adrienne Walker.
Adds a missing nullity check in an assert.
No new tests, no change in functionality.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- 3:49 PM Changeset in webkit [137673] by
-
- 5 edits in trunk/Tools
Unreviewed, rolling out r137661.
http://trac.webkit.org/changeset/137661
https://bugs.webkit.org/show_bug.cgi?id=104891
broke unit tests, run-webkit-tests
- Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output):
(Executive.run_command):
(Executive.popen):
- Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(GooglePProf.profile_after_exit):
(IProfiler.attach_to_pid):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.init):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
- 3:42 PM Changeset in webkit [137672] by
-
- 5 edits1 add in trunk/Tools
nrwt: move rundetails, summarize_results into test_run_results
https://bugs.webkit.org/show_bug.cgi?id=104963
Reviewed by Eric Seidel.
More cleanup; this the plain-old-data functions out of manager.py
and into test_run_results next to the other aggregate data structures.
Also this cleans up a bunch of test code and reduces duplication.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_look_for_new_crash_logs):
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.init):
(TestRunResults.add):
(RunDetails):
(RunDetails.init):
(_interpret_test_failures):
(summarize_results):
- Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: Added.
(get_result):
(run_results):
(summarized_results):
(InterpretTestFailuresTest):
(InterpretTestFailuresTest.setUp):
(InterpretTestFailuresTest.test_interpret_test_failures):
(SummarizedResultsTest):
(SummarizedResultsTest.setUp):
(SummarizedResultsTest.test_no_svn_revision):
(SummarizedResultsTest.test_svn_revision):
(SummarizedResultsTest.test_summarized_results_wontfix):
- Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
(BuildBotPrinterTests.get_printer):
(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_results):
- 3:41 PM Changeset in webkit [137671] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Possible JS re-entrancy caused by UI event handler
https://bugs.webkit.org/show_bug.cgi?id=84862
Reviewed by Rob Buis.
Fix an obvious bug in previous patch.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
- 3:37 PM Changeset in webkit [137670] by
-
- 1 edit in branches/chromium/1312/Source/WebCore/editing/ApplyStyleCommand.cpp
Merge 136619
BUG=163110
Review URL: https://codereview.chromium.org/11577012
- 3:34 PM Changeset in webkit [137669] by
-
- 7 edits in trunk
Switch the gradient drawing code to use bearing angles
https://bugs.webkit.org/show_bug.cgi?id=104616
Patch by Tab Atkins <tabatkins@google.com> on 2012-12-13
Reviewed by Dean Jackson.
Source/WebCore:
Switch the gradient math from polar-coordinate angles to bearing angles.
To make this possible without behavior changes,
switch the m_deprecatedType boolean to an m_gradientType enum,
and fix all usages accordingly.
No new tests, as this is a refactoring and should have no behavior changes. Existing tests suffice.
- css/CSSGradientValue.cpp:
(WebCore::endPointsFromAngle):
This is the only mechanical change. The rest are just fixing the plumbing around the boolean->enum change.
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::sortStopsIfNeeded):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::gradientType):
(WebCore::CSSGradientValue::CSSGradientValue):
(WebCore::CSSLinearGradientValue::create):
(WebCore::CSSLinearGradientValue::CSSLinearGradientValue):
(WebCore::CSSRadialGradientValue::create):
(WebCore::CSSRadialGradientValue::CSSRadialGradientValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
LayoutTests:
This change alters a few pixels on the linux baseline.
It may or may not trigger similar failures on Windows and Mac - we'll see.
- platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium/TestExpectations:
- 3:33 PM Changeset in webkit [137668] by
-
- 2 edits2 copies in branches/chromium/1312
Merge 136560
BUG=158199
Review URL: https://codereview.chromium.org/11565023
- 3:31 PM Changeset in webkit [137667] by
-
- 2 edits9 adds in trunk/LayoutTests
Mark one test as failing and rebaseline another after r137646
Unreviewed chromium gardening.
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium/TestExpectations:
- 3:30 PM Changeset in webkit [137666] by
-
- 2 edits in trunk/Tools
Make --profile output easier to understand for pprof on linux
https://bugs.webkit.org/show_bug.cgi?id=104957
Reviewed by Dirk Pranke.
pprof is kinda mysterious, so we print some information
on how to use it, and how to learn how to read the sample dump.
This is similar to what we've done for perf output for Chromium Android.
- Scripts/webkitpy/common/system/profiler.py:
(GooglePProf._pprof_path):
(GooglePProf.profile_after_exit):
- 3:28 PM Changeset in webkit [137665] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 136558
BUG=158060
Review URL: https://codereview.chromium.org/11573024
- 3:27 PM Changeset in webkit [137664] by
-
- 4 edits in trunk/Tools
Revert r137407 - it didn't actually work right.
https://bugs.webkit.org/show_bug.cgi?id=101976
Unreviewed, build fix.
Turns out that rebaselining was completely broken with this change :(
We're passing in a list of test names rather than the list of
failureInfo objects.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
- 3:21 PM Changeset in webkit [137663] by
-
- 4 edits in trunk
[chromium] Small fixes for WebPluginContainer::setWebLayer
https://bugs.webkit.org/show_bug.cgi?id=104953
Reviewed by James Robinson.
Source/WebKit/chromium:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): Allow
WebPlugin to clean up dangling pointers.
Tools:
- DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Clean up
dangling pointers, force correct invalidation of the layer.
- 3:19 PM Changeset in webkit [137662] by
-
- 10 edits54 moves1 add in trunk/LayoutTests
Move MutationObserver tests to fast/dom/MutationObserver
https://bugs.webkit.org/show_bug.cgi?id=104948
Reviewed by Ryosuke Niwa.
This seems like a more sensible location, and in line with other DOM features.
- fast/dom/MutationObserver/: Renamed from LayoutTests/fast/mutation/.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 3:17 PM Changeset in webkit [137661] by
-
- 5 edits in trunk/Tools
Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
https://bugs.webkit.org/show_bug.cgi?id=104891
Reviewed by Dirk Pranke.
I also implemented a very simple "Sample" Profiler using
Mac OS X's /usr/bin/sample command line tool.
I also moved the map(unicode, args) call into Executive.popen
so that all callers don't have to do it themselves.
The real reason for this abstraction is to make it easy
to support both perf and pprof on linux which seem to
be about equally popular among those I ask in the Chrome team.
- Scripts/webkitpy/common/system/executive.py:
(Executive.popen):
- Scripts/webkitpy/common/system/profiler.py:
(ProfilerFactory.create_profiler):
(ProfilerFactory):
(ProfilerFactory.available_profilers_by_name):
(ProfilerFactory.default_profiler_name):
(Sample):
(Sample.init):
(Sample.attach_to_pid):
(Sample.profile_after_exit):
(IProfiler.attach_to_pid):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.init):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
- 3:11 PM Changeset in webkit [137660] by
-
- 5 edits in trunk/LayoutTests
[Chromium] Unreviewed rebaselining after Skia roll @6773.
- platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDotted04-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png:
- 3:06 PM Changeset in webkit [137659] by
-
- 2 edits in trunk/LayoutTests
Another attempt at getting these expectations right for the bots.
- platform/mac/TestExpectations:
- 2:58 PM Changeset in webkit [137658] by
-
- 2 edits in trunk/LayoutTests
Skipping this test for now since it has been failing a lot recently.
https://bugs.webkit.org/show_bug.cgi?id=104962 tracks fixing to bug.
- platform/mac/TestExpectations:
- 2:46 PM Changeset in webkit [137657] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/12838354> DOM cookie access functions should respect private browsing
https://bugs.webkit.org/show_bug.cgi?id=104691
Reviewed by Anders Carlsson.
Remove obsolete FIXMEs, and fix one function that I overlooked.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::cookiesForDOM): (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM): (WebKit::NetworkConnectionToWebProcess::cookiesEnabled): (WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue): (WebKit::NetworkConnectionToWebProcess::getRawCookies): (WebKit::NetworkConnectionToWebProcess::deleteCookie): (WebKit::NetworkConnectionToWebProcess::getHostnamesWithCookies): (WebKit::NetworkConnectionToWebProcess::deleteCookiesForHostname): (WebKit::NetworkConnectionToWebProcess::deleteAllCookies):
- 2:40 PM Changeset in webkit [137656] by
-
- 2 edits in trunk/LayoutTests
Skipping this test for now since it has been failing since it was added.
https://bugs.webkit.org/show_bug.cgi?id=104954 tracks fixing to bug.
- platform/mac/TestExpectations:
- 2:27 PM Changeset in webkit [137655] by
-
- 6 edits in trunk/Source/WebKit2
DownloadManager shouldn't call the web process directly
https://bugs.webkit.org/show_bug.cgi?id=104946
Reviewed by Antti Koivisto.
Introduce the needed DownloadManager::Client member functions and have Download call them instead of calling the web process directly.
- WebProcess/Downloads/Download.cpp:
(WebKit::Download::Download):
(WebKit::Download::~Download):
(WebKit::Download::connection):
- WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::DownloadManager):
(WebKit::DownloadManager::didCreateDownload):
(WebKit::DownloadManager::didDestroyDownload):
(WebKit::DownloadManager::connection):
- WebProcess/Downloads/DownloadManager.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didCreateDownload):
(WebKit::WebProcess::didDestroyDownload):
- WebProcess/WebProcess.h:
- 2:25 PM Changeset in webkit [137654] by
-
- 5 edits3 adds in trunk/LayoutTests
Unreviewed gardening. Apple Windows port.
- platform/win/TestExpectations:
- platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt:
- platform/win/fast/css/image-resolution/image-resolution-expected.txt:
- platform/win/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/win/fast/text/orientation-sideways-expected.txt:
- platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
- platform/win/svg/css/shadow-changes-expected.txt: Added.
- 2:16 PM Changeset in webkit [137653] by
-
- 5 edits in trunk
[chromium] Add WebPluginContainer::setWebLayer to supersede setBackingTextureId/setBackingIOSurfaceId
https://bugs.webkit.org/show_bug.cgi?id=104875
Reviewed by James Robinson.
- public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setWebLayer):
(WebKit):
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 2:07 PM Changeset in webkit [137652] by
-
- 2 edits in trunk/LayoutTests
This test has been failing on the Mac bots for a while.
https://bugs.webkit.org/show_bug.cgi?id=104949
- platform/mac/TestExpectations:
- 2:06 PM Changeset in webkit [137651] by
-
- 4 edits in branches/safari-536.28-branch/Source
Versioning.
- 1:53 PM Changeset in webkit [137650] by
-
- 9 edits in trunk/Tools
support -wk2 port names properly in webkitpy.layout_tests.port
https://bugs.webkit.org/show_bug.cgi?id=104761
Reviewed by Eric Seidel.
Our support for WK2 port names was inconsistent at best; this patch
modifies the code so that <port_name>-wk2 is supported for all ports that
have WK2 implementations and is equivalent to specifying <port_name>
and -2/--webkit-test-runner. In addition, this modifies
builders.all_port_names() to include the wk2 variants.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.determine_full_port_name):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.determine_full_port_name):
(Port.init):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.make_port):
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_baseline_search_path):
- Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.default_baseline_search_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.test_rebaseline_expectations):
- 1:50 PM Changeset in webkit [137649] by
-
- 2 edits in trunk/LayoutTests
Fixing a copy-paste error.
- platform/mac/TestExpectations:
- 1:49 PM Changeset in webkit [137648] by
-
- 2 edits in trunk/LayoutTests
Marking these tests as failing since they are failing on the bots.
https://bugs.webkit.org/show_bug.cgi?id=104942 tracks fixing the actual bug.
- platform/mac/TestExpectations:
- 1:48 PM Changeset in webkit [137647] by
-
- 18 edits in trunk/Source
<rdar://problem/12838354> Per-Tab WebProcess: DOM cookie access functions should respect private browsing
https://bugs.webkit.org/show_bug.cgi?id=104691
Reviewed by Sam Weinig.
Pass private browsing state from local context to remote one.
- 1:37 PM Changeset in webkit [137646] by
-
- 11 edits2 adds in trunk
Source/WebCore: [chromium] Automatically use composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=94743
Reviewed by Adrienne Walker.
We currently use the composited scrolling facilities provided by
wkb.ug/91117 if the overflow scroll block element is styled with
-webkit-overflow-scrolling: touch. Ideally, we could automatically
opt into composited scrolling if it is safe to do so. This can affect
antialiasing, so it is important that automatically opting in is only
enabled via a setting.
The way I determine if it is safe is by checking that z-ordering will
not be affected if the overflow scrollable element were promoted to a
stacking context (details below), and that clipping our scrolling
descendants will not affect rendering.
To check the first condition (that z-ordering will not be affected).
I ensure that the candidate element and all its descendants appear as a
continuous block in the candidate's stacking context. That is, if no
other elements are 'between' any of the candidates descendants when we
sort in paint order, then we're safe. This is overly conservative,
however. We could, in future, only consider stacking problems between
elements that actually overlap.
To ensure that clipping will not cause a rendering change, I ensure
that the layer has no out of flow positioned descendant whose
containing block is not also a descendant of ours.
Test: compositing/overflow/automatically-opt-into-compositing-scrolling.html
(WebCore):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::acceleratedCompositingForOverflowScrollEnabled):
(WebCore):
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrderRecursive):
(WebCore::RenderLayer::positionOverflowControlsAfterPromotionToCompositedScrolling):
(WebCore::RenderLayer::canSafelyEstablishAStackingContext):
Returns true if the RenderLayer could become a stacking context without
affecting the stacking order.
(WebCore::RenderLayer::updateDescendantDependentFlags):
We now need to keep track of out of flow positioned descendants.
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::usesCompositedScrolling):
Has been updated to return true if it can safely establish a stacking
context, and the setting is turned on.
(WebCore::RenderLayer::needsCompositedScrolling):
This function returns true if we would like to use composited
scrolling.
(WebCore::RenderLayer::updateNeedsCompositedScrolling):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
Since these could affect opting into composited scrolling, we must
request that the RenderLayerCompositor reevaluate compositing.
(WebCore::RenderLayer::updateLayerListsIfNeeded):
We call updateCanSafelyEstablishStackingContext here, if necessary.
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
usesCompositedScrolling -> needsCompositedScrolling
(WebCore::RenderLayer::setAncestorChainHasOutOfFlowPositionedDescendant):
(WebCore::RenderLayer::dirtyAncestorChainHasOutOfFlowPositionedDescendantStatus):
(WebCore::RenderLayer::updateOutOfFlowPositioned):
Dirties and sets the out of flow positioned descendant state.
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::hasOutOfFlowPositionedDescendant):
- rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::hasUnpositionedOverflowControlsLayers):
(WebCore):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
We now ensure that newly created overflow scroll controls get
positioned.
(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling):
- rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::setShouldReevaluateCompositingAfterLayout):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEnableCompositingForOverflowScroll):
Allows enabling the setting in layout tests.
(WebCore):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
LayoutTests: Automatically use composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=94743
Reviewed by Adrienne Walker.
Tests various configurations of elements to ensure that we only automatically opt into
composited scrolling when it is safe to do so.
- compositing/overflow/automatically-opt-into-composited-scrolling-expected.txt: Added.
- compositing/overflow/automatically-opt-into-composited-scrolling.html: Added.
- 1:25 PM Changeset in webkit [137645] by
-
- 4 edits in trunk
[chromium] Add a virtual test suite for enabling opt-in to composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=104911
Reviewed by Adrienne Walker.
Tools:
Adds two virtual tests suites to run the tests in
compositing/overflow/ and scrollbars/ with the flag
--enable-accelerated-compositing-for-overflow-scroll
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
LayoutTests:
Updated the test expectations for the virtual test suite to match the
usual chromium test expectations.
- platform/chromium/TestExpectations:
- 1:18 PM Changeset in webkit [137644] by
-
- 5 edits in tags/Safari-537.21/Source/WebCore
Merged r137573. <rdar://problem/12872298>
- 1:18 PM Changeset in webkit [137643] by
-
- 2 edits in trunk/Tools
delete extraneous self.fail in mastercfg_unittest.py
https://bugs.webkit.org/show_bug.cgi?id=104940
Reviewed by Eric Seidel.
This was accidentally introduced in r137404.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 12:56 PM Changeset in webkit [137642] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r137406): NodeTraversal changes causing large renderer crash
https://bugs.webkit.org/show_bug.cgi?id=104937
Reviewed by Antti Koivisto.
Add a null pointer check to exit early since ElementTraversal::next assumes a non-null pointer.
No new tests since I don't think this function is ever exposed to any ES5 bindings.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
- 12:54 PM Changeset in webkit [137641] by
-
- 14 edits in tags/Safari-537.21
Merged r137607. <rdar://problem/12815054>
- 12:53 PM Changeset in webkit [137640] by
-
- 6 edits in trunk/Source/WebKit2
Get rid of DownloadManager::shared
https://bugs.webkit.org/show_bug.cgi?id=104939
Reviewed by Andreas Kling.
Move the DownloadManager singleton to WebProcess and stub out a DownloadManager::Client class.
- WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::DownloadManager):
- WebProcess/Downloads/DownloadManager.h:
(Client):
(WebKit::DownloadManager::Client::~Client):
(DownloadManager):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertHandleToDownload):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadManager):
(WebKit):
(WebKit::WebProcess::shouldTerminate):
(WebKit::WebProcess::downloadRequest):
(WebKit::WebProcess::cancelDownload):
(WebKit::WebProcess::startTransfer):
- WebProcess/WebProcess.h:
(WebProcess):
- 12:50 PM Changeset in webkit [137639] by
-
- 4 edits in tags/Safari-537.21/Source/WebCore
Merged r137604. <rdar://problem/12815054>
- 12:46 PM Changeset in webkit [137638] by
-
- 2 edits in trunk/LayoutTests
This test started failing after http://trac.webkit.org/changeset/137592 which
rolled out a patch that touched these results. I am going to re-set the results
for now so that the test will pass, and make a note in the bug.
- platform/mac/accessibility/internal-link-anchors2-expected.txt:
- 12:44 PM Changeset in webkit [137637] by
-
- 3 edits in trunk/Source/WebKit2
[WebKit2] Only register NSNotificationCenter observers once per WebContext
https://bugs.webkit.org/show_bug.cgi?id=104879
Reviewed by Alexey Proskuryakov.
WebContext was mistakenly registering NSNotificationCenter observers
every time a new web process was created. In a multi-WebProcess world,
this caused duplicate observers to be needlessly registered. Fix this
by registering observers at WebContext creation time (and fix a related
bug where two of the observers were never unregistered).
- UIProcess/WebContext.h:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitialize): Register observers when initializing the context.
(WebKit::WebContext::platformInitializeWebProcess): Don't register observers here.
(WebKit::WebContext::platformInvalidateContext): Unregister observers when invalidating the context.
(WebKit::WebContext::registerNotificationObservers):
(WebKit::WebContext::unregisterNotificationObservers):
- 12:11 PM Changeset in webkit [137636] by
-
- 4 edits in trunk/Source/WebKit2
Download objects should keep track of their associated DownloadManager object
https://bugs.webkit.org/show_bug.cgi?id=104936
Reviewed by Andreas Kling.
This is the first step towards eliminating DownloadManager::shared.
- WebProcess/Downloads/Download.cpp:
(WebKit::Download::create):
(WebKit::Download::Download):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
- WebProcess/Downloads/Download.h:
- WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
- 12:10 PM Changeset in webkit [137635] by
-
- 10 edits in trunk
IndexedDB: Improve error messages
https://bugs.webkit.org/show_bug.cgi?id=104624
Reviewed by Tony Chang.
Source/WebCore:
Add detail to error messages so that they are more helpful and can be
traced back to a specific line of code.
Updated test: transaction-error.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::open):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::perform):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
LayoutTests:
Updated error message and establish that non-ascii characters in index
names don't make it back to the browser properly.
- storage/indexeddb/resources/shared.js:
(unexpectedAbortCallback):
- storage/indexeddb/resources/transaction-error.js:
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded.trans.onabort):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded):
(testErrorFromCommit.trans.oncomplete):
(testErrorFromCommit):
- storage/indexeddb/transaction-error-expected.txt:
- storage/indexeddb/transaction-error.html:
- 12:07 PM Changeset in webkit [137634] by
-
- 3 edits in trunk/Tools
Fix a mis-named variable after r137621.
https://bugs.webkit.org/show_bug.cgi?id=104871
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_results):
- Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
- 11:51 AM Changeset in webkit [137633] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Safeguard against possible NULL-dereference
https://bugs.webkit.org/show_bug.cgi?id=104931
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-12-13
Reviewed by Chris Fleizach.
This was spotted by Coverity. See bug 104114.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetIndexInParent): If parent is NULL
bail out early.
- 11:48 AM Changeset in webkit [137632] by
-
- 3 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderBlock::finishDelayUpdateScrollInfo
https://bugs.webkit.org/show_bug.cgi?id=103750
Reviewed by Tony Chang.
Source/WebCore:
MathML sometimes creates and destroys renderers for descendants during layout (or even to calculate
preferred logical widths), e.g. for operator stretching. RenderBlock::finishDelayUpdateScrollInfo
must therefore leave gDelayedUpdateScrollInfoSet intact as it iterates over it, so
RenderBlock::willBeDestroyed can call gDelayedUpdateScrollInfoSet->remove(this) effectively if needed.
This also prevents duplicate entries from being added to gDelayedUpdateScrollInfoSet.
Test: mathml/mo-stretch-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::startDelayUpdateScrollInfo):
- Allow gDelayedUpdateScrollInfoSet to be non-null when gDelayUpdateScrollInfo is 0 during RenderBlock::finishDelayUpdateScrollInfo.
(WebCore::RenderBlock::finishDelayUpdateScrollInfo):
- Remove blocks from gDelayedUpdateScrollInfoSet one at a time, waiting for each block until it is about to be updated.
LayoutTests:
- mathml/mo-stretch-crash-expected.txt: Added.
- mathml/mo-stretch-crash.html: Added.
- 11:46 AM Changeset in webkit [137631] by
-
- 2 edits in trunk/Source/WebCore
ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client
https://bugs.webkit.org/show_bug.cgi?id=104935
<rdar://problem/12870361>
Reviewed by Anders Carlsson.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): The handle is null when NetworkProcess is used. In any case, it should be correct to use the client carried within AuthenticationChallenge.
- 11:32 AM Changeset in webkit [137630] by
-
- 3 edits1 add in trunk
.: Added manual test for canvas setFont speed.
https://bugs.webkit.org/show_bug.cgi?id=104923
Reviewed by James Robinson.
- ManualTests/canvas-font-speed.html: Added.
Source/WebCore: CanvasRenderingContext2D::setFont() is slow.
https://bugs.webkit.org/show_bug.cgi?id=104923
Reviewed by James Robinson.
This spends most of its time in the CSS parser. As a first step,
early-out if the new value is the same as unparsed string for the current font.
See also http://code.google.com/p/chromium/issues/detail?id=164016.
Covered by existing tests in canvas/ and fast/canvas, and ManualTests/canvas-font-speed.html.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- 11:26 AM Changeset in webkit [137629] by
-
- 6 edits in branches/safari-536.28-branch/Source/WebKit2
Rollout r133937. <rdar://problem/12516369>
- 11:23 AM Changeset in webkit [137628] by
-
- 9 edits in branches/safari-536.28-branch
- 11:23 AM Changeset in webkit [137627] by
-
- 6 edits in trunk/Source
Allow plugins to be disabled by shared library filename
https://bugs.webkit.org/show_bug.cgi?id=101274
Patch by Parth Patel <parpatel@rim.com>, Max Feil <mfeil@rim.com> on 2012-12-13
Reviewed by Antonio Gomes.
Source/WebCore:
This fix makes PluginDatabase changes general so that other ports
can use this mechanism if they wish.
Layout test not included with this patch because there
is currently no framework within LayoutTests to allow calls
from an external application via platform API code (such as the
WebView API).
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::fileExistsAndIsNotDisabled):
(WebCore):
(WebCore::PluginDatabase::getDeletedPlugins):
(WebCore::PluginDatabase::removeDisabledPluginFile):
(WebCore::PluginDatabase::addDisabledPluginFile):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
- plugins/PluginDatabase.h:
(PluginDatabase):
Source/WebKit/blackberry:
Mechanism allows plugins to be disabled by specifying their shared library filenames.
Once disabled, a plugin's shared library should never be loaded.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
(WebKit):
(BlackBerry::WebKit::WebPage::updateDisabledPluginFiles):
- Api/WebPage.h:
- 11:16 AM Changeset in webkit [137626] by
-
- 32 edits2 deletes in branches/safari-536.28-branch
Rollout r133946. <rdar://problem/12516369>
- 11:13 AM Changeset in webkit [137625] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Rollout r133947. <rdar://problem/12516350>
- 11:11 AM Changeset in webkit [137624] by
-
- 10 edits3 deletes in branches/safari-536.28-branch
Rollout r133949. <rdar://problem/12516352>
- 11:11 AM Changeset in webkit [137623] by
-
- 2 edits in trunk/PerformanceTests
[chromium perf] DOM/DOMWalk.html failures
https://bugs.webkit.org/show_bug.cgi?id=104866
Reviewed by Eric Seidel.
Use PerfTestRunner.now which in turn uses window.performance.now() when it's available.
- DOM/resources/dom-perf.js:
(Interval.start):
(Interval.stop):
(BenchmarkSuite.prototype.RunSingle):
- 11:07 AM Changeset in webkit [137622] by
-
- 6 edits2 deletes in branches/safari-536.28-branch
Rollout r133969. <rdar://problem/12665292>
- 11:05 AM Changeset in webkit [137621] by
-
- 11 edits1 move in trunk/Tools
webkitpy: rename ResultSummary
https://bugs.webkit.org/show_bug.cgi?id=104871
Reviewed by Eric Seidel.
This patch changes the names of ResultSummary and related modules,
classes, and variables as a part of the larger clean up in bug 103824.
This change is basically a bunch of search and replaces:
- result_summary.py -> test_run_results.py
- class ResultSummary -> class TestRunResults
- "result_summary" or "rs" as a generic variable name -> "run_results", when it doesn't matter (or we don't know) if this refers to the initial pass over the tests or the retry pass.
- "result_summary" as a variable containing the results of the initial, complete test run -> "initial_results"
- "retry_summary" as a variable containing the results of retried results -> "retry_results"
- ResultSummary.results (the property) -> TestRunResults.results_by_name
- ResultSummary.failures (the property) -> TestRunResults.failures_by_name
- RunDetails.result_summary -> RunDetails.initial_results
- RunDetails.retry_summary -> RunDetails.retry_results
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner._mark_interrupted_tests_as_skipped):
(LayoutTestRunner._interrupt_if_at_failure_limits):
(LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
(LayoutTestRunner._update_summary_with_result):
(LayoutTestRunner._handle_finished_test):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(FakePrinter.print_expected):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
(LayoutTestRunnerTests.test_update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(RunDetails.init):
(summarize_results):
(Manager.run):
(Manager._look_for_new_crash_logs):
(Manager._tests_to_retry):
(Manager._upload_json_files):
(Manager._stats_trie):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_look_for_new_crash_logs):
(SummarizeResultsTest):
(SummarizeResultsTest.get_run_results):
(SummarizeResultsTest.summarized_results):
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.init):
(JSONLayoutResultsGenerator._get_modifier_char):
(JSONLayoutResultsGenerator._insert_failure_summaries):
(JSONLayoutResultsGenerator._get_failure_summary_entry):
- Scripts/webkitpy/layout_tests/models/test_run_results.py: Renamed from Tools/Scripts/webkitpy/layout_tests/models/result_summary.py.
(TestRunResults):
(TestRunResults.init):
(TestRunResults.add):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(get_test_results):
(MainTest.test_basic):
- Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_results):
(BuildBotPrinter.print_run_results):
(BuildBotPrinter._print_run_results_entry):
- Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
(BuildBotPrinterTests.get_run_results):
(BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
(BuildBotPrinterTests):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_expected):
(Printer._print_expected_results_of_type):
(Printer.print_results):
(Printer._print_timing_statistics):
(Printer._print_worker_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_directory_timings):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
- 11:04 AM Changeset in webkit [137620] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Rollout r134109. <rdar://problem/12516330>
- 11:02 AM Changeset in webkit [137619] by
-
- 4 edits in trunk/LayoutTests
[GTK] accessibiltiy/aria-hidden.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98352
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-13
Reviewed by Martin Robinson.
The test is failing due to platform differences in the implementation of
AccessibilityUIElement::allAttributes(). This test does not require this
method as it is only looking at the AXTitle attribute.
- accessibility/aria-hidden-expected.txt: Included the actual reason for
passing/failing in the results output.
- accessibility/aria-hidden.html: Included the actual reason for passing/
failing in the results output.
- platform/gtk/TestExpectations: Unskipped the failing test.
- 11:02 AM Changeset in webkit [137618] by
-
- 8 edits3 deletes in branches/safari-536.28-branch
Rollout r134834. <rdar://problem/12516304>
- 10:55 AM Changeset in webkit [137617] by
-
- 10 edits2 deletes in branches/safari-536.28-branch
Rollout r134991. <rdar://problem/12516313>
- 10:52 AM Changeset in webkit [137616] by
-
- 4 edits in trunk/Source
Check whether a touchDown lands on a registered touch event handler from the compositor
https://bugs.webkit.org/show_bug.cgi?id=104863
Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-12-13
Reviewed by James Robinson.
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
- 10:48 AM Changeset in webkit [137615] by
-
- 2 edits in trunk/Source/WebCore
Document will never be released when an Image is created inside unload event listener
https://bugs.webkit.org/show_bug.cgi?id=104830
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-12-13
Reviewed by Darin Adler.
When setting src attribute to an Image object inside unload event listener, ImageLoader will
mark it as load failure (by setting m_hasPendingErrorEvent to true) and the following call
to updatedHasPendingEvent will ref the element but won't be deref-ed since the Document is
being dismissed. This was introduced in r131670. To match pre r131670 behavior, we shouldn't
trigger error event for image loading when the page is being dismissed.
No new tests, there is no visual change. Manually tested to verify documents are released by
using heap in Mac OS X.
- loader/ImageLoader.cpp:
(WebCore::pageIsBeingDismissed): add a helper function to test whether the page is being dismissed.
(WebCore::ImageLoader::updateFromElement): don't trigger error event if the page is being dismissed.
- 10:47 AM Changeset in webkit [137614] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Add missing breaks in switch-case statements
https://bugs.webkit.org/show_bug.cgi?id=104929
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-12-13
Reviewed by Martin Robinson.
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::clearData): Add missing breaks.
- 10:44 AM Changeset in webkit [137613] by
-
- 11 edits in trunk/Source/WebKit2
Remove unused initiatingPage parameter from download objects
https://bugs.webkit.org/show_bug.cgi?id=104933
Reviewed by Alexey Proskuryakov.
- WebProcess/Downloads/Download.h:
(Download):
- WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
- WebProcess/Downloads/DownloadManager.h:
(DownloadManager):
- WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
- WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
- WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
- WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
- WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertHandleToDownload):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadRequest):
- 10:39 AM Changeset in webkit [137612] by
-
- 4 edits in trunk/Tools
[EFL] The WebKit2 bots are building and executing WebKit1 tests
https://bugs.webkit.org/show_bug.cgi?id=104690
Reviewed by Csaba Osztrogonác.
Pass --no-webkit1 option to the EFL WK2 bots when building. This
will disable WK1 API and thus, the WK1 API tests.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit2Only):
(BuildAndTestFactory):
(BuildAndTestFactory.init):
(BuildAndTestWebKit2OnlyFactory):
Now bots using BuildAndTestWebKit2OnlyFactory (for instance only EFL) will
get --no-webkit1 as a parameter on the build-webkit script.
- Scripts/build-webkit:
Added support for -no-webkit1 for the Qt and EFL port.
- 10:34 AM Changeset in webkit [137611] by
-
- 2 edits in trunk/Tools
build-webkit --chromium-android forces Make even when update-webkit used --ninja
https://bugs.webkit.org/show_bug.cgi?id=104839
Reviewed by Tony Chang.
This was recommended by Peter as part of:
https://bugs.webkit.org/show_bug.cgi?id=104434#c4
Fixing this makes build-webkit --chromium-android work for the common (ninja) case.
- Scripts/webkitdirs.pm:
(buildChromium):
- 10:32 AM Changeset in webkit [137610] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/12870065> Frequent NetworkProcess crashes due to null connection when closing tabs
https://bugs.webkit.org/show_bug.cgi?id=104922
Reviewed by Anders Carlsson.
Don't zero out connection pointers when a connection closes. There doesn't appear
to be any reason to do this.
Tested by hitting breakpoints in all relevant objects destructors to confirm that
this doesn't introduce leaks.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess): (WebKit::NetworkConnectionToWebProcess::didClose):
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
- 10:32 AM Changeset in webkit [137609] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Update chromium expectatins for fonts/monospace.html
- platform/chromium/TestExpectations:
- 10:30 AM Changeset in webkit [137608] by
-
- 17 edits2 deletes in branches/chromium/1359
and now revert the manual merge for another build
- 10:27 AM Changeset in webkit [137607] by
-
- 14 edits in trunk
Route main resource loads through the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=49246
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Note that this patch doesn't actually enable caching of main resources. That will be done in a later patch.
The MainResourceLoader actually has an underlying SubresourceLoader (with the cache layer between them).
In several places, the MainResourceLoader's SubresourceLoader is treated as special.
No new tests, as this is primarily a refactor. A couple of expected results changed slightly.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setRequest):
(WebCore::DocumentLoader::subresource):
(WebCore::DocumentLoader::addSubresourceLoader): Because the SubresourceLoader underlying the main resource
needs special handling in certain cases, track it separately from the real SubresourceLoaders.
(WebCore::DocumentLoader::removeSubresourceLoader):
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::cancel):
(WebCore::MainResourceLoader::clearResource):
(WebCore):
(WebCore::MainResourceLoader::frameLoader):
(WebCore::MainResourceLoader::request):
(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::notifyFinished):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::setDefersLoading):
(WebCore::MainResourceLoader::defersLoading):
(WebCore::MainResourceLoader::setShouldBufferData):
(WebCore::MainResourceLoader::loader):
(WebCore::MainResourceLoader::identifier):
- loader/MainResourceLoader.h:
(MainResourceLoader):
(WebCore::MainResourceLoader::documentLoader):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::defersLoading):
(WebCore::ResourceLoader::cancelled):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError):
- loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):
LayoutTests:
- http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: The error code for loads cancelled
by an embedder's willSendRequest() will show as standard load cancellations rather than as a content policy
failure. This was an odd quirk of how MainResourceLoader::willSendRequest() was implemented (namely, doing a
content policy check on ResourceRequests with empty urls).
- platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
- platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: The error code for loads cancelled
by an embedder's willSendRequest() will show as standard load cancellations rather than as a content policy
failure. This was an odd quirk of how MainResourceLoader::willSendRequest() was implemented (namely, doing a
content policy check on ResourceRequests with empty urls).
- 10:16 AM Changeset in webkit [137606] by
-
- 2 edits in trunk/Source/WebCore
Duplicate code in GraphicsContext3D::validateAttributes() and GraphicsContext3D::validateDepthStencil()
https://bugs.webkit.org/show_bug.cgi?id=97275
Reviewed by Dean Jackson.
Remove duplicate code in validateAttributes(). validateAttributes() calls
validateDepthStencil() which has the exact same code.
No new tests because no change in functionality.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
- 9:41 AM Changeset in webkit [137605] by
-
- 1 edit1 delete in trunk/Source/WebKit2
[EFL] Update the way we set the cookies policy
https://bugs.webkit.org/show_bug.cgi?id=104915
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-12-13
Reviewed by Kenneth Rohde Christiansen.
We are mistakenly assigning the cookie policy to the persistent storage
type which is not correct. This was caused by r137432 and is making
the unit tests fail.
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- 9:37 AM Changeset in webkit [137604] by
-
- 4 edits in trunk/Source/WebCore
CachedResources should hang on to stripped fragment identifiers
https://bugs.webkit.org/show_bug.cgi?id=104721
Reviewed by Maciej Stachowiak.
No new tests, this will be unused until bug
https://bugs.webkit.org/show_bug.cgi?id=49246 re-lands. Then, it will
allow http/tests/inspector/resource-parameters.html to continue passing.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):
- loader/cache/CachedResource.h:
(CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource): We override the request's url with the
local variable "url" here. The only difference between url and request.url() is that url
has had any fragment identifier removed. Do this work later (in the CachedResource constructor)
so that the CachedResource can save the fragment for later.
- 9:18 AM Changeset in webkit [137603] by
-
- 17 edits2 copies in branches/chromium/1359
hand merge patch for Chromium build
- 9:13 AM Changeset in webkit [137602] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove deprecated API usage
https://bugs.webkit.org/show_bug.cgi?id=104894
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-12-13
Reviewed by Martin Robinson.
Remove deprecated GTK+ API usage.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize): Do not use deprecated
gtk_style_context_get_font().
- 9:13 AM Changeset in webkit [137601] by
-
- 1 copy in branches/chromium/1359
Quick branch to pick up new fix.
- 9:10 AM Changeset in webkit [137600] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove temporary workaround from GraphicsSurfaceGLX constructor.
https://bugs.webkit.org/show_bug.cgi?id=104904
QXcbNativeInterface::nativeResourceForContext() is now
available in Qt5. Therefore the temporary workaround
in GraphicsSurfaceGLX can be removed.
Reviewed by Kenneth Rohde Christiansen.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
- 9:08 AM Changeset in webkit [137599] by
-
- 2 edits in trunk/Tools
Loader_unittests should reset state between runs.
https://bugs.webkit.org/show_bug.cgi?id=104862
Reviewed by Dirk Pranke.
The loader_unittests were not resetting state between runs, leaving
a lot of data behind in global objects that the dashboard and tests
rely on. A handful were resetting just a few objects. Use the common
resetGlobals() method instead.
- TestResultServer/static-dashboards/loader_unittests.js:
- 8:26 AM Changeset in webkit [137598] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Update the way we set the cookies policy
https://bugs.webkit.org/show_bug.cgi?id=104915
Reviewed by Kenneth Rohde Christiansen.
We are mistakenly assigning the cookie policy to the persistent storage
type which is not correct. This was caused by r137432 and is making
the unit tests fail.
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- 8:08 AM Changeset in webkit [137597] by
-
- 11 edits in trunk
[Qt][WK2] Fix painting on Mac with retina display
https://bugs.webkit.org/show_bug.cgi?id=104574
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Since HiDPI support has been added and enabled in Qt we ended up
painting incorrectly scaled content on high-resolution screens.
Because the intrinsic device pixel ratio is always taken into
account by Qt when painting to high-resolution screens we should
automatically obtain the scale ratio from the window in which the
item is rendered instead of setting it in QML.
Qt does not make it possible to override the device pixel ratio
of the native window, therefore our experimental QML API for setting
a custom value is of no use any more and should be removed.
This patch fixes the scaling issue on Mac retina display by querying
the underlying window for the device scale factor and applying it to
the backing store and the scene-graph rendering of the content node.
Additionally removes the experimental API and related API tests.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::newWebView):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHostProxy::deviceScaleFactor):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::ContentsSGNode):
(WebKit::ContentsSGNode::render):
(WebKit::ContentsSGNode::clipRect):
(ContentsSGNode):
(WebKit::QtWebPageSGNode::QtWebPageSGNode):
(WebKit::QtWebPageSGNode::devicePixelRatio):
(WebKit):
(WebKit::QtWebPageSGNode::setRenderer):
- UIProcess/qt/QtWebPageSGNode.h:
(QtWebPageSGNode):
Tools:
Remove setting the devicePixelRatio experimental property
since the value is now automatically picked up from Qt.
- MiniBrowser/qt/qml/BrowserWindow.qml:
- 7:43 AM Changeset in webkit [137596] by
-
- 4 edits1 add in trunk
[GTK] Expose ARIA roles for tab, tabpanel and tablist
https://bugs.webkit.org/show_bug.cgi?id=84043
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-13
Reviewed by Martin Robinson.
Source/WebCore:
Mapped the ARIA roles to their corresponding ATK roles.
No new tests; instead unskipped the associated test.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Mapped the ARIA roles to their corresponding ATK roles
LayoutTests:
Mapped the ARIA roles to the corresponding ATK roles and unskipped the
associated test. Also created the missing platform-specific expected
results.
- accessibility/aria-tab-roles-expected.txt: Added.
- platform/gtk/TestExpectations: Unskipped the associated test.
- 7:34 AM Changeset in webkit [137595] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] API tests failing because Vibration API is using unsigned as duration since r137410
https://bugs.webkit.org/show_bug.cgi?id=104914
Reviewed by Kenneth Rohde Christiansen.
Update the tests to reflect the data type coming from WebCore.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(VibrationCbData):
(onVibrate):
- 7:24 AM Changeset in webkit [137594] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: "Add Attribute" context menu on closing tag should apply on the opening tag on Elements Panel
https://bugs.webkit.org/show_bug.cgi?id=104902
Reviewed by Alexander Pavlov.
The context menu action on the closing tag scrolls to the opening tag for adding the attribute.
No new tests as this is a UI change.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._addNewAttribute):
- 7:09 AM Changeset in webkit [137593] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Device pixel ratio lost upon relaunch of the web process
https://bugs.webkit.org/show_bug.cgi?id=104913
Reviewed by Simon Hausmann.
Use setIntrinsicDeviceScaleFactor instead of setCustomDeviceScaleFactor
when setting the device pixel ratio to make the setting permanent and
make sure it is set as part of the web process creation parameters.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_device_pixel_ratio_set):
- 7:09 AM Changeset in webkit [137592] by
-
- 13 edits2 deletes in trunk
Unreviewed, rolling out r137512.
http://trac.webkit.org/changeset/137512
https://bugs.webkit.org/show_bug.cgi?id=104912
The entire GTK+ layout test step has been failing for hours
(Requested by mrobinson on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-13
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
LayoutTests:
- accessibility/button-title-uses-inner-img-alt-expected.txt: Removed.
- accessibility/button-title-uses-inner-img-alt.html: Removed.
- accessibility/focusable-div-expected.txt:
- accessibility/focusable-div.html:
- platform/chromium/TestExpectations:
- platform/chromium/accessibility/image-link-expected.txt:
- platform/mac/accessibility/image-link-expected.txt:
- platform/mac/accessibility/internal-link-anchors2-expected.txt:
- platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt:
- platform/mac/accessibility/static-text-role-uses-text-under-element.html:
- platform/mac/accessibility/table-with-aria-role-expected.txt:
- 7:06 AM Changeset in webkit [137591] by
-
- 5 edits1 add in trunk/Source/WebCore
OpenCL version of FEColorMatrix.
https://bugs.webkit.org/show_bug.cgi?id=103398
Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2012-12-13
Reviewed by Zoltan Herczeg.
~3x speed-up (depending on hardware configuration)
- Target.pri: Added a new file to the build system.
- platform/graphics/filters/FEColorMatrix.cpp: calculateSaturateComponents and calculateHueRotateComponents methodes are moved to the header, since they are used by OpenCL as well
(WebCore::effectType):
- platform/graphics/filters/FEColorMatrix.h:
(FEColorMatrix):
(WebCore::FEColorMatrix::calculateSaturateComponents):
(WebCore):
(WebCore::FEColorMatrix::calculateHueRotateComponents):
- platform/graphics/gpu/opencl/FilterContextOpenCL.h: Required fields for the ColorMatrix kernels were added
(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):
- platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp: the core implementation goes here
(WebCore):
(WebCore::FilterContextOpenCL::compileFEColorMatrix):
(WebCore::FilterContextOpenCL::applyFEColorMatrix):
(WebCore::FEColorMatrix::platformApplyOpenCL):
- 7:04 AM Changeset in webkit [137590] by
-
- 6 edits in trunk
[Qt] Doc: Fixing Qt WebKit reference documentation.
Patch by Jerome Pasion <jerome.pasion@digia.com> on 2012-12-13
Reviewed by Simon Hausmann.
Fixes:
-added \module for C++ classes and \qmlmodule for QML types
-added links to the Qt WebKit Examples pages
-fixed the qhp settings for Qt Creator
Task-number: QTBUG-28583
Task-number: QTBUG-28418
Task-number: QTBUG-27646
.:
- Source/qtwebkit.qdocconf:
Source/WebKit/qt:
- docs/qtwebkit.qdoc:
Source/WebKit2:
- UIProcess/API/qt/qquickwebview.cpp:
- 6:23 AM Changeset in webkit [137589] by
-
- 12 edits in trunk/Source
Web Inspector: Native Memory Instrumentation: do not validate pointers to objects in RenderArena agains tcmalloc data.
https://bugs.webkit.org/show_bug.cgi?id=104903
Reviewed by Yury Semikhatsky.
This is a simplest approach to do that with zero performance overhead.
Source/WebCore:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::reportMemoryUsage):
(WebCore):
- rendering/InlineBox.h:
(InlineBox):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::reportMemoryUsage):
(WebCore):
- rendering/InlineTextBox.h:
(InlineTextBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::reportMemoryUsage):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::reportMemoryUsage):
Source/WTF:
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryClassInfo::setCustomAllocation):
(WTF):
- wtf/MemoryInstrumentation.h:
(MemoryClassInfo):
- wtf/MemoryObjectInfo.h:
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::customAllocation):
(WTF::MemoryObjectInfo::setCustomAllocations):
(MemoryObjectInfo):
- 6:21 AM Changeset in webkit [137588] by
-
- 8 edits in trunk
[EFL][GTK] Don't call deprecated g_type_init when glib => 2.35
https://bugs.webkit.org/show_bug.cgi?id=103209
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-13
Reviewed by Kenneth Rohde Christiansen.
g_type_init() is deprecated from 2.35.0 onwards. Don't call it
in that case to avoid warnings and/or build failure.
Source/WebKit/efl:
- ewk/ewk_main.cpp:
(_ewk_init_body):
Source/WebKit2:
Also, remove a call to g_type_init() from WebProcessMainGtk():
It is not needed if gtk_init() is called.
- UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
Tools:
- DumpRenderTree/gtk/ImageDiff.cpp:
(main):
- 6:02 AM Changeset in webkit [137587] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Don't leak GStaticRecMutex
https://bugs.webkit.org/show_bug.cgi?id=104901
Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-13
Reviewed by Martin Robinson.
The mutex in WebKitWebAudioSourceGStreamer is allocated using
g_new(), but that memory is not freed when the object is
destroyed.
This patch replaces that pointer with the structure itself, which
is faster and doesn't need to be explicitly freed.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(_WebKitWebAudioSourcePrivate):
(webkit_web_audio_src_init):
(webKitWebAudioSrcFinalize):
- 5:20 AM Changeset in webkit [137586] by
-
- 1 edit9 adds in trunk/LayoutTests
Unreviewed. Rebaselined compositor-touch-hit-rects.html.
- platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Added.
- platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Added.
- platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Added.
- 5:05 AM Changeset in webkit [137585] by
-
- 8 edits in trunk
Web Inspector: Network: Sorting cookies by size is broken.
https://bugs.webkit.org/show_bug.cgi?id=104893
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-13
Reviewed by Alexander Pavlov.
Source/WebCore:
Problem: cookie "size" is not a field now; its value is accessible
through getter method.
Solution: make cookie fields uniformly accessible (add getters for name,
type and value).
- inspector/front-end/CookieItemsView.js: Adopt changes.
- inspector/front-end/CookieParser.js:
(WebInspector.Cookie): Refine JsDoc.
(WebInspector.Cookie.prototype.name): Added getter.
(WebInspector.Cookie.prototype.value): Ditto.
(WebInspector.Cookie.prototype.type): Ditto.
(WebInspector.Cookies.buildCookiesFromString): Adopt changes.
(WebInspector.Cookies.buildCookieProtocolObject): Ditto.
- inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable): Remove unused parameter.
(WebInspector.CookiesTable.prototype._sortCookies):
Use getters instead of field names.
(WebInspector.CookiesTable.prototype._createGridNode): Adopt changes.
- inspector/front-end/HAREntry.js: Ditto.
- inspector/front-end/RequestCookiesView.js: Ditto.
LayoutTests:
Adopt new cookie field accessors.
- inspector/cookie-parser.html: Adopt new cookie field accessors.
- 4:50 AM Changeset in webkit [137584] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r137569.
http://trac.webkit.org/changeset/137569
https://bugs.webkit.org/show_bug.cgi?id=104876
A bunch of CSS tests hit ASSERTs
- css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
- 4:02 AM Changeset in webkit [137583] by
-
- 3 edits in trunk/Tools
[Tools] Add exception for gtk_style_context_get()
https://bugs.webkit.org/show_bug.cgi?id=104896
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-12-13
Reviewed by Martin Robinson.
Add new exception for gtk_style_context_get().
- Scripts/webkitpy/style/checkers/cpp.py:
(check_for_null): Add exception for gtk_style_context_get().
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_null_false_zero): Add a unit
test for the new exception.
- 3:28 AM Changeset in webkit [137582] by
-
- 2 edits in trunk/Source/WebKit/efl
Regression(r137568): Broke layout test on EFL WK1
https://bugs.webkit.org/show_bug.cgi?id=104895
Reviewed by Kenneth Rohde Christiansen.
Fix layout test crash after r137568 because ewk_view.cpp has kept unused networkInfoClient member variable
using OwnPtr. The r137568 lets NetworkInfoClientEfl destroy by WebCore::NetworkInfoController.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
- 3:10 AM Changeset in webkit [137581] by
-
- 5 edits in trunk
REGRESSION (r137432): The /webkit2/WebKitCookieManager/accept-policy unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=104790
Patch by Joaquim Rocha <jrocha@igalia.com> on 2012-12-13
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
The cookies accept policy and the cookies persistent storage type
were not being correctly assigned.
- UIProcess/WebContext.cpp: Set the default value of the cookie
accept policy.
(WebKit::WebContext::WebContext):
- UIProcess/gtk/WebContextGtk.cpp: Fix setting the cookies persistent
storage type (it was mistakenly assigning the policy instead) and
set the accept policy which was missing.
(WebKit::WebContext::platformInitializeWebProcess):
Tools:
Unskip the GTK accept policy test.
- Scripts/run-gtk-tests:
(TestRunner):
- 3:00 AM Changeset in webkit [137580] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Remove redundant pipe write to prevent pipe buffer full.
https://bugs.webkit.org/show_bug.cgi?id=101135
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-12-13
Reviewed by Gyuyoung Kim.
To prevent a source of a deadlock, remove the redundant pipe write
in wakeUp() function.
EFL uses ecore_pipe_write() to wake up main run loop, and the function
uses POSIX pipe write with O_NONBLOCK disabled.
With O_NONBLOCK disabled, when written data is more than PIPE_BUF,
pipe write will be blocked until it can be written.
Currently, every wakeUp() function calls ecore_pipe_write() to invoke
wakeUpEvent() callback. And this can make pipe buffer full status
which is the one reason of the lockup problem described in Bug 99494.
- platform/RunLoop.h:
(RunLoop):
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):
- 2:56 AM Changeset in webkit [137579] by
-
- 2 edits in trunk
[Qt] Fix missing doc dependency to examples
Patch by Jerome Pasion <Jerome.Pasion@digia.com> on 2012-12-13
Reviewed by Simon Hausmann.
- Source/qtwebkit.qdocconf:
- 2:27 AM Changeset in webkit [137578] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix deleteAllCookies() invalid SQL statement
https://bugs.webkit.org/show_bug.cgi?id=101580
Patch by Antti Harju <antti.harju@ixonos.com> on 2012-12-13
Reviewed by Jocelyn Turcotte.
- platform/network/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::deleteAllCookies):
- 2:18 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 2:09 AM Changeset in webkit [137577] by
-
- 2 edits in trunk/Source/WebCore
Safari spends a lot of time in WebCore::findSimpleWordBoundary while selecting text on large scrabutility.com page
https://bugs.webkit.org/show_bug.cgi?id=104884
Reviewed by Hajime Morita.
We don't need to do anything in AlternativeTextController if selection is already outside of the editable region.
No new tests are added since this is only a performance improvement, and doesn't change any asymptotic behavior.
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::respondToChangedSelection):
- 1:42 AM Changeset in webkit [137576] by
-
- 2 edits in trunk/LayoutTests
[Mac][WK2] Unreviewed, spelling-unified-emulation.html fails after 137571
Replace the "zzz" word with "buzz" for mac-wk2.
- platform/mac-wk2/editing/spelling/spelling-unified-emulation-expected.txt:
Change-Id: I6434a60e9dc1aab9abda218977255f8649468aa2
- 1:29 AM Changeset in webkit [137575] by
-
- 2 edits in trunk/Source/WebKit2
plugin snapshotting accepts bad snapshot after 5 seconds
https://bugs.webkit.org/show_bug.cgi?id=104886
<rdar://problem/12838753>
Reviewed by Maciej Stachowiak.
- WebProcess/Plugins/PluginView.cpp: Increase to 60 tries, equating to a little over 60 seconds total.
- 1:26 AM Changeset in webkit [137574] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to committers list.
- Scripts/webkitpy/common/config/committers.py:
- 1:19 AM EFLWebKit edited by
- (diff)
- 12:42 AM Changeset in webkit [137573] by
-
- 5 edits in trunk/Source/WebCore
Crash in PlugInOriginHash with empty MIME type (104882)
https://bugs.webkit.org/show_bug.cgi?id=104882
<rdar://problem/12872298>
Reviewed by Filip Pizlo.
The crash occurs because the strings might be null. Add a check for it, but also try to infer a MIME type
in case the markup does not include a type attribute, but we can find it from the extension in the URL.
- platform/KURL.cpp: Add a new function mimeTypeFromURL() which tries to return the implied MIME type
based on the URL provided. If nothing was found, return a null string.
(WebCore::mimeTypeFromURL): Factored out from FrameLoader::defaultObjectContentType().
- platform/KURL.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType): Refactor to use mimeTypeFromURL().
- plugins/PlugInOriginHash.cpp:
(WebCore::addCaseFoldedCharacters): Add a check for an empty string.
(WebCore::PlugInOriginHash::hash): If the service type is empty, try to infer the MIME type.
- 12:29 AM Changeset in webkit [137572] by
-
- 2 edits in trunk/Source/WebCore
Regression(r137486): Broke EFL build
https://bugs.webkit.org/show_bug.cgi?id=104883
Unreviewed EFL build fix.
Fix EFL build break after r137486 due to missing WebCore::
namespace.
No new tests, no behavior change for layout tests.
- platform/NotImplemented.h:
