Context Navigation

← Previous Period
Next Period →

Timeline

Dec 15, 2012:

8:41 PM Changeset in webkit [137834] by vollick@chromium.org

2 edits in trunk/LayoutTests

[chromium] More expectations updates for composited scrolling.

Unreviewed change. Updating expectations.

Added expectations for a remaining test that needs a new baseline.

platform/chromium/TestExpectations:

8:03 PM Changeset in webkit [137833] by vollick@chromium.org

2 edits in trunk/LayoutTests

[chromium] More expectations updates for composited scrolling.

Unreviewed change. Updating expectations.

Some of the Failures noted in the last change were actually
ImageOnlyFailures, and some tests are now passing - these are
corrected in this patch.

platform/chromium/TestExpectations:

7:11 PM Changeset in webkit [137832] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Another build fix.

UIProcess/WebContext.cpp:

(WebKit::WebContext::createDownloadProxy):

6:54 PM Changeset in webkit [137831] by aestes@apple.com

11 edits in trunk/Source/WebKit2

[WebKit2] Have CustomProtocolManager and CustomProtocolManagerProxy store Connections for messaging
https://bugs.webkit.org/show_bug.cgi?id=105124

Reviewed by Anders Carlsson.

Remove CustomProtocolManagerProxy's assumption that all messages go to
a web process. Have it take a ChildProcessProxy instead and extract its
connection.

Similarly, remove CustomProtocolManager's assumption that all messages
go through a shared WebProcess. Initialize the shared CustomProtocolManager
with a Connection object instead.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess): Initialize the
shared CustomProtocolManager with the NetworkProcess's connection to
the UI process.

Shared/Network/CustomProtocols/CustomProtocolManager.h:

(WebKit::CustomProtocolManager::connection): Assert m_connection is
non-0 and return it.

Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(+[WKCustomProtocol canInitWithRequest:]): Remove an unnecessary
namespace.
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]): Ditto.
(-[WKCustomProtocol startLoading]): Send a message on the
CustomProtocolManager's connection rather than assuming there is a
shared WebProcess in our address space.
(-[WKCustomProtocol stopLoading]): Ditto.
(WebKit::CustomProtocolManager::initialize): Initialize the shared
CustomProtocolManager with a Connection and register our custom
protocol handler with NSURLProtocol.

UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:

(WebKit):
(CustomProtocolManagerProxy): Take a ChildProcessProxy* rather than a
WebProcessProxy*.

UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy): Ditto.
(WebKit::CustomProtocolManagerProxy::startLoading): Ditto.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy): Instantiate a
CustomProtocolManagerProxy for the network process.
(WebKit::NetworkProcessProxy::didReceiveMessage): Route messages of
class MessageClassCustomProtocolManagerProxy to the
CustomProtocolManagerProxy.

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Assert that we aren't
using the network process since we've received a message from a
web process's CustomProtocolManager.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Break CustomProtocolManager
initialization out into a helper function.
(WebKit::WebProcess::initializeCustomProtocolManager): Initialize our
CustomProtocolManager.

WebProcess/WebProcess.h:

6:47 PM Changeset in webkit [137830] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Happy little Qt build fix.

UIProcess/WebContext.cpp:

(WebKit::WebContext::download):

6:41 PM Changeset in webkit [137829] by vollick@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update test expectations now that we're opting into composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=105123

Unreviewed change. Updating expectations.

Added expectations for tests that need updated baselines now that
we're opting into composited scrolling.

platform/chromium/TestExpectations:

6:07 PM Changeset in webkit [137828] by vollick@chromium.org

12 edits
2 adds in trunk

Source/WebCore: [chromium] Automatically use composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=94743

Reviewed by Adrienne Walker.

We currently use the composited scrolling facilities provided by
wkb.ug/91117 if the overflow scroll block element is styled with
-webkit-overflow-scrolling: touch. Ideally, we could automatically
opt into composited scrolling if it is safe to do so. This can affect
antialiasing, so it is important that automatically opting in is only
enabled via a setting.

The way I determine if it is safe is by checking that z-ordering will
not be affected if the overflow scrollable element were promoted to a
stacking context (details below), and that clipping our scrolling
descendants will not affect rendering.

To check the first condition (that z-ordering will not be affected).
I ensure that the candidate element and all its descendants appear as a
contiguous block in the candidate's stacking context. That is, if no
other elements are 'between' any of the candidates descendants when we
sort in paint order, then we're safe. This is overly conservative,
however. We could, in future, only consider stacking problems between
elements that actually overlap.

To ensure that clipping will not cause a rendering change, I ensure
that the layer has no out of flow positioned descendant whose
containing block is not also a descendant of ours.

Test: compositing/overflow/automatically-opt-into-compositing-scrolling.html

(WebCore):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::acceleratedCompositingForOverflowScrollEnabled):
(WebCore):
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrderRecursive):
(WebCore::RenderLayer::positionNewlyCreatedOverflowControls):
(WebCore::RenderLayer::canSafelyEstablishAStackingContext):

Returns true if the RenderLayer could become a stacking context without
affecting the stacking order.

(WebCore::RenderLayer::updateDescendantDependentFlags):

We now need to keep track of out of flow positioned descendants.

(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::usesCompositedScrolling):

Returns true if the layer actually is using composited scrolling.
This function may return false, even when needsCompositedScrolling
returns true.

(WebCore::RenderLayer::needsCompositedScrolling):

This function returns true if we would like to use composited
scrolling and it is safe to turn it on.

(WebCore::RenderLayer::updateNeedsCompositedScrolling):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):

Since these could affect opting into composited scrolling, we must
request that the RenderLayerCompositor reevaluate compositing.

(WebCore::RenderLayer::updateLayerListsIfNeeded):

We call updateCanSafelyEstablishStackingContext here, if necessary.

(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

usesCompositedScrolling -> needsCompositedScrolling

(WebCore::RenderLayer::setAncestorChainHasOutOfFlowPositionedDescendant):
(WebCore::RenderLayer::dirtyAncestorChainHasOutOfFlowPositionedDescendantStatus):
(WebCore::RenderLayer::updateOutOfFlowPositioned):

Dirties and sets the out of flow positioned descendant state.

(WebCore::RenderLayer::styleChanged):

rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::hasOutOfFlowPositionedDescendant):

rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::hasUnpositionedOverflowControlsLayers):
(WebCore):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling):

rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::setShouldReevaluateCompositingAfterLayout):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEnableCompositingForOverflowScroll):

Allows enabling the setting in layout tests.

(WebCore):

testing/InternalSettings.h:

(InternalSettings):

testing/InternalSettings.idl:

LayoutTests: Automatically use composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=94743

Reviewed by Adrienne Walker.

Tests various configurations of elements to ensure that we only automatically opt into
composited scrolling when it is safe to do so.

compositing/overflow/automatically-opt-into-composited-scrolling-expected.txt: Added.
compositing/overflow/automatically-opt-into-composited-scrolling.html: Added.
platform/chromium/TestExpectations: The test platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style.html is failing due to wkb.ug/103156

6:01 PM Changeset in webkit [137827] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

bindings/gobject/GNUmakefile.am: Do not dist generated DOM

bindings headers.

platform/ScrollAnimatorNone.cpp: Include PlatformGestureEvent.h

only if gesture events are enabled.

5:49 PM Changeset in webkit [137826] by ap@apple.com

2 edits in trunk/Source/WebCore

Build fix.

platform/network/FormData.cpp: (WebCore::encodeElement): (WebCore::decodeElement): (WebCore::FormData::encode): (WebCore::FormData::decode): Disambiguated encode/decode functions. I'm not quite sure why the compiler was confused, but distinct names should make the code more readable anyway.

5:31 PM Changeset in webkit [137825] by ap@apple.com

8 edits in trunk/Source

<rdar://problem/12886312> Cannot upload patches to Bugzilla (<input type=file> doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=105120

Reviewed by Sam Weinig.

Serialize HTTP body. ResourceRequest serialization cannot (and shouldn't) know about
body streams, as used with files.

Shared/Network/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::encode): (WebKit::NetworkResourceLoadParameters::decode):
Shared/WebCoreArgumentCoders.cpp: (CoreIPC::::encode):

5:26 PM Changeset in webkit [137824] by andersca@apple.com

14 edits in trunk/Source/WebKit2

Handle downloads in the network process
https://bugs.webkit.org/show_bug.cgi?id=105117

Reviewed by Sam Weinig.

Start using the download manager in the network process.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::startDownload):
Call through to the download manager.

NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Add StartDownload message.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::downloadManager):
Add "singleton" download manager.

(WebKit::NetworkProcess::didCreateDownload):
(WebKit::NetworkProcess::didDestroyDownload):
(WebKit::NetworkProcess::downloadProxyConnection):
Implement DownloadManager::Client.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
Call through to the message receiver map.

WebProcess/Downloads/Download.cpp:
WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::downloadProxyConnection):

WebProcess/Downloads/DownloadManager.h:

Rename connection to downloadProxyConnection.

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
When using the network process, send a message to it with the request that needs to be downloaded.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::downloadProxyConnection):
Return the connection to the UI process.

5:15 PM Changeset in webkit [137823] by weinig@apple.com

2 edits in trunk/Source/WebKit2

NSURLCache should be disabled in the WebProcess when using the NetworkProcess
<rdar://problem/12872266>
https://bugs.webkit.org/show_bug.cgi?id=105119

Reviewed by Alexey Proskuryakov.

Set the size of the NSURLCache to 0 (both disk and memory) in the WebProcess when using
the NetworkProcess.

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

4:42 PM Changeset in webkit [137822] by aestes@apple.com

4 edits in trunk/Source/WebKit2

[WebKit2] Register the custom protocol handler in the network process if it exists
https://bugs.webkit.org/show_bug.cgi?id=105118

Reviewed by Anders Carlsson.

Register our custom protocol handler with NSURLProtocol when starting
up the network process; do not register the custom protocol handler in
web processes if a network process is being used.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

4:22 PM Changeset in webkit [137821] by weinig@apple.com

12 edits in trunk/Source/WebKit2

The network process should use the correct NSURLCache location and set its size correctly for the CacheModel
<rdar://problem/12848505>
https://bugs.webkit.org/show_bug.cgi?id=105115

Reviewed by Anders Carlsson.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::setCacheModel):

NetworkProcess/NetworkProcess.h:

(NetworkProcess):

NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::platformInitialize):
(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::NetworkProcess::platformSetCacheModel):
Copy code from the WebProcess to set up the NSURLCache correctly (location and size).
We should eventually move the calculation of this to the WebContext so it can be done
once.

Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

Shared/Network/NetworkProcessCreationParameters.h:

(NetworkProcessCreationParameters):
Add the necessary creation parameters to set up the cache.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFinishLaunching):

UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

UIProcess/Network/mac/NetworkProcessProxyMac.mm:
UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::setCacheModel):

UIProcess/WebContext.h:

(WebKit):
(WebContext):

UIProcess/mac/WebContextMac.mm:

(WebKit):
(WebKit::WebContext::platformInitializeNetworkProcess):
Move initializing the NetworkProcess to just after creating (matching the WebProcess),
rather than waiting for it finish loading before sending the creation parameters.
Additionally, this moves the setting up of the creation parameters to the WebContext,
as that is where all the interesting state resides (and also matches the WebProcess).

4:18 PM Changeset in webkit [137820] by aestes@apple.com

2 edits in trunk/Source/WebKit2

Clean up the previous build fix; access m_networkProcess directly.

UIProcess/WebContext.cpp:

(WebKit::WebContext::registerSchemeForCustomProtocol):
(WebKit::WebContext::unregisterSchemeForCustomProtocol):

4:13 PM Changeset in webkit [137819] by aestes@apple.com

2 edits in trunk/Source/WebKit2

Fix the build.

UIProcess/WebContext.cpp:

(WebKit::WebContext::registerSchemeForCustomProtocol):
(WebKit::WebContext::unregisterSchemeForCustomProtocol):

4:03 PM Changeset in webkit [137818] by aestes@apple.com

11 edits in trunk/Source/WebKit2

[WebKit2] Register schemes with the network process if it is being used
https://bugs.webkit.org/show_bug.cgi?id=105113

Reviewed by Anders Carlsson.

If a WebContext is using the network process, it needs to be told about
scheme (un)registration rather than the context's web processes.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess): Tell the shared
CustomProtocolManager about schemes registered at process creation time.
(WebKit::NetworkProcess::registerSchemeForCustomProtocol): Tell the
shared CustomProtocolManager about a new scheme.
(WebKit::NetworkProcess::unregisterSchemeForCustomProtocol): Remove a
scheme from the shared CustomProtocolManager.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in: Add registration and

unregistration messages for the NetworkProcess.

Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode): Encode
urlSchemesRegisteredForCustomProtocols.
(WebKit::NetworkProcessCreationParameters::decode): Decode
urlSchemesRegisteredForCustomProtocols.

Shared/Network/NetworkProcessCreationParameters.h: Define

urlSchemesRegisteredForCustomProtocols.

UIProcess/Network/mac/NetworkProcessProxyMac.mm:

(WebKit::NetworkProcessProxy::platformInitializeNetworkProcess): Populate
urlSchemesRegisteredForCustomProtocols with the current set of schemes.

UIProcess/WebContext.cpp:

(WebKit::WebContext::registerSchemeForCustomProtocol): Send a new
scheme to either the network process or to the context's web processes.
(WebKit::WebContext::unregisterSchemeForCustomProtocol): Ditto for
removing a scheme.

UIProcess/WebContext.h:
UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess): Only populate
urlSchemesRegisteredForCustomProtocols if the network process isn't
being used.
(WebKit::WebContext::registerNotificationObservers):

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
urlSchemesRegisteredForCustomProtocols should only be non-empty if the
network process isn't being used. Assert this.

3:43 PM Changeset in webkit [137817] by nghanavatian@rim.com

12 edits in trunk

[BlackBerry] Pass key modifiers with touch and mouse events
https://bugs.webkit.org/show_bug.cgi?id=105108

Reviewed by Rob Buis.

Source/WebCore:

Call Screen to retrieve current key modifiers.

Internally reviewed by Gen Mak.

platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

platform/blackberry/PlatformMouseEventBlackBerry.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

platform/blackberry/PlatformTouchEventBlackBerry.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

Source/WebKit/blackberry:

Pass key modifiers to allow for added functionality, such as
shift+click to highlight.

Internally reviewed by Gen Mak.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):

Api/WebPage.h:
WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):

WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

Tools:

Update DRT to new api.

Internally reviewed by Gen Mak.

DumpRenderTree/blackberry/EventSender.cpp:

(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):

3:40 PM Changeset in webkit [137816] by nghanavatian@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Clean up allocated memory from InputMethodSupport
https://bugs.webkit.org/show_bug.cgi?id=105110

Reviewed by Rob Buis.

PR265919
We are deep copying the spannable_string from IMF and freeing
here once we're done with it.

Internally reviewed by Jeff Rogers.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

3:35 PM Changeset in webkit [137815] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Remove the unneeded NetworkProcessCrashed message
https://bugs.webkit.org/show_bug.cgi?id=105114

Reviewed by Sam Weinig.

Remove the NetworkProcessCrashed message; it's not needed since the connection member variable is already
nulled out in WebProcess::networkProcessConnectionClosed which is called when the Connection::Client::didClose member
function is called on the connection between the web process and network process.

Furthermore, this message was handled on the connection queue which runs on a different thread and the handler was not
thread-safe so this could in theory cause bad crashes.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didClose):

WebProcess/WebProcess.cpp:
WebProcess/WebProcess.h:

(WebProcess):

WebProcess/WebProcess.messages.in:

3:32 PM Changeset in webkit [137814] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[BlackBerry] Prevent CookieManager from blocking the WKT thread
https://bugs.webkit.org/show_bug.cgi?id=105111

PR 265603

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-15
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.

The getBackingStoreCookies in WKT is blocking the thread because it has to wait for
the db to be opened before it can call on it.

The fix is to make CookieDatabaseBackingStore in the cookie_db thread dispatch
a getBackingStoreCookies call on WKT after invokeOpen is finished.

Tested loading the browser. Cookies are being loaded into memory on start up.

platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::invokeOpen):

platform/blackberry/CookieManager.cpp:

(WebCore::cookieManager):

platform/blackberry/CookieManager.h:

3:11 PM Changeset in webkit [137813] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Add a DownloadProxyMap object to the NetworkProcessProxy object
https://bugs.webkit.org/show_bug.cgi?id=105112

Reviewed by Sam Weinig.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::createDownloadProxy):
(WebKit::NetworkProcessProxy::didClose):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::createDownloadProxy):

UIProcess/WebProcessProxy.cpp:
UIProcess/WebProcessProxy.h:

2:49 PM Changeset in webkit [137812] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Move the download proxy map from the web context to the web process proxy
https://bugs.webkit.org/show_bug.cgi?id=105109

Reviewed by Andreas Kling.

More progress towards making downloads work with the networking process. Since downloads are handled by the
web process when not using a networking process, it makes sense for the download proxy map to live in the
web process proxy object.

UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::download):
(WebKit::WebContext::createDownloadProxy):

UIProcess/WebContext.h:

(WebContext):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::shouldTerminate):
(WebKit):
(WebKit::WebProcessProxy::createDownloadProxy):

UIProcess/WebProcessProxy.h:

(WebProcessProxy):

2:11 PM Changeset in webkit [137811] by Simon Fraser

15 edits
1 add in trunk

Fix repaint issues when resizing a window with centered content, for platforms with a tile cache
https://bugs.webkit.org/show_bug.cgi?id=105073

Reviewed by Dan Bernstein.

Add a manual test for window resize with a centered element.

ManualTests/resize-repaint.html: Added.

Source/WebCore:

There were several issues with the "do full repaint" code path in
FrameView::layout(). These caused repaint issues when resizing the web view,
especially for platforms that use a tile cache.

First, the m_doFullRepaint flag wold get clobbered on resize-layouts, because
the call to adjustViewSize() re-enters layout(), and resets the m_doFullRepaint member
variable to false, even if the outer call had previously set it to true. This would
cause us to lose track of whether we needed to do a full repaint. The patch fixes
this by restoring m_doFullRepaint to the value it had before the call to adjustViewSize().

The second problem was that full repaints would not propagate to compositing
layers. They only repainted the RenderView, and on platforms that use a tile cache,
this only repaints the top portion of that tile cache. This was fixed by sending
a NeedsFullRepaintInBacking flag down into RenderLayer::updateLayerPositions(),
and using that to do a full repaint on all compositing layers.

Sending this new flag down into updateAfterLayout() prompted some boolean/flags
cleanup with propagated into several files. This also allowed me to no longer
include RenderLayerBacking.h in RenderLayerCompositor.h, but that required
header cleanup in several files.

Automated testing is not possible because WebKitTestRunner resizes the window
asynchronously (bug 105101). Added manual test.

page/FrameView.cpp:

(WebCore::updateLayerPositionFlags):
(WebCore::FrameView::layout):

page/scrolling/ScrollingCoordinator.cpp:
page/scrolling/mac/ScrollingCoordinatorMac.mm:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::contentChanged):

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

rendering/RenderLayerCompositor.h:
rendering/RenderObject.cpp:
rendering/RenderView.cpp:

Source/WebKit/chromium:

Include RenderLayerBacking.h, which is no longer included by RenderLayerCompositor.h.

tests/ScrollingCoordinatorChromiumTest.cpp:

2:04 PM Changeset in webkit [137810] by andersca@apple.com

3 edits in trunk/Source/WebKit2

DownloadProxy should keep a strong reference to its associated web context
https://bugs.webkit.org/show_bug.cgi?id=105107

Reviewed by Alexey Proskuryakov.

While this does create a ref-cycle, it's broken when the download completes, fails, is canceled or
if the process that's doing the download crashes.

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::processDidClose):
(WebKit::DownloadProxy::didStart):
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
(WebKit::DownloadProxy::didReceiveResponse):
(WebKit::DownloadProxy::didReceiveData):
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
(WebKit::DownloadProxy::didFail):
(WebKit::DownloadProxy::didCancel):

UIProcess/Downloads/DownloadProxy.h:

(DownloadProxy):

1:53 PM Changeset in webkit [137809] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Remove WebContext::downloadFinished
https://bugs.webkit.org/show_bug.cgi?id=105105

Reviewed by Sam Weinig.

Have DownloadProxyMap manage the message receiver map and remove WebContext::downloadFinished.

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didFinish):
(WebKit::DownloadProxy::didFail):
(WebKit::DownloadProxy::didCancel):

UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::DownloadProxyMap):
(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):

UIProcess/Downloads/DownloadProxyMap.h:

(DownloadProxyMap):

UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createDownloadProxy):

UIProcess/WebContext.h:

1:31 PM Changeset in webkit [137808] by weinig@apple.com

8 edits
3 deletes in trunk/Source/WebKit2

Make the NetworkProcess be managed by the WebContext, rather than a singleton NetworkProcessMananger
https://bugs.webkit.org/show_bug.cgi?id=105104

Reviewed by Alexey Proskuryakov.

Move to having the WebContext own and manage the NetworkProcessProxy.

UIProcess/Network/NetworkProcessManager.cpp: Removed.
UIProcess/Network/NetworkProcessManager.h: Removed.
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::create):
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):

UIProcess/Network/NetworkProcessProxy.h:

(WebKit):
(NetworkProcessProxy):

UIProcess/Network/mac/NetworkProcessManagerMac.mm: Removed.
UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::removeNetworkProcessProxy):
(WebKit::WebContext::getNetworkProcessConnection):
(WebKit::WebContext::willStartUsingPrivateBrowsing):
(WebKit::WebContext::willStopUsingPrivateBrowsing):
(WebKit::WebContext::createNewWebProcess):

UIProcess/WebContext.h:

(WebKit):
(WebContext):
(WebKit::WebContext::networkProcess):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getNetworkProcessConnection):

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::applicationBecameVisible):
(WebKit::WebContext::applicationBecameOccluded):

WebKit2.xcodeproj/project.pbxproj:

1:15 PM Changeset in webkit [137807] by andersca@apple.com

4 edits in trunk/Source/WebKit2

DownloadProxy objects should know which DownloadProxyMap they belong to
https://bugs.webkit.org/show_bug.cgi?id=105102

Reviewed by Andy Estes.

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::create):
(WebKit::DownloadProxy::DownloadProxy):

UIProcess/Downloads/DownloadProxy.h:

(WebKit):
(DownloadProxy):

UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::createDownloadProxy):

1:08 PM Changeset in webkit [137806] by aestes@apple.com

3 edits
3 moves
2 adds in trunk/Source/WebKit2

[WebKit2] Move CustomProtocolManager to Shared/
https://bugs.webkit.org/show_bug.cgi?id=105103

Reviewed by Sam Weinig.

CustomProtocolManager can be instantiated either in the NetworkProcess or the WebProcess, so it should live in Shared/.

DerivedSources.make: Update the path where CustomProtocolManager.messages.in can be found.
Shared/Network/CustomProtocols/CustomProtocolManager.h: Renamed from Source/WebKit2/WebProcess/Network/CustomProtocols/CustomProtocolManager.h.
Shared/Network/CustomProtocols/CustomProtocolManager.messages.in: Renamed from Source/WebKit2/WebProcess/Network/CustomProtocols/CustomProtocolManager.messages.in.
Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm: Renamed from Source/WebKit2/WebProcess/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm.
WebKit2.xcodeproj/project.pbxproj:

1:02 PM Changeset in webkit [137805] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Try to fix the Qt build.

Target.pri:

12:35 PM Changeset in webkit [137804] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Get rid of DownloadProxyMap::downloads()
https://bugs.webkit.org/show_bug.cgi?id=105100

Reviewed by Sam Weinig.

Add the needed member functions to DownloadProxyMap and remove the downloads() member function.

UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::processDidClose):
(WebKit):

UIProcess/Downloads/DownloadProxyMap.h:

(WebKit::DownloadProxyMap::isEmpty):
(DownloadProxyMap):

UIProcess/WebContext.cpp:

(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::downloadFinished):

12:26 PM Changeset in webkit [137803] by weinig@apple.com

9 edits
1 add in trunk/Source/WebKit2

Move calculation of caches sizes based on the cache model to CacheModel.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=105098

Reviewed by Anders Carlsson.

Move calculation of caches sizes based on the cache model to CacheModel.h/cpp so
that it can be used by more than just the WebProcess.

CMakeLists.txt:
GNUmakefile.list.am:
Shared/CacheModel.cpp: Added.

(WebKit):
(WebKit::calculateCacheSizes):

Shared/CacheModel.h:
Target.pri:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebProcess.cpp:
WebProcess/WebProcess.h:

(WebProcess):

win/WebKit2.vcproj:

12:13 PM Changeset in webkit [137802] by andersca@apple.com

6 edits in trunk/Source/WebKit2

DownloadProxyMap shouldn't be a singleton after all
https://bugs.webkit.org/show_bug.cgi?id=105099

Reviewed by Sam Weinig.

Make the DownloadProxyMap be per context instead, and get rid of the m_downloads hash map from WebContext.

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didFinish):
(WebKit::DownloadProxy::didFail):
(WebKit::DownloadProxy::didCancel):

UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::~DownloadProxyMap):

UIProcess/Downloads/DownloadProxyMap.h:

(DownloadProxyMap):
(WebKit::DownloadProxyMap::downloads):

UIProcess/WebContext.cpp:

(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::createDownloadProxy):
(WebKit::WebContext::downloadFinished):

UIProcess/WebContext.h:

(WebContext):

11:40 AM Changeset in webkit [137801] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix build.

platform/graphics/ca/GraphicsLayerCA.h:

Remove an unused member variable.

11:37 AM Changeset in webkit [137800] by Simon Fraser

11 edits in trunk

REGRESSION (r137006): TileCache flashes to linen, rather than the background color, when scrolling fast
https://bugs.webkit.org/show_bug.cgi?id=104746

Reviewed by Darin Adler.

Make RenderLayerBacking::updateBackgroundColor() responsible for setting the background
color of the main frame's root layer to the document background color (rather than doing
it in code related to overlay scrollbars, which was crazy). This is only done for platforms
that use a TiledBacking (currently, just Mac).

Also fix updateBackgroundColor() to not call m_graphicsLayer->setContentsToBackgroundColor()
and then call clearBackgroundColor() right away if the color was transparent.

page/FrameView.cpp:

(WebCore::FrameView::recalculateScrollbarOverlayStyle): Remove code that calls documentBackgroundColorDidChange().

rendering/RenderLayerBacking.cpp:

(WebCore::clipBox): Remove blank linke.
(WebCore::RenderLayerBacking::updateBackgroundColor):

rendering/RenderLayerCompositor.cpp:
rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

11:36 AM Changeset in webkit [137799] by zandobersek@gmail.com

2 edits in trunk/Tools

Stop the XvfbDriver before proceeding with its starting setup
https://bugs.webkit.org/show_bug.cgi?id=105006

Reviewed by Philippe Normand.

Just as with the base Driver implementation, stop the XvfbDriver
before proceeding with setting up lock files and a new Xvfb instance.
This forces any driver or Xvfb instances that are currently under
the driver's control to be closed/killed and cleaned up after.

Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

11:11 AM Changeset in webkit [137798] by Simon Fraser

100 edits in trunk

Disambiguate "background color" and "contents as solid color" on GraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=104842

Source/WebCore:

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-12-15
Reviewed by Simon Fraser.

Rename overloads in GraphicsLayerTextureMapper and GraphicsLayerChromium to account for the rename in GraphicsLayer.

Covered by existing tests.

platform/graphics/chromium/GraphicsLayerChromium.cpp:
platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToSolidColor):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::solidColor):

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

platform/graphics/texmap/TextureMapperLayer.h:

(State):

Source/WebKit2:

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-12-15
Reviewed by Simon Fraser.

Rename overloads in coordinated graphics to account for the rename in GraphicsLayer.

Shared/CoordinatedGraphics/CoordinatedLayerInfo.h:

(CoordinatedLayerInfo):

UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsToSolidColor):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

LayoutTests:

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-15
Reviewed by Simon Fraser.

Since we don't set the background color for a layer with a solid color, the test results have to be rebaselined.

compositing/backing/no-backing-for-clip-expected.txt:
compositing/backing/no-backing-for-clip-overlap-expected.txt:
compositing/backing/no-backing-for-perspective-expected.txt:
compositing/columns/composited-in-paginated-expected.txt:
compositing/geometry/ancestor-overflow-change-expected.txt:
compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
compositing/geometry/clip-expected.txt:
compositing/geometry/clip-inside-expected.txt:
compositing/geometry/composited-in-columns-expected.txt:
compositing/geometry/flipped-writing-mode-expected.txt:
compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
compositing/geometry/limit-layer-bounds-positioned-expected.txt:
compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
compositing/geometry/limit-layer-bounds-transformed-expected.txt:
compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
compositing/geometry/preserve-3d-switching-expected.txt:
compositing/iframes/become-composited-nested-iframes-expected.txt:
compositing/iframes/become-overlapped-iframe-expected.txt:
compositing/iframes/composited-parent-iframe-expected.txt:
compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
compositing/iframes/connect-compositing-iframe-expected.txt:
compositing/iframes/connect-compositing-iframe2-expected.txt:
compositing/iframes/connect-compositing-iframe3-expected.txt:
compositing/iframes/enter-compositing-iframe-expected.txt:
compositing/iframes/iframe-resize-expected.txt:
compositing/iframes/invisible-nested-iframe-hide-expected.txt:
compositing/iframes/invisible-nested-iframe-show-expected.txt:
compositing/iframes/overlapped-iframe-expected.txt:
compositing/iframes/overlapped-iframe-iframe-expected.txt:
compositing/iframes/page-cache-layer-tree-expected.txt:
compositing/iframes/scrolling-iframe-expected.txt:
compositing/layer-creation/animation-overlap-with-children-expected.txt:
compositing/layer-creation/fixed-position-and-transform-expected.txt:
compositing/layer-creation/fixed-position-under-transform-expected.txt:
compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
compositing/layer-creation/overflow-scroll-overlap-expected.txt:
compositing/layer-creation/overlap-animation-expected.txt:
compositing/layer-creation/overlap-child-layer-expected.txt:
compositing/layer-creation/overlap-clipping-expected.txt:
compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
compositing/layer-creation/overlap-transformed-layer-expected.txt:
compositing/layer-creation/overlap-transforms-expected.txt:
compositing/layer-creation/scroll-partial-update-expected.txt:
compositing/layer-creation/spanOverlapsCanvas-expected.txt:
compositing/layer-creation/stacking-context-overlap-expected.txt:
compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
compositing/layer-creation/translatez-overlap-expected.txt:
compositing/overflow-trumps-transform-style-expected.txt:
compositing/overflow/clip-descendents-expected.txt:
compositing/plugins/no-backing-store-expected.txt:
compositing/rtl/rtl-absolute-expected.txt:
compositing/rtl/rtl-absolute-overflow-expected.txt:
compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
compositing/rtl/rtl-fixed-expected.txt:
compositing/rtl/rtl-fixed-overflow-expected.txt:
compositing/rtl/rtl-relative-expected.txt:
compositing/tiled-layers-hidpi-expected.txt:
compositing/visible-rect/2d-transformed-expected.txt:
compositing/visible-rect/3d-transform-style-expected.txt:
compositing/visible-rect/3d-transformed-expected.txt:
compositing/visible-rect/animated-expected.txt:
compositing/visible-rect/animated-from-none-expected.txt:
compositing/visible-rect/clipped-by-viewport-expected.txt:
compositing/visible-rect/clipped-visible-rect-expected.txt:
compositing/visible-rect/iframe-and-layers-expected.txt:
compositing/visible-rect/nested-transform-expected.txt:
compositing/visible-rect/scrolled-expected.txt:
css3/filters/filtered-compositing-descendant-expected.txt:
platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
platform/mac/compositing/iframes/resizer-expected.txt:
platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:

10:49 AM Changeset in webkit [137797] by Christophe Dumez

2 edits in trunk/Source/WebKit2

[GTK][WK2] Memory leak in ChunkedUpdateDrawingArea::paintIntoUpdateChunk()
https://bugs.webkit.org/show_bug.cgi?id=105095

Reviewed by Martin Robinson.

Adopt the pointer returned by cairo_create() in
ChunkedUpdateDrawingArea::paintIntoUpdateChunk() to avoid leaking
memory.

WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp:

(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

6:49 AM WebInspector edited by abecsi@webkit.org

Remove spam. (diff)

3:24 AM WebInspector edited by mousewiki@yahoo.com

(diff)

1:02 AM Changeset in webkit [137796] by mark.lam@apple.com

3 edits in trunk/Source/WebKit2

Added #if ENABLE(SQL_DATABASE) around WebPlatformStrategies::getDatabaseServer().
https://bugs.webkit.org/show_bug.cgi?id=104934..

Not reviewed.

Greening the Qt Linux Release Minimal bot.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit):

WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

12:09 AM Changeset in webkit [137795] by mark.lam@apple.com

33 edits
4 copies in trunk/Source

Re-landing patch for "Introducing the DatabaseStrategy and database servers".
https://bugs.webkit.org/show_bug.cgi?id=104934.

Not reviewed.

Source/WebCore:

Merged from r137767. Previously reviewed by Sam Weinig.
Also added ZTVN7WebCore16DatabaseStrategyE to WebCore.exp.in.

No new tests.

CMakeLists.txt:
GNUmakefile.list.am:
Modules/webdatabase/AbstractDatabaseServer.h: Copied from Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h.
Modules/webdatabase/DBBackendServer.h: Copied from Source/WebCore/Modules/webdatabase/DBBackendServer.h.
Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::DatabaseManager):

Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/DatabaseStrategy.cpp: Copied from Source/WebCore/platform/DatabaseStrategy.cpp.
platform/DatabaseStrategy.h: Copied from Source/WebCore/platform/DatabaseStrategy.h.
platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::databaseStrategy):
(PlatformStrategies):
(WebCore::PlatformStrategies::PlatformStrategies):

Source/WebKit/efl: