⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 22, 2012:

8:44 PM EFLWebKitTests edited by Joone Hur
(diff)
6:36 PM Changeset in webkit [138415] by weinig@apple.com
  • 9 edits in trunk/Source/WebKit2

Give the ChildProcess a MessageReceiverMap
​https://bugs.webkit.org/show_bug.cgi?id=105681

Reviewed by Dan Bernstein.

Moving the MessageReceiverMap to the ChildProcess will help shared code
between the WebProcess and NetworkProcess.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
Pass 'this' instead of the MessageReceiverMap, now that ChildProcess
can be used to access the MessageReceiverMap.

  • NetworkProcess/NetworkProcess.h:

(NetworkProcess):
Remove the now extraneous MessageReceiverMap.

  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::ChildProcess):
(WebKit):
(WebKit::ChildProcess::~ChildProcess):
(WebKit::ChildProcess::addMessageReceiver):
(WebKit::ChildProcess::removeMessageReceiver):

  • Shared/ChildProcess.h:

(ChildProcess):
Add a MessageReceiverMap and helper functions from WebProcess.

  • WebProcess/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):

  • WebProcess/Authentication/AuthenticationManager.h:

(AuthenticationManager):
Fix the FIXME, passing the ChildProcess rather than the MessageReceiverMap.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/WebProcess.h:

(WebProcess):
Remove the MessageReceiverMap and helper functions.

6:19 PM Changeset in webkit [138414] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
6:15 PM Changeset in webkit [138413] by ap@apple.com
  • 90 edits
    3 adds
    2 deletes in trunk/Source

Add a separate class for networking related storage
​https://bugs.webkit.org/show_bug.cgi?id=105676

Reviewed by Sam Weinig.

NetworkingContext combines a reference to storage (cookies and more) and data that's
only meaningful when loading. This makes it very ugly to use for cookie manipulation
when there is no load (e.g. for document.cookie).

Adding NetworkStorageSession, which encorportes network-related sesion data, such
as cookies and session HTTP credentials.

For some ports, refactoring is not finished, NetworkStorageSession being a wrapper
for NetworkingContext.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Updated for new files and functions.
  • platform/network/PlatformCookieJar.h:
  • loader/CookieJar.cpp:
  • platform/CookiesStrategy.h:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/chromium/CookieJarChromium.cpp:
  • platform/network/curl/CookieJarCurl.cpp:
  • platform/network/mac/CookieJarMac.mm:
  • platform/network/qt/CookieJarQt.cpp:
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/win/CookieJarWin.cpp: PlatformCookieJar and strategy cookie functions now take a NetworkStorageSession instead of NetworkingContext. Note that they take a const reference to support creating a temporary session wrapper for ports that just wrap a NetworkingContext.
  • loader/ResourceLoader.cpp:
  • loader/cache/CachedResource.h:
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/chromium/ResourceHandle.cpp:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/soup/DNSSoup.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp: ResourceHandle no longer includes unneeded NetworkingContext.h and AuthenticationClient.h. This avoids near-world rebuilds on any NetworkingContext change.
  • platform/network/NetworkStorageSession.h: Added.
  • platform/network/NetworkStorageSessionStub.cpp: Added.
  • platform/network/cf/NetworkStorageSessionCFNet.cpp: Added. Good new stuff. Stub version just wraps NetworkingContext for platforms that still need to finish the refactoring.
  • platform/network/NetworkingContext.h: The context now has a NetworkStorageSession, and doesn't expose CFNet level objects directly.
  • platform/network/cf/CookieStorageCFNet.cpp:
  • platform/network/cf/CookieStorageCFNet.h: Removed. We no longer have separate free functions to track storage, it's part of NetworkStorageSession now.
  • platform/network/cf/ResourceHandleCFNet.cpp: Updated to use NetworkStorageSession.
  • platform/network/mac/CookieStorageMac.mm: Dont include CookieStorageCFNet.h, it was not needed.
3:14 PM Changeset in webkit [138412] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

InlineTextBox: Remove potentially confusing "} if" pattern.
​https://bugs.webkit.org/show_bug.cgi?id=105499

Reviewed by Ojan Vafai.

It's not clear to me on first look if this is intentional or missing
an "else" (and this pattern was used in just one other place in
webkit, which I've removed). It turns out no else is missing here,
this is checked by fast/text/justified-selection.html

  • rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows):

2:35 PM FeatureFlags edited by Laszlo Gombos
Remove COMMANDLINE_TYPEDARRAYS from the list - see r114575 (diff)
2:28 PM FeatureFlags edited by Laszlo Gombos
Remove JIT_USE_SOFT_MODULO from the list - see r111481 (diff)
1:53 PM FeatureFlags edited by Laszlo Gombos
Remove CLASSIC_INTERPRETER and COMPUTED_GOTO_CLASSIC_INTERPRETER from … (diff)
1:07 PM FeatureFlags edited by Laszlo Gombos
Remove ARM_NEON_INTRINSICS from the list as it is not an ENABLE flag - … (diff)
12:54 PM FeatureFlags edited by Laszlo Gombos
Remove RUN_TIME_HEURISTICS from the list - see r131089 (diff)
12:38 PM FeatureFlags edited by Laszlo Gombos
Remove SKIA_GPU_CANVAS from the list - see r97570 (diff)
12:28 PM FeatureFlags edited by Laszlo Gombos
Remove MAC_JAVA_BRIDGE from the list - see r129964 (diff)
12:20 PM FeatureFlags edited by Laszlo Gombos
Remove CSS3_FLEXBOX from the list - see r100198 (diff)
12:15 PM FeatureFlags edited by Laszlo Gombos
Fix typo - DRAGGBALE -> DRAGGABLE (diff)
12:11 PM FeatureFlags edited by Laszlo Gombos
Remove DATABASE from the list - see r95271 (diff)
12:00 AM Changeset in webkit [138411] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining the global constructors test after r138393.
Adjusting and merging expectations as required.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/js/global-constructors-expected.txt:

Dec 21, 2012:

11:34 PM Changeset in webkit [138410] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Update CodeMirror to stable
​https://bugs.webkit.org/show_bug.cgi?id=105653

Patch by Jan Keromnes <​janx@linux.com> on 2012-12-21
Reviewed by Pavel Feldman.

Fixes several minor issues, including throw scroll on mac.

  • inspector/front-end/cm/codemirror.css:

(.cm-negative):
(.cm-positive):
(.CodeMirror-gutter):
(.cm-searching):

  • inspector/front-end/cm/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):

  • inspector/front-end/cm/css.js:

(.):

  • inspector/front-end/cm/htmlmixed.js:

(.):

  • inspector/front-end/cm/javascript.js:

(.):

  • inspector/front-end/cm/xml.js:
10:16 PM Changeset in webkit [138409] by loislo@chromium.org
  • 2 edits in trunk/Source/WTF

Unreviewed. Another try to fix Apple Win Release build.

  • wtf/FastMalloc.cpp:

(WTF::ClassIndex):

10:06 PM Changeset in webkit [138408] by loislo@chromium.org
  • 2 edits in trunk/Source/WTF

Unreviewed compilation fix for Apple Win Release after r138398.

  • wtf/FastMalloc.cpp:

(WTF::ClassIndex):

9:40 PM Changeset in webkit [138407] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Remove Crash expectation from media/track tests after r138381.

  • platform/chromium/TestExpectations:
6:12 PM Changeset in webkit [138406] by thakis@chromium.org
  • 2 edits in trunk/Tools

chromium: webkit-build-directory doesn't handle ninja output dirs
​https://bugs.webkit.org/show_bug.cgi?id=105671

Reviewed by Daniel Bates.

Teach webkit-build-directory to detect the ninja build directory.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(determineIsChromiumNinja):

5:06 PM Changeset in webkit [138405] by rniwa@webkit.org
  • 7 edits in trunk

[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
​https://bugs.webkit.org/show_bug.cgi?id=95477

Reviewed by Sam Weinig.

Tools:

Co-authored by Jia Pu.

Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
we can have consistent autocorrection behavior when running tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

LayoutTests:

Use "notationl" -> "notational" auto correction in autocorrection-blockquote-crash.html to get reliable results.
Also add a failing expectation to removing-underline-after-accepting-autocorrection-using-punctuation.html for WebKit2.
This failure is tracked by the bug 105616.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
4:24 PM Changeset in webkit [138404] by esprehn@chromium.org
  • 12 edits in trunk

Replace documentFragmentIsShadowRoot with isTreeScope
​https://bugs.webkit.org/show_bug.cgi?id=105345

Reviewed by Dimitri Glazkov.

.:

Expose isTreeScope symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

We can replace documentFragmentIsShadowRoot with isTreeScope() which is
trival to detect by checking treeScope()->rootNode() == this. To do this
we must stop adopting ShadowRoots into the document when they're removed,
which was always wrong anyway as it meant that the TreeScope of a ShadowRoot
was no longer itself after it had been removed. It also meant that the
children of a ShadowRoot that was removed were no longer in it's tree scope
despite being descendants of it.

Making this simplification allows further simplication like
Node::containingShadowRoot can be made O(1) instead of O(k) where k is
the depth of the node.

No new tests, just refactoring.

  • WebCore.exp.in:
  • dom/DocumentFragment.h:

(DocumentFragment):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::removeAllShadowRoots):

  • dom/Node.cpp:

(WebCore::Node::setTreeScope):
(WebCore::Node::isTreeScope):
(WebCore):

  • dom/Node.h:

(Node):
(WebCore::Node::isShadowRoot):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):

  • dom/ShadowRoot.h:

(ShadowRoot):

Source/WebKit2:

Expose isTreeScope symbol.

  • win/WebKit2.def.in:
4:22 PM Changeset in webkit [138403] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r138331.
​http://trac.webkit.org/changeset/138331
​https://bugs.webkit.org/show_bug.cgi?id=105668

Broke Windows clean builds; can't figure out how to fix it
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-21

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitLibCommon.vsprops:
  • WebKit.vcproj/WebKitLibDebug.vsprops:
  • WebKit.vcproj/WebKitLibDebugAll.vsprops:
  • WebKit.vcproj/WebKitLibProduction.vsprops:
  • WebKit.vcproj/WebKitLibRelease.vsprops:

Source/WebKit2:

  • win/WebKit2.def.in:
3:48 PM Changeset in webkit [138402] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] IndexedDB: storage/indexeddb/intversion-close-between-events.html flaky in content_shell
​https://bugs.webkit.org/show_bug.cgi?id=105665

Test uses a setTimeout() which may fire at different times relative to the completion of the
IDBOpenDBRequest in multiprocess ports. Make the test resilient against different outcomes.

Reviewed by Tony Chang.

  • storage/indexeddb/resources/intversion-close-between-events.js:

(deleteSuccess):
(openSuccessOrError):
(checkFinished):

3:27 PM Changeset in webkit [138401] by wangxianzhu@chromium.org
  • 4 edits in trunk/Source

[Chromium-Android] Use harfbuzz-ng instead of harfbuzz-old on Android
​https://bugs.webkit.org/show_bug.cgi?id=104410

Source/WebCore:

Using harfbuzz-ng we can avoid many bugs of the obsolete harfbuzz-old.

Reviewed by Eric Seidel.

No new tests. No change of functionality. Existing tests should pass.

  • WebCore.gyp/WebCore.gyp: Use harfbuzz-ng on Android.

Source/WebKit/chromium:

Reviewed by Eric Seidel.

  • features.gypi: Enable harfbuzz-ng on Android.
3:26 PM Changeset in webkit [138400] by jsbell@chromium.org
  • 7 edits
    3 adds in trunk

IndexedDB: Combine openConnection and openConnectionWithVersion
​https://bugs.webkit.org/show_bug.cgi?id=105658

Reviewed by Tony Chang.

Source/WebCore:

Combine the logic from these two methods. Mostly a refactor, but in the "pending calls"
case the behavior is slightly altered since the version and no-version queues were
previously separate, so the order changes. The new order matches the spec and FF/IE
behavior, and a test is added to verify this.

Chromium's webkit_unit_tests rely on a quirk to bypass the upgrade mechanism; the usage
is slightly altered and made more explicit, and requires a small amount of test-only code.

Test: storage/indexeddb/open-ordering.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::close):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

Source/WebKit/chromium:

  • tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

  • storage/indexeddb/open-ordering-expected.txt: Added.
  • storage/indexeddb/open-ordering.html: Added.
  • storage/indexeddb/resources/open-ordering.js: Added.

(runTest):
(onDeleteSuccess):
(onRequest1Success):
(onRequest2Success):
(onRequest3Success):
(checkOrder):

2:34 PM Changeset in webkit [138399] by fpizlo@apple.com
  • 7 edits
    3 adds in trunk/Source/JavaScriptCore

DFG Arrayify slow path should be out-of-line
​https://bugs.webkit.org/show_bug.cgi?id=105400

Reviewed by Gavin Barraclough.

The interesting bit of this change is allowing out-of-line slow path generators
to emit speculation checks. This is accomplished by having a version of
speculationCheck() that returns a jump placeholder instead of taking a jump (or
jump list) as an argument. You can then fill in that jump placeholder at a
later time, so long as you do it before OSR exit linking. Slow path generators
run before linking, so that just naturally ends up working.

This isn't really a big win, but we know that out-of-lining slow paths is
generally a good thing to do, so it's fair to assume that this is a move in the
right direction.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArrayifySlowPathGenerator.h: Added.

(DFG):
(ArrayifySlowPathGenerator):
(JSC::DFG::ArrayifySlowPathGenerator::ArrayifySlowPathGenerator):
(JSC::DFG::ArrayifySlowPathGenerator::generateInternal):

  • dfg/DFGOSRExitJumpPlaceholder.cpp: Added.

(DFG):
(JSC::DFG::OSRExitJumpPlaceholder::fill):

  • dfg/DFGOSRExitJumpPlaceholder.h: Added.

(DFG):
(OSRExitJumpPlaceholder):
(JSC::DFG::OSRExitJumpPlaceholder::OSRExitJumpPlaceholder):
(JSC::DFG::OSRExitJumpPlaceholder::operator!):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculationCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::arrayify):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

2:22 PM Changeset in webkit [138398] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Further harden FastMalloc
​https://bugs.webkit.org/show_bug.cgi?id=105656

Reviewed by Gavin Barraclough.

This increases the degree to which we harden the FastMalloc
linked lists. We now also mask the previous and next pointers
in the doubly linked list implementation. I've also made
the masking itself somewhat more complex without a measurable
cost. We still use ASLR to provide some general entropy, but
we blind the pointers against each nodes 'this' pointer.

  • wtf/FastMalloc.cpp:

(WTF::ClassIndex):
(WTF::SLL_Next):
(WTF::SLL_SetNext):
(WTF::Span::next):
(WTF::Span::prev):
(WTF::Span::setNext):
(WTF::Span::setPrev):
(Span):

As Span now has to do masking on the next and previous pointers,
I've updated the code to use accessors instead.

(WTF::DLL_Init):
(WTF::DLL_Remove):
(WTF::DLL_IsEmpty):
(WTF::DLL_Length):
(WTF::DLL_Prepend):
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects):
(WTF::TCMalloc_PageHeap::scavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::ReturnedBytes):
(WTF::TCMalloc_PageHeap::Check):
(WTF::TCMalloc_PageHeap::CheckList):
(WTF::TCMalloc_PageHeap::ReleaseFreeList):
(WTF::TCMalloc_Central_FreeList::FetchFromSpans):

2:17 PM Changeset in webkit [138397] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

ASSERT in WebResourceLoadScheduler::scheduleLoad with a crashed NetworkProcess.
<rdar://problem/12924845> and ​https://bugs.webkit.org/show_bug.cgi?id=105646

Reviewed by Alexey Proskuryakov.

If we fail to schedule a loader with the NetworkProcess it is probably because the NetworkProcess crashed.

Since these loaders will never succeed in loading we should schedule them to fail on a timer.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::addUnschedulableLoad):
(WebKit::WebResourceLoadScheduler::unscheduledLoadTimerFired):
(WebKit::WebResourceLoadScheduler::remove):

  • WebProcess/Network/WebResourceLoadScheduler.h:
1:00 PM Changeset in webkit [138396] by acolwell@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Removing CRASH expectations for media layout tests
broken by ​http://crbug.com/162917.
​https://bugs.webkit.org/show_bug.cgi?id=103093

  • platform/chromium/TestExpectations:
12:58 PM Changeset in webkit [138395] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed potential fix EFL/Qt test breakage on WK2

Only disable scrollbars when in fixed layout mode.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

11:48 AM Changeset in webkit [138394] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Update localizable strings as a followup to ​http://trac.webkit.org/changeset/138387
​https://bugs.webkit.org/show_bug.cgi?id=105592

Rubberstamped by Alexey Proskuryakov.

  • English.lproj/Localizable.strings: Added a new error string.
11:38 AM Changeset in webkit [138393] by kbr@google.com
  • 6 edits in trunk

Expose ArrayBufferView constructor on DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=105605

Reviewed by Sam Weinig.

Source/WebCore:

Update IDL to track recent spec change exposing ArrayBufferView
constructor on DOMWindow for instanceof checks. There are no
constructors exposed in the Web IDL, however, so calling it via
operator new throws TypeError.

Test (updated): fast/canvas/webgl/array-unit-tests.html

  • html/canvas/ArrayBufferView.idl:

Removed OmitConstructor attribute.

  • page/DOMWindow.idl:

Exposed ArrayBufferView constructor function attribute.

LayoutTests:

Updated test from Khronos repository.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
11:27 AM Changeset in webkit [138392] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, unskip now passing tests.

  • platform/qt-5.0-wk2/TestExpectations:
11:14 AM Changeset in webkit [138391] by beidson@apple.com
  • 7 edits in trunk/Source

Remove ResourceLoadScheduler::addMainResourceLoad and all related code
<rdar://problem/12925275> and ​https://bugs.webkit.org/show_bug.cgi?id=105644

Reviewed by Alexey Proskuryakov.

Now that main resources loads are scheduled (bug 49246) we don't need this stuff anymore.

Source/WebCore:

No new tests (No change in behavior).

  • WebCore.exp.in:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:

Source/WebKit2:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove):
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

  • WebProcess/Network/WebResourceLoadScheduler.h:
11:13 AM Changeset in webkit [138390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WebGL][EFL][Qt] Transparent canvas composited non-transparent
​https://bugs.webkit.org/show_bug.cgi?id=105325

Patch by Viatcheslav Ostapenko <​sl.ostapenko@samsung.com> on 2012-12-21
Reviewed by Kenneth Rohde Christiansen.

glXPixmap is always created without alpha channel because 1st GLXFBConfig
in a list doesn't support transparency.
Use the same code that is used to find GLXFBConfig with alpha for window
creation in GraphicsSurfacePrivate::createPixmap(). Code is moved to
findFBConfigWithAlpha() method.

Covered by fast/canvas/webgl/webgl-composite-modes-repaint.html

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
(GraphicsSurfacePrivate):

10:57 AM Changeset in webkit [138389] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fullscreen video fixed position container horizontal position is wrong
​https://bugs.webkit.org/show_bug.cgi?id=105488

Patch by Max Feil <​mfeil@rim.com> on 2012-12-21
Reviewed by George Staikos.

The fix for ​https://bugs.webkit.org/show_bug.cgi?id=105333 has
broken fullscreen video, which was compensating by doing its
own positioning in x. My patch fixes things by making vertical
and horizontal handling symmetrical.
NOTE: This function was not upstreamed before, so you can't
actually see my diff. See the bug.

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):

10:53 AM Changeset in webkit [138388] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

Add WebKit2 SPI to get the current selection as a WebArchive
​https://bugs.webkit.org/show_bug.cgi?id=105613

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSelectionAsWebArchiveData):

  • UIProcess/API/C/WKPage.h:

Add SPI.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::frameWithSelection):
(WebKit::WebPage::getSelectionAsWebArchiveData):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:

Pipe getter to the WebProcess and back.

10:46 AM Changeset in webkit [138387] by beidson@apple.com
  • 9 edits in trunk/Source/WebKit2

Perform cleanup in WebProcess if the NetworkProcess crashes.
<rdar://problem/12903117> and ​https://bugs.webkit.org/show_bug.cgi?id=105592

Reviewed by Alexey Proskuryakov.

If the NetworkProcess crashes, a whole bunch of WebResourceLoaders (and WebCore::ResourceLoaders)
might be orphaned in the WebProcess.

These loaders need to fail once it is apparent they will never finish loading.

  • Shared/API/c/WKError.h: Add a new error representing an "WebKit Internal Error."
  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::internalError):

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::networkProcessCrashed): Call didFail all outstanding ResourceLoaders

and tell all WebResourceLoaders the NetworkProcess crashed.

  • WebProcess/Network/WebResourceLoadScheduler.h:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::networkProcessCrashed): Call didFail with the new InternalError

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::networkProcessConnectionClosed): Tell the scheduled the NetworkProcess crashed.

9:42 AM Changeset in webkit [138386] by Dimitri Glazkov
  • 74 edits in trunk

Unreviewed, rolling out r138376.
​http://trac.webkit.org/changeset/138376
​https://bugs.webkit.org/show_bug.cgi?id=104995

Broke a bunch of tests on mac.

Source/WebCore:

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::nodeName):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

LayoutTests:

  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/resources/shadow-dom.js:

(isShadowRoot):

  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • inspector/elements/shadow-dom-modify-chardata-expected.txt:
  • inspector/elements/shadow-root-expected.txt:
  • inspector/elements/update-shadowdom-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • resources/dump-as-markup.js:

(Markup._get):

9:12 AM Changeset in webkit [138385] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing a list of failure expectations that were added as a precaution
in r138250 in case of regressions (which in the end didn't occur).

  • platform/gtk/TestExpectations:
9:05 AM Changeset in webkit [138384] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a few missing expectations for tests that require their baselines
to be checked before they are added.
Adding and modifying expectations where necessary to accommodate recent
changes in test behavior.

  • platform/gtk/TestExpectations:
8:47 AM Changeset in webkit [138383] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r138237.
​http://trac.webkit.org/changeset/138237
​https://bugs.webkit.org/show_bug.cgi?id=105637

Regresses web inspector's editor performance. (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-21

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorMainChunk.prototype.expand):

8:45 AM Changeset in webkit [138382] by zandobersek@gmail.com
  • 4 edits
    2 adds in trunk

[GTK] Add WebKit1-specific TestExpectations file
​https://bugs.webkit.org/show_bug.cgi?id=97562

Reviewed by Dirk Pranke.

Tools:

Implement the expectations_files method inside the GtkPort class that
returns the list of the TestExpectations files the current test configuration
requires. The method is implemented in a similar way as on the EFL port.
A unit test is also added.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._search_paths):
(GtkPort):
(GtkPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest.test_expectations_files):

LayoutTests:

Add properly formatted but currently empty TestExpectations file
for GTK WebKit1-specific test expectations.

  • platform/gtk-wk1/TestExpectations: Added.
8:36 AM Changeset in webkit [138381] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Various tests in media/track are intermittently crashing.
​https://bugs.webkit.org/show_bug.cgi?id=105606

Reviewed by Eric Seidel.

The root of problem is the fact that we update tracks even if we are in process of deleting the document.
Media element can stop doing that if the document informed the element via ::stop that it is going away.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):

8:19 AM Changeset in webkit [138380] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Chromium/Mac] Don't send an onclick event from a ctrl-click
​https://bugs.webkit.org/show_bug.cgi?id=105554

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2012-12-21
Reviewed by Dimitri Glazkov.

Don't send the onclick event on a control click event (which
triggers the context menu on the Mac). This matches the
behaviour of the Apple Mac port, although the Apple port
does this by checking whether the context menu is visible
in WebPage::mouseEvent().

This is a fix for ​http://crbug.com/146143

Source/WebCore:

Test: fast/events/controlclick-no-onclick.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/events/controlclick-no-onclick-expected.txt: Added.
  • fast/events/controlclick-no-onclick.html: Added.
8:01 AM Changeset in webkit [138379] by shinyak@chromium.org
  • 6 edits
    2 adds in trunk

Implement ShadowRoot::elementFromPoint
​https://bugs.webkit.org/show_bug.cgi?id=104579

Reviewed by Dimitri Glazkov.

Source/WebCore:

Move elementFromPoint and nodeFromPoint to TreeScope from Document so that ShadowRoot can call it.
In the elementFromPoint(), the element taken by nodeFromPoint is not in the same tree scope, its ancestor is returned.

Since nodeFromPoint does not return the shadow ancestor of the result node, I don't make it TreeScope method.

Test: fast/dom/shadow/elementfrompoint.html

  • dom/Document.cpp:

(WebCore::Document::elementFromPoint): Code is shared with TreeScope.
(WebCore::Document::caretRangeFromPoint):

  • dom/ShadowRoot.idl:
  • dom/TreeScope.cpp:

(WebCore::nodeFromPoint): Moved from Document.cpp
(WebCore):
(WebCore::TreeScope::elementFromPoint):

  • dom/TreeScope.h:

(WebCore):
(TreeScope):

LayoutTests:

  • fast/dom/shadow/elementfrompoint-expected.txt: Added.
  • fast/dom/shadow/elementfrompoint.html: Added.
7:55 AM Changeset in webkit [138378] by kenneth@webkit.org
  • 4 edits in trunk/Source

[EFL][WK2] Never create WebCore scrollbars for EFL/WK2
​https://bugs.webkit.org/show_bug.cgi?id=105632

Reviewed by Antonio Gomes.

Source/WebCore:

For delegates scroll we must not use the scroll animator,
or similar as those depends on creating WebCore scrollbars.

Handle the wheel event manually for delegates scrolling.

  • page/FrameView.cpp:

(WebCore::FrameView::wheelEvent):

Source/WebKit2:

Then creating the frame ask to not create scrollbars and
lock it so they won't be created at any later time.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

7:55 AM Changeset in webkit [138377] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Add Crash test expectation to the media/track/ tests which have explicit expectations.
It needs to be removed after fixing ​https://bugs.webkit.org/show_bug.cgi?id=105606

  • platform/chromium/TestExpectations:
7:44 AM Changeset in webkit [138376] by shinyak@chromium.org
  • 74 edits in trunk

[Shadow DOM]: ShadowRoot wrong nodeName attribute
​https://bugs.webkit.org/show_bug.cgi?id=104995

Reviewed by Dimitri Glazkov.

Source/WebCore:

According to the Shadow DOM spec, ShadowRoot.nodeName should return '#document-fragment' instead of '#shadow-root'.
We remove ShadowRoot::nodeName.

No new tests, covered by existing tests.

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):

LayoutTests:

Uses 'instanceof' to check the instance is ShadowRoot or not.
Update dump-as-markup.js to see 'instanceof' instead of nodeType.
Also, a lot of rebaselines have been conducted.

  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/resources/shadow-dom.js:

(isShadowRoot):

  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • inspector/elements/shadow-dom-modify-chardata-expected.txt:
  • inspector/elements/shadow-root-expected.txt:
  • inspector/elements/update-shadowdom-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • resources/dump-as-markup.js:

(Markup._get):

7:36 AM Changeset in webkit [138375] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline.

  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
7:30 AM Changeset in webkit [138374] by mihaip@chromium.org
  • 3 edits
    2 adds in trunk

Slow performance with <select> with many options and size >= 2
​https://bugs.webkit.org/show_bug.cgi?id=105483

Source/WebCore:

Reviewed by Eric Seidel.

Avoids creating renderers for children of list <select>s that are not
<option> or <optgroup>. This is both more correct (no other browser
displays them) and provides a performance benefit (direct text children
of <select> would have O(N2) behavior; this usually happened due to
whitespace between <option>...</option> tags).

Test: fast/forms/menulist-no-renderer-for-unexpected-children.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):

LayoutTests:

Reviewed by Eric Seidel.

Test that checks that text and non-<option> and <optgroup> element
children of <select> do not get a renderer.

  • fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt: Added.
  • fast/forms/menulist-no-renderer-for-unexpected-children.html: Added.
7:28 AM Changeset in webkit [138373] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after r138248.

  • platform/efl/fast/js/global-constructors-expected.txt:
7:19 AM Changeset in webkit [138372] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline.

  • platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
7:08 AM Changeset in webkit [138371] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark svg/custom/feDisplacementMap-01.svg as missing.

  • platform/efl/TestExpectations:
6:51 AM Changeset in webkit [138370] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[EFL] Add guard around ContextMenuItemTagInspectElement
​https://bugs.webkit.org/show_bug.cgi?id=105267

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-21
Reviewed by Ryosuke Niwa.

Need INSPECTOR guard for using ContextMenuItemTagInspectElement.

Source/WebKit/efl:

  • WebCoreSupport/AssertMatchingEnums.cpp:

Source/WebKit2:

  • UIProcess/API/efl/ewk_context_menu_item.cpp:
6:50 AM FeatureFlags edited by alexis@webkit.org
Add CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED (diff)
6:25 AM Changeset in webkit [138369] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Enable feature option for the CSS sticky position
​https://bugs.webkit.org/show_bug.cgi?id=105630

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2012-12-21
Reviewed by Kenneth Rohde Christiansen.

Enable CSS sticky position feature by default for the
EFL port. This feature option was added in r138252.

No new tests. Existing layout tests pass.

  • Scripts/webkitperl/FeatureList.pm:
5:47 AM Changeset in webkit [138368] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2] REGRESSION(r138232): It made 4 tests timeout
​https://bugs.webkit.org/show_bug.cgi?id=105623

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2012-12-21
Reviewed by Kenneth Rohde Christiansen.

r138232 changed functionality so that empty text output
no longer leads to a dump() call, which leads to a timeout.
Instead do a text dump if there is text output or if there
is no audio output.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults):

5:40 AM Changeset in webkit [138367] by mikhail.pozdnyakov@intel.com
  • 3 edits
    3 adds in trunk

[WK2] TiledBackingStore: Scroll position is not reset when new page is loaded
​https://bugs.webkit.org/show_bug.cgi?id=105627

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Reset scroll position to (0,0) when new page is loaded.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

LayoutTests:

Added a layout test checking scroll position for newly loaded pages.

  • fast/dom/resources/check-scroll-position-onload.html: Added.
  • fast/dom/scroll-position-for-new-loads-expected.txt: Added.
  • fast/dom/scroll-position-for-new-loads.html: Added.
5:30 AM Changeset in webkit [138366] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaseline after r138365.

  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
4:42 AM Changeset in webkit [138365] by keishi@webkit.org
  • 13 edits in trunk

Fix typing zero into multiple field input
​https://bugs.webkit.org/show_bug.cgi?id=105501

Reviewed by Kent Tamura.

Source/WebCore:

We have a couple of problems when handling zero in a multiple fields
element.

  1. Typing '02' into a month field will set '12'.
  2. Typing '0' into 12 hour hour field will set '12' and move to the focus to the next field.

This change adds a type ahead buffer so we can handle these cases
properly. If the value in the type ahead buffer is valid we set it so a
change event will fire.

Added tests to *-multiple-fields-keyboard-events.html.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::didBlur): Clear the type ahead
buffer. handleKeyboardEvent() won't set the type ahead value if it is
not in range, so we set the value here.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::stepDown): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::stepUp): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::typeAheadValue): Returns integer
value for the type ahead characters.
(WebCore):
(WebCore::DateTimeNumericFieldElement::visibleValue): If we have type
ahead characters, show that.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement):

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:
2:46 AM Changeset in webkit [138364] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Buffering ranges are reported incorrectly with GStreamer 1.0
​https://bugs.webkit.org/show_bug.cgi?id=105319

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2012-12-21
Reviewed by Philippe Normand.

We add the gPercentMax constant to select between 100 and
GST_FORMAT_PERCENT_MAX depending if we are compiling against
GStreamer 0.10 or 1.0 and we use that in the corresponding method.

Current tests should suffice.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered): Added the use of
gPercentMax constant instead of 100 to have the different code
paths for GStreamer 0.10 and 1.0.

2:46 AM Changeset in webkit [138363] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL][WK1] Obsolete a case in test_ewk_frame api test to not make bot sick
​https://bugs.webkit.org/show_bug.cgi?id=105142

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-12-21
Reviewed by Gyuyoung Kim.

BUG 49246 has changed load behavior on malformed url input.
That is why test_ewk_frame api test is timed out.
To not make bot sick, this patch comments out that test case at a moment.

  • tests/test_ewk_frame.cpp:

(TEST_F):

2:34 AM Changeset in webkit [138362] by János Badics
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Gardening after r138232. Skipped 4 tests timing out.
​https://bugs.webkit.org/show_bug.cgi?id=105623

Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/TestExpectations:
2:31 AM Changeset in webkit [138361] by timothy_horton@apple.com
  • 11 edits in trunk/Source

PDFPlugin: Cannot drop files/URLs on PDFPlugin
​https://bugs.webkit.org/show_bug.cgi?id=105516
<rdar://problem/12729443>

Reviewed by Alexey Proskuryakov.

Add shouldAllowNavigationFromDrags to Plugin/PluginView/etc., which WebCore will
consult when dragging over a PluginDocument to decide whether or not a drag may result in navigation.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::shouldAllowNavigationFromDrags): Added, always returning false to keep existing behavior.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin): Added.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:

(WebKit::SimplePDFPlugin::shouldAllowNavigationFromDrags): Added, always returning true. (Simple)PDFPlugin should
navigate when dropped onto, just like an image or HTML document would.

  • WebProcess/Plugins/Plugin.h:

(Plugin): Add shouldAllowNavigationFromDrags.

  • WebProcess/Plugins/PluginProxy.h: Add shouldAllowNavigationFromDrags.
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::shouldAllowNavigationFromDrags): Forward shouldAllowNavigationFromDrags to the plugin.

  • WebProcess/Plugins/PluginView.h: Add shouldAllowNavigationFromDrags.
  • page/DragController.cpp:

(WebCore::DragController::operationForLoad): If we drag over a PluginDocument, check if its PluginView
claims to support navigation resulting from a drag (only PDFPlugin will for now). If it does, allow the drag.

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::shouldAllowNavigationFromDrags): Add shouldAllowNavigationFromDrags.

2:22 AM WK2-EFLTextCheckerApiTutorial created by g.czajkowski@samsung.com
2:19 AM Changeset in webkit [138360] by János Badics
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r138316. Skipped a new failing reftest
with minor pixel differences.

Reviewed by Csaba Osztrogonác.

  • platform/qt/TestExpectations:
2:17 AM Changeset in webkit [138359] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r138357.
​http://trac.webkit.org/changeset/138357
​https://bugs.webkit.org/show_bug.cgi?id=105622

wrong fix for the problem (the original author actually
already did this, and it's not helping) (Requested by thorton
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-21

  • win/WebKit2.def.in:
2:05 AM Changeset in webkit [138358] by loislo@chromium.org
  • 10 edits in trunk

Unreviewed, rolling out r138338.
​http://trac.webkit.org/changeset/138338
​https://bugs.webkit.org/show_bug.cgi?id=105621

speculative rollout because fast/dom/shadow/content-element-
distributed-nodes.html is crashing on linux debug. (Requested
by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-21

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/DocumentFragment.h:
  • dom/Node.cpp:

(WebCore::Node::documentFragmentIsShadowRoot):
(WebCore):

  • dom/Node.h:

(Node):
(WebCore::Node::isShadowRoot):

  • dom/ShadowRoot.h:

Source/WebKit2:

  • win/WebKit2.def.in:
2:04 AM Changeset in webkit [138357] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed Windows build fix after ​http://trac.webkit.org/changeset/138338

  • win/WebKit2.def.in:
1:54 AM Changeset in webkit [138356] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit2

Reducing print preview scale significantly causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=105519
<rdar://problem/12807090>

Reviewed by Alexey Proskuryakov.

The bitmap image used for print previews was being created respecting the print preview scale.
This doesn't make any sense, as the scale does not affect the size of the image required to
represent the previewed page. Instead, we should not scale the size, creating the buffer at a
size that is constant regardless of scale, and do the scaling when drawing *into* the buffer instead.

In some cases, this could cause an out-of-memory crash.

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _drawPreview:]): Rename rect to scaledPrintingRect for clarity. Compute print
preview bitmap image size from the original non-scaled drawing size and the device scale factor.
Hand the image size to drawRectToImage. Draw the image without scaling, as it's always created
at the correct size. Don't compute the scale factor from the size of the image, we can know it from WebPageProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::drawRectToImage): Add a parameter to drawRectForImage, imageSize.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Add a parameter to drawRectForImage, imageSize.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToImage): Use imageSize to size our buffer, and scale up to make the printing rect
fit in the bitmap's bounds.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Add a parameter to drawRectForImage, imageSize.

  • WebProcess/WebPage/WebPage.messages.in: Add a parameter to drawRectForImage, imageSize.
1:45 AM EFLWebKit edited by g.czajkowski@samsung.com
(diff)
1:33 AM Changeset in webkit [138355] by zeno.albisser@digia.com
  • 2 edits in trunk/Tools

[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
​https://bugs.webkit.org/show_bug.cgi?id=105309

On Windows the library name is Qt5WebKitWidgets as well.
So r138136 should not have adjusted the library name for Windows.

Reviewed by Simon Hausmann.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):

1:15 AM Changeset in webkit [138354] by adam.bergkvist@ericsson.com
  • 13 edits in trunk

MediaStream API: Update the MediaStream constructor
​https://bugs.webkit.org/show_bug.cgi?id=98416

Reviewed by Adam Barth.

Updated the MediaStream constructor to support the more general argument
list from the latest Media Capture and Streams specification:
​http://dev.w3.org/2011/webrtc/editor/getusermedia.html

Source/WebCore:

Added more test cases to existing tests.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::containsSource):
(WebCore):
(WebCore::processTrack):
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::create):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStream.idl:

LayoutTests:

  • fast/js/constructor-length.html:
  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
  • platform/blackberry/fast/js/constructor-length-expected.txt:
  • platform/chromium/fast/js/constructor-length-expected.txt:
  • platform/gtk/fast/js/constructor-length-expected.txt:
  • platform/mac/fast/js/constructor-length-expected.txt:
  • platform/qt/fast/js/constructor-length-expected.txt:
1:07 AM Changeset in webkit [138353] by zeno.albisser@digia.com
  • 4 edits
    2 adds in trunk

[Qt] Add new TestExpectations for qt-5.0-mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=105424

This change will allow us to run a very specific
subset of the available LayoutTests on a mac buildbot.
The new baseline search path for mac will look as follows:
qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt

Reviewed by Dirk Pranke.

Tools:

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._search_paths):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):

LayoutTests:

  • platform/qt-5.0-mac-wk2/TestExpectations: Added.
Note: See TracTimeline for information about the timeline view.