Timeline
Dec 23, 2012:
- 10:10 PM Changeset in webkit [138434] by
-
- 3 edits in trunk/Source/WebKit2
Fix the incorrect use of preprocessor statement in API header
https://bugs.webkit.org/show_bug.cgi?id=105675
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-23
Reviewed by Sam Weinig.
Remove a preprocessor statement in WKBundlePage.h
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetInspector):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 9:45 PM Changeset in webkit [138433] by
-
- 13 edits in trunk/Source/WebKit2
Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection
https://bugs.webkit.org/show_bug.cgi?id=105703
Reviewed by Dan Bernstein.
Also switches WebCookieManager over to be a MessageReceiver while we are at it.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initialize):
(WebKit::NetworkProcess::didReceiveMessage):
- NetworkProcess/NetworkProcess.h:
(WebKit):
- WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
- WebProcess/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit):
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::didReceiveMessage):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::cookiesDidChange):
(WebKit::WebCookieManager::dispatchCookiesDidChange):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
- WebProcess/Cookies/WebCookieManager.h:
(WebKit):
(WebCookieManager):
- WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::setCookiePersistentStorage):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAlwaysAcceptCookies):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initialize):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::cookieManager):
- 9:05 PM Changeset in webkit [138432] by
-
- 12 edits2 adds in trunk/Source/WebCore
Split fast-rejection filter logic off SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=105660
The awesome Bloom filter and parent stack logic don't need to be in SelectorChecker. They nicely factor out
into their own pretty thing, named thereby SelectorFilter.
Reviewed by Eric Seidel.
No change in functionality, covered by existing tests.
- CMakeLists.txt: Added SelectorFilter to build systems.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSAllInOne.cpp: Ditto.
- css/RuleSet.cpp: Changed to use SelectorFilter.
(WebCore::RuleData::RuleData): Ditto.
- css/SelectorChecker.cpp: Ditto.
- css/SelectorChecker.h: Ditto.
(SelectorChecker):
- css/StyleResolver.cpp: Ditto.
(WebCore):
(WebCore::StyleResolver::pushParentElement): Ditto.
(WebCore::StyleResolver::popParentElement): Ditto.
(WebCore::StyleResolver::collectMatchingRulesForList): Ditto.
- css/StyleResolver.h:
(StyleResolver): Ditto.
- 8:43 PM Changeset in webkit [138431] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] give url when createWindow
https://bugs.webkit.org/show_bug.cgi?id=105702
RIM bug# 257329
Reviewed by George Staikos.
This is to revert previous commit 575407238c35f1a0fa7ff7dd5dbbf6cc3ece1107
for integration issue of cascade and air, as old app side still use the url
to invoke. It would unrevert after resolving the integration issue.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 8:38 PM Changeset in webkit [138430] by
-
- 2 edits in trunk/Source/WebCore
Remove unused reference to "class LayerChromium"
https://bugs.webkit.org/show_bug.cgi?id=105502
Patch by Qiankun Miao <qiankun.miao@intel.com> on 2012-12-23
Reviewed by Kentaro Hara.
class LayerChromium doesn't exist any more. Just remove the unused
code.
- platform/graphics/chromium/Canvas2DLayerBridge.h:
- 6:57 PM Changeset in webkit [138429] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the Qt build.
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- 6:34 PM Changeset in webkit [138428] by
-
- 11 edits in trunk/Source/WebKit2
Remove more special cased message receiving code from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=105700
Reviewed by Dan Bernstein.
Makes WebApplicationCacheManager, WebResourceCacheManager and WebDatabaseManager
CoreIPC::MessageReceivers, removes them as special cases in WebProcess.
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
(WebKit::WebApplicationCacheManager::setAppCacheMaximumSize):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebKit):
(WebApplicationCacheManager):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):
(WebKit::InjectedBundle::clearApplicationCache):
(WebKit::InjectedBundle::setAppCacheMaximumSize):
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::WebResourceCacheManager):
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebKit):
(WebResourceCacheManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit):
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManager::deleteAllDatabases):
(WebKit::WebDatabaseManager::setQuotaForOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebKit):
(WebDatabaseManager):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::applicationCacheManager):
(WebKit::WebProcess::resourceCacheManager):
(WebKit::WebProcess::databaseManager):
- 5:29 PM Changeset in webkit [138427] by
-
- 39 edits in trunk/Source
<rdar://problem/12808377> Network process should respect cookie accept policy
https://bugs.webkit.org/show_bug.cgi?id=105684
Reviewed by Sam Weinig.
Source/WebCore:
Changed cookie change observer to not use platform strategies, to make it usable
in NetworkProcess. startObservingCookieChanges() now just takes a callback pointer.
- WebCore.exp.in:
- platform/CookiesStrategy.h:
- platform/network/CookieStorage.h:
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::startObservingCookieChanges):
- platform/network/mac/CookieStorageMac.mm:
(-[WebCookieStorageObjCAdapter notifyCookiesChangedOnMainThread]):
(-[WebCookieStorageObjCAdapter startListeningForCookieChangeNotificationsWithCallback:]):
(WebCore::startObservingCookieChanges):
Source/WebKit/efl:
- WebCoreSupport/PlatformStrategiesEfl.cpp:
- WebCoreSupport/PlatformStrategiesEfl.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/gtk:
- WebCoreSupport/PlatformStrategiesGtk.cpp:
- WebCoreSupport/PlatformStrategiesGtk.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
CookiesStrategy no longer has notifyCookiesChanged().
Source/WebKit/qt:
- WebCoreSupport/PlatformStrategiesQt.cpp:
- WebCoreSupport/PlatformStrategiesQt.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
- WebCoreSupport/WebPlatformStrategies.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/wince:
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
- WebCoreSupport/PlatformStrategiesWinCE.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initialize): Tell cookie manager which connection to
make calls on. Now that the code can run in either WebProcess or NetworkProcess,
it cannot use WebProcess singleton.
(WebKit::NetworkProcess::didReceiveMessage): Dispatch WebCookieManager messages.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initialize): Tell cookie manager which connection to
make calls on.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge): Changed to use
WebContext::networkingProcessConnection() instead of deciding upon the connection here.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage): Call m_webContext->dispatchMessage),
as WebCookieManagerProxy handlers are registered on the context. This may seem wasteful,
but a lot of registered managers will need the ame handling soon.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::networkingProcessConnection): Added a way to get connection
to whichever process performs networking.
(WebKit::WebContext::removeNetworkProcessProxy): Invalidate cookie manager proxy,
so that expected responses could be cleared.
(WebKit::WebContext::disconnectProcess): Updated a FIXME.
- UIProcess/WebContext.h: Deleted deprecatedSharedProcess().
(WebKit::WebContext::networkingProcessConnection): Added.
(WebKit::WebContext::sendToNetworkingProcess): Added.
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary): Added.
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::shouldTerminate): Should not prevent WebProcess
termination when NetworkProcess is in use.
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Removed a useless ASSERT
that neiter documents expectations nor helps find bugs. Send a message to correct
process, whether WebProcess or NetworkProcess.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Ditto.
(WebKit::WebCookieManagerProxy::deleteAllCookies): Ditto.
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): Ditto.
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy): Ditto.
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Cookies/WebCookieManager.cpp: Made the class usable in either WebProcess
or NetworkProcess.
(WebKit::WebCookieManager::setConnection): WebCookieManager now remembers which
connection to talk back on.
(WebKit::WebCookieManager::didReceiveMessage): Added an assertion that stored connection
matches the one being used to reciev messages.
(WebKit::WebCookieManager::getHostnamesWithCookies): Use the stored connection to
send a reply.
(WebKit::WebCookieManager::startObservingCookieChanges): Pass a callback function,
so that WebCore doesn't have to use a platform strategy.
(WebKit::WebCookieManager::cookiesDidChange): The new callback.
(WebKit::WebCookieManager::dispatchCookiesDidChange): Use the stored connection.
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy): Use the stored connection.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Removed notifyCookiesChanged() which is no longer part of CookiesStrategy.
- 1:03 PM Changeset in webkit [138426] by
-
- 10 edits in trunk/Source/WebKit2
Make CustomProtocolManager a MessageReceiver to remove more special casing
https://bugs.webkit.org/show_bug.cgi?id=105682
Reviewed by Dan Bernstein.
To avoid storing a Connection in CustomProtocolManager, which is not a great idea without
it being the Connection::Client and therefore getting death notifications, I also made
ChildProcess a MessageSender so that extensions to it, like CustomProtocolManager, can
easily send messages to the parent process.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
Initialize the shared CustomProtocolManager, which will add it to the MessageReceiverMap in
the ChildProcess.
(WebKit::NetworkProcess::didReceiveMessage):
Remove the special case for CustomProtocolManager.
(WebKit::NetworkProcess::initializeNetworkProcess):
Call connectionEstablished on the CustomProtocolManager to make it start working as a NSURLProtocol handler.
- NetworkProcess/NetworkProcess.h:
Add overrides necessary for MessageSender.
- PluginProcess/PluginProcess.h:
Ditto.
- Shared/ChildProcess.h:
(ChildProcess):
Make ChildProcess a MessageSender.
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
(WebKit::CustomProtocolManager::childProcess):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::CustomProtocolManager::CustomProtocolManager):
(WebKit::CustomProtocolManager::initialize):
(WebKit::CustomProtocolManager::connectionEstablished):
Make CustomProtocolManager a MessageReceiver and split initialization and the time when it can
start acting as protocol handler as these happen at different times now. It also now stores a
ChildProcess rather than a Connection.
- SharedWorkerProcess/SharedWorkerProcess.h:
Add overrides necessary for MessageSender.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
Initialize the shared CustomProtocolManager, which will add it to the MessageReceiverMap in
the ChildProcess.
(WebKit::WebProcess::didReceiveMessage):
Remove the special case for CustomProtocolManager.
(WebKit::WebProcess::initializeCustomProtocolManager):
Call connectionEstablished on the CustomProtocolManager to make it start working as a NSURLProtocol handler.
- WebProcess/WebProcess.h:
Add overrides necessary for MessageSender.
- 12:22 PM Changeset in webkit [138425] by
-
- 5 edits in trunk
[GTK] Remove plugin process configuration option
https://bugs.webkit.org/show_bug.cgi?id=105564
Reviewed by Carlos Garcia Campos.
Remove the --enable-plugin-process configuration option, opting instead to
always build the plugin process when building WebKit2. It isn't very interesting
for downstream to enable or disable the plugin process. It should always be
enabled for WebKit2 and it's better for us not to have to keep a disabled plugin
process building. Additionally, the in-process plugin isn't functional, since
plugins depend on GTK+ 2 and WebKit2 depends on GTK+ 3.
.:
- configure.ac: Remove the configuration option.
Source/WebKit2:
- GNUmakefile.am: Remove the option.
- GNUmakefile.list.am: Remote the option.
- 9:52 AM Changeset in webkit [138424] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Specify tile usage enum for backingstore tiles.
https://bugs.webkit.org/show_bug.cgi?id=105688
RIM PR 262120
Reviewed by George Staikos.
This enables us to have separate tile sizes for
backingstore / root layer purposes and generic layers.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::tileSize):
- 9:35 AM Changeset in webkit [138423] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding crashing expectations for two tests that constantly crash
in debug builds.
- platform/gtk/TestExpectations:
- 9:28 AM Changeset in webkit [138422] by
-
- 4 edits1 add in trunk
Add a patch to fix libxml2 2.9.0 regression
https://bugs.webkit.org/show_bug.cgi?id=104494
Reviewed by Martin Robinson.
- gtk/jhbuild.modules:
- gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
Unskip tests that were failing in libxml 2.9.0
https://bugs.webkit.org/show_bug.cgi?id=104494
Reviewed by Martin Robinson.
Added a patch from upstream to the jhbuild config to make all but
one of these pass again; the remaining one fails for a different
reason and is being tracked in a different bug.
- platform/gtk/TestExpectations:
- 9:04 AM Changeset in webkit [138421] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Mac] Unreviewed fix the build after r138413
https://bugs.webkit.org/show_bug.cgi?id=105686
Don't use a temporary const reference so the compiler doesn't make a copy.
An example compile error (clang):
Source/WebCore/loader/CookieJar.cpp:73:67: error: copying parameter of type 'WebCore::NetworkStorageSession' invokes deleted constructor
return platformStrategies()->cookiesStrategy()->cookiesForDOM(SESSION(document), document->firstPartyForCookies(), url);
- loader/CookieJar.cpp:
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- 6:59 AM Changeset in webkit [138420] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening
Rebaseline fast/js/global-constructors.html after
r138393.
- platform/efl/fast/js/global-constructors-expected.txt:
- 6:13 AM Changeset in webkit [138419] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed Xmas gardening after r138395.
- platform/qt-5.0/fast/js/global-constructors-expected.txt:
- 5:16 AM Changeset in webkit [138418] by
-
- 2 edits in trunk/Tools
Unreviewed update of status to reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 1:28 AM Changeset in webkit [138417] by
-
- 7 edits in branches/chromium/1312
Merge 138365
Fix typing zero into multiple field input
https://bugs.webkit.org/show_bug.cgi?id=105501
Reviewed by Kent Tamura.
Source/WebCore:
We have a couple of problems when handling zero in a multiple fields
element.
- Typing '02' into a month field will set '12'.
- Typing '0' into 12 hour hour field will set '12' and move to the focus to the next field.
This change adds a type ahead buffer so we can handle these cases
properly. If the value in the type ahead buffer is valid we set it so a
change event will fire.
Added tests to *-multiple-fields-keyboard-events.html.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::didBlur): Clear the type ahead
buffer. handleKeyboardEvent() won't set the type ahead value if it is
not in range, so we set the value here.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::stepDown): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::stepUp): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::typeAheadValue): Returns integer
value for the type ahead characters.
(WebCore):
(WebCore::DateTimeNumericFieldElement::visibleValue): If we have type
ahead characters, show that.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
- fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:
TBR=keishi@webkit.org
BUG=crbug.com/167020
Review URL: https://codereview.chromium.org/11665021
- 12:53 AM Changeset in webkit [138416] by
-
- 2 edits in trunk/Tools
[GTK][jhbuild] Bump GStreamer to 1.0.4
https://bugs.webkit.org/show_bug.cgi?id=105640
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
Dec 22, 2012:
- 8:44 PM EFLWebKitTests edited by
- (diff)
- 6:36 PM Changeset in webkit [138415] by
-
- 9 edits in trunk/Source/WebKit2
Give the ChildProcess a MessageReceiverMap
https://bugs.webkit.org/show_bug.cgi?id=105681
Reviewed by Dan Bernstein.
Moving the MessageReceiverMap to the ChildProcess will help shared code
between the WebProcess and NetworkProcess.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
Pass 'this' instead of the MessageReceiverMap, now that ChildProcess
can be used to access the MessageReceiverMap.
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
Remove the now extraneous MessageReceiverMap.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess):
(WebKit):
(WebKit::ChildProcess::~ChildProcess):
(WebKit::ChildProcess::addMessageReceiver):
(WebKit::ChildProcess::removeMessageReceiver):
- Shared/ChildProcess.h:
(ChildProcess):
Add a MessageReceiverMap and helper functions from WebProcess.
- WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
- WebProcess/Authentication/AuthenticationManager.h:
(AuthenticationManager):
Fix the FIXME, passing the ChildProcess rather than the MessageReceiverMap.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
(WebProcess):
Remove the MessageReceiverMap and helper functions.
- 6:19 PM Changeset in webkit [138414] by
-
- 2 edits in trunk/Source/WebKit2
Windows build fix.
- WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
- 6:15 PM Changeset in webkit [138413] by
-
- 90 edits3 adds2 deletes in trunk/Source
Add a separate class for networking related storage
https://bugs.webkit.org/show_bug.cgi?id=105676
Reviewed by Sam Weinig.
NetworkingContext combines a reference to storage (cookies and more) and data that's
only meaningful when loading. This makes it very ugly to use for cookie manipulation
when there is no load (e.g. for document.cookie).
Adding NetworkStorageSession, which encorportes network-related sesion data, such
as cookies and session HTTP credentials.
For some ports, refactoring is not finished, NetworkStorageSession being a wrapper
for NetworkingContext.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Updated for new files and functions.
- platform/network/PlatformCookieJar.h:
- loader/CookieJar.cpp:
- platform/CookiesStrategy.h:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/chromium/CookieJarChromium.cpp:
- platform/network/curl/CookieJarCurl.cpp:
- platform/network/mac/CookieJarMac.mm:
- platform/network/qt/CookieJarQt.cpp:
- platform/network/soup/CookieJarSoup.cpp:
- platform/network/win/CookieJarWin.cpp: PlatformCookieJar and strategy cookie functions now take a NetworkStorageSession instead of NetworkingContext. Note that they take a const reference to support creating a temporary session wrapper for ports that just wrap a NetworkingContext.
- loader/ResourceLoader.cpp:
- loader/cache/CachedResource.h:
- platform/network/BlobResourceHandle.cpp:
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/chromium/ResourceHandle.cpp:
- platform/network/curl/ResourceHandleCurl.cpp:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/soup/DNSSoup.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/win/ResourceHandleWin.cpp: ResourceHandle no longer includes unneeded NetworkingContext.h and AuthenticationClient.h. This avoids near-world rebuilds on any NetworkingContext change.
- platform/network/NetworkStorageSession.h: Added.
- platform/network/NetworkStorageSessionStub.cpp: Added.
- platform/network/cf/NetworkStorageSessionCFNet.cpp: Added. Good new stuff. Stub version just wraps NetworkingContext for platforms that still need to finish the refactoring.
- platform/network/NetworkingContext.h: The context now has a NetworkStorageSession, and doesn't expose CFNet level objects directly.
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/cf/CookieStorageCFNet.h: Removed. We no longer have separate free functions to track storage, it's part of NetworkStorageSession now.
- platform/network/cf/ResourceHandleCFNet.cpp: Updated to use NetworkStorageSession.
- platform/network/mac/CookieStorageMac.mm: Dont include CookieStorageCFNet.h, it was not needed.
- 3:14 PM Changeset in webkit [138412] by
-
- 2 edits in trunk/Source/WebCore
InlineTextBox: Remove potentially confusing "} if" pattern.
https://bugs.webkit.org/show_bug.cgi?id=105499
Reviewed by Ojan Vafai.
It's not clear to me on first look if this is intentional or missing
an "else" (and this pattern was used in just one other place in
webkit, which I've removed). It turns out no else is missing here,
this is checked by fast/text/justified-selection.html
- rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows):
- 2:35 PM FeatureFlags edited by
- Remove COMMANDLINE_TYPEDARRAYS from the list - see r114575 (diff)
- 2:28 PM FeatureFlags edited by
- Remove JIT_USE_SOFT_MODULO from the list - see r111481 (diff)
- 1:53 PM FeatureFlags edited by
- Remove CLASSIC_INTERPRETER and COMPUTED_GOTO_CLASSIC_INTERPRETER from … (diff)
- 1:07 PM FeatureFlags edited by
- Remove ARM_NEON_INTRINSICS from the list as it is not an ENABLE flag - … (diff)
- 12:54 PM FeatureFlags edited by
- Remove RUN_TIME_HEURISTICS from the list - see r131089 (diff)
- 12:38 PM FeatureFlags edited by
- Remove SKIA_GPU_CANVAS from the list - see r97570 (diff)
- 12:28 PM FeatureFlags edited by
- Remove MAC_JAVA_BRIDGE from the list - see r129964 (diff)
- 12:20 PM FeatureFlags edited by
- Remove CSS3_FLEXBOX from the list - see r100198 (diff)
- 12:15 PM FeatureFlags edited by
- Fix typo - DRAGGBALE -> DRAGGABLE (diff)
- 12:11 PM FeatureFlags edited by
- Remove DATABASE from the list - see r95271 (diff)
- 12:00 AM Changeset in webkit [138411] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining the global constructors test after r138393.
Adjusting and merging expectations as required.
- platform/gtk/TestExpectations:
- platform/gtk/fast/js/global-constructors-expected.txt:
