⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 24, 2012:

11:53 PM Changeset in webkit [138455] by loislo@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed compilation fix for r138452.

11:41 PM Changeset in webkit [138454] by yurys@chromium.org
  • 7 edits in trunk/Source

Memory instrumentation: provide a way to mark a node as a root
https://bugs.webkit.org/show_bug.cgi?id=105737

Reviewed by Alexander Pavlov.

Source/WebCore:

Extended HeapGraphSerializer to add a fake root node with edges to all
real instrumentation roots.

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::addRootNode):
(WebCore):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

Source/WTF:

Objects added using MemoryInstrumentation::addRootObject will be marked as roots.

  • wtf/MemoryInstrumentation.cpp:

(WTF::MemoryInstrumentation::WrapperBase::process):
(WTF):
(WTF::MemoryInstrumentation::WrapperBase::processPointer):
(WTF::MemoryInstrumentation::WrapperBase::processRootObjectRef):

  • wtf/MemoryInstrumentation.h:

(WrapperBase):

  • wtf/MemoryObjectInfo.h: added root marker which can be used by the heap graph builder.

(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::isRoot):
(WTF::MemoryObjectInfo::markAsRoot):
(MemoryObjectInfo):

11:26 PM Changeset in webkit [138453] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add message listener only in case of standalone test-runner.html
https://bugs.webkit.org/show_bug.cgi?id=105715

Reviewed by Pavel Feldman.

Tell InspectorFrontendAPI that it is launched by standalone test runner so that it
can decide whether message event listener should be added.

  • inspector/front-end/InspectorFrontendAPI.js:
  • inspector/front-end/test-runner.html:
11:01 PM Changeset in webkit [138452] by loislo@chromium.org
  • 10 edits in trunk

Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
https://bugs.webkit.org/show_bug.cgi?id=105725

Reviewed by Yury Semikhatsky.

Source/WebCore:

MemoryOwningType was renamed to MemberType.
Source argument were removed from reportEdge, reportLeaf and other edge related methods because it is not necessary.
MemberType argument was propagated from MemoryInstrumentation down to HeapGraphSerializer.

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphEdge::HeapGraphEdge):
(HeapGraphEdge):
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportEdge):
(WebCore::HeapGraphSerializer::reportLeaf):
(WebCore::HeapGraphSerializer::serialize):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportEdge):
(WebCore::MemoryInstrumentationClientImpl::reportLeaf):

  • inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationClientImpl):

Source/WTF:

MemoryOwningType was renamed to MemberType.
Source argument were removed from reportEdge, reportLeaf and other edge related methods because it is not necessary.
MemberType argument was propagated from MemoryInstrumentation down to HeapGraphSerializer.

The changes covered by tests in TestWebKitAPI.

  • wtf/MemoryInstrumentation.cpp:

(WTF::MemoryInstrumentation::reportEdge):
(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentationClient):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addRawBuffer):
(WTF::MemoryInstrumentation::MemberTypeTraits::addObject):
(WTF::MemoryInstrumentation::addObjectImpl):

Tools:

MemberType value names were adjusted according to Style Guide.
Existing tests were extended with link type validation.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
10:16 PM Changeset in webkit [138451] by tasak@google.com
  • 3 edits
    2 adds in trunk

::first-letter { overflow: -webkit-paged-y } causes crash
https://bugs.webkit.org/show_bug.cgi?id=105393

Reviewed by Beth Dakin.

Source/WebCore:

Should check whether e is available or not before invoking
e->hasTagName in adjustRenderStyle in StyleResolver.cpp.

Test: fast/css/pseudo-element-opagedxy-crash.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
If adjustRenderStyle is invoked in pseudoStyleForElement, the given
element is 0. So e is not available. However if the given style's
overflowY is OPAGEDX or OPAGEDY, adjustRenderStyle doesn't check
whether e is available or not before e->hasTagName.
This causes a crash.

LayoutTests:

  • fast/css/pseudo-element-opagedxy-crash-expected.txt: Added.
  • fast/css/pseudo-element-opagedxy-crash.html: Added.
9:23 PM Changeset in webkit [138450] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Web Inspector: add async API for passing renderer process memory stats
https://bugs.webkit.org/show_bug.cgi?id=105278

Patch by Alexei Filippov <alph@chromium.org> on 2012-12-24
Reviewed by Yury Semikhatsky.

On some platforms (e.g. Linux) it may take some time to collect
total process memory information as it involves an IPC out of a
sandboxed renderer process. So add an async way to collect the statistics.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):
(ProcessMemorySizesCallback):
(WebKit::Platform::ProcessMemorySizesCallback::~ProcessMemorySizesCallback):
(WebKit::Platform::requestProcessMemorySizes):

Source/WebCore:

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):
(ProcessMemorySizesCallback):
(WebCore::MemoryUsageSupport::ProcessMemorySizesCallback::~ProcessMemorySizesCallback):

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):

  • platform/qt/MemoryUsageSupportQt.cpp:

(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):

6:17 PM Changeset in webkit [138449] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Remove wtf/Platform.h includes from {c|cpp} files
https://bugs.webkit.org/show_bug.cgi?id=105678

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-12-24
Reviewed by Kentaro Hara.

Remove wtf/Platform.h from the include list as it is already
included in config.h.

Source/JavaScriptCore:

  • disassembler/udis86/udis86.c:
  • disassembler/udis86/udis86_decode.c:
  • disassembler/udis86/udis86_input.c:
  • disassembler/udis86/udis86_itab_holder.c:
  • disassembler/udis86/udis86_syn-att.c:
  • disassembler/udis86/udis86_syn-intel.c:
  • disassembler/udis86/udis86_syn.c:
  • heap/VTableSpectrum.cpp:

Source/WebCore:

No new tests as there is no new functionality.

  • rendering/svg/RenderSVGRect.cpp:

Source/WebKit2:

  • Shared/qt/QtNetworkRequestData.cpp:
5:17 PM Changeset in webkit [138448] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Follow up fixes for r137739
https://bugs.webkit.org/show_bug.cgi?id=104982

Reviewed by Ryosuke Niwa.

Applied darin's comments in https://bugs.webkit.org/show_bug.cgi?id=104982#c18

No tests. No change in behavior.

  • dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::nextNode):

11:37 AM Changeset in webkit [138447] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Update BB10 media render theme.
https://bugs.webkit.org/show_bug.cgi?id=105728

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-12-24
Reviewed by Rob Buis.

Internally reviewed by John Griggs.
Use GL renderer to paint media control.

  • css/mediaControlsBlackBerry.css:

(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):

10:28 AM Changeset in webkit [138446] by mihnea@adobe.com
  • 2 edits
    1 add
    14 deletes in trunk/LayoutTests

[CSS Regions] Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=80191

Reviewed by Tony Chang.

Convert fast/regions/bottom-overflow-out-of-first-region.html to a ref test.
Used a monospace font, removed text-align and margins for text flowing into regions so that
the text fits nicely in the two regions of the test.

  • fast/regions/bottom-overflow-out-of-first-region-expected.html: Added.
  • fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • platform/chromium-linux/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac-lion/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
10:19 AM Changeset in webkit [138445] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Assert fix take 2.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):

10:12 AM Changeset in webkit [138444] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix WebKit2 asserting on launch.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::databaseManager):
(WebProcess):

8:45 AM Changeset in webkit [138443] by commit-queue@webkit.org
  • 20 edits in trunk/Source/WebCore

Unreviewed, rolling out r138436.
http://trac.webkit.org/changeset/138436
https://bugs.webkit.org/show_bug.cgi?id=105723

Asserts on state restoration in debug builds (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-24

  • inspector/InspectorAgent.cpp:

(InspectorAgentState):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::disable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::inspect):

  • inspector/InspectorApplicationCacheAgent.cpp:

(ApplicationCacheAgentState):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):

  • inspector/InspectorCSSAgent.cpp:

(CSSAgentState):
(WebCore::InspectorCSSAgent::restore):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):

  • inspector/InspectorCanvasAgent.cpp:

(CanvasAgentState):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorController.h:

(WebCore):
(InspectorController):

  • inspector/InspectorDOMStorageAgent.cpp:

(DOMStorageAgentState):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):

  • inspector/InspectorDatabaseAgent.cpp:

(DatabaseAgentState):
(WebCore):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::restore):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::disable):

  • inspector/InspectorFileSystemAgent.cpp:

(FileSystemAgentState):
(WebCore):
(WebCore::InspectorFileSystemAgent::enable):
(WebCore::InspectorFileSystemAgent::disable):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::restore):

  • inspector/InspectorIndexedDBAgent.cpp:

(IndexedDBAgentState):
(WebCore):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):

  • inspector/InspectorLayerTreeAgent.cpp:

(LayerTreeAgentState):
(WebCore::InspectorLayerTreeAgent::restore):
(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::webViewResized):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore::InspectorPageAgent::setShowFPSCounter):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::applyScreenWidthOverride):
(WebCore::InspectorPageAgent::applyScreenHeightOverride):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::applyEmulatedMedia):

  • inspector/InspectorResourceAgent.cpp:

(ResourceAgentState):
(WebCore::InspectorResourceAgent::restore):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):

  • inspector/InspectorState.cpp:

(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::loadFromCookie):
(WebCore):
(WebCore::InspectorState::mute):
(WebCore::InspectorState::unmute):
(WebCore::InspectorState::updateCookie):
(WebCore::InspectorState::remove):

  • inspector/InspectorState.h:

(WebCore):
(InspectorState):
(WebCore::InspectorState::setLong):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineAgentState):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/WorkerInspectorController.h:

(WebCore):
(WorkerInspectorController):

7:59 AM Changeset in webkit [138442] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Keep LiveEdit API disabled when idle
https://bugs.webkit.org/show_bug.cgi?id=104039

Patch by Peter Rybin <prybin@chromium.org> on 2012-12-24
Reviewed by Pavel Feldman.

Guards are added to LiveEdit call

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setScriptSource):

6:03 AM Changeset in webkit [138441] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix various RenderQueue bugs introduced by r138024.
https://bugs.webkit.org/show_bug.cgi?id=105717
RIM PR 269029

Reviewed by George Staikos.

Scroll/zoom jobs were pretty solid, but I managed to
leave some bugs in the region handling of RenderQueue's
renderRegularRenderJobs() function, causing us to skip
a desired blit or render operation in cases where the
region and tile tracking did not match up.

This commit fixes these errors.

  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):

4:56 AM Changeset in webkit [138440] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] DRT - Crashed when running pixels tests
https://bugs.webkit.org/show_bug.cgi?id=105711

RIM PR 270003

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-12-24
Reviewed by George Staikos.

Calling window->post() here will result in buffer swapping which is
only allowed in UI thread now, and I found we don't need to call it
for GL renderer.

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView):

4:37 AM Changeset in webkit [138439] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Close page popup when a page becomes invisible.
https://bugs.webkit.org/show_bug.cgi?id=105704

Reviewed by George Staikos.

Reviewed internally by Jakob Petsovits.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setVisible):

3:23 AM Changeset in webkit [138438] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: refactor TextEditorHighlighter's highlight attributes to dense array
https://bugs.webkit.org/show_bug.cgi?id=105626

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-24
Reviewed by Pavel Feldman.

Source/WebCore:

Refactor highlight attributes from sparse array to dense array.

No new tests: no behaviour changes, coverage provided by existing tests.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):

  • inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter.prototype._highlightLines):

LayoutTests:

Fix tests according to new highlight attribute structure.

  • inspector/editor/highlighter-long-line.html:
  • inspector/editor/highlighter-test.js:

(initialize_HighlighterTests.InspectorTest.dumpTextModel):
(initialize_HighlighterTests):

2:03 AM Changeset in webkit [138437] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL [WebGL] GLES2 detection is broken.
https://bugs.webkit.org/show_bug.cgi?id=105677

We use the logic in FindGLES.cmake to detect GLES2 support during compile time.
OPENGLES2_FOUND is never set, even though OPENGLES2_INCLUDE_DIR and OPENGLES2_LIBRARY
contain right information. The name passed to find_package_handle_standard_args seems to be the issue here.
This patch changes the name passed to find_package_handle_standard_args to OPENGLES2.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-24
Reviewed by Kenneth Rohde Christiansen.

  • Source/cmake/FindGLES.cmake:
1:07 AM Changeset in webkit [138436] by apavlov@chromium.org
  • 20 edits in trunk/Source/WebCore

Web Inspector: Make use of the new InspectorState::remove() in inspector agents
https://bugs.webkit.org/show_bug.cgi?id=105438

Reviewed by Yury Semikhatsky.

This patch introduces the following refactorings:

  • setting property values of InspectorState to "empty" objects has been replaced by removing them from the state;
  • InspectorState instance is no longer shared across agents, so that the property names can no longer clash. Instead, InspectorCompositeState creates and owns InspectorState instances for every agent;
  • agent-specific prefix has been stripped from most property names, where it looked synthetic.
  • updateCookie() is called from InspectorState::remove().

No new tests, as there is no visible change in the behavior.

  • inspector/InspectorAgent.cpp: Agent-specific property name prefix stripped.
  • inspector/InspectorApplicationCacheAgent.cpp: Ditto.
  • inspector/InspectorCSSAgent.cpp: Ditto.
  • inspector/InspectorCanvasAgent.cpp: Ditto.
  • inspector/InspectorController.cpp: Make use of InspectorCompositeState rather than InspectorState.
  • inspector/InspectorController.h: Ditto.
  • inspector/InspectorDOMStorageAgent.cpp: Agent-specific property name prefix stripped.
  • inspector/InspectorDatabaseAgent.cpp: Ditto.
  • inspector/InspectorDebuggerAgent.cpp: Ditto.

(WebCore::InspectorDebuggerAgent::disable):
Use "remove" instead of setting an empty object.

  • inspector/InspectorFileSystemAgent.cpp: Agent-specific property name prefix stripped.
  • inspector/InspectorIndexedDBAgent.cpp: Ditto.
  • inspector/InspectorLayerTreeAgent.cpp: Ditto.
  • inspector/InspectorPageAgent.cpp: Ditto.

(WebCore::InspectorPageAgent::disable):
Use "remove" instead of setting empty values for certain properties.
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
Remove unnecessary code (object is created and put into the map if none is found).

  • inspector/InspectorResourceAgent.cpp: Agent-specific property name prefix stripped.

(WebCore::InspectorResourceAgent::disable):
Use "remove" instead of setting an empty object for userAgentOverride.

  • inspector/InspectorState.cpp: Add InspectorCompositeState.

(WebCore::InspectorState::setFromCookie): Gets invoked from InspectorCompositeState::loadFromCookie().
(WebCore::InspectorState::updateCookie): Call updateCookie().
(WebCore::InspectorCompositeState::createAgentState): Creates an InspectorState instance to be passed to an agent.

  • inspector/InspectorState.h: Add InspectorCompositeState.

(WebCore::InspectorState::setLong): Fix cast.

  • inspector/InspectorTimelineAgent.cpp: Agent-specific property name prefix stripped.
  • inspector/WorkerInspectorController.cpp: Make use of InspectorCompositeState rather than InspectorState.
  • inspector/WorkerInspectorController.h: Ditto.
12:19 AM Changeset in webkit [138435] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt][Win] Unreviewed Xmas buildfix after r138433.

  • WebProcess/Cookies/WebCookieManager.h:

Dec 23, 2012:

10:10 PM Changeset in webkit [138434] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Fix the incorrect use of preprocessor statement in API header
https://bugs.webkit.org/show_bug.cgi?id=105675

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-23
Reviewed by Sam Weinig.

Remove a preprocessor statement in WKBundlePage.h

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetInspector):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
9:45 PM Changeset in webkit [138433] by weinig@apple.com
  • 13 edits in trunk/Source/WebKit2

Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection
https://bugs.webkit.org/show_bug.cgi?id=105703

Reviewed by Dan Bernstein.

Also switches WebCookieManager over to be a MessageReceiver while we are at it.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initialize):
(WebKit::NetworkProcess::didReceiveMessage):

  • NetworkProcess/NetworkProcess.h:

(WebKit):

  • WebProcess/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):

  • WebProcess/Authentication/AuthenticationManager.h:

(AuthenticationManager):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit):
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::didReceiveMessage):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::cookiesDidChange):
(WebKit::WebCookieManager::dispatchCookiesDidChange):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):

  • WebProcess/Cookies/WebCookieManager.h:

(WebKit):
(WebCookieManager):

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::setCookiePersistentStorage):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setAlwaysAcceptCookies):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initialize):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):
(WebKit::WebProcess::cookieManager):

9:05 PM Changeset in webkit [138432] by Dimitri Glazkov
  • 12 edits
    2 adds in trunk/Source/WebCore

Split fast-rejection filter logic off SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=105660

The awesome Bloom filter and parent stack logic don't need to be in SelectorChecker. They nicely factor out
into their own pretty thing, named thereby SelectorFilter.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

  • CMakeLists.txt: Added SelectorFilter to build systems.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSAllInOne.cpp: Ditto.
  • css/RuleSet.cpp: Changed to use SelectorFilter.

(WebCore::RuleData::RuleData): Ditto.

  • css/SelectorChecker.cpp: Ditto.
  • css/SelectorChecker.h: Ditto.

(SelectorChecker):

  • css/StyleResolver.cpp: Ditto.

(WebCore):
(WebCore::StyleResolver::pushParentElement): Ditto.
(WebCore::StyleResolver::popParentElement): Ditto.
(WebCore::StyleResolver::collectMatchingRulesForList): Ditto.

  • css/StyleResolver.h:

(StyleResolver): Ditto.

8:43 PM Changeset in webkit [138431] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] give url when createWindow
https://bugs.webkit.org/show_bug.cgi?id=105702
RIM bug# 257329

Reviewed by George Staikos.

This is to revert previous commit 575407238c35f1a0fa7ff7dd5dbbf6cc3ece1107
for integration issue of cascade and air, as old app side still use the url
to invoke. It would unrevert after resolving the integration issue.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):

8:38 PM Changeset in webkit [138430] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused reference to "class LayerChromium"
https://bugs.webkit.org/show_bug.cgi?id=105502

Patch by Qiankun Miao <qiankun.miao@intel.com> on 2012-12-23
Reviewed by Kentaro Hara.

class LayerChromium doesn't exist any more. Just remove the unused
code.

  • platform/graphics/chromium/Canvas2DLayerBridge.h:
6:57 PM Changeset in webkit [138429] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Qt build.

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
6:34 PM Changeset in webkit [138428] by weinig@apple.com
  • 11 edits in trunk/Source/WebKit2

Remove more special cased message receiving code from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=105700

Reviewed by Dan Bernstein.

Makes WebApplicationCacheManager, WebResourceCacheManager and WebDatabaseManager
CoreIPC::MessageReceivers, removes them as special cases in WebProcess.

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
(WebKit::WebApplicationCacheManager::setAppCacheMaximumSize):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:

(WebKit):
(WebApplicationCacheManager):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):
(WebKit::InjectedBundle::clearApplicationCache):
(WebKit::InjectedBundle::setAppCacheMaximumSize):

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::WebResourceCacheManager):
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):

  • WebProcess/ResourceCache/WebResourceCacheManager.h:

(WebKit):
(WebResourceCacheManager):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit):
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManager::deleteAllDatabases):
(WebKit::WebDatabaseManager::setQuotaForOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:

(WebKit):
(WebDatabaseManager):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):
(WebKit::WebProcess::applicationCacheManager):
(WebKit::WebProcess::resourceCacheManager):
(WebKit::WebProcess::databaseManager):

5:29 PM Changeset in webkit [138427] by ap@apple.com
  • 39 edits in trunk/Source

<rdar://problem/12808377> Network process should respect cookie accept policy
https://bugs.webkit.org/show_bug.cgi?id=105684

Reviewed by Sam Weinig.

Source/WebCore:

Changed cookie change observer to not use platform strategies, to make it usable
in NetworkProcess. startObservingCookieChanges() now just takes a callback pointer.

  • WebCore.exp.in:
  • platform/CookiesStrategy.h:
  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::startObservingCookieChanges):

  • platform/network/mac/CookieStorageMac.mm:

(-[WebCookieStorageObjCAdapter notifyCookiesChangedOnMainThread]):
(-[WebCookieStorageObjCAdapter startListeningForCookieChangeNotificationsWithCallback:]):
(WebCore::startObservingCookieChanges):

Source/WebKit/efl:

  • WebCoreSupport/PlatformStrategiesEfl.cpp:
  • WebCoreSupport/PlatformStrategiesEfl.h:

CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:
  • WebCoreSupport/PlatformStrategiesGtk.h:

CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

CookiesStrategy no longer has notifyCookiesChanged().

Source/WebKit/qt:

  • WebCoreSupport/PlatformStrategiesQt.cpp:
  • WebCoreSupport/PlatformStrategiesQt.h:

CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.

Source/WebKit/win:

  • WebCoreSupport/WebPlatformStrategies.cpp:
  • WebCoreSupport/WebPlatformStrategies.h:

CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:
  • WebCoreSupport/PlatformStrategiesWinCE.h:

CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initialize): Tell cookie manager which connection to
make calls on. Now that the code can run in either WebProcess or NetworkProcess,
it cannot use WebProcess singleton.
(WebKit::NetworkProcess::didReceiveMessage): Dispatch WebCookieManager messages.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initialize): Tell cookie manager which connection to
make calls on.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didReceiveAuthenticationChallenge): Changed to use
WebContext::networkingProcessConnection() instead of deciding upon the connection here.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveMessage): Call m_webContext->dispatchMessage),
as WebCookieManagerProxy handlers are registered on the context. This may seem wasteful,
but a lot of registered managers will need the ame handling soon.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::networkingProcessConnection): Added a way to get connection
to whichever process performs networking.
(WebKit::WebContext::removeNetworkProcessProxy): Invalidate cookie manager proxy,
so that expected responses could be cleared.
(WebKit::WebContext::disconnectProcess): Updated a FIXME.

  • UIProcess/WebContext.h: Deleted deprecatedSharedProcess().

(WebKit::WebContext::networkingProcessConnection): Added.
(WebKit::WebContext::sendToNetworkingProcess): Added.
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary): Added.

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::shouldTerminate): Should not prevent WebProcess
termination when NetworkProcess is in use.
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Removed a useless ASSERT
that neiter documents expectations nor helps find bugs. Send a message to correct
process, whether WebProcess or NetworkProcess.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Ditto.
(WebKit::WebCookieManagerProxy::deleteAllCookies): Ditto.
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): Ditto.
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy): Ditto.

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Cookies/WebCookieManager.cpp: Made the class usable in either WebProcess

or NetworkProcess.
(WebKit::WebCookieManager::setConnection): WebCookieManager now remembers which
connection to talk back on.
(WebKit::WebCookieManager::didReceiveMessage): Added an assertion that stored connection
matches the one being used to reciev messages.
(WebKit::WebCookieManager::getHostnamesWithCookies): Use the stored connection to
send a reply.
(WebKit::WebCookieManager::startObservingCookieChanges): Pass a callback function,
so that WebCore doesn't have to use a platform strategy.
(WebKit::WebCookieManager::cookiesDidChange): The new callback.
(WebKit::WebCookieManager::dispatchCookiesDidChange): Use the stored connection.
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy): Use the stored connection.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Removed notifyCookiesChanged() which is no longer part of CookiesStrategy.

1:03 PM Changeset in webkit [138426] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Make CustomProtocolManager a MessageReceiver to remove more special casing
https://bugs.webkit.org/show_bug.cgi?id=105682

Reviewed by Dan Bernstein.

To avoid storing a Connection in CustomProtocolManager, which is not a great idea without
it being the Connection::Client and therefore getting death notifications, I also made
ChildProcess a MessageSender so that extensions to it, like CustomProtocolManager, can
easily send messages to the parent process.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
Initialize the shared CustomProtocolManager, which will add it to the MessageReceiverMap in
the ChildProcess.

(WebKit::NetworkProcess::didReceiveMessage):
Remove the special case for CustomProtocolManager.

(WebKit::NetworkProcess::initializeNetworkProcess):
Call connectionEstablished on the CustomProtocolManager to make it start working as a NSURLProtocol handler.

  • NetworkProcess/NetworkProcess.h:

Add overrides necessary for MessageSender.

  • PluginProcess/PluginProcess.h:

Ditto.

  • Shared/ChildProcess.h:

(ChildProcess):
Make ChildProcess a MessageSender.

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):
(WebKit::CustomProtocolManager::childProcess):

  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::CustomProtocolManager::CustomProtocolManager):
(WebKit::CustomProtocolManager::initialize):
(WebKit::CustomProtocolManager::connectionEstablished):
Make CustomProtocolManager a MessageReceiver and split initialization and the time when it can
start acting as protocol handler as these happen at different times now. It also now stores a
ChildProcess rather than a Connection.

  • SharedWorkerProcess/SharedWorkerProcess.h:

Add overrides necessary for MessageSender.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
Initialize the shared CustomProtocolManager, which will add it to the MessageReceiverMap in
the ChildProcess.

(WebKit::WebProcess::didReceiveMessage):
Remove the special case for CustomProtocolManager.

(WebKit::WebProcess::initializeCustomProtocolManager):
Call connectionEstablished on the CustomProtocolManager to make it start working as a NSURLProtocol handler.

  • WebProcess/WebProcess.h:

Add overrides necessary for MessageSender.

12:22 PM Changeset in webkit [138425] by Martin Robinson
  • 5 edits in trunk

[GTK] Remove plugin process configuration option
https://bugs.webkit.org/show_bug.cgi?id=105564

Reviewed by Carlos Garcia Campos.

Remove the --enable-plugin-process configuration option, opting instead to
always build the plugin process when building WebKit2. It isn't very interesting
for downstream to enable or disable the plugin process. It should always be
enabled for WebKit2 and it's better for us not to have to keep a disabled plugin
process building. Additionally, the in-process plugin isn't functional, since
plugins depend on GTK+ 2 and WebKit2 depends on GTK+ 3.

.:

  • configure.ac: Remove the configuration option.

Source/WebKit2:

  • GNUmakefile.am: Remove the option.
  • GNUmakefile.list.am: Remote the option.
9:52 AM Changeset in webkit [138424] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Specify tile usage enum for backingstore tiles.
https://bugs.webkit.org/show_bug.cgi?id=105688
RIM PR 262120

Reviewed by George Staikos.

This enables us to have separate tile sizes for
backingstore / root layer purposes and generic layers.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::tileSize):

9:35 AM Changeset in webkit [138423] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding crashing expectations for two tests that constantly crash
in debug builds.

  • platform/gtk/TestExpectations:
9:28 AM Changeset in webkit [138422] by danw@gnome.org
  • 4 edits
    1 add in trunk

Add a patch to fix libxml2 2.9.0 regression
https://bugs.webkit.org/show_bug.cgi?id=104494

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules:
  • gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream

Unskip tests that were failing in libxml 2.9.0
https://bugs.webkit.org/show_bug.cgi?id=104494

Reviewed by Martin Robinson.

Added a patch from upstream to the jhbuild config to make all but
one of these pass again; the remaining one fails for a different
reason and is being tracked in a different bug.

  • platform/gtk/TestExpectations:
9:04 AM Changeset in webkit [138421] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[Qt][Mac] Unreviewed fix the build after r138413
https://bugs.webkit.org/show_bug.cgi?id=105686

Don't use a temporary const reference so the compiler doesn't make a copy.
An example compile error (clang):
Source/WebCore/loader/CookieJar.cpp:73:67: error: copying parameter of type 'WebCore::NetworkStorageSession' invokes deleted constructor

return platformStrategies()->cookiesStrategy()->cookiesForDOM(SESSION(document), document->firstPartyForCookies(), url);

  • loader/CookieJar.cpp:

(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

6:59 AM Changeset in webkit [138420] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening

Rebaseline fast/js/global-constructors.html after
r138393.

  • platform/efl/fast/js/global-constructors-expected.txt:
6:13 AM Changeset in webkit [138419] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed Xmas gardening after r138395.

  • platform/qt-5.0/fast/js/global-constructors-expected.txt:
5:16 AM Changeset in webkit [138418] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

Unreviewed update of status to reviewer.

  • Scripts/webkitpy/common/config/committers.py:
1:28 AM Changeset in webkit [138417] by tkent@chromium.org
  • 7 edits in branches/chromium/1312

Merge 138365

Fix typing zero into multiple field input
https://bugs.webkit.org/show_bug.cgi?id=105501

Reviewed by Kent Tamura.

Source/WebCore:

We have a couple of problems when handling zero in a multiple fields
element.

  1. Typing '02' into a month field will set '12'.
  2. Typing '0' into 12 hour hour field will set '12' and move to the focus to the next field.

This change adds a type ahead buffer so we can handle these cases
properly. If the value in the type ahead buffer is valid we set it so a
change event will fire.

Added tests to *-multiple-fields-keyboard-events.html.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::didBlur): Clear the type ahead
buffer. handleKeyboardEvent() won't set the type ahead value if it is
not in range, so we set the value here.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::stepDown): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::stepUp): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::typeAheadValue): Returns integer
value for the type ahead characters.
(WebCore):
(WebCore::DateTimeNumericFieldElement::visibleValue): If we have type
ahead characters, show that.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement):

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:

TBR=keishi@webkit.org
BUG=crbug.com/167020
Review URL: https://codereview.chromium.org/11665021

12:53 AM Changeset in webkit [138416] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK][jhbuild] Bump GStreamer to 1.0.4
https://bugs.webkit.org/show_bug.cgi?id=105640

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
Note: See TracTimeline for information about the timeline view.