Timeline
Dec 25, 2012:
- 11:24 PM Changeset in webkit [138472] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=105753
Reviewed by Laszlo Gombos.
- CMakeLists.txt: Remove header files in source list.
- 6:36 PM Changeset in webkit [138471] by
-
- 4 edits in trunk/Source/WebKit2
Fix the Database manager assert, again.
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit):
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::initialize):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 6:29 PM Changeset in webkit [138470] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to initialize the onLine in the global
https://bugs.webkit.org/show_bug.cgi?id=105749
Reviewed by George Staikos.
The NetworkStatus is initialized to online in the constructor by default,
we need to update it correctly with the network status at startup.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
- 6:15 PM Changeset in webkit [138469] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Media controls are drawn on top of one another for media with unknown duration.
https://bugs.webkit.org/show_bug.cgi?id=105747
Patch by John Griggs <jgriggs@rim.com> on 2012-12-25
Reviewed by George Staikos.
No need to reposition controls when there is no timeline element, this mispositions them in the new design.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
- 6:04 PM Changeset in webkit [138468] by
-
- 8 edits in trunk/Source/WebKit2
Coordinated Graphics: Manage the lifecycle of CoordinatedGraphicsLayer explicitly.
https://bugs.webkit.org/show_bug.cgi?id=104990
Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-25
Reviewed by Noam Rosenthal.
Send explicit commands to the UI process to create/delete compositing
layers, instead of having the UI process decide lazily when to create
them.
Avoid creating a compositing layer at all if it was deleted in the same
cycle.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::createCompositingLayer):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::createCanvas):
(WebKit::LayerTreeRenderer::destroyCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::getLayerByIDIfExists):
(WebKit):
(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::setRootLayerID):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::ensureRootLayer):
(WebKit::LayerTreeRenderer::setLayerAnimations):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
(WebKit::LayerTreeRenderer::layerByID):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::createCompositingLayers):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::deleteCompositingLayers):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 5:56 PM Changeset in webkit [138467] by
-
- 2 edits in trunk/Source/WebKit2
Fix Qt build.
- WebProcess/WebPage/qt/WebPageQt.cpp:
- 5:37 PM Changeset in webkit [138466] by
-
- 16 edits in trunk/Source/WebKit2
Reduce the number of includes in WebProcess.h
https://bugs.webkit.org/show_bug.cgi?id=105709
Reviewed by Dan Bernstein.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::downloadsAuthenticationManager):
- NetworkProcess/NetworkProcess.h:
(WebKit):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/Network/NetworkProcessConnection.cpp:
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/WebContextMenu.cpp:
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::downloadsAuthenticationManager):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::geolocationManager):
(WebKit):
(WebKit::WebProcess::applicationCacheManager):
(WebKit::WebProcess::resourceCacheManager):
(WebKit::WebProcess::cookieManager):
(WebKit::WebProcess::authenticationManager):
(WebKit::WebProcess::databaseManager):
(WebKit::WebProcess::notificationManager):
(WebKit::WebProcess::pluginProcessConnectionManager):
(WebKit::WebProcess::networkProcessConnectionClosed):
(WebKit::WebProcess::webResourceLoadScheduler):
(WebKit::WebProcess::pluginProcessCrashed):
- WebProcess/WebProcess.h:
(WebCore):
(WebKit):
(WebProcess):
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 1:07 PM Changeset in webkit [138465] by
-
- 11 edits3 adds in trunk/Source/JavaScriptCore
JITThunks should be in its own file
https://bugs.webkit.org/show_bug.cgi?id=105744
Rubber stamped by Sam Weinig.
Moved JITThunks into its own file and removed some static methods from it
that were not related to what JITThunks currently does. Performed various
pagan rituals to get it to build - apparently there is a circular dependency
between JSCell, Weak, and JITThunks, which magically resolves itself if you
make sure to first include Register.h. Making it so that fewer pagan rituals
need to be performed if this code changes in the future is covered by
https://bugs.webkit.org/show_bug.cgi?id=105696.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
- jit/JITStubs.h:
(JSC::JITStackFrame::returnAddressSlot):
(JSC::returnAddressIsInCtiTrampoline):
- jit/JITThunks.cpp: Added.
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::~JITThunks):
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
(JSC::JITThunks::clearHostFunctionStubs):
- jit/JITThunks.h: Added.
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):
- jit/ThunkGenerator.h: Added.
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- runtime/JSGlobalData.h:
- 1:06 PM Changeset in webkit [138464] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Mac] Call Carbon resource APIs on main thread only.
<rdar://problem/11760262>
<http://webkit.org/b/105746>
Reviewed by Anders Carlsson.
The Carbon resource APIs are not thread-safe, so use a little libdispatch sugar to make
sure that plugin enumeration never calls them on a secondary thread.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResourcesOnMainThread):
(WebKit::getPluginInfoFromCarbonResources):
- 9:08 AM Changeset in webkit [138463] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Build breaks with --no-input-type-color
https://bugs.webkit.org/show_bug.cgi?id=105740
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-25
Reviewed by Laszlo Gombos.
- UIProcess/API/efl/EwkViewImpl.h: Add INPUT_TYPE_COLOR guard.
(EwkViewImpl):
- 4:28 AM Changeset in webkit [138462] by
-
- 9 edits in trunk
[EFL][WK2] Refactor snapshot taking code
https://bugs.webkit.org/show_bug.cgi?id=105687
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Refactor EFL WK2 snapshot taking code to use
smart pointers when possible and follow naming
conventions.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewCreateSnapshot):
- UIProcess/API/C/efl/WKView.h: Rename WKViewGetSnapshot
to WKViewCreateSnapshot to follow C API naming conventions,
since the returned value needs to be adopted.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::takeSnapshot):
- UIProcess/API/efl/EwkViewImpl.h: Have takeSnapshot() return
a cairo_surface_t instead of a WKType. The value should be
converted to a WKType at C API level.
(EwkViewImpl):
- UIProcess/API/efl/SnapshotImageGL.cpp: Use OwnArrayPtr for the
buffer to avoid manual memory handling. Remove useless call to
glBindTexture() since glReadPixels() reads pixels from the frame
buffer, not from the texture.
(getImageDataFromFrameBuffer):
- UIProcess/API/efl/SnapshotImageGL.h: Rename getImageFromCurrentTexture
to getImageDataFromFrameBuffer for consistency since we technically
return the pixel data of the image and since glReadPixels does not
actually read from the texture. Have the function return a smart
pointer instead of a raw one to avoid manual memory handling.
Tools:
Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
since the function was renamed to follow naming style.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::windowSnapshotImage):
- 3:08 AM Changeset in webkit [138461] by
-
- 12 edits in trunk/Source/WebKit2
PDFPlugin: Find-in-page
https://bugs.webkit.org/show_bug.cgi?id=105710
<rdar://problem/12555331>
Reviewed by Alexey Proskuryakov.
Make use of PDFLayerController's find-in-page functionality to mimic WebKit's.
Add two Plugin methods, countFindMatches and findString, and make use of them
if attempting to find-in-page within a PluginDocument.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::countFindMatches): Added. We don't support find-in-page for NetscapePlugin.
(WebKit::NetscapePlugin::findString): Added. We don't support find-in-page for NetscapePlugin.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add requisite PDFLayerController interfaces.
- WebProcess/Plugins/PDF/PDFPlugin.h: Add countFindMatches, findString, and nextMatchForString,
as well as storage for the most-recently-searched string.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
(WebKit::PDFPlugin::countFindMatches):
(WebKit::PDFPlugin::nextMatchForString):
(WebKit::PDFPlugin::findString):
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/Plugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/PluginProxy.h: Add countFindMatches and findString, but since PDFPlugin
is in-process, we don't need to forward these calls to the PluginProcess.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::countFindMatches): Forward countFindMatches to the plugin.
(WebKit::PluginView::findString): Forward findString to the plugin.
- WebProcess/Plugins/PluginView.h: Add countFindMatches and findString.
- WebProcess/WebPage/FindController.cpp:
(WebKit::pluginViewForFrame): If the given frame hosts a PluginDocument, grab its PluginView.
(WebKit::FindController::countStringMatches): Forward countStringMatches to PluginView if necessary.
(WebKit::FindController::updateFindUIAfterPageScroll): Only use unmarkAllTextMatches if we're using
ordinary find-in-page and don't have a plugin. If we have a plugin, disable our overlay, as it must
be handled by the plugin itself, and request the number of matches for the search from the plugin.
(WebKit::FindController::findString): If necessary, forward findString to the plugin.
(WebKit::FindController::hideFindUI): Hide the search highlight by searching for an empty string.
- 1:26 AM Changeset in webkit [138460] by
-
- 5 edits2 adds in trunk
Web Inspector: Crash when modifying a rule that has been removed through JavaScript
https://bugs.webkit.org/show_bug.cgi?id=105718
Reviewed by Yury Semikhatsky.
Source/WebCore:
CSSStyleRules should be stored by RefPtr's to avoid using stale pointers to deleted instances.
Test: inspector/styles/removed-rule-crash.html
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ruleForId):
(WebCore::InspectorStyleSheet::revalidateStyle):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheet::collectFlatRules):
- inspector/InspectorStyleSheet.h:
(InspectorStyleSheet):
LayoutTests:
- http/tests/inspector/elements-test.js: Add InspectorTest.toggleMatchedStyleProperty.
(initialize_ElementTest.InspectorTest.toggleMatchedStyleProperty): Added.
- inspector/styles/removed-rule-crash-expected.txt: Added.
- inspector/styles/removed-rule-crash.html: Added.
- 1:24 AM Changeset in webkit [138459] by
-
- 2 edits3 adds in trunk/LayoutTests
Web Inspector: device-metrics-fit-window.html is failing on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=104362
Unreviewed expectations rebaseline.
- platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:13 AM Changeset in webkit [138458] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Console] Add "Replay XHR" context menu item for corresponding messages.
https://bugs.webkit.org/show_bug.cgi?id=105714
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-25
Reviewed by Pavel Feldman.
Expose "request" value from console message object and use it in console
context menu generator.
- inspector/front-end/ConsoleMessage.js: Expose "request".
- inspector/front-end/ConsoleView.js: Add "Replay XHR" menu item.
- inspector/front-end/NetworkPanel.js: Fix whitespaces.
- 1:00 AM Changeset in webkit [138457] by
-
- 63 edits in trunk/Source/WebCore
Web Inspector: Make InspectorState instances per-agent, corresponding to JSON map entries in the cookie
https://bugs.webkit.org/show_bug.cgi?id=105722
Reviewed by Yury Semikhatsky.
Inspector state cookie (in JSON format) has become a map (agent name -> "properties object")
to avoid cross-agent property name clashes in a single property namespace.
As such, InspectorState corresponds to a single "properties object" and is now per-agent,
managed by an InspectorCompositeState (which is owned by [Worker]InspectorController).
Since InspectorCompositeState maps "properties objects" by their agent names, InspectorStates are created
by InspectorCompositeState in the InspectorBaseAgentInterface ctor, using the respective agent name.
No new tests, no change in visible behavior.
- inspector/InspectorAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorAgent.h: Ditto.
- inspector/InspectorApplicationCacheAgent.cpp: Ditto.
- inspector/InspectorApplicationCacheAgent.h: Ditto.
- inspector/InspectorBaseAgent.cpp: Ditto.
(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
Create InspectorState via InspectorCompositeState::createAgentState(agentName).
- inspector/InspectorBaseAgent.h: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorCSSAgent.cpp: Ditto.
- inspector/InspectorCSSAgent.h: Ditto.
- inspector/InspectorCanvasAgent.cpp: Ditto.
- inspector/InspectorCanvasAgent.h: Ditto.
- inspector/InspectorConsoleAgent.cpp: Ditto.
- inspector/InspectorConsoleAgent.h: Ditto.
- inspector/InspectorController.cpp: Use InspectorCompositeState rather than InspectorState.
- inspector/InspectorController.h: Ditto.
- inspector/InspectorDOMAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
(WebCore::InspectorDOMAgent::InspectorDOMAgent): Ditto.
- inspector/InspectorDOMAgent.h: Ditto.
- inspector/InspectorDOMDebuggerAgent.cpp: Ditto.
- inspector/InspectorDOMDebuggerAgent.h: Ditto.
- inspector/InspectorDOMStorageAgent.cpp: Ditto.
- inspector/InspectorDOMStorageAgent.h: Ditto.
- inspector/InspectorDatabaseAgent.cpp: Ditto.
- inspector/InspectorDatabaseAgent.h: Ditto.
- inspector/InspectorDebuggerAgent.cpp: Ditto.
- inspector/InspectorDebuggerAgent.h: Ditto.
- inspector/InspectorFileSystemAgent.cpp: Ditto.
- inspector/InspectorFileSystemAgent.h: Ditto.
- inspector/InspectorIndexedDBAgent.cpp: Ditto.
- inspector/InspectorIndexedDBAgent.h: Ditto.
- inspector/InspectorInputAgent.cpp: Ditto.
- inspector/InspectorInputAgent.h: Ditto.
- inspector/InspectorLayerTreeAgent.cpp: Ditto.
- inspector/InspectorLayerTreeAgent.h: Ditto.
- inspector/InspectorMemoryAgent.cpp: Ditto.
- inspector/InspectorMemoryAgent.h: Ditto.
- inspector/InspectorPageAgent.cpp: Ditto.
- inspector/InspectorPageAgent.h: Ditto.
- inspector/InspectorProfilerAgent.cpp: Ditto.
- inspector/InspectorProfilerAgent.h: Ditto.
- inspector/InspectorResourceAgent.cpp: Ditto.
- inspector/InspectorResourceAgent.h: Ditto.
- inspector/InspectorRuntimeAgent.cpp: Ditto.
- inspector/InspectorRuntimeAgent.h: Ditto.
- inspector/InspectorState.cpp: Introduce InspectorCompositeState, refactor.
(WebCore::InspectorState::updateCookie): Delegates to the owning InspectorCompositeState instance.
(WebCore::InspectorState::setFromCookie): Gets called from InspectorCompositeState::loadFromCookie().
(WebCore::InspectorState::remove): Don't forget to update the cookie.
(WebCore::InspectorCompositeState::createAgentState): Creates an InspectorState instance for a named agent.
(WebCore::InspectorCompositeState::loadFromCookie): Restores InspectorStates from a cookie.
(WebCore::InspectorCompositeState::inspectorStateUpdated): Delegate invoked from InspectorState::updateCookie().
- inspector/InspectorState.h:
(InspectorStateUpdateListener): InspectorCompositeState API exposed to InspectorState.
- inspector/InspectorTimelineAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorTimelineAgent.h: Ditto.
- inspector/InspectorWorkerAgent.cpp: Ditto.
- inspector/InspectorWorkerAgent.h: Ditto.
- inspector/PageConsoleAgent.cpp: Ditto.
- inspector/PageConsoleAgent.h: Ditto.
- inspector/PageDebuggerAgent.cpp: Ditto.
- inspector/PageDebuggerAgent.h: Ditto.
- inspector/PageRuntimeAgent.cpp: Ditto.
- inspector/PageRuntimeAgent.h: Ditto.
- inspector/WorkerConsoleAgent.cpp: Ditto.
- inspector/WorkerConsoleAgent.h: Ditto.
- inspector/WorkerDebuggerAgent.cpp: Ditto.
- inspector/WorkerDebuggerAgent.h: Ditto.
- inspector/WorkerInspectorController.cpp: Ditto.
- inspector/WorkerInspectorController.h: Ditto.
- inspector/WorkerRuntimeAgent.cpp: Ditto.
- inspector/WorkerRuntimeAgent.h: Ditto.
- 12:12 AM Changeset in webkit [138456] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed follow-up for r138455.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Dec 24, 2012:
- 11:53 PM Changeset in webkit [138455] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed compilation fix for r138452.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:41 PM Changeset in webkit [138454] by
-
- 7 edits in trunk/Source
Memory instrumentation: provide a way to mark a node as a root
https://bugs.webkit.org/show_bug.cgi?id=105737
Reviewed by Alexander Pavlov.
Source/WebCore:
Extended HeapGraphSerializer to add a fake root node with edges to all
real instrumentation roots.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::addRootNode):
(WebCore):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
Source/WTF:
Objects added using MemoryInstrumentation::addRootObject will be marked as roots.
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::WrapperBase::process):
(WTF):
(WTF::MemoryInstrumentation::WrapperBase::processPointer):
(WTF::MemoryInstrumentation::WrapperBase::processRootObjectRef):
- wtf/MemoryInstrumentation.h:
(WrapperBase):
- wtf/MemoryObjectInfo.h: added root marker which can be used by the heap graph builder.
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::isRoot):
(WTF::MemoryObjectInfo::markAsRoot):
(MemoryObjectInfo):
- 11:26 PM Changeset in webkit [138453] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add message listener only in case of standalone test-runner.html
https://bugs.webkit.org/show_bug.cgi?id=105715
Reviewed by Pavel Feldman.
Tell InspectorFrontendAPI that it is launched by standalone test runner so that it
can decide whether message event listener should be added.
- inspector/front-end/InspectorFrontendAPI.js:
- inspector/front-end/test-runner.html:
- 11:01 PM Changeset in webkit [138452] by
-
- 10 edits in trunk
Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
https://bugs.webkit.org/show_bug.cgi?id=105725
Reviewed by Yury Semikhatsky.
Source/WebCore:
MemoryOwningType was renamed to MemberType.
Source argument were removed from reportEdge, reportLeaf and other edge related methods because it is not necessary.
MemberType argument was propagated from MemoryInstrumentation down to HeapGraphSerializer.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphEdge::HeapGraphEdge):
(HeapGraphEdge):
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportEdge):
(WebCore::HeapGraphSerializer::reportLeaf):
(WebCore::HeapGraphSerializer::serialize):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportEdge):
(WebCore::MemoryInstrumentationClientImpl::reportLeaf):
- inspector/MemoryInstrumentationImpl.h:
(MemoryInstrumentationClientImpl):
Source/WTF:
MemoryOwningType was renamed to MemberType.
Source argument were removed from reportEdge, reportLeaf and other edge related methods because it is not necessary.
MemberType argument was propagated from MemoryInstrumentation down to HeapGraphSerializer.
The changes covered by tests in TestWebKitAPI.
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::reportEdge):
(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
- wtf/MemoryInstrumentation.h:
(MemoryInstrumentationClient):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addRawBuffer):
(WTF::MemoryInstrumentation::MemberTypeTraits::addObject):
(WTF::MemoryInstrumentation::addObjectImpl):
Tools:
MemberType value names were adjusted according to Style Guide.
Existing tests were extended with link type validation.
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
- 10:16 PM Changeset in webkit [138451] by
-
- 3 edits2 adds in trunk
::first-letter { overflow: -webkit-paged-y } causes crash
https://bugs.webkit.org/show_bug.cgi?id=105393
Reviewed by Beth Dakin.
Source/WebCore:
Should check whether e is available or not before invoking
e->hasTagName in adjustRenderStyle in StyleResolver.cpp.
Test: fast/css/pseudo-element-opagedxy-crash.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
If adjustRenderStyle is invoked in pseudoStyleForElement, the given
element is 0. So e is not available. However if the given style's
overflowY is OPAGEDX or OPAGEDY, adjustRenderStyle doesn't check
whether e is available or not before e->hasTagName.
This causes a crash.
LayoutTests:
- fast/css/pseudo-element-opagedxy-crash-expected.txt: Added.
- fast/css/pseudo-element-opagedxy-crash.html: Added.
- 9:23 PM Changeset in webkit [138450] by
-
- 7 edits in trunk/Source
Web Inspector: add async API for passing renderer process memory stats
https://bugs.webkit.org/show_bug.cgi?id=105278
Patch by Alexei Filippov <alph@chromium.org> on 2012-12-24
Reviewed by Yury Semikhatsky.
On some platforms (e.g. Linux) it may take some time to collect
total process memory information as it involves an IPC out of a
sandboxed renderer process. So add an async way to collect the statistics.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
(ProcessMemorySizesCallback):
(WebKit::Platform::ProcessMemorySizesCallback::~ProcessMemorySizesCallback):
(WebKit::Platform::requestProcessMemorySizes):
Source/WebCore:
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
(ProcessMemorySizesCallback):
(WebCore::MemoryUsageSupport::ProcessMemorySizesCallback::~ProcessMemorySizesCallback):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):
- 6:17 PM Changeset in webkit [138449] by
-
- 13 edits in trunk/Source
Remove wtf/Platform.h includes from {c|cpp} files
https://bugs.webkit.org/show_bug.cgi?id=105678
Patch by Laszlo Gombos <Laszlo Gombos> on 2012-12-24
Reviewed by Kentaro Hara.
Remove wtf/Platform.h from the include list as it is already
included in config.h.
Source/JavaScriptCore:
- disassembler/udis86/udis86.c:
- disassembler/udis86/udis86_decode.c:
- disassembler/udis86/udis86_input.c:
- disassembler/udis86/udis86_itab_holder.c:
- disassembler/udis86/udis86_syn-att.c:
- disassembler/udis86/udis86_syn-intel.c:
- disassembler/udis86/udis86_syn.c:
- heap/VTableSpectrum.cpp:
Source/WebCore:
No new tests as there is no new functionality.
- rendering/svg/RenderSVGRect.cpp:
Source/WebKit2:
- Shared/qt/QtNetworkRequestData.cpp:
- 5:17 PM Changeset in webkit [138448] by
-
- 2 edits in trunk/Source/WebCore
Follow up fixes for r137739
https://bugs.webkit.org/show_bug.cgi?id=104982
Reviewed by Ryosuke Niwa.
Applied darin's comments in https://bugs.webkit.org/show_bug.cgi?id=104982#c18
No tests. No change in behavior.
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
- 11:37 AM Changeset in webkit [138447] by
-
- 3 edits in trunk/Source/WebCore
Update BB10 media render theme.
https://bugs.webkit.org/show_bug.cgi?id=105728
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-12-24
Reviewed by Rob Buis.
Internally reviewed by John Griggs.
Use GL renderer to paint media control.
- css/mediaControlsBlackBerry.css:
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
- 10:28 AM Changeset in webkit [138446] by
-
- 2 edits1 add14 deletes in trunk/LayoutTests
[CSS Regions] Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=80191
Reviewed by Tony Chang.
Convert fast/regions/bottom-overflow-out-of-first-region.html to a ref test.
Used a monospace font, removed text-align and margins for text flowing into regions so that
the text fits nicely in the two regions of the test.
- fast/regions/bottom-overflow-out-of-first-region-expected.html: Added.
- fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- fast/regions/bottom-overflow-out-of-first-region.html:
- platform/chromium-linux/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac-lion/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- 10:19 AM Changeset in webkit [138445] by
-
- 2 edits in trunk/Source/WebKit2
Assert fix take 2.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
- 10:12 AM Changeset in webkit [138444] by
-
- 3 edits in trunk/Source/WebKit2
Fix WebKit2 asserting on launch.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::databaseManager):
(WebProcess):
- 8:45 AM Changeset in webkit [138443] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r138436.
http://trac.webkit.org/changeset/138436
https://bugs.webkit.org/show_bug.cgi?id=105723
Asserts on state restoration in debug builds (Requested by
apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-24
- inspector/InspectorAgent.cpp:
(InspectorAgentState):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::disable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::inspect):
- inspector/InspectorApplicationCacheAgent.cpp:
(ApplicationCacheAgentState):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):
- inspector/InspectorCSSAgent.cpp:
(CSSAgentState):
(WebCore::InspectorCSSAgent::restore):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):
- inspector/InspectorCanvasAgent.cpp:
(CanvasAgentState):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorController.h:
(WebCore):
(InspectorController):
- inspector/InspectorDOMStorageAgent.cpp:
(DOMStorageAgentState):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
- inspector/InspectorDatabaseAgent.cpp:
(DatabaseAgentState):
(WebCore):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::restore):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::disable):
- inspector/InspectorFileSystemAgent.cpp:
(FileSystemAgentState):
(WebCore):
(WebCore::InspectorFileSystemAgent::enable):
(WebCore::InspectorFileSystemAgent::disable):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::restore):
- inspector/InspectorIndexedDBAgent.cpp:
(IndexedDBAgentState):
(WebCore):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
- inspector/InspectorLayerTreeAgent.cpp:
(LayerTreeAgentState):
(WebCore::InspectorLayerTreeAgent::restore):
(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):
- inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::webViewResized):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore::InspectorPageAgent::setShowFPSCounter):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::applyScreenWidthOverride):
(WebCore::InspectorPageAgent::applyScreenHeightOverride):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::applyEmulatedMedia):
- inspector/InspectorResourceAgent.cpp:
(ResourceAgentState):
(WebCore::InspectorResourceAgent::restore):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
- inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::loadFromCookie):
(WebCore):
(WebCore::InspectorState::mute):
(WebCore::InspectorState::unmute):
(WebCore::InspectorState::updateCookie):
(WebCore::InspectorState::remove):
- inspector/InspectorState.h:
(WebCore):
(InspectorState):
(WebCore::InspectorState::setLong):
- inspector/InspectorTimelineAgent.cpp:
(TimelineAgentState):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/WorkerInspectorController.h:
(WebCore):
(WorkerInspectorController):
- 7:59 AM Changeset in webkit [138442] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Keep LiveEdit API disabled when idle
https://bugs.webkit.org/show_bug.cgi?id=104039
Patch by Peter Rybin <prybin@chromium.org> on 2012-12-24
Reviewed by Pavel Feldman.
Guards are added to LiveEdit call
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setScriptSource):
- 6:03 AM Changeset in webkit [138441] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix various RenderQueue bugs introduced by r138024.
https://bugs.webkit.org/show_bug.cgi?id=105717
RIM PR 269029
Reviewed by George Staikos.
Scroll/zoom jobs were pretty solid, but I managed to
leave some bugs in the region handling of RenderQueue's
renderRegularRenderJobs() function, causing us to skip
a desired blit or render operation in cases where the
region and tile tracking did not match up.
This commit fixes these errors.
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
- 4:56 AM Changeset in webkit [138440] by
-
- 2 edits in trunk/Tools
[BlackBerry] DRT - Crashed when running pixels tests
https://bugs.webkit.org/show_bug.cgi?id=105711
RIM PR 270003
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-12-24
Reviewed by George Staikos.
Calling window->post() here will result in buffer swapping which is
only allowed in UI thread now, and I found we don't need to call it
for GL renderer.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView):
- 4:37 AM Changeset in webkit [138439] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Close page popup when a page becomes invisible.
https://bugs.webkit.org/show_bug.cgi?id=105704
Reviewed by George Staikos.
Reviewed internally by Jakob Petsovits.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setVisible):
- 3:23 AM Changeset in webkit [138438] by
-
- 6 edits in trunk
Web Inspector: refactor TextEditorHighlighter's highlight attributes to dense array
https://bugs.webkit.org/show_bug.cgi?id=105626
Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-24
Reviewed by Pavel Feldman.
Source/WebCore:
Refactor highlight attributes from sparse array to dense array.
No new tests: no behaviour changes, coverage provided by existing tests.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
- inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
LayoutTests:
Fix tests according to new highlight attribute structure.
- inspector/editor/highlighter-long-line.html:
- inspector/editor/highlighter-test.js:
(initialize_HighlighterTests.InspectorTest.dumpTextModel):
(initialize_HighlighterTests):
- 2:03 AM Changeset in webkit [138437] by
-
- 2 edits in trunk
[EFL [WebGL] GLES2 detection is broken.
https://bugs.webkit.org/show_bug.cgi?id=105677
We use the logic in FindGLES.cmake to detect GLES2 support during compile time.
OPENGLES2_FOUND is never set, even though OPENGLES2_INCLUDE_DIR and OPENGLES2_LIBRARY
contain right information. The name passed to find_package_handle_standard_args seems to be the issue here.
This patch changes the name passed to find_package_handle_standard_args to OPENGLES2.
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-24
Reviewed by Kenneth Rohde Christiansen.
- Source/cmake/FindGLES.cmake:
- 1:07 AM Changeset in webkit [138436] by
-
- 20 edits in trunk/Source/WebCore
Web Inspector: Make use of the new InspectorState::remove() in inspector agents
https://bugs.webkit.org/show_bug.cgi?id=105438
Reviewed by Yury Semikhatsky.
This patch introduces the following refactorings:
- setting property values of InspectorState to "empty" objects has been replaced by removing them from the state;
- InspectorState instance is no longer shared across agents, so that the property names can no longer clash. Instead, InspectorCompositeState creates and owns InspectorState instances for every agent;
- agent-specific prefix has been stripped from most property names, where it looked synthetic.
- updateCookie() is called from InspectorState::remove().
No new tests, as there is no visible change in the behavior.
- inspector/InspectorAgent.cpp: Agent-specific property name prefix stripped.
- inspector/InspectorApplicationCacheAgent.cpp: Ditto.
- inspector/InspectorCSSAgent.cpp: Ditto.
- inspector/InspectorCanvasAgent.cpp: Ditto.
- inspector/InspectorController.cpp: Make use of InspectorCompositeState rather than InspectorState.
- inspector/InspectorController.h: Ditto.
- inspector/InspectorDOMStorageAgent.cpp: Agent-specific property name prefix stripped.
- inspector/InspectorDatabaseAgent.cpp: Ditto.
- inspector/InspectorDebuggerAgent.cpp: Ditto.
(WebCore::InspectorDebuggerAgent::disable):
Use "remove" instead of setting an empty object.
- inspector/InspectorFileSystemAgent.cpp: Agent-specific property name prefix stripped.
- inspector/InspectorIndexedDBAgent.cpp: Ditto.
- inspector/InspectorLayerTreeAgent.cpp: Ditto.
- inspector/InspectorPageAgent.cpp: Ditto.
(WebCore::InspectorPageAgent::disable):
Use "remove" instead of setting empty values for certain properties.
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
Remove unnecessary code (object is created and put into the map if none is found).
- inspector/InspectorResourceAgent.cpp: Agent-specific property name prefix stripped.
(WebCore::InspectorResourceAgent::disable):
Use "remove" instead of setting an empty object for userAgentOverride.
- inspector/InspectorState.cpp: Add InspectorCompositeState.
(WebCore::InspectorState::setFromCookie): Gets invoked from InspectorCompositeState::loadFromCookie().
(WebCore::InspectorState::updateCookie): Call updateCookie().
(WebCore::InspectorCompositeState::createAgentState): Creates an InspectorState instance to be passed to an agent.
- inspector/InspectorState.h: Add InspectorCompositeState.
(WebCore::InspectorState::setLong): Fix cast.
- inspector/InspectorTimelineAgent.cpp: Agent-specific property name prefix stripped.
- inspector/WorkerInspectorController.cpp: Make use of InspectorCompositeState rather than InspectorState.
- inspector/WorkerInspectorController.h: Ditto.
- 12:19 AM Changeset in webkit [138435] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][Win] Unreviewed Xmas buildfix after r138433.
- WebProcess/Cookies/WebCookieManager.h:
