Timeline
Dec 26, 2012:
- 11:31 PM Changeset in webkit [138491] by
-
- 2 edits in trunk/Tools
Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
As example ..../DevTools/src/third_party/WebKit
- Scripts/webkitpy/common/webkit_finder.py:
(WebKitFinder.webkit_base):
- 10:43 PM Changeset in webkit [138490] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set load state for popups manually, in absence of a loader.
https://bugs.webkit.org/show_bug.cgi?id=105708
RIM PR 257216
Reviewed by George Staikos.
Internally reviewed by Chris Guan.
The WebPage class relies on the load state for various things,
among others it will only emit contents size changes after
layouts if a load state other than None is set.
Given that popups write the web page content itself with no
loader that would issue such notifications, the load state
should probably just be set manually in this case.
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::init):
- 6:29 PM Changeset in webkit [138489] by
-
- 4 edits in trunk/Source/WebCore
[Texmap] Instead of having multiple shaders sources with lots of duplication, we should have one shader source with MACRO variants
https://bugs.webkit.org/show_bug.cgi?id=104815
Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-26
Reviewed by Kenneth Rohde Christiansen.
Created templates for the vertex and fragment shaders, and added some MACROs in
TextureMapperShaderManager to allow GLSL precompiler-based configuration.
The template follows a pattern where the main function in the shader calls
applyFooBarIfNeeded(), while applyFooBar() is implemented. The Macros prepended to the template define whether applyIfNeeded resolves to the real function or to a noop.
In addition, made some small changes to the filter shaders so that they can use the same code as the normal shaders.
Covered by existing pixel/ref tests when run on Qt/EFL/GTK.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::optionsForFilterType):
(WebCore):
(WebCore::getPassesRequiredForFilter):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
Always draw using the drawQuad function, and use the new TextureMapperShaderManager::Options mask instead of the old ShaderKey.
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
(WebCore::getShaderSpec):
(WebCore::TextureMapperShaderManager::getShaderProgram):
- platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgram):
(TextureMapperShaderManager):
- 5:14 PM Changeset in webkit [138488] by
-
- 3 edits in trunk
[chromium] Disable unprefixed css transitions until they're functional
https://bugs.webkit.org/show_bug.cgi?id=105771
Reviewed by Eric Seidel.
Bug 105647 mentions that this is not fully implemented yet, and the
partial support breaks feature detection in modernizr and friends.
- features.gypi:
- 4:38 PM Changeset in webkit [138487] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] A Minor optimization of GraphicsLayerTransform.
https://bugs.webkit.org/show_bug.cgi?id=105758
Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-26
Reviewed by Noam Rosenthal.
Only multiply the transformation matrices if the paramaters are actually
changed.
This optimizes the code path called from flushCompositingStateForThisLayerOnly(),
and potentially setAnimatedTransform().
No new tests. Refactoring only.
- platform/graphics/GraphicsLayerTransform.cpp:
(WebCore::GraphicsLayerTransform::setPosition):
(WebCore::GraphicsLayerTransform::setSize):
(WebCore::GraphicsLayerTransform::setAnchorPoint):
(WebCore::GraphicsLayerTransform::setFlattening):
(WebCore::GraphicsLayerTransform::setLocalTransform):
(WebCore::GraphicsLayerTransform::setChildrenTransform):
- 3:24 PM Changeset in webkit [138486] by
-
- 2 edits in trunk/LayoutTests
Add a Mac test expectations for bugs 105777 and 105778.
- platform/mac/TestExpectations:
- 1:45 PM Changeset in webkit [138485] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed Xmas buildfix after r138479.
- WebProcess/MediaCache/WebMediaCacheManager.h:
- 1:33 PM Changeset in webkit [138484] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Enable most sub-pixel tests on mac.
- platform/mac/TestExpectations:
- 12:59 PM Changeset in webkit [138483] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Remove unused members and methods in TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=105755
Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-26
Reviewed by Noam Rosenthal.
No new tests. Refactoring only.
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
(State):
(WebCore::TextureMapperLayer::State::State):
- 12:13 PM Changeset in webkit [138482] by
-
- 2 edits in trunk/Source/WebCore
[Mac] MemoryPressureHandler: Occasional crashes in uninstall() when responding to memory pressure signal.
<http://webkit.org/b/105772>
Reviewed by Stephanie Lewis.
We can't synchronously dereference _cache_event_source in uninstall() just because m_installed
is true -- the block that initializes _cache_event_source is asynchronous and may not have executed.
Fix this by performing the uninstallation asynchronously on the main queue as well.
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::uninstall):
- 11:49 AM Changeset in webkit [138481] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r137905.
http://trac.webkit.org/changeset/137905
https://bugs.webkit.org/show_bug.cgi?id=105765
Popover does not disappear when hovering another identifier in
sources panel. (Requested by vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-26
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._innerShow):
- inspector/front-end/popover.css:
(.popover):
- 11:48 AM Changeset in webkit [138480] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Resources] Table lose focus (selection) after deleting cookie.
https://bugs.webkit.org/show_bug.cgi?id=105716
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-26
Reviewed by Yury Semikhatsky.
This makes deletion of a set of cookies (using keyboard) painful.
- inspector/front-end/CookieItemsView.js: Call method instead of getter.
- inspector/front-end/CookiesTable.js: Remember and use next selected
cookie value.
- 10:01 AM Changeset in webkit [138479] by
-
- 7 edits in trunk/Source/WebKit2
Convert WebKeyValueStorageManager and WebMediaCacheManager to MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=105751
Reviewed by Andreas Kling.
- WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::dispatchDidGetKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
- WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:
(WebKeyValueStorageManager): Remove unused m_originsLoaded member variable.
- WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::WebMediaCacheManager):
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
- WebProcess/MediaCache/WebMediaCacheManager.h:
(WebMediaCacheManager):
Convert the managers to MessageReceiver.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
(WebProcess):
Add the new managers.
- 9:00 AM Changeset in webkit [138478] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Caret doesn't update position when scrolling text in Input element
https://bugs.webkit.org/show_bug.cgi?id=105757
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-12-26
Reviewed by George Staikos.
PR 271627
Internally reviewed by George Staikos.
Call FrameSelection's updateAppearence instead of SelectionHandler's
selectionPositionChanged to update the caret position.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
- 7:54 AM Changeset in webkit [138477] by
-
- 17 edits1 add in trunk
Web Inspector: extract JS heap profiler specifics into JSHeapSnapshot.js
https://bugs.webkit.org/show_bug.cgi?id=105768
Reviewed by Pavel Feldman.
Source/WebCore:
Inroduced JSHeapSnapshot, JSHeapSnapshotNode, JSHeapSnapshotEdge and JSHeapSnapshotRetainerEdge which
should encapsulate logic specific to JS-heap.
No behavioral changes, covered with existing heap profiler tests.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdge.prototype.hasStringName):
(WebInspector.HeapSnapshotEdge.prototype.name):
(WebInspector.HeapSnapshotEdge.prototype.node):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshotRetainerEdge.prototype._node):
(WebInspector.HeapSnapshotRetainerEdge.prototype._edge):
(WebInspector.HeapSnapshotNode.prototype.className):
(WebInspector.HeapSnapshotNode.prototype.classIndex):
(WebInspector.HeapSnapshotNode.prototype.edges):
(WebInspector.HeapSnapshotNode.prototype.id):
(WebInspector.HeapSnapshotNode.prototype.retainers):
(WebInspector.HeapSnapshot.prototype.createNode):
(WebInspector.HeapSnapshot.prototype.createEdge):
(WebInspector.HeapSnapshot.prototype.createRetainingEdge):
(WebInspector.HeapSnapshot.prototype.rootNode):
(WebInspector.HeapSnapshot.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
(WebInspector.HeapSnapshotNodesProvider.prototype.nodePosition):
- inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.buildSnapshot):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
- inspector/front-end/HeapSnapshotWorker.js:
- inspector/front-end/JSHeapSnapshot.js: Added.
(WebInspector.JSHeapSnapshot):
(WebInspector.JSHeapSnapshot.prototype.createNode):
(WebInspector.JSHeapSnapshot.prototype.createEdge):
(WebInspector.JSHeapSnapshot.prototype.createRetainingEdge):
(WebInspector.JSHeapSnapshotNode):
(WebInspector.JSHeapSnapshotNode.prototype.canBeQueried):
(WebInspector.JSHeapSnapshotNode.prototype.isPageObject):
(WebInspector.JSHeapSnapshotNode.prototype.distanceToWindow):
(WebInspector.JSHeapSnapshotNode.prototype.className):
(WebInspector.JSHeapSnapshotNode.prototype.classIndex):
(WebInspector.JSHeapSnapshotNode.prototype.id):
(WebInspector.JSHeapSnapshotNode.prototype.isHidden):
(WebInspector.JSHeapSnapshotNode.prototype.isNative):
(WebInspector.JSHeapSnapshotNode.prototype.isSynthetic):
(WebInspector.JSHeapSnapshotNode.prototype.isWindow):
(WebInspector.JSHeapSnapshotNode.prototype.isDetachedDOMTreesRoot):
(WebInspector.JSHeapSnapshotNode.prototype.isDetachedDOMTree):
(WebInspector.JSHeapSnapshotEdge):
(WebInspector.JSHeapSnapshotEdge.prototype.clone):
(WebInspector.JSHeapSnapshotEdge.prototype.hasStringName):
(WebInspector.JSHeapSnapshotEdge.prototype.isElement):
(WebInspector.JSHeapSnapshotEdge.prototype.isHidden):
(WebInspector.JSHeapSnapshotEdge.prototype.isWeak):
(WebInspector.JSHeapSnapshotEdge.prototype.isInternal):
(WebInspector.JSHeapSnapshotEdge.prototype.isInvisible):
(WebInspector.JSHeapSnapshotEdge.prototype.isShortcut):
(WebInspector.JSHeapSnapshotEdge.prototype.name):
(WebInspector.JSHeapSnapshotEdge.prototype.toString):
(WebInspector.JSHeapSnapshotEdge.prototype._hasStringName):
(WebInspector.JSHeapSnapshotEdge.prototype._name):
(WebInspector.JSHeapSnapshotEdge.prototype._nameOrIndex):
(WebInspector.JSHeapSnapshotEdge.prototype._type):
(WebInspector.JSHeapSnapshotRetainerEdge):
(WebInspector.JSHeapSnapshotRetainerEdge.prototype.clone):
(WebInspector.JSHeapSnapshotRetainerEdge.prototype.isElement):
(WebInspector.JSHeapSnapshotRetainerEdge.prototype.isHidden):
(WebInspector.JSHeapSnapshotRetainerEdge.prototype.isInternal):
(WebInspector.JSHeapSnapshotRetainerEdge.prototype.isInvisible):
(WebInspector.JSHeapSnapshotRetainerEdge.prototype.isShortcut):
(WebInspector.JSHeapSnapshotRetainerEdge.prototype.isWeak):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/WebKit.qrc:
Source/WebKit/chromium:
- WebKit.gyp: added new file to JS heap profiler.
LayoutTests:
Inroduced JSHeapSnapshot, JSHeapSnapshotNode, JSHeapSnapshotEdge and JSHeapSnapshotRetainerEdge which
should encapsulate logic specific to JS-heap. The tests were switched to the new classes.
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createJSHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
- inspector/profiler/heap-snapshot.html:
- 6:46 AM Changeset in webkit [138476] by
-
- 2 edits in trunk/Source/WebCore
[WIN] Build fix for !USE(CFNETWORK) after r138413.
- platform/network/NetworkStorageSession.h:
(WebCore):
- 4:07 AM Changeset in webkit [138475] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: prepare HeapSnapshot.js for use with native heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=105763
Reviewed by Alexander Pavlov.
HeapSnapshot.js now expects root node to be either the first or the last (real) one
in the list of all nodes.
- inspector/HeapGraphSerializer.cpp:
(HeapGraphNode):
(WebCore::HeapGraphSerializer::serialize): reordered node and edge fields so that the go in
the same order as in the JS heap snapshot.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
- inspector/front-end/NativeHeapGraph.js:
(WebInspector.NativeHeapGraph):
(WebInspector.NativeHeapGraph.prototype.root): now there is explicit root node which is the last
one in the list, use it.
(WebInspector.NativeHeapGraph.prototype._calculateNodeEdgeIndexes):
(WebInspector.NativeHeapGraph.prototype._addDummyNode): fixed dummy node first edge index.
(WebInspector.NativeHeapGraph.Edge.prototype.target):
(WebInspector.NativeHeapGraph.Node.prototype.referencedNodes):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotNode.prototype._addChildrenFromGraph): switched to use of the root node
(WebInspector.NativeHeapGraphDataGridRoot.prototype._populate):
- 2:27 AM Changeset in webkit [138474] by
-
- 2 edits in trunk/Source/WTF
Fix build warning in OSAllocatorPosix.cpp
https://bugs.webkit.org/show_bug.cgi?id=105761
Reviewed by Kentaro Hara.
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted): Fix unused param warnings.
- 1:56 AM Changeset in webkit [138473] by
-
- 2 edits in trunk/Source/WebCore
[Web Inspector]Remove Preview and Response tab from network panel in case websocket.
https://bugs.webkit.org/show_bug.cgi?id=105754
Patch by Pan Deng <pan.deng@intel.com> on 2012-12-26
Reviewed by Pavel Feldman.
Network item views for websocket is not consistent before/after receiving a frame.
This change keeps Headers, Frames and Cookies tab for websocket.
No new tests.
- inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
Dec 25, 2012:
- 11:24 PM Changeset in webkit [138472] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=105753
Reviewed by Laszlo Gombos.
- CMakeLists.txt: Remove header files in source list.
- 6:36 PM Changeset in webkit [138471] by
-
- 4 edits in trunk/Source/WebKit2
Fix the Database manager assert, again.
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit):
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::initialize):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 6:29 PM Changeset in webkit [138470] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to initialize the onLine in the global
https://bugs.webkit.org/show_bug.cgi?id=105749
Reviewed by George Staikos.
The NetworkStatus is initialized to online in the constructor by default,
we need to update it correctly with the network status at startup.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
- 6:15 PM Changeset in webkit [138469] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Media controls are drawn on top of one another for media with unknown duration.
https://bugs.webkit.org/show_bug.cgi?id=105747
Patch by John Griggs <jgriggs@rim.com> on 2012-12-25
Reviewed by George Staikos.
No need to reposition controls when there is no timeline element, this mispositions them in the new design.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
- 6:04 PM Changeset in webkit [138468] by
-
- 8 edits in trunk/Source/WebKit2
Coordinated Graphics: Manage the lifecycle of CoordinatedGraphicsLayer explicitly.
https://bugs.webkit.org/show_bug.cgi?id=104990
Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-25
Reviewed by Noam Rosenthal.
Send explicit commands to the UI process to create/delete compositing
layers, instead of having the UI process decide lazily when to create
them.
Avoid creating a compositing layer at all if it was deleted in the same
cycle.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::createCompositingLayer):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::createCanvas):
(WebKit::LayerTreeRenderer::destroyCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::getLayerByIDIfExists):
(WebKit):
(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::setRootLayerID):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::ensureRootLayer):
(WebKit::LayerTreeRenderer::setLayerAnimations):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
(WebKit::LayerTreeRenderer::layerByID):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::createCompositingLayers):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::deleteCompositingLayers):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 5:56 PM Changeset in webkit [138467] by
-
- 2 edits in trunk/Source/WebKit2
Fix Qt build.
- WebProcess/WebPage/qt/WebPageQt.cpp:
- 5:37 PM Changeset in webkit [138466] by
-
- 16 edits in trunk/Source/WebKit2
Reduce the number of includes in WebProcess.h
https://bugs.webkit.org/show_bug.cgi?id=105709
Reviewed by Dan Bernstein.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::downloadsAuthenticationManager):
- NetworkProcess/NetworkProcess.h:
(WebKit):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/Network/NetworkProcessConnection.cpp:
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/WebContextMenu.cpp:
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::downloadsAuthenticationManager):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::geolocationManager):
(WebKit):
(WebKit::WebProcess::applicationCacheManager):
(WebKit::WebProcess::resourceCacheManager):
(WebKit::WebProcess::cookieManager):
(WebKit::WebProcess::authenticationManager):
(WebKit::WebProcess::databaseManager):
(WebKit::WebProcess::notificationManager):
(WebKit::WebProcess::pluginProcessConnectionManager):
(WebKit::WebProcess::networkProcessConnectionClosed):
(WebKit::WebProcess::webResourceLoadScheduler):
(WebKit::WebProcess::pluginProcessCrashed):
- WebProcess/WebProcess.h:
(WebCore):
(WebKit):
(WebProcess):
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 1:07 PM Changeset in webkit [138465] by
-
- 11 edits3 adds in trunk/Source/JavaScriptCore
JITThunks should be in its own file
https://bugs.webkit.org/show_bug.cgi?id=105744
Rubber stamped by Sam Weinig.
Moved JITThunks into its own file and removed some static methods from it
that were not related to what JITThunks currently does. Performed various
pagan rituals to get it to build - apparently there is a circular dependency
between JSCell, Weak, and JITThunks, which magically resolves itself if you
make sure to first include Register.h. Making it so that fewer pagan rituals
need to be performed if this code changes in the future is covered by
https://bugs.webkit.org/show_bug.cgi?id=105696.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
- jit/JITStubs.h:
(JSC::JITStackFrame::returnAddressSlot):
(JSC::returnAddressIsInCtiTrampoline):
- jit/JITThunks.cpp: Added.
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::~JITThunks):
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
(JSC::JITThunks::clearHostFunctionStubs):
- jit/JITThunks.h: Added.
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):
- jit/ThunkGenerator.h: Added.
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- runtime/JSGlobalData.h:
- 1:06 PM Changeset in webkit [138464] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Mac] Call Carbon resource APIs on main thread only.
<rdar://problem/11760262>
<http://webkit.org/b/105746>
Reviewed by Anders Carlsson.
The Carbon resource APIs are not thread-safe, so use a little libdispatch sugar to make
sure that plugin enumeration never calls them on a secondary thread.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResourcesOnMainThread):
(WebKit::getPluginInfoFromCarbonResources):
- 9:08 AM Changeset in webkit [138463] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Build breaks with --no-input-type-color
https://bugs.webkit.org/show_bug.cgi?id=105740
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-25
Reviewed by Laszlo Gombos.
- UIProcess/API/efl/EwkViewImpl.h: Add INPUT_TYPE_COLOR guard.
(EwkViewImpl):
- 4:28 AM Changeset in webkit [138462] by
-
- 9 edits in trunk
[EFL][WK2] Refactor snapshot taking code
https://bugs.webkit.org/show_bug.cgi?id=105687
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Refactor EFL WK2 snapshot taking code to use
smart pointers when possible and follow naming
conventions.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewCreateSnapshot):
- UIProcess/API/C/efl/WKView.h: Rename WKViewGetSnapshot
to WKViewCreateSnapshot to follow C API naming conventions,
since the returned value needs to be adopted.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::takeSnapshot):
- UIProcess/API/efl/EwkViewImpl.h: Have takeSnapshot() return
a cairo_surface_t instead of a WKType. The value should be
converted to a WKType at C API level.
(EwkViewImpl):
- UIProcess/API/efl/SnapshotImageGL.cpp: Use OwnArrayPtr for the
buffer to avoid manual memory handling. Remove useless call to
glBindTexture() since glReadPixels() reads pixels from the frame
buffer, not from the texture.
(getImageDataFromFrameBuffer):
- UIProcess/API/efl/SnapshotImageGL.h: Rename getImageFromCurrentTexture
to getImageDataFromFrameBuffer for consistency since we technically
return the pixel data of the image and since glReadPixels does not
actually read from the texture. Have the function return a smart
pointer instead of a raw one to avoid manual memory handling.
Tools:
Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
since the function was renamed to follow naming style.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::windowSnapshotImage):
- 3:08 AM Changeset in webkit [138461] by
-
- 12 edits in trunk/Source/WebKit2
PDFPlugin: Find-in-page
https://bugs.webkit.org/show_bug.cgi?id=105710
<rdar://problem/12555331>
Reviewed by Alexey Proskuryakov.
Make use of PDFLayerController's find-in-page functionality to mimic WebKit's.
Add two Plugin methods, countFindMatches and findString, and make use of them
if attempting to find-in-page within a PluginDocument.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::countFindMatches): Added. We don't support find-in-page for NetscapePlugin.
(WebKit::NetscapePlugin::findString): Added. We don't support find-in-page for NetscapePlugin.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add requisite PDFLayerController interfaces.
- WebProcess/Plugins/PDF/PDFPlugin.h: Add countFindMatches, findString, and nextMatchForString,
as well as storage for the most-recently-searched string.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
(WebKit::PDFPlugin::countFindMatches):
(WebKit::PDFPlugin::nextMatchForString):
(WebKit::PDFPlugin::findString):
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/Plugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/PluginProxy.h: Add countFindMatches and findString, but since PDFPlugin
is in-process, we don't need to forward these calls to the PluginProcess.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::countFindMatches): Forward countFindMatches to the plugin.
(WebKit::PluginView::findString): Forward findString to the plugin.
- WebProcess/Plugins/PluginView.h: Add countFindMatches and findString.
- WebProcess/WebPage/FindController.cpp:
(WebKit::pluginViewForFrame): If the given frame hosts a PluginDocument, grab its PluginView.
(WebKit::FindController::countStringMatches): Forward countStringMatches to PluginView if necessary.
(WebKit::FindController::updateFindUIAfterPageScroll): Only use unmarkAllTextMatches if we're using
ordinary find-in-page and don't have a plugin. If we have a plugin, disable our overlay, as it must
be handled by the plugin itself, and request the number of matches for the search from the plugin.
(WebKit::FindController::findString): If necessary, forward findString to the plugin.
(WebKit::FindController::hideFindUI): Hide the search highlight by searching for an empty string.
- 1:26 AM Changeset in webkit [138460] by
-
- 5 edits2 adds in trunk
Web Inspector: Crash when modifying a rule that has been removed through JavaScript
https://bugs.webkit.org/show_bug.cgi?id=105718
Reviewed by Yury Semikhatsky.
Source/WebCore:
CSSStyleRules should be stored by RefPtr's to avoid using stale pointers to deleted instances.
Test: inspector/styles/removed-rule-crash.html
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ruleForId):
(WebCore::InspectorStyleSheet::revalidateStyle):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheet::collectFlatRules):
- inspector/InspectorStyleSheet.h:
(InspectorStyleSheet):
LayoutTests:
- http/tests/inspector/elements-test.js: Add InspectorTest.toggleMatchedStyleProperty.
(initialize_ElementTest.InspectorTest.toggleMatchedStyleProperty): Added.
- inspector/styles/removed-rule-crash-expected.txt: Added.
- inspector/styles/removed-rule-crash.html: Added.
- 1:24 AM Changeset in webkit [138459] by
-
- 2 edits3 adds in trunk/LayoutTests
Web Inspector: device-metrics-fit-window.html is failing on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=104362
Unreviewed expectations rebaseline.
- platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:13 AM Changeset in webkit [138458] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Console] Add "Replay XHR" context menu item for corresponding messages.
https://bugs.webkit.org/show_bug.cgi?id=105714
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-25
Reviewed by Pavel Feldman.
Expose "request" value from console message object and use it in console
context menu generator.
- inspector/front-end/ConsoleMessage.js: Expose "request".
- inspector/front-end/ConsoleView.js: Add "Replay XHR" menu item.
- inspector/front-end/NetworkPanel.js: Fix whitespaces.
- 1:00 AM Changeset in webkit [138457] by
-
- 63 edits in trunk/Source/WebCore
Web Inspector: Make InspectorState instances per-agent, corresponding to JSON map entries in the cookie
https://bugs.webkit.org/show_bug.cgi?id=105722
Reviewed by Yury Semikhatsky.
Inspector state cookie (in JSON format) has become a map (agent name -> "properties object")
to avoid cross-agent property name clashes in a single property namespace.
As such, InspectorState corresponds to a single "properties object" and is now per-agent,
managed by an InspectorCompositeState (which is owned by [Worker]InspectorController).
Since InspectorCompositeState maps "properties objects" by their agent names, InspectorStates are created
by InspectorCompositeState in the InspectorBaseAgentInterface ctor, using the respective agent name.
No new tests, no change in visible behavior.
- inspector/InspectorAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorAgent.h: Ditto.
- inspector/InspectorApplicationCacheAgent.cpp: Ditto.
- inspector/InspectorApplicationCacheAgent.h: Ditto.
- inspector/InspectorBaseAgent.cpp: Ditto.
(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
Create InspectorState via InspectorCompositeState::createAgentState(agentName).
- inspector/InspectorBaseAgent.h: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorCSSAgent.cpp: Ditto.
- inspector/InspectorCSSAgent.h: Ditto.
- inspector/InspectorCanvasAgent.cpp: Ditto.
- inspector/InspectorCanvasAgent.h: Ditto.
- inspector/InspectorConsoleAgent.cpp: Ditto.
- inspector/InspectorConsoleAgent.h: Ditto.
- inspector/InspectorController.cpp: Use InspectorCompositeState rather than InspectorState.
- inspector/InspectorController.h: Ditto.
- inspector/InspectorDOMAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
(WebCore::InspectorDOMAgent::InspectorDOMAgent): Ditto.
- inspector/InspectorDOMAgent.h: Ditto.
- inspector/InspectorDOMDebuggerAgent.cpp: Ditto.
- inspector/InspectorDOMDebuggerAgent.h: Ditto.
- inspector/InspectorDOMStorageAgent.cpp: Ditto.
- inspector/InspectorDOMStorageAgent.h: Ditto.
- inspector/InspectorDatabaseAgent.cpp: Ditto.
- inspector/InspectorDatabaseAgent.h: Ditto.
- inspector/InspectorDebuggerAgent.cpp: Ditto.
- inspector/InspectorDebuggerAgent.h: Ditto.
- inspector/InspectorFileSystemAgent.cpp: Ditto.
- inspector/InspectorFileSystemAgent.h: Ditto.
- inspector/InspectorIndexedDBAgent.cpp: Ditto.
- inspector/InspectorIndexedDBAgent.h: Ditto.
- inspector/InspectorInputAgent.cpp: Ditto.
- inspector/InspectorInputAgent.h: Ditto.
- inspector/InspectorLayerTreeAgent.cpp: Ditto.
- inspector/InspectorLayerTreeAgent.h: Ditto.
- inspector/InspectorMemoryAgent.cpp: Ditto.
- inspector/InspectorMemoryAgent.h: Ditto.
- inspector/InspectorPageAgent.cpp: Ditto.
- inspector/InspectorPageAgent.h: Ditto.
- inspector/InspectorProfilerAgent.cpp: Ditto.
- inspector/InspectorProfilerAgent.h: Ditto.
- inspector/InspectorResourceAgent.cpp: Ditto.
- inspector/InspectorResourceAgent.h: Ditto.
- inspector/InspectorRuntimeAgent.cpp: Ditto.
- inspector/InspectorRuntimeAgent.h: Ditto.
- inspector/InspectorState.cpp: Introduce InspectorCompositeState, refactor.
(WebCore::InspectorState::updateCookie): Delegates to the owning InspectorCompositeState instance.
(WebCore::InspectorState::setFromCookie): Gets called from InspectorCompositeState::loadFromCookie().
(WebCore::InspectorState::remove): Don't forget to update the cookie.
(WebCore::InspectorCompositeState::createAgentState): Creates an InspectorState instance for a named agent.
(WebCore::InspectorCompositeState::loadFromCookie): Restores InspectorStates from a cookie.
(WebCore::InspectorCompositeState::inspectorStateUpdated): Delegate invoked from InspectorState::updateCookie().
- inspector/InspectorState.h:
(InspectorStateUpdateListener): InspectorCompositeState API exposed to InspectorState.
- inspector/InspectorTimelineAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorTimelineAgent.h: Ditto.
- inspector/InspectorWorkerAgent.cpp: Ditto.
- inspector/InspectorWorkerAgent.h: Ditto.
- inspector/PageConsoleAgent.cpp: Ditto.
- inspector/PageConsoleAgent.h: Ditto.
- inspector/PageDebuggerAgent.cpp: Ditto.
- inspector/PageDebuggerAgent.h: Ditto.
- inspector/PageRuntimeAgent.cpp: Ditto.
- inspector/PageRuntimeAgent.h: Ditto.
- inspector/WorkerConsoleAgent.cpp: Ditto.
- inspector/WorkerConsoleAgent.h: Ditto.
- inspector/WorkerDebuggerAgent.cpp: Ditto.
- inspector/WorkerDebuggerAgent.h: Ditto.
- inspector/WorkerInspectorController.cpp: Ditto.
- inspector/WorkerInspectorController.h: Ditto.
- inspector/WorkerRuntimeAgent.cpp: Ditto.
- inspector/WorkerRuntimeAgent.h: Ditto.
- 12:12 AM Changeset in webkit [138456] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed follow-up for r138455.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
