Timeline
Dec 30, 2012:
- 11:57 PM Changeset in webkit [138591] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/dom/Range/range-extract-contents.html as flaky
since it sometimes hits an assertion in
WebCore::endOfContinuations().
- platform/efl/TestExpectations:
- 11:49 PM Changeset in webkit [138590] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark editing/pasteboard/4806874.html as flaky since
it sometimes hits an assertion in RenderObject
destructor.
- platform/efl/TestExpectations:
- 11:41 PM Changeset in webkit [138589] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors.html after
TEMPLATE_ELEMENT was enabled for EFL port in r138586.
- platform/efl/fast/js/global-constructors-expected.txt:
- 11:33 PM Changeset in webkit [138588] by
-
- 5 edits2 moves in trunk
[EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
https://bugs.webkit.org/show_bug.cgi?id=105876
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-30
Reviewed by Kenneth Rohde Christiansen.
This is to sync the naming conventions of our classes in both EGL and GLX implementations.
In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.
This patch renames EGLConfigHelper as EGLConfigSelector.
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
- PlatformEfl.cmake:
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.cpp.
(WebCore):
(WebCore::SharedEGLDisplay::deref):
(WebCore::SharedEGLDisplay::sharedEGLDisplay):
(WebCore::SharedEGLDisplay::SharedEGLDisplay):
(WebCore::SharedEGLDisplay::cleanup):
(WebCore::SharedEGLDisplay::~SharedEGLDisplay):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::~EGLConfigSelector):
(WebCore::EGLConfigSelector::display):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):
- platform/graphics/surfaces/egl/EGLConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.h.
(WebCore):
(SharedEGLDisplay):
(WebCore::SharedEGLDisplay::create):
(EGLConfigSelector):
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::configuration):
(WebCore::EGLWindowTransportSurface::destroy):
- platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):
- 11:12 PM Changeset in webkit [138587] by
-
- 3 edits in trunk/Tools
Add myself to watchlists for CSP and console logs.
https://bugs.webkit.org/show_bug.cgi?id=105874
Reviewed by Dirk Pranke.
Because I really, really, really need more email.
- Scripts/webkitpy/common/config/committers.py:
Add mkwst+watchlist@chromium.org as a contributor.
- Scripts/webkitpy/common/config/watchlist:
Create watchlist categories for 1) the various mechanisms used to
generate console messages, and 2) CSP usage and files.
- 8:44 PM Changeset in webkit [138586] by
-
- 6 edits in trunk
.: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865
Reviewed by Laszlo Gombos.
- Source/cmake/OptionsEfl.cmake: Add ENABLE_TEMPLATE_ELEMENT macro.
Tools: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865
Reviewed by Laszlo Gombos.
- Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
LayoutTests: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865
Reviewed by Laszlo Gombos.
- platform/efl/TestExpectations: Unskip test cases for template element.
- 1:22 PM Changeset in webkit [138585] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
PrettyDiff.rb fails to render image diffs with Ruby 1.9.3p194
https://bugs.webkit.org/show_bug.cgi?id=104932
Reviewed by Eric Seidel.
Ruby 1.9 added the concept of string encodings, so the use of `match' with binary data
treats it as UTF-8. Forcing the png_bytes string to have the "binary" encoding avoids
this error.
- PrettyPatch/PrettyPatch.rb: Use force_encoding.
- 9:51 AM Changeset in webkit [138584] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Add several webaudio tests to TestExpectations since
they sometimes hit !m_finishedNodes.size() assertion
in AudioContext destructor.
- platform/efl/TestExpectations:
- 9:37 AM Changeset in webkit [138583] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip XSS Auditor test case that has been consistently
passing on EFL port for a while.
- platform/efl/TestExpectations:
- 9:08 AM Changeset in webkit [138582] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip fast/dom/shadow/host-wrapper-reclaimed.html
since it is passing after r137978.
- platform/efl/TestExpectations:
- 9:05 AM Changeset in webkit [138581] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Update expectations for 2 fast/dom test cases so
that they are not reported as unexpected passes.
Those tests are passing because their generated
expectations are wrong.
- platform/efl/TestExpectations:
- 8:57 AM Changeset in webkit [138580] by
-
- 4 edits in trunk
[GStreamer] webaudio/decode-audio-data-basic.html fails
https://bugs.webkit.org/show_bug.cgi?id=105298
Reviewed by Martin Robinson.
Source/WebCore:
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus): Return a null pointer if an
error happened while processing a media file.
LayoutTests:
- platform/efl/TestExpectations: Unflag fixed test.
- 8:55 AM Changeset in webkit [138579] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip text-decoration-style tests passing after
r126054 and r132076.
- platform/efl/TestExpectations:
- 7:55 AM Changeset in webkit [138578] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip cairo-related tests that are now consistently
passing on both WK1 and WK2 EFL.
- platform/efl/TestExpectations:
- 7:45 AM Changeset in webkit [138577] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several compositing test cases that are passing
consistently on EFL WK2.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 6:57 AM Changeset in webkit [138576] by
-
- 3 edits in trunk/Source/WebCore
Regression(r138545): Makes WebAudio tests crash
https://bugs.webkit.org/show_bug.cgi?id=105869
Reviewed by Philippe Normand.
Stop using smart pointers and adoptGRef() for the
GstBus object and call gst_object_unref() manually.
This fixes assertions hits when calling adoptGRef()
since the GstBus object has a floating reference.
Alternatively, we could keep using smart pointers
and stop calling adoptGRef() so that
gst_object_ref_sink() is called and the floating
flag is cleared but I think it is clearer to do
it manually here.
No new tests, already covered by existing tests.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::messageCallback):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
- 6:52 AM Changeset in webkit [138575] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, unskip a now passing test.
- platform/qt/TestExpectations:
- 3:56 AM Changeset in webkit [138574] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Invalid use of temporary object in ProcessLauncher::launchProcess()
https://bugs.webkit.org/show_bug.cgi?id=105867
Reviewed by Kenneth Rohde Christiansen.
Fix invalid use of temporary object in ProcessLauncher::launchProcess()
for prefixedExecutablePath.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- 1:51 AM Changeset in webkit [138573] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening of the unit tests.
Skip the TestInspectorServer unit test that's timing out completely.
- Scripts/run-gtk-tests:
(TestRunner):
Dec 29, 2012:
- 5:22 PM Changeset in webkit [138572] by
-
- 3 edits in trunk/Source/WebCore
Rename StyleResolver's member variable that holds SelectorChecker to a proper name.
https://bugs.webkit.org/show_bug.cgi?id=105864
In https://bugs.webkit.org/show_bug.cgi?id=105660#c11, Antti suggested renaming m_checker to
m_selectorChecker. I've forgotten about that, but now I remembered it.
Reviewed by Eric Seidel.
No change in functionality, covered by existing tests.
- css/StyleResolver.cpp/h: Renamed all instances of m_checker to m_selectorChecker.
- 4:29 PM Changeset in webkit [138571] by
-
- 8 edits in trunk/Source/WebCore
Move pointer to Document up from SelectorChecker to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=105863
Now that SelectorChecker is mostly stateless, it no longer needs to keep a pointer to Document, which
makes all the code in StyleResolver that reaches for it sort of weird.
Reviewed by Eric Seidel.
No change in functionality, covered by existing tests.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::SelectorChecker): Changed to take document as argument (only used to set bit fields).
(WebCore::SelectorChecker::checkOneSelector): Changed to use element document.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Ditto.
- css/SelectorChecker.h:
(WebCore): Removed unnecessary Document forward declaration.
(SelectorChecker): Changed constructor declaration, and removed m_document member.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver): Adjusted SelectorChecker initializer accordingly.
(WebCore::StyleResolver::initElement): Changed to use own document accessor.
(WebCore::StyleResolver::initForStyleResolve): Ditto.
(WebCore::StyleResolver::matchUARules): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::checkForGenericFamilyChange): Ditto.
(WebCore::StyleResolver::initializeFontStyle): Ditto.
(WebCore::StyleResolver::setFontSize): Ditto.
- css/StyleResolver.h:
(WebCore::StyleResolver::document): Changed to use own member.
(WebCore::StyleResolver::documentSettings): Ditto.
(StyleResolver): Added m_document member.
- dom/SelectorQuery.cpp:
(WebCore::SelectorQuery::matches): Changed callsite to reflect new constructor signature.
(WebCore::SelectorQuery::queryAll): Ditto.
(WebCore::SelectorQuery::queryFirst): Ditto.
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorChecker::ContentSelectorChecker): Ditto.
(WebCore::ContentSelectorQuery::ContentSelectorQuery): Ditto.
- html/shadow/ContentSelectorQuery.h:
(ContentSelectorChecker): Removed unnecessary argument.
- 2:17 PM Changeset in webkit [138570] by
-
- 2 edits in trunk/Source/WebKit2
Windows build fix.
- win/WebKit2Common.vsprops:
- 1:58 PM Changeset in webkit [138569] by
-
- 21 edits1 add in trunk/Source/WebKit2
Add supplementability to the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=105838
Reviewed by Dan Bernstein.
This patch adds a NetworkProcessSupplement, which is almost identical to
WebProcessSupplement, but has a different initialization override. It also
stops WebProcessSupplement from inheriting from MessageReceiver (and makes
everything that is a WebProcessSupplement also a MessageReceiver) as keeping
that would cause classes that need to be both WebProcessSupplements and
NetworkProcessSupplements inherit from MessageReceiver twice.
- GNUmakefile.list.am:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::downloadsAuthenticationManager):
(WebKit::NetworkProcess::initializeNetworkProcess):
- NetworkProcess/NetworkProcess.h:
(WebKit):
(NetworkProcess):
(WebKit::NetworkProcess::supplement):
(WebKit::NetworkProcess::addSupplement):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/NetworkProcessSupplement.h: Added.
(WebKit):
(NetworkProcessSupplement):
(WebKit::NetworkProcessSupplement::~NetworkProcessSupplement):
(WebKit::NetworkProcessSupplement::initialize):
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
- WebProcess/Authentication/AuthenticationManager.h:
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Geolocation/WebGeolocationManager.h:
- WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:
- WebProcess/MediaCache/WebMediaCacheManager.h:
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/ResourceCache/WebResourceCacheManager.h:
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- WebProcess/WebProcessSupplement.h:
- win/WebKit2.vcproj:
- 12:11 PM BuildingGtk edited by
- (diff)
- 11:10 AM Changeset in webkit [138568] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Cookies with an IP domain are not being loaded properly into memory
https://bugs.webkit.org/show_bug.cgi?id=105859
PR 271597
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-29
Reviewed by George Staikos.
The isIP flag isn't persistented in the database. We need to check it
again when we load it into memory.
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getBackingStoreCookies):
- 10:11 AM Changeset in webkit [138567] by
-
- 7 edits1 move in trunk/Source/WebCore
[EFL][WebGL] Refactor GLXImplementation.
https://bugs.webkit.org/show_bug.cgi?id=105825
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-29
Reviewed by Kenneth Rohde Christiansen.
This patch decouples native window management and logic to find surface configuration in GLX implementation.
- platform/graphics/opengl/GLDefs.h:
- platform/graphics/surfaces/glx/GLXConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h.
(WebCore):
(GLXConfigSelector):
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::~GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::reset):
(WebCore::GLXConfigSelector::createConfig):
Helper class to find surface configuration.
- platform/graphics/surfaces/glx/GLXContext.h:
(GLXOffScreenContext):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::configuration):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::GLXPBuffer):
(WebCore::GLXPBuffer::initialize):
(WebCore::GLXPBuffer::configuration):
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXPBuffer):
Inheritance changed from X11OffScreenWindow to GLPlatformSurface.
- platform/graphics/surfaces/glx/X11WindowResources.cpp:
(WebCore):
(WebCore::X11OffScreenWindow::X11OffScreenWindow):
(WebCore::X11OffScreenWindow::reSizeWindow):
(WebCore::X11OffScreenWindow::createOffscreenWindow):
(WebCore::X11OffScreenWindow::destroyWindow):
(WebCore::X11OffScreenWindow::nativeSharedDisplay):
(WebCore::X11OffScreenWindow::setVisualInfo):
(WebCore::X11OffScreenWindow::isXRenderExtensionSupported):
- platform/graphics/surfaces/glx/X11WindowResources.h:
(WebCore::SharedX11Resources::create):
(SharedX11Resources):
(X11OffScreenWindow):
Removed code related to surface configiration.
- 9:02 AM Changeset in webkit [138566] by
-
- 2 edits in trunk/LayoutTests
[GTK] Change bug for some inspector tests
https://bugs.webkit.org/show_bug.cgi?id=105842
Unreviewed gardening.
Bug 43332 was landed. But these tests still fail on GTK port.
And change bug to track the failures.
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-29
- platform/gtk/TestExpectations:
- 8:14 AM Changeset in webkit [138565] by
-
- 3 edits in trunk/Source/WebKit/mac
Web Inspector: Mac WK1 Inspector can't save/load timeline data
https://bugs.webkit.org/show_bug.cgi?id=105547
Reviewed by Pavel Feldman.
- WebCoreSupport/WebInspectorClient.h: Declared new overrides and
member variables necessary for save support.
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):
Implemented these to make saving timeline data work. (It seems to me
the InspectorFrontendClient API could be cleaned up a bit. I had to
look at Chromium source code to determine that I needed to call back
into the InspectorFrontendAPI JS object after saving/appending, and
that I needed to keep a map of passed URLs -> chosen URLs.)
(-[WebInspectorWindowController window:willPositionSheet:usingRect:]):
Tweaked the position of the sheet so that open/save sheets look a
little bette.r
(-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
Implemented to make loading timeline data work.
- 4:41 AM Changeset in webkit [138564] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time.
https://bugs.webkit.org/show_bug.cgi?id=105854
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-29
Reviewed by Vsevolod Vlasov.
Problem: CPU task indexes are already incremented before written to
data structure.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
Use for loop to get correct indexes.
- 3:38 AM Changeset in webkit [138563] by
-
- 2 edits in trunk/Tools
Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
https://bugs.webkit.org/show_bug.cgi?id=105855
Reviewed by Vsevolod Vlasov.
Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
- clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
(ReportMemoryUsageVisitor):
(clang::AddMemberCallVisitor::VisitCallExpr):
(clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
(clang::ReportMemoryUsageVisitor::checkMembersCoverage):
- 2:53 AM Changeset in webkit [138562] by
-
- 2 edits in trunk/Tools
Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
https://bugs.webkit.org/show_bug.cgi?id=105852
Reviewed by Alexander Pavlov.
- clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
(clang):
(AddMemberCallVisitor):
(ReportMemoryUsageVisitor):
(clang::ReportMemoryUsageAction::ParseArgs):
(clang::AddMemberCallVisitor::VisitCallExpr):
(clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
(clang::ReportMemoryUsageVisitor::emitWarning):
(clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
(clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
(clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
- 1:27 AM Changeset in webkit [138561] by
-
- 14 edits in trunk/Source
Web Inspector: Native Memory Instrumentation: instrument not instrumented members.
https://bugs.webkit.org/show_bug.cgi?id=105830
Reviewed by Vsevolod Vlasov.
In some cases we don't want to visit some class members.
As example we decided to skip pointers to interface classes such as GraphicLayerClient.
We could use addWeakPointer for them but it can't be used for nonpointer members.
In the offline discussion we came to a conclusion that we need a new instrumentation
method ignoreMember, which will be used for all the members which we won't like to visit/instrument.
DriveBy: Also I instrumented not yet instrumented members.
Source/WebCore:
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::reportMemoryUsage):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
- platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
- platform/audio/AudioArray.h:
(WebCore::AudioArray::reportMemoryUsage):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
Source/WTF:
- wtf/MemoryInstrumentation.h:
(MemoryClassInfo):
(WTF::MemoryClassInfo::ignoreMember):
- 1:19 AM Changeset in webkit [138560] by
-
- 4 edits in trunk
Source/WebCore: Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters style
https://bugs.webkit.org/show_bug.cgi?id=105829
Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-29
Reviewed by Pavel Feldman.
Refactor DefaultTextEditor.js: improve handler method annotations,
remove "get" prefix from method names, get rid of unnecessary
delegation (e.g. see _handleCut).
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._contextMenu):
(WebInspector.DefaultTextEditor.prototype.selection):
(WebInspector.DefaultTextEditor.prototype.lastSelection):
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorChunkedPanel.prototype.createNewChunk):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype.populateContextMenu):
(WebInspector.TextEditorMainPanel.prototype.splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype.expandChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype.selection):
(WebInspector.TextEditorMainPanel.prototype.lastSelection):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
(WebInspector.TextEditorMainPanel.prototype._handleTextInput):
(WebInspector.TextEditorMainPanel.prototype.handleKeyDown):
(WebInspector.TextEditorMainPanel.prototype._handleCut):
LayoutTests: Web Inspector: refactor DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=105829
Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-29
Reviewed by Pavel Feldman.
Fix test to correlate with refactoring of DefaultTextEditor.
- inspector/editor/text-editor-selection.html:
- 12:02 AM Changeset in webkit [138559] by
-
- 2 edits in trunk/Tools
[webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
https://bugs.webkit.org/show_bug.cgi?id=105835
Reviewed by Dirk Pranke.
The BeautifulSoup module is a third-party import and as such we don't have much control
over its testing. Because of that it should be omitted from code coverage checking.
- Scripts/webkitpy/test/main.py:
(Tester._run_tests):
